9c5d3060e5
* uri: Two tests that demonstrate missing handling of the "force" parameter Add unit and integration tests that demonstrate that the uri module is not handling the "force" parameter. The unit test demonstrates that when "force" is present in the module parameters, it is not being passed through to fetch_url(). The integration test demonstrates that "force" does not disable caching as documented, and calls with a "dest" parameter that points to an existing file can result in a "304 Not Modified" response. * uri: Handle the "force" parameter properly The uri module documents a "force" parameter that can be used to disable caching. The module accepted the parameter but didn't pass it through to the fetch_url() method which implements the logic to handle setting the appropriate headers for disabling caching. This change passes the "force" parameter through as expected, allowing caching to be disabled when requested by the module caller.
44 lines
1.8 KiB
Python
44 lines
1.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright:
|
|
# (c) 2023 Ansible Project
|
|
# License: GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
from units.modules.utils import AnsibleExitJson, AnsibleFailJson, ModuleTestCase, set_module_args
|
|
from ansible.modules import uri
|
|
|
|
|
|
class TestUri(ModuleTestCase):
|
|
|
|
def test_main_no_args(self):
|
|
"""Module must fail if called with no args."""
|
|
with self.assertRaises(AnsibleFailJson):
|
|
set_module_args({})
|
|
uri.main()
|
|
|
|
def test_main_no_force(self):
|
|
"""The "force" parameter to fetch_url() must be absent or false when the module is called without "force"."""
|
|
set_module_args({"url": "http://example.com/"})
|
|
resp = MagicMock()
|
|
resp.headers.get_content_type.return_value = "text/html"
|
|
info = {"url": "http://example.com/", "status": 200}
|
|
with patch.object(uri, "fetch_url", return_value=(resp, info)) as fetch_url:
|
|
with self.assertRaises(AnsibleExitJson):
|
|
uri.main()
|
|
fetch_url.assert_called_once()
|
|
assert not fetch_url.call_args[1].get("force")
|
|
|
|
def test_main_force(self):
|
|
"""The "force" parameter to fetch_url() must be true when the module is called with "force"."""
|
|
set_module_args({"url": "http://example.com/", "force": True})
|
|
resp = MagicMock()
|
|
resp.headers.get_content_type.return_value = "text/html"
|
|
info = {"url": "http://example.com/", "status": 200}
|
|
with patch.object(uri, "fetch_url", return_value=(resp, info)) as fetch_url:
|
|
with self.assertRaises(AnsibleExitJson):
|
|
uri.main()
|
|
fetch_url.assert_called_once()
|
|
assert fetch_url.call_args[1].get("force")
|