habsi/authentik
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

providers/oauth2: fix redirect_uri not being checked correctly if multiple redirect_uris are configured

Browse Source
This commit is contained in:
Jens Langhammer
2020-08-20 16:41:00 +02:00
parent 86597df159
commit 0eb94df1f7
4 changed files with 4 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
passbook/providers/oauth2/views/authorize.py
View File

@ -143,8 +143,8 @@ class OAuthAuthorizationParams:
if is_open_id and not self.redirect_uri:
LOGGER.warning("Missing redirect uri.")
raise RedirectUriError()
if self.redirect_uri not in self.provider.redirect_uris:
LOGGER.warning("Invalid redirect uri", redirect_uri=self.redirect_uri)
if self.redirect_uri not in self.provider.redirect_uris.split():
LOGGER.warning("Invalid redirect uri", redirect_uri=self.redirect_uri, excepted=self.provider.redirect_uris.split())
raise RedirectUriError()
if not is_open_id and (

4
passbook/providers/oauth2/views/token.py
View File

@ -109,8 +109,8 @@ class TokenParams:
LOGGER.warning("Missing authorization code")
raise TokenError("invalid_grant")
if self.redirect_uri not in self.provider.redirect_uris:
LOGGER.warning("Invalid redirect uri", uri=self.redirect_uri)
if self.redirect_uri not in self.provider.redirect_uris.split():
LOGGER.warning("Invalid redirect uri", uri=self.redirect_uri, expected=self.provider.redirect_uris.split())
raise TokenError("invalid_client")
try: