From 40f598f3f12dc163bc866c2b113935244eb869a3 Mon Sep 17 00:00:00 2001 From: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com> Date: Mon, 19 May 2025 19:34:51 +0200 Subject: [PATCH] web: (ESLint) No else return (#14558) web: (ESLint) no-else-return. --- web/package.json | 6 +++--- .../admin-overview/cards/WorkerStatusCard.ts | 7 +++---- .../entitlements/ApplicationEntitlementForm.ts | 10 ++++------ web/src/admin/blueprints/BlueprintForm.ts | 7 +++---- web/src/admin/brands/BrandForm.ts | 7 +++---- web/src/admin/crypto/CertificateKeyPairForm.ts | 7 +++---- web/src/admin/events/RuleForm.ts | 7 +++---- web/src/admin/events/TransportForm.ts | 7 +++---- web/src/admin/flows/StageBindingForm.ts | 16 +++++++--------- web/src/admin/groups/GroupForm.ts | 9 ++++----- web/src/admin/outposts/OutpostForm.ts | 7 +++---- .../outposts/ServiceConnectionDockerForm.ts | 7 +++---- .../outposts/ServiceConnectionKubernetesForm.ts | 7 +++---- web/src/admin/policies/BoundPoliciesList.ts | 6 ++---- web/src/admin/policies/PolicyBindingForm.ts | 10 ++++------ web/src/admin/policies/dummy/DummyPolicyForm.ts | 7 +++---- .../event_matcher/EventMatcherPolicyForm.ts | 7 +++---- .../admin/policies/expiry/ExpiryPolicyForm.ts | 7 +++---- .../policies/expression/ExpressionPolicyForm.ts | 7 +++---- web/src/admin/policies/geoip/GeoIPPolicyForm.ts | 7 +++---- .../policies/password/PasswordPolicyForm.ts | 7 +++---- .../policies/reputation/ReputationPolicyForm.ts | 7 +++---- .../unique_password/UniquePasswordPolicyForm.ts | 7 +++---- .../PropertyMappingNotification.ts | 7 +++---- ...PropertyMappingProviderGoogleWorkspaceForm.ts | 11 +++++------ .../PropertyMappingProviderMicrosoftEntraForm.ts | 11 +++++------ .../PropertyMappingProviderRACForm.ts | 7 +++---- .../PropertyMappingProviderRadiusForm.ts | 7 +++---- .../PropertyMappingProviderSAMLForm.ts | 7 +++---- .../PropertyMappingProviderSCIMForm.ts | 7 +++---- .../PropertyMappingProviderScopeForm.ts | 7 +++---- .../PropertyMappingSourceKerberosForm.ts | 7 +++---- .../PropertyMappingSourceLDAPForm.ts | 7 +++---- .../PropertyMappingSourceOAuthForm.ts | 7 +++---- .../PropertyMappingSourcePlexForm.ts | 7 +++---- .../PropertyMappingSourceSAMLForm.ts | 7 +++---- .../PropertyMappingSourceSCIMForm.ts | 7 +++---- .../GoogleWorkspaceProviderForm.ts | 7 +++---- web/src/admin/providers/ldap/LDAPProviderForm.ts | 7 +++---- .../MicrosoftEntraProviderForm.ts | 7 +++---- .../admin/providers/oauth2/OAuth2ProviderForm.ts | 7 +++---- .../admin/providers/proxy/ProxyProviderForm.ts | 7 +++---- web/src/admin/providers/rac/EndpointForm.ts | 7 +++---- web/src/admin/providers/rac/RACProviderForm.ts | 10 ++++------ .../admin/providers/radius/RadiusProviderForm.ts | 7 +++---- web/src/admin/providers/saml/SAMLProviderForm.ts | 7 +++---- web/src/admin/providers/scim/SCIMProviderForm.ts | 7 +++---- .../admin/providers/ssf/SSFProviderFormPage.ts | 7 +++---- web/src/admin/rbac/InitialPermissionsForm.ts | 7 +++---- web/src/admin/roles/RoleForm.ts | 7 +++---- web/src/admin/sources/scim/SCIMSourceForm.ts | 7 +++---- .../AuthenticatorDuoStageForm.ts | 7 +++---- .../AuthenticatorEmailStageForm.ts | 7 +++---- .../AuthenticatorEndpointGDTCStageForm.ts | 7 +++---- .../AuthenticatorSMSStageForm.ts | 7 +++---- .../AuthenticatorStaticStageForm.ts | 7 +++---- .../AuthenticatorTOTPStageForm.ts | 7 +++---- .../AuthenticatorValidateStageForm.ts | 7 +++---- .../AuthenticatorWebAuthnStageForm.ts | 7 +++---- web/src/admin/stages/captcha/CaptchaStageForm.ts | 7 +++---- web/src/admin/stages/consent/ConsentStageForm.ts | 7 +++---- web/src/admin/stages/deny/DenyStageForm.ts | 7 +++---- web/src/admin/stages/dummy/DummyStageForm.ts | 7 +++---- web/src/admin/stages/email/EmailStageForm.ts | 7 +++---- .../admin/stages/invitation/InvitationForm.ts | 7 +++---- .../stages/invitation/InvitationStageForm.ts | 7 +++---- .../admin/stages/password/PasswordStageForm.ts | 7 +++---- web/src/admin/stages/prompt/PromptForm.ts | 7 +++---- web/src/admin/stages/prompt/PromptStageForm.ts | 7 +++---- .../admin/stages/redirect/RedirectStageForm.ts | 7 +++---- web/src/admin/stages/source/SourceStageForm.ts | 7 +++---- .../stages/user_delete/UserDeleteStageForm.ts | 7 +++---- .../stages/user_login/UserLoginStageForm.ts | 7 +++---- .../stages/user_logout/UserLogoutStageForm.ts | 7 +++---- .../stages/user_write/UserWriteStageForm.ts | 7 +++---- web/src/admin/tokens/TokenForm.ts | 7 +++---- web/src/admin/users/UserForm.ts | 9 ++++----- web/src/elements/TreeView.ts | 3 +-- .../user/user-settings/tokens/UserTokenForm.ts | 9 ++++----- 79 files changed, 248 insertions(+), 331 deletions(-) diff --git a/web/package.json b/web/package.json index 37239efcb9..11869aacaf 100644 --- a/web/package.json +++ b/web/package.json @@ -387,11 +387,11 @@ ], "prettier": "@goauthentik/prettier-config", "overrides": { - "rapidoc": { - "@apitools/openapi-parser@": "0.0.37" - }, "chromedriver": { "axios": "^1.8.4" + }, + "rapidoc": { + "@apitools/openapi-parser@": "0.0.37" } } } diff --git a/web/src/admin/admin-overview/cards/WorkerStatusCard.ts b/web/src/admin/admin-overview/cards/WorkerStatusCard.ts index f4f640382f..ad158bc07e 100644 --- a/web/src/admin/admin-overview/cards/WorkerStatusCard.ts +++ b/web/src/admin/admin-overview/cards/WorkerStatusCard.ts @@ -33,11 +33,10 @@ export class WorkersStatusCard extends AdminStatusCard { icon: "fa fa-times-circle pf-m-danger", message: html`${msg("Worker with incorrect version connected.")}`, }); - } else { - return Promise.resolve({ - icon: "fa fa-check-circle pf-m-success", - }); } + return Promise.resolve({ + icon: "fa fa-check-circle pf-m-success", + }); } renderValue() { diff --git a/web/src/admin/applications/entitlements/ApplicationEntitlementForm.ts b/web/src/admin/applications/entitlements/ApplicationEntitlementForm.ts index 3ee3cad0ee..5db5ab956d 100644 --- a/web/src/admin/applications/entitlements/ApplicationEntitlementForm.ts +++ b/web/src/admin/applications/entitlements/ApplicationEntitlementForm.ts @@ -30,9 +30,8 @@ export class ApplicationEntitlementForm extends ModelForm { instanceUuid: this.instance.pk, blueprintInstanceRequest: data, }); - } else { - return new ManagedApi(DEFAULT_CONFIG).managedBlueprintsCreate({ - blueprintInstanceRequest: data, - }); } + return new ManagedApi(DEFAULT_CONFIG).managedBlueprintsCreate({ + blueprintInstanceRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/brands/BrandForm.ts b/web/src/admin/brands/BrandForm.ts index 1090e9fcbf..fa79fdb53c 100644 --- a/web/src/admin/brands/BrandForm.ts +++ b/web/src/admin/brands/BrandForm.ts @@ -42,11 +42,10 @@ export class BrandForm extends ModelForm { brandUuid: this.instance.brandUuid, brandRequest: data, }); - } else { - return new CoreApi(DEFAULT_CONFIG).coreBrandsCreate({ - brandRequest: data, - }); } + return new CoreApi(DEFAULT_CONFIG).coreBrandsCreate({ + brandRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/crypto/CertificateKeyPairForm.ts b/web/src/admin/crypto/CertificateKeyPairForm.ts index bfa2d4ca48..942c3b8e24 100644 --- a/web/src/admin/crypto/CertificateKeyPairForm.ts +++ b/web/src/admin/crypto/CertificateKeyPairForm.ts @@ -30,11 +30,10 @@ export class CertificateKeyPairForm extends ModelForm { pbmUuid: this.instance.pk || "", notificationRuleRequest: data, }); - } else { - return new EventsApi(DEFAULT_CONFIG).eventsRulesCreate({ - notificationRuleRequest: data, - }); } + return new EventsApi(DEFAULT_CONFIG).eventsRulesCreate({ + notificationRuleRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/events/TransportForm.ts b/web/src/admin/events/TransportForm.ts index 7775ed0642..907902497b 100644 --- a/web/src/admin/events/TransportForm.ts +++ b/web/src/admin/events/TransportForm.ts @@ -46,11 +46,10 @@ export class TransportForm extends ModelForm { uuid: this.instance.pk || "", notificationTransportRequest: data, }); - } else { - return new EventsApi(DEFAULT_CONFIG).eventsTransportsCreate({ - notificationTransportRequest: data, - }); } + return new EventsApi(DEFAULT_CONFIG).eventsTransportsCreate({ + notificationTransportRequest: data, + }); } onModeChange(mode: string | undefined): void { diff --git a/web/src/admin/flows/StageBindingForm.ts b/web/src/admin/flows/StageBindingForm.ts index 4d0709d5f5..956b9ef360 100644 --- a/web/src/admin/flows/StageBindingForm.ts +++ b/web/src/admin/flows/StageBindingForm.ts @@ -39,9 +39,8 @@ export class StageBindingForm extends ModelForm { getSuccessMessage(): string { if (this.instance?.pk) { return msg("Successfully updated binding."); - } else { - return msg("Successfully created binding."); } + return msg("Successfully created binding."); } send(data: FlowStageBinding): Promise { @@ -50,14 +49,13 @@ export class StageBindingForm extends ModelForm { fsbUuid: this.instance.pk, patchedFlowStageBindingRequest: data, }); - } else { - if (this.targetPk) { - data.target = this.targetPk; - } - return new FlowsApi(DEFAULT_CONFIG).flowsBindingsCreate({ - flowStageBindingRequest: data, - }); } + if (this.targetPk) { + data.target = this.targetPk; + } + return new FlowsApi(DEFAULT_CONFIG).flowsBindingsCreate({ + flowStageBindingRequest: data, + }); } async getOrder(): Promise { diff --git a/web/src/admin/groups/GroupForm.ts b/web/src/admin/groups/GroupForm.ts index db8d9e3765..98b39ecb5a 100644 --- a/web/src/admin/groups/GroupForm.ts +++ b/web/src/admin/groups/GroupForm.ts @@ -54,12 +54,11 @@ export class GroupForm extends ModelForm { groupUuid: this.instance.pk, patchedGroupRequest: data, }); - } else { - data.users = []; - return new CoreApi(DEFAULT_CONFIG).coreGroupsCreate({ - groupRequest: data, - }); } + data.users = []; + return new CoreApi(DEFAULT_CONFIG).coreGroupsCreate({ + groupRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/outposts/OutpostForm.ts b/web/src/admin/outposts/OutpostForm.ts index fb1ac2fdf4..be98215d13 100644 --- a/web/src/admin/outposts/OutpostForm.ts +++ b/web/src/admin/outposts/OutpostForm.ts @@ -129,11 +129,10 @@ export class OutpostForm extends ModelForm { uuid: this.instance.pk || "", outpostRequest: data, }); - } else { - return new OutpostsApi(DEFAULT_CONFIG).outpostsInstancesCreate({ - outpostRequest: data, - }); } + return new OutpostsApi(DEFAULT_CONFIG).outpostsInstancesCreate({ + outpostRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/outposts/ServiceConnectionDockerForm.ts b/web/src/admin/outposts/ServiceConnectionDockerForm.ts index 7866696443..6482df7462 100644 --- a/web/src/admin/outposts/ServiceConnectionDockerForm.ts +++ b/web/src/admin/outposts/ServiceConnectionDockerForm.ts @@ -31,11 +31,10 @@ export class ServiceConnectionDockerForm extends ModelForm { return msg(str`Group ${item.groupObj?.name}`); } else if (item.user) { return msg(str`User ${item.userObj?.name}`); - } else { - return msg("-"); } + return msg("-"); } getPolicyUserGroupRow(item: PolicyBinding): TemplateResult { @@ -123,9 +122,8 @@ export class BoundPoliciesList extends Table { ${msg("Edit User")} `; - } else { - return html``; } + return html``; } renderToolbarSelected(): TemplateResult { diff --git a/web/src/admin/policies/PolicyBindingForm.ts b/web/src/admin/policies/PolicyBindingForm.ts index ea88ca1c9b..8007157dc3 100644 --- a/web/src/admin/policies/PolicyBindingForm.ts +++ b/web/src/admin/policies/PolicyBindingForm.ts @@ -72,9 +72,8 @@ export class PolicyBindingForm extends ModelForm { getSuccessMessage(): string { if (this.instance?.pk) { return msg("Successfully updated binding."); - } else { - return msg("Successfully created binding."); } + return msg("Successfully created binding."); } static get styles(): CSSResult[] { @@ -111,11 +110,10 @@ export class PolicyBindingForm extends ModelForm { policyBindingUuid: this.instance.pk, policyBindingRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesBindingsCreate({ - policyBindingRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesBindingsCreate({ + policyBindingRequest: data, + }); } async getOrder(): Promise { diff --git a/web/src/admin/policies/dummy/DummyPolicyForm.ts b/web/src/admin/policies/dummy/DummyPolicyForm.ts index 4dcc523f39..4d15498598 100644 --- a/web/src/admin/policies/dummy/DummyPolicyForm.ts +++ b/web/src/admin/policies/dummy/DummyPolicyForm.ts @@ -24,11 +24,10 @@ export class DummyPolicyForm extends BasePolicyForm { policyUuid: this.instance.pk || "", dummyPolicyRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesDummyCreate({ - dummyPolicyRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesDummyCreate({ + dummyPolicyRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/policies/event_matcher/EventMatcherPolicyForm.ts b/web/src/admin/policies/event_matcher/EventMatcherPolicyForm.ts index e079502d4d..2f4234ba26 100644 --- a/web/src/admin/policies/event_matcher/EventMatcherPolicyForm.ts +++ b/web/src/admin/policies/event_matcher/EventMatcherPolicyForm.ts @@ -36,11 +36,10 @@ export class EventMatcherPolicyForm extends BasePolicyForm { policyUuid: this.instance.pk || "", eventMatcherPolicyRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesEventMatcherCreate({ - eventMatcherPolicyRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesEventMatcherCreate({ + eventMatcherPolicyRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/policies/expiry/ExpiryPolicyForm.ts b/web/src/admin/policies/expiry/ExpiryPolicyForm.ts index 9d92858b1c..62aa294b59 100644 --- a/web/src/admin/policies/expiry/ExpiryPolicyForm.ts +++ b/web/src/admin/policies/expiry/ExpiryPolicyForm.ts @@ -24,11 +24,10 @@ export class PasswordExpiryPolicyForm extends BasePolicyForm { policyUuid: this.instance.pk || "", expressionPolicyRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesExpressionCreate({ - expressionPolicyRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesExpressionCreate({ + expressionPolicyRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/policies/geoip/GeoIPPolicyForm.ts b/web/src/admin/policies/geoip/GeoIPPolicyForm.ts index fa55a5ec32..d11f374d8f 100644 --- a/web/src/admin/policies/geoip/GeoIPPolicyForm.ts +++ b/web/src/admin/policies/geoip/GeoIPPolicyForm.ts @@ -38,11 +38,10 @@ export class GeoIPPolicyForm extends BasePolicyForm { policyUuid: this.instance.pk || "", geoIPPolicyRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesGeoipCreate({ - geoIPPolicyRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesGeoipCreate({ + geoIPPolicyRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/policies/password/PasswordPolicyForm.ts b/web/src/admin/policies/password/PasswordPolicyForm.ts index 9999577e7a..fe8f63ec7b 100644 --- a/web/src/admin/policies/password/PasswordPolicyForm.ts +++ b/web/src/admin/policies/password/PasswordPolicyForm.ts @@ -37,11 +37,10 @@ export class PasswordPolicyForm extends BasePolicyForm { policyUuid: this.instance.pk || "", passwordPolicyRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesPasswordCreate({ - passwordPolicyRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesPasswordCreate({ + passwordPolicyRequest: data, + }); } renderStaticRules(): TemplateResult { diff --git a/web/src/admin/policies/reputation/ReputationPolicyForm.ts b/web/src/admin/policies/reputation/ReputationPolicyForm.ts index 1c6b45825e..7a6f3d8419 100644 --- a/web/src/admin/policies/reputation/ReputationPolicyForm.ts +++ b/web/src/admin/policies/reputation/ReputationPolicyForm.ts @@ -24,11 +24,10 @@ export class ReputationPolicyForm extends BasePolicyForm { policyUuid: this.instance.pk || "", reputationPolicyRequest: data, }); - } else { - return new PoliciesApi(DEFAULT_CONFIG).policiesReputationCreate({ - reputationPolicyRequest: data, - }); } + return new PoliciesApi(DEFAULT_CONFIG).policiesReputationCreate({ + reputationPolicyRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/policies/unique_password/UniquePasswordPolicyForm.ts b/web/src/admin/policies/unique_password/UniquePasswordPolicyForm.ts index 1455080063..0d33c39941 100644 --- a/web/src/admin/policies/unique_password/UniquePasswordPolicyForm.ts +++ b/web/src/admin/policies/unique_password/UniquePasswordPolicyForm.ts @@ -24,11 +24,10 @@ export class UniquePasswordPolicyForm extends BasePolicyForm { id: this.instance.pk, oAuth2ProviderRequest: data, }); - } else { - return new ProvidersApi(DEFAULT_CONFIG).providersOauth2Create({ - oAuth2ProviderRequest: data, - }); } + return new ProvidersApi(DEFAULT_CONFIG).providersOauth2Create({ + oAuth2ProviderRequest: data, + }); } renderForm() { diff --git a/web/src/admin/providers/proxy/ProxyProviderForm.ts b/web/src/admin/providers/proxy/ProxyProviderForm.ts index 31a2c1105b..8e3c527719 100644 --- a/web/src/admin/providers/proxy/ProxyProviderForm.ts +++ b/web/src/admin/providers/proxy/ProxyProviderForm.ts @@ -45,11 +45,10 @@ export class ProxyProviderFormPage extends BaseProviderForm { id: this.instance.pk, proxyProviderRequest: data, }); - } else { - return new ProvidersApi(DEFAULT_CONFIG).providersProxyCreate({ - proxyProviderRequest: data, - }); } + return new ProvidersApi(DEFAULT_CONFIG).providersProxyCreate({ + proxyProviderRequest: data, + }); } renderForm() { diff --git a/web/src/admin/providers/rac/EndpointForm.ts b/web/src/admin/providers/rac/EndpointForm.ts index d303b2371e..d447373a9a 100644 --- a/web/src/admin/providers/rac/EndpointForm.ts +++ b/web/src/admin/providers/rac/EndpointForm.ts @@ -45,11 +45,10 @@ export class EndpointForm extends ModelForm { pbmUuid: this.instance.pk || "", patchedEndpointRequest: data, }); - } else { - return new RacApi(DEFAULT_CONFIG).racEndpointsCreate({ - endpointRequest: data, - }); } + return new RacApi(DEFAULT_CONFIG).racEndpointsCreate({ + endpointRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/providers/rac/RACProviderForm.ts b/web/src/admin/providers/rac/RACProviderForm.ts index c88fb2560f..3e451fcdcc 100644 --- a/web/src/admin/providers/rac/RACProviderForm.ts +++ b/web/src/admin/providers/rac/RACProviderForm.ts @@ -31,9 +31,8 @@ export class RACProviderFormPage extends ModelForm { getSuccessMessage(): string { if (this.instance) { return msg("Successfully updated provider."); - } else { - return msg("Successfully created provider."); } + return msg("Successfully created provider."); } async send(data: RACProvider): Promise { @@ -42,11 +41,10 @@ export class RACProviderFormPage extends ModelForm { id: this.instance.pk, rACProviderRequest: data, }); - } else { - return new ProvidersApi(DEFAULT_CONFIG).providersRacCreate({ - rACProviderRequest: data, - }); } + return new ProvidersApi(DEFAULT_CONFIG).providersRacCreate({ + rACProviderRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/providers/radius/RadiusProviderForm.ts b/web/src/admin/providers/radius/RadiusProviderForm.ts index e1832f7fc7..69fc12cdcc 100644 --- a/web/src/admin/providers/radius/RadiusProviderForm.ts +++ b/web/src/admin/providers/radius/RadiusProviderForm.ts @@ -22,11 +22,10 @@ export class RadiusProviderFormPage extends WithBrandConfig(BaseProviderForm { id: this.instance.pk, sAMLProviderRequest: data, }); - } else { - return new ProvidersApi(DEFAULT_CONFIG).providersSamlCreate({ - sAMLProviderRequest: data, - }); } + return new ProvidersApi(DEFAULT_CONFIG).providersSamlCreate({ + sAMLProviderRequest: data, + }); } renderForm() { diff --git a/web/src/admin/providers/scim/SCIMProviderForm.ts b/web/src/admin/providers/scim/SCIMProviderForm.ts index bfdcd3736d..4f88bee8d5 100644 --- a/web/src/admin/providers/scim/SCIMProviderForm.ts +++ b/web/src/admin/providers/scim/SCIMProviderForm.ts @@ -21,11 +21,10 @@ export class SCIMProviderFormPage extends BaseProviderForm { id: this.instance.pk, sCIMProviderRequest: data, }); - } else { - return new ProvidersApi(DEFAULT_CONFIG).providersScimCreate({ - sCIMProviderRequest: data, - }); } + return new ProvidersApi(DEFAULT_CONFIG).providersScimCreate({ + sCIMProviderRequest: data, + }); } renderForm() { diff --git a/web/src/admin/providers/ssf/SSFProviderFormPage.ts b/web/src/admin/providers/ssf/SSFProviderFormPage.ts index 9454732e72..b5fc6c0e07 100644 --- a/web/src/admin/providers/ssf/SSFProviderFormPage.ts +++ b/web/src/admin/providers/ssf/SSFProviderFormPage.ts @@ -42,11 +42,10 @@ export class SSFProviderFormPage extends BaseProviderForm { id: this.instance.pk, sSFProviderRequest: data, }); - } else { - return new ProvidersApi(DEFAULT_CONFIG).providersSsfCreate({ - sSFProviderRequest: data, - }); } + return new ProvidersApi(DEFAULT_CONFIG).providersSsfCreate({ + sSFProviderRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/rbac/InitialPermissionsForm.ts b/web/src/admin/rbac/InitialPermissionsForm.ts index 4cf02ce7de..6f8bdd096f 100644 --- a/web/src/admin/rbac/InitialPermissionsForm.ts +++ b/web/src/admin/rbac/InitialPermissionsForm.ts @@ -46,11 +46,10 @@ export class InitialPermissionsForm extends ModelForm { uuid: this.instance.pk, patchedRoleRequest: data, }); - } else { - return new RbacApi(DEFAULT_CONFIG).rbacRolesCreate({ - roleRequest: data, - }); } + return new RbacApi(DEFAULT_CONFIG).rbacRolesCreate({ + roleRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/sources/scim/SCIMSourceForm.ts b/web/src/admin/sources/scim/SCIMSourceForm.ts index 2f9daa836a..11cc3b0450 100644 --- a/web/src/admin/sources/scim/SCIMSourceForm.ts +++ b/web/src/admin/sources/scim/SCIMSourceForm.ts @@ -32,11 +32,10 @@ export class SCIMSourceForm extends BaseSourceForm { slug: this.instance.slug, patchedSCIMSourceRequest: data, }); - } else { - return new SourcesApi(DEFAULT_CONFIG).sourcesScimCreate({ - sCIMSourceRequest: data as unknown as SCIMSourceRequest, - }); } + return new SourcesApi(DEFAULT_CONFIG).sourcesScimCreate({ + sCIMSourceRequest: data as unknown as SCIMSourceRequest, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/authenticator_duo/AuthenticatorDuoStageForm.ts b/web/src/admin/stages/authenticator_duo/AuthenticatorDuoStageForm.ts index 4417c1fbbe..2820b44831 100644 --- a/web/src/admin/stages/authenticator_duo/AuthenticatorDuoStageForm.ts +++ b/web/src/admin/stages/authenticator_duo/AuthenticatorDuoStageForm.ts @@ -33,11 +33,10 @@ export class AuthenticatorDuoStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", patchedCaptchaStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesCaptchaCreate({ - captchaStageRequest: data as unknown as CaptchaStageRequest, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesCaptchaCreate({ + captchaStageRequest: data as unknown as CaptchaStageRequest, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/consent/ConsentStageForm.ts b/web/src/admin/stages/consent/ConsentStageForm.ts index 9c45582baa..6d985e0122 100644 --- a/web/src/admin/stages/consent/ConsentStageForm.ts +++ b/web/src/admin/stages/consent/ConsentStageForm.ts @@ -33,11 +33,10 @@ export class ConsentStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", consentStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesConsentCreate({ - consentStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesConsentCreate({ + consentStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/deny/DenyStageForm.ts b/web/src/admin/stages/deny/DenyStageForm.ts index 1858588df4..ed03e2c424 100644 --- a/web/src/admin/stages/deny/DenyStageForm.ts +++ b/web/src/admin/stages/deny/DenyStageForm.ts @@ -23,11 +23,10 @@ export class DenyStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", denyStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesDenyCreate({ - denyStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesDenyCreate({ + denyStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/dummy/DummyStageForm.ts b/web/src/admin/stages/dummy/DummyStageForm.ts index 17d4125c1a..11a8a6cf7f 100644 --- a/web/src/admin/stages/dummy/DummyStageForm.ts +++ b/web/src/admin/stages/dummy/DummyStageForm.ts @@ -23,11 +23,10 @@ export class DummyStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", dummyStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesDummyCreate({ - dummyStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesDummyCreate({ + dummyStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/email/EmailStageForm.ts b/web/src/admin/stages/email/EmailStageForm.ts index b26d25af2c..7292bd6d39 100644 --- a/web/src/admin/stages/email/EmailStageForm.ts +++ b/web/src/admin/stages/email/EmailStageForm.ts @@ -36,11 +36,10 @@ export class EmailStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", patchedEmailStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesEmailCreate({ - emailStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesEmailCreate({ + emailStageRequest: data, + }); } renderConnectionSettings(): TemplateResult { diff --git a/web/src/admin/stages/invitation/InvitationForm.ts b/web/src/admin/stages/invitation/InvitationForm.ts index 300aebe1d7..28637cd153 100644 --- a/web/src/admin/stages/invitation/InvitationForm.ts +++ b/web/src/admin/stages/invitation/InvitationForm.ts @@ -34,11 +34,10 @@ export class InvitationForm extends ModelForm { inviteUuid: this.instance.pk || "", invitationRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesInvitationInvitationsCreate({ - invitationRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesInvitationInvitationsCreate({ + invitationRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/invitation/InvitationStageForm.ts b/web/src/admin/stages/invitation/InvitationStageForm.ts index b1111bc6a0..546b31ee11 100644 --- a/web/src/admin/stages/invitation/InvitationStageForm.ts +++ b/web/src/admin/stages/invitation/InvitationStageForm.ts @@ -23,11 +23,10 @@ export class InvitationStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", invitationStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesInvitationStagesCreate({ - invitationStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesInvitationStagesCreate({ + invitationStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/password/PasswordStageForm.ts b/web/src/admin/stages/password/PasswordStageForm.ts index b23513811e..356fcf745a 100644 --- a/web/src/admin/stages/password/PasswordStageForm.ts +++ b/web/src/admin/stages/password/PasswordStageForm.ts @@ -34,11 +34,10 @@ export class PasswordStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", passwordStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesPasswordCreate({ - passwordStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesPasswordCreate({ + passwordStageRequest: data, + }); } isBackendSelected(field: BackendsEnum): boolean { diff --git a/web/src/admin/stages/prompt/PromptForm.ts b/web/src/admin/stages/prompt/PromptForm.ts index 762c3cf09a..dc72f16b8e 100644 --- a/web/src/admin/stages/prompt/PromptForm.ts +++ b/web/src/admin/stages/prompt/PromptForm.ts @@ -54,11 +54,10 @@ export class PromptForm extends ModelForm { promptUuid: this.instance.pk || "", promptRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesPromptPromptsCreate({ - promptRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesPromptPromptsCreate({ + promptRequest: data, + }); } async loadInstance(pk: string): Promise { diff --git a/web/src/admin/stages/prompt/PromptStageForm.ts b/web/src/admin/stages/prompt/PromptStageForm.ts index 9dfc37b5f9..b3d63196ae 100644 --- a/web/src/admin/stages/prompt/PromptStageForm.ts +++ b/web/src/admin/stages/prompt/PromptStageForm.ts @@ -35,11 +35,10 @@ export class PromptStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", promptStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesPromptStagesCreate({ - promptStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesPromptStagesCreate({ + promptStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/redirect/RedirectStageForm.ts b/web/src/admin/stages/redirect/RedirectStageForm.ts index 9659870e1e..e485585177 100644 --- a/web/src/admin/stages/redirect/RedirectStageForm.ts +++ b/web/src/admin/stages/redirect/RedirectStageForm.ts @@ -38,11 +38,10 @@ export class RedirectStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", redirectStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesRedirectCreate({ - redirectStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesRedirectCreate({ + redirectStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/source/SourceStageForm.ts b/web/src/admin/stages/source/SourceStageForm.ts index 9a99d11c0f..4d31087faa 100644 --- a/web/src/admin/stages/source/SourceStageForm.ts +++ b/web/src/admin/stages/source/SourceStageForm.ts @@ -31,11 +31,10 @@ export class SourceStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", sourceStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesSourceCreate({ - sourceStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesSourceCreate({ + sourceStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/user_delete/UserDeleteStageForm.ts b/web/src/admin/stages/user_delete/UserDeleteStageForm.ts index ce6d940960..14e4532511 100644 --- a/web/src/admin/stages/user_delete/UserDeleteStageForm.ts +++ b/web/src/admin/stages/user_delete/UserDeleteStageForm.ts @@ -23,11 +23,10 @@ export class UserDeleteStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", userDeleteStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesUserDeleteCreate({ - userDeleteStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesUserDeleteCreate({ + userDeleteStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/user_login/UserLoginStageForm.ts b/web/src/admin/stages/user_login/UserLoginStageForm.ts index ec0ddd4028..f30122a2a5 100644 --- a/web/src/admin/stages/user_login/UserLoginStageForm.ts +++ b/web/src/admin/stages/user_login/UserLoginStageForm.ts @@ -25,11 +25,10 @@ export class UserLoginStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", userLoginStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesUserLoginCreate({ - userLoginStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesUserLoginCreate({ + userLoginStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/user_logout/UserLogoutStageForm.ts b/web/src/admin/stages/user_logout/UserLogoutStageForm.ts index 139f2fffb7..cb3d349894 100644 --- a/web/src/admin/stages/user_logout/UserLogoutStageForm.ts +++ b/web/src/admin/stages/user_logout/UserLogoutStageForm.ts @@ -23,11 +23,10 @@ export class UserLogoutStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", userLogoutStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesUserLogoutCreate({ - userLogoutStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesUserLogoutCreate({ + userLogoutStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/stages/user_write/UserWriteStageForm.ts b/web/src/admin/stages/user_write/UserWriteStageForm.ts index 9d6c6346f4..00a2afe471 100644 --- a/web/src/admin/stages/user_write/UserWriteStageForm.ts +++ b/web/src/admin/stages/user_write/UserWriteStageForm.ts @@ -34,11 +34,10 @@ export class UserWriteStageForm extends BaseStageForm { stageUuid: this.instance.pk || "", userWriteStageRequest: data, }); - } else { - return new StagesApi(DEFAULT_CONFIG).stagesUserWriteCreate({ - userWriteStageRequest: data, - }); } + return new StagesApi(DEFAULT_CONFIG).stagesUserWriteCreate({ + userWriteStageRequest: data, + }); } renderForm(): TemplateResult { diff --git a/web/src/admin/tokens/TokenForm.ts b/web/src/admin/tokens/TokenForm.ts index 2d2a08d7ec..696061e18f 100644 --- a/web/src/admin/tokens/TokenForm.ts +++ b/web/src/admin/tokens/TokenForm.ts @@ -37,11 +37,10 @@ export class TokenForm extends ModelForm { identifier: this.instance.identifier, tokenRequest: data, }); - } else { - return new CoreApi(DEFAULT_CONFIG).coreTokensCreate({ - tokenRequest: data, - }); } + return new CoreApi(DEFAULT_CONFIG).coreTokensCreate({ + tokenRequest: data, + }); } renderExpiry(): TemplateResult { diff --git a/web/src/admin/users/UserForm.ts b/web/src/admin/users/UserForm.ts index cdc2cf3b4e..d47c313942 100644 --- a/web/src/admin/users/UserForm.ts +++ b/web/src/admin/users/UserForm.ts @@ -46,12 +46,11 @@ export class UserForm extends ModelForm { getSuccessMessage(): string { if (this.instance) { return msg("Successfully updated user."); - } else { - if (this.group) { - return msg(str`Successfully created user and added to group ${this.group.name}`); - } - return msg("Successfully created user."); } + if (this.group) { + return msg(str`Successfully created user and added to group ${this.group.name}`); + } + return msg("Successfully created user."); } async send(data: User): Promise { diff --git a/web/src/elements/TreeView.ts b/web/src/elements/TreeView.ts index 60c0645e88..203a6abc33 100644 --- a/web/src/elements/TreeView.ts +++ b/web/src/elements/TreeView.ts @@ -173,9 +173,8 @@ export class TreeView extends AKElement { child.parent = item; } return item; - } else { - return this.createNode(path, parentItem.childItems[idx], level + 1); } + return this.createNode(path, parentItem.childItems[idx], level + 1); } parse(data: string[]): TreeViewItem { diff --git a/web/src/user/user-settings/tokens/UserTokenForm.ts b/web/src/user/user-settings/tokens/UserTokenForm.ts index b200199c89..6fcb48d4aa 100644 --- a/web/src/user/user-settings/tokens/UserTokenForm.ts +++ b/web/src/user/user-settings/tokens/UserTokenForm.ts @@ -34,12 +34,11 @@ export class UserTokenForm extends ModelForm { identifier: this.instance.identifier, tokenRequest: data, }); - } else { - data.intent = this.intent; - return new CoreApi(DEFAULT_CONFIG).coreTokensCreate({ - tokenRequest: data, - }); } + data.intent = this.intent; + return new CoreApi(DEFAULT_CONFIG).coreTokensCreate({ + tokenRequest: data, + }); } renderForm(): TemplateResult {