From 4d8ee983ef7ec1a9b0a58d3bf82978797bdcfa02 Mon Sep 17 00:00:00 2001
From: Jens L <jens@goauthentik.io>
Date: Tue, 2 Apr 2024 12:31:59 +0200
Subject: [PATCH] web: fix console log leftover (#9096)

* web: disallow console.log

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix easy fixes

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
---
 web/.eslintrc.json                            |  3 ++-
 .../stories/ak-dual-select-search.stories.ts  |  2 +-
 .../stories/ak-pagination.stories.ts          |  2 +-
 .../rbac/RoleObjectPermissionTable.ts         | 23 ++++++++-----------
 4 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/web/.eslintrc.json b/web/.eslintrc.json
index 86137ef245..cf7447670c 100644
--- a/web/.eslintrc.json
+++ b/web/.eslintrc.json
@@ -32,6 +32,7 @@
                 "varsIgnorePattern": "^_",
                 "caughtErrorsIgnorePattern": "^_"
             }
-        ]
+        ],
+        "no-console": ["error", { "allow": ["debug", "warn", "error"] }]
     }
 }
diff --git a/web/src/elements/ak-dual-select/stories/ak-dual-select-search.stories.ts b/web/src/elements/ak-dual-select/stories/ak-dual-select-search.stories.ts
index 43f311c208..49bf52fc54 100644
--- a/web/src/elements/ak-dual-select/stories/ak-dual-select-search.stories.ts
+++ b/web/src/elements/ak-dual-select/stories/ak-dual-select-search.stories.ts
@@ -48,7 +48,7 @@ const displayMessage = (result: any) => {
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const displayMessage2 = (result: any) => {
-    console.log("Huh.");
+    console.debug("Huh.");
     const doc = new DOMParser().parseFromString(`<p><i>Behavior</i>: ${result}</p>`, "text/xml");
     const target = document.querySelector("#action-button-message-pad-2");
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
diff --git a/web/src/elements/ak-dual-select/stories/ak-pagination.stories.ts b/web/src/elements/ak-dual-select/stories/ak-pagination.stories.ts
index 739855620f..0ecbe68af9 100644
--- a/web/src/elements/ak-dual-select/stories/ak-pagination.stories.ts
+++ b/web/src/elements/ak-dual-select/stories/ak-pagination.stories.ts
@@ -44,7 +44,7 @@ const container = (testItem: TemplateResult) =>
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const handleMoveChanged = (result: any) => {
-    console.log(result);
+    console.debug(result);
     const target = document.querySelector("#action-button-message-pad");
     target!.append(
         new DOMParser().parseFromString(
diff --git a/web/src/elements/rbac/RoleObjectPermissionTable.ts b/web/src/elements/rbac/RoleObjectPermissionTable.ts
index 7e64edf011..18da770242 100644
--- a/web/src/elements/rbac/RoleObjectPermissionTable.ts
+++ b/web/src/elements/rbac/RoleObjectPermissionTable.ts
@@ -110,20 +110,15 @@ export class RoleAssignedObjectPermissionTable extends Table<RoleAssignedObjectP
         this.modelPermissions?.results.forEach((perm) => {
             const granted =
                 item.permissions.filter((uperm) => uperm.codename === perm.codename).length > 0;
-            baseRow.push(html`
-                <ak-action-button
-                    .apiRequest=${async () => {
-                        console.log(granted);
-                    }}
-                    class="pf-m-link"
-                >
-                    ${granted
-                        ? html`<pf-tooltip position="top" content=${msg("Directly assigned")}
-                              >✓</pf-tooltip
-                          >`
-                        : html`X`}
-                </ak-action-button>
-            `);
+            baseRow.push(
+                html`${granted
+                    ? html`<pf-tooltip
+                          position="top"
+                          content=${msg("Directly assigned")}
+                          >✓</pf-tooltip
+                      >`
+                    : html`X`} `,
+            );
         });
         return baseRow;
     }