security: fix CVE 2024 52307 (#12115)

* security: fix CVE-2024-52307

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* add docs

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix tests

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
This commit is contained in:
Jens L.
2024-11-21 14:24:28 +01:00
committed by GitHub
parent e9c29e1644
commit 5ea4580884
7 changed files with 87 additions and 20 deletions

View File

@ -78,7 +78,7 @@ Short summary of the issue
### Patches
authentik x, y and z fix this issue, for other versions the workaround can be used.
authentik x, y and z fix this issue, for other versions the workaround below can be used.
### Impact
@ -96,7 +96,7 @@ Describe a workaround if possible
If you have any questions or comments about this advisory:
- Email us at [security@goauthentik.io](mailto:security@goauthentik.io)
- Email us at [security@goauthentik.io](mailto:security@goauthentik.io).
```
</details>

View File

@ -0,0 +1,36 @@
# CVE-2024-52307
_Reported by [@mgerstner](https://github.com/mgerstner)_
## Timing attack due to a lack of constant time comparison for metrics view
### Summary
Due to the usage of a non-constant time comparison for the `/-/metrics/` endpoint it was possible to brute-force the `SECRET_KEY`, which is used to authenticate the endpoint. The `/-/metrics/` endpoint returns Prometheus metrics and is not intended to be accessed directly, as the Go proxy running in the authentik server container fetches data from this endpoint and serves it on a separate port (9300 by default), which can be scraped by Prometheus without being exposed publicly.
### Patches
authentik 2024.8.5 and 2024.10.3 fix this issue, for other versions the workaround below can be used.
### Impact
With enough attempts the `SECRET_KEY` of the authentik installation can be brute-forced, which can be used to sign new or modify existing cookies.
### Workarounds
Since the `/-/metrics/` endpoint is not intended to be accessed publicly, requests to the endpoint can be blocked by the reverse proxy/load balancer used in conjunction with authentik.
For example for nginx:
```
location /-/metrics/ {
deny all;
return 404;
}
```
### For more information
If you have any questions or comments about this advisory:
- Email us at [security@goauthentik.io](mailto:security@goauthentik.io).