From 873dd956412491d0d99d5368453784bf925926f5 Mon Sep 17 00:00:00 2001 From: Jens Langhammer Date: Thu, 29 May 2025 21:00:28 +0200 Subject: [PATCH] re-add implicit and fix? Signed-off-by: Jens Langhammer --- authentik/providers/oauth2/views/authorize.py | 4 ++-- tests/openid_conformance/generator.py | 1 + tests/openid_conformance/test_conformance.py | 4 ++++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/authentik/providers/oauth2/views/authorize.py b/authentik/providers/oauth2/views/authorize.py index c6c1aecda7..253f4009b9 100644 --- a/authentik/providers/oauth2/views/authorize.py +++ b/authentik/providers/oauth2/views/authorize.py @@ -150,12 +150,12 @@ class OAuthAuthorizationParams: self.check_redirect_uri() self.check_grant() self.check_scope(github_compat) - self.check_nonce() - self.check_code_challenge() if self.request: raise AuthorizeError( self.redirect_uri, "request_not_supported", self.grant_type, self.state ) + self.check_nonce() + self.check_code_challenge() def check_grant(self): """Check grant""" diff --git a/tests/openid_conformance/generator.py b/tests/openid_conformance/generator.py index 207234128a..d5a9f6795c 100644 --- a/tests/openid_conformance/generator.py +++ b/tests/openid_conformance/generator.py @@ -102,6 +102,7 @@ def generate(plan_name: str): self.run_test(module_id) self.conformance.wait_for_state(module_id, ["FINISHED"], timeout=self.wait_timeout) sleep(2) + return tester_func class test_cls(BaseOpenIDConformance): diff --git a/tests/openid_conformance/test_conformance.py b/tests/openid_conformance/test_conformance.py index 9e29e5ac7f..fc92a4a255 100644 --- a/tests/openid_conformance/test_conformance.py +++ b/tests/openid_conformance/test_conformance.py @@ -3,3 +3,7 @@ from tests.openid_conformance.generator import generate class TestConformanceOIDCCBasicCertification(generate("oidcc-basic-certification-test-plan")): pass + + +class TestConformanceOIDCCImplicitCertification(generate("oidcc-implicit-certification-test-plan")): + pass