habsi/authentik
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

providers/oidc: remove static lookup for OIDCProvider, get related object for app_gw

Browse Source
This commit is contained in:
Jens Langhammer
2020-08-01 20:53:33 +02:00
parent 7897ca4744
commit 8b3839343c
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
passbook/providers/oidc/views.py
View File

@ -1,10 +1,10 @@
"""passbook OIDC Views""" """passbook OIDC Views"""
from django.http import HttpRequest, HttpResponse, JsonResponse from django.http import Http404, HttpRequest, HttpResponse, JsonResponse
from django.shortcuts import get_object_or_404, reverse from django.shortcuts import get_object_or_404, reverse
from django.views import View from django.views import View
from oidc_provider.lib.endpoints.authorize import AuthorizeEndpoint from oidc_provider.lib.endpoints.authorize import AuthorizeEndpoint
from oidc_provider.lib.utils.common import get_issuer, get_site_url from oidc_provider.lib.utils.common import get_issuer, get_site_url
from oidc_provider.models import ResponseType from oidc_provider.models import Client, ResponseType
from oidc_provider.views import AuthorizeView from oidc_provider.views import AuthorizeView
from structlog import get_logger from structlog import get_logger
@ -20,7 +20,7 @@ from passbook.flows.stage import StageView
from passbook.flows.views import SESSION_KEY_PLAN from passbook.flows.views import SESSION_KEY_PLAN
from passbook.lib.utils.urls import redirect_with_qs from passbook.lib.utils.urls import redirect_with_qs
from passbook.policies.mixins import PolicyAccessMixin from passbook.policies.mixins import PolicyAccessMixin
from passbook.providers.oidc.models import OpenIDProvider from passbook.providers.oidc.auth import client_related_provider
from passbook.stages.consent.stage import PLAN_CONTEXT_CONSENT_TEMPLATE from passbook.stages.consent.stage import PLAN_CONTEXT_CONSENT_TEMPLATE
LOGGER = get_logger() LOGGER = get_logger()
@ -36,7 +36,11 @@ class AuthorizationFlowInitView(PolicyAccessMixin, View):
def get(self, request: HttpRequest, *args, **kwargs) -> HttpResponse: def get(self, request: HttpRequest, *args, **kwargs) -> HttpResponse:
"""Check access to application, start FlowPLanner, return to flow executor shell""" """Check access to application, start FlowPLanner, return to flow executor shell"""
client_id = request.GET.get("client_id") client_id = request.GET.get("client_id")
provider = get_object_or_404(OpenIDProvider, oidc_client__client_id=client_id) client: Client = get_object_or_404(Client, client_id=client_id)
provider = client_related_provider(client)
if not provider:
LOGGER.debug(f"Cannot find related provider to client '{client}")
raise Http404
try: try:
application = self.provider_to_application(provider) application = self.provider_to_application(provider)
except Application.DoesNotExist: except Application.DoesNotExist: