habsi/authentik
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

web: elements: Table: Fix table selection clearing behavior (#13959)

Browse Source 
web: elements: Table: Fix table selection clearing and modal closing behavior

Closes https://github.com/goauthentik/authentik/issues/13831
This commit is contained in:
Dominic R
2025-04-10 11:03:02 -04:00
committed by GitHub
parent e5e53f034e
commit 8d0b362c9c
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/elements/forms/DeleteBulkForm.ts
View File

@ -167,13 +167,13 @@ export class DeleteBulkForm<T> extends ModalButton {
}),
);
this.onSuccess();
this.open = false;
this.dispatchEvent(
new CustomEvent(EVENT_REFRESH, {
bubbles: true,
composed: true,
}),
);
this.open = false;
} catch (e) {
this.onError(e as Error);
throw e;

10
web/src/elements/table/Table.ts
View File

@ -207,9 +207,6 @@ export abstract class Table<T> extends AKElement implements TableLike {
super();
this.addEventListener(EVENT_REFRESH, async () => {
await this.fetch();
if (this.clearOnRefresh) {
this.selectedElements = [];
}
});
if (this.searchEnabled()) {
this.search = getURLParam("search", "");
@ -272,6 +269,11 @@ export abstract class Table<T> extends AKElement implements TableLike {
});
this.expandedElements = newExpanded;
// Clear selections after fetch if clearOnRefresh is true
if (this.clearOnRefresh) {
this.selectedElements = [];
}
})
.catch(async (error: unknown) => {
this.error = await parseAPIResponseError(error);
@ -565,7 +567,7 @@ export abstract class Table<T> extends AKElement implements TableLike {
const renderBottomPagination = () =>
html`<div class="pf-c-pagination pf-m-bottom">${this.renderTablePagination()}</div>`;
return html` ${this.needChipGroup ? this.renderChipGroup() : html``}
return html`${this.needChipGroup ? this.renderChipGroup() : html``}
${this.renderToolbarContainer()}
<table class="pf-c-table pf-m-compact pf-m-grid-md pf-m-expandable">
<thead>