habsi/authentik
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stages/dummy: add unittests

Browse Source 
stages/password: improve coverage
stages/user_login: improve coverage
This commit is contained in:
Jens Langhammer
2020-05-10 17:02:01 +02:00
parent f111604b70
commit a3a3dde1c8
8 changed files with 65 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
passbook/core/views/user.py
View File

@ -11,7 +11,6 @@ from django.views.generic import DeleteView, FormView, UpdateView
from passbook.core.forms.users import PasswordChangeForm, UserDetailForm
from passbook.lib.config import CONFIG
from passbook.stages.password.exceptions import PasswordPolicyInvalid
class UserSettingsView(SuccessMessageMixin, LoginRequiredMixin, UpdateView):
@ -48,20 +47,20 @@ class UserChangePasswordView(LoginRequiredMixin, FormView):
template_name = "login/form_with_user.html"
def form_valid(self, form: PasswordChangeForm):
# TODO: Rewrite to flow
try:
# user.set_password checks against Policies so we don't need to manually do it here
self.request.user.set_password(form.cleaned_data.get("password"))
self.request.user.save()
update_session_auth_hash(self.request, self.request.user)
messages.success(self.request, _("Successfully changed password"))
except PasswordPolicyInvalid as exc:
except ValueError:
# Manually inject error into form
# pylint: disable=protected-access
errors = form._errors.setdefault("password_repeat", ErrorList(""))
# pylint: disable=protected-access
errors = form._errors.setdefault("password", ErrorList())
for error in exc.messages:
errors.append(error)
errors.append("foo")
return self.form_invalid(form)
return redirect("passbook_core:overview")