From a61a41d7d0504de185ea7b6faf1960e1b447469b Mon Sep 17 00:00:00 2001
From: "Jens L." <jens@goauthentik.io>
Date: Fri, 3 Jan 2025 01:02:13 +0100
Subject: [PATCH] web: fix source selection and outpost integration health
 (#12530)

* fix source selector

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix service connection health not updating fully

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix logo alt not translated

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
---
 web/src/admin/AdminInterface/AboutModal.ts             | 2 +-
 web/src/admin/outposts/ServiceConnectionListPage.ts    | 2 +-
 web/src/admin/providers/oauth2/OAuth2Sources.ts        | 2 +-
 web/src/admin/providers/proxy/ProxyProviderFormForm.ts | 2 +-
 web/src/elements/sidebar/SidebarBrand.ts               | 3 ++-
 web/src/flow/FlowExecutor.ts                           | 2 +-
 web/src/standalone/api-browser/index.ts                | 3 ++-
 7 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/web/src/admin/AdminInterface/AboutModal.ts b/web/src/admin/AdminInterface/AboutModal.ts
index 0877fc54d1..7df4fe980a 100644
--- a/web/src/admin/AdminInterface/AboutModal.ts
+++ b/web/src/admin/AdminInterface/AboutModal.ts
@@ -74,7 +74,7 @@ export class AboutModal extends WithLicenseSummary(WithBrandConfig(ModalButton))
                         <img
                             class="pf-c-about-modal-box__brand-image"
                             src=${this.brand?.brandingFavicon ?? DefaultBrand.brandingFavicon}
-                            alt="authentik Logo"
+                            alt="${msg("authentik Logo")}"
                         />
                     </div>
                     <div class="pf-c-about-modal-box__close">
diff --git a/web/src/admin/outposts/ServiceConnectionListPage.ts b/web/src/admin/outposts/ServiceConnectionListPage.ts
index d9556c37ba..d922fa22f3 100644
--- a/web/src/admin/outposts/ServiceConnectionListPage.ts
+++ b/web/src/admin/outposts/ServiceConnectionListPage.ts
@@ -46,7 +46,7 @@ export class OutpostServiceConnectionListPage extends TablePage<ServiceConnectio
         const connections = await new OutpostsApi(DEFAULT_CONFIG).outpostsServiceConnectionsAllList(
             await this.defaultEndpointConfig(),
         );
-        Promise.all(
+        await Promise.all(
             connections.results.map((connection) => {
                 return new OutpostsApi(DEFAULT_CONFIG)
                     .outpostsServiceConnectionsAllStateRetrieve({
diff --git a/web/src/admin/providers/oauth2/OAuth2Sources.ts b/web/src/admin/providers/oauth2/OAuth2Sources.ts
index 69743223ec..f8dcb910b5 100644
--- a/web/src/admin/providers/oauth2/OAuth2Sources.ts
+++ b/web/src/admin/providers/oauth2/OAuth2Sources.ts
@@ -4,7 +4,7 @@ import { DualSelectPair } from "@goauthentik/elements/ak-dual-select/types";
 import { OAuthSource, SourcesApi } from "@goauthentik/api";
 
 const sourceToSelect = (source: OAuthSource) => [
-    source.pk,
+    source.slug,
     `${source.name} (${source.slug})`,
     source.name,
     source,
diff --git a/web/src/admin/providers/proxy/ProxyProviderFormForm.ts b/web/src/admin/providers/proxy/ProxyProviderFormForm.ts
index 3749ebce09..99449eae6d 100644
--- a/web/src/admin/providers/proxy/ProxyProviderFormForm.ts
+++ b/web/src/admin/providers/proxy/ProxyProviderFormForm.ts
@@ -291,7 +291,7 @@ export function renderForm(
 
                 ${showHttpBasic ? renderHttpBasic(provider) : nothing}
                 <ak-form-element-horizontal
-                    label=${msg("Trusted OIDC Sources")}
+                    label=${msg("Federated OIDC Sources")}
                     name="jwtFederationSources"
                 >
                     <ak-dual-select-dynamic-selected
diff --git a/web/src/elements/sidebar/SidebarBrand.ts b/web/src/elements/sidebar/SidebarBrand.ts
index d5df0eefdb..67abd1a74d 100644
--- a/web/src/elements/sidebar/SidebarBrand.ts
+++ b/web/src/elements/sidebar/SidebarBrand.ts
@@ -3,6 +3,7 @@ import { AKElement } from "@goauthentik/elements/Base";
 import { WithBrandConfig } from "@goauthentik/elements/Interface/brandProvider";
 import { themeImage } from "@goauthentik/elements/utils/images";
 
+import { msg } from "@lit/localize";
 import { CSSResult, TemplateResult, css, html } from "lit";
 import { customElement } from "lit/decorators.js";
 
@@ -89,7 +90,7 @@ export class SidebarBrand extends WithBrandConfig(AKElement) {
                 <div class="pf-c-brand ak-brand">
                     <img
                         src=${themeImage(this.brand?.brandingLogo ?? DefaultBrand.brandingLogo)}
-                        alt="authentik Logo"
+                        alt="${msg("authentik Logo")}"
                         loading="lazy"
                     />
                 </div>
diff --git a/web/src/flow/FlowExecutor.ts b/web/src/flow/FlowExecutor.ts
index 669053b5a7..e857cbc8ba 100644
--- a/web/src/flow/FlowExecutor.ts
+++ b/web/src/flow/FlowExecutor.ts
@@ -515,7 +515,7 @@ export class FlowExecutor extends Interface implements StageHost {
                                                             DefaultBrand.brandingLogo,
                                                         ),
                                                     )}"
-                                                    alt="authentik Logo"
+                                                    alt="${msg("authentik Logo")}"
                                                 />
                                             </div>
                                             ${until(this.renderChallenge())}
diff --git a/web/src/standalone/api-browser/index.ts b/web/src/standalone/api-browser/index.ts
index 3272c63d09..7d0e113f7c 100644
--- a/web/src/standalone/api-browser/index.ts
+++ b/web/src/standalone/api-browser/index.ts
@@ -8,6 +8,7 @@ import { DefaultBrand } from "@goauthentik/elements/sidebar/SidebarBrand";
 import { themeImage } from "@goauthentik/elements/utils/images";
 import "rapidoc";
 
+import { msg } from "@lit/localize";
 import { CSSResult, TemplateResult, css, html } from "lit";
 import { customElement, property, state } from "lit/decorators.js";
 import { ifDefined } from "lit/directives/if-defined.js";
@@ -102,7 +103,7 @@ export class APIBrowser extends Interface {
                 >
                     <div slot="nav-logo">
                         <img
-                            alt="authentik Logo"
+                            alt="${msg("authentik Logo")}"
                             class="logo"
                             src="${themeImage(
                                 first(this.brand?.brandingLogo, DefaultBrand.brandingLogo),