habsi/authentik
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

web/elements: fix table selection handler firing when click isn't for tr

Browse Source 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
This commit is contained in:
Jens Langhammer
2023-02-06 11:37:40 +01:00
parent fd9ce531c9
commit b3323c5d00
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
web/src/elements/table/Table.ts
View File

@ -292,10 +292,17 @@ export abstract class Table<T> extends AKElement {
private renderRowGroup(items: T[]): TemplateResult[] {
return items.map((item) => {
const itemSelectHandler = (ev?: InputEvent) => {
const itemSelectHandler = (ev?: InputEvent | PointerEvent) => {
let checked = false;
if (ev) {
checked = (ev.target as HTMLInputElement).checked;
// Only register click events on a table row
if (ev instanceof PointerEvent) {
if ((ev.target as HTMLInputElement).tagName.toLowerCase() != "tr") {
return;
}
} else if (ev instanceof InputEvent) {
checked = (ev.target as HTMLInputElement).checked;
}
} else {
// If we have no event, toggle the state
checked = this.selectedElements.indexOf(item) === -1;
@ -332,9 +339,7 @@ export abstract class Table<T> extends AKElement {
<tr
role="row"
class="${this.checkbox ? "pf-m-hoverable" : ""}"
@click=${() => {
itemSelectHandler();
}}
@click=${itemSelectHandler}
>
${this.checkbox
? html`<td class="pf-c-table__check" role="cell">