web: further cleanup, more linting

web/src/pages/LibraryPage.ts

@@ -6,7 +6,7 @@ import { truncate } from "../utils";
 
 @customElement("pb-library")
 export class ApplicationViewPage extends LitElement {
-    @property()
+    @property({attribute: false})
     apps?: PBResponse<Application>;
 
     static get styles(): CSSResult[] {

web/src/pages/admin-overview/AdminOverviewPage.ts

@@ -5,21 +5,25 @@ import { DefaultClient } from "../../api/client";
 import { User } from "../../api/user";
 import { COMMON_STYLES } from "../../common/styles";
 import { AggregatePromiseCard } from "../../elements/cards/AggregatePromiseCard";
+import { SpinnerSize } from "../../elements/Spinner";
+
+import "../../elements/AdminLoginsChart";
+import "./TopApplicationsTable";
 
 @customElement("pb-admin-status-card")
 export class AdminStatusCard extends AggregatePromiseCard {
 
-    @property()
+    @property({type: Number})
     value?: number;
 
     @property()
     warningText?: string;
 
-    @property()
+    @property({type: Number})
     lessThanThreshold?: number;
 
     renderNone(): TemplateResult {
-        return html`<pb-spinner size="large"></pb-spinner>`;
+        return html`<pb-spinner size=${SpinnerSize.Large}></pb-spinner>`;
     }
 
     renderGood(): TemplateResult {
@@ -47,10 +51,10 @@ export class AdminStatusCard extends AggregatePromiseCard {
 
 @customElement("pb-admin-overview")
 export class AdminOverviewPage extends LitElement {
-    @property()
+    @property({attribute: false})
     data?: AdminOverview;
 
-    @property()
+    @property({attribute: false})
     users?: Promise<number>;
 
     static get styles(): CSSResult[] {
@@ -89,7 +93,7 @@ export class AdminOverviewPage extends LitElement {
             html`<p class="pb-aggregate-card">
                                     <i class="fa fa-check-circle"></i> 0
                                 </p>`
-        : html`<pb-spinner size="large"></pb-spinner>`}
+        : html`<pb-spinner size=${SpinnerSize.Large}></pb-spinner>`}
                 </pb-aggregate-card>
                 <pb-aggregate-card class="pf-l-gallery__item pf-m-4-col" icon="pf-icon pf-icon-plugged" header="Policies" headerLink="#/administration/policies/">
                     ${this.data ?
@@ -101,7 +105,7 @@ export class AdminOverviewPage extends LitElement {
             html`<p class="pb-aggregate-card">
                                     <i class="fa fa-check-circle"></i> 0
                                 </p>`
-        : html`<pb-spinner size="large"></pb-spinner>`}
+        : html`<pb-spinner size=${SpinnerSize.Large}></pb-spinner>`}
                 </pb-aggregate-card>
                 <pb-aggregate-card-promise
                     icon="pf-icon pf-icon-user"

web/src/pages/admin-overview/TopApplicationsTable.ts

@@ -3,10 +3,12 @@ import { CSSResult, customElement, html, LitElement, property, TemplateResult }
 import { AuditEvent, TopNEvent } from "../../api/events";
 import { COMMON_STYLES } from "../../common/styles";
 
+import "../../elements/Spinner";
+
 @customElement("pb-top-applications-table")
 export class TopApplicationsTable extends LitElement {
 
-    @property()
+    @property({attribute: false})
     topN?: TopNEvent[];
 
     static get styles(): CSSResult[] {

web/src/pages/applications/ApplicationViewPage.ts

@@ -6,6 +6,9 @@ import { PolicyBinding } from "../../api/policy_binding";
 import { COMMON_STYLES } from "../../common/styles";
 import { Table } from "../../elements/table/Table";
 
+import "../../elements/Tabs";
+import "../../elements/AdminLoginsChart";
+
 @customElement("pb-bound-policies-list")
 export class BoundPoliciesList extends Table<PolicyBinding> {
     @property()
@@ -59,7 +62,7 @@ export class ApplicationViewPage extends LitElement {
         Application.get(value).then((app) => (this.application = app));
     }
 
-    @property()
+    @property({attribute: false})
     application?: Application;
 
     static get styles(): CSSResult[] {

web/src/pages/generic/SiteShell.ts

@@ -5,6 +5,7 @@ import BullseyeStyle from "@patternfly/patternfly/layouts/Bullseye/bullseye.css"
 import SpinnerStyle from "@patternfly/patternfly/components/Spinner/spinner.css";
 // @ts-ignore
 import BackdropStyle from "@patternfly/patternfly/components/Backdrop/backdrop.css";
+import { SpinnerSize } from "../../elements/Spinner";
 
 @customElement("pb-site-shell")
 export class SiteShell extends LitElement {
@@ -16,7 +17,7 @@ export class SiteShell extends LitElement {
 
     _url?: string;
 
-    @property()
+    @property({type: Boolean})
     loading = false;
 
     static get styles(): CSSResult[] {
@@ -107,7 +108,7 @@ export class SiteShell extends LitElement {
             html`<div class="pf-c-backdrop">
                     <div class="pf-l-bullseye">
                         <div class="pf-l-bullseye__item">
-                            <pb-spinner size="large"></pb-spinner>
+                            <pb-spinner size=${SpinnerSize.Large}></pb-spinner>
                         </div>
                     </div>
                 </div>`

web/src/pages/router/RouterOutlet.ts

@@ -9,9 +9,11 @@ import { Route } from "./Route";
 import { ROUTES } from "../../routes";
 import { RouteMatch } from "./RouteMatch";
 
+import "../generic/SiteShell";
+
 @customElement("pb-router-outlet")
 export class RouterOutlet extends LitElement {
-    @property()
+    @property({attribute: false})
     current?: RouteMatch;
 
     @property()