admin: add generic tests

passbook/admin/views/policies.py

@@ -62,9 +62,10 @@ class PolicyCreateView(
 
     def get_form_class(self):
         policy_type = self.request.GET.get("type")
-        model = next(x for x in all_subclasses(Policy) if x.__name__ == policy_type)
-        if not model:
-            raise Http404
+        try:
+            model = next(x for x in all_subclasses(Policy) if x.__name__ == policy_type)
+        except StopIteration as exc:
+            raise Http404 from exc
         return path_to_class(model.form)
 
 

passbook/admin/views/property_mapping.py

@@ -53,11 +53,14 @@ class PropertyMappingCreateView(
     def get_context_data(self, **kwargs):
         kwargs = super().get_context_data(**kwargs)
         property_mapping_type = self.request.GET.get("type")
-        model = next(
-            x
-            for x in all_subclasses(PropertyMapping)
-            if x.__name__ == property_mapping_type
-        )
+        try:
+            model = next(
+                x
+                for x in all_subclasses(PropertyMapping)
+                if x.__name__ == property_mapping_type
+            )
+        except StopIteration as exc:
+            raise Http404 from exc
         kwargs["type"] = model._meta.verbose_name
         form_cls = self.get_form_class()
         if hasattr(form_cls, "template_name"):
@@ -66,13 +69,14 @@ class PropertyMappingCreateView(
 
     def get_form_class(self):
         property_mapping_type = self.request.GET.get("type")
-        model = next(
-            x
-            for x in all_subclasses(PropertyMapping)
-            if x.__name__ == property_mapping_type
-        )
-        if not model:
-            raise Http404
+        try:
+            model = next(
+                x
+                for x in all_subclasses(PropertyMapping)
+                if x.__name__ == property_mapping_type
+            )
+        except StopIteration as exc:
+            raise Http404 from exc
         return path_to_class(model.form)
 
 

passbook/admin/views/providers.py

@@ -52,9 +52,12 @@ class ProviderCreateView(
 
     def get_form_class(self):
         provider_type = self.request.GET.get("type")
-        model = next(x for x in all_subclasses(Provider) if x.__name__ == provider_type)
-        if not model:
-            raise Http404
+        try:
+            model = next(
+                x for x in all_subclasses(Provider) if x.__name__ == provider_type
+            )
+        except StopIteration as exc:
+            raise Http404 from exc
         return path_to_class(model.form)
 
 

passbook/admin/views/sources.py

@@ -52,9 +52,10 @@ class SourceCreateView(
 
     def get_form_class(self):
         source_type = self.request.GET.get("type")
-        model = next(x for x in all_subclasses(Source) if x.__name__ == source_type)
-        if not model:
-            raise Http404
+        try:
+            model = next(x for x in all_subclasses(Source) if x.__name__ == source_type)
+        except StopIteration as exc:
+            raise Http404 from exc
         return path_to_class(model.form)
 
 

passbook/admin/views/stages.py

@@ -59,9 +59,10 @@ class StageCreateView(
 
     def get_form_class(self):
         stage_type = self.request.GET.get("type")
-        model = next(x for x in all_subclasses(Stage) if x.__name__ == stage_type)
-        if not model:
-            raise Http404
+        try:
+            model = next(x for x in all_subclasses(Stage) if x.__name__ == stage_type)
+        except StopIteration as exc:
+            raise Http404 from exc
         return path_to_class(model.form)