admin: add generic tests

2020-05-19 20:59:43 +02:00
parent 5ba55356a9
commit db69c3e38d
7 changed files with 72 additions and 25 deletions
--- a/passbook/admin/views/providers.py
+++ b/passbook/admin/views/providers.py
@ -52,9 +52,12 @@ class ProviderCreateView(

    def get_form_class(self):
        provider_type = self.request.GET.get("type")
-        model = next(x for x in all_subclasses(Provider) if x.__name__ == provider_type)
-        if not model:
-            raise Http404
+        try:
+            model = next(
+                x for x in all_subclasses(Provider) if x.__name__ == provider_type
+            )
+        except StopIteration as exc:
+            raise Http404 from exc
        return path_to_class(model.form)