habsi/authentik
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

web: 3 fixes for small typos, annoyances, and improvements (#7249)

Browse Source 
I'm conducting a more comprehensive survey of the UI in order to get a more holistic idea of the
changes that should be implemented.  Along the way, I'm finding a few small details that annoy me.
Here are three.

It goes to "User statistics."  I have changed both the text of the link and the page to read "User
Statistics" (it's a title, it should be capitalized).

Give people warning when you're about to take them out of the system, especially if you're opening a
new tab along the way.

Just a thing I spotted along the way.
This commit is contained in:
Ken Sternberg
2023-10-23 10:48:16 -07:00
committed by GitHub
parent 75aedb4d3f
commit e3ac774a18
4 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
web/src/admin/admin-overview/AdminOverviewPage.ts
View File

@ -22,6 +22,7 @@ import PFContent from "@patternfly/patternfly/components/Content/content.css";
import PFList from "@patternfly/patternfly/components/List/list.css";
import PFPage from "@patternfly/patternfly/components/Page/page.css";
import PFGrid from "@patternfly/patternfly/layouts/Grid/grid.css";
import PFBase from "@patternfly/patternfly/patternfly-base.css";
import { SessionUser } from "@goauthentik/api";
@ -35,6 +36,7 @@ export function versionFamily(): string {
export class AdminOverviewPage extends AKElement {
static get styles(): CSSResult[] {
return [
PFBase,
PFGrid,
PFPage,
PFContent,
@ -53,6 +55,13 @@ export class AdminOverviewPage extends AKElement {
.card-container {
max-height: 10em;
}
.ak-external-link {
display: inline-block;
margin-left: 0.175rem;
vertical-align: super;
line-height: normal;
font-size: var(--pf-global--icon--FontSize--sm);
}
`,
];
}
@ -104,8 +113,10 @@ export class AdminOverviewPage extends AKElement {
class="pf-u-mb-xl"
target="_blank"
href="https://goauthentik.io/integrations/"
>${msg("Explore integrations")}</a
>
>${msg("Explore integrations")}<i
class="fas fa-external-link-alt ak-external-link"
></i
></a>
</li>
<li>
<a class="pf-u-mb-xl" href=${paramURL("/identity/users")}
@ -120,8 +131,10 @@ export class AdminOverviewPage extends AKElement {
".",
"",
)}"
>${msg("Check release notes")}</a
>
>${msg("Check the release notes")}<i
class="fas fa-external-link-alt ak-external-link"
></i
></a>
</li>
</ul>
</ak-aggregate-card>

2
web/src/admin/admin-overview/DashboardUserPage.ts
View File

@ -41,7 +41,7 @@ export class DashboardUserPage extends AKElement {
}
render(): TemplateResult {
return html`<ak-page-header icon="pf-icon pf-icon-user" header=${msg("User statistics")}>
return html`<ak-page-header icon="pf-icon pf-icon-user" header=${msg("User Statistics")}>
</ak-page-header>
<section class="pf-c-page__main-section">
<div class="pf-l-grid pf-m-gutter">