From f8cb4e880b1fcef9093a31751c8842eb6976a704 Mon Sep 17 00:00:00 2001 From: Ken Sternberg Date: Tue, 16 Jul 2024 09:23:28 -0700 Subject: [PATCH] web: roll back update to sonar Bloody dependabot. We're not compatible with ESLint 9 yet, darnit, and yet dependabot keeps pushing upgrades on us. --- web/package-lock.json | 10 +++++----- web/package.json | 2 +- web/scripts/eslint-precommit.mjs | 2 +- web/src/flow/stages/RedirectStage.ts | 10 ++++++++-- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/web/package-lock.json b/web/package-lock.json index 6a5827bfb4..e5fc5fbbc5 100644 --- a/web/package-lock.json +++ b/web/package-lock.json @@ -93,7 +93,7 @@ "eslint-config-google": "^0.14.0", "eslint-plugin-custom-elements": "0.0.8", "eslint-plugin-lit": "^1.11.0", - "eslint-plugin-sonarjs": "^1.0.3", + "eslint-plugin-sonarjs": "0.25.1", "eslint-plugin-storybook": "^0.8.0", "github-slugger": "^2.0.0", "glob": "^11.0.0", @@ -14421,15 +14421,15 @@ "license": "MIT" }, "node_modules/eslint-plugin-sonarjs": { - "version": "1.0.3", - "resolved": "https://registry.npmjs.org/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-1.0.3.tgz", - "integrity": "sha512-6s41HLPYPyDrp+5+7Db5yFYbod6h9pC7yx+xfcNwHRcLe1EZwbbQT/tdOAkR7ekVUkNGEvN3GmYakIoQUX7dEg==", + "version": "0.25.1", + "resolved": "https://registry.npmjs.org/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-0.25.1.tgz", + "integrity": "sha512-5IOKvj/GMBNqjxBdItfotfRHo7w48496GOu1hxdeXuD0mB1JBlDCViiLHETDTfA8pDAVSBimBEQoetRXYceQEw==", "dev": true, "engines": { "node": ">=16" }, "peerDependencies": { - "eslint": "^8.0.0 || ^9.0.0" + "eslint": "^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0" } }, "node_modules/eslint-plugin-storybook": { diff --git a/web/package.json b/web/package.json index c1c49f921b..8963dce91b 100644 --- a/web/package.json +++ b/web/package.json @@ -120,7 +120,7 @@ "eslint-config-google": "^0.14.0", "eslint-plugin-custom-elements": "0.0.8", "eslint-plugin-lit": "^1.11.0", - "eslint-plugin-sonarjs": "^1.0.3", + "eslint-plugin-sonarjs": "0.25.1", "eslint-plugin-storybook": "^0.8.0", "github-slugger": "^2.0.0", "glob": "^11.0.0", diff --git a/web/scripts/eslint-precommit.mjs b/web/scripts/eslint-precommit.mjs index 4bf4293441..5705ea24b2 100644 --- a/web/scripts/eslint-precommit.mjs +++ b/web/scripts/eslint-precommit.mjs @@ -70,7 +70,7 @@ function findChangedFiles() { modified(status) && checkable(filename) && notIgnored(filename) ? [...acc, path.join(projectRoot, filename)] : acc, - [] + [], ); } diff --git a/web/src/flow/stages/RedirectStage.ts b/web/src/flow/stages/RedirectStage.ts index c38ddb38e8..d731b933bc 100644 --- a/web/src/flow/stages/RedirectStage.ts +++ b/web/src/flow/stages/RedirectStage.ts @@ -45,7 +45,10 @@ export class RedirectStage extends BaseStage + return html` `; } return html` `;