3a2ed11821
providers/proxy: fix URL path getting lost when partial URL is given to rd= (#11354) * providers/proxy: fix URL path getting lost when partial URL is given to rd= * better fallback + tests --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L. <jens@goauthentik.io>
72 lines
2.0 KiB
Go
72 lines
2.0 KiB
Go
package application
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"goauthentik.io/api/v3"
|
|
)
|
|
|
|
func TestCheckRedirectParam_None(t *testing.T) {
|
|
a := newTestApplication()
|
|
// Test no rd param
|
|
req, _ := http.NewRequest("GET", "/outpost.goauthentik.io/auth/start", nil)
|
|
|
|
rd, ok := a.checkRedirectParam(req)
|
|
|
|
assert.Equal(t, false, ok)
|
|
assert.Equal(t, "", rd)
|
|
}
|
|
|
|
func TestCheckRedirectParam_Invalid(t *testing.T) {
|
|
a := newTestApplication()
|
|
// Test invalid rd param
|
|
req, _ := http.NewRequest("GET", "/outpost.goauthentik.io/auth/start?rd=https://google.com", nil)
|
|
|
|
rd, ok := a.checkRedirectParam(req)
|
|
|
|
assert.Equal(t, false, ok)
|
|
assert.Equal(t, "", rd)
|
|
}
|
|
|
|
func TestCheckRedirectParam_ValidFull(t *testing.T) {
|
|
a := newTestApplication()
|
|
// Test valid full rd param
|
|
req, _ := http.NewRequest("GET", "/outpost.goauthentik.io/auth/start?rd=https://ext.t.goauthentik.io/test?foo", nil)
|
|
|
|
rd, ok := a.checkRedirectParam(req)
|
|
|
|
assert.Equal(t, true, ok)
|
|
assert.Equal(t, "https://ext.t.goauthentik.io/test?foo", rd)
|
|
}
|
|
|
|
func TestCheckRedirectParam_ValidPartial(t *testing.T) {
|
|
a := newTestApplication()
|
|
// Test valid partial rd param
|
|
req, _ := http.NewRequest("GET", "/outpost.goauthentik.io/auth/start?rd=/test?foo", nil)
|
|
|
|
rd, ok := a.checkRedirectParam(req)
|
|
|
|
assert.Equal(t, true, ok)
|
|
assert.Equal(t, "https://ext.t.goauthentik.io/test?foo", rd)
|
|
}
|
|
|
|
func TestCheckRedirectParam_Domain(t *testing.T) {
|
|
a := newTestApplication()
|
|
a.proxyConfig.Mode = api.PROXYMODE_FORWARD_DOMAIN.Ptr()
|
|
a.proxyConfig.CookieDomain = api.PtrString("t.goauthentik.io")
|
|
req, _ := http.NewRequest("GET", "https://a.t.goauthentik.io/outpost.goauthentik.io/auth/start", nil)
|
|
|
|
rd, ok := a.checkRedirectParam(req)
|
|
|
|
assert.Equal(t, false, ok)
|
|
assert.Equal(t, "", rd)
|
|
req, _ = http.NewRequest("GET", "/outpost.goauthentik.io/auth/start?rd=https://ext.t.goauthentik.io/test", nil)
|
|
|
|
rd, ok = a.checkRedirectParam(req)
|
|
|
|
assert.Equal(t, true, ok)
|
|
assert.Equal(t, "https://ext.t.goauthentik.io/test", rd)
|
|
}
|