a2714ab1f1
web/outpost: make metrics compliant with Prometheus best-practices Today, all NewHistogramVec store values in nanoseconds without changing the default histogram bucket, which are made for seconds, making them a bit useless. In addition, some metrics names are not self-explanatoryand and do not comply with Prometheus best practices. This commit tries to fix all of this "issues". NOTE: I kept old metrics in order to avoid breaking changes with existing dashboards and metrics. Signed-off-by: Alexandre NICOLAIE <xunleii@users.noreply.github.com>
65 lines
2.0 KiB
Go
65 lines
2.0 KiB
Go
package web
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
|
|
"github.com/gorilla/mux"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/prometheus/client_golang/prometheus/promauto"
|
|
"github.com/prometheus/client_golang/prometheus/promhttp"
|
|
log "github.com/sirupsen/logrus"
|
|
"goauthentik.io/internal/config"
|
|
"goauthentik.io/internal/utils/sentry"
|
|
)
|
|
|
|
var (
|
|
Requests = promauto.NewHistogramVec(prometheus.HistogramOpts{
|
|
Name: "authentik_main_request_duration_seconds",
|
|
Help: "API request latencies in seconds",
|
|
}, []string{"dest"})
|
|
|
|
// NOTE: the following metric is kept for compatibility purpose
|
|
RequestsLegacy = promauto.NewHistogramVec(prometheus.HistogramOpts{
|
|
Name: "authentik_main_requests",
|
|
Help: "The total number of configured providers",
|
|
}, []string{"dest"})
|
|
)
|
|
|
|
func RunMetricsServer() {
|
|
m := mux.NewRouter()
|
|
l := log.WithField("logger", "authentik.router.metrics")
|
|
m.Use(sentry.SentryNoSampleMiddleware)
|
|
m.Path("/metrics").HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
|
|
promhttp.InstrumentMetricHandler(
|
|
prometheus.DefaultRegisterer, promhttp.HandlerFor(prometheus.DefaultGatherer, promhttp.HandlerOpts{
|
|
DisableCompression: true,
|
|
}),
|
|
).ServeHTTP(rw, r)
|
|
|
|
// Get upstream metrics
|
|
re, err := http.NewRequest("GET", "http://localhost:8000/-/metrics/", nil)
|
|
if err != nil {
|
|
l.WithError(err).Warning("failed to get upstream metrics")
|
|
return
|
|
}
|
|
re.SetBasicAuth("monitor", config.Get().SecretKey)
|
|
res, err := http.DefaultClient.Do(re)
|
|
if err != nil {
|
|
l.WithError(err).Warning("failed to get upstream metrics")
|
|
return
|
|
}
|
|
_, err = io.Copy(rw, res.Body)
|
|
if err != nil {
|
|
l.WithError(err).Warning("failed to get upstream metrics")
|
|
return
|
|
}
|
|
})
|
|
l.WithField("listen", config.Get().Listen.Metrics).Info("Starting Metrics server")
|
|
err := http.ListenAndServe(config.Get().Listen.Metrics, m)
|
|
if err != nil {
|
|
l.WithError(err).Warning("Failed to start metrics server")
|
|
}
|
|
l.WithField("listen", config.Get().Listen.Metrics).Info("Stopping Metrics server")
|
|
}
|