habsi/elasticsearch-js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[connectors/http] prevent errors caused by multi-byte characters in paths (#756)

Browse Source 
* [connectors/http] catch errors caused by multi-byte paths

* Check url validity before to run the request

* Updated test
This commit is contained in:
Spencer
2019-01-23 13:29:42 -08:00
committed by GitHub
parent a25a8d996e
commit 0d07233b46
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/connectors/http.js
View File

@ -19,6 +19,7 @@ var qs = require('querystring');
var AgentKeepAlive = require('agentkeepalive');
var ConnectionAbstract = require('../connection');
var zlib = require('zlib');
var INVALID_PATH_REGEX = /[^\u0021-\u00ff]/
/**
* Connector used to talk to an elasticsearch node via HTTP
@ -166,6 +167,11 @@ HttpConnector.prototype.request = function (params, cb) {
}
}, this);
if (INVALID_PATH_REGEX.test(reqParams.path) === true) {
cb(new TypeError('ERR_UNESCAPED_CHARACTERS: ' + reqParams.path))
return function () {}
}
request = this.hand.request(reqParams, function (_incoming) {
incoming = _incoming;
status = incoming.statusCode;