habsi/elasticsearch-js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #267 from spalger/fix/promiseRejection

Browse Source 
[transport/request] ensure the return value gets defined
This commit is contained in:
Spencer
2015-09-10 15:25:54 -07:00
parent 85b2d8739a a9175dad58
commit 0ddcb057b4
3 changed files with 36 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
test/unit/specs/transport.js
View File

@ -360,7 +360,8 @@ describe('Transport Class', function () {
done();
});
});
it('rejects get requests with bodies', function (done) {
it('rejects GET requests with a body (callback)', function (done) {
var trans = new Transport();
stub(trans.log, 'debug');
stub(trans.connectionPool, 'select', function (cb) {
@ -377,6 +378,26 @@ describe('Transport Class', function () {
});
});
it('rejects GET requests with a body (promise)', function (done) {
var trans = new Transport();
stub(trans.log, 'debug');
stub(trans.connectionPool, 'select', function (cb) {
// simulate "no connections"
process.nextTick(cb);
});
trans.request({
body: 'JSON!!',
method: 'GET'
})
.then(function () {
done(new Error('expected the request to fail!'));
}, function (err) {
expect(err).to.be.a(TypeError);
expect(err.message).to.match(/body.*method.*get/i);
done();
});
});
describe('gets a body', function () {
it('serializes it', function (done) {
var trans = new Transport({