From 24454c27a8ce68c1002718a2295b1527451f3bb4 Mon Sep 17 00:00:00 2001 From: spalger Date: Wed, 14 Jun 2017 19:19:43 -0700 Subject: [PATCH] [eslint] remove exception for `prefer-const`, and fix violations --- .eslintrc.yaml | 5 +---- src/lib/connection.js | 3 +-- src/lib/connectors/http.js | 2 +- test/integration/yaml_suite/yaml_doc.js | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.eslintrc.yaml b/.eslintrc.yaml index a340c735d..461653ed5 100644 --- a/.eslintrc.yaml +++ b/.eslintrc.yaml @@ -1,5 +1,2 @@ --- -extends: "@elastic/eslint-config-kibana" - -rules: - prefer-const: warn \ No newline at end of file +extends: "@elastic/eslint-config-kibana" \ No newline at end of file diff --git a/src/lib/connection.js b/src/lib/connection.js index df3b2cd14..8eb6a69c8 100644 --- a/src/lib/connection.js +++ b/src/lib/connection.js @@ -55,13 +55,12 @@ ConnectionAbstract.prototype.ping = function (params, cb) { let requestTimeout = this.pingTimeout; let requestTimeoutId; let aborted; - let abort; if (params && params.hasOwnProperty('requestTimeout')) { requestTimeout = params.requestTimeout; } - abort = this.request(_.defaults(params || {}, { + const abort = this.request(_.defaults(params || {}, { path: '/', method: 'HEAD' }), function (err) { diff --git a/src/lib/connectors/http.js b/src/lib/connectors/http.js index 671206594..2d7e41ecf 100644 --- a/src/lib/connectors/http.js +++ b/src/lib/connectors/http.js @@ -133,11 +133,11 @@ HttpConnector.prototype.makeReqParams = function (params) { HttpConnector.prototype.request = function (params, cb) { let incoming; let timeoutId; - let request; let status = 0; let headers = {}; const log = this.log; let response; + let request; // eslint-disable-line prefer-const const reqParams = this.makeReqParams(params); diff --git a/test/integration/yaml_suite/yaml_doc.js b/test/integration/yaml_suite/yaml_doc.js index c0909e0b2..06250e171 100644 --- a/test/integration/yaml_suite/yaml_doc.js +++ b/test/integration/yaml_suite/yaml_doc.js @@ -449,7 +449,7 @@ YamlDoc.prototype = { catcher = null; } - let timeoutId; + let timeoutId; // eslint-disable-line prefer-const const cb = _.bind(function (error, body) { this._last_requests_response = body; clearTimeout(timeoutId);