[eslint] remove exception for prefer-const, and fix violations

This commit is contained in:
spalger
2017-06-14 19:19:43 -07:00
parent 40078d6965
commit 24454c27a8
4 changed files with 4 additions and 8 deletions

View File

@ -1,5 +1,2 @@
--- ---
extends: "@elastic/eslint-config-kibana" extends: "@elastic/eslint-config-kibana"
rules:
prefer-const: warn

View File

@ -55,13 +55,12 @@ ConnectionAbstract.prototype.ping = function (params, cb) {
let requestTimeout = this.pingTimeout; let requestTimeout = this.pingTimeout;
let requestTimeoutId; let requestTimeoutId;
let aborted; let aborted;
let abort;
if (params && params.hasOwnProperty('requestTimeout')) { if (params && params.hasOwnProperty('requestTimeout')) {
requestTimeout = params.requestTimeout; requestTimeout = params.requestTimeout;
} }
abort = this.request(_.defaults(params || {}, { const abort = this.request(_.defaults(params || {}, {
path: '/', path: '/',
method: 'HEAD' method: 'HEAD'
}), function (err) { }), function (err) {

View File

@ -133,11 +133,11 @@ HttpConnector.prototype.makeReqParams = function (params) {
HttpConnector.prototype.request = function (params, cb) { HttpConnector.prototype.request = function (params, cb) {
let incoming; let incoming;
let timeoutId; let timeoutId;
let request;
let status = 0; let status = 0;
let headers = {}; let headers = {};
const log = this.log; const log = this.log;
let response; let response;
let request; // eslint-disable-line prefer-const
const reqParams = this.makeReqParams(params); const reqParams = this.makeReqParams(params);

View File

@ -449,7 +449,7 @@ YamlDoc.prototype = {
catcher = null; catcher = null;
} }
let timeoutId; let timeoutId; // eslint-disable-line prefer-const
const cb = _.bind(function (error, body) { const cb = _.bind(function (error, body) {
this._last_requests_response = body; this._last_requests_response = body;
clearTimeout(timeoutId); clearTimeout(timeoutId);