Remove Node.js v8 support (#1402)

test/benchmarks/macro/complex.bench.js

@@ -16,7 +16,7 @@ const { bench, beforeEach, afterEach } = require('../suite')({
   }
 })
 
-var stackoverflow = []
+let stackoverflow = []
 const stackoverflowPath = join(
   __dirname,
   'fixtures',
@@ -53,7 +53,7 @@ bench('Bulk index documents', {
   action: 'bulk'
 }, async b => {
   b.start()
-  for (var i = 0; i < stackoverflow.length; i++) {
+  for (let i = 0; i < stackoverflow.length; i++) {
     await b.client.bulk({ body: stackoverflow[i] })
   }
   b.end()
@@ -67,7 +67,7 @@ bench('Complex search request', {
   action: 'search'
 }, async b => {
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.search({
       index: INDEX,
       body: {
@@ -81,8 +81,8 @@ bench('Complex search request', {
 })
 
 function readSOfile () {
-  var i = 0
-  var stackoverflow = []
+  let i = 0
+  const stackoverflow = []
   return new Promise((resolve, reject) => {
     createReadStream(stackoverflowPath)
       .pipe(split(JSON.parse))

test/benchmarks/macro/simple.bench.js

@@ -44,7 +44,7 @@ bench('Ping', {
   action: 'ping'
 }, async b => {
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.ping()
   }
   b.end()
@@ -57,7 +57,7 @@ bench('Create index', {
   action: 'indices.create'
 }, async b => {
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.indices.create({ index: `test-create-${i}` })
   }
   b.end()
@@ -75,7 +75,7 @@ bench('Index small document', {
   await b.client.indices.create({ index })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.create({
       index,
       type: '_doc',
@@ -98,7 +98,7 @@ bench('Index large document', {
   await b.client.indices.create({ index })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.create({
       index,
       type: '_doc',
@@ -128,7 +128,7 @@ bench('Get small document', {
   })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.get({
       index,
       type: '_doc',
@@ -157,7 +157,7 @@ bench('Get large document', {
   })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.get({
       index,
       type: '_doc',
@@ -187,7 +187,7 @@ bench('Search small document', {
   })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.search({
       index,
       type: '_doc',
@@ -221,7 +221,7 @@ bench('Search large document', {
   })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.search({
       index,
       type: '_doc',
@@ -255,7 +255,7 @@ bench('Update small document', {
   })
 
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await b.client.update({
       index,
       type: '_doc',

test/benchmarks/micro/basic.bench.js

@@ -12,7 +12,7 @@ const { connection } = require('../../utils')
 
 bench('Initialization', { warmup: 5, measure: 10, iterations: 1000 }, async b => {
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     const client = new Client({ // eslint-disable-line
       node: 'http://localhost:9200'
     })
@@ -56,7 +56,7 @@ bench('Basic get', { warmup: 5, measure: 10, iterations: 1000 }, async b => {
     q: 'foo:bar'
   })
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await client.search({
       index: 'test',
       type: 'doc',
@@ -83,7 +83,7 @@ bench('Basic post', { warmup: 5, measure: 10, iterations: 1000 }, async b => {
     }
   })
   b.start()
-  for (var i = 0; i < b.iterations; i++) {
+  for (let i = 0; i < b.iterations; i++) {
     await client.search({
       index: 'test',
       type: 'doc',

test/benchmarks/suite.js

@@ -15,10 +15,10 @@ function buildBenchmark (options = {}) {
   const q = workq()
   const stats = {}
   const reports = []
-  var beforeEach = null
-  var afterEach = null
-  var setup = null
-  var teardown = null
+  let beforeEach = null
+  let afterEach = null
+  let setup = null
+  let teardown = null
 
   function setBeforeEach (fn) {
     beforeEach = fn
@@ -54,7 +54,7 @@ function buildBenchmark (options = {}) {
     }
 
     stats[title] = []
-    var { measure, warmup } = opts
+    let { measure, warmup } = opts
     const b = new B({ iterations: opts.iterations })
 
     q.add(runSetup)
@@ -225,7 +225,7 @@ function buildBenchmark (options = {}) {
       }
     })
 
-    for (var i = 0; i < results.length; i++) {
+    for (let i = 0; i < results.length; i++) {
       await client.index({
         index: 'benchmarking_results',
         type: '_doc',