habsi/elasticsearch-js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Backport 7.x] Add warning.name to product check security exception (#1527)

Browse Source 
Co-authored-by: Tomas Della Vedova <delvedor@users.noreply.github.com>
This commit is contained in:
github-actions[bot]
2021-08-20 10:40:19 +02:00
committed by delvedor
parent 5e18738921
commit 649f95afca
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Transport.js
View File

@ -559,7 +559,10 @@ class Transport {
debug('Product check failed', err)
if (err.statusCode === 401 || err.statusCode === 403) {
this[kProductCheck] = 2
process.emitWarning('The client is unable to verify that the server is Elasticsearch due to security privileges on the server side. Some functionality may not be compatible if the server is running an unsupported product.')
process.emitWarning(
'The client is unable to verify that the server is Elasticsearch due to security privileges on the server side. Some functionality may not be compatible if the server is running an unsupported product.',
'ProductNotSupportedSecurityError'
)
productCheckEmitter.emit('product-check', null, true)
} else {
this[kProductCheck] = 0

6
test/acceptance/product-check.test.js
View File

@ -470,7 +470,7 @@ test('Errors v6', t => {
})
test('Auth error - 401', t => {
t.plan(8)
t.plan(9)
const MockConnection = buildMockConnection({
onRequest (params) {
return {
@ -487,6 +487,7 @@ test('Auth error - 401', t => {
process.on('warning', onWarning)
function onWarning (warning) {
t.equal(warning.name, 'ProductNotSupportedSecurityError')
t.equal(warning.message, 'The client is unable to verify that the server is Elasticsearch due to security privileges on the server side. Some functionality may not be compatible if the server is running an unsupported product.')
}
@ -524,7 +525,7 @@ test('Auth error - 401', t => {
})
test('Auth error - 403', t => {
t.plan(8)
t.plan(9)
const MockConnection = buildMockConnection({
onRequest (params) {
return {
@ -541,6 +542,7 @@ test('Auth error - 403', t => {
process.on('warning', onWarning)
function onWarning (warning) {
t.equal(warning.name, 'ProductNotSupportedSecurityError')
t.equal(warning.message, 'The client is unable to verify that the server is Elasticsearch due to security privileges on the server side. Some functionality may not be compatible if the server is running an unsupported product.')
}