Use standard and prettier (#10)

* switch from custom eslint config to standard + prettier

* fix new standard eslint violations

* add editorconfig file

* auto-fix all other violations

* update lint yarn script

* remove jshint comment
This commit is contained in:
Spencer
2019-07-09 13:24:13 -07:00
committed by GitHub
parent f69840c50f
commit 7c1573fb07
119 changed files with 4506 additions and 3521 deletions

View File

@ -7,45 +7,45 @@ var errors = require('../../../src/lib/errors');
var stub = require('../../utils/auto_release_stub').make();
describe('Connection Abstract', function () {
describe('Connection Abstract', function() {
var host = new Host('localhost:9200');
it('constructs with defaults for host, and bound', function () {
it('constructs with defaults for host, and bound', function() {
var conn = new ConnectionAbstract(host);
expect(conn.host).to.be(host);
});
it('requires a valid host', function () {
expect(function () {
it('requires a valid host', function() {
expect(function() {
// eslint-disable-next-line no-new
new ConnectionAbstract();
}).to.throwError(TypeError);
expect(function () {
expect(function() {
// eslint-disable-next-line no-new
new ConnectionAbstract({});
}).to.throwError(TypeError);
});
it('required that the request method is overridden', function () {
expect(function () {
it('required that the request method is overridden', function() {
expect(function() {
var conn = new ConnectionAbstract(host);
conn.request();
}).to.throwError(/overwrit/);
});
describe('#ping', function () {
it('accpets just a callback', function () {
describe('#ping', function() {
it('accpets just a callback', function() {
var conn = new ConnectionAbstract(host);
stub(conn, 'request');
var cb = function () {};
var cb = function() {};
conn.ping(cb);
expect(conn.request.callCount).to.eql(1);
expect(conn.request.lastCall.args[0]).to.be.a('object');
expect(conn.request.lastCall.args[1]).to.be.a('function');
});
it('accpets just params', function () {
it('accpets just params', function() {
var conn = new ConnectionAbstract(host);
stub(conn, 'request');
conn.ping({});
@ -54,13 +54,13 @@ describe('Connection Abstract', function () {
expect(conn.request.lastCall.args[1]).to.be.a('function');
});
it('allows overriding the requestTimeout, method, and path', function () {
it('allows overriding the requestTimeout, method, and path', function() {
var conn = new ConnectionAbstract(host);
stub(conn, 'request');
var params = {
method: 'HEAD',
path: '/',
requestTimeout: 10000
requestTimeout: 10000,
};
conn.ping(params);
expect(conn.request.callCount).to.eql(1);
@ -68,7 +68,7 @@ describe('Connection Abstract', function () {
expect(conn.request.lastCall.args[1]).to.be.a('function');
});
it('defaults to the pingTimeout in the config', function () {
it('defaults to the pingTimeout in the config', function() {
var conn = new ConnectionAbstract(host, { pingTimeout: 5000 });
var clock = sinon.useFakeTimers('setTimeout', 'clearTimeout');
stub.autoRelease(clock);
@ -81,64 +81,70 @@ describe('Connection Abstract', function () {
expect(clock.timers[_.keys(clock.timers).shift()].delay).to.eql(5000);
});
it('calls it\'s own request method', function () {
it("calls it's own request method", function() {
var conn = new ConnectionAbstract(host);
stub(conn, 'request');
conn.ping();
expect(conn.request.callCount).to.eql(1);
});
it('sets a timer for the request', function (done) {
it('sets a timer for the request', function(done) {
var conn = new ConnectionAbstract(host);
var clock = sinon.useFakeTimers('setTimeout', 'clearTimeout');
stub.autoRelease(clock);
var order = 0;
stub(conn, 'request', function (params, cb) {
setTimeout(function () {
stub(conn, 'request', function(params, cb) {
setTimeout(function() {
expect(++order).to.eql(2);
cb();
}, 10001);
});
conn.ping({
requestTimeout: 100
}, function (err) {
expect(++order).to.eql(1);
expect(err).to.be.an(errors.RequestTimeout);
});
conn.ping(
{
requestTimeout: 100,
},
function(err) {
expect(++order).to.eql(1);
expect(err).to.be.an(errors.RequestTimeout);
}
);
process.nextTick(function () {
process.nextTick(function() {
clock.tick(1000);
clock.tick(10000);
done();
});
});
it('calls the requestAborter if req takes too long', function (done) {
it('calls the requestAborter if req takes too long', function(done) {
var conn = new ConnectionAbstract(host);
var clock = sinon.useFakeTimers('setTimeout', 'clearTimeout');
stub.autoRelease(clock);
var order = 0;
stub(conn, 'request', function (params, cb) {
setTimeout(function () {
stub(conn, 'request', function(params, cb) {
setTimeout(function() {
expect(++order).to.eql(3);
cb();
}, 10001);
return function () {
return function() {
expect(++order).to.eql(1);
};
});
conn.ping({
requestTimeout: 100
}, function (err) {
expect(++order).to.eql(2);
expect(err).to.be.an(errors.RequestTimeout);
});
conn.ping(
{
requestTimeout: 100,
},
function(err) {
expect(++order).to.eql(2);
expect(err).to.be.an(errors.RequestTimeout);
}
);
process.nextTick(function () {
process.nextTick(function() {
clock.tick(1000);
clock.tick(10000);
done();
@ -148,15 +154,15 @@ describe('Connection Abstract', function () {
// it('ignores the response from the request if it already aborted');
});
describe('#setStatus', function () {
it('emits the "status set" event with `new`, `old` & `conn` args', function () {
describe('#setStatus', function() {
it('emits the "status set" event with `new`, `old` & `conn` args', function() {
var conn = new ConnectionAbstract(host);
var emitted = false;
conn.emit = function (eventName) {
conn.emit = function(eventName) {
emitted = {
name: eventName,
args: Array.prototype.slice.call(arguments, 1)
args: Array.prototype.slice.call(arguments, 1),
};
};
@ -165,7 +171,7 @@ describe('Connection Abstract', function () {
expect(emitted.args).to.eql(['closed', undefined, conn]);
});
it('stores the status in this.status', function () {
it('stores the status in this.status', function() {
var conn = new ConnectionAbstract(host);
conn.setStatus('closed');