habsi/elasticsearch-js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Upgrade to lodash v4 (#660)

Browse Source 
* npm install lodash-2

Someone handily published a lodash-2 v4.17.4 - it is exactly the same as lodash v4.17.4, so it is safe to use during the migration.

* use lodash-2 in tests

* update tests to split utils vs lodash

* remove Utils.nextTick usage

Utils.nextTick with a single argument is the same as process.nextTick

* lowercase utils

Because it seems that this is the coding style in this repo

* upgrade lodash in grunt/*

* keep lodash-2 as a dev dep for now

* use lodash-2 in scripts

* use snakeCase from utils

It was a mistake in my previous commit to not update this usage

* fix naming gruntUtils vs utils

As all three - gruntUtils, utils and lodash (_) are getting passed into templates, it makes sense to keep the naming consistent

* fix naming gruntUtils vs utils

As all three - gruntUtils, utils and lodash (_) are getting passed into templates, it makes sense to keep the naming consistent

* split utils vs lodash in scripts/generate

Also use lodash-2 where it is easy to do so

* use utils.get until lodash upgrade

* remove lodash.isempty; lodash-2 now used in prod (in src/lib/apis/ code)

* unbundle lodash from utils

* upgrade to lodash 4

* remove lodash.get and lodash.trimEnd

* clean out unused code

* clean out unused code

* fix a breaking change listed under "notable changes" rather than under "breaking changes"...
This commit is contained in:
Dominykas Blyžė
2018-05-14 21:37:23 +03:00
committed by Spencer
parent 4cd2b3e506
commit f1de944809
67 changed files with 355 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
grunt/tasks.js
View File

@ -1,6 +1,6 @@
module.exports = function (grunt) {
var Promise = require('bluebird');
var utils = require('./utils');
var gruntUtils = require('./utils');
var readFile = Promise.promisify(require('fs').readFile);
var writeFile = Promise.promisify(require('fs').writeFile);
@ -16,7 +16,7 @@ module.exports = function (grunt) {
'mochacov:unit'
];
var branches = branch ? [branch] : utils.branches;
var branches = branch ? [branch] : gruntUtils.branches;
process.env.ES_PORT = process.env.ES_PORT || 9400;
process.env.ES_HOST = process.env.ES_HOST || 'localhost';
@ -52,20 +52,20 @@ module.exports = function (grunt) {
var current = pkg.version;
pkg.version = nextVersion;
browserBuilds = utils.replaceAll(browserBuilds, current, nextVersion);
browserBuilds = gruntUtils.replaceAll(browserBuilds, current, nextVersion);
readme = utils.replaceAll(readme, current, nextVersion);
readme = gruntUtils.replaceAll(readme, current, nextVersion);
readme = utils.replaceAll(
readme = gruntUtils.replaceAll(
readme,
'/' + utils.minorVersion(current) + '.svg',
'/' + utils.minorVersion(nextVersion) + '.svg'
'/' + gruntUtils.minorVersion(current) + '.svg',
'/' + gruntUtils.minorVersion(nextVersion) + '.svg'
);
readme = utils.replaceAll(
readme = gruntUtils.replaceAll(
readme,
'branch=' + utils.minorVersion(current),
'branch=' + utils.minorVersion(nextVersion)
'branch=' + gruntUtils.minorVersion(current),
'branch=' + gruntUtils.minorVersion(nextVersion)
);
// write all files to disk