habsi/elasticsearch-js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Upgrade to lodash v4 (#660)

Browse Source 
* npm install lodash-2

Someone handily published a lodash-2 v4.17.4 - it is exactly the same as lodash v4.17.4, so it is safe to use during the migration.

* use lodash-2 in tests

* update tests to split utils vs lodash

* remove Utils.nextTick usage

Utils.nextTick with a single argument is the same as process.nextTick

* lowercase utils

Because it seems that this is the coding style in this repo

* upgrade lodash in grunt/*

* keep lodash-2 as a dev dep for now

* use lodash-2 in scripts

* use snakeCase from utils

It was a mistake in my previous commit to not update this usage

* fix naming gruntUtils vs utils

As all three - gruntUtils, utils and lodash (_) are getting passed into templates, it makes sense to keep the naming consistent

* fix naming gruntUtils vs utils

As all three - gruntUtils, utils and lodash (_) are getting passed into templates, it makes sense to keep the naming consistent

* split utils vs lodash in scripts/generate

Also use lodash-2 where it is easy to do so

* use utils.get until lodash upgrade

* remove lodash.isempty; lodash-2 now used in prod (in src/lib/apis/ code)

* unbundle lodash from utils

* upgrade to lodash 4

* remove lodash.get and lodash.trimEnd

* clean out unused code

* clean out unused code

* fix a breaking change listed under "notable changes" rather than under "breaking changes"...
This commit is contained in:
Dominykas Blyžė
2018-05-14 21:37:23 +03:00
committed by Spencer
parent 4cd2b3e506
commit f1de944809
67 changed files with 355 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/generate/templates/index.js
View File

@ -1,6 +1,7 @@
var _ = require('../../../src/lib/utils');
var utils = require('../../../grunt/utils');
var _ = require('lodash');
var utils = require('../../../src/lib/utils');
var gruntUtils = require('../../../grunt/utils');
var fs = require('fs');
var path = require('path');
@ -42,9 +43,10 @@ var templateGlobals = {
stringify: stringify,
_: _,
utils: utils,
indent: function (block, spaces) {
var indent = _.repeat(' ', spaces);
var indent = utils.repeat(' ', spaces);
return block.split('\n').map(function (line) {
return indent + line;
}).join('\n');
@ -92,7 +94,7 @@ var templateGlobals = {
partials: templates,
utils: utils
gruntUtils: gruntUtils
};
fs.readdirSync(path.resolve(__dirname)).forEach(function (filename) {
@ -100,7 +102,6 @@ fs.readdirSync(path.resolve(__dirname)).forEach(function (filename) {
if (name !== 'index') {
templates[name] = _.template(
fs.readFileSync(path.resolve(__dirname, filename), 'utf8'),
null,
{
imports: templateGlobals
}