From f4e4cf73586a80b07ae4af029a5f68c7fa0be014 Mon Sep 17 00:00:00 2001 From: spalger Date: Wed, 14 Jun 2017 19:11:39 -0700 Subject: [PATCH] [eslint] remove exception for `new-cap`, fix violations --- .eslintrc.yaml | 1 - grunt/config/esvm.js | 2 +- src/elasticsearch.jquery.js | 2 +- test/unit/specs/client.js | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.eslintrc.yaml b/.eslintrc.yaml index ed2e46d65..bfd3e298f 100644 --- a/.eslintrc.yaml +++ b/.eslintrc.yaml @@ -2,7 +2,6 @@ extends: "@elastic/eslint-config-kibana" rules: - new-cap: warn space-unary-ops: warn dot-notation: warn quotes: warn diff --git a/grunt/config/esvm.js b/grunt/config/esvm.js index 130383e69..aa0526314 100644 --- a/grunt/config/esvm.js +++ b/grunt/config/esvm.js @@ -102,7 +102,7 @@ utils.branches.forEach(function (branch) { opts.version = v.version; } else if (ref) { - v = new Version.fromBranch(String(ref).replace(/v?(\d+\.\d+)\..+/, '$1')); + v = Version.fromBranch(String(ref).replace(/v?(\d+\.\d+)\..+/, '$1')); opts.branch = ref; opts.fresh = true; } diff --git a/src/elasticsearch.jquery.js b/src/elasticsearch.jquery.js index a05f8c442..8618a7baf 100644 --- a/src/elasticsearch.jquery.js +++ b/src/elasticsearch.jquery.js @@ -4,7 +4,7 @@ const es = require('./elasticsearch'); function defer() { - const def = $.Deferred(); + const def = new $.Deferred(); // def.promise is usually a property (in normal implementations) // we override the promise to keep things working def.promise = def.promise(); diff --git a/test/unit/specs/client.js b/test/unit/specs/client.js index 6d42b48cc..73fc32c7a 100644 --- a/test/unit/specs/client.js +++ b/test/unit/specs/client.js @@ -36,7 +36,7 @@ describe('Client instances creation', function () { it('inherits the ' + prev + ' API when specified', function () { client.close(); - client = es.Client({ + client = new es.Client({ apiVersion: prev }); expect(client.bulk).to.be(apis[prev].bulk);