New release v2.6.3

* Change how data is sent to the persistent connection socket.

We can't rely on readline(), so send the size of the data first. We can
then read that many bytes from the stream on the recieving end.

* Set pty to noncanonical mode before sending

* Now that we send data length, we don't need a sentinel anymore

* Copy socket changes to persistent, too

* Use os.write instead of fdopen()ing and using that.

* Follow pickle with sha1sum of pickle

* Swap order of vars and init being passed to ansible-connection

(cherry picked from commit f221105882)

.gitattributes

@@ -1,4 +1,2 @@
-CHANGELOG.md merge=union
 .github/ export-ignore
 hacking/ export-ignore
-ticket-stubs/ export-ignore

.github/CODE_OF_CONDUCT.md

@@ -0,0 +1,3 @@
+# Community Code of Conduct
+
+Please see the official [Ansible Community Code of Conduct](https://docs.ansible.com/ansible/latest/community/code_of_conduct.html).

.github/ISSUE_TEMPLATE.md

@@ -1,48 +1,43 @@
 <!---
 Verify first that your issue/request is not already reported on GitHub.
-Also test if the latest release, and master branch are affected too.
--->
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
+
+##### SUMMARY
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-<!--- Pick one below and delete the rest: -->
+<!--- Pick one below and delete the rest -->
  - Bug Report
  - Feature Idea
  - Documentation Report
 
 ##### COMPONENT NAME
-<!--- Name of the module/plugin/task/feature -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
 ##### ANSIBLE VERSION
-<!--- Paste verbatim output from "ansible --version" between quotes below -->
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
 ```
 
 ```
 
 ##### CONFIGURATION
-<!---
-If using Ansible 2.4 or above, paste the results of "ansible-config dump --only-changed"
-
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
 Otherwise, mention any settings you have changed/added/removed in ansible.cfg
-(or using the ANSIBLE_* environment variables).
-
--->
+(or using the ANSIBLE_* environment variables).-->
 
 ##### OS / ENVIRONMENT
-<!---
-Mention the OS you are running Ansible from, and the OS you are
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
 managing, or say "N/A" for anything that is not platform-specific.
 Also mention the specific version of what you are trying to control,
-e.g. if this is a network bug the version of firmware on the network device.
--->
-
-##### SUMMARY
-<!--- Explain the problem briefly -->
+e.g. if this is a network bug the version of firmware on the network device.-->
 
 ##### STEPS TO REPRODUCE
-<!---
-For bugs, show exactly how to reproduce the problem, using a minimal test-case.
-For new features, show how the feature would be used.
--->
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
 
 <!--- Paste example playbooks or commands between quotes below -->
 ```yaml

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,61 @@
+---
+name: 🐛 Bug report
+about: Create a report to help us improve
+
+---
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
+
+##### SUMMARY
+<!--- Explain the problem briefly -->
+
+##### ISSUE TYPE
+ - Bug Report
+
+##### COMPONENT NAME
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
+
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
+
+```
+
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/documentation_report.md

@@ -0,0 +1,61 @@
+---
+name: 📝 Documentation Report
+about: Ask us about docs
+
+---
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
+
+##### SUMMARY
+<!--- Explain the problem briefly -->
+
+##### ISSUE TYPE
+ - Documentation Report
+
+##### COMPONENT NAME
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
+
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
+
+```
+
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,61 @@
+---
+name: ✨ Feature request
+about: Suggest an idea for this project
+
+---
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
+
+##### SUMMARY
+<!--- Explain the problem briefly -->
+
+##### ISSUE TYPE
+ - Feature Idea
+
+##### COMPONENT NAME
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
+
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
+
+```
+
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,11 +1,9 @@
 ##### SUMMARY
 <!--- Describe the change, including rationale and design decisions -->
 
-<!---
-If you are fixing an existing issue, please include "Fixes #nnn" in your
+<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
 commit message and your description; but you should still explain what
-the change does.
--->
+the change does.-->
 
 ##### ISSUE TYPE
 <!--- Pick one below and delete the rest: -->
@@ -15,7 +13,7 @@ the change does.
  - Docs Pull Request
 
 ##### COMPONENT NAME
-<!--- Name of the module/plugin/module/task -->
+<!--- Name of the module, plugin, module or task -->
 
 ##### ANSIBLE VERSION
 <!--- Paste verbatim output from "ansible --version" between quotes below -->
@@ -25,11 +23,9 @@ the change does.
 
 
 ##### ADDITIONAL INFORMATION
-<!---
-Include additional information to help people understand the change here.
+<!--- Include additional information to help people understand the change here.
 For bugs that don't have a linked bug report, a step-by-step reproduction
-of the problem is helpful.
-  -->
+of the problem is helpful. -->
 
 <!--- Paste verbatim command output below, e.g. before and after your change -->
 ```

.gitignore

@@ -17,6 +17,8 @@ rpm-build
 .idea
 #IntelliJ IDEA stuff..
 *.iml
+#VSCode stuff..
+.vscode/
 # Mac OS X stuff...
 .DS_Store
 # manpage build stuff...
@@ -29,28 +31,22 @@ docs/man/man3/*
 # docsite stuff...
 docs/api/_build/
 docs/api/rst/
-docs/docsite/*.html
 docs/docsite/_build
+docs/docsite/*.html
+docs/docsite/htmlout
+docs/docsite/rst/cli/ansible-*.rst
+docs/docsite/rst/cli/ansible.rst
+docs/docsite/rst/modules/*.rst
+docs/docsite/rst/playbooks_directives.rst
+docs/docsite/rst/plugins_by_category.rst
+docs/docsite/rst/plugins/*/*.rst
+docs/docsite/rst/reference_appendices/config.rst
+docs/docsite/rst/reference_appendices/playbooks_keywords.rst
+docs/docsite/rst_warnings
+docs/docsite/searchindex.js
 docs/docsite/_static/*.gif
 docs/docsite/_static/*.png
 docs/docsite/_static/websupport.js
-docs/docsite/htmlout
-docs/docsite/searchindex.js
-docs/docsite/rst_warnings
-docs/docsite/rst/*_module.rst
-docs/docsite/rst/ansible.rst
-docs/docsite/rst/ansible-*.rst
-docs/docsite/rst/community_maintained.rst
-docs/docsite/rst/config.rst
-docs/docsite/rst/core_maintained.rst
-docs/docsite/rst/list_of_*.rst
-docs/docsite/rst/modules_by_category.rst
-docs/docsite/rst/network_maintained.rst
-docs/docsite/rst/plugins_by_category.rst
-docs/docsite/rst/partner_maintained.rst
-docs/docsite/rst/playbook_keywords.rst
-docs/docsite/rst/playbooks_directives.rst
-docs/docsite/rst/plugins/*/*.rst
 # deb building stuff...
 /debian/
 deb-build
@@ -61,12 +57,15 @@ credentials.yml
 # test output
 *.retry
 *.out
+.pytest_cache/
 .tox
 .cache
+.pytest_cache
 results.xml
 coverage.xml
 /test/units/cover-html
 /test/integration/targets/*/backup/
+/test/cache/*
 # Development
 /test/develop
 venv
@@ -76,6 +75,7 @@ ansible.egg-info/
 /shippable/
 /test/integration/cloud-config-*.*
 !/test/integration/cloud-config-*.*.template
+.python-version
 # Release directory
 packaging/release/ansible_release
 /.cache/
@@ -91,6 +91,7 @@ packaging/release/ansible_release
 /test/integration/inventory.networking
 /test/integration/inventory.winrm
 /test/integration/cloud-config-aws.yml
+/test/integration/cloud-config-cs.ini
 # python 'rope' stuff
 .ropeproject
 # local 'ack' config files
@@ -102,3 +103,4 @@ htmlcov/
 # ansible-test coverage results
 test/units/.coverage.*
 /test/integration/cloud-config-azure.yml
+changelogs/.plugin-cache.yaml

.mailmap

@@ -1,5 +1,5 @@
 Michael DeHaan <michael.dehaan@gmail.com> <michael@ansibleworks.com>
-Michael DeHaan <michael.dehaan@gmail.com> Michael DeHaan <Michael DeHaan michael@ansibleworks.com>
+Michael DeHaan <michael.dehaan@gmail.com> Michael DeHaan <michael@ansibleworks.com>
 Michael DeHaan <michael.dehaan@gmail.com> <michael@ansible.com>
 <bcoca@ansible.com> <brian.coca+git@gmail.com>
 <bcoca@ansible.com> <briancoca+ansible@gmail.com>

CODING_GUIDELINES.md

@@ -1,10 +1,10 @@
 Coding Guidelines
 =================
 
-Hi!  Thanks for interest in contributing to Ansible.
+Hi!  Thanks for your interest in contributing to Ansible.
 
-Here are some guidelines for contributing code.  The purpose of this document are to establish what we're looking for in code contributions, and to make sure
-new contributions know some of the conventions that we've been using.
+Here are some guidelines for contributing code.  The purpose of this document is to establish what we're looking for in code contributions, and to make sure
+new contributors know some of the conventions that we've been using.
 
 We don't think much of this should be too strange to readers familiar with contributing to Python projects, though it helps if we all get on the same page.
 
@@ -12,27 +12,27 @@ Language
 ========
 
   * While not all components of Ansible must be in Python, core contributions to the Ansible repo must be written in Python.  This is to maximize the ability of everyone to contribute.
-  * If you want to write non-Python ansible modules or inventory scripts, that's fine, but they are not going to get merged in most likely.  Sorry!!  
+  * If you want to write non-Python ansible modules or inventory scripts, that's fine, but they are not going to get merged in most likely.  Sorry!!
 
 PEP 8 and basic style checks
-===========================
+============================
 
   * [PEP 8](https://www.python.org/dev/peps/pep-0008/) is a great Python style guide, which you should read.
-  * PEP 8 must not be strictly followed in all aspects, but most of it is good advice
-  * In particular, we don't really care about line lengths.  Buy a bigger monitor!
-  * To run checks for things we care about, use [ansible-test](http://docs.ansible.com/ansible/dev_guide/testing_pep8.html#running-locally).
-  * Similarly, additional checks can be made with "make pyflakes"
+  * PEP 8 must not be strictly followed in all aspects, but most of it is good advice.
+  * The line is limited to 160 characters.
+  * To run checks for things we care about, use [ansible-test](https://docs.ansible.com/ansible/devel/dev_guide/testing_sanity.html).
+  * Similarly, additional checks can be made with "make pyflakes".
   * There is no need to submit code changes for PEP 8 and pyflakes fixes, as these break attribution history.  Project leadership will make these periodically.
-  * Do not submit pull requests that simply adjust whitespace in the code
+  * Do not submit pull requests that simply adjust whitespace in the code.
 
 Testing
 =======
 
-  * Much of ansible's testing needs are in integration, not unit tests.  Add module tests there.
+  * Much of Ansible's testing needs are in integration, not unit tests.  Add module tests there.
   * That being said, there are unit tests too!
   * Code written must absolutely pass tests (i.e. "make tests")
   * You should anticipate any error paths in your code and test down those error paths.
-  * Additions to tests for core code is welcome, but not always possible.  Be sure things are at least well tested manually in that case.
+  * Additions to tests for core code are welcome, but not always possible.  Be sure things are at least well tested manually in that case.
 
 Whitespace
 ==========
@@ -42,7 +42,7 @@ Whitespace
 
 Shebang Lines
 =============
- 
+
   * /usr/bin/scripts should start with '/usr/bin/env python'
   * module code should still use '/usr/bin/python' as this is replaced automatically by 'ansible_python_interpreter', see the FAQ in the docs for more info.
 
@@ -60,13 +60,13 @@ Classes
 
   * With the exception of module code (where inline is better), it is desirable to see classes in their own files.
   * Classes should generally not cause side effects as soon as they are instantiated, move meaningful behavior to methods rather than constructors.
- 
+
 Functions and Methods
 =====================
 
   * In general, functions should not be 'too long' and should describe a meaningful amount of work
   * When code gets too nested, that's usually the sign the loop body could benefit from being a function
-  * Parts of our existing code are not the best examples of this at times. 
+  * Parts of our existing code are not the best examples of this at times.
   * Functions should have names that describe what they do, along with docstrings
   * Functions should be named with_underscores
   * "Don't repeat yourself" is generally a good philosophy
@@ -74,7 +74,7 @@ Functions and Methods
 Variables
 =========
 
-  * Use descriptive variable names instead of variables like 'x', unless x is a obvious loop index
+  * Use descriptive variable names instead of variables like 'x', unless x is an obvious loop index
   * Ansible python code uses identifiers like 'ClassesLikeThis and variables_like_this
   * Module parameters should also use_underscores and not runtogether
 
@@ -83,7 +83,7 @@ Module Security
 
   * Modules must take steps to avoid passing user input from the shell and always check return codes
   * always use module.run_command instead of subprocess or Popen or os.system -- this is mandatory
-  * if you use need the shell you must pass use_unsafe_shell=True to module.run_command
+  * if you need to use the shell you must pass use_unsafe_shell=True to module.run_command
   * if you do not need the shell, avoid using the shell
   * any variables that can come from the user input with use_unsafe_shell=True must be wrapped by pipes.quote(x)
   * downloads of https:// resource urls must import module_utils.urls and use the fetch_url method
@@ -161,24 +161,24 @@ All contributions to the core repo should preserve original licenses and new con
 Module Documentation
 ====================
 
-All module pull requests must include a DOCUMENTATION docstring (YAML format, 
-see other modules for examples) as well as an EXAMPLES docstring, which is free form.  
+All module pull requests must include a DOCUMENTATION docstring (YAML format,
+see other modules for examples) as well as an EXAMPLES docstring, which is free form.
 
-When adding new modules, any new parameter must have a "version_added" attribute.  
-When submitting a new module, the module should have a "version_added" attribute in the 
+When adding new modules, any new parameter must have a "version_added" attribute.
+When submitting a new module, the module should have a "version_added" attribute in the
 pull request as well, set to the current development version.
 
 Be sure to check grammar and spelling.
 
-It's frequently the case that modules get submitted with YAML that isn't valid, 
-so you can run "make webdocs" from the checkout to preview your module's documentation. 
-If it fails to build, take a look at your DOCUMENTATION string 
+It's frequently the case that modules get submitted with YAML that isn't valid,
+so you can run "make webdocs" from the checkout to preview your module's documentation.
+If it fails to build, take a look at your DOCUMENTATION string
 or you might have a Python syntax error in there too.
 
 Python Imports
 ==============
 
-To make it clear what a module is importing, imports should not be sprinkled throughout the code. 
+To make it clear what a module is importing, imports should not be sprinkled throughout the code.
 
 Python Imports should happen at the top of the file, exempting code from module_utils.
 
@@ -203,7 +203,7 @@ Exceptions
 ==========
 
 In the main body of the code, use typed exceptions where possible:
-    
+
     # not this
     raise Exception("panic!")
 
@@ -265,7 +265,7 @@ Use 'in':
     # not this:
     if x.find('foo') != -1:
 
-    # this: 
+    # this:
     if 'foo' in x:
 
 String checks
@@ -290,19 +290,19 @@ In particular, metaclasses are probably not appropriate, however entertaining th
 Git Practices
 =============
 
-Pull requests cannot be accepted that contain merge commits.
+Pull requests cannot be accepted if they contain merge commits.
 
-Always do "git pull --rebase" and "git rebase" vs "git pull" or "git merge".
+Always do "git pull --rebase" and "git rebase" vs "git pull" or "git merge". See [rebasing a pull request](https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html) for more information.
+
+Always create a new branch for each pull request to avoid intermingling different features or fixes on the same branch.
 
-Always create a new branch for each pull request to avoid intertwingling different features or fixes on the same branch.
 
-   
 Python Version Compliance
 =========================
 
 All code in Ansible core must support a minimum version of Python 2.6.
 
-Module code must support a minimum of Python 2.4, with occasional exception for modules that require code that themselves require 2.6 and later.
+Module code must support a minimum of Python 2.4, with occasional exceptions for modules that require code that themselves require 2.6 and later.
 
 A quick reminder is that list comprehensions in Python 2.4 are not as fully fleshed out, there are no 'dict' comprehensions, and there is no 'with' statement.
 But otherwise it's pretty much all the same.

CONTRIBUTING.md

@@ -2,24 +2,23 @@
 
 Hi! Nice to see you here!
 
-
 ## QUESTIONS ?
 
-Please see the [community page](http://docs.ansible.com/community.html) for information on how to ask questions on the [mailing lists](http://docs.ansible.com/community.html#mailing-list-information) and IRC.
+Please see the [community guide](https://docs.ansible.com/ansible/latest/community/index.html) for information on how to ask questions on the [mailing lists](https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information) and IRC.
 
 The GitHub issue tracker is not the best place for questions for various reasons, but both IRC and the mailing list are very helpful places for those things, as the community page explains best.
 
-
 ## CONTRIBUTING ?
 
-Please see the [community page](http://docs.ansible.com/community.html) for information regarding the contribution process. Important license agreement information is also included on that page.
+By contributing you agree that these contributions are your own (or approved by your employer) and you grant a full, complete, irrevocable copyright license to all users and developers of the project, present and future, pursuant to the license of the project.
 
+Please see the [community guide](https://docs.ansible.com/ansible/latest/community/index.html) for information regarding the contribution process. Important license agreement information is also included on that page.
 
 ## BUG TO REPORT ?
 
-First and foremost, also check the [community page](http://docs.ansible.com/community.html).
+First and foremost, also check the [community guide](https://docs.ansible.com/ansible/latest/community/index.html).
 
-You can report bugs or make enhancement requests at the [Ansible GitHub issue page](http://github.com/ansible/ansible/issues/new) by filling out the issue template that will be presented.
+You can report bugs or make enhancement requests at the [Ansible GitHub issue page](http://github.com/ansible/ansible/issues/new/choose) by filling out the issue template that will be presented.
 
 Also please make sure you are testing on the latest released version of Ansible or the development branch. You can find the latest releases and development branch at:
 

MANIFEST.in

@@ -1,21 +1,20 @@
-prune ticket_stubs
 prune hacking
-include README.md COPYING
+include README.rst
+include COPYING
 include SYMLINK_CACHE.json
 include requirements.txt
 include .coveragerc
-include .yamllint
 include examples/hosts
 include examples/ansible.cfg
 recursive-include lib/ansible/module_utils/powershell *
 recursive-include lib/ansible/modules *
 recursive-include lib/ansible/galaxy/data *
 recursive-include docs *
+recursive-include licenses *
 recursive-include packaging *
 recursive-include test *
 include Makefile
-include VERSION
 include MANIFEST.in
-include CHANGELOG.md
+include changelogs/CHANGELOG-*.rst
 include contrib/README.md
 recursive-include contrib/inventory *

MODULE_GUIDELINES.md

@@ -1,70 +1,3 @@
 # Module Maintainer Guidelines
 
-Thank you for being a maintainer of one Ansible's community modules! This guide provides module maintainers an overview of their responsibilities, resources for additional information, and links to helpful tools.
-
-In addition to the information below, module maintainers should be familiar with:
-* General Ansible community development practices (http://docs.ansible.com/ansible/community.html)
-* Documentation on module development (http://docs.ansible.com/ansible/developing_modules.html)
-* Any namespace-specific module guidelines (identified as GUIDELINES.md in the appropriate file tree).
-
-***
-
-# Maintainer Responsibilities
-
-When you contribute a new module to the [ansible/ansible](https://github.com/ansible/ansible) repository, you become the maintainer for that module once it has been merged. Maintainership empowers you with the authority to accept, reject, or request revisions to pull requests on your module -- but as they say, "with great power comes great responsibility."
-
-Maintainers of Ansible modules are expected to provide feedback, responses, or actions on pull requests or issues to the module(s) they maintain in a reasonably timely manner.
-
-It is also recommended that you occasionally revisit the [contribution guidelines](https://github.com/ansible/ansible/blob/devel/CONTRIBUTING.md), as they are continually refined. Occasionally, you may be requested to update your module to move it closer to the general accepted standard requirements. We hope for this to be infrequent, and will always be a request with a fair amount of lead time (ie: not by tomorrow!).
-
-Finally, following the [ansible-devel](https://groups.google.com/forum/#!forum/ansible-devel) mailing list can be a great way to participate in the broader Ansible community, and a place where you can influence the overall direction, quality, and goals of Ansible and its modules. If you're not on this relatively low-volume list, please join us here: https://groups.google.com/forum/#!forum/ansible-devel
-
-The Ansible community hopes that you will find that maintaining your module is as rewarding for you as having the module is for the wider community.
-
-***
-
-# Pull Requests, Issues, and Workflow
-
-## Pull Requests
-
-Module pull requests are located in the [main Ansible repository](https://github.com/ansible/ansible/pulls).
-
-Because of the high volume of pull requests, notification of PRs to specific modules are routed by an automated bot to the appropriate maintainer for handling. It is recommended that you set an appropriate notification process to receive notifications which mention your GitHub ID.
-
-## Issues
-
-Issues for modules, including bug reports, documentation bug reports, and feature requests, are tracked in the [ansible repository](https://github.com/ansible/ansible/issues).
-
- Issues for modules are routed to their maintainers via an automated process. This process is still being refined, and currently depends upon the issue creator to provide adequate details (specifically, providing the proper module name) in order to route it correctly. If you are a maintainer of a specific module, it is recommended that you periodically search module issues for issues which mention your module's name (or some variation on that name), as well as setting an appropriate notification process for receiving notification of mentions of your GitHub ID.
-
-## PR Workflow
-
-Automated routing of pull requests is handled by a tool called [Ansibullbot](https://github.com/ansible/ansibullbot). (You could say that he moooo-ves things around.)
-
-Being moderately familiar with how the workflow behind the bot operates can be helpful to you, and -- should things go awry -- your feedback can be helpful to the folks that continually help Ansibullbot to evolve.
-
-A detailed explanation of the PR workflow can be seen here: https://github.com/ansible/community/blob/master/PR-FLOW.md
-
-***
-
-# Maintainers list
-
-The full list of maintainers for modules is located here: https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml
-
-## Changing Maintainership
-
-Communities change over time, and no one maintains a module forever. If you'd like to propose an additional maintainer for your module, please submit a PR to the maintainers file with the Github username of the new maintainer.
-
-If you'd like to step down as a maintainer, please submit a PR to the maintainers file removing your Github ID from the module in question. If that would leave the module with no maintainers, put "ansible" as the maintainer.  This will indicate that the module is temporarily without a maintainer, and the Ansible community team will search for a new maintainer.
-
-***
-
-# Tools and other Resources
-
-## Useful tools
-* https://ansible.sivel.net/pr/byfile.html -- a full list of all open Pull Requests, organized by file.
-
-## Other Resources
-
-* Ansibullbot: https://github.com/ansible/ansibullbot
-* Triage / pull request workflow and information, including definitions for Labels in GitHub: https://github.com/ansible/community/blob/master/PR-FLOW.md
+The Ansible Module Maintainer Guidelines can now be found in the [official Ansible community guide](https://docs.ansible.com/ansible/latest/community/maintainers.html).

Makefile

@@ -9,7 +9,7 @@
 #   make deb-src -------------- produce a DEB source
 #   make deb ------------------ produce a DEB
 #   make docs ----------------- rebuild the manpages (results are checked in)
-#   make tests ---------------- run the tests (see https://docs.ansible.com/ansible/dev_guide/testing_units.html for requirements)
+#   make tests ---------------- run the tests (see https://docs.ansible.com/ansible/devel/dev_guide/testing_units.html for requirements)
 #   make pyflakes, make pep8 -- source code checks
 
 ########################################################
@@ -17,26 +17,34 @@
 
 NAME = ansible
 OS = $(shell uname -s)
+PREFIX ?= '/usr/local'
 
-# Manpages are currently built with asciidoc -- would like to move to markdown
 # This doesn't evaluate until it's called. The -D argument is the
 # directory of the target file ($@), kinda like `dirname`.
-
-MANPAGES ?= $(patsubst %.asciidoc.in,%,$(wildcard ./docs/man/man1/ansible*.1.asciidoc.in))
-ifneq ($(shell which a2x 2>/dev/null),)
-ASCII2MAN = a2x -L -D $(dir $@) -d manpage -f manpage $<
-ASCII2HTMLMAN = a2x -L -D docs/html/man/ -d manpage -f xhtml
+MANPAGES ?= $(patsubst %.rst.in,%,$(wildcard ./docs/man/man1/ansible*.1.rst.in))
+ifneq ($(shell which rst2man 2>/dev/null),)
+ASCII2MAN = rst2man $< $@
+else ifneq ($(shell which rst2man.py 2>/dev/null),)
+ASCII2MAN = rst2man.py $< $@
 else
-ASCII2MAN = @echo "ERROR: AsciiDoc 'a2x' command is not installed but is required to build $(MANPAGES)" && exit 1
+ASCII2MAN = @echo "ERROR: rst2man from docutils command is not installed but is required to build $(MANPAGES)" && exit 1
 endif
 GENERATE_CLI = docs/bin/generate_man.py
 
 PYTHON=python
 SITELIB = $(shell $(PYTHON) -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")
 
-# VERSION file provides one place to update the software version
-VERSION := $(shell cat VERSION | cut -f1 -d' ')
-RELEASE := $(shell cat VERSION | cut -f2 -d' ')
+# fetch version from project release.py as single source-of-truth
+VERSION := $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --raw || echo error)
+ifeq ($(findstring error,$(VERSION)), error)
+$(error "version_helper failed")
+endif
+
+MAJOR_VERSION := $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --majorversion)
+CODENAME := $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --codename)
+
+# if a specific release was not requested, set to 1 (RPMs have "fancier" logic for this further down)
+RELEASE ?= 1
 
 # Get the branch information from git
 ifneq ($(shell which git),)
@@ -62,15 +70,16 @@ DEBUILD_OPTS = --source-option="-I"
 DPUT_BIN ?= dput
 DPUT_OPTS ?=
 DEB_DATE := $(shell LC_TIME=C date +"%a, %d %b %Y %T %z")
+DEB_VERSION ?= $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --debversion)
 ifeq ($(OFFICIAL),yes)
-    DEB_RELEASE = $(RELEASE)ppa
+    DEB_RELEASE ?= $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --debrelease)ppa
     # Sign OFFICIAL builds using 'DEBSIGN_KEYID'
     # DEBSIGN_KEYID is required when signing
     ifneq ($(DEBSIGN_KEYID),)
         DEBUILD_OPTS += -k$(DEBSIGN_KEYID)
     endif
 else
-    DEB_RELEASE = 100.git$(DATE)$(GITINFO)
+    DEB_RELEASE ?= 100.git$(DATE)$(GITINFO)
     # Do not sign unofficial builds
     DEBUILD_OPTS += -uc -us
     DPUT_OPTS += -u
@@ -90,7 +99,7 @@ PBUILDER_OPTS ?= --debootstrapopts --variant=buildd --architecture $(PBUILDER_AR
 RPMSPECDIR= packaging/rpm
 RPMSPEC = $(RPMSPECDIR)/ansible.spec
 RPMDIST = $(shell rpm --eval '%{?dist}')
-RPMRELEASE = $(RELEASE)
+
 ifneq ($(OFFICIAL),yes)
     RPMRELEASE = 100.git$(DATE)$(GITINFO)
 endif
@@ -98,12 +107,20 @@ ifeq ($(PUBLISH),nightly)
     # https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
     RPMRELEASE = $(RELEASE).$(DATE)git.$(GIT_HASH)
 endif
-RPMNVR = "$(NAME)-$(VERSION)-$(RPMRELEASE)$(RPMDIST)"
+
+RPMVERSION ?= $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --baseversion)
+RPMRELEASE ?= $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --rpmrelease)
+RPMNVR = "$(NAME)-$(RPMVERSION)-$(RPMRELEASE)$(RPMDIST)$(REPOTAG)"
 
 # MOCK build parameters
 MOCK_BIN ?= mock
 MOCK_CFG ?=
 
+# dynamically add repotag define only if specified
+ifneq ($(REPOTAG),)
+    EXTRA_RPM_DEFINES += --define "repotag $(REPOTAG)"
+endif
+
 # ansible-test parameters
 ANSIBLE_TEST ?= test/runner/ansible-test
 TEST_FLAGS ?=
@@ -141,14 +158,15 @@ integration:
 authors:
 	sh hacking/authors.sh
 
-# Regenerate %.1.asciidoc if %.1.asciidoc.in has been modified more
-# recently than %.1.asciidoc.
-%.1.asciidoc: %.1.asciidoc.in
+# Regenerate %.1.rst if %.1.rst.in has been modified more
+# recently than %.1.rst.
+%.1.rst: %.1.rst.in
 	sed "s/%VERSION%/$(VERSION)/" $< > $@
+	rm $<
 
-# Regenerate %.1 if %.1.asciidoc or VERSION has been modified more
-# recently than %.1. (Implicitly runs the %.1.asciidoc recipe)
-%.1: %.1.asciidoc VERSION
+# Regenerate %.1 if %.1.rst or release.py has been modified more
+# recently than %.1. (Implicitly runs the %.1.rst recipe)
+%.1: %.1.rst lib/ansible/release.py
 	$(ASCII2MAN)
 
 .PHONY: loc
@@ -177,7 +195,7 @@ clean:
 	find . -type f \( -name "*.swp" \) -delete
 	@echo "Cleaning up manpage stuff"
 	find ./docs/man -type f -name "*.xml" -delete
-	find ./docs/man -type f -name "*.asciidoc" -delete
+	find ./docs/man -type f -name "*.rst" -delete
 	find ./docs/man/man3 -type f -name "*.3" -delete
 	rm -f ./docs/man/man1/*
 	@echo "Cleaning up output from test runs"
@@ -209,6 +227,10 @@ python:
 install:
 	$(PYTHON) setup.py install
 
+install_manpages:
+	gzip -9 $(wildcard ./docs/man/man1/ansible*.1)
+	cp $(wildcard ./docs/man/man1/ansible*.1.gz) $(PREFIX)/man/man1/
+
 .PHONY: sdist
 sdist: clean docs
 	$(PYTHON) setup.py sdist
@@ -217,15 +239,23 @@ sdist: clean docs
 sdist_upload: clean docs
 	$(PYTHON) setup.py sdist upload 2>&1 |tee upload.log
 
+.PHONY: changelog
+changelog:
+	packaging/release/changelogs/changelog.py release -vv && packaging/release/changelogs/changelog.py generate -vv
+
 .PHONY: rpmcommon
 rpmcommon: sdist
 	@mkdir -p rpm-build
 	@cp dist/*.gz rpm-build/
-	@sed -e 's#^Version:.*#Version: $(VERSION)#' -e 's#^Release:.*#Release: $(RPMRELEASE)%{?dist}$(REPOTAG)#' $(RPMSPEC) >rpm-build/$(NAME).spec
+	@cp $(RPMSPEC) rpm-build/$(NAME).spec
 
 .PHONY: mock-srpm
 mock-srpm: /etc/mock/$(MOCK_CFG).cfg rpmcommon
-	$(MOCK_BIN) -r $(MOCK_CFG) $(MOCK_ARGS) --resultdir rpm-build/  --buildsrpm --spec rpm-build/$(NAME).spec --sources rpm-build/
+	$(MOCK_BIN) -r $(MOCK_CFG) $(MOCK_ARGS) --resultdir rpm-build/ --bootstrap-chroot --old-chroot --buildsrpm --spec rpm-build/$(NAME).spec --sources rpm-build/ \
+	--define "rpmversion $(RPMVERSION)" \
+	--define "upstream_version $(VERSION)" \
+	--define "rpmrelease $(RPMRELEASE)" \
+	$(EXTRA_RPM_DEFINES)
 	@echo "#############################################"
 	@echo "Ansible SRPM is built:"
 	@echo rpm-build/*.src.rpm
@@ -233,7 +263,11 @@ mock-srpm: /etc/mock/$(MOCK_CFG).cfg rpmcommon
 
 .PHONY: mock-rpm
 mock-rpm: /etc/mock/$(MOCK_CFG).cfg mock-srpm
-	$(MOCK_BIN) -r $(MOCK_CFG) $(MOCK_ARGS) --resultdir rpm-build/ --rebuild rpm-build/$(NAME)-*.src.rpm
+	$(MOCK_BIN) -r $(MOCK_CFG) $(MOCK_ARGS) --resultdir rpm-build/ --bootstrap-chroot --old-chroot --rebuild rpm-build/$(NAME)-*.src.rpm \
+	--define "rpmversion $(RPMVERSION)" \
+	--define "upstream_version $(VERSION)" \
+	--define "rpmrelease $(RPMRELEASE)" \
+	$(EXTRA_RPM_DEFINES)
 	@echo "#############################################"
 	@echo "Ansible RPM is built:"
 	@echo rpm-build/*.noarch.rpm
@@ -247,6 +281,10 @@ srpm: rpmcommon
 	--define "_srcrpmdir %{_topdir}" \
 	--define "_specdir $(RPMSPECDIR)" \
 	--define "_sourcedir %{_topdir}" \
+	--define "upstream_version $(VERSION)" \
+	--define "rpmversion $(RPMVERSION)" \
+	--define "rpmrelease $(RPMRELEASE)" \
+	$(EXTRA_RPM_DEFINES) \
 	-bs rpm-build/$(NAME).spec
 	@rm -f rpm-build/$(NAME).spec
 	@echo "#############################################"
@@ -262,8 +300,12 @@ rpm: rpmcommon
 	--define "_srcrpmdir %{_topdir}" \
 	--define "_specdir $(RPMSPECDIR)" \
 	--define "_sourcedir %{_topdir}" \
-	--define "_rpmfilename %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm" \
+	--define "_rpmfilename $(RPMNVR).%%{ARCH}.rpm" \
 	--define "__python `which $(PYTHON)`" \
+	--define "upstream_version $(VERSION)" \
+	--define "rpmversion $(RPMVERSION)" \
+	--define "rpmrelease $(RPMRELEASE)" \
+	$(EXTRA_RPM_DEFINES) \
 	-ba rpm-build/$(NAME).spec
 	@rm -f rpm-build/$(NAME).spec
 	@echo "#############################################"
@@ -277,7 +319,7 @@ debian: sdist
 	    mkdir -p deb-build/$${DIST} ; \
 	    tar -C deb-build/$${DIST} -xvf dist/$(NAME)-$(VERSION).tar.gz ; \
 	    cp -a packaging/debian deb-build/$${DIST}/$(NAME)-$(VERSION)/ ; \
-        sed -ie "s|%VERSION%|$(VERSION)|g;s|%RELEASE%|$(DEB_RELEASE)|;s|%DIST%|$${DIST}|g;s|%DATE%|$(DEB_DATE)|g" deb-build/$${DIST}/$(NAME)-$(VERSION)/debian/changelog ; \
+        sed -ie "s|%VERSION%|$(DEB_VERSION)|g;s|%RELEASE%|$(DEB_RELEASE)|;s|%DIST%|$${DIST}|g;s|%DATE%|$(DEB_DATE)|g" deb-build/$${DIST}/$(NAME)-$(VERSION)/debian/changelog ; \
 	done
 
 .PHONY: deb
@@ -286,12 +328,12 @@ deb: deb-src
 	    PBUILDER_OPTS="$(PBUILDER_OPTS) --distribution $${DIST} --basetgz $(PBUILDER_CACHE_DIR)/$${DIST}-$(PBUILDER_ARCH)-base.tgz --buildresult $(CURDIR)/deb-build/$${DIST}" ; \
 	    $(PBUILDER_BIN) create $${PBUILDER_OPTS} --othermirror "deb http://archive.ubuntu.com/ubuntu $${DIST} universe" ; \
 	    $(PBUILDER_BIN) update $${PBUILDER_OPTS} ; \
-	    $(PBUILDER_BIN) build $${PBUILDER_OPTS} deb-build/$${DIST}/$(NAME)_$(VERSION)-$(DEB_RELEASE)~$${DIST}.dsc ; \
+	    $(PBUILDER_BIN) build $${PBUILDER_OPTS} deb-build/$${DIST}/$(NAME)_$(DEB_VERSION)-$(DEB_RELEASE)~$${DIST}.dsc ; \
 	done
 	@echo "#############################################"
 	@echo "Ansible DEB artifacts:"
 	@for DIST in $(DEB_DIST) ; do \
-	    echo deb-build/$${DIST}/$(NAME)_$(VERSION)-$(DEB_RELEASE)~$${DIST}_amd64.changes ; \
+	    echo deb-build/$${DIST}/$(NAME)_$(DEB_VERSION)-$(DEB_RELEASE)~$${DIST}_amd64.changes ; \
 	done
 	@echo "#############################################"
 
@@ -305,7 +347,7 @@ local_deb: debian
 	@echo "#############################################"
 	@echo "Ansible DEB artifacts:"
 	@for DIST in $(DEB_DIST) ; do \
-	    echo deb-build/$${DIST}/$(NAME)_$(VERSION)-$(DEB_RELEASE)~$${DIST}_amd64.changes ; \
+	    echo deb-build/$${DIST}/$(NAME)_$(DEB_VERSION)-$(DEB_RELEASE)~$${DIST}_amd64.changes ; \
 	done
 	@echo "#############################################"
 
@@ -317,39 +359,39 @@ deb-src: debian
 	@echo "#############################################"
 	@echo "Ansible DEB artifacts:"
 	@for DIST in $(DEB_DIST) ; do \
-	    echo deb-build/$${DIST}/$(NAME)_$(VERSION)-$(DEB_RELEASE)~$${DIST}_source.changes ; \
+	    echo deb-build/$${DIST}/$(NAME)_$(DEB_VERSION)-$(DEB_RELEASE)~$${DIST}_source.changes ; \
 	done
 	@echo "#############################################"
 
 .PHONY: deb-upload
 deb-upload: deb
 	@for DIST in $(DEB_DIST) ; do \
-	    $(DPUT_BIN) $(DPUT_OPTS) $(DEB_PPA) deb-build/$${DIST}/$(NAME)_$(VERSION)-$(DEB_RELEASE)~$${DIST}_amd64.changes ; \
+	    $(DPUT_BIN) $(DPUT_OPTS) $(DEB_PPA) deb-build/$${DIST}/$(NAME)_$(DEB_VERSION)-$(DEB_RELEASE)~$${DIST}_amd64.changes ; \
 	done
 
 .PHONY: deb-src-upload
 deb-src-upload: deb-src
 	@for DIST in $(DEB_DIST) ; do \
-	    $(DPUT_BIN) $(DPUT_OPTS) $(DEB_PPA) deb-build/$${DIST}/$(NAME)_$(VERSION)-$(DEB_RELEASE)~$${DIST}_source.changes ; \
+	    $(DPUT_BIN) $(DPUT_OPTS) $(DEB_PPA) deb-build/$${DIST}/$(NAME)_$(DEB_VERSION)-$(DEB_RELEASE)~$${DIST}_source.changes ; \
 	done
 
 .PHONY: epub
 epub:
-	(cd docs/docsite/; CPUS=$(CPUS) make epub)
+	(cd docs/docsite/; CPUS=$(CPUS) $(MAKE) epub)
 
 # for arch or gentoo, read instructions in the appropriate 'packaging' subdirectory directory
 .PHONY: webdocs
 webdocs:
-	(cd docs/docsite/; CPUS=$(CPUS) make docs)
+	(cd docs/docsite/; CPUS=$(CPUS) $(MAKE) docs)
 
-.PHONY: generate_asciidoc
-generate_asciidoc: lib/ansible/cli/*.py
+.PHONY: generate_rst
+generate_rst: lib/ansible/cli/*.py
 	mkdir -p ./docs/man/man1/ ; \
 	PYTHONPATH=./lib $(GENERATE_CLI) --template-file=docs/templates/man.j2 --output-dir=docs/man/man1/ --output-format man lib/ansible/cli/*.py
 
 
-docs: generate_asciidoc
-	make $(MANPAGES)
+docs: generate_rst
+	$(MAKE) $(MANPAGES)
 
 .PHONY: alldocs
 alldocs: docs webdocs

README.md

@@ -1,56 +0,0 @@
-[![PyPI version](https://img.shields.io/pypi/v/ansible.svg)](https://pypi.python.org/pypi/ansible)
-[![Build Status](https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel)](https://app.shippable.com/projects/573f79d02a8192902e20e34b)
-
-
-Ansible
-=======
-
-Ansible is a radically simple IT automation system.  It handles configuration-management, application deployment, cloud provisioning, ad-hoc task-execution, and multinode orchestration - including trivializing things like zero downtime rolling updates with load balancers.
-
-Read the documentation and more at https://ansible.com/
-
-You can find installation instructions [here](https://docs.ansible.com/ansible/intro_installation.html) for a variety of platforms. Most users should probably install a released version of Ansible from `pip`, a package manager or our [release repository](https://releases.ansible.com/ansible/). [Officially supported](https://www.ansible.com/ansible-engine) builds of Ansible are also available. Some power users run directly from the development branch - while significant efforts are made to ensure that `devel` is reasonably stable, you're more likely to encounter breaking changes when running Ansible this way.
-
-Design Principles
-=================
-
-   * Have a dead simple setup process and a minimal learning curve
-   * Manage machines very quickly and in parallel
-   * Avoid custom-agents and additional open ports, be agentless by leveraging the existing SSH daemon
-   * Describe infrastructure in a language that is both machine and human friendly
-   * Focus on security and easy auditability/review/rewriting of content
-   * Manage new remote machines instantly, without bootstrapping any software
-   * Allow module development in any dynamic language, not just Python
-   * Be usable as non-root
-   * Be the easiest IT automation system to use, ever.
-
-Get Involved
-============
-
-   * Read [Community Information](https://docs.ansible.com/community.html) for all kinds of ways to contribute to and interact with the project, including mailing list information and how to submit bug reports and code to Ansible.
-   * All code submissions are done through pull requests.  Take care to make sure no merge commits are in the submission, and use `git rebase` vs `git merge` for this reason.  If submitting a large code change (other than modules), it's probably a good idea to join ansible-devel and talk about what you would like to do or add first and to avoid duplicate efforts.  This not only helps everyone know what's going on, it also helps save time and effort if we decide some changes are needed.
-   * Users list: [ansible-project](https://groups.google.com/group/ansible-project)
-   * Development list: [ansible-devel](https://groups.google.com/group/ansible-devel)
-   * Announcement list: [ansible-announce](https://groups.google.com/group/ansible-announce) - read only
-   * irc.freenode.net: #ansible
-
-Branch Info
-===========
-
-   * Releases are named after Led Zeppelin songs. (Releases prior to 2.0 were named after Van Halen songs.)
-   * The devel branch corresponds to the release actively under development.
-   * Various release-X.Y branches exist for previous releases.
-   * We'd love to have your contributions, read [Community Information](https://docs.ansible.com/community.html) for notes on how to get started.
-
-Authors
-=======
-
-Ansible was created by [Michael DeHaan](https://github.com/mpdehaan) (michael.dehaan/gmail/com) and has contributions from over 1000 users (and growing).  Thanks everyone!
-
-Ansible is sponsored by [Ansible, Inc](https://ansible.com)
-
-License
-=======
-GNU General Public License v3.0
-
-See [COPYING](COPYING) to see the full text.

README.rst

@@ -0,0 +1,123 @@
+|PyPI version| |Docs badge| |Build Status|
+
+*******
+Ansible
+*******
+
+Ansible is a radically simple IT automation system. It handles
+configuration-management, application deployment, cloud provisioning,
+ad-hoc task-execution, and multinode orchestration -- including
+trivializing things like zero-downtime rolling updates with load
+balancers.
+
+Read the documentation and more at https://ansible.com/
+
+You can find installation instructions
+`here <https://docs.ansible.com/intro_getting_started.html>`_ for a
+variety of platforms.
+
+Most users should probably install a released version of Ansible from ``pip``, a package manager or
+our `release repository <https://releases.ansible.com/ansible/>`_. `Officially supported
+<https://www.ansible.com/ansible-engine>`_ builds of Ansible are also available. Some power users
+run directly from the development branch - while significant efforts are made to ensure that
+``devel`` is reasonably stable, you're more likely to encounter breaking changes when running
+Ansible this way.
+
+Design Principles
+=================
+
+*  Have a dead simple setup process and a minimal learning curve
+*  Manage machines very quickly and in parallel
+*  Avoid custom-agents and additional open ports, be agentless by
+   leveraging the existing SSH daemon
+*  Describe infrastructure in a language that is both machine and human
+   friendly
+*  Focus on security and easy auditability/review/rewriting of content
+*  Manage new remote machines instantly, without bootstrapping any
+   software
+*  Allow module development in any dynamic language, not just Python
+*  Be usable as non-root
+*  Be the easiest IT automation system to use, ever.
+
+Get Involved
+============
+
+*  Read `Community
+   Information <https://docs.ansible.com/community.html>`_ for all
+   kinds of ways to contribute to and interact with the project,
+   including mailing list information and how to submit bug reports and
+   code to Ansible.
+*  All code submissions are done through pull requests. Take care to
+   make sure no merge commits are in the submission, and use
+   ``git rebase`` vs ``git merge`` for this reason. If submitting a
+   large code change (other than modules), it's probably a good idea to
+   join ansible-devel and talk about what you would like to do or add
+   first to avoid duplicate efforts. This not only helps everyone
+   know what's going on, it also helps save time and effort if we decide
+   some changes are needed.
+*  Users list:
+   `ansible-project <https://groups.google.com/group/ansible-project>`_
+*  Development list:
+   `ansible-devel <https://groups.google.com/group/ansible-devel>`_
+*  Announcement list:
+   `ansible-announce <https://groups.google.com/group/ansible-announce>`_
+   -- read only
+*  irc.freenode.net: #ansible
+
+Branch Info
+===========
+
+*  Releases are named after Led Zeppelin songs. (Releases prior to 2.0
+   were named after Van Halen songs.)
+*  The devel branch corresponds to the release actively under
+   development.
+*  Various release-X.Y branches exist for previous releases.
+*  We'd love to have your contributions, read `Community
+   Information <https://docs.ansible.com/community.html>`_ for notes on
+   how to get started.
+
+Roadmap
+=======
+
+Based on team and community feedback, an initial roadmap will be published for a major or minor version (ex: 2.0, 2.1).
+Subminor versions will generally not have roadmaps published.
+
+Ansible 2.1 was the first release which published this and asked for feedback in this manner.
+Feedback on the roadmap and the new process is quite welcome.
+The team is aiming for further transparency and better inclusion of both community desires and submissions.
+
+These are the team's *best guess* roadmaps based on the Ansible team's experience and are also based on requests and feedback from the community.
+There are things that may not make it due to time constraints, lack of community maintainers, etc.
+Each roadmap is published both as an idea of what is upcoming in Ansible, and as a medium for seeking further feedback from the community.
+
+There are multiple places for you to submit feedback:
+
+- Add to the agenda of an IRC `Core Team Meeting <https://github.com/ansible/community/blob/master/meetings/README.md>`_ (preferred)
+- Ansible's google-group: ansible-devel
+- AnsibleFest conferences
+- IRC Freenode channel: #ansible-devel (this one may have things lost in lots of conversation)
+
+For additional details consult the published `Ansible Roadmap <https://docs.ansible.com/ansible/devel/roadmap/>`_.
+
+Authors
+=======
+
+Ansible was created by `Michael DeHaan <https://github.com/mpdehaan>`_
+(michael.dehaan/gmail/com) and has contributions from over 1000 users
+(and growing). Thanks everyone!
+
+Ansible is sponsored by `Ansible, Inc <https://ansible.com>`_
+
+License
+=======
+
+GNU General Public License v3.0
+
+See `COPYING <COPYING>`_ to see the full text.
+
+.. |PyPI version| image:: https://img.shields.io/pypi/v/ansible.svg
+   :target: https://pypi.org/project/ansible
+.. |Docs badge| image:: https://img.shields.io/badge/docs-latest-brightgreen.svg
+   :target: https://docs.ansible.com/ansible
+.. |Build Status| image:: https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel
+   :target: https://app.shippable.com/projects/573f79d02a8192902e20e34b

RELEASES.txt

@@ -1,84 +0,0 @@
-Ansible Releases at a Glance
-============================
-
-VERSION  RELEASE     CODE NAME
-++++++++++++++++++++++++++++++
-
-2.4.0    TBD         "Dancing Days"
-2.3.2    2017-08-04  "Ramble On"
-2.3.1    2017-06-01  "Ramble On"
-2.3.0    2017-04-12  "Ramble On"
-2.2.3    2017-05-09  "The Battle of Evermore"
-2.2.2    2017-03-27  "The Battle of Evermore"
-2.2.1    2017-01-16  "The Battle of Evermore"
-2.2.0    2016-11-01  "The Battle of Evermore"
-2.1.6    2017-06-01  "The Song Remains the Same"
-2.1.5    2017-03-27  "The Song Remains the Same"
-2.1.4    2017-01-16  "The Song Remains the Same"
-2.1.3    2016-11-04  "The Song Remains the Same"
-2.1.2    2016-09-29  "The Song Remains the Same"
-2.1.1    2016-07-28  "The Song Remains the Same"
-2.1.0    2016-05-25  "The Song Remains the Same"
-2.0.2    2016-04-19  "Over the Hills and Far Away"
-2.0.1    2016-02-24  "Over the Hills and Far Away"
-2.0.0    2016-01-12  "Over the Hills and Far Away"
-1.9.6    2016-04-15  "Dancing In the Streets"
-1.9.5    2016-03-21  "Dancing In the Streets"
-1.9.4    2015-10-09  "Dancing In the Streets"
-1.9.3    2015-09-03  "Dancing In the Streets"
-1.9.2    2015-06-24  "Dancing In the Streets"
-1.9.1    2015-04-27  "Dancing In the Streets"
-1.9.0    2015-03-25  "Dancing In the Streets"
-1.8.4    2015-02-19  "You Really Got Me"
-1.8.3    2015-02-17  "You Really Got Me"
-1.8.2    2014-12-04  "You Really Got Me"
-1.8.1    2014-11-26  "You Really Got Me"
-1.8.0    2014-11-25  "You Really Got Me"
-1.7.2    2014-09-24  "Summer Nights"
-1.7.1    2014-08-14  "Summer Nights"
-1.7.0    2014-08-06  "Summer Nights"
-1.6.10   2014-07-25  "The Cradle Will Rock"
-1.6.9    2014-07-24  "The Cradle Will Rock"
-1.6.8    2014-07-22  "The Cradle Will Rock"
-1.6.7    2014-07-21  "The Cradle Will Rock"
-1.6.6    2014-07-01  "The Cradle Will Rock"
-1.6.5    2014-06-25  "The Cradle Will Rock"
-1.6.4    2014-06-25  "The Cradle Will Rock"
-1.6.3    2014-06-09  "The Cradle Will Rock"
-1.6.2    2014-05-23  "The Cradle Will Rock"
-1.6.1    2014-05-07  "The Cradle Will Rock"
-1.6.0    2014-05-05  "The Cradle Will Rock"
-1.5.5    2014-04-18  "Love Walks In"
-1.5.4    2014-04-01  "Love Walks In"
-1.5.3    2014-03-13  "Love Walks In"
-1.5.2    2014-03-11  "Love Walks In"
-1.5.1    2014-03-10  "Love Walks In"
-1.5.0    2014-02-28  "Love Walks In"
-1.4.5    2014-02-12  "Could This Be Magic?"
-1.4.4    2014-01-06  "Could This Be Magic?"
-1.4.3    2013-12-20  "Could This Be Magic?"
-1.4.2    2013-12-18  "Could This Be Magic?"
-1.4.1    2013-11-27  "Could This Be Magic?"
-1.4.0    2013-11-21  "Could This Be Magic?"
-1.3.4    2013-10-29  "Top of the World"
-1.3.3    2013-10-09  "Top of the World"
-1.3.2    2013-09-19  "Top of the World"
-1.3.1    2013-09-16  "Top of the World"
-1.3.0    2013-09-13  "Top of the World"
-1.2.3    2013-08-21  "Right Now"
-1.2.2    2013-07-05  "Right Now"
-1.2.1    2013-07-04  "Right Now"
-1.2.0    2013-06-10  "Right Now"
-1.1.0    2013-04-02  "Mean Street"
-1.0.0    2013-02-01  "Eruption"
-0.9.0    2012-11-30  "Dreams"
-0.8.0    2012-10-19  "Cathedral"
-0.7.0    2012-09-06  "Panama"
-0.6.0    2012-08-06  "Cabo"
-0.5.0    2012-07-04  "Amsterdam"
-0.4.0    2012-05-23  "Unchained"
-0.3.0    2012-04-23  "Baluchitherium"
-0.2.0    ?           "Untitled"
-0.1.0    ?           "Untitled"
-0.0.2    ?           "Untitled"
-0.0.1    ?           "Untitled"

ROADMAP.rst

@@ -1,28 +0,0 @@
-*******************************
-Roadmap For Ansible by Red Hat
-*******************************
-This document is now the location for published Ansible Core roadmaps.
-
-The roadmap will be updated by version. Based on team and community feedback, an initial roadmap will be published for a major or minor version (2.0, 2.1).  Subminor versions will generally not have roadmaps published.
-
-2.1 was the first time Ansible has published this and asked for feedback in this manner.  So feedback on the roadmap and the new process is quite welcome.  The team is aiming for further transparency and better inclusion of both community desires and submissions.
-
-These roadmaps are the team's *best guess* roadmaps based on the Ansible team's experience and are also based on requests and feedback from the community.  There are things that may not make it on due to time constraints, lack of community maintainers, etc.  And there may be things that got missed, so each roadmap is published both as an idea of what is upcoming in Ansible, and as a medium for seeking further feedback from the community. Here are the good places for you to submit feedback:
-
-- Add to the agenda of a `Core IRC Meetings <https://github.com/ansible/community/blob/master/meetings/README.md>`_ (preferred)
-- Ansible's google-group: ansible-devel
-- AnsibleFest conferences.
-- IRC freenode channel: #ansible-devel (this one may have things lost in lots of conversation, so a caution).
-
-=======================================
-Current 2.4 Roadmap is open for comment
-=======================================
-We are starting to build the 2.4 Roadmap. We are seeking community feedback! That document is here:
- - `2.4 Roadmap Document <docs/docsite/rst/roadmap/ROADMAP_2_4.rst>`_
-
-
-
-**Old Roadmaps are found here:**
- - `2.3 Roadmap Document <docs/docsite/rst/roadmap/ROADMAP_2_3.rst>`_
- - `2.2 Roadmap Document <docs/docsite/rst/roadmap/ROADMAP_2_2.rst>`_
- - `2.1 Roadmap Document <docs/docsite/rst/roadmap/ROADMAP_2_1.rst>`_

VERSION

@@ -1 +0,0 @@
-2.5.0 0.0.devel

bin/ansible

@@ -41,6 +41,15 @@ from ansible.errors import AnsibleError, AnsibleOptionsError, AnsibleParserError
 from ansible.module_utils._text import to_text
 
 
+# Used for determining if the system is running a new enough python version
+# and should only restrict on our documented minimum versions
+_PY3_MIN = sys.version_info[:2] >= (3, 5)
+_PY2_MIN = (2, 6) <= sys.version_info[:2] < (3,)
+_PY_MIN = _PY3_MIN or _PY2_MIN
+if not _PY_MIN:
+    raise SystemExit('ERROR: Ansible requires a minimum of Python2 version 2.6 or Python3 version 3.5. Current version: %s' % ''.join(sys.version.splitlines()))
+
+
 class LastResort(object):
     # OUTPUT OF LAST RESORT
     def display(self, msg, log_only=None):
@@ -129,17 +138,26 @@ if __name__ == '__main__':
         display.error("User interrupted execution")
         exit_code = 99
     except Exception as e:
+        if C.DEFAULT_DEBUG:
+            # Show raw stacktraces in debug mode, It also allow pdb to
+            # enter post mortem mode.
+            raise
         have_cli_options = cli is not None and cli.options is not None
         display.error("Unexpected Exception, this is probably a bug: %s" % to_text(e), wrap_text=False)
         if not have_cli_options or have_cli_options and cli.options.verbosity > 2:
             log_only = False
+            if hasattr(e, 'orig_exc'):
+                display.vvv('\nexception type: %s' % to_text(type(e.orig_exc)))
+                why = to_text(e.orig_exc)
+                if to_text(e) != why:
+                    display.vvv('\noriginal msg: %s' % why)
         else:
             display.display("to see the full traceback, use -vvv")
             log_only = True
         display.display(u"the full traceback was:\n\n%s" % to_text(traceback.format_exc()), log_only=log_only)
         exit_code = 250
     finally:
-        # Remove ansible tempdir
+        # Remove ansible tmpdir
         shutil.rmtree(C.DEFAULT_LOCAL_TMP, True)
 
     sys.exit(exit_code)

bin/ansible-connection

@@ -1,23 +1,6 @@
 #!/usr/bin/env python
-
-# (c) 2017, Ansible, Inc. <support@ansible.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-########################################################
+# Copyright: (c) 2017, Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 from __future__ import (absolute_import, division, print_function)
 
 __metaclass__ = type
@@ -29,156 +12,155 @@ except Exception:
     pass
 
 import fcntl
+import hashlib
 import os
-import shlex
 import signal
 import socket
 import sys
-import time
 import traceback
-import datetime
 import errno
+import json
+
+from contextlib import contextmanager
 
 from ansible import constants as C
 from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.module_utils.six import PY3
-from ansible.module_utils.six.moves import cPickle
-from ansible.module_utils.connection import send_data, recv_data
+from ansible.module_utils.six.moves import cPickle, StringIO
+from ansible.module_utils.connection import Connection, ConnectionError, send_data, recv_data
+from ansible.module_utils.service import fork_process
 from ansible.playbook.play_context import PlayContext
 from ansible.plugins.loader import connection_loader
 from ansible.utils.path import unfrackpath, makedirs_safe
-from ansible.errors import AnsibleConnectionFailure
 from ansible.utils.display import Display
+from ansible.utils.jsonrpc import JsonRpcServer
 
 
-def do_fork():
+def read_stream(byte_stream):
+    size = int(byte_stream.readline().strip())
+
+    data = byte_stream.read(size)
+    if len(data) < size:
+        raise Exception("EOF found before data was complete")
+
+    data_hash = to_text(byte_stream.readline().strip())
+    if data_hash != hashlib.sha1(data).hexdigest():
+        raise Exception("Read {0} bytes, but data did not match checksum".format(size))
+
+    # restore escaped loose \r characters
+    data = data.replace(br'\r', b'\r')
+
+    return data
+
+
+@contextmanager
+def file_lock(lock_path):
+    """
+    Uses contextmanager to create and release a file lock based on the
+    given path. This allows us to create locks using `with file_lock()`
+    to prevent deadlocks related to failure to unlock properly.
+    """
+
+    lock_fd = os.open(lock_path, os.O_RDWR | os.O_CREAT, 0o600)
+    fcntl.lockf(lock_fd, fcntl.LOCK_EX)
+    yield
+    fcntl.lockf(lock_fd, fcntl.LOCK_UN)
+    os.close(lock_fd)
+
+
+class ConnectionProcess(object):
     '''
-    Does the required double fork for a daemon process. Based on
-    http://code.activestate.com/recipes/66012-fork-a-daemon-process-on-unix/
+    The connection process wraps around a Connection object that manages
+    the connection to a remote device that persists over the playbook
     '''
-    try:
-        pid = os.fork()
-        if pid > 0:
-            return pid
-        # This is done as a 'good practice' for daemons, but we need to keep the cwd
-        # leaving it here as a note that we KNOW its good practice but are not doing it on purpose.
-        # os.chdir("/")
-        os.setsid()
-        os.umask(0)
-
-        try:
-            pid = os.fork()
-            if pid > 0:
-                sys.exit(0)
-
-            if C.DEFAULT_LOG_PATH != '':
-                out_file = open(C.DEFAULT_LOG_PATH, 'ab+')
-                err_file = open(C.DEFAULT_LOG_PATH, 'ab+', 0)
-            else:
-                out_file = open('/dev/null', 'ab+')
-                err_file = open('/dev/null', 'ab+', 0)
-
-            os.dup2(out_file.fileno(), sys.stdout.fileno())
-            os.dup2(err_file.fileno(), sys.stderr.fileno())
-            os.close(sys.stdin.fileno())
-
-            return pid
-        except OSError as e:
-            sys.exit(1)
-    except OSError as e:
-        sys.exit(1)
-
-
-class Server():
-
-    def __init__(self, socket_path, play_context):
-        self.socket_path = socket_path
+    def __init__(self, fd, play_context, socket_path, original_path, ansible_playbook_pid=None):
         self.play_context = play_context
+        self.socket_path = socket_path
+        self.original_path = original_path
 
-        display.display(
-            'creating new control socket for host %s:%s as user %s' %
-            (play_context.remote_addr, play_context.port, play_context.remote_user),
-            log_only=True
-        )
+        self.fd = fd
+        self.exception = None
 
-        display.display('control socket path is %s' % socket_path, log_only=True)
-        display.display('current working directory is %s' % os.getcwd(), log_only=True)
+        self.srv = JsonRpcServer()
+        self.sock = None
 
-        self._start_time = datetime.datetime.now()
+        self.connection = None
+        self._ansible_playbook_pid = ansible_playbook_pid
 
-        display.display("using connection plugin %s" % self.play_context.connection, log_only=True)
+    def start(self, variables):
+        try:
+            messages = list()
+            result = {}
 
-        self.connection = connection_loader.get(play_context.connection, play_context, sys.stdin)
-        self.connection._connect()
+            messages.append('control socket path is %s' % self.socket_path)
 
-        if not self.connection.connected:
-            raise AnsibleConnectionFailure('unable to connect to remote host %s' % self._play_context.remote_addr)
+            # If this is a relative path (~ gets expanded later) then plug the
+            # key's path on to the directory we originally came from, so we can
+            # find it now that our cwd is /
+            if self.play_context.private_key_file and self.play_context.private_key_file[0] not in '~/':
+                self.play_context.private_key_file = os.path.join(self.original_path, self.play_context.private_key_file)
+            self.connection = connection_loader.get(self.play_context.connection, self.play_context, '/dev/null',
+                                                    ansible_playbook_pid=self._ansible_playbook_pid)
+            self.connection.set_options(var_options=variables)
+            self.connection._connect()
+            self.connection._socket_path = self.socket_path
+            self.srv.register(self.connection)
+            messages.extend(sys.stdout.getvalue().splitlines())
+            messages.append('connection to remote device started successfully')
 
-        connection_time = datetime.datetime.now() - self._start_time
-        display.display('connection established to %s in %s' % (play_context.remote_addr, connection_time), log_only=True)
-
-        self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
-        self.socket.bind(self.socket_path)
-        self.socket.listen(1)
-        display.display('local socket is set to listening', log_only=True)
+            self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
+            self.sock.bind(self.socket_path)
+            self.sock.listen(1)
+            messages.append('local domain socket listeners started successfully')
+        except Exception as exc:
+            result['error'] = to_text(exc)
+            result['exception'] = traceback.format_exc()
+        finally:
+            result['messages'] = messages
+            self.fd.write(json.dumps(result))
+            self.fd.close()
 
     def run(self):
         try:
-            while True:
+            while self.connection.connected:
                 signal.signal(signal.SIGALRM, self.connect_timeout)
                 signal.signal(signal.SIGTERM, self.handler)
-                signal.alarm(C.PERSISTENT_CONNECT_TIMEOUT)
+                signal.alarm(self.connection.get_option('persistent_connect_timeout'))
 
-                (s, addr) = self.socket.accept()
-                display.display('incoming request accepted on persistent socket', log_only=True)
+                self.exception = None
+                (s, addr) = self.sock.accept()
                 signal.alarm(0)
 
+                signal.signal(signal.SIGALRM, self.command_timeout)
                 while True:
                     data = recv_data(s)
                     if not data:
                         break
 
-                    signal.signal(signal.SIGALRM, self.command_timeout)
-                    signal.alarm(self.play_context.timeout)
-
-                    op = to_text(data.split(b':')[0])
-                    display.display('socket operation is %s' % op, log_only=True)
-
-                    method = getattr(self, 'do_%s' % op, None)
-
-                    rc = 255
-                    stdout = stderr = ''
-
-                    if not method:
-                        stderr = 'Invalid action specified'
-                    else:
-                        rc, stdout, stderr = method(data)
-
+                    signal.alarm(self.connection._play_context.timeout)
+                    resp = self.srv.handle_request(data)
                     signal.alarm(0)
 
-                    display.display('socket operation completed with rc %s' % rc, log_only=True)
-
-                    send_data(s, to_bytes(rc))
-                    send_data(s, to_bytes(stdout))
-                    send_data(s, to_bytes(stderr))
+                    send_data(s, to_bytes(resp))
 
                 s.close()
 
         except Exception as e:
             # socket.accept() will raise EINTR if the socket.close() is called
-            if e.errno != errno.EINTR:
-                display.display(traceback.format_exc(), log_only=True)
+            if hasattr(e, 'errno'):
+                if e.errno != errno.EINTR:
+                    self.exception = traceback.format_exc()
+            else:
+                self.exception = traceback.format_exc()
 
         finally:
             # when done, close the connection properly and cleanup
             # the socket file so it can be recreated
             self.shutdown()
-            end_time = datetime.datetime.now()
-            delta = end_time - self._start_time
-            display.display('shutdown local socket, connection was active for %s secs' % delta, log_only=True)
 
     def connect_timeout(self, signum, frame):
-        display.display('persistent connection idle timeout triggered, timeout value is %s secs' % C.PERSISTENT_CONNECT_TIMEOUT, log_only=True)
+        display.display('persistent connection idle timeout triggered, timeout value is %s secs'
+                        % self.connection.get_option('persistent_connect_timeout'), log_only=True)
         self.shutdown()
 
     def command_timeout(self, signum, frame):
@@ -190,200 +172,141 @@ class Server():
         self.shutdown()
 
     def shutdown(self):
-        display.display('shutdown persistent connection requested', log_only=True)
-
-        if not os.path.exists(self.socket_path):
-            display.display('persistent connection is not active', log_only=True)
-            return
-
-        try:
-            if self.socket:
-                display.display('closing local listener', log_only=True)
-                self.socket.close()
-            if self.connection:
-                display.display('closing the connection', log_only=True)
-                self.connection.close()
-        except:
-            pass
-        finally:
-            if os.path.exists(self.socket_path):
-                display.display('removing the local control socket', log_only=True)
-                os.remove(self.socket_path)
-
+        """ Shuts down the local domain socket
+        """
+        if os.path.exists(self.socket_path):
+            try:
+                if self.sock:
+                    self.sock.close()
+                if self.connection:
+                    self.connection.close()
+            except:
+                pass
+            finally:
+                if os.path.exists(self.socket_path):
+                    os.remove(self.socket_path)
+                    setattr(self.connection, '_socket_path', None)
+                    setattr(self.connection, '_connected', False)
         display.display('shutdown complete', log_only=True)
 
-    def do_EXEC(self, data):
-        cmd = data.split(b'EXEC: ')[1]
-        display.display('Command executed: %s' % cmd, log_only=True)
-        return self.connection.exec_command(cmd)
-
-    def do_PUT(self, data):
-        (op, src, dst) = shlex.split(to_native(data))
-        return self.connection.fetch_file(src, dst)
-
-    def do_FETCH(self, data):
-        (op, src, dst) = shlex.split(to_native(data))
-        return self.connection.put_file(src, dst)
-
-    def do_CONTEXT(self, data):
-        pc_data = data.split(b'CONTEXT: ', 1)[1]
-
-        if PY3:
-            pc_data = cPickle.loads(pc_data, encoding='bytes')
-        else:
-            pc_data = cPickle.loads(pc_data)
-
-        pc = PlayContext()
-        pc.deserialize(pc_data)
-
-        try:
-            self.connection.update_play_context(pc)
-        except AttributeError:
-            pass
-
-        return (0, 'ok', '')
-
-    def do_RUN(self, data):
-        timeout = self.play_context.timeout
-        while bool(timeout):
-            if os.path.exists(self.socket_path):
-                break
-            time.sleep(1)
-            timeout -= 1
-        socket_bytes = to_bytes(self.socket_path, errors='surrogate_or_strict')
-        return 0, b'\n#SOCKET_PATH#: %s\n' % socket_bytes, ''
-
-
-def communicate(sock, data):
-    send_data(sock, data)
-    rc = int(recv_data(sock), 10)
-    stdout = recv_data(sock)
-    stderr = recv_data(sock)
-    return (rc, stdout, stderr)
-
 
 def main():
+    """ Called to initiate the connect to the remote device
+    """
+    rc = 0
+    result = {}
+    messages = list()
+    socket_path = None
+
     # Need stdin as a byte stream
     if PY3:
         stdin = sys.stdin.buffer
     else:
         stdin = sys.stdin
 
+    # Note: update the below log capture code after Display.display() is refactored.
+    saved_stdout = sys.stdout
+    sys.stdout = StringIO()
+
     try:
         # read the play context data via stdin, which means depickling it
-        # FIXME: as noted above, we will probably need to deserialize the
-        #        connection loader here as well at some point, otherwise this
-        #        won't find role- or playbook-based connection plugins
-        cur_line = stdin.readline()
-        init_data = b''
-        while cur_line.strip() != b'#END_INIT#':
-            if cur_line == b'':
-                raise Exception("EOF found before init data was complete")
-            init_data += cur_line
-            cur_line = stdin.readline()
+        vars_data = read_stream(stdin)
+        init_data = read_stream(stdin)
+
         if PY3:
             pc_data = cPickle.loads(init_data, encoding='bytes')
+            variables = cPickle.loads(vars_data, encoding='bytes')
         else:
             pc_data = cPickle.loads(init_data)
+            variables = cPickle.loads(vars_data)
 
-        pc = PlayContext()
-        pc.deserialize(pc_data)
+        play_context = PlayContext()
+        play_context.deserialize(pc_data)
+        display.verbosity = play_context.verbosity
 
     except Exception as e:
-        # FIXME: better error message/handling/logging
-        sys.stderr.write(traceback.format_exc())
-        sys.exit("FAIL: %s" % e)
+        rc = 1
+        result.update({
+            'error': to_text(e),
+            'exception': traceback.format_exc()
+        })
 
-    ssh = connection_loader.get('ssh', class_only=True)
-    cp = ssh._create_control_path(pc.remote_addr, pc.port, pc.remote_user, pc.connection)
+    if rc == 0:
+        ssh = connection_loader.get('ssh', class_only=True)
+        ansible_playbook_pid = sys.argv[1]
+        cp = ssh._create_control_path(play_context.remote_addr, play_context.port, play_context.remote_user, play_context.connection, ansible_playbook_pid)
 
-    # create the persistent connection dir if need be and create the paths
-    # which we will be using later
-    tmp_path = unfrackpath(C.PERSISTENT_CONTROL_PATH_DIR)
-    makedirs_safe(tmp_path)
-    lock_path = unfrackpath("%s/.ansible_pc_lock" % tmp_path)
-    socket_path = unfrackpath(cp % dict(directory=tmp_path))
+        # create the persistent connection dir if need be and create the paths
+        # which we will be using later
+        tmp_path = unfrackpath(C.PERSISTENT_CONTROL_PATH_DIR)
+        makedirs_safe(tmp_path)
 
-    # if the socket file doesn't exist, spin up the daemon process
-    lock_fd = os.open(lock_path, os.O_RDWR | os.O_CREAT, 0o600)
-    fcntl.lockf(lock_fd, fcntl.LOCK_EX)
+        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % (tmp_path, play_context.remote_addr))
+        socket_path = unfrackpath(cp % dict(directory=tmp_path))
 
-    if not os.path.exists(socket_path):
-        pid = do_fork()
-        if pid == 0:
-            rc = 0
-            try:
-                server = Server(socket_path, pc)
-            except AnsibleConnectionFailure as exc:
-                display.display('connecting to host %s returned an error' % pc.remote_addr, log_only=True)
-                display.display(str(exc), log_only=True)
-                rc = 1
-            except Exception as exc:
-                display.display('failed to create control socket for host %s' % pc.remote_addr, log_only=True)
-                display.display(traceback.format_exc(), log_only=True)
-                rc = 1
-            fcntl.lockf(lock_fd, fcntl.LOCK_UN)
-            os.close(lock_fd)
-            if rc == 0:
-                server.run()
-            sys.exit(rc)
+        with file_lock(lock_path):
+            if not os.path.exists(socket_path):
+                messages.append('local domain socket does not exist, starting it')
+                original_path = os.getcwd()
+                r, w = os.pipe()
+                pid = fork_process()
+
+                if pid == 0:
+                    try:
+                        os.close(r)
+                        wfd = os.fdopen(w, 'w')
+                        process = ConnectionProcess(wfd, play_context, socket_path, original_path, ansible_playbook_pid)
+                        process.start(variables)
+                    except Exception:
+                        messages.append(traceback.format_exc())
+                        rc = 1
+
+                    if rc == 0:
+                        process.run()
+
+                    sys.exit(rc)
+
+                else:
+                    os.close(w)
+                    rfd = os.fdopen(r, 'r')
+                    data = json.loads(rfd.read())
+                    messages.extend(data.pop('messages'))
+                    result.update(data)
+
+            else:
+                messages.append('found existing local domain socket, using it!')
+                conn = Connection(socket_path)
+                pc_data = to_text(init_data)
+                try:
+                    messages.extend(conn.update_play_context(pc_data))
+                except Exception as exc:
+                    # Only network_cli has update_play context, so missing this is
+                    # not fatal e.g. netconf
+                    if isinstance(exc, ConnectionError) and getattr(exc, 'code', None) == -32601:
+                        pass
+                    else:
+                        result.update({
+                            'error': to_text(exc),
+                            'exception': traceback.format_exc()
+                        })
+
+    messages.append(sys.stdout.getvalue())
+    result.update({
+        'messages': messages,
+        'socket_path': socket_path
+    })
+
+    sys.stdout = saved_stdout
+    if 'exception' in result:
+        rc = 1
+        sys.stderr.write(json.dumps(result))
     else:
-        display.display('re-using existing socket for %s@%s:%s' % (pc.remote_user, pc.remote_addr, pc.port), log_only=True)
-
-    fcntl.lockf(lock_fd, fcntl.LOCK_UN)
-    os.close(lock_fd)
-
-    timeout = pc.timeout
-    while bool(timeout):
-        if os.path.exists(socket_path):
-            display.vvvv('connected to local socket in %s' % (pc.timeout - timeout), pc.remote_addr)
-            break
-        time.sleep(1)
-        timeout -= 1
-    else:
-        raise AnsibleConnectionFailure('timeout waiting for local socket', pc.remote_addr)
-
-    # now connect to the daemon process
-    # FIXME: if the socket file existed but the daemonized process was killed,
-    #        the connection will timeout here. Need to make this more resilient.
-    while True:
-        data = stdin.readline()
-        if data == b'':
-            break
-        if data.strip() == b'':
-            continue
-
-        sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
-
-        connect_retry_timeout = C.PERSISTENT_CONNECT_RETRY_TIMEOUT
-        while bool(connect_retry_timeout):
-            try:
-                sock.connect(socket_path)
-                break
-            except socket.error:
-                time.sleep(1)
-                connect_retry_timeout -= 1
-        else:
-            display.display('connect retry timeout expired, unable to connect to control socket', pc.remote_addr, pc.remote_user, log_only=True)
-            display.display('persistent_connect_retry_timeout is %s secs' % (C.PERSISTENT_CONNECT_RETRY_TIMEOUT), pc.remote_addr, pc.remote_user, log_only=True)
-            sys.stderr.write('failed to connect to control socket')
-            sys.exit(255)
-
-        # send the play_context back into the connection so the connection
-        # can handle any privilege escalation activities
-        pc_data = b'CONTEXT: %s' % init_data
-        communicate(sock, pc_data)
-
-        rc, stdout, stderr = communicate(sock, data.strip())
-
-        sys.stdout.write(to_native(stdout))
-        sys.stderr.write(to_native(stderr))
-
-        sock.close()
-        break
+        rc = 0
+        sys.stdout.write(json.dumps(result))
 
     sys.exit(rc)
 
+
 if __name__ == '__main__':
     display = Display()
     main()

changelogs/.changes.yaml

@@ -0,0 +1,414 @@
+releases:
+  2.6.0:
+    codename: Heartbreaker
+    fragments:
+    - v2.6.0_summary.yaml
+    release_date: '2018-06-28'
+  2.6.0a1:
+    codename: Heartbreaker
+    fragments:
+    - ansible-managed-encoding.yaml
+    - azure-lb-sku.yaml
+    - base64_filter_encoding.yaml
+    - command-support-argv.yaml
+    - copy-files-default-follow.yaml
+    - copy-no-chmod.yaml
+    - copy-recursive-copy.yml
+    - encoding-docs-plugin-parsing.yaml
+    - file-disallow-src.yaml
+    - file-nonexistent-link.yaml
+    - file-nonexitent-link-recurse.yaml
+    - file-succeed-if-already-absent.yaml
+    - gem-custom-home.yaml
+    - grafana-deprecation-warnings.yaml
+    - includes.yaml
+    - mode-preserve.yaml
+    - pause-ctrl-c.yaml
+    - postgresql_user-encrypted-fixes.yml
+    - py36-spwd.yaml
+    - template-filename-encoding.yaml
+    - user-expires.yaml
+    - v2.6.0a1_catchup.yaml
+    - v2.6.0a1_summary.yaml
+    - win_environment-do-not-delete-on-null.yaml
+    - win_file-special-char-fix.yaml
+    - win_get_url-ftp-support.yaml
+    - win_module_utils_sid-conversion.yaml
+    - win_template-dest-dir-fix.yaml
+    - win_updates_typo_whitelist_fix.yaml
+    - window_become-better-errors.yaml
+    - windows-deprecation-removal.yaml
+    - winrm-encoding-fix
+    - winrm-get_correct_user.yaml
+    - yaml-callback-unicode.yaml
+    modules:
+    - aci_l3out
+    - avi_autoscalelaunchconfig
+    - avi_l4policyset
+    - avi_useraccount
+    - aws_caller_facts
+    - aws_inspector_target
+    - aws_ses_identity_policy
+    - aws_sgw_facts
+    - azure_rm_aks
+    - azure_rm_aks_facts
+    - bigip_data_group
+    - bigip_device_license
+    - bigip_gtm_global
+    - bigip_gtm_monitor_bigip
+    - bigip_gtm_monitor_firepass
+    - bigip_gtm_monitor_http
+    - bigip_gtm_monitor_https
+    - bigip_gtm_monitor_tcp
+    - bigip_gtm_monitor_tcp_half_open
+    - bigip_gtm_pool_member
+    - bigip_gtm_virtual_server
+    - bigip_log_destination
+    - bigip_log_publisher
+    - bigip_management_route
+    - bigip_profile_dns
+    - bigip_profile_tcp
+    - bigip_profile_udp
+    - bigip_service_policy
+    - bigip_smtp
+    - bigip_snmp_community
+    - bigip_timer_policy
+    - bigip_trunk
+    - bigiq_application_fasthttp
+    - bigiq_application_fastl4_tcp
+    - bigiq_application_fastl4_udp
+    - bigiq_application_http
+    - bigiq_application_https_offload
+    - bigiq_application_https_waf
+    - bigiq_regkey_license_assignment
+    - cnos_command
+    - cnos_config
+    - cs_role_permission
+    - digital_ocean_account_facts
+    - digital_ocean_certificate_facts
+    - digital_ocean_domain_facts
+    - digital_ocean_image_facts
+    - digital_ocean_load_balancer_facts
+    - digital_ocean_region_facts
+    - digital_ocean_size_facts
+    - digital_ocean_snapshot_facts
+    - digital_ocean_tag_facts
+    - digital_ocean_volume_facts
+    - ec2_eip_facts
+    - ec2_vpc_vpn_facts
+    - exos_command
+    - fortios_webfilter
+    - gcp_compute_address
+    - gcp_compute_backend_bucket
+    - gcp_compute_backend_service
+    - gcp_compute_health_check
+    - gcp_compute_http_health_check
+    - gcp_compute_https_health_check
+    - gcp_compute_instance
+    - gcp_compute_instance_template
+    - gcp_compute_network
+    - gcp_compute_route
+    - gcp_compute_subnetwork
+    - gcp_compute_target_http_proxy
+    - gcp_compute_target_https_proxy
+    - gcp_compute_target_tcp_proxy
+    - gcp_container_cluster
+    - gcp_container_node_pool
+    - gcp_dns_resource_record_set
+    - gcp_pubsub_subscription
+    - gcp_pubsub_topic
+    - gcp_storage_bucket
+    - gcp_storage_bucket_access_control
+    - gitlab_deploy_key
+    - gitlab_hooks
+    - k8s
+    - ldap_passwd
+    - memset_zone
+    - meraki_network
+    - meraki_organization
+    - na_ontap_broadcast_domain
+    - net_get
+    - net_put
+    - netconf_get
+    - one_host
+    - one_image
+    - one_image_facts
+    - one_vm
+    - os_server_metadata
+    - os_volume_snapshot
+    - psexec
+    - purefa_ds
+    - purefa_facts
+    - purefa_pgsnap
+    - purefb_fs
+    - purefb_snap
+    - rds_instance_facts
+    - rds_snapshot_facts
+    - scaleway_compute
+    - scaleway_sshkey
+    - slxos_command
+    - slxos_config
+    - slxos_facts
+    - slxos_interface
+    - slxos_l2_interface
+    - slxos_linkagg
+    - spectrum_device
+    - sysvinit
+    - vmware_cluster_facts
+    - vmware_datastore_cluster
+    - vmware_datastore_maintenancemode
+    - vmware_guest_disk_facts
+    - vmware_guest_snapshot_facts
+    - vmware_host_capability_facts
+    - vmware_host_powerstate
+    - vmware_local_user_facts
+    - vmware_portgroup_facts
+    - vmware_resource_pool_facts
+    - vmware_tag
+    - vmware_tag_facts
+    - vmware_vswitch_facts
+    - win_domain_computer
+    - win_hostname
+    - win_pester
+    - yarn
+    - zabbix_group_facts
+    plugins:
+      callback:
+      - cgroup_memory_recap
+      - grafana_annotations
+      - sumologic
+      connection:
+      - httpapi
+      inventory:
+      - foreman
+      - generator
+      - nmap
+      lookup:
+      - onepassword
+      - onepassword_raw
+    release_date: '2018-05-21'
+  2.6.0a2:
+    codename: Heartbreaker
+    fragments:
+    - always_run_removal.yaml
+    - aws_ses_identity_check_mode.yaml
+    - powershell_use_set_tmpdir.yaml
+    - selinux-check-mode.yaml
+    - synchronize_remote_is_local.yaml
+    - v2.6.0a2_catchup.yaml
+    - v2.6.0a2_summary.yaml
+    - win_updates-add-scheduled-tasks-back.yaml
+    - winrm_kinit_error-fix.yaml
+    - xenserver-facts-fix.yaml
+    modules:
+    - acme_account
+    - aws_config_aggregation_authorization
+    - aws_config_aggregator
+    - aws_config_delivery_channel
+    - aws_config_recorder
+    - aws_config_rule
+    - aws_glue_connection
+    - aws_glue_job
+    - azure_rm_resource
+    - azure_rm_resource_facts
+    - bigip_gtm_monitor_external
+    - bigip_monitor_external
+    - bigiq_utility_license
+    - cloud_init_data_facts
+    - elb_network_lb
+    - flatpak
+    - flatpak_remote
+    - gcp_compute_disk
+    - gcp_compute_firewall
+    - gcp_compute_forwarding_rule
+    - gcp_compute_global_address
+    - gcp_compute_global_forwarding_rule
+    - gcp_compute_image
+    - gcp_compute_instance_group
+    - gcp_compute_instance_group_manager
+    - gcp_compute_ssl_certificate
+    - gcp_compute_target_pool
+    - gcp_compute_target_ssl_proxy
+    - gcp_compute_url_map
+    - gluster_peer
+    - heroku_collaborator
+    - memset_dns_reload
+    - memset_zone_domain
+    - memset_zone_record
+    - meraki_admin
+    - meraki_snmp
+    - na_ontap_aggregate
+    - na_ontap_broadcast_domain_ports
+    - na_ontap_cifs
+    - na_ontap_cifs_acl
+    - na_ontap_cifs_server
+    - na_ontap_cluster
+    - na_ontap_cluster_ha
+    - na_ontap_export_policy
+    - na_ontap_export_policy_rule
+    - na_ontap_igroup
+    - na_ontap_interface
+    - na_ontap_iscsi
+    - na_ontap_job_schedule
+    - na_ontap_license
+    - na_ontap_lun
+    - na_ontap_lun_map
+    - na_ontap_net_ifgrp
+    - na_ontap_net_port
+    - na_ontap_net_routes
+    - na_ontap_net_vlan
+    - na_ontap_nfs
+    - na_ontap_ntp
+    - na_ontap_qtree
+    - na_ontap_service_processor_network
+    - na_ontap_snapshot
+    - na_ontap_snmp
+    - na_ontap_svm
+    - na_ontap_ucadapter
+    - na_ontap_user
+    - na_ontap_user_role
+    - na_ontap_volume
+    - na_ontap_volume_clone
+    - netconf_rpc
+    - one_service
+    - slxos_l3_interface
+    - slxos_vlan
+    plugins:
+      inventory:
+      - gcp_compute
+    release_date: '2018-05-30'
+  2.6.0rc1:
+    codename: Heartbreaker
+    fragments:
+    - v2.6.0rc1_catchup.yaml
+    - v2.6.0rc1_summary.yaml
+    release_date: '2018-06-05'
+  2.6.0rc2:
+    codename: Heartbreaker
+    fragments:
+    - 41167_ansible_doc_regression.yaml
+    - admin-users-default-change.yaml
+    - aws_s3_async_fix.yaml
+    - aws_s3_decryption_fix.yaml
+    - aws_s3_fix_custom_endpoints.yaml
+    - aws_s3_fix_exception_handling.yaml
+    - ec2_ami_fix_block_device_mapping_volume_size_type.yaml
+    - v2.6.0rc2_summary.yaml
+    release_date: '2018-06-08'
+  2.6.0rc3:
+    codename: Heartbreaker
+    fragments:
+    - digital_ocean_block_storage_fix.yaml
+    - gce-sort-fix.yaml
+    - iosxr_config_route_policy_objects_fix.yaml
+    - no_log_fix_for_connection_exceptions.yaml
+    - reset_con_fix.yml
+    - v2.6.0rc3_summary.yaml
+    release_date: '2018-06-18'
+  2.6.0rc4:
+    codename: Heartbreaker
+    fragments:
+    - 41530-apt-mark-deb6.yaml
+    - debug_fixes.yml
+    - eos_vrf_failure-fix.yml
+    - file_touch_diff.yaml
+    - fix_config_required.yml
+    - fix_yaml_inv_nulls.yml
+    - missing_raise.yml
+    - v2.6.0rc4_summary.yaml
+    - vars_lk.yml
+    - virtualbox_inventory.yaml
+    - win_updates-async-fix.yml
+    - winrm_kinit-remove-pass-log.yml
+    release_date: '2018-06-25'
+  2.6.0rc5:
+    codename: Heartbreaker
+    fragments:
+    - fix_options.yml
+    - fix_password_lookup_loading.yaml
+    - group_by_localhost.yaml
+    - lineinfile-insertbefore-bof-bugfix.yaml
+    - v2.6.0rc5_summary.yaml
+    - win_iis_webapppool-output-fix.yml
+    release_date: '2018-06-26'
+  2.6.1:
+    codename: Heartbreaker
+    fragments:
+    - avoid_cwd_vars.yml
+    - basic_booleans_backward_compat.yaml
+    - file_touch_check_mode.yaml
+    - inventory_manager_fix_required_options_override.yaml
+    - junos_config_confirm_commit.yaml
+    - nsupdate_fix_hmac-sha384.yaml
+    - v2.6.1_summary.yaml
+    - win_domain-dns-typo-fix.yml
+    - win_group_membership-sid-bugfix.yml
+    - wrcwd_ansible.cfg.yml
+    release_date: '2018-07-05'
+  2.6.2:
+    codename: Heartbreaker
+    fragments:
+    - 40839-docker_container_init.yml
+    - 42042-inventory_with_no_region.yaml
+    - 42647-win_updates.yaml
+    - clarify_error_message.yml
+    - doc_fix.yml
+    - docfix.yml
+    - docker-default-ssl.yml
+    - empty_gh_error.yaml
+    - ensure_text_source.yaml
+    - eos_l2_interface_fix.yaml
+    - fix_fact_clean.yaml
+    - fix_ios_vlan.yaml
+    - fix_pagination_cloudfront_facts.yml
+    - fix_sysvinit_typo.yml
+    - fix_tls_mail.yaml
+    - inventory_dir_ext_compare_fix.yaml
+    - ios_l2_interface-fix.yml
+    - junos_facts_fix.yaml
+    - lineinfile-empty-regexp.yml
+    - nxos_CI_failures_fix.yaml
+    - nxos_cliconf.yaml
+    - nxos_facts.yaml
+    - nxos_module_utils_nxapi_get_capabilities.yaml
+    - nxos_nxapi_default_http_behavior_fix.yaml
+    - nxos_vxlan_vtep_vni_fix.yaml
+    - openvswitch_db_make_key_optional.yaml
+    - pause-stdout-redirection.yaml
+    - pause-try-except-curses.yaml
+    - preserve_delegate_nolog.yml
+    - remote_tmp_de-escalated_user.yaml
+    - sysvinit_bugxif.yml
+    - user-freebsd-createhome-name-fix.yaml
+    - user_freebsd_always_changed_bugfix.yaml
+    - v2.6.2_summary.yaml
+    - vmware_remove_vm_sceanrio.yaml
+    - vultr-parameters-parsing.yaml
+    - vyos_command_retry.yml
+    - win_chocoalatey_install_tls12.yml
+    - win_reboot-fixes.yml
+    - win_security_policy-empty-value.yaml
+    - win_unzip_share-discard-cmdlet-output.yaml
+    - win_user-validate-fixes.yaml
+    release_date: '2018-07-27'
+  2.6.3:
+    codename: Heartbreaker
+    fragments:
+    - 42786-sysvinit-fix-2-issues.yml
+    - 42943_vmware_vmnic_fix.yaml
+    - azure_nsg_deployment_lb.yaml
+    - convert-valid-data-to-bytes-for-conversion.yaml
+    - fix-selectors-error-condition.yaml
+    - fix-swap-mount-module.yaml
+    - fix-world-readable-skip-message.yaml
+    - get_url_bug_fix.yaml
+    - lxd-idempotent-config.yaml
+    - nicer_multi_error.yml
+    - nios_api_duplicate_record-fix.yaml
+    - openstack_inventory-optional-region.yaml
+    - openvswitch_db_column_value_type.yaml
+    - slack_callback_invocation.yaml
+    - v2.6.3_summary.yaml
+    - vars_prompt-allow-prompting-for-play-vars.yaml
+    - win_domain_controller-netlogon.yaml
+    release_date: '2018-08-16'

changelogs/CHANGELOG-v2.6.rst

@@ -0,0 +1,644 @@
+========================================
+Ansible 2.6 "Heartbreaker" Release Notes
+========================================
+
+v2.6.3
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-08-16
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Bugfixes
+--------
+
+- Fix lxd module to be idempotent when the given configuration for the lxd container has not changed (https://github.com/ansible/ansible/pull/38166)
+- Fix setting value type to str to avoid conversion during template read. Fix Idempotency in case of 'no key'.
+- Fix the mount module's handling of swap entries in fstab (https://github.com/ansible/ansible/pull/42837)
+- The fix for `CVE-2018-10875 <https://access.redhat.com/security/cve/cve-2018-10875>`_ prints out a warning message about skipping a config file from a world writable current working directory.  However, if the user explicitly specifies that the config file should be used via the ANSIBLE_CONFIG environment variable then Ansible would honor that but still print out the warning message.  This has been fixed so that Ansible honors the user's explicit wishes and does not print a warning message in that circumstance.
+- To fix the bug where existing host_record was deleted when existing record name is used with different IP. (https://github.com/ansible/ansible/pull/43235)
+- VMware handle pnic in proxyswitch (https://github.com/ansible/ansible/pull/42996)
+- fix azure security group cannot add rules when purge_rule set to false. (https://github.com/ansible/ansible/pull/43699)
+- fix azure_rm_deployment collect tags from existing Resource Group. (https://github.com/ansible/ansible/pull/26104)
+- fix azure_rm_loadbalancer_facts list takes at least 2 arguments. (https://github.com/ansible/ansible/pull/29050)
+- fix for the bundled selectors module (used in the ssh and local connection plugins) when a syscall is restarted after being interrupted by a signal (https://github.com/ansible/ansible/issues/41630)
+- get_url - fix the bug that get_url does not change mode when checksum matches (https://github.com/ansible/ansible/issues/29614)
+- nicer error when multiprocessing breaks https://github.com/ansible/ansible/issues/43090
+- openssl_certificate - Convert valid_date to bytes for conversion
+- openstack_inventory.py dynamic inventory file fixed the plugin to the script so that it will work with current ansible-inventory. Also redirect stdout before dumping the ouptput, because not doing so will cause JSON parse errors in some cases. (https://github.com/ansible/ansible/pull/43432)
+- slack callback - Fix invocation by looking up data from cli.options (https://github.com/ansible/ansible/pull/43542)
+- sysvinit module: handle values of optional parameters (https://github.com/ansible/ansible/pull/42786). Don't disable service when `enabled` parameter isn't set. Fix command when `arguments` parameter isn't set.
+- vars_prompt - properly template play level variables in vars_prompt (https://github.com/ansible/ansible/issues/37984)
+- win_domain - ensure the Netlogon service is up and running after promoting host to controller - https://github.com/ansible/ansible/issues/39235
+- win_domain_controller - ensure the Netlogon service is up and running after promoting host to controller - https://github.com/ansible/ansible/issues/39235
+
+v2.6.2
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-07-27
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- Scenario guide for removing an existing virtual machine is added.
+- lineinfile - add warning when using an empty regexp (https://github.com/ansible/ansible/issues/29443)
+
+Bugfixes
+--------
+
+- Add text output along with structured output in nxos_facts (https://github.com/ansible/ansible/pull/42886).
+- Allow more than one page of results by using the right pagination indicator ('NextMarker' instead of 'NextToken').
+- Fix an atomic_move error that is 'true', but  misleading. Now we show all 3 files involved and clarify what happened.
+- Fix eos_l2_interface eapi (https://github.com/ansible/ansible/pull/42270).
+- Fix fetching old style facts in junos_facts module (https://github.com/ansible/ansible/pull/42351)
+- Fix get_device_info nxos zero or more whitespace regex (https://github.com/ansible/ansible/pull/43178).
+- Fix nxos CI failures (https://github.com/ansible/ansible/pull/42240).
+- Fix nxos_nxapi default http behavior (https://github.com/ansible/ansible/pull/41817).
+- Fix nxos_vxlan_vtep_vni (https://github.com/ansible/ansible/pull/42240).
+- Fix regex network_os_platform nxos (https://github.com/ansible/ansible/pull/42288).
+- Refactor nxos cliconf get_device_info for non structured output supported devices (https://github.com/ansible/ansible/pull/42089).
+- To fix the NoneType error raised in ios_l2_interface when Access Mode VLAN is unassigned (https://github.com/ansible/ansible/pull/42312)
+- emtpy host/group name is an error https://github.com/ansible/ansible/issues/42044
+- fix default SSL version for docker modules https://github.com/ansible/ansible/issues/42897
+- fix mail module when using starttls https://github.com/ansible/ansible/issues/42338
+- fix nmap config example https://github.com/ansible/ansible/pull/42925
+- fix ps detection of service https://github.com/ansible/ansible/pull/43014
+- fix the remote tmp folder permissions issue when becoming a non admin user - https://github.com/ansible/ansible/issues/41340, https://github.com/ansible/ansible/issues/42117
+- fix typoe in sysvinit that breaks update.rc-d detection https://github.com/ansible/ansible/issues/42734
+- fixes docker_container compatibilty with docker-py < 2.2
+- get_capabilities in nxapi module_utils should not return empty dictionary (https://github.com/ansible/ansible/pull/42688).
+- inventory - When using an inventory directory, ensure extension comparison uses text types (https://github.com/ansible/ansible/pull/42475)
+- ios_vlan - fix unable to identify correct vlans issue (https://github.com/ansible/ansible/pull/42247)
+- nxos_facts warning message improved (https://github.com/ansible/ansible/pull/42969).
+- openvswitch_db - make 'key' argument optional https://github.com/ansible/ansible/issues/42108
+- pause - do not set stdout to raw mode when redirecting to a file (https://github.com/ansible/ansible/issues/41717)
+- pause - nest try except when importing curses to gracefully fail if curses is not present (https://github.com/ansible/ansible/issues/42004)
+- plugins/inventory/openstack.py - Do not create group with empty name if region is not set
+- preseve delegation info on nolog https://github.com/ansible/ansible/issues/42344
+- remove ambiguity when it comes to 'the source'
+- remove dupes from var precedence
+- restores filtering out conflicting facts https://github.com/ansible/ansible/issues/41684
+- user - fix bug that resulted in module always reporting a change when specifiying the home directory on FreeBSD (https://github.com/ansible/ansible/issues/42484)
+- user - use correct attribute name in FreeBSD for creat_home (https://github.com/ansible/ansible/pull/42711)
+- vultr - Do not fail trying to load configuration from ini files if required variables have been set as environment variables.
+- vyos_command correcting conditionals looping (https://github.com/ansible/ansible/pull/43331).
+- win_chocolatey - enable TLSv1.2 support when downloading the Chocolatey installer https://github.com/ansible/ansible/issues/41906
+- win_reboot - fix for handling an already scheduled reboot and other minor log formatting issues
+- win_reboot - fix issue when overridding connection timeout hung the post reboot uptime check - https://github.com/ansible/ansible/issues/42185 https://github.com/ansible/ansible/issues/42294
+- win_reboot - handle post reboots when running test_command - https://github.com/ansible/ansible/issues/41713
+- win_security_policy - allows an empty string to reset a policy value https://github.com/ansible/ansible/issues/40869
+- win_share - discard any cmdlet output we don't use to ensure only the return json is received by Ansible
+- win_unzip - discard any cmdlet output we don't use to ensure only the return json is received by Ansible
+- win_updates - fixed module return value is lost in error in some cases (https://github.com/ansible/ansible/pull/42647)
+- win_user - Use LogonUser to validate the password as it does not rely on SMB/RPC to be available https://github.com/ansible/ansible/issues/24884
+
+v2.6.1
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-07-05
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- Restore module_utils.basic.BOOLEANS variable for backwards compatibility with the module API in older ansible releases.
+
+Bugfixes
+--------
+
+- **Security Fix** - avoid loading host/group vars from cwd when not specifying a playbook or playbook base dir
+- **Security Fix** - avoid using ansible.cfg in a world writable dir.
+- Fix junos_config confirm commit timeout issue (https://github.com/ansible/ansible/pull/41527)
+- file module - The touch subcommand had its diff output broken during the 2.6.x development cycle.  The patch to fix that broke check mode. This is now fixed (https://github.com/ansible/ansible/issues/42111)
+- inventory manager - This fixes required options being populated before the inventory config file is read, so the required options may be set in the config file.
+- nsupdate - allow hmac-sha384 https://github.com/ansible/ansible/pull/42209
+- win_domain - fixes typo in one of the AD cmdlets https://github.com/ansible/ansible/issues/41536
+- win_group_membership - uses the internal Ansible SID conversion logic and uses that when comparing group membership instead of the name https://github.com/ansible/ansible/issues/40649
+
+v2.6.0
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-06-28
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- Added an ``encoding`` option to the ``b64encode`` and ``b64decode`` filters to specify the encoding of the string that is base64 encoded.
+- PowerShell modules that use Convert-ToSID in Ansible.ModuleUtils.SID.psm1 like win_user_right now accept an actual SID as an input string. This means any local or domain accounts that are named like a SID need to be prefixed with the domain, hostname, or . to ensure it converts to that accounts SID https://github.com/ansible/ansible/issues/38502
+- Raise AnsibleParserError which was missing previously
+- The aws_ses_identity module supports check mode
+- ``postgresql_user`` module changed ``encrypted=yes`` to be the default. This shouldn't break any current playbooks, the module will just store passwords hashed by default. This change was done because Postgres 10 dropped support for ``UNENCRYPTED`` passwords and because all versions since Postgres 7.2 support storing encrypted passwords.
+- azure_rm_loadbalancer - add support for sku
+- azure_rm_publicipaddress - add support for sku
+- cloudflare_dns module - Removed restriction from protocol to allow other protocols than tcp and udp to be specified.
+- command module - Added argv option to allow command to be specified as a list vs. a string (https://github.com/ansible/ansible/issues/19392)
+- gem - add ability to specify a custom directory for installing gems (https://github.com/ansible/ansible/pull/38195)
+- import/include - Cache task_vars to speed up IncludedFile.process_include_results (https://github.com/ansible/ansible/pull/39026)
+- postgresql_user module - Changed encrypted=yes to be the default. This shouldn't break any current playbooks, the module will just store passwords hashed by default. This change was done because Postgres 10 dropped support for UNENCRYPTED passwords and because all versions since Postgres 7.2 support storing encrypted passwords.
+- vmware_target_canonical_facts module - The target_id parameter is an optional parameter.
+
+Deprecated Features
+-------------------
+
+- nxos_igmp_interface module - The oif_prefix and oif_source properties are deprecated. Use the oif_ps parameter with a dictionary of prefix and source to values instead.
+
+Removed Features (previously deprecated)
+----------------------------------------
+
+- removed the deprecated always_run task option, please use ``check_mode: no`` instead
+- win_chocolatey - removed deprecated upgrade option and choco_* output return values
+- win_feature - removed deprecated reboot option
+- win_iis_webapppool - removed the ability to supply attributes as a string in favour of a dictionary
+- win_package - removed deprecated name option
+- win_regedit - removed deprecated support for specifying HKCC as HCCC
+
+Bugfixes
+--------
+
+- **Security Fix** - Some connection exceptions would cause no_log specified on a task to be ignored.  If this happened, the task information, including any private information could have been displayed to stdout and (if enabled, not the default) logged to a log file specified in ansible.cfg's log_path. Additionally, sites which redirected stdout from ansible runs to a log file may have stored that private information onto disk that way as well. (https://github.com/ansible/ansible/pull/41414)
+- Changed the admin_users config option to not include "admin" by default as admin is frequently used for a non-privileged account  (https://github.com/ansible/ansible/pull/41164)
+- Changed the output to "text" for "show vrf" command as default "json" output format with respect to "eapi" transport was failing (https://github.com/ansible/ansible/pull/41470)
+- Document mode=preserve for both the copy and template module
+- Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response. (https://github.com/ansible/ansible/pull/41431)
+- Fix an encoding issue when parsing the examples from a plugins' documentation
+- Fix iosxr_config module to handle route-policy, community-set, prefix-set, as-path-set and rd-set blocks. All these blocks are part of route-policy language of iosxr.
+- Fix mode=preserve with remote_src=True for the copy module
+- Implement mode=preserve for the template module
+- The yaml callback plugin now allows non-ascii characters to be displayed.
+- Various grafana_* modules - Port away from the deprecated b64encodestring function to the b64encode function instead. https://github.com/ansible/ansible/pull/38388
+- added missing 'raise' to exception definition https://github.com/ansible/ansible/pull/41690
+- allow custom endpoints to be used in the aws_s3 module (https://github.com/ansible/ansible/pull/36832)
+- allow set_options to be called multiple times https://github.com/ansible/ansible/pull/41913
+- ansible-doc - fixed traceback on missing plugins (https://github.com/ansible/ansible/pull/41167)
+- cast the device_mapping volume size to an int in the ec2_ami module (https://github.com/ansible/ansible/pull/40938)
+- copy - fixed copy to only follow symlinks for files in the non-recursive case
+- copy module - The copy module was attempting to change the mode of files for remote_src=True even if mode was not set as a parameter.  This failed on filesystems which do not have permission bits (https://github.com/ansible/ansible/pull/40099)
+- copy module - fixed recursive copy with relative paths (https://github.com/ansible/ansible/pull/40166)
+- correct debug display for all cases https://github.com/ansible/ansible/pull/41331
+- correctly check hostvars for vars term https://github.com/ansible/ansible/pull/41819
+- correctly handle yaml inventory files when entries are null dicts https://github.com/ansible/ansible/issues/41692
+- dynamic includes - Allow inheriting attributes from static parents (https://github.com/ansible/ansible/pull/38827)
+- dynamic includes - Don't treat undefined vars for conditional includes as truthy (https://github.com/ansible/ansible/pull/39377)
+- dynamic includes - Fix IncludedFile comparison for free strategy (https://github.com/ansible/ansible/pull/37083)
+- dynamic includes - Improved performance by fixing re-parenting on copy (https://github.com/ansible/ansible/pull/38747)
+- dynamic includes - Use the copied and merged task for calculating task vars (https://github.com/ansible/ansible/pull/39762)
+- file - fixed the default follow behaviour of file to be true
+- file module - Eliminate an error if we're asked to remove a file but something removes it while we are processing the request (https://github.com/ansible/ansible/pull/39466)
+- file module - Fix error when recursively assigning permissions and a symlink to a nonexistent file is present in the directory tree (https://github.com/ansible/ansible/issues/39456)
+- file module - Fix error when running a task which assures a symlink to a nonexistent file exists for the second and subsequent times (https://github.com/ansible/ansible/issues/39558)
+- file module - The file module allowed the user to specify src as a parameter when state was not link or hard.  This is documented as only applying to state=link or state=hard but in previous Ansible, this could have an effect in rare cornercases.  For instance, "ansible -m file -a 'state=directory path=/tmp src=/var/lib'" would create /tmp/lib.  This has been disabled and a warning emitted (will change to an error in Ansible-2.10).
+- file module - The touch subcommand had its diff output broken during the 2.6.x development cycle.  This is now fixed (https://github.com/ansible/ansible/issues/41755)
+- fix BotoCoreError exception handling
+- fix apt-mark on debian6 (https://github.com/ansible/ansible/pull/41530)
+- fix async for the aws_s3 module by adding async support to the action plugin (https://github.com/ansible/ansible/pull/40826)
+- fix decrypting vault files for the aws_s3 module (https://github.com/ansible/ansible/pull/39634)
+- fix errors with S3-compatible APIs if they cannot use ACLs for buckets or objects
+- fix permission handling to try to download a file even if the user does not have permission to list all objects in the bucket
+- fixed config required handling, specifically for _terms in lookups https://github.com/ansible/ansible/pull/41740
+- gce_net - Fix sorting of allowed ports (https://github.com/ansible/ansible/pull/41567)
+- group_by - support implicit localhost (https://github.com/ansible/ansible/pull/41860)
+- import/include - Ensure role handlers have the proper parent, allowing for correct attribute inheritance (https://github.com/ansible/ansible/pull/39426)
+- import_playbook - Pass vars applied to import_playbook into parsing of the playbook as they may be needed to parse the imported plays (https://github.com/ansible/ansible/pull/39521)
+- include_role/import_role - Don't overwrite included role handlers with play handlers on parse (https://github.com/ansible/ansible/pull/39563)
+- include_role/import_role - Fix parameter templating (https://github.com/ansible/ansible/pull/36372)
+- include_role/import_role - Use the computed role name for include_role/import_role so to diffentiate between names computed from host vars (https://github.com/ansible/ansible/pull/39516)
+- include_role/import_role - improved performance and recursion depth (https://github.com/ansible/ansible/pull/36470)
+- lineinfile - fix insertbefore when used with BOF to not insert duplicate lines (https://github.com/ansible/ansible/issues/38219)
+- password lookup - Do not load password lookup in network filters, allowing the password lookup to be overriden (https://github.com/ansible/ansible/pull/41907)
+- pause - ensure ctrl+c interrupt works in all cases (https://github.com/ansible/ansible/issues/35372)
+- powershell - use the tmpdir set by ``remote_tmp`` for become/async tasks instead of the generic $env:TEMP - https://github.com/ansible/ansible/pull/40210
+- selinux - correct check mode behavior to report same changes as normal mode (https://github.com/ansible/ansible/pull/40721)
+- spwd - With python 3.6 spwd.getspnam returns PermissionError instead of KeyError if user does not have privileges (https://github.com/ansible/ansible/issues/39472)
+- synchronize - Ensure the local connection created by synchronize uses _remote_is_local=True, which causes ActionBase to build a local tmpdir (https://github.com/ansible/ansible/pull/40833)
+- template - Fix for encoding issues when a template path contains non-ascii characters and using the template path in ansible_managed (https://github.com/ansible/ansible/issues/27262)
+- template action plugin - fix the encoding of filenames to avoid tracebacks on Python2 when characters that are not present in the user's locale are present. (https://github.com/ansible/ansible/pull/39424)
+- user - only change the expiration time when necessary (https://github.com/ansible/ansible/issues/13235)
+- uses correct conn info for reset_connection  https://github.com/ansible/ansible/issues/27520
+- win_environment - Fix for issue where the environment value was deleted when a null value or empty string was set - https://github.com/ansible/ansible/issues/40450
+- win_file - fix issue where special chars like [ and ] were not being handled correctly https://github.com/ansible/ansible/pull/37901
+- win_get_url - fixed a few bugs around authentication and force no when using an FTP URL
+- win_iis_webapppool - redirect some module output to null so Ansible can read the output JSON https://github.com/ansible/ansible/issues/40874
+- win_template - fix when specifying the dest option as a directory with and without the trailing slash https://github.com/ansible/ansible/issues/39886
+- win_updates - Added the ability to run on a scheduled task for older hosts so async starts working again - https://github.com/ansible/ansible/issues/38364
+- win_updates - Fix logic when using a whitelist for multiple updates
+- win_updates - Fix typo that hid the download error when a download failed
+- win_updates - Fixed issue where running win_updates on async fails without any error
+- windows become - Show better error messages when the become process fails
+- winrm - Add better error handling when the kinit process fails
+- winrm - allow ``ansible_user`` or ``ansible_winrm_user`` to override ``ansible_ssh_user`` when both are defined in an inventory - https://github.com/ansible/ansible/issues/39844
+- winrm - ensure pexpect is set to not echo the input on a failure and have a manual sanity check afterwards https://github.com/ansible/ansible/issues/41865
+- winrm connection plugin - Fix exception messages sometimes raising a traceback when the winrm connection plugin encounters an unrecoverable error.  https://github.com/ansible/ansible/pull/39333
+- xenserver_facts - ensure module works with newer versions of XenServer (https://github.com/ansible/ansible/pull/35821)
+
+New Plugins
+-----------
+
+Callback
+~~~~~~~~
+
+- cgroup_memory_recap - Profiles maximum memory usage of tasks and full execution using cgroups
+- grafana_annotations - send ansible events as annotations on charts to grafana over http api.
+- sumologic - Sends task result events to Sumologic
+
+Connection
+~~~~~~~~~~
+
+- httpapi - Use httpapi to run command on network appliances
+
+Inventory
+~~~~~~~~~
+
+- foreman - foreman inventory source
+- gcp_compute - Google Cloud Compute Engine inventory source
+- generator - Uses Jinja2 to construct hosts and groups from patterns
+- nmap - Uses nmap to find hosts to target
+
+Lookup
+~~~~~~
+
+- onepassword - fetch field values from 1Password
+- onepassword_raw - fetch raw json data from 1Password
+
+New Modules
+-----------
+
+Cloud
+~~~~~
+
+amazon
+^^^^^^
+
+- aws_caller_facts - Get facts about the user and account being used to make AWS calls.
+- aws_config_aggregation_authorization - Manage cross-account AWS Config authorizations
+- aws_config_aggregator - Manage AWS Config aggregations across multiple accounts
+- aws_config_delivery_channel - Manage AWS Config delivery channels
+- aws_config_recorder - Manage AWS Config Recorders
+- aws_config_rule - Manage AWS Config resources
+- aws_glue_connection - Manage an AWS Glue connection
+- aws_glue_job - Manage an AWS Glue job
+- aws_inspector_target - Create, Update and Delete Amazon Inspector Assessment Targets
+- aws_ses_identity_policy - Manages SES sending authorization policies
+- aws_sgw_facts - Fetch AWS Storage Gateway facts
+- ec2_eip_facts - List EC2 EIP details
+- ec2_vpc_vpn_facts - Gather facts about VPN Connections in AWS.
+- elb_network_lb - Manage a Network Load Balancer
+- rds_instance_facts - obtain facts about one or more RDS instances
+- rds_snapshot_facts - obtain facts about one or more RDS snapshots
+
+azure
+^^^^^
+
+- azure_rm_aks - Manage a managed Azure Container Service (AKS) Instance.
+- azure_rm_aks_facts - Get Azure Kubernetes Service facts.
+- azure_rm_resource - Create any Azure resource.
+- azure_rm_resource_facts - Generic facts of Azure resources.
+
+cloudstack
+^^^^^^^^^^
+
+- cs_role_permission - Manages role permissions on Apache CloudStack based clouds.
+
+digital_ocean
+^^^^^^^^^^^^^
+
+- digital_ocean_account_facts - Gather facts about DigitalOcean User account
+- digital_ocean_certificate_facts - Gather facts about DigitalOcean certificates
+- digital_ocean_domain_facts - Gather facts about DigitalOcean Domains
+- digital_ocean_image_facts - Gather facts about DigitalOcean images
+- digital_ocean_load_balancer_facts - Gather facts about DigitalOcean load balancers
+- digital_ocean_region_facts - Gather facts about DigitalOcean regions
+- digital_ocean_size_facts - Gather facts about DigitalOcean Droplet sizes
+- digital_ocean_snapshot_facts - Gather facts about DigitalOcean Snapshot
+- digital_ocean_tag_facts - Gather facts about DigitalOcean tags
+- digital_ocean_volume_facts - Gather facts about DigitalOcean volumes
+
+google
+^^^^^^
+
+- gcp_compute_address - Creates a GCP Address
+- gcp_compute_backend_bucket - Creates a GCP BackendBucket
+- gcp_compute_backend_service - Creates a GCP BackendService
+- gcp_compute_disk - Creates a GCP Disk
+- gcp_compute_firewall - Creates a GCP Firewall
+- gcp_compute_forwarding_rule - Creates a GCP ForwardingRule
+- gcp_compute_global_address - Creates a GCP GlobalAddress
+- gcp_compute_global_forwarding_rule - Creates a GCP GlobalForwardingRule
+- gcp_compute_health_check - Creates a GCP HealthCheck
+- gcp_compute_http_health_check - Creates a GCP HttpHealthCheck
+- gcp_compute_https_health_check - Creates a GCP HttpsHealthCheck
+- gcp_compute_image - Creates a GCP Image
+- gcp_compute_instance - Creates a GCP Instance
+- gcp_compute_instance_group - Creates a GCP InstanceGroup
+- gcp_compute_instance_group_manager - Creates a GCP InstanceGroupManager
+- gcp_compute_instance_template - Creates a GCP InstanceTemplate
+- gcp_compute_network - Creates a GCP Network
+- gcp_compute_route - Creates a GCP Route
+- gcp_compute_ssl_certificate - Creates a GCP SslCertificate
+- gcp_compute_subnetwork - Creates a GCP Subnetwork
+- gcp_compute_target_http_proxy - Creates a GCP TargetHttpProxy
+- gcp_compute_target_https_proxy - Creates a GCP TargetHttpsProxy
+- gcp_compute_target_pool - Creates a GCP TargetPool
+- gcp_compute_target_ssl_proxy - Creates a GCP TargetSslProxy
+- gcp_compute_target_tcp_proxy - Creates a GCP TargetTcpProxy
+- gcp_compute_url_map - Creates a GCP UrlMap
+- gcp_container_cluster - Creates a GCP Cluster
+- gcp_container_node_pool - Creates a GCP NodePool
+- gcp_dns_resource_record_set - Creates a GCP ResourceRecordSet
+- gcp_pubsub_subscription - Creates a GCP Subscription
+- gcp_pubsub_topic - Creates a GCP Topic
+- gcp_storage_bucket - Creates a GCP Bucket
+- gcp_storage_bucket_access_control - Creates a GCP BucketAccessControl
+
+heroku
+^^^^^^
+
+- heroku_collaborator - Add or delete app collaborators on Heroku
+
+memset
+^^^^^^
+
+- memset_dns_reload - Request reload of Memset's DNS infrastructure,
+- memset_zone - Creates and deletes Memset DNS zones.
+- memset_zone_domain - Create and delete domains in Memset DNS zones.
+- memset_zone_record - Create and delete records in Memset DNS zones.
+
+misc
+^^^^
+
+- cloud_init_data_facts - Retrieve facts of cloud-init.
+
+opennebula
+^^^^^^^^^^
+
+- one_host - Manages OpenNebula Hosts
+- one_image - Manages OpenNebula images
+- one_image_facts - Gather facts about OpenNebula images
+- one_service - Deploy and manage OpenNebula services
+- one_vm - Creates or terminates OpenNebula instances
+
+openstack
+^^^^^^^^^
+
+- os_server_metadata - Add/Update/Delete Metadata in Compute Instances from OpenStack
+- os_volume_snapshot - Create/Delete Cinder Volume Snapshots
+
+scaleway
+^^^^^^^^
+
+- scaleway_compute - Scaleway compute management module
+- scaleway_sshkey - Scaleway SSH keys management module
+
+vmware
+^^^^^^
+
+- vmware_cluster_facts - Gather facts about clusters available in given vCenter
+- vmware_datastore_cluster - Manage VMware vSphere datastore clusters
+- vmware_datastore_maintenancemode - Place a datastore into maintenance mode
+- vmware_guest_disk_facts - Gather facts about disks of given virtual machine
+- vmware_guest_snapshot_facts - Gather facts about virtual machine's snapshots in vCenter
+- vmware_host_capability_facts - Gathers facts about an ESXi host's capability information
+- vmware_host_powerstate - Manages power states of host systems in vCenter
+- vmware_local_user_facts - Gather facts about users on the given ESXi host
+- vmware_portgroup_facts - Gathers facts about an ESXi host's portgroup configuration
+- vmware_resource_pool_facts - Gathers facts about resource pool information
+- vmware_tag - Manage VMware tags
+- vmware_tag_facts - Manage VMware tag facts
+- vmware_vswitch_facts - Gathers facts about an ESXi host's vswitch configurations
+
+Clustering
+~~~~~~~~~~
+
+k8s
+^^^
+
+- k8s - Manage Kubernetes (K8s) objects
+
+Commands
+~~~~~~~~
+
+- psexec - Runs commands on a remote Windows host based on the PsExec model
+
+Monitoring
+~~~~~~~~~~
+
+- spectrum_device - Creates/deletes devices in CA Spectrum.
+
+zabbix
+^^^^^^
+
+- zabbix_group_facts - Gather facts about Zabbix hostgroup
+
+Net Tools
+~~~~~~~~~
+
+ldap
+^^^^
+
+- ldap_passwd - Set passwords in LDAP.
+
+Network
+~~~~~~~
+
+aci
+^^^
+
+- aci_l3out - Manage Layer 3 Outside (L3Out) objects (l3ext:Out)
+
+avi
+^^^
+
+- avi_autoscalelaunchconfig - Module for setup of AutoScaleLaunchConfig Avi RESTful Object
+- avi_l4policyset - Module for setup of L4PolicySet Avi RESTful Object
+- avi_useraccount - Avi UserAccount Module
+
+cnos
+^^^^
+
+- cnos_command - Run arbitrary commands on Lenovo CNOS devices
+- cnos_config - Manage Lenovo CNOS configuration sections
+
+exos
+^^^^
+
+- exos_command - Run commands on remote devices running Extreme EXOS
+
+f5
+^^
+
+- bigip_data_group - Manage data groups on a BIG-IP
+- bigip_device_license - Manage license installation and activation on BIG-IP devices
+- bigip_gtm_global - Manages global GTM settings
+- bigip_gtm_monitor_bigip - Manages F5 BIG-IP GTM BIG-IP monitors
+- bigip_gtm_monitor_external - Manages external GTM monitors on a BIG-IP
+- bigip_gtm_monitor_firepass - Manages F5 BIG-IP GTM FirePass monitors
+- bigip_gtm_monitor_http - Manages F5 BIG-IP GTM http monitors
+- bigip_gtm_monitor_https - Manages F5 BIG-IP GTM https monitors
+- bigip_gtm_monitor_tcp - Manages F5 BIG-IP GTM tcp monitors
+- bigip_gtm_monitor_tcp_half_open - Manages F5 BIG-IP GTM tcp half-open monitors
+- bigip_gtm_pool_member - Manage GTM pool member settings
+- bigip_gtm_virtual_server - Manages F5 BIG-IP GTM virtual servers
+- bigip_log_destination - Manages log destinations on a BIG-IP.
+- bigip_log_publisher - Manages log publishers on a BIG-IP
+- bigip_management_route - Manage system management routes on a BIG-IP
+- bigip_monitor_external - Manages external LTM monitors on a BIG-IP
+- bigip_profile_dns - Manage DNS profiles on a BIG-IP
+- bigip_profile_tcp - Manage TCP profiles on a BIG-IP
+- bigip_profile_udp - Manage UDP profiles on a BIG-IP
+- bigip_service_policy - Manages service policies on a BIG-IP.
+- bigip_smtp - Manages SMTP settings on the BIG-IP
+- bigip_snmp_community - Manages SNMP communities on a BIG-IP.
+- bigip_timer_policy - Manage timer policies on a BIG-IP
+- bigip_trunk - Manage trunks on a BIG-IP
+- bigiq_application_fasthttp - Manages BIG-IQ FastHTTP applications
+- bigiq_application_fastl4_tcp - Manages BIG-IQ FastL4 TCP applications
+- bigiq_application_fastl4_udp - Manages BIG-IQ FastL4 UDP applications
+- bigiq_application_http - Manages BIG-IQ HTTP applications
+- bigiq_application_https_offload - Manages BIG-IQ HTTPS offload applications
+- bigiq_application_https_waf - Manages BIG-IQ HTTPS WAF applications
+- bigiq_regkey_license_assignment - Manage regkey license assignment on BIG-IPs from a BIG-IQ.
+- bigiq_utility_license - Manage utility licenses on a BIG-IQ
+
+files
+^^^^^
+
+- net_get - Copy a file from a network device to Ansible Controller
+- net_put - Copy a file from Ansible Controller to a network device
+
+fortios
+^^^^^^^
+
+- fortios_webfilter - Configure webfilter capabilities of FortiGate and FortiOS.
+
+meraki
+^^^^^^
+
+- meraki_admin - Manage administrators in the Meraki cloud
+- meraki_network - Manage networks in the Meraki cloud
+- meraki_organization - Manage organizations in the Meraki cloud
+- meraki_snmp - Manage organizations in the Meraki cloud
+
+netconf
+^^^^^^^
+
+- netconf_get - Fetch configuration/state data from NETCONF enabled network devices.
+- netconf_rpc - Execute operations on NETCONF enabled network devices.
+
+slxos
+^^^^^
+
+- slxos_command - Run commands on remote devices running Extreme Networks SLX-OS
+- slxos_config - Manage Extreme Networks SLX-OS configuration sections
+- slxos_facts - Collect facts from devices running Extreme SLX-OS
+- slxos_interface - Manage Interfaces on Extreme SLX-OS network devices
+- slxos_l2_interface - Manage Layer-2 interface on Extreme Networks SLXOS devices.
+- slxos_l3_interface - Manage L3 interfaces on Extreme Networks SLXOS network devices.
+- slxos_linkagg - Manage link aggregation groups on Extreme Networks SLXOS network devices
+- slxos_vlan - Manage VLANs on Extreme Networks SLX-OS network devices
+
+Packaging
+~~~~~~~~~
+
+language
+^^^^^^^^
+
+- yarn - Manage node.js packages with Yarn
+
+os
+^^
+
+- flatpak - Manage flatpaks
+- flatpak_remote - Manage flatpak repository remotes
+
+Source Control
+~~~~~~~~~~~~~~
+
+- gitlab_deploy_key - Manages GitLab project deploy keys.
+- gitlab_hooks - Manages GitLab project hooks.
+
+Storage
+~~~~~~~
+
+glusterfs
+^^^^^^^^^
+
+- gluster_peer - Attach/Detach peers to/from the cluster
+
+netapp
+^^^^^^
+
+- na_ontap_aggregate - Manage NetApp ONTAP aggregates.
+- na_ontap_broadcast_domain - Manage NetApp ONTAP broadcast domains.
+- na_ontap_broadcast_domain_ports - Manage NetApp Ontap broadcast domain ports
+- na_ontap_cifs - Manage NetApp cifs-share
+- na_ontap_cifs_acl - Manage NetApp cifs-share-access-control
+- na_ontap_cifs_server - cifs server configuration
+- na_ontap_cluster - Create/Join ONTAP cluster. Apply license to cluster
+- na_ontap_cluster_ha - Manage HA status for cluster
+- na_ontap_export_policy - Manage NetApp ONTAP export-policy
+- na_ontap_export_policy_rule - Manage ONTAP Export rules
+- na_ontap_igroup - ONTAP iSCSI igroup configuration
+- na_ontap_interface - ONTAP LIF configuration
+- na_ontap_iscsi - Manage NetApp Ontap iscsi service
+- na_ontap_job_schedule - Manage NetApp Ontap Job Schedule
+- na_ontap_license - Manage NetApp ONTAP protocol and feature licenses
+- na_ontap_lun - Manage  NetApp Ontap luns
+- na_ontap_lun_map - Manage NetApp Ontap lun maps
+- na_ontap_net_ifgrp - Create, modify, destroy the network interface group
+- na_ontap_net_port - Manage NetApp Ontap network ports.
+- na_ontap_net_routes - Manage NetApp Ontap network routes
+- na_ontap_net_vlan - Manage NetApp Ontap network vlan
+- na_ontap_nfs - Manage Ontap NFS status
+- na_ontap_ntp - Create/Delete/modify_version ONTAP NTP server
+- na_ontap_qtree - Manage qtrees
+- na_ontap_service_processor_network - Manage NetApp Ontap service processor network
+- na_ontap_snapshot - Manage NetApp Sanpshots
+- na_ontap_snmp - Manage NetApp SNMP community
+- na_ontap_svm - Manage NetApp Ontap svm
+- na_ontap_ucadapter - ONTAP UC adapter configuration
+- na_ontap_user - useradmin configuration and management
+- na_ontap_user_role - useradmin configuration and management
+- na_ontap_volume - Manage NetApp ONTAP volumes.
+- na_ontap_volume_clone - Manage NetApp Ontap volume clones.
+
+purestorage
+^^^^^^^^^^^
+
+- purefa_ds - Configure FlashArray Directory Service
+- purefa_facts - Collect facts from Pure Storage FlashArray
+- purefa_pgsnap - Manage protection group snapshots on Pure Storage FlashArrays
+- purefb_fs - Manage filesystemon Pure Storage FlashBlade`
+- purefb_snap - Manage filesystem snapshots on Pure Storage FlashBlades
+
+System
+~~~~~~
+
+- sysvinit - Manage SysV services.
+
+Web Infrastructure
+~~~~~~~~~~~~~~~~~~
+
+- acme_account - Create, modify or delete accounts with Let's Encrypt
+
+Windows
+~~~~~~~
+
+- win_domain_computer - Manage computers in Active Directory
+- win_hostname - Manages local Windows computer name.
+- win_pester - Run Pester tests on Windows hosts

changelogs/config.yaml

@@ -0,0 +1,13 @@
+---
+release_tag_re: '(v(?:[\d.ab\-]|rc)+)'
+pre_release_tag_re: '(?P<pre_release>(?:[ab]|rc)+\d*)$'
+notesdir: fragments
+prelude_section_name: release_summary
+new_plugins_after_name: removed_features
+sections:
+- ['major_changes', 'Major Changes']
+- ['minor_changes', 'Minor Changes']
+- ['deprecated_features', 'Deprecated Features']
+- ['removed_features', 'Removed Features (previously deprecated)']
+- ['bugfixes', 'Bugfixes']
+- ['known_issues', 'Known Issues']

changelogs/fragments/40839-docker_container_init.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- fixes docker_container compatibilty with docker-py < 2.2

changelogs/fragments/41167_ansible_doc_regression.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- ansible-doc - fixed traceback on missing plugins (https://github.com/ansible/ansible/pull/41167)

changelogs/fragments/41530-apt-mark-deb6.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - fix apt-mark on debian6 (https://github.com/ansible/ansible/pull/41530)

changelogs/fragments/42042-inventory_with_no_region.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- plugins/inventory/openstack.py - Do not create group with empty name if region is not set

changelogs/fragments/42647-win_updates.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- win_updates - fixed module return value is lost in error in some cases (https://github.com/ansible/ansible/pull/42647)

changelogs/fragments/42786-sysvinit-fix-2-issues.yml

@@ -0,0 +1,4 @@
+bugfixes:
+- "sysvinit module: handle values of optional parameters (https://github.com/ansible/ansible/pull/42786).
+  Don't disable service when `enabled` parameter isn't set.
+  Fix command when `arguments` parameter isn't set."

changelogs/fragments/42943_vmware_vmnic_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- VMware handle pnic in proxyswitch (https://github.com/ansible/ansible/pull/42996)

changelogs/fragments/admin-users-default-change.yaml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+  - Changed the admin_users config option to not include "admin" by default as
+    admin is frequently used for a non-privileged account  (https://github.com/ansible/ansible/pull/41164)

changelogs/fragments/always_run_removal.yaml

@@ -0,0 +1,2 @@
+removed_features:
+- "removed the deprecated always_run task option, please use ``check_mode: no`` instead"

changelogs/fragments/ansible-managed-encoding.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- template - Fix for encoding issues when a template path contains non-ascii
+  characters and using the template path in ansible_managed
+  (https://github.com/ansible/ansible/issues/27262)

changelogs/fragments/avoid_cwd_vars.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - '**Security Fix** - avoid loading host/group vars from cwd when not specifying a playbook or playbook base dir'

changelogs/fragments/aws_s3_async_fix.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- fix async for the aws_s3 module by adding async support to the action plugin (https://github.com/ansible/ansible/pull/40826)

changelogs/fragments/aws_s3_decryption_fix.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- fix decrypting vault files for the aws_s3 module (https://github.com/ansible/ansible/pull/39634)

changelogs/fragments/aws_s3_fix_custom_endpoints.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- allow custom endpoints to be used in the aws_s3 module (https://github.com/ansible/ansible/pull/36832)

changelogs/fragments/aws_s3_fix_exception_handling.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+  - fix permission handling to try to download a file even if the user does not have permission to list all objects in the bucket
+  - fix BotoCoreError exception handling
+  - fix errors with S3-compatible APIs if they cannot use ACLs for buckets or objects

changelogs/fragments/aws_ses_identity_check_mode.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+  - The aws_ses_identity module supports check mode

changelogs/fragments/azure-lb-sku.yaml

@@ -0,0 +1,3 @@
+minor_changes:
+- azure_rm_loadbalancer - add support for sku
+- azure_rm_publicipaddress - add support for sku

changelogs/fragments/azure_nsg_deployment_lb.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- fix azure security group cannot add rules when purge_rule set to false. (https://github.com/ansible/ansible/pull/43699)
+- fix azure_rm_deployment collect tags from existing Resource Group. (https://github.com/ansible/ansible/pull/26104)
+- fix azure_rm_loadbalancer_facts list takes at least 2 arguments. (https://github.com/ansible/ansible/pull/29050)

changelogs/fragments/base64_filter_encoding.yaml

@@ -0,0 +1,3 @@
+minor_changes:
+- Added an ``encoding`` option to the ``b64encode`` and ``b64decode`` filters
+  to specify the encoding of the string that is base64 encoded.

changelogs/fragments/basic_booleans_backward_compat.yaml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+- Restore module_utils.basic.BOOLEANS variable for backwards compatibility with the module API in older ansible releases.

changelogs/fragments/clarify_error_message.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - Fix an atomic_move error that is 'true', but  misleading. Now we show all 3 files involved and clarify what happened.

changelogs/fragments/command-support-argv.yaml

@@ -0,0 +1,4 @@
+---
+minor_changes:
+  - command module - Added argv option to allow command to be specified as a list vs. a string
+    (https://github.com/ansible/ansible/issues/19392)

changelogs/fragments/convert-valid-data-to-bytes-for-conversion.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - openssl_certificate - Convert valid_date to bytes for conversion

changelogs/fragments/copy-files-default-follow.yaml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+- copy - fixed copy to only follow symlinks for files in the non-recursive case
+- file - fixed the default follow behaviour of file to be true

changelogs/fragments/copy-no-chmod.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- copy module - The copy module was attempting to change the mode of files for
+  remote_src=True even if mode was not set as a parameter.  This failed on
+  filesystems which do not have permission bits (https://github.com/ansible/ansible/pull/40099)

changelogs/fragments/copy-recursive-copy.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- copy module - fixed recursive copy with relative paths (https://github.com/ansible/ansible/pull/40166)

changelogs/fragments/debug_fixes.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - correct debug display for all cases https://github.com/ansible/ansible/pull/41331

changelogs/fragments/digital_ocean_block_storage_fix.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response. (https://github.com/ansible/ansible/pull/41431)

changelogs/fragments/doc_fix.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - remove dupes from var precedence

changelogs/fragments/docfix.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - fix nmap config example https://github.com/ansible/ansible/pull/42925

changelogs/fragments/docker-default-ssl.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- fix default SSL version for docker modules https://github.com/ansible/ansible/issues/42897

changelogs/fragments/ec2_ami_fix_block_device_mapping_volume_size_type.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- cast the device_mapping volume size to an int in the ec2_ami module (https://github.com/ansible/ansible/pull/40938)

changelogs/fragments/empty_gh_error.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+    - emtpy host/group name is an error https://github.com/ansible/ansible/issues/42044

changelogs/fragments/encoding-docs-plugin-parsing.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- Fix an encoding issue when parsing the examples from a plugins' documentation

changelogs/fragments/ensure_text_source.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+    - remove ambiguity when it comes to 'the source' 

changelogs/fragments/eos_l2_interface_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- Fix eos_l2_interface eapi (https://github.com/ansible/ansible/pull/42270).

changelogs/fragments/eos_vrf_failure-fix.yml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+  - Changed the output to "text" for "show vrf" command as default "json" output format
+    with respect to "eapi" transport was failing (https://github.com/ansible/ansible/pull/41470)

changelogs/fragments/file-disallow-src.yaml

@@ -0,0 +1,8 @@
+---
+bugfixes:
+- file module - The file module allowed the user to specify src as a parameter
+  when state was not link or hard.  This is documented as only applying to
+  state=link or state=hard but in previous Ansible, this could have an effect
+  in rare cornercases.  For instance, "ansible -m file -a 'state=directory
+  path=/tmp src=/var/lib'" would create /tmp/lib.  This has been disabled and
+  a warning emitted (will change to an error in Ansible-2.10).

changelogs/fragments/file-nonexistent-link.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+  - file module - Fix error when running a task which assures a symlink to
+    a nonexistent file exists for the second and subsequent times
+    (https://github.com/ansible/ansible/issues/39558)

changelogs/fragments/file-nonexitent-link-recurse.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+  - file module - Fix error when recursively assigning permissions and
+    a symlink to a nonexistent file is present in the directory tree
+    (https://github.com/ansible/ansible/issues/39456)

changelogs/fragments/file-succeed-if-already-absent.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- file module - Eliminate an error if we're asked to remove a file but
+  something removes it while we are processing the request
+  (https://github.com/ansible/ansible/pull/39466)

changelogs/fragments/file_touch_check_mode.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- file module - The touch subcommand had its diff output broken during the
+  2.6.x development cycle.  The patch to fix that broke check mode.
+  This is now fixed (https://github.com/ansible/ansible/issues/42111)

changelogs/fragments/file_touch_diff.yaml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+- file module - The touch subcommand had its diff output broken during the
+  2.6.x development cycle.  This is now fixed (https://github.com/ansible/ansible/issues/41755)

changelogs/fragments/fix-selectors-error-condition.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- fix for the bundled selectors module (used in the ssh and local connection
+  plugins) when a syscall is restarted after being interrupted by a signal
+  (https://github.com/ansible/ansible/issues/41630)

changelogs/fragments/fix-swap-mount-module.yaml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+- Fix the mount module's handling of swap entries in fstab
+  (https://github.com/ansible/ansible/pull/42837)

changelogs/fragments/fix-world-readable-skip-message.yaml

@@ -0,0 +1,9 @@
+---
+bugfixes:
+- The fix for `CVE-2018-10875 <https://access.redhat.com/security/cve/cve-2018-10875>`_
+  prints out a warning message about skipping a config file from a world
+  writable current working directory.  However, if the user explicitly
+  specifies that the config file should be used via the ANSIBLE_CONFIG
+  environment variable then Ansible would honor that but still print out the
+  warning message.  This has been fixed so that Ansible honors the user's
+  explicit wishes and does not print a warning message in that circumstance.

changelogs/fragments/fix_config_required.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - fixed config required handling, specifically for _terms in lookups https://github.com/ansible/ansible/pull/41740

changelogs/fragments/fix_fact_clean.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+    - restores filtering out conflicting facts https://github.com/ansible/ansible/issues/41684

changelogs/fragments/fix_ios_vlan.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - ios_vlan - fix unable to identify correct vlans issue (https://github.com/ansible/ansible/pull/42247)

changelogs/fragments/fix_options.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - allow set_options to be called multiple times https://github.com/ansible/ansible/pull/41913

changelogs/fragments/fix_pagination_cloudfront_facts.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - Allow more than one page of results by using the right pagination indicator ('NextMarker' instead of 'NextToken').

changelogs/fragments/fix_password_lookup_loading.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- password lookup - Do not load password lookup in network filters, allowing the password lookup to be overriden (https://github.com/ansible/ansible/pull/41907)

changelogs/fragments/fix_sysvinit_typo.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - fix typoe in sysvinit that breaks update.rc-d detection https://github.com/ansible/ansible/issues/42734

changelogs/fragments/fix_tls_mail.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+    - fix mail module when using starttls https://github.com/ansible/ansible/issues/42338

changelogs/fragments/fix_yaml_inv_nulls.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - correctly handle yaml inventory files when entries are null dicts https://github.com/ansible/ansible/issues/41692

changelogs/fragments/gce-sort-fix.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- gce_net - Fix sorting of allowed ports (https://github.com/ansible/ansible/pull/41567)

changelogs/fragments/gem-custom-home.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+  - gem - add ability to specify a custom directory for installing gems (https://github.com/ansible/ansible/pull/38195)

changelogs/fragments/get_url_bug_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- get_url - fix the bug that get_url does not change mode when checksum matches (https://github.com/ansible/ansible/issues/29614)

changelogs/fragments/grafana-deprecation-warnings.yaml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+- Various grafana_* modules - Port away from the deprecated b64encodestring
+  function to the b64encode function instead. https://github.com/ansible/ansible/pull/38388

changelogs/fragments/group_by_localhost.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- group_by - support implicit localhost (https://github.com/ansible/ansible/pull/41860)

changelogs/fragments/includes.yaml

@@ -0,0 +1,16 @@
+---
+minor_changes:
+- import/include - Cache task_vars to speed up IncludedFile.process_include_results (https://github.com/ansible/ansible/pull/39026)
+
+bugfixes:
+- dynamic includes - Don't treat undefined vars for conditional includes as truthy (https://github.com/ansible/ansible/pull/39377)
+- import/include - Ensure role handlers have the proper parent, allowing for correct attribute inheritance (https://github.com/ansible/ansible/pull/39426)
+- include_role/import_role - Use the computed role name for include_role/import_role so to diffentiate between names computed from host vars (https://github.com/ansible/ansible/pull/39516)
+- import_playbook - Pass vars applied to import_playbook into parsing of the playbook as they may be needed to parse the imported plays (https://github.com/ansible/ansible/pull/39521)
+- include_role/import_role - Don't overwrite included role handlers with play handlers on parse (https://github.com/ansible/ansible/pull/39563)
+- dynamic includes - Improved performance by fixing re-parenting on copy (https://github.com/ansible/ansible/pull/38747)
+- dynamic includes - Fix IncludedFile comparison for free strategy (https://github.com/ansible/ansible/pull/37083)
+- dynamic includes - Allow inheriting attributes from static parents (https://github.com/ansible/ansible/pull/38827)
+- include_role/import_role - improved performance and recursion depth (https://github.com/ansible/ansible/pull/36470)
+- include_role/import_role - Fix parameter templating (https://github.com/ansible/ansible/pull/36372)
+- dynamic includes - Use the copied and merged task for calculating task vars (https://github.com/ansible/ansible/pull/39762)

changelogs/fragments/inventory_dir_ext_compare_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- inventory - When using an inventory directory, ensure extension comparison uses text types (https://github.com/ansible/ansible/pull/42475)

changelogs/fragments/inventory_manager_fix_required_options_override.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- inventory manager - This fixes required options being populated before the
+  inventory config file is read, so the required options may be set in the
+  config file.

changelogs/fragments/ios_l2_interface-fix.yml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+  - To fix the NoneType error raised in ios_l2_interface when Access Mode VLAN is unassigned 
+    (https://github.com/ansible/ansible/pull/42312)

changelogs/fragments/iosxr_config_route_policy_objects_fix.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- Fix iosxr_config module to handle route-policy, community-set, prefix-set,
+  as-path-set and rd-set blocks. All these blocks are part of route-policy
+  language of iosxr.

changelogs/fragments/junos_config_confirm_commit.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - Fix junos_config confirm commit timeout issue (https://github.com/ansible/ansible/pull/41527)

changelogs/fragments/junos_facts_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - Fix fetching old style facts in junos_facts module (https://github.com/ansible/ansible/pull/42351)

changelogs/fragments/lineinfile-empty-regexp.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - lineinfile - add warning when using an empty regexp (https://github.com/ansible/ansible/issues/29443)

changelogs/fragments/lineinfile-insertbefore-bof-bugfix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - lineinfile - fix insertbefore when used with BOF to not insert duplicate lines (https://github.com/ansible/ansible/issues/38219)

changelogs/fragments/lxd-idempotent-config.yaml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+- Fix lxd module to be idempotent when the given configuration for the lxd
+  container has not changed (https://github.com/ansible/ansible/pull/38166)

changelogs/fragments/missing_raise.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - added missing 'raise' to exception definition https://github.com/ansible/ansible/pull/41690

changelogs/fragments/mode-preserve.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- Implement mode=preserve for the template module
+- Fix mode=preserve with remote_src=True for the copy module
+- Document mode=preserve for both the copy and template module

changelogs/fragments/nicer_multi_error.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - nicer error when multiprocessing breaks https://github.com/ansible/ansible/issues/43090