Compare commits

...

6319 Commits

Author SHA1 Message Date
ff603897d2 New release v2.10.15 (#75998) 2021-10-11 10:40:04 -04:00
23f3d0631f Update Ansible release version to v2.10.15rc1.post0. 2021-10-04 15:09:02 -04:00
5d92c7212f New release v2.10.15rc1 2021-10-04 11:58:04 -04:00
c7996fe90e ansible-test - remove obsolete power/centos remote 2021-09-30 16:03:24 -07:00
7596e9420c netconf - handle import error when running in FIPS mode (#73992) (#75707)
* Handle netconf plugin ncclient import error when running in FIPS mode

*  While running in FIPS mode importing ncclient result in
   InternalError raised by cryptography
*  Refer https://github.com/ansible/ansible/pull/65477

(cherry picked from commit d8bf4206e4)

Co-authored-by: Ganesh Nalawade <ganesh634@gmail.com>
2021-09-29 15:19:32 -05:00
87e77a93a9 PowerShell - Ignore LIB env var when building C# code (#75698) (#75724)
* PowerShell - Ignore environment variables when building C# code

* Just unset LIB for now

* Fix sanity issue

(cherry picked from commit 097bc07b66)
2021-09-29 14:22:03 -05:00
2cdc3834c9 [stable-2.10] Don't show params when there is an issue with set_option(s) (#75805) (#75809)
(cherry picked from commit 79e9dae)

Co-authored-by: Matt Martz <matt@sivel.net>
2021-09-29 11:53:40 -05:00
a00c61719b ansible-test - Fix pylint error.
This prevents `pylint` from failing with warnings reported as errors and with no test results given.

Resolves https://github.com/ansible/ansible/issues/75791
2021-09-27 14:39:17 -07:00
ac1132e2a5 [stable-2.10] ansible-test - pin antsibull to prevent failures (#75801)
A recent release of antsibull is causing docs-build sanity tests to fail and
it was not properly pinned in stable-2.10 branch.
2021-09-27 12:32:56 -07:00
036fd07bd3 Update Ansible release version to v2.10.14.post0. 2021-09-13 14:48:59 -04:00
2421b476c5 New release v2.10.14 2021-09-13 10:38:20 -04:00
667c5a4319 Update Ansible release version to v2.10.14rc1.post0. 2021-09-08 13:03:59 -04:00
7b414d094c New release v2.10.14rc1 2021-09-08 09:57:24 -04:00
e10a4d511d various fixes to command (#74212) (#74258)
* various fixes to command

  - Updated splitter to allow for all expected args in ad-hoc
  - Ensure we always return the returns we promissed to always return (i.e stderr/stdout)
  - Updated docs to clarify creates/removes precdence in checking
  - Removed abspath from chdir to allow reporting to handle symlinks correctly
  - Corrected tests to new output messages

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b3b1dde648)
2021-09-03 15:53:29 -07:00
aa08dc6633 Pipe it to connections (#73688) (#73914)
* pipelining tweaks
  added 'defaults'  entry for ini pipelining from ssh plugin

(cherry picked from commit 9690512069)
2021-09-03 15:53:00 -07:00
12c4661bbb Attributes compat (#75563) (#75621)
* ignore 'attributes' for json dump

  let existing overrides display, wont be full info but still pertinent info
  though user will have to check newer versions

(cherry picked from commit 463cf9fe24)
2021-09-02 14:03:24 -07:00
5bc16fcc15 fixed for 2.10 (#75630) 2021-09-02 14:01:54 -07:00
15cf9f1db2 Update Ansible release version to v2.10.13.post0. 2021-08-16 15:00:31 -04:00
6890692d3f New release v2.10.13 2021-08-16 13:23:25 -04:00
6919726435 Update Ansible release version to v2.10.13rc1.post0. 2021-08-10 11:44:10 -05:00
e025d9c6d0 New release v2.10.13rc1 2021-08-10 09:39:56 -05:00
ff19924a7d Fix dnf test assertion (#75426) (#75428)
(cherry picked from commit e23fdee45e)
2021-08-06 16:35:09 -07:00
c1dd0caf2a Fix dnf package matching (#75411) (#75417)
* Fix a bug with the dnf module not using all components of a package name when filtering to determine if it's installed

* changelog

* Simplify splitting on the last '.'

* Update lib/ansible/modules/dnf.py

(cherry picked from commit b541a148d5)
2021-08-06 13:02:20 -07:00
0cf5666778 [stable-2.10] allow env to override unspecified unsafe_writes (#73282) (#75396)
* allow env var for fallback value for unspecified unsafe_writes
(cherry picked from commit c7d4acc)

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
2021-08-04 15:37:54 -05:00
ef53017c1a restores delegated vars that were not passed (#74371) (#75346)
* restores delegatd vars that were not passed

   this will restore delegate display on callbacks using the vars
   also moves to use delegate_to directly on the default callback

* clog

(cherry picked from commit cbc83545582d8d7a718140263c465129e0e535d9)
(cherry picked from commit ed456f25f6)
2021-08-04 15:37:14 -05:00
93070d5dc6 Backport 2.10: Setup virtualization_facts - add RHV and oVirt type (#73905)
* Setup virtualization_facts - add RHV and oVirt type

Signed-off-by: mnecas <necas.marty@gmail.com>

* initialize sys_vendor only once

* add changelog

* Update 72876-setup-facts-add-redhat-vendor.yml

* Update linux.py
2021-08-04 15:27:21 -05:00
46819a65fa Allow to ignore rstcheck errors. 2021-08-04 08:23:02 -07:00
005833ab44 Improve 2.10 role dependency deduplication documentation (#75258) 2021-07-29 13:55:50 -05:00
b61bd959c3 Update Ansible release version to v2.10.12.post0. 2021-07-19 20:37:10 -05:00
add2dca4b1 New release v2.10.12 2021-07-19 16:42:20 -05:00
5e7b492ead Update Ansible release version to v2.10.12rc1.post0. 2021-07-13 03:07:50 -05:00
2e93c12ac5 New release v2.10.12rc1 2021-07-13 00:22:51 -05:00
3ee1694dfe [2.10] get_url: Fix checksum binary validation (#74674)
* get_url: Handle same SHA sum for downloaded files (#71435)

Fixes: #71420

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 159544610e)

* modules: get_url: Fix checksum binary validation (#74502)

From the sha512sum man page:

... The default mode is to print a line with checksum, a character indicating type ('*' for binary, ' ' for text), and name for each FILE.

(cherry picked from commit 403a5d147d)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2021-07-12 13:48:27 -05:00
e0cb0671af [bp-2.10] get_url - Allow checksum file to be local file:// (#75052)
This would be a partial solution for #69364 in that the
SHASUMS file can be downloaded and gpg verified but then
used from the downloaded location to verify the get_url's file.

* Make checksum url parsing more explicit

Use urlsplit to test if the checksum string has a (currently tested and) supported url scheme.

(cherry picked from commit eb8b3a8479)

Co-authored-by: Edwin Hermans <edwin@madtech.cx>
2021-07-09 11:38:16 -05:00
9e5091ab5c ansible-test: exposes tiny_prefix variable (#75129)
ansible-test aws provider now creates and exposes a new tiny_prefix
variable to provide a shorter prefix for the AWS tests.

(cherry picked from commit 5b8fb4dcd3)
2021-07-09 11:25:31 -05:00
e2c60cee80 Do not show empty version_added_collection values in ansible-doc text output. (#74999) (#75004)
(cherry picked from commit 58450f041a)
2021-07-09 11:23:19 -05:00
676ed22a99 [stable-2.10] Restrict packaging to < 21.0 for Python < 3.6. (#75186).
(cherry picked from commit 67bc49e001)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-07-07 11:35:16 -07:00
197458d9ac collections_using.rst: add note that manual upgrade is required when installing collections from Galaxy (#75024) (#75026)
(cherry picked from commit 5df82415b5)
2021-06-29 14:12:23 -05:00
50ef1599a1 [bp-2.10] Clarify Vault password client naming requirements (#75082)
(cherry picked from commit aedc82da98)

Co-authored-by: Andreas Olsson <andreas@arrakis.se>
2021-06-24 13:32:20 -05:00
2c2e168eff remove reference to container ML (#75014) (#75029)
(cherry picked from commit 2387ce311f)
2021-06-23 16:06:40 -05:00
b41d32c237 Due to the takeover of freenode we're moving to a different irc network. (#74775) (#75006)
* Update channel references to point at the same channel name on libera.chat
* Update generic links to https://libera.chat
* In general, use irc.libera.net for link names/text and https://libera.chat for link targets.
  The irc service is hosted on irc.libera.chat but the project web server is hosted on
  libera.chat.
* Removed http://irc.freenode.net from the linkcheck exceptions.
* Add a link to where contributors should get support
for developing groups of modules to docs/docsite/rst/dev_guide/developing_modules_in_groups.rst

Co-authored-by: John R Barker <john@johnrbarker.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 80e7e1a17c)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2021-06-23 16:03:47 -05:00
0f6c6f89ec Update Ansible release version to v2.10.11.post0. 2021-06-22 02:52:23 -05:00
4d849f9a4f New release v2.10.11 2021-06-22 00:17:41 -05:00
de4a08e22d Update Ansible release version to v2.10.11rc1.post0. 2021-06-14 22:16:35 -05:00
96681819e8 New release v2.10.11rc1 2021-06-14 17:41:42 -05:00
9e90c873c4 psrp - cleanup command (#74985) (#75000)
(cherry picked from commit 58d8397771)
2021-06-14 17:12:10 -05:00
e30ffb8499 [2.10] Fix using module-specific module_defaults in action plugins (#74850)
* Use the module redirect_list when getting defaults for action plugins (#73864)

* Fix module-specific defaults in the gather_facts, package, and service action plugins.

* Handle ansible.legacy actions better in get_action_args_with_defaults

* Add tests for each action plugin

* Changelog

Fixes #72918

(cherry picked from commit 5640093f1c)

* Fix tests for < 3.8

(cherry picked from commit 267b7215b3)
2021-06-14 10:08:10 -05:00
c6d647a8f0 psrp - Fix reset connection on failed scenarios (#74967) (#74983)
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit cf3a304ce1)
2021-06-14 08:54:39 -05:00
8aa850e357 fix unsafe preservation across newlines (#74960) (#74975)
CVE-2021-3583
  ensure we always have unsafe

Co-authored-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 4c8c40fd3d)
2021-06-11 16:43:22 -05:00
67d2d13997 Update inventory script references from c.g to ansible-community/contrib-scripts. (#74905) (#74927)
(cherry picked from commit acf09e56a2)
2021-06-07 13:53:14 -05:00
b5f15999d7 Update Ansible release version to v2.10.10.post0. 2021-05-24 17:50:56 -05:00
2c75abf14d New release v2.10.10 2021-05-24 14:49:48 -05:00
2e3c5df8eb Update Ansible release version to v2.10.10rc1.post0. 2021-05-17 18:47:05 -05:00
85dd907d0f New release v2.10.10rc1 2021-05-17 16:56:55 -05:00
093986dfaf [2.10] ansible-galaxy - increase page size and add retry decorator (#74649)
* ansible-galaxy - increase page size and add retry decorator for throttling (#74240)

* Get available collection versions with page_size=100 for v2 and limit=100 for v3

* Update unit tests for larger page sizes

* Add a generic retry decorator in module_utils/api.py that accepts an Iterable of delays and a callable to determine if an exception inheriting from Exception should be retried

* Use the new decorator to handle Galaxy API rate limiting

* Add unit tests for new retry decorator

* Preserve the decorated function's metadata with functools.wraps

ci_complete

Co-authored-by: Matt Martz <matt@sivel.net>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit ee725846f0)

* Add changelog for ansible-galaxy improvements (#74738)

Changelog for #74240

(cherry picked from commit 9cfedcd9c9)
2021-05-17 16:04:16 -05:00
ee4e3564f0 [stable-2.10] Remove leftover test file from incidental_setup_rabbitmq removal 2021-05-17 11:25:43 -07:00
e949469a17 Correctly set path and fullpath for template vars (#73924) (#74050)
* Correctly set path and fullpath for template vars

 don't expect path to always be full path
 also added exception/tb on action fail

(cherry picked from commit 22330dd322)
2021-05-17 12:11:59 -05:00
2b29428f22 [2.10] Do not remove non-empty cron tabs (#74697)
* Only remove crontabs if they are empty

(cherry picked from commit fefda12827)

* Add integration test to ensure system cron tab doesn't get removed. Increase cron integration tests separation.

(cherry picked from commit 1e37fa86b4)

* Also detect crontab which only contains whitespace as empty.

(cherry picked from commit 4b69c8f501)

* cron integration test: Adjust system crontab path to be distribution specific.

(cherry picked from commit 70be3730db)

* Add changelog fragment for #74497.

(cherry picked from commit c606b50a3d)

Co-authored-by: Fabian Klemp <fabian.klemp@elara-gmbh.de>
2021-05-17 10:12:28 -05:00
a6a2af7814 [bp-2.10] service - compare version without LooseVersion (#74619)
The distutils module is not shipped with SUNWPython on Solaris.
It's in the SUNWPython-devel package. Do not use LooseVersion.

Fixes: #74488

(cherry picked from commit 4d7dc15d4e)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2021-05-17 00:26:32 -05:00
8c95db4b8d [stable-2.10] Use our own copy of the Codecov uploader (#74460) (#74492)
Due to the recent security incident, use our own copy hosted in S3
to mitigate future risk from running an arbitrary script downloaded from a
remote and untrtusted server.
(cherry picked from commit aa12af1d34)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-05-17 00:25:58 -05:00
62d69fc724 Fix fileglob parameter order bug (#72879) (#72904)
(cherry picked from commit fe17cb6eba)
2021-05-17 00:23:06 -05:00
c34bfc58cc [stable-2.10] Remove incidental_setup_rabbitmq integration test
All tests using this have been removed..
(cherry picked from commit 8d3dce49bf)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-05-14 13:06:33 -07:00
a28aa38f6c Remove incidental_lookup_rabbitmq test.
It is no longer contributing unique code coverage.

(cherry picked from commit 26e8c07f32)
2021-05-14 12:05:57 -07:00
d1978c64e8 [stable-2.10] Remove incidental Azure tests (#74681) 2021-05-12 14:40:11 -07:00
b345760393 [stable-2.10] CI and compat fixes for Jinja2 >= 3.0 (#74666)
* Add constraint for MarkupSafe

MarkupSafe >= 2.0.0 requires Python >= 3.6.0. Add a constraint for older Python versions
and fix the `groupby_filter` test.

* Fix template_jinja2_latest test.

* patch filter decorators on newer Jinja2

* Jinja2 >= 3.0 renames several filter decorators used by Ansible itself, as well as by filters in collections. This patch ensures that the old names are usable within Ansible and by collections without warnings or errors.

* Ignore docs-build issues.

Co-authored-by: Matt Clay <matt@mystile.com>
Co-authored-by: Matt Davis <mrd@redhat.com>.
(cherry picked from commit f99d024851)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-05-12 10:10:44 -07:00
357714a7c4 [stable-2.10] Fix ansible-test AZP build lookup.
(cherry picked from commit 877e5b3dfe)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-05-04 10:13:28 -07:00
369af59c6c [stable-2.10] Remove obsolete Shippable specific scripts.
Also remove some other unncessary code from CI scripts.
(cherry picked from commit be7de9844e)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-05-04 10:13:08 -07:00
2642ddd7f3 update versions (#74432) (#74451)
(cherry picked from commit a75bae8a62)
2021-05-04 10:02:24 -05:00
c332359121 Product-related updates. (#74462) 2021-05-03 22:10:27 -05:00
e6fd6361bd Change look and feel of the ansible-core docs (#74200) (#74482)
* Change look and feel of the `ansible-core` docs (#74200)

(cherry picked from commit d7f826c987)

* lighten navigation background to make section labels easier to read for core docs (#74356)

* make section labels for /ansible-core/ docs easier to read, with black text and lighter gray background

(cherry picked from commit 6119fb0a9a)

Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-05-03 22:09:51 -05:00
6748ec169c Update Ansible release version to v2.10.9.post0. 2021-05-03 22:03:54 -05:00
d1c49f2e1c New release v2.10.9 2021-05-03 14:34:37 -05:00
b69a23fe0e [stable-2.10] incidental_setup_rabbitmq test - Use official repo for rabbitmq-erlang (#74452)
Previously it was hosted on bintray, but that service is shutting down on May 1. Using the new
repository also required using a newer version of RabbitMQ..
(cherry picked from commit 62cba4a6ad)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-05-03 13:30:54 -05:00
9afd6e8f52 Update Ansible release version to v2.10.9rc1.post0. 2021-04-27 11:46:58 -05:00
a5d4122076 New release v2.10.9rc1 2021-04-27 09:09:06 -05:00
316dbd50ed Prevent ansible_failed_task from further templating (#74290) (#74307)
(cherry picked from commit 664531d7d6)
2021-04-27 08:35:39 -05:00
cd81eddb80 fix wait_for looping when missing net module (#73963) (#74007)
fixes #43486

(cherry picked from commit c1eed681aa)
2021-04-27 08:18:24 -05:00
768c165a84 [stable-2.10] Fix pypi-test-container port conflict.
(cherry picked from commit cb7f4f1971)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-04-26 23:00:18 -07:00
115e5998f4 Actually run blocks/finalized_task test (#74291) (#74311)
(cherry picked from commit 7fecb7ccc3)
2021-04-26 10:29:27 -05:00
55ad72992d defend against bad or missing crypt (#74304)
* defend against bad or missing crypt

  fixes #74279

(cherry picked from commit 4494ef3a9d)
2021-04-26 10:28:56 -05:00
80f8b90b43 removed unused imports (#74299)
(cherry picked from commit e3eeb88f7c)
2021-04-26 10:28:56 -05:00
768f3d75f9 Map Debian 8 to Python 2 (#74152) (#74360)
If Python 3 is installed on Debian 8 Ansible cannot run, as the version
is too old (3.4)

* Add integration test for python interpreter discovery on Debian 8
* fix test issue on Debian 9, add changelog
* un"fix" not broken test :D

Co-authored-by: Fabian Klemp <fabian.klemp@elara-gmbh.de>
Co-authored-by: Matt Davis <mrd@redhat.com>
(cherry picked from commit 437a08eb6d)

Co-authored-by: elara-leitstellentechnik <elara-leitstellentechnik@users.noreply.github.com>
2021-04-26 10:22:27 -05:00
cb4209489f [stable-2.10] Fix ansible-test docker container IP detection.. (#74389)
(cherry picked from commit 14ff5e213c)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-04-26 10:21:32 -05:00
0d25d392aa Detect Homebrew on Mac M1 (Apple Silicon) (#74378) (#74400)
Homebrew's default install location for macOS on ARM is /opt/homebrew.
Source: https://docs.brew.sh/FAQ

On a Mac M1 (Apple Silicon), homebrew will be installed at
/opt/homebrew/bin/brew.
2021-04-26 10:20:33 -05:00
db5b2faf2e pin docutils to 0.16 until theme problem is fixed (#74193) (#74399)
(cherry picked from commit 7443e9d659)
2021-04-23 10:09:35 -05:00
c2f2041be1 Backport/2.10/docs config (#74278)
* update intersphinx links for Ansible 3

(cherry picked from commit 481c036632)

* updates list of available versions for Ansible 3 (#74265)

(cherry picked from commit 126e9244c2)

Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-04-16 16:04:44 -05:00
621d1a94ab undeprecated hash_merge setting (#73328) (#74219)
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Sloane Hertel <shertel@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-04-13 13:22:18 -05:00
cc99cfbf9b [stable-2.10] Bump azure-pipelines-test-container to version 1.9.0
(cherry picked from commit 4819e9301b)

Co-authored-by: Alexander Sowitzki <asowitzk@redhat.com>
2021-04-13 10:58:46 -07:00
3d11b480d0 [stable-2.10] Switch to hashlib.sha256() for ansible-test (#72411) (#74169)
When FIPs mode is enable on centos-8, we are not able to load md5
functions.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit a95213d2f5)

Co-authored-by: Paul Belanger <pabelanger@redhat.com>

Co-authored-by: Paul Belanger <pabelanger@redhat.com>
2021-04-12 20:57:10 -05:00
19ab9ed7b9 [stable-2.10] ansible-test - ensure trailing separator is added for connection unit test target (#74176) (#74181)
For connection units tests, if the `__init__.py` file is modified, the trailing separator was
not added, making the target invalid.
(cherry picked from commit 7b79b69369)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-04-12 20:56:19 -05:00
f5e27ef7ea [stable-2.10] Add PyPI proxy container for tests on Python 2.6. (#74205)
(cherry picked from commit becf941673)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-04-12 20:55:45 -05:00
3c19c9e02b Update Ansible release version to v2.10.8.post0. 2021-04-12 20:53:07 -05:00
675691ce52 New release v2.10.8 2021-04-12 17:13:49 -05:00
e11c2a7b16 Update Ansible release version to v2.10.8rc1.post0. 2021-04-05 21:50:45 -05:00
6011ef5f55 New release v2.10.8rc1 2021-04-05 19:34:12 -05:00
9f74f0663a Nonfatal facts (#73804) (#73830)
continue with local facts vs at script error
 actually capture execution errors
 better error messages in general
 add more local facts tests

 fixes #52427

(cherry picked from commit 9db557e431)
2021-04-05 12:53:10 -05:00
1995b1b6e0 find - set proper default based on use_regex (#73961) (#73965)
When using "use_regex: yes" and setting an excludes: without
specifying a pattern: the existing code passes the file-glob '*' to
the regex matcher.  This results in an internal invalid-regex
exception being thrown.

This maintains the old semantics of a default match-all for pattern:
but switches the default to '.*' when use_regex is specified.

The code made sense as-is before excludes: was added (2.5).  In that
case, it made no sense to set use_regex but *not* set a pattern.
However, with excludes: it now makes sense to only want to exclude a
given regex but not specify a specific matching pattern.

Closes: #50067

* moved change to new location
added changelog

* Update lib/ansible/modules/find.py

Co-authored-by: Ian Wienand <iwienand@redhat.com>
(cherry picked from commit 089d0a0508)

* Fix up bad rebase, nuke duplicate "elements:" lines

Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-04-05 09:16:45 -05:00
7683dfb727 Fix setup subset (#74022) (#74047)
* fix error msg on bad subset
* added test
* handle more raised but not handled fact exceptions

(cherry picked from commit 4a82e2c486)

* Update fix_setup_bad_subset.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
2021-04-05 01:34:26 -05:00
adae63e053 Fix debug factsetter (#74067) (#74084)
* Fix debug factsetter (#74067)

* prevent debug from setting namespaced facts as tlv
* also added tests

(cherry picked from commit f9f839fa08)

* Update debug_dont_set_facts.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
2021-04-05 01:31:51 -05:00
40543aa8db fix su localization option [2.10] (#73878)
* fix su localization optoin

  fixes #73837

(cherry picked from commit 37cb550185)

* Update su_fix.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
2021-04-05 00:22:26 -05:00
69d18e61ed module output is only json objects (#73765) (#73777)
remove json lists as they are not valid from modules
 fixes #73744

(cherry picked from commit 43300e2279)
2021-04-04 23:02:23 -05:00
51852557df add optional module_utils import support (#73832) (#73918)
Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement).

* sanity test fixes

(cherry picked from commit 3e1f6484d7)
2021-04-04 21:46:28 -05:00
7ce0b390b2 Fix a bug adding unrelated candidates to the plugin loader redirect_list (#73863) (#73958)
* Add tests for the redirect list

  * test redirect list for builtin module
  * test redirect list for redirected builtin module
  * test redirect list for collection module
  * test redirect list for redirected collection module
  * test redirect list for legacy module

* changelog

(cherry picked from commit 48c0fbd1cb)
2021-04-04 21:45:52 -05:00
f01227ea42 [stable-2.10] Ensure task from the worker is finalized/squashed (#73881) (#73928)
* Ensure task from the worker is finalized/squashed. Fixes #57399. Fixes #49942
(cherry picked from commit 832631b)

Co-authored-by: Matt Martz <matt@sivel.net>
2021-04-04 21:41:38 -05:00
b6b7e0081b [stable-2.10] find: Specify elements type in paths (#70139) (#73970)
Fixes: #35990

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 87406890cf)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2021-04-04 21:36:08 -05:00
f1f2d96456 Fix wrong backup directory var name in apt module (#73840) (#74002)
(cherry picked from commit 2bff120db6)
2021-04-04 21:35:24 -05:00
502f7c22d9 [stable-2.10] Fix ansible-test coverage exporting.
ci_complete
ci_coverage
(cherry picked from commit b75844af45)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-03-30 18:17:51 -07:00
e29a78104f [stable-2.10] dnf test - update libmodulemd when updating python3-dnf (#74025)
The dependency version is set too low in the latest version of the package.

https://bugzilla.redhat.com/show_bug.cgi?id=1942236
(cherry picked from commit fa1b52ce55)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-03-24 13:16:54 -07:00
7ef1a2f830 Ensure unit test paths for connection and inventory plugins are based on the context (#73877) 2021-03-19 08:44:10 -07:00
3dcdde996c fix 2.10 version (#73788) 2021-03-16 15:52:36 -05:00
da0481c6b3 Update Ansible release version to v2.10.7.post0. 2021-03-15 19:54:40 -05:00
4226af2718 New release v2.10.7 2021-03-15 17:35:04 -05:00
0d4146cb64 Mention that minor releases end once the next ansible release is made. (#73836) (#73868)
(cherry picked from commit 197e8f5640)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2021-03-11 17:28:15 -06:00
1741ba2d67 Docs: Update installation page for package split (#73790) (#73866)
(cherry picked from commit 31932f5fa3)

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2021-03-11 17:25:55 -06:00
2cca1c509a Add note on infoblox inventory script. (#73676) (#73759)
(cherry picked from commit c888705493)
2021-03-11 17:25:34 -06:00
1eaa02c880 Update Ansible release version to v2.10.7rc1.post0. 2021-03-09 00:10:26 -06:00
573d767dcb New release v2.10.7rc1 2021-03-08 21:44:34 -06:00
df5d595984 Don't fail for mixed typed keys (#73726) (#73776)
but warn that content cound not be sorted because of this

* added tests

(cherry picked from commit 527bff6b79)
2021-03-08 14:58:02 -06:00
d78867e493 move firewalld to ansible.posix (#70692) (#73689)
* move firewalld to ansible.posix (#70692)

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit b479adddce)

* Update changelogs/fragments/73689-move-firewalld-to-ansible-posix.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Adam Miller <admiller@redhat.com>
2021-03-08 11:57:02 -06:00
9a86f8c10e [2.10][InventoryManager] Fix two unhandled exceptions (#73798)
Change:
- Fix regression: unhandled exception when given inventory directory
  is empty or contains empty subdirectories.
- Fix unhandled exception when limit file is actually a directory
  instead of a file.
- Fix inventory tests which previously could never fail due to missing
  `set -e`. Fixed up tests that failed after `set -e` was added. Added
  several tests.

Test Plan:
- New tests
- Fixed existing tests which previously could never fail

Tickets:
- Fixes #73658

Signed-off-by: Rick Elrod <rick@elrod.me>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit fa046d302c)

Co-authored-by: Rick Elrod <rick@elrod.me>
2021-03-08 04:55:55 -06:00
a1a57c699e module_utils: ensure find_mount_point consistently returns text (#73625) (#73710)
(cherry picked from commit dabfee4d5c)
2021-03-08 04:52:54 -06:00
65037d4781 [stable-2.10] Normalize ConfigParser between Python2 and Python3 (#73715) (#73723)
* [stable-2.10] Normalize ConfigParser between Python2 and Python3 (#73715)

* Normalize config parser between py2 and py3

* Add tests and changelog

* Use different config entry, since we supply certain env vars
(cherry picked from commit 950ab74)

* Update config entry
2021-03-08 04:29:58 -06:00
ebe0ed9331 [stable-2.10] hostname - add Almalinux support (#73619) (#73648)
(cherry picked from commit ac0dedda72)

Co-authored-by: Aaron Guise <guisea@users.noreply.github.com>
2021-03-08 04:28:07 -06:00
3e95e3c0a0 galaxy: Handle ignored directory names in role skeleton (#72035) (#73806)
* galaxy: restore left hand slicing in assignment

Fix 'ansible-galaxy role init --role-skeleton=role-skeleton' when the role skeleton
contains an ignored directory.

The issue was because the 'dirs' variable was changed to reference a different list,
but needs to be mutated instead to stop os.walk from traversing ignored directories.

Fixes: #71977

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit eb72c36a71)

Co-authored-by: manas-init <70483021+manas-init@users.noreply.github.com>
2021-03-08 04:26:47 -06:00
ece31e1b51 [2.10] find module - stop dir traversal when depth is exceeded (#73808)
* find module - stop traversing directories with os.walk when depth is already exceeded (#73718)

(cherry picked from commit 8628c12f30)

* Update tests since there are fewer prior tasks creating files/directories
2021-03-08 04:18:02 -06:00
b1d278a595 ansible-test: yamllint, check the assigment (#73583)
Ensure `yamllint`'s `check_assignment()` correctly ignore the
attribute assignment. Those don't have any `.id` attribute and will
trigger an `AttributeError` exception.

See: https://github.com/ansible/ansible/pull/73322
(cherry picked from commit 0a8d5c0983)
2021-03-08 04:16:09 -06:00
ab8bbe269d [stable-2.10] Let vault lookup output unicode string. (#73571) (#73573)
Until now, the lookup plugin returned a byte string.
Changed this to output a unicode string instead.
(cherry picked from commit d0fda3e901)

Co-authored-by: Alexander Sowitzki <asowitzk@redhat.com>
2021-03-08 04:15:28 -06:00
e85732f7e6 [ansible-test] attempt to work around podman (#72096) (#73569)
Change:
- podman > 2 && < 2.2 does not support "images --format {{json .}}"
- podman also now outputs images JSON differently than docker
- Work around both of the above.

Test Plan:
- Tested with podman 2.0.6 in Fedora 31.

Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 0332046699)

Co-authored-by: Rick Elrod <rick@elrod.me>
2021-03-08 04:12:38 -06:00
2f51105936 only add data when there is data to add (#54559) (#73566)
Only add data when there is data to add

  also avoid clobbering existing data with empty file
  fixes #45843

* remove redundant code, update comments
* fix mock dataloader, original does not return None
* added test

(cherry picked from commit ec8a556538)
2021-03-08 04:07:44 -06:00
5647f8aa55 [stable-2.10] Bump azure-pipelines-test-container to version 1.8.0 (#73549)
(cherry picked from commit c3e2bdd3a8)

Co-authored-by: Alexander Sowitzki <asowitzk@redhat.com>
2021-03-08 03:15:10 -06:00
77b76a3270 [stable-2.10] Add AlmaLinux to the family of Red Hat-like operating systems (#73541) (#73543)
* Add changelog and fixtures for AlmaLinux support

Co-authored-by: Christoph Schug <com+github@schug.net>
(cherry picked from commit 2f5c83dfb1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-03-08 03:14:54 -06:00
d720a5e42c [stable-2.10] Don't treat host_pinned as lockstep (#73484) (#73504)
* [stable-2.10] Don't treat host_pinned as lockstep (#73484)

* Don't treat host_pinned as lockstep. Fixes #73364

* Add intg tests.
(cherry picked from commit d3f3784b86)

Co-authored-by: Matt Martz <matt@sivel.net>

* Make non-lockstep callback tests more deterministic (#73511)

(cherry picked from commit 125c220343)
2021-03-08 03:14:02 -06:00
0a6004d9ca add base 2.10 to docs version switcher (#73770) (#73773)
(cherry picked from commit 6514027957)
2021-03-03 14:23:06 -06:00
c86a498a67 Backport of Split Ansible docs from core docs (#73616) (#73637)
* Split Ansible docs from core docs (#73616)

* excludes scenario guides from core docs, splits porting guides and roadmaps, symlinks indices to create index.html pages, and adds .gitignore entries for conf.py and the toplevel index.rst files generated by the docs build

This solution builds three types of docs:
* ansible-2.10 and earlier: all the docs.  Handle this via `make webdocs
  ANSIBLE_VERSION=2.10`
* ansible-3 and later: a subset of the docs for the ansible package.
  Handle this via `make webdocs ANSIBLE_VERSION=3` (change the
  ANSIBLE_VERSION to match the version being built for.
* ansible-core: a subset of the docs for the ansible-core package.
  Handle this via `make coredocs`.

* `make webdocs` now always builds all the collection docs
*  Use `make coredocs` to limit it to core plugins only
*  The user specifies the desired version. If no ANSIBLE_VERSION is specified, build plugins for the latest release of ansible

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit ccbfdec334)

* fix CI failures, correct version switcher and makefile logic, set args in all cases, allow 2.10 build

Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2021-03-03 09:42:00 -06:00
b998f7050b [stable-2.10] Fix ansible-test handling of egg-info. (#73595)
* Add test to verify pkg_resources imports work.

(cherry picked from commit 133a29acb4)

* [stable-2.10] Fix ansible-test handling of egg-info.

Resolves https://github.com/ansible/ansible/issues/67990.
(cherry picked from commit d092356fc5)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-03-02 11:12:44 -08:00
a5f0bc0165 Update signing key used in incidental_setup_flatpak_remote tests
The original key was created using the default expiration time of two years.
Signed the repo again using a key that expires in twenty years.
2021-02-22 12:30:16 -08:00
894df504b7 Update Ansible release version to v2.10.6.post0. 2021-02-18 18:31:43 -06:00
9ea56ff292 New release v2.10.6 2021-02-17 16:10:38 -06:00
510ef832ae Update Ansible release version to v2.10.6rc1.post0. 2021-02-08 23:06:02 -06:00
244fdf324c New release v2.10.6rc1 2021-02-08 19:01:35 -06:00
aedc7301f6 [stable-2.10] Temporary fix for cryptography issues. (#73530). (#73533)
(cherry picked from commit 1a2da990a4)

Co-authored-by: Matt Clay <mclay@redhat.com>
2021-02-08 17:21:15 -06:00
5411090f51 Bump antsibull-changelog version for changelog sanity test.
(cherry picked from commit 82cdd7e735)
2021-02-08 09:04:07 -08:00
f9572a377d [stable-2.10] pause - adjust warning when run in background (#73182) (#73231)
When the pause module is run in the background and seconds parameter is provided,
do not warn.

* Add tests
* Fix existing tests
  The test wasn't failing when it should have.
(cherry picked from commit 0e6c334115)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-02-07 17:57:31 -06:00
bca57ec65a bugfix: use to_text(stdout) in psrp.Connection.put_file method (#73491) - 2.10 (#73496)
(cherry picked from commit f271d02a9f)

Co-authored-by: jakegatsby <39974194+jakegatsby@users.noreply.github.com>
2021-02-07 17:56:59 -06:00
e75570ba83 [stable-2.10] Fix YAML error message when error is at the end of the file (#73241) (#73296)
If a YAML file fails to load due to a syntax error in a file, or there is an error in the last line of a
file, PyYAML reports the last line number of the file as the index where the error occurred.

When reading the file lines, we use that index to the get the relevant line.  If the index value is out
of range, the relevant line is lost for error reporting.

Subtract one from the index value to avoid the IndexError in this specific scenario. It is possible
to still get an IndexError, which will be handled as it is currently.

* Update existing tests and add new tests
(cherry picked from commit e8d4b62b41)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-02-07 17:56:17 -06:00
3ef061bdc4 Use a pty for local connections (#73023) (#73281)
Fixes #38696

Co-authored-by: James Cammarata <jimi@sngx.net>
(cherry picked from commit 30d93995dd)
2021-02-07 17:53:10 -06:00
63ead90ab9 Always mention the name of the deprecated plugin in routing deprecation messages (#73059) (#73237)
(cherry picked from commit df9cf368c0)
2021-02-07 17:52:29 -06:00
70fb5ae36a [stable-2.10] facts - properly report virtualization facts for Linux guests on bhyve (#73204). (#73233)
(cherry picked from commit df451636e7)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-02-07 17:50:49 -06:00
9478b59da5 fix inventory source parse error handling (#73160) (#73276)
fixes #51025

added test cases

(cherry picked from commit 1e27d4052a)
2021-02-07 17:29:07 -06:00
2c8c02c816 Local vars should have highest precedence in AnsibleJ2Vars (#72830) (#73370)
Ability to add local variables into AnsibleJ2Vars was added in
18a9eff11f to fix #6653. Local variables
are added using ``AnsibleJ2Vars.add_locals()`` method when creating a
new context - typically when including/importing a template with
context. For that use case local template variables created using
``set`` should override variables from higher contexts - either from the
play or any parent template, or both; Jinja behaves the same way.

Also removes AnsibleJ2Vars.extras instance variable which is not used.

Also adds missing test for #6653.

Fixes #72262
Fixes #72615

ci_complete

(cherry picked from commit a2af8432f3)
2021-02-07 01:30:47 -06:00
e41d1f0a3f no_log mask suboption fallback values and defaults CVE-2021-20228 (#73487) (#73494)
(cherry picked from commit 0cdc410dce)
2021-02-07 01:11:27 -06:00
67a018b815 fix typo (#73479)
(cherry picked from commit f72dec16ea)
2021-02-07 01:09:28 -06:00
015ec3eda8 git: verify, only use --raw when we need it (#70900) (#73473)
Change:
- Allow older git to verify tags again
- Enable verification tests everywhere, even if most of them only work
  on newer git. Some of them work on older git and they test the --raw
  parameter.

Test Plan:
- Re-enabled subset of git tests

Tickets:
- Fixes #64469

Signed-off-by: Rick Elrod <rick@elrod.me>
2021-02-07 01:08:04 -06:00
6df8a9ec53 Fix warning for nonexistent inventory cache (#72840) (#73443)
* Fix inventory cache warning by checking if the key exists before loading it

(cherry picked from commit 840bdc1e10)
2021-02-07 01:05:20 -06:00
148240099a ensure unsafe writes fallback (#70722) (#73144)
* Ensure we actually fallback to unsafe_writes when set to true

 add integration test
 add fix for get_url not passing the parameter from args

(cherry picked from commit 932ba36160)

* Added clog missing for issue 70722 (#73175)

(cherry picked from commit d6670da1d7)
2021-02-07 01:03:43 -06:00
e9c6b382ea [stable-2.10] import_playbook - change additional params to deprecation (#72987) (#73015)
I incorrectly recommended this be set as a warning when it should have been a deprecation.

* Fix deprecation sanity test to not required a collection name when not inside a collection
(cherry picked from commit 8e022ef00a)

Co-authored-by: Sam Doooran <sdoran@redhat.com>
2021-02-07 00:52:15 -06:00
3eafe0f255 [setup_rpm_repo test] Ensure rpm-build is present (#73516) (#73518)
Change:
- Other targets might remove rpm-build as they clean up after
  themselves. Ensure that it's present in setup_rpm_repo because
  rpmfluff needs it.

Test Plan:
- Local experimentation with yum_repository and mysql_db (the latter of
  which depends on a handler which was removing rpm-build) on
  stable-2.9.

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit aca5b0e43b)
2021-02-05 15:37:46 -06:00
457dcf1313 [stable-2.10] Make yum_repository test more reliable (#73467)
* Improve setup_rpm_repo

- add handlers to remove repos
- add variable to control whethere or not repos are created

* Use local repo for all distros
* Change repo creation script to module.
(cherry picked from commit 997b2d2a19)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-02-03 23:01:07 -08:00
985a395cd9 validate_modules: fails with .id attribute not found (#73322)
* validate_modules: fails with .id attribute not found

This patch addresses a problem in the `found_try_except_import` test.

This module tries to identify lines like:

`HAS_FOO = True`

In this case, the target (`HAS_FOO`) is of type `ast.Name` and has a
`id` attribute which provide the name.

In my case, I've a line that set a module attribute`. In this case, the
target (`module.var`) has the type `ast.Attribute` and no `id`
attribute. The code trigger an `AttributeError` exception.

This patch ensures we compare a `ast.Name`.

* Update test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py

(cherry picked from commit 7cf80f50d1)
2021-02-03 09:07:14 -08:00
6cde1cdf35 Documentation: fix formatting (#73186) 2021-02-03 10:18:41 -06:00
dcec0ec806 Make sure to mention collection version for version_added as well. (#73270) (#73280)
(cherry picked from commit 73aa571305)
2021-02-03 09:20:30 -06:00
d7b562b393 add new glossary terms for 2.10 (#71813) (#73293)
* add new terms for 2.10
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>

(cherry picked from commit 4aedd1b987)

Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-02-03 09:19:46 -06:00
d5acbfd6e3 Remove 'type: complex' from the example, and mention that it should be avoided. (#73171) (#73222)
(cherry picked from commit 270385f949)
2021-02-03 09:18:06 -06:00
4488b91699 Fix versionadded syntax @ galaxy user guide (#73350)
(cherry picked from commit 6abeabaff1)
2021-02-02 11:17:13 -06:00
25962888ac Mention that C(...) should be used for inline code. (#73312) (#73374)
(cherry picked from commit 76604397cb)
2021-02-02 11:16:03 -06:00
a3175e9979 Revert "[ansible-test] Bump CentOS 6 image (yum repos) (#73446) (#73447)" (#73450)
This reverts commit e4f8d528b9.
2021-02-01 22:02:55 -06:00
e4f8d528b9 [ansible-test] Bump CentOS 6 image (yum repos) (#73446) (#73447)
Change:
- Bump centos6 image version to one which includes multiple fallbacks
  for vault.centos.org content.

Signed-off-by: Rick Elrod <rick@elrod.me>
2021-02-01 18:37:24 -06:00
356aae0e23 [2.10] Add Ubuntu 20.04 to CI and ansible-test (#69161) (#73365)
Change:
- Add Ubuntu 20.04 to CI now that venv is default instead of virtualenv in ansible-test.

Test Plan:
- CI

Tickets:
- Fixes #69203

Signed-off-by: Rick Elrod <rick@elrod.me>
2021-01-26 13:01:31 -06:00
c47ec375fa [stable-2.10] Use a versioned pip bootstrapper in ansible-test. (#73359)
(cherry picked from commit fc590aeb21)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-01-25 15:37:30 -06:00
1f90c11782 [stable-2.10] Handle get-pip.py breaking change on Python 2.7.
(cherry picked from commit 484e4af4d0)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-01-23 12:36:28 -08:00
e5b6d2aaae Update Ansible release version to v2.10.5.post0. 2021-01-18 18:19:05 -06:00
890601dcef New release v2.10.5 2021-01-18 14:34:40 -06:00
a8ebe99c98 Revert "update the docs requirements versions (#73108) (#73251)"
This reverts commit ee46fe2910.
2021-01-15 14:38:05 -08:00
0803063424 Revert "update rstcheck and sphinx versions in contraints (#73176) (#73249)"
This reverts commit 2a91ba71b2.
2021-01-15 14:34:58 -08:00
ee46fe2910 update the docs requirements versions (#73108) (#73251)
(cherry picked from commit 0936623901)
2021-01-15 12:45:17 -06:00
2a91ba71b2 update rstcheck and sphinx versions in contraints (#73176) (#73249)
* and fix test error

(cherry picked from commit 88763c7347)
2021-01-15 12:44:36 -06:00
0b77ffb980 Update Ansible release version to v2.10.5rc1.post0. 2021-01-11 21:28:30 -06:00
422b9c09ee New release v2.10.5rc1 2021-01-11 17:33:09 -06:00
08ba838a8e [2.10] Pass the top level dictionaries to combine_vars (#72979) (#73146)
combine_vars uses dict.update() to replace keys

(cherry picked from commit 5e03e322de)

* Add tests for merging and replacing vars from inventory sources (#73181)

(cherry picked from commit 9de2da8a7e)
2021-01-11 17:20:48 -06:00
abc6658ac2 [stable-2.10] Add macOS 11 to CI (#72622) (#73180)
* [stable-2.10] Add macOS 11 to CI (#72622)

* Fix connection_paramiko_ssh test for macOS 11
* Update Azure Pipelines config
* Add changelog
(cherry picked from commit a7e834071c)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Prefer venv for tests

* Update pip integration test to use venv on py3.

(cherry picked from commit 456e9b7a33)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-01-11 16:45:58 -06:00
b4b1bf9932 [stable-2.10] user - properly handle password and password lock when used together (#73016) (#73177)
Do the right thing on Linux when password lock and a password hash are provided by writing
out the password hash prepended by the appropriate lock string rather than using -U and -L.
This is the correct way to set and lock the account in one command.

On BSD, run separate commands as appropriate since locking and setting the password cannot
be done in a single action.

FreeBSD requires running several commands to get the account in the desired state. As a result,
the rc, output, and error from all commands need to be combined and evaluated so an accurate
and complete summary can be given at the end of module execution.

* Improve integration tests to cover this scenario.
* Break up user integration tests into smaller files
* Properly lock account when creating a new account and password is supplied

* Simplify rc collection in FreeBSD class
  Since the _handle_lock() method was added, the rc would be set to None, which could make
  task change reporting incorrect. My first attempt to solve this used a set and was a bit too
  complicated. Simplify it my comparing the rc from _handle_lock() and the current value of rc.

* Improve the Linux password hash and locking behavior
  If password lock and hash are provided, set the hash and lock the account by using a password
  hash since -L cannot be used with -p.

* Ensure -U and -L are not combined with -p since they are mutually exclusive to usermod.

* Clarify password_lock behavior..
(cherry picked from commit 264e08f21a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-01-11 13:11:26 -06:00
6ba066fc9e [stable-2.10] Fix async interpreter parsing (#72636) (#72923)
Fixes #70690
(cherry picked from commit 83764ad)
2021-01-11 01:02:33 -06:00
b22d97b2c1 [stable-2.10] Fix string/bytestring comparsion in m_u.basic (#70439) (#73129)
Change:
- module_utils.basic.is_special_selinux_path() used a string ==
  bytestring comparison which returned False and made Ansible think that
  certain filesystems aren't, in fact, special-cased, when they should
  be. Ensure both sides of the == are bytestrings.

Test Plan:
- Added `copy` integration tests for this case.

Tickets:
- Fixes #70244

Signed-off-by: Rick Elrod <rick@elrod.me>.
(cherry picked from commit 688cd8657b)
2021-01-11 00:55:15 -06:00
1cd09b1ebc [stable-2.10] systemd - do not overwrite unit name when searching (#72985) (#73013)
PR #72702 introduced a bug that changed the unit name when splitting it up for the purpose
of searching for the unit. This only happens on unit file templates on systems that have a 5.8
or newer kernel and a version of systemd that does not contain a bugfix that causes systmed
to fail to parse dbus.

* Use facts rather than a manual probe to determine if systmed is present
* Remove unnecessary block
* Use vars files instead of set_fact
* Add tests for using a templated unit file
* Update changelog fragment
* Use template to get correct path to sleep binary
(cherry picked from commit 48803604cd)

Co-authored-by: Sam Doooran <sdoran@redhat.com>
2021-01-11 00:47:00 -06:00
cf21e699d4 Update ansible-test pylint Python support. (#72997)
* Rename pylint plugin and add tests. (#70225)
* Update ansible-test pylint Python support. (#72972)
* Add integration tests for sanity test failures.
(cherry picked from commit fa48678a08)

* Python 3.8 is now officially supported.
* Python 3.9 is now skipped with a warning.
(cherry picked from commit 37d09f2488)

* Allow key None to prevent errors with import test.
(cherry picked from commit dbc2c996ab)

Backport of https://github.com/ansible/ansible/pull/73003

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-01-11 00:46:21 -06:00
31ef9dffa1 [stable-2.10] Remove exit code from traps in tests (#72968)
Having the trap exit with a specific code will override
the exit code that caused the trap to run, which could
mask errors
(cherry picked from commit 5157a92139)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-01-11 00:42:18 -06:00
c5248f756c Collection list site packages (#70173) (#72940)
* ansible-galaxy collection list and verify now utilize collections in site-packages.

This is a short term fix for #70147.  The long term fix needs to handle
install (but that discussion is also bound up in how upgrade is going to
work and where things can get installed so it's deferred for 2.11.)

* Add test for ansible-galaxy collection list with site-packages

Co-authored-by: David Moreau Simard <moi@dmsimard.com>
Co-authored-by: Jordan Borean <jborean93@gmail.com>
(cherry picked from commit e7dee73774)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2021-01-11 00:41:56 -06:00
511ffdeff7 [stable-2.10] Fix reset_connection paramiko, winrm, psrp (#72688) (#72925)
* Ensure we only reset the connection when one has been previously established. Fixes #65812

* Ensure psrp doesn't trace

* winrm too

* Indentation fix
(cherry picked from commit a3b6485)

Co-authored-by: Matt Martz <matt@sivel.net>
2021-01-11 00:36:05 -06:00
82b75282fc Fix task get_name to always prepend the role name (#72511) (#72919)
* Fix 'role_name : tast_name' notation if task contains role name

* Add tests for notifying handler names which contain the role name

Co-authored-by: Thomas Wouters <thomaswouters@gmail.com>
(cherry picked from commit 0ed7bfc694)
2021-01-11 00:28:57 -06:00
a5df30e2bf Use _wrap_native_text only for builtin STRING_TYPE_FILTERS (#71801) (#72915)
(cherry picked from commit 252685092c)
2021-01-11 00:22:01 -06:00
7006b62ff4 Documentation: fix modules doc formatting (#72851) 2021-01-10 23:25:48 -06:00
7c44c24456 modules: fix documentation formatting (#72737) (#72850)
(cherry picked from commit ebd8c101fd)
2021-01-10 23:25:13 -06:00
c4adf62220 Docsite: update "Migrating Ansible content to a different collection" info (#72710) (#72849)
* add a reminder about ignore-*.txt entries, fix formatting, add symlink removal note
* Update docs/docsite/rst/dev_guide/developing_collections.rst

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: David Moreau Simard <moi@dmsimard.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit 0a7fcd135c)
2021-01-10 23:24:49 -06:00
9601d3ef20 Docsite: update complex_data_manipulation and playbooks_advanced_syntax rst files to use FQCNs (#72848) 2021-01-10 23:24:04 -06:00
2f3e9a38b6 Backport/2.10/73079 (#73165)
* Update apt.py, add an example that references the suggested workaround in #25414
(cherry picked from commit 1e1b8e7aca)
(cherry picked from commit 180bbfed6a)

* Added changelog fragment
2021-01-08 16:38:44 -06:00
4452d98662 Support venv in ansible-test virtualenv scripts (#73163)
* ansible-test - prefer venv over virtualenv on Python 3 (#73000)

Also pin virtualenv to 16.7.10 for older Mac OS X systems. This was the version being installed
anway with the previous constraint (<20).

On systems with Python 3, now prefer venv over virtualenv. Test to see if venv is functional since
some systems have a non-functional venv installation (such as Debian).

(cherry picked from commit 850a77f639)

* Make the new ansible-test venv behavior opt-in

Co-authored-by: Sam Doooran <sdoran@redhat.com>
2021-01-08 16:31:17 -06:00
17566d7a17 Documentation: fix modules doc formatting (#73037) 2021-01-08 13:19:05 -06:00
3df8811ace Remove inaccurate Vault documentation (#72938) (#72978)
This is not functionality that exists.
(cherry picked from commit 8450858651)
2021-01-08 13:04:51 -06:00
ee97763a3a [stable-2.10] Update azure pipelines container
(cherry picked from commit 0eb1e22cd9)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-01-08 09:15:47 -08:00
4d231a86b7 Rewrite Docker scenario guide (#73069) (#73135)
(cherry picked from commit c9f28c1735)
2021-01-07 15:45:37 -06:00
2246e1a0fb [2.10] galaxy: Update example for git+file (#73115)
Use correct syntax for installation of role from local git repository. Fixes: #72217

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 776274143f)
2021-01-07 14:12:56 -06:00
dc8d0c4d62 Add link to all module and plugin indexes (#72743) (#73099)
* Add link to all module and plugin indexes, use glob setting for toctree.
* Adjust .gitignore
* Fix docs make clean: now that there's a static file in rst/collections, we have to be more
explicit about how we clean the generated files out of that directory.

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
(cherry picked from commit b514200126)
2021-01-07 14:10:52 -06:00
6b935947c1 left a stray </div> by mistake (#73132) (#73133)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit 1d8760779c)
2021-01-06 11:35:34 -06:00
26e207d344 remove doc survey banner (#73119) (#73125)
(cherry picked from commit 0a3c5d9dcc)

Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-01-05 16:25:12 -06:00
db41f2e384 [stable-2.10] Constrain pexpect and ptyprocess (#73109)
The recent update of ptyprocess to 0.7.0 is incompatible with Python 2.6 and
is causing test failures.

* Add setup_pexpect role to expect test
(cherry picked from commit 003a9e890d)

Co-authored-by: Sam Doooran <sdoran@redhat.com>
2021-01-04 13:54:36 -08:00
8f71aead87 [stable-2.10] Update Azure Pipelines scripts and config. (#72986)
* Increase fetch depth to reduce the frequency of full test runs for out-of-date PRs.
* Update scripts to match those which will be used in collections.
(cherry picked from commit 3274e02fd8)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-12-15 17:05:13 -08:00
02e3e679a2 Update Ansible release version to v2.10.4.post0. 2020-12-14 20:26:43 -06:00
436d8a13b4 New release v2.10.4 2020-12-14 14:44:44 -06:00
12b33c79ee [stable-2.10] Fix cryptography constraints in ansible-test. (#72914) (#72922)
(cherry picked from commit 36ab3d1189)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-12-09 14:41:15 -06:00
7461f873ef add docs survey banner (#72907) (#72909)
* add docs survey banner, with date

(cherry picked from commit 6098793315)
2020-12-08 15:46:36 -06:00
c72d53218a Update Ansible release version to v2.10.4rc1.post0. 2020-12-08 09:22:14 -06:00
dc7faeaf6e New release v2.10.4rc1 2020-12-07 19:05:36 -06:00
1f55a3d15a avoid fatal exception on invalid collection name (#72296) (#72570)
* avoid fatal exception on invalid collection name used in ansible-doc filter

(cherry picked from commit 4f0e2fff95)
2020-12-07 18:37:01 -06:00
847a2c87e5 Fix AIX networks facts when nestat is either missing or has incorrect permissions (#72516) (#72713)
* Added check for none on netstat_path variable

* Added changelog

(cherry picked from commit e879f12fb9)
2020-12-07 18:31:29 -06:00
d852fa4135 remove redundant remote_user for local setting (#72507)
* remove redundant remote_user for local setting

  local action plugin already does and this also should fix
  fork/thread issue by removing use of pwd library

  fixes #59642

(cherry picked from commit 488b9d6c35)

* ensure local exposes correct user (#72543)

* ensure local exposes correct user

  avoid corner case in which delegation relied on
  playcontext fallback which was removed

  fixes #72541

(cherry picked from commit aa4d53ccdf)
2020-12-07 18:30:58 -06:00
ab417f373a [stable-2.10] pause - do not hang if run in the background (#72065) (#72605)
* Consolidate logic for determining whether or not session is interactive
  into a single function, is_interactive()
* Increase test coverage

I wasn't able to find a good way of simulating running a backgrounded test with CI since the
whole test is essentially run not in a TTY, which is similar enough to cause the new is_interactive()
function to always return false.
(cherry picked from commit 4b8cb6582b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-12-07 18:08:56 -06:00
c67d7225e9 ansible-galaxy - source deps from all servers and not just parent - 2.10 (#72684)
* Added integration tests for this scenario

(cherry picked from commit fb092a82a1)

* Slight tweak to galaxy source selection (#72685)

(cherry picked from commit 18e5628b19)
2020-12-07 18:08:23 -06:00
71ef981191 Backport/2.10/72390 (#72690)
* Return error if cwd directory does not exist (#72390)

* Return warning or error if cwd directory does not exist, in AnsibleModule.run_command()

(cherry picked from commit 5654de6fce)

* added flag in run_command signature to control behaviour when cwd does not exist
2020-12-07 18:07:29 -06:00
7f1ee07634 [stable-2.10] iptables: Reorder comment postition (#71496) (#72548)
(cherry picked from commit c1da427a5e)

Co-authored-by: Amin Vakil <info@aminvakil.com>
2020-12-07 17:34:32 -06:00
2a6b411a80 [stable-2.10] ansible-test - skip installing PowerShell sanity test reqs if they are already installed (#72423) (#72424)
(cherry picked from commit 809d5fc398)

Co-authored-by: Jordan Borean <jborean93@gmail.com>
2020-12-07 17:33:52 -06:00
4e34aa0c19 [stable-2.10] wait_for - ignore psutil related errors (#72401) (#72406)
When enumerating connections with psutil, catch and ignore errors to avoid returning a stack trace.

Co-authored-by:  Matt Martz <matt@sivel.net>
(cherry picked from commit fb09fd2a23)
2020-12-07 17:33:34 -06:00
c422bc64dc [stable-2.10] blockinfile - properly insert block when no trailing new line exists (#72350) (#72360)
(cherry picked from commit c51438312a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-12-07 17:32:56 -06:00
19bffccd36 [stable-2.10] systemd - fix issue with capbpf and newer kernel (#72337) (#72347)
* [stable-2.10] systemd - fix issue with capbpf and newer kernel (#72337)

A bug existed in systemd 245 that did not properly handle unknown kernel
capabilities gracefully. This resulted in incomplete output when querying
for the service status. It is possible to get service status by other means.
This PR works around this issue by getting service status using other commands
in the event of a failure due to this bug.
(cherry picked from commit db84e2c989)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* [stable-2.10] systemd - use list-unit-files rather than list-units (#72363)

list-unit-files will return all files on the system. list-units omits those
that are disabled.

Co-authored-by: Ken Dreyer <ktdreyer@ktdreyer.com>
(cherry picked from commit d6115887fa)

* systemd - account for templated unit files when searching for service (#72702)

Related to issue #71528 and PR #72337

Co-authored-by: Martin Polden <mpolden@mpolden.no>
(cherry picked from commit a788ea0132)
2020-12-07 17:03:12 -06:00
2ff5bf0f21 Fix processing of add_file_common_args=True when argument_spec is not specified as kwarg. (#72334) (#72361)
(cherry picked from commit 233e7beb5b)
2020-12-07 17:01:33 -06:00
42da480721 ansible-doc: export has_action when --json is used (#72359) (#72414)
* ansible-doc: export has_action when --json is used.
* Remove docuri and now_data, which were not used resp. ignored in format_plugin_doc and the functions it calls anyway.
* Add function _combine_plugin_doc.

(cherry picked from commit 4fb336cef1)
2020-12-07 16:59:33 -06:00
27f547b4d3 [2.10] Fix missing ansible.builtin FQCNs in hardcoded action names (#72457)
* Fix missing ansible.builtin FQCNs in hardcoded action names (#71824)

* Make sure hard-coded action names also check for FQCN.
* Use _add_internal_fqcn() to avoid hardcoded lists and typoes.

(cherry picked from commit da60525610)

* Replace some more FQCNs.

(cherry picked from commit 72302dd611)
2020-12-07 16:59:12 -06:00
07cdb709ae Adjust action groups to moved modules (#72428) (#72496)
* Support docker and k8s action groups for moved modules in community.docker and community.kubevirt.

* Also support k8s action group for community.okd.

* Also add kubernetes.core.

* Fix changelog fragment.

* Remove community.okd.

* Revert "Remove community.okd."

This reverts commit 812b5aa6e2.

(cherry picked from commit c7a4b39633)
2020-12-07 16:58:42 -06:00
ba25a1cdf1 [stable-2.10] AnsibleModule.set_mode_if_different: handle symlink is in a sticky directory (#45198) (#72863)
* file: add symlink is in a sticky directory tests
* file: handle symlink in a sticky directory

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

* Add changelog and fix unit test
The builtins import was removed since it was unused, but it is now needed.
(cherry picked from commit b464d18fd1)

Co-authored-by: Pilou <pierre-louis.bonicoli@libregerbil.fr>
2020-12-07 16:52:40 -06:00
6dc2e9c2f4 [2.10] The implicit default for type=bool options is not 'false', but 'none' (#72864)
* The implicit default for type=bool options is not 'false', but 'none' (#72699)

* Fix modules, resp. add ignore.txt entries.

(cherry picked from commit 5226ac5778)

* Add ignore.txt entries and fix deprecated option that was already removed in 2.11.
2020-12-07 16:51:35 -06:00
a15550c0c8 ansible-test sanity: fix UnicodeDecodeError for --python 2.7 --docker (#72623) (#72865)
* Store target paths as unicode.

* Add changelog fragment.

(cherry picked from commit f94ba68d8f)
2020-12-07 16:48:19 -06:00
138a5bd2d6 [2.10] Improve deprecations (#72871)
* Improve deprecations (#72697)

* Remove space before comma in '... bla , use ...'

* 'why' is inserted in the middle of a sentence, between two commas.

* Make deprecations from base.yml show source ansible-core.

* Add changelog fragment.

* Improve some more 'why's.

* Add PR URL to fragment.

(cherry picked from commit f569d80fde)

* 2.10 is ansible-base, not ansible-core
2020-12-07 16:47:38 -06:00
856a932ca0 [stable-2.10] Remove shippable.yml.
(cherry picked from commit 711064a073)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-12-07 14:44:44 -08:00
7e2faa25d7 Improve ansible-test classifications for collections (#72353)
(cherry picked from commit 64a809d2b6)
2020-12-03 17:27:29 -08:00
dbdacbd48c [stable-2.10] Use AZP config for integration-aliases test.
No changelog entry since this test is limited to the ansible/ansible repo.

Backport of https://github.com/ansible/ansible/pull/72842
2020-12-03 16:17:21 -08:00
7813b1248b [stable-2.10] Fix Azure Pipelines change detection. (#72824)
(cherry picked from commit 08842cd6bb)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-12-03 10:10:08 -08:00
eb4f30cd03 [stable-2.10] Fix CI schedule. 2020-12-02 20:49:13 -08:00
2d5f549a98 update PyPI badge to use ansible-base (#72814) 2020-12-02 18:26:58 -08:00
a1288def89 update build badge for AZP (#72807) (#72810)
(cherry picked from commit d567a553a9)
2020-12-02 17:27:43 -08:00
99d5afaad0 [stable-2.10] Azure Pipelines configuration. 2020-12-02 14:57:34 -08:00
0d7ab375eb [centos6] update container for EOL (#72795)
Change:
- Reference:
  https://lists.centos.org/pipermail/centos-devel/2020-December/056208.html
- Bump centos6 container to 1.25.0

Test Plan:
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-12-02 16:04:38 -06:00
7802ca2b06 Add RHEL 7.9 (#72558) - 2.10 (#72568)
* Add RHEL 7.9 - ci_complete (#72558)

(cherry picked from commit d451433e5d)

* Added changelog for RHEL 7.9 (#72572)

(cherry picked from commit bdd0c48837)
2020-12-01 12:51:15 -08:00
6322630360 [stable-2.10] ansible-test - add cryptography constraint for cffi (#72761)
The recently released version of cffi fails to install on systems with an older version of gcc. In
our case, this in the CentOS 6 test image. There is a fix but it has not yet been released.

https://foss.heptapod.net/pypy/cffi/-/issues/480
(cherry picked from commit 1db9588279)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-12-01 09:49:17 -08:00
3297c221f1 Test pip fix (#72764)
(cherry picked from commit 2eb9795543)
2020-12-01 10:36:48 -06:00
633396c71b Update playbooks_filters_ipaddr.rst (#72705) (#72755)
Fix the order of the arguments for ansible.netcommon.reduce_on_network. Pass the network as the argument and the list of IP addresses as the filter input.

(cherry picked from commit 454ac6420e)

Co-authored-by: Pablo Martinez <pablo@docecosas.com>
2020-11-30 15:25:22 -06:00
8bdda8792d Remove incorrect changelog (#72682)
* also remove offending code
2020-11-30 10:02:26 -06:00
581337a6d5 [stable-2.10] Fix super annoying Python 2.6 multiprocessing.Queue stack trace in CI (#72604) (#72608)
* Fix super annoying Python 2.6 multiprocessing.Queue stack trace in CI

A bug exists in Python 2.6 that sometimes raises an exception during interpreter shutdown. We
encounter this frequently in our CI since we run tests on CentOS 6 as the control node, which
has Python 2.6.6 with this bug.

This PR adds a very minor sleep only on Python 2.6 which gets around this issue. I did lot of testing
using a standalon script I found that easily duplicated the issue to find the minimum sleep value
needed to avoid this issue.

CPython issue: https://bugs.python.org/issue4106
Fix in CPython: https://hg.python.org/cpython/rev/d316315a8781

* Use correct attribute
(cherry picked from commit bbef250c2b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-11-20 13:10:11 -06:00
ed78b479ec Improve argument spec documentation (#72335) (#72486)
* Link to argument spec documentation from 'Creating a module'.

* Use items instead of sub-headings.

* Update deprecation information.

* Document conditional requirements.

* Document supports_check_mode and add_file_common_args.

* Add deprecation examples.

* Re-add word.

* Improve title.

* Fix RST formatting, add conditional dependency section starter.

(cherry picked from commit 01d207a3e3)
2020-11-13 15:17:31 -06:00
913aebb140 Docsite: update user_guide/playbooks_module_defaults (#72051) (#72493)
* Docsite: update user_guide/playbooks_module_defaults, add name: lines and use FQCN consistently
(cherry picked from commit dbe43e071e)
2020-11-13 14:51:37 -06:00
fc4411adcd Improve config.rst formatting (#72354) (#72487)
* Indent Jinja2 directives.

* Show version_added and deprecations for ini settings and environment variables.

* Make default conditional, add choices. Copied from #55474.

* Add Ansible variables. Copied from #55474.

* Turn ini keys and environment variables into lists. Copied from #55474.

* Improve formatting. Copied from #55474.

(cherry picked from commit 569d937df8)
2020-11-13 14:31:32 -06:00
cfa8075537 [stable-2.10] Add coverage exporting to ansible-test
A new `--export` option for `ansible-test coverage combine` allows multi-step aggregation of code coverage for CI pipelines.
(cherry picked from commit fa2be89cd4)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-11-09 23:29:39 -08:00
8f767f7180 [stable-2.10] Fix container discovery for the acme test plugin.
(cherry picked from commit f022dedd0a)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-11-09 15:30:07 -08:00
5bd0df7621 [ansible-test] use newer container images (#72126) (#72550)
Change:
- Bump default, ansible-base, distro containers
- We do NOT add fedora33 yet, because it doesn't work right on Shippable
  due to an old kernel. This will be added post-AZP.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit e7bf0696ef)
2020-11-09 14:23:48 -06:00
81ce0f8fc4 Remove sanity ignores 2020-11-06 11:47:09 -06:00
1f5afcd072 Various intentional tests (#72485)
* Add tests for argspec choices type=list

* Add explicit interpreter discovery tests to validate modules returning ansible_facts still set interp

* Add explicit tests for missing_required_lib

* Add explicit tests for recursive_diff

* ci_complete ci_coverage

* Update data to cover more code/tests

* ci_complete ci_coverage

* Add argspec tests for aliases, and no_log

* Forgotten file

* ci_complete ci_coverage

* Add argspec tests for type int

* ci_complete ci_coverage

* Remove incidental_k8s

* ci_complete ci_coverage

* fix missing newline

* Remove incidental_sts_assume_role

* ci_complete ci_coverage

(cherry picked from commit c8590c7482)
2020-11-06 11:47:09 -06:00
65470f48bd Remove incidental tower integration tests (#72461)
* Add explicit test for dict repr in argspec

* Add explicit test for undefined repr

* ci_complete ci_coverage

* Skip old jinja2

* ci_complete ci_coverage

* Remove incidental_tower_receive

* ci_complete ci_coverage

* Remove incidental_tower_credential_type

* ci_complete ci_coverage

* Remove ignore entries

* ci_complete ci_coverage

(cherry picked from commit 880087748c)
2020-11-06 11:47:09 -06:00
e555358c32 Remove incidental vmware tests (#72420)
* Add explicit tests for ansible.module_utils.common.network.is_mac

* Test missing ANSIBLE_CONFIG

* Add explicit inventory script tests

* Add explicit tests for _consume_options

* Adjust perms, remove extra file

* ci_complete ci_coverage

* remove incidental_inventory_vmware_vm_inventory

* ci_complete ci_coverage

* Remove incidental_script_inventory_vmware_inventory

* ci_complete ci_coverage

* Remove incidental_vmware_guest

* ci_complete ci_coverage

* Remove incidental_vmware_host_hyperthreading and incidental_vmware_prepare_tests

* ci_complete ci_coverage

* newline and comment about what the test is doing

* ci_complete ci_coverage

(cherry picked from commit ccc63abc8e)
2020-11-06 11:47:09 -06:00
5b5870886b Remove incidental_cs_role_permission (#72380)
* Add explicit argspec tests for choices

* ci_complete ci_coverage

* Remove incidental_cs_role_permission

* ci_complete ci_coverage

* ci_complete ci_coverage

(cherry picked from commit 6543c7bc5d)
2020-11-06 11:47:09 -06:00
73991233fb Remove incidental_zabbix_host (#72142)
* Add explicit apt tests for fnmatch and update_cache

* Add explicit apt_key tests for fetching key directly from url

* ci_complete ci_coverage

* Remove repo only by repo

* ci_complete ci_coverage

* Add apt cache update after apt_repository to show that the cache doesn't update

* ci_complete ci_coverage

* Add systemd tests for enabling and disabling a service

* ci_complete ci_coverage

* Remove incidental_zabbix_host

* ci_complete ci_coverage

(cherry picked from commit 2f8dbf673e)
2020-11-06 11:47:09 -06:00
dca64d3c74 Remove incidental_aws_codebuild (#72140)
* Remove incidental_aws_codebuild

* ci_complete ci_coverage

(cherry picked from commit cf0cd4b50b)
2020-11-06 11:47:09 -06:00
ce47796db9 Add info on how to contribute to **community**-maintained collections as well. (#72494) (#72512)
(cherry picked from commit da1c1e8bb8)
2020-11-06 11:42:18 -06:00
8c5910efe7 [stable-2.10] [dnf] Some fixes around filtering (#72483) (#72500)
* [stable-2.10] [dnf] Some fixes around filtering (#72483)

Change:
- Docs: Add note that security/bugfix apply to dependencies too, like
  the dnf command.

- dnf: security/bugfix only makes sense for updates, so limit the
  package query sack to available updates.

- tests: Limit tests to our known-good test packages, so that RHEL
  packages marked security/bugfix without similarly marked dependencies
  don't fail our tests.

Test Plan:
- Tested with `dnf upgrade-minimal --bugfix` and reproduced the same
  error currently seen in CI, showing that we are consistent with what
  dnf does.

Tickets:
- Likely fixes #72316

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit d8c637da37)

Co-authored-by: Rick Elrod <rick@elrod.me>

* Add changelog (#72502)

(cherry picked from commit b33d7e2e29)

Co-authored-by: Rick Elrod <rick@elrod.me>
2020-11-06 08:56:18 -06:00
31ab3d8a64 clarify upstream release status of 2.10 (#72269) (#72489)
* clarify upstream release status of 2.10

(cherry picked from commit d76f85208d)
2020-11-05 14:34:53 -06:00
10871f3246 Update Ansible release version to v2.10.3.post0. 2020-11-02 19:04:58 -06:00
3e9afdae2e New release v2.10.3 2020-11-02 15:34:41 -06:00
7cd080b10d [stable-2.10] Update pip tests to omit install dev extras to avoid dep issues (#72436) (#72438)
(cherry picked from commit 2ee5af5)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-11-02 11:05:48 -06:00
1f485dccaa [stable-2.10] Add intentional coverage for incidental_ec2_instance (#72028)
* Add a test suite for module_utils.common.dict_transformations

* ci_complete

ci_coverage

Add a wait_for test using delegate_to

* Remove incidental_ec2_instance

* Remove unused test support modules

* Requested changes

ci_complete

ci_coverage

* Oops, put everything back to test coverage again

ci_complete

ci_coverage

* Remove incidental_ec2_instance tests and supporting modules
(cherry picked from commit 960e4c0809)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
2020-10-29 07:31:53 -07:00
522f167d27 Replace incidental tests with intentional argspec tests (#72370)
* Remove incidental_consul tests (#71811)

* Add explicit intg tests for argspec functionality

* ci_complete ci_coverage

* Remove incidental_consul and incidental_setup_openssl

* ci_complete ci_coverage

(cherry picked from commit a99212464c)

* Remove incidental_nios_txt_record (#72009)

* Add explicit coverage of argspec type=dict

* Non string mapping failure

* ci_complete ci_coverage

* Remove incidental_nios_txt_record and associated files

* Don't forget the ignore.txt changes

* ci_complete ci_coverage

(cherry picked from commit 6f4aed5377)

* Remove incidental_vyos_static_route (#72024)

* Add explicit tests for required_together suboptions

* ci_complete ci_coverage

* Remove incidental_vyos_static_route

* ci_complete ci_coverage

* Add explicit coverage of suboptions required_if

* ci_complete ci_coverage

* Remove incidental_vyos_logging

* ci_complete ci_coverage

(cherry picked from commit 9081b22868)

* More explicit argspec tests (#72064)

* Add more explicit coverage of argspec functionality

* fail_on_missing_params

* ci_complete ci_coverage

* Remove incidental_aws_step_functions_state_machine

* ci_complete ci_coverage

* Remove incidental_cs_service_offering

* ci_complete ci_coverage

(cherry picked from commit ab2b339dd6)

* Add explicit coverage of required_together (#72107)

* Add explicit coverage of required_together

* ci_complete ci_coverage

* Remove incidental_hcloud_server

* Remove hcloud from shippable matrix

* ci_complete ci_coverage

(cherry picked from commit 460ba041c8)

* Add explicit coverage of suboptions=list without elements (#72108)

* Add explicit coverage of suboptions=list without elements

* ci_complete ci_coverage

* Remove incidental_vmware_guest_custom_attributes

* ci_complete ci_coverage

(cherry picked from commit 50c8c87fe2)

* Add explicit coverage of argspec choices with strings that shadow YAML bools (#72122)

* Add explicit coverage of argspec choices with strings that shadow YAML bools

* ci_complete ci_coverage

* Remove incidental_ufw

* ci_complete ci_coverage

(cherry picked from commit cfa41898c4)

* Adds argspec tests for required, required_one_of and required_by (#72245)

* Improve variable names.

* Add test for required.

* Add test for required_one_of.

* Add test for required_by.

(cherry picked from commit 1489bf9190)

* Remove incidentals without coverage (#71788)

* Remove incidental_lookup_hashi_vault
* Remove incidental_connection_chroot
* Remove incidental_selinux
* Remove incidental_win_hosts

(cherry picked from commit e6e9840717)

Co-authored-by: Matt Martz <matt@sivel.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-10-28 09:12:09 -07:00
dcae6d20d2 Update Ansible release version to v2.10.3rc1.post0. 2020-10-26 19:01:43 -05:00
10922d58f0 New release v2.10.3rc1 2020-10-26 14:32:55 -05:00
69d5ce9b41 Remove ansible-galaxy login (#72288) (#72320)
* GitHub is removing the underlying API used to implement the `login` command. Since the general consensus seems to be that relatively nobody currently uses this command (in favor of explicit token passing), support was simply removed for interactive login. If a future need arises, this command should be reimplemented via OAuth Device Auth Grants.
* login or role login commands now produce a fatal error with a descriptive message
* updated 2.10 porting guide entry

* remove dead code/config, update messages and porting guides

(cherry picked from commit 83909bfa22)
2020-10-26 14:31:52 -05:00
4159c73db2 [ansible-test] Limit cryptography to <3.2 (#72342) (#72345)
Change:
- Cryptography 3.2 drops support for OpenSSL 1.0.2. Some of our CI
  infrastructure still uses this version (FreeBSD, namely). For now,
  just add a constraint to use old cryptography.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-10-26 13:44:16 -05:00
69744aa0a7 [2.10] Fix various sanity errors in plugins (#72168)
* Fix various sanity errors in plugins (#71736)

* Fix various sanity errors in plugins.

* Revert callback_type -> type transform.

* Undo paramiko_ssh 'connection' change, since this discrepancy is hardcoded in the plugin loader.

* Standardize on name and type (for callbacks).

* Fix existing author entries.

* Add 'Unknown (!UNKNOWN)' as author when author is missing.

* These are actually parsed as integers in the code.

* Revert "Add 'Unknown (!UNKNOWN)' as author when author is missing."

This reverts commit 29d1438aca.

(cherry picked from commit aff78f4cbc)

* Undo potentially disrupting normalizations.

* Add changelog fragment for #71736. (#72323)

(cherry picked from commit 0b2b82c0b6)
2020-10-24 06:03:18 -05:00
8471814f86 [stable-2.10] Fix the reversed order of return values (#72088) (#72300)
AnsibleModule.run_command returns a tuple of return code, stdout and stderr.
The module main function of the user module expects user.create_user to
return a tuple of return code, stdout and stderr.
Fix the locations where stdout and stderr got reversed.

Co-authored-by: Ruediger Pluem <53253255+rpluem-vf@users.noreply.github.com>
2020-10-23 15:58:23 -05:00
d4b7b8bae7 Fix example to use correct shebang (#72129) (#72146)
* Fix example to use correct shebang

* Fix other example modules as well

* Ignore shebang test

(cherry picked from commit 1ae3683d0c)
2020-10-23 15:57:20 -05:00
4293718b2a make collection callbacks follow normal flow (#59932) (#72227)
* fixes missing set_options call and adhoc and stdout processing rules
* avoid dupes
* fixed to handle redirects
* also updated tests with new and more accurate skip message
* fix callback tests for envs with cowsay installed
* lots MOAR comments on why the code is as it is, some todos to refactor in future
2020-10-23 15:54:38 -05:00
843ebcc436 Docsite: update user_guide/playbooks_async (#72115) (#72193)
(cherry picked from commit 30a651bca3)
2020-10-23 15:29:38 -05:00
132346cb6a [stable-2.10] Ensure we call action_loader.get with collection_list (#72206) (#72252)
(cherry picked from commit be5fc4e)
2020-10-23 15:29:16 -05:00
ae1ee31b99 Fix race condition when creating async dir (#72069) (#72259)
* Fix race condition when creating async dir

* Simplify exception wrapper

* Remove var used for testing

(cherry picked from commit c9fa1d0e7e)
2020-10-23 15:28:05 -05:00
dbbc44b1f4 [2.10] Docsite backport of 71973, 71975, 71980 (#71991)
* Docsite: improve user_guide/playbooks_vars_facts (#71973)

* Docsite: improve user_guide/playbooks_vars_facts

* Docsite: update user_guide/vault (#71975)

* Docsite: update user_guide/playbooks_filters (#71980)
2020-10-23 15:27:03 -05:00
775d6e6752 [stable-2.10] Changes required for macOS 10.15 (#71841) (#71954)
* Use default group of staff on macos to prevent sudo issues
* Install gnu-tar for macos in git and unarchive tests
* Enable timezone module to support py3 on macos
* If the virtualenv command is missing, try python -m virtualenv
* Install passlib for filter_core on macos
* Install paramiko via pip on macos for paramiko tests
* Normalize discovered python interpreter on macos
* Get pip tests passing, by ensuring we have wheel installed
* Create /etc/ansible for ca certs on mac, list lookup_url as destructive
* Fixups for CA certs
* Include macos
* Dynamically get cafile instead of hardcoding the path
(cherry picked from commit 35b0fef536)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-10-23 15:18:24 -05:00
83c34eb7de [dnf] accumulate update filters (#71726) (#72181)
Change:
- Previously when `security: true` and `bugfix: true` were both given,
  only security updates would get applied. Filters now accumulate so
  that both get applied in this case.

Test Plan:
- New integration tests for both check_mode and not. These tests make
  use of a contrived yum repository which is stored in S3.

Tickets:
- Fixes #70854

Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Matt Martz <matt@sivel.net>

Co-authored-by: Matt Martz <matt@sivel.net>
(cherry picked from commit fdf80690e4)
2020-10-23 14:15:47 -05:00
b9c8b79d60 remove ansibleFest banner (#72253) (#72266)
(cherry picked from commit 3ece57c01a)
2020-10-23 10:27:35 -05:00
3bd6daa4a4 [stable-2.10] Fix ansible-test handling of user-defined docker networks. (#72256)
* Fix ansible-test docker container detection.

* Attach test containers to the correct network.

* Do not assume `localhost` for accesing Docker.

* Look for containers on current network.

* Always map /var/run/docker.sock into containers.

This fixes issues when using a remote Docker host.

* Support container IP lookup from networks list.

* Fix container network attachment.

* Remove redundant container detection messages.

* Limit DOCKER_HOST parsing to TCP.

* Restore docker socket existence check.

The check is skipped if the docker hostname is not localhost.

* Correct changelog entry..
(cherry picked from commit 3c2e8b99be)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-10-22 21:40:23 -07:00
98cc9cb834 [2.10] AnsibleVaultEncryptedUnicode should be considered a string (#72216)
* AnsibleVaultEncryptedUnicode should be considered a string
* linting fix
* clog frag

(cherry picked from commit 48f12c14e9)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-10-21 18:08:18 -05:00
7499848cb1 user - allow local users with an expiry date to be created (#72022) (#72085)
The luseradd / lusermod commands do not support the -e option. Set
the expiry time in this case via lchage after the user was
created / modified.

Fixes: #71942

In Python3 math.floor returns an integer whereas Python2 returns a float.
Hence always convert the result of math.floor to an int to ensure that
lexpires is an integer.

Move local expires tests in a separate file and import the tasks to the
main.yml to keep main.yml smaller.

(cherry picked from commit a7170da851)
2020-10-21 17:04:35 -05:00
6c8d6a3182 [stable-2.10] Fix ansible-test Azure Pipelines container auth.
(cherry picked from commit 2ef4b7e07e)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-10-21 14:15:39 -07:00
961ead55c6 Add deprecation collection name to plugin options (#71735) (#72081)
* Add changelog fragment.

* Use correct field that's expected by lib/ansible/cli/__init__.py..

* Add basic unit tests.

(cherry picked from commit 1107aace1b)
2020-10-21 15:58:51 -05:00
5a3a2d1a39 replace porting guides with stub pages - issue 71687 (#71988) 2020-10-21 15:36:40 -05:00
505df0d564 fix distribution fact for SLES4SAP (#71559) (#72026)
b6b238a fixed the SLES4SAP detection, which was at this time ok.
Sadly Suse changed with SLES 15 the /etc/os-release file, so the above
change will no longer work.

This commit updates the SLES4SAP detection regarding
https://www.suse.com/support/kb/doc/?id=000019341.

The symlink realpath is matched with endswith, because in SLES 12+ the
link target is SLES_SAP.prod, but in SLES 11 the link target is
SUSE_SLES_SAP.prod.

(cherry picked from commit ea119d3089)
2020-10-21 15:35:36 -05:00
d53d247c84 Only apply the unroll wrapper once (#72003) (#72017)
Co-authored-by: Matt Martz <matt@sivel.net>

Fixes #71920

(cherry picked from commit 4197666179)
2020-10-21 15:32:45 -05:00
cd89aadec1 powershell - remove env var (#72010) (#72012)
(cherry picked from commit 3c33618cf6)
2020-10-21 15:27:57 -05:00
e6a4585807 [dnf] show installations/removals in check_mode (#70892) (#72180)
Change:
- Previously, we only showed that something would have changed, not what
  would have changed. This allows us to show what will chang as well.

Test Plan:
- Local RHEL8 VM
- New integration tests

Tickets:
- Fixes #66132

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 7d32129efb)
2020-10-21 14:42:26 -05:00
b8e718cccd [2.10] Docsite backports of 71938, 71907 (#71972)
* Docsite: improve user_guide/playbooks_variables (#71938)
(cherry picked from commit c19af92be6)

* Docsite: improve inventory-related pages (#71907)
Update docs/docsite/rst/plugins/inventory.rst
(cherry picked from commit 2fed63a930)
2020-10-20 16:03:29 -05:00
2c5e4b5a88 [tests/dnf] work around dnf packaging issue (#72249) (#72251)
Change:
- In this test we end up upgrading dnf (and python3-dnf) so that we can
  test its new logging behavior. However, the latest Fedora 32 dnf had a
  packaging issue which caused it to not pull in the latest
  python3-libdnf. This is fixed, but not synced out to mirrors yet.
  Fixing it in this test will get CI passing again in the meanwhile.

Test Plan:
- CI

Tickets:
- https://bugzilla.redhat.com/show_bug.cgi?id=1887502

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 9ddb1d76af)
2020-10-19 11:04:32 -05:00
2e0eb330a1 Update the porting guide for a new ansible version (#72212)
(cherry picked from commit 0a5985c4a6)
2020-10-13 12:37:03 -05:00
f9ecb4fe74 [2.10] Docsite backport of 72049, 72052, 72053 (#72071)
* Docsite: update user_guide/playbooks_prompts (#72049)

(cherry picked from commit 3efc8b6de8)

* Docsite: update user_guide/playbooks_checkmode (#72052)

(cherry picked from commit c12fce3aa9)

* Docsite: update user_guide/playbooks_debugger (#72053)

(cherry picked from commit 77840f886e)
2020-10-09 10:53:47 -05:00
c24bdfa7df Add example values and results for theory filters (#72087)
(cherry picked from commit 69c3e5644c)
2020-10-09 10:52:16 -05:00
49504da1ed [stable-2.10] Support collection constraints in ansible-test. (#72157)
This allows collections to specify requirements and constraints for packages that ansible-test has requirements or constraints for.
(cherry picked from commit 5f76bd2af7)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-10-08 16:17:28 -05:00
f57b149ec8 Intentional coverage, incidental_azure_rm_resource (#71052) (#72159)
Change:
- Adds some intentional coverage around PluginLoader for cases that
  incidental_azure_rm_resource covered.
- Specifically, modules starting with an underscore, and starting with
  an underscore but a symlink.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit cdcf0aa42a)
2020-10-08 16:16:53 -05:00
70172dde27 Add intentional unit tests for basic._set_cwd and common.dict_merge (#70283) (#72160)
* Add unit tests for basic._set_cwd

* incidental coverage for dict_merge

* add test for async stderr inclusion

(cherry picked from commit b019029bf3)

Co-authored-by: jctanner <tanner.jc@gmail.com>
2020-10-08 16:16:34 -05:00
d60a4c064c Update Ansible release version to v2.10.2.post0. 2020-10-05 18:55:41 -05:00
656c228abe New release v2.10.2 2020-10-05 15:50:46 -05:00
d88fb87fd0 Update Ansible release version to v2.10.2rc1.post0. 2020-09-28 14:50:47 -05:00
68f0fcfbd5 New release v2.10.2rc1 2020-09-28 11:54:17 -05:00
8e00447aef ansible-doc: show correct plugin name (#71966) (#71984)
(cherry picked from commit 0c3a9c7ae6)
2020-09-28 11:36:00 -05:00
4df129c6ae Provide more information in AnsibleUndefinedVariable (#71666) (#71876)
* Provide more information in AnsibleUndefinedVariable

Fixes #55152

(cherry picked from commit 00b22ab55e)
2020-09-28 00:34:38 -05:00
c4e3552c8d [stable-2.10] CI provider fixes for ansible-test. (#71929) (#71932)
* Make Azure Pipelines resource_prefix lowercase.

* Make classification of CI files consistent.

* Update package-data sanity test for AZP.
(cherry picked from commit 92b66e3e31)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-09-28 00:34:12 -05:00
988d410e17 [stable-2.10] Test changes to allow using "macos" test image (#71849) (#71861)
* Add link to remote.sh from macos.sh
* Add skip/macos to tests that have skip/osx.
(cherry picked from commit 6984081111)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-09-28 00:33:11 -05:00
198cffcb52 Fix passing the connection timeout to connection plugins (#71722) (#71785)
(cherry picked from commit 7048542199)
2020-09-28 00:32:04 -05:00
2327ef9da8 runas - create new SYSTEM token on become (#71714) (#71751)
(cherry picked from commit fc08c1f3c5)
2020-09-28 00:29:45 -05:00
07a9de1247 fix coverage output from synthetic packages (#71727) (#71748)
* fix coverage output from synthetic packages

* synthetic packages (eg, implicit collection packages without `__init__.py`) were always created at runtime with empty string source, which was compiled to a code object and exec'd during the package load. When run with code coverage, it created a bogus coverage entry (since the `__synthetic__`-suffixed `__file__` entry didn't exist on disk).
* modified collection loader `get_code` to preserve the distinction between `None` (eg synthetic package) and empty string (eg empty `__init__.py`) values from `get_source`, and to return `None` when the source is `None`. This allows the package loader to skip `exec`ing things that truly have no source file on disk, thus not creating bogus coverage entries, while preserving behavior and coverage reporting for empty package inits that actually exist.

* add unit test

(cherry picked from commit e813b0151c)
2020-09-28 00:29:24 -05:00
68278f36fd psrp - fix hang when copying an empty file (#71649) (#71651)
(cherry picked from commit b615789fcc)
2020-09-28 00:28:01 -05:00
ab100f8ee5 [tests] Make setup_docker clean up better (#71949) (#71959)
Change:
- pip packages should get removed after, not try to add them again
- Try removing containerd.io package too

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 6a7e637c5f)
2020-09-26 03:41:03 -05:00
12874bbdea [2.10] updates intersphinx references for docs links (#71921) (#71945)
* updates intersphinx references for docs links (#71921)

* DOCS: updates intersphinx references for docs links
* TESTS: Raise the number of bytes scanned to determine if a file is binary. The newest ansible-2.10.inv file has its first null byte at position 2261. 4096 is still a cheap chunksize to read so it still makes sense to raise this.

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
(cherry picked from commit 27826827e9)

* adds changelog for already-merged PR (#71947)
* adds changelogs/fragments/71921-raise-bytes-for-binary-test.yml

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 91b0dfb659)
2020-09-25 13:53:44 -05:00
5282ab853d [2.10] Docsite backport 71909, 71859, 71858, 71857, 71854, 71834 (#71937)
* Docsite: improve user_guide/intro_inventory (#71859)

(cherry picked from commit 25bfda8417)

* Docsite: improve user_guide/playbooks_tags (#71858)

(cherry picked from commit c3841b8440)

* Docsite: improve user_guide/playbooks_reuse_roles (#71857)

* Docsite: improve user_guide/playbooks_reuse_roles

* fix
(cherry picked from commit 7a0a2f188b)

* Docsite: update Migrating Ansible content to a different collection (#71854)

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 2655fc0c23)

* Docsite: improve user_guide/intro_adhoc (#71909)

(cherry picked from commit ed6fb2e3f6)

* Docsite: improve user_guide/playbooks_reuse (#71834)

(cherry picked from commit 3db4be2c3b)
2020-09-25 09:42:21 -05:00
5fc0dc1956 update install instructions for pip (#71891) (#71922)
(cherry picked from commit e358946b98)
2020-09-24 13:41:14 -05:00
d7f6d8c8f0 [incidental_setup_docker] changes to upstream repo (#71897) (#71899)
Change:
- The docker-ce.repo file for centos does not work on RHEL since it uses
  $releasever and on RHEL that is, e.g., "7Server".
- Instead, set up the repo manually.
- Additionally, the docker centos8 repo no longer has old versions, so
  we use the (only) version in the repo instead.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 31ddca4c0d)
2020-09-23 21:36:53 -05:00
806acf9cd9 hacking: fix announce script version parsing (#71008) (#71893)
Change:
- Fix a bug where rc/beta versions throw off the "is this an
  ansible-base release"? check.

Test Plan:
- Used it for 2.10.0rc4

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 75e8da0950)
2020-09-23 16:16:52 -05:00
77408dccab fix version label to 2.10 (#71870) 2020-09-22 18:25:52 -05:00
a10e76a64c update version switcher for 2.10 release (#71866)
(cherry picked from commit bf4e102d97)
2020-09-22 14:23:41 -05:00
51517a6232 Update the porting guide for a new ansible version (#71863) (#71868)
(cherry picked from commit 606924a4b4)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-09-22 14:20:50 -05:00
86de15ea53 add cli parser documentation (#71497) (#71864)
* with native network example, linux example

(cherry picked from commit 0e5911d650)
2020-09-22 14:18:24 -05:00
df150a2780 [stable-2.10] Fix attribute testing in file integration test. (#71843)
The file test will no longer attempt to test attributes if `lsattr -vd` does not work on the system under test.
(cherry picked from commit 17765cd4e8)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-09-21 15:06:26 -07:00
b739bbe0a5 [Docs][backport][2.10] Backportapalooza 12 (#71842)
* Fix typo in the documentation (#71701)

Fix typo in the documentation: casting instead of casing

(cherry picked from commit 1a06587f3b)

* Add how to run unit test link in testing_units_modules doc (#71523)

* Add how to run unit test link in testing_units_modules
* Fix sanity test

(cherry picked from commit 7a0e545700)

* Fix typo in delveloping_plugins_network (#71737)

(cherry picked from commit 4bf61f0714)

* Fix broken bullet list (#71728)

(cherry picked from commit 00ed5b1f2e)

* vmware: Add docs for filters (#71670)

Add a scenario guide for filters in VMware documentation

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 760334303b)

* [docs] add porting guide for DNF GPG validation (#71640)

* [docs] add porting guide for DNF GPG validation

Change:
- This was a breaking change (security fix), but I neglected to add a
  porting guide entry for it previously.

Tickets:
- Refs #71537
- Refs #71539
- Refs #71540
- Refs #71541

Signed-off-by: Rick Elrod <rick@elrod.me>

* changes from sivel

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 7a38c470ba)

* Fixed invalid urls inside guide_packet.rst and collections_using.rst (#71705)

* Fixed invalid urls inside guide_packet.rst and collections_using.rst

* Reverted fix for collections_using.rst

(cherry picked from commit c36e939414)

* Update EXAMPLES in package_facts.py documentation (#71838)

this module is not limited to rpm , so remove rpm in tasks name

(cherry picked from commit 7f62b4733d)

* change duplicated label

(cherry picked from commit bcfead8e0f)

Co-authored-by: Guillaume Vincent <guillaume@oslab.fr>
Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Shufeng <fenghhk@gmail.com>
Co-authored-by: Evaristo Rojas <evaristo.rojas@islas.org.mx>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Shounak <25407872+shounak1@users.noreply.github.com>
Co-authored-by: roumano <roumano@gmail.com>
2020-09-21 15:42:39 -05:00
47cabb1d32 [2.10] Doc backports: 71753, 71754, 71769, 71770, 71771, 71772 (#71807)
* Docsite: misc fixes of playbooks_delegation (#71753)

(cherry picked from commit 05a45f63ff)

* Docsite: fix playbooks_conditionals (#71754)

(cherry picked from commit aa1f0bd062)

* Docsite: fix user_guide/playbooks_blocks (#71769)

(cherry picked from commit 79dc6fa948)

* Docsite: fix user_guide/playbooks_handlers (#71770)

(cherry picked from commit 1cf42897d2)

* Docsite: fix user_guide/playbooks_error_handling (#71771)

(cherry picked from commit 2c6661d4c1)

* Docsite: fix user_guide/playbooks_environment (#71772)

(cherry picked from commit a204f5f955)
2020-09-21 11:20:57 -05:00
aacff5e35f setup - update docs for win setup fact_path (#71791) (#71799)
(cherry picked from commit 2d2c5d5ed7)
2020-09-21 11:01:18 -05:00
ea9a223ab6 [2.10] Doc fixes backporting 71697, 71718, 71717 (#71768)
* Docsite: misc fixes (#71697)

(cherry picked from commit a80131a283)

* Docsite: improve playbooks_loops.rst (#71718)

(cherry picked from commit 13ab9f5932)

* Docsite: fix a typo in user_guide/index.rst (#71717)
2020-09-21 10:59:05 -05:00
b6637c0afc [stable-2.10] incidental_setup_openssl - Pin version of Python packages
A recent update to cffi that was yanked is still being installed on our
Mac OS X 10.11 test image since the version of pip there is very old and
does not ignore yanked packages.

Pin the version of pyOpenSSL and its dependencies to fix this and avoid
future spontaneous failures.
(cherry picked from commit 65cdb86c8a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-09-17 08:44:41 -07:00
2b9e5b931a Update Ansible release version to v2.10.1.post0. 2020-09-14 16:21:16 -05:00
355a69f416 Revert "[deb packaging] Change maintainer email for now"
This reverts commit 6cf4a33f35.
2020-09-14 16:02:23 -05:00
6cf4a33f35 [deb packaging] Change maintainer email for now
Change:
- For getting debug/error notifs from launchpad

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-09-14 15:46:28 -05:00
72a8b55920 New release v2.10.1 2020-09-14 13:04:22 -05:00
45c8c9909d [Docs][2.10] Backportapalooza 11 (#71702)
* Add note on where inventory scripts moved to' (#71638)

(cherry picked from commit 2f240f5dd7)

* clarify that collection names use same requirements as namespaces (#71639)

(cherry picked from commit bbd4ec13f1)

* Fix typo in documentation (#71652)

Fix typo on the page about unit testing modules,

(cherry picked from commit 1ad0f666d5)

* Changed all_modules references to list_of_collections in the documentation (#71656)

(cherry picked from commit a34043c6be)

* Adds FAQ and other pointers for collections (#71606)

(cherry picked from commit b430f9b9aa)

* Docs(lineinfile): Update link to python regex docs (#71688)

There was a link still pointing at the python2 documentation.

(cherry picked from commit 11ba30183e)

* Docsite: add reference to Style guide (#71694)

(cherry picked from commit 73bed95ead)

Co-authored-by: Zois Pagoulatos <zpagoulatos@hotmail.com>
Co-authored-by: esmersmith <62951573+esmersmith@users.noreply.github.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Valentin Krasontovitsch <v.krasontov@gmail.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2020-09-10 10:48:28 -05:00
57b5069990 Update the porting guide for 2.10.0b2 (#71677) (#71684)
(cherry picked from commit 9fcf1db871)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-09-09 11:38:04 -05:00
eb165c0a9b Update Ansible release version to v2.10.1rc3.post0. 2020-09-07 14:56:34 -05:00
387a7199fc New release v2.10.1rc3 2020-09-07 13:52:06 -05:00
2797322fd3 [stable-2.10] Update to the ansible-2.10.0 pre-release schedule (#71647) (#71648)
(cherry picked from commit 4d4e75ee05)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-09-04 21:11:30 -05:00
43e0aa5b57 WIP: Backport/2.10/71588 (#71626)
* Add dual index pages for roadmaps (part of #71566)

(cherry picked from commit b518a5db14)

* Docsite: replace Latin phrases to English (#71588)

Replace Latin phrases like "e.g." and "i.e." and "etc." with English phrases.

* Update docs/docsite/rst/community/committer_guidelines.rst
* Update docs/docsite/rst/dev_guide/developing_modules_documenting.rst
* Update docs/docsite/rst/dev_guide/developing_program_flow_modules.rst
* Update docs/docsite/rst/dev_guide/module_lifecycle.rst
* Update docs/docsite/rst/user_guide/intro_inventory.rst
* Update docs/docsite/rst/user_guide/playbooks_loops.rst
* Update docs/docsite/rst/user_guide/playbooks_reuse.rst
* Update docs/docsite/rst/dev_guide/platforms/aws_guidelines.rst
* Update docs/docsite/rst/dev_guide/testing.rst
* Update docs/docsite/rst/dev_guide/testing_integration.rst
* Update docs/docsite/rst/porting_guides/porting_guide_2.5.rst
* Update docs/docsite/rst/reference_appendices/faq.rst

(cherry picked from commit 7bfeed3e24)

* fix index page and TOCs

* adds old roadmap index

* adds toctree ref for old roadmaps

Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-09-04 14:44:13 -05:00
1af7c6c003 [docs][backport]Backportapalooza 10 (#71621)
* Feature freeze date has been merged with Ansible-2.10.0beta1 (#71494)

(cherry picked from commit c586d436fa)

* Add --allow-disabled to sanity docs (#71524)

(cherry picked from commit bc6461432e)

* Update intro_patterns.rst (#71542)

Call out the trailing comma when specifying a single host. Small snag that took me a while to notice.

(cherry picked from commit ec3920cef1)

* ansible-vault: Fix typo in help message (#71485)

(cherry picked from commit 215eb730e1)

* update install for 2.10 (#71543)

* update install for 2.10

(cherry picked from commit f75223d2c6)

* User guide overhaul, Table of Contents (#71553)

(cherry picked from commit b694dbadfe)

* update backport instructions for 2.11 (#71567)

* update backport instructions in docs/docsite/rst/community/development_process.rst

Co-authored-by: Matt Martz <matt@sivel.net>
(cherry picked from commit 7f9258b024)

* More docs updates to reflect collections ecosystem (#71597)

(cherry picked from commit 96aee766f4)

* DOCS: Mentions ansible-base, adds collections pointers to Community and Dev Guides (#71480)

(cherry picked from commit 29b20bd1b1)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Matt Deacalion <matt@dirtymonkey.co.uk>
Co-authored-by: Fabien Malfoy <fabien.malfoy@laposte.net>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-09-03 18:07:02 -05:00
7caa7e1162 Docsite: improve developing_modules_documenting.rst (#71590) (#71613)
* add necessary dots to returns descriptions
(cherry picked from commit bfba0ffc45)
2020-09-03 14:42:31 -05:00
3fadb5eb28 Docsite: improve spelling_word_choice.rst (#71592) (#71612)
(cherry picked from commit cda5854099)
2020-09-03 14:41:45 -05:00
a2d8d45c61 testing_sanity.rst: add argument for running in docker (#71223) (#71587)
(cherry picked from commit 56423b1648)
2020-09-03 14:41:19 -05:00
fd27c4db71 [stable-2.10] Add pause to avoid same mtime in test.
(cherry picked from commit 3d769f3a76)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-09-02 15:49:08 -07:00
ec8878ced4 [stable-2.10] Use new endpoint for Parallels based instances.
(cherry picked from commit 98febab975)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-09-02 15:08:32 -07:00
333f7bc088 [tests] Bump container versions (#71518) (#71598)
Change:
- This pulls in python 3.9.0rc1

Test Plan:
- CI, hopefully

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit db519bc17c)
2020-09-02 14:44:23 -05:00
8d88d4550b Update Ansible release version to v2.10.1rc2.post0. 2020-09-02 12:48:07 -05:00
4273443686 [stable-2.10] Support macOS 10.15 for ansible-test --remote.
Use of this new version is experimental, so it is not enabled in CI yet.
(cherry picked from commit 2bbcbe99fd)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-09-01 19:07:10 -07:00
356ea0b8d0 [stable-2.10] Fix ansible-test coverage traceback. (#71446) (#71578)
* [stable-2.10] Fix ansible-test coverage traceback. (#71446)

* Add integration test for ansible-test coverage.

* Fix ansible-test coverage traceback.

* Fix coverage reporting on Python 2.6.
(cherry picked from commit f5b6df14ab)

Co-authored-by: Matt Clay <mclay@redhat.com>

* Add empty ignore.txt file for tests.
2020-09-01 17:05:19 -07:00
7d8b6dc779 [stable-2.10] Update the porting guide for ansible-2.10.0b1 (#71583). (#71584)
(cherry picked from commit 1882c60b04)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-09-01 17:58:18 -05:00
6aaef596d6 [docs] Fix up porting guides for CVE revert (#71581)
Change:
- Fix up wording and do proper backports for porting guide entries.

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit ed48a2dd62)
2020-09-01 17:34:33 -05:00
d699d38dd5 [stable-2.10] Update ansible-test remote endpoint handling. (#71413)
* Request ansible-core-ci resources by provider.
* Remove obsolete us-east-2 CI endpoint.
* Add new --remote-endpoint option.
* Add warning for --remote-aws-region option.
* Update service endpoints.
* Allow non-standard remote stages.
* Add changelog fragment.
(cherry picked from commit d099591964)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-09-01 14:54:17 -07:00
0e68601002 New release v2.10.1rc2 2020-09-01 01:01:32 -05:00
9a48ffd61b Attempt at reverting CVE-2020-1736 changes [2.10] (#71514)
* Revert atomic_move changes
* add note about mode reverts in porting guide

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-09-01 01:00:26 -05:00
314834c6d3 New release v2.10.1rc1 2020-08-31 19:42:18 -05:00
1678577681 [tests] fix fallout from dnf gpg fix (#71552)
Change:
- Missed needed gpg ignores

Test Plan:
- CI
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-31 18:24:00 -05:00
dc97027453 [dnf] ensure packages are gpg-verified (#71539)
Change:
- By default the dnf API does not gpg-verify packages. This is a feature
  that is executed in its CLI code. It never made it into Ansible's
  usage of the API, so packages were previously not verified.
- This fixes CVE-2020-14365.

Test Plan:
- New integration tests

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-31 10:05:30 -05:00
d3e0cb4320 [docs][2.10] Backportapalooza 9 (#71493)
* Explain duplicate checks includes tags and when (#68183)

##### SUMMARY
Per #67913, when comparing dependencies, Ansible takes into account parameters, tags and the when clause in determining whether a role is a duplicate or not.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

(cherry picked from commit 3e4377300b)

* Docs: ansible_host can contain FQDN (#71186)

(cherry picked from commit 13ab73cd89)

* clarify inventory plugin user documentation (#71387)

(cherry picked from commit fb035da3b2)

* Keep caution tape for older versions (#71400)

(cherry picked from commit 156b1c5245)

* document securing editor for vault (#71404)

(cherry picked from commit 6c48c62f93)

* galaxy: Add examples for galaxy section in ansible.cfg (#70931)

Add example section for galaxy section in ansible.cfg

Fixes: #68402

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 3f3bcbf05e)

* docs: Remove examples using the `ec2.py` script (#69107)

This script is mostly unmaintained and relies on the deprecated and
unmaintained `boto` library. Featuring it prominently in the docs
leads to many new users using it instead of the supported `aws_ec2`
inventory plugin.

(cherry picked from commit 66e38bf499)

* Update uri.py (#67688)

Adds an example of creating workspaces in Log analytics Azure
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>

(cherry picked from commit 4317c2c80c)

* docs: Update Kubernetes Guide (#71372)

Fixes: #61681

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 59b80b9146)

* fix broken links due to master -> main branch rename (#71426)

(cherry picked from commit 2b7461eb52)

* Modify wording to specify two ctl-d to end stdin input in ansible-vault (#69436)

* 51860 - Modify wording to specify two ctl-d to end stdin input in ansible-vault
* removes space to make line 160 chars

(cherry picked from commit a6537b59ab)

* user_guide: Add an example for loop (#71441)

Explain how to use complex data in loop while converting
from with_together

Fixes: #47906

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 5c1594916a)

* Add link to Matt's blog (#71436)

nitzmahone's blog nicely explained why Windows is not supported
as Ansible controller. Link that in documentation so users can
read about it.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 3c8744f0c1)

* user_guide: Fix reuse role examples (#71440)

Fixes: #53919

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 0b16c0a8c7)

* service: Add a note about ignored parameters (#71455)

Some parameters for systemd are ignored, add a note about such parameters in documentation.
Fixes: #23144

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 1257b0a184)

* updates network plugin docs pages for 2.10 (#71467)

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit f82a1e06d7)

* Remove "mode: preserve" option from documentation (#71486)

Remove "mode: preserve" option from documentation in doc fragments "FILE_COMMON_ARGUMENTS", as it was incorrectly included in the documentation for the `lineinfile`, `unarchive` and other file-related modules.
The `copy` and `templates` modules documentation remains untouched and still contain "mode: preserve", as intended.

(cherry picked from commit 7127d37466)

* quick update to changelog instructins (#71492)

(cherry picked from commit addee0699e)

* update Network Advanced Topics for FQCN (#71325)

* update Network Advanced Topics for FQCN

(cherry picked from commit b6f10b9b52)

* fix shippable error

Co-authored-by: David M. Lee <leedm777@yahoo.com>
Co-authored-by: Eric G <e+github1690@linuxw.info>
Co-authored-by: Sloane Hertel <shertel@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: flowerysong <paul.arthur@flowerysong.com>
Co-authored-by: Jose l. Azagra <azagramac@gmail.com>
Co-authored-by: Patrick Reader <pxeger@protonmail.com>
Co-authored-by: John Westcott IV <32551173+john-westcott-iv@users.noreply.github.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Timothy Visser <team@sacrome.com>
2020-08-31 09:59:52 -05:00
393412dc64 Fix play stats when rescue block is a child block (#70922) (#71334)
* check run state of current block only

* Add changelog and test

* Add test for issue 29047

(cherry picked from commit f2f6c34632)
2020-08-28 12:23:30 -05:00
7131c75d93 powershell - fix quoting values (#71411) (#71449)
* powershell - fix quoting values

* Add ignore for smart quote skip

(cherry picked from commit 72a7cb4a2c)
2020-08-28 12:22:22 -05:00
5688fef486 psrp - use native copy mechanism - 2.10 (#71434)
* psrp - use native copy mechanism (#71409)

* psrp - use native copy mechanism

* Fix sanity issues

* Split the bugfix and deprecation into separate changelog fragments

(cherry picked from commit 985ba187b2)

* Removed deprecation warnings for backport
2020-08-28 12:21:53 -05:00
b936539ae1 powershell - fix nested CLIXML parser (#71412) (#71451)
(cherry picked from commit 8897d7e2ff)
2020-08-28 09:54:14 -07:00
ce7b95499f native types: properly handle Undefined in nested data (#68432) (#71105)
(cherry picked from commit 5ca3aec3c4)
2020-08-28 07:57:17 -05:00
d38a7ff577 Fix changelog fragment type. (#70902) (#71114)
(cherry picked from commit fc83055425)
2020-08-27 14:07:22 -05:00
c39753d7ad [stable-2.10] linux facts - return proper broadcast address (#64528) (#71064)
Check that the value being returned is actually a broadcast address

(cherry picked from commit e6bf202738)
2020-08-27 13:48:50 -05:00
0c32a4f793 Emit proper error for x in y when y is undefined (#70990) (#71011)
Fixes #70984

(cherry picked from commit bf7276a4e8)
2020-08-27 13:46:52 -05:00
0c6edb34f9 [stable-2.10] unarchive - Check 'fut_gid' against 'run_gid' in addition to supplemental groups (#65666) (#71001)
* [stable-2.10] unarchive - Check 'fut_gid' against 'run_gid' in addition to supplemental groups (#65666)

Add integration tests for unarchiving as unprivileged user
Break tasks into separate files for easier reading and maintenance

Create a user by specifying a default group of 'staff' for macOS.

The user module does not actually remove the user directory on macOS,
so explicitly remove it.

Put the removal tasks in an always block to ensure they always run

Co-authored-by: Philip Douglass <philip.douglass@amadeus.com>
Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit ac5f3f8bef)

Co-authored-by: Philip Douglass <philip@philipdouglass.com>

* [stable-2.10] Fix unstable unarchive test (#71004)

* Add mode to copy tasks
* Fix unreliable test by ignoring errors

(cherry picked from commit f99f96ceb6)

Co-authored-by: Philip Douglass <philip@philipdouglass.com>
2020-08-27 13:45:19 -05:00
a253c93fd1 [2.10] iptables: Add a note about ipv6-icmp (#71010)
ipv6-icmp and icmpv6 are valid protocols and adding note about
it in protocol parameter.

Fixes: #70905

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit e139739ab3)
2020-08-27 13:43:11 -05:00
714cd2ad2e copy - redact 'content' from invocation in check mode (#71033) (#71067)
* sanitize copy module invocation secrets in check mode

(cherry picked from commit 991714b9d1)
2020-08-27 13:41:14 -05:00
f41ff33ca6 ansible-galaxy - fix download for subdirs in SCM (#71005) (#71093)
(cherry picked from commit f6b3b4b430)
2020-08-27 13:39:54 -05:00
00caeff928 dont clobber facts in loop (#71032) (#71095)
(cherry picked from commit f9af27c631)
2020-08-27 13:39:19 -05:00
6b639f147d [stable-2.10] Update ansible doc formats (#71070) (#71111)
* Fix tty_ify bugs and refactor

* Move tty_ify() and supporting attributes to the DocCLI class as that's
  the only thing using it.
* Add unittest for the code.
* Fix a bug where the substitution macros can be detected when they are
  a part of another word.
* Add support for L(), R(), and HORIZONTALLINE which were added to the
  website docs many years ago.

* Update test/units/cli/test_doc.py

Co-authored-by: Matt Clay <matt@mystile.com>

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit fb144c4)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-08-27 13:33:24 -05:00
4b1df6cc05 Remove ANSIBLE_COLLECTIONS_PATHS dep warning (#71094) (#71099)
(cherry picked from commit aab9beccf7)
2020-08-27 13:26:17 -05:00
e33fff922a ansible-test: bump acme test container version to 2.0.0 (#71097) (#71165)
(cherry picked from commit 050841324c)
2020-08-27 12:58:06 -05:00
092ec680e6 Ensure -k is set to delegated hosts without a pass (#71136) (#71168)
* Ensure -k is set to delegated hosts without a pass

* Fix up some broken tests

* Update task_executor.py

one possible fix, the other is updating winrm to normalize on 'password' like the other connection plugins

* Add alias for winrm and fix incorrect assumption

* Make sure aliases are used for keyword options

* Conditionally run test if sshpass is present, fix sanity

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
(cherry picked from commit 3f22f79e73)
2020-08-27 12:57:24 -05:00
e95b45c5ec Update network integration auth timeout (#71057) (#71238)
*  Incase of network integration test for connection local
   test the paramiko_ssh auth_timeout is the value of timeout
   under defaults section which is 10 seconds.
*  For slower connection 10sec timout value result in authentication
   timeout error hence increase the timeout value to 90 seconds

(cherry picked from commit 6160e82bf2)

Co-authored-by: Ganesh Nalawade <ganesh634@gmail.com>
2020-08-27 12:55:04 -05:00
7b3d2a00a0 Fix cron file regression (#71207) (#71243)
Co-authored-by: Florent PIGOUT <toopy@users.noreply.github.com>
2020-08-27 12:54:15 -05:00
7662568bd8 Antsibull build format backport 71080 (#71285)
* Updates to docs build for new antsibull CLI

* --ansible-base-cache renamed to --ansible-base-source
* _acd_version in the .deps file has been renamed to _ansible_version

(cherry picked from commit 22d2c97b81)

* Fix expr regex for MacOSX compat

MacOSX seems to want bare `+` whereas GNU expr wants escaped `+` (`\+`)
to mean match one or more.  Use `\{1,\}` instead which will match one or
more on both MaxOSX and GNU-using systems.

Fixes #71053

(cherry picked from commit 99cac0b135)

* Force an upgrade to a newer version of antsibull

(cherry picked from commit d816a5966e)
2020-08-27 12:53:29 -05:00
67b2b8caf1 Fix netconf validate capability check (#71195) (#71252)
*  Use ``:validate`` string to check if the netconf
   server supports validate capability as per netconf RFC

(cherry picked from commit 7635d23cee)
2020-08-27 12:52:49 -05:00
ca118613aa Fixes https://github.com/ansible-collections/cisco.iosxr/issues/74 (#71292)
*  ncclient API expects commit timeout value in either unicode
   or bytes format, hence convert the timeout value explicitly
   to string type.
2020-08-27 12:47:40 -05:00
02f4fc1a14 Skip literal_eval for string filters results in native jinja. (#70988) (#71313)
Fixes #70831

(cherry picked from commit b66d66027e)
2020-08-27 12:47:02 -05:00
90a8d07f31 [stable-2.10] Don't do conflict check on sdist and egg_info (#71310) (#71316) 2020-08-27 12:44:30 -05:00
c04a751f0e Reject unknown types from results queue. Fixes #70023 (#71336) 2020-08-27 12:43:20 -05:00
3f41c76564 [stable-2.10] Allow the TOML inventory to dump unsafe. Fixes #71307 (#71309) (#71317)
(cherry picked from commit 9da8801)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-08-27 12:35:36 -05:00
6d1cc0dede [stable-2.10] epoch can be a float with strftime filter. Fixes #71257 (#71314) (#71319)
(cherry picked from commit 6289570)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-08-27 12:35:21 -05:00
ac248cf34a systemd - supports new systemctl output message for chroot (#71197) (#71330)
The message generated by systemctl has been updated in 9321e23c40, which requires a corresponding change in the systemd module.

In addition, this fixes the module when the SYSTEMD_OFFLINE environment variable is set.

(cherry picked from commit a1a50bb3cd)
2020-08-27 12:34:59 -05:00
4cfe2cf8dc Fix meta tasks used with --flush-cache (#71311) (#71358)
* Remove incorrect code

(cherry picked from commit 88bfc7977d)
2020-08-27 12:23:58 -05:00
4dece71417 skydive.skydive was renamed to community.skydive (#71357) (#71364)
(cherry picked from commit 705c666521)
2020-08-27 12:23:39 -05:00
724b3648ea _check_failed_state: always use the current/nested state (#71347) (#71457)
Fixes #71306

(cherry picked from commit 9792d631b1)
2020-08-27 12:22:45 -05:00
3be597419d point all older release pages to devel (#71428) 2020-08-24 14:39:11 -05:00
1252323e34 Make changelog tool be more strict about suffixes (#70909) (#71135)
* Bump antsibull-changelog version.

* Flag all dotfiles, except .keep and .gitkeep.

* Enable ignoring other fragment extensions.

(cherry picked from commit fbfc0f99eb)
2020-08-21 09:33:08 -07:00
5f40a4efa6 Fix module links. (#71030) (#71389)
(cherry picked from commit a479b003e8)
2020-08-21 09:35:27 -05:00
72e9974f10 Documentation: improve dev_guide/testing_integration.rst (#71370) (#71390)
(cherry picked from commit 5498b0bb71)
2020-08-21 09:33:43 -05:00
26bb114ccb [backport][docs][2.10]Docsbackportapalooza 8 (#71379)
* Move 2.10.0rc1 release date a few days forward. (#71270)

At yesterday's meeting it was decided to have ansible-2.10.0 depend on
ansible-base-2.10.1 so that we can get several fixes for ansible-base's
routing (including adding the gluster.gluster collection).
ansible-base-2.10.1 will release on September 8th.  So we will plan on
releasing ansible-2.10.0rc1 on the 10th.

https://meetbot.fedoraproject.org/ansible-community/2020-08-12/ansible_community_meeting.2020-08-12-18.00.html
(cherry picked from commit e507c127e5)

* a few writing style updates (#71212)

(cherry picked from commit 4f0bd5de38)

* Fix code markups and add link to CVE (#71082)

(cherry picked from commit 92d59a58c0)

* Fix 404 links (#71256)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit ecea018506)

* Writing style updates to Developing dynamic inventory topic (#71245)

* modified the writing style

* incorporated peer feedback

(cherry picked from commit ecd3b52ad7)

* Fix roadmap formatting. (#71275)

(cherry picked from commit ee48e0b0ad)

* Update password.py (#71295)

List md5_crypt, bcrypt, sha256_crypt, sha512_crypt as hash schemes in the password plugin.

(cherry picked from commit 1d1de2c6fd)

* Update ansible european IRC channel (#71326)

Signed-off-by: Rémi VERCHERE <remi@verchere.fr>
(cherry picked from commit 824cd4cbeb)

* Add warning about copyright year change (#71251)

To simplify project administration and avoid any legal issues,
add a warning in the docs. This reflects - https://github.com/ansible/ansible/issues/45989#issuecomment-423635622 and fixes: #45989

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 606604bb97)

* subelements: Clarify parameter docs (#71177)

skip_missing parameter in subelements lookup plugin is accepted from
inside the dictionary.

Fixes: #38182

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 6d17736ef4)

* Writing style updates to Using Variables topic (#71194)

* updated topic title, underline length for headings, and incorporated peer feedback

(cherry picked from commit 4d68efbe24)

* cron module defaults to current user, not root (#71337)

(cherry picked from commit 4792d83e13)

* Update Network Getting Started for FQCN/collection world (#71188)

* pull out network roles, cleanup, update first playbook examples, update gather facts section, some inventory conversion to .yml, update inventory and roles, simplify the navigation titles, fix tocs, feedback comments

(cherry picked from commit f79a7c5585)

* Add documentation about info/facts module development (#71250)

Fixes: #40151

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 4f993922c8)

* network: Correct documentation (#71246)

ini-style inventory does not support Ansible Vault password.
This fixes network_best_practices_2.5 doc.
Fixes: #69039

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a1257d75aa)

* tidies up vars page (#71339)

(cherry picked from commit 02ea80f6d7)

* base.yml: Fix typos (#71346)

(cherry picked from commit 41d7d53573)

* quick fix to change main back to devel (#71342)

* quick fix to change main back to devel
* Update docs/docsite/rst/dev_guide/developing_collections.rst

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 74f88c56a5)

* Add note about integration tests for new modules to the dev guide (#71345)

(cherry picked from commit b82889eef5)

* update fest link (#71376)

(cherry picked from commit 80b8fde946)

* incorporate minimalism feedback on debugging page (#71272)

Co-authored-by: bobjohnsrh <50667510+bobjohnsrh@users.noreply.github.com>

(cherry picked from commit 5073cfc8bc)

* fix header problem

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Co-authored-by: Sayee <57951841+sayee-jadhav@users.noreply.github.com>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: rovshango <rovshan.go@gmail.com>
Co-authored-by: Remi Verchere <rverchere@users.noreply.github.com>
Co-authored-by: Jake Howard <RealOrangeOne@users.noreply.github.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Per Lundberg <perlun@gmail.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2020-08-20 17:44:50 -05:00
9a26fbe58e update Ansible-maintained platform guides with FQCN (#70369) (#71263)
* update platform guides with FQCN
* implemented feedback
* fix remainin fqcn
* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>

(cherry picked from commit 172230d7b8)
2020-08-20 16:27:58 -05:00
8775001671 Add the ansible_2_10 intersphinx reference. (#71028) (#71384)
There are links from the scenario guides to collections but collections
docs aren't built in testing or locally when we're on the devel branch.
Due to that we need to make sure those references resolve to the
production docsite.  We can use intersphinx to make sure that happens.

* The test for binary files wasn't reading enough of the file.

Checking for null bytes in the first 1024 bytes failed to diagnose the
ansible_2_10.inv file as binary

(cherry picked from commit e10902d744)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-08-20 16:13:45 -05:00
a007176d7e Backport/2.10/70530 (#71380)
* add FQCN to M() references (#70530)

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit dd048a5197)

* Fix make webdocs warnings (#71340)

(cherry picked from commit 7f97a62d87)

Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-08-20 15:45:15 -05:00
4442661611 dev_guide: improve developing_collections.rst (#71332) (#71365)
(cherry picked from commit 180507c62b)
2020-08-20 09:48:02 -05:00
13dff99f50 developing_modules_in_groups.rst: add note about releasing (#71305) (#71366)
(cherry picked from commit 9296ee9329)
2020-08-20 09:47:28 -05:00
e0a550efea overview_architecture.rst: fix playbook example (#71303) (#71367)
(cherry picked from commit a496b89d6f)
2020-08-20 09:46:40 -05:00
1984a34c2b Add Fest banner (#71360) (#71361)
Adds Fest banner, with fixes; updates existing banners, adds links.

(cherry picked from commit 9be8d723da)
2020-08-19 15:41:37 -05:00
aa51c6000a Fix fortimanager httpapi redirect (#71073) (#71081)
* The fortimanager httpapi plugin is in fortinet.fortimanager, not in fortinet.fortios.

* Add changelog fragment.

(cherry picked from commit 4bd7580dd7)
2020-08-19 13:29:55 -05:00
a06730cdb0 Redirect gluster modules to gluster.gluster. (#71240) (#71264)
(cherry picked from commit 9f72ff80e3)
2020-08-19 13:28:01 -05:00
c96e955c76 Fix roadmap formatting. (#71275) (#71322)
(cherry picked from commit ee48e0b0ad)
2020-08-17 15:32:18 -05:00
1895b7ab5e Update auto-generated 2.10 porting guide in devel. (#71276) (#71323)
(cherry picked from commit 61b7f234bd)
2020-08-17 15:31:47 -05:00
fa18566c3e [stable-2.10] Fix ansible-test self-test change classification.
Changes to sanity and unit tests now trigger the ansible-test self-test integration tests.

No changelog entry since this only affects tests for ansible itself and not collections.
(cherry picked from commit b53e7f8720)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-08-17 11:16:56 -07:00
3b9ee86381 [stable-2.10] fix collection package root location under pytest >=6.0.0 (#70963)
(cherry picked from commit 86b6c4bbb6)

Co-authored-by: nitzmahone <nitzmahone@users.noreply.github.com>
2020-08-17 11:16:08 -07:00
8c4af4bc3b Update Ansible release version to v2.10.0.post0. 2020-08-13 15:29:34 -05:00
a6ed955132 New release v2.10.0 2020-08-13 12:30:50 -05:00
ae9c1167e4 [2.10] Docs Backportapalooza 7 (#71261)
* Fixes due to branch being renamed (#71115)
The ansible collection repository correctly renamed their default branch from `master` to `main`, which has caused a number for broken urls. This PR fixes those urls.

(cherry picked from commit fb9c9570d5)

* Docs:  Fix typo (#71119)

(cherry picked from commit cb9336ab6d)

* remove network for 2.10 base porting guide (#71158)

(cherry picked from commit 56748a8060)

* Updating Getting Started with Resources section #68962 (#71102)

* Updating Getting Started with Resources section #68962
* Add links, including Workshops URL #68962

(cherry picked from commit 5f8b45a70e)

* start of 'data manipulation' examples (#46979)

Co-authored-by: Klaus Frank <agowa338@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit f46b124d65)

* toml: Clarify about inventory examples (#71180)

Add a note in toml inventory plugin about three different
inventory examples. Fixes: #67003

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit edac065bd2)

* filters: minor doc fix (#71178)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 0a7ab396c7)

* docs: 'ansible_play_hosts' lists active hosts, not limited by serial (#71116)

ansible_play_batch lists the currently targeted host(s) in the serial/batch, while
ansible_play_hosts lists all the hosts which will be targeted by the play.

(cherry picked from commit e72e12aa27)

* Fix references to Ansible Collections Overview (#71227)

(cherry picked from commit 19589db10c)

* add another resource module example (#71162)

* Update docs/docsite/rst/network/user_guide/network_resource_modules.rst
Co-authored-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>

(cherry picked from commit f4388de14d)

* Adds fest link (#71241)

(cherry picked from commit ae3b8eec12)

* Update release page for ansible and ansible-base (#71229)

* [docs] 2.7 is EOL, add 2.10 which is almost out
- Remove 2.7 support from the maintenance schedule
- Add 2.10 which is in RC and will be out soon enough.
Signed-off-by: Rick Elrod <rick@elrod.me>

* Update docs/docsite/rst/reference_appendices/release_and_maintenance.rst, fix table and separate ansible-base from ansible, fix rstcheck errors, clean up sections, explain the two packages
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Rick Elrod <rick@elrod.me>

(cherry picked from commit 553ccedcd3)

Co-authored-by: Daniel Finneran <dan@thebsdbox.co.uk>
Co-authored-by: Liviu Chircu <liviu@opensips.org>
Co-authored-by: kshitijcode <ikshitijsharma@gmail.com>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Håkon Solbjørg <hakon@solbj.org>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-08-13 12:23:46 -05:00
6e3271aa61 [stable-2.10] Revert default mode changes (#71260)
* Revert "[stable-2.10] Revert "Change default file permissions so they are not world readable (#70221) (#70824)" (#71236)"

This reverts commit c968020d52.

* Revert "Remove porting guide entry related to reverted change (#71242)"

This reverts commit 006a21eae2.
2020-08-13 12:17:47 -05:00
006a21eae2 Remove porting guide entry related to reverted change (#71242)
Related to #71236
2020-08-13 02:23:03 -05:00
c968020d52 [stable-2.10] Revert "Change default file permissions so they are not world readable (#70221) (#70824)" (#71236)
* [stable-2.10] Revert "Fix warning for new default permissions when mode is not specified (#70976) (#70985)"

This reverts commit 5cb96087e6.

* [stable-2.10] Revert "Change default file permissions so they are not world readable (#70221) (#70824)"

This reverts commit 7e4cffc5d2.
2020-08-12 14:30:47 -05:00
b9a406f890 Docs [2.10] Backportapalooza 6 (#71129)
* Misc typo fixes (#71089)

(cherry picked from commit 504ef607f3)

* Add some documentation for the format of meta/runtime.yml (#71035)

* Document the format of meta/runtime.yml

* Document multiple Ansible versions

Clarify difference between deprecation and tombstone fields

* add note

(cherry picked from commit a9eb8b0488)

* add note to uninstall older versions of ansible for pip (#71023)

* add note to uninstall older versions of ansible for pip

* combine with the other PR

(cherry picked from commit 72d3d44163)

* VMware: Inventory scenario guide for hostnames (#71055)

Added a scenario guide for ``hostnames`` parameter
for vmware_vm_inventory.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 0055673c70)

* Document string tests a bit more (#71049)

- Explain how `regex` differs from `match` and `search`.
- Document `multiline` and `ignorecase`.

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 701c638757)

* docs: Add a note about package requirements for fact gathering (#70796)

Fixes: #26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a6725d6e2a)

* added note about fakeroot (#71018)

see #70895

(cherry picked from commit 11a31e99e6)

* Update documentation of httpapi's handle_httperror method for clarity (#70991)

(cherry picked from commit a0523e5b8a)

* DOCS: add 2.10 collections roadmap (#70975)

* draft of 2.10 collections roadmap

* incorporates feedback from felixfontein

* gundalow and samccann feedback, fix link

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit 9879da8e23)

* updates changelog types; some updates for easier translation (#71027)

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 4f4436c124)

* Document common return values with examples (#71046)

* adding return value examples
* shift to console code blocks
* cleaning up whitespace and shortening invocation example
* reordering diff section

(cherry picked from commit 864573a38d)

* Update intro_getting_started.rst (#71039)

Added two additional learning resources in the See also: section- forgot closing backticks

(cherry picked from commit 9850915bd6)

* Guide users to use ansible-runner (#71063)

Update the docs to guide users to use `ansible-runner` instead of using Python API directly. In many use cases, executing Ansible playbooks are sufficient. In those use cases, `ansible-runner` is easier and much stable to use comparing with Python API, but there is no mention of it.

(cherry picked from commit 0c855dc70b)

* Porting guides for ansible-base 2.10 and ansible 2.10 (#70891)

* Fix changelog link title.

* Rename Ansible 2.10 and 2.11 porting guides to Ansible-base porting guides.

* Add stub for automatically generated 2.10 porting guide.

* Move things that should not be in the ansible-base porting guide to the ansible porting guide.

* Apply changes to base porting guides.

* Add remark that ansible-base is mainly for developers.

* Ansible Base -> Ansible-base

* Fix link in base porting guide.

* Add generated porting guide.

* Use same header signs as antsibull-changelog's RST builder.

* Update generated porting guide.

(cherry picked from commit 61b36c6f30)

* Update network platform guides with FQCN (#70699)

* fqcn all the docs things!

(cherry picked from commit 54bee7152b)

* Document how to upgrade to ansible with pip (#70768)

Fixes #70348

(cherry picked from commit 5019335660)

* document how to migrate between collections (#70243)

* document how to migrate between collections
* Apply suggestions from code review

Co-authored-by: John R Barker <john@johnrbarker.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 58145dff9c)

* remove github link from plugins (#70951)

(cherry picked from commit e28b20d729)

* Add latest rc from ansible-base (#70974)

* Add latest rc from ansible-base

(cherry picked from commit d62dffafb3)

* Document to_json will convert to ASCII strings by default (#70954)

... as reported in issue #68702

(cherry picked from commit 8c48366f1c)

* Update the porting guide for ansible-2.10.0a8 (#71141)

(cherry picked from commit 0a9638ce4b)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sloane Hertel <shertel@redhat.com>
Co-authored-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Nathaniel Case <ncase@redhat.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Terciero <terciero@users.noreply.github.com>
Co-authored-by: Brendon O'Sullivan <49501251+bjosullivan@users.noreply.github.com>
Co-authored-by: EthanHur <ethan0311@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-08-07 16:04:19 -05:00
4b03d898f3 Update integration tests to support rpmfluff-0.6 (#71155) (#71159)
Co-authored-by: Matt Martz <matt@sivel.net>
2020-08-07 14:52:17 -05:00
a187613da8 Add CVE reference to changelog for PR 70762 (#71151) (#71156)
Co-authored-by: David Shrewsbury <Shrews@users.noreply.github.com>
2020-08-07 11:50:34 -05:00
72aa55d514 [stable-2.10] Fix version comparison for determining what ansible to build against (#71152)
* The version comparison for determining what ansible package to build
  docs against was comparing the version number for ansible-base but it
  needed to check the version number for ansible instead

* add a comment about some bad logic than needs to be fixed after 2.10.0
(cherry picked from commit 37a7485)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-08-07 10:18:25 -05:00
be5aab177c [stable-2.10] Drop "rhui-" prefix from RHEL repositories in AMI (#71130) (#71131)
The repository names seem to have changed and no longer have the "rhui-" prefix
(cherry picked from commit 6ac4439a6a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-08-06 16:58:58 -05:00
3e7e3ee352 Warning banner should only show on /devel/ docs, not on pages with 'devel' in their titles (#70849) (#71075)
* Update docs/docsite/_themes/sphinx_rtd_theme/ansible_banner.html
* Only match paths at the beginning

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
(cherry picked from commit 8313cc8fb1)
2020-08-06 16:19:59 -05:00
58517e52e2 Porting guides for ansible-base 2.10 and ansible 2.10 (#70891) (#71029)
* Fix changelog link title.

* Rename Ansible 2.10 and 2.11 porting guides to Ansible-base porting guides.

* Add stub for automatically generated 2.10 porting guide.

* Move things that should not be in the ansible-base porting guide to the ansible porting guide.

* Apply changes to base porting guides.

* Add remark that ansible-base is mainly for developers.

* Ansible Base -> Ansible-base

* Fix link in base porting guide.

* Add generated porting guide.

* Use same header signs as antsibull-changelog's RST builder.

* Update generated porting guide.

(cherry picked from commit 61b36c6f30)
2020-07-31 15:52:55 -05:00
224a0b4809 [DOCS] Backportapalooza 5 (#70999)
* misc typo fixes (#70736)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8915f262b4)

* How to use rst :ref: for modules in collections (#70567)

(cherry picked from commit 748ba96610)

* Update network_best_practices_2.5.rst (#70962)

Fix a small typo in the playbook tasks sample section

(cherry picked from commit 69e5c6c14a)

* Fix a typo in "restart mysql" example (#70950)

Fix a typo in "restart mysql" example task. It's missing a space between "state:" and "restarted".

(cherry picked from commit 37e9d2278a)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: PJ Waskiewicz <pjwaskiewicz@gmail.com>
Co-authored-by: Emilien Macchi <EmilienM@users.noreply.github.com>
2020-07-31 15:51:54 -05:00
b8eb35ef76 Update Ansible release version to v2.10.0rc4.post0. 2020-07-30 18:27:32 -05:00
3900f82d00 New release v2.10.0rc4 2020-07-30 16:17:16 -05:00
9f4748cb2d fix downloading collections in git repos and tar.gz artifacts (#70524) (#71000)
* Fix downloading tar files

* Fix downloading SCM collections

* changelog

(cherry picked from commit 54e2ae79e7)
2020-07-30 13:37:59 -07:00
719c40bfdf [stable-2.10] facts - fix incorrect time for some date_time_facts (#70665) (#70996)
* [stable-2.10] facts - fix incorrect time for some date_time_facts (#70665)

The iso8601_micro and iso8601 facts incorrectly called now.utcnow(), resulting
in a new timestamp at the time it was called, not a conversion of the previously
stored timestamp.

Correct this by capturing the UTC timestamp once then calculating the local
time using the UTC offset of the current system.

* Use time.time() for getting the current time
* Convert from that stored epoch timestamp to local and UTC times
* Used existing timestamp for epoch time
* Add unit tests that validate the formate of the return value rather than an exact value since mocking time and timezone is non-trivial
(cherry picked from commit c4f442ed5a)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Remove tests for tz_dst since that only exists in newer versions
2020-07-30 13:37:19 -07:00
b764d381f0 [stable-2.10] Fix ansible-test relative import analysis. (#70993)
(cherry picked from commit 2e0097ada3)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-30 13:36:49 -07:00
abfedb06c3 default_callback: Move 'check_mode_markers' in doc_fragments (#70228) (#70989)
Callback plugin dense, yaml, and debug implement 'check_mode_markers'
so moving documentation to default callback doc_fragments.

Fixes: https://github.com/ansible-collections/community.general/issues/565

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 4885ebad27)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-07-30 13:36:24 -07:00
5cb96087e6 Fix warning for new default permissions when mode is not specified (#70976) (#70985)
Follow up to #70221
Related to #67794
CVE-2020-1736

When set_mode_if_different() is called with mode of 'None', ensure we issue
a warning about the change in default permissions.

Add integration tests to ensure the warning works properly.

* Fix tests
- actually use custom module 🤦‍♂️
- verify file permission on created files
- use remote_tmp_dir so we're ready for split controller
- improve test module so we can skip the call to set_fs_attributes_if_different()
- fix tests for CentOS 6

(cherry picked from commit dc79528cc6)
2020-07-30 10:10:23 -07:00
a8217f1bd4 ansible-galaxy - fix fallback for AH searches (#70957) - 2.10 (#70980)
* ansible-galaxy - fix fallback for AH searches (#70957)

(cherry picked from commit b1cb2553af)

* Fix tests after backport
2020-07-30 10:08:25 -07:00
8389f4df0b [stable-2.10] Update module debugging docs (#70847) (#70972)
- Combine remote and local debugging instructions.
- Update the example code to match current AnsiballZ structure and behavior
- Change reference name and update references
- Clarify how PYTHON path is modified
- Also add note about other remote debugging tools.

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit 7f0c84ea15)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-29 14:33:36 -07:00
a75b3601d9 Allow changed/failed mgmt on strategy actions (#70919) (#70968)
* Allow changed/failed mgmt on strategy actions

(cherry picked from commit f9c3c6cba6)
2020-07-29 14:32:33 -07:00
4c459f341b Document galaxy install from local clones (#70941) (#70967) 2020-07-29 13:55:15 -07:00
c39e536d84 validate-modules: fix version_added validation for top-level, fix error codes (#70869) (#70947)
* Also validate top-level version_added.

* Fix error code.

* Produce same version_added validation error in schema than in code (and stop returning it twice).

* Return correct error codes for invalid version_added for options and return values.

* Add changelog.

* Fix forgotten closing braket.

* Accept 'historical' for some top-level version_added.

(cherry picked from commit 7e2cc7db12)
2020-07-29 13:54:45 -07:00
6f70d40d51 [stable-2.10] lineinfile - fix broken exception handling (#70846) (#70944)
* prevent (ExceptionType) is not subscriptable errors
* tweak error message and use text conversion
* add to_text import
(cherry picked from commit 45c2eb6c0a)

Co-authored-by: nitzmahone <nitzmahone@users.noreply.github.com>

Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
2020-07-29 13:53:54 -07:00
293d6c59bb [stable-2.10] reboot - fix Void Linux (#70704) (#70916)
Add entry for appropriate commands for Void Linux
(cherry picked from commit 4cc4cebc97)

Co-authored-by: fosslinux <fosslinux@aussies.space>

Co-authored-by: fosslinux <fosslinux@aussies.space>
2020-07-29 13:52:45 -07:00
bf479eb7f3 [ansible_builtin_runtime.yml] fix text[fs]m typo (#70893) (#70894)
Change:
- textsfm -> textfsm

Test Plan:
- Out-of-band ansible_builtin_runtime.yml checker script

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-07-29 13:52:09 -07:00
155041d8ee Fix ansible-test error in community.aws (#70507) (#70873)
* Fix ansible-test error in community.aws

* Add changelog entry for fix

* Change check from None to string_types

* Update changelogs/fragments/70507-validate-null-author.yaml

clarify wording "or a list of strings"

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/schema.py

clarify wording - single string or not specified valid

Co-authored-by: Felix Fontein <felix@fontein.de>

* Do not fail but return None when given outside list

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b0d9deeae3)

Co-authored-by: Alan Rominger <arominge@redhat.com>
2020-07-29 13:51:47 -07:00
be28e98cf2 [backport][2.10][PR #70446] Refactor Python API examples and docs (#70850)
* Add boilerplate snippet into `examples/`

It is a partial backport of #70224

(partially cherry picked from commit 4816bb4f43)

* Refactor Python API examples and docs

PR #70446: it's a follow-up for #70445.

It includes a merge of `examples/scripts/uptime.py` and a similar
code snippet from `docs/docsite/rst/dev_guide/developing_api.rst`.

This patch also changes the docs RST file to include contents of
the example file instead of holding a copy of a similar code.

(cherry picked from commit 20bb915092)
2020-07-29 13:51:21 -07:00
4280efccc4 [stable-2.10] Cap pytest version to avoid relative import issue.
(cherry picked from commit 3a8ac62596)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-28 17:14:30 -07:00
8d2b25d490 Docs backportapalooza 4 (#70875)
* Pipe lookup plugin usage example documentation fix (#70679)

(cherry picked from commit 58d24584c0)

* Fix misleading documentation for naming blocks (#68458)

From what I have observed it is the block itself that doesn't support the name attribute rather than the tasks inside the block.

* Update docs/docsite/rst/user_guide/playbooks_blocks.rst

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit 633c2d0522)

* Fix incorrect statement to set a variable for a playbook (#70712)

Fixes #70638

(cherry picked from commit 59513ae673)

* Make Sources, Plugins sections easier to read (#70652)

Re-wrote the Inventory Sources section and also the next section to have shorter, clearer sentences with a more active voice.

(cherry picked from commit fb3db170cc)

* fix rstcheck problem and gitignore collections dir (#70764)

(cherry picked from commit 24e5d3a51c)

* add note for write permission on rst files (#70766)

* add note for write permission on rst files
* Update docs/docsite/rst/community/documentation_contributions.rst

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
(cherry picked from commit 2a7df5e07b)

* Modification of 'Adding modules and plugins locally' topic (#70659)

* Remediated the topic to comply with IBM style guide and minimalism practices
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>

(cherry picked from commit 1733253297)

* WIP: add collections as an intersphinx link (#70826)

* adds collections as a ref for intersphinx

* no need for intersphinx

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit b28d59124b)

* Proper example for splitext filter in docs (#70494)

* Update playbooks_filters.rst with a clear example of how to extract its 2 tokens.

Co-authored-by: Sloane Hertel <shertel@redhat.com>
(cherry picked from commit 7a42d27462)

* Few fixes for reference_appendices/faq.html (#70719)

* Format using `` instead of `, add line breaks for long lines, rephrase or remove useless text.
Move some text.

* Add clearer version of OpenSSh is affected by SCP bug

* Review some pages using ansible doc writing guide.

(cherry picked from commit 92e16c2838)

Co-authored-by: Roman Gorshunov <34521622+gorshunovr@users.noreply.github.com>
Co-authored-by: David Rieger <david@isan.engineer>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Stef B <regendo@users.noreply.github.com>
Co-authored-by: Sayee <57951841+sayee-jadhav@users.noreply.github.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Fixmetal <fixmetal@gmail.com>
2020-07-28 17:38:17 -05:00
12784beb87 Update Ansible release version to v2.10.0rc3.post0. 2020-07-24 18:16:57 -05:00
f28fa88448 New release v2.10.0rc3 2020-07-24 15:59:04 -05:00
9b992c0b78 reset logging to INFO (#70878) (#70881)
- due to CVE-2019-14846
 - also added comments and test to avoid 'oportunistic' reversion

(cherry picked from commit 1223ce656a)
2020-07-24 15:47:57 -05:00
cea2544943 Update Ansible release version to v2.10.0rc2.post0. 2020-07-23 23:16:58 -05:00
c528e648a6 New release v2.10.0rc2 2020-07-23 21:38:44 -05:00
c53a68bf16 Update ansible-base test container to 1.5.0. (#70856) (#70857)
Co-authored-by: Matt Clay <mclay@redhat.com>
2020-07-23 21:36:41 -05:00
e9c9c02e0a Do not add connection vars to the output results (#70853) (#70855)
* Do not add connection vars to the output results

* Also revert the delgated scenario JIC

* Added regression test

(cherry picked from commit 5e1a968983)
2020-07-23 19:48:45 -05:00
6dd05dfe67 Update Ansible release version to v2.10.0rc1.post0. 2020-07-23 17:33:24 -05:00
3ee5b46ba7 New release v2.10.0rc1 2020-07-23 14:44:50 -05:00
cc8d180801 fix internal cases of actions calling unqualified module names (#70818) (#70840)
* fix internal cases of actions calling unqualified module names

* add porting_guide entry
* misc other fixes around action/module resolution broken by redirection

ci_complete

* Update docs/docsite/rst/porting_guides/porting_guide_2.10.rst

Co-authored-by: Rick Elrod <rick@elrod.me>

* Update docs/docsite/rst/porting_guides/porting_guide_2.10.rst

Co-authored-by: Rick Elrod <rick@elrod.me>

* address review feedback

* pep8

* unit test fixes

* win fixes

* gather_facts fix module args ignores

* docs sanity

* pep8

* fix timeout test

* fix win name rewrites

Co-authored-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 4c0af6c808)
2020-07-23 10:29:09 -07:00
7969b60552 Fix the internal Python API usage examples (#70841)
Previous version initialized the `TaskQueueManager` after calling
`Play.load()` while advertising a way to inject a custom library
location path. This caused the tasks loader not to find any custom
modules because it was triggered before the path was actually added
to the module loader.

This patch changes the order of the operations to ensure that the
customized `context.CLIARGS` actually influences things.

Resolves https://github.com/ansible/ansible/issues/69758.

(cherry picked from commit 8d97c8c222)
2020-07-23 10:10:42 -07:00
180eea8089 Update default from True to False for CONDITIONAL_BARE_VARS (#70709) (#70838)
ci_complete

(cherry picked from commit 2811d9486f)
2020-07-23 10:09:58 -07:00
7e4cffc5d2 [stable-2.10] Change default file permissions so they are not world readable (#70221) (#70824)
* Change default file permissions so they are not world readable

CVE-2020-1736

Set the default permissions for files we create with atomic_move() to 0o0660. Track
which files we create that did not exist and warn if the module supports 'mode'
and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults.

A code audit is needed to find all instances of modules that call atomic_move()
but do not call set_mode_if_different(). The findings need to be documented in
a changelog since we are not warning. Warning in those instances would be frustrating
to the user since they have no way to change the module code.

- use a set for storing list of created files
- just check the argument spac and params rather than using another property
- improve the warning message to include the default permissions.
(cherry picked from commit 5260527c4a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-23 09:07:18 -07:00
8c2754e6d3 Allow hostvars delegation (#70331) (#70810)
* ensure hostvars are available on delegation
* also inventory_hostname must point to current host and not delegated one
* fix get_connection since it was still mixing original host vars and delegated ones
* also return connection vars for delegation and non delegation alike
* add test to ensure we have expected usage when directly assigning for non delegated host

(cherry picked from commit 84adaba6f5)
2020-07-22 18:29:07 -07:00
7cdba7c923 Sanitize URI module keys with no_log values (#70762) (#70820)
* Add sanitize_keys() to module_utils.

* More robust tests

* Revert 69653 change

* Allow list or dict

* fix pep8

* Sanitize lists within dict values

* words

* First pass at uri module

* Fix insane sanity tests

* fix integration tests

* Add changelog

* Remove unit test introduced in 69653

* Add ignore_keys param

* Sanitize all-the-things

* Ignore '_ansible*' keys

* cleanup

* Use module.no_log_values

* Avoid deep recursion issues by using deferred removal structure.

* Nit cleanups

* Add doc blurb

* spelling

* ci_complete

(cherry picked from commit bf98f031f3)
2020-07-22 18:28:24 -07:00
529dad9a39 Add ansible-releases@redhat.com to announce template (#70813)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-07-22 18:27:44 -07:00
4cbfb08da5 [stable-2.10] Document existing ansi_re sequences and add ESC[m (#70683) (#70807)
* Document existing ansi_re sequences and add `ESC[m`

* Add changelog
(cherry picked from commit 06a4fc2)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
2020-07-22 18:27:21 -07:00
18dd73c147 [2.10] basic: use PollSelector implementation (#70800)
Some platform such as ESXi does not implement EpollSelector,
which is selected by DefaultSelector. Use PollSelector.
This works perfectly with a platform like VMware ESXi.

Fixes: #70238

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8cccede0d4)
2020-07-22 18:26:47 -07:00
61f8f8ce7f cron - Allow non-ascii (UTF-8) chars in cron file paths and jobs (#70426) (#70794)
* Encode/Decode files in UTF-8
* Use helper function in ansible
* Add an integration test
* Use emoji in test data.
* add changelog
* Also support non-ascii chars in filepath and add tests about this.
* Also use non-ascii chars in replaced text and ensure not to break cron syntax.
* rename self.existing to self.n_existing
* rename crontab.existing to crontab.n_existing
2020-07-22 18:26:10 -07:00
7eb5f53294 [stable-2.10] Ensure single vaulted values aren't counted as sequences. Fixes #70784 (#70786) (#70791)
(cherry picked from commit 96b74d3)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-07-22 18:25:38 -07:00
1eb2afac63 Create home and parent directories only when requested (#70790)
The home user and the parents directories should only be created when
create_home == True

(cherry picked from commit f3dd8d3052)
2020-07-22 18:23:47 -07:00
4170786cd9 2.10: Detect failure in always block after rescue (#70094) (#70204)
* Detect failure in always block after rescue (#70094)

* Detect failure in always block after rescue

Fixes #70000

ci_complete

* Add more tests

(cherry picked from commit 0ed5b77377)

* add changelog

Co-authored-by: Matt Davis <mrd@redhat.com>
2020-07-22 14:00:27 -07:00
32c818a1c8 Update Molecule support contact (#70797) (#70804)
As Molecule started to use https://github.com/ansible-community/molecule/discussions we need to update documentation before retiring
the molecule-users mailing list.

(cherry picked from commit b7ee07215d)

Co-authored-by: Sorin Sbarnea <ssbarnea@users.noreply.github.com>
2020-07-22 12:15:12 +01:00
75be854360 runtime: aws_netapp_cvs_filesystems (#70781) (#70803)
(cherry picked from commit 481cd30129)
2020-07-22 12:14:45 +01:00
9cd47492be runtime os_image_facts is now called os_image_info (#70776) (#70780)
(cherry picked from commit 1e0d83524c)
2020-07-21 11:24:22 -07:00
448f17e9a5 [stable-2.10] Guard against allowing ansible to ansible-base upgrades (#70529) (#70760)
* Fix building Ansible dist w/ setuptools>=48,<49.1 (#70525)

* Fix building Ansible dist w/ setuptools>=48,<49.1

This change addresses the deprecation of the use of stdlib
`distutils`. It's a short-term hotfix for the problem and we'll
need to consider dropping the use of `distutils` from our `setup.py`.

Refs:
* https://github.com/ansible/ansible/issues/70456
* https://github.com/pypa/setuptools/issues/2230
* https://github.com/pypa/setuptools/commit/bd110264

Co-Authored-By: Jason R. Coombs <jaraco@jaraco.com>

* Add a change note for PR #70525

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
(cherry picked from commit 918388b85f)

* Guard against allowing ansible to ansible-base upgrades (#70529)

* Guard against allowing ansible to ansible-base upgrades

* newline

* use alias

* Add an explicit line detailing this is a 1 time thing

* period

* Read __version__ and __author__ rather than import, update working, and add ability to skip conflict checks

* Remove commented code

* Re introduce removed changes from rebase

* Just use open

* Nuke unused import

(cherry picked from commit 54b002e1ac)

Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
2020-07-21 11:23:55 -07:00
ffd3757fc3 Fix missing quoting for remote_tmp in second mkdir of shell module. Issue #69577 (#69578) (#70757)
* Fix missing quoting for remote_tmp in second mkdir of shell module. Issue #69577

* adding changelog

* fixing typo in changelog entry

* adding test case

Adding test case written by bmillemayhias.

* using $HOME instead of ~

* fixing commit measage

* Update 69578-shell-remote_tmp-quoting.yaml

Co-authored-by: Brian Kohles <me@briankohles.com>
(cherry picked from commit 77d0effcc5)

Co-authored-by: Brian Kohles <briankohles@users.noreply.github.com>
2020-07-21 11:23:25 -07:00
0d230b4f56 [2.10] debconf: add a note about no_log usage (#70752)
debconf module exposes sensitive information to logs, console.
Add a note to user about using no_log=True to hide such
information from console.

Fixes: #32386

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 84b4387702)
2020-07-21 11:21:45 -07:00
9b8a649f2e [stable-2.10] Handle Slackware OS version strings containing a plus (“+”) (#68142) (#70717)
A couple of years ago Slackware -current began using a plus (“+”) at the end of the distribution version string to indicate a future version work-in-progress.

Rearrange distribution_files unit tests to easily support more tests
  - add conftest with common fixtures
  - use parametrize for testing multiple scenarios

* Add changelog
* Add unit tests for Slackware distribution parsing
* Use correct fixtures for Slackware
Data comes from /etc/slackware-version

Co-authored-by: Sam Doran <sdoran@redhat.com>
Co-authored-by: <Eduard Rozenberg <eduardr@pobox.com>>
(cherry picked from commit 566c5e6ce1)

Co-authored-by: Eduard Rozenberg <2648417+edrozenberg@users.noreply.github.com>

Co-authored-by: Eduard Rozenberg <2648417+edrozenberg@users.noreply.github.com>
2020-07-21 11:21:07 -07:00
a7f4c6a37f win async - use full path for powershell (#70703) (#70714)
(cherry picked from commit 154efd97f2)
2020-07-21 11:20:35 -07:00
d329985d4c [2.10] template connection variables accessed directly before using (#70657) (#70688)
* template connection variables accessed directly before using (#70657)

* template variables accessed directly when using them instead of FieldAttributes

(cherry picked from commit 8c213c9334)

* changelog
2020-07-21 11:19:52 -07:00
ed07821a59 [2.10] api: time.clock compatible code (#70677)
time.clock is removed in Python 3.8. Add time.clock
compatible code.

Fixes: #70649

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 055871cbb8)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-07-21 11:19:27 -07:00
524d4b08dc runtime Remove vmware_httpapi entries that were not released (#70777)
These modules and plugins were added to ansible/ansible *after*
stable-2.9 was branched, ie they've not been released yet.

The new collection https://github.com/ansible-collections/vmware_rest
will not be released till later in the year.
2020-07-21 17:56:41 +01:00
895fc1d659 Redirect restored modules to community.general. (#70769) (#70775)
(cherry picked from commit 8188bce0ff)

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-21 13:01:04 +01:00
652ac88931 ansible_builtin_runtime.yml fixes (#70767) (#70771)
* Correct name is modules, not mso: https://github.com/CiscoDevNet/ansible-mso/blob/master/plugins/doc_fragments/modules.py

* The port_ went missing.

https://github.com/CiscoDevNet/ansible-aci/blob/master/plugins/modules/aci_interface_policy_port_channel.py
https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/modules/network/aci/aci_interface_policy_port_channel.py

https://github.com/CiscoDevNet/ansible-aci/blob/master/plugins/modules/aci_interface_policy_port_security.py
https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/modules/network/aci/aci_interface_policy_port_security.py

* Fix typo.

(cherry picked from commit 707e8b6e0c)

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-20 16:50:15 -07:00
46b1a999c6 Collections docs generation backport (#70515)
* Build documentation for Ansible-2.10 (formerly known as ACD).

Builds plugin docs from collections whose source is on galaxy

The new command downloads collections from galaxy, then finds the
plugins inside of them to get the documentation for those plugins.

* Update the python syntax checks
  * docs builds can now require python 3.6+.

* Move plugin formatter code out to an external tool, antsibull-docs.
  Collection owners want to be able to extract docs for their own
  websites as well.
* The jinja2 filters, tests, and other support code have moved to antsibull
* Remove document_plugins as that has now been integrated into antsibull-docs

* Cleanup and bugfix to other build script code:
  * The Commands class needed to have its metaclass set for abstractmethod
    to work correctly
  * Fix lint issues in some command plugins

* Add the docs/docsite/rst/collections to .gitignore as
  everything in that directory will be generated so we don't want any of
  it saved in the git repository
* gitignore the build dir and remove edit docs link on module pages

* Add docs/rst/collections as a directory to remove on make clean
* Split the collections docs from the main docs

* remove version and edit on github
* remove version banner for just collections
* clarify examples need collection keyword defined

* Remove references to plugin documentation locations that no longer exist.
  * Perhaps the pages in plugins/*.rst should be deprecated
    altogether and their content moved?
  * If not, perhaps we want to rephrase and link into the collection
    documentation?
  * Or perhaps we want to link to the plugins which are present in
    collections/ansible/builtin?

* Remove PYTHONPATH from the build-ansible calls
  One of the design goals of the build-ansible.py script was for it to
  automatically set its library path to include the checkout of ansible
  and the library of code to implement itself.  Because it automatically
  includes the checkout of ansible, we don't need to set PYTHONPATH in
  the Makefile any longer.

* Create a command to only build ansible-base plugin docs
  * When building docs for devel, only build the ansible-base docs for
    now.  This is because antsibull needs support for building a "devel
    tree" of docs.  This can be changed once that is implemented
  * When building docs for the sanity tests, only build the ansible-base
    plugin docs for now.  Those are the docs which are in this repo so
    that seems appropriate for now.

* Docs: User guide overhaul, part 5 (#70307)

(cherry picked from commit db354c0300)

* Need to return any error code from running antsibull-docs (#70763)

This way we fail early if there's a problem

(cherry picked from commit 1e3989c9f7)

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-07-20 14:28:35 -07:00
3eba8b8792 dellemc related module name changes (#70749) (#70761)
(cherry picked from commit f9bb5c9c5a)

Co-authored-by: Mohamed Javeed <mohamed_javeed_faroo@dell.com>
2020-07-20 14:33:53 -05:00
a5b46b6372 Followup to #70610: fix ansible_builtin_runtime.yml redirects to wrong collections (#70725) (#70743)
* Followup to #70610: fix redirects to wrong collections

* gcp module_utils is in community.general.

* dellos10_* modules are in dellemc_networking.os10, not dellemc.os10.

* intersight_facts was renamed to intersight_info in cisco.intersight in version 1.0.7.

* Fix more dellos10 redirects.

(cherry picked from commit cf217178c7)
2020-07-20 15:24:40 +01:00
6b6ecaf742 fix netbox inventory plguin name to redirect (#70708)
(cherry picked from commit 75c5087ccf)

Co-authored-by: akira <akira6592@example.com>
2020-07-17 13:00:26 -07:00
9b7ed6b81b Fix spelling errors. (#70664) (#70696)
(cherry picked from commit 08b20c9c08)
2020-07-17 12:59:38 -07:00
255dfca7f6 [stable-2.10] Allow single vault encrypted values to be used directly as module parameters. Fixes #68275 (#70607) (#70641)
(cherry picked from commit a77dbf0)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-07-17 12:54:32 -07:00
86b24498b7 Add intentional coverage for an async_wrapper case (#70593) (#70630)
* Add intentional coverage for an async_wrapper case (#70593)

Change:
- Test async_wrapper when the module it runs has stderr output

Test Plan:
- CI
- Looked at coverage report and saw green for a few lines that weren't
  previously green.

Signed-off-by: Rick Elrod <rick@elrod.me>

* sigh

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-07-17 12:52:45 -07:00
33e5f1d661 Get m_u.facts.utils coverage up to 100% (#70614) (#70629)
* Get m_u.facts.utils coverage up to 100%

Change:
- Add tests to 'gathering_facts' integration target to get
  module_utils.facts.utils coverage up to 100%.
- This also clears incidental coverage from incidental_selinux.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-07-17 12:52:00 -07:00
963bdd9983 [2.10] pipe: update docs for Popen with shell=True usage (#70602)
pipe lookup plugin uses Popen with shell=True intentionally.
This is considered a security issue if user input is not validated.
Updated docs to reflect this information for the user. Also, added
Bandit B602 documentation link for further reading.

Fixes: #70159

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit e5649ca3e8)
2020-07-17 12:51:35 -07:00
6cd015d7e2 Make filter type errors 'loop friendly' (#70417) (#70574)
- ensure we preserve the typeerror part of the exception so loop defereed error handling
 can postpone those caused by undefined variables until the when check is done.
 - fix tests to comply with the 'new normal'

 - human_to_bytes and others can issue TypeError not only on 'non string'
 but also bad string that is not convertable.

Co-authored-by: Sloane Hertel <shertel@redhat.com>

Co-authored-by: Sloane Hertel <shertel@redhat.com>
(cherry picked from commit cf89ca8a03)
2020-07-17 12:51:18 -07:00
15355ed059 [2.10] ansible-doc: include collection name in text output / plugin loader: return collection name; ansible-doc: handle ansible.builtin correctly (#70572)
* ansible-doc: include collection name in text output (#70401)

* ansible-doc: include collection name in text output

* Be more careful to not accidentally pass ansible.builtin for user-supplied modules.

(cherry picked from commit f4c89eab23)

* plugin loader: return collection name; ansible-doc: handle ansible.builtin correctly (#70026)

* Determine collection in plugin loader.

* Fix test.

* Use PluginPathContext objects in PluginLoader._plugin_path_cache instead of tuples.

(cherry picked from commit 24dcaf8974)
2020-07-17 12:50:23 -07:00
827c47d9bc try to capture better winrm/put_file error (#70508) (#70570)
* try to capture better winrm/put_file error

fixes #70361

* Update lib/ansible/plugins/connection/winrm.py

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
(cherry picked from commit 8789d7968d)
2020-07-17 12:49:11 -07:00
5ea6de4e7d Fix decrypt argument in assemble module (#70465) (#70560)
* Do not pass decrypt parameter to assemble module

* Add integration tests where decrypt=True

* Add changelog #70465

(cherry picked from commit 71c378e139)
2020-07-17 12:48:38 -07:00
94a81f7b44 Make sure ansible_become treated as a boolean (#70484) (#70526)
* Make sure ansible_become treated as a boolean

(cherry picked from commit 8aca464b8b)
2020-07-17 12:46:33 -07:00
a5c0b11913 ansible-doc man formatter: fail with better error message when description isn't there (#70046) (#70485)
* ansible-doc man formatter: do not crash when description isn't there.
* Change to report a better error message when description is not there.
* Add test.

(cherry picked from commit 9164b96774)
2020-07-17 12:44:03 -07:00
422e976649 [stable-2.10] apt - make errors more transparent (#70099) (#70478)
Include error from apt Python library in module error output

Co-authored-by: Andreas Schleifer <aschleifer@bigpoint.net>
(cherry picked from commit 7d7f15fc9b)

Co-authored-by: Andreas Schleifer <a.schleifer@bigpoint.net>

Co-authored-by: Andreas Schleifer <a.schleifer@bigpoint.net>
2020-07-17 12:43:19 -07:00
df3246b7d1 [stable-2.10] ssh connection - use get_option() rather than _play_context (#70438) (#70443)
The ssh_args were sometimes not correctly applied to the connection
when using _play_context. Use get_option() instead to ensure the
correct ssh_args are always applied.
(cherry picked from commit b4184aa50e)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-17 12:42:51 -07:00
865ba1953b misc collection metadata fixes (#70403) (#70428)
* misc collection metadata fixes

* parse collection meta with libyaml if available
* require only Mapping for validation
* add explanatory text for _meta_yml_to_dict

* ignore custom pylint rule

* this code shouldn't import a bunch of stuff from ansible, since it's run under the import sanity test

(cherry picked from commit b9e38e8b55)
2020-07-17 12:42:20 -07:00
212d2024f4 [2.10] Handle post_validate templating errors and fix tests (#70240) (#70389)
* Handle post_validate templating errors and fix tests (#70240)

* Handle unexpected templating errors

* Fixes #70050

Fix up tests that weren't running and add tests for graceful templating error handling

(cherry picked from commit 30e70f4b63)

* changelog

ci_complete
2020-07-17 12:41:43 -07:00
d0e37aeec1 [stable-2.10] Improve error message when ssh client is not found on the host (#70122) (#70386)
* Add changlelog
(cherry picked from commit 70bb2b33ca)

Co-authored-by: Mykola Grygoriev <nickgryg@gmail.com>

Co-authored-by: Mykola Grygoriev <nickgryg@gmail.com>
2020-07-17 12:40:38 -07:00
7dfda4026e Fix delegate_facts with interpreter not being set (#70293) (#70384)
Fixes #70168

ci_complete

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit b05e00e99a)
2020-07-17 12:40:00 -07:00
e1c0688e43 [2.10] Improve ansible-galaxy STDOUT messages for collections (#70379)
- Fix issue #70010
- Add installation successful message
- This feature targets "collection" sub-command and does not affect "role" sub-command

Signed-off-by: Hideki Saito <saito@fgrep.org>
(cherry picked from commit 2d59e548f6)

Co-authored-by: Hideki Saito <saito@fgrep.org>
2020-07-17 12:39:16 -07:00
c936b8b638 [backport][2.10]Docs backportapalooza3 (#70695)
* Suggest ansible ad-hoc command while developing module (#70308)

If a local module has no documentation, the doc command will fail without any hints of what is wrong. Add another way to confirm the presence of a local module.
* Update docs/docsite/rst/dev_guide/developing_locally.rst

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 82e5d03bdb)

* Update AWS Integration test docmentation (#70454)

(cherry picked from commit e1ba7dc52a)

* Update hacking/shippable docs.

The `--all` option downloads more than is needed for analyzing code coverage.

(cherry picked from commit fb7740ae3b)

* Document that subversion module requires subversion (#70537)

(cherry picked from commit 64c2cb273f)

* update documentation link to python 3 (#70509)

update the docs link for strftime on the filters page to point to the python3 docs

(cherry picked from commit f7db428375)

* Update windows_winrm.rst (#70306)

gcc also needed to be installed alongside python-devel, krb5-devel, krb5-libs, and krb5-workstation.

(cherry picked from commit f4ea43c4a0)

* updated requirements file for docs build (#70609)

(cherry picked from commit 38ccfb4a3e)

* Clarify that index_var is 0 indexed (#70548)

A little further down the page is another index, ansible_loop.index, which shares a similar description but is 1 indexed.
Its zero indexed twin has a 0 suffix.

``ansible_loop.index``      The current iteration of the loop. (1 indexed)
``ansible_loop.index0``     The current iteration of the loop. (0 indexed)

To remove ambiguity around the usage of index_var, explicitly mention that this variable is 0 indexed.

(cherry picked from commit c410311f55)

* docs: update module development docs (#70594)

Update module development docs for flattened modules directory.

Fixes: #70261 (at least partially)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 20209c508f)

* Doc: fix examples of changelog entries. (#70551)

(cherry picked from commit edcd1a1a70)

* Document tags are not supported with task meta. (#70590)

fixes #70338

(cherry picked from commit 40591d5fbb)

* docs: update date format in removed_at_date (#70597)

removed_at_date requires YYYY-MM-DD format.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 375c6b4ae4)

* partial update of community docs to reflect collections transition (#70488)

(cherry picked from commit f1f782fc37)

Co-authored-by: Michael Ritsema <michaelritsema@users.noreply.github.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Matt Clay <matt@mystile.com>
Co-authored-by: Alan Rominger <arominge@redhat.com>
Co-authored-by: FloMiau <37121807+FloMiau@users.noreply.github.com>
Co-authored-by: mahadelmi <mahadelmi@cmail.carleton.ca>
Co-authored-by: Sayee <57951841+sayee-jadhav@users.noreply.github.com>
Co-authored-by: Karl Goetz <goetzk@users.noreply.github.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-07-17 13:50:40 -05:00
f9a737b9b2 Top-level deprecation of plugin did not get collection_name added when deprecating by version (#70344) (#70370)
* Top-level deprecation of plugin did not get collection_name added when deprecating by version.

* Add changelog fragment.

(cherry picked from commit 689cfd1983)
2020-07-17 10:58:54 -07:00
1e03b54d23 refactor Python module_utils locator (#70610) (#70711)
* refactor Python module_utils locator

* no longer recursive
* embed special-case module code internally
* share common code between collections/not cases
* fixes #70134
* properly support subpackage redirection
* adds support for FQCN redirect targets used by migration (expands to FQ Python name)
* add tests

* add changelog

(cherry picked from commit c616e54a6e)
2020-07-17 10:57:44 -07:00
367c9b7eda [stable-2.10] pause - fix curses.setupterm() error (#47851) (#70363)
* [Bugfix] curses.setupterm() error

When run playbook in celery task, curses.setupterm()  will be failed

```
  File "<frozen importlib._bootstrap>", line 675, in _load
  File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
  File "/Users/guang/.virtualenvs/ansible/lib/python3.6/site-packages/ansible/plugins/action/pause.py", line 45, in <module>
    curses.setupterm()
TypeError: argument must be an int, or have a fileno() method.

```

* Add changelog

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit c3fc2d27d9)

Co-authored-by: 老广 <ibuler@qq.com>

Co-authored-by: 老广 <ibuler@qq.com>
2020-07-17 10:57:20 -07:00
3afa0424b3 [2.10] display: use stdout for column width (#70290)
stdout may differ from stdin so it should be used to determine the column
width, especially since it is the target file descriptor.

(cherry picked from commit 45e0f74702)

Co-authored-by: Pavel Březina <pbrezina@redhat.com>
2020-07-17 10:56:40 -07:00
273159da4c Include changelogs/changelog.yaml in distribution. (#70260) (#70266)
(cherry picked from commit ebd20ddca6)
2020-07-17 10:55:25 -07:00
95ec1618ef [stable-2.10] Only pass kwargs to our string checker not callable checkers (#70151) (#70170)
Since only check_type_str() accepts extra param, only pass to our checker and
do not pass kwargs to custom checkers.

* Add unit tests
(cherry picked from commit bc05415109)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-17 10:53:56 -07:00
b6f6067dfd [stable-2.10] ansible_runner test - Add constraints (#70667) (#70669)
A recent updated to psutil, which is a dependency of ansible-runner, fails
to install on older versions of pip.

Commit with the breaking change:

  135628639b
(cherry picked from commit 9d27d7c8b1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-15 17:32:09 -05:00
c2b69fd30e [stable-2.10] Fix ansible-test virtualenv management.
(cherry picked from commit 1e02a201a6)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-14 02:08:17 -07:00
ddc78622a4 [stable-2.10] Update ansible-test change detection for plugins.
(cherry picked from commit 09f02980a4)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 23:55:15 -07:00
957f0c27fc [stable-2.10] Fix boilerplate in setup.py and lib/ansible/ dir..
(cherry picked from commit 234994fc07)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 18:57:17 -07:00
a707466c0b [stable-2.10] Fix yamllint sanity test line numbers.
Parse errors from libyaml now compensate for the offset of the documentation within a module.
(cherry picked from commit 1a0d8a51cd)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 18:28:30 -07:00
8cd66ce95a [stable-2.10] Clean up unit test boilerplate.
(cherry picked from commit 98a0995fd0)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 18:28:02 -07:00
3204d260dd [stable-2.10] Add integration tests for basic.py _set_cwd.
These tests verify that AnsibleModule can be instantiated when cwd does not exist or is unreadable.
(cherry picked from commit d6fb42d1c5)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 18:16:00 -07:00
f28fabe6ef [stable-2.10] Add integration tests for test plugins. (#70576)
(cherry picked from commit df45dcdae0)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-07-13 18:15:21 -07:00
ba645400bf [stable-2.10] Correct name of fileglob lookup integration test.
(cherry picked from commit bbd8f15a58)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 18:15:00 -07:00
73d9054b32 [stable-2.10] Test netconf plugins in ansible-doc sanity test.
(cherry picked from commit 8d92df4537)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-13 18:14:42 -07:00
143827b0ad Updated infini* redirects to transition to infinidat collection (#70565) (#70568)
(cherry picked from commit b285f4c675)

Co-authored-by: ekaulberg <2768206+ekaulberg@users.noreply.github.com>
2020-07-10 22:41:16 +01:00
e57afc774c Migrating MySQL to community.mysql (#70523) (#70557)
* Migrating MySQL to community.mysql

* Removed aliases to fix yaml linting

Co-authored-by: Ben Mildren <bmildren@digitalocean.com>
(cherry picked from commit b149a89e07)

Co-authored-by: Ben Mildren <ben.mildren@gmail.com>
2020-07-10 18:46:48 +01:00
7872d60413 Fix ansible_builtin_runtime.yml w.r.t. c.g and c.n (#70322) (#70400)
* Fix module_utils for community.general.
* Fix module_utils for community.network.
* Add forgotten entry for community.general.

(cherry picked from commit 24915b2ccf)
2020-07-10 14:07:47 +01:00
374d4ecd98 Doc backportapalooza 2 (#70440)
* doc: avoid mix of single and double quotes (#70115)

Avoid mix of single and double quotes in the `ternary`, this way
we can copy/past the example without any surprise.

(cherry picked from commit b491f776b9)

* document FQCN for M()  and :seealso: in DOCUMENTATION blocks (#70245)

* document FQCN for M() in DOCUMENTATION blocks

* add note about c

(cherry picked from commit 83f6e4850b)

* Fix bullet points in intro_getting_started.rst. (#70365)

The layout was jumbled due to issues with whitespace.

(cherry picked from commit dc6f4b6502)

* Add steps for how to create changelog.rst for a collection (#70262)

* Update docs/docsite/rst/dev_guide/developing_collections.rst
* add steps to create changelogs, add sentence about not using the tool
* add note for rerunning the command

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 5a28b2b86c)

* ansible-doc: avoid problems with YAML anchors when formatting man page (#70045)

* Avoid problems with YAML anchors when formatting man page.

* Add changelog.

(cherry picked from commit 5e4f708241)

* Minor grammatical fix (#70405)

'you' -> 'your'

(cherry picked from commit a1ac595d42)

* incorporate minimalism feedback on filters page (#70366)

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit c89f3cda9e)

* more correct info about role main.yml (#70326)

fixes #40496

(cherry picked from commit 5d3d097de3)

* Fix a small typo in cache plugin description @ `config/base.yml`

PR #70420

(cherry picked from commit 626df08d9d)

* with_sequence: example using vars (#69369)

Added an example for using vars in with_sequence.

Fixes: #68836

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 5709173c32)

* Update pull.py (#70393)

(cherry picked from commit 46ad3c1162)

* Update playbooks.rst (#70317)

(cherry picked from commit 7c90a2d2a6)

* Add documentation for ipaddr filters  (#70343)

(cherry picked from commit 9eb904ea61)

* update platform table with links to collections (#70373)

(cherry picked from commit aa59c23aed)

* Add description of collections and become_exe keywords (#68055)

* Add description of collections keyword
* Update based on feedback.
- Add link to become plugins.
- Add note about how the collections keyword works with roles.

(cherry picked from commit 5833af9e2a)

Co-authored-by: Gonéri Le Bouder <goneri@lebouder.net>
Co-authored-by: Mark Sanders <ziplokk.mark.sanders@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sir Mobus Gochfulshigan Dorphin Esquire XXIII <celestialtuba@gmail.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Michael Scherer <mscherer@users.noreply.github.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Ethan <smithe2413@gmail.com>
Co-authored-by: jafiala <56597272+jafiala@users.noreply.github.com>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-08 16:05:41 -05:00
d07a84e233 DigitalOcean content has been moved to community.digitalocean. (#70483) (#70498)
(cherry picked from commit 535fde3c0f)

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-07-07 21:08:13 +01:00
0890d9fbb2 migrating ProxySQL to community.proxysql (#70490) (#70497)
* migrating ProxySQL to community.proxysql

* Removed remaining ProxySQL ref to community.general

Co-authored-by: Ben Mildren <bmildren@digitalocean.com>
(cherry picked from commit 1a542e9824)

Co-authored-by: Ben Mildren <ben.mildren@gmail.com>
2020-07-07 13:19:35 +01:00
14997f0309 [2.10] runtime and botmeta backports (#70451)
* botmeta: vultr migrated to ngine_io.vultr (#68916)


(cherry picked from commit 1787a3dbf5)

* botmeta: exoscale migrated to ngine_io.exoscale (#70095)

* botmeta: exoscale migrated to ngine_io.exoscale

* botmeta: exoscale: add missing migrations

* Update lib/ansible/config/ansible_builtin_runtime.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 73139df36c)

* botmeta: cloudstack migrated to ngine_io.cloudstack (#68917)

* botmeta: cloudstack migrated to ngine_io.cloudstack

* also update file references

* cloudstack: botmeta: added missing migrated_to

(cherry picked from commit 8cb1272ca4)

* botmeta: cloudscale: add missing migrations (#70447)


(cherry picked from commit 0198ceebe4)

* All cloudscale.ch modules are moved to a collection (#70358)


(cherry picked from commit c600f8df58)

Co-authored-by: Gaudenz Steinlin <gaudenz@users.noreply.github.com>
2020-07-03 12:44:36 +01:00
43ef13d206 command module, nix warnings for moved modules (#70444)
Change:
- Remove warnings from command module which point to modules that no
  longer ship with ansible-base but have moved to collections.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-07-02 14:26:18 -05:00
a1224760c4 [stable 2.10] [backport] Migrate onyx modules from community.network to mellanox.onyx (#70280)
* Migrate onyx modules from community.network to mellanox.onyx

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Redirect all onyx plugins from network.common to mellanox.onyx

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2020-07-02 19:54:56 +01:00
4f8e1c0cee Rename from dellemc_networking to dellemc (#70321)
Rename from dellemc_networking to dellemc
2020-07-02 19:52:17 +01:00
ad61774acf fix runtime.yml splunk.enterprise_security -> splunk.es (#70305) (#70310)
Signed-off-by: Adam Miller <admiller@redhat.com>
2020-07-02 10:32:01 -05:00
0abb5e597e [2.10] known_hosts: update documentation (#70406)
* Update documentation as per sanity tests
* Added example about custom SSH port in example section

Fixes: #29236

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 74bedab8a9)
2020-07-02 10:31:23 -05:00
e35e4b4ab0 [2.10] Docs: mention about Ansible workshops (#70377)
Lightbulb is deprecated in favor of https://ansible.github.io/workshops/. Update docs links accordingly.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit e4f48c920c)
2020-07-02 10:29:45 -05:00
70da336de9 ansible-test - do not validate blacklisted ps modules (#70376)
* ansible-test - do not validate blacklisted ps modules

* Update changelogs/fragments/validate-modules-ps-doc-blacklist.yaml

Co-authored-by: Matt Clay <matt@mystile.com>

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 40ce448657)
2020-06-30 15:15:13 -07:00
73ee85145b [stable-2.10] Pin ansible-test requirements for RHEL.
The `packaging` and `pyparsing` packages are now installed by `ansible-test` during provisioning of RHEL instances to match the downstream vendored versions.
(cherry picked from commit 70c59423fc)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-06-26 11:32:16 -07:00
bcd7c860e2 pip tests, use py2 compat sampleproject fork
Change:
- sampleproject has gone py3 only. Use a py2 compatible fork.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-06-26 09:17:28 -07:00
222d35ebbd [backport][2.10] Docsbackportapaloosa (#70302)
* Fix broken link in AWS Guide (#70153)

Point to collection rather than ansible/ansible for example.

(cherry picked from commit 0ef75f65d9)

* remove gendered example (#70117)

Changed example to not assume things about names and genders

(cherry picked from commit 5885ed4455)

* docs: Add note about ansible-doc (#70162)

ansible-doc can only parse Python modules, added a note about
this is developer guide; Fixes: #69109

(cherry picked from commit da868d9d60)

* Update config.yml (#70154)

typos & branding
* Update .github/ISSUE_TEMPLATE/config.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 4b358c6641)

* async_status: Update documentation (#70196)

Fixes: #38164

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 40a42de081)

* updates to ansible-maintained collections guidelines (#70178)

(cherry picked from commit 647c6cd289)

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
Co-authored-by: Westley Argentum Hennigh-Palermo <WestleyArgentum@gmail.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: John R Barker <john@johnrbarker.com>
2020-06-25 10:17:49 -05:00
2a4f4dd526 redirecting the conjur lookup plugin to correct collection (#70106) (#70182)
(cherry picked from commit 33e25504ac)
2020-06-23 19:08:33 +01:00
82a3366701 adds japanese translation as a version-switcher option (#70214) (#70215)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit 4a0f42923b)
2020-06-22 15:41:05 -05:00
0b7e3694c7 [stable-2.10] Rebalance CI groups to avoid macOS timeouts (#70126)
(cherry picked from commit b2d6db7916)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-06-22 10:19:54 -07:00
a45d4fe80d Fix up the redirection of the win setup module (#70158) (#70181)
(cherry picked from commit 8b24a4c5ed)
2020-06-19 17:12:32 -07:00
aa8f73f7e7 Update note about AWS collection test requirements in docs (#70176) (#70179)
(cherry picked from commit 8ad46870a4)
2020-06-19 14:17:54 -05:00
8002b4d4fc Update Ansible release version to v2.10.0b1.post0. 2020-06-17 17:06:28 -05:00
cbfe2e642f New release v2.10.0b1 2020-06-17 14:38:15 -05:00
ed2de20bca bump porting guide link
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-06-17 13:12:52 -05:00
8152d8bc1a Disabled inconsistent pylint checks. 2020-06-17 10:10:17 -07:00
0133757d44 Add an author exception for OpenStack Ansible SIG
The current author line wants to match a github author id. But
some people, including the OpenStack project, do not use github,
and additionally do not claim individual ownership but instead
group ownership.

Since there are already a couple of hard-coded examples in the
regex, just add one more. Alternately we could come up with some
mechanism to indicate that the author is purposely not listing
a github id, but that seems a bit heavywight.
2020-06-17 08:21:14 -07:00
29c6aae2fc try to load unqualified plugins from whitelist (#70086)
* try to load unqualified plugins from whitelist

* necessary for backcompat loading of unqualified collectionized callback plugins redirected from <= 2.9 core
* also added de-duping from actual loaded name

* add tests

* add warning test

* group test script entries by topic

* shorten warning text grep because wrapping is dumb

* fix adhoc callback loading behavior

* collections pass over whitelist wasn't respecting `_run_additional_callbacks`
* adds regression tests for same

* avoid `grep -L` in tests since it breaks the world
2020-06-16 17:17:38 -07:00
598786e16d Update ansible-test default test containers.
The main change is the upgrade to Python 3.9.0b3.
2020-06-16 16:50:04 -07:00
3dd324b837 disable slow/unstable hetzner incidental tests (#70103)
* disable slow/unstable hetzner incidental tests

* zap disabled tests

* verified no incidental coverage loss
2020-06-16 16:30:56 -07:00
d295b81920 Improve stability of postgresql tests. 2020-06-16 16:29:25 -07:00
fc448ea54f Clarify blockinfile docs for insertafter/insertbefore (#69396)
* Clarify blockinfile docs for insertafter/insertbefore

It's not clear from the docs that these options take effect
only when no marker lines are found in the document.

* Add changelog fragment
2020-06-16 14:48:08 -04:00
7ef0fd1c08 document return values of file module (#69560)
* document return values of file module
* Clarify whether path or dest input is used as dest output in file module

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-06-16 13:45:43 -05:00
ccf90a62c3 Enhance documentation around add_host bypassing the play host loop (#69692)
Signed-off-by: Vincent Bernat <vincent@bernat.ch>
2020-06-16 14:35:03 -04:00
0faec62354 Remove temporary migration hack from CI scripts. 2020-06-16 11:25:39 -07:00
5f30f4e524 Use default network in Google Cloud Platform Guide (#68846)
* Update guide_gce.rst
The given example is not working as a SSH connection is not possible because of #59573. Instead, in this tutorial the default network should be used which allows SSH connections in most cases.

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-06-16 13:15:11 -05:00
f69b1846f9 Add pyparsing constraint to ansible-test.
The upcoming pyparsing 3 release will require Python 3.5 or later, see:

https://github.com/pypa/packaging/issues/313

Unfortunately pip 8.x and earlier versions do not support python version requirements, which is why this constraint is needed.
2020-06-16 10:38:16 -07:00
c9c8cd34b2 added documentation for R() (#69832)
* Updated docs/docsite/rst/dev_guide/developing_modules_documenting.rst, added documentation for R()
* added link to how to add anchors, anchor, and clarification on when to use each option

Co-authored-by: John R Barker <john@johnrbarker.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-06-16 11:50:50 -05:00
923655642b mentions minimum required boto versions (#68124)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-06-16 12:32:44 -04:00
fb9740db4c Specify numeric range can contain a stride (#68952)
Updated the range creation example to show that you can also specify a stride value when creating a hostname by numeric range.
2020-06-16 11:31:00 -05:00
c2eb1eadb2 Removed danowar2k from Wiki and now removing myself from botmeta (#70037) 2020-06-16 11:09:41 -04:00
9c753341e2 Porting guide: transfer entries to collection changelogs (#70064)
* Remove community.crypto parts from porting guide.
* Remove community.general parts from porting guide.
* Removed 'modules removed' section, since this is better suited for a general entry on the collection split.
2020-06-16 10:04:32 -05:00
d1dcd5bcb3 remove new Windows modules not present in 2.9 (#70087) 2020-06-16 18:50:19 +10:00
de63cba7e8 transparent downstream vendoring (#69850)
* builtin downstream vendoring support

* allows downstream packagers to install packages to `ansible/_vendor` that will automatically be added to head of sys.path during `ansible` package load
* tests

* sort conflicting package names in warning text

* sanity fixes

* skip unnecessary comparison
2020-06-15 16:22:25 -07:00
7641d32f8e Fix ansible-test import sanity test issues. (#70084) 2020-06-15 15:09:15 -07:00
d45cb01b84 ansible-galaxy - fix collection installation with trailing slashes (#70016)
If we fail to find a member when extracting a directory, try adding a trailing
slash to the member name. In certain cases, the member in the tarfile will
contain a trailing slash but the file name in FILES.json will never contain
the trailing slash.

If unable to find the member, handle the KeyError and print a nicer error.

Also check if a directory exists before creating it since it may have been
extracted from the archive.

Fixes #70009

* Add unit tests
* Use loop for trying to get members
2020-06-15 17:36:07 -04:00
2609482975 How to contribute to Ansible maintained collections (#69202)
contributor info with HTML table
2020-06-15 15:38:42 -05:00
80410f292b Fix missing allow_date=False. 2020-06-15 11:18:51 -07:00
9c92c96918 Updating 2.10 roadmap with adjusted beta release date (#70077)
Co-authored-by: James Cammarata <jimi@cube.sngx.net>
2020-06-15 19:10:51 +01:00
16796a6170 enable collections module_utils subpkg tests (#69957)
* fixed by collection loader rewrite, just needed to be reenabled
2020-06-15 09:34:25 -07:00
843751a00d yum/dnf: check type of elements in a name (#70072) 2020-06-15 11:01:42 -04:00
8a88b845ce Fix aci_intf_policy_* redirects. (#70051) 2020-06-15 13:05:47 +01:00
0617514176 Boolean error: fix deprecation date sanity check. (#70047) 2020-06-13 09:05:40 -04:00
5b3719805e Update ansible-test test containers. 2020-06-12 09:19:18 -07:00
2fa65eb5e1 validate-modules: allow YAML dates in module documentation and meta/runtime.yml. (#70025) 2020-06-12 15:36:38 +01:00
37785255f2 validate ansible-base's and collections runtime.yml (#69742)
* Validate ansible-base & collection's runtime.yml

Add new test `runtime-metadata`

* Schema validation of file
* Error if a a legacy meta/routing.yml exist in a collection
* removal_date OR removal_version

* Add tombstone validation.

* Allow both ISO 8601 date strings and datetime.date objects (from YAML dates).

* Address review comments.

* Add metadata to test collection.

* Add requirements file.

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Matt Clay <matt@mystile.com>
2020-06-12 15:34:34 +01:00
9f49db1f99 Avoid use of deprecated junit-xml method. 2020-06-12 00:47:07 -07:00
26f318d277 Ignore return code from antsibull_changelog lint. 2020-06-11 19:27:40 -07:00
4c9d9dbb56 fix discovery on loop with delegation (#70013)
* fix discovery on loop with delegation

fixes #69963
2020-06-11 18:04:17 -04:00
8ffaed00f8 Add Azure Pipelines support to ansible-test. 2020-06-11 14:57:42 -07:00
524257a7b0 Document the ability to deprecate by date (#69833)
* Document the ability to deprecate by date
* deprecated_in and deprecated_by_date are mutually exclusive
2020-06-11 15:28:24 -05:00
f5df702b55 Fix Include_vars example (#69966)
* Remove incorrect var in first_found docs
* Fix include_vars example using lookup
2020-06-11 15:24:52 -05:00
8c3eb7ae4a fix configurable pipelining (#69920)
* fix configurable pipelining

Co-authored-by: Sloane Hertel <shertel@redhat.com>
2020-06-11 16:17:58 -04:00
4a4a11d282 Add mccabe complexity testing (#64623)
* Add mccabe complexity testing

* Make mccabe complexity an optional error

* Add mccabe to new sanity pylint requirements

* Add a changelog fragment.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-06-11 13:02:06 -07:00
0ae4dac65a Fix copy module file perms with remote_src (#69993)
When using 'remote_src: yes' and 'mode: preserve', the code handling
the file modes has to be handled on the remote node because it's
the one that has access to the source files. This means that the
copy module itself must handle this, rather than the copy action
plugin (which is where all that logic exists). The copy module
handles this when we copy a single file over. But when it is a
directory as the src parameter value, the mode of the files
beneath it are not considered. Subdirectories are copied with
shutil.copytree() which will preserve permissions automatically.
Individual files are copied with shutil.copyfile() which does NOT
preserve permissions. We need to add some calls to shutil.copymode()
to correct that.

Note: This *always* retains individial file permissions. Specifying
a 'mode' other than 'preserve' when giving a source directory for
the 'src' param does not make sense so will be ignored in that case
only.

Fixes #69783

* Add changelog and test
2020-06-11 15:18:59 -04:00
2251b239a3 Fix changelog sanity test config detection. 2020-06-11 11:57:58 -07:00
1d63b6f4f8 updated requirements file for docs build (#70020) 2020-06-11 14:47:17 -04:00
47d14a33bd config: singular ANSIBLE_COLLECTIONS_PATH (#70007)
* config: singular ANSIBLE_COLLECTIONS_PATH

Every other *_PATH setting in ansible is singular, and the traditional
$PATH variable is also singular despite containing a list of
directories.  Let's be consistent both internally and with POSIX
tradition.

* update all ANSIBLE_COLLECTIONS_PATHS env references to be singular

* deprecate plural ANSIBLE_COLLECTIONS_PATHS setting
2020-06-11 11:40:13 -07:00
a114da80ee Use antsibull-changelog instead of packaged changelog generator (#69313)
Replace the ansible-base changelog linting and generation tool with antsibull-changelog and make it available for linting collections. Previously changelog linting was limited to ansible-base.
2020-06-11 11:21:21 -07:00
851e8e18b2 clarifies that vars can begin with _, with a warning (#69749)
Co-authored-by: Sayee <57951841+sayee-jadhav@users.noreply.github.com>

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Sayee <57951841+sayee-jadhav@users.noreply.github.com>
2020-06-11 14:16:41 -04:00
8d93ba9120 Plugin/module docs: parse return values, add collection names in them (version_added_collection), and format them nicely in ansible-doc (#69796)
* Tag return value docs if they are a dict (and not str/None).

* Try to parse return docs as YAML.

* Properly dump return values in ansible-doc.

* Adjust plugin formatter.

* Add changelog fragment.

* Don't add 'default' for return values.

* Fix plugin_formatter.

* Only try to parse return docs if they are still a string.

* Add tests.

* Warn if RETURN cannot be parsed.

* Adjust tests. Also test for warning.

* if -> elif (otherwise EXAMPLE will be parsed too).

* Always parse return documentation, and fail if it is invalid YAML.

* Polishing.

* Mostly re-enable ansible-doc tests.

Listing from the local collection seems to be somewhat broken. I assume this
is why the test was disabled.

* Lint and make tests work with Python 2.

* Keep FQCNs in plugins (not modules), i.e. restore previous state.
2020-06-11 11:03:43 -07:00
f509a22f9d add changelog categories, update CVE fragments to use security_fix category (#69968)
* use security_fix category in changelogs for CVEs

* these fragments do not say CVE but are security fixes

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-06-11 10:24:01 -07:00
9d6b0f2b03 Support removed_at_date in ansible-doc (#70002)
* Support removed_at_date in ansible-doc

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

Changes:
  * ansible-doc does not support `removed_at_date` and assumes that
    deprecated dict will either have `removed_in` or `version`. This
    results in ansible-doc (and hence "sanity --test=ansible-doc")
    failing for modules having only `removed_at_date`.

  * This patch adds support for `removed_at_date` and also gives it
    precedence over `removed_in` or `version`.

* Add tests and changelog

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-06-11 13:18:18 -04:00
4869874337 ansible-test: vcenter initialize group/vmware (#70011)
Ensure the vcenter provider initialize the `module_defaults` of all
the vmware modules, not just `vmware_guest`.
The VMware CI relies on this for the authentication of the different
VMware modules.

The commit adjust `incidental_vmware_prepare_tests/tasks/init_vcsim.yml`.
The test-suite uses a copy of `vmware_guest` that is not in the
`group/vmware` group. As a result, we need to manually pass the
authentification parameter.
2020-06-11 12:21:44 -04:00
ebb22655e4 implemented 'prefix' for file based cache (#69872)
* implemented 'prefix' for file based cache

Co-authored-by: s-hertel <shertel@redhat.com>
2020-06-11 10:40:25 -04:00
ad37218200 Update my github username (#70005) 2020-06-11 14:29:01 +01:00
6c2be04b6f Intercept code-smell tests using subprocess.
Some code-smell sanity tests for ansible-base use subprocess to invoke ansible commands.
Intercept these commands to make sure the correct script and python version are used.
2020-06-10 16:07:47 -07:00
d30fc6c0b3 galaxy - preserve symlinks on build/install (#69959)
* galaxy - preserve symlinks on build/install

* Handle directory symlinks

* py2 compat change

* Updated changelog fragment
2020-06-11 06:46:42 +10:00
a58fcde3a0 Use common ps sanity requirements file (#69992)
* Use common pssanity requirements file

* Fix up sanity ignore
2020-06-11 06:38:17 +10:00
d7c03e9fdb Update testing collections to mention ansible-base versions (#69805)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-06-10 16:22:01 -04:00
37e7191304 added more ways to config new options in url (#69950)
* added more ways to config new options in url
2020-06-10 15:48:20 -04:00
3815ed67d5 ansible-galaxy - Fix role info when role is not installed (#69924)
* ansible-galaxy - Fix role info when role is not installed

Only report the role not found if in offline mode, otherwise query the galaxy API
to get role information.

Fixes #69867

* Improve error message when role is not found in Ansible Galaxy
2020-06-10 15:36:24 -04:00
32c392e622 Raise Warning when import_playbook receives additional parameters (#64156)
* Extra whitespace around imported playbook filename are stripped.
* Corrected call for display.deprecated
* Changed warning type & added test
* Added auto verification of raised warning
* More accurate warning message
2020-06-10 13:22:40 -04:00
ac20466375 Do not keep empty blocks after tag filtering (#69987)
This prevents PlayIterator having to go through empty blocks
that were created in filter_tagged_tasks. This should
be a performance improvement for playbooks that mostly skip
tasks with tags.

ci_complete
2020-06-10 12:12:11 -05:00
a5679d4dd1 Additional ansible-test sanity adjustments. (#69974)
* Fix ansible-test check_pyyaml usage.
* Avoid unnecessary pip commands.
* Avoid pointless pip check.
* Only install ansible-test requirements as needed.
2020-06-10 09:39:25 -07:00
dc9c1d202b Fix ansible-test pip filter on Fedora 32.
The original version works on CentOS 8 but not Fedora 32.
2020-06-10 09:37:01 -07:00
aff6b1ff21 Address linting errors in default callback (#69989) 2020-06-10 11:30:50 -05:00
026bf4a9a8 do we really need update vars from pc? (#69952)
* don't we really need update vars from pc
2020-06-10 08:39:47 -04:00
805dff4129 fixed missing default (#69972)
* fixed missing default

 also deprecated so new options wont have to go through this
2020-06-10 08:35:36 -04:00
f1ab7cf0c6 Validate-modules: adjust test to fixes in #69977 (#69978) 2020-06-10 18:02:01 +10:00
15f07e7a6c Fix up schema for collection deprecation (#69977)
* Fix up schema for collection deprecation

* Fix up modules using wrong name

* Another fix
2020-06-10 16:33:08 +10:00
a81dd4f06a Update ansible-test default containers. (#69819)
* Move ansible-test completion code.

* Fix a few type hints.

* Change docker completion based on context.

Collections now use version 2.0 of the default-test-container.
This is an updated version of the earlier 1.x default-test-container with ansible-base and cloud specific requirements removed.

Testing of ansible-base now uses version 1.0 of a new ansible-base-test-container.
This container is similar to the earlier 1.x default-test-container, but with unnecessary duplication of requirements across Python versions removed.

Collections which have tests that depend on requirements no longer present in the default test container should specify them in their test requirements files:

* tests/integration/requirements.txt
* tests/unit/requirements.txt

* Bump test container versions

Co-authored-by: Jordan Borean <jborean93@gmail.com>
2020-06-09 15:40:56 -07:00
51f6d129cb support hard coded module_defaults.yml groups for collections (#69919)
* Only allow groups which were hardcoded in module_defaults.yml

only load action groups from the collection if module_defaults contains a potential group for the action

* Fix tests using modules that override those whitelisted in lib/ansible/config/module_defaults.yml

Third party modules should not be using group/ - use the action name instead

* add externalized module_defaults tests

add the missing group and collections

ci_complete

Co-authored-by: Matt Davis <mrd@redhat.com>

* changelog

ci_complete

* Fix import in tests

ci_complete

* Update with requested changes

ci_complete

* don't traceback since we don't validate the contents of module_defaults

ci_complete

Co-authored-by: Matt Davis <mrd@redhat.com>
2020-06-09 15:38:57 -07:00
a862ff2d43 Deprecation revisited (#69926)
* Allow to specify collection_name separately for deprecation.

* Use new functionality in Ansible.

* Use new functionality in tests.

* Update tagging/untagging functions.

* Update pylint deprecated sanity test.

* Update validate-modules. Missing are basic checks for version_added (validate semantic version format for collections).

* Improve version validation. Re-add version_added validation.

* Make sure collection names are added to return docs before schema validation.

* Extra checks to avoid crashes on bad data.

* Make C# module utils code work, and update/extend tests.

* Add changelog fragment.

* Stop extracting collection name from potentially tagged versions/dates.

* Simplify C# code.

* Update Windows modules docs.

* Forgot semicolons.
2020-06-09 15:21:19 -07:00
7bff3d312f Split out and install sanity test requirements. (#69971)
* Split out sanity test requirements.

* Run each --venv test separately.

This provides verification that the requirements for each test are properly specified.

* Use a separate requirements file per sanity test.

* Skip setuptools/cryptography setup for sanity.

* Eliminate pyyaml missing warning.

* Eliminate more pip noise.

* Fix conflicting generate_pip_install commands.

* Add changelog fragment.
2020-06-09 13:38:36 -07:00
ce199ef0e1 Add intg test to repro #36045 (add_host traceback) (#69912)
* Add intg test to repro #36045 (add_host traceback)

* fix raw_params usage in add_host

Co-authored-by: Adrian Likins <alikins@redhat.com>
2020-06-09 15:25:56 -04:00
03f8bf46c3 Update ansible-test integration tests. (#69970)
* Extend ansible-test collection test.

It now runs `rstcheck` and `empty-init` tests.

* Add galaxy.yml to test collections.
2020-06-09 11:16:48 -07:00
6065638e00 Display parameter name in string conversion warning (#57145)
Add prefix to error message for nested options. This is helpful if a subelement key has the same name as a top level key.
2020-06-09 13:05:53 -04:00
a64418c2b3 avoid constant checking controlpersist (#69910)
* avoid constant checking controlpersist
2020-06-09 11:59:38 -04:00
c41a160951 Update test images to version 1.16.0 (#66771) 2020-06-09 10:08:31 -04:00
5a7f2f9d5d Add platform guide for FRR (#69773)
* Add platform guide for FRR

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add entry in index

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-06-09 10:22:30 +05:30
bfff95393c Add custom globals to the environment, and not per template (#69278)
* Add custom globals to the environment, and not per template

* Add changelog fragment
2020-06-08 16:30:40 -05:00
9667f221a5 Make AnsibleVaultEncryptedUnicode work more like a string (#67823)
* Make AnsibleVaultEncryptedUnicode work more like a string. Fixes #24425

* Remove debugging

* Wrap some things

* Reduce diff

* data should always result in text

* add tests

* Don't just copy and paste, kids

* Add eq and ne back

* Go full UserString copy/paste

* Various version related fixes

* Remove trailing newline

* py2v3

* Add a test that can evaluate whether a variable is vault encrypted

* map was introduces in jinja2 2.7

* moar jinja

* type fix

Co-Authored-By: Sam Doran <sdoran@redhat.com>

* Remove duplicate __hash__

* Fix typo

* Add changelog fragment

* ci_complete

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-06-08 16:30:14 -05:00
8dd0356719 Update bundled version of distro from 1.4.0 to 1.5.0 (#69709)
Includes changes we made in our version that were merged upstream

ci_complete
2020-06-08 16:34:37 -04:00
86f1cba3a6 Minor cleanup for ansible-test integration test. 2020-06-08 11:06:23 -07:00
c1c6f61a18 Auto unroll generators produced by jinja filters (#68014)
* Auto unroll generators produced by jinja filters

* Unroll for native in finalize

* Fix indentation

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Add changelog fragment

* ci_complete

* Always unroll regardless of jinja2

* ci_complete

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-06-08 12:58:03 -05:00
840d3a9dd7 ansible-doc: properly handle suboptions (#69795)
* Specifically handle suboptions, contains, etc in ansible-doc.
2020-06-08 11:51:33 -04:00
ff98ecc4d0 Update developing_modules_best_practices.rst (#69937)
##### SUMMARY
wrong module path for module_utils.basic in developing_modules_best_practices.rst
2020-06-08 13:28:17 +05:30
3e566768c1 Fix broken validate-modules. 2020-06-06 11:00:10 -07:00
06efc41fb0 Reduce pip output noise in ansible-test. (#69925) 2020-06-05 18:25:48 -07:00
1a0c309629 Remove CentOS on Power from CI. 2020-06-05 18:24:41 -07:00
5194965a24 Revert "Revert "fixes f5 modules specific redirects (#69865)""
This reverts commit a69c23fd5b.
2020-06-05 16:52:51 -07:00
f733517e6e Support dates in metadata in import sanity test.
No changelog entry since this feature and the associated bug have not been included in a release.
2020-06-05 14:46:08 -07:00
4882471bc9 fix unvault lookup name in example (#69913) 2020-06-05 16:42:13 -04:00
112251c7f4 Bump fallaxy version (#69917) 2020-06-06 06:00:57 +10:00
984216f52e various deprecation, display, warning, error fixes for collections redirection (#69822)
* various deprecation, display, warning, error fixes

* Update lib/ansible/utils/display.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update lib/ansible/utils/display.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update lib/ansible/utils/display.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* cleanup, test fixes

* add collection name to deprecated() calls

* clean up redirect entries from uncommitted tests

* fix dep warning/error header text to match previous

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-06-05 00:28:40 -07:00
d79b23910a fix sys.modules cleanup and blacklist behavior (#69898)
* fix sys.modules cleanup and blacklist behavior

* fix map-as-generator py2/py3 issue
* clear path_importer_cache between runs

* sanity fix

* don't be stupid with moving target generators
2020-06-04 19:02:23 -07:00
efe103cdff Make add_host be idempotent/show changed status (#69897)
Change:
- The `add_host` action now shows an accurate change status.

Test Plan:
- Added a plethora of integration tests.

Tickets:
Fixes #69881

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-06-04 21:01:56 -05:00
062e780a68 starting metadata sunset (#69454)
* starting metadata sunset

 - purged metadata from any requirements
 - fix indent in generic handler for yaml content (whey metadata display was off)
 - make more resilient against bad formed docs
 - removed all metadata from docs template
 - remove metadata from schemas
 - removed mdata tests and from unrelated tests

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Rick Elrod <rick@elrod.me>
2020-06-04 21:01:46 -04:00
f5718a354c lineinfile - Add alternative backrefs example to docs (#69844)
* lineinfile - Add alternative backrefs example to docs

* Add changelog
2020-06-04 16:13:42 -05:00
2dbd5dc2ae ansible-test: do not accept empty string as valid version number (#69816)
* Work around strange behavior of StrictVersion and SemanticVersion constructors that they accept an falsy value.

* Do not accept empty strings as versions.
2020-06-04 13:25:05 -07:00
3b00c161dc Re-add documentation for yum "install_repoquery" (#69871)
Change:
- This was removed in 2014 in 122a7021bc.
- The option still exists and is enabled by default and can lead to user
  confusion when people aren't expecting packages (or updated
  dependencies for it) to get installed and they do.
- Add the option documentation back with a few notes to make it clear what
  is happening.

Test Plan:
N/A, no code change, just documentation

Tickets:
- Refs #69497

Signed-off-by: Rick Elrod <rick@elrod.me>

* Fix sanity errors

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-06-04 15:45:22 -04:00
b69e5c55f4 Only show one deprecation warning if version and date are both defined. (#69808)
This prefers date to version on the basis that date will have been added
in 2.10, and version retained for 2.9 compatibility
2020-06-04 12:42:43 -07:00
66bd385f6f Fix documentation for the assemble modules remote_src property. (#69845) 2020-06-04 15:30:45 -04:00
a02960f506 Remove AIX from test matrix 2020-06-04 10:07:12 -07:00
646536643f Use fqcr from command module invocation using shell module (#69790)
* Use fqcr from command module invocation using shell module

Fixes https://github.com/ansible/ansible/issues/69788

Use fully qualified collection reference while invoking
command module from shell module

* Fox review comment
2020-06-04 10:00:11 -07:00
247e43b252 Fix IncludedFile equality check (#69524)
In the case of a free style strategy, it is possible to end up with
multiple hosts trying to include from the same role, however the tasks
being included may be different with the use of tasks_from.  Previously
if you had two hosts that were included the same role when the
process_include_results function tries to determine if a included needs
to be run on a specific host, it would end up merging two different
tasks into which ever one was processed first.

This change updates the equality check to also check if the task uuid
associated with the IncludedFile is the same. The previous check only
checked if the task's parent uuid was the same. This breaks down when
both includes have the same parent.

    - hosts: all
      strategy: free
      gather_facts: false
      tasks:
        - include_role:
            name: random_sleep
        - block:
          - name: set a fact (1)
            include_role:
              name: set_a_fact
              tasks_from: fact1.yml
          - name: set a fact (2)
            include_role:
              name: set_a_fact
              tasks_from: fact2.yml
        - name: include didn't run
          fail:
            msg: >
              set_a_fact didn't run
              fact1: {{ fact1 | default('not defined')}}
              fact2: {{ fact2 | default('not defined') }}"
          when: (fact1 is not defined or fact2 is not defined)

Closes #69521
2020-06-04 10:41:46 -05:00
53b95b865f __eq__ should be redefined if __hash__ is defined. 2020-06-03 21:57:21 -07:00
4ecf22db9a Revert "fixes f5 modules specific redirects (#69865)"
This reverts commit 16f5dbf985.
2020-06-03 19:41:04 -07:00
7b632788aa Add Power back to test matrix 2020-06-03 16:31:27 -07:00
7e5a39d1d3 Add AIX back to test matrix 2020-06-03 16:31:03 -07:00
16f5dbf985 fixes f5 modules specific redirects (#69865)
* fixes f5 modules specific redirects

* adds removed entry
2020-06-03 21:58:27 +01:00
22da903e9c return changed for group_by (#32057)
* return changed for group_by

* added tests and fixed 'early registeration'
2020-06-03 12:46:40 -04:00
2d394382cf Reap collections changelog fragments - 6 (#69491) 2020-06-02 11:39:46 -05:00
00ead98595 systemd: should fail in check_mode when service not found on host (#68136)
* systemd: should fail in check_mode when service not found on host
2020-06-02 11:52:12 -04:00
6a4455ff54 Update plugin_formatter to understand tagged version_added (#69797)
* Update version_added handling for plugin_formatter w.r.t. #69680.

* Update hacking/build_library/build_ansible/command_plugins/plugin_formatter.py

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-06-02 08:07:34 -07:00
d757995bb6 service_facts: Update documentation about service status (#69757)
Update documentation about undocumented service status provided
by systemd

Fixes: #69752

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-06-02 11:07:02 -04:00
598e3392a9 Discover Flatcar Linux properly for hostname (#69627)
To avoid issues with Flatcar Container Linux being unable to be found,
detect Flatcar distro name especially for hostname, just like CoreOS
Container Linux was supported.

See also https://github.com/ansible/ansible/issues/69516
2020-06-02 18:41:53 +05:30
d7f61cbc28 Update 2.10 roadmap dates (#69771) 2020-06-01 13:36:14 -05:00
e10e5fc4ad only ever catch ImportError (#69792)
ModuleNotFoundError is a subclass of ImportError but only exists in
Python 3.6 or newer. Instead of doing hacks to be able to catch that on
older Pythons, just always only catch ImportError, which will also catch
ModuleNotFoundError on Python 3.6 or later
2020-06-01 09:01:38 -07:00
80f09efd03 do not return the body even if it failed (#69706)
* do not return the body even if it failed

* add some tests for this and rebase

* import test task

* ignore_errors when fails

Co-authored-by: Jack Zhang <jack.zhang@aspiraconnect.com>
2020-06-01 09:55:38 -04:00
723a904f4e Handle disabled service units (#69349)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-06-01 09:40:52 -04:00
2abaf320d7 [ansiballz] ensure that '' is not in sys.path (#69342)
Change:
On OpenBSD when using pipelining, we do not set cwd which results in a
permissions fatal. Ensure that `''` - cwd - is not in `sys.path`.

Test Plan:
Tested against local OpenBSD VM

Tickets:
Fixes #69320

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-06-01 03:43:20 -05:00
79ab798427 Enable logging using setup_loggers() API in dnf-4.2.17-6 or later
- Fixed issue #28061
- https://bugzilla.redhat.com/show_bug.cgi?id=1788212

Signed-off-by: Hideki Saito <saito@fgrep.org>
2020-05-30 20:37:27 -05:00
b1b79be08b Fix return value interpretation of PluginLoader.find_plugin_with_context(). (#69772) 2020-05-29 17:17:28 -07:00
3ec18ccb77 Allow announce script to work for base and older (#69768)
Change:
- Generalize the announce script changes from 4dd0f4127

Test Plan:
Harcoded 'hashes' to [] and then:
- Ran with --version 2.9.9 --version 2.10.0.dev1
- Ran with --version 2.9.9
- Ran with --version 2.10.1

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-29 16:20:30 -05:00
61a1fe1d7d Fix network_cli test to use a trap for cleanup (#69762)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-29 15:45:33 -05:00
53f9822e75 make plugins loader Python 3.5 compatible again (#69754)
ModuleNotFoundError was only introduced in Python 3.6
2020-05-29 12:37:52 -07:00
ee1625f906 Remove Power from test matrix (#69767)
We are having failures due to floating IPs not being cleaned
up and hitting the account limit of 50
2020-05-29 15:03:20 -04:00
3606dcfe65 Ensure --version works with non-ascii project path (#66624)
Fixes #66617
2020-05-29 14:42:44 -04:00
1dd8247fba Add SLES to user_guide/playbook_conditionals.yml (#69262) 2020-05-29 13:39:49 -04:00
bfc510a0f8 Update other_tools_and_programs.rst (#69499) 2020-05-29 13:38:06 -04:00
e40889e711 Add support to install collections from git repositories (#69154)
* Enable installing collections from git repositories

* Add tests for installing individual and multiple collections from git repositories

* Test to make sure recursive dependencies with different syntax are deduplicated

* Add documentation

* add a changelog

* Skip Python 2.6

* Only fail if no collections are located in a git repository

Add support for a 'type' key for collections in requirement.yml files.
Update the changelog and document the supported keys and allowed values for the type.

Add a note that the collection(s) in the repo must contain a galaxy.yml

* Add a warning about embedding credentials in SCM URLs

* Update with review suggestions

* suppress sanity compile failure for Python 2.6
2020-05-29 13:33:32 -04:00
225ae65b0f Make Python path warning say what it means to say (#69669) 2020-05-29 13:15:11 -04:00
c3dff34c15 Add entries for missing network modules (#69760)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-05-29 10:11:45 -07:00
925199511e Add JetBrains platform tools (#69478) 2020-05-29 12:09:26 -05:00
c884c5fddf add pointer to namespace and collection name restrictions (#69761) 2020-05-29 11:58:15 -05:00
3a4e227efa remove build errors including guess (#69711)
* remove build errors including guess

* fixed shippable errors
2020-05-29 11:56:49 -05:00
f110bcd59e Turn on linkchecker in sphinx for documentation (#69590)
* add make linkcheckerdocs as option to verify external links

* add back anchor checks

* spacing nit

* fix shippable issue

* Update docs/docsite/rst/conf.py

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2020-05-29 11:48:53 -05:00
0b82d4499e ansible-test ansible-doc sanity test: also run with --json parameter (#69288) 2020-05-29 08:52:29 -07:00
4794b98f2a Fix version_added test (#69756)
* Fix version_added test for changes in #69680.

* Fix error message.
2020-05-29 08:25:14 -07:00
8e19ab178a connection plugins: try config, then play_context (#69751)
Change:
Rather than only using config, have base connection plugins fall back to
play_context.

Test Plan:
- Tested ansible-connection logic against an IOS device
- Tested -k against a VM
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-29 10:00:21 -05:00
eea84b6fdd routing.yml: update collections (#69699)
* routing.yml: update collections

routing.yml had gotten out of sync since `migrate.py` was run.
Update based on where files are today (more updates are needed)
Also validate routing.yml's schema

* Update lib/ansible/config/routing.yml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* rename scripts

* docker_service

* updated ansible_builtin_runtime schema

* Correct schema for plugin_router and import_redirect

* Correct schema for plugin_router and import_redirect

* validation moved to #69742

* netap, slxos, checkpoint

* test moved to separate PR

* even more

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2020-05-29 14:25:39 +01:00
7b3d9cbcb8 distribution: Added support for openEuler OS (#69324)
Detect os_family for openEuler OS as 'RedHat', instead of 'openEuler'.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-29 12:43:16 +05:30
f81f5da20e Ansible.Basic added generic fragment merger for module options (#69719) 2020-05-29 16:11:38 +10:00
40f21dfd3c Version source tagging (automatic and manual) for version_added and deprecation versions (#69680)
* Track collection for version_added.
Validate *all* version numbers in validate-modules.
For tagged version numbers (i.e. version_added), consider source collection to chose validation.

* Make tagging/untagging functions more flexible.

* Tag all versions in doc fragments.

* Tag all deprecation versions issued by code.

* Make Display.deprecated() understand tagged versions.

* Extend validation to enforce tagged version numbers.

* Tag versions in tests.

* Lint and fix test.

* Mention collection name in collection loader's deprecation/removal messages.

* Fix error IDs.

* Handle tagged dates in Display.deprecated().

* Also require that removed_at_date and deprecated_aliases.date are tagged.

* Also automatically tag/untag removed_at_date; fix sanity module removal version check.

* Improve error message when invalid version number is used (like '2.14' in collections).
2020-05-28 22:46:16 -07:00
f5f3ba7ab5 ansible-test - fix up relative util import for powershell validate-modules (#69753)
* ansible-test - fix up relative util import for powershell validate-modules

* Use different tactic for generic group

* Use python 2 and 3
2020-05-29 14:31:59 +10:00
31bf3a5622 Deprecate module in collection: allow removal date in documentation, make validate-modules ensure version and date match (#69727)
* Allow to deprecate module by date in documentation.

* Make sure deprecation date/version match between module docs and meta/runtime.yml.

* Unrelated fix: don't compare deprecated module version to Ansible's version in collection.

* Allow documentation's removal version to be something else than fixed list of Ansible versions for collections.

* Linting.

* Allow to deprecate plugin options by date.

* Add changelog fragment for deprecation by date (also covers #68177).
2020-05-28 14:20:52 -07:00
061c6c7c6f Prevent losing error info by including both loop and cond error msgs (#68485)
Fixes #66529
2020-05-28 17:13:39 -04:00
1e01ac413b Improve the changelog-how-to documentation. (#69268)
* Improve the changelog-how-to documentation:
* remove repetitions
* mention starting with lowercase
* update the link to examples, remove an irrelevant link
* change win_ example to apt_repository
* add info about collections
2020-05-28 15:56:26 -05:00
0894ea1b1d Adding nested variable example (#69518)
* Adding nested variable example to lib/ansible/plugins/lookup/vars.py
Co-authored-by: Matt Martz <matt@sivel.net>
2020-05-28 15:48:52 -05:00
323d2adfcc Fix example format in Ansible modules (#69509)
* Fix example format in several Ansible modules
* Update lib/ansible/modules/fail.py
* Update lib/ansible/modules/pip.py

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-05-28 15:42:26 -05:00
d0a25f004c note that environment is not good for secrets (#69618)
* note that environment is not good for secrets
* Update docs/docsite/rst/user_guide/playbooks_environment.rst
Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-05-28 15:24:32 -05:00
412af6ae91 Fix docs return formatting. (#69632)
Gets rid of the unknown field names in the return data.
Allows the plugin return docs to format under the new docs pipeline.
* Expect that package_facts will pass return-syntax-error now.
2020-05-28 15:23:30 -05:00
21b65257bf Fix spacing for playbook collections example. (#69688) 2020-05-28 15:21:50 -05:00
09f86c1410 docs: communications update (#69687)
* add some more info on IRC support channels to docs
2020-05-28 15:12:24 -05:00
0ce404c4d9 Update intro_inventory.rst (#69718)
Vars in inventory are merged in ASCII order. Change docs to reflect that.
2020-05-28 15:06:17 -05:00
59f2174c8b Doc: playbook keywords are reserved names too (#69585) 2020-05-28 10:32:28 -05:00
187de7a8aa Updated CLI help for 'ansible-galaxy' for 'collection' subcommand (#69458)
* Added YAML header line and link to existing github issue
2020-05-28 10:38:48 -04:00
4dd0f41270 Update announce script for ansible-base (#69735)
Change:
- s/Ansible/ansible-base/
- Update URLs

Test Plan:
- Hope for the best. (No real way to test this until release day because
  there are no files on releases.a.c for it to hash right now. A staging
  releng environment would fix this.)

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-27 23:04:42 -05:00
d7618712fd blockinfile - fix line end regression (#69734)
PR #66461 introduced a regression that resulted in an in correct block in the file
if the block to be inserted did not end with a line separator. Fix this bug and add
tests to cover this scenario.
2020-05-27 16:54:38 -04:00
65c57a7f5b Update default-test-container to version 1.14. 2020-05-27 11:31:38 -07:00
e5cc12a64f blockinfile - Preserve line endings (#66461)
Fixes #64966
* Fix "TypeError: splitlines() takes no keyword arguments" on Python2.7
* Add changelog fragment
* Don't use `grep -P` for BSD/macOS compatibility
* Fix sanity checks complaining about test fixtures with mixed line endings
* Update changelogs/fragments/66461-blockinfile_preserve_line_endings.yaml
2020-05-27 11:05:07 -04:00
8b6c02fc69 Make connection plugins use password from config (#69670)
Change:
Rather than connection plugins directly accessing play_context and pulling
the password from there, have them pull it from the config system, and
have TaskExecutor store it there for now.

Internally, it still routes through play_context for now, but this is
the first step away from that.

Test Plan:
- Local test with `ansible -c ssh`
- grep -R play_context.pass lib/ansible/plugins/connection/
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-27 09:59:55 -05:00
564907d8ac distribution: Refactor test_distribution_version testcases (#69300) 2020-05-27 14:01:31 +05:30
cb8f645e0f Allow to deprecate / remove plugins by version. (#69712) 2020-05-26 18:43:40 -07:00
304c3e57e8 [ssh] Add new sshpass_prompt option (#68874)
Change:
Allows the user to configure sshpass (1.06+) to look for a different
substring than the default "assword" that it comes with.

Test Plan:
Set a custom ssh password prompt on a VM with PAM and tried connecting to
it. Without `ansible_sshpass_prompt` set in inventory: experienced hang.
With `ansible_sshpass_prompt` in inventory: connected successfully.

Tried setting `ansible_sshpass_prompt` with an older `sshpass` in PATH
and got a loud error, as expected.

Tickets:
Fixes #34722, fixes #54743, refs #11565.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-26 19:58:31 -05:00
ea04e0048d Allow to deprecate options and aliases by date (#68177)
* Allow to deprecate options and aliases by date instead of only by version.

* Update display.deprecate().

* Adjust behavior to conform to tested behavior, extend tests, and improve C# style.

* Parse date and fail on invalid date.

This is mainly to make sure that people start using invalid dates, and we eventually have a mess to clean up.

* C# code: improve validation and update/extend tests.

* Make sure that deprecate() is not called with both date and version.

* Forgot to remove no longer necessary formatting.

* Adjust order of warnings in C# code.

* Adjust unrelated test.

* Fix grammar (and make that test pass).

* Don't parse date, and adjust message to be same as in #67684.

* Sanity tests: disable date in past test.

* Validate-modules: validate ISO 8601 date format.

* Validate-modules: switch schema declaration for deprecated_aliases to improve error messages for invalid dates.

* Use DateTime instead of string for date deprecation.

* Validate that date in deprecated_aliases is actually a DateTime.

* Fix tests.

* Fix rebasing error.

* Adjust error codes for pylint, and add removed_at_date and deprecated_aliases.date checks to validate-modules.

* Make deprecation date in the past error codes optional.

* Make sure not both version and date are specified for AnsibleModule.deprecate() calls.

* Stop using Python 3.7+ API.

* Make sure errors are actually reported. Re-add 'ansible-' prefix.

* Avoid crashing when 'name' isn't there.

* Linting.

* Update lib/ansible/module_utils/csharp/Ansible.Basic.cs

Co-authored-by: Jordan Borean <jborean93@gmail.com>

* Adjust test to latest change.

* Prefer date over version if both end up in Display.deprecated().

Co-authored-by: Jordan Borean <jborean93@gmail.com>
2020-05-26 20:23:56 -04:00
341a6be78d fix debian control file copypaste fail (#69715)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-26 18:42:40 -05:00
1ed5b587c8 More fixes for debian ansible-base builds (#69714)
Change:
Fix files that got missed in 04ec72160

Test Plan:
Local Ubuntu 20.04 VM

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-26 18:13:33 -05:00
fa81cc6a0c fix delegated loading when path is not a directory (#69713)
* find_module can't pop ImportError- we need to just translate to `None` since this is a normal condition with files on sys.path (eg `/usr/lib/python36.zip`)
* added test
2020-05-26 15:55:17 -07:00
5fc01c0a1d Use a custom build container on Shippable. (#69660)
* Use a custom build container on Shippable.

This supports key generation before git_sync, to avoid issues with pre-migration PRs.

If the node pool is switched to another version, a matching build container should be built and used.

* Don't kill our own custom container.
2020-05-26 14:05:46 -07:00
c987c0c8a1 provides per host/plugin world readable temp opt (#69393)
fixes #46174
2020-05-26 15:29:37 -04:00
4aff87770e [yum] Make package removal confirmation strict (#69592)
* [yum] Make package removal confirmation strict

Change:
After removing packages, the yum module does a final check to ensure the
packages are really installed. The check would include packages that
were RPM `Provides:` values of another package.

This means that, for example, if a third-party kernel RPM spec had
`Provides: kernel` in it, removing the stock kernel would be successful
but the check to see if it was really removed would fail and cause
Ansible to report a failure.

Test Plan:
Tested on local CentOS 7 VM with kernel from elrepo which is known to
`Provides: kernel`.

Tickets:
Fixes #69237
Refs #35672
Refs #40723

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-26 14:47:39 -04:00
f7dfa817ae collection routing (#67684)
* `meta/` directory in collections
* runtime metadata for redirection/deprecation/removal of plugin loads
* a compatibility layer to keep existing content working on ansible-base + collections
* a Python import redirection layer to keep collections-hosted (and otherwise moved) content importable by things that don't know better
* supported Ansible version validation on collection loads
2020-05-26 09:42:06 -07:00
fdfa6fec75 Module Find returns empty list when setting path to "/" and depth to 1 (#69650)
* Fix bug on find module when path is / and depth 1.
2020-05-26 12:30:59 -04:00
dae3ba71a8 Add FQCN mappings for network facts modules (#69601)
* Add FQCN mappings for network facts modules

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add unit tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* update entry for ironware

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-05-22 23:20:21 +05:30
fe9696be52 Fix ansible -K become_pass regression (#69629)
* Fix `ansible -K` become_pass regression

Change:
- This fixes a breaking change introduced in
  2165f9ac40

Test Plan:
- Local VM for now, with plans to add an integration test for -K going
  forward.

Tickets:
Refs #69244
2020-05-22 09:34:26 -04:00
de3f7c7739 fix delegated interpreter discovery (#69604)
* fix delegated interpeter
* allow returning fact if it is 'the right host'
* added note for future fix/efficiency
 as it stands we rerun discovery for the delegated host
unless its saving facts to itself
 * fixed test lacking delegate_to mock
2020-05-22 09:31:34 -04:00
dc63b36501 Spelling: dependant -> dependent (#69661) 2020-05-22 11:24:25 +05:30
a4072ad0e9 Split regular and handler results into their own queues (#69498)
When mixed with the free strategy (or any custom strategy that does not behave in
a lock-step manner), the linear methodology of _wait_on_handler_results may cause
race conditions with regular task result processing if the strategy uses
_process_pending_results directly. This patch addresses that by splitting the queues
used for results and adding a flag to _process_pending_results to determine which
queue to check.

Fixes #69457
2020-05-21 15:55:08 -05:00
cd8920af99 file - return 'state': 'absent' when a file does not exist (#66503)
This was changed in ansible/ansible#51350.
2020-05-21 16:35:45 -04:00
e0f25a2b1f Strip no log values from module response keys. Fixes #68400 (#69653) 2020-05-21 16:17:57 -04:00
cfd301a586 Restore CentOS on Power in CI. 2020-05-21 13:15:01 -07:00
eb5147e57b intersight_info and intersight_facts routed to cisco.intersight (#69648)
Co-authored-by: “dsoper2” <“dsoper@cisco.com”>
2020-05-21 15:28:22 -04:00
1ee70fc272 ansible.utils.vars.isidentifier improvements (#58278)
ci_complete
2020-05-21 19:54:40 +02:00
9281148b62 correctly merge multiple facts results (#68987)
* correctly merge multiple facts results

  fixes #68532
2020-05-20 18:53:37 -04:00
fe941a4045 Pin Docker version at 19.03.1 2020-05-20 15:10:41 -07:00
8fe812b212 Remove conflicting plugin from test/support/ dir. (#69628) 2020-05-20 14:52:26 -07:00
b748edea45 Add multipart/form-data functionality (#69376)
* Add multipart/form-data functionality

* Fix some linting issues

* Fix error message

* Allow filename to be provided with content

* Add integration test

* Update examples

* General improvements to multipart handling

* Use prepare_multipart for galaxy collection publish

* Properly account for py2 vs py3, ensuring no max header length

* Address test assumptions

* Add unit tests

* Add changelog

* Ensure to use CRLF instead of NL

* Ignore line-endings in fixture

* Consolidate code, add comment

* Bump fallaxy container version

* ci_complete
2020-05-20 15:44:01 -05:00
08da8f49b8 Remove AIX from CI. 2020-05-20 12:37:21 -07:00
ecd986006e Properly handle unicode in safe_eval (#68576)
* Properly handle unicode in safe_eval

Fixes #66943

* Update lib/ansible/template/safe_eval.py

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-05-20 12:08:50 -04:00
889da811d7 Pin docker-ce-cli version in tests (#69620)
Installing docker-ce has a dependency of docker-ce-cli. If the version of docker-ci-cli is not specified, it installs the latest version.
2020-05-20 11:38:01 -04:00
9780d3db18 Remove "keywords" field in DOCUMENTATION.
This doesn't seem to be used by config although it came in with the
config PR.  It's not displayed in docs.  Removing it as this is the only
place where it's present.
2020-05-19 22:36:53 -07:00
06ecdaa7b1 comment heavy playbook (#68981)
* create examples/play.yml


Co-authored-by: flowerysong <junk+github@flowerysong.com>
2020-05-19 17:27:08 -04:00
df4e83deda added 'task timeout' feature (#69284)
* added 'task timeout' feature


Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-19 17:20:08 -04:00
ac533403e3 Google gcp_*_facts modules were symlinks to gcp_*_info modules in 2.9. (#69566)
Since it doesn't make sense to have extra copies of the _info modules in community.general only so that the _facts
symlinks are not in google.cloud, let's simply redirect the _facts modules to their google.cloud _info counterpart.

See also ansible-collections/community.general#351.
2020-05-19 10:40:48 -05:00
f01de15d25 ansible-galaxy - remove warning during collection install (#69541)
* ansible-galaxy - remove warning during collection install

If existing collections do not contain a MANIFEST.json, which is common
for collections under development that were not installed from Ansible
Galaxy, fall back to inspecting galaxy.yml rather than displaying a
warning.

A warning will still be displayed in neither a MANIFEST.json nor
galaxy.yml are present.

* Update unit tests
2020-05-19 10:31:49 -05:00
dd4219184b Update openstack module redirections (#69562)
The openstack related modules moved to the openstack cloud
collection. Update the target pointers.
2020-05-19 10:00:04 -04:00
43acd61901 ansible-test local change detection: use --base-branch if specified (#69508) 2020-05-18 13:18:31 -07:00
ecea15c508 Unify ansible-galaxy install -r (#67843)
* Unify ansible-galaxy install -r

* Minor nit fixes for docs

* Re-align warnings

* Fix up integration test

* Fix up test where no roles/collections were in file
2020-05-19 05:09:42 +10:00
01e7915b0a Remove obsolete incidental_azure_rm_webapp test. 2020-05-15 22:23:17 -07:00
86743292ec Remove incorrect function args in unarchive. 2020-05-15 18:31:43 -07:00
04ec72160a Fixes for building ansible-base .debs, using py3 (#69534)
Change:
- Changes for ansible -> ansible base
- Bump to py3 for 2.10 PPA release

Test Plan:
- Local VM; Jenkins after merge.

Tickets:
- Refs #57342

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-15 20:30:08 -05:00
3dedf95dbd Remove RPM packaging infrastructure (#69554)
Change:
- Nuke `make rpm` and friends from Makefile
- Nuke packaging/rpm

We are no longer going to be pushing RPMs to releases.ansible.com
post-2.10, so this is no longer necessary for us, and users should
prefer RPMs from their distro instead.

Test Plan:
Grepped the Makefile for all of: /rpm/i, /mock/i, /fedora/i

Tickets:
Refs #69539

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-15 20:29:05 -05:00
c495c92a6e Code cleanup in ansible-test. 2020-05-15 18:17:11 -07:00
ed4fd9be67 Code cleanup in ansible-inventory. 2020-05-15 18:02:18 -07:00
159d79995c Freeze pycodestyle in ansible-test. 2020-05-15 16:38:50 -07:00
e7c2eb519b Add Shippable request signing to ansible-test. (#69526) 2020-05-15 15:38:02 -07:00
6fffb0607b WIP: Docs: User guide overhaul, part 4 (#69266)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-05-15 16:18:07 -04:00
b8469d5c7a lineinfile - Use ANSIBLE_REMOTE_TMP for temporary file (#69543) 2020-05-15 15:52:17 -04:00
34db57a47f introduce fact "ansible_processor_nproc": number of usable vcpus (#66569)
This fact reflects the number of usable vcpus (which might be different
from ansible_processor_vcpus, e.g., in containers with limits). See
also #51504.

* Add fixture data and update unit tests

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-05-15 09:38:56 -04:00
d63a71e3f8 typofix - globbing instead of globing. (#69515)
Fix typo introduced in PR #69087
2020-05-15 13:23:35 +05:30
83381cd912 Update the default-test-container in ansible-test.
The updated container includes fewer requirements now that the collection migration has completed.

Collections which encounter test issues with this new container should update their test requirements files to include the necessary requirements.
2020-05-14 21:24:58 -07:00
d0484fbf74 Cleanup for Python 3.9 and pycodestyle compat. 2020-05-14 21:06:16 -07:00
d8e0aadc0d Update ansible-test support for CI providers.
Refactored CI provider code to simplify multiple provider support and addition of new providers.
2020-05-14 17:08:30 -07:00
ca6da5ad63 Remove obsolete incidental test. 2020-05-14 17:02:11 -07:00
9d8cf1ed21 Add path for yum on IBM i to PKG_MGRS (#69484)
* Add path for yum on IBM i to PKG_MGRS

On IBM i, yum is installed under the `/QOpenSys/pkgs` prefix, see:
https://bitbucket.org/ibmi/opensource/src/master/docs/yum/#markdown-header-must-know-usage-notes-read-this-after-you-install

* Add changelog fragment
2020-05-14 19:09:09 -04:00
2165f9ac40 fix delegation vars usage (debug still shows inventory_hostname) (#69244)
* fix delegation vars usage and reporting

 - just pass delegated host vars + task vars to plugins
   and avoid poluting with original host vars
 - updated tests
2020-05-14 16:36:13 -04:00
dfa2863dee Remove FIXME where no change is needed (#69466)
* Added exception

* Added changelog fragment

* Remove FIXME comment

* Edit changelog fragment
2020-05-14 15:44:33 -04:00
9767d592a8 Add resource_from_fqcr utility function. (#68474) 2020-05-14 13:50:29 -04:00
55e29a1464 ansible-galaxy - fall back to galaxy.yml when listing collections (#68925)
Fallback to galaxy.yml for listing collections that don't have a FILES.json or MANIFEST.json

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-05-14 12:28:08 -04:00
343ffaa18b better error for "ansible-galaxy collection verify" if there's no MANIFEST.json (#67498)
* Add a better error for "ansible-galaxy verify" if the MANIFEST.json has been deleted from the installed collection or if the collection hasn't been installed via normal means

* Fix unit tests for the remote collection

If there's something wrong with the local collection's version it will fail before the remote collection is sought

* Add a test for the new error msg

* Prevent the duplicate warning

Mock the new isfile call where needed

* Update lib/ansible/galaxy/collection.py

Co-Authored-By: Martin Krizek <martin.krizek@gmail.com>

Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
2020-05-14 12:25:19 -04:00
25c5388fde Update compile skip; all release and docs build scripts require 3.6+ 2020-05-14 09:14:37 -07:00
efff35a7cd Remove unused imports in the porting_guide command plugin 2020-05-14 09:14:37 -07:00
26704b915b Turn pathlib paths into strs
Some APIs do not take a pathlib.  They need to have a string
representation of a path.  Transform the default path to a str
so those APIs will work with the default value.
2020-05-14 09:14:37 -07:00
957ad8e769 Fix the command plugin to use the ABCMeta metaclass
The abstract* decorators don't have any effect unless the class has an
ABCMeta metaclass.
2020-05-14 09:14:37 -07:00
a3c400d0ce Remove outdated docs and unneeded import from change_detection build file 2020-05-14 09:14:37 -07:00
f200487414 Fix filedescriptor out of range in select() when running commands (#65058)
* Fix filedescriptor out of range in select() when running commands

* Simplify the run_command() code

Now that we're using selectors in run_command(), we can simplify some of
the code.

* Use fileobj.read() instead of os.read()
* No longer use get_buffer_size() as we can just slurp all of the data
  instead.

Also use a simpler conditional check of whether the selector map is
empty

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-05-14 11:46:34 -04:00
87d9b49de2 Fix listing of colleciton plugins with symlinks (#69305)
* Fix listing of colleciton plugins with symlinks
2020-05-14 11:45:02 -04:00
c13b040e67 systemd: set scope default to "system" (#67006)
- Make "system" default scope for systemd
- Remove extra None checks since there is now a default
2020-05-14 11:36:47 -04:00
cedfe34619 added unvault lookup plugin (#69087)
* added unvault lookup plugin
2020-05-14 11:19:19 -04:00
4c4406b2df Flatten the directory hierarchy of modules (#68966)
* Flatten the directory hierarchy of modules

* Update ignore.txt, flatten units

* Update imports

* Completely flatten the modules directory

* Update sanity ignore

* Fix some sanity test ignores

* Fix relative import

* Fix docs builds without category

* ci_complete

* Clean up docs. ci_complete

* Adjust needs/file alias

* ci_complete

* fix hardcoded ping module paths

Co-authored-by: Matt Davis <mrd@redhat.com>
2020-05-13 19:14:53 -07:00
c43f275c7e added missing headers + note (#69500) 2020-05-13 17:12:48 -04:00
0e15375ffe Add deprecated removed_in_version and deprecated_aliases version tests (#66920) 2020-05-13 13:58:09 -07:00
f0b6f76bc6 only show_vars when showing vars (#69365)
* only show_vars when showing vars

avoid processing function params that can be very expensive
and might not be used at all in called function.

fixes #69357

* Update changelogs/fragments/69357_optimize_inventory_graph_wo_vars.yml

Co-authored-by: Sloane Hertel <shertel@redhat.com>

Co-authored-by: Sloane Hertel <shertel@redhat.com>
2020-05-13 15:03:30 -04:00
3b3c811be5 Separate the galaxy lib from the cli (#69473)
The galaxy lib knew about the cli args in context.  This shouldn't be
the case as it makes it hard to use the lib in other contexts.  Moved
the context knowledge into cli/galaxy.py.
2020-05-13 13:13:30 -04:00
0aa76503dc avoid fatal tb on bad fqcn callback name (#69440) 2020-05-13 12:02:31 -04:00
eb3e4b3a7b cyberark appears to have renamed their collection
Trying to build docs for Ansible-2.10 and ran into error #69475
in ansible-doc.  To work around that I need to get a newer cyberark
collection which fixes the issues.  Unfortunately, it looks like the
cyberark team has renamed their collection from bizdev to pas is not
responding to issues on github.  I'm putting in this PR for them to
get this updated before 2.10 so that the modules will work out of the
box.
2020-05-13 07:54:02 -07:00
6086ea62ee Remove deprecation for TRANSFORM_INVALID_GROUP_CHARS (#66650)
Fixes #61889
2020-05-13 10:16:32 -04:00
cdaf7da11a Restore AIX testing. 2020-05-12 15:05:47 -07:00
cc4c38ef7c Revert "Restore AIX testing."
This reverts commit b23b28170b.
2020-05-12 13:39:11 -07:00
b23b28170b Restore AIX testing. 2020-05-12 11:01:58 -07:00
776f4840fc fix ansible-test units to work(ish) under podman (#69462)
* ignore the missing `Networks` key, issue a warning that network disconnection won't function
2020-05-12 10:46:22 -07:00
aa36b02ede Fix fileglob plugin with non-existent subdirectory (#69451)
Since Ansible 2.9.8, if the fileglob plugin is passed a path containing
a subdirectory of a non-existent directory, it will fail. For example:

lookup('fileglob', '/'): ok
lookup('fileglob', '/foo'): (non-existent): ok
lookup('fileglob', '/foo/bar'): (non-existent): FAIL

The exact error depends on Python 2 or 3, but here is the error on
Python 2:

    AttributeError: 'NoneType' object has no attribute 'endswith'

And on Python 3:

    TypeError: expected str, bytes or os.PathLike object, not NoneType

This change fixes the issue by skipping paths that are falsey before
passing them to os.path.join().

Fixes: #69450
2020-05-12 09:12:21 -04:00
01258580b9 Fix formatting in docs for --become-method (#68152)
The default value isn't displayed currently: <https://docs.ansible.com/ansible/latest/cli/ansible.html#cmdoption-ansible-become-method>

+label: docsite_pr
2020-05-12 04:06:24 -04:00
9645304da3 Validate args for includes in handlers too (#57537) 2020-05-12 09:35:58 +02:00
eb40ecc843 Check for correct version of systemd Python library (#60692)
Fix issue where some versions of systemd don't have journal.sendv
2020-05-12 11:01:08 +05:30
b309c14265 Remove aix and power from test matrix.
Services providing both are currently down.
2020-05-11 15:53:52 -07:00
96f504cd11 added missing clog for 58461 2020-05-11 15:09:24 -07:00
e70f5cc132 vmware: example should use FQCN (#69351)
For instance, you should use `community.vmware.vmware_guest` instead of just
`vmware_guest`.

This way, the examples don't depend on the `collections` directive of the
playbook.

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-05-11 16:27:20 -04:00
cd8dd4a272 Fix galaxy publish sha256 value format. (#67942)
* Fix galaxy publish sha256 value format.

The multipart/form content used for the body
of the POST to /api/automation-hub/v3/collections
was missing a newline before the line with the value
of the sha256.

automation-hub/galaxy/django skips the field entirely in
that case and automation-hub code will use None for default
to indicate that no sha256 is provided (an available option).

Fixes ansible/galaxy-dev#246

* Add changelog fragment

Co-authored-by: Matt Martz <matt@sivel.net>
2020-05-11 12:52:38 -05:00
5b9418c06c Fix SemanticVersion comparison (#69395)
* Fix SemanticVersion comparison.

* Complete tests for _Alpha and _Numeric comparators.

* Linting, and add comment.
2020-05-11 11:58:15 -05:00
de59b17c7f Add Fedora 32 to CI (#69222)
Change:
Adds Fedora 32 to shippable and alters tests slightly for new Fedora.

Test Plan:
CI

Tickets:
Fixes #69230

Co-authored-by: Matt Clay <matt@mystile.com>
2020-05-08 18:59:43 -05:00
98fbd1b72f lint
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-07 21:44:13 -05:00
96c56b119d Add a script for adding backport references
Change:
- Add a place for adding backport-related scripts in the future
- Add a script for adding backport references

Test Plan:
- Used it for this latest batch of PR reference-adding.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-07 21:44:13 -05:00
9579113941 Remove some no-op code from InventoryManager
Change:
- Remove some no-op code
- Split up a somewhat complex line into two lines
- Nuke an incorrect comment

Test Plan:
CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-07 21:42:48 -05:00
c62ff861d3 git: don't import get_module_path (#69378)
The module don't use the `get_module_path()` function. No need to import
it.
2020-05-07 16:07:41 -04:00
04b22a6b35 Change example ControlPath to be short and unique (#69347)
Use %C as the ControlPath setting in the example config file. The old setting used %h and %r tokens, which break ansible for a few use cases, including packer provisioning, where hostname is always 127.0.0.1. %C is a hash of local host, remote host, username and port.
2020-05-07 14:52:42 -05:00
bc1364952b changing $HOME to $HOSTNAME in Synopsis (#69273)
$HOME variable does work with command module. This may be a bug. $HOSTNAME never works. Changing the example to use $HOSTNAME in the Synopsis of command module documentation page.
2020-05-07 14:39:16 -05:00
e28e86a428 hostname: PopOS support (#69295)
Added support for PopOS in hostname module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-07 15:36:14 -04:00
084587913a validate-modules: deprecated modules in collections (#68646)
* validate-modules: deprecated modules in collections

In Collections a module is marked as deprecated via meta/routing.yml

Use this file, rather than the leading `_` as part of the deprecated
test.

* Correct variable

* review comments

* indentation

* Read routing.yml only once

* pep8

* Apply suggestions from code review

Co-authored-by: Matt Clay <matt@mystile.com>

* review: remove duplicated conditional

Co-authored-by: Matt Clay <matt@mystile.com>
2020-05-07 08:11:46 +01:00
366f808683 Correct debugging modules documentation (#69245) 2020-05-06 12:20:47 -05:00
d039eb9317 add punctuation marks to comments (#68882) 2020-05-06 13:14:06 -04:00
39b3942048 Remove left hand side slicing
Left hand side slicing is confusing and slower but maybe more memory
efficient in some circumstances.  There is one case where it adds to
code safety: when it's used to substitute a different list in place of a
slice of the original list and the original list could have been bound
to a different variable in some other code.  (The most likely case of
this is when it's a global variable and some other code might import
that variable name).

Because of the confusion factor we think it should only be used for the
safety case or where it's been benchmarked and shown to have some sort
of documentatble improvement.  At the moment, only one piece of code
falls into those categories so this PR removes all the other instances
of left hand side slicing.
2020-05-06 09:56:40 -07:00
852906fe7f Make description of removes option of command module clearer (hopefully) (#68097)
* Improves description of removes option in command module

Co-authored-by: Eric L <android@lavar.de>
2020-05-06 11:47:52 -05:00
4e72ce805d Order my dicts (#58000)
* use orderdict for yaml dictionaries

* clog

* SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

* allow user to toggle odict off

* removed config, since requored to load config

* remove unused import

* Update changelogs/fragments/yaml_orderd_mappings.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Update lib/ansible/parsing/yaml/objects.py

Co-authored-by: Matt Clay <matt@mystile.com>

* Update lib/ansible/parsing/yaml/objects.py

Co-authored-by: Matt Clay <matt@mystile.com>

Co-authored-by: Matt Clay <matt@mystile.com>
2020-05-06 11:05:37 -04:00
34458f3569 Update inventory caching documentation (#69100) 2020-05-05 15:10:57 -05:00
f6860a7a89 generator inventory plugin: remove "strict" from example (#69178)
This "strict" option appears to be unused. It's probably a copy-paste error from the constructed plugin.
2020-05-05 15:09:31 -05:00
47da0f7a4f restore jsonfile cache plugin (#69337)
* restore jsonfile

* update botmeta for jsonfile restoration
2020-05-05 10:50:39 -07:00
d446a4f70d yum: avoid running non-yum modules via the action (#69296)
If the system's detected package manager is not yum or dnf it should
refuse to run without an explicit backend, instead of running the
non-yum module.
2020-05-05 11:48:54 -05:00
794d269a4d Distribution: Add PopOS as Debian OS_FAMILY (#69294)
PopOS is a Debian based OS distribution, added support to detect
ansible_os_family as 'debian' instead of 'Pop!_OS'

Fixes: #69286

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-05 11:43:28 -05:00
947fa3bad3 ansible-test validate-modules: don't allow arbitrary lists and dicts for 'default', 'sample' and 'example' (#69287)
* Don't allow arbitrary lists and dicts for 'default', 'sample' and 'example'.

* Add changelog.

* Make compile with Python 2.
2020-05-05 11:38:10 -05:00
049800c063 Fix metadata defaults
* Metadata defaults were not being set if only a few fields were missing.

* ansible-doc with no documentation and no status in metadata should
  return empty, just like if there was no documentation and no metadata
  at all.
2020-05-05 09:06:52 -07:00
6d8cfcf539 Addressed FIXME's in hurd.py (Extracted functionality and exit early) (#69226)
* Addressed FIXME's in hurd.py

* Added changelog fragment

* Fix function order

* Added self reference

* Changed to 'is None'
2020-05-05 10:47:25 -05:00
8d43d79191 galaxy: Handle empty roles and collections (#69199)
Galaxy collection install command raised indexError,
when requirements.yml contains empty roles and collections.

This fix handles empty roles and/or empty collections.

Fixes: #68186

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-05 10:34:04 -05:00
9d48884e36 Fix support for Kali Linux detection (#69194)
* Fix support for Kali Linux detection

* Add test for Kali Linux detection

* Improve path matching with "in list"

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-05 10:31:32 -05:00
70219df905 Address FIXME's in sysctl.py (#69175)
* Address FIXME's in sysctl.py

* Added changelog fragment

* Updated check

* Update conditions

* if not instead of is None

* Restore and delete FIXME comments
2020-05-05 10:25:46 -05:00
cdad594b16 plugin_formatter: sys.exit does not take a file argument (#68016)
Cleanup of leftover from bcdfdc0cc3.

sys.exit does not take any named argument.
2020-05-05 08:38:23 +05:30
1a5bbfbe01 Fix name of utility "nologin" (#69207)
The utility is `nologin`, not 'no login'. Fix this on the page about Become. In the example further down below it is spelled correctly.
2020-05-04 17:40:44 -05:00
c52121f4c9 Clarification for Ansible and BSD Introduction (#69275)
Bug: https://github.com/ansible/ansible/issues/69274
2020-05-04 16:16:41 -05:00
46fea92125 Add note in inventory guide saying group names follow variable name guidelines. (#69285) 2020-05-04 16:09:44 -05:00
eab4f9afc4 docs: Small grammar improvement in the community guide (#69304)
The comma should not be included as it is not joining two independent
clauses.
2020-05-04 16:06:23 -05:00
5e74ada06b fix expires usage sentence flow (#69306) 2020-05-04 16:04:08 -05:00
44a4538280 add FQCN for migrated filters (#69321) 2020-05-04 16:02:13 -05:00
caa263e2cf Document how to migrate a standalone role to a collection (#68687)
Adds docs for role developers/owners in the collections ecosystem
2020-05-04 15:59:54 -05:00
7e0794085e add links to new docsites (#69310) 2020-05-04 14:59:09 -05:00
722d89478b Remove Ansible.Service from routing (#69317) 2020-05-05 05:50:08 +10:00
bbdf77a59f preserve json parsing error (#58461)
* preserve json parsing error
* added test
2020-05-01 15:03:07 -04:00
23ab8f37df fix a-doc listing plugins and add tests (#68600)
* add docs listing tests
* added collection module docs test
* always safe_load
* force 'type consistency' for uniquing paths
* bytified
* use our json encoder

Co-Authored-By: Matt Clay <matt@mystile.com>
2020-04-30 17:20:56 -04:00
a67d5dbcb7 Add example setting for collections_paths parameter to examples/ansible.cfg (#69018)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2020-04-30 14:29:50 -05:00
1142faa213 Do not pass file mode during recursive copy on symlink files. (#69011)
* Do not pass file mode during recursive copy on symlink files.

The 'file' module cannot deal with mode=preserve. Do not pass that
mode to the module when 'preserve' is used.

* Fix changelog fragment filename
2020-04-30 14:22:16 -05:00
1cf26896c5 Default ansible-test provisioning to us-east-1.
Previously windows instances on Shippable would be automatically directed to us-east-2.
2020-04-30 11:04:37 -07:00
dba17aeb13 dnf allowerasing (#48319)
Add the ability to pass allowerasing to alter the dnf transaction
behavior.

Fixes #24161

This is effectively a port of the original pull request from
poettler-ric who has since abandoned the PR

    https://github.com/ansible/ansible/pull/34111

Signed-off-by: Adam Miller <admiller@redhat.com>
2020-04-30 09:33:05 +02:00
1c5c89baa6 Add RHEL 8.2 to CI
Change:
RHEL 8.2 GA was released this week, test it in CI instead of 8.1.

Test Plan:
CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-29 20:51:28 -05:00
eb65a01598 Enable dnf integration tests on CentOS 8
Change:
We were only testing dnf on RHEL previously.
Test on CentOS 8 as well.

Test Plan:
Ran locally in docker.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-29 20:51:28 -05:00
f6cfcba346 [dnf] Make behavior/errors compatible for new DNF
Change:
Extend the logic for custom error handling in the dnf module, so that on
newer DNF (such as DNF that ships with modern Fedora 31 container
images, and ships with RHEL 8.2) we report errors consistently with
older DNF.

Test Plan:
Ran dnf integration tests against an old Fedora 31 container image and a
brand new Fedora 32 container image; tess passed on both.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-29 20:51:28 -05:00
b437236633 Redirect inventory script links (#69143)
With inventory script migrated to their respective collection,
redirect links in documentation to their respective collection
location.

Fixes: #69139

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-29 16:05:39 -04:00
bc41dd4514 Handle non-ascii paths during role installation. Fixes #69133 (#69213) 2020-04-28 15:33:44 -05:00
babac66f9c Be strict about what is a boolean for keywords (#67625)
* be strict about what is a boolean for keywords

 - found and fixed typo in test , 'yes' != 'yes.'
2020-04-28 13:55:26 -04:00
7714f691eb wait_for simplehttpserver to come up online
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-28 09:43:07 -07:00
ff47d3f766 Make sure collection is a list if a str is given (#69081)
* Make sure collection is a list if a str is given

* Call field validation early on collections

Because we are doing work on modifying the collections value before
it is actually validated, we can validate it ourselves early to make
sure the user supplies either a string or list. Dicts are not valid.

The new validation allows us to simplify the _ensure_default_collection()
function. And since the field is now static, we no longer need to specify
a default for it, which also allows us to simplify the function. Since
the default is now removed, we can also remove the sanity/ignore.txt entry
for collectionsearch.py.

New unit tests are added (and the existing one modified) that allow us to
make sure that we throw a parser error if a user specifies something other
than a string or list for the collections value everywhere it can be specified.

* Revert removing the collection default

The default is actually used, so restore it.

* Fix unit tests in test_helpers.py affected by early collection validation
2020-04-28 10:47:11 -05:00
91bb5af688 Update ansible-galaxy to handle role requirements (#68288)
* Update galaxy role object to handle requirements

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2020-04-28 10:42:57 -04:00
d42151e676 Removed redundant conditional in paramiko_ssh.py (#69164)
* Removed redundant conditional

* Added changelog fragment

* Removed trailing whitespace
2020-04-28 10:36:22 -04:00
339c442250 Added missing parameter (#69160)
The call to daemonize() in sysvinit.py was missing the module parameter included in the function definition in service.py.

This pull request simply adds that parameter, as the module is used for error handling in daemonize().
2020-04-28 15:31:48 +05:30
53cf6c60cb ROADMAP - s/ansible/ansible-base/g (#69071) 2020-04-28 10:44:20 +01:00
f66c65e241 Remove tomaszkiewicz from ansibullbot notifications (#69197) 2020-04-27 12:39:59 -04:00
9217aeeac1 Revert "Fix missing persistent connection messages (#68496)" (#69147)
This reverts commit 5f6427b1fc.
as it breaks netconf connection. This will be a temporary measure
for unlocking CI until a proper fix is shipped.
2020-04-27 11:58:57 +02:00
91d02e1c1f constructed inventory plugin: correct example (#69165)
Fixed 'intersect' filter name in constructed inventory plugin example.
2020-04-27 12:04:51 +05:30
a050d892d8 Remove obsolete vcenter setup from ansible-test. 2020-04-26 19:56:40 -07:00
bd4fdb1ca2 service_facts: fix for systemd 245 (#68211)
* service_facts: fix for systemd 245

Since systemd 245, `systemctl list-unit-files` comes with a new column
"VENDOR PRESET" [1] and breaks the service_facts module:

$ ansible localhost -m service_facts
localhost | FAILED! => {
    "changed": false,
    "msg": "Malformed output discovered from systemd list-unit-files: auditd.service                             disabled        disabled     "
}

This patch drops the third column to make it work with old and new
systemd. With the new slice operation, IndexError instead of ValueError
is raised if the output contains less than 2 columns.

Test plan: running `ansible-test integration -v service_facts` on
up-to-date Arch Linux

[1] https://github.com/systemd/systemd/pull/14445

* add changelog

Signed-off-by: Rick Elrod <rick@elrod.me>

Co-authored-by: Rick Elrod <rick@elrod.me>
2020-04-24 18:26:42 -05:00
d7da1d9bd0 Fix ansible-test coverage constraints. 2020-04-24 10:52:21 -07:00
572fe9e480 Adjust Openstack Inventory script path (#69058) 2020-04-24 11:15:51 +05:30
e8d3358427 Ignore GPG key checks on test repo
Disable GPG key checks when installing packages from the test repo.
2020-04-23 14:48:55 -07:00
e663391e77 Fix yum test case on ppc64le
This patch covers a few changes to get the yum test case working on ppc64le
CentOS.  Specifically we needed to enable the EPEL repository on CentOS
as well as ensure some of the architecture-specific tasks use the right
set of binaries during their test.
2020-04-23 14:48:30 -07:00
fce66b9707 Openstack inventory script moved to openstack.cloud (#68908)
Openstack dynamic inventory script is moved from community.general to
openstack.cloud, adjust the bot meta accordingly.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-23 15:45:35 -04:00
42cc3fa923 collection build should ignore .git files (#68750) 2020-04-23 15:27:19 -04:00
3f47610d94 Don't crash ansible-vault create when no arguments (#68667)
* Don't crash ansible-vault create when no arguments

* Add changelog entry
2020-04-23 15:15:25 -04:00
813ea48fcf Bring back more objects that were exposes in _text (#69090) 2020-04-24 04:56:59 +10:00
da390b297e [pip] Enable virtualenv_command to have arguments
Currently if virtualenv_command has arguments, then the
search for the binary in the path does not work so the
user has to specify the full path to it.

To allow arguments to be used without having to specify
the path to the binary, we split the module argument into
the command and anything after the first space.

This makes using this module argument more flexible and
user friendly.

Fixes: #52275
2020-04-23 18:13:30 +02:00
f27c417fc4 Use Templar for galaxy skeletons (#69106)
* Use Templar for galaxy skeletons. Fixes #69104

* Update checksum, our templar doesn't remove trailing newline, jinja2 seems to remove it
2020-04-23 10:36:14 -05:00
85bb804cda Revert "Cap cryptography version for macOS openssl test (#69083)" (#69126)
This reverts commit 1e08bb7a6f.
2020-04-23 08:49:09 -05:00
8b30360ca9 fixed handling of releasever for all known scenarios (#69057)
Signed-off-by: Adam Miller <admiller@redhat.com>
2020-04-23 09:02:00 +02:00
cace616aab Filter BLACKLIST_EXTS in PluginLoader (#69029)
Change:
Rather than hardcoding .pyo and .pyc, filter on all BLACKLIST_EXTS in
the non-legacy logic of PluginLoader (_find_fq_plugin). The two harcoded
extensions are part of BLACKLIST_EXTS already and this simply adds the
rest of the blacklisted extensions to the check.

In addition, check .endswith() instead of an exact match of the suffix,
like everywhere else that uses BLACKLIST_EXTS. This allows for
blacklisting, for example, emacs's backup files which can appear after
any extension, leading to things like `foo.py~`.

Test Plan:
Ran `ansible-playbook` against a collection where a `foo.py~` module was
getting executed instead of `foo.py` which also appeared in the same
directory. `foo.py~` is no longer executed.

Tickets:
Fixes #22268
Refs #27235

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-22 17:20:12 -05:00
da98fc267a Allow a collection role to call a standalone role by default (#69102)
* Allow a collection role to call a standalone role by default. Fixes #69101

* tweaked changelog text

* Guard against NoneType

Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
2020-04-22 13:58:08 -05:00
977b58740b update ActionBase._low_level_execute_command to honor executable (#68315)
* update ActionBase._low_level_execute_command to honor executable

* adding changelog fragment

* renaming changelog fragment to .yml

* noop change to bump shippable

* adding raw_executable integration test

* copying aliases from raw

* removing blank lines

* skipping aix and freebsd

* noop to bump shippable

* moving tests to raw/

* removing become_method: sudo ; it doesn't work on AIX

* removing trailing blank line

* forcing become_method: su to try to get AIX to work

Co-authored-by: Rob Wagner <rob.wagner@sas.com>
2020-04-22 11:56:35 -05:00
1e08bb7a6f Cap cryptography version for macOS openssl test (#69083)
Change:
New `cryptography` statically links an openssl that is too new for macOS
10.11, so limit to an older cryptography for now.

Test Plan:
Ran the test with `--remote osx/10.11` and it passed.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-21 15:13:46 -05:00
2a90e9b615 Fix incorrect CVE reference in changelog fragment
Change:
This corrects an incorrect CVE identifier in the changelog entry for
CVE-2020-1735.

Test Plan:
N/A

Tickets:
Refs #67793, #68720

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-21 11:42:52 -07:00
5a3ca0ae5f Fix ansible-test delegation from pip install. 2020-04-21 09:48:16 -07:00
d17a44b0c5 Add new arches/OSes for binary_modules tests (#69052) 2020-04-21 00:52:23 -07:00
af44bd4ddd Fix --start-at-task when skipping tasks with no name (#68951)
Using --start-at-task on a playbook with tasks with no name would fail
if those unnamed tasks were encountered before the targetted start task.
2020-04-21 09:39:17 +02:00
cb389f6c31 Prevent rewriting nested Block's data in filter_tagged_tasks (#68337)
This patch fixes the issue where nested Block copies were created from
incorrect Block object. This resulted in nested Blocks data like ``name``
or ``_uuid`` to contain values from the Block the filter_tagged_tasks
method was called on.
2020-04-21 09:36:35 +02:00
122743ae30 Update ansible-test handling of delegation paths. (#69056) 2020-04-20 22:04:25 -07:00
a8a61829b8 Enable passing tests on power. 2020-04-20 10:07:54 -07:00
fd8b874273 Update docs, pointing to an existing chapter. (#69026)
The chapter that described more information about become to an unprivileged user has moved. This commit points to an existing chapter

Relates to #69021
2020-04-18 07:52:29 -05:00
648b3d43d3 [copy] Add some test coverage for check_mode (#68895)
Change:
Adds some missing coverage for the copy module when `check_mode: True`.

Test Plan:
Ran test with --coverage and looked at the resulting report.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-17 16:09:32 -05:00
561725bace corrected comment (#69006) 2020-04-17 16:07:26 -05:00
44a471f6ba Enable service integration tests for FreeBSD (#68980)
* Enable service integration tests for FreeBSD

Change:
Adds necessary rc file for freebsd, and gets tests passing for it.

Test Plan:
Ran test with `--remote freebsd/12.1` and `--remote freebsd/11.1`. Both
passed.

Signed-off-by: Rick Elrod <rick@elrod.me>

* Update test/integration/targets/service/tasks/rc_setup.yml

Co-Authored-By: Matt Clay <matt@mystile.com>

* fix up comment

Signed-off-by: Rick Elrod <rick@elrod.me>

Co-authored-by: Matt Clay <matt@mystile.com>
2020-04-17 10:41:08 -07:00
d3cab602a5 Fix fileglob when using 'file*' vs 'stuff/file*' (#68945)
* Fix fileglob when using 'file*' vs 'stuff/file*'

 when not having dir in glob, files/ subdir was being ignored.

* tests for fileglob
2020-04-17 09:51:05 -04:00
acdc9eb76d native types: literal_eval all the things (#68938)
With https://github.com/pallets/jinja/pull/1190 merged our short-circuit
is no longer valid (has it ever been?) as now data like ' True ' may go
through our ansible_native_concat function as opposed to going through
intermediate call to Jinja2's native_concat before. Now we need to always
send data through literal_eval to ensure native types are returned.
2020-04-17 14:59:52 +02:00
3591451bc7 include_role: Strictly check string datatype for *_from (#68958)
Strictly check string datatype for 'tasks_from', 'vars_from',
'defaults_from', and 'handlers_from' in include_role

Fixes: #68515

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-17 10:57:41 +05:30
79fff7da69 Expose to_<str> as a public function (#68965)
* Expose to_<str> as a public function

* Fix sanity checks

* Move docstring to start of util
2020-04-17 07:54:00 +10:00
e4ea6a15b0 import where? (#68943) 2020-04-16 17:41:23 -04:00
ac509d489b Revert "stricter permissions on atomic_move when creating new file (#68970)" (#68983)
This reverts commit 566f2467f6.
2020-04-16 12:52:15 -04:00
566f2467f6 stricter permissions on atomic_move when creating new file (#68970)
fixes #67794
  updated some tests that expected previous defaults
  CVE-2020-1736
2020-04-16 09:06:18 -04:00
de6b047fc3 Add variable for DEFAULT_NO_TARGET_SYSLOG (#68971)
* Add variable for DEFAULT_NO_TARGET_SYSLOG

* Added version_added to new var
2020-04-16 20:25:09 +10:00
702949e64c windows - fix up env var quoting for unicode single quotes (#68968)
* windows - fix up env var quoting for unicode single quotes

* Add sanity ignore check for smart quotes
2020-04-16 20:24:23 +10:00
77a916e763 Add more integration tests. (#68972) 2020-04-16 00:53:08 -07:00
cce6153cd1 Remove unused functions (#68969) 2020-04-16 13:01:20 +10:00
46d82179d8 Testing: Add support for CentOS Linux On Power platform (#68130)
* Testing: Add CentOS Linux On Power platform

* Add arch designation to remotes.

This avoids overloading the provider with the arch.

Also add a changelog entry.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-04-15 16:22:17 -07:00
abb807e5dd Extend dev guide for collection testing and collection hacking (#68899)
* Make clear which BOTMETA.yml is meant (some collections also have one), fix itemization, document /rebuild and /rebuild_failed, add section on how to test collections with ansible-test, update supported versions for compile tests, add a section on hacking collections, implement feedback. 

* Update docs/docsite/rst/dev_guide/developing_collections.rst

Co-Authored-By: Felix Fontein <felix@fontein.de>
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-04-15 15:51:19 -05:00
6493a190f6 docs: Update inventory script paths (#68905)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-15 16:29:55 -04:00
c7997a77d2 VMware: Document vm properties (#68552)
VMware vm inventory uses configuration properties, rather than
relying on external documents, point user to this document.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-15 16:26:58 -04:00
d60b17082e small fix to install command as no longer needs -p by default (#68947) 2020-04-15 16:23:37 -04:00
cdb24e0078 ansible-galaxy - fix listing specific role and role description (#67409)
* ansible-galaxy - fix listing specific role

If the role was not in the first search path, it was reported as not found

* Properly display role description

Default to description to top level description, falling back to the description from within galaxy_info

* Display proper message when a role does not exist

* Add integration tests

* Use context manager

* BSD and macOS ruining all the fun
2020-04-15 15:26:45 -04:00
d3d301e776 Adjust openssl_certificate* module names (ansible-collections/community.crypto#7) (#68719) 2020-04-14 16:52:44 -05:00
f8a9d86388 Fix routing entry to patch. (#68537) 2020-04-14 16:49:35 -05:00
7d51706278 Revert "Switch network incidental tests to VyOS 1.1.7-R2."
This reverts commit 7d5177d6a0.
2020-04-14 12:18:23 -07:00
f11b1454bb prepare for future ansibot collection changes (#68944) 2020-04-14 13:11:05 -04:00
ff1ba39c8a Prevent templating unused variables for {%include%} (#68749)
Fixes #68699
2020-04-14 10:27:02 +02:00
7d5177d6a0 Switch network incidental tests to VyOS 1.1.7-R2.
The previous version being used, VyOS 1.1.8, is currently unavailable in AWS.
2020-04-14 01:12:48 -07:00
eaf648e600 Use context manager in yum module. (#65376) 2020-04-14 09:21:22 +02:00
8077d8e401 avoid mkdir -p (#68921)
* also consolidated temp dir name generation, added pid for more 'uniqness'
* generalize error message
* added notes about remote expansion

CVE-2020-1733
fixes #67791
2020-04-13 17:16:29 -04:00
18a66e291d Force collections to be static (#68723)
* Force collections to be static

Templating of collection names does not work at all. Force them to
be static so that a warning is generated for the user.

* Add collectionsearch unit test and fix for reviews

New unit test validates the new _load_collections() code and moves
the new check to the end of the method.

* Change unit test to pytest

* Adjust unit test to use capsys instead of monkeypatch

* Fix pep8 error

* Add changelog fragment

Closes #68704
2020-04-13 11:53:05 -05:00
d91658ec0c subversion module - provide password securely when possible or warn (#67829)
* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-04-13 10:21:10 -04:00
1097694355 get_url pass incorrect If-Modified-Since header(#67417) (#67419)
Fix #67417. HTTP header value of `If-Modified-Since` set by `get_url` does not follow HTTP protocol.
2020-04-10 12:17:55 -05:00
25650cb592 Updating routing data for gcp_kms_* filters (#68807)
gcp_kms_encrypt and gcp_kms_decrypt located in
google.cloud collection and not in community.general collection

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-10 16:25:17 +01:00
3b5ba22f52 Fixes #68121: Move kubectl plugin migration to proper place. (#68122) 2020-04-10 16:24:52 +01:00
cba90feabf moving zabbix modules to a dedicated collection (#68190) 2020-04-10 16:24:20 +01:00
a095172130 Fix ansible-test --docker without tests dir. 2020-04-09 18:12:21 -07:00
d86d20a378 Fix label lookup in the default callback for includes (#68822)
* Replace included_file._args w/ included_file._vars

* Fix item value in output of include_tasks loop

Signed-off-by: Yadnyawalk Tale <ytale@redhat.com>

* Update tests for loop callback fix. Add changelog

Co-authored-by: Yadnyawalk Tale <ytale@redhat.com>

Fixes #65904
Fixes #66018
2020-04-09 13:27:58 -05:00
a681810b2f doc: variable precedence: "override", not "overwrite" (#68698) 2020-04-09 11:55:53 -04:00
0f8937f2ed basic: Update required library message (#68657)
Updated missing_required_lib API message.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-09 11:49:04 -04:00
780067e6a1 url_windows - Add not around no redirection for auth headers (#68791) 2020-04-09 11:46:54 -04:00
43270332e7 true and false commands have to be quoted (#68761)
otherwise they will be parsed as bool instead of string by YAML.
2020-04-09 10:22:43 -05:00
4e3068dd5e reroute zabbix to its dedicated collection (#68806)
Refs https://github.com/ansible-collections/community.general/pull/11
Refs https://github.com/ansible-collections/community.zabbix/pull/1

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-09 10:12:00 -05:00
bae5f18f5c ansible-test: don't trigger full CI run for changes to changelogs/ and docs/ in collections (#68550)
* Don't trigger full CI run for changes to changelogs/ and docs/ in collections.

* Add changelog fragment.

* Update changelogs/fragments/68550-ansible-test-docs-changelogs.yml

Co-Authored-By: Matt Clay <matt@mystile.com>

Co-authored-by: Matt Clay <matt@mystile.com>
2020-04-09 02:53:34 -07:00
38b7ceb75a Update docker.txt to use the OpenSUSE 15.1 container image (devel edition) (#68785)
* Update docker.txt to use the OpenSUSE 15.1 container image

Signed-off-by: Rick Elrod <rick@elrod.me>

* handle installing mysql on suse

Signed-off-by: Rick Elrod <rick@elrod.me>

* add changelog fragment

Signed-off-by: Rick Elrod <rick@elrod.me>

* Update changelogs/fragments/ansible-test-opensuse-15.1.yml

Co-Authored-By: Matt Clay <matt@mystile.com>

Co-authored-by: Matt Clay <matt@mystile.com>
2020-04-09 00:26:59 -07:00
6f8a1d083e patch is in ansible.posix part deux (#68796) 2020-04-09 07:14:01 +01:00
9b43a57916 Add some missing dmi facts when we use dmidecode (#68756)
On OSes where we fall back to dmidecode (freebsd and linux currently),
add some missing fields that dmidecode provides when it is able.

Closes #59317.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-09 00:33:11 -05:00
04edd77c42 Update tests to use RHEL 7.8. (#68787)
* Update tests to use RHEL 7.8.

Keeping support for RHEL 7.6 since collections are still using it.

* Fix tests for RHEL 7.7+ due to extras repo name change.
2020-04-08 21:09:52 -07:00
a513a62536 Remove cgroup_perf_recap_graph.py, since that callback no longer exists here (#68779) 2020-04-08 14:04:53 -05:00
c9c1146cc8 dnf: remove un-needed function (#68482) 2020-04-08 20:36:28 +02:00
ba87c225cd fixed fetch traversal from slurp (#68720)
* fixed fetch traversal from slurp

  * ignore slurp result for dest
  * fixed naming when source is relative
  * fixed bug in local connection plugin
  * added tests with fake slurp
  * moved existing role tests into runme.sh
  * normalized on action excepts
  * moved dest transform down to when needed
  * added is_subpath check
  * fixed bug in local connection

fixes #67793

CVE-2019-3828
2020-04-08 14:28:51 -04:00
087be1da50 Allow tasks to notify a fqcn handler name (#68213)
* Allow tasks to notify a fqcn handler name

* Add tests. Fixes #68181

* Add changelog fragment

* Add test to ensure handlers are deduped properly with fqcn, role, and just handler names

* Add some docs about new special vars
2020-04-08 11:36:38 -05:00
4f8e98d322 Update changelogs/fragments/allow-fail-json-msg-to-be-positional.yaml
Co-Authored-By: Matt Martz <matt@sivel.net>
2020-04-08 07:56:11 -07:00
e0e7713fd8 Fix yaml in changelog 2020-04-08 07:56:11 -07:00
184f540056 Add some more unittests for fail_json
Test that order of msg as a keyword arg doesn't matter
2020-04-08 07:56:11 -07:00
6531ba38f8 Allow the msg argument to fail_json() to be a positional argument
fial_json() requires a message be given to it to inform the end user of
why the module failed.  Prior to this commit, the message had to be a
keyword argument:

    module.fail_json(msg='Failed due to error')

Since this is a required parameter, this commit allows the message to be
given as a positional argument instead:

   module.fail_json('Failed due to an error')
2020-04-08 07:56:11 -07:00
148e83f832 Fix ansible-test submodule handling. (#68759)
* Refactor ansible-test integration test.
* Add env --list-files option.
* Add tests for collection files tracked by git.
* Fix ansible-test submodule usage on older git.
* Fix submodule directory detection as files.
* Improve handling of nested source control.
2020-04-08 01:15:49 -07:00
d4d2c95819 Update team_openstack in botmeta (#68679)
* Update team_openstack in botmeta

* Also add an ignore for Shrews
2020-04-07 16:47:26 -05:00
598ead965d Dev guide: add notes about different image types for integration and unit/sanity tests (#68663)
* Dev guide: add notes about different image types for integration and unit/sanity tests
* Update docs/docsite/rst/dev_guide/testing_integration.rst

Co-authored-by: Matt Clay <matt@mystile.com>
2020-04-07 09:17:44 -05:00
13aef3c2e5 Add --docker-terminate flag to ansible-test (#68688)
* Add --docker-terminate flag to ansible-test

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-06 20:38:29 -05:00
4916be24fd [git] make force=True apply to git fetches (#68691)
Fixes #67972

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-06 15:25:24 -05:00
123c624b28 Always set the discovered interpreter on the delegated host (#64906)
* Always set the discovered interpreter on the delegated host. Fixes #63180

* Make code a little more generic

* Move code into a function

* Implement some changes based on reviews

* Add changelog fragment
2020-04-06 15:09:00 -05:00
318d5606c1 doc: explain default "required" value for argument_spec (#68678) 2020-04-06 16:07:30 -04:00
16e07fe5b5 Fix grammar error in docfile (#68707) 2020-04-06 16:03:17 -04:00
f50df67517 coverage for lookup_list (#68683)
* coverage for lookup_list

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-06 13:39:18 -05:00
82c60db49b pip - Fix check_mode for prerelease packages (#68690)
* pip - Fix check_mode for prerelease packages

Fixes #68592.

Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Matt Martz <matt@sivel.net>
2020-04-06 11:18:48 -05:00
f921b1e3bd asa_facts (#68076) 2020-04-06 19:32:54 +05:30
e2b2de5827 Update BOTMETA for networking (#68639)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-04-06 15:22:26 +05:30
28f9fbdb5e safely use vault to edit secrets (#68644)
* when possible, use filedescriptors from mkstemp to avoid race
  * when using path strings, ensure we are always creating the file

CVE-2020-1740
Fixes #67798

Co-authored-by: samdoran
2020-04-03 10:19:01 -04:00
40d9650f20 Migrate apt_repo to community.general. Fixes #68637 (#68641) 2020-04-02 11:06:12 -05:00
ae1cd27b57 WebRequest - Fix use_proxy: no on module options (#68603)
* WebRequest - Fix use_proxy: no on module options

* Fix up changelog fragment
2020-04-02 07:17:50 +10:00
e785bdaa5b Un-migrate url_windows doc fragment (#68602)
* Un-migrate url_windows doc fragment

* Removed from routing file
2020-04-02 05:20:49 +10:00
f5178f9705 Reap collections changelog fragments - 5 (#68618)
* Reap collections changelog fragments - 5

* One more
2020-04-01 12:52:53 -05:00
f206af7a3a chocolatey botmeta and routing changes (#68598) 2020-04-01 10:23:07 +01:00
6db66bcadd Add relative module_util support for powershell (#68321)
* Add relative module_util support for powershell

* Added ansible-test classification support
2020-04-01 09:01:18 +10:00
a20a527014 ansible-galaxy - Fix tar path traversal issue during install - CVE-2020-10691 (#68596) 2020-04-01 06:39:02 +10:00
8c044b846d add collection plugin listing to ansible-doc (#68522)
- listing from collections
 - able to filter by namespace or collection
 - masks dupes just as normal collection loading does
2020-03-31 15:25:20 -04:00
a3d6b6bc48 Add pacman support to package_facts (#66596)
* Add pacman support
2020-03-31 13:03:54 -04:00
541384e7b7 coverage for lookup_config (#68566)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-31 09:57:50 -05:00
2b4ca69bc2 Add notifications to BOTMETA.yml. 2020-03-30 16:07:27 -07:00
7323d5dd0d Fix references to old egg-info directory. 2020-03-30 13:56:43 -07:00
d8d7a30ea6 Reap collections changelog fragments - 4 (#68570)
* Reap collections changelog fragments - 4

* Reap collections changelog fragments - 4
2020-03-30 14:57:37 -05:00
2c294d0cbf Reap collections changelog fragments - 3 (#68567) 2020-03-30 14:28:50 -05:00
af27d1a5ad Reap collections changelog fragments - 2 (#68565) 2020-03-30 14:06:08 -05:00
5c7746e521 Remove changelog entries related to content that has migrated to collections (#68498)
* Reap changelog fragments

* remove changelogs/fragments/60510-k8s-apply-check-mode.yml

* Reap more

* Reap a few more
2020-03-30 11:47:53 -05:00
5f6427b1fc Fix missing persistent connection messages (#68496)
* Be more proactive about returning module messages

* Move message display to a function, and replace handling already in shutdown()
2020-03-30 11:26:33 -04:00
0fb5593abf Add initial ansible-test tests for collections. (#68533) 2020-03-29 09:04:27 -07:00
735885d57c Fix ansible-test requirements installation. 2020-03-29 08:46:25 -07:00
c888035e02 Update Ubuntu 18.04 test container to 1.13. (#68534) 2020-03-28 17:35:21 -07:00
bd9e31fcb0 Add a custom policy for hackers using ansible-test (#68535)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-28 17:07:29 -05:00
7777189954 Revert "ansilbe-doc list collections plugins (#67928)"
This reverts commit 0f5a63f1b9.
2020-03-28 11:21:08 -07:00
0f5a63f1b9 ansilbe-doc list collections plugins (#67928)
Now -l and -F will list plugins from discover-able collections
2020-03-27 22:19:49 -04:00
1570098e86 fallback to uid when no uname (#68466)
* fallback to uid when no uname

 fixes #68007

Co-Authored-By: Matt Clay <matt@mystile.com>
2020-03-27 22:09:51 -04:00
835ad75a0a add test coverage for core filters (#68518)
Also remove now-useless exception handling.
2020-03-27 17:18:27 -07:00
2068131589 Fix colorization to not extend across newline boundary (#68517)
* Fix colorization to not extend across newline boundary

* Fix unit test to look for the newline outside the coloration

* Add changelog fragment
2020-03-27 17:10:38 -07:00
53a3d1ffdb Fix ansible-test change detection traceback. 2020-03-27 15:56:02 -07:00
d8b5c11a63 Report error for coverage 5+ in ansible-test. 2020-03-27 12:29:02 -07:00
27fc049993 Fix ansible-test code coverage collection. (#68502)
The last task in a play should now properly report code coverage.

This change should also eliminate empty coverage files, as well as incomplete coverage files resulting from early worker termination.
2020-03-27 12:24:08 -07:00
6a7e438012 Fix code coverage in tests.
Code coverage < 5 must be used.

ci_coverage
2020-03-26 22:41:12 -07:00
3c3ffc09c2 Fix and add tests for some module_utils.common.validation (#67771)
* Fix test_check_mutually_exclusive exception-checking

Asserting inside of the `with` context of `pytest.raises`
doesn't actually have any effect. So we move the assert
out, using the exception that gets placed into the scope
after we leave the context, and ensure that it actually gets
checked.

This is also what the pytest documentation says to do:
https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions

Signed-off-by: Rick Elrod <rick@elrod.me>

* Add some tests for check_required_together

Signed-off-by: Rick Elrod <rick@elrod.me>

* use to_native instead of str, for consistency

Signed-off-by: Rick Elrod <rick@elrod.me>

* Add newlines for pep8

Signed-off-by: Rick Elrod <rick@elrod.me>

* Add tests for check_required_arguments

Signed-off-by: Rick Elrod <rick@elrod.me>

* Sort missing keys in error message, since hashes are unsorted and this can be random

Signed-off-by: Rick Elrod <rick@elrod.me>

* Add changelog entry

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-26 18:18:56 -05:00
2af76f16be Unify yaml style in unarchive tests to be dict-style (refs #68272) (#68477)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-26 18:02:17 -05:00
cfc9b4a1e2 Add Kubernetes Working Group to Communicating guide. (#68028) 2020-03-26 15:56:35 -04:00
01269f57a7 Rename AWS collections (#68476)
Both AWS collections have been renamed due to restrictions on the
ansible collections namespace.  Update botmeta and routing.yml for
the new paths.
2020-03-26 15:25:55 -04:00
db01053d6a Remove reference to core Ansible (#68462) 2020-03-26 15:22:36 -04:00
4fc10186b9 Move coding guidelines links to readme. (#68479) 2020-03-26 15:19:01 -04:00
5945415398 fix using inventory and cache plugins in a collection (#56469)
* Allow custom inventory plugins and cache plugins

If _load_name is not set correctly the cache plugin can't load the documentation (which is also the arg spec)

Fix the existing inventory plugin in the collections tests

Add integration tests for using a cache plugin in a collection

* Set the attribute on the instance instead of the class

Deprecate importing custom CacheModules directly - they should use the cache_loader
2020-03-26 12:05:46 -04:00
2268a37d4d Rename package to ansible-base 2020-03-26 08:12:17 -07:00
c61f141bbc Remove obsolete Makefile targets and logic. 2020-03-25 19:23:50 -07:00
206896e9b2 Cleanup refs to deleted files/dirs. (#68480)
* Remove deleted contrib dir from MANIFEST.in

* Update package-data sanity test.

Remove deleted files and directories.

* Remove aws_config dirs.
2020-03-25 19:10:27 -07:00
0bf7a08eb6 Remove hacking/aws_config
AWS hacking config has been moved to the AWS CI terminator repo, and is no
longer required in base.
https://github.com/mattclay/aws-terminator/pull/91
2020-03-25 18:47:34 -07:00
9139c1f81d consistently call tests tests, not filters (#68170)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-03-25 21:31:29 -04:00
0651e1c25f Add some more test coverage for unarchive (#68272)
* Add some more test coverage for unarchive

This moves over (and slightly extends) coverage which was found in
incidental_flatpak_remote.

Signed-off-by: Rick Elrod <rick@elrod.me>

* add a group for testing too, user creation does not mean group creation on all platforms

Signed-off-by: Rick Elrod <rick@elrod.me>

* update the test group assert

Signed-off-by: Rick Elrod <rick@elrod.me>

* Fix style

Signed-off-by: Rick Elrod <rick@elrod.me>

* block/always

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-25 16:23:55 -05:00
11e678b1b0 coverage for filter/urls.py, including fallback to custom implementations (#68412)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-25 16:23:14 -05:00
01638e0ea2 [mathstuff] Get coverage into the 90% range (#68395)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-25 15:33:37 -05:00
913ee9119a Fix list formatting in Getting Started (#68153) 2020-03-25 15:29:09 -04:00
6452a82452 fix vault temp file handling (#68433)
* fix vault tmpe file handling

 * use local temp dir instead of system temp
 * ensure each worker clears dataloader temp files
 * added test for dangling temp files
 * added notes to data loader

CVE-2020-10685
2020-03-25 15:24:04 -04:00
f633772942 Update documenation contributions to reflect that some docs are in collections now (#68264) 2020-03-25 14:04:53 -05:00
0d379d4205 Explain module docs loss for devel (#68369) 2020-03-25 13:55:05 -05:00
969e209a48 docs(windows_setup): +choco install openssh (#68408)
Also show most basic way of installing OpenSSH via Chocolatey
2020-03-25 13:53:54 -05:00
ddef49bb7f correctly escape parameters with dashes (#68281) 2020-03-25 14:49:05 -04:00
601065cb7a Remove old example playbooks dir. (#68409)
The content was relocated nearly 7 years ago.
2020-03-25 14:15:57 -04:00
89cec7c298 Remove MODULE_GUIDELINES.md (#68410)
The guidelines were moved to the docs site over 2 years ago.
2020-03-25 13:14:48 -05:00
8042d226e4 fix make webdocs warnings (#68411) 2020-03-25 13:13:56 -05:00
7ec0d59c30 windows - add docs for UNC path in PSModulePath error (#68421) 2020-03-25 14:09:32 -04:00
02e36fbfc2 fix broken link in developing collections (#68442) 2020-03-25 13:07:03 -05:00
d52d02f8aa reclassify fact_path to avoid local relative path (#67652)
should fix following when setting windows path in ansible.cfg:

  {"ansible_facts": {}, "changed": false, "failed_modules": {"setup": {"changed": false, "failed": true, "msg": "Get-AnsibleParam: Parameter 'fact_path' has an invalid path '/home/myname/ansible/test/C:\\users\\vagrant\\facts.d\\' specified."}}, "msg": "The following modules failed to execute: setup\n"}
2020-03-25 11:58:58 -04:00
ecd66a6a6e Action module xross coll (#68080)
* added test to verify xrs collection action/module

* added to runme

* sanity fixes

* corrected name

* avoid windoez
2020-03-25 11:57:53 -04:00
6acaf9fa95 route filters themselves, not their files (#68429) 2020-03-25 11:55:57 -04:00
c067beecda disable bot notification spam (#68460)
* disable bot notification spam

* add new key to botmeta sanity
2020-03-25 11:45:53 -04:00
e12cea2c7c ansible-test - fix up powershell module_util analysis for collections (#68422) 2020-03-24 23:44:50 -07:00
48bef155fd Ignore test files in new package-data sanity test (#68452) 2020-03-25 10:57:14 +10:00
a2deeb8fa2 ansible-galaxy - add download option (#67632)
* ansible-galaxy - add download option

* Fix sanity issues and added integration tests

* Fix doc suggestions

* Added --pre option
2020-03-25 08:32:43 +10:00
28f8b89760 add readme to test/support (#68450)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-24 17:15:01 -05:00
127d54b363 galaxy - preserve mode properly on artifact (#68418)
* galaxy - preserve mode properly on artifact

* Fix py2 encoding issue

* Update lib/ansible/galaxy/collection.py

Co-Authored-By: Matt Clay <matt@mystile.com>

* Use sane defaults instead of sourcing from tarfile

Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-25 08:08:23 +10:00
a9d2ceafe4 prevent ansible_facts injection (#68431)
- also only replace when needed
 - switched from replace to index
 - added test to verify bogus_facts are not accepted

CVE-2020-10684
2020-03-24 15:46:56 -04:00
97e5179745 Test installing a .deb that has deps, from a URL (#68332)
Improve coverage of the apt module and remove some incidental
coverage from incidental_lookup_rabbitmq.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-24 13:59:42 -05:00
433c98eae0 Ensure we have enough values to split (#56802)
Avoid raising an exception if pkgstr does not complains with expected
value.
2020-03-24 10:46:58 -04:00
550e021cd2 ansible_native_concat: use to_text rather than jinja2's text_type (#68038)
jinja2._compat.text_type has been removed in jinja2's master branch so
use ansible's to_text instead.
2020-03-24 12:03:31 +01:00
967e05bb23 DOC fix: typo in group addressing syntax (#67994) 2020-03-24 09:03:08 +01:00
3d6807f098 Reference directory_mode from mode description (#68202) 2020-03-24 09:00:27 +01:00
4083514d3e Fix typo and styling FAQ docs (#68212) 2020-03-24 09:00:03 +01:00
fb2a7ce923 Testing: Move from ibmcloud to ibmps 2020-03-23 23:00:06 -07:00
8d8c73729f Merge pull request #67093 from sivel/acd-content-dir
Add content dir where Ansible will look for the content provided by ACD
2020-03-23 23:30:40 +01:00
dbd8d0a492 Pull timezone's incidental file coverage into file tests (#68247)
* Remove some unreachable code in the file module

Remove some cases in file.py which are covered by conditionals a few
lines earlier. Remove the duplicate code which will never be hit.

Signed-off-by: Rick Elrod <rick@elrod.me>

* Restore incidental file coverage from timezone module

Signed-off-by: Rick Elrod <rick@elrod.me>

* Combine two conditionals, add a changelog entry

Signed-off-by: Rick Elrod <rick@elrod.me>

* Make new test syntax consistent, add two stat tests

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-23 15:28:53 -07:00
36fc5840b7 hacking - Add script to easily rebalance Shippable groups (#67976)
* hacking - Add script to easily rebalance Shippable groups

* Fix py26 compile issue

* Add option to automatically change test target aliases
2020-03-24 08:14:09 +10:00
d3ec31f8d5 Support pre-releases via new SemanticVersion (#68258)
* Support pre-releases via new SemanticVersion. Fixes #64905

* Don't treat buildmeta as prerelease

* Don't inherit from str and int

* Add helper method to try and construct a SemanticVersion from a LooseVersion

* Don't count major 0 as pre-release, it's different

* Guard against invalid or no version in LooseVersion

* return a bool

* Add integration tests for pre-release

* Fix up lingering issues with comparisons

* typo fix

* Always allow pre-releases in verify

* Move pre-release filtering into CollectionRequirement, add messaging when a collection only contains pre-releases

* Update changelog

* If explicit requirement allow pre releases

* Enable pre-releases for tar installs, and collections already installed when they are pre-releases

* Drop --pre-release alias, make arg name more clear

* Simplify code into a single line

* Remove build metadata precedence, add some comments, and is_stable helper

* Improve from_loose_version

* Increase test coverage

* linting fix

* Update changelog
2020-03-23 16:04:07 -05:00
ed9de94ad9 remove azure extras and extras_require support (#67822)
* remove azure extras and extras_require support

* Since Azure will be collectionized, the requirements will float more frequently than Ansible releases; the Azure collection needs to host the requirements now.
* Removed the dynamic extras support as well, since Azure was the only thing using it. If we need it again, it's easy to pull back from history.

* Mark azure-requirements as orhpaned.

This keeps the docs around so that existing links from old test runs remain valid.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-23 13:07:33 -07:00
f1b3e8364e Fix ansible-test PATH handling. 2020-03-23 13:06:03 -07:00
9765a80bd4 Fix ansible-test coverage analysis option usage. (#68406)
* Fix ansible-test coverage analysis option usage.

The `--input-dir` option for `coverage analyze targets generate` was being ignored.

No changelog entry since this feature has not yet been released.

* Move coverage config to fix type annotations.

Declaring the types before referencing them makes sure they're recognized by tools such as PyCharm.
2020-03-23 13:05:29 -07:00
d049888a92 Update Shippable hacking scripts default branch. 2020-03-23 13:04:56 -07:00
ee6413af47 Address fixme and handle filter/test errors for collections better (#68047)
* Address fixme and handle fitler/test errors for collections better. Fixes #66721

* Re-arrange code
2020-03-23 14:47:58 -05:00
6369591b11 Update 2.10 roadmap (#68081) 2020-03-23 13:33:44 -05:00
2d93cebb72 Update pip install instructions (#68316)
* Update pip install instructions

* Remove a few words

* We are not maintaining RPMs on releases.ansible.com any longer
2020-03-23 12:34:23 -05:00
7c9889a72b validate-modules - fix ps module delegate type inspection 2020-03-23 11:14:21 -05:00
70827c7923 Fix ansible-test import analysis warning.
Fix overlooked in https://github.com/ansible/ansible/pull/68372/
2020-03-23 11:14:21 -05:00
10fe54de58 Fix ansible-test module_utils import analysis.
Now empty `*.py` files are ignored during module_utils import analysis for change detection.
This eliminates "No imports found" warnings for files which should have no imports.
2020-03-23 11:14:21 -05:00
707eea3afa Add new options to hacking/shippable/incidental.py (#68384)
* Add `--plugin-path` option to `incidental.py`.

* Report on plugins with no test target.

* Add `--verbose` option to script.
2020-03-23 11:14:21 -05:00
649f657f91 Fix coverage script to handle ongoing runs (#68380)
* Fix get_recent_coverage_runs.py to handle ongoing runs

Signed-off-by: Rick Elrod <rick@elrod.me>

* Color code test status to make it easier to see at a glance

Signed-off-by: Rick Elrod <rick@elrod.me>

* fix lint

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-23 11:14:21 -05:00
82516a424e Fix hacking/shippable/incidental.py source search. 2020-03-23 11:14:21 -05:00
5a1b59adf9 Rename tests (#68356)
* Rename `tests` test to match plugin type.

* Rename `test_infra` test to avoid confusion.

This test target is not a test for test plugins.

* Rename `vars_prompt` test to avoid confusion.

* Update sanity ignores.
2020-03-23 11:14:21 -05:00
cf75e3f526 Fix ansible-test import analysis for collections. (#68352)
* Fix ansible-test import analysis for collections.

* Ignore plugins/module_utils/__init__.py
2020-03-23 11:14:21 -05:00
6fde9b3a23 Fix shebang sanity test module identification. 2020-03-23 11:14:21 -05:00
aaf575f0b2 Internally redirect win modules to collection name (#68317)
* Internally redirect win modules to collection name

* Added comment for how this should be fixed in a subsystem plugin

* add collection plugins for base tests
2020-03-23 11:14:21 -05:00
2c7f8bf586 Fix ansible-test windows-integration module refs. 2020-03-23 11:14:21 -05:00
a63dd92a45 Clean up network test config. 2020-03-23 11:14:21 -05:00
26da443fd2 Address compat issue for collection loading on py26 (#68219)
* Address compat issue for collection loading on py26

* Move import_module shim to utils for compat across the codebase

* Enable collection tests on py2.6

* Update changelog fragment

* Simplify code using sys.moduls

* Move compat to module_utils/compat/importlib

* Add back errantly deleted newline

* Remove hack comment

Co-Authored-By: Matt Clay <matt@mystile.com>

Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-23 11:14:21 -05:00
41f6c73be0 Update ansible-test network test provisioning. (#68220)
* Update network provisioning defaults.

* Update network test requirements.
2020-03-23 11:14:21 -05:00
5159457ba1 Fix ansible-test unit test requirements.
Requirements were incorrectly added to ansible-test in https://github.com/ansible/ansible/pull/61813

These requirements should have been placed into `test/units/requirements.txt` instead.
Now that the relevant content has been migrated out of the repository, the requirements are no longer necessary there either.

No changelog entry for this change since the original changes were not included in any release and also lacked a changelog entry.
2020-03-23 11:14:21 -05:00
2dd9c479dc Remove unnecessary unit test requirements. 2020-03-23 11:14:21 -05:00
815a36d7a9 Fix sanity test ignores. 2020-03-23 11:14:21 -05:00
7e8dae5790 Remove unused unit test files. 2020-03-23 11:14:21 -05:00
9126ac53e3 Add dynamic and static include tests. (#68200)
* Add dynamic and static include tests.

* Update task names for junit output.
2020-03-23 11:14:21 -05:00
d87d96077f Add script for getting URLs of coverage runs
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-23 11:14:21 -05:00
f18f480a3c Add hacking/shippable/incidental.py script. (#68182)
* Add hacking/shippable/incidental.py script.

* Add README.md.
2020-03-23 11:14:21 -05:00
8715bc400a Add coverage filtering to ansible-test. (#68158)
* Relocate expand_indexes so it can be reused.

* Add generate_indexes function.

* Simplify type annotations.

* Add `coverage analyze targets filter` command.

* Add changelog entry.
2020-03-23 11:14:21 -05:00
787089cba2 First attempt at making the shippable downloader recurse to pull parent results of reruns (#68154)
* First attempt at making the shippable downloader recurse to pull parent results of reruns

Signed-off-by: Rick Elrod <rick@elrod.me>

* Update message for previous run download.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-23 11:14:21 -05:00
09614d90ac Consolidate Windows tests to one group. 2020-03-23 11:14:21 -05:00
27ce6dbc1f Remove test support option from ansible-test.
This option was added to facilitate migration and is no longer needed.
2020-03-23 11:14:21 -05:00
fb3e6d6b00 Remove unused Shippable scripts. 2020-03-23 11:14:21 -05:00
50442f9fdd Fix ansible-test handling of no Python coverage. 2020-03-23 11:14:21 -05:00
99e136e153 Remove out-of-date test constraint on paramiko.
ci_complete
2020-03-23 11:14:21 -05:00
26c45b2c2f Fix docker_swarm inventory integration tests (#68126)
* copy plugins.inventory.docker_swarm in to test/support

Signed-off-by: Rick Elrod <rick@elrod.me>

* Copy over functions from module_utils.docker.common and nuke the import

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-23 11:14:21 -05:00
5e28323f32 Fix incidental test stability. (#68125) 2020-03-23 11:14:21 -05:00
69543b47c9 fix last 7 docs errors on post-migration test runs (#68115)
* address toc-tree-glob-pattern-no-match errors

* address Include-file-not-found error

* address 2.10 porting guide errors, add warning to page

* updates individual plugin type pages

* Add ignores.

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-23 11:14:21 -05:00
4cecacb915 Update Shippable test matrix. (#68117)
* Update Shippable test matrix.

* Remove unit test groups.

* Remove extra windows groups.
2020-03-23 11:14:21 -05:00
930d89dd5e core promotions 2020-03-23 11:14:21 -05:00
e0e57b4beb migration final cleanup 2020-03-23 11:14:21 -05:00
c788ee69d9 Migrated to wti.remote 2020-03-23 11:14:21 -05:00
cc2feea51b Migrated to vyos.vyos 2020-03-23 11:14:21 -05:00
d101834d28 Migrated to ibm.qradar 2020-03-23 11:14:21 -05:00
40714dfca9 Migrated to openvswitch.openvswitch 2020-03-23 11:14:21 -05:00
ab914b9ab6 Migrated to azure.azcollection 2020-03-23 11:14:21 -05:00
fe0f4750e1 Migrated to purestorage.flashblade 2020-03-23 11:14:21 -05:00
d9920706d7 Migrated to purestorage.flasharray 2020-03-23 11:14:21 -05:00
7449ec1546 Migrated to google.cloud 2020-03-23 11:14:21 -05:00
fb696bf66b Migrated to cyberark.bizdev 2020-03-23 11:14:21 -05:00
b82d084e90 Migrated to skydive.skydive 2020-03-23 11:14:21 -05:00
dd5a8dec21 Migrated to hetzner.hcloud 2020-03-23 11:14:21 -05:00
36a545553e Migrated to dellemc_networking.os6 2020-03-23 11:14:21 -05:00
bc40fe0b6f Migrated to dellemc_networking.os9 2020-03-23 11:14:21 -05:00
0b633b3703 Migrated to dellemc_networking.os10 2020-03-23 11:14:21 -05:00
d1f86d7151 Migrated to ovirt.ovirt 2020-03-23 11:14:21 -05:00
02541a15b2 Migrated to awx.awx 2020-03-23 11:14:21 -05:00
35063de590 Migrated to junipernetworks.junos 2020-03-23 11:14:21 -05:00
0c8d6f0805 Migrated to splunk.enterprise_security 2020-03-23 11:14:21 -05:00
8ee0187388 Migrated to openstack.cloud 2020-03-23 11:14:21 -05:00
6ce86295c0 Migrated to f5networks.f5_modules 2020-03-23 11:14:21 -05:00
675129ae19 Migrated to cisco.ucs 2020-03-23 11:14:21 -05:00
3149db0869 Migrated to cisco.nxos 2020-03-23 11:14:21 -05:00
ae8fb5e371 Migrated to cisco.mso 2020-03-23 11:14:21 -05:00
8a3f3e41f8 Migrated to cisco.meraki 2020-03-23 11:14:21 -05:00
5aa37733c3 Migrated to cisco.iosxr 2020-03-23 11:14:21 -05:00
7e04b5ba8b Migrated to cisco.ios 2020-03-23 11:14:21 -05:00
8a2e2e8af2 Migrated to cisco.intersight 2020-03-23 11:14:21 -05:00
ab5a3b4305 Migrated to cisco.asa 2020-03-23 11:14:21 -05:00
3f1cea89fb Migrated to cisco.aci 2020-03-23 11:14:21 -05:00
14b0ab63ac Migrated to arista.eos 2020-03-23 11:14:21 -05:00
6da1ec1d8c Migrated to check_point.mgmt 2020-03-23 11:14:21 -05:00
f0cf2c159b Migrated to netapp.ontap 2020-03-23 11:14:21 -05:00
cae9d633b0 Migrated to netapp.elementsw 2020-03-23 11:14:21 -05:00
0a9205b7c0 Migrated to netapp.aws 2020-03-23 11:14:21 -05:00
bdd82adf61 Migrated to netbox.netbox 2020-03-23 11:14:21 -05:00
0743e733bb Migrated to theforeman.foreman 2020-03-23 11:14:21 -05:00
09d8d46983 Migrated to fortinet.fortios 2020-03-23 11:14:21 -05:00
48d4e9370e Migrated to ansible.windows 2020-03-23 11:14:21 -05:00
829eb0f1d1 Migrated to ansible.posix 2020-03-23 11:14:21 -05:00
9a7a574ffc Migrated to ansible.netcommon 2020-03-23 11:14:21 -05:00
6d910034a0 Migrated to ansible.amazon 2020-03-23 11:14:21 -05:00
8f7e9f73ce Migrated to servicenow.servicenow 2020-03-23 11:14:21 -05:00
3c9bb5e442 Migrated to community.azure 2020-03-23 11:14:21 -05:00
bb3494356a Migrated to community.windows 2020-03-23 11:14:21 -05:00
40218535ee Migrated to community.vmware 2020-03-23 11:14:21 -05:00
f8c4936c10 Migrated to community.vmware_rest 2020-03-23 11:14:21 -05:00
46b865c7d6 Migrated to community.mongo 2020-03-23 11:14:21 -05:00
0ed8af9021 Migrated to community.crypto 2020-03-23 11:14:21 -05:00
fb6bc5058a Migrated to community.kubernetes 2020-03-23 11:14:21 -05:00
43f47d553e Migrated to community.grafana 2020-03-23 11:14:21 -05:00
4e488d8435 Migrated to community.general 2020-03-23 11:14:21 -05:00
58e8a91f4d Migrated to community.amazon 2020-03-23 11:14:21 -05:00
32bf1b8115 Migrated to frr.frr 2020-03-23 11:14:21 -05:00
38c652712c Migrated to containers.podman 2020-03-23 11:14:21 -05:00
13bd868f59 Added routing file 2020-03-23 11:14:21 -05:00
3a267cb2f6 Mark migrated remote 2020-03-23 11:14:21 -05:00
f9db761748 Mark migrated vyos 2020-03-23 11:14:21 -05:00
3ac3b43ef3 Mark migrated openvswitch 2020-03-23 11:14:21 -05:00
4bc38cf845 Mark migrated azcollection 2020-03-23 11:14:21 -05:00
8c9af7f760 Mark migrated flashblade 2020-03-23 11:14:21 -05:00
7c7ad4930d Mark migrated flasharray 2020-03-23 11:14:21 -05:00
65cc7ae3b3 Mark migrated cloud 2020-03-23 11:14:21 -05:00
1a00aacce2 Mark migrated bizdev 2020-03-23 11:14:21 -05:00
cf97d471dc Mark migrated skydive 2020-03-23 11:14:21 -05:00
0656a6fb2d Mark migrated hcloud 2020-03-23 11:14:21 -05:00
b1b8a5172e Mark migrated os6 2020-03-23 11:14:21 -05:00
e9f9930783 Mark migrated os9 2020-03-23 11:14:21 -05:00
a0530306ab Mark migrated os10 2020-03-23 11:14:21 -05:00
29d4513c5a Mark migrated ovirt 2020-03-23 11:14:21 -05:00
8434b55d2a Mark migrated awx 2020-03-23 11:14:21 -05:00
be982042cc Mark migrated junos 2020-03-23 11:14:21 -05:00
1d736b01bc Mark migrated cloud 2020-03-23 11:14:21 -05:00
3cf7db206b Mark migrated f5_modules 2020-03-23 11:14:21 -05:00
23b70690df Mark migrated ucs 2020-03-23 11:14:21 -05:00
d374925529 Mark migrated nxos 2020-03-23 11:14:21 -05:00
1d85b0d46f Mark migrated mso 2020-03-23 11:14:21 -05:00
330b15d8ea Mark migrated meraki 2020-03-23 11:14:21 -05:00
b8d382acf5 Mark migrated iosxr 2020-03-23 11:14:21 -05:00
99abf93a22 Mark migrated ios 2020-03-23 11:14:21 -05:00
35f3f306e1 Mark migrated intersight 2020-03-23 11:14:21 -05:00
d9f55acdd5 Mark migrated asa 2020-03-23 11:14:21 -05:00
2176b36b6f Mark migrated aci 2020-03-23 11:14:21 -05:00
708d3a7639 Mark migrated eos 2020-03-23 11:14:21 -05:00
128eff1e23 Mark migrated mgmt 2020-03-23 11:14:21 -05:00
cb396e8e43 Mark migrated ontap 2020-03-23 11:14:21 -05:00
5fea0ad10d Mark migrated elementsw 2020-03-23 11:14:21 -05:00
59289b0c26 Mark migrated aws 2020-03-23 11:14:21 -05:00
9764b658ce Mark migrated netbox 2020-03-23 11:14:21 -05:00
6c7c0ebe7d Mark migrated foreman 2020-03-23 11:14:21 -05:00
e7f03a436f Mark migrated fortios 2020-03-23 11:14:21 -05:00
cf8d4cec50 Mark migrated windows 2020-03-23 11:14:21 -05:00
a14be5560f Mark migrated posix 2020-03-23 11:14:21 -05:00
24eabf2fb9 Mark migrated netcommon 2020-03-23 11:14:21 -05:00
a20c36a304 Mark migrated amazon 2020-03-23 11:14:21 -05:00
da5e24e389 Mark migrated azure 2020-03-23 11:14:21 -05:00
daf3daf2db Mark migrated windows 2020-03-23 11:14:21 -05:00
a7d1e5934d Mark migrated vmware 2020-03-23 11:14:21 -05:00
6c0fdede6b Mark migrated vmware_rest 2020-03-23 11:14:21 -05:00
7a961ef0cc Mark migrated mongo 2020-03-23 11:14:21 -05:00
a9ae99106b Mark migrated crypto 2020-03-23 11:14:21 -05:00
37fd05b11d Mark migrated kubernetes 2020-03-23 11:14:21 -05:00
210e197b4b Mark migrated grafana 2020-03-23 11:14:21 -05:00
a2a1fde328 Mark migrated general 2020-03-23 11:14:21 -05:00
8b3f1dd5c3 Mark migrated amazon 2020-03-23 11:14:21 -05:00
f275bf0c10 Mark migrated frr 2020-03-23 11:14:21 -05:00
bb7359390a Mark migrated podman 2020-03-23 11:14:21 -05:00
e8103cd3d1 Mark migrated init 2020-03-23 11:14:21 -05:00
4e8b240b8b Intersphinx (#68090)
* try to route 2.9 porting guide links to 2.9 module docs

* refreshed existing .inv files

* better URL

* new .inv file for version-specific links

* adds targets for version-specific docs

* fixes 2.5 porting guide refs

* fixes 2.8 porting guide refs

* fixes 2.7 porting guide refs

* fixes links on ACI guide

* adds .inv files for versions 2.5 through 2.8

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-03-06 14:16:35 -08:00
d7b7ed6ba6 Remove assemble from incidental tests.
The module and action plugin are now remaining in base.
2020-03-06 13:02:54 -08:00
21dfec6c4f make test_raw use setUp instead of global definitions
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-06 09:34:21 -08:00
2c0be65f44 Relocate netbox module_utils unit tests. (#68056)
* Relocate netbox module_utils unit tests.

This puts them where migration expects them.

* Update sanity ignores.
2020-03-05 16:01:55 -08:00
65edd5e37f Split test_connection into individual files
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-03-05 14:08:38 -08:00
f9a038cbd4 win - Allow FQCN for win_command and win_shell 2020-03-05 12:14:58 -08:00
35996e57ab Add missing test support plugin. 2020-03-04 22:35:12 -08:00
46fdbbdd18 Split test_play_context_make_become_cmd into files (#68026)
* Split test_play_context_make_become_cmd into files

For NWO migration. Split the become module assertions into distinct test
files and functions. For now, this is done naively - there is probably
room to abstract these tests out and remove some of the duplication
later on.

Signed-off-by: Rick Elrod <rick@elrod.me>

* use default_exe variable instead of hardcoding /bin/bash

Signed-off-by: Rick Elrod <rick@elrod.me>

* Move become plugin tests to their proper directory and rename them accordingly

Signed-off-by: Rick Elrod <rick@elrod.me>

* Fix up fixtures and imports.

* Remove stray file.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-04 22:26:04 -08:00
f963c8ca3d Update no-unwanted-files sanity test.
This prepares for an additional path to be present after migration.
2020-03-04 14:03:35 -08:00
b26ceb57ce Remove file exists check from botmeta sanity test.
Many of the paths in botmeta will no longer exist after migration, making this check pointless.
2020-03-04 14:03:09 -08:00
4fb7e62003 Include more test support plugins. (#68015)
* Include more test support plugins.

Also add missing module_utils `__init__.py` files.

* Update sanity ignores.
2020-03-04 12:20:02 -08:00
a51266ba85 Skip removed windows CI groups after migration. 2020-03-04 12:08:05 -08:00
8339704831 Create a dedicated windows-minimal test target. (#67987)
* Create a dedicated windows-minimal test target.

The windows-minimal target is a copy of the win_ping test, taking the place of that test as the windows minimal test run on multiple python versions.

It includes a private copy of the win_ping module so it will work after migration.

This will keep tests passing during the migration prep process.

* Update sanity ignores.
2020-03-03 18:36:37 -08:00
3508e1197e Update test matrix to prepare for migration. (#67983)
* Split fallaxy tests into their own group.

This keeps expected pass/fail tests separate during migration prep.

* Move network tests down in matrix.

This will help keep pass/fail tests grouped together during migration prep.

* Group all incidental tests together.

This will keep pass/fail tests separate leading up to migration.
2020-03-03 16:23:48 -08:00
f4b923a29b Automatically enable test plugins after migration. 2020-03-03 16:23:27 -08:00
1a8fdaadc7 Fix powershell coverage path rewriting.
This applies the same rewrite logic to PowerShell coverage as is used for Python coverage.
2020-03-03 14:07:29 -08:00
d61332b50e O365 connector_card import from dict_transformations
Update office_365_connector_card.py to import snake_dict_to_camel_dict
from common.dict_transformations instead of ec2, to eliminate collection
dependency on AWS collection.
2020-03-02 14:02:46 -08:00
90dc0e904e Revert "Temporarily remove AIX from CI."
This reverts commit ce0fc4005c.
2020-03-02 12:00:12 -08:00
b241c021b7 Set fallaxy tests as a smoketest 2020-03-02 11:59:38 -08:00
7c493577ba Unit test cleanup to assist with migration. (#67920)
* Move linode unit tests to match module layout.

* Fix location of netapp module_utils unit tests.

* Update sanity ignores.
2020-03-02 10:40:34 -08:00
3383dc8c02 Disable automerge 2020-03-02 09:16:43 -08:00
d4581aca96 Update nxos_l2_interfaces merged test (#67918)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-03-02 21:44:10 +05:30
7307339a7e NX-OS ACLs module (#67558)
* Added nxos_acls module

* Adding tests

* Added integration tests

* Integration tests update

* Updated documentation

* Replaced state changes

* Added warning detection

* Added port-protocol mapping

* Added change

* Merge update changes

* Completed integration tests, rtt

* Added unit tests

* Linting

Added metaclass info

* Changed port protocol to str

* Fixed shippable errors, added examples

* Fixed type error, updated examples
2020-03-02 16:49:28 +05:30
4ef7bd4c79 ovirt: update botmeta deprecated (#67826)
* ovirt: update botmeta deprecated

* correct deprecate option

* remove duplication

* add removed_module

* add removed_module to external_provider

* add imports and metaclass

* update misc ovirt

* update sanity tests to have correct misc ovirt name

Signed-off-by: mnecas <necas.marty@gmail.com>

* remove unnecessary sanity ignore
2020-03-02 10:18:35 +00:00
48fffe167d ovirt_vm: remove deprecated warning (#67922)
* ovirt_vm: remove deprecated warning of boot params

* update docs
2020-03-02 04:45:25 -05:00
4e43bd3a4f fix nxos_l2 resource tests (#67916) 2020-03-02 15:05:26 +05:30
29978d027b Update default test container to version 1.12. 2020-03-02 00:06:47 -08:00
637d1f19d5 Skip lookup tests on Python 2.6.
Lookups are only executed on the controller and Python 2.6 is no longer supported on the controller.
2020-03-02 00:06:18 -08:00
64782dd815 Split unit tests into 3 groups. (#67917) 2020-03-01 22:57:48 -08:00
97d2d4512f Separated ps module_util test targets, added WebRequest tests (#67914)
* Separated ps module_util test targets, added WebRequest tests

* Simplify header test
2020-03-02 16:12:08 +10:00
c66ee7e994 Split C# module utils to their own test target (#67910)
* Split C# module utils to their own test target

* Fix up outstanding sanity ignores
2020-03-02 15:16:31 +10:00
f3ddf1bc95 NX-OS ACL interfaces module (#67505)
* Rebase

* Completed integration tests

* Added unit tests

* Added warning detection

* Updated tests

* Completed tests

* Linting

Linting II

YAML Lint

Linting

* Updated review changes

* Updated examples, fixed reviews

* Added failure condition

* Resolved merge conflict
2020-03-02 09:52:32 +05:30
42eba3ce25 Increase unit test timeout. 2020-03-01 19:22:56 -08:00
ebb255f0d3 Add Python 3.9 to ansible-test.
ci_complete
ci_coverage
2020-03-01 17:42:06 -08:00
e0875f2aef Skip ios_acls unit test on Python 3.5. 2020-03-01 14:07:37 -08:00
2e38f80f9e win_timezone - Allow for _dstoff timezones (#67892)
* win_timezone - Allow for _dstoff timezones

* Update win_timezone-Allow-dstoff.yml

* Added doc entry for new format

Co-authored-by: Jordan Borean <jborean93@gmail.com>
2020-03-02 08:02:38 +10:00
64a2864158 Fix ansible-test constraints for AWS. 2020-03-01 14:01:25 -08:00
8446553953 Fix ACI unit test on Python 3.8+ 2020-03-01 13:59:58 -08:00
c06f442409 Fix ansible-test import sanity test venv setup. 2020-03-01 13:59:24 -08:00
bcddf2bda9 Increase unit test coverage timeout. 2020-03-01 13:59:09 -08:00
ac8f1ad4e2 Fix AttributeError in ce_lacp on Python 3.9. 2020-03-01 13:58:42 -08:00
gp
44d8ce9b31 Remove redundant check for pyopenssl (#67901) 2020-03-01 21:32:49 +01:00
99e657162f Fix ansible-test module_utils analysis. 2020-03-01 12:29:54 -08:00
40dc851f7e Skip mongodb tests on all centos versions.
The tests were already skipped for versions 6 and 7, and are not passing on version 8.
2020-03-01 10:33:42 -08:00
0c0b3f054b Remove invalid skip aliases in tests. 2020-03-01 10:32:01 -08:00
3558651d39 nxos_lldp_interfaces resource module (#67802)
* Added nxos_lldp_interfaces module

* Linting

* Added RTT, resolved shippable errors

* Added new states

* New states edit

* Updated states

* Updated tests

* Show all interfaces in facts

* Test changes

* Added unit tests

* Linting

* Handled portchannel failing condition
2020-03-01 20:52:25 +05:30
4b718ed58b The different MongoDB test setups collide. (#67895)
ci_complete
2020-03-01 15:26:04 +01:00
b3381704e3 Misc documentation fixes (#67863)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-01 10:44:53 +01:00
8f9f8ec594 VyOS: firewall_interfaces module added (#67254)
* firewall_interfaces module added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* delete opr updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* tests updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* ci failure fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-03-01 11:02:22 +05:30
7765870421 NXOS: Manually Configurable Route-Target (#52650)
* Renamed auto evpn test

* Made sure that the current module is idempotent with additional tests

* Added tests for route-target import function

* Added tests for route-target export function

* Added tests for route-target both function

* PEP8 syntax fix

* Added route-target import & export function

* Added required 'version_added: "2.8"' in the documentation

* Updated documentation of new route-target options

* Added a test to make sure that in case of `state=absent` on the vrf
level the route-target options are ignored.

* Specified that the route-target options are ignored in case of
`state=absent'.

* Updated the doc to the correct format (using 'C()')

* Changed the VRF Route Target Syntax

Instead of using three different params (route_target_import,
route_target_export, route_target_both) the module uses now only one
param (route_targets) and the direction is specified for each of the
route targets.

Example:
route_targets:
[{rt: '...', direction: '{import|export|both}', state: '...'}]

* Updated Description and Examples to reflect new params

* Updated "version_added"

* pep8 fixes

* If rt['direction'] is not definied, we assume default 'both' and run
the same routine

* Added test with default direction for route-targets

* Documentation fixes
2020-03-01 10:39:04 +05:30
db2d5b09ef ldap_attr: fix small bug (using wrong variable) (#67887)
Changed self.name to name in ldap_attr module
2020-03-01 09:17:44 +05:30
70fc69c852 Fix vcenter requirements. 2020-02-29 13:49:26 -08:00
9dacbea5ef Update BOTMETA.yml migrated_to for Netbox components (#67586)
* Update BOTMETA.yml to show they have been migrated to netbox_community.ansible_modules

* Update BOTMETA.yml to proper format

* Expanded from dir to each module migrated_to

* Fixed test issues

* Updated to new FQCN
2020-02-29 16:43:29 +00:00
0bb2d67562 add new module mongodb_info (#67846)
* add new module mongodb_info

* fix doc and examples

* add GPL info

* use LooseVersion in the function doc string
2020-02-29 15:37:52 +01:00
35fd86c6bc acme_* modules: adjust documentation to reference RFCs 8737 and 8738 instead of the drafts (#67881)
* Adjust documentation to reference RFCs 8737 and 8738 instead of the drafts.

* More references.
2020-02-29 14:20:14 +01:00
ce0fc4005c Temporarily remove AIX from CI. 2020-02-28 21:07:47 -08:00
7c8b046b5f Fourth batch of incidental integration tests. (#67873)
* Copy in incidental posix tests.

* Update incidental test aliases.

* Update target names.

* Add support plugins.

* Fix paths.

* Update ignores.

* Update integration-aliases sanity test.

* Add incidental tests to CI.
2020-02-28 20:37:50 -08:00
04666c9fa1 Clean up unit tests to assist with migration. (#67875)
* Split out cache plugin unit tests.

* Rename unit tests to match code under test.

* Relocate unit test code to match code under test.

* Another rename.

* Update sanity ignores.
2020-02-28 20:29:41 -08:00
3c9747ba2f Remove unused json import (#67876)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-28 21:31:52 -05:00
fbcef7e586 cloudwatchlogs_log_group.py: retention handling improvement (#48004)
* cloudwatchlogs_log_group.py: retention handling improvement

* add purge_retention_policy to cloudwatchlogs_log_group.py

* update version added for purge_retention_policy feature

* make retention and purge_retention_policy mutually exclusive

* make purge_retention_policy and overwrite mutually exclusive

* changelog

Co-authored-by: Sloane Hertel <shertel@redhat.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-28 20:33:30 -05:00
26129fcb80 ansible-galaxy - optimise some paths and use fake galaxy int tests (#67685)
* ansible-galaxy - optimise some paths and use fake galaxy int tests

* Added init, built, and publish tests

* Test against both mocked Galaxy and AH server

* Finish off writing the install tests

* Fix up broken tests

* Rename test target and add migrated tests

* Use cloud provider for Galaxy implementation

* Added blank static config

* Use correct alias group

* Set release version and fix copy typo

* Remove reset step as it is no longer needed

* Use sane env var names for test container name
2020-02-29 08:59:09 +10:00
d30c57ab22 win_unzip - normalize and compare paths to prevent path traversal (#67799)
* Actually inspect the paths and prevent escape
* Add integration tests
* Generate zip files for use in integration test
* Adjust error message
2020-02-28 17:56:21 -05:00
8ab304af44 implement support for hidden/protected variables gitlab_project_variable (#67461)
* #66135 implement support for hidden/protected variables

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* update example value

* fix pep

* fix pep8

* fix tailing whitespace

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* fix recommendations and request changes

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* fix undefine module

* add missing import

* expand documentation

* add idempotent check

* add changelog

* Update changelogs/fragments/67461-gitlab-project-variable-masked-protected.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* check also for integer_types

* expand integration test and check also for float type

* append documentation

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-28 23:17:03 +01:00
7a42354021 Switch to using FreeBSD 12.1 (#67659) 2020-02-28 17:12:55 -05:00
e0eee3c37e Run Powershell modules on windows container via docker connection (#67832)
* Run modules on windows container

This provides an ability to run Powershell modules on windows container via docker connection. Otherwise, Ansible tries to run python modules on windows containers and fails.

* Removing whitespace in the blank lines

* Adding a changelog fragment
2020-02-28 23:05:53 +01:00
09fb563317 fix docker_login doc example (#67852) 2020-02-28 15:37:50 -05:00
a76d78f691 Fixed incorrect request body when creating VM snapshot with disks (#67815)
* Fixed incorrect request body when creating VM snapshot with disks

* fixed changlog file extension
2020-02-28 12:32:14 -05:00
b84dc2f2a6 Add integration test for regex_search filter. 2020-02-28 08:38:50 -08:00
9392912608 Resource module for IOS ACL (#66629)
* fix ios_acl
2020-02-28 22:06:38 +05:30
32a76f0aa1 Add 'OperationAborted' to the list of S3 error codes where we'll retry (#67811) 2020-02-28 11:26:26 -05:00
dbd86be2d6 Update vmware_guest_info.py (#67853)
forgotten doc replacement of vmware_guest_facts to vmware_guest_info
2020-02-28 21:23:35 +05:30
b437167671 line indentation issue in postgresql_set (#67859)
Fixed indentation issue with the `register` for the example task in postgresql_set module.
2020-02-28 21:22:30 +05:30
ed37efb217 "Fix" test_get_bin_path by changing mock order (#67730)
pytest-mock 2.0.0, when run locally, gets grumpy when os.path.exists is
messed with and then another method is patched afterwards. Likely
something in the pytest-mock chain uses os.path.exists internally, and
since pytest-mock prohibits context-specific patching, there's not a
good solution. For now, just patch os.path.exists last.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-02-28 10:39:27 -05:00
735ea43aeb hostname Add cloudlinuxserver value to hostname.py (#66911) 2020-02-28 10:26:07 -05:00
554676da5e git - use remote_tmp directory (#66762)
* fix:git module ignores remote_tmp

* WIP: added the changelog fragment and edit comment

* Revert "WIP: added the changelog fragment and edit comment"

This reverts commit 2f739df619.

* WIP: added changelog fragments

* WIP: added changelog fragment

* WIP: fixed spelling in changelog fragment
2020-02-28 10:19:47 -05:00
4c0eb4396b Resource module for IOS static routes (#64632)
* ios_static_routes
2020-02-28 18:29:17 +05:30
6629b9feef Resource module for IOS ACL_Interfaces (#66746)
* acl_interfaces
2020-02-28 16:29:18 +05:30
08fc9f63b6 Add x509_crl_info module (#67539)
* Add x509_crl_info module.

* Apply suggestions from code review

Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2020-02-28 08:00:47 +01:00
21475aa83b Test system users and groups. 2020-02-27 21:45:18 -08:00
b6c2056ea2 mongodb_user: fix doc formatting (#67763)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-28 09:04:27 +05:30
0cd22abe8c mongodb: Fix documentation (#67806)
* Added correct datatypes of parameter
* Fixed doc formatting

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-28 08:51:06 +05:30
8e31a2fe40 Add lookup_dict integration test. (#67836)
* Add lookup_dict integration test.

* Skip test on python 2.6.
2020-02-27 18:45:37 -08:00
2a920cf228 Fix flake8 errors for checkpoint modules (#67827)
We caught these in our checkpoint.checkpoint collection testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-27 21:15:32 -05:00
f735fd672a Third batch of incidental integration tests. (#67830)
* Copy in incidental windows tests.

* Update incidental test aliases.

* Add support plugins.

* Update target references.

* Update sanity ignores.

* Update integration-aliases test.

* Add to CI.
2020-02-27 16:05:47 -08:00
da30e6d2e1 sqs_queue - Move to boto3 and add support for various extra features (#66795)
* reworked sqs_queue

* Switch default purge_tags behaviour to false.

This matches the behaviour of ec2_tag and ecs_tag.

* Minor lint / review fixups

* Add missing AWS IAM policy for SQS tests

* Move integration tests to using module_defaults: group/aws:...

* add changelog

* Break out the 'compatability' map from our spec definition (gets flagged by the schema validation)

* Tweaks based on review

* add basic examples

* Lint fixups

* Switch out NonExistentQueue logic so it's easier to follow

* Reorder name argument options for consistency

Co-authored-by: Dennis Podkovyrin <dennis.podkovyrin@gmail.com>
2020-02-27 15:26:20 -07:00
75b088d6a9 Remove extra Ansible in network automation section header (#67828) 2020-02-27 15:28:34 -06:00
92571e5448 Update blockinfile.py to change dest: to path: (#67824) 2020-02-27 16:13:25 -05:00
d7546ba336 Fix PostgreSQL tests for newer FreeBSD versions (#67658)
Use PostgreSQL 9.5 on FreeBSD 12.0, and PostgreSQL 11 on FreeBSD 12.1 and 11.3 due to the Python packages having a dependency on that version of PostgreSQL and automatically uninstalling PostgreSQL 9.5.

* Use separate PostgreSQL versions for 12.0 and 12.1
2020-02-27 15:01:15 -05:00
cfe96b2092 add module cloudformation_exports (#67349)
* add module cloudformation_exports

* add RETURN, add aliases group, clean up yaml

* update return value. uncomment security_token. remove cloudformation shortcut

* fix typo

* try to delete test stack

* rename stack

* add cleanup and assert. try to set stack name with variable

* create s3 bucket instead

* set bucket name

* add tests, remove unsed key and import, add iam role, add to module_defaults

* import exceptions, fix assert syntax

* fix assert

* Update test/integration/targets/cloudformation_exports/tasks/main.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* fix export name

* renamed module

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-27 11:39:59 -07:00
652346ad5d Allow passing through of (almost) all params available … (#58118)
* Allow passing through of (almost) all params available on boto methods in aws_api_gateway

* Linting and docs fixes

* Refactored method signature of create_deployment() to use keyword args instead of named args

* Updated version_added flags to 2.10

* Cleanup and improve aws_api__gateway integration test play. Also included new params into test.

* Fixed RETURN docs and some ttests

* Completed RETURN docs and made integration tests match

* Fixed variable names in test and YAML syntax in docs

* Comment out critical sections of integration test

* Fixed update test after figuring out what the error message means. Also updated error message to be more descriptive.

* Fixed test assertion

* Update docs and make tests reflect that endpoint type wont be changed on updates

* Syntax fix

* Add changelog fragment

* Improve aws_api_gateway docs, fix typos.

* Quote doc lines with colon
2020-02-27 10:44:20 -07:00
a81ab5fe40 mysql_db: add possibility to make dump with --no-create-db option (#67767)
* mysql_db: add possibility to make dump with --no-create-db option

* add changelog fragment

* fix
2020-02-27 13:51:23 +00:00
ed306c7991 influxdb: Fix documentation (#67807)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-27 13:43:16 +01:00
08821709ef Fix invalid botmeta entries (#67785)
Correct paths
Remove trailing whitespace
2020-02-27 11:49:45 +00:00
3405ee1c01 Add iosxr_static_routes RM (#65181)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-27 14:31:00 +05:30
9afe87139a Add win_psrepository_info module (#67594)
* Add win_psrepository_info module

* Change return type

* Add tests for win_psrepository_info
2020-02-27 16:05:37 +10:00
10feb24870 mongodb_shard: fix doc formatting (#67750) 2020-02-27 08:04:12 +05:30
d5c17118ed s3_bucket - cleanup and test stabilisation. (#66778)
* AnsibleAWSModule related cleanup - s3_bucket

* Add extra information to s3_bucket timeout failures, it's possible the comparisons are doing something weird...

* Move Bucket Encryption boto support logic into the pre-flight checks

* Use the built in required_by logic

* Rework s3_bucket integration tests

* Add a retry around put_bucket_encryption

s3_client.put_bucket_encryption is occasionally dropped on the floor
by Amazon add some logic to retry s3_client.put_bucket_encryption call

* Catch OperationAborted and retry, it is caused by a conflicting change
still being in progress.   (For example an Encryption setting applying)

* Make sure we don't explode if the botocore version's too old

* Review tweaks
2020-02-26 16:54:39 -07:00
9463d28967 read enabled_key_rotation status also in aws_kms_info (#67770)
* read enabled_key_rotation status

* add changelog

* use AWSRetry decorator to prevent api rate limits

* fix pip8
2020-02-26 16:51:04 -07:00
454b043c13 Reflect changed JSON structure than zabbix version 4.4 or more to zabbix_user
add fragments file

Fix several pointed out

https://github.com/ansible/ansible/pull/67475#discussion_r380528775
https://github.com/ansible/ansible/pull/67475#discussion_r380532685

Enable integration test
2020-02-26 15:40:17 -08:00
5550fc442b Mark aws_acm unstable and connection_aws_ssm disabled (#67787)
* Mark aws_acm and connection_aws_ssm unstable

CI failures in https://app.shippable.com/github/ansible/ansible/runs/160867/133/tests
and https://app.shippable.com/github/ansible/ansible/runs/160867/129/tests

* Disabling concection_aws_ssm, it's repeatedly failing on this PR
https://app.shippable.com/github/ansible/ansible/runs/160888/133/tests
2020-02-26 14:56:05 -08:00
357ae7ec0e Remove unused import from frr cli plugin (#67790)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-26 16:48:07 -05:00
dd53c104d7 postgresql_info: move subscription info to corresponding database dict (#67772) 2020-02-26 22:25:16 +01:00
b68e55da26 Remove test/legacy/ directory. (#67786)
* Remove `test/legacy/` directory.

* Remove references to `test/legacy/` directory.

* Update the remaining valid legacy reference.

* Remove outdated legacy references.
2020-02-26 11:48:30 -08:00
a6f24f8aa9 Migrate ovirt to collection - add botmeta (#67729)
* Add ovirt migrated_to to botmeta

* list all ovirt modules

* remove .idea

* remove links
2020-02-26 18:35:22 +00:00
d8c5c6eb9d Add Switchport mode support in newly introduced *_l2_interfaces resource module (#67456)
* fixes 65032
2020-02-26 23:49:00 +05:30
a18d3257e9 Add more bot notifications for test related paths. 2020-02-26 08:50:03 -08:00
a1f26af712 ec2_instance - update tests related to termination protection (#65035)
* ec2_instance - update tests related to termination protection

* add more test cases for termination protection
2020-02-26 11:08:49 -05:00
a4da73e961 misc typo fixes (#67775)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-26 10:58:39 -05:00
9c221e2bfa Remove unused import from test_eos_static_routes.py (#67776)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-26 09:27:40 -05:00
829a29ef18 Fix to be support for zabbix 4.4 or more and python3 (#67693)
add fragments file
2020-02-26 07:48:29 -05:00
305789144a Fix to remove unnecessary duplicate line (#67761) 2020-02-26 07:48:15 -05:00
e3591223a0 Second batch of incidental integration tests. (#67765)
* Update incidental test aliases.

* Rewrite target references for renamed targets.

* Add incidental tests to CI.

* Update sanity tests for incidental cloud tests.

* Initial copy of incidental tests.

* Copy contrib files into test.

* Update paths in test.

* Add support plugins.

* Update plugin to work around missing deps.

* Update sanity ignores.

* Fix matrix entries.

* Remove debug echo.
2020-02-25 23:18:50 -08:00
a19ae28326 Test the delay option in wait_for_connection. 2020-02-25 19:27:18 -08:00
6e1a59174a Clean up CONDITIONAL_BARE_VARS warning. Fixes #67735 (#67751) 2020-02-25 16:36:01 -06:00
370f788731 adhoc: Load callbacks before sending v2_playbook_on_start (#67673) 2020-02-25 17:00:08 -05:00
4c016e64dd Update 'server' doc in nsupdate module to avoid DNS names (#67597) 2020-02-25 16:07:55 -05:00
e9f22a2269 win_dns_record: Improve examples documentation (#67744) 2020-02-25 16:03:03 -05:00
1b5c69deef mysql_info: remove irrelevant comment (#67753) 2020-02-25 16:00:41 -05:00
9d455bed7b aws_acm Add additional AWSRetry error codes (#67671)
* Cleanup tests

* Auto-Retry on ResourceNotFound and RequestInProgress exceptions

* Use AnsibleModule options for required_if logic

* changelog

* Remove (now) duplicate RequestInProgressException catching

* Allow a single retry when attempting to fetch the information about a cert directly after deleting it.

There is a small chance that it goes away while we pull the details.
2020-02-25 13:48:26 -07:00
99f6f0c832 add key rotation option to aws_kms (#67651)
* add key rotation option

* add changelog fragment

* provide version added as string

* change changelog to minor_changes

* Update changelogs/fragments/67651-aws-kms-key-rotation.yml

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/aws_kms.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* prevent key upgrade if key rotation was enabled manually. In that case, the key rotation would be disabled, if not mentioned in the playbook

* Update lib/ansible/modules/cloud/amazon/aws_kms.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/aws_kms.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/aws_kms.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-25 13:30:45 -07:00
f0159b8870 postgresql_info: add getting publication statistics (#67614)
* postgresql_info: add getting publication statistics

* add changelog

* fix

* fix server_version check
2020-02-25 20:58:23 +01:00
b9a315a2c0 mysql_db: add dump_extra_args parameter (#67747)
* mysql_db: add dump_extra_args parameter

* add changelog fragment
2020-02-25 20:48:32 +01:00
848aa06cac Remove unused variables in collection API (#67724)
Remove unused variables in _download_file API

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-25 12:30:53 -05:00
8eb00dd14c Fix inline vaults for plugins in ensure_type (#67492)
* Fix implicit string - only looked right because of the vault __repr__
* Add tests for strings and implicit strings
2020-02-25 10:42:31 -05:00
b950d18912 Add an example of specifying a specific commit hash. (#67722) 2020-02-25 10:40:12 -05:00
9ea5bb3364 strip spaces for each value in host list lists (#67701) 2020-02-25 09:16:27 -05:00
726d6455d8 eos static_routes module added (#65480)
* Adding files for RM static_routes

* Added Integration tests

* Added Unit testcases

* Addressed review comments

* corrected lint errors

* corrected documentation errors

* Lint errors

* corrected test/sanity

* corrected documentation for deprecation

* corrected case sensitivity

* Again Documentation eroor

* Lint errors again

* corrected deprecated module in ignoretxt

* added new gethered,rendered,parsed state checks to unit test

* New code broke the old flow-fixed

* Lint errs

* Added check for running_config

* Add rtt testcase

* Fixed unit tcs

* lint errors

* lint errors

* Modified replaced operation behavior

* updated documentation and tests for delete opration

* fixed shippable errors

* review comments and flake8 error fix

* syntax errors fixed
2020-02-25 07:50:27 -05:00
6f0924a892 Remove unnecessary indent (#67728)
total_size fact is populated if schema is not specified in
postgresql_user_obj_stat_info module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-25 14:12:56 +05:30
4e571248a9 First batch of incidental integration tests. (#67717)
* Initial copy of incidental network tests.

* Update incidental test aliases.

* Add incidental tests to CI.

* Rewrite module references in tests.

This should not be necessary once module redirection is supported.

* Rewrite target references for renamed targets.

* Add support collections for incidental tests.

* Add ignores for test support code.

* Remove echo used for debugging.
2020-02-24 17:31:14 -08:00
81ffc315a4 Remove unused imports for iosxr_acls (#67711)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 17:47:35 -05:00
8fbec3cdeb add download tarball option (#67548) 2020-02-24 16:30:34 -06:00
fc69f63cec Remove unused imports in eos_modules unittest (#67709)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 16:37:19 -05:00
bfea5cfca0 Remove unused imports from vyos_firewall_global (#67710)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 15:26:42 -05:00
d317cc71c7 s3_bucket: accept NetApp StorageGRID create_bucket response. (#67462) 2020-02-24 13:00:38 -07:00
c5ec0fcb34 Setup documentation - windows custom fact variable name (#67690) 2020-02-24 14:58:18 -05:00
4b382b78d0 ovirt_vm: add cpu_pinning example (#67612) 2020-02-24 14:41:50 -05:00
6c70959131 Update example requirements file docs (#67626)
Use "name" when possible rather than "src" to make the examples
of roles and collections in a single requirements files more
coherenant. Fundamentally, roles and collections are completely different.
But we can make the requiremets file easier to read by unifying the
format as much as possible.
2020-02-24 14:37:10 -05:00
e2f1b57299 adds missing alias to win_regedit documentation (#67662) 2020-02-24 14:35:21 -05:00
75191c1484 fixes link, makes intrapage TOC local (#67664) 2020-02-24 14:29:22 -05:00
febbb66d71 Change package_license to accept_license (#67676) 2020-02-24 14:28:11 -05:00
a173ce9630 change intelligence_pack to intelligence_packs (#67686) 2020-02-24 14:25:23 -05:00
f520238d60 Migrate a batch of AWS modules to AnsibleAWSModule (1) (#67191)
* Move various Amazon modules over to AnsibleAWSModule

* Remove HAS_BOTO3 logic, it's handled by AnsibleAWSModule

* Simplify argument_spec handling ec2_argument_spec is automatically added by AnsibleAWSModule

* Cleanup boto3 error handling using fail_json_aws

* Migrate simple cases from boto3_conn to module.client()

* Migrate batch modules over to module.client()

* Migrate EFS module over to module.client()

* Comment cleanup

* Use deprecated_aliases in argument_spec rather than custom code

* Cleanup unused imports

* Make use of module.region

* Deprecate batch.AWSConnection it's now dead code
2020-02-24 14:01:14 -05:00
7b792e0a53 Skip lookup_hashi_vault test for Python 2.6 (#67657) 2020-02-24 14:00:59 -05:00
96244c4cde Make AWS test plugin to refer to the aws-permissions-for-integration-tests (#67665)
Make AWS test plugin to refer to the aws-permissions-for-integration-tests section of the AWS devel docs now that we have them, rather than suggesting to flag down specific users.
2020-02-24 11:56:58 -07:00
bd26b6c0b4 updated single quote handling to not strip and error on odd number (#67500)
Fixes #67274
2020-02-24 13:45:19 -05:00
eab914426b Specify display width and no color in test_execute_list_collection_no_valid_paths (#67680)
This ensures the test passes regardless of the test environment.
Previously, it would pass in some environments but fail locally
in other environments, due to the width being calculated as
different or support for color not being consistently detected.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-02-24 13:43:32 -05:00
32a71221e8 Fix wakeonlan test for newer FreeBSD (#67656) 2020-02-24 13:40:59 -05:00
9b91068e23 Remove unused DCI script 2020-02-24 09:41:37 -08:00
d283126c31 eos_acls : Add eos acls resource module (#66308)
* Adding files for RM static_routes

* Added Integration tests

* Added Unit testcases

* Addressed review comments

* corrected lint errors

* corrected documentation errors

* Lint errors

* corrected test/sanity

* corrected documentation for deprecation

* corrected case sensitivity

* Again Documentation eroor

* Lint errors again

* corrected deprecated module in ignoretxt

* added new gethered,rendered,parsed state checks to unit test

* New code broke the old flow-fixed

* Lint errs

* Added check for running_config

* eos_acls resource module added

* Corrected errors

* corrected documentation errors

* corrected typo

* Testcases in progress

* Integration tests in progress

* Integration tests

* Added Intergration tcs

* Corrected pylint errors

* Resolving issues due to rebase

* Corrected Typo

* more pylint errors

* more pylint errors

* more pylint errors

* Documentation

* Documentation

* More lint errors

* Fixed Indentation

* Indentation issues - not getting fixed

* Indentation issues - not getting fixed

* Added rtt testcase

* Corrected whitespaces

* addressed review comments

* moved integration tests to common - to support eapi tests

* modification for merge update

* indentation errors

* added line key

* Fixing shippable errors

* fixing doc errors

* fixing doc errors

* fixing doc errors

* fixing doc errors

* fixing indentation

* modified replaced operation

* rebase issue fixed

* Corrected typo

* review comments and flake8 error fixed
2020-02-24 12:27:11 -05:00
74e948e6e4 Fix flake8 errors with eos_acl_interfaces (#67695)
Theses were exposed by our collections testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 09:47:43 -05:00
059a193dff lib/ansible/plugins/inventory/ini.py: added spacing for error message (#67361)
Signed-off-by: James McClune <falcon78921@users.noreply.github.com>
2020-02-24 09:26:48 -05:00
fc05c50b7f VyOS: firewall global module added (#66800)
* firewall global module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* group member handling updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-24 09:03:02 -05:00
b818436c5f Add iosxr_acls RM (#66207)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-24 18:34:27 +05:30
3acd8f6f7f Fix to - nxos_lag_interfaces not idempotent (#67359)
* Added fix for bug # 54400

* Adding files for RM static_routes

* Added Integration tests

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* Adding files for RM static_routes

* Added Integration tests

* Corrected lint errors

* Added fix for bug # 54400

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* Fix to #67169

* corrected rebase spillover

* indentation errors fixed

* modified integration testcase
2020-02-24 07:57:11 -05:00
f292f21d86 Fixes nxos_l2_interfaces module traceback if allowed vlans are not preconfigured (#67457)
* fixes 67455

* fix review
2020-02-24 17:44:21 +05:30
0d72d2d4d2 ovirt_vm: correct numa nodes (#67611)
* init commit

* update docs

* update numa function name

* correct whitespaces
2020-02-24 04:20:46 -05:00
feeb380649 scaleway_compute: check image on get instead of list (#67655)
* fix scaleway_compute: check image on get instead of list
* add changelog

Signed-off-by: Alexis Camilleri <acamilleri@scaleway.com>
2020-02-24 11:08:14 +05:30
2dadc259d3 Split hcloud tests into two CI groups. (#67683)
* Split hcloud tests into two CI groups.

This will hopefully resolve CI failures when running with code coverage.

* Fix smoketest logic.
2020-02-23 21:17:03 -08:00
4a885072af Split vyos tests to avoid timeouts with coverage. 2020-02-23 20:43:05 -08:00
a64b562071 Fix up network testing on Shippable. (#67678)
This prepares for code coverage collection for initial setup of incidental test coverage.
2020-02-23 18:37:26 -08:00
dbaa421f9d Some cloudengine modules miss "import __future__" and "mateclass", update to add them. (#67634)
* update doc missing future & mateclass.

* update ignore.txt.

* add a changelog.

* update changelog.
2020-02-22 17:35:18 +01:00
6936e7b698 Handle NoneType error in vmware_host_service_info (#67641)
Handle NoneType error occured due to accessing host system service info
in vmware_host_service_info module.

Fixes: #67615

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-22 21:46:18 +05:30
482885e0c8 Fix network setup for collections in ansible-test. 2020-02-21 18:31:40 -08:00
00b70bf36a Show field instead of value (#59926)
* Show argument name vs value on failed conversion

  generally more useful to user as they might set values indirectly

* clog
2020-02-21 17:01:09 -05:00
542d1b98ff Support private test plugins in ansible-test. (#67660)
* Support private test plugins in ansible-test.

This feature is exclusively used for testing Ansible itself and is not available to collections.

Content in the newly supported directories will be added in follow-up PRs.

* Add new directory to path classification.

* Support new paths in shebang test.

* Add new directory to manifest.
2020-02-21 13:34:21 -08:00
79dfae9624 copy: ensure _original_basename is set: fixes #47050 (#47238)
* fixed #47050

* added changelog fragment

* added quick and basic test

* Revert "added quick and basic test"

This reverts commit 75f4141656.

* added better tests

* now also creating files to copy on the remote

* removed tests for recursive copying which is not supported by remote_src
2020-02-21 12:55:12 -05:00
d74ed41a4c AnsibleAWSModule add 'region' method (#66988)
* Add get_aws_region to module_utils.ec2 and region to AnsibleAWSModule

* Add example use

* Add changelog
2020-02-21 11:58:02 -05:00
34800fe027 Test: Bump Tower version to latest release 2020-02-21 08:34:54 -08:00
f70dc261cc fix(scaleway): use jsonify for application/json content-type only (#66957)
* fix(scaleway): use jsonify for application/json content-type

* add changelog
2020-02-21 17:14:22 +01:00
600d6278f9 eos : Add resource module eos_acl_interfaces (#67137)
* Added fix for bug # 54400

* Adding files for RM static_routes

* Added Integration tests

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* Adding files for RM static_routes

* Added Integration tests

* Corrected lint errors

* Added fix for bug # 54400

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* acl_interfaces

* acl_interfaces in progress

* Adding unit testcases

* Addresses Paul's review comments

* worked on shippable errors

* indentation errors

* Modified unit tests

* indent issues

* indent issues

* eos specfic changes

* making the integration tcs skip the zuul run

* addressed review comments

* added required:True documentaiton
2020-02-21 10:05:16 -05:00
195ded6527 Update AWS modules that use to implicitly retry on NotFound errors (#67369)
* Update AWS modules that expect to retry on exception codes that match the regex '^\w+.NotFound'

Modules should intentionally define any extra error codes

Use a waiter for ec2_vpc_igw after creating an internet gateway instead of retrying on InvalidInternetGatewayID.NotFound
2020-02-21 08:17:24 -05:00
ad8df69b58 docs/docsite/rst/: fix typos (#67645) 2020-02-21 10:57:07 +00:00
244277addd dev_guide/developing_modules_best_practices.rst: fix typo (#67639) 2020-02-21 10:56:35 +00:00
05a3192eb7 user_guide/intro_adhoc.rst: fix typo (#67644) 2020-02-21 10:56:25 +00:00
907c98ebcd /docs/docsite/rst/dev_guide: fix typos (#67643) 2020-02-21 10:56:12 +00:00
347e19178d Some cloudengine modules miss "import __future__" and "mateclass", update to add them. (#67635)
* update doc, missing future & metaclass type.

* update ignore.txt

* add a changelog.

* update changelog.

* rename changelog.

* update changelog.
2020-02-21 11:54:45 +01:00
61f2ae1c26 Fix runas as collection become plugin (#67638) 2020-02-21 19:23:53 +10:00
021ba057ab sns_topic ensure "changed" works as expected when managing delivery policies (#60944)
* sns_topic: (integration tests) Move the tests over to using module defaults

* sns_topic: (integration tests) Add test for behaviour of changed when using delivery_policy

* sns_topic: ensure "changed" behaves properly when managing delivery policies

- a delivery_policy isn't an IAM policy, so compare_policies didn't cope with it
- AWS automatically adds an additional option when you set an HTTP delivery
  policy

* Parse the delivery policies so we can test the changes properly
2020-02-20 17:15:27 -07:00
9c6495d4d4 elb_target / elb_target_info : Integration test fixups (#61256)
* Update AWS policy to enable management of TargetGroups

* elb_target: (integration tests) migrate to using module_defaults

* elb_target: (integration tests) lookup the AMI by name rather than hard coding AMI IDs

* elb_target_info: (integration tests) finish rename of integration test role

* elb_target: (integration tests) rename various resources to consistently use {{ resource_prefix }}

* elb_target_info: (integration tests) Migrate to using module_defaults

* elb_target_info: (integration tests) Lookup AMI by name rather than hard coding AMI IDs

* Apply suggestions from code review

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* elb_target: (integration tests) Remove the 'unsupported' alias

* Try bumping up the timeout

* Rules don't permit 'shippable' (resource_prefix uses this when run in shippable)

* Try bumping up more timeouts :/

* Avoid double evaluation of target_health assertion

* Simplify target_type usage a little (rather than constantly performing a lookup)

* mark elb_target tests 'unstable' for now, they're slow

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-20 17:13:09 -07:00
65646179f1 Fix become for network_cli in collections. 2020-02-20 15:13:39 -08:00
854925b072 Add changelog 2020-02-20 17:44:40 -05:00
1c15a485c2 Allow SSH synchronization between Docker containers 2020-02-20 17:44:40 -05:00
fb87f6f502 Purestorage content migration botmeta (#67189)
* Adding content migration for purestorage flasharray modules

* Adding content migration for purestorage flashblade modules
2020-02-20 14:12:12 -05:00
574033cebb Spelling fix, win_chocolatey_facts.py (#67617)
Spelling fix - "path" not "pth"
2020-02-20 11:33:42 -06:00
cffead4631 Do not error if collection specified null dependencies (#67575) 2020-02-20 11:23:23 -05:00
2de4e55650 Remove unused import for six in ipaddr filter (#67595)
This was caught in our ansible.netcommon collection testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-20 10:58:47 -05:00
335108ac62 Refactor aws_kms to bring down the complexity score (#66037)
* Remove dead code key_matches_filter/key_matches_filters

* Fail more cleanly when we don't recognise the 'shape' of KMS policy

* Refactor aws_kms to bring down the complexity

* Minor docs tweaks

* Changelog fragment

* Fixups from review
2020-02-20 09:35:41 -05:00
0dc08f6b97 postgresql_info: add subscription info (#67464)
* postgresql_info: add subscription info

* add changelog
2020-02-20 09:59:45 +01:00
23995fef48 Add create_option to disk definitions (#62357)
Add create_option parameter to disk definitions to control whether disks
are created from the base image or are new disks being added to the VMs.
Currently, custom images with data disks defined in the image cannot be
used to launch VMs unless data disk definitions are excluded.  This
prevents the data disks from being modified/extended (like selecting a
different SKU or making the data disks bigger).  Exposing this option
allows VMSS VMs to be created with base images that have data disks
while extending their definitions.

Addresses #61804
2020-02-20 02:19:48 -05:00
36def8bf03 Use Ansible to load ps module utils in arg spec checker (#67596)
* Use Ansible to load ps module utils in arg spec checker

* Added changelog and note
2020-02-20 14:32:21 +10:00
b54e64bbc9 Remove unused import for iosxr acl_interfaces (#67587)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-19 20:10:25 -05:00
ec967bce76 Fix typo with devel warning config option (#67590) 2020-02-19 18:24:05 -05:00
c520d70bf4 Templating: make sure only one variable results are cached (#67429)
* Make sure only one variable results are cached.

* Add changelog.

* Add test.
2020-02-19 18:04:01 -05:00
c61c0f7ad5 Add warning when running devel (#67502)
* Add warning when running devel. Addresses #67362

* Add config entry to disable devel warning, so it doesn't impact CI

* Update warning about using devel
2020-02-19 15:17:42 -06:00
3aae025cce cloudfront_distribution: Always add field_level_encryption_id to cache behaviour (#61271)
* cloudfront_distribution: (integration tests) Migrate to using module_defaults

* cloudfront_distribution: (integration tests) Use the ID rather than the alias

Using aliases requires providing a valid SSL certificate, as such we're not longer able to test using an arbitrary hostname

* cloudfront_distribution: (integration tests) Make sure we delete the test s3 bucket when tests fail

* cloudfront_distribution: field_level_encryption_id is now a mandatory field always add it

Setting the field to an empty string has the same effect as the original behaviour.

* Copy & Paste fixup

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-19 15:42:46 -05:00
052e8b7be4 ec2_tag - Deprecate the use of state=list (#66840)
* ec2_tag - Deprecate the use of state=list

* Update lib/ansible/modules/cloud/amazon/ec2_tag.py

* Add changelog and porting_guide entries

Co-authored-by: flowerysong <junk+github@flowerysong.com>
2020-02-19 13:54:34 -05:00
a8d72a9923 Adding nanvault to Other Tools list (#67583)
##### SUMMARY
Adding nanvault - a standalone tool to encrypt and decrypt files in the Ansible Vault format, featuring UNIX-style composability.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-19 18:31:09 +00:00
a409100205 Update win_dsc.py (#67563) 2020-02-19 13:28:14 -05:00
887263c315 fix indents of EOS Platform Options (#67564) 2020-02-19 13:26:49 -05:00
19f6fc68d4 Relocate Shippable tools. (#67556)
* Move Shippable tools to hacking directory.

These limits the `test/utils/shippable/` directory to scripts required for CI.

* Fix `test/utils/shippable/` file classification.

* Update package-data sanity test.
2020-02-19 09:55:34 -08:00
4373863f25 Module validation: sanity check mutually_exclusive, required_if, required_xxx ... (#66961)
* required_if checks should have three or four parts.

* Validate mutually_exclusive, required_together, required_one_of, required_if and required_by.

* Simplify code.

* Improve messages.

* Add changelog.

* Sanity check.

* Update docs.

* Update ignore.txt.

* Don't continue with tests when terms are not strings.

* Remove ignore.txt entry.

* Make sure validate-modules doesn't choke on things already flagged by schema test.

* Check required_if requirements list for strings.
2020-02-19 12:26:42 -05:00
29ca9d2d4d openssl_* modules: improve test robustness (#67568)
* Run Ed25519 and Ed448 tests for openssl_csr and openssl_certificate only if key generation succeeded.
* Make openssl_privatekey tests more robust: allow special key generation tests to fail with 'algorithm not supported' on FreeBSD.
2020-02-19 12:24:46 -05:00
e867535a57 regex_replace multiline support (#65051)
* document multiline parameter for regex_replace
* add changelog fragment
* tests for regex_replace_multiline
2020-02-19 12:19:40 -05:00
b3db41e6d8 Fix hacking policy (#67579) 2020-02-19 12:05:43 -05:00
6d97943c82 New module ec2_tag_info - fetch the tags from EC2 objects (#66839)
* New module ec2_tag_info - fetch the tags from EC2 objects

* Add ec2_tag_info to group/aws

* Add basic test case
2020-02-19 11:31:54 -05:00
4844adff9a Collection developer guide - BOTMETA (#67538)
* Docs: Improve how to migrate and create collections
* Update docs/docsite/rst/dev_guide/developing_collections.rst

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-02-19 10:11:38 -06:00
5928918352 vmware_guest_disk storage DRS bugfix for get_recommended_datas… (#67221)
* Fix sDRS recommendations

Fixes storage DRS recommendation call for add disk scenario

* Undo changes to whitespacing

* Undo changes to whitespacing (pt. 2)

* Add datastore_cluster prop to disk defaults

* Create 67221-vmware-guest-disk-storage-drs-fix.yml
2020-02-19 19:12:27 +05:30
faa9533734 Specify priority for VMs in Azure VM scale sets (#65226)
Adds support to create VMSS with low-priority VMs through a new optional
parameter. The default is to create a VMSS with Regular priority VMs.
https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-use-low-priority
for details.
2020-02-19 05:18:50 -05:00
a7197a4320 zabbix: new module zabbix_host_events_info (#56162) 2020-02-19 10:22:59 +01:00
9d8bd225af postgresql_subscription: remove stat (#67470) 2020-02-19 09:34:20 +01:00
8aec058473 add omit_date option for template dump (#67302)
* added omit_date option for template dump

omit_date=yes removed the date field in the exported template

* Update zabbix_template.py

- ansibot fixes
- better function call handling

* Update zabbix_template_info.py

* Create 67302-zabbix_template_info-add-omit_date-field

* Rename 67302-zabbix_template_info-add-omit_date-field to 67302-zabbix_template_info-add-omit_date-field.yml
2020-02-19 01:56:40 -05:00
cceb517aff IOS: Add voice vlan to ios_l2_interfaces (#67211)
* Add voice vlan to ios_l2_interfaces

* Fixed pep8 issues, added voice vlan to tests, updated module docs
2020-02-19 12:23:59 +05:30
e632d93371 Add iosxr_acl_interfaces RM (#66936)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-19 11:40:45 +05:30
493dda94e9 Remove unused imports for vyos (#67550)
These flake8 errors would caught in our collection testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-18 17:49:49 -05:00
d7059881a2 win_credential - fix wildcard name (#67549) 2020-02-19 07:43:04 +10:00
650c3c5df3 doc fragment needs proper types (#67545) 2020-02-18 16:40:00 -05:00
de5c18af7c openssl_* / x509_* modules: refactoring (#67540)
* Move common code to module_utils.

* Unify get_relative_time_option.
2020-02-18 22:23:50 +01:00
b8f0cfc38a Move scaleway_s3 tests to the legacy directory.
These tests rely on the AWS S3 modules, but will not be migrated along with those modules into an AWS collection.

Since these tests will not reside in a collection alongside the modules under test they are being moved to the legacy tests directory.

The legacy tests directory will soon be migrated to a separate repository.
2020-02-18 13:02:51 -08:00
13a949e345 Update digital_ocean_droplet.py (#65251) 2020-02-18 15:09:28 -05:00
704e7a5055 Rename callback_retry_task_name test.
Avoid confusion with other `callback_` prefixed tests.
2020-02-18 11:16:37 -08:00
ed6a6aca25 Allow botocore configuration for aws modules (#55217)
* Allow botocore configuration to be configurable for boto3 modules

* Allow modification of the boto user agent

* play nicely with modules that might be modifying config

* changelog
2020-02-18 13:12:10 -05:00
214bf8dc0b Fix KeyError for iSCSI parameters (#67463)
The required parameters for the LUN mapping for destination LUN is
address, port and iqn. However if the user doesn't pass parameters
like  CHAP authentication parameters, we will get KeyError. The patch
fixes the same.
2020-02-18 12:56:15 -05:00
0f56ac018b Add x509_crl module (#63435)
* Add x509_crl module.

* Add integration tests.

* Fix some errors.

* Fix inversion.

* Compare name instead of tpye.

* Fix fail_json() calls.

* Work around rename of serial_number attribute for cryptography 1.4.

* Don't die for non-cert loading errors.

* One more.

* Fix function call.

* Fixed/improved descriptions.

* Don't read issuer from certificate file.

* Allow to ignore timestamps.

* Default value for revocation_date.

* Update tests.

* Mention ignore_timestamps in update docs.

* Support privatekey_content, and require some options only if state is present.

* Allow to pass certificate in directly.

* Add tests.

* Fix required_if.

* Forgot to encode content.

* Forgot to adjust type.

* Allow to return CRL's content directly.

* return_crl_content -> return_content (as in #65400).

* Fix elements.

* Fix messages.

* Use required_one_of and mutually_exclusive instead of doing the checks by hand.

* Fix format.

* Skip tests on AIX.

* Fix typo.
2020-02-18 17:14:13 +01:00
de230d04a3 Fixed documentation for elb_target_group module to match the code logic. (#66689) 2020-02-18 09:56:37 -06:00
2a36ade26f Update win_service example in win_nssm (#67530)
`user` should be `username` for use in `win_service`, see https://docs.ansible.com/ansible/latest/modules/win_service_module.html#parameter-username
2020-02-18 09:50:43 -06:00
3ccda78145 pause - add missing interpreter line (#67134) 2020-02-18 10:46:29 -05:00
1bdbbd2784 Attempt to rebalance the aws tests (#67523) 2020-02-18 08:57:42 -05:00
9eb7709c61 Vyos static route module added (#62193)
* Vyos static route module added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* empty config traceback fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check fix

* model specific changes and SI test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new state changes and SI test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* UT cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* replaced operation fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* review comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* shippable fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* delete opr updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-18 07:32:26 -05:00
b6753b46a9 Replace 'message' in module parameters (#60051)
* 'message' parameter is replaced by 'commit_message' in grafana_dashboard
* 'message' parameter is replaced by 'notification_message' in datadog_monitor

This change is required since 'message' as parameter name is used internally by
Ansible core engine.

Fixes: #39295 #45362 #47132 #59617

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-18 13:00:16 +01:00
00bed0eb1c facts virtual: detect KVM when product_name is 'KVM Server' (#66780)
* facts virtual: detect KVM when product_name is 'KVM Server'

* added changelog fragment for "facts virtual: detect KVM when product_name is 'KVM Server'"
2020-02-18 12:14:20 +01:00
5a7c58b2be postgresql_info module: fix broken link (#67517) 2020-02-18 14:22:41 +05:30
ca57871954 openssl_* modules: prevent crash on fingerprint determination in FIPS mode (#67515)
* openssl_* modules: prevent crash on fingerprint determination in FIPS mode.

* Add changelog.
2020-02-18 09:43:22 +01:00
9f41d0e914 route53: improve octal encoded characters handling (#60508)
* route53: improve octal encoded characters handling

* Update changelogs/fragments/60508-route53-improve-octal-characters-handling.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-18 09:18:59 +01:00
70b9bdbce6 Fix links in Postgresql modules (#67511)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-18 13:18:16 +05:30
7dcf32294b Update URLs in documentation (#67376)
Partially fixes: #67357

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-18 09:00:30 +05:30
6b111e46ba Win tests - prepare for collection migration in tests (#67506) 2020-02-18 10:29:30 +10:00
bb70c0b996 [doc] Set consistent return codes for modules (#67444)
Set consistent possible return codes for these similar two modules.
2020-02-17 17:50:52 -06:00
cbc38d2e5a Windows: Add multi-domain forest Support (#65138)
* Add multi-domain forest Support
cloned extra_args so there is no check for credentials needed.
Fixed Formatting
added missing extra_args to pure state

* minor Fixes
do not clone $extra_member_args again
do not overide $name
better description

* added Changelog
fixed typo in Documentation
2020-02-18 08:43:17 +10:00
a60feeb3c1 Specify lowercase only for Galaxy namespaces (#67485)
* specify lowercase only for galaxy namespaces
* doh... include meta file
2020-02-17 15:26:47 -06:00
b5b23efdcc Add SimpleUpdate command (#65074)
* add SimpleUpdate command

* add AllowableValues check for Targets property
2020-02-17 21:19:47 +00:00
c64202a495 ansible-galaxy - fix role list bug (#67391)
Properly list roles even when the role name is the same or a substring of the
path to the role.
2020-02-17 16:16:14 -05:00
343de73f2d Rebalance Windows groups for devel run (#67496) 2020-02-18 07:10:12 +10:00
640e9c7722 Restore AIX tests in CI. 2020-02-17 13:05:28 -08:00
b0abc1f5f6 Fix bug in iam_role - _list_policies was not returning anything (#67495) 2020-02-17 15:43:26 -05:00
82ca00e4fe Update windows_faq.rst (#67482)
Steers users around the error:  Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/xmltodict.py'
Consider using the `--user` option or check the permissions. -->
2020-02-17 13:38:46 -06:00
423a900791 Clarify b64encode with Python 2 (#67488) 2020-02-17 13:31:03 -06:00
36ed3321fd Disable failing zabbix_user test. (#67487)
* Disable zabbix_user test on aix.

* Disable failing zabbix_user test.
2020-02-17 11:11:13 -08:00
6a8b1f867e [aws_s3] fix deleting versioned objects before deleting bucket (#54435)
* [aws_s3] fix deleting the current objects and the previous versions from a version-enabled bucket

* use existing paginated_list function to keep compatibility with the other places it is called

* changelog

* Add noteworthy change to the porting guide

* Reword that with acozine's suggestion

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-02-17 13:16:09 -05:00
3bf6802cb2 ovirt_disk: correct description of storage_domain (#67454)
* ovirt_disk: correct description of storage_domain
* add changelog

Signed-off-by: mnecas <necas.marty@gmail.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-17 11:19:57 -06:00
39fef58bea Add note that devel branch should not be used in real environments (#67483) 2020-02-17 10:53:16 -06:00
62cc120dce Add support for networks to hcloud inventory (#67453) 2020-02-17 13:39:37 +00:00
e76630c4e4 VyOS: firewall_rules module added (#65680)
* firewall_rules module added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* state fact gathering code

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts and operation code added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* unit tests added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* delete opr updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-17 08:08:08 -05:00
eff51c0122 Fix proxysql module cursor_class (#67339)
* Fix proxysql module cursor class

* Adding changelog file

* adding extension to changelog file
2020-02-17 13:55:44 +01:00
38f26ffcc7 win_domain_object_info: new module (#67450)
* win_domain_object_info: new module

* Added basic integration tests
2020-02-17 18:22:11 +10:00
be26f4916f win_dns_client DHCP improvements + more (#66451)
* Fix DHCP support in win_dns_client + more

* Fix bugs and test failures, add changelog fragment

* Add idempotency tests for DHCP

* Address review feedback; dedup address-family code

* Remove legacy function

* Remove old reference
2020-02-17 15:35:54 +10:00
e3d5dc0ed0 win_domain_controller: Added domain_log_path (#67448) 2020-02-17 07:25:22 +10:00
Ali
4733af3376 Added support for GitHub Enterprise to github_deploy_key module (#59564) 2020-02-16 17:33:06 +00:00
569f0cf808 azure_rm_rg_info: fix KeyError: 'ansible_facts' (#66729)
* azure_rm_rg_info: fix KeyError: 'ansible_facts'

Fix facts for using old azure_rm_resourcegroup_facts, closes #66727

* fix intendation
2020-02-16 17:03:31 +01:00
ff0576802f Support changing fetch_url settings for Rendeck modules (#66357) 2020-02-16 15:07:36 +01:00
274a07e7c7 Add module ipwcli_dns.py to manage DNS records on Ericsson IPWorks (#67135)
* Create ipwcli_dns.py

* add newline at the end

* Update after review and support AAAA

* Update lib/ansible/modules/net_tools/ipwcli_dns.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* add integration tests and change param user to username

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-16 15:05:44 +01:00
31a6a37329 Add integration tests for the mas module (#67442)
* Add integration tests for the mas module

See https://github.com/ansible/ansible/pull/19768.

* Implement review feedback
2020-02-15 22:57:58 +01:00
a43f76cbf9 Add mas module for installing applications via the Mac App Store (#19768)
* Add `mas` module for installing applications via the Mac App Store

Currently, only the `install` command is available, and you must provide IDs
when installing applications.

* mas module: Update metadata

Brings the metadata in line with the current style.

* mas module: General refactor, support more states

- `check_mode` is now fully supported
- Support for states `absent` and `latest` (using `mas uninstall` and `mas upgrade`)
- Support for a list of apps to manage
- Remove return value as other packaging modules don’t support it either
- Return msg with details on the changes on success
- Code was refactored to be easier to read and maintain

* mas module: Add upgrade_all option

* mas module: Fix linting errors

* mas module: Implement review feedback

Co-authored-by: Lukas Bestle <account-github@lukasbestle.com>
2020-02-15 19:44:20 +00:00
807f4ea658 Don't send JOIN and PART commands if channel is not set (#62334)
Currently, the irc module is sending JOIN and PART commands even if the channel
key is not set in the irc module. This causes the module to send JOIN and PART
commands to the #None channel. This module can send PRIVMSGs to either a
channel or a list of nicks, so sending JOIN and PART doesn't make sense in
cases where channel is undefined. The same goes for the TOPIC command, which is
used to set a topic for channels.

This patch ensures that the JOIN, PART and TOPIC commands are only sent if the
channel is defined.
2020-02-15 12:39:28 -05:00
cc86748109 Fix url handling in lxd_container and lxd_profile module (#66097)
* Fix url handling in lxd_container module

* Fix url handling in lxd_profile module
2020-02-15 12:39:05 -05:00
eaf879a7a7 Fix uptimerobot stacktrace on decode (#66244)
* Fix uptimerobot stacktrace on decode

`req.read()` always returns bytes whereas the json module expects
strings.

I don't know how this worked before.

* Use `module_utils._text.to_native` instead of decode
2020-02-15 11:10:23 -05:00
11483921f2 Added additional error handling inside the hcloud.py inventory plugin… (#66381)
* Added additional error handling inside the hcloud.py inventory plugin. Otherwise, errors may happen, if the HCloud API is not able to correctly identify the server image.

* Corrected the previous commit to not check for None on variables that are always set. Additionally, used image.description if image.name was not set, instead of the previously added default string.
2020-02-15 11:09:18 -05:00
a753ff7cbf Fix packet dynamic inventory "Slug" issue. (#63916)
* Fixed 'slug' bug in packet_net.py that was caused by a breaking change in the Packet API.

* Removed some debugging and comments I had left.

* Missed a spot!
2020-02-15 14:58:44 +00:00
5aa60a5fa7 ovirt: don't ignore instance_cpus parameter (#64366) 2020-02-15 14:57:19 +00:00
e1a815381a Thresholds need to be passed for the log alert type (#64851)
* Thresholds need to be passed for the log alert type

* removed whitespace from linting error
2020-02-15 14:56:16 +00:00
95d4908987 Fix packet.net dynamic inventory projects limit. (#64889)
* Added parameters to list more than 10 projects per run

* Fix slug issue due to packet api change. Same as https://github.com/ansible/ansible/pull/63916
2020-02-15 14:55:40 +00:00
f978b6c789 Use https for Ansible Slack icon. (#65625) 2020-02-15 14:53:18 +00:00
8647d0a873 Removing a cron file when the 'name' parameter is specified is now allowed (#57471). Added integration tests to validate new behavior. (#65640)
Also added user input validation to return a clear error when deleting an environment variables without specifying a name.
2020-02-15 14:52:36 +00:00
fe6848badd sefcontext: fix fatal failure for socket file type (#65690)
fix #65689
2020-02-15 14:51:06 +00:00
9541377a20 Port keycloak to python3 (#66452) 2020-02-15 14:44:18 +00:00
6b017db05b support rabbitmq 3.8.x in version check (#66855)
* support rabbitmq 3.8.x in version check

* Removed extraneous white space
2020-02-15 14:42:32 +00:00
b1de5d43fc openssh_keypair and openssl_privatekey: add regenerate option (#67038)
* Add regenerate option to openssh_keypair and openssl_privatekey.

* Add changelog.
2020-02-15 14:39:36 +00:00
55cb8c5388 docker_login: fix permissions for ~/.docker/config.json (#67353)
* Fix permissions for ~/.docker/config.json.

* Add changelog, remove debug output.
2020-02-15 14:38:58 +00:00
25181e1b70 mongodb_user: Ensure to close database connection (closes #59353) (#65665) 2020-02-15 09:10:27 -05:00
c9b38bd74e ec2_snapshot and ec2_snapshot_info test suite (#65896)
* ec2_snapshot and ec2_snapshot_info test suite

* Add a fact to make tests easier to follow.
Test all return values, and add missing RETURN docs to module.
2020-02-15 13:21:23 +00:00
c2ad25020b removed the multiline if condition as it seems unnecessary and also prevents the warning message (#66543)
* removed "this_dns_name" variable comparision with empty string.  #66537

* removed the imultiline if condition as it seems unnecessary.  #66537
2020-02-15 13:19:17 +00:00
717b7fee9f Update redis module to support memory size units (#66975) 2020-02-15 13:15:12 +00:00
24ce97a49b open_iscsi: Set default port as string (#67270) 2020-02-15 13:06:16 +00:00
59bcc9f739 Bugfix of 67377: postgresql_set converts value to uppercase if "mb" or "gb" or "tb" is in the value string (#67418)
* Bugfix of 67377: postgresql_set converts value to uppercase if "mb" or "gb" or "tb" is in the value string

* fix CI

* add changelog
2020-02-15 13:03:53 +00:00
a4f5c2e993 Post reports to newer Foreman API endpoint (#64955)
The `/api/v2/reports` endpoint has been deprecated a long time ago and should
no longer be used. This changes to callback to use the correct API
endpoint and paramerter.
2020-02-15 13:01:27 +00:00
435bd91d2e Add new command ClearSessions (#65600)
* Add ClearSessions command to clear all active sessions.

* Delete trailing whitespaces
2020-02-15 13:00:55 +00:00
f21ee7f685 cloudformation - use mutually_exclusive for on_create_failure and disable_rollback (#65629)
* cloudformation - use mutually_exclusive for on_create_failure and disable_rollback

* cloudformation - remove unit test test_disable_rollback_and_on_failure_defined
2020-02-15 13:00:36 +00:00
be1459af0f use proxy settings for Redfish requests (#65998) 2020-02-15 12:58:27 +00:00
9edcda7ef7 Refactor iam_role to bring down the complexity score (#66027)
* Simplify BotoCore- / Client- Error try/except loops where we don't need different behaviour

* Refactor IAM Role manipulation to reduce complexity scores

* Missing permissions

* Add retry decorator by default

* compare_attached_role_policies is dead code, remove it
2020-02-15 12:57:52 +00:00
d0443909ff Zabbix: add integration test for zabbix_user module (#66418)
* add integration test for zabbix_user module

* Fix syntax mistake

* remove unsupported languages ​​from integration test
2020-02-15 12:57:17 +00:00
98bc53d3cb zabbix_action - allowing string for esc_period (#66841)
* allowing string for esc_period

* add changelog fragment

* Update zabbix_action.py

* remove now unneeded test
2020-02-15 12:57:02 +00:00
f98874e4f9 ec2_asg: max_instance_lifetime and respect wait on replace (#66863)
* ec2_asg: max_instance_lifetime and respect wait on replace

* ec2_asg: max_instance_lifetime integration tests

* ec2_asg: address review comments
2020-02-15 12:56:39 +00:00
d2f4d305ee Zabbix host tags & macros integration tests + zbx server version increase (#66997)
* bumped zabbix integration tests to be run against current LTS 4.4

* macros and tags tests for zabbix host + naming changes due to switch to zabbix 4.4
2020-02-15 12:55:48 +00:00
fe2a8cb145 do not loop through chassis in manage_indicator_led() (#66044) 2020-02-15 12:49:18 +00:00
936bd83614 Fix duplicate log entries (and add item support for failures) (#66098) 2020-02-15 12:48:05 +00:00
ad2428c176 fix hashi_vault lookup generates warning at LDAP authenticate #52131 (#67251) 2020-02-15 12:46:44 +00:00
c36f03b3e1 Add AWSRetry decorator to ec2_vpc_nacl (#67204)
* Add AWSRetry decorator to ec2_vpc_nacl

* Also add a decorator to ec2_vpc_nacl_info to catch things like API rate limit errors.

* add double-removal integration tests to make sure things don't get too slow

* Fixup retry usage for _info

* Simplify changed logic when modifying a NACL

* tweak error message
2020-02-15 12:42:02 +00:00
bcd145c111 vultr: Fix retry max delay param ignored (#67437)
* vultr: Fix retry max delay param not taken

* add changelog
2020-02-15 12:40:03 +00:00
a5af649a73 foreman: ansible_ssh_host should consider ip, ipv4, ipv6 (#67401) 2020-02-15 10:05:08 +00:00
ffead3b1c0 migration data for checkpoint collection (#67194)
* migration data for checkpoint collection

* Adding files instead of dirs
2020-02-15 10:01:24 +00:00
23e81f9907 google migration data (#67327) 2020-02-15 10:00:33 +00:00
8f6bce9134 Migrate Meraki modules to collections (#66396)
* Add documentation for ansible-test with collections

* Declare Meraki modules moved to collection

I have moved the Meraki modules to a collection at Galaxy called `cisco.meraki`. If additional changes are needed for this declaration please let me know.

* Remove changes to collection and specify each module for BOTMETA

* Remove duplicate anchors maybe

* Remove anchor references
2020-02-15 09:57:16 +00:00
2ab80a4388 migration data for fortios collection (#67193)
* migration data for fortios collection

* Adding all files to BOTMETA instead of dirs
2020-02-15 09:51:46 +00:00
0760a7ec08 Fix for shared snapshot parameter (#60250)
* Fix for shared snapshot parameter

Fixing this bug:
`Unknown parameter in input: "IsShared", must be one of: DBInstanceIdentifier, DBSnapshotIdentifier, SnapshotType, Filters, MaxRecords, Marker, IncludeShared, IncludePublic, DbiResourceId`

* Updated documentation for shared snapshots

Tags can't get accessed for shared snapshots

* fixed indentation

* added test for shared snapshot

* fixed isPublic parameter to correct IncludePublic parameter

Co-authored-by: Oliver Kastler <oliver@realestate.co.nz>
2020-02-14 19:05:40 -07:00
7ae34cef15 Fix role list regression (#67436)
Add the roles_path parent to the role_parser
object, so paths are passed to the list function

Add basic role list tests to prevent future regressions
2020-02-14 19:51:48 -05:00
5ea26b6e5a Added nameAlias field (#67150)
* Added nameAlias field to all the supported ACI modules

* Changed nameAlias to name_alias

* Review changes
2020-02-15 01:50:37 +01:00
98c1fc9d3a add a testing section to collections dev guide (#67370)
Signed-off-by: Adam Miller <admiller@redhat.com>
2020-02-14 16:57:24 -06:00
9b28f1f5d9 Fix incorrect "Could not match supplied host pattern" warning (#66764) (#67432) 2020-02-14 15:50:52 -06:00
c45d193af4 Rename some integration tests.
This avoids confusion with tests named `inventory_*` which do not test inventory plugins.

Tests for inventory scripts are now prefixed with `script_inventory_`.
2020-02-14 13:34:26 -08:00
1d370bd189 VMware: vcenter_folder nested folder absent fix (#65283)
- no longer try to create folder which exists.
- correctly remove nested folders with absent.
2020-02-14 16:18:34 -05:00
7000c51c06 VMware: Add support for specify tag and category as dict
User can now specify tag and category using dict in vmware_tag_manager
module. This is useful when tag or category name contains colon.

Fixes: #65765

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-14 16:07:10 -05:00
33d5c68887 Add newline in description of win_file.state (#67427) 2020-02-14 15:30:35 -05:00
ed4fccb308 Fix typo (#67433) 2020-02-14 15:22:58 -05:00
210e799375 UCS Emulator link to Doc Fragment use cs.co domain (#67434) 2020-02-14 15:20:17 -05:00
f506fd4730 Add ansible-galaxy collection list command (#65022)
* Start adding ansible-galaxy collection list options

* Working list all collections and list a specific collection

* Nuke debugging cruft

* Use to_text to get a string of the FQCN for sorting

* Improve collection output formatting

- add header
- display collection name and version in separate columns
- width of columns is dynamic based on collection name and version length

* Make role list output match collection output list

- add header
- add columns for role name and version
- make column width dynamic based on name and version length

* remove debug statemnt and extra header

* Revert "Make role list output match collection output list"

This reverts commit a0b3db47bb3b198aafd34c1f1be5b6561af2f928.

* Add validate_collection_path function

Utility function for ensuring a collection target ends with 'ansible_collection'

* Use validate_collection_path

* Do not warn if a specific collection in found in any search path

* Fix extraneous warning and remove duplicate code

Do not warn when listing a specific collection and it does not exist
in other collection paths.

Restructure the code that loops through collection paths to remove
duplicate conditional code.

* Indicate role path was found

* Use new function name

* WIP Save Point

* Use separate functions for role and collection list

* Wrap error message

There may be a better way to do this besides hard coding a line break, but this
does make the message a lot more readable.

* Add validate_collection_path function (#66441)

* Add validate_collection_path function

Utility function for ensuring a collection target ends with 'ansible_collection'

* Fix bad syntax

* Correct docstring

* Bikeshed the names

* Properly list a single role

* Simplify _display_warnings()

Only display warnings. Move exception raise back to each caller.

* Move private methods to private functions

They don't need self, so it makes sense to have them as functions
Get rid of _display_warnings() function since it doesn't do anything worthy of
an independent function.

* Add integration tests for ansible-galaxy collection list

* Fix docs sanity test

* Fix bug where ansible_collections dir does not exist

The path may exist, but if there is no ansible_collections dir inside that path,
an exception was raised in find_existing_collections().

Add integration test for this scenario

* Put execute_list() method back

* Add some informational messages for debugging

* Add unit tests

Units tests for the various private methods in support of collection list

* Start adding unit tests for test_execute_list

* Display collection path when listing specific collection

* Add unit tests for listing all collections and specific collection

- Create fixture for creating test objects
- Add function for controlling os.path.isdir results

* Set defaults for minimum collection widths

Ensure that collections with small FQCNs display correctly.
Add unit tests

* Split up unit tests and fix fixtures

Add more fixtures for mocking objects during the specific collection tests

* Change help message for -p in list subcommand

Give accurate description of what it actually does rather than trying to use language shared between sub commands.

* Disable colorized output in unit test

* Add docs for collection list

* Fix integration test on macOS

The temp file path is really long on macOS, so the warning message gets wrapped
across multiple lines. That make seth grep fail. Switch to matching on a smaller
part of the warning.

* Recreate common path options for collections

Improve help about what the '-p' option does and how it works.

* Remove unnecessary elif after continue statements

* Account for duplicate paths in collections_searh_paths

If someone specifies the same path via '-p' that is the COLLECTIONS_PATHS,
do not list the collections twice.

* Docs updates
2020-02-14 14:00:00 -06:00
Bas
f35293c052 Update YAMLSyntax.rst with yamllint (#66622)
* Update YAMLSyntax.rst with yamllint

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-02-14 12:18:13 -05:00
68620ced7f vmware_host_firewall_manager: avoid ansible.netcommon dep (#67386)
We use `ansible.module_utils.compat.ipaddress()` just for trivial IP
validations that are not critical. This module will be ship in the
`ansible.netcommon` collection. If we continue this way, it means
the futur `community.vmware` will carry this extra dependency for
limited benefit.

This commit introduce a new `is_ipaddress()` that provide similar
feature.
2020-02-14 22:05:29 +05:30
3fce39d610 Update azure_rm_aks.py (#66900) 2020-02-14 11:19:44 -05:00
b763d79b75 Updated description of examples to avoid confusion (#67192) 2020-02-14 11:16:29 -05:00
0680a91418 Updating broken link for UCS module (#67396) 2020-02-14 11:15:20 -05:00
69e31a440c Updating UCS Platform Emulator Link (#67400) 2020-02-14 11:13:00 -05:00
0485ce9d12 docs: fix path to roles' meta/main.yml file (#67408) 2020-02-14 11:10:33 -05:00
b625b430f1 Add (more) explicit references to Jinja2 docs in conditionals doc (#61814)
Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-02-14 10:53:14 -05:00
6cc326dcf1 VMware: Update VMware module defaults (#66486)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-14 10:00:08 -05:00
46205594c2 Fix typos in EC2 VPCE module docs (#67426) 2020-02-14 20:28:25 +05:30
97f011cf94 Add verify subcommand to 'ansible-galaxy collection' (#65618)
* [WIP] Add verify subcommand command to 'ansible-galaxy collection'

* Fix pep8 and use consistent display order

* WIP - docs

* Remove some redundancy in verify display messages by using an error queue for each collection

* Share common code and improve output format

* clean up documentation

* typo

* Apply suggestions from code review

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Move ModifiedContent namedtuple to the global scope

Add a public metadata property

Rename function to _get_json_from_tar_file

* Add some unit tests

* fix using common functions after rebase

* changelog

* Improve efficiency finding specific installed collections

Improve efficiency by only downloading the tar.gz from the galaxy server for comparison after checking that the collection has been installed

Handle multiple collection paths

Fix up tests

* pep8

* reword that for accuracy

* use more common code and verify collection name

* Improve error message and add documentation

* Update unit tests and add coverage for both local and remote collections that are unable to be located

* Only validate collections using the format collection_namespace.collection_name

Fix tests to reflect that

Fix documentation

* Fix a bug when a local collection does not contain a file

* pep8

* Fix formatting

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-02-14 08:57:04 -06:00
1b9b551b61 Explicitly chose an AZ for cloudformation and ec2_vol tests (#67425)
us-east-1e is sometimes picked at random, and has no support for
t3/m5 instance types, which breaks some tests.

Because availability_zones is returned in a consistent (sorted) order,
we should at least get either consistent success or consistent failure.
2020-02-14 09:39:59 -05:00
0c597f4434 vmware_guest_register_operation/test: no deprecated mod (#67411)
Don't use `vmware_guest_facts` to collect the Guest information. The
module is deprecated and replaced by `vmware_guest_info`.
2020-02-14 11:17:15 +05:30
5ca7a9ea26 Fix tracebacks with search_obj_in_list (#67389)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-14 09:46:59 +05:30
c1d8bdb87a FortiAnalyzer Network Manager Hotfix (#62919)
* Hotfix for FortiAnalyzer HTTPAPI Plugin in response to connection issues introduced in Ansible 2.9.

* Changed _connect behavior per Mr. Case.

Co-authored-by: Luke Weighall <lweighall@users.noreply.github.com>
Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
2020-02-13 19:36:48 -05:00
4881af2e7e galaxy - Fix collection install dep resolver for bad versions (#67405)
* Also make sure version is a string and not an int/float
2020-02-13 17:23:17 -05:00
90898132e4 CloudRetry/AWSRetry : Disable catching of NotFound exceptions (#67281)
* CloudRetry/AWSRetry : Remove default catching of NotFound exceptions

* Add docs

* Changelog updates from review

* Update unit tests after removing 'NotFound' from default retries
2020-02-13 16:59:00 -05:00
1a450400ff add migrated_to for tower to awx.awx (#67233) 2020-02-13 21:35:11 +00:00
69eec1c98f elb_target_group - try to handle target_type default when state is absent (#65201)
* try to handle default when state is absent

* remove default target_type

* Update lib/ansible/modules/cloud/amazon/elb_target_group.py

Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-13 15:49:24 -05:00
a2c620819f Remove a host from a play after meta: end_host (#66851)
* Remove a host from a play after meta: end_host

* Fix changelog
2020-02-13 15:35:00 -05:00
da1bed8932 Moving ACI support to aciguru (#67348) 2020-02-13 19:36:35 +01:00
b9bd2c25ca Test: Bump TOWER_VERSION to supported version (#67378)
* Revert "Remove Tower module tests from CI. (#67368)"

This reverts commit b041d96762.

* Test: Bump TOWER_VERSION to 3.6.2
2020-02-13 10:13:05 -08:00
f4b821a4da Update Maintainer List for team_tower (#67387)
* Update maintainer list for team_tower

* Add John Westcott IV to the list
2020-02-13 18:03:28 +00:00
77c19daefa Fix creating IP specific firewall rules with Python 2 2020-02-13 12:32:42 -05:00
3b3db88a72 Update vmware_guest.py (#67380)
Incorrect value in example
2020-02-13 12:25:23 -05:00
f49f14e8c7 Revert "Revert "Temporarily remove AIX from test matrix."" (#67382)
This reverts commit 772071cc08.
2020-02-13 08:30:27 -05:00
ed863b377b win_package: add missing porting guide entries (#67374) 2020-02-13 16:59:44 +10:00
446a0c1b08 win_package - Refactor with msp, appx support (#66931)
* win_package - Refactor with msp, appx support

* Added msi test for ALLUSERS

* Added some msix tests, refactored tests

* Added remaining msix tests

* Enable msix sideloading for tests

* Added remaining exe path tests

* Added basic msp tests

* Remove url options now the util no longer has them

* Fix file version check for older Windows hosts

* Remove no_proxy ansible-test setting

* Use same mechanism of become to copy the file with explicit creds
2020-02-13 16:44:19 +10:00
2d9328cb0f Added Ansible.Service util and win_service_info (#67367)
* Added Ansible.Service util and win_service_info

* Fix up util test

* Sigh forgot to update the test and fix sanity

* Try to make tests more robust

* That didn't work, just check the username

* Betraying Queen and country with this doc fix

* More changes for compat

* More OS compatibility
2020-02-13 14:34:58 +10:00
b041d96762 Remove Tower module tests from CI. (#67368)
* Remove Tower module tests from CI.

The required AMIs are no longer available.

* Mark Tower tests as unsupported.
2020-02-12 19:02:39 -08:00
11e75b0af2 Fix broken links in crypto, docker and hetzner modules. (#67360) 2020-02-12 16:41:40 -05:00
53e043b5fe combine filter: fine list handling (option b) (#57894) 2020-02-12 16:40:36 -05:00
33f136292b Hotfix for FortiManager Network Connection Plugin (#62534)
* Hotfix for connection manager persistent connection initialization.

* PEP8 Fixes

* First Round of fixes requested by Qualthos.

* Removed _connection check per Mr. Case.

* Somehow the wrong version got sent... should be all good.

Co-authored-by: Luke Weighall <lweighall@users.noreply.github.com>
Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
2020-02-12 14:30:59 -05:00
156dc68e40 Followup from #65868 defionscode doesn't have the time to be a… (#67351) 2020-02-12 14:06:54 -05:00
a928db1420 Split out selinux setup in subversion test.
This avoids failures when the sefcontext module is not present.
2020-02-12 10:49:40 -08:00
8d574c3770 AnsibleAWSModule related cleanup - redshift (#66779)
* AnsibleAWSModule related cleanup - redshift

* Apply a backoff on modify_cluster to cope with concurrent operations

* Add AWS 'hacking' policy to allow creation of Redshift ServiceRole

* Adding the retry policies makes the redshift test suite more reliable
2020-02-12 11:17:18 -07:00
a6bb3ae291 fix some broken links (#67345) 2020-02-12 10:47:00 -06:00
4231f34458 vmware: define more Zuul aliases
- vmware_content_library_info
- vmware_content_library_manager
- vmware_guest_disk
- vmware_host
- vmware_host
- vmware_host_firewall_manager
- vmware_host_ipv6
- vmware_host_powermgmt_policy
- vmware_vswitch
2020-02-12 11:46:27 -05:00
772071cc08 Revert "Temporarily remove AIX from test matrix."
This reverts commit 231726d38b.
2020-02-12 08:28:08 -08:00
4ec1437212 Fix to - eos_vlans using state parameter replaced is giving odd behavior (#67318)
* Added fix for bug # 54400

* Adding files for RM static_routes

* Added Integration tests

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* Adding files for RM static_routes

* Added Integration tests

* Corrected lint errors

* Added fix for bug # 54400

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* fix to bug #67313

* fixing rebase issue

* fixing rebase issue

* addressed review comments

* addressed review comments
2020-02-12 11:12:12 -05:00
cd146b836e migration data for cisco aci collection (#67199) 2020-02-12 15:15:45 +00:00
561f8c1d60 Update macOS installation instructions (#67058)
On macOS Catalina ``pip install --user ansible`` results in warnings and errors. This updates the reference documents to reflect changes Catalina+ with a safe, easy install for Ansible, accessing pip as a module and installing ansible with --user.

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-02-12 09:06:23 -06:00
bc2419c47c don't update nios_a_record object when running in check mode (#67145) 2020-02-12 20:10:10 +05:30
a4ec18d8a3 Cloudscale Regions and Zones Support (#67165) 2020-02-12 14:06:41 +01:00
7c8c53de20 Ignore authors ethanculler and woz5999 for logicmonitor* modules. (#67287) 2020-02-12 12:27:50 +00:00
8ff62799c9 AnsibleModule.load_file_common_arguments: allow to override path (#61659)
* Allow to overwrite path in AnsibleModule.load_file_common_arguments

* Use path override.

* Add changelog.
2020-02-12 12:52:36 +01:00
d1846b96c0 cope with an ASG instance not having a launch config any more (#57737) 2020-02-12 05:54:58 -05:00
8ac0bbcbf6 mysql_replication: add option to fail on error (#67322) 2020-02-12 12:18:51 +05:30
f6815040fd add_file_common_arguments: fix defaults and tpyes, improve sanity checking (#67243)
* Make validate-modules stop ignore FILE_COMMON_ARGUMENTS.

* Add types to FILE_COMMON_ARGUMENTS and update document fragment to match it.

* Update ignore.txt.

* Add changelog.
2020-02-12 01:44:11 -05:00
a61dcfd542 Mark mariadb_replication tests unsupported.
Only one integration test target is supported per module. Since there is already a `mysql_replication` integration test, the `mariadb_replication` tests will not execute for the same module.

To avoid issues with tests not running on changes to the `mysql_replication` module and then failing after changes are made and all tests are executed, the test has been marked `unsupported` to prevent it from running in CI.

To re-enable this test for CI it will need to be merged into the `mysql_replication` tests, which will require working around conflicts between the packages required by the two sets of tests.
2020-02-11 19:27:31 -08:00
9788daf13b Split up more lookup integration tests. (#67328) 2020-02-11 18:00:01 -08:00
cad0110228 Rename kubevirt inventory plugin test. (#67326)
* Rename kubevirt inventory plugin test.

This maintains association of the test with the plugin.

* Update ignores.
2020-02-11 16:43:41 -08:00
274417d424 Improve test compatibility with ansible-base. (#67325)
* Remove shells from test that will be migrated.

* Fix binary_modules test to work without win_ping.
2020-02-11 16:18:34 -08:00
08db603262 vmware_host: fix doc syntax error
Adjust the `DOCUMENTATION` section to get a proper rendering of the
`folder` example.
2020-02-11 18:23:13 -05:00
efc5d62c49 Use a custom test module for module_defaults test.
This avoids a dependency on a module which will not remain in the repo after migration.
2020-02-11 13:59:33 -08:00
8774b2f697 Use package for pkgng and zypper in tests.
This allows tests to run on other platforms when `pkgng` or `zypper` are not present.
2020-02-11 13:57:01 -08:00
888a059ee7 Can we simplify _How to test a PR_? (#65383)
Switch the instructions on testing PRs to use the `refs/pull/XXXX/head` refspec as described in [_Checking out pull requests locally_](https://help.github.com/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally#modifying-an-inactive-pull-request-locally).
2020-02-11 15:53:23 -06:00
236773bfea Improve distribution unit tests (#67300)
* Include distro.{os,lsb}_release_info() in distro fixture generation script
* Add distro release information to existing fixtures
* Add some new fixtures for newer distribution versions
* Add fixture for Arch Linux with lsb-release
2020-02-11 16:46:48 -05:00
3be0795ea3 Fix examples to use from_yaml filter with lookup (#65424)
The documentation says to use `from_yaml` filter when using `lookup`  from node executor. Now the examples do too.
2020-02-11 15:36:08 -06:00
a3b7d67fb0 Split up platform cleanup in tests. (#67320)
* Split up platform cleanup for git test.

* Split up platform cleanup for ansible-galaxy test.
2020-02-11 13:25:44 -08:00
a0247d13d8 New magic var: ansible_config_file (#66085)
* Add `ansible_config_file` magic variable

* Add ansible_config_file to INTERNAL_VARS

* Add changelog fragment

* Update Special Variables docs
2020-02-11 15:49:55 -05:00
29edcdcf5b Add library in role directory structure (#67030)
* Add library directory to the list of directories in a role
2020-02-11 14:30:59 -06:00
4967224248 Update digital_ocean_droplet.py (#66794)
* Update digital_ocean_droplet.py

here's new term of `ssh_keys` from `SSH key (numeric) ID` and in fact it's fingerprint. correctly term so people can easily know how to do it.

* Update digital_ocean_droplet.py
2020-02-11 15:14:50 -05:00
a8a89b7102 Update yum.py (#67252)
Move the simpler name list example to the top of EXAMPLES.
Those with v2.11 loop deprecation warnings will be looking for a solution.
2020-02-11 14:03:28 -05:00
7e83c40957 examples check system state present/absent (#54473)
<!--- Your description here -->

+label: docsite_pr
2020-02-11 14:02:29 -05:00
fd43619f1a Docs: improve anchors vs. header bar (#67244) 2020-02-11 13:16:26 -05:00
28071daab8 s3_bucket: fix condition checking of requester_pays param. (#64010) 2020-02-11 10:57:09 -07:00
1867ff4013 Update mso_schema_site_anp.py (#67099)
Under Examples > Query a specific site ANPs: the example was missing the "anp: ANP1" to query.
2020-02-11 11:52:57 -06:00
070f946745 Update intro_patterns.rst (#67151)
Removed extra quotes from example.
2020-02-11 11:52:00 -06:00
01a6e1c2c9 Mention role defaults file (#67153)
Add info on where role defaults are set; matches the entry for role variables.
2020-02-11 11:50:16 -06:00
d273e9758e Update group.py (#67309)
Added example with gid-param
2020-02-11 11:37:21 -06:00
8a2ac8f76a Fixing typo in regex escape. (#67236) 2020-02-11 11:23:58 -06:00
a86524b2bb Bugfix of 65525: proxysql in check_config TypeError: tuple indices must be integers, not str (#66850) 2020-02-11 10:53:42 -05:00
7ef7c1b5d7 add note on write access to socket_path (#67060)
* Change socket_path error messages to not directly refer to socket_path
* Apply suggestions from code review

Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>
2020-02-11 09:49:20 -06:00
28543ae208 Update virt.py (#66899)
##### SUMMARY
The info command also does not require the name option, which is completely ignored.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:20:25 +00:00
2c7623c6cc Update yarn.py (#66973)
##### SUMMARY
To globally install from local node.js library. Prepend "file:" to the path of the node.js library.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:19:30 +00:00
3b67e75562 Update aws_batch_job_definition.py (#67082)
##### SUMMARY
<!--- The example to call the method batch_job_definition is bad, the good method name is aws_batch_job_definition-->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:18:14 +00:00
60479d36f6 Update elasticache_parameter_group.py (#67164)
##### SUMMARY
Typo in description :)


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:16:52 +00:00
808bf02588 Remove options from some vmware modules that are not used in the code (#67282) 2020-02-11 12:30:22 +01:00
88f0c85228 Remove deprecated attributes from nxos_igmp_interface (#67186)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-11 12:27:07 +01:00
11eee1181a Split out platform specific cleanup in pip test. 2020-02-10 16:55:04 -08:00
89c8eb5a08 Split up lookup integration tests. (#67294)
* Split up lookup integration tests.

* Rename lookup_paths integration test.

This will avoid confusing it for a test of the `paths` lookup plugin, which does not exist.

* Fix lookup_pipe integration test.

The test now verifies it receives the correct output.

Adding a second task also causes code coverage to be properly registered for the lookup plugin.

* Rename ini lookup test to match plugin name.

* Update sanity ignore path.
2020-02-10 16:41:45 -08:00
8f296a6533 ansible-test - add constraint for virtualenv (#67289)
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-02-10 16:29:47 -08:00
c32348088a Remove conflicting integration test aliases.
Modules and plugins can only have one integration test target associated with them.

When there is a conflict between alias(es) and/or the target name, only one target will trigger on changes to the module or plugin.
2020-02-10 14:27:01 -08:00
49e7f9afe2 Link the testing documentation to the module documenting page (#67248) 2020-02-10 15:30:04 -05:00
585e79942c Slash missing from /etc/ (#67220) 2020-02-10 14:07:22 -05:00
120d11a82b ovirt_disk: update interface docs (#67272) 2020-02-10 13:56:44 -05:00
b9d22b901d Allow default network mode, as required for windows containers. (#59597)
* Allow default network option for network_mode, required for windows containers.

* Add change fragment and param description

* Update changelogs/fragments/59597-ecs-allow_default_network_mode.yml

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Correct descriptions. Remove whitespaces.

* Remove empty line.

* Add single space after comma

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

Co-authored-by: kevinsagle <44478308+kevinsagle@users.noreply.github.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-10 11:01:13 -07:00
231726d38b Temporarily remove AIX from test matrix.
AIX provisioning is failing.
2020-02-10 08:48:21 -08:00
1b263e77de Add example for retrieve Product, Version, Build, Update info for ESXi 2020-02-10 11:47:29 -05:00
4dd2513371 add info on creating doc fragments in a collection (#67171)
* add info on creating doc fragments in a collection
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-02-10 10:23:28 -06:00
fa8c07a33c Revert "Make cloudfront_info work with Python3 … (#66695)" (#67085)
This reverts commit aad286b403.
2020-02-10 10:22:00 -05:00
b65fc3527f vmware_guest_tools_wait: disable the function test
The test fails randomly in the CI with a timeout.
2020-02-10 10:02:36 -05:00
b40bdb7a22 cloudscale: Fixes wrong return value docs in cloudscale_server (#67198) 2020-02-10 11:47:51 +01:00
c80d0c40ce fixed zabbix no longer returning macros as part of the template (#66996) 2020-02-10 02:09:00 -05:00
1110e9d80d Test AIX with smaller volumes. 2020-02-09 13:23:28 -08:00
959ddf2589 Revert "Temporarily remove AIX from test matrix."
This reverts commit 57d43d1932.
2020-02-09 13:23:28 -08:00
4719072c49 Fix describing transit gateways with backoff in ec2_transit_gateway (#67247)
* Fix ec2_transit_gateway retries. AWSRetry must be used within ClientError handling to have any effect

* changelog
2020-02-08 21:48:11 +01:00
3f5aed056b Integration tests for notify with variable list (#66423)
Co-authored-by: Luca Berruti <nadirio@gmail.com>

Co-authored-by: lberruti <nadirio@gmail.com>
2020-02-08 12:41:06 -05:00
88efb24ff8 Rename aci_switch_leaf_policy_profile test. 2020-02-07 21:33:23 -08:00
d86dcedef1 Rename scaleway_ssh test. 2020-02-07 21:33:06 -08:00
c2f7c4ae47 Rename rabbitmq lookup test. 2020-02-07 21:32:54 -08:00
a42a76190e Renamed meraki_webhooks test. 2020-02-07 21:32:40 -08:00
a68a8ef2f1 Rename netapp_eseries_* tests to match modules.
This will allow the ansible-base migration script to recognize the tests as being associated with their respective modules.
2020-02-07 21:32:24 -08:00
0d430c2ccc Rename digital_ocean_ssh_key test. 2020-02-07 21:32:07 -08:00
f02ceaf66a Fix AWS test names and aliases. (#67232)
* Fix AWS test names and aliases.

* Add missing alias.

* Rename ec2_vpc_vpn_facts test.
2020-02-07 21:31:48 -08:00
6a79bb2b91 Simplify package install in unarchive test.
This will enable the test to work on supported platforms when modules for other platforms are not present.
2020-02-07 21:31:24 -08:00
c92697acec Move tower_common tests with tower_organization. 2020-02-07 21:31:05 -08:00
c10f4a8156 Rename azure_rm_workspace test. 2020-02-07 21:30:43 -08:00
415409c6e3 Rename azure_rm_virtualmachineimage_facts test. 2020-02-07 21:30:20 -08:00
64567cf4f6 Split tasks for prepare_http_tests.
This allows setup of a platform to run even when modules for another platform are not present.
2020-02-07 21:30:01 -08:00
80561ccef0 Improve sanity test handling in CI after migration. 2020-02-07 21:29:39 -08:00
7724fb8f33 Split handler tasks for setup_remote_tmp_dir.
This allows a platform handler to run even when the module required for the other platform is not present.
2020-02-07 21:29:20 -08:00
a0242b2173 Improve unit test handling in CI after migration. (#67217)
* Improve unit test handling in CI after migration.

* Fix undefined var in bash 4.3 and earlier.

See https://git.savannah.gnu.org/cgit/bash.git/tree/CHANGES?id=3ba697465bc74fab513a26dea700cc82e9f4724e#n878
2020-02-07 21:28:46 -08:00
f725dce936 Clean up FILE_COMMON_ARGUMENTS (#66389)
* Clean up FILE_COMMON_ARGUMENTS.

* postgresql_pg_hba doesn't declare the backup option.

* uri doesn't declare the remote_src option.

* Add documentation.

* maven_artifact seems to use directory_mode, which it doesn't declare.

* Update changelogs/fragments/66389-file-common-arguments.yml
Update docs/docsite/rst/porting_guides/porting_guide_2.10.rst

ci_complete

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-07 18:56:01 -05:00
802cc60242 vmware_guest_tools_wait: add timeout parameter
Add a new `timeout` parameter to `vmware_guest_tools_wait`.

Also, a functional test to cover the module.
2020-02-07 17:48:29 -05:00
57d43d1932 Temporarily remove AIX from test matrix.
AIX provisioning is failing.
2020-02-07 11:07:30 -08:00
4863efd0df Remove yaml stdout_callback plugin from network-integration tests (#67203)
With the move to collections, yaml is no longer in ansible base. Switch
back to default stdout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-07 13:24:42 -05:00
fd8eb77cc3 pmrun - quote success command (#66929)
* Recreate the older behavior where the entire success command was quoted

* Use shlex_quote for a correct fix of this

* Add changelog fragment
2020-02-07 12:15:55 -05:00
8fa233ba1e aws_az_info: Fix rename deprecaction warning (#67188) 2020-02-07 11:13:02 -05:00
4a1115785f vmware_guest_network/test: disable the test
The test fails in the CI with a timeout of vmware_guest_tools_wait. It's
still unclear if this comes from:

- the ESXi environment
- the VM configuration, e.g: the amount of the RAM
- the ISO image itself

Ideally, we should have a light VM with the vmware-tools.
2020-02-06 19:59:23 -05:00
bf4dac10fa Revert "WIP: testing ansible-base (#67149)" (#67175)
I didn't properly update the commit message via github UI. Revert, to
open a new PR.

This reverts commit 2794142eb3.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-06 14:26:10 -05:00
2794142eb3 WIP: testing ansible-base (#67149)
Currently, yaml stdout_callback is not in base.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-06 13:40:02 -05:00
640bf31f87 user - allow 'groups', 'append' with 'local' (#62134) 2020-02-06 12:32:44 -05:00
c3635532d3 Revert "Allow httpapi for EOS resource modules (#66871)" (#67131)
This looks to be causing issues for our new ansible.netcommon
collection. Revert for now, until we can properly address.

This reverts commit 53c7f8cbde.
2020-02-06 10:20:08 -05:00
637eed5a5c postgresql modules: fix sanity issues (#67046)
* postgresql modules: fix sanity issues

* add changelog

* fix changelog
2020-02-06 16:05:42 +01:00
a5b5101e09 Fix a typo in hcloud_image_info and hcloud_location_info (#67123) 2020-02-06 03:09:47 -05:00
b48a89682b Revert "Temporarily remove AIX from test matrix."
This reverts commit be9471b251.
2020-02-05 22:16:36 -08:00
5e68bb3d93 Add code coverage target analysis to ansible-test. (#67141)
* Refactor coverage file enumeration.
* Relocate sanitize_filename function.
* Support sets when writing JSON files.
* Generalize setting of info_stderr mode.
* Split out coverage path checking.
* Split out collection regex logic.
* Improve sanitize_filename type hints and docs.
* Clean up coverage erase command.
* Fix docs and type hints for initialize_coverage.
* Update type hints on CoverageConfig.
* Split out logic for finding modules.
* Split out arc enumeration.
* Split out powershell coverage enumeration.
* Raise verbosity level of empty coverage warnings.
* Add code coverage target analysis to ansible-test.
2020-02-05 22:16:15 -08:00
68b981ae21 update nmap inventory plugin to not depend on rdns (#56457) 2020-02-05 17:29:59 -05:00
0e46af17a5 Nuke all removed_module stubs (#67139)
* Nuke all removed_module stubs

* Remove ignores and botmeta entry
2020-02-05 16:29:27 -06:00
b868f1c933 fix systemd use in container builds (#66062)
* systemd: unify "systemctl show" failure cases

* systemd: is-enabled to detect configured state

* systemd: is-enabled to detect masked status
2020-02-05 15:14:57 -05:00
48505af9d2 Remove filtering from edgeos_config module (#63362)
The edgeos_config module had a list of commands to filter out to avoid
load failures. This list had a single regular expression which caught
commands that attempted to set pre-encrypted passwords. This behavior is
undesirable for a few reasons.

* It's poorly documented. The documentation makes cryptic mention of a
  return value that some commands might be filtered out, but offers no
  explanation as to what they are or why.

* It's hard-coded. There's no way for the user to change or disable this
  functionality, rendering the commands caught by that expression
  completely unusable with the edgeos_config module.

* The obvious workaround is unsafe. The filter catches passwords that
  are already encrypted, but is perfectly fine letting the user set
  plain-text passwords. EdgeOS will encrypt them upon commit, but this
  module encourages unsafe handling of secrets up to that point.

* It's a security vulnerability if the user doesn't know about this
  behavior. While the module will warn if commands are filtered, the
  user won't know what got filtered out until after the fact, and may
  easily miss that warning if they are not vigilant. For something as
  sensitive as setting a password, it's not hard to imagine naive use of
  this module resulting in incorrect credentials being deployed.

* It provides no discernible benefit. Using the module without filtering
  does not result in load failures. If those commands are indeed harmful
  for some reason on (old?) versions of EdgeOS, it should be incumbent
  upon the user to be scrupulous in what commands they issue, rather
  than the module maintaining a blacklist of possible ways the user
  might misuse their own system.
2020-02-05 14:57:55 -05:00
43f93d275c openssl_certificate: Selecting which acme directory to use to get certificate (#67109)
* "openssl_certificate - Add option for changing which ACME directory to use with acme-tiny. Set the default ACME directory to Let's Encrypt instead of using acme-tiny's default. (acme-tiny also uses Let's Encrypt at the time being, so no action should neccessary.)"
  * "openssl_certificate - Change the required version of acme-tiny to >= 4.0.0"
2020-02-05 14:10:27 -05:00
80c4b86abe group - correctly determine if a local group exists. (#59772)
Fixes #58619
Add integration test
2020-02-05 12:34:41 -05:00
50eb2f6957 sns_topic: Retry on Topic 'NotFound' Exceptions when attempting to list subscriptions (#67089)
* sns_topic: Retry on Topic 'NotFound' Exceptions when attempting to list subscriptions

* add changelog
2020-02-05 12:16:07 -05:00
2f77a6f1f0 migrate qradar and splunk httpapi plugins to collections (#67132)
Signed-off-by: Adam Miller <admiller@redhat.com>
2020-02-05 11:07:03 -06:00
f3f9671e01 Adding migration for netapp content (#67081)
* Adding migration for netapp elementsw content

* Adding migration data for netapp ontap content
2020-02-05 18:05:53 +01:00
c55ba658c6 add note for Azure Availbility Zone (#66200)
* add note for Azure Availbility Zone

* Change title

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/scenario_guides/guide_azure.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-02-05 12:04:47 -05:00
0a8f5aba74 Bugfix for os_coe_cluster_template module (#54819) (#54820)
* Support 'overlay2' in docker_storage_driver

* Fixed the data type in labels

* Improve string process with parsing labels
2020-02-05 10:41:15 -05:00
3dd4b3c8a3 Replaces a open/close to validate access with os.access in azure storageblob. (#65608) 2020-02-05 08:20:39 -05:00
52f2081e62 Ovirt_host_network: add custom_properties (#67117)
* init of cp

* set update_custom_properties

* update check_mode

* correct examples

* add version_added

* update sanity
2020-02-05 07:03:32 -05:00
822077fefd Asg mixed instance types (#67045)
* merge from origin pr 55067

* handle update existing asg with mixed-instance-policy

* fix documentation and append output

* update output documentation

* update documentation version added

* add integration test for mixed instance policy using launch template

* add changelog fragment

* Update lib/ansible/modules/cloud/amazon/ec2_asg.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ec2_asg.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ec2_asg.py

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* add warning about botocore version and add expand example documentation

* Update changelogs/fragments/67045-ec2_asg_mixed_instance_policy.yml

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ec2_asg.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ec2_asg.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* remove useless line

Co-authored-by: Yi-Tse Hong <yitse.hong@soocii.me>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-05 09:04:15 +01:00
f23cee2145 win_mapped_drive - Add WebDAV information (#67111) 2020-02-05 13:23:52 +10:00
12e3adb23a win_domain_controller - add a deprecation warning for the log_path option (#67108) 2020-02-05 10:46:47 +10:00
78470c43c2 Removed deprecated items in Windows modules (#67105) 2020-02-05 09:02:04 +10:00
1bb94ec92f service_mgr: detect systemd, even offline (#66071)
* service_mgr: detect systemd, even offline

* service_mgr=systemd iff /sbin/init is symlink
2020-02-04 17:32:36 -05:00
4ac89b8ac7 Added Fix - Allow nxos_l2_interfaces to append the allowed vlans list (#66517)
* Added Integration tests

* Corrected lint errors

* Added fix for bug # 54400

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* Bug Fix 65332

* Added testcase for #66517

* Removed unnecessary commit

* fixing conflicts

* fixing conflicts

* addressed mikeweibe's comments

* Corrected lint errors

* Added idempotent tc for add vlans

* Added replaced and overridded tcs for trunk vlan add
2020-02-04 15:14:04 -05:00
fd954a9c5c wait_for_connection: also retry interpreter discovery (#67040)
self._discovered_interpreter_key is None unless a previous iteration
has attempted discovery.  In that case, force re-discovery, as the
previous attempt certainly failed.
2020-02-04 11:40:09 -08:00
f4a80bb600 Code cleanup and refactoring in ansible-test. (#67063)
* Code cleanup in ansible-test.
* Split out encoding functions.
* Consoldate loading of JSON files.
* Split out disk IO functions.
* Simplify file access.
* Add functions for opening files.
* Replace open calls with appropriate functions.
* Expose more types from typing module.
* Support writing compact JSON.
* Add verbosity argument to display.warning.
* Add changelog entry.
* Update files overlooked during rebase.
* Use `io.open` instead of `open`.
* Fix file opening for imp.load_module.
* Remove use of `r+` mode to access files.
* Add missing import.
* Fix httptester on Python 2.x.
* Clarify changelog fragment.
* Consolidate imports. Remove extra newlines.
* Fix indirect imports.
2020-02-04 11:21:53 -08:00
994a6b0c5a fixes ANSIBLE_DUPLICATE_YAML_DICT_KEY=error crashes (#66786)
* Fix #65366
2020-02-04 13:53:13 -05:00
3b32f95fb3 user - warn if "append" is set but not "groups" (#65795)
This fixes people unknowingly changing the primary group rather than adding a secondary group.

* Add integration test
2020-02-04 12:35:05 -05:00
fe454d27a1 Fix removed_in_version to support honor suboptions (#66918)
* Add unit tests.
* Fix reporting for removed_in_version.
* Add changelog.
2020-02-04 10:14:55 -05:00
28b2428d22 docker_container: fix port order in docs (#67071)
* Fix port order.

* Forgot to remove random.
2020-02-04 10:05:53 +01:00
8b2ead5870 add jittered backoff for elb (#66673) 2020-02-04 08:57:26 +01:00
fc7980af9a Fix UNC path support in the powershell shell plugin (#66604)
* Fix UNC path joining in the powershell shell plugin, add test

* Remove testy bits and a redundant line

* Fix style nits

* Update to use os.ntpath

* Add changelog for #66604
2020-02-04 16:34:11 +10:00
81378b3e74 Added -LogPath param from Install-ADDSForest to win_domain module (#66956)
* Added omitted logpath parameter to win_domain

The Install-ADDSForest -LogPath param seems to have been omitted in the win_domain module. We do not use this module organisation-wide as its non trivial to change the log patch once AD is set up. I will also update docs

* Removed trailing whitespace

* Added logpath option to win_domain module docs
2020-02-04 14:52:24 +10:00
6d792838e4 Move url option from util to individual modules (#67068) 2020-02-04 10:43:33 +10:00
be9471b251 Temporarily remove AIX from test matrix.
AIX provisioning is failing.
2020-02-03 16:36:51 -08:00
3ada0b2f65 win_uri: fix up tests (#67064) 2020-02-04 09:57:44 +10:00
23b2bb4f4d docker_container: change behavior for one-port container ranges to be same as docker CLI (#66382)
* Adjust docker_container behavior for one-port container ranges to be similar to docker CLI.

* Add changelog.

* Add documented examples for ports:.
2020-02-03 23:27:40 +01:00
21ae66db2e postgresql_user_obj_stat_info: new module (#66892)
* postgresql_user_obj_stat_info: new module

* fix sanity

* add schema parameter

* add CI tests

* add RETURN section

* add example with schema

* fix CI

* fix example comments

* skip aix

* fixes part 1

* fixes part 2

* fix CI

* fix CI

* fix doc formatting
2020-02-03 23:06:31 +01:00
622f1c4c01 Revert "Temporarily remove AIX from test matrix."
This reverts commit 6024c09be5.
2020-02-03 13:34:10 -08:00
5b93a14a0f Add anchor to each parameter row (#66895)
* Add anchor to each paramater row

* Update docs/templates/plugin.rst.j2

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Insert full keys into plugin docs.

* Added visible links.

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-03 20:11:48 +01:00
6024c09be5 Temporarily remove AIX from test matrix.
AIX provisioning is failing.
2020-02-03 10:13:33 -08:00
5c1a3a3ac2 docker_container and docker_swarm_service: allow to actually disable healthcheck of image (#66599)
* Allow to actually disable healthcheck of image.

* Add changelog.
2020-02-03 13:13:17 -05:00
d6f2b4e788 Fix indentation (#66991) 2020-02-03 12:30:12 -05:00
ea105dcb2f Update template.py (#67010)
Update the example so that the task name matches the filename being updated
The first example shows how you might template a file to destination /etc/file.conf.  The description of this task appears to have a typo as it refers to  '/etc/files.conf' rather than '/etc/file.conf'
2020-02-03 12:28:55 -05:00
87a5e433ef update guide_azure.rst (#66940)
changed example for ping linux machines. Looks liked it was wrongly copy paste.
2020-02-03 12:26:14 -05:00
f49408287a Document difference between ec2 and ec2_instance modules (#67009)
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
2020-02-03 12:12:13 -05:00
fad261b04f ovirt_job: add when job is detected but in state finished (#66810)
* ovirt_job: add when job is detected but in state finished

* add docs
2020-02-03 09:21:10 -05:00
53c7f8cbde Allow httpapi for EOS resource modules (#66871)
* Redo tests to be transport agnostic

cli -> eos config

* Redirect connection for httpapi

* Fix tests

* Handle missing platform imports
2020-02-03 08:04:08 -05:00
0ee28c14c2 Add maintainer for keycloak module (#61521)
* add maintainer for keycloak module

* typo correction
2020-02-03 11:57:11 +01:00
a0e5e2e4c5 openssl_publickey: forgot to pass backend (#67036)
* Forgot to pass backend.

* Add changelog.

* Pass on backend from get_fingerprint.

* Handle cryptography backend in get_fingerprint.
2020-02-03 06:18:19 +01:00
b1a8bded3f Remove deprecated parameter for 2.10 in purefb_fs (#67026) 2020-02-02 15:30:01 +01:00
8f10db8552 Do fail instead of regenerate for password protected and invalid keys. (#65638) 2020-02-02 07:54:28 -05:00
d6fb9da8ed openssl_* modules: allow direct input and output for some files (#65400)
* Allow to return generated object.

* Use slurp module instead of file lookup + b64encode.

* Rename return_xxx_content -> return_content.
2020-02-02 12:42:52 +01:00
4d345813ea Group ids are strings now (#66939) 2020-02-02 04:57:23 -05:00
14b1febf64 Fix pacman: "IndexError: list index out of range" #63077 (#65750)
* Fix #63077

If the package is already installed the stdout is not as expected by this function. Either remove `--needed` or just noop if we detect pacman returning. We cannot match the stdout string, as that is most likely localized.

```
[root@archBook user]# /usr/bin/pacman --upgrade --noconfirm --noprogressbar --needed  /srv/aur/src/i3cat-git/i3cat-git-r38.c6d29dd-1-x86_64.pkg.tar.xz
loading packages...
warning: i3cat-git-r38.c6d29dd-1 is up to date -- skipping
 there is nothing to do
```

* Add comment

Add comment

* Add changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-01 14:37:27 +01:00
3baea92ec9 Bugfix of 54239: mysql_variables not supporting variables name with dot (#66806)
* Bugfix of 54239: mysql_variables not supporting variables name with dot

* add changelog

* add CI tests
2020-02-01 12:39:52 +05:30
f5e194cbcd Move random_mac into its own file (#67000)
* Move random_mac into its own file

This is likely to be the only filter which is not included in
ansible-base.  So it needs to be in its own file.
2020-01-31 14:33:16 -08:00
ef1fd19c00 croc cloud - ec2 key patch (#60929)
This patch fixes "IndexError: list index out of range" error for https://console.cloud.croc.ru.
When key pair is new, croc return dict with an empty list for key KeyPairs that causes ansible to crush.
2020-01-31 17:20:58 -05:00
919a9e33e8 Minor AWS argument checks (required_if / mutually_exclusive) fixups (#66966)
* aws_netapp_cvs_snapshots - minor required_if fixup (state must be set if state=present)

* ec2 - fix typo in mutually_exclusive definition

* rds_instance: fix typo in mutually_exclusive restore_to_time should be restore_time - currently throws a boto error
2020-01-31 22:17:46 +01:00
26175178ee Fix user_agent string not getting set (#66914) 2020-01-31 15:50:53 -05:00
9db0fb785d Add collections path option to ansible-galaxy (#66969)
Some common code needed for 'collection list' and 'collection validate'
2020-01-31 14:27:54 -06:00
16ebeda86d Bugfix of 66974: mysql_user doesnt support privileges with underscore (#66995)
* Bugfix of 66974: mysql_user doesnt support privileges with underscore

* add changelog

* add seealso
2020-01-31 20:44:03 +01:00
aad286b403 Make cloudfront_info work with Python3 … (#66695)
* Make cloudfront_info work with Python3 by using dict.update(dict) instead of dict += dict.

* Added changelog fragment for cloudfront_info fix
2020-01-31 14:37:36 -05:00
3dbc03d58a Try to load action plugin from the same collection as the module (#66701)
* Try to load network action plugin from the same collection as the module

* Alter tests to match

Just make sure the action plugin is as qualified as the module it is paired with
2020-01-31 12:49:37 -05:00
725bb4d173 Fix typo in shell_windows.py (#66964) 2020-01-31 11:48:28 -05:00
54520c4685 mysql_user: priv parameter can also be a dictionary (#66801)
* mysql_user: add priv_dict parameter

* add changelog

* priv can be string or dictionary

* fix example
2020-01-31 16:32:31 +01:00
813091cf94 Migrate ec2_vol_info to AnsibleAWSModule (#66979)
* Migrate ec2_vol_info to AnsibleAWSModule

* Enable ec2_vol_info tests

* Add changelog

* Update lib/ansible/modules/cloud/amazon/ec2_vol_info.py

Co-Authored-By: Sloane Hertel <shertel@redhat.com>
2020-01-31 09:55:10 -05:00
7968271559 Add migrated_to: community.grafana (#66981) 2020-01-31 12:12:21 +00:00
f1a30164c5 Fix 'container_default_behavior: no_defaults'. (#66601) 2020-01-31 10:45:59 +01:00
2a9ec8975f win_unzip - LiteralPath fix (#66972)
* win_unzip - LiteralPath fix

* Fix up Python sanity issues
2020-01-31 12:59:46 +10:00
d584584474 Reorganize ansible-test coverage code.
This change moves all code for the `ansible-test coverage` command into the `coverage` directory.

Each subcommand is split into a separate file.

Only minor spelling changes were made aside from code relocation.
2020-01-30 14:41:21 -08:00
2ea159eefd vmware_cluster_facts does not set hosts key
Since https://github.com/ansible/ansible/pull/61006 `vmware_cluster_info`
exposes a new key called `hosts`. The deprecated module
`vmware_cluster_facts` keeps the previous behaviour, and so we must keep
its test-suite unchanged.
2020-01-30 16:45:02 -05:00
5d4d9d40af ansible-test - Add 'get' to the list of bad choices for state (#66921)
* ansible-test - Add 'get' to the list of bad choices for state

* Changelog fragment
2020-01-30 22:38:47 +01:00
811c54a7a4 validate-modules - support deprecated_aliases (#66965)
* validate-modules - support deprecated_aliases

* Removed changelog fragment
2020-01-31 07:35:16 +10:00
4452f506a8 Split up filter integration tests. (#66962)
* Split out json_query filter tests.
* Split out urlsplit filter tests.
* Split out ipaddr filter tests.
* Split out urls filter tests.
* Split out mathstuff filter tests.
* Clean up core filter tests.
2020-01-30 12:49:54 -08:00
5112feeace Make get_bin_path() always raise an exception (#56813)
This makes it behave in a more idiomatic way

* Fix bug in Darwin facts for free memory
    If the vm_stat command is not found, fact gathering would fail with an unhelpful 
    error message. Handle this gracefully and return a default value for free memory.

* Add unit tests
2020-01-30 12:54:25 -05:00
c9a34ae33e mysql modules: fix the module's documentation (#66848) 2020-01-30 11:44:47 -05:00
c8568a5c94 Add documentation about vars used in roles at the play level (#66907) 2020-01-30 11:08:24 -05:00
adf73d47ec Remove unused imports from paramiko_ssh connection (#66948)
These were caught by flake8 testing for ansible.netcommon collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-30 11:01:34 -05:00
4273e84962 Upstream jinja has decided not to rename from jinja2. (#66880)
So we're going to keep our intersphinx labels as jinja2 to match what
upstream is doing
2020-01-30 10:57:50 -05:00
2728c2476e docs: Fixed "Edit on GitHub" link for plugin, cli (#66745)
Fixed sphinx theme to navigate "Edit on Github" link to locate correct
plugin, cli source in GitHub repo.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-30 10:55:46 -05:00
76809bbba2 testing: Enable AIX has a platform again 2020-01-30 07:37:41 -08:00
bf65e7a3f6 nxos_facts: Don't fail if faninfo isn't reported (#66866) 2020-01-30 10:23:21 -05:00
72e1716f29 Fix to gather facts include macro and tag (#66947) 2020-01-30 10:07:40 -05:00
e3190adcbb zabbix_host - added support for usermacros and tags (#66777) 2020-01-30 08:32:47 -05:00
5fdc9a61f0 docker_container: pass volumes only for anonymous volumes (#66600)
* Simplify code.

* Only pass anonymous volumes.

* Add changelog and update porting guide.

* Add integration tests.
2020-01-30 14:08:25 +01:00
57805b7def zabbix_proxy interface option documentation and argspec fixes (#66837)
* zabbix_proxy interface option documentation and argspec fixes

* Update changelogs/fragments/66837-zabbix-proxy-interface.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-01-30 14:06:44 +01:00
553997db25 Add new module cloud/ovh/ovh_monthly_billing.py (#65730)
remove useless 'state' parameter and update doc

remove useless module.params.get('state')

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py

add application_key, application_secret and consumer_key optional parameters

Add some example concerning ovh auth.
2020-01-30 12:16:11 +01:00
df1144ced7 Temporarily remove AIX from test matrix.
AIX provisioning is failing.
2020-01-29 20:32:27 -08:00
49d8d5ae33 Fix ansible-test tar format handling. 2020-01-29 20:31:54 -08:00
4fd2dce7f3 Testing: Add support for AIX platform (#65802) 2020-01-29 15:56:51 -08:00
eec6afd116 Explicitly set junit_family=xunit1 @ pytest config
This change hides the deprecation warning and protects from
failures in pytest==6.0.0

Ref:
* https://github.com/ansible/ansible/pull/66445#discussion_r372530176

Co-Authored-By: Matt Clay <matt@mystile.com>
2020-01-30 00:05:02 +01:00
479845a05c Expand Shippable test matrix. (#66912)
* Add 2 CI groups for AWS.
* Add 1 CI group for vmware.
* Add 1 CI group for CS.
* Add 1 CI group for posix.
2020-01-29 14:43:27 -08:00
6a1f82f174 url lookup - add options to match those in urls.py (#64892)
Add 'force_basic_auth' option
By default "force_basic_auth" option is set to False, with this adjustment it is up to the user if it wants to enforce basic authentication.
2020-01-29 16:45:25 -05:00
e2a57414f4 Remove with statement for pytest-mock unit tests
As per:
https://github.com/pytest-dev/pytest-mock#note-about-usage-as-context-manager
pytest-mock is not meant to be used within a `with` context or as a
decorator. Instead, pytest-mock will automatically unpatch the mocked
methods when each test is complete.

In newer pytest-mock, this use actually throws an exception and causes
the tests to fail.

This hasn't been hit in Ansible's CI yet, because the docker image
that the tests run in uses an older version of pytest-mock. However,
there is no constraint on the upper bound of pytest-mock in
test/lib/ansible_test/_data/requirements/constraints.txt which means
that when running the tests locally, outside of that docker image, the
tests never pass.

This patch removes the `with` context in each such case.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-01-29 13:29:40 -08:00
1156962cde Forbid state=(list|info) in modules via ansible-test sanity check
PR #66898

This change introduces a new sanity check with code
`parameter-state-invalid-choice` in the `ansible-test sanity`
validator. It enforces modules not to support `list` or `info`
as their `state`.

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
2020-01-29 21:06:36 +01:00
6e2fff1acc vmware_vswitch/test: clean up vmswitch_0002
Ensure `vmswitch_0002` get removed from ESXi2 at the end of the test.
2020-01-29 14:32:57 -05:00
e64b279ea1 Add CS smoketest group for CI. 2020-01-29 11:01:35 -08:00
6f1bb37feb When no pool quantity is set, then do not set quantity to 1 (#66807)
* Fixes #66478
* When no quantity is set, then candlepin server usually uses
  default value 1. When more quantities are required, then
  candlepin server can automatically choose correct minimal
  value.
2020-01-29 12:10:47 -05:00
9276dd2007 file - change warning to error (#66671)
When 'src' is specified without 'state', raise an exception
2020-01-29 10:51:34 -05:00
91063f40d6 tests: ipify_facts: retry on fail (#66897) 2020-01-29 10:43:40 -05:00
8ba324a33d VMware: shares and io limits support while adding new disk (#64087)
Fixes: #25714
2020-01-29 19:52:35 +05:30
72fbbbeb34 Typo correction (#66869)
* Corrected typo in documentation
* Corrected typo in the log statement
2020-01-29 19:46:43 +05:30
308723c3ca postgresql_idx: revert PR for 64138 (#66889) 2020-01-29 14:12:34 +00:00
4752547d35 ecs_tag: remove state=list (#66811)
* ecs_tag: remove state=list

* adjust tests
2020-01-29 10:30:53 +01:00
3c3cf50e7a Fix ansible-test coverage of ansible-connection. 2020-01-28 23:47:07 -08:00
21069c84d9 Fix ansible-test color ls logic. 2020-01-28 17:48:54 -08:00
428aaf7e65 Keep SSH authorized keys in ansible-test setup. 2020-01-28 17:48:54 -08:00
efd2dd8929 Add more ansible-test args to delegation config. 2020-01-28 17:48:54 -08:00
ee50792416 Add a --no-pip-check option to ansible-test. 2020-01-28 17:48:54 -08:00
0971a0e7bc Consolidate remote Shippable scripts. 2020-01-28 17:48:54 -08:00
86663abf37 all: fix all the the duplicate words (#66784) 2020-01-28 14:06:40 -05:00
b482857fd3 Update conjur_variable.py (#66763)
Update the link in the Conjur documentation to point to the correct current URL
for information on Conjur machine identity.
2020-01-28 13:15:12 -05:00
9656811e7c Fix virtual private gateway filters reference link (#66772) 2020-01-28 13:03:12 -05:00
35652ca788 Add tests to make sure that the documented 'elements' matches that defined in argument_spec (#66385)
* Add tests to make sure that the documented 'elements' matches that defined in argument_spec

* Mass-add test/sanity/ignore.txt
2020-01-28 12:33:03 -05:00
3461c682c3 Add mechanism for storing warnings and deprecations outside of AnsibleModule (#58993)
* Move warn() and deprecate() methods out of basic.py
* Use _global_warnings and _global_deprications and create accessor functions
    - This lays the foundation for future functions being moved outside of AnsibleModule
       that need an interface to warnings and deprecations without modifying them.
* Add unit tests for new warn and deprecate functions
2020-01-28 12:12:14 -05:00
cc2376b782 include_vars - fix stack trace when run ad-hoc with dirs parameter (#66581)
Add integration test

There are a number of other parameters that result in stack traces as well when this module is used ad-hoc. I'm not sure if we're interested in fixing them all since this module isn't meant to be run ad-hoc.
2020-01-28 11:50:34 -05:00
3f16752ed2 Remove misleading slash on prefix examples (#66842)
##### SUMMARY
S3 lifecycle rule prefixes starting with slash (/) have no effects. If an S3 bucket contains a file 'apache.log' under the (virtual) folder 'logs/', for the lifecycle rule to be effective the prefix to be configured must be 'logs/'. If you put '/logs/' (with a trailing slash) as a prefix the file will never be matched by the lifecycle rule.
2020-01-28 11:36:52 -05:00
b74ca2fe4f ovirt_network: correct when not specified external_provider (#66859) 2020-01-28 11:08:46 -05:00
d385a648c4 uri: Document cookies_string, cookies and content (#66612)
The example with set_cookie value in cookie header can fail if the server
has set many cookies. The set_cookie value is the cookies sent by server in
set-cookie header, not what the client should send in cookie header to
server.

#33792 introduced cookies_string to solve the problem, but did not update
the uri module example.

content and cookies were also missing from RETURN.
2020-01-28 10:59:29 -05:00
365f2aaed1 get_url: remove deprecated headers string format (#66649)
Fixes #61891
2020-01-28 10:39:40 -05:00
abc8b0ae73 This was changed to python 2.7 but should have remained python 2.6 (#66836)
* Modules are still python-2.6+ unless there's a compelling reason not
  to be.
2020-01-28 09:32:03 -06:00
5ff899662d Add sanity test to require elements entry when argument type=list (#66386)
* Require elements entry for lists

* Bulk add initial test/sanity/ignore.txt
2020-01-28 10:23:22 -05:00
6901c9c61c botmeta: Fix f5_modules typo (#66847) 2020-01-28 07:23:28 -05:00
e3ce0d3612 Assign team_aireos to team_ansible (#66798)
Since there are no members in team_aireos, assign maintainership
to team_ansible for now.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-28 12:10:53 +00:00
78e666dd39 vultr: improve handling of dicontinued plans (#66792)
* vultr: improve handling of dicontinued plans

* add changelog
2020-01-28 10:46:17 +01:00
2dc9841806 doc: Fix tiny typo in example: change --> changed (#66835)
##### SUMMARY
Fixed another tiny typo: change --> changed

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-01-28 10:34:36 +01:00
94f30b3815 Migrate ServiceNow modules to Collection (#66818)
* adding snow files

* remove duplicate
2020-01-28 08:05:19 +00:00
5409904c35 vmware_cluster_facts: adds list of host in cluster (#61006) 2020-01-28 11:43:46 +05:30
65aedc5d4a VMware: Change node_wwn and port_wwn for FC HBA to hexadecimal value
Fixes: #63045
2020-01-28 09:46:29 +05:30
5c1fe78685 Move CI coverage stub to sanity/5. (#66827) 2020-01-27 16:19:49 -08:00
cba0feab18 folder support on gcp_compute (#66511)
* folder support on gcp_compute

* fixed issues associated with projects with no vms

* linter fix

* more linter

* linter
2020-01-27 22:37:14 +00:00
965854fbd2 Add constraints for Jinja2 on Python 2.6. (#66826)
* Add constraint for Jinja2 on Python 2.6.

* Fix constraint in inventory_aws_conformance test.

* Add constrraints for template_jinja2_latest test.
2020-01-27 14:01:34 -08:00
4ca0c7f116 Fix case sensitivity for lookup() (#66521)
This brings consistency to lookup(), with_ and ansible-doc.

Fixes #66464

* Add a porting guide entry
2020-01-27 15:09:45 -05:00
3ce6440515 vmware_export_ovf: increase default timeout
I consistently reach a timeout with the current (10s) timeout. This
commit increases the default value to 30s, this should simplify the life
of our users.
Also, the documentation was incorrect. The value is in second, not minute.
2020-01-27 13:57:01 -05:00
bdceab379e vmware: adjust the module/Zuul jobs mapping
- vmware_host_active_directory: we need an Active Directory to run the
  test
- vmware_vm_storage_policy_info: we just need a vcenter
2020-01-27 13:55:58 -05:00
8cff585891 Schema validation for argument_spec (#65747)
* Start of schema for argument_spec

* Add changelog.

* Remove superfluous import.

* Update ignore.txt

Co-authored-by: Matt Martz <matt@sivel.net>
2020-01-27 17:26:46 +01:00
8f2e30a0cf Update botmeta with migrated openstack modules (#66789) 2020-01-27 14:21:58 +00:00
055cf91d02 zabbix_template - enable new update rule to delete missing linked templates (#66747)
* enable new update rule to delete missing linked templates

New update rule is available from 4.0.16 and 4.4.4 up. Add check for version and enable new update rule.

fixes #66720

* adding fragment file

* Update zabbix_template.py

* Update zabbix_template.py
2020-01-27 09:20:45 -05:00
99d7f15087 Mark the hacking AWS policies as owned by team_aws (#66793) 2020-01-26 22:41:10 +05:30
d7a1917c17 ovirt_host: add iscsi portal (#66750)
* ovirt_host: add iscsi portal

* correct version_added to 2.10
2020-01-25 08:18:34 -05:00
f1ec48429a Add changed condition (#66230) 2020-01-25 14:01:17 +08:00
a1f6c611b7 Add team_aws for aws modules, and add new maintainer (#66774) 2020-01-24 18:13:40 -05:00
0ceac57bc6 AnsibleAWSModule related cleanup (batch 2) (#65987)
* Remove redundant use of ec2_argument_spec where we're using AnsibleAWSModule

* Use module.client() instead of the get_aws_connection_info/boto3_conn combo.

* AnsibleAWSModule handles 'HAS_BOTO3'

* Remove unused imports

* Update error message that lambda_policy integration test is looking for when the region's missing

* Revert redshift and s3_bucket
2020-01-24 13:39:01 -07:00
70017e2679 postgresql_db: add dump_extra_args parameter (#66717)
* postgresql_db: add dump_extra_args parameter

* add changelog

* fix doc

* fix example
2020-01-24 13:32:54 -05:00
4d1e21bf18 mysql_user: make sure current_pass_hash is a string before using it in comparison (#64059)
* make sure current_pass_hash is a string before using it in comparison

* add changelogs/fragments file

* fix changelogs/fragments file: it is actually a bugfix, not a minor change
2020-01-24 13:32:15 -05:00
9df9ed4cd3 Reinstall i18n files for PostgreSQL tests (#66734)
I am removing these from the test image to reduce its size a bit.
2020-01-24 12:16:40 -05:00
8e195adda5 display - remove extra new line after warning message (#65199)
Add unit tests for display
2020-01-24 12:10:04 -05:00
85b5f89ed6 ecs_tag and integration tests for new feature request (#66603)
* Added integrations test for ecs_tag
Testing invalid cluster test for the expected message.
Add idempotency test is  for adding tests to service and task_definition.
2020-01-24 10:09:36 -07:00
1152774f92 git - add an 'archive_prefix' option (#66067)
Add integration tests for new option
2020-01-24 09:42:47 -05:00
bbbdc1c25c throttle: fix linear based strategies (#65422)
* throttle tests: fix detection of parallel execution

The test wasn't able to detect if too many workers were running.

On my laptop:
- without this change, the 'throttle' target takes ~20 seconds
- with this change, the 'throttle' target takes ~70 seconds
- 1 second isn't long enough to encounter the issue

* Fix throttle test when strategy is 'free' based

'free' strategy allows multiple tasks to be executed in parallel: use
one 'throttledir' per task.

Use 'linear' strategy with a dedicated play for cleanup/setup tasks

* throttle: reset worker idx before queuing a new task

* TestStrategyBase: define task.throttle

otherwise '1' will be used instead of the default value due to the
following expression being equal to '1':

    int(templar.template(task_mock.throttle))

Co-authored-by: James Cammarata <jimi@sngx.net>
2020-01-24 08:18:08 -06:00
7bbf4ad7d6 Modifying output for VM already present (#66705)
Signed-off-by: Anusha Hegde
2020-01-24 08:09:05 -05:00
de2985df84 icx_vlan: Removed byte type regex in string matching (#66715) 2020-01-24 18:28:51 +05:30
ff35103bf9 Add external refs to the GH issue template chooser (#66743)
This change replaces a dummy template for security issues with a
proper reference to the doc. It also adds pointers to a few other
useful community pages.

Ref:
https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
2020-01-24 07:56:03 +00:00
68ab8c23be Network prompts (#66584)
* add network prompt examples and module examples

* Update docs/docsite/rst/network/user_guide/network_working_with_command_output.rst

Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>
2020-01-23 18:02:16 -06:00
b16525b841 [aws] integration tests for ec2_vol (#66193) 2020-01-23 15:34:06 -07:00
8b63da7b43 Fix ansible-test egg-info directory detection. 2020-01-23 13:21:15 -08:00
913037731f Update examples in documentation for env lookup plugin (#62662) 2020-01-23 15:27:30 -05:00
9e8fb5b7f5 galaxy: fix AttributeError on empty requirements.yml (#66726)
* galaxy: fix AttributeError on empty requirements.yml

* add changelog
2020-01-24 06:06:44 +10:00
5c721e8a47 Add new configuration parameter to make Windows async startup timeout configurable (#66670)
* Add new configuration parameter to make this timeout configurable

* Rename keys to be more correct and reformat exception message for whitespace handling

* Rename config away from default prefix. Add vars element and associated changes to support.

* Update 65001-allow_configuring_async_startup_timeout.yml

Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
2020-01-24 06:04:52 +10:00
14cc63dc0f Switch intersphinx label from jinja2 to jinja (#66703)
* Switch intersphinx label from jinja2 to jinja

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2020-01-23 14:09:17 -05:00
a4b59d0213 pamd: Fix AttributeError when removing the first or last rule (#66398) 2020-01-23 14:08:42 -05:00
e368f788f7 Update BOTMETA.yml
* remove nitzmahone from Azure and non-core Windows notifications
2020-01-23 10:48:40 -08:00
4a0c875447 Working Cisco IOS macro editing (fixes #55211) (#55220)
* Working Cisco IOS macro editing (fixes #55211)

* Working Cisco IOS macro editing [fixed pylints] (fixes #55211)

* Added integration tests for edit_macro

* Added conditional integration tests for ios_config macro

* Cosmetic fix: when near block for added conditional integration tests for ios_config macro

* Move teardown to always for block
2020-01-23 21:19:15 +05:30
81aabdc94f Update botmeta to reflect F5 migrated content (#65885)
* update botmeta with f5 migration destination

* added terminal and doc_fragments, removed modules_utils
2020-01-23 10:05:18 -05:00
ac881b0026 Add section to aws devel guidelines about module_defaults (#66699) 2020-01-23 09:47:51 -05:00
72fbed2c61 postgresql_user: add comment parameter (#66711)
* postgresql_user: add comment parameter

* add changelog

* fix CI
2020-01-23 14:34:50 +00:00
e646bd08e1 zabbix_template - fixing errors linked templates and dump/imports (#66463)
* Fixing errors on empty linked templates

fixes #66417

Line 409 fixes KeyError if existing template has no linked templates - as Zabbix API isn't returning an empty array either.
Line 417 is needed to mark as changed if new/modified template has no linked but existing one has.
Line 442 is needed to actually update even if link_templates was None.

* decode parsed xml root

fixes #66466

Line 533: without .decode() the ET.tostring on python3 returns byte-like object

* Create 66463-zabbix_template-fix-error-linktemplate-and-importdump.yml

* Update changelogs/fragments/66463-zabbix_template-fix-error-linktemplate-and-importdump.yml

Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>

* Update changelogs/fragments/66463-zabbix_template-fix-error-linktemplate-and-importdump.yml

Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>

Co-authored-by: Dusan Matejka <D3DeFi@users.noreply.github.com>
2020-01-23 08:22:19 -05:00
eb3d081c11 Add lun for azure_rm_manageddisk (#66153)
* add lun for azure_rm_manageddisk

* add whitespace

* Change condition
2020-01-23 07:51:20 -05:00
a589b10b26 Freeipa: Support for homedir in ipa_user (#49151)
Add support for user homedirectory in ipa_user module.
2020-01-23 16:08:59 +05:30
fc6476bd72 VMware: Handle multiple tags with different category (#66465)
vmware_tag_info used to return dict of tag information which caused
data loss when there are multiple tags with same name and different category ids.
This fix will add additional fact "tag_info" which will deprecated existing fact
"tag_facts".
The "tag_info" is a list which handles multiple tags with same name.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-23 10:15:57 +05:30
0da13469d3 Add a script to update the intersphinx inventory (#66646)
* Add a script to update the intersphinx inventory files

* We're about to add intersphinx inventories for separate ansible docs
  so we need an easy way to update them.  Also, we should be updating
  these cache files for other upstreams occassionally as well.  With a
  script, we can add updating them to a release process.
* Now that we don't know what the version of the cache is, change the
  filenames to not contain versions.

* Update the intersphinx cache files with the latest upstream versions

Results of running:

hacking/build-ansible.py update-intersphinx-cache -o docs/docsite -c docs/docsite/rst/conf.py

* Add a comment to the configuration file which says how to structure the intersphinx mapping and why.

* Update docs/docsite/rst/conf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-01-22 17:20:02 -05:00
cb8ce7159d Docs: clarify that roles do not inherit collections set in a playbook (#66667)
Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-01-22 15:08:38 -05:00
05e034f899 Arbiter change and test additions (#59883) 2020-01-22 19:30:52 +00:00
b8a36e5950 Migrate azure_rm inventory to collection (#66693)
* migrate azure rm to collection

* missing :
2020-01-22 19:29:30 +00:00
fabb2eb555 mysql_db: add skip_lock_tables option (#66688)
* mysql_db: add skip_lock_tables option

* add changelog fragment
2020-01-22 20:19:49 +01:00
a412e4d9fd Add validate_collection_path function (#66441)
* Add validate_collection_path function

Utility function for ensuring a collection target ends with 'ansible_collection'

* Fix bad syntax

* Correct docstring
2020-01-22 10:46:41 -05:00
ec371eb227 Set HostVars._variable_manager's attrs (#65508)
When HostVars are part of the data that goes through (de)serialization
when being passed from a worker process to the main process, its
variable manager reference loses some of its attributes due to the
implementation of __getstate__ and __setstate__ (perf utilization).
Since HostVars already has those attributes, use __setstate__ to assign
them.

Fixes #65365
2020-01-22 05:57:09 -05:00
0c4f167b82 fix 66530 (#66654) 2020-01-22 13:35:51 +05:30
ebf21bb48d Fix ansible-test inventory delegation. 2020-01-21 22:37:14 -08:00
5c158755fc Fix fact gathering for sensor-groups (#66439) 2020-01-22 10:49:12 +05:30
934d6b235b Add --venv-system-site-packages to ansible-test. 2020-01-21 17:32:29 -08:00
8f02022353 Remove unstable from aws_acm integration test.
The quota for the CI account has been increased, so tests are once again passing.
2020-01-21 17:22:09 -08:00
c58d8ed1f5 Improve deprecate sanity check; remove deprecated features which should have been removed for 2.9 (#65745)
* Update deprecation check.

* Remove support for check_invalid_arguments.
2020-01-21 16:58:26 -05:00
0b503f6057 Docs: User Guide overhaul, part 3 (#66371) 2020-01-21 16:57:55 -05:00
20eb1dca99 Update Galaxy docs to use "token" rather than "API key" (#66644)
We have called an API token many things. I changed the command line argument to
"--token", so now I'm unifying the documentation. I looked at both Galaxy and
Automation Hub and Galaxy is the only place that still uses the term "API Key",
which it could be argued should change.
2020-01-21 15:13:25 -05:00
d8c2f4738e CI is hitting 'maximum number of 2200 certificates' again, marking aws_acm unstable (#66665) 2020-01-21 15:03:03 -05:00
2b7393141f reboot - add boot_time_command parameter (#62680)
Allow the built in commands for checking boot time to be overridden. This is mainly for containers and other odd systems where it would add too much complexity to the plugin code to try and discern the correct command to use.
2020-01-21 13:42:32 -05:00
617fbad743 synchronize - fix password authentication (#66542)
On Python 2, leave all fds open since there is no mechanism to close specific fds with subprocess.Popen() on Python 2

Add unit tests.

Co-authored-by: Matt Martz <matt@sivel.net>
2020-01-21 10:43:56 -05:00
986c9cf6a1 Docs: Fix collection adjacent folder tree (#66490)
##### SUMMARY

Previously folder tree example for collection adjacent to the current playbook were displaying a subfolder below the playbook instead of being a sibling.
2020-01-21 10:20:37 -05:00
c423b1f213 dev_guide: Correct path to ansible-test requirements files (#66626)
The requirements path was old due to file relocation in
commit d651bda123.
2020-01-21 10:16:48 -05:00
8f6f4d62df Update win_package.py (#66658)
##### SUMMARY
<!--- Your description here -->
Replaced wrong registry paths with correct ones (HKLM:\, not HKLM:).
2020-01-21 10:06:41 -05:00
e38217f7fd ovirt_vm: add docs about importing ova (#66652) 2020-01-21 05:08:00 -05:00
1ee47a5969 Fix flake8 errors for junos tests (#66645)
Deal with F841 local variable foo is assigned to but never used
errors.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-21 08:57:39 +01:00
14ae3ba8c0 Fixed argument spec for multiple modules - Part II (#65497)
This change contains fixes for argument spec and respective datatypes.
Created separate PR since these changes might alter the behavior of these modules.
Will need shipit from individual module owner(s).

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-21 11:37:38 +05:30
04b60624ef Update vmware_cluster doc (#66630)
Missing delegate_to directive on Delete Cluster example task
2020-01-21 08:18:43 +05:30
22fe22f796 yum - fix bug where enablerepo is not honored when disablerepo all (#66557)
Fixes #66549

The inefficiency improvement
https://github.com/ansible/ansible/pull/63713 introduced a bug where
`enablerepo` was not being honored if combined with
`disablerepo="*"`. This fixes that issue.

Signed-off-by: Adam Miller <admiller@redhat.com>
2020-01-20 14:26:36 -05:00
f9bc53e23d fix closing quotation mark in copy module(#66619)
fix from "ntp.conf to "ntp.conf" in copy module documentation
2020-01-20 17:06:17 +05:30
b620134f9c VMware: Add example of specific folder in VM fact gathering (#66613)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-20 13:56:32 +05:30
1befb52321 VMware: add properties option to vmware_datastore_info module (#62940)
* add_properties_option_to_vmware_datastore_info
* fix document indent error
* add changelog file for vmware_datastore_info
2020-01-20 13:47:13 +05:30
7fabb28d22 nxos_gir timeout fixes (#66043)
* nxos_gir timeout fixes

* additional setup/teardown cleanups for sanity test

* Add timeout extension comment to module header

* lint

* rework logic to use action plugin
2020-01-20 12:45:49 +05:30
986be77337 vmware_host_powermgmt_policy/test: just one esxi (#66515)
Since the run the test playbook in a vcenter+1esxi scenario, there is no
need of second host.

The commit also simplify the logic of the test.
2020-01-20 11:31:25 +05:30
2d0ccdc98c vmware_host_acceptance/test: fix the functional test (#66576)
Ensure the functional test is actually run. It works fine on a real
environment.
2020-01-20 11:21:53 +05:30
7129453cd9 Maven Central requires TLS (#66611)
Fixes: #66609
Maven requires TLS as of 2019-01-15
2020-01-20 11:16:49 +05:30
3bf8b1d1c9 jenkins_job module: fix for python3 (#54958) 2020-01-19 12:57:54 -05:00
4181717af6 Removed "encode" on color in get_job_status (#66585)
* Removed "encode" on color in get_job_status

In Python3 (tested in 3.8.1), variable.encode('utf-8') returns as a byte string versus just a string in Python2 (tested in 2.7.17). Removed encode method on return of get_job_status when color exists and wrapped in str() for good measure.

* Swap str() for to_native() per feedback
2020-01-18 17:36:27 -05:00
f46af19702 Revert "eos_config: Added fix for bug #54400 - support for !! in config mode (#63694)" (#66591)
This actually breaks iosxr_config, revert for now to make tests passing
again.

This reverts commit 7ddf7474d3.
2020-01-18 14:22:26 -05:00
5db00a05b6 Disable mongodb_user test (#66595) 2020-01-18 07:43:49 -05:00
875ac4b7a5 Fix a tiny typo (#66589)
Fixes a very small typo: as --> a in playbook_debuggers.rst
2020-01-18 10:35:31 +05:30
f15050b09e Change package name in docker_setup integration test (#66572)
* Change package name

* Retry to hopefully get a good mirror
2020-01-17 23:41:42 -05:00
dd68458da2 Add missing gcp modules to module defaults (#66388)
* Renamed gcp_*_facts to gcp_*_info
* Added missing GCP modules to GCP module defaults group
2020-01-18 09:51:27 +05:30
a3dfabfdba vmware_host_ipv6/test: reset status before new check
Ensure a disable IPv6 before we try to re-enable it. This to get a
consistent result.
2020-01-17 16:57:23 -05:00
5280042901 vmware_host_dns: consistent rslt when name changes
This commit address a problem in static mode, if the hostname change,
`host.name` value with change too. And as a result:

    results['dns_config_result'][host.name]

will be initialized.
We now record the initial hostname first, and uses it as the key for the
results.

This commit also ensures hostname and search domain change are detected if
`instance.dnsConfig.dhcp` is true.

Finally, if we target a cluster, the `changed` result will depend on the
number of nodes.
2020-01-17 16:57:12 -05:00
b183d36c53 vmware_export_ovf/test needs an ESXi
Ensure the `vmware_export_ovf` test-suite runs with at least one ESXi.
2020-01-17 16:56:47 -05:00
437b8b3807 vmware_export_ovf/test: don't use a rescue block in test
By using a `rescue` block, we can potentially hide a really problem in the
block and return a success. This is a bit problematic for a functional
test.
2020-01-17 16:56:47 -05:00
ae6317004e vmware_guest_network/test: create the dvswitch
Ensure the DVSwitch and the portgroup are created by
`prepare_vmware_tests`.
2020-01-17 16:56:13 -05:00
077a8b4898 podman - fix rootless container copy no pause (#66583)
Fixes #66263

Signed-off-by: Adam Miller <admiller@redhat.com>
2020-01-17 16:41:10 -05:00
7ae5331218 update ismount() to match upstream from cPython (#64586) 2020-01-17 16:32:14 -05:00
864a3fd59d VMware: Add advanced settings to vmware_cluster_drs (#66233)
* VMware: Add advanced settings to vmware_cluster_drs

* Add DRS advcanced settings example
2020-01-17 16:23:19 -05:00
9b7198d25e file - change _diff_peek type in argument_spec (#60428)
* Add integration tests
* Handle error in _get_diff_data()
* Change to warning rather than error
* Also change failure to warning in assemble action plugin
2020-01-17 16:02:28 -05:00
9a51dff0b1 Rename private function (#66577)
Make find_existing_collections() a public function since it is being used across mulitple files now to support listing and verifying collections
2020-01-17 15:27:15 -05:00
87fd93f140 Added fix to bug #64568 (#64621) 2020-01-17 15:23:02 -05:00
7ddf7474d3 eos_config: Added fix for bug #54400 - support for !! in config mode (#63694)
* Corrected lint errors

* Added fix for bug # 54400

* Resolving conflicts
2020-01-17 15:22:38 -05:00
a7e4479d01 Fix DNF idempotency. (#66209) 2020-01-17 11:22:06 -05:00
6b21f56b97 fix typo in EXAMPLES (#64932) 2020-01-17 10:23:52 -05:00
8b0fb9f290 Fix flake8 error with test_eos_lacp_interfaces (#66552)
F841 local variable 'commands' is assigned to but never used

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-17 09:32:19 -05:00
148d72d6e2 vmware_vcenter_settings: Specify defaults inside parameter dict (#59546)
* vmware_vcenter_settings: Specify defaults inside dictionaries
* Add default to documentation and fix bug in example
2020-01-17 19:25:13 +05:30
b59fa134be Fix indent on example of set_fact module (#66554)
Fixed incorrect indent on example section in set_fact module's example section
2020-01-17 13:11:43 +05:30
9fd66556a6 VMware: new module to clone VM/template Cross-vCenter (#66156)
* Adding documentation and integration test for the new module
* Correcting typo
* removed unused if else block
* changing error messages
* Addressed review comments
* resolving sanity error
* fixed typo in vmware.py
* Added support for datastore cluster
* adding state parameter instead of power on fixed few more review comments
* Documentation update
* Updating argument
2020-01-17 13:08:42 +05:30
84b68aa05f gitlab_project_variable: Remove sensitive information (#66556)
Redact GitLab Project variables which might include sensetive information
such as password, api_keys and other project related details.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-17 01:42:15 -05:00
cd760782c9 vmware_rest_client: define 'port' parameter (#66506)
Ensure the `vmware_rest_client` based modules accept the `port`
parameter.
2020-01-17 08:11:24 +05:30
5edd076241 Update return doc in python_requirements_info (#66519)
not_found is a list and not dict
2020-01-17 08:10:14 +05:30
1f340721a7 ansible-galaxy - add "--token" command line argument (#66376) 2020-01-16 12:51:21 -08:00
0ab0e1556b eos_lacp_interfaces: Add unit testcases to eos_lacp_interfaces (#64455)
* Add unit testcases to eos_lacp_interfaces

* Add unit testcases to eos_lacp_interfaces
2020-01-16 15:07:57 -05:00
599cc0bdfa restructure headings and copy-edit shell completion (#66479)
* restructure headings and fix shell completion, apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2020-01-16 10:30:26 -06:00
0fa556f751 Fix flake8 errors related to vyos.vyos collection (#66516)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-16 08:22:51 -05:00
3b764c6dcb Add diff and check_mode support to os_server (#62206)
* don't mix " and '

* rename functions that perform changes

* add diff, reorganize _present/_absent functions

* update tests to match function reorg

* add result to _exit_hostvars and removal of possibly sensitive information

* shallow copy dict for proper diff, add check_mode

* set check_mode to False for unit tests

* move _parse_meta back to it's original place

* use get_openstack_vars for diff when not in check_mode

* add changelog fragment
2020-01-16 10:39:54 +01:00
ea6bc98398 Foreman: support for want_collectionhosts and want_ansible_ssh_host
* Add support for want_collectionhosts and want_ansible_ssh_host in foreman plugin
2020-01-16 14:55:45 +05:30
450d9c4a04 hostname - Add Void Linux distribution (#66499)
Add support for Void Linux in hostname module.
2020-01-16 14:30:22 +05:30
bc37ea96d5 Vmss scale in policy (#66512)
* azure_rm_virtualmachinescaleset: add scale_in_policy and terminate_event_notification

* azure_rm_virtualmachinescalesetinstance: add vmss instance protection policy support
2020-01-16 09:24:39 +08:00
e459eac565 Use UTF-8 without a BOM for win coverage (#66510) 2020-01-16 09:52:05 +10:00
3bcb664497 Fixes #65590 add pywinrm version explanation (#65591)
* add pywinrm version explanation

* Update windows_winrm.rst

Changed pywinrm explanation to note style

* Add period

Co-authored-by: Jordan Borean <jborean93@gmail.com>
2020-01-16 08:22:38 +10:00
eab385e006 Update and cleanup Arch packaging (#64747) 2020-01-15 16:01:33 -05:00
ee3dcb4d35 use query instead of q in "if files exist" example (#66409)
##### SUMMARY
It's not obvious that `q` is the same as `query` (which is referred to in the name of the task) and using long-names is generally preferred in examples.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-01-15 14:19:16 -05:00
d5c5cb5a17 podman_image: Use provided credentials when pulling image (#66372)
* Use credentials when pulling from a remote registry
2020-01-15 12:47:12 -05:00
1cb634a3ab Add a metadata property for CollectionRequirement (#66370)
* Add a metadata property for CollectionRequirement so the _metadata attribute doesn't need to be accessed directly

* changelog
2020-01-15 12:40:26 -05:00
b9b2ddc580 prepare_vmware_tests: no waiting loop during DS probing
For a refresh of the datastore list on the vcenter, this before we
check the present of the newly attached datastores.

A lot of tests depend on the presence of the DS, and this little
change allow us to save =~ 45s everytime.
2020-01-15 12:39:56 -05:00
f956581846 vmware_host_auto_start: enable the tests
- remove the unsupported alias
- refactoring
- move the hosts outside of the cluster to avoid any conflict with DRS
- import the `prepare_vmware_tests` role
- does not work with govcsim
2020-01-15 12:39:31 -05:00
af3603f9ee Revert "Allow httpapi for resource modules (#62843)" (#66483)
While this does properly pass our testing for ansible/ansible devel
branch, it is currently breaking our collection testing for 2.10.

Specifically, this would mean ansible.netcommon would need to directly
import arista.eos or cisco.nxos collections, causing a circular dependency.

This reverts commit e266e5f8b6.
2020-01-15 12:25:38 -05:00
3103fd62dd vmware_vmotion/test: ensure we can run tests
Some adjustments to be able to run the test-suite properly:

- Starts with the ESXi out of the cluster to be able to deploy the
  VM on a proper host consistently
- Ensure the resource pool exists
- The resource pool is called `DC0_C0_RP1`, not `Resources`
- Avoid an exception if we try to move a non existing VM.

Put the test in the zuul/vmware/vcenter_2esxi group.
2020-01-15 11:50:04 -05:00
68a8cc2b1f vcenter: don't bind container on <1024 port
Bind the govcsim service on port 1443, this way we don't need root privilege
to start the container. This allow us to use ansible-test with podman
seamlessly.
The commit also avoid the mapping of port 80. We don't need it.
2020-01-15 11:49:42 -05:00
afb71c14bd VMware: Use existing DVPG network in vmware_guest_network (#65994)
* Handle all cases of networks

Fixes: #65968

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-15 21:56:19 +05:30
69f9c3c8eb add one note to help ansible user to understand the requirements to (#65969)
execute iosxr_command module

Signed-off-by: Peng Xiao <xiaoquwl@gmail.com>
2020-01-15 12:35:07 +05:30
257ac9d175 Fortios: Correct underscore_to_hyphen API (#66119)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-15 10:35:57 +05:30
222b6dec8a vmware_guest_serial_port: avoid autoselect_datastore (#66481)
Avoid `autoselect_datastore` until #58541 gets fixed.
2020-01-15 09:44:46 +05:30
317c7fe144 vmware_inventory: define si outside try/except (#66482) 2020-01-15 09:43:23 +05:30
62991a8bdd terraform: Remove line that is suppressing output being shown (#66322)
* remove the line that is suppressing the output being shown when running
terraform from ansible
* Address #56934 and #57044
* added changelog for bug fix for missing terraform output

Co-authored-by: Adam <adam.lemanski@gmail.com>
2020-01-15 09:42:58 +05:30
73d343b7aa Enforce new setuptools for building official dists 2020-01-14 17:14:59 -08:00
e266e5f8b6 Allow httpapi for resource modules (#62843)
* Redo tests to be transport agnostic

cli -> eos config

Redirect connection for httpapi
2020-01-14 14:26:10 -05:00
6044325dec Bug fix for #53271 (return commands for cli_config) (#61808)
* cli_config return commands bug fix

* Spacing error

* Added notes section

* Spacing error

* Spacing error

* Spacing error

* Spacing error
2020-01-14 11:32:28 -05:00
9272e3d547 Fix Bug (#64553) 2020-01-14 11:08:38 -05:00
1b3ca349eb RoleRequirement - Include stderr in the error message (#66006)
* RoleRequirement - Include stderr in the error message if there's a non-0 return code

* Don't try to concatenate str and bytes

Co-Authored-By: Sam Doran <sdoran@redhat.com>
2020-01-14 09:46:23 -05:00
b06e78c16c make: use -f instead of --file to aid in portability (#65880)
`make` on FreeBSD (and others) has support for an option `-f` to specify a `Makefile`, whereas GNU make uses `--file` or `-f`. In the interest of portability use `-f` which covers both.
2020-01-14 06:01:13 -05:00
6f04f87a13 Deprecate Windows 2008, and 2008 R2 (#66257)
* Deprecate Windows 2008, and 2008 R2

* Remove shippable nodes

* Update windows_faq.rst

Be less specific about 2008/R2 timeframes

* Update setup.ps1

tweak warning text

Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
2020-01-14 11:22:39 +10:00
9a1329153e ec2_vol module filtering bug (#65960)
* Update ec2_vol.py

When `name` is specified, it ignores `zone` filter. That is you could not have same tag:Name in different zones.

* Add changelog fragment
2020-01-14 11:09:06 +10:00
ad341ea4bb Fix unarchive integration test failure due to rpm error (#66420)
* Fix unarchive integration test failure
* Do not cleanup pip packages
2020-01-13 16:23:31 -08:00
3db1ac4f56 Ignore warnings in ansible-test environment check. 2020-01-13 16:16:55 -08:00
4fedc10035 added guidelines for seo; (#66431) 2020-01-13 15:46:44 -06:00
51e5b714e0 Add test constraint for setuptools. (#66426)
* Add test constraint for setuptools.

* Update pip test to work on centos6 container.
2020-01-13 13:09:33 -08:00
9dd548ebb7 Update developing_python_3.rst (#66249)
##### SUMMARY

fix link § redirection

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-01-13 15:40:37 -05:00
3a2257c45c net_facts modules: Don't warn about defaults changing if they're not being used (#66270) 2020-01-13 11:36:01 -05:00
223e1675f4 vmware_local_role_info/test: avoid json_query
Refactoring to avoid the use of `json_query`. As a bonus point, we now
also ensure `NoAccess` role has no provilege.
2020-01-13 09:42:14 -05:00
16d3f6bcbb vcenter provider: do not set env var
Some secrets are exposed because of the environment variables. The
Ansible variables are now enough, we don't need to expose the envvar
anymore.
2020-01-13 09:41:43 -05:00
d64b49e8a0 Delete linter ignore lines for keycloak modules (#66406)
* linter: auth_client_id is not required, default value

Delete the lines linked to this mistake in ignore.txt.

* doc: state is not required
2020-01-13 10:41:07 +00:00
3de2575063 Add proxy type passive example to example block of zabbix_proxy (#66400) 2020-01-13 04:40:12 -05:00
b7dfcfa0b4 Check vars against Mapping in DEBUG (#66355)
When ANSIBLE_DEBUG=1, vars are VarsWithSources now which is a Mapping.
Check vars against Mapping instead of dict.
2020-01-13 10:04:32 +01:00
b070fd1630 Fix typo. (#66403) 2020-01-13 07:27:07 +01:00
654b9e2754 Add collection support with local for supported network platforms (#66302)
* Add collection support with local for supported network platforms

*  The legacy behavior of network action plugins using persistent
   the framework is to override the connection=local with the actual connection type (network_cli/netconf/httpapi) based
   on the value of transport option in provider.
*  After the actual connection plugin is identified try to load it from
   `ansible.netcommon` collection, if it fails load it from ansible
   core. This is done to work with Ansible 2.10 and also maintain backward compatibility for
   Ansible 2.9 version to ensure it works with network collections.
*  To support this need to pass collection_list value to connection
   plugins. As in case of connection=local it loads `persistent`
   connection within action plugin which in turn invokes `network_cli`
   or `netconf` connection. Similarly `network_cli` connection plugin invokes
   `terminal` and `cliconf plugins and `netconf` connection plugin invokes `netconf`
   `plugins` based on value on `ansible_network_os`.
*  Add deprecation warning for connection=local support and
   provider support for applicable platforms

* Fix CI failures
2020-01-13 09:49:55 +05:30
5c04f25245 ec2_lc: Update example to use snapshot id (#66064)
Fixes: #52085

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-13 13:13:13 +10:00
a79ca57d22 Fix aws_ssm connection plugin. (#66393) 2020-01-12 23:59:25 +01:00
663f9cda25 Disable failing tests. (#66391) 2020-01-12 23:25:11 +01:00
c380b18dcf openssl_* modules: allow direct input for some files (#66384)
* Allow to not read content from file.

* Allow to feed content directly into _info modules.

* Allow to feed non-primary content into openssl_certificate, openssl_csr and openssl_publickey.

* Rename changelog.
2020-01-12 19:12:33 +01:00
011e0176c2 Clarify the advantage include* statement brought regarding looping (#66022)
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
2020-01-11 11:09:51 -05:00
3456700420 adjusted doc and argument spec in zabbix modules to match sanity requirements (#66176) 2020-01-11 15:25:15 +01:00
515c4a7e2c Bugfix of 65367: postgresql_query doesn't support non-ASCII characters in SQL files with Python3 (#66331)
* Bugfix of 65367: postgresql_query doesn't support non-ASCII characters in SQL files with Python3

* add changelog

* fix

* change changelog fragment, add example
2020-01-11 15:19:55 +01:00
f8fb391548 new connection plugin aws_ssm (#49652)
* new connection plugin aws_ssm

Return code may be at the end of the last command output line.

Marking regex.

Ensure command status code is on it's owm line - last 3 lines are not part of command stdout.

* Adding timeout parameter - aws_ssm_timeout

Default 10 second timeout (https://docs.ansible.com/ansible/2.4/intro_configuration.html#timeout) is marginal.
This avoids changing this default and allowing the SSM timeout to be controlled via inventory.
This change wraps commands so commands which may never return do timeout.

* Added integration tests

Added AWS SSM Executor, target and config functions

Fixed more code for integration tests

Improved execution

Added S3 bucket name

Fixed pylint

Reverted lib changes

Reverted few more changes

Improved support for integration test execution

added ansible role for aws_ssm_integration_test setup and teardown and modifiled runme.sh

Reset to 17fa565 commit

inventory file location changed

change inventory file location

deleted meta and handlers folder as it is not required

deleted main.yml inside vars, removed extra space from tasks/main.yml, Added appropriate tags for ec2 and delete test folder as it is not required

deleted main.yml inside vars, removed extra space from tasks/main.yml, Added appropriate tags for ec2 and delete test folder as it is not required

modified task/main.yml

added region variable and fixed pattern for using variable

modified policy for IAM role

moved to first line of scrip set -eux

Updated Session Manager plugin installation

edited custme policy

Included tags for Session Manager plugin installation

Added README.md

Upddated README and added support for ssm-plugin for Amazon-Linux

Added Windows Integration test support

Improved user data for Linux

Added random value generation for the role and policy,delete vars_to_delete.yml

upadte README in vars

fixed typo

update policy

Updated IAM policy file

update playbook

Updated playbook to include ssm-agent userdata

modified jing2 template

modified jing2 template

modified jing2 template and fixed role deletion

fixed role name issue while deleting and task name

Updated playbook to include wait_connection for ec2

Corrected Synatx changes and updated ssm-plugin debian file

Changed region variable to us-east-1

Removed vars file and updated  to /tmp dir

fixed typo

Improved setup

Fixed boto3 dependency

Fixed missing tag

Added boto as dependency as well

Improved execution workflow

Trying other way of defining tags

Fixed undefined var

Changed AMI ID to Amazon Linux

Improved Tags

Ok, created different directory for WIndows test execution

Fixed IAM Role Name for Windows

Fixed inventory not found

Improved integration test execution

Fixed Windows Inventory path

Fixed wrong Windows AMI ID

Fixes issue for windows test execution

* Don't attempt to terminate sessions without a session id.

* Added Unit test cases file for AWS SSM Connection plugin

updated test file with close

updated unit test file with start_session

updated test files

* Eliminate AWS CLI dependency for terminal session.

* Removing unused code, cleanup logic.

Reduce mark length - 52^26 should be plenty
Be explicit about subprocess.Popen options
Simplify if/else for mark end
_stdin_readline is not used now

* updated test file

Added exec command and fixed close session unit tests

updated test files

Improved ansible ssm test command

updated file for lint checks

updated for pylint checks

New Unit_testcases for pre-signed URL file

removing additonal spaces and white spaces

remaning error changes

fixed changes

fixed spaces issues

python 2.7 version and whitespaces

python 2.7 version and whitespaces

python 2.7 skip if

space issue with 16:1

Unit test cases for windows and linux

Unit test cases for windows and linux with issues fixed issues

Unit test cases for windows and linux with issues fixed issues1

* Added support for S3 Pre-signed URLs

* Updated documentation and comments

* Documentation and curl dependency removal for controller machine

Fixing lint errors and removing requirements.

* Adding support for Windows remote EC2 instances.

* Added Encoding fixes

* Updating author section and adding obvious requirement for the SSM agent.

* Refactor stdout post processing
Attempt to get real return code on error (test using ansible -m raw -a 'cmd /c exit 99'.
Fixes problem at terminal width (ansible windows -i ./hosts.yml -m setup).

* Refactor back to a single module.

* Fixed fetch file for windows

* ssm usage examples for linux and windows

* Update aws_ssm.py

Service state corrected.

* Strip line continuation when at terminal width - otherwise replace.
Strip ANSI control sequences only for Windows.

Test playbook:

---
- name: test
  hosts: windows
  gather_facts: False
  vars:
    small: 'abc'
  tasks:
  - name:
    set_fact:
      large: "{{ lookup('password', '/dev/null length=2000 chars=ascii_letters,digits,hexdigits,punctuation') }}"
  - name: small fixed
    raw: echo '{{ small }}'
    register: small_result
    changed_when: False
  - name: check
    assert:
      that:
        - "(item | length) == (small | length)"
        - "item == small"
      msg: "'{{ item | length }} must equal '{{ small | length }}' and '{{ item }}' must match '{{ small }}'"
    with_items:
      - "{{ small_result.stdout_lines[0] }}"
  - name: large random
    raw: echo '{{ large }}'
    register: large_result
    changed_when: False
  - name: check
    assert:
      that:
        - "(item | length) == (large | length)"
        - "item == large"
      msg: "'{{ item | length }} must equal '{{ large | length }}' and '{{ item }}' must match '{{ large }}'"
    with_items:
      - "{{ large_result.stdout_lines[0] }}"
  - name: gather facts
    setup:

* Correct module parameter names.

* Updated Windows Executable variable.

Updated Windows Executable variable to "ansible_shell_type".

Fixing Examples with raw declaration

Updated the plugin timeout variable.

* Fix to work with dynamic inventory plug-in

* IntegrationTest template updates

* Removing unsupported flag for integration tests.
Fixing unit test.

* Adding shippable group.

* SSM Usage examples with dynamic inventory plugin

* Fixing yamllint errors.

* Fixed Integration tests

* Fixed Integration tests

* Updates for python3.

Removing python3 restriction.

* Remove python3 restriction.
Change block from retry to always

* Fixed Integration tests with Python 3

* Fixed shellcheck

* Fix for Windows which could pick up end mark prematurely
Move debug to _wrap_command and use a single return point

Single-quotes not needed around linux marks
Fix typo in comment

End mark to new command.

* Unit test cases now works on Python2 and Python3

* Skip tests on Python 2.6

* Fix for wait_for_connection module for windows.

* Updated changes as per review comments

* Fixing broken pipe error seen with session-manager-plugin version 1.1.17.0.
Eliminating sleep as this looks to be fixed in session-manager-plugin version 1.1.17.0.

* Adding back delays for Windows with session-manager-plugin 1.1.17.0.

* Updating Windows AMI ID for integration Test

* Upgrading windows ssm agent to the latest

* Adding boilerplate code.

* Windows ami and integration test updates

* Revert "Windows ami and integration test updates"

This reverts commit cd6ca3579b7cda584bd9c065f9c0835bddb23627.

* Updating windows ami for Integration tests

* Integration test suite updates and fixes.

* Updates and fixes

* Eliminate duplicate processing for exit code on failed command.

* Add powershell wrap.

* Refactor windows post_process.

* AMI Lookup, aliases, OSC filter, test suite updates

Co-authored-by: Gaurav Ashtikar <gau1991@gmail.com>
Co-authored-by: Deepak Choudhary <40276333+deepsvc@users.noreply.github.com>
Co-authored-by: Hanumanth <46720371+hanumantharaomvl@users.noreply.github.com>
Co-authored-by: KUMAR MAYANK <mayank@flux7.com>
2020-01-11 15:22:01 +10:00
0a3a81bd12 Persistent connections: These timeouts seem unused (#66267)
* These timeouts seem unused

* Add changelog
2020-01-10 23:09:21 -05:00
f695f40133 Temporarily mark unarchive test unstable. 2020-01-10 18:31:14 -08:00
5f966ef664 Update deprecation version and porting guide for resource_id option (#66060)
* update deprecation version and porting guide for resource_id option

* add changelog fragment
2020-01-10 16:37:53 -06:00
1a0724fdd4 Trim down to one Ansible search option (#66284)
* move swiftype search to upper left of docsite, fix spacing and length issues for search icon and searchbox
2020-01-10 16:31:46 -06:00
22be69188b Fix unarchive integration test on CentOS 6 (#66362)
* Cleanup packages added for Python TLS support
2020-01-10 16:58:37 -05:00
9922014441 add details on network gather facts improvements (#66220)
* add details on network gather facts improvements, implement feedback
2020-01-10 15:06:49 -06:00
ffc1f33f2a Docs: make different heading levels more obviously different in html output (#66253) 2020-01-10 14:13:48 -06:00
2ad6055efd Document network resource modules (#66226)
* add network resource module details to docs

(cherry picked from commit 3e35d2d63ce17fb694e645785ad855f01420f7d8)

* network resource module page, with example output
2020-01-10 14:12:26 -06:00
ce66743b10 vmware_category/test: ensure test can run on Zuul
- set the zuul/vmware/vcenter_only alias
- import `prepare_vmware_tests` role
- little refactoring to avoid an extra level of indentation
2020-01-10 14:51:30 -05:00
0703590686 vmware_vm_info/test: drop dep on json_query
Test refactoring to avoid dependency on `json_query`.
2020-01-10 14:50:01 -05:00
136b3be722 added unit test details for resource modules (#65891)
* added unit test details for resource modules
2020-01-10 13:49:42 -06:00
0d85ab1fe3 Add collection support for network platform agnostic modules (#66342)
*  Refactor net_base action plugin to invoke platform
   action plugin with implementation module name updated
   in the new task copy.
2020-01-10 12:42:53 -05:00
3ebc96e5c7 nxos_l3_interfaces: fix states, add new minor attributes (#64853)
* (WIP) nxos_l3_interfaces: fix states, add new minor attributes

* sa cleanup

* more regression fixes

* test_8 for add'l code coverage

* Fix regressions to handle mgmt w/o IP

* add 'no system default switchport' to regression setups

* add err msg to terminal_stderr_re so that cli_config will catch L2 failures

* regression test change: /int4/int3/

* Add default rsvd_intf_len for Zuul CI

* Fix replaced-with-no-ipaddr and ip redirect issues
2020-01-10 16:33:22 +05:30
687f57d6ca updating metadata (#66289) 2020-01-10 12:29:28 +05:30
c92b538cc5 WebRequest - remove generically named aliases from util (#66325)
* WebRequest - remove generically named aliases from util

* Fix location of deprecated aliases key
2020-01-10 13:01:26 +10:00
7a7f70612a Revert "Fix net_put module text file issue (#66065)" (#66328)
This PR didn't properly run testing for network jobs. As a result it has
broken jobs for ios and junos.

This reverts commit fa66813696.
2020-01-09 21:51:59 -05:00
7ed00a1560 Fix up deprecated_aliases spot for PS (#66326) 2020-01-10 11:44:15 +10:00
3c0a836004 Add changelog entry for PR #66321 2020-01-09 15:26:14 -08:00
397ec6f291 Add comment about not installing requests 2020-01-09 15:18:38 -08:00
db491eca0e Do not install requests[security] for MongoDB tests
This was previously removed in PR ##60083 but was added again in
PR #61257. This will cause a lot of things to fail if it is uninstalled
during cleanup after the test role, which is why it was originally removed
from the test.
2020-01-09 15:18:38 -08:00
595ab62ab8 Ansible.Basic - Added deprecated_aliases (#66323) 2020-01-10 09:13:13 +10:00
92677d43b6 Account for argument spec of None in validate modules sanity test 2020-01-09 15:11:51 -08:00
3ca4580cb4 Allow no_log=False to silence the no_log warnings for module parameters (#64733)
As AnsibleModule._log_invocation is currently implemented, any parameter
with a name that matches PASSWORD_MATCH triggers the no_log warning as a
precaution against parameters that may contain sensitive data, but have not
been marked as sensitive by the module author.

This patch would allow module authors to explicitly mark the aforementioned
parameters as not sensitive thereby bypassing an erroneous warning message,
while still catching parameters which have not been marked at all by the
author.

Adds tests for various no_log states including True, False, and None (as
extracted by AnsibleModule._log_invocation) when applied to an argument with
a name that matches PASSWORD_MATCH.

Fixes: #49465 #64656
2020-01-09 16:47:57 -05:00
93bfa4b07a win_user_right - docs to show how to remove all (#66315) 2020-01-10 06:33:00 +10:00
891c759832 Fix AttributeError due to cgi.escape removal in Python 3.8. (#66040)
* Fix cgi.escape AttributeError due to cgi.escape removal in Python 3.8.

* Fix linter errors.
2020-01-09 15:28:02 -05:00
d3427bb860 Make sure warnings are printed during fact gathering (#66258) 2020-01-10 06:16:20 +10:00
a3d67edfca Fix to nxos_vrf purge breaks with empty aggregate (#66004)
* resolving conflicts

* fixed issue with purge and state var. fixed space issue with vrf name

* lint issues
2020-01-09 14:43:59 -05:00
f70f426604 set up 'yanzhangi' as a reviewer for cloudengine. (#66024) 2020-01-09 14:32:22 -05:00
aba8f12495 ansible-galaxy ignore empty server_list (#65986)
* ansible-galaxy ignore empty server_list
2020-01-09 14:24:36 -05:00
609c3d0e36 mongodb_user module integration tests (#61257)
* Add final commits

* End of night commit

* Add further tests

* What is this doing here?

* Remove file from commit

* Change os check

* Change version check
2020-01-09 09:22:45 -05:00
559de7ee1e mongodb_parameter module integration tests (#61644)
* Add final commits

* End of day check in

* Initial commit

* Remove file

* Remove module from pr

* Run tests
2020-01-09 09:07:27 -05:00
fa66813696 Fix net_put module text file issue (#66065)
*  Modify the parent class for net_put and net_get
   module to refer from `ActionModule` class in
   network.py action plugin which contains the
   common code for network plugins.
*  Replace `_handle_template` with `_handle_src_option`
   function name which is defined in common class.
2020-01-09 18:42:00 +05:30
42b0c967d0 FreeIPA: Fix documentation (#66194)
* Add datatype whereever it is missing
* Fix documentation

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-09 15:32:26 +05:30
70bc351f31 mysql_query: new module (#65941)
* tmp

* mysql_query: new module

* remove irrelevant changes from mysql.py

* add autocommit keyarg to mysql_connect

* add basic CI tests

* tmp

* fix CI tests

* add CI tests

* fix comment in CI tests

* remove path_to_script option

* refactoring

* change tests formatting

* add single_transaction param

* fix sanity

* add note

* fix
2020-01-09 07:39:09 +01:00
963b8249ec setup: more reliably detect container environment (#66183)
* virtual facts: /proc/<pid>/environ is NULL-separated
* non-empty "container" env is a guest container
* This is consistent with `systemd-detect-virt --container`
* fact utils: line_sep option: specify delim for split
* allow using the same function to split null-delimited objects
2020-01-09 11:51:45 +05:30
fff613dd3e routeros_command – add support for dot in username (#65905) 2020-01-08 23:04:47 -05:00
b05529c5a3 adding proxy_address field for active proxies (#66247)
Since 4.0.0 there is a field proxy_address for limiting proxy requests.

Official Docs: "Proxy address	If specified then active proxy requests are only accepted from this list of comma-delimited IP addresses, optionally in CIDR notation, or DNS names of active Zabbix proxy.
This field is only available if an active proxy is selected in the Proxy mode field. Macros are not supported.
This option is supported since Zabbix 4.0.0."
updated documentation/help
fixed test issues
fixed version_added not a string
fix suggestions by D3DeFi


added changelog fragment
applied D3DeFi suggestions

way cleaner and better readable
2020-01-08 19:25:10 -05:00
a5c36eedd8 Simplify docker_setup on Fedora.
This avoids installing dnf-plugins-core, which breaks the yum and dnf modules
when uninstalling packages using a wildcard after they have already been removed.

This should resolve issues with the yum integration tests failing after docker tests run.
2020-01-08 15:29:39 -08:00
53e405dd42 Fix 'CyberarkPassword' object has no attribute 'delimiter' (#66268)
This is a very small follow up to PR #59500
2020-01-08 15:36:41 -05:00
d1c39b9068 Don't remove trailing / on galaxy api URLS (#63294)
This causes multiple unneeded http redirects.
Since each http redirect takes a few hundred
milliseconds, handling the redirects starts to
take up a significant amount of wall time.

Fixes: #63281
2020-01-08 15:25:40 -05:00
66550cd3c2 vmware_guest/test: create test vm in correct directory
Ensure we already create the `test_vm3` VM in the `{{ f0 }}` directory.
This to be sure the teardown playbook will be able to clean it up at the
end. This to avoid problem like this one:

```
Multiple virtual machines with same name [test_vm3] found, Folder value is a required parameter to find uniqueness of the virtual machine
```
2020-01-08 13:20:47 -05:00
4676e5d60e New module: onyx_bfd (#64359)
* Supporting BFD in Ansible

* Modifying BFD module
2020-01-08 12:03:32 -05:00
37dd3c3aa4 Supporting SNMP Hosts Configurations in Ansible (#63983)
* Supporting SNMP Hosts Configurations in Ansible

* Modifying SNMP Hosts Configuration.

* Modifying SNMP Hosts Configurations.

* Modifying SNMP Hosts Configurations

* Modifying SNMP Hosts Configurations.

* Modifying SNMP Hosts Configurations Code.
2020-01-08 11:51:58 -05:00
24781c01be Supporting AAA Configs in Ansible. (#64434) 2020-01-08 11:51:37 -05:00
96b1efdce4 Supporting bfd command in Ansible. (#64509) 2020-01-08 11:51:25 -05:00
20503d7078 nxos_linkagg: removing unsupported parameter "provider" and "timeout" from sanity test (#64370)
* nxos_linkagg: removing timeout parameter from module nxos_feature

* nxos_linkagg: removing unsupported parameter "provider" from sanity test

* nxos_linkagg: typo correction

* nxos_linkagg: typo correction
2020-01-08 13:45:03 +05:30
c4cfe1d7f6 Fix typos in ios_l2_interfaces (#66246)
Some typos in the examples of ios_l2_interfaces are fixed.
This might help to have a fluent start with this module.
2020-01-08 13:44:09 +05:30
01e4c41be4 nxos: Removing local-nxapi plugin and related parameters' usage from the integration tests. (#65068)
* nxos_integration_tests: Removing obsolete provider parameter

* nxos: removing support for local-nxapi plugin

* nxos: removing LocalNxapi plugin implementation

* nxos_nxapi: removing local plugin usage

* REVERT - nxos: removing LocalNxapi plugin implementation

* Addressing yamllint issues

* Removing the condition on the debug messages

* Restoring changes done to nxos_nxapi* tests

* Retaining timeout of 500 on nxos_smoke test

* Some cleanup

* Addressing latest comments

* Restoring the nxos_smoke and removing timeout from nxos_config and nxos_rollback
2020-01-08 13:43:23 +05:30
45713aa38f Track source of vars 2020-01-07 17:30:28 -08:00
009225dfc6 Add support for replacing an existing openstack keypair (#62762)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

Co-authored-by: Monty Taylor <mordred@redhat.com>
2020-01-07 18:35:06 -05:00
452ade007e Clean up Shippable scripts in tools directory. 2020-01-07 14:38:15 -08:00
0ca79a4234 Clarify how to use the Galaxy token (#65961)
* DOCS: clarify how to use the Galaxy token, with info for installs and api-key
2020-01-07 13:57:47 -06:00
e19b94f43b Add test for reboot & wait_for_connection on EOS & IOS (#63014)
* Add test for reboot & wait_for_connection

* Add test for ios

* Collection-proof block test

* Add junos test

* Don't try to evaluate cli context unless using the connection

* Prevent infinite recursion
2020-01-07 14:24:26 -05:00
40394ed671 Update user module to support no_log=False. (#66219)
Updates the user module to support pull request #64733. Neither the
update_password or password_lock field contains sensitive information, so
mark them as such.
2020-01-07 11:26:55 -05:00
10cc2e2b47 Stop using {{ }} in templates for conditionals in integration test (#65797)
Co-Authored-By: Matt Martz <matt@sivel.net>
2020-01-07 11:12:55 -05:00
45240213be Move bitbucket unit tests to separate dir (#66237) 2020-01-07 17:02:27 +01:00
9cfc313dc5 Fix small typo in purefa_host documentation examples (#66240) 2020-01-07 10:50:45 -05:00
469f104ec2 loop: simplify dict2items example in docs (#66235)
* Added a simple example to explain "dict2items" filters for better understading.

Fixes: #65505

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-07 10:32:46 -05:00
f8654de851 Ensure that data within a tuple is marked as unsafe (#65918)
* Use is_sequence, and Mapping throughout, add support for tuples. Fixes #65722

* Address tests

* Remove unused import

* Add changelog

* Add docstring for clarity

* Argh, linting fix

* Not chasing this rabbit

* wrap_var doesn't return a ref to the original item

* no ref tests

* Remove unused import
2020-01-07 08:41:37 -06:00
f9e315671a pagerduty_alert: fix IndexError exception (#46770)
* pagerduty_alert: fix IndexError exception

* clean a bit
2020-01-07 06:27:11 -05:00
8743ff02c0 Fix hcloud_server and hcloud_server_info module when the image is None (#66234) 2020-01-07 05:20:40 -05:00
cb46e5f06b Use dict_diff instead of sets to take diff lag members (#66126)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-01-07 13:12:54 +05:30
97aefb8e11 Temporarily disable vpc peer-link tests (#66121)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-01-07 13:12:45 +05:30
0ebb0ac0fa Fix rendering duplicate peer-ip commands (#66088)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-01-07 13:12:30 +05:30
4674435367 Fix nxos_snmp_community command ordering (#66094)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-01-07 12:15:43 +05:30
bac2e02900 vmware_guest: exclude dvswitch_name from guest os customization (#65997)
- exclude dvswitch_name from guest os customization
- add changelog fragment for ansible PR#65997
2020-01-06 16:41:02 -05:00
22855f73fb Remove unstable from yum tests (#66218)
They seem to be stable again on Fedora 31.
2020-01-06 16:35:09 -05:00
02c126f5ee docker_container - #65993 - update restart policy (restart policy & restart retries) wit… (#66192)
* #65993 - update restart policy (restart policy & restart retries) without restarting the container

* - proper indentation on the continuation-line
- set restart_policy to the correct value independent from the api version

* - move restart_policy definitions into the if block
- add a new variable for the restart_policy configuration value

* add changelog fragment

* typo; minus -> underscore

* rename changelog fragment to contain the correct module name

* rename restart_policy_config_value to just restart_policy and refer to the correct dict values
2020-01-06 20:49:48 +01:00
ec34235e2e Use a context handler for file handling in paramiko_ssh.Connection. (#65624) 2020-01-06 13:09:57 -05:00
d3e9ef3c35 add a path_join filter which joins path components (#62713) 2020-01-06 11:56:40 -05:00
7888eafb82 Fix callback set_options issue with collections (#66128)
Fixes: #66127
2020-01-06 11:32:36 -05:00
80dff8743a fixed some broken links (#66182) 2020-01-06 10:24:07 -06:00
7f9295568a ali_instance: fix doc formatting (#66086) 2020-01-06 10:20:00 -06:00
f85d9d7028 Correct rst syntax in playbooks_filters.rst (#66198)
The `regex_replace` documentation included an example that was meant
to be preformatted text but due to an indentation error was rendering
incorrectly.
2020-01-06 10:13:21 -06:00
6ba4f04f45 Helm: add 'values' examples (#66197)
* DOC: add 'values' examples to helm module docs, see https://github.com/ansible/ansible/issues/31117

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-06 10:09:27 -06:00
e5b2432122 name2Name for myTestNameTags (#66203) 2020-01-06 10:08:05 -06:00
8ae5e34127 pre cleanup services (#66188)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-01-06 16:20:36 +05:30
6b1dff64d0 Fixed misc typo in netcup_dns module (#66201)
Changed 'authentification' to 'authentication'
2020-01-06 15:19:02 +05:30
d56d0f97e3 Add support for OSCM-distribution in hostname module (#66190)
Fixes: #66189

Added subclass to detect the new distribution OSMC
2020-01-05 12:37:39 +05:30
193879d462 Assign AWS Cloudwatch Metric Filter via Ansible (#59925)
* #42292 first draft.

* fix some documentation

* use snake dict keynames

* return metric filter variable

* rework documentation

* try to fix documentation. fix condition when defaultValue is 0. update version string

* fix intenion, syntax and undefined

* try solve state documentation

* define type for state in doc

* rework integration test and fix minor typos

* add defaults for integration test

* update documentation, integration tests, and return value

* fix code formatting and documentation

* irgnore errors in ignore block

* Update lib/ansible/modules/cloud/amazon/cloudwatchlogs_log_group_metric_filter.py

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* add options to metric_transformation

* fix pep-8

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2020-01-04 11:39:01 -07:00
b0b00b555f docker_container: configure removal wait timeout (#66144)
* Add support for timeout while waiting for state.

* Allow to limit removal wait time.

* Add changelog.

* Forgot version_added.

* Add some check mode tests.

* Use removal_wait_timeout in tests.
2020-01-04 17:56:59 +01:00
9a13d56b26 Misc typo fixes (#66120)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-04 21:13:30 +05:30
865e767d39 PostgreSQL : Create unique index (#66157)
* Postgresql : Create unique index

TODO:

* fix syntax error

* add version added

* adding specs and improve doc

* add changelog

* Update lib/ansible/modules/database/postgresql/postgresql_idx.py

* Update lib/ansible/modules/database/postgresql/postgresql_idx.py

* remove check about concurrent

* Apply suggestions from code review
2020-01-04 10:38:17 +00:00
4ecc9da244 mysql_db: add master_data parameter (#66048)
* mysql_db: add master_data parameter

* add changelog

* fix CI
2020-01-04 10:37:40 +00:00
b48366c2fe postgresql modules: use query parameters with cursor objects (#65862)
* postgresql modules: use query parameters with cursor objects

* add changelog fragment

* fix typo in changelog fragment
2020-01-04 05:18:45 -05:00
aa53eb0e71 Bug fixes for GCP modules (#65309) 2020-01-03 15:36:21 -05:00
d37f00df9b Bug fixes for GCP modules (#65445) 2020-01-03 15:36:10 -05:00
5bc11caa92 Bug fixes for GCP modules (#65597) 2020-01-03 15:35:59 -05:00
528163ded2 Bug fixes for GCP modules (#65681) 2020-01-03 15:35:49 -05:00
de01872e7c Bug fixes for GCP modules (#65792) 2020-01-03 15:35:40 -05:00
47970d413e vrong usage of name tag in example (#66129)
Docs: the capitalization of the tag should match in the description and the example. Change the example to "Name" (not "name") to match the description above in the efs_info module documentation.
2020-01-03 09:15:58 -06:00
51570526a9 add example for 'search_paths' option (#65731)
credit to GoneWacko, see #51190 for reference
2020-01-03 09:04:28 -06:00
5e38d5a6dd lambda_info: Remove unused variable and import (#66124)
* Clean up residual code from #64548

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-03 10:02:59 -05:00
633f64f780 Correct fetch_url error code documentation (#66061)
HttpError is passed for 400 and above, not only greater than 400. Change docs to `>=` instead of `>`.
2020-01-03 08:31:20 -06:00
2f996fc6e2 vyos_config bug fix #66110 (#66122)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-01-03 17:35:37 +05:30
5493ea590c make concurrent aws_acm integration tests not clash (#64660)
* add uuid for aws_acm test resources, allow concurrent tests

* remove debug task in aws_acm int test
2020-01-02 17:06:56 -07:00
0597c5d052 Fix typo (#66158) 2020-01-02 22:04:19 +01:00
d85f68cf6c Update Documentation for win_scheduled_task.py (#66079)
Passing an empty string through this parameter is not gracefully handled by the module implementation, so adjust the documentation to only include the `PT0S` method of specifying unbounded `execution_time_limit`. The win_scheduled_task execution_time_limit must be set explicitly to an empty string to permit unbounded execution time.

A newly created task without a value for `TaskSettings.ExecutionTimeLimit` will default to 72 hours (https://docs.microsoft.com/en-us/windows/win32/taskschd/tasksettings-executiontimelimit) even if you omit the Ansible task parameter `execution_time_limit`.
2020-01-02 11:34:17 -06:00
506e2da0ff wording in examples changed ios to eos (#66131)
wrong module was used in examples: should be eos_vlans not ios_vlans
2020-01-02 11:27:50 -06:00
14e32c85b4 Don't wait for removal during check mode. (#66145) 2020-01-02 17:51:52 +01:00
19f77faf7b Fixed typo in vultur module (#66159)
Changed `exmaple` to `example`
2020-01-02 20:30:01 +05:30
f31b8e08b2 docker_swarm_service: Fix parsing of Healthcheck.StartPeriod (#66151)
* Parse Healthcheck.StartPeriod properly

* Add changelog fragment

* Use proper markup in changelog

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-01-02 09:23:36 -05:00
f7d4121446 postgresql_query: refactoring (#66084) 2020-01-01 05:15:48 -05:00
80896792c8 Correct spelling mistake in proxmox_kvm (#66133)
* Correct a little spelling mistake in proxmox_kvm - changed 'update' to 'updated'
2019-12-30 21:20:56 +05:30
458268f4cb AWS Guidelines: Make 'security_token' optional so that they can be run outside of CI (#66107) 2019-12-30 08:38:20 +00:00
06927eab1f Make autocost bandwidth calculation a floor division for Py3 compatibility (#66095)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-30 13:12:16 +05:30
fc2d7ae63e mysql_db: fix doc formatting (#66087) 2019-12-30 10:36:00 +05:30
074190ae54 Update OS_FAMILY_MAP for EulerOS (#66104)
Add support for EulerOS

Signed-off-by: Dai zhiwei daizhiwei3@huawei.com
2019-12-30 10:25:37 +05:30
4df5bdb11e docker_container: wait for removal if removal is in process (#65854)
* Allow to inspect containers directly.

* Wait for containers to be removed before recreating them.

* Also wait for containers to be removed before creating them.

* Add changelog.
2019-12-29 23:16:32 +01:00
17ef253ad1 docker_network: fix multiple subnet (of same IP version) idempotence (#65839)
* Fix multiple subnet (of same IP version) idempotence for docker_network.

* Add changelog.

* Unit tests no longer make sense, since the part of the code they test has been removed.

* Re-add CIDR validation. Move it to better position (module setup instead of idempotence check).

* Update changelog.

* Only run new tests on VM test images.

* Actually do what is documented. Especially since an empty object is a valid value for aux_addresses.
2019-12-29 23:16:17 +01:00
30cfa92e90 docker_swarm_service: Fix description of limits.memory (#66078)
This option corresponds to the '--limit-memory' option. Also
fix other mentions memory reservation instead of limit.
2019-12-29 21:18:46 +01:00
8456d4e354 update aws_eks_cluster.py (#66105) 2019-12-29 19:45:34 +10:00
c5a2ba5217 To fix the bug where IOS vlans module throws traceback (#64633)
* fix 64515

* add fix
2019-12-27 20:49:29 +05:30
b733178bac nsupdate: Use provided TSIG key for all queries (#63174)
In addition to signing update queries also use the TSIG key to sign
lookup queries. By doing that we allow a hidden master to not only to
be looked down network wise, but also TSIG wise.

A bonus benefit of threating update queries and lookup queries more
the same is that will allow for all queries to be refactored into a
shared helper method. Currently we have a bit too much duplicated code
within the module.
2019-12-27 16:02:24 +01:00
c2fed8603c Fix nxos_user roles bug (#65962) 2019-12-27 15:51:17 +05:30
52f3ce8a80 allowing banner without stripping spaces (#62573)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-12-27 12:43:09 +05:30
da07b98b7a os_volume: optional bootable parameter for volume (#43945) 2019-12-27 11:04:17 +05:30
c35a7b88d4 Homebrew: some functions ignored check_mode option (#65387)
update_homebrew and upgrade_all now support check_mode

Fixes: #65352
2019-12-27 10:45:34 +05:30
4d1a57453e homebrew_cask: Update documentation and examples (#66073)
* properly document ``upgrade`` option as an alias to ``upgrade_all``, and not a separate option
* Update documentation.
* Update examples.

Fixes: #34696

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-27 10:08:18 +05:30
82c63c0ac3 zabbix_host idempotency fix for situation where ZabbixAPI handles host groups case insensitively (#63860) 2019-12-25 10:30:51 -05:00
2fa8f9cfd8 Fix env lookup plugin error on utf8 values (#65541)
This commit fixes issue #65297.

The env lookup plugin used to fail when environment variable value
contained any UTF-8 characters (e.g., δ, ζ).
2019-12-25 17:24:38 +05:30
05e2e18061 VMware: Add example for creating VM without disks (#66057)
Fixes: #39743

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-24 22:40:02 +05:30
94e054755f Fix nxos_l3_interfaces rendering of dhcp (#66049)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-24 21:58:30 +05:30
abad4fbf5e fixing #64404 (#66032) 2019-12-24 16:10:47 +08:00
cb2a45d286 fix nxos_hsrp keyerror (#65796)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-12-24 12:13:58 +05:30
683c467609 Check if task file is specified for import_tasks (#57572)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-24 10:26:32 +05:30
34acabd70a VMware: Handle NoneType in vmware_vmkernel_info (#65834)
Check for virtualNicManager in Esxi host system before accessing properties in vmware_vmkernel_info.

Fixes: #62772

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-24 09:38:38 +05:30
365820f871 Add a banner which will display on the testing site. (#64763)
* Add a banner which will display on the testing site.

Thanks to shane for the javascript code

* change to more noticable color

Co-authored-by: Sandra McCann <samccann@redhat.com>
2019-12-23 12:15:47 -05:00
d85816396e Update os_group_info.py (#65115) 2019-12-23 11:29:14 -05:00
6d65280dfc improved zabbix action conditions documentation in zabbix_action module (#65808) 2019-12-23 11:28:29 -05:00
c0cf148eee Be more specific about the requirements per distro (#65810) 2019-12-23 10:35:26 -05:00
57730505b5 fix AWS cloudfront purge_cache_behaviors misspelling (#65927) 2019-12-23 10:29:01 -05:00
81465455cd Fixes #65952: Remove ambiguous example from k8s docs to clarify file usage. (#65953) 2019-12-23 10:18:15 -05:00
5c69e02a35 don't use with_file in exclusive=True examples (#65967) 2019-12-23 10:16:16 -05:00
10b6038e21 Fix pacman stdout parsing in the Ansible module (#65238)
pacman output is localized and the Ansible module is parsing its output.
So, we need to force the locale.
Add changelog fragment

Fixes #65237
2019-12-23 14:23:46 +05:30
3caadca3f4 Include groups in name-based search results (#66026)
add changelogs
2019-12-23 02:47:02 -05:00
5e271baa55 Revert "Don't rely anymore on locale-dependent wording in Pacman output (#65878)" (#66029)
This reverts commit cd0e038b74.
2019-12-23 09:34:37 +05:30
cd0e038b74 Don't rely anymore on locale-dependent wording in Pacman output (#65878)
Use line position instead, as specified in upstream pacman source code.

See: https://git.archlinux.org/pacman.git/tree/src/pacman/package.c#n260
Fixes: https://github.com/ansible/ansible/issues/64682
Fixes: https://github.com/ansible/ansible/issues/65237
2019-12-23 09:11:39 +05:30
22d93d9496 zabbix_hostmacro support for zabbix native macro names and macro_value not required when state=absent (#65884) 2019-12-22 02:58:23 -05:00
6fa070e824 Fix to return data when using lambda_info module (#64548)
* Fixed issue 64479 with lambda_info module

* Added integration tests for lambda_info module

* Moved lambda_info tests into already existing aws_lamda testsuite for easier test setup.

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2019-12-21 20:29:05 -05:00
a0e6bf366e Use context manager for file handling in misc files. (#65372)
The file handles are left open in those files.
2019-12-21 13:01:38 +01:00
b580f2929d terraform workspace list failure warns instead of fails (#65044)
* terraform workspace list failure warns instead of fails

Fixes #64788

* add a changelog fragment
2019-12-21 12:50:31 +01:00
e711d01ed1 #58578 support absolute paths additionally (#58812)
* support absolute paths additionally

* add changelog

* rename changelog

* fix changelog to bugfix
2019-12-21 12:49:38 +01:00
663171e218 nmcli: Add compatibility for new networkmanager library (#65726)
Fixes: #48055
* add compatibility for new networkmanager library
* update debian/ubuntu docs
* move import gi into try
2019-12-21 11:28:58 +05:30
7ee3103a86 clc_aa_policy: deprecate unused 'wait' parameter (#64367) 2019-12-20 23:46:53 -05:00
342b9953bc Disable failing azure_rm_storageaccount test. 2019-12-20 16:11:21 -08:00
9ea5b539b6 Add ansible-test constraint to avoid coverage 5.0+ 2019-12-20 11:55:54 -08:00
2b6d94c4c8 Change the check_pyyaml() function to return the features of pyyaml that we check 2019-12-20 10:29:03 -08:00
ece306b201 Add a sanity test for yaml to make sure we can parse all yaml
Check that all yaml we ship is parsable by the pyyaml c backend.  Since
Ansible uses Pyyaml for docs and playbooks, if the yaml files aren't
parsable, they will error out if they were used.

Warn and skip yamllint if libyaml backend is not present

Ignore new errors in examples until someone can fix them
2019-12-20 10:29:03 -08:00
18130e1419 user - honor update_password parameter on BusyBox hosts (#65977)
The check for this parameter was missing from BusyBox.modify_user(), resulting in unexpected password changes to existing user accounts.
2019-12-20 13:09:22 -05:00
d50fac9905 Remove illusion of caching in the inventory script plugin (#64151)
* Load the cache plugin for the inventory script plugin and fix update cache logic

* Remove the illusion and let individual scripts deal with it

* reword that

* Deprecate instead of a hard failure

* changelog
2019-12-20 11:44:07 -05:00
1cfab26fab Fix netconf plugin related to collections (#65718)
* Fix netconf plugin related to collections

Fixes #65655 (partly)

*  Make netconf plugins configurable so that the
   information of ncclient device handler
   for give platform resides in the platform
   specific netconf plugin.
*  If the device handler value in ncclient is
   different from the ansible_network_os value
   the right value of `ncclient_device_handler`
   should be set in the plugin documentation.

* Fix review comments

* Fix CI issue

* Fix review comment
2019-12-20 12:25:59 +05:30
fc31b4e506 VMware: Corrected documentation on vmware_guest module (#65733)
Update link for vapp_properties as per VMware docs in vmware_guest module
2019-12-20 10:16:38 +05:30
4769d731ac VMware: filter VMs of Same name on the basis of folder (#65922)
vmware_guest now filters VMs of same name on the basis of additional information of folder.
2019-12-20 08:54:15 +05:30
50eb4eec90 fix ec2_vpc_net test instability (#65184)
* Move ec2_vpc_net tests to group1, group2 is running much longer

* Allow for VPC CIDRs to be "associat*ing*", things in AWS are "eventually consistent" and occasionally take longer than we would like
2019-12-19 16:30:44 -07:00
7bb925489e elb_{network_lb,target_group}: allow UDP/TCP_UDP (#65828)
elb_network_lb.py: allow UDP and TCP_UDP protocols

- Fixing documentation
- Add support to UDP and TCP_UDP as described on AWS SDK

elb_target_group.py: allow UDP, TLS, TCP_UDP proto

- Fixing documentation
- Making health checks with response codes and paths only in HTTP/HTTPS
- Allow UDP, TLS, TCP_UDP protocols as described on AWS SDK.

others:
- Added changelog fragments
- Integration test

Fixes: #65265
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-12-19 15:06:16 -07:00
32a8b620f3 [get_url] Return status_code on HTTP 304 (#65739)
Return field status_code on HTTP status 304 (implemented by lkthomas)
Add an integration test for this case.
Fixes #65263
2019-12-19 14:50:44 -05:00
4351a756e1 Set a deprecation warning and version for option sha256sum (#65637)
The option sha256sum was declared deprecated more than 2 years ago without
setting a removal version. Let's do that now.

fixes #65636
2019-12-19 14:47:27 -05:00
fec883dfff VMware: Add advanced settings to vmware_cluster_ha 2019-12-19 14:19:45 -05:00
c870457339 free strategy - include failed hosts that were notified (#65576)
* free strategy - include failed hosts that were notified so --force-handlers is used

* trim line length a bit

* Loop over the force handler tests with the strategies linear and free

* rename changelog

* Use the play iterator instead of TQM for accurate failure representation in blocks

* Remove hack in a backwards compatible way for 3rd party plugins
2019-12-19 14:10:51 -05:00
89703b3284 vmware/test: more modular teardown.yml
Some teardown tasks are now enabled only if we have ESXi in the configuration
file. On my system and in a vcenter only scenario, `vcenter_folder` goes from
42.7 to 31.2s.
2019-12-19 13:52:51 -05:00
284f26303c Add support for ECR Lifecycle Policies to ecs_ecr (#48997)
* Fix copy/pasta for ecs_ecr test names

* Add support for lifecycle policies to ecs_ecr

New feature for ecs_ecr to support [ECR Lifecycle Policies][].

Fixes #32003

 [ECR Lifecycle Policies]: https://docs.aws.amazon.com/AmazonECR/latest/userguide/LifecyclePolicies.html

* Improve error message for ecs_ecr parsing errors

Replaces the exception and stack trace with a description of what's
actually going wrong from a user perspective.

* Rename delete policy to purge policy

Marks the `delete_policy` parameter as deprecated, to be removed in
Ansible 2.6.

* Add version_added to purge_policy

* Remove changing results based on verbosity

What I really want is --diff support, and changing results based on
verbosity is abnormal.

* Ensure repository name is lowercase

* Fix deprecation cycle to 4 releases

* Use a YAML anchor for credentials

* Remove filters from assertions

* Add minimal permissions needed

* Updating version_added and deprecation cycle

The original PR sat while a few releases happened.

* Bumping version added and deprecation version

We missed the 2.8 release.

* Removing bare except:

This is not allowed and is generally bad practice.

* Fix lint errors

* update ansible release metadata

* Use the new alias deprecation scheme

This was added in the time the PR has been in development, so rework
things to use it.

* Add test coverage

This makes sure that lifecycle_policy is produced when passed in.

*Also a minor suggestion for simplification from PR.

* Restore changes from 62871 lost in rebase

* Add changelog

* Remove version_added for new purge_policy option

Per sanity test fail.
2019-12-19 11:41:41 -07:00
e9267bf6d6 Cloudformation info checkmode (#65958)
* set supports_check_mode=True

I don't see any reason why this module cannot run in check mode.  The following API calls are made, none of which modify configurations

All using boto3.client('cloudformation')
describe_change_set
describe_stacks
describe_stack_events
get_paginator
get_stack_policy
get_template
list_change_sets
list_stack_resources

* duplicate cloudformation_info tasks with checkmode

Duplicated all existing cloudformation_info tests and added check_mode: yes to them

* delete duplicate empty line
2019-12-19 10:45:22 -07:00
14ebceec25 Fix 'Assert CNAME failure' assertion (#65875) 2019-12-19 12:12:38 -05:00
bd989052b1 Add ansible cli options --ask-vault-password and --vault-pass-file (#63782)
* Move new Ansible cli options '--ask-vault-password' and '--vault-pass-file' to the existing calls to add_argument
* Add changelog fragement
* Change order of ansible cli arguments to use --ask-vault-password and --vault-password-file by default
* Update runme.sh in vault integration tests to test new options --ask-vault-password and --vault-pass-file
2019-12-19 12:07:25 -05:00
3ed0b2c7ea vmware/test: init esxi_user with esxi1_username
By default, `esxi_user` is initialize as `root`. We now use `esxi1_username`
instead.
2019-12-19 11:30:00 -05:00
8d6b9cf6e0 prepare_vmware_tests: add scenario with one ESXi
Add the ability to test with just one vcenter instance and a single
ESXi. This allow us to cover 90 modules.
2019-12-19 11:30:00 -05:00
b31b5d105a vars: Fail with warning for extra_vars filename without @ sign (#59915)
Rather than silently processing extra_vars filename without @ sign,
CLI now fails with appropriate warning about requirement.

Fixes: #51857

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-19 18:01:22 +05:30
31eb1a1412 ovirt_affinity_group: add host rule option disabled (#65704) 2019-12-19 03:28:43 -05:00
6a880b78a2 ovirt_network: correct external provider (#65701)
* ovirt_network: update external provider

* unnecessary remove blank line

* remove update check for external_provider

* first try to import then create
2019-12-19 02:52:35 -05:00
9f6c210eac ovirt_snapshot: select disks (#65729) 2019-12-19 02:52:11 -05:00
a168e73713 azure_rm_virtualmachine: fixing issue #63844 (#65601) 2019-12-19 15:48:38 +08:00
ee58225970 add image reference in vmss instance info (#65872) 2019-12-19 15:47:27 +08:00
973e36c6b6 Fix version param in deprecate() call and update porting guide (#65894)
* fix version= param in deprecate() call and update porting guide

* add changelog fragment
2019-12-19 07:09:28 +01:00
d3b6db3754 Add notes on docker_network connectivity for containers and services. (#65840) 2019-12-18 18:55:17 -05:00
777b6d3e30 Force values to be sorted when compared. (#65315)
* Force values to be sorted when compared.

This avoids problems where lists of values could be generated in
indeterminate order.

* Update lib/ansible/module_utils/aws/elbv2.py

Thank you felixfontein, sorry I missed this detail.

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-12-18 16:35:35 -05:00
aa6dbbf7ea addd jie to azure dev (#65939) 2019-12-18 21:20:59 +00:00
c40832af48 ec2_launch_template: Add default_version and latest_version to output, matching the documentation (#61279)
- Add tests for default/latest version manipulation
2019-12-18 15:53:57 -05:00
791e9dabe3 Run ec2_instance tests in parallel and re-enable them (#63800)
* Run ec2_instance tests in parallel

* Make sure we spin up the iam_instance_role instances in the dedicated VPC

* Rework a little to only build one VPC while still running in parallel

* Start running the tests within shippable

* We only use setup_remote_tmp_dir for the version_fail tests, so only set it up once

* Make sure we clean up if we fail during Environment Setup

* Add a warning about running in parallel

* Minor review tweaks

* Remove unused file
2019-12-18 13:18:23 -07:00
45a413a4a2 Add ChangeSets to cloudformation_info + updates (#64571)
* cloudformation_info updates

Add ability to retrieve stack change sets
Update module to use AnsibleAWSModule
Update backoff to use new decorator style
Updated exceptions to use fail_json_aws
Converted outputs to snake_case where appropriate, for cloudformation_info only to preserve cloudformation_facts functionality.
  Unconverted keys are stack_outputs, stack_parameters, stack_policy,
  stack_resources, stack_tags and stack_template

* cloudformation_info updates

Add ability to retrieve stack change sets
Update module to use AnsibleAWSModule
Update backoff to use new decorator style
Updated exceptions to use fail_json_aws
Converted outputs to snake_case where appropriate, for cloudformation_info only to preserve cloudformation_facts functionality.
  Unconverted keys are stack_outputs, stack_parameters, stack_policy,
  stack_resources, stack_tags and stack_template

* Adding integration tests

* Remove unneeded debug statement

* Add myself to Authors

* rename stack-name to match iam policy limits

aws-terminator permission for cloudformation have the following resource
Resource: arn:aws:cloudformation:us-east-1:{{ aws_account_id }}:stack/ansible-test*
updating test stack name to match

* removing .orig file from rebase

* fix stack name, underscore not allowed

* rename integration testsuite to cloudformation

rename per request

* add resource_prefix to resource names

* prefix stack name with ansible-test

IAM policy in aws-terminator requires the stack name to begin with ansible-test

* add single quotes around variable in test

* fix test for display name

mistakenly updated when changing topic_name to use resource_prefix.  The test is to check the display name, which is what the stack update changes

* fix value to display name test

* rename main.yaml to main.yml before rebase

* Merge tests with  #65643

remove uneeded files
using tests from #65643 with added check to validate changeset is present in info when requested

* fix assert on chageset check

* remove trailing blank line
2019-12-18 12:08:22 -07:00
ae0df67539 Add debug (#65909)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-19 00:36:32 +05:30
a1381d6e67 Add connection_local / connection_httpapi skip to eos (#65948)
This starts to allow us to break jobs out per connection testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-18 13:32:56 -05:00
71ea16995a Meraki: Fixed line 174 changed from None to the actual net_id… (#59395)
* Fixed line 174 changed from None to the actual net_id variable

* Update meraki_content_filtering.py

* Create 59395_meraki_content_filtering.yaml
2019-12-18 12:10:16 -05:00
9fafbe3ab2 Add myself as a watcher on sanity/ignore.txt (#65950)
After spending the time and effort to clean out the AWS sanity failures I'd like to keep an eye open for new failures as the sanity tests are updated
2019-12-18 16:36:39 +00:00
848782acd4 New zabbix_service module (#58926)
* New module zabbix_service (#5)

* new module zabbix_service

* fix type

* fix githubid

* New Zabbix service module (#11)

* new zabbix service module

* fix validate module failure

* Fix algorithm doc and all_childs param name

* Update Ansible version

Co-Authored-By: sky-joker <megane@kurobuti.com>

* remove dump state
2019-12-18 15:05:58 +01:00
6abf59cac8 Use module references 2019-12-18 06:22:05 -05:00
b121065d28 Update aci_access_port_to_interface_policy_leaf_profile.py
##### SUMMARY
<!--- Your description here -->
The links in the file are wrong.  Updating the document name to point to the right document.

https://docs.ansible.com/ansible/latest/modules/aci_access_port_block_to_access_port_module.html

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-12-18 06:22:05 -05:00
dfd998bcbc Added ability to specify plan information for images that require it. (#65335)
* Modified to include plan information.

* Fixed where plan is passed to the virtual machine object.

* Added changelog file

* Update changelogs/fragments/65335-add-plan-to-azure-vmscaleset-module.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Added plan suboptions with required flag. Removed code block checking plan since suboptions were added.

* Changed true to True. Added space after commas where failed tests indicated.

* Removed extra blank line. Added promotion_code to plan param list.

* Trying to fix indention issue

* Trying to fix indention

* Changed example capacity to trigger build check. Last failure was not due to code.

* Removed property for accepting terms and code block using it..

* Removed extra unneeded spaces.
2019-12-18 12:55:33 +08:00
8a423868d9 AnsibleAWSModule related cleanup: (#64931)
- fetch boto3 clients using module.client()
- remove ec2_argument_spec() use (AnsibleAWSModule adds it automatically)
- remove unused imports
- remove HAS_BOTO3 (AnsibleAWSModule handles it)
2019-12-17 19:28:26 -05:00
b8729b2544 cloudformation integration tests (#65643) 2019-12-17 15:27:52 -07:00
80f5503ed0 Use requirements.txt to install prereqs for docs build (#65709)
* Use requirements.txt to install prereqs for docs build

* implement feedback
2019-12-17 15:09:05 -06:00
f76dded9c6 Split ios tests into network_cli and local connections (#65921)
This allows to group tests by connections, which allow us to disable
local connection testing in collections for the moment.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-17 14:10:52 -05:00
42144204f3 Fix purefa_host preferred array connection logic (#65917) 2019-12-17 10:46:10 -05:00
9b85a51c64 Bugfix of 65761: postgresql_privs fail after it's updated to 2.9.2 (#65903)
* Bugfix of 65761: postgresql_privs fail after it's updated to 2.9.2

* add changelog
2019-12-17 13:53:51 +00:00
ec0885cf05 Onyx username (#63897)
* Support username command to config users and edit capabilities

* Add disconnected param to disconnect all session for such user

* Edit yaml examples, add types to docs and edit the version

* Add fullname attribute

* Add no_log to password field and mutually_execlusive relations

* Fix pep8 issue

* remove debug line
2019-12-17 14:01:03 +05:30
557c8ab161 support syslog remote module (#63195)
* support syslog remote module

* change enabled implementation and edit the tests, also support disable override class

* fix the level order and delete types from choices
2019-12-17 12:12:55 +05:30
84572c3b67 Supporting ntp servers and ntp peers configuration in Ansible. (#63714)
* Supporting ntp servers and ntp peers configuration in Ansible.

* Modifing ntp servers and peers config.

* Modifying ntp peers and servers configuration.
2019-12-17 11:51:29 +05:30
d0d8fca334 Supporting SNMP Users Configurations in Ansible (#63778) 2019-12-17 11:50:58 +05:30
fe354ed183 Supporting general ntp configurations in Ansible (#63724)
* Supporting general ntp configurations in Ansible

* Modifying ntp module
2019-12-17 11:50:32 +05:30
13d0ebd603 Supporting general snmp configurations in Ansible (#63723)
* Supporting general snmp configurations in Ansible

* Modifying SNMP General configurations.

* Fix pycodestyle issues

Signed-off-by: Sara Touqan <sarato@mellanox.com>

* Fix documentation errors

Signed-off-by: Sara Touqan <sarato@mellanox.com>
2019-12-17 11:49:56 +05:30
33338decf7 Feature/onyx syslog files (#62746)
* support syslog files

* nested doc fix

* required togother

* fix docs type dict

* add file-debug feature same as files logging

* remove duplicated validation and change dict key access method

* add format of upload url and change the way of getting data from dict
2019-12-17 11:24:33 +05:30
a54e77193b New Windows Module: win_certificate_info (#64035)
* win_cert_stat initial commit with tests

* documentation fix.
first attempt windows server 2008 compatibility

* add formatted dates
removed debug tests

* make choices generic list

* return a list of certificates
use .net x509 store instead of PS cert provider

* fixed tests file

* fix timestamps returning null

* rename to win_certificate_info

* rename tests win_certificate_info

* return certificates as a sorted array
open the store with readonly privileges

* extensions always returned as an array
2019-12-17 12:43:03 +10:00
ae6fc265c9 Add-Type - Added a way to reference assemblies by type name (#65866)
* Add-Type - Added a way to reference assemblies by type name

* Also add architecture symbols during compile time

* Fix stray output values
2019-12-17 09:06:54 +10:00
83ad1231b8 Remove unused variable in resetconf_config.py (#65892)
Our flake8 jobs for ansible.netcommon exposed this issue.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-16 17:25:08 -05:00
95d35a3b95 adding new azure dev to (#65744) 2019-12-16 22:19:49 +00:00
0310163bb9 Remove unused json import for iosxr terminal (#65879)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-16 13:25:01 -05:00
aacc2d1a18 Update indentation used in the code examples, unify empty lines (#65874) 2019-12-16 11:26:25 -06:00
40fb46f1e8 fixes import paths for ansible unit testing (#65775)
* fixes import paths for ansible unit testing

* Update docs/docsite/rst/dev_guide/testing_units_modules.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-12-16 11:07:26 -06:00
6f76a48f59 Make sorting in collection_loader match plugin loader (#65776)
* Simply sorting of Windows files below other plugin types
    Using the sort method with a custom key function uses less memory than creating multiple lists then joining them.

    This seemed to be an acceptable use of a lamdba, even though I geneally try to avoid them.

* Fix sorting of plugins inside of collections
    Explicitly sort Windows files below others, mimicking what we do in plugin/loader.py

* Add documentation about ansible.builtin and ansible.legacy
    Also document to the two different methods used for searching based on the candidate type.

* Add changelog
* Add integration test
* Update comment with expected sort order
2019-12-16 11:28:24 -05:00
74e9b1e219 Fix network action plugin load in collection (#65849)
* Fix network action plugin load in collection

Fixes https://github.com/ansible/ansible/issues/65071

*  Load network action plugin that matches the module
   prefix name from list of collections.

* Update changelog

* Fix unit test
2019-12-16 19:15:41 +05:30
093d1500b9 Clean up flake8 for ansible.netcommon collection (#65842)
We noticed the following flake8 errors when we ran the migration script
for ansible.netcommon.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-16 08:24:38 -05:00
0a04a5efc2 adding the modules to /nxos/storage/ folder (#64269)
* adding the modules to /nxos/storage/ folder

* fix pep8 stuff

* fixed provider specific information from doc

* Fix integration tests

* Added tested against note

* Review comments

* added assertions for the commands sent in the integration tests
2019-12-16 14:44:33 +05:30
7b2cfdacd0 Zabbix: Handle KeyError in zabbix_host module (#65392)
Fixes: #65304
2019-12-16 13:32:11 +05:30
06d997b2b2 Fix nxos_file_copy argument error handling. (#65861)
*  Use `option_type` instead of `type` for error
   handling in task options
2019-12-16 13:05:18 +05:30
dac3bf5b71 zabbix_host: interface.port parameter is a string (#64986)
interface.port should be a string to be able to use macros in that
value.
This fixes the case when interface.port is a macro (eg.: "{$MACRO}" and
force=false.

Because, until now, setting the interface.port to an integer was the correct way to work with force=false, a type validation has been added
to that parameter.
Previously, if a string was used for interface.port, it was converted
to an integer, the comparison didn't work (if interface not in interfaces)
and the module tried to register the same interface twice, returning an
error.

Zabbix API manual specifies that only 'main, 'type', 'useip' and 'bulk'
are integers.
https://www.zabbix.com/documentation/current/manual/api/reference/hostinterface/object

Tests are changed to use always str in the interface.port.

Two new tests are added.
The first one is to show that now registering a host with force=false and
a macro in interface.port works.
The other one tests that interfaces defined using string for port are
compared correctly when force=false is used. Previously it was
a comparison between int and str, interfaces were seen as different
and an error was thrown because we were trying to create twice a main
interface.

* Try to kindly convert interface port to the string

As suggested, the previous behaviour could break current configurations. This solution accepts integers and strings.

Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>
2019-12-16 10:55:05 +05:30
5046413b6d Fix flake8 errors for iosxr tests (#65860)
These were noticed when we migrated to the cisco.iosxr collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-15 23:48:28 -05:00
94be732351 Handle push_events_branch_filter in gitlab hooks (#60039)
* Handle push_events_branch_filter in gitlab hooks

* Update doc of push_events_branch_filter option in gitlab hooks

* Ensure default empty value for push_events_branch_filter

* scm/gitlab_hook : Update version_added to 2.10
2019-12-15 17:08:10 -05:00
8165ce6144 add prefix-list to ios_bgp af-mode (#62705)
* adding prefix-list to ios_bgp

* adding prefix-list to ios_bgp

* Fix copy-paste bug in test

* Adding neigbor 10.10.20.20 to global neighbor pool

* Added prefix_list_in and _out to documentation

* Rewrite bgp prefix_list test

* Bugfix in yaml data

* More test, assert neighbor 10.10.20.20
2019-12-15 12:35:51 +05:30
88008badb1 Fix nxos_file_copy option value path validation (#65423)
* Fix nxos_file_copy option value path validation

*  Modify `local_file`, `local_file_directory` and
   `remote_file` option type from `str` to `path`
   so that the option value is validated in Ansible
   for a legitimate path value

* Fix review comments
2019-12-15 10:41:33 +05:30
d7414d55e1 fixes bug: visible_name was not updated when not set in existing host… (#64095)
* fixes bug: visible_name was not updated when not set in existing host in zabbix

* Update changelogs/fragments/fix_zabbix_host_visible_name.yml

Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>

* Update lib/ansible/modules/monitoring/zabbix/zabbix_host.py

Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>
2019-12-14 22:13:49 -05:00
ff5253fa0e Fix network_cli become check to be compatible with collections (#65829)
*  The become method name check is not required in network_cli
   as the become command is specific to platform and is implemented
   in the platform specific terminal plugins
2019-12-14 16:50:51 -05:00
gp
98f19c970f VMware: Fix cluster argument of module vmware_content_deploy_template (#65715) 2019-12-14 20:43:35 +05:30
885cecfc94 postgresql modules: use query parameters with cursor objects (#65791) 2019-12-14 13:43:59 +05:30
f5a0d6e4ba unsubscribe cove from docker modules (#65714) 2019-12-14 13:39:12 +05:30
eb2f2ad282 Fix purefa_volume when used in check_mmode (#65825) 2019-12-14 11:24:04 +05:30
8d542edeae VMware: Misc fixes in HTTPAPI connection plugin (#65764)
* Error handling
* Support session URL

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-14 09:47:21 +05:30
24b1409667 postgresql_sequence: use query parameters with cursor object (#65787) 2019-12-14 09:46:27 +05:30
c5a42a9ac6 Fix a typo in changelog fragment's file name (#65788)
Changed '65679-postgresql_schema_user_query_params_with_cursor.yml' to '65679-postgresql_schema_use_query_params_with_cursor.yml'
2019-12-14 09:45:43 +05:30
ab54736e12 Add tags to aws ecs task (#53717)
* Add tags to ecs_task

remove older reference to credentials

* uncomment shell commands to enable/disable account settings

* Fix documentation and pep8 issues

* fix review items for ecs_task tags

use missing_required_lib for tags
change fail_json message to suggested message
switch from task_tags to tags for consisitency

* Add import for missing_required_lib function

* Tidy put-account-setting tasks and add permission

Using `environment` and `command` rather than `shell` avoids the
need for `no_log` and means that people can fix the problem

* update version added for ecs_task tags

* fix tests after removal of ansible_facts from ecs_service_info, add delay when service is still draining

* Add documentation for sanity tests
2019-12-13 16:54:44 -07:00
1535d9fd90 Allow template import to create groups (#65503) 2019-12-13 09:25:07 -05:00
a68269660e mysql_user: support for MySQL plugin authentication (#65789)
* mysql_user: support for MySQL plugin authentication

* add changelog fragment
2019-12-13 09:23:06 -05:00
2ef47148cd Fix action plugin issue with network connection type in common collection (#65078)
* Fix action plugin isse with network connection type in common collection

*  For network connection in common collection the value of
   ansible_connection is the FQCN of the connection type
   For example ansible_connection=network.common.network_cli

*  Add fix in supported network action plugins to extract
   the connection name from FQCN

* Fix CI issue

* Fix review comments and update community network action plugins
2019-12-13 19:22:56 +05:30
d72025be75 nxos_interfaces: RMB state fixes (#63960)
* nxos_interfaces: RMB state fixes

* shippable fixes

* Add add'l comments per review

* fix long line

* Fix mode/enabled system defaults handling

* fix N3L test skips

* lint

* test updates for titanium images

* doc fix
2019-12-13 18:06:21 +05:30
ea164fdde7 Clean up flake8 errors on ios unit tests (#65782)
This was caught during our collection migration process.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-12 19:26:54 -05:00
057e137998 clarify returned value of RETURN nlock (#65724) 2019-12-12 17:12:38 -06:00
1f0b5b09cd Explanation for "check_mode: no" is confusing (#65777)
When an ansible module, e.g., command, does not support check mode, you can use "check_mode: no" in that task to execute the task in normal mode, even when "--check" flag is used. The current document basically says, use "check_mode: no" to run in check mode, which is confusing and inaccurate.
2019-12-12 17:04:57 -06:00
f1fc5dba92 add asterisk '*' to the list of non-working operations (#65728)
Asterisk '*' doesn't work either in the command module
2019-12-12 17:03:11 -06:00
af1c788ba7 Fix list formatting in Getting Started docs page (#65713) 2019-12-12 16:52:52 -06:00
c3c1708dea Fix variable name in an example (#65760)
Makes the variable name consistent between the example code (`myname`) and the text below (mentioning a variable called `name`) in the docs.
2019-12-12 16:51:47 -06:00
493ec588ab Ec2 metric alarm boto3 and treat missing data (#62669)
* Converted ec2_metric_alarm to boto3. Added treat_missing_data option.

* Handle potentially non-existent alarm keys in ec2_metric_alarm module

* Add treat missing data to ec2_metric_alarms wth some tests

Continues the work of #23407

* Clean up ec2_metric_alarm main test playbook

* fix test suite and sanity checks

* more fixes for sanity tests

* fixes to ec2_metric_alarms requested in code review

* import ClientError from botocore, catch generic ClientError

* more fixes from review

drops extra dict in argument spec and set_facts for aws access

* Fix pep8 blank line issue

* switch to fail_json_aws, add idempotency test

* fix under indented continuation

* remove unsupported alias

* Add group to ec2_metric_alarm aliases

* Put alarm prefix before resource prefix to match aws-terminator pr 63

* Add type for treat_missing_data
2019-12-12 14:09:09 -07:00
226bf7b227 apt target: use 'until' when the cache is updated (#65456)
This integration target can be unstable due to network/mirror issues:

    TASK [apt : uninstall hello with apt] ***
    fatal: [testhost]: FAILED! => {
        "changed": false,
        "cmd": "apt-get update",
        "msg": "E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/bionic-updates/universe/source/Sources.gz File has unexpected size (354740 != 354745). Mirror sync in progress? [...]",
        "rc": 100,
        [...]
2019-12-12 12:45:54 -07:00
9c30325704 fixed some link nits (#65772) 2019-12-12 13:20:08 -06:00
860cacc54f Docs: User guide overhaul, part 2 (#65474) 2019-12-12 13:35:17 -05:00
7af98f9724 Always cleanup vlan interfaces (#65756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-12 13:02:52 -05:00
0079b8eaa2 mysql_info: add return_empty_dbs parameter (#65755)
* Bugfix of 65727: mysql_info doesn't list empty DBs

* add changelog

* mysql_info: add return_empty_dbs parameter

* fix
2019-12-12 14:10:52 +01:00
80333f9c4b Clean up flake8 errors for eos unit tests (#65753)
These were found while migrating our content to eos collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-12 07:44:13 -05:00
90072d1baa added $team_zabbix to BOTMETA and updated zabbix modules maintainership (#65446) 2019-12-12 10:53:29 +00:00
cbc513e748 Fix simple typo: workind -> working (#65758)
Closes #65757
2019-12-12 15:37:14 +05:30
570c82f068 Patch: fix seports to allow integers or string (#65134)
Signed-off-by: Joshua Schmidlkofer <joshua@joshuainnovates.us>
2019-12-12 14:15:33 +05:30
4a54873023 Correct the spelling of property to last_modified (#65752)
Fixed the misspelt 'last_modified' field in azure_rm_storageblob output
2019-12-12 13:49:08 +05:30
356e3e30fa VMware: Handle KeyError while moving VM from suspended to poweredon
Modified module_utils/vmware.py to handle KeyError while moving VM from suspened to poweredon state.
2019-12-12 09:46:24 +05:30
41e19a4058 inventory: Fail on non-existing limit file (#59758)
Ansible now fails with error message when user provides
non-existing limit file.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-12 09:09:40 +05:30
b349ec8fcf Adding network plugin changes for netconf and network_cli (#65708)
* Adding network plugin changes for netconf and network_cli
2019-12-11 18:42:01 -06:00
a0cf42ae32 removed unnecessary ipv* address-family statements from vrf if the ip version is not used (#53866) 2019-12-12 00:29:23 +05:30
5eceebcaf3 Clarify how to install roles and collections from same requirements file (#65707) 2019-12-11 10:21:41 -06:00
e82b28a920 cgroup_perf_recap: Check if user wants to write to files or not (#64988)
if user sets 'write_files' to False or does not set value, then
handle file write related operations.

Fixes: #64936

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-11 20:21:38 +05:30
4da87fb3ee Fixed misleading helm module import failure message (#44916) 2019-12-11 15:04:42 +05:30
19220a0607 VMware: Add associable_object_types in vmware_category (#62347)
User can specify associable object types while creating the categories.
VMware API does not allow to modify associable object types after creation of
category.

Fixes: #61220

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-11 13:45:07 +05:30
24b8b629b9 hostname - Add OpenSUSE Tumbleweed Linux distro (#65457)
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-12-11 13:40:47 +05:30
0685691d07 Fixes for #56301, #64034 (#65369)
* Update nios_txt_record.py

Fix for Bug #62377

* Fixes for #62377, #64045, #64034

Fixes for #62377 nios_txt_record module cannot handle multiple TXT records

Fix for #64045 nios_a_record is requested to modify IP of existing A record, but attempts to create new A record instead

Fix for #64034 nios_fixed_address not able to add options that don't require use_options

* Update api.py

* Update nios_a_record.py examples

* Update nios_fixed_address.py

* Update nios_txt_record.py

* Update nios_fixed_address.py

* Update nios_fixed_address.py to fix #56301

Fixes #56301

* Update nios_fixed_address.py

* Update nios_a_record.py

* Update api.py
2019-12-11 13:12:47 +05:30
895c8ce373 Fixed bug when asa_acl terminates when lines array is empty (#63838)
* Fixed bug when asa_acl terminates when lines array is empty

* Removed redundant blank lines
2019-12-11 13:02:05 +05:30
bcc2ffdbf9 Fix version_compare with nxos_snmp_user tests (#65527)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 21:54:02 -05:00
da82ecadd6 Use fact cache to make nxos tests faster (#65479)
This should cut down about 1hour worth of test time, due to not looping
over the set_fact functions more then 60 times.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 21:53:48 -05:00
5ebce4672b VMware: add note to vmware_guest faq (#65569)
* add note to vmware_guest faq about the vmware API being read-only unless you're a paid subscriber
2019-12-10 15:45:32 -06:00
056b035c98 add module aws_step_functions_state_machine_execution (#64431)
* add module aws_step_functions_state_machine_execution

* AWS step functions tests - Use module defaults

* Return all attributes from aws api calls as ansible task output

* aws_sfn - make start and stop execution idempotent and fix check mode

* aws sfn - use build_full_result method of the paginator

* aws sfn - remove changes made to help with local debugging
2019-12-10 14:08:49 -05:00
95aef88a45 Update indentation used in the code examples, unify empty lines (#65346) 2019-12-10 10:55:51 -05:00
c5c1ad4fb8 Make docs testing_formatter script more portable (#65112)
* Make script more portable
sha1sum is a Linux only command. Test for the command and if not found
use sha1 instead for portability. Avoid patches on BSD and Mac systems.
2019-12-10 09:34:03 -06:00
d906fdeba2 Document group module return values (#65294)
* Document group module return values, based on iterating over the combinations of `state` and `system` with existent and non-existent groups.
2019-12-10 09:32:43 -06:00
f89db2af99 Adding filename and destroy options to vmware_guest_disk (#63740)
Adding filename and destroy options to vmware_guest_disk
2019-12-10 10:30:15 -05:00
02539c9a37 add os version requirement text to note (#65617)
* add os version requirement for win_format.py
2019-12-10 09:16:35 -06:00
88bba21708 Documenting how to change VM's params (#65429) 2019-12-10 10:05:07 -05:00
c185c46501 Update guide_azure.rst (#65519)
Adds subscription_id to the list of user/password credentials.
2019-12-10 08:58:01 -06:00
f89ea5677b Fix typo in a changelog fragment of #64902 (#65533) 2019-12-10 09:51:47 -05:00
3af1732bd8 fix rendering of GOOD/BAD code for regex_replace examples (#65654)
adds double colon (::) so the examples render as code
2019-12-10 08:49:38 -06:00
d9f0703b45 Update generator.py documentation (#65573) 2019-12-10 09:29:00 -05:00
e818ab1dd0 mysql_info: add seealso section (#65688) 2019-12-10 09:26:00 -05:00
4239dc1bb5 ANSIBLE_CACHE_PLUGIN_TIMEOUT - docs (#65311) 2019-12-10 09:19:54 -05:00
030b20b024 prepare_vmware_tests: ensure 'VM Network' exists (#65616)
Depending on the ESXi configuration, the 'VM Network' may missing.
2019-12-10 09:08:42 -05:00
53cd0bdd29 docs: Prefer python3 on OpenBSD (#65447) 2019-12-10 09:05:18 -05:00
d39870a693 Remove unused code in nxos_user (#65529)
There is no longer the need to warn on password, it is not supported any
more.

Update nxos_user tests not to purge current SSH user for nxos, otherwise
we loose access for testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 19:01:59 +05:30
7d2ae7e322 solaris_zone: Allow only valid characters in zone name (#65686)
CVE-2019-14904 - solaris_zone module accepts zone name and performs actions related to that.
However, there is no user input validation done while performing actions.
A malicious user could provide a crafted zone name which allows executing commands
into the server manipulating the module behaviour.

Adding user input validation as per Solaris Zone documentation fixes this issue.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-10 07:18:55 -05:00
c791f916d3 postgresql_schema: use query_params with cursor object (#65679) 2019-12-10 14:11:23 +05:30
2e82989b3b Add support for podman in virtualization facts (#64981)
Check additional file check virtualization facts for podman

Fixes: #64954

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-10 11:26:34 +05:30
f8216db21f Update iocage.py: remove 'docker' (#65656)
It seems to me as though the term 'docker' was copy/pasted in; I don't understand what it would mean in the context of iocage. As such, I think removal is best.
2019-12-10 11:09:54 +05:30
ddd786eedf Fix tests which have unparsable yaml 2019-12-09 16:54:29 -08:00
7767f0bb23 Mark yum tests as unstable (#65671)
Fedora 31 tests are failing due to a missing packages error. I am unable to duplicate this issue when running locally, so it is possibly an issue with a mirror that is being used when run from Shippable
2019-12-09 16:24:11 -05:00
880bbb9946 fixed inconsistent required set to True in zabbix modules 2019-12-09 10:20:17 -08:00
d35c1a435b Handle InternalError raised by cryptography when running in FIPS mode (#65477)
Since older versions of paramiko do not require cryptography,
we cannot catch the exact exception from cryptography.

Remove other exceptions since we're catching everything now
2019-12-09 13:18:32 -05:00
0b2558051c VMware: Minor fixes in vmware_httpapi modules (#65663)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-09 22:14:00 +05:30
0647c52368 Detect virtualization facts when VM on Nutanix AHV hypervisor (#58327)
- /sys/devices/virtual/dmi/id/product_name == 'AHV'
- /sys/devices/virtual/dmi/id/sys_vendor == 'Nutanix'
2019-12-09 21:50:20 +05:30
28019233db Don't search for VMDK if filename is defined (#63741) 2019-12-09 11:06:31 -05:00
d8943d495e AWS NLB: Deprecate current default behaviour of 'absent' (#65468)
* Deprecate elb_network_lb default of *delete*.

* Add changelog fragment

* Porting guide entry
2019-12-09 15:55:32 +01:00
ecb6f2e76c Fix bug in format handling. (#65642) 2019-12-09 18:56:15 +05:30
57c042243f crypto modules: fix various errors in argument specs (#65633)
* Fix various errors in crypto module argument specs.

* Adjust PR #.

* Fix provider requirement.

* Make sure openssl binary is installed.
2019-12-09 13:40:11 +01:00
e9cec0262d docker_* modules: fix various errors in argument specs (#65632)
* Fix various errors in docker module argument specs.

* Adjust PR #.

* Fix option name.

* Fix username/password requirements for docker_login.
2019-12-09 13:39:02 +01:00
9f87978eb3 aws_acm: Fixup typo in argument_spec (alias should be aliases) (#65653) 2019-12-09 18:00:22 +05:30
30132861af Introduce force_basic_auth for maven_artifact (#64808)
as it's known from uri or get_url. Causes basic auth header to be sent on first request to avoid trouble with some receiving ends.

Fixes #64595
2019-12-09 05:26:12 -05:00
9c79de2e1e ovirt_vm: dont try to update template when already created from clone (#65317) 2019-12-09 05:09:33 -05:00
5c9539903e iam_policy: Make 'iam_name' a required option to match the documentation (#65559)
Without it we'd always throw a boto error
2019-12-09 15:08:43 +05:30
4919d5658a iam_cert: Make 'name' a required option to match the documentation (#65558)
Without it we'd always throw a boto error
2019-12-09 14:53:53 +05:30
cf3f1b9d3f iam: Make 'name' required to match the documentation (#65557)
With the exception of deleting Users and Roles (where we'd do nothing and exit) not passing a name would trigger a boto exception.
2019-12-09 14:46:02 +05:30
eac7d2a958 ec2_placement_group: Make name 'required' to match the documentation (#65555)
Previously you'd get one of the following behaviours:
- A boto3 error
- Nothing would change
- An error that you're not allowed to change the strategy

So of the bahaviour would depend on the random order that AWS returns the list of all Placement Groups
2019-12-09 14:35:36 +05:30
a56139e792 Link to LTS version of Zabbix docs (#65604)
Documentation now points to version 4.0
2019-12-09 10:16:40 +05:30
7089fa1cd4 update to remove redundant code. (#65630)
* update

* update

* update
2019-12-08 20:37:35 -05:00
717c0da32b 2.10 -> 2.9.2 (#65517) 2019-12-08 15:14:24 +01:00
965474841f Use a context manager in docker.ImageManager. (#65609)
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-12-08 08:36:33 -05:00
03a4edb477 Add method to automatically clean up after an action plugin (#65509)
* Use correct var, move cleanup for async
* Add changelog and tests. Fixes #65393. Fixes #65277.
* Kill off all long running async tasks from listen_ports_facts
* Update task to work with older jinja2
2019-12-06 17:29:26 -05:00
c97360d21f vmware: vmware_vm_inventory use port value when with_tags:True (#65568)
If user specifies a port number in vmware_vm_inventory plugin configuration,
then use that port to connect to vCenter rather than connecting to 443 which
is default port.

Fixes: #64096
2019-12-06 15:23:12 -05:00
b782227642 display - Fix up tracebacks on 3rd party loggers when log path is set (#65582) 2019-12-07 06:06:52 +10:00
09fca101b7 Nagios module: minor change, added "start" parameter (#61562)
* Finished implementing the "start" parameter to the nagios module. The backend functions already had it; this change just exposes it. This allows setting the time a Nagios outage begins rather than always starting at the time the module was run. If not provided, "start" defaults to the current time (preserving compability with existing playbooks).
* Changed default start time to None, as per comment by @goneri. This avoids initializing the variable twice.
2019-12-06 12:23:03 -05:00
b8cd4c5409 remove some tests from zuul/vmware/vcenter_only
Depends-On: ansible/ansible-zuul-jobs#253

We cannot run the following tests without any ESXi host:

- vmware_drs_rule_info
- vmware_drs_rule_facts
- vmware_host_acceptance
- vmware_host_active_directory
- vmware_host_powerstate
2019-12-06 12:20:21 -05:00
5ad61ed7c1 Fix and reenable hcloud tests 2019-12-06 08:30:01 -08:00
e444e68bf0 Add podman_container_info module (#64361)
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-12-06 09:50:30 -05:00
63bb08fea8 Object searching method should not traceback for non-existant keys (#65553)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-06 17:56:39 +05:30
531eebffa8 mysql: remove unused import (#65606) 2019-12-06 12:19:45 +00:00
10898cbcbf postgresql_idx: fix maintainer's name (#65605) 2019-12-06 06:06:29 -05:00
0474f0b4dd mysql_info: add note to the module's documentation (#65603) 2019-12-06 05:53:04 -05:00
a79c9e23ee mysql_db: add seeaslo section (#65593) 2019-12-06 02:30:28 -05:00
85486b1ce4 mysql: add changelog fragment for PR 64585 (#65594)
* mysql: add changelog fragment for PR 64585

* change fragment name and bug description
2019-12-06 12:05:47 +05:30
47aea84924 Don't return module error when mysql_connect fails (#64560) (#64585)
* Don't return module error when mysql_connect fails (#64560)

mysql_user expects an Exception when using check_implicit_admin.

* Adds integration tests for mysql_user check_implicit_admin (#64560)
2019-12-06 11:22:34 +05:30
f21e72d55a win_package - Use newer module wrapper as refactor baseline (#65586)
* win_package - Use newer module wrapper as refactor baseline

* Fix aliases in new arg spec
2019-12-06 13:37:52 +10:00
3919a891c2 Fix iosxr netconf plugin get device info (#65489)
* Fix iosxr netconf plugin get device info

Fixes https://github.com/ansible/ansible/issues/64634

*  Catch execption if the xml payload to get
   device info is not valid for iosxr version
   running on remote host.

* Fix CI issue
2019-12-06 08:58:03 +05:30
9a81f5c3b7 win_uri win_get_url - Fix up redirection defaults (#65584) 2019-12-06 11:47:35 +10:00
eaba5572cd ansible-galaxy - expand User-Agent string for Galaxy endpoints (#65578) 2019-12-06 10:34:14 +10:00
fcdebe41e9 win_find - Refactor for better performance and alignment to find (#65536)
* win_find - refactor to make more performance and use newer style

* win_find - refactor for performance improvements and alignment to find

* More path alignment to find

* Fix yamllint error
2019-12-06 10:01:11 +10:00
96cbbdd59f update version metadata to get faceted swiftype search running (#65574)
* update version metadata to get faceted swiftype search running
2019-12-05 15:16:34 -06:00
edc7c4ddee Fix encrypt command output when using --stdin-name (#65122)
* Fix encrypt command output when using --stdin-name

Add a new line after reading input if input doesn't end with a new line

* Only print is we're in a tty

* Add changelog fragment
2019-12-05 15:42:15 -05:00
a0f26b40cb Sanity checks: test for print statement (#65219)
* Add test for print() call in module_utils and modules.

* Add changelog fragment.

* Add ignore.txt entries.

* Use blacklist plugin instead of adding a new.

* Update ignore.txt
2019-12-06 05:31:31 +10:00
e1be5a8acb vmware host system fact add uuid (#65415)
* vmware host system fact add uuid
2019-12-05 12:00:41 -05:00
631120e749 Yet more Sanity test "required" Amazon module cleanup (#65554)
* More 'required' cleanup on AWS modules.
2019-12-05 09:58:55 -06:00
8a409f37db Throw an error on unsupported vars_prompt keys (#65487) 2019-12-05 10:54:32 -05:00
b975fd407d Remove timeout from nxos tests (#65470)
This fixes the following:

  Unsupported parameters for (nxos_rollback) module: timeout unsupported

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-05 10:39:35 -05:00
95c85b395c Add hetzner_firewall_info module. (#65421) 2019-12-05 20:40:11 +05:30
c59e061cff mysql_info: add exclude_fields parameter (#63371)
* mysql_info: add exclude_fields parameter

* mysql_info: add exclude_fields parameter, add changelog fragment

* change logic
2019-12-05 13:29:58 +00:00
8b684644e0 Add support for fetching Lifecycle Controller and System attributes (#65280)
* support for fetching lifecycle controller and system attributes

* Support for fetching lifecycle controller and system attributes

* fixed syntax error

* minor documentation update
2019-12-05 07:32:24 -05:00
8f78a0f8bf postgresql_publication: use query params with cursor object (#65404)
* postgresql_publication: use query params with cursor object

* add changelog
2019-12-05 10:44:45 +00:00
0c71249b03 mysql_db: add force parameter (#65547)
* mysql_db: add force parameter

* mysql_db: add force parameter

* add changelog

* add the param to state dump
2019-12-05 10:44:22 +00:00
7d3cc250ef Fix ec2 filter dict iteration for python3.8 (#65521)
Python now throws a RuntimeError if dict keys are modified mid-iteration.
https://bugs.python.org/issue36452
Cast filter dicts to list before iteration.

Fixes: 65024
Related: 65434
2019-12-05 05:02:59 -05:00
c266fc3b74 postgresql_db: add executed_commands returned value (#65542)
* postgresql_db: add executed_commands returned value

* add changelog

* fix tests
2019-12-05 10:53:08 +01:00
4352e39989 Update network common code to support new states (#65534)
*  Update the network common code to support the
   new resource modules state - parsed, rendered
   and gathered.
*  For states parsed and rendered active connection
   to remote host is not required.
2019-12-05 13:21:01 +05:30
96df2bdcf3 Fixed argument spec for multiple modules (#65496)
This change contains fixes for argument spec and respective datatypes.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-05 11:59:05 +05:30
c3d5371510 route53: diff support (#64867)
* Refactoring.

* Add diff support.

* Add changelog.
2019-12-05 06:22:11 +01:00
fb69d68821 Fix plugin paths for ansible-test pylint test. (#65526)
* Fix plugin paths for ansible-test pylint test.
2019-12-04 18:07:16 -08:00
4d3ebd65db win_auto_logon - check, diff and store pass in LSA (#65528)
* win_auto_logon - check, diff and store pass in LSA

* Ensure baseline keys are set for test

* Skip remove item prop on check mode due to win bug

* Start at a cleared baseline to ensure old LSA secrets are cleared
2019-12-05 11:24:30 +10:00
cff80f1319 azure_rm_galleryimageversion: support data disk snapshot as source input (#65405)
* azure_rm_galleryimageversion: support data disk snapshot as source

* fixing typo
2019-12-05 08:31:47 +08:00
2dcaa108d8 Adding new module win_auto_logon (#63414)
* add new modul

* correct password var

* fix for linting issues

* add return values documentation

* linting fixes

* Get tests working and simplify a bit
2019-12-05 09:27:08 +10:00
567c860027 Split up docker-registry test target. (#65211)
* Copy relevant docker-registry files:

docker-registry/files/nginx.conf -> setup_docker_registry/files/nginx.conf
docker-registry/files/nginx.htpasswd -> setup_docker_registry/files/nginx.htpasswd
docker-registry/meta/main.yml -> setup_docker_registry/meta/main.yml
docker-registry/tasks/main.yml -> setup_docker_registry/tasks/main.yml
docker-registry/tasks/main.yml -> setup_docker_registry/handlers/cleanup.yml

* Remove non-cleanup code from handlers/cleanup.yml.

* Remove tests and cleanup from tasks/main.yml.

* Register cleanup handler.

* Use setup_docker_registry in docker-registry test.

* Fix handler execution order.

* Split out docker_login integration test.

* Move remaining tests into docker_image test.

* Cleanup before running docker_image options test.

* Improve reliability of test cleanup.

* Move files for conditional inclusion.

* Set proper conditions on tests.

* Rename tasks file for conditional inclusion.

* Conditionally include tasks.
2019-12-04 14:14:43 -08:00
a8efe7442c vmware/test: set vmware/scenario/vcenter_only alias (#65515)
Add the `vmware/scenario/vcenter_only` alias to be able to identify the
vmware test roles that can be tested with just on vcenter instance.

Also, add a check to be sure we don't try to attach ESXi hosts if none
has been defined.
2019-12-04 17:12:29 -05:00
212fb40147 Added an example with output. (#65336)
* Added an example with output.

##### SUMMARY
<!--- Added an example with output. -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Just use simpler debug tasks
2019-12-05 06:56:51 +10:00
be8fa961cf Fix RuntimeError in ec2_group_info (#65434)
Modifying dictionary while iterating over it
2019-12-04 13:50:06 -07:00
fc54ae9227 dnf: don't return fail_json['msg'] as list (#65302)
Although it's not enforced that fail_json['msg'] should be a string
[1], I think it is pretty strongly implied.

In this case the failure_response['msg'] is sent through as the
fail_json['msg'], and the trailing commas here turn it into a tuple.
It's not clear if this is a typo or intended, but it does cause
problems for callbacks that expect this as a string (e.g. [2]).

Since there seems no point to having these values as a tuple, remove
the trailing commas so they return a string as per everywhere else.

[1] 4c589661c2/lib/ansible/module_utils/basic.py (L2078)
[2] https://review.opendev.org/#/c/696081
2019-12-04 15:28:10 -05:00
770430fd07 Added required parameter to document DOC-string to produce Documentation. (#65230)
* Added required parameter to document DOC-string to produce Documentation.

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

* Just copy short_description as it was
2019-12-05 06:23:45 +10:00
c04fc52aad win_dns_client - only configure ip enabled adapters (#65488) 2019-12-05 06:04:13 +10:00
9973121f44 Fix ansible-galaxy man page generation (#65478)
The Action list was misformatted, leading to an error message in the man
page.

https://bugzilla.redhat.com/show_bug.cgi?id=1717110
2019-12-04 13:49:21 -06:00
2a7623dd5c Add CentOS 8 to the test matrix (#63649) 2019-12-04 13:39:00 -05:00
b51a1bc429 Fixup parameter documentation ("doc-required-mismatch") AWS simple cases (#65462)
* Clean up "required" lines in AWS module docs, remove corresponding ignore.txt entries, general docs cleanup
2019-12-04 10:00:50 -06:00
4184b05cc1 meraki_organization - Ignore URL parameter when comparing for… (#65337) 2019-12-04 10:40:56 -05:00
79b088aeba Meraki - Remove type comparison for idempotency check (#65338)
* Remove type comparison in is_update_required()

* Add changelog
2019-12-04 10:39:26 -05:00
f4a9f23a1b Removes duplicate HAS_IPADDRESS variable assignment in postgresql_pg_hba. (#65408) 2019-12-04 08:29:48 -05:00
2eb615f1ef gitlab_runner: fix idempotency for shared runners (#65176) 2019-12-04 08:18:46 -05:00
651dff6a2e mysql_db: add the executed_commands returned value (#65498)
* mysql_db: add the executed_commands returned value

* add changelog
2019-12-04 18:31:33 +05:30
03c16096d7 Fix extract filter when key does not exist in container (#64959)
Fixes #64957
2019-12-04 13:24:52 +01:00
9404384985 Add junos_static_routes module (#65239)
This commit adds a new network resource module for static routes on
junos devices.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
2019-12-04 12:59:56 +01:00
520a505caf VMware: Fix state parameter in vmware_host_lockdown module (#65495)
Changed 'str' to 'type' in Argument_spec which is valid parameter.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-04 14:16:13 +05:30
2d074f2a31 win_description Module (#61629)
* win_description Module

Module to change Windows description and Windows license owner information.

* LiteralPath updated

changed -path to -LiteralPath in the script

* Version and metadata_version

version_added updated to 2.10
Metadata_version set to 1.1

* version updated

version_added changed to '2.10'

* Changes based on feedback

* removed some redundant checks

* Rename win_description.ps1 to win_computer_description.ps1

* Rename win_description.py to win_computer_description.py

* Module name change

* Integration tests added

* added aliases file

* Change compatibility from 2008 to 2008R2

* Update aliases
2019-12-04 14:25:16 +10:00
cfb6cb4cef Win data deduplication module (#59723)
* win_data_deduplication initial commit

* Ansible version added bump

* integration tests

* missing aliases

* Fixing documentation

* license and metadata

* documentation formating

* removing win_format ref

* documentation fixes

* trailing whitespace

* Fixing more documentation :(

* missing return

* documentation cleanup

* align copyright with doc

* indentation fixes...

* updated examples

* ignore meta and future for python doc

* removing when

* use Get-PSVolume

* Get-Volume not PSVolume

* missing updated var

* updated old drive refs

* make sure that the T drive is formated as NTFS

* path and drive_letter are exclusive

* idempotence test fix

* changing task order + reboot timeout

* implementing the requested changes to the code

* updating documentation to reflect code changes

* simplifying tests

* missing feature install before running the tasks

* pslint trailing whitespace

* putting old tests back

* missing win_format

* skip windows 2012

* Fixing message for OS check

* pass settings and dedup_job variables

* Removing unnecessary module

* logic issue

* replacing tabs with double space

* documentation fix + removing tabs

* Update documentation with recent changes

* Apply changes requested

* switch feature install with partition format

* replace tabs with spaces

* trailing whitespace

* we don't need those ignores anymore

* minor fixes

* updated test to match latest code changes

* removing dedup job task

* adding check mode yes test

* fixes for check_mode support

* updating examples in documentation

* wrong indentation for check_mode in tests

* convert indentation to spaces

* -not $check_mode

* removing unneeded spec in documentation

* Switch to Ansible.Basic

* 2.9 is already gone, so let's add this module to 2.10...

* removing useless else condition

* updated documentation

* fixing specs and removing useless try/catch + fix exit/fail

* spaces indentation

* $null check is actually needed if volume never had dedup

* Missing check_mode update

* removing required for default state in documentation

* converted tabs to spaces
2019-12-04 14:21:21 +10:00
584824f560 win_share - Implement append paramtere for access rules (#59469)
* win_share - Implement append paramtere for access rules

* changed fragment

* add test

* missing bracket

* removed whitespace

* Wrong number of lines

* Forgot the actual new parameter in the test

* community review

* Change option names

* version update

* Update tests.yml

* Add idempotence to rule_action: add
2019-12-04 14:16:10 +10:00
ed54b9b441 add win_initialize_disk module (#58617)
* add win_initialize_disk module

* Add ability to specify disk by path or uniqueid

* Fix documentation

* fix shippable failures

* Update anisble version

* Slight tweaks to the documentation

* Small documentation fixes
2019-12-04 12:37:15 +10:00
85722c360f Disable failing hcloud tests. 2019-12-03 17:52:08 -08:00
d710a5cd7f eos_interfaces: Added unit testcases for eos_interfaces (#63813)
* Added unit testcases for eos_interfaces

* Corrected lint errors

* Corrected lint errors

* Addressed Review comments
2019-12-03 18:42:26 -05:00
db709488bd Update foreman inventory to use foreman's inventory report (#62438) 2019-12-03 15:11:40 -07:00
322a4dc691 BOTMETA migrated_to should be namespace.collection (#64029) 2019-12-03 19:20:58 +00:00
88d8cf8197 Remove no longer valid ignore.txt entry. (#65469) 2019-12-03 18:13:23 +01:00
974e8cec3d prepare_vmware_tests: run test w/ just 1 vcsa (#65433)
Add the ability to run test with just a VCSA instance. This allow us to
test a subset of tests that don't need any ESXi nodes.
2019-12-03 11:17:06 -05:00
daecbb9bf0 Ensure allow_duplicates: true enables to run single role multiple times (#64902) (#65063)
* Ensure `allow_duplicates: true` enables to run single role multiple times(#64902)

* Changed return value in `_load_roles` . Fixes #64902

* Add changelog fragment

* Add an integration test for the issue

* Fix changelog generation error and integration test.

* Fix yaml syntax error in changelog fragment
2019-12-03 10:21:54 -05:00
4be8b2134f Sanity checks: make sure that required in argument spec coincides with documentation (#65437)
* Add sanity test for required parameters, update ignore.txt, and add changelog.
2019-12-03 09:15:07 -06:00
c19949706f vyos: Make vyos related yaml file passing yamllint (#65449) 2019-12-03 09:34:35 -05:00
ae4363f6d1 openssl_csr: make sure privatekey_path is specified when state is present (#65435)
* Make sure privatekey_path is specified when state is present.

* Add changelog.
2019-12-03 14:08:26 +01:00
d82361a709 Fix exos_lldp_interfaces support status (#65428)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-03 13:47:32 +05:30
49b457016e k8s: persist refreshed tokens (#63219)
When the ansible k8s module is refreshing the tokens from the local kube
config, it should save those token to the kube config file.

If this is not done, this might break the next kube client call as the
token in the local kube config file is not valid anymore and refreshing
can fail.

This commit is adding an env var K8S_AUTH_PERSIST_CONFIG that can be
used to set this flag to true (default is false, same as current
behavior).
2019-12-03 12:22:26 +10:00
8648003c1f ansible-galaxy - Add User-Agent to requests (#65438) 2019-12-03 10:04:41 +10:00
6075536907 route53_info: add pagination support to list (#60433) 2019-12-02 15:33:59 -07:00
6586b7132c galaxy - print HTTP reason on unknown error (#65273) 2019-12-03 07:36:05 +10:00
0e5a83a1cc Add Fedora 31 to the test matrix (#64848)
* Add Fedora 31 to the test matrix

* Remove Fedora 29 from the test matrix
2019-12-02 15:54:32 -05:00
37ce55fd79 lightsail - Use AnsibleAWSModule (#65275)
* lightsail - Use AnsibleAWSModule

- Use AnsibleAWSModule
- Refactor the logic for wait into a separate function (Fixes #63869)
- Handle exceptions in find_instance_info and add a fail_if_not_found parameter
- Add a new state `rebooted` as an alias for `restarted`. AWS calls the action Reboot.
- Add required_if clause for when state is present

* lightsail - Use the default keypair if one is not provided

* lightsail - add a required_if for when state=present

* Update short description for lightsail module
2019-12-02 13:12:44 -07:00
02e7c5a19f vmware_datastore_cluster: Added SDRS configuration (#65193) 2019-12-02 15:02:50 -05:00
694ef5660d Fix using a URL for galaxy collection install (#65272)
* Fix using a URL for galaxy collection install

* Update lib/ansible/galaxy/collection.py

Co-Authored-By: Sloane Hertel <shertel@redhat.com>
2019-12-03 04:55:31 +10:00
41472ee387 Describe different ways to set connection timeout options (#65126)
* add timeout option examples, link to new section, implement feedback
2019-12-02 10:42:45 -06:00
a8ef5d5034 VMware: Autoselect datastore only from the given cluster/ESXi (#43435)
* Autoselect DS only from the given cluster/esxi
* Run tests only on real vCenter
2019-12-02 21:53:08 +05:30
5942e7f2a2 Fix type in svn documentation path (#65353) 2019-12-02 09:55:02 -06:00
21bbf49396 Mention Python builtin methods in filter docs (#65425) 2019-12-02 09:44:59 -06:00
8ebc57c186 Mention that Python keywords are invalid Ansible variable names (#65094)
* Mention that Python keywords are invalid Ansible variable names
Using a Python keyword as a variable name triggers the error `Invalid variable name in 'register' specified: 'return'`.
2019-12-02 09:42:40 -06:00
0cadb952f9 postgresql_ext: use query_params (#64994)
* postgresql_ext: use query_params

* added changelog
2019-12-02 13:32:25 +00:00
c53b8030ab lbu module: Alpine Linux Local Backup Utility (#62584) 2019-12-02 19:00:09 +05:30
a8f1c85a20 VMware: Updated module compatibility with vsphere version. (#65419)
Update vmware_content_deploy_template module compatibility with vSphere version.
2019-12-02 18:57:56 +05:30
08b53b94a9 acme_certificate: Fix ACME v1 support when modify_account is set to false (#64648)
* Fix ACME v1 when modify_account is set to false.

* Add changelog.
2019-12-02 03:35:49 -05:00
5f6057598e Hetzner: dedicated server firewall module (#65399) 2019-12-02 09:19:49 +01:00
da73bbd73c openssh_keypair - Add logic to handle password protected or broken key (#64436)
* The ssh key may be created manually prior the task execution with a
  passphrase. And the task will be executed on the same key.
* The ssh key may be broken and not usable.

The module will check the private key and if the key is password
protected or broken, it will be overridden.
The check of the ssh key performed by retrieve the public key from the
private key.

Set the "self.force" check before the "isPrivateKeyValid" check.
In case of any issue with the "isPrivateKeyValid" function, the user
will be able to force the regeneration of the key with the "force: yes"
argument.
2019-12-02 08:12:38 +01:00
a0b8b85fa5 ufw: add support for interface_in and interface_out (#65382)
* ufw: escalate privileges in integration tests

A few of the integration tests for the UFW module forgot to `become`.
This is problematic if the test suite is executed as a non-privileged
user.  This commit amends that by adding `become` when appropriate.

* ufw: add unit tests for direction and interface

Extend the unit tests for the UFW module to test the `direction` and
`interface` parameters.  This will help in the implementation of a fix
for issue #63903.

* ufw: add support for interface_in and interface_out

The UFW module has support for specifying `direction` and `interface`
for UFW rules.  Rules with these parameters are built such that
per-interface filtering only apply to a single direction based on the
value of `direction`.

Not being able to specify multiple interfaces complicates things for
`routed` rules where one might want to apply filtering only for a
specific combination of `in` and `out` interfaces.

This commit introduces two new parameters to the UFW module:
`interface_in` and `interface_out`.  These rules are mutually exclusive
with the old `direction` and `interface` parameter because of the
ambiguity of having e.g.:

    direction: XXX
    interface: foo
    interface_XXX: bar

Fixes #63903
2019-12-02 08:01:44 +01:00
03dce68227 win_disk_facts - Set output array order to be by disk number property (#64997)
* win_disk_facts - Set output array order to be by disk number property - https://github.com/ansible/ansible/issues/63998

* Update win_disk_facts.ps1
2019-12-02 06:54:18 +10:00
d8982b4992 win_nssm - Implement additional parameters (#65131)
* win_nssm - Implement additional parameters

* Update win_nssm.py

* Snake case change

* Update win_nssm.py

* Update win_nssm.ps1

* Remove duplicated executable option

* Added default values for new options
2019-12-02 06:49:07 +10:00
2acfa0e08c Add passphrase support for luks_device (#65050)
* Elevate privileges for luks_device integration tests

Several tests in `key-management.yml` don't `become` before executing,
despite needing elevated privileges.  This commit fixes that.

* Add passphrase support for luks_device

Previously, the luks_device module only worked with keyfiles.  The
implication was that the key had to be written to disk before the module
could be used.

This commit implements support for opening, adding and removing
passphrases supplied as strings to the module.

Closes #52408
2019-11-30 20:50:30 +01:00
0d34a2ecee syspatch: Check for apply=no condition (#65350)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-30 19:39:54 +05:30
38193f6b60 proxmox: fix proxmox 6 version detection by using LooseVersion (#59165)
* proxmox: use 'release' key for version detection if possible

* proxmox: fix PEP issues

* add changelog fragment

* Uses LooseVersion for proxmox version detection

* move imports

* removes useless comment
2019-11-29 18:16:40 +01:00
0407af936a vmware/test: switch the ro of the two datastore (#65356)
The `ro_datastore` was actually using the value of `rw_datastore`.
2019-11-29 10:23:57 -05:00
d335d7a62c Use context manager for mssql and postgresql modules. (#65224) 2019-11-29 00:37:23 -05:00
deb0cbbf73 VMware: Fix vmware_host_dns examples (#65355)
Added type in example sections
2019-11-29 06:50:33 +05:30
34ecd6cb25 VMware: Update hostname when VM is cloned (#65037)
Fixes: #57873
2019-11-28 16:43:46 +05:30
6ae01d4fbd postgresql_owner: use query_params with cursor (#65310)
* postgresql_owner: use query_params with cursor

* add changelog fragment
2019-11-27 10:42:26 +00:00
8d6192d61e adding encoding dump/import support for the mysql_db module, with upd… (#65228)
* adding encoding dump/import support for the mysql_db module, with updated documentation, and full test suite

* fixing lint issue test #3

* fixing lint issue test #1

* fixing lint issue test #1 second time

* Improving Test to be re-entrant

* improving test to not fail on centos/6

* Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml

Comminting suggestion

Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com>

* Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml

comminting suggestion

Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com>

* adding comment

Adding comment to explain test strategy

* Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml

Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com>

* Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml

Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com>

* Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml

accepted

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update encoding_dump_import.yml

* Fixing typoo
2019-11-27 10:41:55 +00:00
8df03a6f6e azure_rm_virtualmachine: Fix VHD URI valid schemes in extract_names_from_blob_uri (#64507)
When a VM has been provisioned with unmanaged disks (VHD), the URI
schemes used for those disks are kept untouched. Unfortunately, the regexp that
parses the URI only accepts 'https' leading the module to fail if one
uses for instance 'http'.

Please note that the official Azure API documentation uses 'http' and
not 'https' as URI scheme.

Resolves #64506

Testing Done: Using an ARM template, provision a VM with one OS and one
data disk with 'http' as VHD URI scheme. Then use the
azure_rm_virtualmachine module to delete the VM. Finally check that the
module does not fail anymore and that the unmanaged disks are correctly
deleted from the storage account.
2019-11-27 15:55:06 +08:00
7c65ad11e2 azure_rm_storageaccount_info: Fix list_all method (#64321)
The 'azure_rm_storageaccount_info' module was calling the storage client
'list_by_resource_group()' method rather than the 'list()' one, leading
to callers not being able to fetch all the storage accounts of their
subscription.

Issue: #64319

Testing Done: was successfully able to call the module and retrieve
all the storage accounts in the subscription without having to
specify a resource group.
2019-11-27 15:53:51 +08:00
4b240a5d74 Azure RM: Fix missing ipConfiguration 'primary' attribute (#63722)
If a NIC has no primary ipConfiguration, the 'primary' field returned
by Azure is set to 'null' thus removed from the 'nic_model'
ipConfigurations properties. Unfortunately the code generating the
hostvars dict. assumes the 'primary' key always exists, leading the
entire host parsing to fail.

This patch changes the way the 'primary' field is accessed by using the
dict. 'get' method with a default value set to 'False'.

Resolves #63721

Testing Done: Run ansible-inventory with an azure_rm plugin that points
to a resource group that contain a two VMs, on with a primary
ipConfiguration and another one without. Check that without the patch
the inventory output does not contain the VMs (or just the one with the
primary ipConfiguration set, depending on the VM names). Finally check
that with the patched azure_rm.py file, both VMs show up.
2019-11-27 15:53:05 +08:00
4c589661c2 Fixed want_facts in the foreman inventory plugin - fixes #65111 (#65114)
* Replaced 'ansible_facts' by 'foreman_facts'

'foreman_facts' is the key that the foreman inventory script used
'ansible_facts' is a special key that is overwritten internally and has never worked in this inventory plugin

* Added changelog
2019-11-26 13:41:28 -05:00
39ebd244e3 Update playbooks_filters.rst (#64769) 2019-11-26 13:39:12 -05:00
756ac826fe Improve ignore_unreachable documentation (#64938) 2019-11-26 13:35:02 -05:00
2460470ae7 Add an example for mounting NFS. (#64974) 2019-11-26 13:30:37 -05:00
12670f5a80 all modules documentation should be valid yaml data (#64838) 2019-11-26 13:18:16 -05:00
8d0c2cd4d5 include_vars: Check NoneType for raw_params (#64979)
Lookup 'first_found' returns empty list which results in
raw_params checking. Check NoneType for 'raw_params' before
proceeding.

Fixes: #64939

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-26 13:11:02 -05:00
a15fb2637d Add or later to the license expressed in the README
This is a clarification, not a relicensing.

Our source code says "GPLv3+" or "version 3 of the License, or later".
Our documentation says GPLv3+:

https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_checklist.rst#contributing-to-ansible-objective-requirements

We were just lazy when we wrote the README and left out the "or later".
this update to the README brings it in line with what everything else
says.
2019-11-26 08:33:41 -08:00
ee413fe414 Allow updating of ec2_group rules with EC2 classic ELB targets (#62374)
* Allow updating of ec2_group rules with EC2 classic ELB targets

Fix regression introduced in #45296 with EC2 Classic SGs

Fixes: #57247

Also add (unsupported) ec2 classic test suite with test case for this scenario

* move ec2 classic tests to conditional within ec2_group target

* clean up ec2_classic tests

* ec2_classic account can't run most ec2_group tests
2019-11-26 11:29:03 -05:00
a67ff91032 Fixed some documentation for postgresql_slot (#65278) 2019-11-26 09:30:47 -05:00
7f97f86303 add a new module to configure multicast igmp and enable it. (#63746)
* add a new.

* import-error

* update docs.

* add unittest.

* Update test_ce_multicast_igmp_enable.py

* add a ihtegration test.

* update for review.

* update for review.

* add notes.
2019-11-26 11:38:30 +00:00
76e904e44f add a new module to create isis instance. (#63716)
* add a new

* update to add futuer.

* update

* update shippable

* update docs.

* update

* add unittest.

* add integration test.

* update for shippable.

* syntax error

* syntax error

* syntax error

* update for review.

* update for review.

* add notes.
2019-11-26 11:23:05 +00:00
8c88ee3b9f add a new module to configure multicast global. (#63745)
* add a new module.

* add future

* update docs.

* update

* update

* update

* update

* add test.

* Update test_ce_multicast_global.py

* update for review.

* update for review.

* add notes.
2019-11-26 11:22:39 +00:00
9f58e915d9 add a new module to configure mdn on interface. (#63755)
* add a new module to confiure mdn on interface.

* doc-default-does-not-match-spec.

* add unittest

* Update test_ce_mdn_interface.py

* add integration.

* update for review.

* add notes.
2019-11-26 11:21:40 +00:00
f543e72d0a postgres.PgMembership: use query params in cursor.execute method (#65164)
* postgres.PgMembership: use query params in cursor.execute method

* changelog fragment
2019-11-26 11:19:41 +00:00
2242c385b2 Zabbix: zabbix_template: fix #63907 and add test case (#65236)
* Zabbix: zabbix_template: fix https://github.com/ansible/ansible/issues/63907 and add test case

* update test case
2019-11-26 11:18:55 +00:00
eb423ecec0 add a new module to configure isis on interface. (#63717)
* add a new.

* update doc

* update docs.

* update

* delete provider.

* add future.

* add unittest

* add integration test.

* KeyError

* update for review.

* add notes.

* unused codes removed.
2019-11-26 11:12:31 +00:00
ee3f8d28a4 Fix cli context check for network_cli connection (#64697)
* Fix cli context check for network_cli connection

Fixes #64575

*  Check cli context for network_cli connection
   at the start of new task run only.

* Pass task_uuid around to identify start of new task run

* Handle for local connection
2019-11-26 08:40:49 +05:30
bd68bcab95 Fix empty and zeroed memory variables on Windows (#65259)
* Fix empty and zeroed memory variables on Windows

The CIM elements about swap information are for Unix platform implementations of Powershell. CIM has separate elements for the "Windows swap".  This fixes memory information being non-present or zero.

* Properly name Windows variables for Page File

See https://github.com/ansible/ansible/pull/65259 for discussion

* Update setup.ps1
2019-11-26 12:18:25 +10:00
9dca2bd3c4 collection: Provide additional info about collection name restriction (#65250)
Fixes: #65151

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-26 11:29:13 +10:00
cd8b42c376 Bug fixes for GCP modules (#64823) 2019-11-25 19:20:07 -05:00
4fdc022853 Bug fixes for GCP modules (#64824) 2019-11-25 19:19:56 -05:00
152a94bfaf Bug fixes for GCP modules (#64825) 2019-11-25 19:19:49 -05:00
954ce8d21e Bug fixes for GCP modules (#64826) 2019-11-25 19:19:33 -05:00
01249b7fb1 Bug fixes for GCP modules (#64827) 2019-11-25 19:19:26 -05:00
161ad4bf2c Bug fixes for GCP modules (#64828) 2019-11-25 19:19:19 -05:00
19063166dd New Windows Module: win_file_compression (#56475)
* add win_compact module

* fixed line endings

* fix documentation

* Use cim method instead of wmi method

* renamed to win_file_compression
added single file support
added force option to avoid traversing large directory structures

* fixed end of file

* fixed renaming.
bench test still had win_compact as a module

* Removed more NTFS references and slight test tweaks
2019-11-26 09:26:13 +10:00
7084dd727a clarify httpapi with an example (#65083) 2019-11-25 16:30:16 -06:00
b2fc12a29f clean up network toc (#65264) 2019-11-25 15:17:49 -06:00
a797802d27 playbooks_filters_ipaddr.rst: fix syntax, indentation (#65208) 2019-11-25 15:00:15 -05:00
f9f19d171b updated required zabbix-api version for zabbix modules (#65145) 2019-11-25 14:59:15 -05:00
af64e9ce6a add Automation Hub stub page (#65261)
* add Automation Hub stub page

* implement feedback
2019-11-25 13:58:01 -06:00
0471ed3731 Add docs clarifying behavior of retry files (#65153) 2019-11-25 14:26:46 -05:00
c1f280ba6e Inventory CLI - Ignore settings for when vars plugins should run (#65073)
* Inventory CLI - Ignore settings for when vars plugins should run and just always run them

* Add note to porting guide

* Fix loading vars plugins

* changelog

* Remove a staging test for ansible-inventory since it ignores that setting
2019-11-25 13:16:03 -05:00
8f1af61851 vmware_guest: relax the requirements of the tests (#65192)
- 128MB or RAM is enough for most of the cases
- 1VCPU is also enough
2019-11-25 12:58:22 -05:00
277dd54d45 Fix/archive empty file (#64895)
* Remove call to filecompare to fix issue with empty file exclusion from archive

* Add empty file
2019-11-25 11:23:14 -05:00
f9f7a0c60e fix syntax issue (#65166)
- can disabled  
+ can be disabled
2019-11-25 15:01:10 +00:00
e4196f99e0 one_vm: Fix typo in error message. (#65253)
##### SUMMARY
Fix a (likely) copy+paste error in error message in the `one_vm` module.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-11-25 14:54:38 +00:00
2d6f716d37 Add 'bhyve' as a valid brand for SmartOS vmadm (#65200) 2019-11-25 20:20:39 +05:30
b08e7daf46 Do not treat AnsibleUndefined as being unsafe (#65202)
* Do not treat AnsibleUndefined as being unsafe. Fixes #65198

* fix yaml formatting
2019-11-25 15:06:29 +01:00
f37dbf859b os_security_group_rule fix port matching when protocol is any (#59055)
* Added logic to match on protocol 'any'

I personally use this to remove the default created egress rules from
security groups.

* Fixes for ansible-test
2019-11-25 08:05:34 -05:00
5f8ec4d46e Handle LibraryError exception in postgresql_db (#65229)
* Added changes into changelogs/fragments
* Removed no longer used 'LibraryError'.

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
2019-11-25 15:12:18 +05:30
89954e6ef5 Test fix (#65132) 2019-11-25 12:16:19 +05:30
4d69648893 Add default log level for new facitlity (#65197) 2019-11-25 12:04:36 +05:30
8daa42bb3d Support non-KV and KV v1/v2 secret engines (#64288)
* Support generic and KV v1/v2 secret engines.

Fixes #41132
Fixes #50598
Fixes #54462
Fixes #64150

* Update KV v2 compatibility notes/usage docs.

* Add tests for KV v1/v2 and generic secrets engines.

* Add changelog fragment.

* Add KV v2 behavior changes to porting guide.

* Fix pylint blacklisted name warnings.
2019-11-25 06:18:49 +01:00
e74cf5e4b3 Fix: OpenBSD syspatch module bug (#57259)
* Append is not a list

* Adding new example. Renaming reboot var to match other modules

* syspatch: Fixing if statement logic issue to properly compare integer

* Syspatch: Using get_bin_path to find path. Revert to reboot_needed instead of reboot_required.

* syspatch: Fix wording in playbook example
2019-11-24 23:15:15 -05:00
a8fa432096 Add --override-arguments option to win_chocolatey module (#65101)
* Add --override-arguments option to win_chocolatey module

* Fix version and argument type

* Added changelog fragment and tests
2019-11-25 09:51:13 +10:00
63b94fca7e docker_container and docker_network: avoid None errors (#65018)
* Avoid None errors.

* Add changelog.
2019-11-24 07:39:27 -05:00
f4d45ffdff docker_container: change network_host default behavior for Ansible 2.14 (#64635)
* Update network_mode docs.

* Announce default change for 2.14.

* Add changelog fragment.
2019-11-24 05:05:00 +01:00
0b8b5baecd docker_container: add support for --cpus (#64683)
* Add support for --cpus.

* Adjust PR #.

* Add version_added.
2019-11-24 05:04:42 +01:00
ebdb581e63 Fix typos in ansible.cfg comments
PR #65177
2019-11-23 22:15:25 +01:00
a096cd08c5 docker_swarm_service: Sort lists when checking for changes (#63887)
* docker_swarm_service: Sort lists when checking for changes

When two lists are checked for changes in this module, the lists are 
reported changed when the order of the items is different. This PR 
resolves this issue.

* docker_swarm_service: Minor typo fix

* docker_swarm_service: Another minor typo

* docker_swarm_service: Should use sorted(), not sort()

* docker_swarm_service: Sort lists of dictionaries

* docker_swarm_service: Fix style issues in tests

* docker_swarm_service: Updates to integration tests

* docker_swarm_service: Casting string types within lists when comparing

* docker_swarm_service: Special handling of unordered networks with ordered aliases

* docker_swarm_service: Sorting network lists

* docker_swarm_serivce: Better unit test code coverage for lists and networks

* docker_swarm_service: Fixed coding style for sanity tests

* docker_swarm_service: More coding style fixes

* docker_swarm_service: Ignoring test for Python < 3

* docker_swarm_service: Update to version info check for backwards compatibility

* docker_swarm_service: Added change fragment #63887

* docker_swarm_service: Better handling of missing sort key for dictionary of lists

* docker_swarm_service: Preventing sorts from modifying in-place

Co-Authored-By: Felix Fontein <felix@fontein.de>

* docker_swarm_service: Removed spurious import in test

* docker_swarm_service: Preventing sorts from modifying more data in-place

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-23 20:31:35 +01:00
136dc27572 [yarn] Set name_version when version is not specified (#62348)
* Set name_version when version is not specified, fix #55097

This will default to installing the latest version available

* Add changelog fragment

* update changelog
2019-11-23 09:26:35 +01:00
eb3da65886 vmware_rest_client: pass object to get_tags_for_dynamic_obj (#65156)
This patch fix the `vmware_cluster_info` functional-tests.
`get_tags_for_dynamic_obj()` expects an object, not the object ID in a
string.

Without this patch, the `vmware_cluster_info` module fails.
`get_tags_for_object()` raises the following exception:

```
vmware.vapi.exception.CoreException: Expected VapiStruct instance or python dictionary, but received str
```

The patch partially reverts changes introduce in:
35cc26f8c0

See: http://vmware.github.io/vsphere-automation-sdk-rest/6.5/operations/com/vmware/cis/tagging/tag_association.list_attached_tags-operation.html
2019-11-22 21:17:30 -05:00
239213baee vmware_guest: do not use autoselect_datastore in test (#65191)
Disable the use of `autoselect_datastore` until https://github.com/ansible/ansible/issues/58541
is fixed.
2019-11-22 21:17:05 -05:00
c73288ad53 user - compare macOS user properties using same type (#62973)
self._get_user_property returns a string, so when doing a comparison
using this value, cast the second variable to a string so that the
comparison behaves correctly
* Add changelog
* Add to_text import
* Add integration test
2019-11-22 17:05:17 -05:00
d4c4c92c97 Fix issue 64503. Added pool to relocate spec (#64544)
VM relocate to destination host works without pool param when hosts are part of same cluster. but spec.pool is required when hosts are part different clusters.

Closes: #64503
2019-11-22 16:42:41 -05:00
0ab21fd1ec add note re required forward slash on url (#65203) 2019-11-22 15:22:48 -06:00
cba9abcbec elbv2 - print() statement results an task failure, even if the task itself was successfull (#65183) 2019-11-22 10:52:06 -05:00
d3f6943446 Remove postgresql_shared integration test (#65133)
Move test tasks into appropriate integration test
2019-11-22 09:30:10 -05:00
315cc2f3ea VMware: vcenter_folder checks nested parent folder path (#62741)
added possibility to create Subfolder by defining full path below datacenter

Closes: #64442
2019-11-22 09:25:42 -05:00
d05d5cfc39 VMware: add new module vmware_guest_controller (#59615)
Add the `vmware_guest_controller` module.
2019-11-22 09:05:10 -05:00
62c4ff8174 Fix legacy facts keys having redundant underscore (#65167)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-11-22 15:02:18 +05:30
3dc113fd9a Update notes in vmware_guest about SysPrep Windows Guest (#65055) 2019-11-22 14:18:31 +05:30
d7039b6633 VMware: Fix typo in fail_json in vmware_guest_powerstate (#65162)
Fixed typo from "chanaged" to "changed"

Fixes: #65161

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-22 10:27:41 +05:30
dc59880c31 vmware_deploy_ovf: Use correct datastore in multi-datacenter environment
Fixes: #63920 

Need to pass the datacenter to assure we get the correct datastore managed object Id.
2019-11-22 09:52:45 +05:30
41b199a936 Fortinet's new module for fortios_system_global (#64817) 2019-11-22 09:32:48 +05:30
95bd92da04 Add integration tests for aws lightsail (#63770)
* Add integration tests for aws lightsail

* lightsail - use module_defaults instead of aws_connection_info

* lightsail tests - assert instance state on create

* Fix yaml syntax error

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* [lightsail] create keypair as part of the testsuite

* Fix lightsail actions in compute-policy

* Add ability to delete keypair in lightsail_keypair
2019-11-21 16:53:36 -07:00
6e652ae6df Improve consistency of IAM_{role,user,group} behaviour (#64258)
* iam_user: use AnsibleAWSModule.client to fetch connection rather than C&P code

* iam_role: Add deprecation warning so we can switch purge_polices default behaviour from true to false

* iam_user/role/group: Rename 'managed_policy' and 'purge_policy'

Rename from singluar to plural (we accept a *list* of policies), and add aliases for the old values.

* Cleanup documentation

* Changelog
2019-11-21 14:38:44 -07:00
784e507671 module sanity checks: improve alias handling (#59060)
* add_file_common_args is only of interest on top-level.
* Handle undocumented arguments in one place.
* Update ignore.txt
* Add changelog
2019-11-21 15:33:27 -05:00
f3575c5025 docs: add solution to timeout errors to docs (#65140) 2019-11-21 15:05:07 -05:00
b0c8e7926f link from quickstart page to Network Getting Started (#65150) 2019-11-21 11:42:57 -05:00
d52af75c68 Add aws elb multiple host header support (#65021)
* Add support for aws elbv2 multiple host header actions

* Add example of multiple host header

* Add test for multiple host headers

* Add missing quote

* Update test/integration/targets/elb_application_lb/tasks/test_modifying_alb_listeners.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Update test/integration/targets/elb_application_lb/tasks/test_modifying_alb_listeners.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Remove debug statements
2019-11-21 09:42:37 -07:00
d1c58bc942 #59522: adjust messages (#65129)
* Adjust messages.

* Fix one more.
2019-11-21 17:20:38 +01:00
c08f536260 Add support for all_projects in OpenStack inventory module (#55965) 2019-11-21 10:35:44 -05:00
c6301a9fc7 fix utils.color.stringc: enclosure non printable sequences in SOH,STX (#64751)
* ansible.utils.color.stringc: add wrap_nonvisible_chars flag in stringc
* add exaplanation for `wrap_nonvisible_chars` case in utils.stringc
* add changelog entry
2019-11-21 09:41:42 -05:00
1a7823af03 Added missing logout to zabbix_user_info module (#65146) 2019-11-21 18:11:28 +05:30
ede62b8ad4 Update influxdb_write.py (#65117)
Remove duplicated line
2019-11-21 09:48:07 +05:30
f1311d3e98 Rewrite iam_policy using boto3 (#63924)
* reworked iam_policy

* Deprecate policy_document option

* deprecate defaulting skip_duplicates to true

* No longer explicitly catch ParamValidationError.

ParamValidationErrror is already caught by ClientError

* Work with complex policy objects rather than json documents

comparisons can better cope with the special cases (eg True vs "True" )

* Enable check_mode tests and fix related 'changed' bug

* changelog

* doc cleanup based on review
2019-11-20 16:59:02 -07:00
426e37ea92 postgresql_privs - fix sort comparison (#65125)
The result of .sort() is None, not the sorted object. The comparison was comparing the result of the .sort() method and not the sorted values.
2019-11-20 18:26:30 -05:00
6a763d7133 Remove uneeded Python version compatibility checks. (#64076) 2019-11-20 18:08:30 -05:00
da8ec327cc Update plugins/netconf/ce.py to fix a bug(failed to get veriosn information via neocnf). (#65065)
* fix version fail.

* add a changelog fragment.

* Update ce.py

* Rename plugins-netconf-ce-fix.yaml to 65065-plugins-netconf-ce-fix.yaml

* Update ce.py
2019-11-20 22:18:24 +01:00
e16e6fac92 Fixes #28325: Add ansible_ssh_host_key_<algorithm>_public_subtype fact for each public host key algorithm (#28449) 2019-11-20 20:09:45 +00:00
5bd06ee16e rabbitmq_publish SSL certificate implementation (#62036)
* Implementing ability to specify certificates.

* Changelog fragment for rabbitmq_publish certificate checking

* Fixing version_added

* Reducing line size.

* Minor documentation updates.

* Update to add missing space.

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-20 20:09:06 +00:00
60d49c410d Zabbix: new module zabbix_template_info (#64027)
Remove unnecessary module import(LooseVersion)
2019-11-20 20:05:26 +00:00
a7716ae7a9 add new command SetManagerNic in redfish_config module (#64477)
* add new command SetManagerNic in redfish_config module

* use a more explicit/rigorous way to select the EthernetInterface, split port for default nic_addr if root_uri has port, update variable name to lower_case_with_underscores instead of CamelCase

* add missing whitespace around arithmetic operator, fix inline comment should start with '# '
2019-11-20 20:04:24 +00:00
f51f87a986 DeleteUser: do not disable user if already disabled (#64797)
* DeleteUser: do not disable user if already disabled

* add changelog fragment
2019-11-20 20:03:19 +00:00
b36f572256 openssh_keypair: fix idempotence issue (#65017)
* Fix idempotence issue.

* Add changelog.
2019-11-20 20:02:26 +00:00
509b989a9a postgresql_lang: use query parameters with cursor.execute() (#65093)
* postgresql_lang: use query parameters with cursor.execute()

* add changelog fragment
2019-11-20 20:00:07 +00:00
cc5132a8ba add a new module to configure isis on isis-view. (#63720)
* add a new module.

* update docs.

* update docs.

* update again.

* add __future__

* update docs, some args type

* update docs, some args type

* add integration test.

* add unittest.

* update for shippabel.

* update for syntax error.

* Update setup.yaml

* Update setup.yaml

* Update cleanup.yaml

* update for review.

* add notes.
2019-11-20 14:37:13 +00:00
2cf079bc8f Meraki - Remove integration tests which work with HTTP respons… (#64975)
- These are modular level and I'm not catching these anyways
- More appropriate for unit tests, at least for HTTPS
2019-11-20 09:24:12 -05:00
502fc2087e Add support for jumphost setting in junos_scp and junos_package (#64086)
* Add support for jumphost setting in junos_scp and junos_package

* Since junos_scp and junos_package module uses junos-eznc library
  to transfer file and load package respectively to a remote device
  it does not read the jumphost related configuration in netconf
  connection plugin unlike other junos modules which uses the
  Ansible persistent.
* Add `ssh_config` and `ssh_private_key_file` to add support to
  read custom ssh config file and mention ssh private key file
  for junos_scp and junos_package module

* Fix CI issue and update note section
2019-11-20 17:29:41 +05:30
38d6421425 Handle gfid tag when producing ansible facts in gluster_heal_info (#65041)
we ignore lines beginning with / or < which will produce the requires json format.

Fixes: #65095
2019-11-20 14:59:22 +05:30
35cc26f8c0 VMware: Find unique tag using category id (#61082)
If two tags with same name and different category exists, vmware_tag_manager
used to take first found tag.

This commit use combination of tag and category to identify the category.

Fixes: #59379

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-20 14:43:04 +05:30
b1e6667664 fix all modules to be able to get parameter with value false (very important fix) (#65040)
* add import of future and __metaclass__

* fix all modules to be able to get parameter with value false (very importent fix)

* Update ignore.txt
2019-11-20 12:09:40 +05:30
bc92170242 fix module that it reports the correct status of a change (#65061) 2019-11-20 00:43:20 -05:00
4270df1fa2 Fix typo in docs for lvol module(#65092)
Changed activate to active
2019-11-20 10:26:40 +05:30
7092c196ed config manager str type vault source (#65023)
* config manager str type vault source

* Convert vault text to_text earlier and add tests
2019-11-20 12:02:28 +10:00
200fb00310 Windows coverage - output temp files with UTF-8 BOM (#65086)
* Windows coverage - output temp files with UTF-8 BOM
ci_complete ci_coverage

* Remove testing changes to get ready for merge
2019-11-20 11:07:07 +10:00
96a422a6fc win_firewall- Change req check from wmf version to cmdlets presence (#64998) 2019-11-20 11:00:56 +10:00
f5133bec22 Fix up broken Windows test when run with coverage (#65085) 2019-11-20 08:53:38 +10:00
765b054f15 fix net_system domain_search examples (#65080) 2019-11-19 15:21:55 -06:00
e65be0beee Put all files and Path filters under a specific section (#64913)
Many of the filters in the "other useful filters" list manipulate filenames and paths; add a heading and put them together.
2019-11-19 12:30:56 -06:00
ba273c72d8 Fix ansible-test handling of git submodules. (#65027)
* Revert most of PR #61605 commit e218c9814c

This removes the git error handling that converted all git errors into warnings.

* Fix ansible-test handling of git submodules.
2019-11-19 10:19:03 -08:00
3f3d1d8f2d Fix text in import_role module description (#65066)
Docs: Remove unnecessary "it" in description.
2019-11-19 11:37:33 -06:00
9e92668d4f Amazon modules - Yet more minor documentation cleanup (#64930) 2019-11-19 10:10:18 -07:00
7dac93254e Fixes error in regex example (#65047) 2019-11-19 11:30:52 -05:00
1588ad77e2 Update ansible.cfg (#64855)
- clean out old options that are now deprecated
- clean up formatting of comments a bit
- add become plugin examples
2019-11-19 09:36:35 -06:00
b6f0f14dd3 Document diff. (#64888) 2019-11-19 09:46:59 -05:00
09aebf33e4 Add doc to ce for user guide. (#63982) 2019-11-19 09:45:07 -05:00
a6bc43ba47 vmware_guest: Revert custom value customization in guest (#65031)
Due to confusion between 'Custom Attributes' and 'Advanced options',
this change got in devel. Revert to original behavior i.e. customizing
custom values using vmware_guest is done in this PR.

Fixes: #64291

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-19 18:49:02 +05:30
9ef266778f Add missing version_added in checkpoint documentation (#65048)
Domain is newly added in 2.10 release, specify this in the
documentation section in Checkpoint httpapi connection plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-19 16:55:19 +05:30
4e6fa59ec1 gitlab modules: unify authentication method (#64989)
* gitlab modules: unify authentication method
* gitlab module utils: remove useless import
* gitlab module utils: add documentation
* gitlab module utils: use distutil to compare version
* gitlab modules: sanity
* gitlab modules: remove useless import
* gitlab module utils: add missing import
* add changelog
2019-11-19 15:30:34 +05:30
bc479fcafc Fix py2/py3 compability issue for httpapi plugin fortios (#64982) 2019-11-19 14:51:56 +05:30
3252665a94 nxos_vlans: fix rmb behaviors and tests (#63650)
* nxos_vlans: fix rmb behaviors and tests

* whitespace fixes

* whitespace fixes 2

* review comments addressed

* TBD for legacy support

* additional tests to hit code coverage misses

* whitespace
2019-11-19 14:24:52 +05:30
067e96b152 VMware: Fix wait for customization timeout issue (#64493) 2019-11-19 08:03:42 +05:30
f1bf15bf63 cloudformation_info Move sample outputs from EXAMPLES to RETURN section (#64298) 2019-11-18 16:05:46 -07:00
8a5adcd8e1 Improve examples on parameters use with argv (#60781)
* Add example showing that when using the `argv` syntax for command module instead of the string one, we can directly provide other parameters in the "command" block, rather than using an "args" block.
2019-11-18 16:29:03 -06:00
a4b36b2e6a Update cache plugin documentation (#63635)
* Update cache plugin documentation since all cache plugins shipped with Ansible can be used for caching inventory since 2.8

* Update docs/docsite/rst/plugins/cache.rst

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-11-18 16:00:26 -06:00
7d4800deb1 Feature: iam_role tags (#63944)
* iam_role tags support

* Make sure we don't Camel -> Snake tags in our return values

* Minor documentation tweaks

* Add tagging tests

* Make sure we return the state of tags once we updated them

* Update lib/ansible/modules/cloud/amazon/iam_role.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Move boto3/botocore before we start making changes
2019-11-18 13:41:52 -07:00
6b2b876d43 Make Docker and Podman play nice (#65009)
podman 1.4 now installs docker man pages. Add handler to remove docker packages to avoid test failure due to this conflict.

Adjust inventory_docker_swarm integration test
Add conditional to cleanup handlers to allow use of the setup_docker role without removing packages at the end of the play. The inventory_docker_swarm integration tests does its own cleanup.
2019-11-18 15:08:58 -05:00
163904fe37 Fix timezone integration test for Fedora 31 (#65013) 2019-11-18 15:06:38 -05:00
d5fd588b34 distribution: ignore plesk-release file while parsing (#64665)
/etc/plesk-release file is now ignored while parsing distribution
release.

Fixes: #64101

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-18 15:05:23 -05:00
2749090bc6 fix collection broken links (#65010) 2019-11-18 13:50:23 -06:00
1e59017d27 renamed module tls client auth params to avoid overlaping with fetch_url (#59522)
* renamed module tls client auth parameters to avoid overlaping with ansible fetch_url

* added version_added info for params

* Updated version_added

Updated version_added info from 2.9 to 2.10

* Update pulp_repo.py

removed version_added for renamed params

* Apply suggestions from code review

added ca_cert alias and 'version_added'

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Apply suggestions from code review

added old behavior for client_cert and client_key which will deprecate in 2.14

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update pulp_repo.py

fix for linting error ansibot is complaining

* added changelog fragment for 59522

* Apply suggestions from code review

more informative depreciation warning and changelog fragment

Co-Authored-By: Felix Fontein <felix@fontein.de>

* added mention for changes in client_key and client_cert behavior

* fixed too long line (linting)

* deprecated ca_cert alias to have consistent module params in Ansible 2.14

* fixed indentation for deprecation warning

* changed deprecated alias handling to argument_spec

* moved deprecated_aliases insied argument dict, thanks tremble

* suggestions from felixfontein

Move doc info about client_cert and client_key into its own paragraph

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-18 20:41:40 +01:00
1d0a832692 Fix link to Roles (#64992) 2019-11-18 12:05:18 -05:00
f198036d7f Remove duplicated and broken link to Roles (#64991) 2019-11-18 12:04:38 -05:00
14897a3a0c Fix typo in grafana_datasource docs (#65000) 2019-11-18 12:02:08 -05:00
fcd29406a2 Fix postgresql_lang integration test for CentOS 8 (#64872)
* Only search inside the role for files to include
When a role is called as a dependency, both roles are searched. This can cause the incorrect file to be included if it is picked up from the parent role.
2019-11-18 10:45:22 -05:00
1df62f129a Collections versions (#64912) 2019-11-18 09:31:29 -05:00
a815fdf8bb Update Route53 IAM policy so the Route53 tests run (#64886) 2019-11-18 08:48:58 -05:00
c9d3c9e233 hcloud: inventory: missing compose variables (#64559) 2019-11-18 13:54:36 +01:00
13a8dbfd5c Fix Grafana lookup auth header for py2/3 compatibility (#50816) 2019-11-18 10:21:58 +05:30
a3c0277259 Move grafana modules to own subdir (#64657) 2019-11-18 09:56:49 +05:30
096c3ffa80 Correct win_dns_client test option name (#64967) 2019-11-18 07:39:25 +10:00
0efe5a666d Add full IPv6 support to win_dns_client - Fixes #55962 (#57577)
* Add full IPv6 support to win_dns_client - Fixes #55962

* Fix missing cast

* Add type to win_dns_client.py

* Remove version_added again, to hopefully make ansibot happy. Even though it was added as a response to the bot...

* Fix $params undefined error, that was introduced by fixing the "global variable" linting issue

* Fix casting error

* Fix inverted logic

* Fix rebase error

* Fix assignment to readonly variable

* Fix "reset IPv4 DNS back to DHCP adapter_name"

* Fix legacy windows server support (2008/2008R2)

* Fix 2k8

* Remove unecessary pslint ignore

* Added IPv6 tests, changelog fragment and further docs
2019-11-18 07:30:06 +10:00
480b106d65 become - stop using play context in more places (#62373)
* become - stop using play context in more places - ci_complete

* Fix up review points
2019-11-18 05:32:56 +10:00
a385ad321b Use newer version of podman on RHEL (#64934)
- Use same podman version for RHEL 7 and 8
- Pin to version 1.4
2019-11-17 12:45:10 -05:00
b04940d256 VMware: Re-introduce backing_disk_mode in vmware_guest_disk_in… (#63244)
This info about backing_disk_mode was renamed to backing_diskmode,
to keep backward compatability re-introducing backing_disk_mode along
with backing_diskmode info.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-16 21:34:13 +05:30
45527716fd Add module ldap_attrs; deprecate ldap_attr (#62701)
* Add ldap_attrs module

* Fix codesyle error

* Apply deprecation rules

* Add support for X-ORDERED extension in ldap_attrs

The 'X-ORDERED' LDAP extension allows definition of ordered LDAP object
attributes. This extension is used in OpenLDAP "cn=config" database to
support ordered configuration options.

Specification: https://tools.ietf.org/html/draft-chu-ldap-xordered-00

* Update ldap_attr deprecation notice

* Documentation improvements based on suggestions

* Remove redundant dots from documentation

* Correct 'insertations' to 'insertions'

* Remove insecure 'params' option

* Fix sanity ignore errors

* Improve module documentation

* Change example value from string to list

* Fix support for "" values
2019-11-16 15:53:35 +01:00
034df49c56 VMware: New module vmware_host_dns (#64458)
* Restore module vmware_dns_config
* Remove domainname and change_hostname_to
* Changed version_added from 2.10 to '2.10'
* Add setup_attach_host: true to test case
* Add 'vcsim is not defined' block to integration tests
* Change 'result' to 'dns_config_result'
* Bugfix: Changing some static configurations while keeping others can crash the module
* Implement changing DNS config from DHCP to static on a cluster
* Update documentation for vmware_host_dns
* vmware_host_dns integration tests: Always revert to original DNS configuration, even if a test fails
* Deprecate vmware_dns_config
2019-11-16 11:25:06 +05:30
889953a43e add notes for 4 ce moudules docs. (#64929)
* add notes.

* duplication of key "notes" in mapping
2019-11-15 23:39:05 -05:00
8ea9d0c06a Doc notes 5 (#64928)
* addd

* all  update

* add/update notes.

* add/updates notes.

* new version 2.10 can not be backported
2019-11-15 23:08:35 -05:00
2ccdf29b5b Doc notes 4 (#64927)
* addd

* all  update

* add/update notes.

* revert and exclubde new in 2.10
2019-11-15 22:57:04 -05:00
cf4882e0c0 Fix argument name in example of documentation (#64891)
##### SUMMARY
The second example of the documentation uses an argument "hostname" that does not exist in this module.
It should be replaced by argument "name"


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-11-16 08:55:13 +05:30
8301ad47c3 VMware: new module vmware_host_auto_start (#64605)
Fixes: #63905

* Add return parameters to return after module execution https://github.com/ansible/ansible/pull/64605#discussion_r344430717
* Add moid and use_instance_uuid parameters https://github.com/ansible/ansible/pull/64605#discussion_r344431003
* Add reset playbook for test case
* Delete HAS_PYVMOMI variable https://github.com/ansible/ansible/pull/64605#discussion_r344430877
* Fix because the default value of stop_action was wrong
* Fix multiple sanity test error for document related
* Fix remove unnecessary line break
2019-11-16 08:46:38 +05:30
9a8d0cf006 Revert "Doc notes 5 (#64350)" (#64921)
This reverts commit 1d40d429a0.
2019-11-15 21:21:06 -05:00
6dff4f43d3 Revert "Doc notes 4 (#64349)" (#64922)
This reverts commit 703f7a149a.
2019-11-15 21:08:16 -05:00
4291f09a68 Fix lookup_passwordstore integration test for CentOS 8 (#64869)
pass is no longer packaged in EPEL
https://lists.zx2c4.com/pipermail/password-store/2019-July/003689.html
2019-11-15 17:37:43 -05:00
f2e605c856 Fix iso_extract tests for CentOS 8 (#64861)
- use setup_epel role rather than task which contains correct URL now since it has changed for EL8
- add conditional to setup_epel to prevent attempted installation on non-RHEL distros
2019-11-15 17:37:13 -05:00
dd8a3ebb72 Fix paramiko_ssh test (#64857) 2019-11-15 17:08:26 -05:00
5d2a3ecbc4 Fix setup_rpm integration tests for CentOS 8 (#64862) 2019-11-15 17:07:48 -05:00
5e3b6c84c7 Fix group integration test for CentOS 8 (#64858) 2019-11-15 17:07:02 -05:00
3902c6dd9d Fix MariaDB integration tests for CentOS 8 (#64859)
* Fix setup_mariadb for CentOS 8
Switch to using systemd for multiple instances on CentOS 7 and 8
2019-11-15 17:06:27 -05:00
05a7ce798d Fix yum_repository tests for CentOS 8 (#64863)
Refactor tests to run the same tasks with CentOS and Fedora using different variables.
2019-11-15 17:05:23 -05:00
477fa63f68 Fix setup_mysql_db for CentOS 8 (#64864) 2019-11-15 17:04:35 -05:00
16f070f318 Fix mariadb_replication tests for CentOS 8 (#64865) 2019-11-15 17:03:59 -05:00
082b1b6cca Fix filesystem integration test for CentOS 8 (#64866) 2019-11-15 17:03:27 -05:00
41f301fe1b Fix setup_mysql8 tests for CentOS 8 (#64868)
# Conflicts:
#	test/integration/targets/firewalld/tasks/main.yml
2019-11-15 17:02:20 -05:00
73a2ee7318 Fix mysql_replication integration test for CentOS 8 (#64870) 2019-11-15 17:01:23 -05:00
f8c741894a Fix setup_postgresql integration test for CestOS 8 (#64871) 2019-11-15 17:00:27 -05:00
79a38c8a3a Fix firewalld integration tests for CentOS 8 (#64873) 2019-11-15 16:59:39 -05:00
a01376a493 update configuring ansible-galaxy client (#64796)
* update configuring ansible-galaxy client, deduplicate, clarify tokens, AH procedures, etc.
2019-11-15 09:49:51 -06:00
64595a7d6a module_defaults: add tree missing vmware modules (#64877)
The following modules a new, and were not yet in `module_defaults.yml`:

- vmware_guest_register_operation
- vmware_guest_serial_port
- vmware_guest_tools_info
2019-11-15 17:10:11 +05:30
f45fdc7c9b postgresql_subscription: fix the module can return incorect changed value when owner is passed (#64885) 2019-11-15 17:04:58 +05:30
96fc1a1b80 Add support for multiple manager attributes configuration (#60201)
* Add support for multiple manager attributes configuration

* Updated version_added to 2.10

* Added support for modifying LC and system attributes

* Added support for LC and system attributes

* Pylint fixes

* Add support for multiple manager attributes

* Add support for multiple manager attributes

* Add support for multiple manager attributes
2019-11-15 10:53:36 +00:00
069c7959da Add timeout to jenkins_script csrf requests (#62850) 2019-11-15 10:49:01 +00:00
864a597a3e Improved message for unarchive. (#64594)
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
2019-11-15 12:52:51 +05:30
01e4e1bb42 postgres.py: add query_params (#64661)
* postgres.py: add query_params

* postgres.py: add query_params, add changelog
2019-11-15 07:07:56 +00:00
8ff6e4c68e win_iis_webapplication: add authentication parameters (#56033)
* add connect_as, username, password parameters
add tests

* fixed reference to undefined variable.
added version added to new options.

* add changelog fragment

* fix line endings

* use ansible facts to determine os version
remove unused iis version check
test checksum of iis configuration after backup

* correct assertion

* added more cleanup tasks.

* version added is now 2.10

* skip server 2008 r2 for now

* run tests on server 2012 and higher
2019-11-15 16:04:19 +10:00
40071e5db3 win_disk_facts: Adds Win32_DiskDrive object to facts (#51595)
* Adds win32_disk_drive object to win_disk_facts

* Names class parameter for Get-CimInstance as requested in the devdocs

* Maps whole class and adds docs

* Improve matching of disks when UniqueID is different format

* Improve logic for PNPDeviceID mapping

* Adds test for win32_disk_drive
2019-11-15 15:45:18 +10:00
762fcf78b9 win_pester - Align dir scanning with Pester's defaults (#64880)
* win_pester - Align dir scanning with Pester's defaults

Co-authored-by: Coby Caldwell <cobycaldwell@gmail.com>

* Fix sanity issues
2019-11-15 13:53:30 +10:00
521d6465f6 win_chocolatey: Fix error when choco.exe not found (#53115)
* win_chocolatey: Fix error when choco.exe not found

* Slight tweak to check and added changelog fragment

* Removed ignore rule that's no longer needed
2019-11-15 12:46:36 +10:00
cd39e6ec6e win_domain_user: add retry logic for null user principal group (#54334)
* win_domain_user: add retry logic for null user principal group

* win_domain_user.ps1: Fix "user without group" case use

* Added changelog fragment

* Fix up missing dollar sign
2019-11-15 11:54:37 +10:00
bf8fe221bf Modified setup.ps1 in order to show Windows Installation type (#41002)
* Modified setup.ps1 in order to show Windows Installation type

* Fix after pull request comment

* Added changelog fragment
2019-11-15 11:19:01 +10:00
4f51b7d323 Remove ansible-test --tox delegation option.
Use the --venv option instead.

This option was only available when running from source to test the ansible/ansible repository.

This will have no effect on testing collections or running from an installed version of Ansible.

Also update docs to reference the --venv option instead of the --tox option.
2019-11-14 17:18:00 -08:00
0aa59ce9ab vmware/test: use better name for datastores
In the VMware tests, we call the datastores `ds1` and `ds2`. The first
one is read-only, the second is read-write and can be used to deploy
VMs. The naming convention was not clear enough and source of a lot
confusion and mistake.

We now have two better names:

- ro_datastore, which is ... read-only
- rw_datastore, the one that we can use to deploy new VM.
2019-11-14 16:55:05 -05:00
161e0be89b Fix access variable name programmatically faq docs (#64041)
* Add an example of replacing dashes with underscores in interface names for IPv4
2019-11-14 15:38:40 -06:00
a6f45713fc Add default value to 0 for disk in nova_flavor module (#64749)
* Add default value to 0 for disk in nova_flavor module

* Apply suggestions from code review

Add type int for disk size

Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-11-14 20:50:16 +00:00
551b17b8a2 ec2_vpc_net_info: integration tests (#62649)
* ec2_vpc_net: (integration tests) migrate to using module_defaults

* ec2_vpc_net: (integration tests) use a private subnet for the tests

* ec2_vpc_net_info: Add integration tests

* ec2_vpc_net_info: add cidr_block_association_set to documentation

* Update AWS hacking test policy to allow VPC CIDR disassociation

* Update test/integration/targets/ec2_vpc_net/tasks/main.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Store vpc2 ID to make it clearer which VPC we're changing

* Be more consistent with our quoting

* Explicitly test that the VPC IDs haven't changed
2019-11-14 13:36:42 -07:00
db3994cb03 Default to python3 on Debian 10 (#63097) 2019-11-14 13:52:13 -06:00
e9feea2270 VMware: new module vmware_guest_serial_port (#63126)
The ask was to add an option in the vmware_guest itself. Upon inspection, a serial port can
be created in multiple ways and so can be a module in itself. Therefore, created a new module
called vmware_serial_port.

Fixes: #54956
2019-11-14 14:16:30 -05:00
9b0cdad4d4 Add a random component to state machine name in aws_step_functions_st… (#64476)
* Add a random component to state machine name in aws_step_functions_state_machine testsuite

* Pick a random number from a bigger set to avoid conflicts between parallel runs

Co-Authored-By: Matt Clay <matt@mystile.com>
2019-11-14 08:37:55 -08:00
81b334bcaf Close subprocess stdout and stderr in the ssh connection plugin
Eliminate `ResourceWarning: unclosed file` by closing all
file handles of each subprocess used by the SSH connection
plugin to execute commands.

This change prevents Ansible from accumulating "forgotten"
open file handles.

PR #64785 by Julien Palard
Fixes #64768
2019-11-14 17:35:30 +01:00
67fd17bee4 Update RDS snapshot info to use DBClusterIdentifier (#64253) 2019-11-14 09:02:42 -07:00
d6a51807cd Fix kinesis_stream wait loop pause. (#64283) 2019-11-14 08:53:01 -07:00
fbdd295cef Adjust conditional for disabling alert email (#63951)
* Adjust conditional for disabling alert email

Conditional was improperly disabling existing alert email when it was found enabled.  The expectation is that it should only disable if module.param['enabled'] was set to false.

* Adjusted disable logic

Added back in the logic of only disabling the alert email if it is module.params['enabled'] is false AND current value of enabled is true on the array
2019-11-14 10:44:55 -05:00
5c0b2c151c Fix ansible_failed_{task,result} undefined in rescue (#64831)
This is a fix for a regression introduced by Perfy. Since then we mainly
operate on host.name instead of the Host object. In a call to
set_nonpersistent_facts where we set ansible_failed_task and
ansible_failed_result variables we were still passing the object which
led to those vars being undefined.

Fixes #64789
2019-11-14 15:50:54 +01:00
f17a55a181 Add advice how to prevent jinja2 warning (#60594)
* Add advice how to prevent jinja2 warning

##### SUMMARY
This addition helps users to demonstrate how to prevent `[WARNING]: when statements should not include jinja2 templating delimiters`.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Update playbooks_tests.rst

* Update playbooks_tests.rst

Refer to the advised FAQ about when to use `{{ }}`.
2019-11-14 14:36:05 +00:00
eac7fa1860 gitlab_user: Remove optional parameters while state is absent (#64832)
While deleting gitlab user, several parameters such as email, name,
password are not required. This fix removes this requirement from the
module.

Fixes: #61921

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-14 17:21:14 +05:30
9ee601288c Fix postgres_user not commiting changes when groups is set (#64807)
resolves #64806
2019-11-14 15:09:45 +05:30
a75a79b84c hostname - Add Manjaro Linux distribution (#64810)
* Add Manjaro Linux distribution
2019-11-14 14:31:21 +05:30
e0373a73a8 VMware: Simplifying get_vm() in module_utils.vmware (#62217) 2019-11-14 10:40:37 +05:30
46a6c28bb0 use ~/.one/one_auth as default of ONE_AUTH file location (#64535)
* better excpetion handling when one_auth file is missing
* use Exception instead of BaseException
2019-11-14 09:37:35 +05:30
04b8f75ffa win_domain_computer module: Fix idempotence when name != sam_account_name (#56967)
* win_domain_computer module: Minor documentation error

* Fix idempotence when name != samaccountname

* Added changelog

* Added unsupported alias for CI check
2019-11-14 12:59:05 +10:00
f6ac4361e7 win_firewall_rule - support ICMP types and codes (#60361)
* win_firewall_rule - support ICMP types and codes

* Update main.yml

* Add more examples and change type to list
2019-11-14 11:32:01 +10:00
91d0ad9a4c Update win_firewall_rule.py to include ICMP echo (ping) example (#55013)
* Update win_firewall_rule.py

<!--- Your description here -->
Added example of enabling ICMP protocol, as ping is commonly used for troubleshooting in automation scenarios.  Equivalent netsh command is: 
netsh advfirewall firewall add rule name='ICMP Allow incoming V4 echo request' protocol=icmpv4:8,any dir=in action=allow

+label: docsite_pr

* Remove yaml-breaking space

Removed extraneous space that caused validation to fail.

* Remove more extraneous whitespace
2019-11-14 10:17:45 +10:00
23a751323b allow using --check on win_iis_webapppool module (#50528)
* allow using --check on win_iis_webapppool module

* Added changelog and slight logic tweak

* Fix typo in changelog fragment
2019-11-14 08:52:34 +10:00
3a9650df98 Merging conflicts and updating PR
Signed-off-by: Anusha Hegde
2019-11-13 16:12:52 -05:00
4e7c0b3e21 Fixed review comments
Signed-off-by: Anusha Hegde
2019-11-13 16:12:52 -05:00
907c66c082 Resolved merge conflicts 2019-11-13 16:12:52 -05:00
80bf24b17c vmware_guest_disk/test: use less disk space
Reduce the amount of space that is used on the datastore during the
test. This allow use to use lighter storage environment during the test.
2019-11-13 16:00:20 -05:00
b5f484dcc3 ec2_eip Don't throw an exception when re-releasing an EIP (idempotency) (#62332)
* ec2_eip: (integration tests) move to using module_defaults

* ec2_eip: (integration tests) expand integration tests

Also clean up a little
- Delete EIPs when we finish testing them (reduce the chance of hitting limits)
- Rejig deletion so that it works when runs fail
- Add tests for ec2_eip_info

* ec2_eip: Minor doc tweaks

* ec2_eip: Don't throw an exception when we try to disassociate an already disassociated EIP

* ec2_eip: Add missing IAM policy (manage IGWs)

* ec2_eip: (integration tests) Use the VPC as a crude lock to avoid running parallel tests

We test that untagged EIPs come and go as we expect, if multiple tests are
running in parallel this confuses things

* Fix ec2_eip association
2019-11-13 13:27:35 -07:00
f8f7662850 Add the ability to ignore files and collection build (#64688) 2019-11-14 05:02:58 +10:00
bf19060683 ipaddr: add an option to return peer of a point-to-point link (#59144)
* ipaddr: add an option to return peer of a point-to-point link

Signed-off-by: Vincent Bernat <vincent@bernat.ch>

* ipaddr: extend "peer" to also work with /30
2019-11-13 13:47:05 -05:00
bb72b8f1d9 Syntax fix guide_gce.rst (#64779)
Fix syntax for create a GCP instance example playbook. Fix task indentation.
2019-11-13 11:39:20 -06:00
a2047cfa2d update documentation example (#64786)
missing k in workflow in an example for the tower_workflow_template module
2019-11-13 11:29:46 -06:00
844b5d4673 docs: fix gcs example to work with ansible 2+ (#64778)
switched directive sudo to become
2019-11-13 11:26:57 -06:00
a7f90df0e9 Document match/search tests (#64775)
* clarify `search` vs `match` tests

* string test docs: fix rst formatting
2019-11-13 11:14:10 -06:00
93d1a57d9a vmware_guest: fix the name of the test VMs
The test VM names must be deterministic, this way, the teardown playbook
can clean up the resources after the test execution.

See: https://docs.ansible.com/ansible/latest/dev_guide/platforms/vmware_guidelines.html#vm-names-should-be-predictable
2019-11-13 11:52:57 -05:00
d3b7828118 [FIX] graceful is not an immutable attribute (#64397) 2019-11-13 11:22:34 -05:00
143bafec9a eos_lacp_interfaces : Fix to - lacp port-priority not set when… (#64530)
* Fix bug 64453
2019-11-13 09:31:21 -05:00
83927c3437 Update openssl_certificate.py (#64772)
Changed 'generate' to 'generating'
2019-11-13 18:25:47 +05:30
743b6eb5b0 Fortinet's new module for fortios_vpn_ipsec_phase2_interface (#64767) 2019-11-13 16:27:20 +05:30
d0f8e8896f vmware_tools handle connection issues (#57661)
* Catch vmodl.fault.SystemError exception.

* Add exceptions for connection issues.

* Fix self._si not defined exception (L353), when trying to close a non existing connection.

* Fix vmware_tools connection reset

* Also catch InvalidGuestLogin exception, as it get's also thrown when trying to logging in too early on startup...
2019-11-13 18:27:15 +10:00
bd9a0b6700 Improve handling of "restarted" state for win_iis_website module (#63829)
* Improve handling of "restarted" state for win_iis_website module

* Added changelog fragment
2019-11-13 10:24:25 +10:00
95d613f3ab win_acl no longer needs SeSecurityPrivilege (#57804)
* win_acl no longer needs SeSecurityPrivilege
Set-ACL raises missing SeSecurityPrivilege error when the inheritance
from the parent directory is disabled.

* fixes test sanity

* registry rights can only be modified with Set-ACL

* add changelog
2019-11-13 09:54:57 +10:00
e77426dad3 Corrected Get-adcomputer (#63093)
* Corrected Get-adcomputer

Corrected Get-adcomputer on "Remove-ConstructedState" and "Set-ConstructedState" functions.
resolved error: Unable to contact the server. This may be because this server does not exist, it is currently down, or it does not have the Active Directory Web Services running.

* Update lib/ansible/modules/windows/win_domain_computer.ps1

Co-Authored-By: Daniel-Sanchez-Fabregas <33929811+Daniel-Sanchez-Fabregas@users.noreply.github.com>

* Update win_domain_computer.ps1

changed
"-credential $credential" to "@extra_args" (Line 115 and 150)
corrected exception message (Line 122)

* Added changelog fragment, minor code tweak
2019-11-13 09:13:44 +10:00
e74d397c01 setup.ps1 - parity with linux regarding missing local facts path (#58887)
* setup.ps1 - parity with linux regarding missing local facts path

* add warning

* Update setup.ps1-parity-with-linux-regarding-missing-local-facts-path.yml
2019-11-13 09:05:16 +10:00
d2e1aeeb67 win_domain_user: Make Identification of the user to work with more robust (#61594)
* Ensure we work on only one user.

After the initial get/create use the GUID of the found/created user to
ensure we will not start to work with  a different user. If we create a
user or modify it's attributes an he is not identified with the name
parameter afterwards this module fails in rather unpredictable ways.

This addressed #45298

* Use splatting create_args for creating user.

This prepars this for adding more optional create arguments without 
nesting of condictions.

* Set the UserPrincipalName and SamAccountName on create.

Set the UserPrincipalName and SamAccountName on the create operation if 
upn is given to ensure the User is created with a contollable 
SamAccountName.

* Rename $username to $name.

$username is missleading as its not the SamAccountName.

* Add a identity parameter to win_domain_user

This gives the user full controll over how the user is identified in the 
AD.

* Add version_added information for new parameter and fix yaml syntax.

* Added changelog fragment
2019-11-13 08:42:44 +10:00
fadf7a426f re-enable zabbix_host integration tests and add cleanup handlers 2019-11-12 09:54:51 -08:00
47bf5deb54 command, script & shell: mention 'cmd' parameter (#62778)
'cmd' parameter is supported since 2b3c5aa41e (v2.0.0-1)
2019-11-12 09:40:09 -06:00
68428efc39 Remove temp directory created by wait_for_connection (#64592)
wait_for_connection creates AnsiballZ_ping.py in temp directory,
which remains on remote machine even after playbook run.

Fixes: #62407

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-12 10:07:33 -05:00
fed0496005 Fix eos_facts over local eapi (#64570)
* Fix eos_facts over local eapi

* Much better feedback when querying resources over local

* No need for that anymore

* Update comment

* Mkae sure facts are tested on local

resource modules might break this otherwise

* This test was not checking anything

* Pass over nxos_facts as well
2019-11-12 09:29:44 -05:00
9dc94b32d2 added missing atexit logout for zabbix_host module (#63785) 2019-11-12 08:28:08 -05:00
94e98d5369 remove toshio as release manager (boohoo) (#64685) 2019-11-12 13:14:09 +00:00
47f9873eab VMware: Handle slash in network name in vmware_guest module (#64494)
Encode slash in network name to work with vSphere API.

Fixes: #64399

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-12 17:13:57 +05:30
575116a584 doc: Handle exception in parsing parameter description (#60933)
Fixes: #60587

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-12 16:48:46 +05:30
4bf79de8a6 Add output options for win_pester (#63583)
* add output options for win_pester

* fix typo

* correct variable name
2019-11-12 16:13:52 +10:00
c0331053db Add encoding and codepage params to win_command/win_shell (#54896) (#54966)
* Add output_encoding_override params to win_command/win_shell (#54896)

This enhancement enables Ansible to parse the output of
localized commands that ignore the prompt code page.

* Added changelog and minor nits
2019-11-12 15:58:57 +10:00
c11d73575b Fixes azure_rm_snapshot (#64542) (#64547)
* feature enhancement: make a snapshot from an existing managed disk.

* remove default creation option in argu_spec of azure_rm_snapshot

* fix pep8 related issue

* fixing broken integration test
2019-11-12 13:05:15 +08:00
ca42cb2868 Make the DNS service optional when installing Active Directory (#63440)
* Added install_dns option to the win_domain module.

* Added install_dns option to the win_domain_controller module.

* Updated version_added to devel branch version 2.10.

* Updates for ansible-test errors.

* Minor nits to docs
2019-11-12 14:53:51 +10:00
8b13836b1f change $partition variable name to $ansible_partition (#63968)
* change $partition variable name to $ansbile_partition

* Added changelog fragment
2019-11-12 14:44:18 +10:00
8c4f59ebd9 win_package - Set raw for argument type (#64690) 2019-11-12 14:39:48 +10:00
9c5a1ebba5 Add Local Security Policy update example (#60897)
* Add Local Security Policy update example

##### SUMMARY
This real world example will be useful, but perhaps there is a better section?


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Move new example and add not to username
2019-11-12 14:33:56 +10:00
b93d92ef9a Set alter_sys=True instead of False to address backwards incompat (#64670)
* Set alter_sys=True instead of False to address backwards incompat

* ci_complete

* Add integration test

* ci_complete

* sanity

* ci_complete

* Changelog fragment

* Update import test and validate-modules to match
2019-11-11 16:47:35 -06:00
c1493e5267 really clarify environment (#62531)
Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-11-11 16:04:31 -05:00
8b83f9c14e archive module documentation is misleading (#62755) 2019-11-11 15:46:03 -05:00
a5dc11cdd1 Changed with_items -> loop (#62995) 2019-11-11 15:09:52 -05:00
4083d02989 Buypass now has a ACME v2 production endpoint. (#64649) 2019-11-11 14:48:48 -05:00
ee50c3b3cf Bug fixes for GCP modules (#64587) 2019-11-11 14:08:19 -05:00
b1849d1a3e New Module: gcp_serviceusage_service (#64588) 2019-11-11 14:08:09 -05:00
79e2273f96 New Module: gcp_serviceusage_service_info (#64589) 2019-11-11 14:08:00 -05:00
f145057c5c - add nextToken support (#64598)
* - add nextToken support

* - add changelog fragment

* - use boto3 paginator for describe_log_groups
2019-11-11 13:27:09 -05:00
0f491c0289 Replace TestCase.assertEquals with TestCase.assertEqual. 2019-11-11 10:24:21 -08:00
a7ae0da6a4 Sort test/sanity/ignore.txt (#64672) 2019-11-11 11:02:49 -06:00
abf3319666 Refine default 401 handling (#64619) 2019-11-11 08:09:01 -05:00
0d851dda59 VMware: add new module vmware_guest_tools_info (#62860) 2019-11-11 12:39:25 +05:30
8c1a42ef0a Remove kustodian from postgres and opennebula (#64647)
I currently don't have time to follow the changes in Postgresql and OpenNebula modules.
2019-11-11 11:00:49 +05:30
00193f27eb nxos_lacp: updated tests to handle platforms not supporting lacp system mac command (#64074)
* Updated nxos_lacp tests to handle platforms not supporting lacp system mac command

* nxos_lacp: addressing comments

* nxos_lacp: Updating image tag search to include more tags
2019-11-10 10:32:07 +05:30
964da2f442 nxos_lacp_interfaces: Updating the tests to handle platforms that don't support - lacp mode delay (#64123)
* nxos_lacp_interfaces: Updating the tests to handle platforms that dont support - lacp mode delay

* nxos_lacp_interfaces: Updating search string to include all 9500 series switches

* nxos_lacp_interfaces: Adding a comment about chassis_type
2019-11-10 10:00:13 +05:30
d5e30be686 nxos_igmp_interface: fix regression test failure (#64286) 2019-11-10 09:56:10 +05:30
2be04e2bd6 nxos_overlay_global: Removing provider and correcting relative references (#64454) 2019-11-10 09:47:34 +05:30
574bd32db2 docker_swarm_service: Allow source to be omitted for tmpfs mounts (#64637)
* Allow source to be omitted for tmpfs mounts.

* Add changelog.
2019-11-09 21:01:56 +01:00
dd5415017e docker_login: allow to function with credential helpers (#63158)
* Allow docker_login to function with credential helpers.

* Improve various details and update docs.
2019-11-09 11:25:53 +01:00
4a995f26a3 Update aruba modules to handle prompt and syntax changes (#54261)
* Update prompt matching to handle changes introduced in arubaos 8.x

* Update aruba modules to support command changes on arubaos 8.x
2019-11-09 15:03:01 +05:30
5d30180f6b VMware: Implement updates for dvPG in vmware_dvs_portgroup (#62537)
* VMware: Implement updates / changes for dvPG in vmware_dvs_portgroup
* Remove unnecessary else
* Add more integration tests
* Improve create_vlan_list() helper function
2019-11-09 09:35:01 +05:30
6e19e341b0 one_vm: Fix creating VM also for template_id=0 (#63579) 2019-11-08 17:59:33 -05:00
7ea1db89d3 Documents storage of task files (#62345) 2019-11-08 16:23:33 -05:00
7a26aff357 Fix cache example (#64600) 2019-11-08 16:16:45 -05:00
d9db2c3354 minor typos and style changes (#64386) 2019-11-08 16:13:13 -05:00
901eaf2ecc Add warning about winrm on MacoS (#64472) 2019-11-08 16:12:26 -05:00
74b0760cb4 Add note about kerberos dependency versions (#64478) 2019-11-08 16:11:18 -05:00
6f197880ce Update azure_rm_azurefirewall relate document (#64488) 2019-11-08 16:10:06 -05:00
beaf9c25d8 Update azure_rm_batchaccount's document (#64490) 2019-11-08 16:09:08 -05:00
1e4230c0e7 Format azure_rm_gallery* relate document (#64541) 2019-11-08 16:08:10 -05:00
0573e51482 Remove deprecated kubernetes and oc module "indirection" in v2.9 changelog doc (#64572)
+label: docsite_pr
2019-11-08 16:07:42 -05:00
cc2e48a40e Format azure_rm_snapshot document (#64579) 2019-11-08 16:05:25 -05:00
0b8b84c16f Format azure_rm_keyvault_key_info module's document (#64580) 2019-11-08 16:04:06 -05:00
6a662b0ed0 clarify acceptable file types in collection docs (#64618)
* clarify acceptable file times in collection docs

* implement feedback
2019-11-08 14:31:14 -06:00
4e7779030d route53_info max_items and next_marker should be a str (#64617)
* route53_info  max_items and next_marker should be a str

Type was changed in #64358, however boto3 takes a str for this option
Add some basic tests for route53_info.
Fixes: #64534
2019-11-08 13:06:30 -07:00
84bffff96a Fixed tiny typo in interpreter_discovery.rst (#64608)
Added missing '/'
2019-11-08 22:47:16 +05:30
4f7f57e655 PR raised to add the feature of adding/removing IP from a Host record (#50975)
* 50238 fix
2019-11-08 19:30:38 +05:30
0cb19e655c zabbix_action shouldn't require args other than name when state=absent 2019-11-08 16:45:13 +05:30
21c8dae83b Correct usage of API call in aws_config_aggregator (#64581)
update_resource and delete_resource takes and requires four argument.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-08 05:24:07 -05:00
5e3fda5582 postgresql_subscription: fix typo in module.warn method name (#64583)
* postgresql_subscription: fix typo in module.warn method name

* postgresql_subscription: fix typo in module.warn method name, add changelog
2019-11-08 08:54:16 +01:00
2039bf45fe postgresql_publication: fix typo in module.warn (#64582)
* postgresql_publication: fix typo in module.warn

* postgresql_publication: fix typo in module.warn, add changelog
2019-11-08 08:53:48 +01:00
Ali
26acb0703d Added support for pagination to the github_deploy_key module(#36876)
- Fixes #36745 
- removed json import
- removed requirements from documentation
- refactored the module
- added changelog fragment
2019-11-08 09:09:23 +05:30
bbf376682f Disable failing aws_acm integration test. 2019-11-07 14:34:14 -08:00
27d3dd58a4 Replace clear() method for backward compatibility. (#64504) 2019-11-07 16:30:03 -05:00
75646037dc Switch from RHEL 8.0 & 8.1b to 8.1 in CI. 2019-11-07 13:17:49 -08:00
7348185948 Bug fixes for GCP modules (#64484) 2019-11-07 14:35:49 -05:00
f80653fcff Bug fixes for GCP modules (#64485) 2019-11-07 14:35:41 -05:00
45a5067c98 Bug fixes for GCP modules (#64486) 2019-11-07 14:35:33 -05:00
c4b83619a6 botmeta sanity: check migrated_to on non-existing file (#64551) 2019-11-07 14:12:10 -05:00
e5c1de29a8 postgresql_subscription: improve logic (#64561) 2019-11-07 09:24:57 -05:00
4078dcbb77 Zabbix: zabbix_template: fix https://github.com/ansible/ansible/issues/64030 (#64032)
add zabbix_template changelog
2019-11-07 08:21:14 -05:00
98b6b98287 Fixed few typo's: "Mutiple" to "Multiple" (#64543)
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
2019-11-07 14:03:28 +05:30
023a9b3166 VMware: vmware_export_ovf module fix Python3 compatibility issue (#60265) 2019-11-07 13:20:14 +05:30
9a54070fa2 VMware: Added check for temp_version type in vmware_guest(#64376)
Fixes: #64374

* Adding tests for create VM with interger version and latest version
2019-11-07 12:43:30 +05:30
b475e0408c eos_lacp: Add unit testcases to eos_lacp (#64417)
* Added unit testcases eos_lacp

* Added unit testcases eos_lacp
2019-11-06 19:02:12 -05:00
257736e828 Update the number of contributors in README: 4700+ 2019-11-06 23:17:06 +01:00
35a8922988 prepare_vmware_tests: datastore host is datastore.test
Use an alias to access the datastore host. This way, it's easier
to use an existing NFS server.
We can also disable the `write` access on the iso datastore.
2019-11-06 17:08:07 -05:00
ac9c75d467 updates RHEL packages to 2.9 (#64532) 2019-11-06 14:33:17 -05:00
26e0e4be01 ACI/MSO: Use get() dict lookups (#63074)
This improves the reliability of the modules somewhat.
2019-11-06 18:24:11 +01:00
1f5d2f9159 Enable aws_acm tests, AWS reports our account quota should be fixed (#64470) 2019-11-06 11:35:26 -05:00
254788bc22 unsafe wrapping should only happen for with_ loops (#64401)
* unsafe wrapping should only happen for with_ lookups. Fixes #64379. Addresses #64169

* edit porting guide entry

* typo in changelog fragment

* typo

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* punctuation

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-11-06 10:31:55 -06:00
c5d61953b1 Remove empty setUp/tearDown/tearDownClass methods in test classes. 2019-11-06 08:14:29 -08:00
14f68e31ab Move consul modules to own subdir (#64508) 2019-11-06 15:48:35 +00:00
eb58f437fb postgresql_query: add note to the documentation (#64432) 2019-11-06 08:28:16 -06:00
cd8ce16d48 template lookup: fix regression when templating hostvars (#64070)
This fixes a regression that was caused by switching from copy() to
deepcopy() when 'saving' variables before templating. Since HostVars
did not implement the __deepcopy__() method, deepcopy returned incorrect
results when host vars were present in the variables.

Fixes #63940
2019-11-06 15:25:43 +01:00
22fe622589 postgresql_subscription: new module (#63661)
* postgresql_subscription: setup master-standby cluster into one container

* postgresql_subscription: setup master-standby cluster into one container, fix

* postgresql_subscription: setup master-standby cluster into one container, set up publication

* postgresql_subscription: setup master-standby cluster into one container, add module template

* postgresql_subscription: setup master-standby cluster into one container, fix tests

* postgresql_subscription: setup master-standby cluster into one container, create subscr via shell

* postgresql_subscription: setup replication, state stat

* postgresql_subscription: add basic present mode

* postgresql_subscription: add assertions

* postgresql_subscription: add samples

* postgresql_subscription: state absent, cascade

* postgresql_subscription: add owner param

* postgresql_subscription: update

* postgresql_subscription: refresh

* postgresql_subscription: doc, warns

* postgresql_subscription: relinfo

* postgresql_subscription: fixes

* postgresql_subscription: fix CI tests
2019-11-06 14:19:30 +00:00
da25c2b07b Move datadog modules to own subdir (#64502)
* Move datadog modules to own subdir

* datadog ignore.txt
2019-11-06 13:01:27 +00:00
f34d59dbef Move gitlab modules to own subdir (#64497)
* Move gitlab modules to own subdir

* Correct module_utils
2019-11-06 12:35:12 +00:00
f21f3219b2 [Fix] Typo in playbooks_environment.rst (#64496)
Change from `varaible` to `variable`
2019-11-06 17:31:16 +05:30
16c17765a6 Move sensu modules to own subdir (#64498) 2019-11-06 12:00:41 +00:00
498edda603 Move github modules to own subdir (#64460)
* Move github modules to own subdir

* Update test/sanity/ignore.txt

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-06 11:44:26 +00:00
008a95073d nxos_lag_interfaces: fix regression tests (#64119)
This is a change to the regression tests only. These tests were failing because of leftover device settings from previous tests:

- existing `channel-group` configurations on non-test interfaces were included in the before/after counts
  - fixed by using the `nxos_lag_interfaces` module with `state: deleted` to remove `channel-group` configur
ations from all interfaces

- existing `L2` `port-channel` interfaces with the same ID as the test `channel-group` ID may prevent configuring `channel-group` on the test ethernet interface
  - fixed by removing `port-channel` interfaces with the same ID; e.g.

```
  interface port-channel98
    switchport
    switchport mode trunk

  nx-1(config-if)# interface Ethernet1/19
  nx-1(config-if)# channel-group 98
command failed: port not compatible [switching port]
```

Fixes passed on `N6K,N7K,N9K,N3K` (internal TBs: `dt-n9k5-1,n6k-77,n7k-99,n7k-j,n3k-173,evergreen-nx-1,greensboro-nx-1,hamilton-nx-1,camden-nx-1`)
2019-11-06 15:45:19 +05:30
2f34318ceb Remove timeout parameter from prepare_nxos_tests (#63963)
The error below occurs when attempting to run `ansible-playbook` with nxos regression tests.

```
fatal: [dt-n9k5-1.cisco.com]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "commands": [
                "show interface brief | json"
            ],
            "timeout": 60
        }
    },
    "msg": "Unsupported parameters for (nxos_command) module: timeout Supported parameters include: commands, interval, match, provider, retries, wait_for"
}
```

This error appears to be a result of https://github.com/ansible/ansible/pull/62625, but that has not been verified.
2019-11-06 15:42:12 +05:30
3b6681f889 nxos_lldp_global: fix regression tests (#64161) 2019-11-06 15:41:40 +05:30
351f60b0e1 nxos_hsrp_interfaces: new module (#61498)
* nxos_hsrp_interfaces: new module

* lint 1

* lint 2

* add normalize_interfaces

* change version /2.9/2.10/

* /2.10/"2.10"/
2019-11-06 15:40:39 +05:30
52c4c1b00d docker_login: Use with statement for accessing files (#64382) (#64392)
* docker_login: Use with statement for accessing files (#64382)

* Update changelogs/fragments/64382-docker_login-fix-invalid-json.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-06 09:40:30 +01:00
9a8d73456c mariadb_replication: fix CI tests (#64481) 2019-11-06 07:48:42 +01:00
8c0ab43f05 Use more route information to improve default_ipvX facts on BSDs (#64172)
* Use "default" route info to help pick the default address.

Before this change, the address information used for the "default_ipv4"
and "default_ipv6" information is whatever is first on the interface
identified by the looking up the "default" route. On OpenBSD at
least, the first IPv6 address tends to be a link-local address,
which is not useful if you want to try and put a globally routable
v6 address in a template somewhere.

OpenBSD and NetBSD list the local address used for the default
route, so we can then use that to filter the addresses on the
interface and use the right one when it is available. This should
also help in situations where the interface has a lot of aliases,
or if you're doing IP multipath.

Thanks to John-Mark Gurney and Jared McNeill for providing me output
from the route command on FreeBSD and NetBSD respectively.

* Use "route get default" to get default route information.

Using some other arbitrary address makes these facts produce
unexpected results in some situations.
2019-11-05 19:36:04 -05:00
adcf9458f1 Fix ansible-test collections sanity import test. (#64467)
* Fix ansible-test collections sanity import test.

Resolves https://github.com/ansible/ansible/issues/64466

* Fix get_source implementation also.

* Fix is_package function.
2019-11-05 16:06:57 -08:00
78be0dcbc8 Update faq.rst (#63026) 2019-11-05 16:55:01 -05:00
70d2750e0a Improve formatting of include_vars doc page (#63482) 2019-11-05 16:48:55 -05:00
b2939c71b7 Fix modules code quote documentations (#63594) 2019-11-05 16:44:21 -05:00
f178c49c02 Add warning about skipped vars (#63599) 2019-11-05 16:25:15 -05:00
0e4716d326 Clarify Python 2.x support in python_3_support.rst (#64077)
+label: docsite_pr
2019-11-05 16:08:07 -05:00
fbbf21f771 Add note about spot instances for ec2_instance (#64069)
Signed-off-by: Major Hayden <major@redhat.com>
2019-11-05 16:06:27 -05:00
e704406564 Update firewalld.py (#64153)
+label: docsite_pr
2019-11-05 15:43:23 -05:00
2d92ad5736 Admin rights are required (documentation) (#64260) 2019-11-05 15:30:51 -05:00
798d622a08 ec2_* Sanity corrections (#64409)
* ec2_* Sanity corrections

Cleanup some typos that were missed in #64230

* Update lib/ansible/modules/cloud/amazon/ec2_launch_template.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-05 20:58:11 +01:00
8e4ac212c8 Improve control node concept explanation (#64356)
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>

+label: docsite_pr
2019-11-05 14:57:16 -05:00
de2b29a60f Unlimited CPU credits apply to any T instance (#64372)
+label: docsite_pr
2019-11-05 14:55:05 -05:00
4ee9f40e62 Add aws_acm module (#60552)
* convert aws_acm_facts to AnsibleAWSModule

* factor aws_acm_facts into module_utils

* add more filtering options for aws_acm_info

* add aws_acm module and tests

* uncomment aws_acm test

* fix linting for aws_acm

* fix __future__ linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix aws_acm_info arg type

* remove test for old module name aws_acm_facts

* simplify AWS ACM client creation

* fix indent typo in aws_acm test

* catch BotoCoreError in aws_acm

* fix indent typo in aws_acm test

* tighten AWS ACM test policy resource

* move aws acm int test to venv

* remove errant file

* fix AWS ACM int test perms

* undo copyright addition to wrong file

* fix invalid log message in aws_acm

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* rephrase aws_acm_info doc from facts to information

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* rename aws_facts var to aws_info

* remove case insensitivity for aws_acm pem compare

* add no_log for aws_acm credential setting

* add per-test prefix to aws_acm test resource names

* make aws_acm use crypto module_util

* clarify copyright for aws_acm

* make aws_acm int test clearer

* add explicit crypto dependency to aws_acm

* change requests for aws_acm pr

* fix wrong copyright owner aws_acm test

* fix wrong copyright owner aws_acm test

* rewrite aws_acm cert chain compare with regex, no dependency

* fix linting for aws_acm unit test

* fix linting for aws_acm unit test

* fix linting and duplicate ignore

* fix failed cert chain split in aws_acm, add more tests

* remove errant file

* more linting fixes for aws_acm

* fix sanity ignore

* rewrite cert compare in aws_acm to use base64 decode

* improve regex for pem cert chain split in aws_acm

* undo changes to crypto module util for aws_acm

* increment ansible version for new aws_acm module

* convert aws_acm return(x) to return x

* increment version added for aws_acm_info new features

* fix linting

* fix bugs with AWS ACM

* fix bad rebase

* disable AWS ACM integration test, due to AWS account limit issue

* remove aws acm integration test from shippable group
2019-11-05 11:57:08 -07:00
ecc8e51044 Remove empty overridden unittest.setUp and unittest.tearDown methods. 2019-11-05 09:12:11 -08:00
377c763334 Removing jmighion as maintainer of aruba and aireos modules. (#61469) 2019-11-05 11:20:03 -05:00
f4ff45dcd4 ansible-test: bumping ACME test container version (#64424)
* Bumping ACME test container version.

* Add changelog.
2019-11-05 10:51:22 -05:00
37c7f2414a Adding team_aruba as maintainer for aruba modules (#64423) 2019-11-05 10:50:27 -05:00
519e4f4223 debian: install lib in dist-packages (#64412)
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: #64160
2019-11-05 10:45:05 -05:00
7acae62fa8 Fix up role version pagination for Galaxy install (#64373)
* Fix up role version pagination for Galaxy install

* Fix sanity issue
2019-11-05 10:34:50 -05:00
Med
a1ab093ddb synchronize - remove unused block (#64344) 2019-11-05 10:34:18 -05:00
d9f5be8d0d Ovirt host network dict correct (#64437)
* ovirt_host_network: correct comparing of two dicts

* update mode_number for 4th option
2019-11-05 08:22:17 -05:00
484943cbd1 Add unit testcases to eos_vlans (#63404)
* Added unit testcases to eos_vlans

* Corrected lint errors

* Corrected lint errors

* Corrected lint errors

* Addressed review comments and changed the testcase after bug fix

* Corrected lint errors

* removed the unwanted comments
2019-11-05 07:55:05 -05:00
4c8d0b1b8d eos_l2interfaces: Add unit testcases to eos_l2interfaces (#64127)
* Add unit testcases to eos_l2interfaces

* Fixed lint errors

* Corrected lint errors
2019-11-05 07:51:13 -05:00
143b5a3674 Added Unit tests to eos_logging (#63248)
* Added Unit tests to eos_logging

* Added Unit testcases for eos_logging

* Added Unit testcases for eos_logging

* Added Unit testcases for eos_logging

* Add UT

* Corrected lint errors

* Corrected lint errors

* Addressed review comments

* Corrected lint errors
2019-11-05 07:50:00 -05:00
3a0c6454a9 Enable logging to any domain in the check point machine (#63976)
* enable using any domain in the check point machine

* Update checkpoint.py

* trying to checge `test_chrckpoint` according to `test_ftd` in order to pass the tests

* Update test_checkpoint.py
2019-11-05 17:44:34 +05:30
48e132b9c3 Add GetHealthReport commands (#57494)
* add GetHealthReport commands

* add NetworkInterfaces and SimpleStorage

* convert report uri property keys from plural to singular

* one more plural to sungular uri conversion

* change module name to redfish_info in EXAMPLES docstring
2019-11-05 11:46:58 +00:00
8f853fef11 Added module for attaching volumes in the Packet host (#27843)
* Added module for attaching volumes in the Packet host

* Fix __future__ import sanity

* removed changed from RETURN doc

* Fix sanity tests, add check mode & few other minor changes
2019-11-05 11:36:59 +00:00
edf776189d Added module for handling volumes in the Packet Host (#27842)
* Added module for handling volumes in the Packet Host

* fixed CI bot issues

* Fix sanity tests, add check mode & few other minor changes
2019-11-05 11:36:23 +00:00
a3772e1ac3 New module: Add module for Packet API IP address assignment (cloud/packet/packet_ip_address) (#23133)
* Added module for IP address assignment in the Packet Host

* fixed CI bot issues

* rework of IP address handling to subnets

* fix pep8 in modules/cloud/packet/packet_ip_subnet

* Fix verison added

* Fix sanity tests, rebase, refactor & other improvements
2019-11-05 11:35:25 +00:00
04c999f0f8 postgresql_idx: add stat mode support (#64138)
* postgresql_idx: add stat mode support

* postgresql_idx: add stat mode support, add changelog

* postgresql_idx: add stat mode support, fix CI
2019-11-05 10:26:51 +00:00
e7cd5af1a6 Update intro_inventory.rst (#64345)
##### SUMMARY
A minor typo in `user_guide/intro_inventory.rst` is fixed.
Changed from "know" to "known"
2019-11-05 12:42:28 +05:30
9b0d487ce1 Add module_defaults group for ovirt (#64377)
* Add module_defaults group for ovirt

* Update docs to list ovirt module_defaults group
2019-11-05 12:30:41 +05:30
53f07bc283 intro_patterns.rst: fix typo (#64422)
Changed "your" to "you" in intro_patterns.rst
2019-11-05 11:56:41 +05:30
b1f02be9eb clarify vault warning and fix typo (#64419) 2019-11-04 17:47:03 -06:00
797397558e Add note about large tarball sizes for collections (#64411)
* add note on collection tarball size
2019-11-04 14:26:59 -06:00
0bf9146b29 Document 'elements' for module option and return value documentation. (#64075) 2019-11-04 15:21:07 -05:00
0515633189 Bug fixes for GCP modules (#64083) 2019-11-04 14:52:57 -05:00
def62163c2 New Module: gcp_compute_reservation_info (#64134) 2019-11-04 14:52:36 -05:00
1a726d436e New Module: gcp_compute_target_instance (#64135) 2019-11-04 14:52:28 -05:00
14cf1c1197 New Module: gcp_logging_metric (#64339) 2019-11-04 14:51:52 -05:00
9517d4c755 New Module: gcp_logging_metric_info (#64340) 2019-11-04 14:51:44 -05:00
4569949bcd Bug fixes for GCP modules (#64407) 2019-11-04 14:50:42 -05:00
819ba2259d Sanity test fixups for AWS ec2 modules (#64230)
* ec2_ boilerplate

* Deprecate unused options.

* ec2_vol: Perform explicit type checking on volume_size and iops when parsing the args

Boto would through a type exception if the string couldn't be converted to an int.

* ec2_lc_find: remove duplicate definition of region

It's defined in ec2_argument_spec and ec2 doc fragment

* ec2_lc_info: Move responsibility for type checking/conversion of sort_start and sort_end into arg parser

* General sanity test related doc fixups

* Remove EC2 related sanity/ignore.txt entries

* Add changelog fragment
2019-11-04 18:39:31 +00:00
8528fbc790 Amazon related Sanity test fixups (remaining batch 2) (#64358)
* Remove sanity/ignore.txt entries

* replace use of "_" as a variable name

* Cleanup boilerplate

* Remove default values from mandatory parameters

* Sanity test documentation updates

* Remove unused imports from iam_role
2019-11-04 16:56:14 +00:00
9686808326 restore TOC links to old porting guides (#64395)
* restore TOC links to old porting guides

* remove stray orphans
2019-11-04 10:55:31 -06:00
c1f1b2029c Support vars plugins in collections (#61078)
* Move var plugins handling to a separate file

* Allow var plugins to require whitelisting

* Add global configuration ('demand', 'start') for users to control when they execute

* Add 'stage' configuration ('all', 'task', 'inventory') for users to control on a per-plugin basis when they execute

* Update ansible-inventory and InventoryManager to the global and stage configuration

* Update host_group_vars to use stage configuration and whitelisting

* Add documentation for using new options and to the developer's guide

* Add integration tests to exercise whitelisting and the new configuration options, using vars plugins in collections, and maintain backward compatibility

* Changelog

Co-Authored-By: Brian Coca <brian.coca+git@gmail.com>
Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-11-04 11:41:14 -05:00
39bf09517a wait_for - remove an obsolete fallback for Python 2.6 (#63988) 2019-11-04 11:39:19 -05:00
8c8077b5be Amazon related Sanity test fixups (remaining batch 1) (#64368)
* Remove Sanity test ignore.txt entries

* Fixup boilerplate

* Remove use of blacklisted _ variable name

* cloudformation: Add an explicit removal version for template_format

This option's been ignored since ansible 2.3

* General docs cleanup to clear sanity errors

* elasticache_parameter_group: Add list of choices

- matches documented choices
- other values wouldn't have worked

* data_pipeline: Deprecate 'version' - always ignored

* Add deprecation documentation
2019-11-04 15:13:27 +00:00
3126c38f8a Replace import of pycompat24.literal_eval with ast.literal_eval. (#64088) 2019-11-04 09:55:08 -05:00
c67c23234a clean_facts - use correct variable when evaluating the string (#64284)
A regexp object has no .startswith() method, which caused an unnecessary
try/except block to be added to handle this.
2019-11-04 09:44:10 -05:00
816e194e37 ovirt_vm: update cpu_threads docs (#64380) 2019-11-04 07:19:07 -05:00
9e3b1f3b32 Doc notes 2 (#64347)
* addd

* all  update

* add/fix notes about modules work with connection

* duplication of key "notes"

* Update ce_evpn_bgp_rr.py

* Update ce_evpn_bgp.py
2019-11-03 21:56:57 -05:00
1d40d429a0 Doc notes 5 (#64350)
* addd

* all  update

* add/update notes.

* add/updates notes.
2019-11-03 21:46:18 -05:00
25e03b1e75 Doc notes 6 (#64351)
* addd

* all  update

* update/add notes.
2019-11-03 21:46:07 -05:00
ad0769c095 Doc notes 3 (#64348)
* addd

* all  update

* update/add notes.
2019-11-03 21:35:12 -05:00
703f7a149a Doc notes 4 (#64349)
* addd

* all  update

* add/update notes.
2019-11-03 21:35:03 -05:00
705c014ec3 Doc notes 1 (#64346)
* addd

* all  update

* add notes to set modules works with C(connection)
2019-11-03 21:25:24 -05:00
c27e47327f Refactor CLI prompt mode check for network plugins (#63945)
* Refactor CLI prompt mode check for network plugins

*  Move the CLI prompt mode check logic from action plugin
   to the controller side with the cliconf plugins.

*  This refactor also allows the network modules
   to initialise the persistent connection with remote device
   only when it is required.

* Fix review comments
2019-11-03 04:10:30 +05:30
73526b9d65 mysql_variables: add mode parameter (#63547)
* mysql_variables: add mode parameter

* mysql_variables: add mode parameter, add changelog fragment

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix sanity

* mysql_variables: add mode parameter, remove warns

* mysql_variables: add mode parameter, refactoring

* mysql_variables: add mode parameter, fix logic
2019-11-02 10:16:28 +01:00
42b290b781 cloud/openstack: fix os_server_action errors when wait is False (#64330)
Using os_server_action to perform start, stop and pause actions on a
server in OpenStack results in an error when 'wait' is False.

The command is successfully sent to OpenStack, however Ansible fails the
task:

  fatal: [127.0.0.1]: FAILED! => {
    "changed": false,
    "msg": "New-style module did not handle its own exit"
  }

This patch ensures that those actions always exit, whether running with
'wait' set to True or False.

As we are not waiting to confirm the result, this assumes that the
actions were successful.

Fixes #62958

Signed-off-by: Chris Smart <chris.smart@humanservices.gov.au>
2019-11-02 04:42:34 -04:00
78e476eb20 Increase unit test timeout in CI. 2019-11-01 17:16:07 -07:00
135c853588 reduce docs/docsite/README to essential info (#64287) 2019-11-01 15:35:40 -05:00
bbbaf0dfe7 VMware Inventory Enhancements (#63938)
* Fixes #63937

* Add the environment variables VMWARE_HOST, VMWARE_USER, and VMWARE_VALIDATE_CERTS for consistency

* Follow the general pattern for config file naming requirements and update the documentation
2019-11-01 16:16:56 -04:00
6e07d4c1d9 add general facts-to-info paragraph (#64293) 2019-11-01 16:09:03 -04:00
371d7aae31 Use templating in HostVarsVars __repr__ (#64282)
* Fix HostVarsVars templating

* Add some tests for HostVars and HostVarsVars templating

* changelog
2019-11-01 15:51:34 -04:00
5dff5603af New Module: gcp_compute_reservation (#64133) 2019-11-01 13:46:42 -04:00
6e63210620 New Module: gcp_compute_target_instance_info (#64136) 2019-11-01 13:46:34 -04:00
d865b7da71 Bug fixes for GCP modules (#64193) 2019-11-01 13:46:13 -04:00
2444fae208 Add a named parameter to the filter to_uuid (#64057)
Let the caller choose a namespace for `to_uuid` and document the
behaviour of both the default case, and the new explicit case.

This PR does not change the existing behaviour of the `to_uuid` UUIDv5
filter.
2019-11-01 13:11:34 -04:00
7b7f15cb3a Fix ec2_instance module where if placement_group and tenancy are (#63340)
both set in params, the placement_group setting is ignored.
2019-11-01 10:10:07 -07:00
d2562cde1c Temporarily increase CI timeout. 2019-11-01 10:10:02 -07:00
87de146038 Exclude the ansible-test script from the main rpm package (#64277)
We want the script to live in the ansible-test rpm subpackage alongside
of its libraries

Fixes #64275
2019-11-01 12:14:36 -04:00
c76e074e4c Callback: removing args from task_fields from Sumologic and Splunk plugin(#63527)
CVE-2019-14864 Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs

Fixes #63522

Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-01 19:51:11 +05:30
56d5fd34e3 [Docs-Release-2.9] clean up porting guide links and network text (#64124)
* clean up porting guide links and network text
* fix shippable error
2019-11-01 08:56:41 -05:00
60276d3d8d Fix network plugin config option load from collection (#64046)
* Fix network plugin config option load from collection

Fixes #63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.

* Fix review comments
2019-11-01 11:25:28 +05:30
3f808d9ed6 [Doc-Release-2.9] update release and maintenance page for 2.9 (#64166)
* update release and maintenance page for 2.9
* only 2.4 and earlier used the old changelog system
2019-10-31 20:20:34 -05:00
f264e9cfca update backport instructions to use stable-2.9 (#64168) 2019-10-31 19:49:17 -05:00
4d087ba6bd reorder porting guides (#64122) 2019-10-31 19:48:05 -05:00
0812516208 [Doc-Release-2.9] Add Roadmap 2.10 (#64162)
* add 2.10 roadmap shell and remove very old roadmaps
2019-10-31 19:46:33 -05:00
c63ef6d911 update too old version to 2.4 (#64167) 2019-10-31 19:44:53 -05:00
409545825f docs: update to latest 3 versions (#64109) 2019-10-31 19:32:05 -05:00
4349ab5777 Add option to specify ID of System/Manager/Chassis to modify (#62921)
* add option to specify ID of System/Manager/Chassis to modify

* added version to deprecate() call

* fix merge TODOs to use new self.systems_uri variable
2019-10-31 22:09:48 +00:00
c3838b5d73 Replaces deprecated usage of functions in ansible.module_utils.basic (#63990) 2019-10-31 16:22:44 -04:00
1ad3879430 Add podman_volume_info module (#63380)
Add module podman_volume_info that collects data about podman
volumes on the host. Acts as docker_volume_info module.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2019-10-31 16:17:33 -04:00
d5fbe6573b paramiko_ssh - Improve authentication error message (#64157)
The error is not always an invalid username/password. It could be a connection timeout or refusal.
2019-10-31 15:39:53 -04:00
35c415de98 get_url integration test: Fix missing conditional (#64100) 2019-10-31 15:17:38 -04:00
090dca7569 Note for virtual environment users (#64040) 2019-10-31 11:47:09 -04:00
63ce7d57b1 Remove extra dot at the end of the sentence (#64149)
Dot is already set in display.deprecated.
2019-10-31 11:07:23 -04:00
b4cd9086dc allow setting multiple BIOS attributes at a time (#62764)
* allow setting multiple BIOS attributes at a time

* fix documentation string errors
2019-10-31 14:47:05 +00:00
ec1c5585af nxos_vrf: N6K regression test failures (#63277)
* nxos_vrf: N6K regression test needs 'nv overlay evpn'

* Add delay for vrf creation

* Revert "Add delay for vrf creation"

This reverts commit 8afa5281ff4b3c5a1775fbd40c5acb7ab5ecdf68.

* Add vrf_error_check w/delay to module

* whitespace

* httpapi fixes

* /input/input_data/ - 'input' is a built-in

* shippable retry
2019-10-31 18:17:39 +05:30
be1bcc7450 fix bug 63761 (#63901) 2019-10-31 18:09:03 +05:30
548fa65ac6 VMware: Allow dash in Windows server dnsname (#64052)
Fixes: #62810
2019-10-31 14:02:52 +05:30
8316fa66e8 add GetManagerServices and SetManagerServices (#62815)
* add GetManagerServices in redfish_info module, and add SetManagerServices in redfish_config module

* fix incorrect-version-added, fix incorrect Comparison to None, fix continuation line under-indented for visual indent, fix line too long, fix blank line at end of file

* update parameter format to allow multi-services update and additional parameter update

* fix bad-whitespace and trailing-whitespace detected by ansible-test

* change command name from GetManagerServices/SetManagerServices to GetNetworkProtocols/SetNetworkProtocols, and update parameter name to network_protocols with dict type, and enhance set_network_protocols() to follow suggestions

* donot need to import ast any more

* fix problems caused by code merge
2019-10-31 07:57:20 +00:00
4e8bb334a9 Sanity test fixups: AWS VPC related modules (#64089)
* Add missing boilerplate

* Avoid blocklisted variable name '_'

* doc fixups

* Remove defaults for required parameters

* Remove explicit definition of 'region' from argument spec
it's automatically added by ec2_argument_spec and redefining removes the aliases

* remove sanity ignore entries for AWS VPC related modules

* Suggested Review changes
2019-10-30 14:28:14 -07:00
56db433d63 BOTMETA: Enable automerge (#64114)
We are in the process of enacting our migration strategy of content out of the Ansible repo, and auto-merge privileges being revoked at this point in time was an accidental byproduct of that migration strategy.

TL;DR I jumped the gun, sorry, Bot will catch up and merge open PRs shortly.
2019-10-30 16:37:45 -04:00
fed267df03 openssl_csr and openssl_certificate: fix support for Ed25519 and Ed448 private keys (#63984)
* Move X25519, X448, Ed25519 and Ed448 feature tests to module_utils.

* Correctly sign with Ed25519 and Ed448 keys.

* Fix public key comparison. Ed25519 and Ed448 do not have public_numbers().

* Add tests.

* Add changelog.

* Give better errors for cryptography 2.6.x and 2.7.x.

* Test for new errors.

* Forgot one.

* Used wrong private key.

* Use private key password for CA key. Add more stuff to its certificate.
2019-10-30 21:36:36 +01:00
1f2d78b356 unify mongodb installation for both xenial and bionic in integration tests 2019-10-30 13:21:37 -07:00
554285acb7 Fix image detection in os_image openstack module (#63959)
Currently first check was by checksum only, and if there are 2
images with the same checksum, but different names, this check
fails with error:
* Multiple matches found for None *

To prevent this let's add more exact check in the beginning:
1. Firstly try to find by unique ID if it's given, most safe way.
2. Try to find by combination of name and checksum, not only
checksum, it will drop duplicates with different name.
3. Try to find just by name, as most general approach.

By going from most narrow to more general checks we can drop
duplicates in more efficient manner.
2019-10-30 13:19:08 -07:00
0cd2ad5880 Try to escalate before on_open_shell to work around ios (#63571) 2019-10-30 16:10:36 -04:00
0a38460176 Fixup sanity test issues related to aws_ modules (#64064)
* Add AWS_ boilier plate

* AWS_ modules: clean up missing parameter types

* Remove documentation duplicated by ec2 document fragment

* Add missing documentation for options and sub-options

* Add missing return type documentation

* Remove AWS_ sanity-check ignores

* aws_waf_info: fixup conflicting 'defaults' information about the use of waf_regional

* Wrap URLs in U()

* Add elements entries, because felixfontein asked nicely

* Apply suggestions from code review

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Second round of review comments.
2019-10-30 13:08:02 -07:00
a5d69f2a26 Make docker_stack adhere to standard ansible return values (#63467)
* Make docker_stack adhere to standard return values

The names of the various fields returned from ansible modules are e.g defined here https://docs.ansible.com/ansible/latest/reference_appendices/common_return_values.html#msg.

Adhering to this improves usability and makes use of functionality for e.g stdout_lines etc.

* Update lib/ansible/modules/cloud/docker/docker_stack.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix under-indentation of continuation line (pep8)

Issue exposed in test here https://app.shippable.com/github/ansible/ansible/runs/146667/1/console

* Don't break old playbooks/roles

Made sure the changes are only adding new variables, not removing anything existing yet.

* Added comment

* Minor fixes

* Update lib/ansible/modules/cloud/docker/docker_stack.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_stack.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* minor change to docker_stack.py

* Add changelog fragment for PR 63467

* Format changelog fragment

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Add fragment about docker_stack return val depr

* Add docker_stack doc note about deprecated vals

* Remove whitespace in empty line

* Add docker_stack depr notice to porting guide

* Update changelogs/fragments/63467-docker-stack-return-fix.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update docs/docsite/rst/porting_guides/porting_guide_2.10.rst

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_stack.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Added back a missing new line
2019-10-30 19:42:19 +01:00
d529e37eed Update porting_guide_2.9.rst (#64082)
Porting guide should redirect `azure_rm_availabilityset_facts` to `azure_rm_availabilityset_info` on line 365, not to `azure_rm_availabilityset`
2019-10-30 12:48:57 -05:00
e6607d611a Sanity test fixups - AWS related tests (#64093)
* AWS tests Sanity Test fixups (add boilerplate)

* Remove sanity ignore.txt entries
2019-10-30 09:48:59 -07:00
e9f8a34dce Fixes for validate-modules import handling. (#63932)
* Fix validate-modules support for collections.

- Relative imports now work correctly.
- The collection loader is now used.
- Modules are invoked as `__main__`.

* Remove obsolete validate-modules code ignores.

* Handle sys.exit in validate-modules.

* Add check for AnsibleModule initialization.

* Remove `missing-module-utils-import` check.

This check does not support relative imports or collections.

Instead of trying to overhaul the test, we can rely on the `ansible-module-not-initialized` test instead.

* Fix badly named error codes with `c#` in the name.

The `#` conflicts with comments in the sanity test ignore files.

* Add changelog entries.
2019-10-30 09:48:21 -07:00
b7e38dfa52 copy - check for changes beyond first level of subdirectories (#58323)
Add integration test for copy: deep recursive with remote_src=True
2019-10-30 12:17:11 -04:00
26236f474b fix spelling issues (#64103) 2019-10-30 09:26:36 -05:00
e82d407fa8 Add filter option to netconf_config module (#63593)
* Add filter option for netconf_config module

* Address review comments and add tests

* Refactor integration tests

* Address review comments

* Review comments

* Fix nxos_netconf include check
2019-10-30 19:09:13 +05:30
003c26de04 iam_user Additional integration tests (#63768)
* Add tests that were originally part of pr59079 before being lost in a rebase

* missed a needed check_mode: yes and a test with a wrong group

* Clarify test name, fix resource, add user delete test

* Use AWSDenyAll for benign policy, chech policy with non-full ARN path works, fix wrong module copy-pasta
2019-10-30 09:37:33 -04:00
df6b7bf77f Fix grafana_datasource fails when name with spaces (#63987) 2019-10-30 07:15:26 +00:00
9c17c7ad19 Add integration tests for grafana_datasource module (#63986)
* Add setup_grafana role for integration tests

* grafana_datasource: add integration tests for elastic datasource

* grafana_datasource: add integration tests for influxdb datasource

* grafana_datasource: add integration tests for postgres datasource

* grafana_datasource: add integration tests for cloudwatch datasource
2019-10-29 22:39:38 +01:00
0d905a0496 ACMEAccount.get_request check status code value lower boundary (#63140)
* check status code value lower boundary

Any HTTP code below 200 cannot be considered a success, should be
handled like a failure instead.

This is particularly true for below zero status codes.

Fixes #63139

* provide changelog fragment

* ensure connection errors are handled in Acme module

* add fetch_url check to ACME.send_signed_request

* remove module.fail_json

* move _assert_fetch_url_success out of ACMEAccount

* fix ansible-lint errors

* use simplified syntax status checking
2019-10-29 19:44:25 +01:00
c782831dd7 Disable failing zabbix_host integration test. 2019-10-29 10:26:53 -07:00
885ee62b53 clarified some points on environment keyword usage (#64065) 2019-10-29 13:17:41 -04:00
1aee11c860 add newline to render table correctly (#63769) 2019-10-29 13:09:18 -04:00
1e52782d6b Fix indentation of example (#63789)
Remove no_log since module_defaults aren't displayed like set_fact was
2019-10-29 13:08:41 -04:00
3c978a3225 lineinfile - don't run os.makedirs on empty dir path (#63921)
* Fix #63919: don't run os.makedirs on empty dir path

* integration test for lineinfile create: yes without path
2019-10-29 13:06:17 -04:00
92daec5d0b Update password.py (#63965)
Update the examples of the password lookup plugin to show how multiple options are joined together.
2019-10-29 11:16:00 -04:00
ae2a27ad6a Disable automerge (#63958)
Help reduce the incoming flow of features into devel as we confirm what we are doing regarding collections.
2019-10-29 11:13:12 -04:00
4048fb4da7 Fix doc errors on aws_batch_job_queue (#63804)
Fixes: ansible/ansible#63803

Signed-off-by: Major Hayden <major@redhat.com>
2019-10-29 10:24:21 -04:00
14eedb2956 Do not PATCH Account Enabled prop if not supported (#62617)
* do not PATCH Account Enabled prop if not supported

* add changelog fragment
2019-10-29 13:16:49 +00:00
c9a669e42c add GetSoftwareInventory command (#62811) 2019-10-29 13:15:42 +00:00
31f3a29613 add UpdateUserName and UpdatePasswordPolicy (#62941)
* add new command UpdateUserName and UpdatePasswordPolicy in redfish_command module

* fix errors detected by ansible-test

* fix error detected by ansible-test

* change command name UpdatePasswordPolicy to UpdateAccountServiceProperties, and update parameter to account_properties to support mlti-properties setting
2019-10-29 13:13:40 +00:00
92a39a0910 add controller name to Drive and Volume inventories (#63106) 2019-10-29 13:13:12 +00:00
2108a2e1c9 add type of elements of list in package modules (#63427) 2019-10-29 13:12:50 +00:00
2b8553b242 Add SetBootOrder and SetDefaultBootOrder commands (#63915)
* add SetBootOrder and SetDefaultBootOrder commands

* change boot_order version added from 2.9 to 2.10
2019-10-29 13:10:58 +00:00
16d4d2dba9 acme_certificate: add select_chain option (#60710)
* Add select_alternate_chain option.

* Fix docs.

* Allow to match via subject key identifier and authority key identifier.

* Simplify test.

* Add comments.

* Add tests.

* Fix bugs.

* Also consider main chain when searching for alternatives.

* Bump version_added.

* Rename select_alternate_chain -> select_chain.
2019-10-29 08:09:15 +01:00
35a412fab7 openssl_csr: fix tests (#63994)
* Make sure tests are validated with correct backend in mind.

* Fix tests.
2019-10-29 07:07:17 +01:00
5c973dd147 docker_container: get rid of defaults (#63419)
* Add container_default_behavior option to get rid of some defaults.

* Add changelog.

* Fix option.
2019-10-28 16:40:48 -04:00
18f4f0549f Correct a typo (#64020) 2019-10-28 15:01:10 -05:00
ee8a088205 combine galaxy.com install roles details (#63486)
* combine galaxy.com install roles details
* flatten dev guide and user guide for galaxy
2019-10-28 14:59:14 -05:00
d455183cac Bug fixes for GCP modules (#63966) 2019-10-28 13:50:24 -04:00
ee290bf5b1 Declare support for Python 3.8 @ Trove classifiers 2019-10-28 10:06:03 -07:00
5c962ef859 revisions to docsite README (#63957) 2019-10-28 12:04:59 -05:00
039c770a95 vmware_host_firewall_manager: fix #61332
Since https://github.com/ansible/ansible/pull/56733, we were not able to apply
firewall rules with no `allowed_hosts` key.

closes: #61332

In addition, this patch ensures the `allowed_hosts` key accepts a dict,
instead of a dict in a single entry list.

```yaml
vmware_host_firewall_manager:
  esxi_hostname: "{{ esxi1 }}"
  rules:
    - name: NFC
      enabled: True
      allowed_hosts:
        - all_ip: False
          ip_address:
            - "1.2.3.4"
```

Should be written:

```yaml
vmware_host_firewall_manager:
  esxi_hostname: "{{ esxi1 }}"
  rules:
    - name: NFC
      enabled: True
      allowed_hosts:
        all_ip: False
        ip_address:
          - "1.2.3.4"
```
2019-10-28 13:01:02 -04:00
358574d57f update ce_sflow to fix bugs (#64021)
* update ce_sflow to fix bugs

* update ce_sflow to fix bugs

* update ce_sflow to fix bugs

* update ce_sflow to fix bugs

* update ce_sflow to fix bugs
2019-10-28 10:33:41 -04:00
defccd1d44 postgresql_db: allow to pass users names with dots (#64007)
* postgresql_db: allow to pass users names with dots

* postgresql_db: allow to pass users names with dots, add changelog fragment

* postgresql_db: allow to pass users names with dots, fix ci
2019-10-28 13:23:09 +00:00
823f2e3fca update ce_acl_interface to fix bugs (#64018) 2019-10-28 09:21:11 -04:00
1e8765f0d9 BOTMETA support migrated_to (#63952)
* BOTMETA support migrated_to

Allow BOTMETA to define if this part of the codebase has moved
into a Collection on Galaxy.
See also https://github.com/ansible/ansible/pull/63935

* Enforce migrated_to URL format

* pep8
2019-10-28 11:02:31 +00:00
ef7d060a3f AWS module_utils: Clear out Sanity Test issues (#63991) 2019-10-28 09:21:40 +00:00
cd7bfc09a1 AWS ELB: Sanity Test fixups (#64008) 2019-10-28 09:19:26 +00:00
8d7580a59f AWS S3 : Fixup sanity test issues and deprecate 2 unused options (#63989)
* S3 module Sanity check fixes.

* s3_lifecycle: deprecate unused 'requester_pays' option

* s3_sync: deprecate unused retries option

* Add changelog fragment
2019-10-28 09:18:08 +00:00
fd54c54b51 AWS IAM Sanity test cleanup and deprecate unused 'fail_on_delete' option (#63961)
* AWS IAM Sanity test cleanup

* Changelog and porting guide updates

* Review recommendations
2019-10-28 09:18:58 +01:00
30be3a4a9f Revert "ce_sflow: update to fix bugs." (#64001)
* Revert "ce_sflow: update to fix bugs. (#59349)"

This reverts commit 7711524718.

* Update ce_sflow.py
2019-10-27 21:51:20 -04:00
e60cdc310d Remove k8s_scale dependency on k8s_raw (#59887)
* Remove k8s_scale dependency on k8s_raw

* fix sanity checks
2019-10-25 15:44:39 -04:00
01a92f0191 Make banner detection non-greedy in ios_banner (#63092)
* Make banner detection non-greedy in ios_banner

* Added ios_banner unit test to detect bug #63091

* Corrected PEP8 errors

* Added integration test

* Corrected typo in integration test
2019-10-25 14:20:00 -04:00
9d91e6275e enable grafana_annotations callback sending annotations to multiple panels (#57575)
* enable grafana_annotations callback plugin message sending to multiple panels

* remove new line at end of file

* restructuring code of grafana_annotations cb plugin

* add missing self keyword

* grafana callback: use list for panel_ids

* grafana callback: convert panel_id to integer

annotations HTTP API states that panelId are integer (same as
dashboardId which is also converted).
2019-10-25 18:49:20 +01:00
0f6ca6c4c5 New Module: gcp_runtimeconfig_config_info (#63884) 2019-10-25 13:41:01 -04:00
1d5413a6ce Bug fixes for GCP modules (#63941) 2019-10-25 13:40:41 -04:00
88af9f6470 mysql_replication - accept empty string to the module's parameters (#63546) 2019-10-25 11:56:40 -04:00
cdb7ab61a0 Introduce context manager for temporary templar context changes (#60513)
* Introduce context manager for temporary templar context changes. Fixes #60106

* Rename and docstring

* Make set_temporary_context more generic, don't hardcode each thing you can set, apply to template action too

* not None

* linting fix

* Ignore invalid attrs

* Catch the right things, loop the right things

* Use set_temporary_context in a few extra action plugins
2019-10-25 09:51:57 -05:00
92d6212026 ovirt correct resolving nested atributes which are false (#63908) 2019-10-25 14:51:45 +01:00
5e9638c869 ManageIQ Ivanchuk fixes (#63948)
- manageiq-group: better handling if key not present
- manageiq-tenant: ivanchuk api now returns ids as strings
2019-10-25 14:46:13 +01:00
3aaebba235 postgresql_privs: allow to pass roles with names containing dots (#63942) 2019-10-25 14:39:49 +01:00
54f0b183dc Add BOTMETA entry for pear module (#62349)
* Add BOTMETA entry for pear module

Add an entry for pear module so that team_ansible can be set as maintainer

* Wrong indentation.

* Update .github/BOTMETA.yml

Co-Authored-By: Sloane Hertel <shertel@redhat.com>
2019-10-25 14:23:10 +01:00
3e6ecdedb4 Botmate: update to label cloudengine files. (#63566)
* Update BOTMETA.yml

* update for cloudengine.
2019-10-25 14:11:40 +01:00
5c5a315a44 a new module to manage static route and bfd. (#58004)
* add a new module

* update for shippable

* update

* update for shippable

* update for shippable

* update for shippable

* update

* add unittest.

* update

* update integration

* update unittest

* update

* update unittest.

* update for syntax error

* update for reviewing.
2019-10-25 06:40:30 -04:00
9d68115f7f Add packet project module (#63569) 2019-10-25 06:28:49 -04:00
57c36e0378 Zabbix integration tests (#63744)
* adjusted setup_zabbix integration tests role to work on distributions from Debian family

* bumped zabbix_host integration tests role to be run against bionic
2019-10-25 06:28:20 -04:00
07ed860c2b Add more kubernetes Service tests (#62581)
* Add more kubernetes Service tests

Services can often go wrong, and one of the main motivations for
apply was being able to correctly modify them, so more tests are good

* Remove a port from a service for k8s testing

* Add a Service check mode to k8s tests
2019-10-25 11:21:13 +01:00
8d1aa42e7b fix: Scaleway loadbalancer API url (#63437) 2019-10-25 11:19:25 +01:00
68c997e4dd add a new module ce_lldp_interface. (#58252)
* add a new module ce_lldp_interface.

* update for shipabble

* update

* ad unittest

* update

* update

* update

* update

* update

* upate

* update

* update for shipable.

* update & add intergration tests.

* update for shippable.

* update

* import future.

* update.

* update.

* update docs.

* missing whitespace after ','

* update docs.

* update docs.

* update docs.

* Update ce_lldp_interface.py

* Update ce_lldp_interface.py

* update for reviewing
2019-10-25 10:45:53 +01:00
bfb8b015c9 Don't sort lists of routes again in os_subnet (#63538) 2019-10-25 05:38:01 -04:00
e4f16368ed Fix doc errors in AWS modules (#63851)
* Fix register/debug in aws_batch_compute_environment
* Fix aws_batch_job_queue doc errors
* Fix module naming: `batch_job_queue` > `aws_batch_job_queue`
* Fix missing register
* Update debug task to use modern YAML format
* Fix missing register + debug for lambda_policy
* Fix YAML syntax for elb_application_lb_info module

Signed-off-by: Major Hayden <major@redhat.com>
2019-10-25 09:36:05 +05:30
f279715c29 template: Add a space in example block (#63930) 2019-10-25 09:21:17 +05:30
ffce2d3d2a Bug fixes for GCP modules (#63882) 2019-10-24 17:16:31 -04:00
9fe524248c New Module: gcp_runtimeconfig_config (#63883) 2019-10-24 17:16:24 -04:00
50f85c9bdd New Module: gcp_runtimeconfig_variable (#63885) 2019-10-24 17:15:57 -04:00
072767e005 New Module: gcp_runtimeconfig_variable_info (#63886) 2019-10-24 17:15:49 -04:00
c562e17659 Fixed example error in windows_winrm user guide (#63922)
##### SUMMARY
The example code to configure TLS 1.2 Support using Ansible had an indention error. The register variable 'enable_tls12' was not indented. This caused the subsequent task to fail since the variable was not registered. 


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-24 14:31:47 -05:00
7f2c367d78 Update documentation for package module (#63909)
##### SUMMARY
It is not clear from the documentation that list can be used

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-24 14:29:48 -05:00
af0d70cb6f user: Handle exception when /etc/shadow file is missing (#63888)
Added exception handling when module tries to modify user details,
and /etc/shadow file is missing or not found.

Fixes: #63490

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-24 14:22:41 -05:00
7f5d1ab2b7 Removed in 29 (#63680)
* Eh, 2.10 is close enough

* drop top-level authorize

* Remove from documentation

* Remove load_params

* Centralize this junos thing

* Fixup user modules

* I'm 95% sure this did not do what it was supposed to

* nxos_hsrp: I don't think this is an actual module parameter

* Try to fix junos_package tests

* Move local params to provider

* Promote 'timeout' to a real parameter for eos_eapi

* Don't assume provider exists?

* move another timeout

* Provider now always has auth_pass

* Fix junos tests to avoid NameErrors
2019-10-24 15:01:05 -04:00
553767ef50 Reword the ticket stub for collections (#63917) 2019-10-24 12:39:08 -05:00
2a80b3933e BOTMETA: team_grafana (#63859)
* BOTMETA: team_grafana

Ensure all Grafana bits of the codebase have maintainers

* typo
2019-10-24 17:37:08 +01:00
40437d434e postgresql_membership: add CI tests for roles with dots (#63896) 2019-10-24 11:09:42 +01:00
fb38c9cea9 Support PostgreSQL Custom Format (#63806)
* Support PGC Restores

* Fix whitespace

* support pgc both dump and restore
2019-10-24 11:09:11 +01:00
54b530967b ovirt disk correct fcp host (#63857) 2019-10-24 03:17:18 -04:00
ed86907587 DNF Handle Empty AppStream stream definition (#63819)
* DNF Handle Empty AppStream stream definition

Fixes #63683

Signed-off-by: Adam Miller <admiller@redhat.com>

* Switch Fedora dnf test target modularity to stratis

In Fedora 29, the metadata was not properly set for a default stream
for ripgrep even though there is a profile called "default", however
that's an arbitrary string and the module maintainer must set the
default stream (which it never was for the ripgrep module, thus
failing the "empty stream" install test)

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-24 00:57:31 -04:00
b96ae6ab67 Bug fixes for GCP modules (#63831) 2019-10-23 19:57:28 -04:00
b816e70d4a Bug fixes for GCP modules (#63832) 2019-10-23 19:57:15 -04:00
cc24f27857 Bug fixes for GCP modules (#63833) 2019-10-23 19:57:03 -04:00
1d7b027cdc Bug fixes for GCP modules (#63834) 2019-10-23 19:56:54 -04:00
fb76ac2bb6 Bug fixes for GCP modules (#63835) 2019-10-23 19:56:45 -04:00
b933350daa Bug fixes for GCP modules (#63836) 2019-10-23 19:56:38 -04:00
7ea7260753 [ec2_launch_template] Update description of state param (#63147)
##### SUMMARY
Currently, it is not possible to delete specific versions of an ec2 launch template. The module docs incorrectly suggest that there is a `version` param to the module that can be used to do that. This patch aims to correct that error.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-23 16:58:55 -04:00
bd6d4b5b3a New module: iam_policy_info (#62955)
* iam_policy: (integration tests) migrate to module_defaults

* iam_policy: (integration tests) Rework iam_policy integration tests

* iam_policy_info: Add new module and add iam_policy_info tests to iam_policy integration tests
2019-10-23 13:04:25 -07:00
18b9ce8b82 Integration tests: prevent loop squashing (#63847)
1. the feature will be deprecated in 2.11
2. these modules support passing lists
3. loop squashing does not work with collections
2019-10-23 21:02:25 +02:00
d620a209a5 Fix ios_l2_interfaces skipping relevant L2 interfaces facts (#63779)
* fix bug 63777

* fix comment
2019-10-23 21:13:37 +05:30
3e4ae42256 Cleanup after MySQL integration tests (#63641)
Add handlers to setup_mysql_db and setup_mysql8 to remove installed packages.
2019-10-23 11:11:02 -04:00
68de182555 eos_eapi: Added fix for bug # 51144 (#63632)
* Added fix for bug # 51144

* Corrected Lint errors

* Added fix for bug 51144

* Corrected errors

* Added unit testcase
2019-10-23 19:46:43 +05:30
b1e8a6c1cb mariadb_replication: improve CI tests (#63848) 2019-10-23 15:50:31 +02:00
4d72b69035 rds_subnet_group : Sanity Check fixes (docs) and Integration tests (#63214)
* rds_subnet_group: Fixup sanity test issues

* rds_subnet_group: Add integration tests

* rds_subnet_group: Add testing policy
2019-10-23 08:27:07 -04:00
2da2da54f8 Fix virtualization role for DigitalOcean droplets (#41062)
Fixes #41061
2019-10-23 14:00:05 +05:30
8c43697e3b yum - only instantiate YumBase once (#63713)
* yum - only instantiate YumBase once

Previously, this code was re-instantiating the `YumBase` object
many times which is unnecessary and slow. However, we must do it
twice in the `state: absent` case because the `yumSack` and
`rpmSack` data of the previously instantiated object becomes
invalid and is no longer useful post transaction when we verify
that the package removal did in fact take place. Also, this patch
removes the repetitive re-processing of enable/disable of repos in
various places.

Here's a display of the speed increase against a RHEL7 host:

```yaml
- hosts: rhel7
  remote_user: root
  tasks:
  - name: Install generic packages
    yum:
      state: present
      name:
        - iptraf-ng
        - screen
        - erlang
  - name: Remove generic packages
    yum:
      state: absent
      name:
        - iptraf-ng
        - screen
        - erlang
```

Before this patch:
```
real    0m52.728s
user    0m5.645s
sys     0m0.482s
```

After this patch:
```
real    0m17.139s
user    0m3.238s
sys     0m0.277s
```

Fixes #63588
Fixes #63551

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-23 03:34:13 -04:00
0923ed56c7 Changelog entry for ansible-test sanity fixes. 2019-10-22 23:26:59 -07:00
92ccdeac31 Fix various import sanity test issues.
- Relative imports are now properly recognized.
- Correct script invocation of Ansible modules is used.
- Warnings are now consistently reported as errors.
- Errors are now consistently reported with the file tested.

Resolves https://github.com/ansible/ansible/issues/62723
Resolves https://github.com/ansible/ansible/issues/61884
2019-10-22 23:00:35 -07:00
b52d715567 add change_set_id to cloudformation output (#63752)
* Add change_set_id to the cloudformation module output when a change set is created

* Add module return documentation for change_set_id

* changelog
2019-10-22 23:31:06 +02:00
6a2902c8d5 clarify no subfolders and md only for collections /docs folder (#63808) 2019-10-22 15:50:02 -05:00
56f52a0169 ec2_vpc_route_table_info integration tests (#63413)
* ec2_vpc_route_table_info integration tests

Make sure ec2_vpc_route_table_info return value has the right attributes.

* ec2_vpc_route_table_info integration tests for tags
2019-10-22 14:46:40 -04:00
7afba9420a XenServer: Update docs with recent changes in XenAPI python lib and branding (#63728)
- xenserver module_util: XenAPI lib import error message handling is now
   ported to missing_required_lib(). Updated unit tests.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   docs are updated to reflect recent changes in availability of XenAPI lib
   on PyPI.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   docs are updated to reflect recent Citrix rebranding of XenServer. Broken
   URLs to external resources are fixed.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   more tested platforms are mentioned in docs.
2019-10-22 21:04:16 +05:30
a6e610a9ed Prevent generating roles that do not pass linting (#63709)
Fixes bug where newly created role fails linting due to extra space
at end of line: [201] Trailing whitespace
2019-10-22 11:26:07 -04:00
7aac7a56da Added missing param to lambda module to pass it through to boto3 (#58822)
* Added missing param to lambda module to pass it through to boto3

* Allow updating of runtime, because there is no reason why not

* Updated version_added to 2.10 to make tests green again

* Updated RETURN docs of Lambda module

* Added tests to aws_lambda test-suite.
2019-10-22 17:17:01 +02:00
92cd13a2cf lineinfile - use correct index value when inserting at the end (#63696) 2019-10-22 10:39:58 -04:00
05c8e33983 Ignore sivel as a maintainer of vmware_deploy_ovf (#63790) 2019-10-22 09:17:21 -05:00
29d4d318a5 lineinfile - properly insert line when line exists and backrefs are enabled (#63763)
Use a separate variable for the boolean test rather than having the same variable sometimes be a boolean and sometimes be a regular expression match object

Add integration tests to cover this scenario
2019-10-22 10:01:11 -04:00
f6c85b7380 mso_schema_site_anp_epg_staticport - Add VPC support (#62803) 2019-10-22 09:41:23 -04:00
2bd2de02e3 Added module to manage contracts for external EPG in Cisco MSO (#63550)
* Added module to manage contracts for external EPG in Cisco MSO

* Looking good
2019-10-22 15:16:23 +02:00
2b1177dfad Added module to manage template external epg subnet for Cisco MSO (#63542)
* Added module to manage template external epg subnet for Cisco MSO

* Looking good
2019-10-22 15:16:06 +02:00
74f9816885 Map Extreme Network OSes to their facts modules (#63574) 2019-10-22 08:57:11 -04:00
e4b6dd1862 ce_config/bug/jingdong: a bug from jingdong. (#62872)
* update to fix "`quit` may make seesion closed."

* update to fix "`quit` may make seesion closed."

* 274:49: E272: multiple spaces before keyword

* add a changelog fragment.

* Update ce_config.py

using run_command for prompts.

* Update ce_config.py

* Update ce_config.py

typo error

* update to use get_prompt

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py
2019-10-22 07:38:10 -04:00
c317c3cadf mysql_db: Correct argument for single database entry (#38326)
Fixes: #38318
2019-10-22 14:50:03 +05:30
2e65c1ebb7 Bug fixes- Dellos modules (#63272) 2019-10-22 14:06:34 +05:30
4745d45711 azure_rm_keyvaultkey_info: show_deleted_key error fix (#63157) 2019-10-22 11:51:25 +05:30
aa68f728fd s3_bucket: Allow empty encryption_key_id with aws:kms (#62031)
* s3_bucket: Allow empty encryption_key_id with aws:kms to use KMS master key

* Add idempotency check and cleanup example, dont require encryption_key_id
2019-10-21 19:45:41 -04:00
2e81b813dd Add example for port range to win_firewall_rule_module (#63269) 2019-10-21 17:05:10 -04:00
cfe2beae46 added a link to install instruction of OpenSSH (#63548) 2019-10-21 17:02:19 -04:00
9cda5819b9 Update AWS dev guide to recomment module_defaults and point to CI policy repo (#63589) 2019-10-21 17:01:19 -04:00
c2d1cc6f5b Confusing indication of no notable module changes (#63685) 2019-10-21 16:58:51 -04:00
ae8aa05535 Implement run_commands on edgeos (#63754) 2019-10-21 16:01:04 -04:00
1971d1111e Bug fixes for GCP modules (#63603) 2019-10-21 14:46:39 -04:00
8b0927fe16 Bug fixes for GCP modules (#63604) 2019-10-21 14:46:29 -04:00
e7b0050542 Bug fixes for GCP modules (#63605) 2019-10-21 14:46:21 -04:00
ce9e909a5b Bug fixes for GCP modules (#63606) 2019-10-21 14:46:09 -04:00
66202c385e Bug fixes for GCP modules (#63607) 2019-10-21 14:45:57 -04:00
32e8a716ea Bug fixes for GCP modules (#63608) 2019-10-21 14:45:49 -04:00
dc5770dfa2 EXOS/VOSS/SLXOS - Single action file and 'gather_facts' (#61914)
* EXOS Single action file

* Single action file for all Extreme Network OSes
2019-10-21 13:31:26 -04:00
40975cd436 fix 61907 - auto_attach yes option not honored in ec2_transit_gateway (#61993)
* fix 61907 - auto_attach yes option not honored in ec2_transit_gateway

* add changelog fragment
2019-10-21 16:06:43 +01:00
f0cadb9843 Fix AWS iam_user remove (#59079)
* Make iam_user not fail on user deletion.

- Use guard clause on already absent user
- Refactor, use variable instead nested dict
- Ensure needed prerequisites for boto3 delete_user successfully
- Use AnsibleAWSModule on iam_user.
- Fix fail_json_aws calls

* Add s-hertel comments to PR
2019-10-21 17:06:05 +02:00
6046386dba doc: win_user: fix typo in the description of the groups modifyer (#63743) 2019-10-21 17:02:39 +02:00
891489a27e postgresql_publication: fix logic (#63737) 2019-10-21 15:14:23 +01:00
145b79ef0e ec2_instance test cleanup (#63708)
* ec2_instance/ec2_instance_info : Fixup sanity test errors

* Move ec2_instance integration tests to use aws_defaults

* Search for the AMI instead of hardcoding an AMI

* Make our VPC CIDR variable

* Remove AZ assumptions - no guarantees about specific AZs being available

* Make sure we terminate instances when we're done with them.

* Add a 10 second pause for IAM roles to become available before using them

* Wait on instance changes by default

* Switch out t2 instances for t3 they're cheaper and have more CPU available

* Pull t3.nano instance info a little earlier

* rework vpc_name and vpc_cidr a little

* Mark ec2_instance tests unsupported for now, they take too long
2019-10-21 14:55:44 +02:00
aa671be28b zabbix_host: fix https://github.com/ansible/ansible/issues/63449 (#63637) 2019-10-21 06:12:10 -04:00
f92c99b413 gitlab_*: remove deprecated functionalities (#61912)
* Documentation update
* Remove deprecated functionalities

Fixes: #61898 #61897 #61896 #61895 #61894 #61893

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-20 07:38:08 -04:00
331d51fb16 Attach an attached/detached volume from OpenStack VM’s should return similar information (#21558)
Currently, attach an attached volume from OpenStack VM’s returns only
argument data. It is better to return full data as attaching a detached
volume.

In my use case, I need the extra data to mount and format the volume.
2019-10-20 12:36:50 +05:30
78158c2e63 mysql_db: Add option hex_blob in db_dump operation (#23891)
Added support for --hex-blob option to mysql_db module.
This option is for dump binary columns using hexadecimal notation (for example, 'abc' becomes 0x616263).
The affected data types are BINARY, VARBINARY, the BLOB types, and BIT.
2019-10-20 11:48:46 +05:30
cc1ff57c5b AH servers include automation-hub as part of the server configuration. (#63700)
* AH servers include automation-hub as part of the server configuration.

So we don't need to add it here.

Fixes #63699

* Update unittests for the fix to galaxy wait_import_task
2019-10-19 12:40:45 -07:00
8f843bbaa5 iptables: support wait parameter (#47877)
Version 1.4.20 doesn't support 'wait' at all
Version 1.6.0 requires an argument for it
2019-10-19 22:27:45 +05:30
3f0479279e VMware: Add a parameter wait_for_ip_address_timeout in vmware_guest (#63557)
* Added a parameter (wait_for_ip_address_timeout) to allow a longer timeout than the default.
* Removed the wait_for_vm_ip function in this module as one in module_utils is already being used elsewhere.
2019-10-19 22:15:28 +05:30
b6e997aa5f Cleanup after MariaDB integration tests (#63657) 2019-10-19 13:10:35 +02:00
64989bea6a hwc: Add eip module (#60182) 2019-10-19 12:58:29 +02:00
86e4dcbaed hcloud: Add protection support to hcloud_server and hcloud_server_info (#63669) 2019-10-19 12:57:00 +02:00
c904336db0 hwc: Add security group rule module (#60186) 2019-10-19 12:53:02 +02:00
420de44a57 hwc: Add port module (#60188) 2019-10-19 11:32:10 +02:00
652de1a7fd hwc: Add new module to peering (#60190)
* Add peering module

* Update hwc_vpc_peering_connect.py
2019-10-19 11:27:53 +02:00
0af32a1093 gitlab_modules : remove misssing required parameter (#63690)
* gitlab_group: remove required=True on server_url param

* gitlab_project: remove required=True on server_url param

* Revert "Example incorrect: server_url is required argument (#63670)"

This reverts commit b02467961a.
This modification shouldn't have been made.
This parameter is deprecated and #60425 forget to remove the required
parameter
2019-10-19 13:57:18 +05:30
e0b4fafb22 hwc: Add disk module (#59919) 2019-10-19 10:09:40 +02:00
39201d1ba3 hwc: Add instance module (#60180) 2019-10-19 09:50:03 +02:00
7ed6a0037c hwc: Add security group module (#60187)
* Add security group module

* Update hwc_vpc_security_group.py
2019-10-19 09:43:50 +02:00
034afd40a3 zypper: add additional flag --force-resolution (#61705) 2019-10-19 09:40:47 +02:00
712abfd1a1 cloudstack: exoscale: fix boilerplate (#63532) 2019-10-19 09:37:23 +02:00
df0e747899 ASA: fixes #59007 (#59008) 2019-10-19 11:36:16 +05:30
8eb46acbb1 hcloud: Add Delete Protection to hcloud_volume and hcloud_volume_info (#63665) 2019-10-18 23:28:12 +02:00
e9e4b02b92 hcloud: Add Delete Protection to hcloud_floating_ip and hcloud_floating_ip_info (#63663) 2019-10-18 23:27:23 +02:00
d98482c294 eos_vlans: Never try to set vlan_id as a property (#63689) 2019-10-18 16:55:27 -04:00
93280bd59c exos_l2_interfaces Resource module (#63113)
* Resource module for exos_l2_interfaces
2019-10-18 13:10:19 -04:00
dcec3d000e syslogger - disable check mode (#63646) 2019-10-18 13:01:03 -04:00
cb0ee51712 ios_bgp: fixes #57666 (#57667)
* ios_bgp: fixes #57666

* ios_bgp: add integration tests
2019-10-18 21:25:45 +05:30
04252cf90d Improve validation of module return values (#63411)
* Add contains: validation for return values.

* Only require returned: on top level.

* Fix various return value problems.

* Update ignore.txt.

* Two more.
2019-10-18 16:01:52 +01:00
4de516d35f Do not set ANSIBLE_LIBRARY in env-setup.fish (#63688)
Setting this env var was removed from env-setup back in 2014. Not sure why it is in this setup script and it interferes with the defult search path
2019-10-18 10:56:19 -04:00
741d529409 Eos vlan override (#63639)
* Fix overridden & deleted in eos_vlans

* Fix vlan creation in overridden

* Right, Python 2.6
2019-10-18 10:36:30 -04:00
4326165be5 Update win_regmerge.py (#63633)
##### SUMMARY
<!--- s/windows/Windows/ in title -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 15:33:39 +01:00
5b2d625eb7 ovirt: Fix fetching of nested attributes (#61841)
This patch is fixing the fetching of nested attributes.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1748025
2019-10-18 13:40:41 +01:00
4e50096663 fix: scaleway api endpoint (#63436) 2019-10-18 13:31:33 +01:00
39c92310b4 Add a new module ce_lldp to manage Link Layer Discovery Protocol(LLDP) (#63395)
* new module ce_lldp

* update for shippable

* update for shippable

* update for shipabble

* update

* merge confilcts

* add integration test.

* update for shippable.

* update for bad-whitespace

* update for shippable

* update for shippable

* update for shippable

* update license.

* update for typo.
2019-10-18 13:15:42 +01:00
5ea72934bd Fix obvious typos (#62821)
* lib/ansible/modules/cloud/digital_ocean/digital_ocean_snapshot_info.py: fix typos

* lib/ansible/modules/cloud/ovirt/ovirt_host_network.py: fix typos

* test/integration/targets/cnos_backup/README.md: fix typos

* test/integration/targets/cnos_bgp/README.md: fix typos

* test/integration/targets/cnos_command/README.md: fix typos

* test/integration/targets/cnos_conditional_command/README.md: fix typos

* test/integration/targets/cnos_conditional_template/README.md: fix typos

* test/integration/targets/cnos_config/README.md: fix typos

* test/integration/targets/cnos_facts/README.md: fix typos

* test/integration/targets/cnos_image/README.md: fix typos

* test/integration/targets/cnos_rollback/README.md: fix typos

* test/integration/targets/cnos_save/README.md: fix typos

* test/integration/targets/cnos_showrun/README.md: fix typos

* test/integration/targets/cnos_template/README.md: fix typos

* test/integration/targets/cnos_vlag/README.md: fix typos

* test/integration/targets/enos_command/README.md: fix typos

* test/integration/targets/enos_config/README.md: fix typos

* test/integration/targets/enos_facts/README.md: fix typos

* test/legacy/roles/cnos_backup/README.md: fix typos

* test/legacy/roles/cnos_bgp/README.md: fix typos

* test/legacy/roles/cnos_command/README.md: fix typos

* test/legacy/roles/cnos_conditional_command/README.md: fix typos

* test/legacy/roles/cnos_conditional_template/README.md: fix typos

* test/legacy/roles/cnos_ethernet/README.md: fix typos

* test/legacy/roles/cnos_facts/README.md: fix typos

* test/legacy/roles/cnos_image/README.md: fix typos

* test/legacy/roles/cnos_portchannel/README.md: fix typos

* test/legacy/roles/cnos_rollback/README.md: fix typos

* test/legacy/roles/cnos_save/README.md: fix typos

* test/legacy/roles/cnos_showrun/README.md: fix typos

* test/legacy/roles/cnos_template/README.md: fix typos

* test/legacy/roles/cnos_vlag/README.md: fix typos

* test/legacy/roles/cnos_vlan/README.md: fix typos
2019-10-18 12:56:55 +01:00
aeb0dde7cc Update description for firstmatch option (#62896)
##### SUMMARY
This fixes issue https://github.com/ansible/ansible/issues/62862. The edit makes the description for the `firstmatch` option clearer.

The `firstmatch` option was introduced by PR https://github.com/ansible/ansible/pull/33825


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 12:53:50 +01:00
0b97180c74 adding ostype win10 support (#62987) 2019-10-18 12:44:39 +01:00
b02467961a Example incorrect: server_url is required argument (#63670)
##### SUMMARY
The example "Delete GitLab Group" does not work.

- name: "Delete GitLab Group"
  gitlab_group:
    api_url: https://gitlab.example.com/
    api_token: "{{ access_token }}"
    validate_certs: False
    name: my_first_group
    state: absent

It errors with: 
fatal: [myhost.mydomain.com -> localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: server_url"}

If you provide server_url and api_url, it complains that they are mutually exclusive:
fatal: [myhost.mydomain.com -> localhost]: FAILED! => {"changed": false, "msg": "parameters are mutually exclusive: api_url|server_url"}

This means there is no logical path in the use of the module where api_url can be specified without resulting in at least one of these fatal errors. I suggest adjusting the examples in the meantime, then changing the module to move away from the soon-to-be deprecated server_url parameter, removing it as a required argument.

This likely applies to all Examples, so this change proposes at least putting in the required parameter in the examples.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 12:34:00 +01:00
2ef4ac1404 Typo usersername should be username (#63671)
##### SUMMARY
Typo in examples using api_username. Example incorrectly has usersername.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-18 12:32:37 +01:00
4b1fdee119 docker_container: deprecate trust_image_content (#63420)
* Deprecate trust_image_content.

* Add changelog.

* Mention it has never been used; removed test stub.
2019-10-18 13:03:42 +02:00
b243494a29 Add subnet module (#60183)
* Add subnet module

* Update hwc_vpc_subnet.py

* Add subnet module
2019-10-18 11:00:32 +01:00
0b9c241822 Grafana dashboard : added folder parameter + fix when uid is missing in json file (#63342)
Related: ansible/ansible#61685
2019-10-18 10:35:56 +01:00
7d9a0baa7f Add private ip module (#60191)
* Add private ip module

* Update hwc_vpc_private_ip.py

* Add private ip module
2019-10-18 10:15:13 +01:00
47c31c201b action/ce.py:clear configuration candidate when return to user-view. (#63513)
* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml
2019-10-18 10:09:47 +01:00
d22dc5ab8b doc: postgresql_user: Add changelog fragment for 63565 (#63666) 2019-10-18 10:59:20 +02:00
f1c6a3331f hcloud: Add delete_protection to hcloud_network and hcloud_network_info (#63656) 2019-10-18 10:54:01 +02:00
4f2665810f Fix IOS_VLANS override operation for new VLANs (#63624)
* fix vlans override state

* adding code comment
2019-10-18 13:56:23 +05:30
684e70c8d7 postgresql_user: allow to pass user name with dots (#63565) 2019-10-18 12:55:41 +05:30
8a77f17dea Update vmware ansible modules requirements section (#62797)
* Update vSphere Automation Python SDK to the requirement section

Signed-off-by: Jobin George <jgeorge@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-18 11:34:02 +05:30
92b387aa27 Fix hcloud requirements.
Avoid installing hcloud on Python 3.9 since it is not supported.
2019-10-17 17:40:57 -07:00
6be4741f72 Fix ansible-test env var mixing running commands. 2019-10-17 17:40:34 -07:00
78eca0eb5d Fix SSL protocol references in mqtt module. 2019-10-17 17:40:21 -07:00
437e9b7063 Fix ansible-test sanity requirements install.
This fixes ansible-test so it no longer tries to install sanity test dependencies on unsupported Python versions.
2019-10-17 17:40:04 -07:00
424f9f0dac vmware_guest_network/test: fix name of test VM
The test VM is called `test_vm1` since
https://github.com/ansible/ansible/issues/63302.

Also, avoid the `00:50:56` prefix for the MAC address, since it's known
for being source of problem: https://github.com/ansible/ansible/issues/63302
2019-10-17 17:38:42 -04:00
a129499cf4 Improve module return values (#63541)
* Remove lists from contains:, fix types, some more details.

* Adjust types.

* Add new type.

* Re-add meraki_mx_l7_firewall docs at right indentation level.
2019-10-17 22:02:39 +02:00
d8b9f9fb4f Fix example in pip module documentation (#63462) 2019-10-17 15:40:13 -04:00
017f0cb2f8 Add scaleway maintainer to BOTMETA (#63439) 2019-10-17 15:34:04 -04:00
faf8fc62cb Add inventory cache to the netbox plugin (#57644)
* Add cache to netbox inventory plugin

* add changelog fragment
2019-10-17 15:18:07 -04:00
8d0737edf0 Integration tests for s3_logging (#63257)
* s3_logging: (integration tests) updated AWS policy

* s3_logging: fix sanity test issues

* s3_logging: Integration tests

* Add pauses to cope with evenual consistency

* Mark s3_logging tests as 'unsupported' for now due to testing instability
2019-10-17 11:33:55 -07:00
1a384a61fb exos_lldp_interfaces resource module (#62108)
* exos_lldp_interfaces resource module

* Fix exos_lldp_interfaces and add integration tests

* Fix deleted testcase for integration test
2019-10-17 13:40:17 -04:00
f5e0995cae Fix netconf post "delay persistent connections" (#63463)
* ensure_connect on manager use

* Remove ensure_connected from individual netconf plugins
2019-10-17 11:22:48 -04:00
7da37e58de Added changelog fragment 2019-10-17 08:12:49 -07:00
202ad4f89a Fixes --version in ansible-galaxy cli 2019-10-17 08:12:49 -07:00
81d49c38f8 Default lookups to community (#63631) 2019-10-17 09:44:24 -05:00
b4bb3dee9a gitlab_user: Fix ssh key add and group membership add when there's other changes (#63621)
* Fixed syntax in sshkey/group add

* Added changelog

* pep8 fix
2019-10-17 10:22:15 -04:00
7dd46f7b2d postgresql_privs: add support a type parameter option for types (#63555)
* postgresql_privs: add support a type parameter option for types

* postgresql_privs: add support a type parameter option for types, add changelog fragment

* postgresql_privs: add support a type parameter option for types, add schema handling

* postgresql_privs: add support a type parameter option for types, fix typo

* postgresql_privs: add support a type parameter option for types, add comment
2019-10-17 14:59:06 +01:00
ae16a840f6 mysql_replication: fix typo in setup role (#63625) 2019-10-17 13:17:15 +01:00
f2ca4cce2b Add Constructed to Foreman inventory plugin (#62542)
* add constructed

* changelog
2019-10-17 11:43:22 +02:00
ba686154b9 openssl_csr: deprecate version option (#63432)
* Deprecate openssl_csr's version.

* Add changelog.

* Change PR so that version will no longer accept values != 1 from 2.14 on.

* Make sure it is a string.
2019-10-17 10:42:05 +02:00
d00d0c81b3 openssl_privatekey: add support for format option (#60388)
* Add support for format option.

* Improve private key format detection.

* Fix raw format handling.

* Improve error handling.

* Improve raw key handling.

* Add failed raw test.

* Improve raw key loading.

* Simplify tests.

* Add raw format tests.

* Fail if format != 'auto_ignore' is specified for pyopenssl backend.

* Fix quoting.

* Bump version.

* Allow to convert private keys between different formats.

* Improve description.
2019-10-17 10:40:13 +02:00
e3c7e35656 Add extra args and executable name to podman connection plugin (#63166)
* Add extra args and executable name to podman connection plugin

Like there is for docker plugin, add extra arguments for command
line of podman. Also add configurable executable and checking if
this executable exists on host. Fail module if executable is not
in PATH.

* Update changelogs/fragments/63166-add-extra-args-executalbe-podman-connection.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-10-17 13:48:29 +05:30
b6ea43efc3 VMware: Support instance_uuid to find the vm for vmware_guest_network module (#62818) 2019-10-17 12:23:13 +05:30
d615d7ea19 mysql_variables tests: change CI host group (#63602) 2019-10-17 08:26:09 +02:00
4cad7e479c Galaxy publish fix (#63580)
* Handle galaxy v2/v3 API diffs for artifact publish response

For publishing a collection artifact
(POST /v3/collections/artifacts/), the response
format is different between v2 and v3.

For v2 galaxy, the 'task' url returned is
a full url with scheme:

        {"task": "https://galaxy-dev.ansible.com/api/v2/collection-imports/35573/"}

For v3 galaxy, the task url is relative:

        {"task": "/api/automation-hub/v3/imports/collections/838d1308-a8f4-402c-95cb-7823f3806cd8/"}

So check which API we are using and update the task url approriately.

* Use full url for all wait_for_import messages

Update unit tests to parameterize the expected
responses and urls.

* update explanatory comment

* Rename n_url to full_url.

* Fix issue with overwrite of the complete path

* Fixes overwrite of the complete path in case there's extra path stored
  in self.api_sever
* Normalizes the input to the wait_import_task function so it receives
  the same value on both v2 and v3

Builds on #63523

* Update unittests for new call signature

* Add changelog for ansible-galaxy publish API fixes.
2019-10-16 15:23:12 -07:00
82ee341fe0 Explicitly use multiprocessing fork start method (#63581)
* Explicitly use multiprocessing fork start method

* Remove unused import

* Remove unused import

* Fallback to just multiprocessing on py2
2019-10-16 15:30:50 -05:00
f638f29e44 Replaced old DSC links that given 404 (#63556)
Replace DSC links that returned "not found" with updated, working links.
2019-10-16 12:52:30 -05:00
275b3972cb [lightsail] make delete operation idempotent (#63317)
Fixes #63315
2019-10-16 13:01:50 -04:00
94c23136be one_vm: moved to pyone added Persisten Deployment (#57393)
* moved to pyone added Persisten Deployment

Moved from python-oca to pyone.
Added Persistent deployment of VMs.

* Cleanup fixed missing whitespace

* cleanup whitesüace and indent

* corrected Versions and fixed disk count in error msg

* inc version

* wrong version for vm_start_on_hold

* added datastore for new instances

* added multiple Disks

* fixed missing info
2019-10-16 12:11:08 -04:00
7448084858 Update default-test-container to 1.10.1.
This brings in the final Python 3.8.0 release instead of a release candidate.
2019-10-16 09:07:09 -07:00
6d7620b646 Added fix for bug 63290 (#63308) 2019-10-16 19:17:46 +05:30
88013e7159 generalized on_become prompt match for ios (#63528) 2019-10-16 19:13:57 +05:30
3a733cb0a1 postgresql_user: remove unused import (#63559) 2019-10-16 08:51:08 -04:00
98b025239a nsupdate: Don't try fixing non-existing TXT values (#63408)
The commit 4e895c1 aimed to ensure that TXT record values were sanely
quoted. Sadly it failed to take the scenario of non-existing values
into account. While record values are required for record creation
they are not required for record deletion.

This change rectifies that oversight, saving Ansible from
unsuccessfully trying to operate on NoneType objects.

Resolves #63364
2019-10-16 17:58:41 +05:30
332b220854 cloudscale: fix boilerplate (#63533) 2019-10-16 11:02:32 +02:00
c4ce4a6c03 mysql_variables: update MySQL in CI to 8.0 (#63454) 2019-10-16 08:30:33 +02:00
d829a50a5b Fix use of deprecated function in xml module. 2019-10-15 15:29:11 -07:00
32b57d57a0 Add constraint for pathspec.
This fixes installation of pathspec on Python 2.6.
2019-10-15 14:39:29 -07:00
4bc298af83 Fix return value documentation (2/2) (#63478)
* Fix return value documentation (2/2).
* Avoid validation errors for missing 'contains:'.
* Convert JSON text to JSON dict.
* example -> sample.
* Fix YAML.
2019-10-15 15:53:46 -05:00
20be8693ba Revert "Remove top-level arguments from network modules (#62603)"
This reverts commit d5ac3f7e77.
2019-10-15 12:53:51 -07:00
e4eea0510c Fix warnings for ufw examples (#63505) 2019-10-15 11:55:45 -04:00
e0f67b58ce Fix doc - porting_guide_2.8 value example (#63493) 2019-10-15 10:50:10 -05:00
d5ac3f7e77 Remove top-level arguments from network modules (#62603)
Eh, 2.10 is close enough

* drop top-level authorize

* Remove from documentation

* Remove load_params

* nxos_hsrp: I don't think this is an actual module parameter

* Move local params to provider

* Promote 'timeout' to a real parameter for eos_eapi

* Provider now always has auth_pass
2019-10-15 11:41:35 -04:00
6bea1597cc Fix return value documentation (1/2) (#63477)
* Fix return value documentation (1/2).
* Avoid validation errors for missing 'contains:'.
2019-10-15 10:03:08 -05:00
16e49fdd44 ovirt_vm add warning about next run configuration (#63458) 2019-10-15 09:42:32 -04:00
ecf71dd720 mysql_user: add seealso (#63497) 2019-10-15 10:48:13 +02:00
e967060b9f Update unarchive.py - Further clarify extra_opts (#58102)
* Update unarchive.py - Further clarify extra_opts
Update the description in the options to help assist with what the module is looking for in the extra_opts.  #31873 alone is not enough since if you are not familiar with the option given in the example it may not be obvious that both elements are part of the same option instead of being two different options.

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-10-14 15:38:49 -05:00
2b1e24fc49 package_facts - use AnsibleModule.warn() for warnings 2019-10-14 13:30:16 -07:00
7bb90999d3 Fix Gitlab module deprecation warning (#60425)
* gitlab modules : Fix deprecation warnings and parameters

Also preparing for 2.10 deprecation

* gitlab modules : Correct deprecation message
2019-10-14 15:58:21 -04:00
e9d10f94b7 user - fix shadow file parsing on AIX (#62547)
Initialize variables in case the shadow file is not found.
Handle IndexErrors if something goes wrong with file parsing.
2019-10-14 15:44:22 -04:00
d8389d9f55 Ensure we preserve the /api appended URL (#63472) 2019-10-14 13:34:07 -05:00
da46800f1b Update 'delete' parameter description in synchronize module (#63450)
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-14 13:49:43 -04:00
0beab6bf69 ovirt update fetch_nested param doc (#63191) 2019-10-14 12:21:17 -04:00
e9d29b1fe4 Properly mask no_log values is sub parameters during failure (#63405)
* Get no_log parameters from subspec

* Add changelog and unit tests

* Handle list of dicts in suboptions

Add fancy error message (this will probably haunt me)

* Update unit tests to test for list of dicts in suboptions

* Add integration tests

* Validate parameters in dict and list

In case it comes in as a string

* Make changes based on feedback, fix tests

* Simplify validators since we only need to validate dicts

Add test for suboptions passed in as strings to ensure they get validated properly and turned into a dictionary.

ci_complete

* Add a few more integration tests
2019-10-14 09:20:07 -07:00
876a2d57be Changed with_items to loop in VMware example (#63022) 2019-10-14 21:48:20 +05:30
ab249a469e ini_file: remove incorrect documentation (#63394) 2019-10-14 12:14:32 -04:00
4c2b137728 Deprecate hash_behaviour (#63300)
* Deprecate hash_behaviour

* Fix wording
2019-10-14 10:35:11 -05:00
ffe8f45ddd Pickle non-str objects to survive connection return (#63110)
* Fail more helpfully when data is not str

* Pickle arbitrary objects to return from connection
2019-10-14 11:34:37 -04:00
11dc3a972f Fix example typo for vmware_host_facts module (#63434) 2019-10-14 11:14:50 -04:00
7a8c909876 Enter should be Italics as it is a menu option (#63441) 2019-10-14 11:04:05 -04:00
36457bebc9 add a new module ce lacp to manage Eth-Trunk interfaces mode (#58077)
* add a new module to manage lacp

* add a new module to manage lacp

* add a new module to manage lacp

* add a new module to manage lacp

* add a new module to manage lacp

* update for shippable.

* update for shippable

* add units test to module ce_lacp.

* add units test to module ce_lacp.

* add units test to module ce_lacp.

* update

* update

* update

* update

* update

* update

* update for shippable.

* for shippable

* update ignore.txt to reslove conflict

* update for shippable

* update

* update unittest to remove provider.

* update unittest for shipppable.

* use to_native.

* intergration test

* syntax error

* syntax error

* syntax error

* update for `Andersson007` review and thanks.

* update for shippable
2019-10-14 15:14:43 +01:00
500f056b4e ovirt_vm correct graphical port (#63379) 2019-10-14 07:57:13 -04:00
2fe2a12440 ovirt_disk add state imported (#62859)
* ovirt_disk add state imported

* change search_by_name to get_id_by_name

* add disk_module.create as ret
2019-10-14 07:16:50 -04:00
aa0d4ef4ab ovirt_template remove unnecessary ret (#63382) 2019-10-14 07:16:34 -04:00
0ca682384d mysql_variables: add seealso, add return value (#63442) 2019-10-14 09:28:00 +01:00
d753168e9d docker_node_info: improve error handling (#63418)
* Improve error handling for get_service_inspect().

* Add changelog fragment.
2019-10-13 14:16:02 +02:00
7f643690c7 docker modules: improve return value list documentation (#63145)
* Improve type documentation.

* Also improve return values.
2019-10-12 15:08:20 -04:00
6170f3a6f6 Add route module (#60189)
* Add route module

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update main.yml

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update hwc.py

* Update hwc_vpc_route.py
2019-10-12 18:15:02 +02:00
61b3784131 docker_image: fix option parameter so that warnings are issued (#63345)
* Fix option parameter so that warnings are issued.

* Add changelog.
2019-10-12 08:09:03 -04:00
d4bbb8e2b8 Update ce_facts to fix bugs (#63331) 2019-10-11 21:11:22 -04:00
054285c34c crypto modules: improve return value list documentation (#62929)
* Improve return value documentation by allowing entry for return values.
* Add docs formatting, adjust styling.
* Fix sample return value. (Taken from https://tools.ietf.org/html/rfc7517#appendix-A.1.)
* Work around abuse of .
2019-10-11 13:59:15 -05:00
ae265bc546 Move galaxy appendix info to a new Galaxy section (#63356)
* start galaxy docs restructure
* shared snippets in txt files
* moved all content to galaxy section
2019-10-11 13:19:44 -05:00
504d76e956 acl: fix module failure if there're spaces in a path (#63280)
* Make acl module to work with whitespaces in path

* Added a changelog fragment

* Add quotes to changelog fragment
2019-10-11 10:40:19 -07:00
29939383e6 Improve ecs_ecr module to handle image_tag_mutability feature (#62871)
Since 2019 jul. 26, AWS Elastic Container Registry can be configured to be immutable that prevent overwritting of an existing tag in the registry.
https://aws.amazon.com/fr/about-aws/whats-new/2019/07/amazon-ecr-now-supports-immutable-image-tags/
https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-tag-mutability.html

By default, ecr is created MUTABLE, as this was the only option before this feature.
This module leverage new capabilities of boto3 to configure image_tag_mutability option.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecr.html#ECR.Client.put_image_tag_mutability

The image_tag_mutability option definition was inspired by existing terraform module.
https://www.terraform.io/docs/providers/aws/r/ecr_repository.html
2019-10-11 09:13:13 -07:00
df283788e5 Nosh module documentation update (#63303)
* detail the 'status' dictionary
* did not add individual descriptions, see nosh documentation for those
* sample: False not being rendered unless 'False' is quoted
2019-10-11 11:07:53 -05:00
7f4befdea7 Wrap CLI Passwords with AnsibleUnsafeText, ensure unsafe context is not lost during encode/decode (#63351)
* Wrap .encode and .decode on AnsibleUnsafe objects

* runme.sh needs to be executable

* ci_complete

* Update changelog with CVE
2019-10-11 09:17:10 -05:00
73febd4ea6 prepare_vmware_tests: use module_defaults (#63209) 2019-10-11 19:46:54 +05:30
bdd0fac606 add note about collection links (#63346) 2019-10-11 08:27:26 -05:00
b7f12f9ff3 ce_netstream_global: bugs fix(list index out of range) (#63332)
* update to fix bugs:index out of range

* list index out of range

* list index out of range

* update for bad-whitespace

* Update ce_netstream_aging.py

* Update ce_netstream_aging.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_aging.py
2019-10-11 07:09:53 -04:00
79ab8cb48d enabled check mode on nxos bgp modules (#57360)
* enabled check mode on nxos bgp modules

* fixed indentation

* spaces instead of tabs
2019-10-11 11:50:40 +05:30
82dedec011 vmware_guest_sendkey/test: ensure the test VM is running (#63359)
The `vmware_guest_sendkey` module fails if the test VM is off. We this
commit, we ensures the VM is running.
2019-10-11 07:52:36 +05:30
286102eb5e vmware_host_kernel_manager: fix the test (#63358)
PR #62161 changed the name of key
returned by the module from `ansible_module_results` to
`host_kernel_status`.
2019-10-11 07:52:05 +05:30
aaef214a26 adapt to firewalld 0.7.0 for RHEL 8.1 Beta, Fedora 31+ (#63357)
Fixes #63254

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-10 18:33:18 -04:00
bfd32c9b00 clean "changed" only after it has been processed (#59958)
* clean "changed" after it has been processed

without this change, a loop of `debug` tasks with `changed_when`
causes the "changed" status to get lost before output

* runme.sh tests for debug loop status
2019-10-10 18:24:31 -04:00
35cc228b3b VMware: name is not required parameter for vmware_guest_custom_attributes
Fixes: #63222

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-10 17:25:20 -04:00
b3deab4319 Update sros_config.py (#63132) 2019-10-10 16:56:08 -04:00
6ff5968781 fix aruba_config examples (#63136) 2019-10-10 16:41:03 -04:00
32980f214a [ec2_launch_template] Update examples (#63152)
- Update tasks names for existing examples
- Add a new example showing how to delete a launch template
2019-10-10 16:36:56 -04:00
719170e5c1 Update ec2.py (#63260)
Change the explanation of spot_wait_timeout
2019-10-10 16:34:22 -04:00
03b98f6351 Fix plain format output functionality (#63107) 2019-10-10 15:46:36 -04:00
6d52bdf4db fix default collection resolution in adhoc (#63298)
* fix default collection resolution in adhoc

* if an adhoc command is run with a playbook-dir under a configured collection, default collection resolution is used to resolve unqualified module/action names

* Set ANSIBLE_PLAYBOOK_DIR in integration tests.

* Fix config conflict in ansible integration test.

* add adhoc default collection test

* text-ify warning string
2019-10-10 12:42:03 -07:00
b20a0f4831 text-ify config warning message (#63349) 2019-10-10 11:31:54 -07:00
add74fd24b vmware_guest_network: avoid functional test failure
- Avoid the 00:50:56 MAC prefix, See: https://github.com/ansible/ansible/issues/63302
- Create an Ad-Hoc VM for the test and wait until the VMware tools are
  ready
2019-10-10 13:26:47 -04:00
7de70bde52 prepare_vmware_test: avoid the dependency on jmespath (#63344)
We don't really need to depend on jmespath for this.
2019-10-10 13:25:07 -04:00
904e8434db VMware: Add support to delete vm from inventory (#62903)
Fixes: #55572
2019-10-10 17:07:23 +05:30
3e87429365 mysql_replication: add support of resetmaster choice to mode parameter (#63321) 2019-10-10 13:02:57 +02:00
64a66f566d doc: mysql_info: add changelog and version_added for global_status (#63328) 2019-10-10 13:01:02 +02:00
45acdb41d2 Added Exos vlan resource module (#61865)
* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* Fix exos_vlans resource module and integration test

* Move exos_vlan folder to exos_vlans folder

* Fix exos->config->vlans and exos->utils

* Fix version_added

* Improve exos_vlans module and integration tests

* Fix exos_vlans.py

* exos_vlan resource module
2019-10-10 06:50:04 -04:00
eca33b80f0 mysql_info: add support for global status (#63189)
Signed-off-by: Yap Sok Ann <sokann@gmail.com>
2019-10-10 12:14:49 +02:00
f2e5e6de23 ovirt_vm: Fix getting console parameter (#63325)
Previously if the ovirt_vm module was executed without graphical_console
parameter, the task failed with "NoneType has no attribute 'get'". The
problem was that we obtained the graphical_console by
self.param('graphical_console', dict()), which returned None, in case
graphical_console is not passed instead of empty dict. So we must
change the line to self.param('graphical_console') or dict().
2019-10-10 04:32:00 -04:00
38d1025d58 mysql_replication: add mutually_excl block, new maintainer, seealso, change doc formatting (#63295) 2019-10-10 03:06:45 -04:00
77de663879 config encode errors should not be fatal (#63311)
* fixes #63310
* subset of fixes from #58638
* added warning on error
2019-10-09 17:08:29 -07:00
9d014778ad cronvar - use correct binary name (#63279)
Fixes regression introduced by #62554
Add integration tests for cronvar
2019-10-09 18:33:25 -04:00
ce402f003f Fix STS assume role error message when role does not exist (#63249)
AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
2019-10-09 14:08:29 -07:00
ed203c5902 Fix galaxy url use everywhere when url is set in config. (#63286)
In addition to trying the configured url (for ex, a migrated
'https://galaxy.ansible.com/') there is an attempt at that
URL with '/api' postpended.

If the extended URL works, update GalaxyAPI.api_server to
use the extended URL. Previously it only used it for finding
the API root info ('available_versions', etc)
2019-10-09 16:24:46 -04:00
5349b3ae4c docker_* modules: docs improvements (#63165)
* Improve docker_container docs.

* Fix usage of C(...) and I(...).

* Fix abuses of I(...).

* tls_verify has been made an alias of validate_certs some time ago.

* Fix YAML problems.

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Fix order.

* Split long description.

* Improve formatting.

* Rewrite state docs.

* Make proper sentences.
2019-10-09 22:21:28 +02:00
1d5206f53e Pass a JSON file to the Lambda's payload (#63261)
* Add an example of passing a JSON file to the Lambda's payload
Events passed to Lambda are commonly in JSON format, the change provides an example of using JSON file as an alternative to the inline YAML payload in the other examples.
2019-10-09 15:10:32 -05:00
5ed163ce3f Spot instance code error (#63246)
##### SUMMARY
Adds 'instance_initiated_shutdown_behavior: terminate' to spot instance example for greater efficiency.
2019-10-09 14:57:13 -05:00
81a614684a Typo on line 161 (#63133)
fix module name for azure_rm_manageddisk in one example
2019-10-09 14:38:32 -05:00
021d095625 Fix broken link (#63185) 2019-10-09 14:36:43 -05:00
ce1c8c24f7 Update win_disk_facts.py example (#63266)
Fix incorrect index for second disk (should be `disks[1]` not `disks[0]`)
2019-10-09 14:21:37 -05:00
aa04e61c89 docker_* modules: add docker module defaults group (#63164)
* Add docker module defaults group.
* Add footnote about docker_stack not being included (instead of remarks column)
2019-10-09 14:12:02 -05:00
b46299ff86 Update stat.py (#63289)
Reword awkward documentation language.
2019-10-09 14:07:56 -05:00
19587b35da docs: add Centos and Ubuntu to examples for playbook conditionals (#63085)
* docs: add Centos and Ubuntu to examples for playbook conditionals

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-10-09 14:05:21 -05:00
0fcb6574dd Ovirt: add ovirt_vnic_profile_info (#62396) 2019-10-10 00:20:12 +05:30
3ad602bfa6 Add aliases to path parameter of stat module (#61270) 2019-10-09 11:24:59 -04:00
d4ad541eee dest lives in 4 different places depending on exeuction type (#62444) 2019-10-09 19:50:08 +05:30
d336a14da6 Fix junos unicode errors. (#63046) 2019-10-09 19:26:27 +05:30
71bcce5db5 mysql_replication: add channel parameter (#63271)
* mysql_replication: add channel parameter

* mysql_replication: add channel parameter, add changelog
2019-10-09 14:27:01 +01:00
f72d4d2339 Do not use fully qualified module_utils imports (#63101) 2019-10-09 11:30:43 +02:00
9f9afcb203 mysql_replication: add connection_name param for MariaDB multi source replication support (#63229)
* mysql_replication: add connection_name param for MariaDB multi source support

* mysql_replication: add connection_name param for MariaDB multi source support, add changelog
2019-10-09 10:05:55 +02:00
fd229dcbb5 add ANSIBLE_PLAYBOOK_DIR envvar support (#63220)
* add ANSIBLE_PLAYBOOK_DIR envvar support

* allows `ANSIBLE_PLAYBOOK_DIR` envvar as a fallback on CLI types that support `--playbook-dir`. This should have been implemented with #59464, but was missed due to an oversight.
* added basic integration test

* make first-class PLAYBOOK_DIR config entry

* update changelog
2019-10-08 17:34:15 -07:00
bad72693e4 Stop appending '/api' to galaxy server url (#63238)
* Stop appending '/api' to configured galaxy server url

Since not all galaxy REST api server URLs live
at '/api', stop always appending it to the
'url' value loaded from config.

* Add note about manually migrated galaxy configs and /api

* Add '/api/' to galaxy url and guessing if galaxy API

* Fix most unit tests (update to expect /api/)

* Fix test_initialise_unknown unit test

Since we retry now with an added /api/, mock it as well.

* Update fallback default avail_ver to new format
2019-10-08 15:09:19 -07:00
dbc9444572 ec2_vpc_nacl and ec2_vpc_nacl_info migrate to AnsibleAWSModule and add tests (#63163)
* Move EC2 networking objects into network-policy.json

* ec2_vpc_nacl: Add integration tests

* ec2_vpc_nacl: Migrate tests to use module_defaults

* ec2_vpc_nacl: (integration tests) Add missing AWS permissions

* ec2_vpc_nacl: (integration tests) Update tests for ipv6 support

* ec2_vpc_nacl: Migrate to AnsibleAWSModule

* Fix sanity tests for ec2_vpc_nacl and ec2_vpc_nacl_info

* ec2_vpc_nacl_info: Migrate to AnsibleAWSModule

* ec2_vpc_nacl_info: (integration tests) Rename from ec2_vpc_nacl_facts to ec2_vpc_nacl_info and add a test using a filter (by tag)

* Pick availability zones dynamically

Rather than assuming that AZa and AZb always exist (they don't), query to find out which AZs we have available first

* Test that the NACLs we get back are actually the *saml* NACL rather than duplicates/delete remove

* Cleanup IPv6 tests a little.

Note: IPv6 support for ec2_vpc_nacl not complete yet.

This provides the initial framework, and should ensure things don't start exploding when support is added.

* Removing subnets by name from a NACL *is* now supported

* Fix ec2_vpc_nacl return documentation
2019-10-08 13:27:24 -07:00
811127d64d Add RHEL 8.1b to the Shippable test matrix. 2019-10-08 13:06:28 -07:00
5997d33381 Updated with slipped dates for the 2.9.0 release (#63243) 2019-10-08 14:13:45 -04:00
941a9b68fc Docs: User guide overhaul, part 1 (#63056) 2019-10-08 13:46:38 -04:00
da1a945088 fix typo in collection/plugins/readme (#63162) 2019-10-08 11:12:34 -04:00
35c3d831fb ovirt_vm: Add new suboptions to graphical_console (#63230)
Fixes: https://github.com/ansible/ansible/issues/63225

This PR add following new suboptions to graphical_console param:

  - keyboard_layout
  - monitors
  - disconnect_action
2019-10-08 11:12:14 -04:00
67d9cc45bd maven_artifact.py - add support for version ranges by using spec (#54309) (#61813) 2019-10-08 15:24:50 +01:00
65fd331cb5 Ovirt add template timeout error (#63199)
* Ovirt add template timeout error

* correct example syntax
2019-10-08 10:03:44 -04:00
3b18337cac lineinfile - fix bug with insertbefore/insertafter and firstmatch (#63194) 2019-10-08 10:01:36 -04:00
b7a9d99cef Add spaces around {{ indicators. (#63125)
##### SUMMARY
The example looked a little less readable by not having spaces after `{{` and before `}}`. This commit should make the examples match [ansible-lint rule 206](https://github.com/ansible/ansible-lint/blob/master/lib/ansiblelint/rules/VariableHasSpacesRule.py)

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-08 13:41:54 +01:00
5fcaefc012 mysql_replication: small fix of master_delay parameter (#63221) 2019-10-08 13:06:54 +05:30
022335669c Work around ssh-keygen issue in ansible-test. (#63211)
Newer versions of ssh-keygen create PEM keys that are not recognized by Paramiko.

Now ansible-test compensates for this by updating they keys it generates so Paramiko will recognize them.
2019-10-07 14:36:05 -07:00
314f9fbd5c Support latest version while upgrading VM hardware. (#62188)
Support for the `latest` version during an VM hardware upgrade.
2019-10-07 16:41:57 -04:00
4c79f1ec4d Fix ansible-test integration temp dir location.
Previously the temporary directory used to run integration tests resided under the user's home directory. This prevented ansible-playbook from detecting the default collection when running tests.

Now the temporary directory is created within the collection to facilitate default collection detection.
2019-10-07 13:12:59 -07:00
32979430d0 Add missing var for format string in ansible-test. 2019-10-07 13:10:42 -07:00
deda9d4cc5 VMware: Add module defaults for VMware modules (#63197)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-07 14:24:58 -04:00
86ae3cfa12 Install zip for unarchive test when using dnf. 2019-10-07 10:41:46 -07:00
4959ab5004 Bug fixes for GCP modules (#63153) 2019-10-07 13:22:41 -04:00
1522603078 New Module: gcp_compute_region_backend_service (#63154) 2019-10-07 13:22:26 -04:00
94433dc65e New Module: gcp_compute_region_backend_service_info (#63155) 2019-10-07 13:22:19 -04:00
785ba62867 vmware: Only add configured network interfaces to facts (#28552)
This change effectively filters out any network interfaces which were
not explicitly configured for the guest. This fixes some unexpected behaviour where a machine with multiple IP addresses (for example, when Docker is installed, an internal IPv4 interface is added to
communicate with the container) would show one of the internal
addresses in the 'ipv4' field, but then no other information about the
corresponding hardware interface.
2019-10-07 21:41:50 +05:30
e48202838c mysql_replication: add master_delay parameter (#63130) 2019-10-07 15:23:56 +02:00
30c2d21f17 mysql: add elements for list params to the modules' documentation (#63187) 2019-10-07 07:58:15 -04:00
8a37a2440e postgresql: add elements for list params to the module's documentation (#63186) 2019-10-07 04:44:57 -04:00
0554b50eed Misc typo in nxos_config documentation (#62629)
* Changed 'exit' to 'exist'
* Removed unnecessary word 'first'
2019-10-07 11:23:31 +05:30
7b7d266a39 VMware: add properties option to vmware_host_facts module (#62916)
* add properties option to vmware_host_facts
2019-10-07 10:27:57 +05:30
e977e0af74 VMware: Update maintenance notes on vmware_cfg_backup (#62853)
Maintenance mode seems only to be required for load or restet, not for save_configuration.
2019-10-07 10:19:37 +05:30
b5cc0872e7 Typo fix in mssql_db (#63184)
Changed from 'then' to 'than'
2019-10-06 21:13:23 -04:00
a99af710fb mariadb_replication / mysql_replication integration tests: conflicts on centos7 (#63171)
* Change group of mariadb_replication to avoid mysql_replication conflicts.

* Add remarks.
2019-10-06 10:21:15 +02:00
2b6ee572ee CentOS8/RHEL8 base don't have all the deps we were specifying
We used a few packages for tests which don't exist in RHEL8 base.  Don't
dep on those so those tests will simply skip
2019-10-04 20:52:22 -07:00
239d639fee Add support for automation-hub authentication to ansible-galaxy (#63031)
Adds support for token authentication in Automation Hub. Fixes: ansible/galaxy-dev#96
2019-10-04 17:57:37 -04:00
24b80848dc openssl_dhparam: add cryptography backend (#62991)
* Separate OpenSSL-specific code from generic code.

* Make sure absent works without OpenSSL.

* Add cryptography backend.

* Add tests.

* Add changelog.

* Duplicate disclaimer.

* Add dependency on setup_openssl.

* Forgot to adjust something.

* Fix version tuple.
2019-10-04 21:53:04 +02:00
a59b9d4269 Improve type documentation. (#62179) 2019-10-04 21:50:41 +02:00
41eafc2051 docker_container: improve image finding / change detection (#62971)
* Improve image finding / change detection.

* Checked wrong object.

* Improve behavior. (Let docker daemon sort this out.)

* Add changelog.

* Add simple test.

* Fix image name.

* Use new docker_image params.

* Rewrite.
2019-10-04 21:50:09 +02:00
bb9b2e87bc New Module: gcp_compute_node_group (#63080) 2019-10-04 13:10:53 -04:00
18237d78e4 New Module: gcp_compute_node_group_info (#63081) 2019-10-04 13:10:44 -04:00
d19b1da1e1 New Module: gcp_compute_network_endpoint_group (#63121) 2019-10-04 13:09:34 -04:00
7b7fff3d84 New Module: gcp_compute_network_endpoint_group_info (#63122) 2019-10-04 13:09:25 -04:00
7ac4756bf6 ios_bgp : Fix for bug #59083 (#63055)
* Fix for the bug 59083

* Bug fix #59083 - corrected linting errors
2019-10-04 10:56:08 -04:00
10ed3d0ec8 updated python-oca to pyone (#62867) 2019-10-04 09:23:25 -04:00
82a6f9d198 Update xml.py (#63128)
##### SUMMARY
Update example to remove escape characters in front of special characters as it is not needed to add explicitly anymore with latest ansible version


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-04 14:56:39 +02:00
66de3d429f mysql_replication: add basic CI tests with MySQL 5.6 (#63124)
* mysql_replication: add CI tests with MySQL 5.6

* mysql_replication: add CI tests with MySQL 5.6, add auxiliary checks

* mysql_replication: add CI tests with MySQL 5.6, fix comments

* mysql_replication: add CI tests with MySQL 5.6, add pause
2019-10-04 12:49:19 +02:00
b91f452f4f Fix ansible-test virtualenv real python search.
ansible-test now properly searches for `pythonX.Y` instead of `python` when looking for the real python that created a `virtualenv`.
2019-10-03 17:12:33 -07:00
f2214951c5 Update intro_installation.rst (#62994) 2019-10-03 16:57:30 -04:00
0311897722 Add docs on hiding sensitive data in loops (#63096) 2019-10-03 10:15:00 -05:00
fc5358cea0 Fix traceback for empty config (#62515)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-10-03 19:45:52 +05:30
7ae46329f2 This should never have been "support:network" (#63068) 2019-10-03 08:58:05 -04:00
ad5200a7c0 postgresql_lang: add owner parameter (#62999)
* postgresql_lang: add owner parameter

* postgresql_lang: add owner parameter, add changelog fragment
2019-10-03 18:03:06 +05:30
ea86b2c2f7 mysql_replication: add master_use_gtid parameter (#62648)
* mysql_replication: add master_use_gtid parameter

* mysql_replication: add master_use_gtid parameter, improve tests
2019-10-03 18:02:41 +05:30
6ad6fde424 datadog_monitor - Add api_host parameter (#62608) 2019-10-03 05:41:17 -04:00
25ac7042b0 pacman: remove 'recurse' deprecated option (#61961)
* pacman: remove 'recurse' deprecated option

* pacman: remove recurse deprecated option

* pacman: remove recurse deprecated option
2019-10-03 00:02:06 +02:00
e55f46f302 Doc updates to openssl_certificate and ecs_certificate (#63006)
* Doc updates to openssl_Certificate

* Doc updates to openssl_certificate and ecs_certificate.

* Update lib/ansible/modules/crypto/entrust/ecs_certificate.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-10-02 23:06:48 +02:00
ff933be7e6 VMware: new module vmware_guest_register_operation (#54647)
Added vmware module vmware_guest_register_operation

This module can do the following.

    Register VM to inventory
    Unregister VM from inventory

This is useful when you want to unregister a VM from inventory and register it again.
2019-10-02 16:57:03 -04:00
4bfa3b2bf8 aci_contract_subject: Remove missing entry (#63044)
This fixes a `KeyError: 'filter'` exception.
2019-10-02 21:46:48 +02:00
2f5886f4ef vmware/test: add vsphere-automation-sdk dep
The following modules depend on `vSphere Automation SDK`:

- `vmware_rest_client`
- `vmware_guest_info`
- `vmware_tag_manager`
- `vmware_vm_inventory`

The associated test cannot be run with `govcsim`. But the situation is
changing since we will soon run them on a regular lab, and so, we
need to install the dependency.

Bumping the default-test-container version to 1.9.3 to get a fresh version
of pip and requests.

Depends-On: https://github.com/ansible/ansible/pull/62412
2019-10-02 14:57:23 -04:00
93f851b698 Bug fixes for GCP modules (#61915) 2019-10-02 14:31:45 -04:00
c2b8f64e83 New Module: gcp_compute_node_template (#63064) 2019-10-02 14:30:10 -04:00
dc7dbc7aa8 New Module: gcp_compute_node_template_info (#63065) 2019-10-02 14:29:51 -04:00
c724aa22bf hcloud_volume: add linux_device to return values (#62865) 2019-10-02 20:19:10 +02:00
88a2778c60 hcloud_floating_ip_info.name: add version_added 2019-10-02 20:17:20 +02:00
84bde7aea6 hcloud_floating_ip_info: create temporary ip in integration tests 2019-10-02 20:17:20 +02:00
596f80586b hcloud_floating_ip_info: add name to return values 2019-10-02 20:17:20 +02:00
594a0fa9ae Add new truthy and falsy jinja2 tests (#62602) 2019-10-02 13:58:28 -04:00
918f768890 [stable-2.9] Fix nxos_l3_interfaces module and tests (#62545)
* Fix nxos_l3_interfaces module and tests

* Use get_interface_type

* get_interface_type in utils lib
2019-10-02 13:43:17 -04:00
926e423690 Add Azure Stack supported API profiles (#62675)
* Add Azure Stack supported API profiles

* Bug fix

* add enum package to requirements

* Revert bacl latest profile changes

* Bug fixes

* Bug fix
2019-10-02 13:04:28 -04:00
69317a9d3e IOS-XR: Fix iosxr_lag_interfaces intermittent failures (#62998)
* Fix iosxr_lag_interfaces intermittent failures

*  If the dictionary is read out of order from member
   the current logic in `diff_list_of_dicts` returns
   unwanted diff. Hence use `dict_diff` utils
   function instead of sets.

Remove zip() to make existing tests happy

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Address review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-10-02 11:43:29 -04:00
8bcf11fee9 dnf - properly handle idempotent removal of wildcard globs (#63034)
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-02 11:05:12 -04:00
911aa6aab9 Default collection install path to first path in COLLECTIONS_PATHS (#62870) 2019-10-02 10:22:00 -04:00
1fd79240db vmware_httpapi: version_added==2.10
`vmware_httpapi` hierachy will actually be released with Ansible 2.10, not
2.9. This commit fixes the `version_added` field.
2019-10-02 09:38:19 -04:00
0706782e4e mysql_replication: add return value, remove extra argument from function (#63036) 2019-10-02 13:33:53 +02:00
d6781a2a5a Bug fixes for GCP modules (#61590) 2019-10-01 18:27:51 -04:00
2b535cc59a Bug fixes for GCP modules (#61829) 2019-10-01 18:27:42 -04:00
53cd75bee6 Bug fixes for GCP modules (#61916) 2019-10-01 18:27:19 -04:00
b4d15b3040 Bug fixes for GCP modules (#61917) 2019-10-01 18:27:03 -04:00
ecc47b653b Bug fixes for GCP modules (#61918) 2019-10-01 18:26:56 -04:00
8bfc39e231 ACME module defaults (#62719)
* Add module defaults group 'acme'.

* Start YAML document.
2019-10-01 17:14:22 -04:00
50d1cbd30a fix issue #60237 when non-ascii is returned from the WLC (#60243)
* fix issue #60237 when non-ascii is returned from the WLC

* update test to work with python3 through use of six library

* remove trailing white space
2019-10-01 16:52:35 -04:00
30cc54da8c rpmfilename must be constructed using rpmmacros
Different subpackages have different names so, at the least, the %NAME
macros must be used when constructing the rpmfilename.  Otherwise each
subsequent subpackage will overwrite the previous one.

This reinstates dag's fix from d4b6aecd97

Fixes #62673
2019-10-01 10:29:40 -07:00
ada02f1966 Limit Shippable matrix check to ansible repo. 2019-10-01 09:53:19 -07:00
f102705c95 changed capitals vSphere (#62975) 2019-10-01 16:41:50 +02:00
d8109550ec mysql_replication: setup a later version of MariaDB (#62993) 2019-10-01 08:29:40 +02:00
593d639160 Fixes to the rpm dependencies
* Remove duplicate bundled provides line in the rpm spec file
* Remove jmespath and passlib on RHEL7 as these are optional dependencies
  which aren't shipped with RHEL7
2019-09-30 20:51:16 -07:00
1e6fd6f54d Adjust documentation for yum clean to use best practices (#62898)
The yum module docs suggested using `shell: yum clean all`, which gives an `ansible-lint` error. Plus, you should use the `command` module unless you need more advanced features than just passing in an arbitrary command. Fixes that problem by using the `command` module in the example instead.
2019-09-30 18:33:53 -04:00
87a6f8397e Concise file module example description (#62932)
A file won't be created by the example, the execution would fail unless the file already exists as specified by the module options
2019-09-30 18:30:33 -04:00
6bbd9c9eca add ios/iosxr deprecated modules (#62908) 2019-09-30 18:18:57 -04:00
3f2380ccce Exclude tmp dir from ansible-test results copy.
This fixes test errors related to failures copying temporary test results files from a remote system back to the local system.

It also speeds up processing of test results and reduces network utilization by avoiding the temporary files.
2019-09-30 18:18:37 -04:00
0d79013f51 Modernize Vagrant documentation (#62923)
* By requiring a slightly newer Vagrant version (from 2015) we get the
  same generated Ansible inventory format is still used by today's
  version of Vagrant. That extended inventory format also has the
  benefit of allowing for simpler Ansible examples.

* Switching to a current and supported Ubuntu LTS version.
2019-09-30 17:47:57 -04:00
d01035ef25 VMware: Move helper functions from vmware_host_config_manager to module util. 2019-09-30 16:55:36 -04:00
ad580a71c4 fix minor typos (#62950) 2019-09-30 15:31:35 -04:00
c8315bfd60 Prefer https:// links in the docs site (#62939)
This is a follow-up of last year's 1a11cec. It deals with links which
at that point either were not present or did not support https://.
2019-09-30 15:11:19 -04:00
7ecfa4a471 vmware guidlines: adjust the location of cloud-config-vcenter.ini.template (#62970)
Update the location of the cloud-config-vcenter.ini.template template.
The file has been moved by: 2e7d36a3f9.
2019-09-30 14:21:35 -04:00
c6c13b5626 Fixing typo mistake in testbed with section. Deploy template from content library is supported from 67U3 2019-09-30 11:54:15 -04:00
67213ccb4d Fix traceback for empty config (#62520)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-30 20:37:28 +05:30
9aff5f6007 ovirt_vm add reboot state (#62785)
* ovirt_vm add reboot state

* update pep8 syntax

* update docs

* correct whitespace
2019-09-30 10:46:19 -04:00
44a6c69562 Remove unused variables from nxos_ping / nxos_snapshot (#62933)
This was caught by our network collections lint jobs.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-30 10:12:31 -04:00
50dc41cca2 ovirt: Fixing typo in ovirt_disk examples (#62962) 2019-09-30 08:25:34 -04:00
c24a85c793 lookup: lmdb_kv: fix for py3 2019-09-30 11:00:00 +02:00
6370c63efc lookup: lmdb_kv: add tests 2019-09-30 11:00:00 +02:00
a2270ead2f new lookup plugin: LMDB - allow wildcard searches - make dbname configurable for with_lmdb_kv: - added built-in documentation - incorporate suggested changes by dw - comment spaces - outdent for the bot 2019-09-30 11:00:00 +02:00
62c0cae29a docker_container: fix idempotency for network IP addresses (#62928)
* Specifying IP addresses needs API version 1.22 or newer.

* Simplify code.

* Use IPAMConfig.IPv*Address instead of IPAddress and GlobalIPv6Address.

* Add changelog.

* Fix syntax errors.

* Add integration test.

* Don't rely on netaddr.

* Normalize IPv6 addresses before comparison.

* Install netaddr, and use it.
2019-09-30 10:47:02 +02:00
a79f7e575a docker_image and docker_login: move tests needing a registry into own target, add tests for docker_login (#62721)
* Move tests with docker registry into own target.

* Add docker_login tests.

* Add step which makes sure hello-world:latest is around.

* Make work inside docker container.

* Add dependency.

* Use plaintext password.

* Forgot check_mode.

* Add no_log to avoid double log output in verbose mode.
2019-09-30 06:09:00 +02:00
75c4e9ec05 Fix _validate_csr_subject and _validate_csr_signature (#62790)
On python 3, if there is no explicit "return True", the
function call will be seen as "False", thus failling the module
2019-09-29 16:17:38 +02:00
fd627e3b78 docker_container: document some of the unexpected behaviors. (#62325) 2019-09-29 14:52:47 +02:00
75dfe6c88a nsupdate: Use authoritative server for zone lookup (#62329)
Using a regular recursive resolver to lookup the zone name might not
work when the zone in question belong to a private/internal
domain. The authoritative server being used on the other hand will
definitely know about the zone(s) it's serving.

This approach is also consistent with the nsupdate module already
querying the specified authoritative server for TTL values.

The reason for the implementation having to loop until finding a
direct match is to account for different SOA responses triggered by
CNAMEs and DNAMEs. The previously used `dns.resolver.zone_for_name()`
function does the same.

Resolves #62052
2019-09-28 19:34:28 +02:00
ee91714eb2 New module: Add module to collect Amazon AWS IAM user info (cloud/amazon/iam_user_info) (#23382)
* AWS: new module iam_user_info

Signed-off-by: psharkey <psharkey@cleo.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Rename from iam_user_facts to iam_user_info.

Rename and target 2.10.

Fixing docs.

* Adding iam_user_info integration test.

Removing unnecessary tasks.

Fixing yamllint failure test/integration/targets/iam_user_info/defaults/main.yml:5:1: empty-lines: too many blank lines (1 > 0).

* name paramter is optional

* Switch to use AnsibleAWSModule.

* Convert to using fail_json_aws

* Rework asserts to inspect ARN.

* Move integration tests from iam_user_info to iam_user.

* Fix pep8 problems.

* ec2_argument_spec not needed with AnsibleAWSModule.

* Switch to use helper in AnsibleAWSModule.

* Add iam_user_info to the aws group.

* Add support for pagination and backoff.

* Check improper parameter usage first.

* Adding test cases for multiple users.

* Rmoving unneeded line.

* Remove unneeded imports.

* Switch to catch BotoCoreError.

* Adding tests for exception coverage.

* Compare user info directly with values from created user.
2019-09-28 22:00:59 +10:00
334d2ce764 mysql_replication: add CI tests for MariaDB (#62907) 2019-09-27 09:29:34 -04:00
c3eceb3a0d support creating an image from a volume (#59574)
* support creating an image from a volume

* leave filename/volume optional

* enforce volume/filename mutual exclusivity

* bump version_added to 2.10 for volume option

* add changelog fragment
2019-09-27 14:29:34 +02:00
3c8abc0b82 cron: add integration tests (#59830)
* cron: add integration tests

Use faketime in order to reduce waiting time. Using opensuse15
container:

    Tuesday 30 July 2019  23:03:19 +0000 (0:00:05.410)       0:01:28.291 **********
    ===============================================================================
    cron : install cron and faketime packages ------------------------------ 78.65s
    cron : wait 70 seconds max ---------------------------------------------- 5.41s
    Gathering Facts --------------------------------------------------------- 0.97s
    cron : enable cron service ---------------------------------------------- 0.72s
    cron : Use faketime with cron service ----------------------------------- 0.71s
    cron : command ---------------------------------------------------------- 0.41s
    cron : create directory for cron drop-in file --------------------------- 0.41s
    cron : add cron task ---------------------------------------------------- 0.40s
    cron : command ---------------------------------------------------------- 0.25s
    cron : command ---------------------------------------------------------- 0.25s
    cron : include_vars ----------------------------------------------------- 0.06s

* cron test, simplify: use Environment instead ExecStart

Thanks to mscherer for the suggestion.

* clean up comment: remove reference to outdated path

$OUTPUT_DIR is a plain path which doesn't reference any other
environment variables

* cron test: display elapsed time

* cron test: display some logs in case of failure

* cron test: handle FreeBSD

* cron tests: add checks
2019-09-26 21:50:54 +02:00
e7436e278f Remove Latin phrases from the docs (#62419)
* add styleguide about avoiding use of latin words
2019-09-26 15:12:24 -04:00
8b9c2533b5 Remove check_args from nxos (#62625)
* Remove check_args from nxos

* Clean up check_args from nxos
2019-09-26 15:02:09 -04:00
89abfcdb18 Remove check_args from eos & ios (#62623)
* Remove check_args from eos & ios

* Clean up check_args from eos & ios

* Missed ios_vrf
2019-09-26 15:01:53 -04:00
831e1bf2e0 Fix ansible-test PYTHONPATH handling.
Running from an installed version of ansible-test now results in tests using a dedicated directory for PYTHONPATH instead of using the site-packages directory where ansible is installed.

This provides consistency with tests running from source, which already used a dedicated directory.

Resolves https://github.com/ansible/ansible/issues/62716
2019-09-26 14:02:19 -04:00
d41050b28b Add some documentation about plugins in collections (#62465)
* Add some documentation about using plugins in collections

- FQCN requirements
- Sharing code in collections
- Limitations with inventory caching
2019-09-26 12:00:26 -04:00
de515522b6 allow option docker_storage_driver=overlay2 (#62874) 2019-09-26 11:34:49 -04:00
2375fd0990 find - clarify description of 'contains' (#62445) 2019-09-26 11:33:14 -04:00
d4064a965b Improved docs on docker_swarm_service (#62712)
* Improved docs on docker_swarm_service

Co-Authored-By: Piotr Wojciechowski <23406016+WojciechowskiPiotr@users.noreply.github.com>

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-09-26 11:30:59 -04:00
cea8a222a3 Update playbooks_environment.rst (#62800) 2019-09-26 10:42:23 -04:00
798c5a55fa Update win_dsc.py (#62863) 2019-09-26 10:38:14 -04:00
b33ae14949 doc: fix typos (#62852) 2019-09-26 10:18:29 -04:00
f8fcf7fcbb facts: detect FreeBSD jails guest (#62857)
* facts: detect FreeBSD jails

* PEP8 fix
2019-09-26 10:08:33 -04:00
5b1c047a56 postgresql: move CI test to separate targets (#62855) 2019-09-26 05:53:13 -04:00
992b81e8fc Added suffix note to process_name_exact parameter (#62849)
##### SUMMARY
<!--- Your description here -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-25 22:49:41 +01:00
cae4255a16 Fix broken link to powershell resources (#62845)
##### SUMMARY
The previous link (https://docs.microsoft.com/en-us/powershell/dsc/builtinresource ) is a 404 . MS has a new link https://docs.microsoft.com/en-us/powershell/dsc/resources/resources  with the same content

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-25 21:19:11 +01:00
2995ae4ffd Fix MSO examples (#62835)
Fix reported issues with the examples.
2019-09-25 18:29:36 +02:00
7dfd994a7e win_partition - Fix handling of maximum partition size (#58225)
* Fix handling of maximum partition size

* Added changelog fragment
2019-09-25 11:51:26 -04:00
53ba3c46cc postgresql: move CI test to separate targets (#62823) 2019-09-25 09:03:48 -04:00
3b409f2f50 win_format - Add allocation_unit_size (#56966)
* Fix allocation_unit_size

* Some final changes and added tests

* Cleanup...

* Fixes issues on 2012/R2

* Update tests for 2012/R2

* Suggested changes
2019-09-25 08:58:30 -04:00
7e01de96d7 add more anchors to collections docs (#62827) 2019-09-25 08:32:44 -04:00
322e225830 Fix issue when setting an empty pass to no_log param (#62804)
* Fix issue when setting an empty pass to no_log param

* Fix typo
2019-09-24 21:45:53 -04:00
1b3bf33bdf add anchors to support galaxy links (#62808) 2019-09-24 16:23:32 -04:00
8a4c8ae20a Add checks for Cloud Block Store (#62068) 2019-09-24 15:11:15 -04:00
09ac8c154a Update developing_modules_general_windows.rst (#62796)
Use American spelling of favor.
2019-09-24 13:37:49 -04:00
28d30a04aa SoftLayer: Added flavor option (#56036)
* Added flavor option

Added flavor option to allow for use of SoftLayer flavor templates when creating new virtual machines.

See here for examples of ordering a vm with the flavor parameter:
https://softlayer-python.readthedocs.io/en/latest/api/managers/vs.html

To see flavor options use:
`slcli vs create-options`

* Update sl_vm.py

* Update sl_vm.py

* fixed version
2019-09-24 11:18:49 -04:00
3299f29f7c update example document for zabbix_action module (#62667) 2019-09-24 11:15:33 -04:00
1520eba0a7 package_facts: improve return value documentation (#62725)
* Improve documentation for package_facts.

* Add sample return value.
2019-09-24 11:14:49 -04:00
3b2b418aad ovirt_host update force doc (#62491)
* ovirt_host update force doc

* update doc message
2019-09-24 11:06:49 -04:00
190b8fcd1c hcloud_volume: clarify volume size units (#62771) 2019-09-24 10:52:14 -04:00
7fa1e4f70f Fix sanity checks (#62782)
This PR fixes all new ACI sanity issues.
2019-09-24 09:00:00 -04:00
d4ec9422a3 Add proper error when trying to run on older PS versions (#62634) 2019-09-24 08:43:14 -04:00
7711524718 ce_sflow: update to fix bugs. (#59349)
* update to fix bugs.

* remove params which is not supported.

* update to remove some .

* update to remove some redundant code.

* update for missing import.

* Update ce_sflow.py

* Update ce_sflow.py

* Update ce_sflow.py

* Update ce_sflow.py

* Update ce_sflow.py

* Update ce_sflow.py
2019-09-24 05:49:42 -04:00
6be46b59fa postgresql: move CI tests to separate targets (#62773) 2019-09-24 10:42:08 +02:00
278398555d package_facts: check 'vital' and 'automated' values ('pkg' manager) (#62766) 2019-09-24 10:03:56 +02:00
7d344d00ef Fix whitespace issue in filter (#62768)
This fixes a reported issue.
2019-09-24 02:05:13 +02:00
a2846613b8 Apcon modules (#62028)
* Add APCON modules

* Fix cli regex

* revise for passing sanity tests

* Add unit test for apcon_command module
Remove apconos_config.py apconos_update.py apconos_cert.py for now

* Fix for santiy test

* test

* Ignore action-plugin-docs test

* Add apcon_command module

* conflict solved

* merge

* Fix for sanity test

* Revise integration test

* Mark integration test unstable

* Remove integration test temprorily

* 1. Ignored privilege escalation;
2. Ignored get_configure command;
3. Removed doc_fragments;
2019-09-23 16:42:17 -04:00
b17581a307 [Docs] Document the resource module builder (#62222) 2019-09-23 11:10:05 -04:00
fbf182c369 Improve type documentation. (#62178) 2019-09-23 16:26:13 +02:00
03b4d8f2a7 fixes option names in examples (#62706) 2019-09-23 09:19:38 -04:00
d6ef7c8530 module_utils-network-cloudengine: fix get_nc_next. (#62587)
* fix get_nc_next.

* add a changelog fragment.

* upadte for  changelgo fragment.

* merge two prs, one depens another.

* merge two prs, one depens another.

* update changelog.
2019-09-23 15:13:42 +02:00
bd8097ea91 Fix ios terminal regex for privilege escalation (#62479)
Fixes https://github.com/ansible/ansible/issues/61726

*  On some ios versions the passwrod prompt for enable
   command differs. Modify the regex to work with multiple
   password prompt patterns
   1) password:
   2) Password:
   3) Local_Password:
   4) Enter Local Password:
2019-09-23 15:14:47 +05:30
0530a08b67 postgresql: move CI tests to separate targets (#62732) 2019-09-23 04:28:52 -04:00
cb76be17d6 cloudflare_dns: Stick do RFC 2606 example domains (#62718)
It's not nice to use other people's domains in your examples.
2019-09-23 10:20:03 +02:00
fc6a37fe54 cloudflare_dns: Rename account_api_token parameter (#62707)
Name change triggered by the new parameter _api_token_ (8cabf1c) being
a bit too similar to the old name _account_api_token_. At the same
time _account_api_key_ is actually a better name for the original
parameter, in it mapping closer to the terminology used by Cloudflare.

Keeping _account_api_token_ as an alias for backward compatibility.
2019-09-21 23:03:23 +02:00
8cabf1c1d8 Support cloudflare API Tokens. (#62043)
API Tokens provide a new way to authenticate with the Cloudflare API.
They allow for scoped and permissioned access to resources.
2019-09-21 16:55:53 +02:00
c6dcf78f53 ACME modules: make compatible to Buypass ACME v1 CA, and fix bug in ACME v1 account update (#61693) 2019-09-21 16:53:15 +02:00
2e5137078d docker_login: fix Python 3 problem in #60381 (#62621)
* Fix Python 3 problem: run_command() returns native strings, not byte strings.

* Add changelog.
2019-09-21 15:13:31 +02:00
a7b239708e acme_* modules: deprecate acme_version default, announce that ACME v1 support will be deprecated eventually (#61667) 2019-09-21 15:01:29 +02:00
0239f70648 cloudtrail: Initial integration tests (#61919) 2019-09-20 18:46:37 -07:00
40660e7f6e iam_role : support managing max session duration and deleting the instance profile it creates (#62014)
* iam_role: Add support for managing MaxSessionDuration

* iam_role: Add support for deleting the IAM Instance Profiles we created

* iam_role: migrate all boto failures to fail_json_aws for consistency

* iam_role: test validity of path so we can throw a more understandable error

* iam_role: (integration tests) Split iam_role integration tests from sts_assume_role tests

- Make the iam_role tests more comprehensive
- Add tests for iam_role_info

* iam_role: (integration tests) Make some of our pauses optional

If the tests appear to be flakey we may need to enable standard_pauses
2019-09-20 13:26:29 -07:00
679d3a46fa doc: fix typo (#62668) 2019-09-20 22:10:52 +02:00
987265a6ef Account for empty strings when splitting the host pattern (#62442)
Improve tests
- add more unit test cases
- add specific integration test with more cases

Testing shows no major downside to calling .strip() twice in a comprehension vs. using a regular for loop and only calling .strip() once. Going with the comprehension for ease of maintenance and because comprehensions are optimized in CPython.
2019-09-20 16:03:51 -04:00
8d0c193b25 allow before/after diff to be NoneType (#62582)
when creating or deleting an object (e.g. via an API), before/after can
be `None` (or at least represented as such by the used library). to
avoid modules havig to do

    diff={'before': before or '', 'after': after or ''}

let's just convert `None` to an empty string that can be diffed properly
2019-09-20 15:47:18 -04:00
bb0fa0a622 k8s: apply no longer the default behaviour (#62632)
There are too many lingering uncertainties about the correctness of
apply behaviour. All tests seem to suggest it works, and it's definitely
performed well in real world application, but it may be a breaking
and unexpected change to default to apply

We will let apply bed in during 2.9 and allow people to opt in, we
may default to it in future (or not)
2019-09-20 08:22:42 -07:00
cced1a3cd1 ec2_vpc_subnet: Rename resource_tags > tags (#62663)
Most of the AWS module documentation refers to `tags` and not
`resource_tags`. This patch updates the documentation to match
other AWS module documentation. 😉

Signed-off-by: Major Hayden <major@redhat.com>
2019-09-20 15:36:11 +01:00
5ecbe9cbbb vcenter provider: Only rely on VMWARE_TEST_PLATFORM
Until now, the vcenter provider was switching between `static` and
`govcsim` depending on the presence of the following configuration file:
`test/integration/cloud-config-vcenter.ini`.

This was not consistent with Worldstream, which we enable with the
`VMWARE_TEST_PLATFORM` environment variable.

We now only rely on `VMWARE_TEST_PLATFORM` to know which platform should be
used. `govcsim` is still the default, this to preserve the original
behaviour.

This commit also rename the following variables to be consistent with the rest
of the code base. It also ensures they are alway defined, even with `govcsim`:

- `VCENTER_HOSTNAME`
- `VCENTER_USERNAME`
- `VCENTER_PASSWORD`
2019-09-20 10:33:44 -04:00
170b4e63ff fixed options (#62605) 2019-09-20 09:08:47 -05:00
7cfcf18a8c Update ovirt_vm.py (#62425)
* Update ovirt_vm.py
2019-09-20 09:40:14 -04:00
2969614c2c Fix link syntax and a typo in dev collections doc (#62650) 2019-09-20 09:36:23 -04:00
be9bf8cd15 postgresql: move CI test of *_publication, *_ext, *_slot to separate targets (#62646) 2019-09-20 12:47:13 +01:00
0c66e7ef10 VMware: Remove mentions of enable_vsan from vmware_cluster_ha example (#62616)
* VMware: Remove mentions of enable_vsan from vmware_cluster_ha example
* Add changelog fragment
2019-09-20 12:03:20 +05:30
6541bb0315 pids: Search for process name matches in the cmdline (#59318)
* Also search for process name matches in the cmdline
* Return integer pids
* Use correct variable name
* Fix linter concerns
2019-09-20 12:00:25 +05:30
41bfd2bf0e Include computer_name in VM instance facts (#62566) 2019-09-20 12:16:58 +08:00
153a322f54 Master (#62626)
* Update win_package.ps1

Update Test-Path to use -LiteralPath instead of -Path to fix issue where powershell will not detect path with special characters such as '=' and '[]'.

* Update win_package.ps1

modified other instances of -Path and changed to -LiteralPath.  All except line L243 since it is a different function.

* added literal path to get-itemproperty
2019-09-20 13:25:47 +10:00
2a206f0e4c update ce_bgp_af to fix bugs (#62589)
* update to fix bugs

* update to fix bugs
2019-09-19 22:34:11 -04:00
cee55ab718 mongodb_replicaset/test: properly kill the nodes
The `pids` module returns the list of the PID in a `pids` key.

This change ensures we correctly wait for the end of the previous mongod
instances before we start the next ones.

In addition, we remove an unnecessary `ignore_errors`.
2019-09-19 17:19:48 -04:00
85eba9d860 Fix test_galaxy failing test 2019-09-19 13:20:43 -07:00
7badeb6df0 [docs] split collections into user and dev guide sections (#62363)
* split collections into user and dev guide sections

* sentence case
2019-09-19 15:09:19 -05:00
6d35f9026f added networking porting guide info (#61999)
* added networking porting guide info

* Update docs/docsite/rst/porting_guides/porting_guide_2.9.rst

Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>

* implemented review comments
2019-09-19 14:29:15 -05:00
4116d263c4 Add missing gcp modules to gcp module defaults group (#57779)
* Add missing gcp modules to gcp module defaults group

Fixes #56324

* Add changelog fragment for #57779
2019-09-19 20:25:47 +01:00
4cc4c44dd0 Add a representer for AnsibleUnsafeBytes (#62598)
* Add a representer for AnsibleUnsafeBytes

* changelog

* Add unit tests

Remove native string test until we have time to evaluate how this the function should work
Add non-ASCII characters to test cases

* Compare to the string on Python 2

Add a comment in the test about this behavior
2019-09-19 14:27:48 -04:00
c8e220a62e vm change to support specialized (#62586) 2019-09-19 09:45:24 -07:00
9a43a8fcfc Display leftover messages when shutting down. (#62431) 2019-09-19 10:37:14 -04:00
7b3d8431dd postgresql: move CI tests of *_tablespace, *_membership, *_idx to separate targets (#62575)
* postgresql: move CI tests of *_tablespace, *_membership, *_idx to separate targets

* postgresql: move CI tests of *_tablespace, *_membership, *_idx to separate targets, change formatting
2019-09-19 14:57:45 +01:00
7047b66d34 Add examples for various inventory setups to the documentation (#62323)
* Add examples for various inventory setups to the documentation. This closes #12480.

* Update docs/docsite/rst/user_guide/intro_inventory.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/user_guide/intro_inventory.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update wording in inventory examples

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update wording in inventory examples

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Use code-block and rename groups in inventory setup examples

* Fix group name in inventory setup example

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-09-19 09:32:04 -04:00
95525030e2 enables to set keys not present in existing config (#61607) 2019-09-19 07:14:26 -04:00
875cc156c9 Remove notifications for joshsouza (#62443) 2019-09-19 11:53:36 +01:00
70a33c3140 nsupdate: Don't mention the Microsoft DNS server (#62330)
Microsoft's DNS server uses GSS-TSIG to secure Dynamic DNS
updates. That is a Kerberos based form of TSIG neither supported by
the Ansible nsupdate module nor the underlying dnspython module.

Related to #57294 and #62238.
2019-09-19 11:45:53 +01:00
ea73e0c43a Update BOTMETA.yml (#62482) 2019-09-19 11:40:14 +01:00
7541dab1ef update to fix a bug. (#62417) 2019-09-19 05:15:48 -04:00
558ce6575d modify vmss to support specialized (#62571) 2019-09-19 14:29:49 +08:00
35463d45f4 Fix traceback empty config error to meaningful msg for IOS (#62538)
* fix empty config msg

* fix space

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-19 10:13:36 +05:30
054519920e snapshot fix for backporting (#62559) 2019-09-19 11:42:08 +08:00
a684bb9f5b Ensure k8s apply works with check mode (#60572)
* Ensure k8s apply works with check mode

Update the new predicted object with fields from the previous object
before applying in check mode

Don't log output of `file` with `state: absent` on huge virtualenvs!

Fixes #60510

* Use openshift client fix to improve apply for check mode

Use new apply_object method to get a better approximation
of the expected object in check mode.

Requires released upgrade to openshift

* Add changelog fragment for k8s apply check mode fix

* Update changelogs/fragments/60510-k8s-apply-check-mode.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-09-19 05:30:31 +02:00
bebb11b918 Disable setting of -s in shebang
RPM builds on Fedora and RHEL create a python shebang line with -s

This is not good for ansible since ansible has a lot of optional
features which need extra dependencies installed.  If the user installs
those extra dependencies to their home directory or to /usr/local then
the -s will keep them from being used.
2019-09-18 20:27:56 -07:00
978def38d8 error message updated (#62536)
* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-09-19 08:34:31 +05:30
1c64dba3c9 Fix plugin names for collection plugins. (#60317)
* Fix plugin names for collection plugins.

Add an integration test to verify plugin __name__ is correct for collection plugins.

* Fix collection loader PEP 302 compliance.

The `find_module` function now returns `None` if the module cannot be found. Previously it would return `self` for modules which did not exist.

Returning a loader from `find_module` which cannot find the module will result in import errors on Python 2.x when using implicit relative imports.

* add changelog

* sanity/units/merge fixes
2019-09-18 17:47:56 -07:00
cbe8271745 update ce_static_route to fix bugs (#62498) 2019-09-18 20:31:44 -04:00
b7897e3a8d cron - Only run get_bin_path() once (#62554) 2019-09-18 19:04:26 -04:00
064e443ea5 psexec - Fix kerb and interactive support (#62556) 2019-09-19 08:41:02 +10:00
d0c7b42e58 fix collection jinja2 cache issue (#62543)
* prevents premature lookup (and potential KeyError) of Jinja filter/test function cache that's not fully populated
2019-09-18 14:39:59 -07:00
bad338aca6 win_exec_wrapper - Be more defensive when trying to get output errors (#62376)
* win_exec_wrapper - Be more defensive when trying to get output errors

* Fix up property search
2019-09-19 06:53:56 +10:00
bf5b6695ec Add hint for config option priority (#62463)
* Add hint for config option priority

* Fix some spelling issues
2019-09-18 16:36:08 -04:00
864928365e Improve dconf documentation to include conversion problems (#62316) 2019-09-18 16:04:44 -04:00
d16ee65ecd Add link to become plugins in become docs (#62462) 2019-09-18 15:53:16 -04:00
a4a216640f chore/doc-module: sts_assume_role.py (#62475)
Update `Example` section with with the correct module usage.
2019-09-18 15:50:34 -04:00
951a80c8b0 cron - Use the default crontab executable in cron and cronvar modules (#59765)
In some remote environments, the `crontab` executable is
overloaded with a custom executable, which typically does
some pre/post processing before forwarding to crontab.

Instead of using the hardcoded `/usr/bin/crontab`, this uses
the `get_bin_path` utility to locate the default crontab executable.
2019-09-18 15:35:06 -04:00
b24f7d2800 vyosnoconfig tracebackfix (#62518)
* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml
2019-09-18 21:58:39 +05:30
55f285a384 fix if equals error code if command not found (#62529) 2019-09-18 18:00:42 +02:00
2232232b45 fix delete to pass the right parameters (#62525) 2019-09-18 20:59:59 +05:30
cf8e84fc62 fix session_uid (#62523) 2019-09-18 20:38:31 +05:30
2e1c6a7839 Add fix for specifying current dir in collections_paths (#62478) 2019-09-18 08:04:22 -07:00
66e5427ffb cloudformation_info - fix KeyError (#62290)
* cloudformation_info - fix KeyError

* changelog
2019-09-18 09:58:58 -04:00
b87b359df5 postgresql: move CI tests of *_owner, *_info, *_ping, *_query to separate targets (#62500) 2019-09-18 14:22:13 +01:00
05ef39551a Remove unused variable from nxos module_utils (#62474)
This variable isn't used, remove it to make linters happy.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-18 09:11:47 -04:00
d5449eed11 tests: hcloud: Enable hcloud_floating_ip_info tests (#62494) 2019-09-18 13:55:05 +02:00
97b15e9f0c [stable-2.9] Stabilize nxos initiated copy for nxos_file_copy plugin (#62355)
* Retry spawn connection on failure

* Add debug logs

* Additional debug logs

* Close session before respawn attempt

* More debug info and increase loops

* Remove debug info and reset error dict on reconnect

* Add epdb debuger

* Add epdb debuger

* Add epdb debuger

* Wait before sending password and close pexpect session

* Fix comment typo

* Scrub error logs

* Scrub error logs

* Add more specific initial connect pattern

* Fix shippable errors

* Dont make remote_scp_server_password a hard requirement

* Add saftey check
2019-09-18 17:07:50 +05:30
fd7e156ccd Add hcloud_floating_ip module (#62409) 2019-09-18 11:26:53 +02:00
24ff3f257b fix azure_rm_rediscache notify notify_keyspace_events type (should be str) (#58922) 2019-09-18 17:01:28 +08:00
7d40f6d53e Remove obsolete MANIFEST.in entries. 2019-09-17 21:49:05 -07:00
e51fa5c972 luks_device: ansibot wasn't able to extract author (#62464)
Ansibullbot ignores lines without 'author' or dash [1].

The following command allows to check that no other module is impacted:

    rgrep -A1 -P "^author:[[:space:]]*$" lib/ansible/modules/ |grep -P "\.py-[[:space:]]*[^-][[:space:]A-Za-z\"'@()]+$" -B1

Related: https://github.com/ansible/ansibullbot/issues/1106.

[1] 02ae638641/ansibullbot/utils/moduletools.py (L828)
2019-09-18 00:32:24 -04:00
2d85cb3ded Update ce_info_center_global to fix bugs (#61283)
* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs
2019-09-18 00:15:14 -04:00
9bf0e69601 Update ce_bgp_neighbor to fix bugs (#60634) 2019-09-18 00:05:56 -04:00
8233389446 Update ce_netstream_export to fix bugs (#61652)
* Update ce_netstream_export to fix bugs

* Update ce_netstream_export to fix bugs
2019-09-17 23:56:15 -04:00
80fa2a0816 Update ce_netstream_aging to fix bugs (#61653)
* Update ce_netstream_aging to fix bugs

* Update ce_netstream_aging to fix bugs
2019-09-17 23:56:09 -04:00
027cd16b1a Update ce_snmp_target_host to fix bugs (#61842) 2019-09-17 23:20:58 -04:00
a260209098 Update ce_bgp_neighbor_af to fix bugs (#60937)
* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs
2019-09-17 23:02:36 -04:00
3cde0b5693 Update ce_evpn_global to fix bugs (#61013) 2019-09-17 22:52:32 -04:00
80ead00838 Update ce_mtu to fix bugs (#61442) 2019-09-17 22:52:16 -04:00
12512f7319 Update ce_vxlan_arp to fix bugs (#61995)
* Update ce_vxlan_arp to fix bugs

* Update ce_vxlan_arp to fix bugs
2019-09-17 22:52:11 -04:00
e559fafbc4 Update ce_vxlan_vap to fix bugs (#61996) 2019-09-17 22:52:04 -04:00
90958b01c1 Update ce_evpn_bgp to fix bugs (#61136) 2019-09-17 22:08:27 -04:00
1a8c1c7365 Update ce_evpn_bgp_rr to fix bugs (#61168) 2019-09-17 22:08:12 -04:00
8eec5d2ab2 Update ce_interface_ospf to fix bugs (#61431) 2019-09-17 22:07:48 -04:00
698e3eae5e Update ce_ntp to fix bugs (#61654) 2019-09-17 21:56:51 -04:00
9d9863fec1 Update ce_ospf to fix bugs (#61684) 2019-09-17 21:56:44 -04:00
e1ca38e53a Update ce_snmp_traps to fix bugs (#61843) 2019-09-17 21:56:30 -04:00
5f35916b22 update ce_bgp to fix bugs (#60573)
* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* Update ce_bgp to fix bugs
2019-09-17 21:46:34 -04:00
db0f290ca3 Update ce_vrf_af to fix bugs (#61683) 2019-09-17 21:45:18 -04:00
466c3e63ce Update ce_stp to fix bugs (#61774) 2019-09-17 21:45:06 -04:00
b2d145d924 ce_mlag_interface:update to fix a bug (#60144)
* update to fix a bug

* ansible-test Ignoring 'blacklisted-name' on 'lib/ansible/modules/network/cloudengine/ce_mlag_interface.py' is unnecessary

* update

* update

* update for shippable

* update for shippable

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py
2019-09-17 21:24:34 -04:00
acd459f909 Add missing changelog fragments. (#62471)
* Add missing default-test-container 1.9.2 fragment.
* Add missing default-test-container 1.9.3 fragment.
2019-09-17 17:33:58 -07:00
3b86dc3e12 WIP - Fix ansible-doc bugs and add integration tests. (#62461)
* Add integration tests for ansible-doc.

* Enable tests that now pass

* Cleanup processing of plugin docs

* Mostly separate the steps of processing plugin docs

  1) Acquire source data
  2) Transform and calculate additonal data
  3) Format data for output
  4) Output data

  format_plugin_doc() is still mixing transformation and formatting but
  that should be fixed in a devel-only change

* Raise exceptions in _get_plugin_doc() on errors.

* Remove check to exclude on blacklisted extensions.  We already request
  only .py files

* If there is no DOCUMENTATION entry in the plugin, raise an exception
  from _get_plugin_doc().  Everywhere we use _get_plugin_doc(), this is
  treated as an error

* If there is no ANSIBLE_METADATA raise an exception as well as
  displaying of docs assumes that this has been set.

* If there is neither DOCUMENTATION nor ANSIBLE_METADATA, warn about the
  lack of METADATA and error on the lack of DOCUMENTATION.  Lack of
  DOCUMENTATION is more important so it is what the user should see.

* Add a few special cases for backwards compat.  These should probably
  be made errors in 2.10:
  * no docs but has metadata shows no documentation rather than an error
  * empty plugin file shows no doumentation rather than an error

* Simplify backwards compatibility logic.
2019-09-17 15:45:30 -07:00
b68f5b406a test: bump default-test-container
VMware VSphere SDK needs an up to date version of `pip` for the
installation step. With the current image, we face the following error:

```
(...)
02:27 Collecting git+https://github.com/vmware/vsphere-automation-sdk-python.git (from -r /root/ansible/test/lib/ansible_test/_data/requirements/integration.cloud.vcenter.txt (line 2))
02:27   Cloning https://github.com/vmware/vsphere-automation-sdk-python.git to /tmp/pip-req-build-pm27t16b
02:33 Requirement already satisfied: pyvmomi in /usr/local/lib/python3.6/dist-packages (from -r /root/ansible/test/lib/ansible_test/_data/requirements/integration.cloud.vcenter.txt (line 1)) (6.7.1.2018.12)
02:33 Requirement already satisfied: lxml>=4.3.0 in /usr/local/lib/python3.6/dist-packages (from vSphere-Automation-SDK==1.4.0->-r /root/ansible/test/lib/ansible_test/_data/requirements/integration.cloud.vcenter.txt (line 2)) (4.4.0)
02:33 Processing ./\\localhost/tmp/pip-req-build-pm27t16b/lib/vapi-runtime/vapi_runtime-2.12.0-py2.py3-none-any.whl
02:33 Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: '/root/ansible/\\\\localhost/tmp/pip-req-build-pm27t16b/lib/vapi-runtime/vapi_runtime-2.12.0-py2.py3-none-any.whl'
```

Bump default-test-container to 1.9.3 to get an up to date release of
`pip` (was 19.0.2, is now 19.2.3).
2019-09-17 17:35:57 -04:00
d3ec5ca80f Update pip module docs (#62359)
* Clarifying pip module requirements in reference to #47361

* Further clarifying message with link to ansible_python_interpreter

* Clarifies pip behavior

* incorporates review feedback
2019-09-17 16:30:51 -04:00
459677877a hcloud_networ_info: be more resilient is network already exists
We may already have an existing network or subnet. This commit ensures
we don't raise an error in this case.
e.g: https://app.shippable.com/github/ansible/ansible/runs/143559/145/tests
2019-09-17 16:20:38 -04:00
9f7b124a6f Mark ansible-test cloud credentials as sensitive. 2019-09-17 13:08:14 -07:00
23c7bf6481 Fix access to exception using Python 3 scoping rules (#62268) 2019-09-17 13:28:37 -04:00
edf15b346f test: disable hcloud_floating_ip_info
Temporarily disable `hcloud_floating_ip_info`, this until #62414 is
resolved.
2019-09-17 13:19:40 -04:00
9addad0f4a fix ios_lldp_global (#62420) 2019-09-17 22:11:20 +05:30
f11429a80d fix typos in network modules (#62320)
* fix typos in network modules
2019-09-17 11:01:28 -05:00
aa673400da Update OpenNebula modules maintainers (#62281) 2019-09-17 10:52:03 -05:00
f9e7af4413 BOTMETA: Enable automerge (#62410)
It's been over 7 days since devel because 2.10 and automerge was disabled, therefore `version_added` should be correct for any current PRs.

Follow on from https://github.com/ansible/ansible/pull/61674
2019-09-17 16:28:46 +01:00
ea6e96985a Remove leading space in warning messages (#62002)
ci_complete
2019-09-17 10:16:00 -05:00
32fbde67f7 BOTMETA.yml: update for plugins/netconf/ce.py (#62000)
* update for plugin/netconf/ce.py

* update for plugin/netconf/ce.py

* update
2019-09-17 10:14:27 -05:00
0631e057e9 Redact sensitive values by default in ansible-test 2019-09-17 08:09:17 -07:00
84d9b3e589 Fix "JSON object must be str, bytes or bytearray, not list" (#62350) 2019-09-17 10:00:19 -04:00
5cd3be9129 gather_facts action plugin: Fix loading network facts modules for smart gathering (#59856)
* fix smart gathering for network_os in gather_facts action plugin

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Fix detection of network_os for smart gathering

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* make pep8 happy

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-09-17 18:35:44 +05:30
74e4993628 Fix network_cli exec_command connection init (#62344)
* Fix network_cli exec_command connection init

Fixes https://github.com/ansible/ansible/issues/61596

*  If `exec_command` method is invoked from module side
   on connection object to execute the command on target
   host check if connection is created if not create the
   connection.

* Fix review comment
2019-09-17 09:00:54 -04:00
7a5a5e7c87 Fix traceback error in IOS and IOSXR when ran without config (#62400)
* fixes issue 61321

* complete iosxr

* fix ios_vlans

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-17 18:24:50 +05:30
c1126afbfb ce_bgp_neighbor_af: fix a typo in module's parameter (#62403)
* ce_bgp_neighbor_af: fix a typo in module's parameter

* ce_bgp_neighbor_af: fix a typo in module's parameter, add version_added and changelog

* ce_bgp_neighbor_af: fix a typo in module's parameter, add aliase
2019-09-17 13:34:07 +01:00
98415dec86 postgresql_copy: move ci tests to a separate target (#62398) 2019-09-17 13:32:45 +01:00
b0668e17ed nxos_telemetry replaced state (#62368) 2019-09-17 16:49:30 +05:30
d8d3790d6a Bump acme-test-container version. (#62381) 2019-09-17 13:06:33 +02:00
a6857d6359 postgresql_table: add reference to postgresql_idx in seealso (#62387) 2019-09-17 11:55:48 +01:00
f9fd1f3626 To fix ios_l3_interfaces resource module round trip failure (#61642)
* fix 61396

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* add ios_l3_interfaces rtt tests

* remove unnecessary config

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* change test description

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* remove rtt and move to new PR
2019-09-17 13:40:32 +05:30
037401b6e0 fix plugins/netconf/ce.py for netconf/capability/exchange (#60569) 2019-09-17 08:00:55 +02:00
8bc397c229 Bug fixes to the Infoblox NIOS modules (#58521)
* Update nios_ptr_record to fix bug #58378

* Update to api.py to fix bug #58378 and #56856

* Update test_nios_ptr_record.py to fix bug #58378

* Update nios_ptr_record_idempotence.yml to fix bug #58378

*  Update test_nios_ptr_record.py to fix bug ansible#58378
2019-09-17 09:45:50 +05:30
b73e7721df Mark AWS credentials in ansible-test as sensitive.
This avoids displaying the credentials in CI when retrying tests at maximum verbosity.
2019-09-16 20:21:23 -07:00
6d8743d5f1 test: temp disable azure_rm_azurefirewall
Disabled `azure_rm_azurefirewall` until #62307 is fixed.
2019-09-16 21:24:30 -04:00
3e4d5aeee3 [WIP] VMware: Fix fragile sort order in vmware_vcenter_statistics (#62288)
* vmware_vcenter_statistics: Fix fragile sort order

* vmware_vcenter_statistics: Python 2.6 compatibility
2019-09-16 14:50:39 -07:00
a8dddff5ec Use to_native for error messages, fix docs typo 2019-09-16 12:11:41 -07:00
d4738596ce test: cleanup sanity/ignore.txt to avoid A100
See: https://app.shippable.com/github/ansible/ansible/runs/143332/5/console
```
21:30 ERROR: Found 1 validate-modules issue(s) which need to be resolved:
21:30 ERROR: test/sanity/ignore.txt:1608:1: A100: Ignoring 'option-incorrect-version-added' on 'lib/ansible/modules/cloud/openstack/os_keystone_endpoint.py' is unnecessary (75%)
21:30 See documentation for help: https://docs.ansible.com/ansible/devel/dev_guide/testing/sanity/validate-modules.html
21:30 ERROR: The 1 sanity test(s) listed below (out of 1) failed.
```
2019-09-16 12:10:14 -07:00
119acc1afe Remove unused variable for junos_user (#62311)
This isn't used any place, lets remove it to fix lint checks on our
network collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-16 14:06:11 -04:00
b1afb37ac9 Add implicit localhost hostvars note (#61956) 2019-09-16 14:00:29 -04:00
7a36606574 fixed build error for docs (#62356) 2019-09-16 12:21:06 -05:00
31fe1d1daf BOTMETA: add the vmware_httpapi team
Add the new `vmware_httpapi` for the new modules based on
`module_utils/vmware_httpapi`.

The `vmware_httpapi` label does not exist yet.
2019-09-16 12:17:54 -04:00
448a8c4e5f Fix os_keystone_endpoint endpoint_interface docs (#62283)
The os_keystone_endpoint module has two interface arguments -
'interface' for authentication, and 'endpoint_interface' for the
endpoint being registered. Currently the module documentation only
covers 'interface', when in fact it should cover 'endpoint_interface'
and pick up 'interface' from the standard OpenStack module parameter
documentation.
2019-09-16 11:02:43 -05:00
ac56d35e19 Fix azure_rm_virtualmachinescalesetinstance_info doc error (#62335)
* update azure_rm_virtualmachinescalesetinstance doc to use correct module name in examples
2019-09-16 10:54:20 -05:00
f44bfccb56 fix typos in storage modules (#62333) 2019-09-16 10:12:15 -05:00
b4dcd7c835 Network and address range tests (#62338)
* commit network and address_range

* remove test_cp_mgmt_network from ignore.txt
2019-09-16 11:03:03 +02:00
6bb8861b0e unique tests (#62328) 2019-09-16 11:00:28 +02:00
47cf4e6565 Commands tests (#62322)
* commands tests

* add space in order to delete it and tun shipable tests again

* delete space in order to run shipable tests again
2019-09-16 13:51:21 +05:30
ebdf78d6e4 Forth pr 18 tests (#62216)
* Update test_cp_mgmt_network.py

* 18 tests
2019-09-16 13:32:27 +05:30
a9a5f4e40d Change enable to enabled for junos_interfaces module (#62321)
Fixes #62319

Change `enable` option to `enabled` in junos_interfaces
and junos_lldp_interfaces
data model to be in sync with other network platform
resource modules added in 2.9 version.
2019-09-16 12:17:27 +05:30
4de3e2b440 Fix typos in remote_management modules (#62336) 2019-09-16 12:07:25 +05:30
74a3eec1d9 win_format - Idem not working if file exist but same fs (#59819)
* win_format - Idem not working if file exist but same fs

* Test fix

* Fix test assertion syntax

* Update tests.yml
2019-09-15 22:45:44 -04:00
c7662d8b2f correct behaviour of win_iis_webapplication when no applicationpool is specified (#61227)
* correct behaviour of win_iis_webapplication when no applicationpool is specified

* documentation for win_iis_webapplication apppool change
2019-09-15 22:27:18 -04:00
99796dfa87 win_find - Fix deduped files mistaken for directories (#58680)
* win_find - Fix deduped files mistaken for directories

* Update win_find.ps1

* Update win_find.py

* Update win_find.ps1
2019-09-15 20:02:05 -04:00
8def67939d Support large folder size comparisons for win_find (#58466)
* Support large folder size comparisons for win_find

Changed [int] to [int64] to support larger folders. Otherwise module fails as soon as a large folder is encountered.

* Create 58466-FIX_win_find-Bug-Get-FileStat_fails_on_large_files.yml
2019-09-15 19:04:59 -04:00
d361ff4122 Fix check mode support in win_group (#61977)
* Fix check mode support in win_group

* Fix copy/paste error
2019-09-16 06:45:43 +10:00
a0bec0bc32 Remove deprecated letsencrypt alias of acme_certificate (#61648) 2019-09-14 23:24:32 +02:00
14bccef2c2 Add ecs_domain module (#62007)
* Add ecs_domain module

* Fixes to integration tests and module

* Fixes to tests and module

* Corrections to revalidation behavior, cna only revalidate domains in expiring.

* Remove debugs for final test run, fix sanity check test fails.

* Add checks for domain status

* Add changelog fragment for new module.

* Removed extra space in backtick

* Minor fixes to make behavior more consistent and correct documentation.

* Update lib/ansible/modules/crypto/entrust/ecs_domain.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/crypto/entrust/ecs_domain.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/crypto/entrust/ecs_domain.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Change casing of verification method enum, remove redundant changelog fragment

* Return ov_eligible and ev_eligible fields even if false, as long as they're returned by ECS API
2019-09-14 19:33:48 +02:00
32d965e2c6 Fix display of sanity test doc links.
The documentation links are now displayed when running from an install.

Previously the links were only displayed when running from source.
This was due to ansible-test checking for the presence of documentation files locally, which are only present when running from source.
The check is no longer necessary since there is a sanity test in place to enforce the presence of documentation for all sanity tests.
2019-09-13 22:24:14 -07:00
3a5c68205c Third pr 18 tests (#62215)
* Update test_cp_mgmt_network.py

* 18 tests
2019-09-14 09:39:21 +05:30
271825cfaf Add unit tests for check_point ansible modules (#62214)
* Update test_cp_mgmt_network.py

* 18 tests
2019-09-14 09:38:06 +05:30
2421ad3e87 azure: re-balance tests to avoid timeout
- azure_rm_azurefirewall currently takes more than 25m to run: #62307
- azure_rm_manageddisk takes around 2 minutes
2019-09-13 18:19:01 -04:00
f6a51b3f07 revert back to contiguous (#62301) 2019-09-13 15:25:32 -05:00
d933278f3d Add version 2.14 to the removed_in list (#62298)
devel is now 2.10, so this needs to be bumped as well.
2019-09-13 14:32:11 -05:00
05ded87848 Add httpapi VMware REST VmwareRestModule (#60914)
* Initial commit of VMware HttpApi REST

New directory structure created for httpapi-based modules. These will
live in the 'vmware_httpapi' directory under 'modules/cloud'.  The
AnsibleModule class was extended to create the VmwareRestModule class
that lives in the 'vmware_httpapi' directory under 'module_utils'. It
implements comms with the httpapi plugin, and also provides debugging
output, url and filtering generation by object, and support for
multiple VMware REST APIs. It also provides dynamic handling of HTTP
return codes that can be tailored to each module's needs.
2019-09-13 14:34:11 -04:00
5be0668fb0 Ensure we don't erase unsafe context in TaskExecutor.run on bytes (#62287)
* Ensure we don't erase unsafe context in TaskExecutor.run on bytes. Fixes #62237

* Remove unused import

* Add missing import

* use args splatting for to_unsafe_text/bytes

* Add security issue to changelog

* fix yaml linting issue
2019-09-13 13:14:35 -05:00
7d51cac330 Don't treat no checksum as a checksum match (#62146)
Fixes #61978
* moar tests for get_url fetch behavior with existing file
* add changelog fragment
2019-09-13 13:24:15 -04:00
08279c7d54 Update default test container with Python 3.8b4 (#62100) 2019-09-13 12:38:47 -04:00
098a13dff4 Re-enable some docker_swarm tests. (#61875) 2019-09-13 12:08:45 -04:00
7917d4def7 Standardize eos resource modules (#61736)
* Fix eos_l3_interfaces case sensitivity

* Unify EOS module notes

* Add normalize_interfaces to eos_l2_interfaces

* Pull normalize_interface into eos_interfaces

* Add normalize_interface to lag_interfaces

* Add normalize_interface to lldp_interfaces

* Add normalize_interface to lacp_interfaces

* more module cleanup

* Add changelog
2019-09-13 09:35:50 -04:00
200ed25648 Fix for junos cli_config replace option (#62131)
* Fix for junos cli_config replace option

*  For device that support replace option by loading
   configuration from a file on device `config` option
   is not required and value of `replace` option is the
   path of configuration file on device. This fix allows
   invoking run() function in cli_config if `config` option
   is None and `replace` option is not boolean

*  The command to replace running config on junos device
   is `load override <filename>` and not `load replace <filename>`
   This is fixed in the junos cliconf plugin.

* Add integration test
2019-09-13 18:52:33 +05:30
2d19150757 Update mitogen link (#62247) 2019-09-13 09:20:19 -04:00
efdf52a254 remove undefined YAML anchor (#62273) 2019-09-13 08:50:42 -04:00
c7f9c3f27e Add unit tests for check_point ansible modules (#62213)
* Update test_cp_mgmt_network.py

* 17 tests
2019-09-13 13:54:29 +02:00
c226c1015e Update junos_user.py (#60459) 2019-09-13 15:49:06 +05:30
e33700c5e2 Update BOTMETA.yml (#62123) 2019-09-13 07:36:15 +01:00
991b865cb6 Update junos_config.py (#62221)
Add the commands alias to match UX of IOS, EOS etc.
2019-09-13 11:04:36 +05:30
1c3effe92e VMware: Change return key results from VMware modules (#62161)
Following module used internal results key as part of return json, this commit
changes this to appropriate values -
* vmware_datastore_maintenancemode.py
* vmware_host_kernel_manager.py
* vmware_host_ntp.py
* vmware_host_service_manager.py
* vmware_tag.py

Fixes: #62083

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-13 09:57:04 +05:30
041c52d629 Add info about layering properties 2019-09-12 18:55:13 -07:00
5deb01c84d Remove suggestion to go caving 2019-09-12 18:55:13 -07:00
9b348e690c Improve documentation on doc fragments
Add information and examples on how to use additional properites from a doc fragment
2019-09-12 18:55:13 -07:00
46ffcd6c44 ansible-galaxy - add config to control the display wheel (#61902)
* ansible-galaxy - add config to control the display wheel

* Fix changelog and make test more stable

* Don't use display thread at all if progress wheel isn't being shown
2019-09-13 11:06:18 +10:00
b010acfb27 nxos_bfd_global - add missing import of re (#62226) 2019-09-13 07:37:30 +10:00
c324503f5a Updating link for guest_id info (#61988) 2019-09-12 15:19:36 -05:00
09f1c286e0 Add some details to any_errors_fatal documentation (#62029) 2019-09-12 16:15:02 -04:00
0e72cbd451 openssh_keypair file permissions/ownership: add porting guide entry (#62176)
* Add porting guide entry for 2.9.
2019-09-12 15:05:01 -05:00
c1773d5d2b document suboptions for type:list options too (#62177) 2019-09-12 16:00:06 -04:00
740ec90688 sanity ignores for a collection need to go to tests/sanity/ (#62182)
collections use tests/ not test/ as the folder for tests
2019-09-12 15:55:19 -04:00
48a39f5616 typo: missing-subption-docs → missing-suboption-docs (#62180)
updates the name of the test and all ignore.txt entries
2019-09-12 14:51:20 -05:00
dc7a765e57 fix fact caching plugin name from json to jsonfile (#62198) 2019-09-12 15:45:43 -04:00
a2e61f67d5 core: Handle empty extra vars in cli (#61831)
Fixes: #61497

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-12 15:43:41 -04:00
a6ec6c3175 Fixes #56832: Remove warning when falling back to apt-get if aptitude is missing. (#61782) 2019-09-12 15:29:36 -04:00
606e13919e Always specify header of connection keep-alive regardless of python v… (#62218)
* Always specify header of connection keep-alive regardless of python version.

* Add chgangelog fragment

* Fixes to changelog fragment
2019-09-12 21:05:23 +02:00
6952295114 explicited RouterOS does not support connection: local (#62203) 2019-09-12 13:45:28 -04:00
46f633598e Add guidelines for when to use a doc_fragment (#61828) 2019-09-12 12:55:50 -04:00
c0f3777fe2 nxos_l2_interfaces: fix for integration tests failing to setup layer2 (#61887) 2019-09-12 21:46:52 +05:30
c4894b512d [stable-2.9] fix nxos_config tests for httpapi (#62082)
* fix nxos_config tests for httpapi

* Remove become parameter
2019-09-12 21:46:00 +05:30
f582d74f7c Fix bfd cmd order and test issues (#61943) 2019-09-12 21:45:37 +05:30
6e72893d78 nxos_lacp_interfaces: fix integration test dependencies (#61947)
* nxos_lacp_interfaces: fix integration test dependencies

* Add conditional mode test to m/d/r tests
2019-09-12 21:45:04 +05:30
621f273767 Revert "svc: fix a typo (#62174)" (#62212)
This reverts commit d838a9021a.

was not a typo, 'ed' is added later on and 'stop' goes to 'stopped'
2019-09-12 11:19:05 -04:00
c3c54302af Don't fail if exos can't configure cli columns (#51364)
* Don't fail if exos can't configure cli columns

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
2019-09-12 11:12:44 -04:00
6691527799 fix typos in commands modules (#62197) 2019-09-12 09:54:45 -05:00
742eebc92c fix typos in identity modules (#62200) 2019-09-12 09:54:15 -05:00
655f771547 fix typos in web_infrastructure modules (#62202) 2019-09-12 09:53:05 -05:00
d838a9021a svc: fix a typo (#62174) 2019-09-12 10:32:52 -04:00
c170ab5e31 Add exception handling when retrieving k8s client (#60726) 2019-09-12 15:02:52 +01:00
7e91998049 fix typos in cloud modules (#62194)
* fix typos in cloud modules

* fix typos in cloud modules, fix ci tests
2019-09-13 00:01:14 +10:00
3dbf89e8ae added version support to aws_ssm lookup (#61045) 2019-09-12 14:49:09 +01:00
6936187bbe fix typos in net_tools_modules (#62201) 2019-09-12 14:47:17 +01:00
dee529dc66 fix typos in clustering modules (#62196) 2019-09-12 23:45:34 +10:00
a72ea8440a elasticache_info: fix a typo (#62204) 2019-09-12 23:44:53 +10:00
f1766457a2 Handle cases where normal commit operation throws a prompt (#62132)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-12 16:25:56 +05:30
4e6270750a Set no_log to True for junos_user encrypted_password (#62184)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-12 12:38:40 +02:00
cd4882e229 Fix ansible-test vcenter test filtering.
The default behavior of the ansible-test vcenter plugin is to use the govcsim container to run tests.

However, unless the govcsim mode was specified using the VMWARE_TEST_PLATFORM environment variable, the filter code would skip the tests unless the tests ran on Shippable or the user had an ansible-core-ci key.

Now the filter correctly recognizes that govcsim is the default.
2019-09-12 02:13:57 -07:00
cdc4926340 Fix ansible-test collections requirements installation. (#62181)
* Fix location of unit test requirements.

* Preserve ansible-test unit test requirements.

* Remove redundant unit test requirements.

* Fix location of network test requirements.

* Preserve ansible-test network test requirements.

* Remove redundant network test requirements.

* Add missing ordereddict requirements.

* Load collection requirements correctly.

* Add changelog fragment.
2019-09-12 02:00:33 -07:00
4393940a41 Docs formatting: recursively preprocess suboptions (#61900)
* Simplify code, move option massaging code into own function.
* Process suboptions recursively.
2019-09-11 19:08:52 -05:00
6c78f02121 Add missing changelog entry for ansible-test fix.
PR https://github.com/ansible/ansible/pull/62119 was missing a changelog entry.
2019-09-11 13:03:36 -07:00
1dac0df7e5 Remove deleted file from sanity ignore list. 2019-09-11 12:54:32 -07:00
8b42de29fa hall: remove the module for supporting nonexistent messenger (#62152) 2019-09-11 20:33:03 +01:00
5b3526535c luks_device.py: allows user explicity define luks format version (#61812)
* luks_device.py: allow the user create LUKS based on specific versions

- Allow user pass an option 'type' that explicits define the version of LUKS
  container that will be created. It should be 'luks1' or 'luks2' format.
- If 'label' option is defined the 'type' option will be 'luks2' independently
  of the option 'type' informed by user. (labels NEED luks2 format)

Fixes: #58973
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

* added the changelog fragment

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

* luks_device.py: make it fail in certain conditions

- Not allow user especify luks1 type and label at the same playbook

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-09-11 20:45:33 +02:00
5eb5f74083 fix typos in modules (#62135) 2019-09-11 13:40:22 -05:00
1b2fd2cb5f rabbitmq_publish fix for incorrectly stating message was not published to the queue (#61960)
* Pika v1.0.0 and above were causing issues for publish_message.  Updated
to ensure publish_message works with pika 0.13.1 and 1.0.0 and above.

* Adding changelog fragment for rabbitmq_publish fix.

* Updating return value.
2019-09-11 20:29:05 +02:00
2064fc3fc5 Added AWS SAML Federation Module (#55821)
* Added AWS SAML Federation Module

* iam_saml_federation: (integration tests) initial integration tests
2019-09-11 10:00:05 -07:00
a999f07010 Allow tower inventory plugin to accept integer inventory_id (#61338) 2019-09-11 11:48:38 -04:00
179eb623d7 docs: avoid confusing double negation (#62143)
Avoid "no backward incompatible interface" term which uses a double
negation and replaces it with easier "backward compatible interface"
contruct.
2019-09-11 11:26:22 -04:00
c0ea9f021b Added zabbix module zabbix_user (#56815)
This pull request adds a module to manage Zabbix users.
Tested with Zabbix Server(3.0, 4.0, 4.2).
2019-09-11 11:07:07 -04:00
9d67bfa31b Added zabbix module zabbix_user_info
[update] Fix zabbix_user_info module to use missing_required_lib helper and add zabbix logout processing.

Fixed the following issue.

* https://github.com/ansible/ansible/pull/58002
* https://github.com/ansible/ansible/issues/58459

change version_added 2.9 to 2.10
2019-09-11 10:48:36 -04:00
a9d4415657 Several enhancements for Radware modules and their unit testing (#61467)
* Adding support for Plugin runnable type
Adding support for device arrays in vdirect_runnable module.
Adding "output" dictionary to the vdirect_runnable module result dictionary.

* Adding support for Plugin runnable type
Adding support for device arrays in vdirect_runnable module.
Adding "output" dictionary to the vdirect_runnable module result dictionary.
2019-09-11 10:42:26 -04:00
fa03f438e7 routeros_facts: fix for error when there's more than 10 interfaces (#61376)
* fix: proper regex for preprocessing routeros output

* test: regression test

* test: fix nondeterministic unit test
2019-09-11 19:42:07 +05:30
c5a4086ed7 Add proper hostname cleanup for nxos tests (#61810) 2019-09-11 19:40:14 +05:30
b03091213d Call get_capabilities to initiate device connection (#62103) 2019-09-11 19:38:54 +05:30
b7ab8f9411 Clean up more linting errors for nxos modules (#62069)
This removes a few unused variables and duplicate functions being
defined.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-11 09:35:09 -04:00
7173267095 Fix test_cp_mgmt flake8 issues (#62129)
This commit deletes unused imports for the check_point cp_mgmt tests.
2019-09-11 08:53:44 -04:00
f79d03d292 Elaborate on note that docker-priv only works with integration (#62035) 2019-09-11 08:20:49 -04:00
bcc3620182 Fix typos in database modules and their integration tests (#62125) 2019-09-11 08:19:25 -04:00
b9a70aa76a New module: zabbix_valuemap (#60132)
* Adding zabbix_valuemap module

* Minor corrections

* Fixing typos

Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>

* Sorting mappings based on the 'value' field

* Updating

Co-Authored-By: John R Barker <john@johnrbarker.com>

* Fixing "version_added"
2019-09-11 12:17:32 +01:00
3a05955ec8 fix regex in plugins/terminal/iosxr.py (#54817)
Fixes situations where iosxr terminals that do not contain new line "/r/n" at the beginning of CLI timeouts due to regex error. Just make "/r/n" optional including "*" character in the regex
2019-09-11 14:35:15 +05:30
aaa6d2ecb0 Fix ansible-test pytest plugin loading. (#62119)
* Avoid assertion rewriting in pytest plugins.

Adding PYTEST_DONT_REWRITE to the ansible-test pytest plugin docstrings disables assertion rewriting in pytest for those plugins.

This avoids warnings during test execution if the plugins are loaded multiple times (such as being imported within tests).

* Run ansible-test pytest plugins early.

The ansible-test pytest plugins need to load and run earlier than conftest modules.

To facilitate this, the pytest_configure function is run during loading, which works since they are loaded (but not always run) before conftest modules are loaded.

A check has also been added to the pytest_configure functions to prevent them from running multiple times in the same process.

* Load pytest plugins using an env var.

The -p command line option loads plugins before conftest, but only during collection.
The PYTEST_PLUGINS environment variable loads plugins before confest, both during collection and test execution.
2019-09-10 23:27:05 -07:00
9b149917a6 lookup_rabbitmq pika > 1.0.0 is_closing bug fix (#61959)
* In pika v1.0.0 BlockingChannel.is_closing was removed.  Updating
plugin accordingly.

Ref: https://github.com/pika/pika/pull/1034

* Adding change fragment for is_closing bug.

* Updated change fragment description.
2019-09-11 08:23:27 +02:00
ff53ca76b8 Return commands key instead of xml in result for junos rm (#62041)
Fixes https://github.com/ansible/ansible/issues/61773

*  Change `xml` key name to `commands` key to be in sync with
   other platform resource modules.
2019-09-11 11:06:08 +05:30
6fb1d56fdc Fix ansible-test coverage --all (#62115) 2019-09-11 15:12:38 +10:00
53aa258d78 hostname: Use hostnamectl for Systemd strategy (#59974)
Use hostnamectl command to get current hostname for host while using
systemd strategy.

Fixes: #59438

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-11 10:27:17 +05:30
b0fd1043e1 hostname: Add support for Astra Linux Common Edition (#59607)
Add support Astra Linux Common Edition in hostname module
2019-09-11 08:13:39 +05:30
a7bc11ce67 Work around virtualenv/venv issue in ansible-test. (#62111)
Creating a virtual environment using `venv` when running in a virtual environment created by `virtualenv` results in a copy of the original virtual environment instead of creation of a new one.

To work around this, `ansible-test` now identifies when it is running in a `virtualenv` created virtual environment and uses the real Python interpreter to create the `venv` virtual environment.
2019-09-10 19:27:12 -07:00
cd8161a948 hostname: Add support for Kylin linux (#62053)
* Add support for Kylin linux to hostname module
2019-09-11 07:24:57 +05:30
414d844ed2 AWS ec2_vpc_net: Enable ipv6 CIDR assignment (#60983)
* AWS ec2_vpc_net: Enable ipv6 CIDR assignment

Enable IPv6 CIDRs in ec2_vpc_net, and fix ec2_vpc_subnet tests that
were depending on the aws cli for CIDR assignment.

Related to: #27800
2019-09-10 19:25:36 -04:00
983f0ad5a0 Properly exclude tests/output/ from code coverage. 2019-09-10 15:50:22 -07:00
f110abb806 Fix ansible-test to ignore tests/output/. (#62084)
The `test/results/` directory for Ansible test output was already ignored when not using git.

When Ansible Collections were switched to `tests/output/` the ignore entry was previously overlooked.
2019-09-10 15:49:40 -07:00
0f52b18f3f bump hcloud version to 1.4.1 (#62097)
* bump hcloud version to 1.4.1

`hcloud`<=1.4.0 has requirement `requests==2.20.0`. This prevents the
installation of the Vcenter Automation SDK which depends on `requests>=2.22.0`.

`hcloud` 1.4.1 does not have the problem: 8bff356efb
Bumping the dependency will resolve the issue.
2019-09-10 16:49:23 -04:00
72023d7462 mount: Check if src exists before mounted (#61752)
Fixes: #59183

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-10 21:42:10 +05:30
a3e9d14702 Update ovirt_vm.py (#62072)
Typo fix: "IDE" is not an acceptable choice for disk type, "ide" is a valid choice
2019-09-10 10:42:06 -05:00
7a79c12e52 Update my handle (#61966) 2019-09-10 10:06:32 -05:00
e589e22b7e mysql_info: fix typo (#62067) 2019-09-10 09:10:35 -05:00
8b24fe1f0a postgresql: fix typos in modules (#62065) 2019-09-10 09:08:29 -05:00
76b5b90bd6 issue #61672: make jenkins_plugin module work in a session when CSRF … (#61673)
* issue #61672: make jenkins_plugin module work in a session when CSRF enabled

This commit modifies the signature of `fetch_url` so that a cookie jar can be
specified allowing multiple calls to operate with the same session.  It uses
a similar construct to the `Request` class to initialise the cookie jar if
it is not provided.

The jenkins_plugin module is modified to create a cookie jar if CSRF is
enabled.  This cookie jar is then submitted with every call to fetch_url.
Also changed is to submit the crumb in the request headers rather than
in the data field.

This has been tested with Jenkins 2.176.

* issue #61672: fix jenkins_script module

This commit modifies the jenkins_script module to use the authorization crumb
in a session in a similar fashion to the jenkins_plugin change for the same
issue.
2019-09-10 09:44:37 -04:00
dfc023209f fix(azure_rm_containerregistry): Fixed sku idempostency (#61009) 2019-09-10 16:35:05 +08:00
064e8e1ef4 Fix ansible-doc traceback and sanity test. (#62040)
* Fix ansible-doc traceback for removed modules.

This avoids tracebacks with errors like the following when a module has been removed:

module module_name missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

* Fix ansible-doc sanity test warning handling.

Warnings about removed modules/plugins on stderr are now properly ignored.

Previously an ansible-doc error could result in unrelated errors going undetected because tests were stopped early and the underlying error was ignored.
2019-09-10 00:29:34 -07:00
603c8c171f fix ci (#57216) 2019-09-10 13:23:04 +08:00
c19cea9b03 openssh_keypair: make sure public key has same permissions as private key (#61658)
* Make sure public key has same permissions as private key.

* Add changelog.

* Text, not binary.
2019-09-10 06:44:04 +02:00
c77ab11051 Fix issues with ansible-test --venv option. (#62033)
* Fix ansible-test venv activation.

When using the ansible-test --venv option, an execv wrapper for each python interpreter is now used instead of a symbolic link.

* Fix ansible-test execv wrapper generation.

Use the currently running Python interpreter for the shebang in the execv wrapper instead of the selected interpreter.

This allows the wrapper to work when the selected interpreter is a script instead of a binary.

* Fix ansible-test sanity requirements install.

When running sanity tests on multiple Python versions, install requirements for all versions used instead of only the default version.

* Fix ansible-test --venv when installed.

When running ansible-test from an install, the --venv delegation option needs to make sure the ansible-test code is available in the created virtual environment.

Exposing system site packages does not work because the virtual environment may be for a different Python version than the one on which ansible-test is installed.
2019-09-09 18:32:29 -07:00
e3ea89801b Update playbooks_prompts.rst (#62003)
Fixed typo: "wierd" > "weird"
2019-09-10 06:57:01 +05:30
cc758ea574 Revert "shippable: temporary bump the timeout for Azure jobs"
The Azure timeout should not accure anymore since
173d47d1f4.

This reverts commit aaa8835311.
2019-09-09 18:17:25 -07:00
b437a19f6d create-deprecated-issues script can now add to a specified project (#61901)
* create-deprecated-issues script can now add to a specified project

* Migrate the create deprecated issues script into a subcommand of build-ansible

* Remove deprecated-issue script from ignore list
2019-09-09 17:28:52 -07:00
e0ebc8c9b4 Fixup aws_secret integration tests (#61241)
* aws_secret: (integration tests) Move tests to using module_defaults

* Update hacking aws security policy to enable management of secrets

* aws_secret: (integration tests) Fixup integration tests
- Update tests to use resource_prefix as a prefix rather than a suffix
- Pause after role creation to cope with AWS being slow (and returning before the role it ready)
2019-09-09 15:23:19 -07:00
50e09be14f Allow the use of _paramiko_conn even if the connection hasn't been started. (#61570)
* Allow the use of _paramiko_conn even if the connection hasn't been started.

I'm not sure what the benefit is of Noneing paramiko_conn on close, but will keep for now

* Fix test

* Try to fix up net_put & net_get

* Add changelog
2019-09-09 16:59:20 -04:00
6e8d430872 win_become - don't dispose logon token until end (#61905) 2019-09-10 06:37:07 +10:00
900a51b283 VMware: Fix issue with order of changes in vmware_vcenter_statistics 2019-09-09 16:01:54 -04:00
528f9a6672 Fix ec2_vpc_vgw broken tests (#60981)
* Fix ec2_vpc_vgw broken tests

Add waiter function to wait for API to report detached vgw is available.
Also catch extra error code in attach retry as EC2 sometimes reports that
the vgw is available several seconds before permitting the attachment.

Fixes: #53185

* Re-enable ec2_vgc_vgw test target
2019-09-09 15:57:09 -04:00
6f74fca238 New module for AWS Step Functions state machines (#59116)
* add new module: aws_stepfunctions_state_machine

* add integration tests for new module: aws_stepfunctions_state_machine

* fix sanity checks

* use files/ folder instead for integration test

* rename role name in integration test

* attempt further permissions

* iam states prefix

* iam integration test prefix

* add iam policy for running step functions state machine actions

* slightly increase iam permission scope

* rename integration test folder to proper name

* move main() method to end of file

* move contents of integration-policy.json for state machines to compute-policy.json

* make check_mode return proper changed value + add check_mode integration tests

* rename module to aws_step_functions_state_machine

* fix missed rename in integration test variable

* add purge_tags option

* bump to version 2.10
2019-09-09 10:08:21 -07:00
4e2c70c13e Include version_added in report.py (#61857) 2019-09-09 11:40:38 -05:00
3ea8e0a144 VMware: not ssl.SSLContext if validate_certs false (#57185)
Python < 2.7.9 does not have the ssl.SSLContext attribute.
ssl.SSLContext is only required when we want to validate the SSL
connection. If `validate_certs` is false, we don't initialize the
`ssl_context` variable.

Add unit-test coverage and a little refactoring:

- avoid the use of `mocker`, when we can push `monkeypatch` which is
  `pytest`'s default.
- use `mock.Mocker()` when possible

closes: #57072
2019-09-09 21:41:46 +05:30
1f38a12057 Fix behaviour of module_utils/ec2 compare_policies when dealing with bare bools and ints. (#61115)
* module_utils/ec2: (unit tests) Move unit tests for module_utils/ec2.py into test/units/module_utils

- compare_policies was refactored from s3_bucket
- "ec2_utils" doesn't seem to have ever existed

* module_utils/ec2: (unit tests) Add unit test for comparing quoted and unquoted bools and numbers within policies

As per https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html

"Values are enclosed in quotation marks. Quotation marks are optional for numeric
and Boolean values."

* module_utils/ec2: Explicitly convert bools and ints to strings when comparing policies

See also: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html
2019-09-09 12:08:25 -04:00
646a0b9024 Add missed eos modules to porting guide (#61994) 2019-09-09 12:07:42 -04:00
9d93076a99 Debug location of ansible-connection when found (#61998) 2019-09-09 12:06:54 -04:00
02c7f2f518 Add collections ticket stub (#62001)
* Add collections ticket stub

* typo

Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-09-09 10:47:47 -05:00
28227c95a4 for capability/exchange/1.0 (#60630)
* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py
2019-09-09 14:33:34 +01:00
6fa8abf162 fix: adds prefix length error to eos cli plugin (#61747) 2019-09-09 09:28:40 -04:00
483e76ee58 Allow junos_config changes the candidate configuration only (#61969)
This allows junos_config to changes the candidate configuration only and
does not commit it as the active configuration at once w/ the
'check_commit' option.
2019-09-09 18:22:57 +05:30
7b28960ebe VMware: Add new module VMware vSAN health infos (#58636) 2019-09-09 14:59:31 +05:30
3703c3bb1a atomic_image: Fix absent state (#61827)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-09 14:38:32 +05:30
df49a9e58c purefa_info: Fix failure due to API version check (#61925) 2019-09-09 09:14:46 +02:00
92099d7f2f Remove unnecessary pass statement (#61749)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-09 10:12:11 +05:30
a680ff2ade Clean up unused imports for nxos related code (#61856)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-08 22:53:24 -04:00
6ccb245a2d test_cp_mgmt_address_range module (#61867)
* test_cp_mgmt_address_range module

* fix test issues

- file location
- api_call is missing from facts
- metclass and import items
2019-09-09 06:51:39 +05:30
d40ba28fb4 docker_container: improve port range parsing error behavior (#61740)
* Improve port range parsing.

* Add changelog.
2019-09-08 20:30:18 +02:00
943888b955 Fixes to ecs_certificate cert chain for #61738 (#61858)
* Fixes to ecs_certificate cert chain for #61738

* Added changelog fragment

* Fixes to ecs_certificate for cleaner join, and better integration test

* Fix integration test formatting

* End cert chain with a \n

* Update changelogs/fragments/61738-ecs-certificate-invalid-chain.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update main.yml
2019-09-07 07:58:25 +02:00
cac93cbd1f os_port allowed_address_pairs and extra_dhcp_opts list of dicts comparison fix (#56577)
* compare list of dicts

* update example for dhcp_server_opts to include ip_version which is automatically added by openstack

* add note about dhcp_server_opts

* add changelog fragment

* fix forgotten exception+pass

* no need to excplicitly check for None

* fix oops

* fix import error

* missed missing_required_lib

* changelog fragment formatting and grammar fixes

* update requirements in documentation and fix spelling
2019-09-06 22:44:25 +02:00
b8650c0a50 aws_asg: Fix idempotency when using tags and metrics (#61284)
* Update AWS hacking policy to enable ASG Tagging management

* aws_asg: Add tests for ASG Tagging (including idempotency)

* aws_asg: ignore sort order when comparing tags on the ASG (fix idempotency)

* ec2_asg: (integration tests) test for idempotency when managing metrics collection

* ec2_asg: sort list of enabled metrics to ensure clean comparisons.
2019-09-06 12:48:40 -07:00
d7604844c2 Update the number of contributors in README: 4600+ (#61949) 2019-09-06 15:07:27 -04:00
8331c8fdc3 Properly hide limit and list-hosts args from ansible-inventory (#61618)
* Properly hide limit and list-hosts args from ansible-inventory. Fixes #61604

* Add changelog fragment

* Consolidate limit

* Fix positional argument with --graph

* Properly error for hidden arguments

* linting issue

* host pattern changelog
2019-09-06 11:43:50 -05:00
61efffcbe1 User - correct group removal description in docs (#61936) 2019-09-06 12:16:33 -04:00
e4d4e49388 Fix mysql.py logic related to 53326 (#61832) 2019-09-06 13:53:54 +01:00
4f29b5a76b Fix ansible-connection persist after playbook run complete issue (#61591)
* Fix ansible-connection persist after playbook run issue

*  PR https://github.com/ansible/ansible/pull/59153 to add support
   for delaying the ansible-connection added an old issue of
   ansible-connection persisting even after playbook run is finished
   till either command timeout or connect timeout is triggered.
   ansible-connection persist after playbook execution is done
   and also delays the connection initilization untill a method
   in invoked from module side on the connection object.

* Add chanegelog
2019-09-06 14:23:18 +05:30
e6fe52bc56 Update os_security_group_rule.py (#61262)
Currently, this module does not support to add 132 SCTP rule in security group rule of openstack. Could we add this support in this module? Thanks~
2019-09-06 02:32:34 -04:00
7f4328ad12 allow external collections under the ansible NS (#61908)
* fixes #59988
2019-09-05 18:50:22 -07:00
f58899eef7 Update release name for 2.10
Add a list of previously used release names to make it easy to tell what
release names are no longer usable.

Add a test that new release names have been added to the used list.

Fixes #61616
2019-09-05 18:36:06 -07:00
832e03d932 Fixup iam_group integration tests and return value documentation (#61243)
* iam_group: (integration tests) migrate tests to module_defaults

* iam_group: (integration tests) migrate to using temporary user and group with {{ resource_prefix }}

* iam_group: (integration tests) fix test, checking the return values

* iam_group: (integration tests) Add some more tests around the behaviour of 'changed'

* iam_group: (docs) Update documentation of iam_group return value

* Update AWS testing policies to enable group/user management
2019-09-05 19:25:36 -04:00
cbe511de1f ec2_vpc_subnet test cleanup (#61663)
* aws_vpc_subnet: (integration tests) migrate to module_defaults

* aws_vpc_subnet: (integration tests) remove hard coded assumption that AZ A exists.

While Amazon now tends to enable all AZs in a region, new customers in us-west-1 are only assigned 2 out of the 3 AZs, which might not include AZ a

* ec2_vpc_subnet: (integration tests) General cleanup

- use "is changed" rather than .changed
- clean up labelling of a couple of assertions (C&P fail)
2019-09-05 15:56:54 -07:00
d49d52eb5f Add tests for new alias deprecation functionality (#61476)
* Add tests for the alias deprecation added in #61245
2019-09-05 15:47:42 -07:00
59afffa334 Fix rpm dependencies for ansible-test
Needs to require ansible = version rather than ansible-version
2019-09-05 15:03:50 -07:00
7d303e54f6 meraki_organization - Add warning about organization deletion (#61886)
* meraki_organization - Add warning about organization deletion
The documentation is now more explicit about the ramifications of using `state: absent` in a task.
2019-09-05 16:02:19 -05:00
1425d23513 To fix IOSXR L3 Interfaces idempotency failures (#61860)
* fix zuul idemptency failures

* adding eol

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-05 16:39:15 -04:00
375eb9723a Add caution about handlers & import to Pitfalls (#61060)
* Add caution about handlers & import to Pitfalls on the playbooks_reuse page.
The fact that handlers lose their name: when using import_tasks:, while logical, is not intuitive and should be noted.
Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-09-05 14:18:09 -05:00
ce8af1c8c5 Typo 'state:' net_lldp (#61543)
'state:' should be "absent" not "lldp"
2019-09-05 14:15:19 -05:00
a365e77cc3 Connect before reading the prompt? (#61797) 2019-09-05 14:48:16 -04:00
394a05108d Update mso_schema_template_deploy.py (#61849)
module names are incorrect in EXAMPLES:  changed module names from 'mso_schema_template' to 'mso_schema_template_deploy'
2019-09-05 10:55:56 -05:00
513bddb44a VMware: Add disk_mode parameter in vmware_guest_disk (#60406)
* Solve issue 58592

Added support to select disk_mode.
2019-09-05 11:52:12 -04:00
1aca1f86b6 don't set default:None in documentation when there is no default (#61111)
otherwise "None" will be rendered as a string on docsite
2019-09-05 10:48:11 -05:00
70f501d5c8 Update hashi_vault.py documentation with kv V2 example (#61221) 2019-09-05 11:42:39 -04:00
08e01380e6 azure_rm_iothub: disable the functional test (#61854)
The test fails with: Operation failed with status: 'Unauthorized'
This commit disable the test until the situation is resolved.

See: https://github.com/ansible/ansible/issues/61852
2019-09-05 11:03:12 -04:00
7132466327 test: disable the docker swarm tests (#61816)
`docker_swarm` tests tend to hang during the creation of the Swarn
cluster.

See: https://github.com/ansible/ansible/issues/61815
2019-09-05 10:47:31 -04:00
2fbe4ca102 Fix galaxy server reference in the docs (#61823) 2019-09-05 10:47:19 -04:00
173d47d1f4 Rebalance Azure tests groups 2019-09-05 09:28:26 -04:00
aadb192846 documentation: modify the link to the docker.txt listing all images (#61838)
The file was moved.
2019-09-05 08:07:09 -05:00
cc9adf7f1a Unify ios_logging documentation with accepted options (#61777)
* Unify ios_logging documentation with accepted options

* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* Copy suggestion over to eos_logging
2019-09-05 08:58:57 -04:00
f406b8b4c4 Fix bug preventing wait_condition from being respected when using apply (#61493) 2019-09-05 22:49:30 +10:00
223dab99ea gitlab_hook: Update documentation (#61837)
* Update docs for note_events

Fixes: #61833

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-05 17:09:59 +05:30
e06dbe6e4f Azure _info modules: fix returned ansible_facts when called as _info (#61805)
* Fix Azure _info modules which still returned ansible_facts.

* Adjust PR #.

* Fix wrong assignment.

* Reorganize code for clarity.
2019-09-05 11:51:56 +02:00
2a932ad7cf Fix power command ResetType mapping logic (#59927)
* fix power command ResetType mapping logic

* add changelog fragment
2019-09-05 05:39:21 -04:00
823c108fac ovirt: Fix API calls in ovirt_storage_domain (#61825)
* Fixed argument in _attached_sds_service API
* Fixed argument in _maintenance API

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-05 15:00:18 +05:30
c723eb2f04 Remove unused import from iosxr facts (#61785)
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 22:16:15 -04:00
3a7b77a94c ansible-galaxy fix --server option for roles (#61820) 2019-09-05 11:46:44 +10:00
f81b7dd10a Remove unsed import for eos facts module (#61795)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 19:50:12 -04:00
8214d188cf Don't truncate the last character from galaxy urls. Fixes #61624 (#61775) 2019-09-05 07:06:42 +10:00
adfaefb732 ec2_launch_template: Fix integration tests (#61260)
* ec2_launch_template: (integration tests) make sure security_token is optional

* ec2_launch_template: (integration tests) add dependencies at the top level so they're pulled into the docker containers

* Update Hacking Compute Policies for Launch Templates
2019-09-04 15:33:01 -04:00
7be672e1c2 Remove unsed import for junos facts (#61787)
This is no longer needed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 15:00:19 -04:00
41055b5dc8 Proposals aren't really used much, delete it (#61800) 2019-09-04 13:56:57 -05:00
ff05991265 s3 - improve waiting for the bucket (#61802) 2019-09-04 14:50:08 -04:00
4c8407fb83 Fix documentation and facts_from_proxy value in the netapp_e_facts module. (#61072) 2019-09-04 14:34:58 -04:00
44eaea9f80 Remove unused import for cisco ios facts (#61790)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 14:22:38 -04:00
7efaad711e Minify ansible (#61792)
* make all comments special to survive minify
* minified css
2019-09-04 12:57:05 -05:00
736938625b Remove unused import for vyos facts (#61784)
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 13:54:08 -04:00
0c73e47a42 fix erroneous failures in docker_compose due to deprecation warnings … (#61650)
* fix erroneous failures in docker_compose due to deprecation warnings from docker (#60961)

* Update error handling to work with new method of capturing output

Co-Authored-By: Felix Fontein <felix@fontein.de>

* update error handling

* fix syntax error

* fix indentation

* fix indentation (again)

* remove erroneous line
2019-09-04 19:34:05 +02:00
d5c8d325e4 codebuild/codepipeline - fix regex for shippable resource_prefix (#61783)
* Fix bad assumption about shippable resource_prefix for codebuild and codepipeline tests
* Update test/integration/targets/aws_codepipeline/defaults/main.yml
2019-09-04 12:48:37 -04:00
1dea661ce8 Allow 13 asterisk characters in password field without warning (#54893)
On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

> [WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone.
2019-09-04 11:49:16 -04:00
de826b437d Minify theme (#61734)
* moved most ansible edits out of theme.css
* remove unnecessary edit to theme.css
* replace with upstream minified theme.css for 0.4.3
2019-09-04 10:45:16 -05:00
49b775f0f7 aluvenko isn't reviewing anymore (#61764)
* aluvenko isn't reviewing anymore

aluvenko hasn't been around for a while, so remove them

* Update BOTMETA.yml
2019-09-04 16:39:58 +01:00
ee4b3b8854 Fix systemd start state with deactivating service state 2019-09-04 08:01:33 -07:00
a795f6941e Make *_bgp modules collection safe (#61761)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-04 10:29:00 -04:00
9ee0deea24 aws_codebuild tests - add retries and delay instead of a pause task (#61731)
- Add retries instead of a pause task
- Shorten the IAM role name length
- Put the IAM role name in defaults/main.yml instead
- Fix the aws_codepipeline tests too
2019-09-04 09:59:35 -04:00
91ccb03552 aws_s3 - wait for the bucket before setting ACLs (#61735)
* Wait for the bucket to become available if possible before setting ACLs
2019-09-04 09:42:28 -04:00
531e0560cb add trustcacerts option for JAVA keytool (#61750)
* add trustcacerts option for JAVA keytool

* fixed whitespace

* added type in documentation
2019-09-04 13:07:20 +01:00
c1e02d5c7a Remove choices from gather_network_resources facts and fix negated all, min (#61362)
* remove choices from gather_network_resources facts and allow negating subset without needing to add a new subset specific for negation

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* negated all, min should not return any fact

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-09-04 16:31:10 +05:30
2672dc9694 Fixes IOS L3 intermittent zuul failure (#61682)
* fix ios l3 intermittent failure

* fix self

* dict to ordered dict

* fix diff_again fn

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* remove orderdict as its expensive

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* update verify fn

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-04 15:51:05 +05:30
01f4081b66 Fix creation of DigitalOcean droplets using digital_ocean_droplet module (#61655)
* Omit disallowed 'id' attribute in request body to create a droplet

* Add changelog fragment for PR #61655
2019-09-04 02:28:56 -04:00
3f9316bca2 debian: prepare the ansible-test package
- Generate an extra package for `ansible-test`.
- Manually install the files because CDBS get confused by our two
  Python packages
- Refresh the package descriptions to match what is done with the RPM
2019-09-03 22:00:24 -07:00
2ebeadfc14 Migrate ec2_eip module to boto3 (#61575)
* Migrate ec2_eip module to boto3

This patch is a step towards the integration of several PRs that have
attempted to migrate this code

closes #55190
closes #45478

Follow-up PRs will address the outstanding changes made in #55190
2019-09-03 22:46:29 -04:00
00add5b668 Set win_pagefile as unstable as thats what it is (#61732) 2019-09-04 12:29:29 +10:00
47ce938121 Read update file as utf-8 (#55253) 2019-09-03 21:54:10 -04:00
091ab12692 Fix issues and limitations in account mgmt commands (#58441)
* fix issues and limitations in account mgmt commands

* fix pep8 and example yaml errors

* remove new option and update option aliases

* find next empty slot when adding user via PATCH
2019-09-03 21:44:33 -04:00
088d821f75 Fix KeyError exceptions in GetLogs command (#59877)
* fix KeyError exceptions in GetLogs command

* add changelog fragment

* refine the list of LogEntry properties to collect
2019-09-03 21:44:07 -04:00
86b38a0ead Add ucs_query (#60607)
* Add ucs_query

* fix sanity erros

* Change version_added to 2.10
2019-09-03 21:34:46 -04:00
a09b89f567 osx_defaults - doc tweaks (#60881)
* [osx_default] We are looking for the "defaults" executable, not "osx_defaults"

* [osx_default] Add example for setting system wide default
2019-09-03 20:16:39 -04:00
f1180f3d3f Fix documentation to reflect CLI usage for collections-path (#60164) 2019-09-03 16:50:58 -04:00
9be8a98aa2 Update the rpm spec file to include ansible-test
* Include ansible-test in a subpackage
* Sync with the ansible engine spec file
* Addresses https://github.com/ansible/ansible/issues/60380 to the
  extent that we're likely to fix that.
2019-09-03 13:41:41 -07:00
6cf025425e Fix Decode Bug in Py3 (#61691)
* Fix Decode Bug in Py3

* Update fortios.py

* Remove special char from name

* Ensure full compatibility when ansible is install from Py2
2019-09-03 15:37:00 -04:00
411b208147 Add example of "parent_group" usage in aws_ec2.py (#60430)
##### SUMMARY
Looks like the "parent_group" option in "keyed_groups" is a very recent feature that is not being documented. 
This pull request just adds a simple example of the usage of this useful feature.



##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-03 20:33:47 +01:00
9797857a67 Fix Python 2.7 compat (#58816) 2019-09-03 20:24:41 +01:00
5f9fe6b9c8 Removed additional fetch from config context because it is now available in the host from Netbox v2.6 onwards (#59028)
* Removed additional fetch and config context as an option as it is now available in the host from Netbox v2.6

* Added config-context as an option
2019-09-03 20:23:28 +01:00
b46e661d39 ovirt search name with space (#59184)
* init ovirt_search_name_with_space

* add search_by_name with whitespace

* add comments
2019-09-03 20:22:37 +01:00
d4147b55dd Issue #41447 - support AWS Aurora S3 privileges in mysql_user module (#59663) 2019-09-03 20:22:07 +01:00
fad405ac42 postgresql: Move PgMembership to module_utils (#61598)
* postgresql: move PgMembership to module_utils

* postgresql: move PgMembership to module_utils, optimize logic
2019-09-03 20:14:09 +01:00
7c92c4214c Fixes #59613 (#60041) 2019-09-03 15:08:08 -04:00
5d7d4a93c8 docs: Update apt_key.py add requirements of gpg (#61552)
* docs: Update apt_key.py add requirements of gpg. The module needs to have gpg installed, otherwise it will end up with error {"changed": false, "msg": "Failed to find required executable gpg in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-09-03 13:53:44 -05:00
763fa4e85f version_added: '2.10' for post branch commits (#61678)
Due to bot automerge a few PRs were merged before version_added had been updated.

https://github.com/ansible/ansible/pull/61674
2019-09-03 19:53:10 +01:00
47b9c5bf04 Ecs taskdefinition secrets (#60112)
* adding specific examples for using environment and secrets in the container definition
2019-09-03 11:17:22 -05:00
c9e7a2122d Increase unit test timeout to account for long image download times (#61717) 2019-09-03 12:14:55 -04:00
9c1dc0ea7f grafana_plugin: update documentation (#60600) 2019-09-03 12:10:47 -04:00
bdc87a5651 datadog_monitor: Add process alert support (#60325) 2019-09-03 12:10:07 -04:00
bfaa29303b adding a collection local try section (#61626) 2019-09-03 11:33:32 -04:00
a10606484c Fix required_together statement - access_logs_s3_prefix is not required as per the documentation (#52017) 2019-09-03 11:26:38 -04:00
c4fd2096bf Fix examples for bigip_file_copy (#61686) 2019-09-03 11:16:31 -04:00
7e7b7bb0b6 Correct indentation of the code in the example (#61622) 2019-09-03 10:09:47 -05:00
54906a68fe Docs - Add Meraki to platform option list (#61651) 2019-09-03 11:04:39 -04:00
ca3078de5f Remove duplicated word
We print "%s success", so there's too much success going on.
2019-09-03 20:31:40 +05:30
bcbcac3bd8 net_user documentation typo configured_password (#61556)
password -> configured_password in the last example
2019-09-03 10:00:20 -05:00
3e2521dfb2 botmeta: unmaintain resmo from cloudstack (#61561) 2019-09-03 15:56:40 +01:00
615f9949c0 Update unit tests requirements/units.txt path (#61656) 2019-09-03 15:49:15 +01:00
4b9b5d3745 Remove unnecessary information (#61657) 2019-09-03 15:47:20 +01:00
58acc8d082 Clarity on mutual exclusion of Username and Token (#61668)
##### SUMMARY
Although there is an example showing that username is not required with personal access token, it will be nice to more clearly state in options description. 
##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-03 15:41:42 +01:00
8e22a60f97 ansible-test: vcenter+Worldstream: hide password
Hide the temporary password when `ansible-test` is called with the
`--redact` parameter.
2019-09-03 10:34:34 -04:00
7dbd6116d8 Fix typesetting of "GitLab" (#61702) 2019-09-03 09:22:26 -05:00
74e6c460b4 Fix missing pass of IPXe params to API client call, fixes #32910 (#32912) 2019-09-03 10:07:15 -04:00
9744ce1e1d Rename checkpoint to check_point due to legal reasons, fix #61145 (#61172)
* Fix #61145

* Fix type keyword

* Removed file fragment
2019-09-03 19:05:50 +05:30
39f35ac5bb Fix network resource module wording and typographical errors (#61613) 2019-09-03 09:11:46 -04:00
036f173962 Remove willthames from AWS and Openshift notifications (#61670)
I no longer desire to be mentioned on most AWS changes.
If there are modules I'm on the authors list then I'll remain
notified.

Also remove me from openshift and kubectl plugins, I don't use
those.
2019-09-03 13:55:36 +01:00
d20d10b5c5 Avoid infinite recursion on login (#61617) 2019-09-03 08:55:20 -04:00
447c7d9ff0 Update homebrew_cask example docs (#61637)
Changed homebrew_cask module flag from "allow_external_apps" to "accept_external_apps" in example section
2019-09-03 16:56:29 +05:30
68f9cd14cb feat: support postgres 11 in azure_rm_postgresqlserver (#58727) 2019-09-03 14:00:33 +08:00
e7c6134fd0 VMware: Fix get_tags_for_vm API in vmware_vm_info module (#61697)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-03 11:25:16 +05:30
e4d72dd981 luks_device.py: Allow manipulate LUKS containers with label or UUID (#61603)
* luks_device.py: Allow manipulate LUKS containers with label or UUID

- Allow create a LUKS2 container format with label support
- Allow manipulate (open, close, modify) an LUKS container based on
  both label (LUKS2 format) or UUID instead of using devices only.

Fixes: #58973
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

* test_luks_device.py: organizing tests to support labels

- Add label on some tests and fix errors reported by Shippable

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

* luks_device.py: adjusting versions and messages

- Modifying version_added from 2.9 to 2.10
- Fixing some messages
- Created a changelog fragment
- Moving blkid from scope

Fixes #58973
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-09-03 05:40:09 +02:00
6f7cd8370a Ansible FTD Module improvements and tests update. (#60640)
* Ansible FTD Module improvements and tests update.

* Fix sanity tests

* Fix formatting
2019-09-03 08:38:11 +05:30
7197c41fff influxdb: Add support for 'path' parameter (#61173)
While it's possible to host InfluxDB on a different path prefix
(through a reverse proxy such as nginx or traefik), the Ansible
influxdb_* modules did't support that use case.

The patch adds a 'path' parameter, which is passed to the influxdb
Python client.

Example for connecting to InfluxDB running on http://localhost/influxdb

    - hosts: all
      tasks:
        - influxdb_database:
            database_name: test
            path: influxdb
            port: 80
2019-09-02 22:17:25 +02:00
9ccef9e819 perf: reduce getting handler variables (#59969)
* perf: reduce getting handler variables

ci_complete

* Do not re-create templar
2019-09-02 10:57:08 -04:00
606e2ff03a Disable Automerge (#61674)
A few PRs have been automerged since devel became 2.10 even though they still had `version_added: 2.9`

Lets disable automerge till:
a) We find a proper fix (automerge should so `rebuild_merge`?)
b) We wait 7 days since devel became 1.10 to cause stale_ci
2019-09-02 12:08:05 +02:00
f1a1b72f07 os_server - add "tag" to instance nics (#61119)
A custom "tag" could be passed to the instance metadata with the nics.
Add support for the "tag" to the module.
2019-09-02 05:07:53 -04:00
6e6c2f5cea Set the default value for the managed_disk_type (#60749) 2019-09-02 15:54:58 +08:00
52a665e224 #59096 Fix for not working azure_rm_aks (#59097) 2019-09-02 15:50:11 +08:00
cf86a5e07a kubevirt: also add wait_sleep (#61020) 2019-09-01 17:53:31 -07:00
de6e2de0c4 Remove unused import for iosxr l3_interfaces (#61563)
This was caught by our ansible network collections migration script.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-31 14:47:02 -04:00
21b101f8e1 add option to define keysize at luks partition creation (#61522)
* add option to define keysize at luks partition creation

* Bump version_added.

* Extend tests.
2019-08-31 19:32:41 +02:00
a6d9401c88 postgresql modules: explicit defaults for bool params (#61538) 2019-08-31 18:27:57 +02:00
4d057e0331 Make sure postgresql tests are run for all postgres_* modules (#61647) 2019-08-31 18:12:40 +02:00
e89048f68a Check module names in action plugin without collection attached (#60947)
* Check for eos_config in action plugin by module name, not entire fqmn

* Modify toher action plugins to find module name

* Restore missing `not`

* Cover netconf plugin as well

* Whoops
2019-08-30 21:11:44 -04:00
3d78dad84b Update Fedora 29 test image 2019-08-30 19:49:40 -04:00
24ad1dffc9 To fix iosxr_l3_interfaces module zuul tests (#61592)
* fix 61540

* fix utils
2019-08-30 19:36:15 -04:00
aaa8835311 shippable: temporary bump the timeout for Azure jobs 2019-08-30 18:47:51 -04:00
1ff20e9804 apt_repository: implement update cache retrying (#57266)
* use exponential backoff
* make cache update retries and max delay in between configurable
2019-08-30 16:14:15 -04:00
fd4ff54580 apt: honor cache_update=false on auto-install deps (#56549)
* apt: honor cache_update=false on auto-install deps
* add porting guide
2019-08-30 15:57:58 -04:00
01ae6991bd apt: use exponential backoff for apt update cache retries (#60527)
* make retries and max delay configurable
2019-08-30 15:55:38 -04:00
e218c9814c ansible-test - Continue if the git command returns an error (#61605)
* ansible-test - Contiune if the git command returns an error

* Just return stdout

* Use to_text() when displaying exception

* Add a message property to SubprocessError
2019-08-30 12:03:39 -07:00
1d40d2b572 fix width (#61619) 2019-08-30 13:44:41 -05:00
35359959de aws_codecommit: Fix integration tests and Add support for updating the description (#61263)
* Update DevOps AWS policy
- Fix typos in permission names
- While AWS claims you can use 'arn:aws:codecommit:*' it errors unless you use '*'

* aws_codecommit: (integration tests) Migrate to module_defaults

* aws_codecommit: (integration tests) Fix integration tests

* aws_codecommit: (integration tests) Add tests for updating the description

* aws_codecommit: Add support for updating the description and rename "comment" option to "description"
2019-08-30 11:25:37 -07:00
0e1ec04efb roadmap should reflect upstream release, not downstream (#61611) 2019-08-30 13:07:24 -04:00
8f6dbb732a [WIP] Cleanups and version bumping for 2.10 (#61572)
* Cleanups and version bumping for 2.10

* Fix changelog url now that stable has been branched

* Fix the lenth of the porting guide title now that the version is two digits
2019-08-30 09:54:12 -07:00
0c2590d3df Run ec2_vol_facts integration tests in CI (#48755)
Filter owner aliases by 'amazon' since amazon marketplace may not be activated
2019-08-30 08:47:32 -07:00
e4e5005640 Fix ansible-test coverage path handling. (#61528)
* Fix ansible-test coverage path handling.
* Split CI unit tests into two groups.
2019-08-30 00:18:49 -07:00
951dac7691 Azure fix _info/_facts return values for some modules (#61584)
* Azure fix _info/_facts return values for some modules

* Further test fixes

* securitygroup fixes after the move to _info module
2019-08-30 16:00:47 +10:00
cd24d57636 Add IOPs bandwidth support to volumes (#61577) 2019-08-30 01:12:39 -04:00
3bd69a47ec Skip certain tests on 2016 (#61585) 2019-08-30 14:59:00 +10:00
4063d58339 Use relative submodule status in ansible-test.
The `git submodule status` command is relative to the current git repository by default.
When running from a repository subdirectory paths can be returned above the current directory.
Specifying the current directory with `git submodule status` avoids listing submodules above that directory.

This will fix issues when testing a collection that is rooted below the repository root when that repository uses submodules.
2019-08-29 20:29:38 -07:00
a7fd6e99d9 Refactor galaxy collection API for v3 support (#61510)
* Refactor galaxy collection API for v3 support

* Added unit tests for GalaxyAPI and starting to fix other failures

* finalise tests

* more unit test fixes
2019-08-30 11:55:19 +10:00
82c1becd24 Bug fixes for GCP modules (#61512) 2019-08-29 19:16:36 -04:00
02572cb9ec Rewrite nxos_file_copy as an action plugin (#60643)
* Initial nxos_file_copy action plugin work
* Remove code from nxos_file_copy module
* Add file_push and file_pull support
* Additional refactoring and shipable updates
* Simplify outcomes and update doc header
* Add more error data information for easier debugging
* Reorder outcomes and add additional tests
* Capture more data for permission denied outcome
2019-08-29 12:57:39 -07:00
2215a62057 Fix ansible-test handling of submodules.
Resolves https://github.com/ansible/ansible/issues/61550
2019-08-29 12:21:28 -07:00
3881326ae2 Fix crashing bug in purefa_info module and add some new info (#61494) 2019-08-29 13:50:21 -04:00
b03fc093b4 Rename junos_lldp_global enable option to enabled (#61551)
*  Change `enable` option to `enabled` option to be in
   sync with other platforms
2019-08-29 22:32:48 +05:30
68fa03138c Revert "New Module: NetApp Account (#59939)"
This reverts commit 6a8dcb8fcb.

Reverting this as it breaks CI for azure (more permissions would be
needed for our account)
2019-08-29 09:04:48 -07:00
f23bb6f7bd Properly load module_prefix for collections in task_executor.py (#60420)
* Properly load module_prefix for collections

Now that we are using collections for tasks, we need to properly split
the name and load the prefix properly.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* Add unit tests for task_executor

This commit adds missing unit tests for action handler in test_task_executor.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
2019-08-29 09:04:26 -07:00
6a8dcb8fcb New Module: NetApp Account (#59939)
* netapp account module for azure

* netapp account module for azure

* fixes

* fixes

* add requirements

* add requirements

* fix issues

* add units

* add units

* updates

* updates

* fixes

* fixes

* fies

* fixes
2019-08-29 11:25:20 -04:00
96f7b5520e BOTMETA: fix team_extreme name use (#61557) 2019-08-29 17:04:03 +02:00
54b108175b VMware: add support for multiple CD-ROMs (#51120)
Add support for create or re-configure VM with multiple CD-ROMs attaching to IDE controller now, will implement SATA controller support later.
parameters can be set as below:

    cdrom:
    - controller_type: ide
      controller_number: 0
      unit_number: 0
      type: client
2019-08-29 10:56:33 -04:00
e41f1a4d7d Update BOTMETA to be included as maintainer for EXOS modules. (#61485) 2019-08-29 15:33:11 +01:00
d3d9c5c273 Fix doc for network_cli connection retry timer (#61509) 2019-08-29 10:24:43 -04:00
0c592c8225 CloudStack modules: rename _facts -> _info (#61090)
* Rename cloudstack _facts -> _info

* Add changelog.

* Fix errors due to overloaded get_result having different parameter names.

* Fix examples.

* Change debug tasks.

* Remove unneeded code.

* Change from rename -> deprecate+new module.

* Make cs_zone_info return a list.

* Make cs_instance_info return a list.

* Fix return value docs.

* Fix typo.

* Improve tests.

* Fix cs_zone_info.

* Linting.

* Fix alias/option switch.

* Fix version numbers.

* Extend docs.
2019-08-29 16:14:51 +02:00
9b5528ab8e cloudscale_volume: refactor to implement tags support (#61531) 2019-08-29 16:08:54 +02:00
060484970d add tag functionality to cs_network (#61530)
* add tag functionality to cs_network

* fix version_added
2019-08-29 16:07:28 +02:00
cee54d55d0 Add 'min' to gather_subset ios_facts documentation (#61536) 2019-08-29 09:58:20 -04:00
017562013a Add porting guide entry for gathering facts tag change (#61180)
* Add porting guide entry for gathering facts tag change

* Use code-block
2019-08-29 08:38:13 -05:00
a321e58c73 fix suboptions of list to replacce _ with - (#61542)
* fix suboptions of list to replacce _ with -

* Update checkpoint.py
2019-08-29 19:00:51 +05:30
41e4ece44b Defer passlib dependency from plugins/filter/network.py (#59304)
* Defer passlib dependency from plugins/filter/network.py to what utils/encrypt.py provides.

* Revert test changes now that passlib is optional
2019-08-29 09:01:30 -04:00
fd9b643219 group_with_exclusion module (#61480) 2019-08-29 18:06:04 +05:30
4d73c7b397 Resource module for iosxr_l3_interfaces (#60464)
* iosxr_l3_interfaces module
2019-08-29 17:58:48 +05:30
68f34351fc Rename remaining facts -> info (#61516)
* rename remaining stuff

* links

* fixed link

* sanity fixes

* too many lines

* fixed link

* fixed link again

* delete mistake

* fixed ignore

* fixed ltl

* fixed trailing whitespace
2019-08-29 20:10:23 +08:00
d9ea88d1a8 Don't bother Ricky (#61377) 2019-08-29 13:09:25 +01:00
0b7d478200 add porting guide for bare vars in conditionals (#60943) 2019-08-29 08:08:29 -04:00
36774ceb40 mds module (#61472)
* mds module

* Update lib/ansible/modules/network/checkpoint/cp_mgmt_mds_facts.py

improve description

Co-Authored-By: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-29 16:53:16 +05:30
df3cf87ae3 session module (#61471) 2019-08-29 16:52:52 +05:30
e5fed1895b discard module (#61452)
* discard module

* fix test failure
2019-08-29 16:52:37 +05:30
bcaed441e7 application_site_group (#61289)
* application_site_group

* add '-'

* update examples

* list to dict

* set example
2019-08-29 16:52:24 +05:30
3d622440a8 jboss: add seealso (#61532) 2019-08-29 12:41:52 +02:00
144108296f postgresql modules: add seealso section (#61526)
* postgresql modules: add seealso section

* postgresql modules: add seealso section
2019-08-29 12:41:31 +02:00
f90587069c Update collections integration targets path. (#61523)
* Update collections integration targets path.

* Fix integration path handling.

* Add collections test target fallback.

Also add warnings and errors for common path mistakes.

* Improve role target detection.
2019-08-29 03:39:03 -07:00
0922407b67 run_ips_update module (#61440) 2019-08-29 15:40:34 +05:30
3bfeae9040 vultr: add changelog and update porting guide (#61520) 2019-08-29 11:49:00 +02:00
032bd3a030 Move the ansible-test output_dir.
This directory is currently a fixed location to make troubleshooting easier.
It is cleared before each test target runs, but is preserved when a test target finishes.
This allows the contents to be inspected when a test fails.

The previous location was `~/ansible_testing/`.
The new location is within the content root:

- `test/results/.tmp/output_dir` for Ansible
- `tests/output/.tmp/output_dir` for Ansible Collections

Moving the directory reduces the number of places on the filesystem where tests create output.
It also enables the results to be returned from delegated systems.
2019-08-29 02:32:31 -07:00
d81ae27a4a Collection role relative deps (#61517)
* default collection support

* playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles)
* this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection

* disable default collection test under Windows

* enable collection search for role dependencies

* unqualified role deps in collection-hosted roles will first search the containing collection
* if the calling role has specified a collections search list in metadata, it will be appended to the search order for unqualified role deps

* disable cycle detection unit test

* failing on 3.7+, needs proper cycle detection
* see #61527
2019-08-29 02:25:44 -07:00
7bb0556334 Rename Azure modules: facts -> info (#61505)
* rename

* add symlink

* rename

* rename

* rename

* rename

* rename

* rename

* rename

* rename

* rename

* rename

* rename

* rename
2019-08-29 17:00:45 +08:00
876804395c tag module (#61393)
* tag module

* list to dict

* removed set example

* fix name in example
2019-08-29 14:24:44 +05:30
a9b7db9d32 dynamic_object module (#61437)
* dynamic_object module

* fix example

* remove set example
2019-08-29 13:52:31 +05:30
649d612d64 keycloak: improve testability of authentification (#57611) 2019-08-29 10:15:47 +02:00
07c288f56f threat_layer module (#61389)
* threat_layer module

* list to dict

* fix example

* remove set example
2019-08-29 13:25:11 +05:30
48a67f4465 Fix race condition in test_sunos_get_uptime_facts
Mock time.time() to return consistent time value.
2019-08-29 00:22:48 -07:00
e5b24a68cc Add additional group for sanity tests
Put validate-modules in its own group
2019-08-29 00:21:07 -07:00
2272f27841 service_group module (#61448)
* service_group module

* fix example (add)

* fix set example
2019-08-29 12:45:11 +05:30
35c76ae0d3 Rename dtl and db _facts --> _info (#61496)
* rename modules

* created links

* fixed sanity

* removed unnecessary ignore rules

* added depreciation warning

* update ignore.txt to match

* removed unnecessary ignore rules

* update ignore.txt to match

* make ignore.txt same as in devel

* cr

* additional sanity
2019-08-29 14:00:10 +08:00
d92e2a6b0e Simplify ansible-test target processing. (#61506)
* Clean up layout paths for integration tests.

* Remove "special" integration test target type.

* Remove unnecessary role detection logic.

* Remove support for non-sh runme scripts.

* Simplify reading of aliases.
2019-08-28 22:18:20 -07:00
d7845da326 Fix in get api for eric_eccli cliconf plugin (#61507)
Fixes https://github.com/ansible/ansible/issues/60674

*  Fix get() API signature for eric_eccli cliconf plugin
   to work with cli_command module.
2019-08-29 10:32:38 +05:30
aa58bb9d43 exception_group module (#61474)
* exception_group module

* Update cp_mgmt_exception_group.py
2019-08-29 10:22:47 +05:30
60ec8692fc security_zone module (#61447)
* security_zone module

* fix example
2019-08-29 10:18:50 +05:30
831942c834 service_icmp6 module (#61453)
* service_icmp6 module

* fix example
2019-08-29 10:18:21 +05:30
d0bcfdf3a3 service_rpc module (#61468)
* service_rpc module

* fix example
2019-08-29 10:17:29 +05:30
f31760d559 service_dce_rpc module (#61465)
* service_dce_rpc module

* fix example
2019-08-29 10:16:43 +05:30
2287585389 wildcard module (#61399)
* wildcard module

* list to dict

* fix example
2019-08-29 10:16:02 +05:30
7799e61faa dns_domain module (#61436)
* dns_domain module

* fix example
2019-08-29 10:13:59 +05:30
a47e56cb15 SIG Additional fix (#61502)
* adding snapshot param

* fix problem with leftover empty dict

* leftovers

* fix leftovers
2019-08-29 12:43:37 +08:00
8097bd633c global_assignment module (#61449) 2019-08-29 10:12:28 +05:30
736bfc3a35 run_script module (#61444) 2019-08-29 10:09:49 +05:30
d3a8a57db0 install_policy module (#61446) 2019-08-29 10:07:29 +05:30
be27159412 threat_exception module (#61470)
* threat_exception module

* fix examples
2019-08-29 10:06:49 +05:30
fff11bde0d threat_profile module (#61391)
* threat_profile module

* list to dict

* fix example
2019-08-29 10:03:38 +05:30
f1e1da7ad3 multicast_address_range module (#61438) 2019-08-29 10:00:40 +05:30
4c168bd019 vpn_community_star module (#61398)
* vpn_community_star module

* list to dict
2019-08-29 09:59:59 +05:30
7e2292427d vpn_community_meshed module (#61397)
* vpn_community_meshed module

* list to dict
2019-08-29 09:58:52 +05:30
799b0fac52 New module: cvs snapshots for aws (#61023)
* New module: cvs snapshots for aws

* fixeS
2019-08-29 00:24:38 -04:00
3bc5957a93 service_other module (#61450)
* service_other module

* fix test failure
2019-08-29 09:54:23 +05:30
c52e0e5021 service_icmp module (#61451)
* service_icmp module

* fix example
2019-08-29 09:53:03 +05:30
53b2a261de new module: Cloud Volumes for AWS, active Directory (#61342)
* new module

* fixes

* update
2019-08-29 00:21:45 -04:00
834746b207 package module (#61439) 2019-08-29 09:51:28 +05:30
f687bc0ff3 simple_gateway module (#61388)
* simple_gateway module

* list to dict

* fix indentation issue

fails tests
2019-08-29 09:48:30 +05:30
a88436decd service_sctp module (#61386)
* service_sctp module

* list to dict

* fix example
2019-08-29 09:47:00 +05:30
0746ae8b37 Limit config fetch on junos_l3_interfaces (#61219)
This commit adds a filter in junos_l3_interfaces so it limits the amount
of configuration fetched from the remote device.
2019-08-29 09:46:15 +05:30
a54b78c67a verify_policy module (#61455) 2019-08-29 09:43:34 +05:30
311ab5e4f8 put_file module (#61479) 2019-08-29 09:41:37 +05:30
c42ebf227c time module (#61477) 2019-08-29 09:40:52 +05:30
183e6b9a84 New module - na_ontap_ldap_client (#59713)
* New module - na_ontap_ldap_client

* Fixing module example usage

* Fixing module documentation - ansible-test sanity

* Fulfile merge request comments

- required_if used for options
- 'client_config' option renamed to 'name'
- docstring updated
- imports placed according to Ansible module best practices

* create an ems log event for users with auto support turned on

* Fix required_if state=present options
2019-08-29 00:06:36 -04:00
f890c9692f nxos_bfd_interfaces: new module (#61407)
* bfd_interfaces: initial commit

* fix state methods, add more UT

* Add integration tests, support for N6K

* minor comment cleanups

* lint 1

* lint 2

* lint 3

* lint 4

* lint 5

* retrigger shippable

* retrigger shippable

* PR review updates: /bfd_echo/echo/, updated tests

* fix overridden logic and integration test
2019-08-29 09:36:10 +05:30
7e9b02df39 access_layer module (#61373)
* access_layer module

* list to dict
2019-08-29 09:35:08 +05:30
7482d21737 New module - na_ontap_ldap (#59718)
* New module - na_ontap_ldap

* Fixing module documentation - ansible-test sanity

* Fulfil merge request changes from comments

- 'client_config' option renamed to 'name'
- docstring updated
- imports placed according to Ansible module best practices

* Fixed docstring typo + netapp_utils.ems_log_event added
2019-08-29 00:04:48 -04:00
ca12d53463 administrator module (#61286)
* administrator module

* fix examples that the list param will apear with '-' instead of '_'

* add '-'

* update examples

* list to dict
2019-08-29 09:33:56 +05:30
0b8da42757 application_site_category module (#61288)
* application_site_category module

* add '-'

* update examples

* list to dict
2019-08-29 09:30:36 +05:30
723b955e95 threat_protection_override module (#61481) 2019-08-29 09:29:52 +05:30
51e696cecf Improving na_ontap_command module (#60471)
* Improving na_ontap_command

- new option 'return_dict': true|false
- module returns parseable dictonary data instead of raw XML output when return_dict: true

* Fix module documentation typo

* Fixing pull request comments

* Python lint

* smaller try blocks
2019-08-28 23:59:04 -04:00
35ab955885 access_role module (#61282)
* access_role module

* add '-'

* update examples

* list to dict
2019-08-29 09:28:40 +05:30
a26ff97de6 threat_indicator module (#61278)
* threat_indicator module

* remove _

* add '-'

* update examples

* fix
2019-08-29 09:27:46 +05:30
7f344b7729 host module (#61277)
* host module

* add '-'

* update examples

* fix
2019-08-29 09:26:11 +05:30
7b2a52651c service_udp module (#61276)
* service_udp module

* add '-'

* update examples

* fix
2019-08-29 09:22:50 +05:30
64adad1aa2 service_tcp module (#61275)
* service_tcp module

* add '-'

* update examples

* fix
2019-08-29 09:21:53 +05:30
19d91f6ee1 group module (#61274)
* group module

* add '-'

* update examples

* fix
2019-08-29 09:21:01 +05:30
a27711bfeb application_site module (#61287)
* application_site module

* add '-'

* update examples

* list of objects

* fix example
2019-08-29 09:20:21 +05:30
e7931d8074 access_rule module (#61281)
* access_rule module

* remove :

* fix to pass tests

* don't start line with quote (")

* remove redundant indentation

* return the origin description

* don't start line with quote (")

* enable longer lines, add '-'

*  adding state: present

* update examples

* dict to list

* list to dict

* Update cp_mgmt_access_rule.py

* remove rule_number
2019-08-29 09:18:37 +05:30
09f4acbe51 threat_rule module (#61280)
* threat_rule module

* remove :

* insert to list

* remove redundant indentation

* Revert "insert to list"

This reverts commit de08dfdf32.

* enable longer lines, remove present, add '-'

* state: present

* update examples

* list to dict

* remove rule_number
2019-08-29 09:16:50 +05:30
86aab259fc Minor bug fixes - 3 (#61458) 2019-08-29 09:16:06 +05:30
9f006dd8c7 new module netapp csv pools for aws (#61340)
* new module cvs pools

* fixes

* updates

* fixes

* fixes

* fixes
2019-08-28 23:30:45 -04:00
ed46f83905 Fix paths in sanity tests. 2019-08-28 20:06:22 -07:00
4879cf8fff new module: Cloud Volume for AWS FileSystems (#61343)
* new module"

* fixes

* updates
2019-08-28 23:02:15 -04:00
81ca44b7e5 Change location of collections tests.
The directories used for collections tests are changing as follows:

`test/` -> `tests/`
`test/results/` -> `tests/output/`

This is a breaking change for collections tests executed by ansible-test.
All collections will need to be updated to use the new directory.

The `tests/output/` directory should be added to the `.gitignore` or equivalent in each collection.

This change is being made before the first pre-release of Ansible 2.9 since ansible-test has not yet been shipped.
Using the `tests/` directory matches the other collections directories `plugins/` and `roles/`.

This resolves https://github.com/ansible/ansible/issues/60218
2019-08-28 19:15:36 -07:00
460b583dff Improve ansible-test --venv error handling.
This allows it to fall back to virtualenv when venv is broken.
2019-08-28 16:50:42 -07:00
a6f828e2ab Reordering entries. (#61491) 2019-08-28 18:49:14 -05:00
51b33b79c0 T woerner max concurrent (#60702)
* play, block, task: New attribute forks

With this it is possible to limit the number of concurrent task runs.
forks can now be used in play, block and task. If forks is set in different
levels in the chain, then the smallest value will be used for the task.

The attribute has been added to the Base class as a list to easily provide
all the values that have been set in the different levels of the chain.

A warning has been added because of the conflict with run_once. forks will
be ignored in this case.

The forks limitation in StrategyBase._queue_task is not used for the free
strategy.

Signed-off-by: Thomas Woerner <twoerner@redhat.com>

* Handle forks in free strategy

The forks attribute for the free strategy is handled in run in the free
StrategyModule. This is dony by counting the amount of tasks where the uuid
is the same as the current task, that should be queued next. If this amount
is bigger or equal to the forks attribute from the chain (task, block,
play), then it will be skipped to the next host. Like it is also done with
blocked_hosts.

Signed-off-by: Thomas Woerner <twoerner@redhat.com>

* Test cases for forks with linear and free strategy

With ansible_python_interpreter defined in inventory file using
ansible_playbook_python.

Signed-off-by: Thomas Woerner <twoerner@redhat.com>

* Changing forks keyword to throttle and adding some more docs
2019-08-28 18:47:39 -05:00
7d1a981b61 default collection support (#61415)
* default collection support

* playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles)
* this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection

* ignore bogus sanity error

* filed #61460

* fixed task unit test failure

* don't append an empty collections list to the ds

* ignore leftover local_action in mod_args ds action parsing

* fix async_extra_data test to not require ssh and bogus locale

* disable default collection test under Windows

* ensure collection location FS code is always bytes

* add changelog
2019-08-28 16:31:40 -07:00
caa5abdfc9 Fix TypeError in ec2_group.py for Python3 when sorting dictionary list (#59844)
* Fix TypeError in ec2_group.py for Python3 when sorting dictionary list

* Using json.loads() and dumps() to replace sorting

* Bug fixes for ec2_group.py

* Dictionaries cannot be compared/sorted in Python3

* Diff will occur when the IpPermissions have the same IpRanges but have different ordering

* 'before' will be sorted by 'Type' with high priority than 'IP', but 'boto3.describe_security_groups()' function cannot get 'Type' from Amazon

* Add some basic diff mode testing to exercise the rule-sorting code
2019-08-28 16:28:42 -07:00
8dd79fbbd2 Show doc URL for sanity test failures 2019-08-28 15:32:31 -07:00
4afe757f93 More ansible-test path handling updates. (#61484)
* Move test results vars into layout.

* Add test_path to layout.

* Add sanity_path to layout.

* Clean up layout.

* Update change classification.

* Improve classification layout.

* Relocate common classification code.

* Use is_subdir for relocated code.

* Relocate ansible test/units/compat/ hack.

* Fix variable shadowing.

* Remove unused code.

* Fix ordering of path tests.

* Clean up ansible classification.

* Fix hard-coded plugin paths in classification.

* Relocate more common classification.

* Fix logic.

* Fix pylint issue.

* Add missing licenses classification.
2019-08-28 15:13:00 -07:00
7ff7ce0123 New storage/netapp module - na_ontap_kerberos_realm (#59923)
* New module na_ontap_kerberos_realm

* Copyright updated

* Unit test for modules + fixed required_if parameters issue

* reverting state=modify

* fixing test

* Fixing imports section
2019-08-28 18:03:45 -04:00
8521474f06 Revert "maven_artifact.py - add support for version ranges by using spec (#54309)"
This reverts commit 145a6a8756.
2019-08-28 14:41:11 -07:00
44c18b544f Addition of ECS_Certificate Module (#60883)
* Addition of ecs_certificate module.

* Documentation and code fixes

* Updates per code review

* Doc fixes, rename of chain_path to full_chain_path, add regex for cert_Expiry check

* Fixes to pep8 check to make regexp string 'raw'.

* Mistakes with find/replace of caseing.

* Added integration tests and some doc cleanup

* Some additional assertions and test typo cleanup

* Update lib/ansible/modules/crypto/entrust/ecs_certificate.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Responses to code review comments

* Remove fake passwords from aliases file.
2019-08-28 23:38:48 +02:00
1d9b473e56 Add netapp_e_firmware module (#59529)
* Add na_santricity_firmware module.

Manages NetApp E-Series firmware upgrades.
Includes unit and integration tests.

* Add legacy support to na_santricity_firmware module.

* Rename na_santricity_firmware to netapp_e_firmware

* Improved netapp_e_firmware example documentation.
2019-08-28 17:17:35 -04:00
f02a62db50 Add netapp_e_drive_firmware (#59528)
* Add na_santricity_drive_firmware module

Manage NetApp E-Series drive firmware downloads
Includes unit and integration tests

* Rename na_santricity_drive_firmware to netapp_e_drive_firmware
2019-08-28 17:15:19 -04:00
73248bf27d validate-modules - Use error codes instead of numbers (#60711) 2019-08-28 14:12:56 -07:00
af01cb114c Support galaxy v3/autohub API in ansible-galaxy (#60982)
* Add galaxy collections API v3 support

Issue: ansible/galaxy-dev#60

- Determine if server supports v3

Use 'available_versions' from `GET /api`
to determine if 'v3' api is available on
the server.

- Support v3 pagination style

ie, 'limit/offset style', with the paginated
responses based on https://jsonapi.org/format/#fetching-pagination

v2 galaxy uses pagination that is more or less
'django rest framework style' or 'page/page_size style',
based on the default drf pagination described
at https://www.django-rest-framework.org/api-guide/pagination/#pagenumberpagination

- Support galaxy v3 style error response

The error objects returned by the galaxy v3 api are based
on the JSONAPI response/errors format
(https://jsonapi.org/format/#errors).

This handles that style response. At least for publish_collection
for now. Needs extracting/generalizing.

Handle HTTPError in CollectionRequirement.from_name()
with _handle_http_error(). It will raise AnsibleError
based on the json in an error response.

- Update unit tests

update test/unit/galaxy/test_collection*
to paramaterize calls to test against
mocked v2 and v3 servers apis.

Update artifacts_versions_json() to tale an
api version paramater.

Add error_json() for generating v3/v3 style error
responses.

So now, the urls generated and the pagination schema
of the response will use the v3 version if
the passed in GalaxyAPI 'galaxy_api' instance
has 'v3' in it's available_api_versions

* Move checking of server avail versions to collections.py

collections.py needs to know the server api versions
supported before it makes collection related calls,
so the 'lazy' server version check in api.GalaxyAPI
is never called and isn't set, so 'v3' servers weren't
found.

Update unit tests to mock the return value of the
request instead of GalaxyAPI itself.
2019-08-28 16:59:34 -04:00
f9b0ab774f Minor bug fixes - 3 (#61461) 2019-08-29 01:33:07 +05:30
a1d997cacb Minor bug fixes - 5 (#61462) 2019-08-29 01:19:25 +05:30
59ab4d9307 oVirt: rename _facts -> _info (#61299)
* Rename oVirt _facts -> _info

* Adjust PR #.

* Forgot update BOTMETA / ignore.txt for doc fragment.

* Compatibility for 3rd-party modules using module_utils or info doc fragment.

* Update note.

* Fix/improve docs.

* Update lib/ansible/modules/cloud/ovirt/ovirt_event_info.py

Co-Authored-By: Sloane Hertel <shertel@redhat.com>

* Fix variable.

* Fix return value documentation for ovirt_external_provider_info.
2019-08-28 21:01:46 +02:00
645fe296bd improve list paremeter description. (#60948)
* improve list option description.
2019-08-28 14:52:22 -04:00
08c7c6c204 Minor bug fixes - 1 (#61456) 2019-08-28 23:57:45 +05:30
b47a291d43 Minor bug fixes - 6 (#61464) 2019-08-28 23:30:23 +05:30
35c0782b50 Minor bug fixes - 1 (#61454) 2019-08-28 23:29:21 +05:30
5e200f2d0a Resource Module for exos_lldp_global (#60988)
* Model->Role->Module.
Yet to import modules/exos_facts.py

* exos_facts refactor

* future-import and metaclass

* Fix unit tests

* Fix openconfig-lldp word and send_request API from Httpapi class

idempotent, json.dumps in base class, send_requests from base exos class

* action file for exos_lldp_global

* Add intergration tests for exos_lldp_global

* Test data field of the request
2019-08-28 13:58:45 -04:00
841d204d0d Fixes #61244 (#61432) 2019-08-28 13:53:33 -04:00
b20bfc1048 Bug fixes for GCP modules (#61359) 2019-08-28 13:43:57 -04:00
89744b72d3 os_image_facts: add ability to filter Openstack images based on properties 2019-08-28 13:43:09 -04:00
58edfec145 Add listen_port_facts module (#61463)
Co-authored-by: Nathan Davison <ndavison85@gmail.com>
2019-08-28 13:16:13 -04:00
a7a053defc New module eos_lacp_interfaces (#61349)
* Prepare for lacp_interfaces.

* Import module from builder

* Implement facts

* Implement config

* Add tests
2019-08-28 13:06:45 -04:00
d987dca2b1 VMware: vmware_guest_screenshot module fix get_parent_datacenter issue (#60626)
Fix get_parent_datacenter not found issue, and change "local_path" parameter to "path" type.

closes: #60565
2019-08-28 13:04:30 -04:00
20d9c34862 Fix CI test result placement. 2019-08-28 09:58:00 -07:00
1db78d4ba4 Attempt quick fix for CI failures. 2019-08-28 09:42:23 -07:00
21892aaf51 Correct grammar of contribute-message in footer. (#61414)
Adds a comma to the "you can edit this documentation" message in the footer on every documentation page.
2019-08-28 11:41:07 -05:00
dd3c5500e1 filename attribute (#61426)
Adds missing return key/value 'filename' to the win_find module documentation
2019-08-28 11:35:57 -05:00
3e0891ed39 assign_global_assignment module (#61290)
* assign_global_assignment module

* add short description

* add '-'
2019-08-28 21:59:30 +05:30
e0243520dd address_range module (#61273)
* adress_range module

* adding '-'

*  adding state: present

* update example

* list to dict
2019-08-28 21:53:51 +05:30
1c5a44340e publish module (#61312) 2019-08-28 21:46:58 +05:30
c3d37f39b7 Checkpoint Network module (#61309)
* network module

* delete cp_network, cp_network_facts, and change test_cp_network to match the new network module

* Update ignore.txt

* adding state: present

* update example

* list to dict

* Update test_cp_mgmt_network.py

* remove white-space
2019-08-28 21:46:05 +05:30
830f995ed4 Add a --venv option to ansible-test. (#61422)
* Add --venv delegation to ansible-test.

* Update import sanity test venv creation.

* Fix import test when using --venv on Python 2.x.

* Improve virtualenv setup overhead.

* Hide pip noise for import sanity test.

* Raise verbosity on venv info messages.

* Get rid of base branch noise for collections.

* Add missing --requirements check.
2019-08-28 09:10:17 -07:00
8ebed4002f Add tray/drawer loss protection preference and integration tests to netapp_e_storagepool module. (#60151) 2019-08-28 12:02:46 -04:00
076726aa08 Typo in example for ios_l2_interface - allow_vlans (#61366) 2019-08-28 12:00:08 -04:00
95ecf24b87 New module eos_lldp_interfaces (#61341)
* Prepare existing files for lldp_interfaces

* Initial commit of scaffolding

* Implement facts

* Implement config

* Add tests

* Appease Shippable
2019-08-28 11:56:43 -04:00
92d57796dd Update Ansible sphinx theme to rtd theme version 0.4.3 (#61189)
* update theme.conf, header, footer, etc.
* clean up layout.html
* move large Ansible changes out of theme.css
* maxify theme to help merge
* remove redundancies, fix top nav bar
* add Ansible color to header and left-nav menu
2019-08-28 10:47:11 -05:00
49cff3d4a6 New options to Interface (#60499)
* update to interface

* force ansibot to run again

* fixes
2019-08-28 11:45:15 -04:00
c6710ebf6b Auto support logs were not being created (#60901)
* Auto support logs were not being created

* fixes
2019-08-28 11:23:54 -04:00
f872c61712 Added integration tests for the following modules: (#55523)
- exos_facts
- exos_command
- exos_config
2019-08-28 10:48:32 -04:00
7a1237781d Files from PR#60621, continue working on fortios_facts modules (#61405)
* Files from PR#60621, continue working on fortios_facts modules

* PR#61405 unit test module test_fortios_facts.py

* sanity fixed in test_fortios_facts unit test module
2019-08-28 19:58:41 +05:30
add33ccbdc Fix exos_facts httpapi (#61198) 2019-08-28 10:24:45 -04:00
f4fa4e4e0e Feature/onyx wjh upstream (#61269)
* support wjh module config with testing file

* Fix version, fix enable/disable all groups

* refactor get current group status

* fix indentation and change command_generate function, add test cases and check them

* Update onyx_wjh.py

fix description

* Update onyx_wjh.py

remove extra spaces, add type to choices after run validate-modules

* fix format string - pytest use 2.6.6 format function

* Remove unused imports

* chenge onyx_wjh file permessions

* Fix version, fix enable/disable all groups

* fix indentation and change command_generate function, add test cases and check them

* support wjh module config with testing file

* Fix version, fix enable/disable all groups

* refactor get current group status

* fix indentation and change command_generate function, add test cases and check them

* Update onyx_wjh.py

fix description

* Update onyx_wjh.py

remove extra spaces, add type to choices after run validate-modules

* fix format string - pytest use 2.6.6 format function

* fix format string - pytest use 2.6.6 format function

* chenge onyx_wjh file permessions
2019-08-28 19:41:56 +05:30
8d167bdaef Deprecate alias 'thirsty' from all usages (#61245)
* Deprecate alias 'thirsty' from all usages

Fixes: #61236

* Now with added version quoting

* Handle deprecated aliases in mod_utils

* Make alias deprecation a subkey of the canonical arg, and not a separate argument
2019-08-28 08:27:08 -05:00
73767778e0 icx: new module icx_lldp (#61310)
* new module

* icx_cliconf

* icx test units module

* icx units module

* added notes

* new changes

* new module

* new fix

* new changes

* new fixes

* new changes

* Rebase
2019-08-28 18:26:31 +05:30
a95f9c6640 Win setup processor (#61425)
* Fix incorrect processor information

Fixes Issue #45869 
Windows Processor Information Incorrect from Setup

* set ansible_processor as list of all cores and threads (mirroring POSIX facts)

* change to $win32_cs.NumberOfLogicalProcessors to calculate $cpu_list

* Simplify vcpus count source

Co-authored-by: Jesse Kaufman <jesse.kaufman@gmail.com>
2019-08-28 21:29:10 +10:00
161c1ce17e Rename Azure modules: "facts"->"info" (#61417)
* rename

* add symlink

* add the log

* fix the ignore file

* fix

* fix
2019-08-28 19:01:10 +08:00
a6f6256a0a new module postgresql_publication (#59439)
* new module postgresql_publication: initial commit

* new module postgresql_publication: add seealso section

* new module postgresql_publication: fix RETURN section, fix typo

* new module postgresql_publication: add __exec_sql method

* new module postgresql_publication: fix typos

* new module postgresql_publication: fix typos

* new module postgresql_publication: fix typos
2019-08-28 10:24:59 +02:00
da762018e8 FortiOS modules for 2.9 - 11 (#61387) 2019-08-28 13:24:59 +05:30
f5d829392a Overhaul ansible-test test path handling. (#61416)
* Remove .keep files from test/results/ dirs.

* Remove classification of test/results/ dir.

* Add results_relative to data context.

* Use variables in delegation paths.

* Standardize file writing and results paths.

* Fix issues reported by PyCharm.

* Clean up invocation of coverage command.

It now runs through the injector.

* Hack to allow intercept_command in cover.py.

* Simplify git ignore for test results.

* Use test result tmp dir instead of cache dir.

* Remove old .pytest_cache reference.

* Fix unit test docker delegation.

* Show HTML report link.

* Clean up more results references.

* Move import sanity test output to .tmp dir.

* Exclude test results dir from coverage.

* Fix import sanity test lib paths.

* Fix hard-coded import test paths.

* Fix most hard-coded integration test paths.

* Fix PyCharm warnings.

* Fix import placement.

* Fix integration test dir path.

* Fix Shippable scripts.

* Fix Shippable matrix check.

* Overhaul key pair management.
2019-08-27 23:40:06 -07:00
bf108ee7bf Adding snapshot module (#61418)
* adding snapshot module

* adding snapshott module

* updates

* updates

* positional args
2019-08-28 14:17:40 +08:00
768dbe5490 Add support for network_cli connection retry (#61103)
* Add support for network_cli connection retry

*  Add network_cli connection configuration option
   to allow retrying the connection initialization
   with remote host.

* Add docs

* Fix test failures

* Fix review comments
2019-08-28 09:46:42 +05:30
ee3e8704e8 icx: new module icx_interface (#60037)
* new module

* new module

* new module

* new terminal

* new terminal

* new terminal

* new terminal

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* icx banner unit test

* PR changes resolved

* PR changes resolved

* changes resolved

* changes resolved

* Changes Resolved

* Changes Resolved

* check_running_config changes resolved

* check_running_config changes resolved

* check_running_config changes resolved

* added notes

* added notes

* new changes

* PR comments resolved

* new module icx_interface

* new module icx_interface

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new fix

* new fix

* new fix

* new fix

* new fix

* new fix

* new fix

* new fix

* new fix

* new fix

* new fix

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* notes updated

* Update icx.py

* Whitespace error
2019-08-28 09:03:50 +05:30
746acccc64 Branch icx l3 interface new (#61363)
* new module

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* added notes

* new changes

* New branch to prevent complex rebase

* Rebase had problems
2019-08-28 08:59:57 +05:30
6ee61f28da added gcp_storage_file lookup plugin (#56754)
* added gcp_storage_file lookup plugin

* updated to remove shebang and clean header

* clean header
2019-08-27 19:12:36 -07:00
f510d59943 Support relative imports in AnsiballZ. (#61196) 2019-08-27 18:11:21 -07:00
5549788c8d win_updates: Add flag to only download updates without installing them (#58631)
* win_updates: Add flag to only download updates without installing them

* Fix test

* Fixes ansible-test (pep8)

* Fix integration test

* Fix actual fix.
2019-08-28 09:46:59 +10:00
03bbba4a9f win modules - standarize regex and regxp as alias (#59037)
* win modules - standarize regex  and regxp as alias

* Changes to reflect desired state

* Update parameter names of funtions

* Update main.yml

* Update win_lineinfile.py

* Update win_wait_for.py
2019-08-28 09:38:23 +10:00
66f52b74b1 Change collection PS util import pattern (#61307)
* Change collection PS util import pattern

* Add changes for py2 compat

* fix up regex and doc errors

* fix up import analysis

* Sanity fix for 2.6 CI workers

* Get collection util path for coverage collection
2019-08-27 16:02:27 -07:00
eaa6848932 Allow password to be null in Scheduled Task for gMSA (#60990)
* Allow password to be null in Scheduled Task for gMSA

* Remove test for removed password validation, linting fixes
2019-08-28 08:44:45 +10:00
0914cdb345 New module to allow two FlasArrays to connect ready for replication (#60293) 2019-08-27 18:32:12 -04:00
2abbc136b1 New module to manage SNMP managers in Pure Storage FlashArray (#59203) 2019-08-27 18:32:00 -04:00
8d8f501968 New module for Pure Storage FlashBlade Remote Assist control (#59261) 2019-08-27 18:31:56 -04:00
e186329ee5 Added Notes (#61315)
##### SUMMARY
<!--- Your description here -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-28 08:15:30 +10:00
a6f585eb62 remove the word "support" from Windows pages, add Windows Server 2019 (#61404)
* remove support from Windows pages, add Windows Server 2019

* jborean feedback

* Removed CBT info

Removed the CBT note about what transports Ansible actually supports. We've worked with both NTLM and Kerberos for a while now.
2019-08-28 08:05:12 +10:00
21f0c0f42f Change references to ansible_facts (#61353) 2019-08-27 18:00:25 -04:00
948023176e Changes references to ansible_facts (FA_RA) (#61355) 2019-08-27 18:00:12 -04:00
05afc28d08 Changes references to ansible_facts (FB_S3USER) (#61356) 2019-08-27 18:00:01 -04:00
a09d1e038d New module to set SMTP config for Pure Storage FlashArray (#58899) 2019-08-27 17:45:17 -04:00
ff94dedf19 New module to set alert email addresses for Pure Storage FlashArray (#57864) 2019-08-27 17:44:55 -04:00
c2f468552d New module for SMTP configuration on Pure Storage FlashBlade (#59270) 2019-08-27 17:44:24 -04:00
f4d336cf1f New module to manage volume groups on Pure Storage FlashArray (#58854) 2019-08-27 17:44:04 -04:00
41778a8e12 Add azure resource lock module (#55700)
* add locks

* rename the module

* add test

* add test

* address comments

* add quote

* can list child scope lock

* minor docs tweaks

* Add files via upload (#62)

* change '\r\n' to '\n' (#63)

* Small changes, just to trigger CI verify.

* trigger CI verify

* remove 's'

* Update according by comments

* change small for trigger CI check
2019-08-28 05:35:12 +08:00
31a1eadab2 Add the azure_rm_azurefirewall_info module (#58697)
* add the info module of azure firewall

* fix the format_item()

* add the test

* fix the indented line

* fix

* fix the test

* change the test file
2019-08-28 05:23:29 +08:00
c9a9bd9d64 OneView: rename _facts -> _info (#61208)
* Rename OneView _facts modules -> _info

* Adjust PR #.

* Forgot to update test names.

* Remove superfluous blank line.

* Some more things from review.
2019-08-27 23:21:40 +02:00
6ad40fd6b8 removes the word 'support' from appendix pages (#61409) 2019-08-27 17:11:53 -04:00
758c63e4fb added gcp_kms filters filter plugin (#56755)
* added gcp_kms filters filter plugin

* update filter header

* remove requests
2019-08-27 14:09:18 -07:00
faaa669764 PowerShell - Added coverage collector (#59009)
* Added coverage collection for PowerShell - ci_complete ci_coverage

* uncomment out coverage uploader call

* Generate XML for PowerShell coverage

* Use whitelist to exclude coverage run on non content plugins

* Remove uneeded ignore entry

* Try to reduce diff in cover.py

* Fix up coverage report package - ci_complete ci_coverage
2019-08-28 07:03:23 +10:00
5438013191 Rename Azure modules: facts -> info (#60987) 2019-08-28 04:44:57 +08:00
2db4e044ab smartos_image_facts: rename to smartos_image_info (#60915)
* Rename smartos_image_facts -> smartos_image_info

* Add changelog.
2019-08-27 16:43:10 -04:00
e176023c6b Scaleway: rename _facts -> _info (#61095)
* Rename scaleway _facts -> _info

* Add changelog.

* Improve docs.
2019-08-27 16:39:24 -04:00
185a1fcb07 Online: rename _facts -> _info (#61091)
* Rename online _facts -> _info

* Add changelog.
2019-08-27 16:36:55 -04:00
489156378c Meraki - Enable API call rate limiting for requests (#54827)
* Initial commit for rate limiting
- Detects if error code is 429
- Pauses for random time between .5 and 5 seconds before retrying
- If it fails 10 times, give up and tell user

* Redo structure of request() to support rate limiting

* Hold down timer is now a sliding scale
- 3 * number of retries
- Fails after the 30 second wait

* Whitespace fixes

* Redo implementation using decorators
- Errors aren't tested but code works for regular calls

* Unit tests work for error handling

* Add integration tests for successful retries

* Add condition for 502 errors and retry

* Move _error_report out of the class

* PEP8 fixes

* Add changelog entry
2019-08-27 16:32:09 -04:00
5ee81338fc Remove unused import in junos/utils/utils.py (#61384)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-27 15:56:39 -04:00
5a60bdd308 Remove unsed / duplicate imports for iosxr module_utils (#61385)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-27 15:55:31 -04:00
32eeeab831 Revert "Disable Hetzner Cloud integration tests due to authentication issues (#61375)" (#61383)
This reverts commit 31b49334b9.
2019-08-27 15:30:28 -04:00
1906c05348 vertica_facts: rename to vertica_info (#60916)
* Rename vertica_facts -> vertica_info

* Add changelog.

* Fix porting guide.
2019-08-27 21:28:36 +02:00
0696fcacf0 Update _ios_l2_interface.py (#61401)
Add support for TwoGigabitEthernet switchports in IOS-XE
2019-08-28 00:51:15 +05:30
e7a9d71ac0 ansible-test: async deployment w/ vcenter provider (#59984)
ansible-test: async deployment w/ vcenter provider

So far, `ansible-test`'s vcenter provider was trigger by a blocking POST
call. Since the depoyment take a lot of time (> 8m), we decided to use
an async call instead and poll the API server until the deployment
is ready.
2019-08-27 14:56:43 -04:00
e8586114ad Move instantiation of terminal plugin earlier (#61261)
* Move instantiation of terminal plugin earlier

* Move test for invalid network_os to where the failure now lives
2019-08-27 14:33:05 -04:00
36f4af203c Add iosxr_lag_interfaces resource module (#61303)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-27 23:01:05 +05:30
a213b9160c Fix extended loop_control with includes (#61231)
* Fix extended loop_control with includes

* Use assert for testing extended loop_control

* fix typo
2019-08-27 12:09:56 -05:00
80b73712a9 Template value of debugger and then check for validity (#53587)
* Template value of debugger and then check for validity

* Removed if/else and forcing failure on undefined as per comments

* Added changelog

* changed colon to brackets so it appears as a string
2019-08-27 12:02:26 -05:00
c1c6e9f008 Add kernel version in ansible facts (#40069) 2019-08-27 11:57:44 -05:00
b47988a8a4 Added more explanation to keypair. (#52766)
* Added more explanation to keypair. 

<!--- Your description here -->

+label: docsite_pr

* Update ec2.py

* Update ec2.py
2019-08-27 11:25:52 -05:00
36b7baca4d getent - add service support(#60295) 2019-08-27 11:58:37 -04:00
c91929b2b3 OpenStack: rename _facts -> _info (#61197)
* Rename openstack _facts -> _info

* Add new module names to module_defaults.yml.
2019-08-27 11:50:14 -04:00
5e4e32b45e FortiOS modules for 2.9 - 10 (#61367)
* FortiOS modules for 2.9 - 10

* Fortios User Device was wrongly set to 2.8 instead of 2.9

* Retriggering shippable due to random failure
2019-08-27 21:07:39 +05:30
d29aaffb16 vmware_guest_disk_info/test: ensure the test VM is running
`vmware_guest_disk_info` expects the VM to be running. Since
964783fbd2, `prepare_vmware_tests`
creates the test VM with the `powered-off` state. This to increase
the performance.

This commit ensures the test-suite actually run against a running VM,
as expected.
2019-08-27 11:31:14 -04:00
ef69f3a3b5 vmware/test: clean up dvswitch_0001 and dvswitch_0002
Ensure `dvswitch_0001` and `dvswitch_0002` won't remain after
`vmware_dvswitch` test execution.
2019-08-27 11:30:44 -04:00
9f8a0f4ace Added vserver to lun_info field to ensure unique LUN dict keys (#61357) 2019-08-27 11:14:59 -04:00
31b49334b9 Disable Hetzner Cloud integration tests due to authentication issues (#61375) 2019-08-27 10:47:08 -04:00
8a7b89c66f Support delegation testing collections with deps.
All collections in the same collection root as the collection being tested will be sent to the remote system/container.
2019-08-27 07:29:42 -07:00
27cac742ca Fix pipelining in buildah connection plugin (#59745)
* Fix pipelining in buildah plugin

* Add changelog fragment
2019-08-27 10:11:47 -04:00
b563f7f880 Add aci_l3out_extsubnet.py (#58087)
* Add aci_extsubnet.py

* Fix aliases of network option

* Shorten the sentence

* Rename to aci_l3out_extsubnet

As suggested during review.

* Rename module
2019-08-27 15:55:46 +02:00
f3bde056b5 aci_maintenance_group_node - Fix "target_filter" (#58675)
* aci_maintenance_group_node - Fix "target_filter"

##### SUMMARY
Fixes target_filter issue that causes the module to fail.

##### ISSUE TYPE

* Use the correct target_filter syntax

So we did not just rename `filter_target` to `target_filter`, the content is also different.
2019-08-27 15:10:47 +02:00
36add6e86f New Module: na_ontap_ndmp (#59815)
* new module

* fixes

* fixes

* fix unit tests

* update tests

* fixes
2019-08-27 09:06:59 -04:00
0e906b0865 bug fixes for group (#60887)
* bug fixes for group

* trigger rebuild

* fixes
2019-08-27 09:05:20 -04:00
37dd373c6b Volume dev upstream new options (#59660)
* Add controller ownership and cache without batteries option

* Add unit test for new netapp_e_volume options

* Add integration tests for netapp_e_volume module.

* Changed default read_ahead_enable option to true in netapp_e_volume module.

* Fix off-segment aligned volume size in netapp_e_volume module.
2019-08-27 09:04:02 -04:00
61a2dab2ff postgresql modules: add seealso section (#61368) 2019-08-27 13:20:34 +01:00
dfd1b29777 Add aci_vmm_credential.py (#60910)
* add module to create aci VMM credential objects
add initial remove and add integration tests for VMM credential objects

* update 'credential' var name to 'name'

* move vmware tests to domain type specific file

* move vmware tests to domain type specific file
add include task in main file to reference domain type specific tests

* update task names
add test to remove credential prior to first credential add
add tests for querying individual credentials
add tests for query all credentials
add additional tests for removing credentials

* update version added to 2.9
remove invalid module references from 'seealso' section

* fix list reference in query all assertions

* add reference to VM_PROVIDER_MAPPING keys for vm_provider arg
2019-08-27 14:08:24 +02:00
b53bc94cc5 Resource module for iosxr_l2_interfaces (#59964)
* iosxr_l2 resource
2019-08-27 17:20:47 +05:30
dbd3ace53e added resources to associate domain to EPG (#60571) 2019-08-27 13:41:13 +02:00
d77697e4d5 FortiOS System Fimrware Upgrade Module (#59213)
* FortiOS System Fimrware Upgrade Module

* default timeout 12 seconds is not enough for large firmware or slow connection, increase it to 300 seconds

* update fortios system firmware upgrade module together with unit test

* minor updates based on the new templates

* minor updates and remove fortiosapi dependency in unit test module

* add author, remove unused method, fix descriptions, apply some sanity fixes
2019-08-27 15:58:07 +05:30
e62fb1e2f9 FortiOS modules for 2.9 - 9 (#61320)
* FortiOS modules for 2.9 - 9

* Undo ignore file

* Remove non valid identifiers

* Leave fortios_switch_controller_lldp_profile and fortios_switch_controller_managed_switch out of this PR

* Updated fortios_switch_controller_lldp_profile and fortios_switch_controller_managed_switch
2019-08-27 15:57:34 +05:30
0074fa5672 Fix typo in postgresql_privs.py (#61365)
##### SUMMARY
Change 'default_prives' to 'default_privs'


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-27 06:05:39 -04:00
b24e1c0077 lag config changes (#61361)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-27 15:26:12 +05:30
ee05d6bde2 Added nxos_lldp_global resource module (#60072)
* Added nxos_lldp_global module

Tests

Correction

remove q

* Added tests

* Corrections

Changes

Last few changes please

Final

Finall

Finalll

* Key error and punctuation changes

* .gitignore edit

* Facts file edit

* Changed facts collection and 'replaced' state

Changed facts collection and replaced state

Changed facts collection and replaced state

* Spacing and module error correction

* return facts as empty dict not list

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-27 14:52:24 +05:30
233a3088f4 postgresql_db: add seealso section (#61360) 2019-08-27 09:11:09 +02:00
cca95e323d postgresql_copy: add seealso section (#61314) 2019-08-27 09:10:59 +02:00
c0046e7f52 adding 3 new methods, get to retrieve configurational data, monitor to retreieve operational data, execute to perform action (#61331) 2019-08-27 12:24:07 +05:30
adb8a0ddc6 Pluribus Networks log audit exception module with unit test cases (#60456)
* Pluribus Networks log audit exception module with unit test cases

* Documentation fix
2019-08-27 11:31:54 +05:30
e7cb2ddc9c Pluribus Networks vtep module with unit test cases (#60455) 2019-08-27 11:26:13 +05:30
2a13ad7adf Fix junos resource modules group based config and minor updates (#61224)
* Fix junos resource modules group based config and minor updates

Fixes https://github.com/ansible/ansible/issues/61183

*  Add support to get inherited configuration for resource
   modules to handle group based configuration
*  Add task input check for merged, replaced and overridden
   states in junos resource modules
*  Integration test for group based configuration

* Fix CI test failures

* Fix test failures
2019-08-27 11:06:06 +05:30
f2c4875fbe Remove unnecessary code (#61350) 2019-08-27 01:27:59 -04:00
b4732dd2e6 Support Azure IoT hub and related module (#55121)
* Support iothub creation

* raise errordetailexception rather than clouderror

* add facts

* change requirement

* compare endpoint

* add documentation

* add documentation

* add iot device facts

* modify line ending

* add auth method

* add iot module

* add consumer group

* add the test

* enhencement of  doc

* add list consumer groups

* fix lint

* fix lint

* fix doc

* fix doc

* Update auzre_rm_iothub related document

* changed paramter's type

* update type

* rename facts -> info

* fixed sanity

* missed during merge
2019-08-27 13:18:28 +08:00
6fb7073adc Fortinet: FortiAnalyzer Plugin and Module Utils and FAZ_DEVICE update. (#58882)
* FortiAnalyzer Plugin and Module Utils and FAZ_DEVICE update.

* Updated Version Added for plugin.

* Removed stray characters (new keyboard... leaned on a key to hard...). DOH!

* Minor fix to documentation

* Added __metaclass__ = type per Sanity/1 test failure of last test.

* Minor PEP8... should be last one

* Same PEP8 Fix for Common...

* Minor change to kick off another shippable after an obscure OS X error.

* Last Shippable showed "unstable" but didn't give any other reasons. Kicking off YET ANOTHER.

* Once again, shippable is erroring on unrelated issues and modules. Minor Docs change to kick it off again.

* Shippable, again, failed to find the commit. Minor doc change to kick it off again.

* Small doc change to kick off shippable. A single test is ending up "unstable" for RHEL...
2019-08-27 10:22:42 +05:30
b09db0ba9e icx: new module icx_user (#60007)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* test

* Revert "test"

This reverts commit 99b72c6614.

* new module icx_user

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* changes

* changes

* new fixes

* new changes

* notes updated
2019-08-27 09:25:56 +05:30
a68d91d0a7 Fortinet's new module for fortios_wireless_controller_hotspot20_hs_profile (#61163)
* Fortinet's new module for fortios_wireless_controller_hotspot20_hs_profile

* Update fortios_wireless_controller_hotspot20_hs_profile.py and test_fortios_wireless_controller_hotspot20_hs_profile.py
2019-08-27 09:24:28 +05:30
cca4eb71e3 Update sanity tests for collections. (#61352)
* Remove pointless sanity tests on `bin` dir.

* Update action-plugin-docs test for collections.

* Update no-main-display test for collections.

* Update empty-init test for collections.

* Update no-assert test for collections.

* Move required-and-default-attributes test.

This test only applies to Ansible itself.

* Update use-argspec-type-path test for collections.
2019-08-26 20:40:53 -07:00
b6290e1d15 icx: new module icx_logging (#60036)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* test

* Revert "test"

This reverts commit 99b72c6614.

* new module icx_logging

* new fixes

* new fix

* new fix

* new fix

* new changes

* notes updated
2019-08-27 08:58:32 +05:30
b6e71c5ffb icx: new module icx_copy (#59920)
* new cliconf

* cliconf

* icx cliconf
* icx test units module

* icx units module
* icx banner unit test

* PR changes resolved

* check_running_config changes resolved
* added notes

* removed icx rst

* deleted icx rst

* icx .rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

* new module icx_copy

* notes updated
2019-08-27 08:57:31 +05:30
fb1094f38d icx: new module icx_system (#60024)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* test

* Revert "test"

This reverts commit 99b72c6614.

* new module icx_system

* new changes

* new changes

* new changes

* Fixed bot bugs

* notes updated
2019-08-27 08:55:46 +05:30
d2429cbd6a icx: new module icx_vlan (#59985)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* test

* Revert "test"

This reverts commit 99b72c6614.

* new module icx_vlan

* new changes

* new fixes

* new fixes

* new fixes

* new fixes

* new fixes

* new fixes

* Fixed bugs

* Fixed bot bugs

* Fixed bot bugs

* Fixed bot bugs

* Fixed bot bugs

* Fixed bot bugs

* Fixed bot bugs

* Fixed bot errors

* notes updated
2019-08-27 08:31:17 +05:30
13e5ec781c ignore wwitzel3 for ansible_tower modules in BOTMETA (#61351) 2019-08-26 20:31:31 -04:00
1c06b302bc Support automation account managment (#56429)
* add automation account

* add test

* update sdk version

* fix doc

* Update azure_rm_automationaccount.py

* Update azure_rm_automationaccount_facts.py

* Update main.yml

* add type define (#64)

* add new (#67)

* change 'example' to 'sample'

* changed 'path' to 'ID'
2019-08-27 07:38:47 +08:00
ab559c4629 Remove 'network-interface' for tag_specifications (#53398)
* Remove 'network-interface' for tag_specifications

https://github.com/aws/aws-cli/issues/2865

* changelog
2019-08-26 19:37:00 -04:00
954416932a route53: optimize zone_id lookup when hosted_zone_id is provided (#60437) 2019-08-26 16:21:17 -07:00
e258ba703e Improve ansible-test env display. (#61339)
* Improve ansible-test env display.
* Fix PyCharm warnings.
* Fix ansible-test ansible-doc sanity test with -e.
2019-08-26 14:02:55 -07:00
749662d776 add azure monitor log profile module (#54702)
* add azure monitor log profile module

* fix version

* fix lint

* mark test as unsupported

* fix lint

* fix lint

* Fix the error prompted in the comments
2019-08-27 05:00:28 +08:00
b335303471 fix keyvault secret bug (#60754)
* fix keyvault secret bug

* remove unexpected spaces
2019-08-27 04:56:54 +08:00
aa5a221ddc Bug fixes for GCP modules (#61094) 2019-08-26 15:04:52 -04:00
1631554c1b Bug fixes for GCP modules (#61251) 2019-08-26 15:04:24 -04:00
8ee7d9f598 VMWare - Rename _facts to _info (#57474)
Deprecate vmware's _facts modules and add new modules.

Fixes: #57278
2019-08-26 14:45:34 -04:00
47c2ff4c26 Redfish modules: rename _facts -> _info (#60992)
* Rename redfish_facts -> redfish_info, idrac_redfish_facts -> idrac_redfish_info

* Update porting guide.

* Add changelog.

* Fix metadata.

* Remove copy artefacts.

* Change from deprecate/new module to rename.
2019-08-26 20:42:04 +02:00
191aa11483 Bug fixes for GCP modules (#61093) 2019-08-26 13:28:40 -04:00
afa84af91d New Module: gcp_kms_key_ring_info (#61099) 2019-08-26 13:28:28 -04:00
e5595f1117 gcp_compute refactor (#61249)
* wip

* it works!

* cache should work

* ran black on code

* wip

* now it works

* black
2019-08-26 13:27:44 -04:00
30714682c9 Fixes iosxr interfaces zuul failure (#61313)
* fixes 61311

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix loopback

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-26 22:25:43 +05:30
e536d0e128 openssl_*: deprecate PyOpenSSL backends (#59907)
* Deprecate PyOpenSSL backends.

* Add changelog.

* Add porting guide entry.

* Improve tests to ignore deprecations when comparing results.

* Deprecating pyopenssl backend for get_certificate and openssl_publickey.

* Fix typo.
2019-08-26 18:26:10 +02:00
7f4f2506a0 acme_certificate: make compatible to Buypass' ACME v2 testing endpoint (#60727)
* Don't unnecessarily use location from header.

* Add changelog.
2019-08-26 18:19:55 +02:00
039123ec6b acme_account_info: retrieve orders (#59697)
* Add retrieve_orders option.

* Run acme_certificate tests also for acme_account_info; use acme_account_info to get list of orders.

* Doing some quoting.

* Improve returned description.
2019-08-26 18:16:43 +02:00
14974f5fc2 openssl_certificate_info: add ocsp_uri return value (#60393)
* Add ocsp_uri return value.

* Add changelog.

* Add integration test.

* Fix rebase error.
2019-08-26 17:42:52 +02:00
a567a3fae0 New module eos_lldp_global (#60975)
* New module eos_lldp_global

* Implement facts

* Implement config, add tests

* Assorted fixes
2019-08-26 11:34:41 -04:00
0b284c1431 Cast booleans to strings. (#60544)
This avoids an error when building the API request:

TypeError: Argument must be bytes or unicode, got 'bool'

This would occur when one explicitly sets async_bool or ignore_owners in
a playbook/role.
2019-08-26 11:32:14 -04:00
7cefef9719 Adding new options to na_ontap_nfs module (#59505)
* Adding new options to na_ontap_nfs module

- nfsv4_fsid_change
- nfsv4_numeric_ids
- nfsv40_referrals
- nfsv41_pnfs
- nfsv41_referrals

* Adding version_added: '2.9' for new options
2019-08-26 10:22:45 -04:00
f62f1ab54c Added comment field to na_ontap_volume module (#59566)
* Added comment field to na_ontap_volume module

* fixed zapi attribute name in create_volume_options(), and fix to ensure comment field can be set back to an empty string
2019-08-26 10:14:39 -04:00
7f06db8211 module_utils/redfish_utils.py: add ForceRestart option (#61104)
The library does not allow you to force a restart via redfish, (unless GracefulRestart
triggered by PowerReboot-command is not supported).
Therefore, I added the option `PowerForceRestart` to be able to force a reboot of an
unresponsive host.
2019-08-26 10:13:09 -04:00
5941e4c843 Properly JSON encode AnsibleUnsafe, using a pre-processor (#60602)
* Properly JSON encode AnsibleUnsafe, using a pre-processor. Fixes #47295

* Add AnsibleUnsafe json tests

* Require preprocess_unsafe to be enabled for that functionality

* Support older json

* sort keys in tests

* Decouple AnsibleJSONEncoder from isinstance checks in preparation to move to module_utils

* Move AnsibleJSONEncoder to module_utils, consolidate instances

* add missing boilerplate

* remove removed.py from ignore
2019-08-26 09:08:22 -05:00
1d405fdd60 Add module aliases back in hardcoded module_defaults list (#61203) 2019-08-26 10:05:57 -04:00
53df4d8186 New options for identity_preserve (#60498)
* new option

* Force ansibot to run again
2019-08-26 10:03:26 -04:00
930088da96 Clarifying: no lists in name parameter (#61029)
* Clarifying: no lists in name parameter
2019-08-26 10:02:37 -04:00
0ac57941c1 VMware: Add missing HA admission control policies in vmware_cluster_ha (#60233)
* Add missing HA admission control policies
* Add new parameter host_isolation_response
* Bugfix: 'das_vm_config' referenced before assignment
* Implement test cases
2019-08-26 09:40:38 -04:00
d95a0f235b Fortinet's new module for fortios_user_local (#61054)
* Fortinet's new module for fortios_user_local

* New version of fortios_user_local

* Update unit tests with removal of attribute
2019-08-26 18:56:30 +05:30
69fcd771e0 FortiOS modules for 2.9 - 8 (#61308)
* FortiOS modules for 2.9 - 8

* Add missing files

* Fix trailing spaces
2019-08-26 18:55:53 +05:30
f3f30c146b Deprecate net_* modules (#60818)
* Deprecate net_ modules

* Move modules to finish deprecation

* Add missing `why`, move net_static_route

* Add changelogs and porting guide
2019-08-26 09:07:54 -04:00
5a04b4feb6 Add nxos_l2_interfaces resource module (#61120)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-26 16:46:05 +05:30
c729f3ba61 icx: new module icx_facts (#61225)
* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* test

* Revert "test"

This reverts commit 99b72c6614.

* new module icx_facts

* fixtures added

* Rebase causing problem on branch-PR4. So created new PR

* new commit

* new changes
2019-08-26 14:00:00 +05:30
8ed3a0b360 fix bug - k8s was crashing when yaml ended with 3 dashes (#61182)
* fix bug - k8s was crashing when yaml ended with 3 dashes

* #61182 - add changelog
2019-08-26 17:28:01 +10:00
7e1a347695 icx: new module icx_linkagg (#59967)
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_linkagg

* bug fixes

* Fixing bot errors

* Trying to fix aggregate document error

* Added options under aggregate in documentation

* Fixed bot error

* Fixed documentation error

* Fix bot error

* notes updated
2019-08-26 09:12:59 +05:30
20ec927280 icx: new module icx_static_route (#59978)
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_static_route

* new changes

* new changes

* notes updated
2019-08-26 09:12:10 +05:30
48eed0b6c8 adding group parameter for win_firewall_rule (#55109)
* adding group parameter for win_firewall_rule

* integration test fix

* changing the version add to 2.9

* setting group optional

* fix:setting required to optional
2019-08-25 19:10:31 -04:00
9786e2b559 Fix up env config source for Galaxy server list (#61294) 2019-08-26 07:11:35 +10:00
265fcaac40 Add Rest API to DNS (#59937)
* add rest to dns

* fix issues with tests

* fixes to netapp.py

* fixes

* fixes

* add updates

* fix issues
2019-08-25 10:52:01 -04:00
25db0c7678 Added NetApp ONTAP Adaptive QoS Policy Module (#58707)
* Added NetApp ONTAP Adaptive QoS Policy Module

* updated documentation to fix validation errors

* Updates to documentation fields and modified logging function to log against the current vserver

* Fixed minor formatting issues

* Documentation update for consistency - author field

* Empty commit to force CI

* fixes
2019-08-25 10:50:34 -04:00
4e6298b847 AWS dynamic inventory: fixup RDS integration tests (#61259)
* ec2 inventory/rds: (integration tests) migrate to module_defaults and cope with missing security_token

* ec2 inventory/rds: (integration tests) Avoid hard coding the parameter group name

Generated it based on the information returned when creating the RDS instance.

* ec2 inventory/rds: (integration tests) rename templates to .j2 rather than .yml
- avoids throwing yamllint errors
- makes it clear they're templates not the final yaml files.
2019-08-25 10:32:18 -04:00
a6b124cccc FortiOS modules for 2.9 - 7 (#61217) 2019-08-25 12:54:45 +05:30
9d4dcc7506 Remove unused imports from netconf_get (#61265)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 19:47:56 -04:00
2ce091cc86 Remove duplicate imports in iosxr_lldp_interfaces (#61266)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 17:59:51 -04:00
02c38ed4fd Relocate ansible-test self tests outside package. (#61255)
* Relocate ansible-test self tests outside package.

We don't want to include the tests for verifying ansible-test within the ansible-test package.

* Add `test/ansible_test/` to classification.py.

* Fix test invocation.

* Relocate tests in MANIFEST.in.

* Improve package-data sanity test error checking.

* Only use includes for ansible-test in MANIFEST.in.

* Improve readability of MANIFEST.in.
2019-08-24 11:38:30 -07:00
c61dec032c Remove unsed variable is l2_interfaces.py (#61246)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 12:57:17 -04:00
c3b1a0a7e8 Vultr: rename _facts -> _info (#61239) 2019-08-24 17:54:17 +02:00
1fbb930747 Add out-of-tree check to symlinks sanity test. 2019-08-24 07:25:35 -07:00
2a9b996bd2 Use .cfg extension for pylint configs. 2019-08-24 07:25:19 -07:00
11d82d70eb Remove duplicate imports from iosxr_lacp_interfaces (#61258)
This cleans up linting for our new iosxr collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 10:12:29 -04:00
6ec0b4ec86 Sanity test updates for collections support. (#61248)
* Run no-unwanted-files sanity test only on Ansible.

Since collections should be able to use binary modules there is not really any limit on what could exist in a collection `plugins` directory.

* Add support for symlinks in sanity target lists:

- Sanity tests that need to analyze symlinks can do so using the supplied target list.
- Tests that analyze directories will now only look at symlinks if requested.
- Directory symlinks will now be seen as directories instead of files.

* Enable symlinks on filename based sanity tests.

Sanity tests that evalulate filenames instead of content should include symlinks.

* Update symlinks sanity test.

Use the sanity test target list now that it can include symlinks.
2019-08-23 18:08:21 -07:00
5434bf74c6 Fix issues with aws_kms when working cross-account and with IDs (#60805)
* aws_kms: (integration tests) Test updating a key by ID rather than just my alias

* aws_kms: (integration tests) Test deletion of non-existent and keys that are already marked for deletion

* aws_kms: Ensure we can perform actions on a specific key_id rather than just aliases

In the process switch over to using get_key_details rather than listing all keys.

* aws_kms: When updating keys use the ARN rather than just the ID.

This is important when working with cross-account trusts.
2019-08-23 16:56:45 -07:00
4551965af1 ACME modules: bump test container version (#61192)
* Fix root cert path.

* Bump testing container version.

* Improve check (needed due to letsencrypt/pebble#257).
2019-08-23 15:30:28 -07:00
1cf43e5017 Handle multiple Content-Type headers correctly (#31238)
* Handle multiple Content-Type headers correctly

Avoids situations where mulitple Content-Type headers including charset information can result in errors like 
```
LookupError: unknown encoding: UTF-8, text/html
```

* Account for multiple conflicting values for content-type and charset

* Add changelog fragment
2019-08-23 16:48:16 -05:00
943b4f5a83 os_server: keep optional nic args for nics specified using net-name or port-name. (#20969) 2019-08-23 17:00:31 -04:00
fabd912fa5 Fix typo in 'Ansible and Python 3' dev guide (#61226)
The underscore does not need to be escaped inside of the RST inline
literal.
2019-08-23 15:53:25 -04:00
1f733e2d55 ec2_asg: fix the integration tests (#61212) 2019-08-23 14:53:47 -04:00
e4c1c05363 Renaming onepassword_facts to onepassword_info. (#61237)
* Renaming `onepassword_facts` to `onepassword_info`.

* Update module examples.

* Add changelog fragment.

* Add module rename to the 2.9 porting guide.

* Document the parameter types in the module docs.

* Fix incorrect parameter name.

* Update docs/docsite/rst/porting_guides/porting_guide_2.9.rst

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Remove `onepassword_facts` as it has been renamed to `onepassword_info` including fixes for the sanity tests.
2019-08-23 20:45:13 +02:00
d3b493020d New Module: gcp_kms_crypto_key (#61096) 2019-08-23 13:27:46 -04:00
bf514b5717 New Module: gcp_kms_crypto_key_info (#61097) 2019-08-23 13:27:37 -04:00
ba026939bb New Module: gcp_kms_key_ring (#61098) 2019-08-23 13:27:28 -04:00
64312a09c9 Add use_proxy option to httpapi (#59259) 2019-08-23 13:07:52 -04:00
c9f0b0fb42 Resource module for ios_l3_interfaces (#60405)
* ios_l3_interfaces

* fix shippable

* fix tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix ignore txt file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n tests

* fix replace test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix zuul failures

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n zuul

* fix zuul

* fix zuul

* fix zuul test

* fix zuul

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* code zuul fix

* fix merge

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix merge

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-23 22:09:20 +05:30
a275bf1625 added better description on how aggregate functions (#61069) 2019-08-23 08:05:19 -07:00
11ba2a965d platform guide updates (#61121)
* platform guide updates

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-23 20:23:50 +05:30
fa70690e5c openssl_certificate/csr(_info): add support for SubjectKeyIdentifier and AuthorityKeyIdentifier (#60741)
* Add support for SubjectKeyIdentifier and AuthorityKeyIdentifier to _info modules.

* Adding SubjectKeyIdentifier and AuthorityKeyIdentifier support to openssl_certificate and openssl_csr.

* Fix type of authority_cert_issuer.

* Add basic tests.

* Add changelog.

* Added proper tests for _info modules.

* Fix docs bug.

* Make sure new features are only used when cryptography backend for openssl_csr is available.

* Work around jinja2 being too old on some CI hosts.

* Add tests for openssl_csr.

* Add openssl_certificate tests.

* Fix idempotence test.

* Move one level up.

* Add ownca_create_authority_key_identifier option.

* Add ownca_create_authority_key_identifier option.

* Add idempotency check.

* Apparently the function call expected different args for cryptography < 2.7.

* Fix copy'n'paste errors and typos.

* string -> general name.

* Add disclaimer.

* Implement always_create / create_if_not_provided / never_create for openssl_certificate.

* Update changelog and porting guide.

* Add comments for defaults.
2019-08-23 14:01:42 +02:00
77e4371460 aws_kms: Update policy on existing keys (when passed) (#60059)
* aws_kms: (integration tests) Use module_defaults to reduce the copy and paste

* aws_kms: (integration tests) make sure policy option functions.

* aws_kms: (integration tests) Move iam_role creation to start of playbook.

iam_roles aren't fully created when iam_role completes, there's a delay on the Amazon side before they're fully recognised.

* aws_kms: Update policy on existing keys (when passed)
2019-08-23 20:38:38 +10:00
25053827a5 icx: new module icx_config (#59914)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_config

* new changes

* new changes in icx_config

* PR changes

* PR comments resolved

* PR comments resolved

* new changes

* new changes

* Review comments

* updated notes section
2019-08-23 16:02:51 +05:30
f1054f575d bfd_global: minor test-only fix (#60965) 2019-08-23 15:12:59 +05:30
f0ef624cff Add nxos_l3_interfaces resource module (#61021)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-23 15:06:26 +05:30
9d77d06fa4 Fortinet's new module for fortios_user_password_policy (#61055)
* Fortinet's new module for fortios_user_password_policy

* Retriggering due to Shippable failure
2019-08-23 14:55:47 +05:30
a6837609e2 FortiOS modules for 2.9 - 6 (#61170)
* FortiOS modules for 2.9 - 5

* Update fortios_firewall_vip.py

* Update fortios_firewall_vip6.py
2019-08-23 14:54:43 +05:30
2ce3ce8477 Fix zuul error for IOSXR interfaces PRs (#61174)
* fix zuul error

* fix utils
2019-08-23 13:27:07 +05:30
30c9abf6e4 Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type (#61088)
* Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type

* Update fortios_wireless_controller_hotspot20_anqp_ip_address_type.py

* Update fortios_wireless_controller_hotspot20_anqp_ip_address_type.py
2019-08-23 12:23:15 +05:30
ec348bb2ac Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_nai_realm (#61089)
* Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_nai_realm

* Update fortios_wireless_controller_hotspot20_anqp_nai_realm.py

* Update fortios_wireless_controller_hotspot20_anqp_nai_realm.py
2019-08-23 12:21:42 +05:30
eb2e0dcc51 Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_network_auth_type (#61109)
* Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_network_auth_type

* Update fortios_wireless_controller_hotspot20_anqp_network_auth_type.py

* Update fortios_wireless_controller_hotspot20_anqp_network_auth_type.py
2019-08-23 12:04:39 +05:30
bb06aed6d8 Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_roaming_consortium (#61110)
* Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_roaming_consortium

* Update fortios_wireless_controller_hotspot20_anqp_roaming_consortium.py
2019-08-23 11:59:20 +05:30
20327589f7 Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_venue_name (#61112) 2019-08-23 11:57:33 +05:30
e3cf76533c postgresql_user: add groups parameter (#60638)
* postgresql_user: add groups parameter

* postgresql_user: add groups parameter, fail_on_role default True

* postgresql_user: add groups parameter, add changelog fragment
2019-08-23 08:17:23 +02:00
4449f3a815 Fortinet's new module for fortios_wireless_controller_hotspot20_h2qp_conn_capability (#61114)
* Fortinet's new module for fortios_wireless_controller_hotspot20_h2qp_conn_capability

* Update fortios_wireless_controller_hotspot20_h2qp_conn_capability.py
2019-08-23 11:32:52 +05:30
a549969b85 Fortinet's new module for fortios_vpn_certificate_crl (#61124) 2019-08-23 11:28:56 +05:30
81bff01893 Fortinet's new module for fortios_wireless_controller_hotspot20_h2qp_operator_name (#61125) 2019-08-23 11:27:47 +05:30
1d43c15c64 Fortinet's new module for fortios_vpn_certificate_local (#61126) 2019-08-23 11:26:08 +05:30
f5cc653865 Fortinet's new module for fortios_vpn_certificate_ocsp_server (#61128) 2019-08-23 11:24:56 +05:30
ae53e38ceb Fortinet's new module for fortios_vpn_certificate_remote (#61129) 2019-08-23 11:24:01 +05:30
8f61e4e39e Fortinet's new module for fortios_vpn_ssl_web_user_bookmark (#61137) 2019-08-23 11:23:02 +05:30
e637934e2c Fortinet's new module for fortios_waf_main_class (#61139) 2019-08-23 11:21:35 +05:30
d41bf3409d Fortinet's new module for fortios_waf_signature (#61140) 2019-08-23 11:20:22 +05:30
af5324b764 Fortinet's new module for fortios_waf_sub_class (#61141) 2019-08-23 11:18:42 +05:30
7a8f37f9e8 Fortinet's new module for fortios_wanopt_auth_group (#61142) 2019-08-23 11:17:15 +05:30
4b8d32d889 Fortinet's new module for fortios_wanopt_cache_service (#61143) 2019-08-23 11:15:46 +05:30
9a53058dda Fortinet's new module for fortios_wanopt_content_delivery_network_rule (#61144) 2019-08-23 11:09:44 +05:30
2aa52a42a9 Fortinet's new module for fortios_wanopt_peer (#61146) 2019-08-23 11:06:48 +05:30
f3daab328b Fortinet's new module for fortios_wanopt_remote_storage (#61147) 2019-08-23 11:05:48 +05:30
8e89306328 Fortinet's new module for fortios_wanopt_webcache (#61148)
* Fortinet's new module for fortios_wanopt_webcache

* Fix minor typo
2019-08-23 11:04:43 +05:30
456ca6c817 Fortinet's new module for fortios_web_proxy_debug_url (#61149) 2019-08-23 11:03:11 +05:30
b40bab6a11 Fortinet's new module for fortios_web_proxy_forward_server (#61150) 2019-08-23 11:02:16 +05:30
c5bc51e365 Fortinet's new module for fortios_web_proxy_forward_server_group (#61152) 2019-08-23 11:00:29 +05:30
5b9f40ec1a Fortinet's new module for fortios_web_proxy_url_match (#61153) 2019-08-23 10:43:18 +05:30
fa05a7960f Fortinet's new module for fortios_web_proxy_wisp (#61154) 2019-08-23 10:36:23 +05:30
be48bb81ce Fortinet's new module for fortios_wireless_controller_ap_status (#61155) 2019-08-23 10:34:01 +05:30
81617cf084 Fortinet's new module for fortios_wireless_controller_ble_profile (#61156) 2019-08-23 10:32:55 +05:30
1d5612bd09 Fortinet's new module for fortios_wireless_controller_hotspot20_h2qp_osu_provider (#61158) 2019-08-23 10:31:19 +05:30
f0c21c61b3 Fortinet's new module for fortios_wireless_controller_timers (#61159) 2019-08-23 10:29:26 +05:30
d4c9d13991 Fortinet's new module for fortios_wireless_controller_vap_group (#61160) 2019-08-23 10:26:31 +05:30
24ffd77fd8 Fortinet's new module for fortios_wireless_controller_hotspot20_h2qp_wan_metric (#61161) 2019-08-23 10:24:38 +05:30
999f5ef286 Fortinet's new module for fortios_wireless_controller_wtp_group (#61162) 2019-08-23 10:22:50 +05:30
c9bf39aa09 Fortinet's new module for fortios_wireless_controller_hotspot20_icon (#61164) 2019-08-23 10:20:51 +05:30
18a0fc701a Fortinet's new module for fortios_wireless_controller_hotspot20_qos_map (#61165) 2019-08-23 10:19:14 +05:30
a1a8ccfd00 Fortinet's new module for fortios_alertemail_setting (#61166) 2019-08-23 10:17:36 +05:30
4a90563c64 Fortinet's new module for fortios_wireless_controller_qos_profile (#61167) 2019-08-23 10:15:19 +05:30
cabad4e0a1 Fortinet's new module for fortios_wireless_controller_inter_controller (#61169) 2019-08-23 10:12:51 +05:30
bc9be2b63a Fortinet's new module for fortios_user_setting (#61122)
* Fortinet's new module for fortios_user_setting

* Update fortios_user_setting.py
2019-08-23 10:09:07 +05:30
72365b01e0 acme_certificate: only return challenges that need to be satisfied (#61191)
* Only return challenges that need to be satisfied.

* Adjust PR #.
2019-08-22 23:10:53 -04:00
2eff25aef8 Update ansible-test network inventory handling.
DCI uses an inventory directory instead of a file, along with --no-temp-workdir.

This changes the inventory check to keep that scenario working until all DCI jobs can be migrated to Zuul.
2019-08-22 17:35:41 -07:00
e5861eb468 Provide verbose details about which galaxy server was used (#61190) 2019-08-23 08:42:14 +10:00
18f7c3b850 Netapp: rename _facts -> _info (#60980)
* Rename na_ontap_gather_facts -> na_ontap_info
Rename netapp_e_facts -> netapp_e_info

* Add changelog.

* Fix sanity.

* Forgot test.

* Forgot to remove 'gather'.

* Fix sanity ignore.

* Remove netapp_e_facts from PR.

* Remove superfluous version_added.
2019-08-22 22:51:45 +02:00
e04b2a9697 ansible-galaxy - Add timeout and progress indicator for publish and install (#60660)
* ansible-galaxy - Add timeout and progress indicator for publish

* add progress indicator to install phase as well
2019-08-23 06:27:28 +10:00
c81a1057e1 Speed up a few more tests by mocking time.sleep (#61186) 2019-08-22 14:33:34 -05:00
0ff9978bc5 Ensure has_dead_workers functions (#60653)
* Ensure has_dead_workers functions

* Fix up tests

* Add changelog. Fixes #29124
2019-08-22 14:32:49 -05:00
5b16e012a4 Doc fixes for readability (formatting/punctuation) (#61086)
Variable-width font was extremely difficult to read in a couple places.
Fixed missing close-quote, colon, spelling, etc.
2019-08-22 15:29:53 -04:00
d31876416b acme_certificate: improve alternate chain handling (#60742)
* Improve alternate chain handling.

* Fix chain handling.
2019-08-22 15:08:36 -04:00
d06930d6f6 Add iosxr platform guide (#60936)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-22 14:05:15 -04:00
cedc012e30 adds diff functionality to the module (#61074) 2019-08-22 09:27:58 -07:00
47243b0b2d Resource module for iosxr_interfaces (#59853)
* iosxr interfaces resource

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-22 21:27:41 +05:30
5487f5dc84 Fix documentation and use urlparse without converting to list. (#60217) 2019-08-22 10:17:59 -04:00
d86968991f Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_3gpp_cellular (#61087) 2019-08-22 19:30:53 +05:30
da1f35f494 Fortinet's new module for fortios_wireless_controller_bonjour_profile (#61157) 2019-08-22 19:21:52 +05:30
81f7034ee3 Fortinet's new module for fortios_user_security_exempt_list (#61108) 2019-08-22 19:13:57 +05:30
3033482f0b Fortinet's new module for fortios_user_quarantine (#61061) 2019-08-22 19:13:25 +05:30
dbc4166e82 Fortinet's new module for fortios_user_pop3 (#61058)
* Fortinet's new module for fortios_user_pop3

* Fix chars in documentation not parseable by Ansible

* Update fortios_user_pop3.py
2019-08-22 19:11:24 +05:30
82d3a2e826 Fortinet's new module for fortios_user_peergrp (#61057) 2019-08-22 19:10:21 +05:30
4e768e2697 Fortinet's new module for fortios_user_peer (#61056)
* Fortinet's new module for fortios_user_peer

* Update fortios_user_peer.py
2019-08-22 19:08:59 +05:30
2684635f7f Fortinet's new module for fortios_user_ldap (#61053)
* Fortinet's new module for fortios_user_ldap

* Update fortios_user_ldap.py
2019-08-22 19:02:39 +05:30
4130fdbc8a Fortinet's new module for fortios_user_krb_keytab (#61052) 2019-08-22 18:58:29 +05:30
f1a24da774 Fortinet's new module for fortios_user_group (#61051) 2019-08-22 18:57:24 +05:30
e4f393e643 Fortinet's new module for fortios_vpn_ssl_web_user_group_bookmark (#61138) 2019-08-22 18:55:46 +05:30
70777020c4 Fix iam_password_policy integration tests (#60930)
* iam_password_policy: (integration tests) Use module defaults for AWS connection details

* iam_password_policy: (integration tests) Ensure the policy is removed when tests fail

* iam_password_policy: (integration tests) Add regression test for #59102

* iam_password_policy: Only return changed when the policy changes.

* iam_password_policy: PasswordReusePrevention must be omitted to remove/set to 0

* #60930 add changelog

* Update hacking AWS security policy to allow testing of Password Policy Management
2019-08-22 23:25:25 +10:00
35ed1fbe8d Fortinet's new module for fortios_user_fsso_polling (#61050) 2019-08-22 18:53:33 +05:30
cfecaba9b5 Fortinet's new module for fortios_user_fsso (#61049) 2019-08-22 18:52:59 +05:30
a53ec6af87 os_loadbalancer: Fix the absent function (#61083) 2019-08-22 09:20:32 -04:00
eeb2fd35d1 Fortinet's new module for fortios_user_fortitoken (#61048) 2019-08-22 18:49:22 +05:30
88e5365019 Fortinet's new module for fortios_user_domain_controller (#61047) 2019-08-22 18:47:54 +05:30
22c8d74e74 Fortinet's new module for fortios_user_device_group (#61046) 2019-08-22 18:47:15 +05:30
24fe418115 Fortinet's new module for fortios_user_device_category (#61044) 2019-08-22 18:45:46 +05:30
7e4c41cf1d Fortinet's new module for fortios_user_device_access_list (#61042) 2019-08-22 18:43:33 +05:30
9f9a741e19 Fortinet's new module for fortios_system_zone (#61041) 2019-08-22 18:42:44 +05:30
11b7b40b61 Fortinet's new module for fortios_system_wccp (#61040) 2019-08-22 18:41:18 +05:30
80897be42d Fortinet's new module for fortios_system_vxlan (#61039) 2019-08-22 18:40:16 +05:30
7c38fc7d07 Fortinet's new module for fortios_system_virtual_wire_pair (#61038) 2019-08-22 18:38:39 +05:30
4bd296c6fe Fortinet's new module for fortios_system_sit_tunnel (#60954) 2019-08-22 18:38:02 +05:30
8c5936671e Add new module eos_l3_interfaces (#59820)
* Update base files for resource modules

* Add modules

* Add module_utils

* Add tests

* Deprecate eos_l3_interface

* Update facts
2019-08-22 09:06:38 -04:00
aefe31e6d9 Fortinet's new module for fortios_vpn_certificate_setting (#61130) 2019-08-22 18:22:35 +05:30
48fe854511 Fortinet's new module for fortios_vpn_ssl_web_realm (#61135) 2019-08-22 18:22:23 +05:30
a5bab18986 Fortinet's new module for fortios_system_sflow (#60953) 2019-08-22 18:19:46 +05:30
3ea55fc254 Fortinet's new module for fortios_system_settings (#60952)
* Fortinet's new module for fortios_system_settings

* Avoid warnings on E336 a E336 for system settings
2019-08-22 18:19:02 +05:30
55979cd0f4 Fortinet's new module for fortios_vpn_ssl_web_host_check_software (#61134) 2019-08-22 18:18:25 +05:30
0a5c11f4da Fortinet's new module for fortios_system_session_ttl (#60951) 2019-08-22 18:18:05 +05:30
b57bf08f09 Fortinet's new module for fortios_vpn_l2tp (#61131) 2019-08-22 18:17:45 +05:30
f9e8dc042b Fortinet's new module for fortios_vpn_pptp (#61133) 2019-08-22 18:17:16 +05:30
2b90ef19d2 Fortinet's new module for fortios_system_replacemsg_webproxy (#60878) 2019-08-22 18:16:53 +05:30
426eea7014 Fortinet's new module for fortios_system_replacemsg_utm (#60877) 2019-08-22 18:16:23 +05:30
b325c488e3 Fortinet's new module for fortios_system_replacemsg_traffic_quota (#60876) 2019-08-22 18:15:37 +05:30
8e493021a1 Fortinet's new module for fortios_system_replacemsg_sslvpn (#60875) 2019-08-22 18:14:42 +05:30
8fb4878906 Fortinet's new module for fortios_system_replacemsg_spam (#60874) 2019-08-22 18:14:19 +05:30
bf6212b23d Fortinet's new module for fortios_system_replacemsg_nntp (#60873) 2019-08-22 18:13:51 +05:30
1ab09778fb Fortinet's new module for fortios_router_access_list6 (#61132) 2019-08-22 18:13:17 +05:30
00d2e541b9 Fortinet's new module for fortios_vpn_certificate_ca (#61123) 2019-08-22 18:13:07 +05:30
267ce70818 Fortinet's new module for fortios_system_replacemsg_nac_quar (#60872) 2019-08-22 18:12:20 +05:30
2fff40d409 add max_allocated_storage parameter to rds_instance (#61008)
* #60921 add max_allocated_storage parameter add apply that parameter also to the integration test

* version_added 2.9

* test value of  max allocated storage
2019-08-22 22:20:50 +10:00
628aa3a808 FortiOS modules for 2.9 - 5 (#61062)
* FortiOS modules for 2.9 - 5

* Update fortios_firewall_vip.py

* Update fortios_firewall_vip6.py
2019-08-22 17:44:17 +05:30
3373a2518a Fortinet's new module for fortios_system_replacemsg_mail (#60871) 2019-08-22 17:17:23 +05:30
4506371611 Fortinet's new module for fortios_system_replacemsg_image (#60870) 2019-08-22 17:08:32 +05:30
ab023b5276 Fortinet's new module for fortios_system_replacemsg_icap (#60869) 2019-08-22 17:08:11 +05:30
e887f1247f Fortinet's new module for fortios_system_replacemsg_http (#60868) 2019-08-22 17:06:31 +05:30
b2c65f20d8 Fortinet's new module for fortios_system_replacemsg_group (#60867) 2019-08-22 17:06:24 +05:30
c4500bffbb Fortinet's new module for fortios_system_replacemsg_ftp (#60866) 2019-08-22 16:53:12 +05:30
8fad5e3081 Fortinet's new module for fortios_system_replacemsg_fortiguard_wf (#60864) 2019-08-22 16:49:37 +05:30
bb09bdb309 Fortinet's new module for fortios_system_replacemsg_ec (#60863) 2019-08-22 16:37:29 +05:30
c041b6e9ca Fortinet's new module for fortios_system_replacemsg_device_detection_portal (#60862) 2019-08-22 16:36:29 +05:30
df6d46fed3 Fortinet: fmgr_fwpol_ipv4 update/behavioral option fix (#58154)
* PR Update to fmgr_fwpol_ipv4 -- now allows for failure or skip behavior option upon missing dependencies

* fmgr_fwpol_ipv4 minor docs fix

* Removed "system_package_print" line from test/sanity/ignore.txt as instructed by failed shippable test.

Actual PR module isn't affected.
2019-08-22 15:54:46 +05:30
45cc29ba08 PR Commit for fmgr_device_provision_template. Contains bug fixes. (#58151) 2019-08-22 15:53:43 +05:30
55d1da08b1 Drop redundant EOL escape from win_updates action
Ref: https://github.com/PyCQA/redbaron/issues/186
Ref: https://github.com/bcoca/gravity/commit/31de47ece73
2019-08-22 12:12:40 +02:00
62f665f0ed Fortinet's new module for fortios_system_vdom_radius_server (#61036) 2019-08-22 15:30:54 +05:30
ffbb906a9f Fortinet's new module for fortios_system_vdom_sflow (#61037) 2019-08-22 15:26:54 +05:30
95fee79c13 Fortinet's new module for fortios_system_sms_server (#60962) 2019-08-22 15:22:47 +05:30
f6421bbe2b Fortinet's new module for fortios_system_session_helper (#60986) 2019-08-22 15:12:53 +05:30
f624fd4c4c Fortinet's new module for fortios_system_vdom_dns (#60974) 2019-08-22 15:12:07 +05:30
2497b0fd5f Fortinet's new module for fortios_system_snmp_community (#60963) 2019-08-22 15:09:57 +05:30
0b1a8494a2 Fortinet's new module for fortios_system_snmp_sysinfo (#60964) 2019-08-22 15:01:35 +05:30
c16e9c2604 Fortinet's new module for fortios_system_replacemsg_auth (#60861) 2019-08-22 15:00:41 +05:30
19f35502f3 Fortinet's new module for fortios_system_replacemsg_alertmail (#60859) 2019-08-22 14:58:19 +05:30
1219c10844 Fortinet's new module for fortios_system_replacemsg_admin (#60858) 2019-08-22 14:57:25 +05:30
502682dfb0 Fortinet's new module for fortios_system_proxy_arp (#60857) 2019-08-22 14:54:56 +05:30
6ba7024e8a Fortinet's new module for fortios_system_probe_response (#60856) 2019-08-22 14:53:13 +05:30
e2e68fa7de Fortinet's new module for fortios_system_password_policy_guest_admin (#60854) 2019-08-22 14:52:04 +05:30
ebc3e48b66 Fortinet's new module for fortios_system_pppoe_interface (#60855) 2019-08-22 14:51:25 +05:30
fc544069c8 Fortinet's new module for fortios_system_snmp_user (#60970) 2019-08-22 14:51:05 +05:30
ee36eeb7a3 Fortinet's new module for fortios_system_switch_interface (#60972) 2019-08-22 14:50:47 +05:30
9cfadf2c67 Fortinet's new module for fortios_system_object_tagging (#60852) 2019-08-22 14:49:46 +05:30
e60b9e4944 Fortinet's new module for fortios_system_storage (#60971) 2019-08-22 14:49:34 +05:30
37bcb5b528 Fortinet's new module for fortios_system_password_policy (#60853) 2019-08-22 14:41:12 +05:30
c6d88da332 Fortinet's new module for fortios_system_ntp (#60851) 2019-08-22 14:38:54 +05:30
107306a5d4 Fortinet's new module for fortios_system_network_visibility (#60850) 2019-08-22 14:38:34 +05:30
8b882be084 Fortinet's new module for fortios_system_switch_interface (#60972) 2019-08-22 14:23:16 +05:30
da7ed1d8a6 Fortinet's new module for fortios_system_tos_based_priority (#60973) 2019-08-22 14:18:53 +05:30
7cc089f0d7 Fortinet's new module for fortios_system_vdom_netflow (#61034) 2019-08-22 14:14:20 +05:30
d39addf6c0 Fortinet's new module for fortios_system_nd_proxy (#60848) 2019-08-22 14:13:44 +05:30
83f7007848 Fortinet's new module for fortios_system_netflow (#60849) 2019-08-22 14:13:38 +05:30
6a0078bee2 Fortinet's new module for fortios_system_vdom_link (#61033) 2019-08-22 14:09:43 +05:30
7988f828b3 Fortinet's new module for fortios_system_nat64 (#60847) 2019-08-22 14:09:34 +05:30
5a28feb81c Fortinet's new module for fortios_system_vdom_exception (#61032) 2019-08-22 14:09:19 +05:30
9d70b2db8c Fortinet's new module for fortios_system_management_tunnel (#60845) 2019-08-22 14:08:37 +05:30
0280bcbfca Fortinet's new module for fortios_system_mobile_tunnel (#60846) 2019-08-22 14:08:25 +05:30
6b5b4fa5e9 Fortinet's new module for fortios_system_link_monitor (#60843) 2019-08-22 12:53:28 +05:30
9245310c99 Fortinet's new module for fortios_system_vdom_property (#61035) 2019-08-22 12:52:22 +05:30
fd11090663 Fortinet's new module for fortios_system_mac_address_table (#60844) 2019-08-22 12:29:58 +05:30
c2f9292987 Fortinet's new module for fortios_system_ipv6_tunnel (#60842) 2019-08-22 12:27:51 +05:30
8d95455167 Fortinet's new module for fortios_system_ipv6_neighbor_cache (#60841) 2019-08-22 12:27:19 +05:30
f8a6d6d991 Fortinet's new module for fortios_system_ips_urlfilter_dns (#60840) 2019-08-22 12:26:36 +05:30
0785ecf58b Fortinet's new module for fortios_system_ips_urlfilter_dns6 (#60839) 2019-08-22 12:25:54 +05:30
cb4de3e2a6 Fortinet's new module for fortios_system_ipip_tunnel (#60838) 2019-08-22 12:25:28 +05:30
b44e486fb0 Fortinet's new module for fortios_system_ha_monitor (#60837) 2019-08-22 12:24:57 +05:30
bcb8364031 Fortinet's new module for fortios_system_gre_tunnel (#60836) 2019-08-22 12:24:29 +05:30
052baf8151 Fortinet's new module for fortios_system_custom_language (#60812) 2019-08-22 12:23:39 +05:30
191068a286 Issue 59955: add array handling to postgresql_query module (#60559)
* Issue 59955: add array handling to postgresql_query module

* Issue 59955: add array handling to postgresql_query module, improvements

* Issue 59955: add array handling to postgresql_query module, fix example comment
2019-08-22 08:53:29 +02:00
5fec75a91a Fortinet's new module for fortios_system_console (#60810) 2019-08-22 12:23:03 +05:30
63a6fe619c Fortinet's new module for fortios_switch_controller_storm_control (#60784)
* Fortinet's new module for fortios_switch_controller_storm_control

* Update fortios_switch_controller_storm_control.py
2019-08-22 12:22:20 +05:30
21accb132e Update azure_rm_aks.py (#61079) 2019-08-22 13:28:04 +08:00
a5a1f01d1e Resource module for ios_lldp_interfaces (#61012)
* ios_lldp_interfaces resource

* fix shippable n reviews

* fix shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* add enable lldp tc
2019-08-22 10:02:25 +05:30
62feb18210 added route domain support (#61077)
added diff functionality
2019-08-21 21:20:50 -07:00
3e1f35155c fixed an issue with LDAP credentials not saving on the device (#61073) 2019-08-21 21:19:27 -07:00
e89d178440 fixed issue with no_tl3 option for client ssl profile (#61075)
added better error reporting in bigip_firewall_rule module
2019-08-21 20:58:23 -07:00
8bfa7569b5 removed deprecated parameters (#61071)
fixed multiple issues with integration tests
added RD support for source parameter
fixed a problem with name parameter in bigip_user module
2019-08-21 20:58:11 -07:00
e5243ef1d7 enabled specyfing snat translation objects as pool members (#61076)
added route domain support
added diff functionality
2019-08-21 20:51:23 -07:00
3a689d3b1f added more examples of module usage (#61070) 2019-08-21 20:50:57 -07:00
3c19c75560 removes deprecated parameters (#61066)
adds diff functionality
fixes issue with serverscope parameter not setting on device
2019-08-21 20:50:40 -07:00
3fa7423e8e fixes an issue where config sync with the module fails if there are sync failures on a different device group than the one being synced (#61067) 2019-08-21 20:50:28 -07:00
306b6b728c adds new module for asm dos application profiles (#61063) 2019-08-21 20:50:07 -07:00
0210447fa7 fixes edge cases where software installation would time out if tomcat was not ready (#61065) 2019-08-21 20:49:33 -07:00
adb886e4ce Speed up units using time.sleep by mocking or shortening sleep time (#61064)
* Speed up units using time.sleep by mocking or shortening sleep time

* Only use durations when not a collection
2019-08-21 16:52:58 -05:00
c1547f10d6 Fix table headers and width (#60549) 2019-08-21 16:55:16 -04:00
3551d83289 Fix ansible-test payload bin creation. 2019-08-21 12:45:55 -07:00
3cd7182796 New Module: gcp_filestore_instance_info (#60997) 2019-08-21 15:43:12 -04:00
21b14d95db Bug fixes for GCP modules (#60995) 2019-08-21 15:31:48 -04:00
76cc8e9fc3 New Module: gcp_filestore_instance (#60996) 2019-08-21 15:31:38 -04:00
29ac0273d4 Update ansible-test collection inventory handling. (#61031)
* Update ansible-test collection inventory handling.

- The `windows-integration` command now supports the `--inventory` option.
- The incomplete support for host_vars and group_vars directories has been removed.
- The incomplete support for an inventory directory has been removed.
- The inventory specified by `--inventory` can now reside outside the install and content roots.
- Using `ansible_ssh_private_key_file` with `--docker` or `--remote` results in a warning about the combination being unsupported and likely to fail.

* Fix config handling.

* Fix payload handling of ssh keys.

* Disable pylint no-self-use rule for ansible-test.

* De-duplicate payload paths.
2019-08-21 12:12:37 -07:00
20ced48717 Update link to user data knowledge base (#60991)
Removes old broken link, replaces with with updated and confirmed working link
2019-08-21 13:26:44 -05:00
cf291f272d Bugfix of issue 60707: add python-apt package to requirements of package_facts module (#60999)
* Issue 60707: add python-apt package to requirements of package_facts module, fix formatting, change fail msg
2019-08-21 13:22:10 -05:00
35d457a14f Resource module for ios_lldp_global (#60506)
* ios_lldp_global model

* final fix for lldp_global

* fix shippable n reviews

* fix reviews
2019-08-21 23:02:25 +05:30
4615139194 vos_config collection fix using FQCN (#60446)
This deals with hardcoded vos_config in our vyos action plugin. Needed
for when we move to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-21 13:30:49 -04:00
ab027611d5 fix typo in become.rst (#61011)
change remote_src: yex to remote_src: yes in documentation
2019-08-21 10:58:45 -05:00
98827c7963 fix openstack bug with transforming group names (#53778) 2019-08-21 08:42:54 -07:00
89e8feae0d Fix junos_vlan documentation (#60278)
This commit fixes junos_vlan documentation so it no longer has any
reference to the non-valid value vlan_name.
2019-08-21 15:49:40 +02:00
4e7cd76c56 Add hcloud network info (#60932)
* Add hcloud network facts

* Add tests

* Rename fact to info, adjust tests

* Fix style

* Fix test

* Fix typo

* Adjust test

* Adjust test

* Rename subnets to subnetworks

* Adjustments

* Apply suggestions from code review

Co-Authored-By: Lukas Kämmerling <4281581+LKaemmerling@users.noreply.github.com>
2019-08-21 15:47:02 +02:00
145a6a8756 maven_artifact.py - add support for version ranges by using spec (#54309) 2019-08-21 14:33:28 +01:00
96199be96b Rename hcloud_*_facts to hcloud_*_info (#60926)
* Rename hcloud_datacenter_facts to hcloud_datacenter_info

* Rename hcloud_location_facts to hcloud_location_info

* Rename hcloud_image_facts to hcloud_image_info

* Rename hcloud_floating_ip_facts to hcloud_floating_ip_info

* Rename hcloud_server_type_facts to hcloud_server_type_info

* Rename hcloud_server_facts to hcloud_server_info

* Rename hcloud_ssh_key_facts to hcloud_ssh_key_info

* Rename hcloud_volume_facts to hcloud_volume_info

* Fix typo in hcloud_image_info

* Add to porting guide and add changelog fragment

* Reword porting guide
2019-08-21 14:55:37 +02:00
839e9019ef Fortinet's new module for fortios_switch_controller_switch_group (#60787) 2019-08-21 16:59:27 +05:30
1c4c2f9519 meraki_webhook: Correct usages of variable (#60998)
Changed `wehooks` to `webhooks` in order to fix a typo.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-21 16:18:22 +05:30
bfa004930a add subdir support to collection loading (#60682)
* add subdir support to collection loading

* collections may now load plugins from subdirs under a plugin type or roles dir, eg `ns.coll.subdir1.subdir2.myrole`->ns.coll's roles/subdir1/subdir2/myrole, `ns.coll.subdir1.mymodule`->ns.coll's plugins/modules/subdir1/mymodule.py
* centralize parsing/validation in AnsibleCollectionRef class
* fix issues loading Jinja2 plugins from multiple sources 
* resolves #59462, #59890,

* sanity test fixes

* string fixes

* add changelog entry
2019-08-21 10:45:04 +01:00
1aecdbb5c5 Fortinet's new module for fortios_switch_controller_switch_interface_tag (#60788) 2019-08-21 15:10:43 +05:30
1d8556710e Fortinet's new module for fortios_switch_controller_switch_log (#60789) 2019-08-21 15:03:31 +05:30
df8cabb4ce Fortinet's new module for fortios_switch_controller_stp_settings (#60786)
* Fortinet's new module for fortios_switch_controller_stp_settings

* Update fortios_switch_controller_stp_settings.py
2019-08-21 14:53:28 +05:30
5041be8350 Fortinet's new module for fortios_switch_controller_sflow (#60783) 2019-08-21 13:43:49 +05:30
af49cd0c4e Fortinet's new module for fortios_switch_controller_security_policy_captive_portal (#60782) 2019-08-21 13:36:34 +05:30
c1b2aa1d11 nginx_status_facts: deprecate/rename to nginx_status_info (#60979)
* Rename nginx_status_facts -> nginx_status_info

* Add changelog.

* Remove warnings.

* Re-add ignore.txt entries.

* ...

* Raw strings for docs.

* Use U(...) for link.
2019-08-21 09:09:22 +02:00
8b3ff933af Vyos lldp interfaces (#60931)
* module_utils checkin

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos lldp_interfaces merging

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* shippable fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* merge changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* failure added in ignore list

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* remove global commands

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-21 12:30:13 +05:30
5f227fe260 Install ansible-test (#60718)
* Install ansible-test

Modify the install script to install ansible-test and its supporting
code.  Alternative to #60701 that doesn't change package_dir ansible for
fear that it might regress https://github.com/ansible/ansible/issues/10437

Also:
* No longer use package_data.  Everything in the package dirs is going
  to be installed.  Anything that shouldn't be installed needs to be
  moved elsewhere.
* modify the algorithm to store symlinks which are in the same tree
  instead of same directory

* Add ansible_test files to package-data sanity test

* MANIFEST.in cleanups

* Add lib/ansible/config/*.yml
* Make most things in code directories (lib/ansible and test/lib/ansible_test/)
  use explicit file extensions instead of wildcards for maintainability
* Exclude common file extensions that we don't want included in the code
  directories

* Change package-data test to be more complete

* Now compares the repository, sdist, and install
* Compares both that everything in the sdist is in the repo and
  everything in the install is in the sdist in addition to comparing that
  everything in the repo that we want is in the install

* Leave out test artifacts

Only include the directory structure for test/results and test/cache not
any files that may have been generated by test runs

Remove test/utils files from the sdist as these are only needed for our CI

cleanup of docs in MANIFEST.in; getting rid of build files.

* Add the ability to output sdist and snapshot to specific directory

* Add a warning about modifying the heuristic to setup.py

* Address generated files

* Use make snapshot instead of sdist to generate changelog and man pages
  and make sure they're included
* Ignore both the test/utils and generated test files (results, cache)
* Deal with Python3 __pycache__ byte code caches
* Don't check documentation, that isn't built for the sdist
* Restructure for clarity

* Add cli web docs to make clean

This was causing problems when attempting to test that the sdist didn't
have extra files

* Fix bug constructing python names from __pycache__ names

* Create a clean repo to work from

* Exclude test/legacy and be more explicit on extensions

* Exclude the legacy directory from sdist
2019-08-20 23:53:35 -07:00
f1d568749f fix: Checkpoint check_mode, add suboptions, return the facts (#60264)
* fix: check_mode, add suboptions, return the facts

* pip8, ansible_facts, get_payload

* add space to create PR

* remove space to create PR

* test tests of cp_network

* change for the test of network

* fixes to pass the tests

* fix tests

* Update ignore.txt
2019-08-21 12:23:17 +05:30
b75fc87a86 VMware: New module for deploy VM from content library template (#60203)
* Fixed format issues reported by pre-check tests

* Changes as per review comments. using single api_client between util class and module

* re-running the task to check the idempotency of module object
2019-08-21 11:17:29 +05:30
32b0a72547 Support windows-integration on collections. (#60984)
* Support windows-integration on collections.

* Update configure-remoting-ps1 sanity test.

* Add copy of ConfigureRemotingForAnsible.ps1.

* Add ignore entry for copied file.
2019-08-20 22:23:28 -07:00
04e0f9d4ea XenServer: When VM is in powered on state, plug newly added disks
Fixes: #60693
2019-08-21 10:50:14 +05:30
2bbbc5fafc Update mso_schema_template_anp_epg.py (#59746)
* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py

* Update mso_schema_template_anp_epg.py
2019-08-21 04:00:53 +02:00
e747487720 ansible-galaxy - define multiple galaxy instances in ansible.cfg (#60553)
* ansible-galaxy: support multiple servers on install

* Added docs for the server configuration file

* Fix up doc string for requirements file format

* Fix bugs after testing

* Fix kwarg doc and added version

* Fix typo and doc improvement

* Fix base64 encoding and allow --server to override list
2019-08-21 07:49:05 +10:00
4d424d0830 Only run package-data sanity once in CI. 2019-08-20 14:09:40 -07:00
764a81fce7 New module eos_lacp (#60698)
* Initial builder import

* Add tests

* Implement facts & config
2019-08-20 16:11:31 -04:00
543401f83b Collections documentatation - Add information about semantic versioning (#60969) 2019-08-20 14:59:01 -04:00
229219ab77 Bug fixes for GCP modules (#60920) 2019-08-20 14:30:16 -04:00
48a04fade4 Update host parameter notes to include China. (#60967) 2019-08-20 14:20:31 -04:00
32f264d508 ansible-doc added a new required element and broke changelog generation
ansible-doc should probably be using subcommands for its
exclusive_options...
2019-08-20 10:59:24 -07:00
673c9a3ee2 add import error (#60886) 2019-08-20 13:50:30 -04:00
3940a2c3c4 bug and doc fixes (#60888) 2019-08-20 13:50:09 -04:00
211fd2c95f small bug fix (#60890) 2019-08-20 13:49:59 -04:00
cba8e12e3c bug fix, was not checking vserver (#60892) 2019-08-20 13:49:33 -04:00
684661b5e0 small bug fix (#60893) 2019-08-20 13:49:24 -04:00
e1e2e61494 small update (#60894) 2019-08-20 13:33:24 -04:00
90d84dd162 doc update (#60895) 2019-08-20 13:33:10 -04:00
cd093be8b2 small bug fix for elementsw_vlan (#60896) 2019-08-20 13:33:00 -04:00
4bffa76134 small bug fix for cifs acl (#60898) 2019-08-20 13:32:49 -04:00
aae484dbae cg snapshot needs to use vserver (#60899) 2019-08-20 13:32:34 -04:00
ad7b55f9ec update copyright (#60900) 2019-08-20 13:32:23 -04:00
099d18bb7e small doc update (#60902) 2019-08-20 13:32:05 -04:00
f8913dce6e update copyright (#60903) 2019-08-20 13:31:53 -04:00
a972ceb344 bug fixes for backup (#60904) 2019-08-20 13:31:40 -04:00
63d4de7e1c igroup has to use vserver (#60905) 2019-08-20 13:31:30 -04:00
d62e75bf6d update copyright (#60906) 2019-08-20 13:31:20 -04:00
ceee866794 fixes' (#60907) 2019-08-20 13:21:26 -04:00
db465384b0 update copyright (#60908) 2019-08-20 13:21:16 -04:00
100fe52860 Add missing ansible-test git ignore. 2019-08-20 09:02:34 -07:00
3247626ac7 Warn when transforming constructed groups (#60912)
* Warn when transforming constructed groups

The `keyed_groups` field has used sanitization since 2.6, but `groups` only started doing so in 2.8.
This adds a warning for the change in behavior.

* changelog
2019-08-20 10:32:02 -05:00
ba25522db4 Remove ddeprecated redis_kv lookup. Fixes #59984 (#60826) 2019-08-20 10:27:09 -05:00
5acbb42dc4 Fix ssh example with sshd config (#60821)
The example tries to validate a sshd config, but provides sshd (server) a client configuration.
If trying to execute the given validation command on a client file, it doesn't work (e.g. running `/usr/sbin/sshd -T -f /etc/ssh/sshd_config` returns non-zero code)
2019-08-20 09:54:02 -05:00
11be31db71 Fix naming discrepancy in zip filter example (#60918)
Fix naming discrepancy in zip filter example
2019-08-20 09:53:15 -05:00
92380d7050 Update ansible-test --windows inventory creation. (#60911)
Host specific settings are created as part of the generated inventory instead of using a host_vars directory.

Also update connection tests to work properly with the generated inventory changes.
2019-08-20 07:17:32 -07:00
e58919bccd gluster_heal_facts: rename to gluster_heal_info (#60919)
* Rename gluster_heal_facts -> gluster_heal_info

* Add changelog.
2019-08-20 15:43:41 +02:00
c66163b118 hpilo_facts: rename to hpilo_info (#60917)
* Rename hpilo_facts -> hpilo_info

* Fix porting guide.

* Add changelog.
2019-08-20 15:14:18 +02:00
2e6458bb73 Fortinet's new module for fortios_switch_controller_security_policy_802_1X (#60779) 2019-08-20 18:08:47 +05:30
34bc40cfde Fortinet's new module for fortios_switch_controller_qos_queue_policy (#60777) 2019-08-20 16:55:52 +05:30
d7b61b2adc Fortinet's new module for fortios_router_route_map (#60761)
* Fortinet's new module for fortios_router_route_map

* Update fortios_router_route_map.py
2019-08-20 16:52:30 +05:30
362c45517d aws_kms: fix failing tests (#60206)
Preserve tag key case by only calling camel_dict_to_snake_dict once,
before the tags are added.

Don't call assert_policy_shape as it seems to fail

Use aws_caller_info in the test suite now that it exists rather
than running `aws sts get_caller_identity`

Ensure that calls using `grant_types` can also use key aliases
2019-08-20 07:15:40 -04:00
7224114c3c Fortinet's new module for fortios_switch_controller_quarantine (#60778) 2019-08-20 16:45:15 +05:30
150b20ed1d Fortinet's new module for fortios_system_geoip_override (#60835) 2019-08-20 16:31:21 +05:30
f578534c79 Fortinet's new module for fortios_system_ftm_push (#60834) 2019-08-20 16:30:50 +05:30
f19851f1a3 Fortinet's new module for fortios_system_fsso_polling (#60832) 2019-08-20 16:30:26 +05:30
c8de713683 Fortinet's new module for fortios_system_fortisandbox (#60831) 2019-08-20 16:30:03 +05:30
95338e9062 Fortinet's new module for fortios_system_fortisandbox (#60831) 2019-08-20 16:29:41 +05:30
6089509c8a Fortinet's new module for fortios_system_fortimanager (#60830) 2019-08-20 16:29:05 +05:30
869b5550c6 Fortinet's new module for fortios_system_fortiguard (#60829) 2019-08-20 16:26:29 +05:30
fea50bef72 Fortinet's new module for fortios_system_fm (#60828) 2019-08-20 16:25:53 +05:30
7328c71adb Fortinet's new module for fortios_system_fips_cc (#60827) 2019-08-20 16:25:35 +05:30
e223100f27 Fortinet's new module for fortios_system_external_resource (#60825) 2019-08-20 16:25:10 +05:30
e2c3f67aad Fortinet's new module for fortios_system_email_server (#60824) 2019-08-20 16:21:08 +05:30
7cd380ddc3 Fortinet's new module for fortios_system_dscp_based_priority (#60823) 2019-08-20 16:20:38 +05:30
5deaf3f495 Fortinet's new module for fortios_system_dns_server (#60822) 2019-08-20 16:20:17 +05:30
a804d03f87 Fortinet's new module for fortios_system_dns_database (#60817)
* Fortinet's new module for fortios_system_dns_database

* Update fortios_system_dns_database.py

* Update fortios_system_dns_database.py
2019-08-20 16:19:44 +05:30
1dc6c05521 Fortinet's new module for fortios_system_dhcp6_server (#60816) 2019-08-20 16:18:58 +05:30
1c75506e22 Fortinet's new module for fortios_system_dedicated_mgmt (#60815) 2019-08-20 16:18:05 +05:30
55110408c0 Fortinet's new module for fortios_system_ddns (#60813) 2019-08-20 16:17:42 +05:30
e4f6d956a7 Fortinet's new module for fortios_system_csf (#60811) 2019-08-20 16:17:06 +05:30
6382f8cb46 Fortinet's new module for fortios_system_cluster_sync (#60807) 2019-08-20 16:15:08 +05:30
ce8493fc4d Fortinet's new module for fortios_system_autoupdate_tunneling (#60804) 2019-08-20 16:14:23 +05:30
41dc8e84e4 fix nxos test failure (#60928)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-20 16:14:00 +05:30
2e9b9d2a70 Fortinet's new module for fortios_system_autoupdate_schedule (#60803) 2019-08-20 16:13:51 +05:30
5557a9eb44 Fortinet's new module for fortios_system_autoupdate_push_update (#60802) 2019-08-20 16:12:40 +05:30
4cb81ad13f Fortinet's new module for fortios_system_auto_script (#60801) 2019-08-20 16:11:59 +05:30
f3c288acf3 Fortinet's new module for fortios_system_automation_trigger (#60800) 2019-08-20 16:11:33 +05:30
3cd70f53cc FortiOS modules for 2.9 - 4 (#60806)
* FortiOS modules for 2.9 - 4

* Update ignore.txt

* Updates from maintainers to legacy modules

* Update fortios_firewall_ssl_setting.py

* Update fortios_firewall_ssl_server.py
2019-08-20 16:11:11 +05:30
2b103a2e54 Fortinet's new module for fortios_system_automation_stitch (#60799) 2019-08-20 16:10:43 +05:30
47dcd2ea23 Fortinet's new module for fortios_system_automation_destination (#60798) 2019-08-20 16:09:22 +05:30
bef8a682d7 Fortinet's new module for fortios_system_automation_action (#60797) 2019-08-20 16:07:41 +05:30
2013f5e728 Fortinet's new module for fortios_system_auto_install (#60795) 2019-08-20 16:00:08 +05:30
c5a29d0b0c Fortinet's new module for fortios_system_arp_table (#60794) 2019-08-20 15:58:46 +05:30
e0e2be1447 Fortinet's new module for fortios_system_alias (#60793) 2019-08-20 15:57:23 +05:30
29df45cd95 Fortinet's new module for fortios_system_alarm (#60792) 2019-08-20 15:56:39 +05:30
bc98bf67af Fortinet's new module for fortios_system_affinity_packet_redistribution (#60791) 2019-08-20 15:54:53 +05:30
a97f4693d9 Fortinet's new module for fortios_system_affinity_interrupt (#60790) 2019-08-20 15:48:46 +05:30
cd4736d893 missing_required_lib: add information how to change Python interpreter (#60736)
* Add information how to change Python interpreter used by Ansible.

* Update lib/ansible/module_utils/basic.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Make test less dependent on exact message.
2019-08-20 19:44:38 +10:00
a9405456bc Fortinet's new module for fortios_switch_controller_qos_qos_policy (#60776)
* Fortinet's new module for fortios_switch_controller_qos_qos_policy

* Update fortios_switch_controller_qos_qos_policy.py
2019-08-20 15:06:07 +05:30
1845ca164f Fortinet's new module for fortios_system_resource_limits (#60879)
* Fortinet's new module for fortios_system_resource_limits

* Update fortios_system_resource_limits.py
2019-08-20 15:02:14 +05:30
1143ebf973 Fortinet's new module for fortios_switch_controller_qos_ip_dscp_map (#60775)
* Fortinet's new module for fortios_switch_controller_qos_ip_dscp_map

* Update fortios_switch_controller_qos_ip_dscp_map.py
2019-08-20 14:53:25 +05:30
8a8798c373 Resource module for ios_lacp_interfaces (#59516)
* ios lacp interfaces

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-20 13:37:31 +05:30
642e54f958 Resource module for ios_lacp (#60884)
* ios lacp resource

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-20 12:05:14 +05:30
5027416fb5 Sort version list on azure_rm_aksversion_facts (#60820) 2019-08-20 14:25:57 +08:00
dae2040717 VMware: refactor REST APIs (#60220)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-20 09:15:52 +05:30
95aa86fcc3 Bug fixes for GCP modules (#60719) 2019-08-19 15:53:30 -04:00
5c8855b404 Bug fixes for GCP modules (#60720) 2019-08-19 15:53:19 -04:00
bf57668423 Bug fixes for GCP modules (#60721) 2019-08-19 15:53:09 -04:00
57a248764c Bug fixes for GCP modules (#60722) 2019-08-19 15:52:58 -04:00
73623c0029 Bug fixes for GCP modules (#60723) 2019-08-19 15:52:47 -04:00
2f033b6169 Bug fixes for GCP modules (#60724) 2019-08-19 15:52:39 -04:00
efa163a2e8 New module eos_lag_interfaces (#60610)
* Copy module files

* Deprecate eos_linkagg

* Add tests
2019-08-19 15:34:20 -04:00
7c704526f3 Remove unused variable from iosxr_logging (#60865)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-19 15:28:20 -04:00
8bac810e38 Update user.py (#60746)
Return value `ssh_key_file` is the private key, not the public key
2019-08-19 14:15:02 -05:00
13f5e930a4 Added support for addtional partitions in ARN (#28699) (#28704) 2019-08-19 15:12:31 -04:00
e58df57ba0 Add people to team_suse (#60860)
This adds fresh blood into team suse through BOTMETA.
2019-08-19 18:26:19 +01:00
cd256256f8 Remove unused imports for iosxr modules (#60819)
These are not used and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-19 12:33:04 -04:00
129e998276 EC2: Don't count instances in 'shutting-down' as running (#60709)
state: shutting-down is a precursor to terminated and should be treated
as such for exact_count.
Fixes #55955
2019-08-19 09:22:38 -07:00
2f05953b52 Remove unused import for ios_l2_interface (#60814)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-19 11:48:22 -04:00
d9ffc61539 Add new module eos_l2_interfaces (#59794)
* Add module files for l2_interfaces

* Add module_utils

* Add tests

* Deprecate eos_l2_interface

* Clean up tests so eos_vlan will still pass
2019-08-19 11:24:36 -04:00
04ef376ab2 Resource module for ios_lag_interfaces (#60672)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-19 20:41:00 +05:30
31bfcd4745 Reworked zabbix_template to support XML import/export + updated documentation (#59040) 2019-08-19 10:53:58 -04:00
d0dac80e41 Fortinet's new module for fortios_spamfilter_iptrust (#60767)
* Fortinet's new module for fortios_spamfilter_iptrust

* Update fortios_spamfilter_iptrust.py
2019-08-19 19:57:57 +05:30
9ffe16c7cb Fortinet's new module for fortios_spamfilter_mheader (#60768)
* Fortinet's new module for fortios_spamfilter_mheader

* Update fortios_spamfilter_mheader.py
2019-08-19 19:57:33 +05:30
b5823d078b Fortinet's new module for fortios_switch_controller_802_1X_settings (#60770)
* Fortinet's new module for fortios_switch_controller_802_1X_settings

* Update fortios_switch_controller_802_1X_settings.py
2019-08-19 19:56:58 +05:30
b7f90dcce0 Fortinet's new module for fortios_spamfilter_bwl (#60763)
* Fortinet's new module for fortios_spamfilter_bwl

* Update fortios_spamfilter_bwl.py
2019-08-19 19:56:19 +05:30
e5a1fb2a29 Fortinet's new module for fortios_spamfilter_bword (#60764)
* Fortinet's new module for fortios_spamfilter_bword

* Update fortios_spamfilter_bword.py
2019-08-19 19:55:46 +05:30
ba44b2a0f8 Fortinet's new module for fortios_spamfilter_dnsbl (#60765)
* Fortinet's new module for fortios_spamfilter_dnsbl

* Update fortios_spamfilter_dnsbl.py
2019-08-19 19:55:23 +05:30
843a51628b Fortinet's new module for fortios_router_ripng (#60760)
* Fortinet's new module for fortios_router_ripng

* Update fortios_router_ripng.py

* Update fortios_router_ripng.py
2019-08-19 19:54:52 +05:30
4b743a2721 vultr: use exponential backoff for api query retries (#60529) 2019-08-19 16:09:09 +02:00
f9f882a981 Fortinet's new module for fortios_switch_controller_qos_dot1p_map (#60774) 2019-08-19 19:07:48 +05:30
8039dea8c4 Fortinet's new module for fortios_switch_controller_igmp_snooping (#60772) 2019-08-19 19:07:07 +05:30
6d93cddd58 Fortinet's new module for fortios_switch_controller_custom_command (#60771) 2019-08-19 19:06:33 +05:30
cbdbf24d15 Terminal prompt Regex update for VPEX mode (#60547) 2019-08-19 19:05:22 +05:30
b48e51cf6d Fortinet's new module for fortios_spamfilter_options (#60769) 2019-08-19 19:04:08 +05:30
4a99c5f64b Fortinet's new module for fortios_spamfilter_fortishield (#60766) 2019-08-19 19:02:21 +05:30
a9566d1b99 Fortinet's new module for fortios_router_static6 (#60762) 2019-08-19 18:58:33 +05:30
49736b6b27 Add support to configure network_cli terminal related options (#60086)
* Add support for configurable terminal plugin options

Fixes #59404

*  Add terminal options to support platform specific login menu
*  Add terminal options to support configurable options for stdout
   and stderr regex list

* Fix CI failures

* Fix CI issues

* Fix review comments and add integration test

* Fix sanity test failures

* Fix review comments

* Fix integration test case

* Fix integration test failure

* Add support to configure terminal related options

Fixes https://github.com/ansible/ansible/issues/59404

*  Add network_cli configurable options to support platform specific login menu
*  Add network_cli configurable options to support configurable options for stdout
   and stderr regex list

* Fix review comment

* Fix review comment
2019-08-19 18:56:20 +05:30
446dcb7c96 New module eos_vlans (#60652)
* Initial commit of module files

* Add tests, implement facts

* Implement config, fix issues

* Handle vlan ranges from the device

* Deprecate eos_vlan
2019-08-19 09:02:38 -04:00
256db658b7 Fortinet's new module for fortios_router_prefix_list6 (#60759) 2019-08-19 18:23:07 +05:30
decb016a2d FortiOS modules for 2.9 - 3 (#60678)
* FortiOS modules for 2.9 - 3

* Remove default values in doc, as suggested from review

* Retriggering due to shippable failure

* Update fortios_firewall_ipv6_eh_filter.py

* Update fortios_firewall_ipmacbinding_setting.py

* Update fortios_firewall_ippool.py

* Update fortios_firewall_local_in_policy6.py

* Update fortios_firewall_local_in_policy.py
2019-08-19 18:18:11 +05:30
d8f9904f43 vyos_lldp_global (#59627)
* vyos_lldp_global

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity checks

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* deprecated changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* branch conflict resolved

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check passes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-19 17:31:09 +05:30
b55a54469c Resource module for ios_vlans (#59640)
* ios_vlans resource module

* fix shippable error

* fix shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix vlans resource

* fix facts doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n review

* fix test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix indentation

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix review

* fix shebang

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-19 16:03:29 +05:30
8e99f0ecc6 aws_kms: Rename various policy manipulation options to reduce confusion (#60561)
* aws_kms: Rename various policy manipulation options to reduce confusion

AWS KMS now has the concept of issuing a 'grant', which is independent
of the policy attached to a key.  Rename the following options to make
it clearer that the operate on the CMK Policy *not* on CMK Grants

* aws_kms: don't just rename grant_types/mode, deprecate them too.
2019-08-19 19:44:03 +10:00
20f9e72c74 Fortinet's new module for fortios_router_key_chain (#60758) 2019-08-19 15:08:46 +05:30
be639a57f8 Fortinet's new module for fortios_router_isis (#60757) 2019-08-19 15:05:16 +05:30
174a854e05 Fortinet's new module for fortios_router_community_list (#60756) 2019-08-19 15:02:44 +05:30
78a382e91d Fortinet's new module for fortios_router_aspath_list (#60755) 2019-08-19 15:01:55 +05:30
f1cf838797 fix nxos CI failures (#60752)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-19 14:24:39 +05:30
7a9e865a23 docker_image_info: improve docs (#60622)
* Improve return value documentation.

* Improve example.

* Fix typo.

* Update lib/ansible/modules/cloud/docker/docker_image_info.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* Update lib/ansible/modules/cloud/docker/docker_image_info.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-08-19 03:21:50 -04:00
555b8413a1 VMware: Add uptime and maintenance mode in vmware_host_facts (#60688)
* adding host facts
* adding to test
2019-08-19 10:57:01 +05:30
aea52c67d6 ansible-galaxy: create parent dir for token file (#60615)
* ansible-galaxy: create parent dir for token file

* The path unfrack is already done by config

* Move common dir creation to ansible cli

* Add warning if dir failed to be created

* remove testing path

* Make mode a position arg not kwarg
2019-08-19 06:21:47 +10:00
fb2c1d4577 Make win_domain_user idempotent for password changes (#58383)
* Make win_domain_user idempotent for passwordchanges

* Add changelog fragment

* Use test-credentials function from win_user.

* Split domain from username

* Update win_domain_user.ps1

* Fix ci

* Update win_domain_user.ps1

Fix ci

* Implement review

* Logic cleanup and remove securestring

* Fix typo

* fix syntax

fix syntax

* Use AD object instead of user input as requested by review

* migrate to Ansible.AccessToken
2019-08-19 06:17:41 +10:00
811153afb1 Add exception handling to win_domain_controller (#58234)
* Add exception handling to win_domain_controller

* Add changelog

* Fix PSUseDeclaredVarsMoreThanAssignments

* Remove dns domain cannot be resolved error message

As requested by PR review in https://github.com/ansible/ansible/pull/58234#discussion_r300509880
2019-08-18 16:14:51 -04:00
cc5957001c win_domain reboot required exception incorrectly reported (#60496)
* Set reboot required dependent on exception message.

* Use exception id instead of it's message
2019-08-19 06:05:33 +10:00
0d88ec241f openssl_certificate: fix idempotency (#60745)
* Fix openssl_certificate idempotency.

* Add changelog.

* Add integration test.
2019-08-18 20:48:34 +02:00
16056f4978 openssl_certificate: check for existence before loading CSR / private keys / ... (#60740)
* Check file existence before loading files.

* Remove superfluous import.

* Add changelog.
2019-08-18 11:41:50 +02:00
13364fc530 docker_swarm_service: Allow passing dicts in networks (#58961)
* Add support for passing networks as dicts

* Add function to compare a list of different objects

* Handle comparing falsy values to missing values

* Pass docker versions to Service

* Move can_update_networks to Service class

* Pass Networks in TaskTemplate when supported

* Remove weird __str__

* Add networks integration tests

* Add unit tests

* Add example

* Add changelog fragment

* Make sure that network options are clean

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Set networks elements as raw in arg spec

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix wrong variable naming

* Check for network options that are not valid

* Only check for None options

* Validate that aliases is a list
2019-08-18 08:55:54 +02:00
aaaa4f1809 This line apparently got lost. (#60739) 2019-08-18 06:00:21 +02:00
26b9c81a8e crypto modules: fix sanity errors (#60046)
* Remove sanity warnings.

* Linting.

* More linting.

* Forgot one place.

* no_bytes -> num_bytes
2019-08-18 05:37:57 +02:00
ceff0029cb openssl_certificate: deprecate assertonly provider (#60623)
* Add deprecation marks.

* Add conversion example.

* Split long line.

* Add changelog and porting guide entry.

* Fix unrelated porting guide entry.

* Fix format.

* Fix doc mistakes found in review.

* Fix filter name.

* Compare CSR and cert subject via subject_ordered.
2019-08-18 05:09:49 +02:00
86366530e8 Entrust Datacard - Support for "entrust" provider in openssl_certificate module (#59272)
* Addition of entrust provider to openssl_certificate module

* Fix native return values of error messages and JSON response.

* Documentation and syntax fixes per ansibot.

* Refactored structure of for loop due to ansible test failures in python 2.6

* Remove OCSP functionality for inclusion in possible seperate future pull request.

* Remove reissue support.

* Indicate the entrust parameters are specific to entrust.

* Comment fixes to make it clear module_utils request is used.

* Fixes to not_after documentation

* Response to pull request comments and cleanup of error handling for bad connections to properly use the 'six' HttpError for compatibility with both Python 2/3 underlying url libraries.

* pep8/pycodestyle fixes.

* Added code fragment and response to comments.

* Update license to simplified BSD

* Fixed botmeta typo

* Include license text in api.yml

* Remove unsupported certificate types, and always submit an explicit organization to match organization in CSR

* Fix documentation misquote, add expired to a comment, and fix path check timing.

* Update changelogs/fragments/59272-support-for-entrust-provider-in-openssl_certificate_module.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-17 21:32:02 +02:00
ab07c206aa Resource module for ios_l2_interfaces (#60344)
* ios_l2_interface checkin

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-17 23:02:36 +05:30
c11d144302 Remove unused imports / variables for junos (#60705)
* Remove unused imports / variables for junos

This is to help with the migration to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* Remove duplicate execute_module() function for junos lacp_interfaces

This seems to have passed lint checks, but something we caught in
collection migration.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-17 22:38:53 +05:30
6a786d0d93 openssl_publickey: add cryptography backend (#60387)
* Add cryptography backend.

* Add changelog.

* Make sure requirements are satisfied.

* Use more compatible elliptic curve.

* Decrease required version numbers.

* PyOpenSSL >= 16.0.0 is really needed.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>
2019-08-17 18:52:14 +02:00
13996aaff6 Fix missing variable with nxos_install_os tests (#60351)
Today we are getting an Ansible templating exception because this
variable isn't defined. But we also don't want testing to run, as we
don't have ability to run this test in DCI.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-17 10:04:50 -04:00
601a4b8f47 get_certificate: add cryptography backend (#60599)
* Add cryptography backend for get_certificate.

* Add changelog.

* Use short names (if possible).

* Adjust version (to behave as pyOpenSSL).

* Work around bugs (needed for cryptography 1.2.3).

* Don't run cryptography backend tests for CentOS 6.

* Bump cryptography requirement to 1.6 or newer.

Otherwise, signature_algorithm_oid isn't there, either.

* Simplify requirement text.

* CentOS 6 has cryptography 1.9, so we still need to block.

* Add auto-detect test.

* Improve YAML.
2019-08-17 16:02:14 +02:00
38435e1bd0 openssl_certificate: various assertonly bugfixes (#60658)
* Fix get_relative_time_option for byte string input. Also fix it for None input.

* Using correct property for invalid_at check.

* Fix invalid_at comparison.

* Converting relative timestamps before comparison for valid_at and invalid_at.

* Fixing key usage display for cryptography backend.

* Fix key usage comparison. OBJ_txt2nid always returns 0 for key usage identifiers.

* Add changelog.

* Fix pyOpenSSL key usage comparison.
2019-08-17 15:58:25 +02:00
cf69b73c04 openssl_certificate/csr_info: add ordered issuer/subject return value (#60708)
* Add ordered issuer/subject return value.

* Add changelog.
2019-08-17 15:49:54 +02:00
100b56439e hcloud_server: Allow users to enable/disable the rescue mode (#60070) 2019-08-17 11:29:58 +02:00
85f7a7e848 Adding Port Security Timeout option in Interface Policy Port Security (#57108)
* Adding support for port security timeout attribute for ACI Interface Policy Port Security

- Feature Pull Request

Network Module ACI

lib:  _aci_intf_policy_port_security.py

* Fixing missing quotes

* Fixing errors raised by ansible-test sanity test

pylint error E321 missing whitespace after comma

Added version 2.9 as version_added

* Fixing the missing version_added under new port_security_timeout option
2019-08-16 22:17:51 -04:00
175f80c788 aci_epg_to_domain - Add switching_mode support (#58429)
* aci_epg_to_domain - Add switching_mode support

##### SUMMARY
When deploying an AVE with VXLAN, the switching mode cannot be native and must be AVE.

##### ISSUE TYPE
- Feature Pull Request

+label: docsite_pr

* Update aci_epg_to_domain.py

* Update aci_epg_to_domain.py
2019-08-17 03:15:32 +02:00
82a00afffb Add aci_extepg.py and aci_extsubnet.py (#58079)
* Add aci_extepg.py and aci_extsubnet.py

* Check pep8 style.

* Remove aci_extsubnet.py.

* Rename to aci_l3out_extepg

* Change file name. (aci_extepg.py -> aci_l3out_extepg.py)
2019-08-17 03:15:18 +02:00
bb7da4239b Fix INTERSITE BUM TRAFFIC ALLOW (#58608)
##### SUMMARY
The payload was using the incorrect keyword to push the True or False statement to the device and was getting dropped. This would also result in erroring out if layer2_unknown_unicase was set to Flood instread of Proxy.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-16 21:10:08 -04:00
b34002bb55 Added preferred group attribute to epg (#59779) 2019-08-17 03:04:52 +02:00
11862782ff Bug fixes for GCP modules (#60666) 2019-08-16 17:41:54 -04:00
ebe55e83c3 Fix ansible-test bin creation.
Use symlink instead of link.
2019-08-16 14:00:43 -07:00
6a5cbcf8b8 Link to the GitHub Web UI for the example file. (#60611)
Change link in the Ansible Config docs to the example `ansible.cfg` file, from the raw download to the web user interface.
2019-08-16 15:09:43 -05:00
68f1e42d95 Minimize collection loader ansible imports
* pass in optional config instead of importing, so other things (eg ansible-test, units) don't have to take a config dependency
2019-08-16 12:36:43 -07:00
def3d1f815 validate-modules: support collections (#60247)
* Start of work to support collections

* remove version_added from base schema

* If a collection, pass that to validate-modules

* clean ups

* Allow version_added in a collection, just make it optional

* Don't traceback on missing doc_fragment

* Don't validate metadata in a collection
2019-08-16 14:28:34 -05:00
7f280434de Remove unused import from eos facts (#60694)
Code clean up to help with collections migration

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-16 15:25:10 -04:00
da57c3b334 Bug fixes for GCP modules (#60664) 2019-08-16 15:24:24 -04:00
7cee7a6d90 Bug fixes for GCP modules (#60665) 2019-08-16 15:24:15 -04:00
8d33e9ae4d Bug fixes for GCP modules (#60667) 2019-08-16 15:23:48 -04:00
818d1b2e45 New Module: gcp_cloudfunctions_cloud_function (#60668) 2019-08-16 15:23:39 -04:00
134379b273 Updating documentation for the setup module (#60696) 2019-08-16 13:42:54 -05:00
e7a8e48053 New Module: gcp_cloudfunctions_cloud_function_info (#60669) 2019-08-16 14:32:35 -04:00
df9b4faa9f Documented disadvantages of using default zabbix password for all zab… (#60639)
* Update lib/ansible/plugins/doc_fragments/zabbix.py
2019-08-16 10:58:06 -05:00
477b34c440 Add network and vpc to args (#60657)
* Add network and vpc to args

network and vpc are needed when create a loadbalancer in a vpc in a recent adquired public ip

* version_added in new args
2019-08-16 11:51:20 -04:00
7e22c7482e Fortinet's new module for fortios_switch_controller_system (#60691) 2019-08-16 20:40:37 +05:30
b4f210945e Fortinet's new module for fortios_system_ha (#60689)
* Fortinet's new module for fortios_system_ha

* Retriggering Ansible checks due to strange failure
2019-08-16 20:40:27 +05:30
ca28ae3be5 FortiOS modules for 2.9 - 2 (#60598)
* FortiOS modules for 2.9 - 2

* Fix long lines and ignore.txt
2019-08-16 20:34:37 +05:30
9c61ef10d1 Fix typo and uses more common role syntax in usage examples (#60165)
* Fix typo and use import_role in examples
2019-08-16 09:34:45 -05:00
da18e3b76c Updating intro_inventory.rst (#60676) 2019-08-16 09:23:58 -05:00
585bfead75 fix ios_interfaces (#60687) 2019-08-16 19:25:28 +05:30
064cd63f3d fix: docker_swarm_service does not publish both tcp and udp ports (#60616)
* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value
2019-08-16 15:23:45 +02:00
48541910bf docker_container: add mount endpoint collision detection (#60384)
* Add mount endpoint collision detection.

* Add changelog.

* Fix error.
2019-08-16 15:23:03 +02:00
523e40e993 nonetype error (#60603) 2019-08-16 06:04:32 -04:00
c5c270d9f7 Typo fix in nxos_file_copy.py (#60659)
Corrected typo in example documentation "local_filr_directory" to "local_file_directory"
2019-08-16 10:40:30 +05:30
06d1705752 Fix mispelling in postgresql_query docs (#60648)
Changed `arbitraty` to `arbitrary` in postgresql_query docs
2019-08-16 10:38:47 +05:30
c60676a118 VMware: add a changelog entry for PR #60476 (#60490)
Add a changelog entry for https://github.com/ansible/ansible/pull/60476.
2019-08-16 09:10:42 +05:30
39d249155a Deprecates Digital Ocean sshkey_facts in favor of new module sshkey_info (#60546)
* Renames Digital Ocean sshkey_facts modules to sshkey_info

* Change digital_ocean_sshkey_facts status to deprected

* Update digital_ocean_sshkey _facts _info doc

* Allow digital_ocean_sshkey_info in Check Mode

* Update lib/ansible/modules/cloud/digital_ocean/_digital_ocean_sshkey_facts.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix _info added version
2019-08-15 23:45:05 +02:00
491a47c7c5 Pure modules: rename _facts with ansible_facts result to _info (#60641) 2019-08-15 22:42:35 +02:00
c4d841f848 Updating intro_inventory.rst (#60651) 2019-08-15 14:42:37 -05:00
31d6d7ada5 Updating developing_inventory.rst (#60647) 2019-08-15 14:41:37 -05:00
d64fe483be Add myself to suse-team in BOTMETA (#57213) (#60624)
I'll help maintaining the code that the suse-team is responsible
for (currently only the zypper module). So adding myself to the
maintainers list.
2019-08-15 14:37:02 -05:00
37dc96b12c Add new Pure Storage maintainer in BOTMETA (#60601) 2019-08-15 14:31:33 -05:00
2ce082c277 Remove unused imports / variables (#60654)
This is to help with the migration to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-15 14:58:57 -04:00
37b30d18f3 Remove unused variable (#60485)
This is to keep our linters happy for ansible_collection vyos migration.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-15 14:47:21 -04:00
d9c44897a6 Fix ansible-test cloud vars overwrite. 2019-08-15 10:20:14 -07:00
218f4276d5 vmware_drs_group: creates test vm properly
Creates the test VMs with `prepare_vmware_test`. Before this commit,
only one VM was created and the next step was failing because this was
not matching the expected list of VMs.
2019-08-15 16:57:39 +02:00
8b78ba095c Fix capitalization of SUSE (#60625)
The openSUSE project was always capitalized openSUSE, and SUSE does not
use the lowercase "u" since over 15 years. Let's update the docs for
this.
2019-08-15 09:04:58 -05:00
c2160274c6 Update purefa_facts to show details on connected arrays (#60368) 2019-08-15 00:30:30 -04:00
535ef2e5ec Update porting guide deprecated modules for junos (#60468)
*  Add deprecating junos modules in porting guide
2019-08-15 09:49:50 +05:30
7968dc4c00 Load integration config test vars from content.
The `test/integration/integration_config.yml` vars file will now be loaded from the content under test and is now optional.

The `output_dir` and `win_output_dir` vars are now provided by ansible-test.
2019-08-14 20:40:59 -07:00
4ebac7d5b7 ansible-galaxy - more fixes for verbosity without sub type (#60604)
* ansible-galaxy - more fixes for verbosity without sub type

* remove testing line
2019-08-15 11:53:40 +10:00
25b20adb94 Fix git module when using absolute repo path.
This prevents a traceback when `repo` is set to an absolute path.
2019-08-14 18:09:56 -07:00
0c74ee4352 Clean up various integration tests. (#60613)
* Fix var_blending test temp dir usage.

* Fix filters integration test:

- Fix use of `output_dir`.
- Use `localhost` instead of `testhost` since we're only testing filters.
- Fix `fileglob` test to actually test a directory that exists.

* Fix lookups integration test:

- Fix use of `output_dir`.
- Use `localhost` instead of `testhost` since we're only testing lookups.

* Fix ansible-runner test temp dir usage.

* Fix template and template_jinja2_latest test.

Use the `OUTPUT_DIR` env var to get the output directory for the tests.

* Fix Python version compat in filters test.

* Skip filters test on Python 2.6.
2019-08-14 16:33:45 -07:00
f52657fb7d Meraki - Initial unit tests (#55251)
* Initial commit for the most basic of unit tests

* Rewrote unit test to actually work
- Uses pytest's fixtures structure, not classes
- Added a test file for importing

* Whitespace fixes

* Draft version of the mock unit test

* Modify code to actually work!

* Add 429 testing

* ansible-test fixes

* Resort lines

* Fix import for 2.x compatibility
2019-08-14 17:00:27 -04:00
7d3c4a8882 Delay persistent connection until needed (#59153)
* Delay calling connect() until absolutely necessary

* Implement transport_test to enable wait_for_connection

* plugin might be connected already for some reason?

* ensure_connect for httpapi

There's some become shenanigans still needing to be ironed out

* Fix tests for network_cli
2019-08-14 16:58:03 -04:00
f02f5c4b5d cloudscale_server: add tags support (#60396) 2019-08-14 22:55:31 +02:00
5298d312a2 cloudscale_server_group: add tags support (#60397) 2019-08-14 22:54:25 +02:00
4a09c7a920 hcloud: Add hcloud_rdns Module (#60123) 2019-08-14 22:51:05 +02:00
814e24fab5 Add note about registering floating IP (#60494)
* Add note about registering floating IP

* Remove trailing whitespace

* adds info to 'wait' param, edits
2019-08-14 14:30:17 -05:00
d808b84621 Update intro_getting_started.rst to take into account inventory precedence when proposing '-u' to change the remote user. (#59858)
* Update intro_getting_started.rst
* adds more info about overriding SSH user to intro
2019-08-14 14:29:41 -05:00
206594c5f0 New Module: Volume Autosize (#59936)
* add new module

* update volume
2019-08-14 15:21:51 -04:00
b8430a3221 vmware_guest_screenshot: fix the functional test
- VM are off my default since 964783fbd2
- `infra.vm_list[0]` → `virtual_machines_in_cluster[0].name`
- `datacenter` key is currently mandatory, see: https://github.com/ansible/ansible/issues/60565
2019-08-14 18:59:58 +02:00
27ff8b1a80 Clean up unused config usage in integration tests. 2019-08-14 09:44:36 -07:00
7955405a23 optparse_helpers: improve unit tests for version() (#59626)
optparse_helpers: improve unit tests for version()
2019-08-14 10:32:26 -05:00
fed6598e28 fixes (#60146) 2019-08-14 10:26:12 -04:00
4cae96109b FortiOS modules for 2.9 - 1 (#60469)
* FortiOS modules for 2.9 - 1

* Fix empty choices and avoid E337,E338 warnings

* Ansible comments on version_added and ignore.txt only on this PR files

* Add version_added also for state attribute

* Avoid null choices on dlp_sensor

* Change required flag according to argspec
2019-08-14 19:44:51 +05:30
5923a64b20 Update junos_facts gather_network_resources choices (#60467)
*  Add negation choice for individual resource names
2019-08-14 19:28:55 +05:30
55d3ecff01 Remove unused variables / imports (#60505)
These helps with the clean up of migrating eos to a collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-14 19:26:34 +05:30
645eebdbbb new options (#60142) 2019-08-14 09:51:38 -04:00
ae794369f8 new module: na_ontap_vserver_cifs_security (#59817)
* new module

* fixes
2019-08-14 09:02:56 -04:00
69bc24f607 lag interfaces resource module (#59175)
* lag interfaces resource module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check imports

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict_diff usage issue fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new task

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* overridden updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict update

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* rebased and merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new failures added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* obsolete file removed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dependency added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-14 17:31:49 +05:30
d8d00c36fa ovirt_vm add linux boot param warning (#60474)
* ovirt_vm add kernel param check

* update check

* update docs phrase

* use douple quotes
2019-08-14 06:24:29 -04:00
b2f1993b20 FreeIPA: Add dynamic update to zones in IPA (#59489)
This feature add a new option to `ipa_dnszone` called
**dynamicupdate** as requested by issue #46768.

It allow user to change between default option `false`
to `true` if user/sysadmin wishes to make zone dynamically
updated.

Fixes #46768

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-08-14 15:38:06 +05:30
7b0a5fb487 ipa_dnsrecord.py: ttl is not required to change zones in ipa (#59924)
this fixes the error reported on issue #56872, is user not pass the argument
module 'record_ttl' it simples removes from json dictionary to make the
correct post request.

Fixes #56872
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-08-14 15:37:33 +05:30
abf7cf97df VMware: Fix typo in vmware_host_dns_facts.py (#60542)
Correct *search_doamin* to *search_domain*
2019-08-14 14:56:04 +05:30
99fb0fcb2f docker_logout: report change on successful logout (#60381)
* Mark logout as changed when docker logout does not return 'Not logged in to '.

* Add changelog.

* Improve logout detection.

* Also return output of 'docker logout'.
2019-08-14 05:23:38 -04:00
6337fbbfe5 Fix naming in example code documentation section for aws_codebuild and aws_codepipeline modules (#60495) 2019-08-14 05:23:25 -04:00
d5d88f9b11 Add nxos_interfaces resource module (#60421)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-14 13:38:22 +05:30
0f35e4b7b9 apt_facts - Fix cache related performance regression (#60511)
* apt_facts - Fix cache related performance regression

* Another minor performance improvement
2019-08-14 03:43:52 -04:00
b07f96c31d Fix integration test temp dir usage. (#60555)
* Fix xfs_quota integration test temp dir usage.
* Fix lvg integration test temp dir usage.
* Fix filesystem integration test temp dir usage.
* Fix connection_windows_ssh test temp dir usage.
2019-08-14 00:12:05 -07:00
ba1b4565d3 Clean up ansible-test results path handling.
This brings us closer to being able to use `tests/` instead of `test/` in collections.
2019-08-13 21:51:57 -07:00
f0d32a2de0 Remove old Makefile targets.
- `pep8` - There is no need to give it more prominent placement than other sanity tests.
- `pyflakes` - The project only makes use of `pylint` and `pycodestyle`. Having the target implies that it should work.
- `loc` - Not used. Easily run manually if needed.
2019-08-13 20:32:16 -07:00
737a500a30 template - move backup to its own doc (#59893)
* template - move backup to its own doc

* Use the backup doc fragment for template
2019-08-14 09:48:37 +10:00
a8d01cf2a2 Made galaxy token file location configurable (#59387)
* Made galaxy token file location configurable

  also made file handling 'unicode safe'

* only create a token on demand

* convert into decorator in case other funcs need
2019-08-14 09:47:40 +10:00
3f784caed1 Table fixing (#60177)
* Change formatting of the network/user_guide tables

* Tables had hardcoded line breaks to workaround a bug in the
  read-the-docs theme.  Change those so that they now flow according to
  the browser size.

* Also switch away from grid tables to the simpler to create and read
  simple tables

* Changes to table stylesheet

* valign all content, not just the first column.  This becomes important
  with more than two columns
* Set the font-weight to the first <p> element inside of the first
  column.  This allows us to simplify the first column when everything
  there is the attribute name

* Change platform_index footnote from numbered to dagger symbol

The footnote notation was very odd to read.  Try using a symbol for the
footnote instead of a number to see if that will clarify it.  We can't
manually specify symbolled footnotes, though, so we have to emulate a
footnote with an internal link.  This loses the backref to each place
that the footnote was used but since that was the portion which was hard
to read, perhaps that's for the best.
2019-08-13 18:23:32 -05:00
14a7722e39 ansible-galaxy tidy up arg parse with better validation (#59957)
* ansible-galaxy tidy up arg parse with better validation

* Add support back in for -v before sub aprser

* Added deprecation warning for manually parsed verbosity
2019-08-14 06:36:29 +10:00
1b8aa798df Update ansible-test integration config handling. (#60448)
* Move Ansible test config into env vars.

This allows ansible-test to use an empty Ansible config file, leaving open the option for users to customize the one used to run tests (although such usage is discouraged).

* Use config from content under test when present.
2019-08-13 13:18:55 -07:00
d9b3af523b Galaxy meta docs table (#60171)
* Use an rst table instead of a raw html table

* Rst is easier to read so we want to use it wherever possible
* Fix the jinja2 filters which create links so that they do not include
  extraneous whitespace in the URL

* Normalize description data before sending them to the templates
2019-08-13 15:00:13 -05:00
60f8483603 Add missing boilerplate to collections test. (#60507)
* Add missing boilerplate to collections test.
* Remove redundant Python version check.
2019-08-13 12:20:14 -07:00
7a2483c47e purefa_phonehome: implement check mode support (#57585) 2019-08-13 13:27:18 -04:00
8923d13537 proxmox_kvm: While a VM is beeing created, vm has no name item (#58196)
* While a VM is beeing created, vm as no name attribute

* Add changelogs fragment
2019-08-13 19:22:17 +02:00
21863d48f3 unit tests: remove unused imports (#60462) 2019-08-13 19:21:43 +02:00
1b1216d2d1 Update file.py's help doc, and narrow down diff logic, for recent pull 56353 (#59069)
* Limiting when path_content is generated

path_content will be empty and unnecessary in all scenarios except when changing the state of a folder to absent, so adding in a check to limit when this parameter is defined
2019-08-13 12:59:13 -04:00
a20848bf66 Use new version of default test image that contains Python 3.8.0b3 (#60139) 2019-08-13 12:28:02 -04:00
49dea22467 Update developing_plugins.rst (#60482)
##### SUMMARY
documentation example-yaml for lookup-plugin seems to have an indent-error


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-13 10:43:38 -05:00
fca8a5ef76 Move all module renames into new section. (#60483) 2019-08-13 10:05:31 -05:00
848c945a2c Fix updating hosts idempotency in purefa_host (#60367) 2019-08-13 10:53:11 -04:00
6915ea96f1 Clarify behavior of --skip-tags, --list-tasks, and --list-tags. (#60492) 2019-08-13 09:47:28 -05:00
ba81084a49 Provide nice error when the shell plugin is incompatible with the con figured become plugin (#60441)
* Provide nice error when the shell plugin is incompatible with the configured become plugin. Fixes #57770

* Add todo

* Add missing import
2019-08-13 09:37:53 -05:00
6b5c7f7c42 Add new module eos_interfaces (#59729)
* Move module_utils

* Add eos_interfaces and deprecate eos_interface

* Add boilerplate, update ignores.txt

* Try to reconcile eos provider documentation with argspec

* Try to work around unknown interfaces

* Move param_list_to_dict to utils
2019-08-13 10:09:52 -04:00
ef0f28097e Remove lo from config (#60480)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 19:10:56 +05:30
2e819c87db new options (#60145) 2019-08-13 09:35:01 -04:00
df2a09e998 vmware: avoid unnecessary copy() call (#60476)
Two vmware modules uses copy() to duplicate an internal instance of a
pyvmomi object. This to be able to modify the object during an iteration.

See: https://github.com/ansible/ansible/pull/60196/files#r312643761

Closes: #60399
2019-08-13 09:27:22 -04:00
fa783c027b Adding waiter to cluster remove process (#57324)
* Adding waiter to cluster remove process

* blank line contains whitespace

* update aws_eks integration test

* Refactor aws_eks test suite to use pip

* update version testing

* missing parens...

* add changelog fragment

* Add waiter to module_utils, fix exception handling.

* Correct EKS waiter checks
2019-08-13 23:11:21 +10:00
2d98734ad5 Amazon modules: rename _facts with ansible_facts result to _info (#60178)
* aws_s3_bucket_facts -> aws_s3_bucket_info

* cloudformation_facts -> cloudformation_info

* cloudfront_facts -> cloudfront_info

* ecs_service_facts -> ecs_service_info

* efs_facts -> efs_info

* Add changelog and porting guide entry.

* lambda_facts -> lambda_info

* Improve examples.

* Add subsection on renamed modules.

* Add sentence on registering variables.

* Fix ReST.

* Instead of renaming lambda_facts, deprecate it and replace with new module.

* Rename internal variable.

* Re-add sanity ignores for lambda_facts.
2019-08-13 08:01:37 -04:00
dee13ea4f8 ovirt vm update kernel docs (#60407)
* ovirt vm update kernel docs

* update doc phrase

* update docs
2019-08-13 07:11:05 -04:00
e3d13cbcdc Ovirt host update force docs (#60202)
* update docs

* update pep8 syntax

* update pep8 syntax
2019-08-13 06:35:05 -04:00
5972567ab6 ovirt_vm update tempalte search by datacenter (#60461) 2019-08-13 06:16:25 -04:00
6110dcc789 Add iosxr_lldp_interfaces resource module (#60411)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 14:58:55 +05:30
a40baf22fa various mod_args fixes (#60290)
* various mod_args fixes

* filter task keywords when parsing actions from task_ds- prevents repeatedly banging on the pluginloader for things we know aren't modules/actions
* clean up module/action error messaging. Death to `no action in task!`- actually list the candidate modules/actions from the task if present.

* remove shadowed_module test

* previous discussion was that this behavior isn't worth the complexity or performance costs in mod_args

* fix/add test, remove module shadow logic

* address review feedback
2019-08-13 09:57:49 +01:00
9efa00e762 Add [junos_lldp_global] model (#59712)
* Add [junos_lldp_global] model

*  Add new resource module junos_lldp_global
*  Targets model https://github.com/ansible/network/pull/30
*  Deprecate junos_lldp module

* Run lldp integration test only if protocol supported
2019-08-13 13:05:17 +05:30
0acf7be56a Add nxos_lacp_interfaces resource module (#60313)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-13 12:13:35 +05:30
4512f664a7 Update ce_bfd_global to fix bugs (#60412) 2019-08-13 02:11:51 -04:00
c27b5ae1a3 add option proxy to get_certificate module (#60076)
* add option proxy to get_certificate module

* Add python 2.7 or higher to requirements

* Modify requirements and add create_default_context module import check processing

* add changelog file for get_certificate

* Modify changelog file
2019-08-13 01:34:04 -04:00
25d396fdfc Fix testing of Windows binary modules. 2019-08-12 22:19:35 -07:00
d36919856f Update integration tests. (#60447)
* Remove unnecessary ANSIBLE_CONFIG override.
* Fix pull integration test.
* Fix inventory_foreman integration test.
2019-08-12 16:23:47 -07:00
262d2a6837 Update docs with file deletion details as recommended in #59051 (#60168) 2019-08-12 15:57:29 -05:00
8346898605 [docs] Fix subversion.py export example (#60438)
The svn export example was missing the `export: yes` parameter. It was accidentally omitted when the syntax was changed in ad6999e2eb.
2019-08-12 15:52:36 -05:00
c485a1b91e Fix sanity tests based on newer version of shellcheck (#60423)
- change egrep to grep -E
- store exit codes and check them directly
- ignore SC1091
2019-08-12 16:24:28 -04:00
697b566971 Update units to pass on macOS (#60435)
* Update units to pass on macOS. Fixes #27810

* raising=False
2019-08-12 15:13:07 -05:00
8bca160363 add vfat to selinux special_context_filesystems (#59823)
vfat is the format of the /boot/efi partition on UEFI hosts and does
not support SELinux labels

add an environment variable for this config option
2019-08-12 14:45:27 -04:00
6cb5b67b22 Bug fixes for GCP modules (#60115) 2019-08-12 14:34:20 -04:00
be459c00bf Bug fixes for GCP modules (#60337) 2019-08-12 14:31:35 -04:00
687da46a85 Bug fixes for GCP modules (#60338) 2019-08-12 13:41:41 -04:00
0855820574 Update package_facts.py (#60402)
Fixed a type in the description about the package_facts module where information was typed informatino.
2019-08-12 10:51:25 -05:00
d320222eb3 gitlab_runner: document minimal dependency version (#60371) 2019-08-12 10:50:34 -05:00
273a2d7a79 gitlab_runners (#60370)
Fix choices formatting in plugin option.
2019-08-12 10:49:12 -05:00
7e69d67f28 Fix firewalld rich_rule example (#60379)
The rich rule example didn't specify the `family` field, which firewalld will fail on if not provided.
2019-08-12 10:44:39 -05:00
c71622b31a user: createhome=no home=/no/such/dir (#60310)
Fixes #60307.

This bug was introduced in commit d2edf1d435
("User - Create parent directories if they do not exist in the specified
home path (#51043)") and did not make it into any releases.
2019-08-12 10:37:45 -04:00
13403b3688 update to command (#60141) 2019-08-12 10:30:00 -04:00
5df9075386 New Module: na_ontap_ports (#59814)
* new module

* fixes
2019-08-12 10:23:24 -04:00
abc5654738 Fix netapp_e_iscsi_target chap secret size and clearing functionality. (#57135) 2019-08-12 09:52:40 -04:00
93484adca3 Create team_suse in BOTMETA (#57213)
A team of SUSE employees and openSUSE community members will
now be able to step up and help maintain zypper modules.

For this, it makes sense to create a team.

I will be the first person of this organisation.
I have started a process internally to start this initiative,
and will extend this to the OpenSUSE ML when this has merged.
2019-08-12 09:35:54 -04:00
09f712c7f3 Add iosxr_lldp_global resource module (#60074)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-12 18:03:23 +05:30
3929dc00a1 unittests: remove unused imports (#60404) 2019-08-12 13:35:39 +02:00
8d3fa2251e Search project in domain when it's defined (#59876)
Since there might be several projects with the same name in different
domains, it's required to define domain_id during project search.
Otherwise openstacksdk will raise "Multiple matches found" error
2019-08-12 07:05:36 -04:00
a3407682ed ansible-test: fix the vcenter+vcsim support
The vcenter provider allow one to use the `VMWARE_TEST_PLATFORM` to
manually select a test platform. The test platforms are:

- `govcsim`
- `static`
- and `worldstream`.

Before this commit, the `govcsim` value was ignored.

Example:

```shell
$ VMWARE_TEST_PLATFORM=govcsim ansible-test integration --python 3.7 needs/target/prepare_vmware_tests/
```
2019-08-12 11:55:38 +02:00
60a1545092 Fortinet's new module for fortios_switch_controller_vlan (#59630)
* Fortinet's new module for fortios_switch_controller_vlan

* Update fortios_switch_controller_vlan.py

* Update fortios_switch_controller_vlan.py
2019-08-12 14:58:02 +05:30
f1a4ab0aa5 Fortinet's new module for fortios_switch_controller_virtual_port_pool (#59601)
* Fortinet's new module for fortios_switch_controller_virtual_port_pool

* Update fortios_switch_controller_virtual_port_pool.py

* Update fortios_switch_controller_virtual_port_pool.py
2019-08-12 14:56:11 +05:30
079a4408ab Fortinet's new module for fortios_switch_controller_switch_profile (#59683)
* Fortinet's new module for fortios_switch_controller_switch_profile

* Update fortios_switch_controller_switch_profile.py

* Update fortios_switch_controller_switch_profile.py
2019-08-12 14:55:19 +05:30
1d6bce961c VMware: Add writing new tests subsection to vmware_guidelines (#60163)
* Add writing new tests subsection to vmware_guidelines

Specifically address use of the prepare_vmware_tests role
Point to common vars for use by test writers

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-12 11:13:21 +02:00
602aded6ec vultr: vultr_block_storage_facts to info (#60230) 2019-08-12 10:36:21 +02:00
0a90ec90c0 VMware: handle KeyError in get_vm API (#60204)
Fixed if conditions for all VM params
2019-08-12 14:03:13 +05:30
8cbfa75038 Add [junos_lacp] model (#59705)
* Add [junos_lacp] model

*  Add new resource module junos_lacp.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/28

* Fix CI issues

* Fix CI failures
2019-08-12 13:54:44 +05:30
84d89190c7 openssh_keypair: Forgot version_added in #59268. (#60394) 2019-08-12 10:22:27 +02:00
622a493ae0 icx: new module icx_ping (#59975)
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_ping

* new changes

* Fixed bot error
2019-08-12 12:01:15 +05:30
f4502a8f1c Set eth0 to dhcp explicitly (#60305)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-12 11:36:54 +05:30
fdf48ed0b4 Add [junos_lacp_interfaces] resource module (#59708)
* Add [junos_lacp_interfaces] resource module

*  Add new resource module junos_lacp_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/36

* Fix sanity test failure
2019-08-12 11:24:34 +05:30
e4dc17fa9f Fix small typo in pip install guide (#60389)
Noticed this small typo in the docs:
- `Ansble` -> `Ansible`
2019-08-12 10:21:00 +05:30
35b87b8633 Move windows test to another group (#60391) 2019-08-12 10:00:09 +10:00
dda80c46e9 openssh_keypair - Add key `comment` to return output (#59268)
If the comment will be provided during the key creation, it will be
diplayed in the return values.
Same will be on the comment change.
2019-08-11 13:47:34 +02:00
8da48b1a40 inventory: cloudscale: extend examples (#60306) 2019-08-11 11:17:47 +02:00
e956753e83 Update ce_acl_advance to fix bugs (#60377) 2019-08-11 03:38:22 -04:00
27e414200f openssh_keypair - Add public key and key comment validation (#57993)
- Split the key validation to separate private and public.
- In case public key does not exist, recreate it.
- Validate comment of the key.
- In case comment changed, update the private and public keys.
2019-08-10 18:57:35 -04:00
a3d55a5ddb fix spelling: certifivate -> certificate (#60369)
##### SUMMARY
spelling fix

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-10 18:39:26 -04:00
7a37ad1f93 update ce_acl_advance to fix bugs (#60353) 2019-08-10 00:54:39 -04:00
473bd6bb0a Relax boilerplate sanity tests.
This will avoid requiring boilerplate for documentation only python files.
2019-08-09 18:49:57 -07:00
3fac6a0adb Fix ansible-test TypeVar type annotations. 2019-08-09 17:29:41 -07:00
86ead40c2b New Module: gcp_compute_snapshot_info (#60342) 2019-08-09 19:26:59 -04:00
30ad73f1c1 Bug fixes for GCP modules (#60339) 2019-08-09 19:17:44 -04:00
5d4c3ad97e Bug fixes for GCP modules (#60340) 2019-08-09 19:17:36 -04:00
1b45abc4f3 Fix major bug in the last update of this module. (#60223) 2019-08-09 18:11:33 -04:00
8b68feb67e acme_certificate: allow to download alternate certificate chains (#56334)
* Improve link handling.

* Also fetch alternate certificate chains.

* Add retrieve_all_alternates option.

* Simplify code.

* Forgot when condition.

* Add tests for retrieve_all_alternates.

* Fixes.

* Moved utility function for link parsing to module_utils.

* Fix grammar.
2019-08-09 23:54:48 +02:00
e9fc095123 Improve docker_compose module documentation (#60064)
* Improve docker_compose module documentation

* Swap usage of C() and I()

* Further improvements

* Mentions of files (docker-compose.yml) are now rendered correctly.
* Compose files are now called just that.

* Further clarify options "services", "stopped" and "restarted"

* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-09 23:51:58 +02:00
3290b8343c docker: fix sanity errors (#60047)
* Remove sanity check errors.

* More linting.

* Forgot to update places.

* Remove choices which aren't provided in argspec.
2019-08-09 23:50:11 +02:00
4f78b694f0 Remove unused imports / variables from vyos modules (#60333)
This code is not used, lets remove it.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-09 16:47:08 -04:00
2e90efd4a7 Changing GCP Facts modules to Info Modules (#60172)
* file changes, porting guide, changelog fragment, renaming autoscaler, removing rst links
* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-09 15:13:08 -05:00
b6202dde32 Allow firmware update for (SP, ACP, Shelf, Disk) (#58597)
* update

* Revert "update"

This reverts commit 84848f8291.

* correct module

* fixes
2019-08-09 16:04:46 -04:00
84e3c0ef1d Fix changelog entry for playbook_dir fix
The final version of the fix makes the addition in two places instead of
moving the single addition from one place to another
2019-08-09 12:33:38 -07:00
2d266fbc87 Fix unit tests to work with pytest >= 5.0 (#60246)
pytest made a change in the way the message from ExceptionInfo objects was returned.

https://docs.pytest.org/en/latest/changelog.html#pytest-5-0-0-2019-06-28
2019-08-09 14:58:46 -04:00
5a50fb35df Add sanity test for obsolete files.
This will help prevent accidental merging of content to recently obsoleted directories when adding new files.

It may also help contributors who have modified obsolete files understand where their changes should now be made.
2019-08-09 11:22:59 -07:00
cb68110296 Clean up ansible-test inventory templates. (#60321)
* Move ansible-test inventory templates.
* Remove obsolete inventoy.remote.template file.
2019-08-09 11:06:21 -07:00
93d9d64038 facts: fix double-counting of CPUs on POWER systems (#58360)
On POWER systems, /proc/cpuinfo provides a 'processor' entry as a
counter, and a 'cpu' entry with a description (similar to 'model name'
on x86). Support for POWER in get_cpu_facts was added via the 'cpu'
entry in commit 8746e692c1.  Subsequent
support for ARM64 in commit ce4ada93f9
used the 'processor' entry, resulting in double-counting of cores on
POWER systems.

When unit tests were later written for this code in
commit 55306906cf, the erroneous values
were just accepted in the test instead of being diagnosed.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
2019-08-09 13:01:29 -04:00
2a9964ede8 Code cleanup in ansible-test. (#60318)
* Move ansible-test units code into separate dir.
* Fix --explain on "code smell" sanity tests.
* Add --strict-markers to pytest invoctaion.
* Fix classification of units code changes.
2019-08-09 09:38:19 -07:00
1405e48157 Fix documentation for collection build code example (#60156) 2019-08-09 11:05:05 -05:00
b5f42869dc win_dns_record PTR docs update (#60158)
* win_dns_record PTR docs update

* Update win_dns_record.py
2019-08-09 11:04:09 -05:00
6c09b5c659 Unit test cleanup. (#60315)
* Clean up option parsing unit tests.
* Remove unused unit test marker and import.
2019-08-09 08:31:13 -07:00
d61df0a9ba Lun mapping upstream dev (#57096)
* Fix hosts with same lun number conflict in netapp_e_lun_mapping.

This patch fixes an issue of when multiple hosts are created and then
subsequently volume(s) are mapped to them using the same specified number.

* Fix netapp_e_host module bug when lun=0

* Add thin-volumes to the netapp_e_lun_mapping update_mapping_info method.
2019-08-09 08:25:38 -04:00
48021a4200 add modify to snapshot policy (#59149) 2019-08-09 07:56:31 -04:00
f088621610 Update azure_rm_webapp related document (#59027)
* Update azure_rm_webapp related document

* resolve format error

* remove whitespace

* update new

* updated according by comments

* update new according by comments

* add support time
2019-08-09 07:30:57 -04:00
dbd082efe4 Ansible.AccessToken - Added shared util for managing a Windows access token (#60302)
* Ansible.AccessToken - Added shared util for managing a Windows access token

* Fix tests when running in CI

* More fixes for older servers

* More fixes for Server 2008
2019-08-09 21:10:44 +10:00
49e16922b2 Remove no longer necessary check (since elements is procesed for path). (#59953) 2019-08-09 09:40:26 +02:00
309a58eafd Add [junos_l2_interfaces] resource module (#59693)
* Add [junos_l2_interfaces] resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/12
*  Deprecate junos_l2_interface module

* Fix CI failures

* Fix CI issues
2019-08-09 13:09:19 +05:30
df59f06d6a Additional ansible-test path fixes. (#60300)
* Add missing ansible-test injector symlink.
* More ansible-test path fixes.
* Expand bin-symlinks docs.
2019-08-08 23:51:03 -07:00
3777c2e93d Fix plugin names when loading all plugins. (#59950)
* Fix plugin names when loading all plugins.

Add an integration test to verify plugin __package__ and __name__ are correct.

* Make sure filter and test names are unique.

* Remove __package__ test.

On Python 2.x __package__ is not set, but it is on Python 3.x.
2019-08-09 07:23:12 +01:00
d3624cf4a4 VMware: test - add missing datacenter parameter (#60273)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-09 11:17:44 +05:30
39b3fc0926 Update ansible-test layout and payload handling. 2019-08-08 21:34:38 -07:00
07051473f8 Disable failing inventory_docker_machine test. 2019-08-08 20:39:04 -07:00
9aabe70452 update ce_aaa_server_host to fix bugs (#60272) 2019-08-08 22:52:25 -04:00
647b78a09c VMware: Check if datastore is valid (#58872)
Check validation of datastore selected using autoselect_datastore API.

Fixes: #58541

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-09 07:56:52 +05:30
57dc7ec265 Prepare ansible-test for inclusion in setup.py (#60294)
* Cache ansible version lookup.
* Fix method of determining ANSIBLE_ROOT.
* Clean up based on PyCharm inspections.
* Generate minimal PKG-INFO without setup.py.
* Use ANSIBLE_LIB_ROOT where possible.
* Use import instead of subprocess to get version.
* Fix install layout type.
* Correct required paths message for installs.
* Update list of files copied during delegation.
* Fix ansible-test entry point.
* Fix pylint issue.
* Fix version lookup on Python 2.x.
* Fix pylint issue.
* Remove unwanted print statement.
2019-08-08 16:14:19 -07:00
b38cb37728 Transform octal escape sequences in mtab fields (#60122) 2019-08-08 16:31:42 -05:00
9cb47832d1 Pin openshift <=0.9.0 to prevent test failures (#60245) 2019-08-08 14:28:40 -05:00
aa717661af Move assertion in unit test inside loop (#60232) 2019-08-08 14:27:49 -05:00
ed21aba442 add link to content collector tool (#59881) 2019-08-08 14:17:26 -05:00
b0ec91e69e Autointerpreter table (#60148)
* Some framework for docs

* Separate CSS file for our site-specific CSS.
* Override the read-the-docs theme for tables so that tables don't
  always horizontally scroll
* Add a |br| substitution that lets us line break inside of tables
* Add |_| non-breaking-space substitution which is also for formatting
  tables
* Configure rstcheck to ignore all substitutions which are being added
  by sphinx in the conf.py

* Fix table of auto interpreter options

The table was being hardcoded at a certain width to work around a
read-the-docs theme bug.  Fix the bug instead and format the table using
better sphinx practices.

* Remove unused substitutions

We had substitutions defined that were never used in our documentation.
Remove those.

Also add to the rstcheck whitelist three substitutions which are defined
by sphinx itself, version, release, and today.
2019-08-08 13:56:07 -05:00
707e33793d Undeprecated the skip argument for first_found. Fixes #58942. Fixes #59949. (#60161) 2019-08-08 13:55:11 -05:00
c954c07271 TRANSFORM_INVALID_GROUP_CHARS: document "ignore" option (#57318)
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-08-08 13:50:20 -04:00
54d9d7805d systemd module will now wait on deactivating state (#59471)
If a service is in the 'deactivating' state running systemctl stop foo,
would wait for the foo service to actually stop before it exits. The
module didn't behave like that and it considered the deactivating state
as if the service wasn't running. This change will align the module with
the systemctl behaviour.
2019-08-08 12:56:17 -04:00
97a0810e0f Move ansible-test entry point. (#60281) 2019-08-08 09:18:31 -07:00
577bb88ad8 Added support for syspurpose to redhat_subscribtion module (#59850)
* Added several unit tests
* Added documentation for new syspurpose option and suboptions
* Simplified specification of module arguments
* Added new changelog file with fragments
2019-08-08 11:43:05 -04:00
10543c8a4c Facts dev upstream (#57082)
* Improved netapp_e_facts module.

Added the following facts:
  - storage system segment size
  - cache block size capabilities
  - workload tags
  - storage array hosts
  - host groups
  - list of mapped volumes for each initiator

* Remove proxy specific facts from netapp_e_facts module

* Add unit tests for netapp_e_facts module.
2019-08-08 11:36:23 -04:00
6932a5b357 add npipe support to docker_swarm_service (#60073)
* add npipe support to docker_swarm_service

* add changelog fragment

* tweak changelog fragment formatting

* Update lib/ansible/modules/cloud/docker/docker_swarm_service.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-08 17:25:13 +02:00
c2e7683926 update ce_aaa_server to fix bugs (#60270)
* update ce_aaa_server to fix bugs

* update ce_aaa_server to fix bugs
2019-08-08 11:03:42 -04:00
66c3e9bb9b update ce_acl to fix bugs (#60274) 2019-08-08 11:03:29 -04:00
29f89b33ba pacman: fix package state detection (#51311) 2019-08-08 16:48:57 +02:00
6f0aae256d Add [junos_lldp_interfaces] model (#59720)
* Add [junos_lldp_interfaces] model

*  Add new resource module junos_lldp_interface
*  Targets model https://github.com/ansible-network/resource_module_models/pull/40
*  Deprecate junos_lldp_interface module

* Fix CI issues
2019-08-08 18:23:54 +05:30
f6ae6eb3e0 Remove automatic default group assignment in netapp_e_host module (#60239) 2019-08-08 08:48:09 -04:00
87a568da0b Add nxos_lacp resource module (#59717)
* Add nxos_lacp resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-08 16:52:16 +05:30
a595c60d4c Add eth0 in prepare_vyos_tests (#60212)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-08 16:45:01 +05:30
534a40c5cd Move win target back a group (#60257) 2019-08-08 12:03:32 +10:00
5f67b5a757 Move ansible-test coverage config to test/lib/ 2019-08-07 18:32:46 -07:00
2e7d36a3f9 Fix placement and handling of ansible-test cloud config (#60253)
* Move cloud templates.
* Update paths for cloud config templates.
* Fix cloud config paths.
* Fix cloud-config classification.
2019-08-07 18:32:30 -07:00
81cb6f366a Added group 7 to Windows groups - ci_complete (#60240) 2019-08-08 10:13:28 +10:00
6a5cd9a820 prevent recursive logging csharp stackoverflow. (#59503)
* prevent recursive logging situation.

* Add changelog
2019-08-08 09:50:41 +10:00
2cae0739e9 updates (#60143) 2019-08-07 19:44:44 -04:00
2c90ddd44d Allow encryption of volumes based off snapshots (#58983)
Since May 10, 2019 AWS have allowed encrypted volumes to be created from snapshots.  BOTO3 allows this, but the EC2 module does not.  This change removes the restriction.

https://aws.amazon.com/about-aws/whats-new/2019/05/launch-encrypted-ebs-backed-ec2-instances-from-unencrypted-amis-in-a-single-step/
2019-08-07 16:38:17 -07:00
d5a02fb3c8 Updated Docs to clarify how 'become' is handled (#60006) 2019-08-08 08:48:21 +10:00
2cca9176a7 Added a Docker Machine dynamic inventory plugin (#54946)
* Added my Docker Machine dynamic inventory plugin (from https://github.com/ximon18/ansible-docker-machine-inventory-plugin) to begin the process of proposing it for inclusion in Ansible core. There are no integration tests yet. The docker_swarm inventory plugin has such tests but has some concerning note in its 'aliases' file about disabling docker due to test instability and also I wouldn't know at his point how to get Docker Machine installed on the integration test platform.
2019-08-07 18:14:14 -04:00
3a3727d200 Remove Python 2.6 from Windows tests (#60235) 2019-08-08 07:32:09 +10:00
5d8302120b Removed breaking type check from nagios module (#49568)
* Removed extraneous type check from nagios module, in order to allow python 3.x

* Removed now useless import types

* Added changelog fragment

* Update changelog.

* Rebased and removed check due to module adding earlier guardrails

* Updated changelog to mention earlier fix adding now completely removed guardrails

* Remove superfluous type checks. Fix docs type.

* Update ignore.txt.
2019-08-07 22:43:14 +02:00
7b90e8aec4 Add iosxr_lacp_resource module (#59724)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-08 00:13:06 +05:30
47796af64f Change dummy package name in yum/dnf tests to not collide with an actual package (#60225)
When targeting 'foo*' in tests, it pulled in packages other than the dummy packages in our testing repo that have many dependencies, some of which were causing tests to fail.

Also change 'bar' package name to avoid the same issue in the future.
2019-08-07 14:26:55 -04:00
5a6003d0ed fix misleading example in docker_image doc (#60207)
Using docker_image to tag an image as "latest" only updates an existing
tag when used with "force_tag: yes" option. As "latest" is present in
most cases, the option is added to the example to prevent unexpected
behaviour.
2019-08-07 13:44:37 -04:00
278044358c Split up ansible-test sanity test requirements. 2019-08-07 09:34:26 -07:00
a93a0c8fd6 Relocate validate-modules for easier testing. (#60214)
* Relocate module validator code and tests.
* Fix validate-modules entry point and imports.
* Fix paths and test entry points.
* Fix up unit tests.
* Fix shebang and execute bit.
2019-08-07 09:34:11 -07:00
164881d871 Remove UnsafeProxy (#59711)
* Remove UnsafeProxy

Move the work from UnsafeProxy to wrap_var and add support for bytes.
Where wrap_var is not needed, use AnsibleUnsafeBytes/AnsibleUnsafeText
directly.

Fixes #59606

* item is not always text

* Address issues from reviews

* ci_complete
2019-08-07 10:39:01 -05:00
e80f8048ee Fix netapp_e_volume wait-for-initialization to complete issue. (#58304)
* Fix netapp_e_volume wait-for-initialization to complete issue.

* Add unit tests for wait_for operations in netapp_e_volume module.
2019-08-07 11:28:39 -04:00
d00aaf66d7 fixes assert statements in tests (#59998) 2019-08-07 06:52:41 -07:00
18e0d679dd hcloud: Fix missing labels propagation in inventory plugin. (#57586) 2019-08-07 15:51:09 +02:00
ce1f25cffd adds module to manage apm acls (#59992) 2019-08-07 06:48:55 -07:00
77b323459f adds more modules to bigip provision (#59996) 2019-08-07 06:45:27 -07:00
7b97abf6a2 adds apm module to manage network access components for APM (#59993) 2019-08-07 06:44:57 -07:00
47e3ed8100 adds module to manage device self signed certificates (#59994) 2019-08-07 06:44:41 -07:00
0d92abad7d adds module to manage snat translations (#59995) 2019-08-07 06:43:10 -07:00
57cbfae797 added user information collection to bigip_device_info (#60016) 2019-08-07 06:42:43 -07:00
4308b87d72 Don't truncate cidr_ipv6 addresses in ec2_group.py (#59106)
* Better cidr_ipv6 validation in ec2_group.py

* Improve warning/error handling, add changelog

* Update unit test for ipv6 validation

* Fix logic that was causing non /128 cidrs with host bits to not be handled
2019-08-07 08:39:55 -04:00
8751319820 Add wait_sleep parameter for the k8s module (#59714) (#59854) 2019-08-07 21:27:54 +10:00
8c0ec5fd82 delete the check for the resource group (#58492) 2019-08-07 05:36:14 -04:00
041ede30b3 Update azure_rm_appserviceplan_facts.py (#58847)
<!--- Your description here -->

+label: docsite_pr
2019-08-07 05:25:36 -04:00
d5bff7a87f VMware: vmware_export_ovf fix timeout and export path issue (#60062)
* fix timeout and export path issue

* change path type
2019-08-07 05:05:42 -04:00
279617a94e add docs (#60192) 2019-08-07 04:41:33 -04:00
45d0e5994a win_user - use proper error code when failing to validate creds (#60181) 2019-08-07 18:28:44 +10:00
92187ae53e icx: new module icx_command (#59903)
* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* new module icx_command

* PR issue

* new PR fix
2019-08-07 13:27:24 +05:30
fb87bafaae ovirt vnic network filter fix (#59727)
* init network filter fix

* add check_params

* update migratable state

* update pass through check

* update pep8 syntax

* allow remove description

* update_check change default attr for network_filter and qos

* update_check qos and network filter update

* add docs about exeption

* remove blank space

* update docs and add comments to conditions

* update comment

* update migratable var for pass_through enabled
2019-08-07 03:49:36 -04:00
7b583e114d Remove description from junos_l3_interfaces (#60058)
The description will be just handled by the _interfaces module, this one
will be just dealing with l3 config options.
2019-08-07 13:10:49 +05:30
d165223f74 New Module: gcp_compute_autoscaler_facts (#60097) 2019-08-07 01:09:23 -04:00
24274b72c9 UCS: new module ucs_vlan_find (#59220)
* UCS: new module to find vlan(s) based on different criteria
* extending ucs doc
* doc update
* Minor fix
2019-08-07 09:02:23 +05:30
9e31cf7270 Avoid pylint error on Python 3.7. 2019-08-06 17:19:01 -07:00
18867847f4 Split up "code smell" sanity tests. (#60174)
* Relocate ansible-only sanity tests.

* Get "code smell" sanity tests from multiple dirs.

- `test/lib/ansible_test/_data/sanity/code-smell/` - General purpose tests used for both Ansible and Ansible Collections.
- `test/sanity/code-smell/` - Tests specific to Ansible, will not be used for Ansible Collections.
2019-08-06 17:17:57 -07:00
709a8c5026 Fix ansible-test classification of sanity changes. 2019-08-06 17:17:31 -07:00
9da5908afb Fix ansible-test layout path generation. 2019-08-06 16:07:53 -07:00
233efe0886 Add missing boilerplate. 2019-08-06 15:45:22 -07:00
5673482460 bug fix (#60140) 2019-08-06 17:53:29 -04:00
d651bda123 Relocate ansible-test code. (#60147)
* Initial move of `test/runner/` content.

`test/runner/lib/` -> `test/lib/ansible_test/_internal/`
`test/runner/`     -> `test/lib/ansible_test/_internal/data/`

* Initial move of `test/sanity/` content.

`test/sanity/` -> `test/lib/ansible_test/_internal/data/sanity/` (except `test/sanity/ignore.txt`)

* Initial move of `test/units/pytest/` content.

`test/units/pytest/` -> `test/lib/ansible_test/_internal/data/pytest/`

* Follow-up move of `test/runner/unit/` content.

`test/lib/ansible_test/_internal/data/unit/` -> `test/lib/ansible_test/tests/unit/`

* Initial move of `ansible.cfg` content.

`test/units/ansible.cfg` -> `test/lib/ansible_test/_internal/data/units/ansible.cfg`
`test/env/ansible.cfg` -> `test/lib/ansible_test/_internal/data/env/ansible.cfg`

* Follow-up move of `data` directory.

`test/lib/ansible_test/_internal/data/` -> `test/lib/ansible_test/_data/`

* Update import statements.

* Add missing __init__.py for unit tests.

* Fix path references and miscellaneous issues.
2019-08-06 14:43:29 -07:00
923e21836b Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI (#59557)
* Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI. Fixes #59548

* Restore cli additions
2019-08-06 15:58:15 -05:00
61d60d07d1 no logging for service account contents (#60149)
* no logging for service account contents

* changelog

* fixes
2019-08-06 15:27:11 -05:00
94f5e2d9ed ansible-galaxy - ignore cert failures for login (#59959) 2019-08-07 05:59:34 +10:00
acbffce079 Host dev upstream (#57086)
* Improve netapp_e_host module

Add host type strings for windows, windows cluster, linux and vmware to netapp_e_host module
Make host port information case-insensitive in netapp_e_host module
Fix port removal and default group.
Fix port reassignment in netapp_e_host module.
Fix port label or address change within existing host object in module netapp_e_host
Add unit and integration tests

* Created new unit test for netapp_e_host module
2019-08-06 15:01:22 -04:00
80e5b2ade5 Update broken NCLU documentation link (#60009) 2019-08-06 13:46:31 -04:00
2af67f0dce fixes issue with RD encoding in names (#59990)
fixes issue with file download function on ASM file transfer endpoints
corrects doc fragments
removes not used parameters
corrects various sanity failures previously ignored across multiple modules
2019-08-06 10:11:02 -07:00
54b04f227e Update validate example in copy.py (#60053) 2019-08-06 11:32:40 -04:00
faebe22439 Conflicting Documentation (#60135)
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
2019-08-06 11:32:12 -04:00
828e346f2c Conflicting Documentation (#60136)
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
2019-08-06 11:31:13 -04:00
1c0b733489 Conflicting Documentation (#60137)
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
2019-08-06 11:27:50 -04:00
a9aeabb456 Improve netapp_e_storagepool and add units. (#57095)
Refactored module to use eseries base class
Removed E322 and E326 for netapp_e_storage module from the ignore.txt file
Updated version_added quotes in netapp_e_storagepool
2019-08-06 10:02:14 -04:00
2c432f8bc7 Add vyos_l3_interfaces resource module (#59929)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-06 19:30:58 +05:30
e3681c049c Add junos vlans resource module (#59041) 2019-08-06 16:00:01 +02:00
2a1393e0e1 VMware: Check dvswitch presence before accessing it (#60052)
Check if dvswitch object is not None before accessing it's
properties such as UUID. This can be due to two reason

1. Permission issues
2. There is no association between given distributed virtual portgroup
distributed virtual switch

Fixes: #59952

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-06 10:38:50 +05:30
b101fda4c6 Use constants to construct ansible-test paths. 2019-08-05 20:39:05 -07:00
dd7b9627ad Runas docs (#60082)
* Mention seclogon requirement in runas docs

* Mention seclogon requirement in Win become docs
2019-08-06 10:44:17 +10:00
fa2adf3b7b More prep for ansible-test relocation. (#60114)
* Update pytest plugins.
* Fix update-bundled sanity test.
* Remove old validate-modules comment.
* Fix ansible-test plugin loading
* Update code coverage comments.
* Fix Makefile ansible-test reference.
* Remove incorrect path from lint output.
* Update ansible-test unit tests.
* Make ansible-test's own unit tests singular.
2019-08-05 16:38:21 -07:00
ac5228390c Removing validate-module exceptions on GCP modules (#60113)
* facts modules with new types
* remove ignores on sanity tests
* removing new modules
2019-08-05 16:17:06 -07:00
2a64a84667 New Module: gcp_cloudtasks_queue_facts (#60095) 2019-08-05 18:38:09 -04:00
4317a97c42 New Module: gcp_compute_autoscaler (#60096) 2019-08-05 18:38:00 -04:00
26a2d84dba New Module: gcp_compute_snapshot (#60098) 2019-08-05 18:37:51 -04:00
820cfbbb77 Bug fixes for GCP modules (#60089) 2019-08-05 18:26:14 -04:00
8241fd88de Bug fixes for GCP modules (#60090) 2019-08-05 18:26:06 -04:00
fcc869ab7a Bug fixes for GCP modules (#60091) 2019-08-05 18:25:57 -04:00
0234937ca3 Bug fixes for GCP modules (#60092) 2019-08-05 18:25:49 -04:00
de8d428157 Bug fixes for GCP modules (#60093) 2019-08-05 18:25:41 -04:00
c1a99c390c Bug fixes for GCP modules (#60088) 2019-08-05 18:16:26 -04:00
b446ca100f Prepare ansible-test code for relocation. (#60110)
* Fix imports in cli.py.

* Fix imports in executor.py.

* Remove old test/runner/ansible-test entry point.

Use the official bin/ansible-test entry point instead, which has been around since Ansible 2.5.

* Use bin/ansible-test on Shippable.
2019-08-05 14:56:38 -07:00
71e607dceb Update docs references for ansible-test. (#60109)
* Remove outdated info from azure-requirements docs.
* Correct validate-modules usage.
2019-08-05 14:56:05 -07:00
9fd244319e Clean up ansible-test references in tests. (#60108)
* Clean up comments in integration tests.

Tests reference soon to be outdated paths and implementation details.

* Remove unused test/runner/ reference in test.
2019-08-05 14:55:30 -07:00
5e0bcc60b5 New Module: gcp_cloudtasks_queue (#60094) 2019-08-05 16:47:52 -04:00
31c7a61f9d Clean up old ansible-test references and code. (#60103)
* Remove obsolete ansible-test retry.py.
* Use ansible-test from bin/ intead of test/runner/.
2019-08-05 13:29:50 -07:00
d2cc9f5f06 Bugfix 60043: turn off the default db warning where it doesn't make sense (#60105) 2019-08-05 16:28:00 -04:00
aecdfd397e ecs_taskdefinition_facts: rename to ecs_taskdefinition_info (#60023)
* Rename ecs_taskdefinition_facts to ecs_taskdefinition_info.
2019-08-05 12:47:35 -07:00
0892d48ebc Do not install requests[security] for MongoDB tests (#60083)
Cleanup packages installed via pip for MongoDB tests

ci_complete
2019-08-05 15:01:58 -04:00
d3da8e4a5b Replace old shippable.py with new check_matrix.py. (#60022)
This new script does not depend on ansible-test and provides much more robust job matrix testing.

It is also run on every job in the matrix now, to detect issues with jobs being re-run after matrix changes are made.
2019-08-05 11:27:37 -07:00
41235ac05a Improve netapp_e_hostgroup and add unit tests. (#57094)
* Improve netapp_e_hostgroup and add unit and integration tests.

netapp_e_hostgroup was refactored for maintainability and improved
documentation clarity.

* Remove ignore sanity check E338 for netapp_e_hostgroup module

* Add __future__ import (absolute_import, division, print_function) to test_netapp_e_hostgroup unit test.
2019-08-05 13:19:23 -04:00
4df97c20b6 Handle quoted paths in ansible-test diff parsing. 2019-08-05 09:31:43 -07:00
13c8f7b00c It is necessary to undo mmi-mode enable after running commands. (#60071) 2019-08-05 11:52:25 -04:00
16e237e095 set mmi-mode enable to run commands nad unset after running. (#60075) 2019-08-05 11:52:11 -04:00
32a8d8ae2a Move definition of UnixHTTPSConnection behind guard (#60049)
This allows module_utils/urls.py to not immediately fall over when run
against a python without SSL support.
2019-08-05 10:46:47 -05:00
df6b8d2a4a Fix async output with adhoc callbacks. Fixes #15988 (#59935) 2019-08-05 10:36:41 -05:00
be24db8886 New module na_ontap_object_store (#59048)
* New module object store

* fixes

* fix tests
2019-08-05 09:27:38 -04:00
38848a4b0c hcloud: Add basic hcloud_route module (#59908) 2019-08-05 14:35:05 +02:00
e46237d705 Fix nxos_facts httpapi (#60055)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-05 18:01:29 +05:30
8a5bde798a hcloud: Add hcloud_server_network module (#60061) 2019-08-05 14:06:22 +02:00
0377c51c3a hcloud: Add hcloud_subnetwork module (#59781) 2019-08-05 11:13:28 +02:00
021b1810c9 Add nxos_vlans resource module (#59294)
* Add nxos_vlans resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comments

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix CI failure and udpate tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-05 12:50:16 +05:30
9610f2b8ac NX-OS Telemetry Resource Module (#59126)
* Combined telemetry module commit

* Minor fixes

* Add back whitespace

* Add telemetry subscription support and simplify

* Remove comment line

* Make ansibot happy

* Create common build_args method

* More ansibot fixes

* Refactored integration tests, remove old files

* Add subscription tests

* Add integration tests

* Update module docs

* Test updates

* Address review comments

* Comment should be one line, not two

* Address Trishna comments

* State deleted should purge all config

* Remove misleading comment

* Doc fixes

* Fix source int bug and remove local debug msg

* Add additional integration test checks
2019-08-05 11:35:46 +05:30
178db5f3ed Fix bug in purefa_facts where remote pgroup without a schedule is skipped (#60030) 2019-08-04 04:29:23 -04:00
ee0c19e519 corrected lib imports to work with python 2.x (#60017) 2019-08-02 22:11:03 -07:00
1268993506 added previously omitted parameter in gtm topology module (#60015) 2019-08-02 22:09:20 -07:00
95ef456bb7 fixes options parameter idempotency issue on v14.x (#60019) 2019-08-02 22:06:07 -07:00
d224a7ccf6 fixes idempotency issues with IPV6 addresses (#60021) 2019-08-02 22:03:33 -07:00
2e54ac37b0 refactors bigip_firewall_log_profile to use correct patterns (#60014)
doc correction in bigip_pool
changes functions in bigip_message_routing_route
2019-08-02 14:49:05 -07:00
c9a9621a02 fixes issue with recieve parameter idempotency (#59999)
fixes assert statements in unit tests
2019-08-02 13:29:40 -07:00
6e8798fa88 Correct module name in changelog fragment (#60029) 2019-08-02 22:22:28 +02:00
a9fe21bc62 docker_compose - use valid variable in exception message (#60020) 2019-08-02 15:57:22 -04:00
5b349a28d4 Fix bot meta. 2019-08-02 11:42:23 -07:00
41e198b429 Issue 59955: add example to postgresql_query module (#59979) 2019-08-02 14:30:17 -04:00
14aaa24522 update botmeta for CLI stub moves 2019-08-02 11:29:57 -07:00
8d1f658ce4 move CLI entrypoints under ansible package (#60004)
* needed so ansible-test can always find the right ones to copy to a target
* renamed the underlying scripts to be properly accessible as Python modules
2019-08-02 11:27:02 -07:00
97d36881e2 Try to clarify the wording (#59956)
* Try to clarify the wording

People were confused by this paragraph.  They read it as Ansible won't
auto-detect the python interpreter until 2.12.  Tried to reword it so
that they'll see that Ansible will auto-detect it currently if
/usr/bin/python is not present and in the future will always autodetect.

* Format the other instances of /usr/bin/python using :command:
2019-08-02 12:50:02 -04:00
1b246d89e3 Conflicting documentation (#59982)
##### SUMMARY
The "mode" parameter is already 'push' by default, so "required: true" isn't necessary.
2019-08-02 12:49:20 -04:00
38eee51057 Fix issue with empty cow_whitelist (#59946)
* Fix issue with empty cow_whitelist. Fixes #45631

* Account for None
2019-08-02 11:13:08 -05:00
f3e20346cb Google: gcpubsub_facts -> gcpubsub_info (#57668)
* Rename gcpubsub_facts -> gcpubsub_info.

* Update porting guide and add changelog fragment.
2019-08-02 17:27:28 +02:00
64e3cb0fa8 Unit tests: remove unused imports (#59812)
* Unit tests: remove unused imports

* Unit tests: remove unused imports, fix
2019-08-02 17:18:14 +02:00
fc558fb85f [docker_container] Adding support for mounts option (#49808)
* [WIP][docker_container] Adding support for `mounts` option

Fixes #42054

* Adjusting to current standards.

* Add changelog.

* Adjust types.

* Cleanup.

* Add idempotency checks for mounts.

* Improve diff for mounts.

* Linting.

* Python 2.6 compatibility.

* Fix error message formatting.

* Move mounts and volumes tests into own file.

* Add set of mount tests.

* Golang's omitempty for bool omits false values.

* Simplify sanity checks. Correct order of volume_options sanitization and usage.

* Fix key.

* Fix check.

* Add tests where both volumes and mounts show up.

* Add collision test.
2019-08-02 17:11:14 +02:00
a7573102bc docker_container: fix port bindings with IPv6 addresses (#59715)
* Pass IPv6 addresses for port bindings without square brackets.

* Add changelog.

* Add test.
2019-08-02 17:10:39 +02:00
f94772f807 Only error out if the gid exists with a different group name (#59769)
Only error out if the gid exists with a different group name as
otherwise it will error out if the group with this gid already
exists, like on a rerun of the playbook. This fixes a regression
introduced by 4898b0a4a2.
2019-08-02 15:51:10 +02:00
c0c17a3031 Remove obsolete tox.ini. (#59963)
Update botmeta
2019-08-02 09:34:21 -04:00
b847327645 Resource module for ios_interfaces and Facts Update (#59716)
* ios interfaces resource
2019-08-02 14:34:05 +05:30
18aae0a02b add new module with integration tests to manage gitlab project variables (#56574)
* add new module with integration tests to manage gitlab project variables

* fix invalid yaml in DOCUMENTATION variable and don't import * from ansible module

* remove extends_documentation_fragment and put imports after DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA

* fix author in documentation and remove import from display

* add alias file for integration test

* split long lines and try to fix the author key

remove tailing whitespace

* replace email address with github username

* adding the at style to username

* add metaclass and future import

* add state variable to be able to delete selected variables

* add test with state = absent

* update documentation. scheme is necessary

* use singular in exmaple section

* use key purge instead of purge_vars

use purge instead of purge_vars also in the integration test

* create gitlab object in the ansible main function

* remove usedless .format

* follow best practice fail message

* add return documentation, return information about which variables were added, updated or removed and catch gitlab api auth error

* use module_utils.api with api_url and api_token

* use dict instead of list for vars

* use project name instead of name as playbook key

* add ansible checkmode_support, reduce variables in gitlab_project_variables class, remove wrong/duplicated HAS_GITLAB_PACKAGE check

* use extends_documentation_fragment and don't pop elements from basic_auth_argument_spec

* use just project_variable as output variable

* update mutually_exclusive as suggested

* re-add api_token documentation, because it is not included in api basic auth

* remove useless statement

remove unnecessary if

* add one test with a changing value

* put type at first position

* keep item to reduce api calls, build array and keep indexes by replacing with None instead of poping

* more asserts

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* remove unused return key from documentation

msg is only returned when failed

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* remove error key, because it is not returned

* change also documentation from purged_vars to purge

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* remove extra spaces

fix wrong spelling

* expand return value documentation with examples

* add check_mode test

reorder tests. first the check_mode test, later all other tests

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* fix existing keys in 'present' array

rework key handling (reduce code)

fix integration tests

use untouched instead of present to identify unchanged variable keys

fix wrong replacement

minor fixes on request

set aliases to unsupported, because the test succeed

remove posix group1 because it conflicts with unsupported

remove useless item from aliases

* rework gitlab connection
2019-08-02 09:08:37 +02:00
6d074d8a94 Move ome_* and idrac_* modules one level up (#59698)
* Move ome_* and idrac_* modules one level up.

* Fix paths.

* Fix package name.

* Oranize in different directories.

* Update BOTMETA.

* Update new ignore entries.

* Revert "Update BOTMETA."
Revert "Oranize in different directories."
Adjust ignores.txt.
2019-08-02 09:06:18 +02:00
2be2ae366e Remove obsolete docs on pep8 sanity test. 2019-08-01 22:34:09 -07:00
372f21e3b5 Handle new output for podman image build (#59807) 2019-08-02 00:55:32 -04:00
e410dcbfed Add logic to handle multiple actions in an ALB listener rule, Fixes #41861 (#41975)
* added logic to handle multiple actions in an ALB listener rule (#41861)

* fix linting and pep8 issues

* added test for multiple actions using OIDC authentication

* added error messages related to old versions of botocore and multiple actions

* fix action validation error checks (need to check the exception string)

* added logic to make oidc configs idempotent (remove clientsecret for check)

* modified TargetGroupName to TargetGroupArn substitution to account for multiple rule actions

* refactored tests so that it can be run against different versions of botocore

* fix runme.sh to refelct changes to cloud testsuite

* add UseExistingClientSecret to oidc config (AWS api change)

* remove tests for OIDC auth action; add tests for redirect and fixed-response

* add in fixes from markuman and mjmayer

* remove documentation for cognito integration (not sure how to test); added example config for fixed-response and redirect actions

* renamed oidc/multiple action tests; leaving commented due to some AWS API changes

* pep8 fix

* more pep8 fixes

* Restructure elb_application_lb test suite

Move from runme.sh to virtualenv based roles

Update policies to fix tests

Don't log temp dir deletion, so many files in the diff!
2019-08-02 10:40:53 +10:00
309e342aaa Remove six decorator for unicode text conversion (#59895) 2019-08-02 09:15:31 +10:00
056aac1e30 Minor fixes in galaxy command for collection (#59846)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-02 07:48:34 +10:00
bb1256ca9a Disable mongodb_shard and mongodb_replicaset tests
They are causing failures when run as part of the  entire group shippable/posix/group1/
2019-08-01 14:40:31 -07:00
88e3449189 Fix ansible-galaxy import command to use argspec instead (#59898) 2019-08-02 07:31:28 +10:00
20b5ff5ab7 [s3_bucket] access the bucket encryption response gracefully (#59826)
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
2019-08-01 14:00:07 -07:00
6838a8209b Maintainer request for team_mysql (#59894)
Requesting maintainer status for mysql modules.
2019-08-01 15:42:46 -04:00
ea209e1c2f Wait for Ansible Tower instance to be ready 2019-08-01 11:32:45 -07:00
26fff6f5c3 Improved netapp module utility for E-Series. (#59527)
Add header option to request method in NetAppESeriesModule
Add multipart formdata builder function
Fix issue with url port change
2019-08-01 13:24:38 -04:00
a01ee2759d Update ce_vrrp to fix bugs (#59677)
* update ce_vrrp to fix bugs

* update ce_vrrp to fix bugs

* update ce_vrrp to fix bugs

* update ce_vrrp to fix bugs
2019-08-01 11:05:30 -04:00
17f2b5f73e os_subnet: allow using non-default subnet pool (#52608) 2019-08-01 10:11:53 -04:00
025e30ea0c VMware: add support for http_proxy in connection API
This commit allows users to access a vCenter or a ESXi through a
HTTP CONNECT based proxy.

To do so, the users have to set the `proxy_host` and `proxy_port`
variables.

The can also use the `VMWARE_PROXY_HOST` and `VMWARE_PROXY_PORT`
environment variables.

This feature depends on pyvmomi > v6.7.1.2018.12.

Fixes: #42221

Co-Author: Abhijeet Kasurde <akasurde@redhat.com>
Co-Author: Gonéri Le Bouder <goneri@redhat.com>
2019-08-01 15:57:26 +02:00
4eb156b2f5 regex match for lowercase Cisco (#59550) 2019-08-01 18:57:27 +05:30
eea46a0d1b Support Ericsson device management (#59277)
* Support Ericsson device management

* modify code

* modify error

* delete redundant file

* delete file

* modified error

* modify additional file name

* delete code

* add blank line

* delete redundant code

* add platform_eric_eccli.rst

* modify syntaxError

* modify document

* modify error

* modify maintaners

* modify document

* add end_string
2019-08-01 16:55:10 +05:30
07e7b69c04 VMware: minor changes in vmware_dvs_portgroup_find (#59911)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-01 15:14:17 +05:30
c35b512413 vmware: new module vmware_dvs_portgroup_find (#59567)
* vmware: new module to find portgroup(s) based on different criteria
2019-08-01 14:52:51 +05:30
3aa73cb6b8 VMware: Refactor vmware_cluster into several modules (#58468)
Refactor vmware_cluster into several modules (vmware_cluster, vmware_cluster_drs, vmware_cluster_ha and vmware_cluster_vsan) as discussed in #58023.

vmware_cluster lacks a lot of configuration options for DRS, HA and vSAN. Implementing them
all in vmware_cluster would make the module hard to maintain. Therefore, splitting it into several
modules and implementing the missing configuration options in them seems a good idea to me.

This is step one, refactoring vmware_cluster into several modules. Step two, implementing more
configuration options for DRS, HA and vSAN, will follow.
2019-08-01 10:35:29 +02:00
b2db38bbc6 resolves test error for PR59550 (#59901)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-01 13:34:14 +05:30
adfbd04b3a ce_netstream_template: update to fix a bug. (#59690)
* update to fix a bug.

* Update ce_netstream_template.py

* Update ce_netstream_template.py

* Update ce_netstream_template.py
2019-07-31 22:54:34 -04:00
349b2bdf43 Rebalance Windows CI groups based on recent delays to 2016 (#59838)
* Change to test out server 2016 CI issues

* ci_complete
2019-08-01 07:44:49 +10:00
093e2460b2 Windows testing - share code for creating a network device (#59847) 2019-08-01 07:43:31 +10:00
dacfd72bd6 Integeration tests for mongodb_shard and mongodb_replicaset modules (#53900) 2019-07-31 12:45:21 -07:00
eb15ee91df removed module from support list (#59878) 2019-07-31 14:58:24 -04:00
f1fd13c0ef Fixed "dictionary changed size during iteration" for zabbix_template when used with newest Python3 (#59181) 2019-07-31 14:30:29 -04:00
f46eb8ebcd Headers in URL lookup plugin (#59555)
* Update url.py

Allow passing of headers to URL lookup plugin
2019-07-31 14:23:55 -04:00
730fa78ca4 Add vyos_interfaces resource module (#58589)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-31 23:06:53 +05:30
288d74ca48 Update FlashBlade Directory Service config module to support NIS (#59608) 2019-07-31 13:33:24 -04:00
d6fd4eb8e6 update ce_bgp_af to fix bugs (#59678)
* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs

* update ce_vrrp to fix bugs

* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs
2019-07-31 13:28:46 -04:00
c4bb38d2b1 vcenter: disable ConfigParser interpolation (#59851)
Password can come with the '%' character. If we keep ConfigParser
interpolation enabled, it will try to modify the value.
Typical error looks like this one:

```
configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: '%Z,sq'
```
See: https://docs.python.org/3/library/configparser.html#interpolation-of-values
2019-07-31 09:53:11 -07:00
81d254da4c Update version in metadata for bundled distro (#59869) 2019-07-31 12:38:25 -04:00
75be309242 Don't warn if local user is found in user database (#56838)
If the 'local' parameter of the 'user' Ansible module is enabled, and
the user has been found in the local user database, don't emit
a warning, because this is an expected outcome.

Add changelog and integration tests

Co-authored-by: drybed <drybjed@gmail.com>
2019-07-31 12:14:22 -04:00
cb9ab42ab8 Document behavior of fetch when file already exists (#59816)
* Document behavior of fetch when file already exists
2019-07-31 12:09:58 -04:00
934d25a820 iam_password_policy: boto expects pw_expire to be ommitted when setting no expiration requirements (#59848)
Fixes #59102
2019-07-31 12:03:30 -04:00
3eeaf2f974 Add description of collection_paths in base.yml (#59778)
Fixes: #59775

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-31 11:57:44 -04:00
c1e5758c4c Add missing aws modules to aws module defaults group (#59788)
* Add missing aws modules to aws module defaults group

* add changelog
2019-07-31 11:53:14 -04:00
b09fbc3bf3 New module - meraki_webhook (#57855)
* Initial commit for meraki_webhook

* Split integration tests into two files to avoid delegate_to
2019-07-31 11:31:16 -04:00
d105c205ef meraki_snmp - Add support for network SNMP settings (#57708)
* meraki_snmp module supports network SNMP settings
- Network SNMP settings were added to the API
- Parameters are different so it's a new data structure
- Full suite of integration tests
- Commit includes some cleanup as well

* Add reset task for SNMPv3
2019-07-31 11:29:57 -04:00
516b39b79a meraki_organization - Add deletion support (#59415)
* Add support for deleting organizations
- Still working on integration tests

* Update documentation and verify check mode works
2019-07-31 11:29:42 -04:00
7afa5913a7 Conflicting documentation (#59777) 2019-07-31 11:17:59 -04:00
1534d6aea3 Update docs for pesize. (#59751) 2019-07-31 11:06:52 -04:00
9aa3130cd1 clarify what a namespace is or is not (#59809) 2019-07-31 10:58:16 -04:00
f2cb44633a Modules to manage ICX devices (#58969)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new commit

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved
2019-07-31 20:01:41 +05:30
58a53fe0eb Add junos_l3_interfaces (#59026) 2019-07-31 16:29:32 +02:00
47f9f43b0d VMware: Modify guest_id reference URL of vmware_guest (#59861) 2019-07-31 19:42:29 +05:30
80d8058f5c Change sub_plugin check to completely ignore napalm (#59298)
This also fixes cases where sub_plugin might not be loaded in executor
2019-07-31 08:46:17 -04:00
98df8e01db Fix py3 decoding issues in cyberarkpassword (#59500)
* Fix py3 decoding issues in cyberarkpassword.py
* Use to_native instead of forced utf-8 decoding
* Use to_bytes to avoid trouble with Popen
* Create 59500-cyberarkpassword-fix-py3-decoding.yaml
2019-07-31 13:46:47 +05:30
93931810c8 Run pytest with dedicated pytest.ini. (#59842)
Also disable the pytest cache plugin.
2019-07-31 00:28:39 -07:00
f944bd2358 Update ansible-test to properly skip unit tests.
Unit tests will no longer run on "remote only" Python versions (2.6) for tests which are not "remote" (modules and module_utils).
2019-07-31 00:27:07 -07:00
32fa4b15d1 More sanity test updates for collections. (#59841)
* Move action-plugin-docs ignores into ignore file.

* Update package-data sanity test.

The test now uses the file list provided by ansible-test.
2019-07-30 22:36:03 -07:00
dc427ff6d5 na_ontap_quota was not using vserver (#58594)
* fix issues

* fixes
2019-07-30 22:32:49 -04:00
ef6be41bf1 Disable pylint import-error for collections.
This matches the Ansible configuration.
2019-07-30 19:19:54 -07:00
2198ecb1d2 Improve checking for unusable sanity test ignores. (#59833)
* Check sanity ignore paths against test paths.

This prevents ignores from being added for paths which will never be tested by the test being ignored or skipped.

* Fix sanity ignore handling for no/all targets.

This allows checking of ignores for tests which do not use a target list.

It also allows checking of the full ignore list on every test run for tests that always use all targets.
2019-07-30 18:58:37 -07:00
f61b044bf0 Support directories in sanity tests. 2019-07-30 18:22:09 -07:00
57e4312a36 Add metaclass-boilerplate to elb_target lamda test function (#59832)
* Add metaclass-boilerplate to elb_target lamda test function

This change makes elb_target pass after #59831
2019-07-30 17:40:24 -07:00
c06751fb26 Handle situation where DOCS.options is None (#59783) 2019-07-30 19:08:43 -04:00
04ec47bdf1 win_dsc - be more lenient with datetime parsing (#59703)
* win_dsc - be more lenient with datetime parsing

* Remove l that shouldn't be there
2019-07-31 08:45:37 +10:00
196347ff32 ability to use lambda target in elb_target_group (#57394)
* enable elb_lambda_target test
2019-07-30 15:35:36 -07:00
e07c4f41d7 Standardize ansible-test sanity test filters. 2019-07-30 15:31:33 -07:00
652bfc7e19 win_template - use shared doc fragment for shared options (#59701)
* win_template - use shared doc fragment for shared options

* Change smart quote to em dash and fix whitespace issue
2019-07-31 08:05:24 +10:00
4c1f52c6c0 Add support for preferred arrays to host configuration (purefa_host) (#59735) 2019-07-30 17:31:40 -04:00
27c60a7cec Add ability to force immeadiate replication of a pgroup (#59785) 2019-07-30 17:31:23 -04:00
24d8e82655 Windows Setup doc; offer 10x perf improvement (#58259)
* Windows Setup; document 10x perf improvement
2019-07-30 15:53:17 -04:00
6208294054 Update the document according to the yuwzho-datadisk branch (#59491) 2019-07-30 15:38:00 -04:00
6a53147a15 Update homebrew.py (#59646)
##### SUMMARY

It should be known that this does not install homebrew. It only uses homebrew that is already installed. It's a core requirement.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-07-30 15:36:29 -04:00
691976c3d0 Fix podman_image integration tests (#59805)
Pin podman package at a specific version
2019-07-30 15:11:35 -04:00
1351962eee Move "code smell" sanity test config loading. 2019-07-30 12:07:33 -07:00
e1c2891188 Add paths_to_dirs function to ansible-test. 2019-07-30 10:46:39 -07:00
53af57b08b Fix type discrepancy in ansible-test. 2019-07-30 10:46:05 -07:00
9f41a4273e Remove redundant sanity test ignores. 2019-07-30 10:45:19 -07:00
2ebc4e1e7e inventory: Handle IndexError while parsing limit file (#59776)
Handle IndexError exception raised while parsing the limit file.

Fixes: #59695

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-30 13:02:17 -04:00
8a6c7a97cc Updating botmeta for netapp module_utils test (#59789) 2019-07-30 12:06:14 -04:00
2f403981b5 unarchive - add requirement of zipinfo command to docs (#59556) 2019-07-30 11:28:54 -04:00
1d560e5ce9 pbrun: Use default value for become_user (#59754)
* Update pbrun.py

Require ternary operator for if get_option('user') returns NoneType object.

* Update pbrun.py

Added default value to become_user in documentation.

* Update pbrun.py

Changed default for become_user to be '' instead of root.
2019-07-30 11:15:48 -04:00
05c586e3ef #54195 List supported platforms for RH customers (#59654)
* #54195 List supported platforms for RH customers
2019-07-30 09:09:42 -04:00
1ec155e773 vmware_guest: clone VM with attached CDROM
If a VM has an attached CDROM, `backing` attribute of the CDROM will
be defined.
As a result, we cannot just loop `vm_obj.config.hardware.device` and check
for the existance of the attribute to decide if the entry is a
harddrive.

Instead, we check the type of the device, and only keep the
`vim.vm.device.VirtualDisk` disk.

This issue is actually breaking our test-suite with regular environment
because we keep a Fedora ISO attached to the VM.
2019-07-30 14:09:07 +02:00
5bddd2f04a Add hcloud_network module (#59366)
* Add hcloud_network module

* Apply suggestions from code review

Co-Authored-By: Matt Clay <matt@mystile.com>

* Add notice about dependency

* Adjust tests

* Apply suggestions from code review

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Allow changing of ip range

* Add Setup step
2019-07-30 14:00:33 +02:00
0b27ec3ddc Revert "mysql.py: remove unused import" (#59768)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-30 17:24:06 +05:30
3c7e8f7905 ce_netstream_global: update to fix a bug. (#59689)
* update to fix a bug.

* Update ce_netstream_global.py
2019-07-30 06:19:29 -04:00
dbe618c084 podman_image: Disable unstable test
Disabling tests for podman_image until CI is green.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-30 11:43:03 +02:00
20c4ad3b95 Add pipelining to podman connection plugin (#57579)
* Add pipelining to podman connection plugin

* Add changelog fragment
2019-07-30 10:14:19 +02:00
fd899956b4 Use correct delegate_to hostnames in loops (#59659)
Fixes #59650
2019-07-30 09:46:29 +02:00
127bd67f6e Render elements in module doc and sanity test for sub-options (#59244)
* Render elements in module doc and sanity test for suboptions

*  Add support to render module elements value in ansible-doc output
   module html
*  Add validate-module sanity test of sunoptions.

* Add current validate module failures to ignore list

* Fix CI failure

* fix rebase conflict

* Fix CI issues

* Fix review comments

* Add validate-modules failure in ignore list
2019-07-30 12:07:21 +05:30
5d7cc993dd Clean up sanity test ignore handling. (#59749)
* Allow sanity tests to easily ignore themselves.

Useful for simple regex based sanity tests that error on their own script due to the regex or error message generated.

* Simplify no-smart-quotes sanity test.

Pruning of unversioned directories is handled by ansible-test.

* Remove directory pruning from boilerplate tests.

Files not passing these tests should be ignored instead.

* Add missing sanity ignore entries.
2019-07-29 14:37:44 -07:00
e9d7156f53 podman-docker docker compat for ansible-test (#59539)
* podman-docker docker compat for ansible-test

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove reprs, use ex.stderr instead

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove u''s ... not needed

Signed-off-by: Adam Miller <admiller@redhat.com>

* Update test/runner/lib/docker_util.py

Co-Authored-By: Matt Clay <matt@mystile.com>

* Update test/runner/lib/docker_util.py

Co-Authored-By: Matt Clay <matt@mystile.com>

* make sanity tests happy

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-07-29 17:34:45 -04:00
f7af4875d3 Misc typo fixes (#59620)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-29 17:05:26 -04:00
19299f3310 Order data in xml integration test (#59742)
A recent update to lxml for Python >= 3.6 now preserves key order. Change the test input so the input is sorted, making tests pass on previous versions of lxml as well as the latest version.
2019-07-29 16:18:46 -04:00
2bc0eecdb3 Update azure_rm_webappslot document (#59494)
* Update azure_rm_webappslot document
2019-07-29 16:15:06 -04:00
978fe81a6d Added unit tests for redhat_subscription module (#58665)
* Fixed the redhat_subscription module:
  - Option 'pool_ids' works in Python3 now
  - It tries to attach only pools IDs that are available
  - Optimization of code: do not call list --available, when
    no pool is requested
  - Simplified configure() method
  - Small changes to generate same commands on Python2 and Python3.
    Order of arguments/options and pool IDs have to be same to
    be able to run unit test using Python2 and Python3.
  - Added fragments file for redhat_subscribtion module
2019-07-29 16:11:29 -04:00
32de51adac Unit tests: remove unused imports (#59740) 2019-07-29 22:10:13 +02:00
8944be32bf lvg: simplify pesize description (#59699)
Remove confusing phrase about pesize as a "multiple of 128KiB".
Allowed values are anything accepted by vgcreate -s,
powers of 2, minimum 1K for lvm2.

As pesize less than 1M is accepted since Ansible 2.6,
close #29295
2019-07-29 16:09:05 -04:00
ed4a729fd6 Update constraints for coverage on Python 3.8 (#59733)
This fixes the unit tests hanging when run with Python 3.8 with coverage enabled
2019-07-29 16:05:29 -04:00
4a7e11ba9a Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59324) 2019-07-29 12:26:39 -07:00
66654475e1 Update ansible-test Python version handling.
Minimum version requirements for sanity tests have been standardized:

- All single version sanity tests now require Python 3.5 or later.
- All multiple version sanity tests continue to use all supported Python versions.
- All version neutral sanity tests continue to work on any supported Python version.

Previously some tests required 3.5 or later with most of the remaining tests requiring 2.7 or later.

When using the `--python` option to specify a Python version:

- Tests which do not support the specified Python version will be skipped with a warning.
- If the specified Python version is not available, any test attempting to use it will generate an error.

When not using the `--python` option to specify a Python version:

- Multiple version tests will attempt to run on all supported versions.
- Single version tests will use the current version if supported and available, or if no supported version is available.
- Single version tests will use the lowest available and supported version if the current version is not supported.
- Any versions which are not available or supported will be skipped with a warning.

Unit tests automatically skip unavailable Python versions unless `--python` was used to specify a version.
2019-07-29 11:54:03 -07:00
ecddbdf0cb Isolate globals in import sanity test. 2019-07-29 11:13:03 -07:00
0b8354751b Added new module avi_user.py (#57116)
* Added new module avi_user.py and tests for that

* Updated documentation as per module argspec

* Updated as per review comments on IP address

* Updated documentation for types

* Fixed sanity check failure for __future__ import

* Updated documentation as per review comments.
2019-07-29 11:49:04 -04:00
93ea961205 vmware_guest: enable 3 extra tests
- network_with_dvpg
- network_with_portgroup.yml
- template_d1_c1_f0.yml
2019-07-29 15:28:52 +02:00
9182d54e98 ce_config: Optimize multi-level views & fix a bug. (#59523)
* Optimize multi-level views

* update to rewrite load_config.

* update.

* update.

* update.

* update.
2019-07-29 08:54:51 -04:00
4d775cbbf1 ec2_eip - added support for BYOIP and filtering reuse addresses by tag/value (#59180)
* change variable name from isinstance to is_instance (prevent overriding builtin function)

* Added support for:
  - Filtering existing Elastic IPs based on a tag name or it's value (when reuse_existing_ip_allowed is true)
  - Allocating new Elastic IPs from a given IPv4 pool (BYOIP support)

* yamllint corrections

* added examples for:
  -  tag_name,
  -  tag_value
  -  public_ipv4_pool

* remove aliases

* Added changelog fragment

* added integration tests for ec2_eip module

* removed space to trigger rebuild
2019-07-29 19:40:19 +10:00
373e887e7f a bug fix for elastic pool name (#56820) 2019-07-29 17:13:56 +08:00
336be58665 VMware: Fix Service Content calls in vmware_deploy_ovf
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-29 11:00:02 +02:00
08d7905be2 Remove incorrect usage of UnsafeProxy (#59633)
This removes couple of uses of UnsafeProxy that relies on the
implementation that is no longer present in the codebase.
2019-07-29 09:48:09 +02:00
6aaf0ea382 fix test typo nxos_lag_interfaces (#59710)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-29 12:40:23 +05:30
c562b53cb2 Fix nxos_facts integration tests (#59643)
This was incorrectly asserting the result of previous nxos_facts task.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-07-29 12:05:35 +05:30
86937e06e3 ce_file_copy: update to Compatible with multiple version of NETCONF API. (#59450)
* update to Compatible with multiple version of NETCONF API.

* update for  shippable.

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py
2019-07-29 02:02:32 -04:00
a589cac18a Windows: new win_netbios module (#58331)
* Initial commit win_netbios module

* Ansibot sanity improvements.

* Corrected file permissions.

* Windows: module description update

* Adding integration tests

* Added missing alias file

* Improvements made to tests and WMI efficiency.

* Correction from sanity check failures

* Shippable corrections

* Moved reboot flag.

* Slight tweak to return value conditoin
2019-07-29 07:56:53 +10:00
fe3459ef86 add module_utils example (#59661)
* add module_utils example to collections docs
2019-07-28 15:40:17 -05:00
c24b841c0a fixed _merge_dictionaries calls in GcpSession class (#59375) 2019-07-28 08:00:24 +05:30
0e9f002073 Fix build-ansible.py release-announcement
* When the release scripts were changed, this file to implement release
  announcements was left out

* Add announce.py to the compile skip lists as only the release engineers
  run this during package build.
2019-07-26 16:39:56 -07:00
f274cefa59 Consolidate sanity test ignore entries. (#59665)
* Update empty-init test.
* Update future-import-boilerplate test.
* Update line-endings test.
* Update metaclass-boilerplate test.
* Update no-assert test.
* Update no-basestring test.
* Update no-dict-iteritems test.
* Update no-dict-iterkeys test.
* Update no-dict-itervalues test.
* Update no-get-exception test.
* Update no-main-display test.
* Update no-smart-quotes test.
* Update no-unicode-literals test.
* Update no-unwanted-files test.
* Update replace-urlopen test.
* Update required-and-default-attributes test.
* Update shebang test.
* Update test-constraints test.
* Update use-argspec-type-path test.
* Update use-compat-six test.
2019-07-26 15:26:39 -07:00
7c6fb57b7d Implements extra_hosts for docker_image module (#59540)
* Implements etc_hosts for docker_image module

Allows custom hosts on docker_image module.

The of this option made impossible to use docker_image module to build
images that required a custom hostname in /etc/hosts. For running
containers this option was already present.

While the python-docker API uses extra_hosts term, our existing module
already uses etc_hosts argument, so it sounds better to have some
consistency between docker_container and docker_image.

Fixes: #59233

* Update test/integration/targets/docker_image/files/EtcHostsDockerfile

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_image.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/docker_image_etc_hosts.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-26 16:39:21 -04:00
30c1d9754d Style end edit changes to collections doc (#59658)
* copy-edit of file
2019-07-26 14:18:49 -05:00
5b1a4f959a postgresql_set: improve CI tests (#59583) 2019-07-26 19:53:34 +02:00
3b5a96fcb7 Fixing race condition in ec2 inventory plugin (#59638)
* Fixing race condition in ec2 inventory plugin

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

* Fixing code block according to suggestion

* Adding changelog fragment
2019-07-26 13:27:48 -04:00
007fe842b9 aws_ec2 inv plugin - fix author field (#59649)
* Fix author field

* Add BOTMETA entry to get notifications
2019-07-26 12:23:56 -04:00
c3d1f9b085 ce_stp: update to fix a bug. (#59347)
* update to fix a bug.

* update for shippable.

* Update ce_stp.py
2019-07-26 12:09:53 -04:00
b4494fa547 Remove redundant "Sanity Tests »" from page title.
The docs now have multi-level breadcrumbs so including "Sanity Tests »" in the title on a sanity test page is redundant.
2019-07-26 09:07:42 -07:00
2f6de3aea4 Add missing decorator to ansible-test sanity.
This fixes sanity test errors so they show the proper error code instead of "bound method".
2019-07-26 09:04:37 -07:00
3cdc667888 New module - meraki_mx_l7_firewall (#55485)
* Initial commit for meraki_mx_l7_firewall module

* Add argument checking

* Sanity fixes

* Fix crash and improve integration tests

* Improved integration tests and coverage

* Reformat response data
- Module does not match argument structure of API
- PR reformats the response to match Ansible arg spec
- Improved integration tests

* Fix reformatting for diffs

* Create rename_* functions
- is_update_required() ignores the key id
- Meraki expects one of the keys to be id
- Function temporarily renames key to appId to get around this

* Tweak documentation and tests
- Tests now do an include so each task doesn't need delegate_to

* Fix which files I'm editing
2019-07-26 11:43:28 -04:00
f8f3986871 New module - meraki_nat (#52889)
* Initial commit for meraki_nat module
- Query fully works
- Present is still very much in development

* Add initial code for present functionality, not complete

* Add request documentation

* Add examples and return documentation.

* Added payload to requests
- Module seems to need new idempotency check

* Allow 1:1 and 1:many NAT to work
- New idempotency check method is probably required to work

* Make all three options work
- Module isn't idempotent

* Diff support
- Added integration tests
- Diff support isn't quite done

* Fix diff output

* Enable idempotency assertion in tests

* Add test assertions for code coverage

* Update documentation and tests
- Split tests to separate file to avoid delegate_to

* Fix blank line
2019-07-26 11:42:36 -04:00
5ed469f6b7 Fix sanity docs page titles.
The titles are used to generate the index of sanity tests, so they should match the name of the test.
2019-07-26 08:39:34 -07:00
db783eb2b9 New module - meraki_firewalled_services (#57289)
* Initial commit for module
- Module can query or modify network services on Meraki gear
- Check mode supported
- Integration tests included

* Small change to examples

* Move mutual exclusive to build in approach

* Sanity err

* Split integration tests into two files to avoid delegate_to

* Add the integration tests, woops
2019-07-26 11:39:20 -04:00
4e8df9a4b8 unit tests: remove unused imports (#59636) 2019-07-26 10:53:31 -04:00
65013c4001 consul_session: ensure certificate is checked when HTTPS is used (#58693)
* consul_session: ensure SSL certificate is checked

* consul_session: don't ignore validate_certs param
2019-07-26 15:05:38 +02:00
8a821d57bd vmware_cluster_facts: fix the functional test
Fix the variable names.
2019-07-26 14:10:44 +02:00
964783fbd2 vmware_guest: speed up vmware_guest tests
- Use predictable VM name during the tests (test_vm1, test_vm2 and
  test_vm2). This to simplify the teardown of the newly created resource
  before the next test.
- Update the documentation to explain the new requirement
- Avoid VM creation with `with_items` when it's not mandatory. This to:
    - speed up the test execution, our hypervisors have limited resources
    - simplify the teardown
- Remove `create_d1_c1_f0_env.yml`, the test was just testing how Ansible
  pass environment variables.
- Correct the name for the `f0` variable (`f1`)
- Fix the DVS tests, the hosts can now reach the dvswitch1 vswitch
- Provision the VM with a poweroff status, this to improve the
  idempotency and sleep up the tests
- Avoid the use of `prepare_vmware_tests` to prepare virtual machines
  when we just need one machine
2019-07-26 14:07:01 +02:00
08b9e18d4f Call remove-brick only if no. of bricks > 0 (#56781) (#58635) 2019-07-26 07:15:11 -04:00
06c7b87613 vmware_inventory: do not ignore validate_certs
Python 2.7.9 < does not have the `ssl.SSLContext` attribute. If
`validate_certs` is `True`, we cannot validate the SSL connection,
and we need to raise an error.
2019-07-26 10:35:12 +02:00
d82446652f Update FlashBlade filesystem module to support quotas and NFS v4.1 (#59559) 2019-07-26 04:06:08 -04:00
37dd0832a4 Fix TypeError in gluster_volume. (#59623) 2019-07-26 13:32:12 +05:30
3da4c0dd3a Update argspec to normalize across platforms (#59596)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-26 12:30:26 +05:30
cf9999692a Fix ansible-test encoding issues.
This fixes `ansible-test sanity --list-tests` which was failing when `LC_ALL=C` was set.
2019-07-25 23:29:42 -07:00
db7e9aa051 Use consolidated ignore.txt in ansible-test. (#59618) 2019-07-25 23:29:23 -07:00
c1ee1f142d gcp_utils: Handle JSON decode exception (#59427)
Handle json.loads exception rather than providing stacktrace

Fixes: #56269

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-26 11:31:07 +05:30
49da47d09f force_basic_auth for default httpapi connection auth (#59193)
The default for a httpapi connection is to do basic auth, however
when setting the url_username and url_password without
force_basic_auth, the call to ansible.module_utils.open_url would
not always properly handle the basic auth headers based on the
combinations of **kwargs passed. This ensures that is always the
case when no session token exists and as the goal is to use basic
auth in the event of not having a session token, this should be
a safe operation.

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-07-25 16:40:09 -05:00
3a103405b1 Handle lowercase in version info (#59565)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-25 23:06:53 +05:30
9e0a3fcc2a Use EOL comment for ansible-test PEP8 skip file. 2019-07-25 10:13:42 -07:00
3ceeae0de9 Make docker swarm integration tests more reliable (#59473) 2019-07-25 12:49:30 -04:00
723da33176 Remove me from VyOS modules (#59535) 2019-07-25 12:47:03 -04:00
b232a9337e Switch sanity ignores to EOL comments.
This will make automated conversion to consolidated ignores easier.
2019-07-25 09:19:14 -07:00
3c8838f0f7 Add check mode indicators at the beginning and the end of the playbook, play, and task (#49432)
* Add integration tests for default callback check mode markers
2019-07-25 12:05:43 -04:00
a5d409a8b2 point at corresponding version (#59200) 2019-07-25 11:54:01 -04:00
488ee40879 updating botmeta for netapp (#59526) 2019-07-25 08:49:59 -07:00
9551528ba0 Replace Mazer references with ansible-galaxy (#59487)
* Replace Mazer references with ansible-galaxy
2019-07-25 11:45:00 -04:00
9b9066d10f Updated references to removed modules in documentation (#59580) 2019-07-25 11:41:07 -04:00
db26fe2f1e module_utils.common.*: removed unused objects (#59570) 2019-07-25 11:04:18 -04:00
cfe01390aa clarify ansible-galaxy collection cli command options (#59470)
* clarify ansible-galaxy collection cli command options
2019-07-25 09:41:37 -05:00
60c76be03c rds_instance: add point-in-time instance restore test (#59411) 2019-07-25 09:49:08 -04:00
ef59dd2ca2 vmware_guest_network: fix the network look up
Before this fix, the module was not able to look up a `VM Network` located at
`/DC0/network/VM Network`. As a consequence, the test module was failing
with a real environment (Non-govcsim).
2019-07-25 14:02:52 +02:00
585128e5ac ce_mlag_config: update to fix a bug. (#59336)
* update to fix a bug.

* update

* Update ce_mlag_config.py

* Update ce_mlag_config.py
2019-07-25 07:12:15 -04:00
e9a37f8e31 prevent templating of passwords from prompt (#59246)
* prevent templating of passwords from prompt

  fixes CVE-2019-10206
2019-07-24 16:00:20 -04:00
4ef38fcee2 remove useless overhead (#59517)
in the examples for the apt module, pass the list directly to the `pkg` option instead of providing it in `vars`
2019-07-24 14:24:53 -05:00
95f4282c42 Verify package data in setup.py installs all files (#59537)
* Add sanity test to ensure all non-py files are installed

* Fix mode and regex

* Fix role skel inventory package_data

* Add docs

* Update package_data for inventory files

* Address pylint concerns

* Another tweak to package_data

* Address review feedback

* Change index to 1

* add to ansible-only.txt
2019-07-24 13:58:13 -05:00
119f2b873a junos_ping supports only network_cli (#59534)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 23:11:27 +05:30
f2b0bfd4aa Add iosxr_lacp resource module (#59281)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 22:55:42 +05:30
97edfccc70 Fix nightly rpm release
The nightly rpm builds were using a timestamp from the last git commit
in their Release field.  Unfortunately, that was using author timestamp
which is nonsequential.  Change to using commit timestamp which is
sequential.

note that this still has a cornercase if the branch's history is ever
rewritten.
2019-07-24 09:13:53 -07:00
8d1b82a26e Typo in the Warning block eneabled -> enabled (#59524)
* Typo in the Warning block eneabled -> enabled
2019-07-24 11:59:13 -04:00
0a081e14d5 Fix inconsistency nxos->ios role (#59521)
Chapter "Ansible supported network roles"
2019-07-24 11:57:34 -04:00
1d82d25ea2 Adding Avi ansible lookup module (#58667)
* Adding Avi ansible lookup module

(cherry picked from commit 77b8951f68cbc889e6595b2a359ca27b84a43c0d)

* Added description for examples

* Added debug logs and unit tests

* Fix __builtin__ import and restting super

* Fix pep8 errors

* Updated as per review comments on IP address
2019-07-24 11:35:04 -04:00
f988c23f82 Added unit tests for avi API utils (#58382)
* Added unit tests for ansibble_utils.py

* Removed unnecessary print statement

* Updated Ip address as review comment

* Updated as per review comments on IP address and test asserts
2019-07-24 11:05:28 -04:00
fb96f0b8ae vmware_content_library_info: init the functional test
`vmware_content_library_info` functional test is currently broken because it
assumes the vCenter content library is not empty.
With this commit, the test inits the vCenter content library database using
`prepapre_vmware_tests`, this before the functional test execution.
2019-07-24 16:47:25 +02:00
47496098e7 vmware_dvs_portgroup_facts: test depends on a dvswitch
Creates the missing dvswitch that is used by the test.
2019-07-24 16:46:48 +02:00
e9725862ca mysql.py: remove unused import (#59511) 2019-07-24 10:36:18 -04:00
5fc769f6b1 sysctl - Reload also when current system values differ (#56153)
Previously if `sysctl_set=no` (which is the default) this module only
checked for changes in the sysctl.conf file to decide whether it should
reload it or not. This means that if the values in the conf file are the
same as they are set with the module, but the current values on the
system are different, that this module wouldn't apply the changes on the
system and thus the value set with the module wouldn't be applied on the
OS. This isn't obvious and it doesn't make sense that the module works
like that by default, especially because there is a separate option
`reload`. Now sysctl will also check if the current value differs on the
system and if it does, it will reload the file again.
2019-07-24 10:04:15 -04:00
401e70c0a2 VMware: add facts about tags in vmware_cluster_facts (#56848)
Fixes: #46458

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 15:45:15 +05:30
fd35833554 postgresql modules: fix by flake8 (#59497) 2019-07-24 15:40:44 +05:30
93265bf92e ce_mtu: update to fix bugs. (#59343)
* update to fix bug.

* Update ce_mtu.py

* Update ce_mtu.py

* Update ce_mtu.py
2019-07-24 05:53:08 -04:00
281307b492 VMware: make properties configurable (#53050)
This allows user to control set of properties which can be included
in the hostvars.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 15:18:32 +05:30
1010363c0b Preserve original variables when using a loop (#59426)
Fixes #59414
2019-07-24 11:35:14 +02:00
5a7f579d86 Fix clouds_yaml_path type in openstack inventory
Fixes: 59442
2019-07-24 10:25:44 +02:00
6ff54c546e update to fix a bug (#59346) 2019-07-24 04:09:53 -04:00
ba90263c22 Fix ansible-test cloud testing for collections. 2019-07-24 00:17:11 -07:00
3c68a2e5f0 Ignore deleted when querying git in ansible-test. 2019-07-23 23:36:08 -07:00
bafd06bc89 VMware: Fix custom value in vmware_guest (#58157)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 10:54:16 +05:30
51083537fa Fix incorrect collections coverage warning. 2019-07-23 22:06:17 -07:00
ba7097cba3 Collection test (#59488)
* Add missing __init__.py for collection unit tests

* Added more tests for collection install and remove default path
2019-07-24 12:38:32 +10:00
d9b9e07d0b VMware: Add datatypes in documentation (#59221)
* Remove E337 warnings
* Update docs
* Fix minor typos

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 07:55:55 +05:30
7c728118e6 Fix import sanity test for collections. (#59484) 2019-07-23 18:10:24 -07:00
d65d8d6e13 Fix default pylint config for collections. 2019-07-23 17:14:10 -07:00
3581e63ca8 psexec - update example for for delegation example (#59475) 2019-07-24 10:12:34 +10:00
8a880d6032 Fix the pytest match test for python-2.6 2019-07-23 14:07:37 -07:00
65bedaf074 Ensure package_data matches collections_galaxy_meta.yml. Fixes #59451 (#59452) 2019-07-23 15:52:38 -05:00
44a262714c Add common sanity ignore & skip to ansible-test. (#59416)
* Add common sanity ignore & skip to ansible-test.
* Switch ansible-doc sanity test to single version.
* Remove duplicate ignore entry.
2019-07-23 13:31:54 -07:00
aebc3b0730 Update cobbler_system.py (#59316)
State was not referenced appropriately in doc examples.
2019-07-23 15:13:07 -05:00
6a77533b57 Specify type-str for common NetApp E-Series documention options. (#59459) 2019-07-23 14:38:11 -05:00
092e5515d1 win_firewall_rule - update doc for localport dep. on protocol (#59467) 2019-07-23 14:37:08 -05:00
7b4ce9e4ae Update find.py (#59456)
Return values for `matched` and `examined` in the find module are integers and not strings.
2019-07-23 13:51:56 -05:00
cb1dd6d77b remove molecule mentions (#59441) 2019-07-23 13:12:13 -05:00
67fb3a8215 Fix root filter test
On python-2.6 the error message is different
2019-07-23 09:50:47 -07:00
266d6e77a9 Re-enable docker_container tests (#59425)
Mark dependent container's ipc_mode as shareable
2019-07-23 10:20:18 -04:00
333953117c Add human_to_bytes isbits arg unit tests&docstring
PR #58623

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-07-23 14:56:56 +02:00
133cb945ae update to fix bugs. (#59345) 2019-07-23 06:30:45 -04:00
1998c9c19d add example (#59287) 2019-07-23 06:05:17 -04:00
8ee587aa7d ovirt add template cluster (#59378)
* ovirt add template cluster

* update doc

* add global search fallback

* update docs
2019-07-23 06:04:42 -04:00
f1dbf6292b update to "state is present but all of the following are missing: password" bug (#59344) 2019-07-23 05:56:01 -04:00
b728347260 ce_bfd_session: update & add 2 params. (#59333)
* update & add 2 paramers.

* update for shippable

* update for shippable
2019-07-23 03:38:27 -04:00
1092ee55d4 Add [junos_lag_interfaces] resource module (#59011)
* Add junos_lag_interfaces resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/29
*  Deprecate junos_linkagg module

* Fix CI issues

* Fix junos integration test cases

* Fail if base lag interface is not configured
2019-07-23 11:53:15 +05:30
3bad4d6a50 Add nxos_lag_interfaces resource module (#59031)
* Add nxos_lag_interfaces resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* ix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* module_utils nxos transport-provider fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos_lag_interfaces tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-23 11:11:37 +05:30
04445f184b Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59322) 2019-07-22 22:07:48 -07:00
c6c262a07e Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59131)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 10:01:47 +05:30
b81239ce50 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59323)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 10:00:22 +05:30
5d412d89b1 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59325)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 09:58:21 +05:30
79eca9c8fb Initial ansible-test support for collections. (#59197)
* Initial ansible-test support for collections.
* Include cloud config in delegation payload.
* Add missing types import and fix `t` shadowing.
* Fix plugin traceback when config_path not set.
* Fix encoding issues.
* Remove unused imports.
* More encoding fixes.
* Handle delegation outside exception handler.
* Inject ssh keys only if not already in place.
* More defensive approach to getting remote pwd.
* Add missing string format var.
* Correct PowerShell require regex.
* Rename `is_install` and `INSTALL_ROOT`.
2019-07-22 19:24:48 -07:00
67c69f3540 Mark Docker tests unstable (#59408)
* Mark Docker tests unstable

- docker_swarm is unstable on RHEL 8
- docker_container is unstable on RHEL 7

* Disable docker_container test.
2019-07-22 16:40:45 -07:00
c7f414dece ovirt vm when creating Nonetypefix (#59377)
* ovirt vm when creating Nonetypefix

* update fix and add comment

* add changelog

* Update 59377-ovirt-vm-when-creating-fix.yml
2019-07-22 16:18:08 -07:00
8a886a6bee Fix gather facts ignoring gather_subsets config (#59271)
* Fix gather facts ignoring gather_subsets config

 fixes #58728

* Update lib/ansible/playbook/play.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 17:59:22 -04:00
aa0de421d2 Ignore collection build release files in the root collection directory (#59121) 2019-07-23 07:52:30 +10:00
199c97728f Update disk description in vmware_guest.py (#59399)
Corrects grammar in the disk description section of the vmware_guest module documentation.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-07-22 16:14:45 -05:00
b2e58856bf Update hpilo_boot.py (#59136)
Change `hpilo` requirement to `python-hpilo` to avoid being confused in installation with pip.
2019-07-22 16:09:56 -05:00
a2b49854ca Update copy.py (#56370)
* Update copy.py to make the behavior of the `content` option clearer.
2019-07-22 15:57:33 -05:00
65049620ee Generate galaxy.yml based on single source of truth (#59170)
* Generate galaxy.yml based on single source of truth

* Fix up tests and align file names

* Minor Makefile tweak

* Remove link in galaxy.yml file and make it a template file

* Moved collections docs to dev_guide

* change Makefile clean path

* Added readme to example meta file

* review fixes

* Use newer style for doc generation script

* Fix mistake in dev_guide index

* removed uneeded file, fixed links and added preview banner

* Moved banner for sanity test
2019-07-23 06:50:46 +10:00
28b9f71640 remove ambiguity: use "my_test" as module name (#59335)
Naming a module "something_module" is misleading (see below). Let's drop the "_module" part of the module name on the developing_modules_general page.
2019-07-22 14:58:12 -05:00
9ff26a4a22 psrp - Added proper reconnection variable name (#59369) 2019-07-23 05:55:52 +10:00
a20afb5822 Add support for test script parameters in win_pester (#58790)
* add parameter list argument

* add tests

* fix test and add doc

* correct test file

* fix typo

* fix tests

* fix typo in file name

* correct file name reverting the previous commit

* correct property name

* add checkmode message

* changes as per review comments

* variable casing and other review comment changes

* define $test_parameters_check_mode_msg variable
2019-07-23 05:46:26 +10:00
284dafe476 Perfy McPerferton (#58400)
* InventoryManager start of perf improvements

* 0 not 1

* More startswith to [0] improvements

* Remove unused var

* The hash doesn't need to be a string, start as a list, make it into a tuple

* set actually appears faster than frozenset, and these don't need to be frozen

* Cache hosts lists, to avoid extra get_hosts calls, pass to get_vars too

* negligible perf improvement, it could help with memory later

* Try the fast way, fallback to the safe way

* Revert to previous logic, linting fix

* Extend pre-caching to free

* Address test failures

* Hosts are strings

* Fix unit test

* host is a string

* update test assumption

* drop SharedPluginLoaderObj, pre-create a set, instead of 2 comparisons in the list comprehension

* Dedupe code

* Change to _hosts and _hosts_all in get_vars

* Add backwards compat for strategies that don't do set host caches

* Add deprecation message to SharedPluginLoaderObj

* Remove unused SharedPluginLoaderObj import

* Update docs/comments

* Remove debugging

* Indicate what patterh_hash is

* That won't work

* Re-fix tests

* Update _set_hosts_cache to accept the play directly, use without refresh in get_hosts_remaining and get_failed_hosts for backwards compat

* Rename variable to avoid confusion

* On add_host only manipulate _hosts_cache_all

* Add warning docs around _hosts and _hosts_all args
2019-07-22 14:25:20 -05:00
6adf0c581e New feature to na_ontap_snapmirror (#59047)
* updates

* updating version added for connection type
2019-07-22 13:46:00 -04:00
74ac229fa8 fix all cases of none remote/become users (#59397)
some cases failed, when defaults were None on the plugins
2019-07-22 12:24:31 -05:00
52ad0f3217 Update ansible-test sanity requirements.
Skip installation of packages on Python 2.x which are only used on 3.x.
2019-07-22 10:14:33 -07:00
7ee5835821 VMware: vmware_dvs_host: Add vendor_specific_config (#57637)
* Add vendor_specific_config
* Fix documentation typo
* Add example using vendor_specific_config
2019-07-22 22:06:30 +05:30
b1360c0d94 bug fixes (#59049) 2019-07-22 11:05:56 -04:00
6f9f67be18 virt_net: add way to get facts for only one specified network 2019-07-22 16:34:07 +02:00
46b821d51f state wasn't a valid value (#59274)
State isn't a valid value for the gcp_compute_address module, remove it from docs example
2019-07-22 09:25:26 -05:00
6531819172 snow: Fix token reference in basic authentication (#59315)
* Fix OAUTHClient logic
* Add Env variable support for snow modules

Fixes: #59299

Signed-off-by: Paul Knight <paul.knight@state.de.us>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 19:31:04 +05:30
59e647910d Add unit tests for bytes_to_human formatter
PR #58664

Co-Authored-By: Sam Doran <sdoran@redhat.com>
2019-07-22 15:45:07 +02:00
d6b1376006 Add changelog for #59280 (#59380) 2019-07-22 13:42:10 +02:00
66d12f6f1e Only convert VirtualDiskFix for #57653 clone_with_convert is failing 2019-07-22 12:52:48 +02:00
e9b1e36d76 vcenter provider: avoid a TypeError exception
Avoid `TypeError: option values must be strings` with `ConfigParser`.
Default values must be string, not `None`.

The error happens when `test/integration/cloud-config-vcenter.ini` does
not have the `vmware_proxy_host` or `vmware_proxy_port` keys defined.
2019-07-22 11:19:39 +02:00
b7868529ee Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)
This reverts commit 6069d09b9d.

Fixes #57351
2019-07-22 10:27:11 +02:00
791e565802 VMware: Additional testcase for mem_reservation (#59365)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 10:44:19 +05:30
8d0f2e5725 Address regression causing bootproto=dhcp for manual IP addresses (#56376)
Commit b7724fdf85
appears to have caused a regression, where `ip4`, `gw4`, `ip6`, `gw6`
were converted to `ipv4.address`, `ipv4.gateway` etc.

This causes bootproto (or `ipv4.method`) to remain `dhcp`, as noted in https://github.com/ansible/ansible/issues/36615

This commit only reverts the key-value pairs to the original names,
which is in line with both expectation (manual ip addr == no dhcp) and
the language used in the playbook, which is, for example, "ip4" not
"ipv4.address"

Co-authored-by: Stuart Pollock <spollock@pivotal.io>
Co-authored-by: Tyler Ramer <tramer@pivotal.io>
2019-07-22 09:30:24 +05:30
252d1b7e95 VMware Tools Connector does not support pipelining (#57237) 2019-07-22 09:27:00 +05:30
1f49abb51c VMware: Accept 0 as valid value for memory reservation (#59230)
vmware_guest accepts 0MB as valid value for memory reservation in
virtual machine hardware configuration. This fixes the regression
introduced via 193f69064f.

Fixes: #59190

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 09:03:25 +05:30
c8697a4864 ce_switchport: add link-type hybrid and dot1qtunnel to mode. and fix bugs. (#59332)
* add link-type hybrid and dot1qtunnel to mode.and fix bugs.

* add verstion_add option for doc.

* update for shippable:E319.

* Update ce_switchport.py
2019-07-21 23:07:09 -04:00
db95ff4823 update documentation for dictionaries (#59354)
it has been fixed if using 0.9.0 or newer

ref https://github.com/ansible/ansible/pull/49053#issuecomment-511073083
2019-07-22 09:43:43 +10:00
2f2b106423 Fix win_reg_stat for HKU hives (#59359) 2019-07-22 09:12:14 +10:00
74598b212e win_hosts to use Ansible.Basic CSharp Util and better diff support (#58600)
* switch win_hosts to use csharp util

* update win_hosts doc to match doc guide

* changed linking format for option values
2019-07-22 09:08:36 +10:00
015119df8c Windows - Add common util for web requests (#54759)
* Windows - Add common util for web requests

* Use different method of retrieving options from module arg spec

* Added proper version_added for module options

* Fix linting errors

* Fix proxy issues and updated cred docs

* Fix FTP usage with proxy settings

* Removed uneeded function added in bad rebase

* Fix up client certificate auth

* fix new sanity checks

* Edit http agent code and update porting guide
2019-07-22 08:42:24 +10:00
1f3a3fdd3e win_firewall_rule - removed deprecated force option (#59358) 2019-07-22 08:24:57 +10:00
883cc665e3 parameter ensure replaced by state (#59342)
corrected a typo at the absent-example.
2019-07-21 04:26:07 -04:00
b378e885ed Make ansible-test TestMessage hashable. 2019-07-19 21:34:04 -07:00
2d5a0d4918 Remove botmeta entry for pep8 legacy-files.txt. 2019-07-19 16:39:19 -07:00
4f1d0f1b39 Skip using paths for ansible-doc sanity test. 2019-07-19 16:17:56 -07:00
f8c278e210 add dns info to gather facts (#59145)
* add dns info

* fix doc fragment

* Revert "fix doc fragment"

This reverts commit 8f08ac192e.
2019-07-19 18:30:30 -04:00
e7fba5cea0 New Module: gcp_mlengine_version (#59224) 2019-07-19 16:52:40 -04:00
5b0214bcce New Module: gcp_appengine_firewall_rule (#58852) 2019-07-19 16:42:37 -04:00
40ff1949fb New Module: gcp_mlengine_model (#59222) 2019-07-19 16:41:07 -04:00
8edad83ae0 User - make groups and append mutually exclusive with local (#59309)
* Update intigration tests
2019-07-19 16:05:15 -04:00
5c6aa9b9e8 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59171)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:33:47 -07:00
c5e26ab4da Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59172)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:33:04 -07:00
b75e8d19be Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59132)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:32:05 -07:00
1d3f2c7764 disable s3_lifecycle tests (#59311) 2019-07-19 13:20:15 -04:00
4a574c4d0c Option parsing: warn if both an option and its alias are specified for a module (#53698)
* Print warning when both an option and its alias is specified.

* Improve output.

* Put warnings into self._warnings directly, resp. use self.warn() when handling subspecs.

* Add changelog.

* Add unit test.
2019-07-19 13:11:41 -04:00
f231f21669 Handle situation where ansible_architecure may not be defined when gathering facts (#55466) 2019-07-19 11:33:05 -04:00
bb006db7c8 Add exclusive configuration mode support (#59289)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-19 19:03:35 +05:30
4b152235ff Typo fixes (#59227)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-19 18:18:14 +05:30
fd2116e26a Added state "remount" which will remount the device (#52649) 2019-07-19 08:59:27 +02:00
a752e2a467 Clear 'connection related' plugin vars for next loop iteration (#59024)
Fixes #58876
2019-07-19 08:39:05 +02:00
da047eec59 cloudformation_facts: Fixes PhysicalResourceId KeyError(#55990)
Fixes: #38033
2019-07-19 10:51:54 +05:30
e7c9c9585e update ce_vrrp to fix a bug (#59185)
* update ce_vrrp to fix a bug

* update module ce_vrrp 20190718

* update ce_vrrp to fix bugs
2019-07-18 21:33:19 -04:00
87601969a3 Correct places where match was intended
pytest.raises has two parameters, message and match.  message is meant
to be the error message that pytest gives when the tested code does not
raise the expected exception.  match is the string that pytest expects
to be a match for the repr of the exception.  Unfortunately, it seems
that message is often mistakenly used where match is meant.  Fix those
cases.

message is also deprecated so removed our usage of it.  Perhaps we
should write a sanity test later that prevents the use of
pytest.raises(message) to avoid this mistake.

seealso: https://docs.pytest.org/en/4.6-maintenance/deprecations.html#message-parameter-of-pytest-raises

Also update the exception message tested for as we're now properly
detecting that the messages have changed.
2019-07-18 17:10:58 -07:00
c010a6d288 Fix maven_artifact.py when your maven is behind a cloudflare (#53495)
Cloudflare has a feature that checks Browser Integrity Check, when the user agent is not present, it can fail on BIC.

Since we are defining the default value of variable "self.module.params['http_agent']" to None, this will cause that
User-Agent header will not be added, because of the conditional if present on module_utils/urls.py [1]

[1] https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/urls.py#L1135-L1136

This fix will ensure that the "self.module.params['http_agent']" will be defined

URLs:
https://support.cloudflare.com/hc/en-us/articles/200171806-Error-1010-The-owner-of-this-website-has-banned-your-access-based-on-your-browser-s-signature
https://support.cloudflare.com/hc/en-us/articles/200170086-What-does-the-Browser-Integrity-Check-do-
2019-07-18 18:55:36 -04:00
4acbb83c84 Add checks for VG and Pod existence when creating volume (#58857) 2019-07-18 18:11:06 -04:00
a1220268b2 Add new facts for Pure Storage FlashArray (#58894)
* Update purefa_facts module to support NVMe and preferred arrays

* Update purefa_facts with new information available from array
2019-07-18 17:46:19 -04:00
aeb0245ebd Add check for correct API version before trying to execute (#59205) 2019-07-18 17:17:31 -04:00
5f222c478d Bug fixes for GCP modules (#59130) 2019-07-18 16:41:45 -04:00
6128d0cd8b New Module: gcp_mlengine_model_facts (#59223) 2019-07-18 16:39:57 -04:00
de92ea6b3d New Module: gcp_mlengine_version_facts (#59225) 2019-07-18 16:39:48 -04:00
eeb97e9ceb Label kubectl connection plugin as community (#59265) 2019-07-18 15:51:32 -04:00
c256e3565c remove trstringer as maintainer (#59256) 2019-07-18 15:28:23 -04:00
00699735e9 add eol banner (#59254) 2019-07-18 14:15:43 -05:00
44a0fb5a93 Add team_foreman to contrib/inventory/foreman.py (#59178)
This will allow team_foreman to merge fixes, but mostly I'd prefer to
close as wontfix to point users to the inventory plugin that also
exists.
2019-07-18 15:07:05 -04:00
42073b6331 Add lambda_bucket_event module (#58059) 2019-07-18 10:54:01 -07:00
1c1da3c11d Re-enable ec2_vpc_vpn_facts test (#58893) 2019-07-18 09:17:15 -07:00
393e4a41d0 Added support to create and delete multiple databases in MySQL (#58602)
* Added support to create/delete mulitiple databases in MySQL

Fixes: #58370

* Added additional tests cases and fixed documentation changes

* Code refactoring and added tests for better test coverage

- Removed db_exists usage from most of the code. Used existence_list
 and non_existence_list instead

- Added additional tests to cover all scenarios w.r.t creation and deletion
 on multiple databases

- Added tests for dump operations

* Minor fix

* Minor fix - create check mode test

* Added dump tests for better dump tests coverage

* Removed minor database connection details

* fixed error

* Added test case for import operations

* Code refactoring and review fixes

- Added dump all test case

* Fixed review comments

* Minor review comment fixes

* Altered db_create return value

* Removed db_list and altered "does exist" to just "exist"

* Kept db and db_list in module.exit_json

* Refactored tests

- Added removal of dump2 file

* Moved import tests to state_dump_import file

* Removed import tests from multi_db_create_delete

* Updated porting guide, added RETURN block

* Minor identation fix

* Added validation to check if databases are dumped
2019-07-18 16:56:32 +02:00
cdf0947df0 Fix typo in import package name. (#59229) 2019-07-18 16:54:33 +02:00
0e8eb1d17f pip: Remove unused option use_mirrors and remove all ignore.txt entries
PR #58977

* Remove unused option use_mirrors

* Add changelog fragment
2019-07-18 16:38:37 +02:00
d2edf1d435 User - Create parent directories if they do not exist in the specified home path (#51043)
* Create a user home directory if it has parents that do not exist

The useradd command line tool does not create parent directories. Check if the specified home path has parents that do not exist. If so, create them prior to running useradd, then set the proper permission on the created directory.

Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Use dict for default user group in tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Fix tests

Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-07-18 10:19:11 -04:00
2fbc226509 Update to base Netapp.py for Azure, and Rest API (#59151)
* base changes

* updateS

* fixes

* fies

* updates

* fix issues

* updates
2019-07-18 08:37:00 -04:00
b2d8ef69f9 PR to support Ansible Checkmode in Checkpoint modules (#57695)
* added checkmode support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-18 16:26:55 +05:30
b01b1d40cf PR to add Unit TC for Checkpoint network module (#57710)
* cp_network unit TC

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-18 16:24:09 +05:30
264945d75f ovirt-host-network: support commit on success (#59212)
In ovirt-engine 4.3 and onwards a 'commit on success' parameter is
available. It is used to commit a network configuration automatically
upon successful application of the configuration without needing a
separate save request.

Therefore since ansible 2.8 if the 'save' parameter is specified as
'true' the commit on success parameter will be set to true and used
instead of making an additional save request.
2019-07-18 06:39:32 -04:00
9489433a4d use sysprep only when needed (#59196) 2019-07-18 03:59:51 -04:00
cb201bfba1 add xmltodict to azure requirements file (#55748)
* add xmltodict

* fix lint
2019-07-18 01:32:51 -04:00
7e25a61464 snow: Call Refactored login from snow modules (#59201)
* Remove python shebang from snow_record*
* Add python shebang to all snow modules
* Remove NO_LOG from username
* Call Refactored login from snow modules
2019-07-18 10:53:23 +05:30
d0538c0d7a postgresql_pg_hba: Exception when two lines with same weight are compared (#59198) 2019-07-18 10:50:19 +05:30
8a13b41823 VMware: Use managed object id to find VM (#59143)
* Based upon partial work of wilmardo
* Now, user can specify managed object id of virtual machine to find
an existing virtual machine

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-18 07:38:12 +05:30
28259ee247 dzdo: fix password prompt (#59208) 2019-07-18 10:42:00 +10:00
277690bcc6 add changelog 2019-07-17 19:11:56 -04:00
b8a41a90b8 Wrap Get-MachineSid's body in a try/catch
It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: #47813
2019-07-17 19:11:56 -04:00
42c43a2822 add azure_rm_keyvaultkey_info module (#55754) 2019-07-18 06:55:51 +08:00
13bbfacb04 Show ansible-test --explain errors in CI. 2019-07-17 15:34:00 -07:00
5392d8697d Docs scripts cleanup (#59169)
* Fix dump_keywords to require attribute docs

* Change the documentation commands to make definition files positional

Since the definition files are mandatory, make them positional
parameters instead of options.
2019-07-17 12:01:07 -07:00
c2253c8133 Allow for no role_versions to be present (#56519)
* Allow for no role_versions to be present

  fixes #46650

  better info on fetch, ensure list return

* use correct to_
2019-07-17 12:35:24 -04:00
4ef2545eb5 if users are None/empty, dont assume sameness (#58875) 2019-07-17 11:17:48 -04:00
48d4d6ec69 Stop ignoring merge hash behaviour in inventory (#58460)
* stop ignoring merge hash behaviour in inventory

fixes #58120

* added porting note

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-07-17 11:16:56 -04:00
0e09800a9a Postgresql modules: tidying up of CI tests (#59099) 2019-07-17 11:00:40 -04:00
a39b721db5 fixes to config manager (#58530)
* skip unreadable ansible.cfg

* all types should check for type

* patch access for tests and fix tests that relied on missing files not being checked
2019-07-17 10:39:30 -04:00
5ac2c6d4fe remove unused and obsolete bsd port makefile (#58633)
freebsd itself has maintained and up to date version of port
2019-07-17 10:36:44 -04:00
b8eba8e1f0 VMware: Add testcase for vmware_dvs_portgroup_facts (#59088)
* Tests for choosing specific DVS while gathering facts

Signed-off-by: dx0xm <52723266+dx0xm@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-17 18:31:52 +05:30
ce907c8b90 New module os_group_info (#57120)
* Added domain_id param to get_group

* Added module os_group_facts based on os_project_facts

* Fix pep8 alarms and version_added to 2.9

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Fixes based on https://github.com/ansible/ansible/pull/57120#issuecomment-511338588

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Removed availability_zone option

* Revert "Removed availability_zone option"

This reverts commit 20155c0b0f.

* Reverted to the original code to open a new Pull Request
2019-07-17 13:55:53 +02:00
edfdf30bcb Improve docs for win_service for custom account rights (#59155) 2019-07-17 08:03:47 +01:00
09aa98bf43 VMware: Gather facts about vlan id from DVS Portgroup in vmware_dvs_portgroup_facts (#59085) 2019-07-17 11:39:44 +05:30
6f94995b52 npm: Validate all option types (#58965)
* Add type validation for name, version and registry
* Add changelog fragment
* Remove ignore of E337 and E338
2019-07-17 09:34:58 +05:30
fbb4eaaba9 Update net_static_route document (#59168)
Update net_static_route examples section document, the missing colon can potentially cause confusion.
2019-07-17 09:08:34 +05:30
0bde145b1f PR to fix minor issues with Checkpoint module (#58049)
* minor checkpoint module fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* state default value set

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-16 18:51:32 -04:00
6430205d39 Update azure_rm_virtualmachine related document (#58861)
* Update azure_rm_virtualmachine_facts module's documentation with nitzmahone feedback, CI fixes

* 'remove_on_absent' does not define choices
2019-07-16 15:58:14 -05:00
493785ccef Remove extra blank line from galaxy .travis.yml.
This fixes the last yamllint error on the file.

The file is currently ignored by CI, but that will be changing soon.
2019-07-16 13:50:19 -07:00
d28f25d118 patch ansible-connection collection plugin loading (#59119) 2019-07-16 13:46:15 -07:00
d4dec59cb0 Fix collection loader builtin handling. (#58897)
- Support more import statements:

  from ansible_collections.ansible.builtin.plugins.module_utils import basic
  from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule

- Add unit tests for more import statements.
- Raise ImportError instead of returning None if load_module fails.
2019-07-16 13:40:22 -07:00
681ab6515a win_domain_group_membership - Fix to a fix in extra_args (#58943)
* win_domain_group_membership - Fix to a fix in extra_args

* addig missing l on the fly
2019-07-17 05:38:42 +10:00
e5e3486be6 clarifies how ASK works for Tower credentials (#59050)
* clarifies how ASK works for credentials
2019-07-16 15:37:47 -04:00
019d078a5a Move common build code from _build_helpers (#55986)
We have some common code used by several docs scripts.  Migrate that
into the build-only shared code repository.

* Move lib/ansible/utils/_build_helpers.py to the directory for common
  build code
* Migrate docs/bin/dump_config.py to a build-ansible subcommand
* Migrate dump_keywords to the build-ansible framework
  * Make the script more maintainable by using functions and good
    variable names
  * Port to Python3 idioms
  * Fix bug so that private attributes will be undocumented
* Move generate_man to a build-ansible subcommand
* Port plugin_formatter to a build-ansible subcommand
* Rework command_plugins so that docs scripts can target Python-3.4+ and
  releng-only subcommands can use more recent versions of Python.
  The architecture is now that command_plugins/* need to be importable
  on Python-3.4.  The init_parsers() method needs to run on Python-3.4.
  But the main() method can utilize features of more recent Python as
  long as it fits within those parameters.
* Update docs build requirements

Port the plugin_formatter to build-ansible framework
2019-07-16 12:19:01 -07:00
65e0f37fc0 Update azure_rm_virtualnetwork related document (#59023)
* Update azure_rm_virtualnetwork related documentation
2019-07-16 14:18:20 -05:00
b376c91749 win_hotfix: fix docs typo (#59124) 2019-07-16 14:09:13 -05:00
c7387549a4 Update azure_rm_virtualnetworkpeering related document (#59025)
* Update azure_rm_virtualnetworkpeering related documentation
2019-07-16 14:04:32 -05:00
cb0dfc9793 Prepare pylint test for collections support. 2019-07-16 11:24:16 -07:00
8bf069114f New Module: Vscan Enable (#57953)
* new module

* fix netapp.py

* updates

* fixes
2019-07-16 13:40:56 -04:00
d17e7a91b1 Add test for meta: end_play (#59118)
- Set ansible_python_interpreter for hosts using local connection
2019-07-16 12:41:48 -04:00
e8a7d89180 Correct a documentation of the jenkins_plugin module (#59139) 2019-07-16 11:46:18 -04:00
b16c264dca chroot connection plugin: defer get_option() call (#59065)
* The chroot connection plugin crashes because its constructor calls
  self.get_option(...) before the plugin loader has established its
  self._load_name.  Therefore, we should defer the self.get_option(...)
  call so that it happens in connect().

Fixes #59063
2019-07-16 11:31:06 -04:00
88c4cf28ea Modified blockinfile module's exmple using loop keyword (#59022) 2019-07-16 11:13:04 -04:00
9c5b3401ff Close file after using it (#59000) 2019-07-16 10:07:27 -05:00
2ed78b650f Update to ansible-test to prepare for collections.
Changes to simplify merging of collections support.
2019-07-16 08:04:07 -07:00
f0eaf1fb39 Module mail : Add Date header (#59080)
* Mail module : add date header (#58808)
2019-07-16 10:55:59 -04:00
de66abe521 VMware: Add support for storagePod (#58627)
* User now can be specify datastore cluster for deploying OVF
* Added find_resource_pool_by_cluster API

Fixes: #57849

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 13:14:21 +05:30
a63e17cd63 vmware_vmkernel: simplify the code (#55176)
- drop a dead branch in a condition tree
- simplify the look-up of the vnic
2019-07-16 09:28:22 +05:30
4b9391f32a Clean up ansible-test target handling. 2019-07-15 20:33:23 -07:00
e2adb37789 crypttab: 'NoneType' object is not callable when password is NoneType (#56790)
This looks to have been broken in commit 8bd5757720 where a fields.append was replaced with a call to self.password
2019-07-16 07:58:19 +05:30
4255ee8e5a Prepare ansible-test for collections support.
Another round of changes to prepare ansible-test for supporting collections to help keep later PRs a manageable size.
2019-07-15 17:46:29 -07:00
f81238012b Clean up pylint issues in test infra. 2019-07-15 14:45:30 -07:00
9e6399f74c Update azure_rm_virtualmachinescalesetextension related document (#58908)
* Update azure_rm_virtualmachinescalesetextension documentation
2019-07-15 16:02:42 -05:00
ee71a7df74 timezone - Add AIX support using chtz (#58838)
* init AIX support

* fix pylint whitespace issues

* Switch chtz from required=False to True

* Refactor AIX to include _get_timezone()

* More Pylint...
2019-07-15 15:52:50 -04:00
7cbd06f3a3 Adding vserver/SVM NFS info to na_ontap_gather_facts (#58826) 2019-07-15 14:35:09 -04:00
7a0a21ea7a ce_file_copy : update ce_file_copy to fix a bug. (#59071)
* update ce_file_copy to fix a bug.

* Update ce_file_copy.py

* Update ce_file_copy.py
2019-07-15 14:18:46 -04:00
a6d32eda84 Remove extra print statement (#59104)
Let ansible-inventory handle all output
Fixes #59101
2019-07-15 13:26:19 -04:00
4898b0a4a2 group: detect duplicate GIDs when local=yes (#58469) 2019-07-15 12:52:15 -04:00
a1dcba63b3 java_keystore - Prefer SHA256 and solve SHA256 keytool in java11 version (#57302) 2019-07-15 12:44:30 -04:00
2a07123fdd jboss module: add check mode support and integration tests (#58959)
* git war file and wildfly archive from S3
* create setup_wildfly_server role for integration tests
2019-07-15 12:17:08 -04:00
30206d3066 Add an example for the debugging module (#50197)
+label: docsite_pr
2019-07-15 12:00:36 -04:00
262c9ffdb6 VMware: fix for vmware_guest_file_operation binary file (#57614) 2019-07-15 19:05:54 +05:30
66a5ed64ca Remove reference to Windows for assemble docs (#59082) 2019-07-15 08:25:30 -05:00
ec35cbc437 Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies (#58771)
* Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies.

* Add changelog for ansible/ansible#58771
2019-07-15 12:02:14 +02:00
644eead954 Fix docs for yum_repository.py (#59068)
* The description has been replaced with proxy_password and proxy_username.
* Rename 59068-fix doc for yum_repository.py to 59068-fix_doc_for_yum_repository.yml
2019-07-15 15:19:40 +05:30
3a5d13b0d7 VMware: Fix vmware_guest cloning bug (#58737)
* fix vmware_guest cloning bug
* added tests for resizing disks during clone
2019-07-15 10:09:54 +05:30
b6273e91cf Fix deprecation warning message from grafana_annotations
The Display class has no `info` attribute/method. The use of the method
was raising an Exception in task_queue_manager and displayed an
unappropriate deprecation warning.
2019-07-14 18:27:39 +02:00
07a598089a update ce_interface to fix a bug. (#59070) 2019-07-14 11:28:40 -04:00
8d6f1846a6 docker_* modules: improve tag validation and requests error handling (#58791)
* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.
2019-07-13 22:36:18 +02:00
fa7c387f9b docker_container: add support for nocopy mode (#59043)
* Add support for nocopy mode.

* Add changelog.
2019-07-13 14:50:32 -04:00
34a68fa0fb pip: Document option types and validate name elements
PR #58966

Also:
* Validate that name elements are strings
2019-07-13 17:05:37 +02:00
a135c483ce Add OAuth and Multi-Record Query for SNOW (#58410)
* Add SNOW OAuth Support and Multi-record Query

* Add OAuth documentation to snow_record_find

* Fix lint and verification issue for PR 58410

* Fix E309 and E324 errors in PR 58410

* Fix E307, need advice on E309

* Fix E309 for PR 58410

* Re-add instance, username and password documentation

* Fix data type mismatch in documentation

* Remove doc_fragment overlap

* Refactor service now module space

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-13 20:34:36 +05:30
d910c971b4 Minor ansible-test code cleanup. (#59052)
* Minor ansible-test code cleanup.
* Fix type annotations.
2019-07-12 21:58:19 -07:00
945e35ada2 Fix exception in unixy callback v2_runner_retry (#58801) 2019-07-13 09:08:51 +05:30
d1587bca41 Bug fixes for GCP modules (#58902) 2019-07-12 18:50:49 -04:00
11d61cc01e Swap ordering to ensure Dynamic always first (#58998) 2019-07-12 15:52:06 -05:00
f3aac3a112 MOTD was not idempotent (#57372)
* fix issue

* fix issues

* fix issues

* fix issues
2019-07-12 16:47:41 -04:00
13d45cd0f9 Fix typo in purefa_user and purefa_dsroledocumentation examples (#59005)
fa_url not fb_url
2019-07-12 15:35:36 -05:00
3b0c933f18 [win_credential.py] Fix example in docs (#59042)
Example should use "secret" instead of "password".
2019-07-12 15:30:09 -05:00
51e1b090db Bug fixes for GCP modules (#58901) 2019-07-12 16:21:43 -04:00
119b8521a6 Bug fixes for GCP modules (#58904) 2019-07-12 16:21:31 -04:00
0dd3fb82eb get rid of Sphinx 2.1.2 errors (#59001) 2019-07-12 16:19:08 -04:00
6645054329 Code cleanup for test infrastructure. (#59046)
* Remove useless object inheritance in test code.
* Remove unnecessary pass statements from test code.
* Comment on why certain pylint rules are ignored.
* Add more pylint test contexts.
* Fix import order.
* Remove unused variables.
* Remove unnecessary pass statement.
* Fix bad continuations.
* Remove unnecessary elif.
* Allow legitimate broad except statements.
* Allow legitimate protected access.
* Clean up names to make pylint pass.
2019-07-12 13:17:20 -07:00
8c55a9c70b Update azure_rm_virtualmachinescalesetinstance related document (#58909)
* Update azure_rm_virtualmachinescalesetinstance related documentation
2019-07-12 15:11:45 -05:00
fec314febb clarifies nmcli option 'conn_name' (#59034) 2019-07-12 16:07:55 -04:00
343acd76d4 Update azure_rm_virtualmachineextesion related document (#58907)
* Update azure_rm_virtualmachineextension related documentation
2019-07-12 15:04:50 -05:00
dd30d86f1e Use comprehensions rather than map() (#58997)
Since we now require Python > 2.6 on the controller, we can drop the use of map() here
2019-07-12 15:49:39 -04:00
dd2755e0b4 Fix pylint warnings for update-bundled 2019-07-12 12:35:56 -07:00
6fb7a2b7cc Bug fixes for GCP modules (#58903) 2019-07-12 15:11:22 -04:00
5cd0e2f19f Bug fixes for GCP modules (#58900) 2019-07-12 15:08:08 -04:00
70db07fa82 Fix junos_interfaces integration test failure (#59035)
* Fix junos_interfaces failure

*  Remove lo0 interface by default since
   vsrz zuul env seems to add it intermittently
   as part of device intial config

* Add missing change for replace case
2019-07-12 13:55:28 -04:00
7b8edbf9dd VMWare: New Module for content library CRUD operations (#58716) 2019-07-12 09:34:05 -07:00
3f2b766d10 Add future and metaclass boilerplate to test code.
Continue to ignore:

- test/integration/
- test/legacy/
- test/units/
2019-07-12 09:18:24 -07:00
f98a4ef2f7 vmware: ro=False datastores for the functional test
https://github.com/ansible/ansible/issues/58541 prevents us from using
read-only datastore. So for now, we mount everything read-write.
2019-07-12 16:23:17 +02:00
aea5b795c0 Make ansible_index_var accessible as a magic var (#59030) 2019-07-12 08:50:19 -04:00
6bd6bf98e5 VMware: New Module for VMWare content Library info (#58703)
* Changes as per review comments and renamed file to vmware_content_library_info
* Removing password field from publish info dictionary
* Removed current password field from publish info
* Modified vmware_content_library_info module with review comments.
* Review comments. Moved test .yml files under tasks folder
* Moved test files under module name folder. Handled library_get call under try catch to throw proper error message
* Fixed precheck failure bare except. Catching Exception
2019-07-12 15:50:30 +05:30
31baab85f9 ansible-test: vcenter through a HTTP proxy
Give the ansible-test user the ability to target a lab behind a HTTP proxy.
2019-07-12 10:56:36 +02:00
617972499f VMware: Correct network_exists_by_name API call (#59006)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-12 11:22:06 +05:30
f09bd91ad0 Add junos_interfaces resource module (#58871)
* Add junos_interfaces resource module [junos_interfaces]

*  Add new resource module junos_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/8
*  Depcreate junos_interface module

* Fix CI failures

* Fix integration test failures

* Fix CI failures

* Fix review comments
2019-07-12 09:05:48 +05:30
6327a6114b Add ansible-test units --num-workers option. 2019-07-11 17:15:16 -07:00
43c3b9fb0e Simplify ansible-test cwd setup. 2019-07-11 17:15:16 -07:00
9fc710f657 Fixed a bug where the Route 53 Health Check would add a new health check instead of updating an existing one when the user has > 100 health checks (#58539) 2019-07-11 14:57:09 -07:00
9cb78b4826 New options to volume (#58531)
* updates to volume

* fix ansibot

* fix issues

* Revert "fix issues"

This reverts commit 54988709ae.
2019-07-11 17:42:00 -04:00
bc3a599678 Fix invalid type hints in ansible-test. 2019-07-11 14:25:57 -07:00
b91a90a274 Fix examples to use the module (#58988)
This was probably a copy/paste mistake. The examples are using a different module.
2019-07-11 15:24:17 -05:00
e8b8a0ab26 Enhancement: replaced with_items keyword for loop keyword. (#58865) 2019-07-11 15:41:43 -04:00
bcc23e70e6 win_dns_client - fix bug in devel and added tests (#58971)
* win_dns_client - fix bug in devel and added tests

* Fix sanity issue
2019-07-12 05:36:12 +10:00
6aad3a6842 iptables gid_owner (#58795) 2019-07-11 15:29:40 -04:00
dfd48ab3c3 Update azure_rm_virtualmachineimage_facts document (#58660)
* Update azure_rm_virtualmachineimage_facts documentation
2019-07-11 14:10:37 -05:00
75724bb7ca Fix reported AIX filesystem module incorrect fail_json() usage (#58642)
* Fix reported AIX filesystem module incorrect fail_json() usage and
extend reporting on an error.

Fixes #58609

* pep8 and ansible-test fixes, as well one missed msg param
2019-07-11 14:23:18 -04:00
adea964c3e Fix gather_facts error/skipped reporting (#58927)
now give back full output from each module executed
 fixes #57204
2019-07-11 14:18:32 -04:00
59feb63d19 Add uid, and gid to volume clone (#57371)
* and new features

* fix issues

* fix issues

* fix issues

* add unit tests
2019-07-11 13:57:36 -04:00
a7b14ec1be Fix strat inv (#58982)
* Fix strategy functions that update inventory

* added tests
2019-07-11 13:49:49 -04:00
b0f38931b0 yum: check whether the lock file disappeared (#58581) 2019-07-11 18:14:42 +02:00
4ab364eaaf Cleanup EXAMPLES (#58972) 2019-07-11 12:12:21 -04:00
86ad4c99ba Reorganize util code in ansible-test.
Code in util.py that depends on CommonConfig is now in util_common.py.
2019-07-11 08:54:13 -07:00
17c88724ab Updating known_hosts module Docs (#58785) 2019-07-11 11:41:57 -04:00
6e3d54ae81 Set vscan_fileop_profile for na_ontap_cifs (#57373)
* new features

* update unit tests
2019-07-11 10:49:35 -04:00
36da7e462a Better fix for invalid data in 'options' field (#58353) 2019-07-11 10:19:18 -04:00
e8f4ebb22c nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
2019-07-11 18:02:02 +05:30
cc4dc075f7 Adds minor improvements to 'zabbix_actions' module (#58379)
Changes:

    1. Update mandatory arguments in accordance with Zabbix API.
       Only esc_period, eventsource and name fields are mandatory.

       Reference: https://www.zabbix.com/documentation/3.0/manual/api/reference/action/object

    2. Add default values to argument options in order to prevent "TypeError: 'NoneType' object is not iterable" error.

    3. Add new condition operators (introduced in Zabbix 4.0 and 4.2)

    References:
      - https://www.zabbix.com/documentation/4.2/manual/api/reference/action/object#action_filter_condition
      - https://www.zabbix.com/documentation/4.0/manual/api/reference/action/object#action_filter_condition

    4. Update module documentation
2019-07-11 06:14:00 -04:00
33d2728879 Rename python files in hacking/ directory to have .py suffix
ansible-test only passes files which have the .py suffix for sanity
tests on python files.  This change will allow sanity tests to run on
the Python files in hacking/

* Rename test-module to test-module.py
* Symlink test-module for backwards compat since end users may be using
  test-module
* Fix test-module sanity errors that are now triggered
* Rename ansible_profile to ansible-profile.py
* Rename build-ansible
2019-07-10 22:17:35 -07:00
146a7f8ff6 Split the metaclass == type and from future boilerplate code.
The metaclass boilerplate is safe to apply en masse.  The future import
boilerplate needs code to be inspected to be sure that there aren't any
py2isms that need to be fixed.  Split these two checks so that we can
fix them independently

Be explicit about which files are grandfathered so we can fix them up one by one
2019-07-10 22:17:35 -07:00
909f7f2ce5 vmware_dvswitch_nioc: fix the integration test (#58920)
Correct the name of the vcenter variables.
2019-07-11 08:06:27 +05:30
ee24e6c5be Qtree was not idempotent (#58596)
* fixes

* fixes
2019-07-10 20:18:17 -04:00
fd9b52f305 Add version_added to ec2 inv iam_role_arn option (#58945) 2019-07-10 16:11:19 -05:00
c513c1e2d3 aws_s3: Improve ETag handling (#46332)
* cosmetic: Remove useless call to ec2_argument_spec()

* aws_s3: Improve ETag handling

* Extract ETag calculation into a utility function for reuse by
  aws_s3_sync.
* Reduce code duplication in put/get by restructuring the logic
* Only calculate ETag when overwrite == different
* Fail gracefully when overwrite == different and MD5 isn't available
  (e.g. due to FIPS-140-2).

* aws_s3: clean up integration tests

Clean up tests, add tests for overwrite settings in both directions.
2019-07-10 14:05:12 -07:00
0e7e3c0ae8 Add msg parameter to the mandatory filter (#56724)
* Add msg parameter to the mandatory filter

The `mandatory` filter would be more useful, particularly when dealing with nested dictionaries, with the simple addition of a `msg` parameter for supplying it with a custom failure message.
2019-07-10 15:53:48 -04:00
3ae2d15e45 add d-little maintainer to team_aix (#58653) 2019-07-10 14:51:49 -05:00
0194d17e4c Update win_iis_webapppool.py (#58930)
##### SUMMARY
Typo: to restart a pool, state should be "restarted", not "restart"
2019-07-10 14:42:00 -05:00
0a02b5ecc1 Update foreman maintainers (#58829) 2019-07-10 15:37:03 -04:00
b58c64e3b1 consul_session: ensure empty result is handled (#58694) 2019-07-10 15:15:18 -04:00
d1afcbced1 Cache handler name for included handlers. Fixes #58769 (#58780) 2019-07-10 13:53:56 -05:00
982a36c915 Update contrib script documentation (#58883)
* Update contrib script documentation - new inventory solutions should be plugins, not scripts
2019-07-10 13:38:31 -05:00
00d7aed56b Changing LBName used by same task inside azure_rm_loadbalancer (#58936)
fixes #58933
2019-07-10 14:20:35 -04:00
15d76d97a9 vdo: fix modify stage KeyError on unsupported parameter (#55160)
In "status: present" playbook execution for a VDO volume that is
absent, all of the parameters that are given in the playbook are
issued to the "vdo create" command, therefore any parameters that
become "unrecognized" will result in the "vdo" command returning an
error with the message "unrecognized arguments", which can then be
relayed back to the user.  This is a gracefully handled failure case.

Examples of "unrecognized" parameters are new features that are not
yet in the current version of VDO, or features that were removed
since the current version of VDO.

In "status: present" playbook execution for a VDO volume that is
already present, the same behavior as the "creation" stage of the
module should occur, but doesn't occur, since the key strings for
the "vdo status" output of the parameter do not exist.  This results
in a KeyError on the parameter that no longer exists.

Therefore, use "if statfield in processedvdos[desiredvdo]:" to filter
the modifiable parameters with the ones that are supported in this
VDO version, then use "if statfield not in processedvdos[desiredvdo]:"
to evade the KeyError, and add the "unsupported" parameters.

Also, instead of using the "currentvdoparams" dictionary, which
filters only the parameters reported by the "vdo status" output, use
the "modtrans" dictionary, which contains all of the possible
parameters.  Therefore, if the playbook specifies an "unsupported"
parameter, let it be passed on to the "vdo" command, to display an
actionable error message.

This fixes https://github.com/ansible/ansible/issues/54556

Signed-off-by: Bryan Gurney <bgurney@redhat.com>
2019-07-10 13:24:05 -04:00
c79afb1cba Move ansible-test unit coverage code into plugin. 2019-07-10 10:09:46 -07:00
49a1ec40aa fix typo "decend" (#58895)
fix typo "decend" to "descend"
2019-07-10 09:16:40 -05:00
520af5cb47 Sanity test fixes for future collections support. 2019-07-10 07:03:48 -07:00
9e1b19e364 Fix nxos_install_os test cases typo (#58825)
This should be ansible_connection, not connection_type. We can also
update local testing logic.

Remove nxos_install_os/tasks/network_local.yaml as it is nolonger used.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-07-10 19:11:53 +05:30
c68bf5997f Add version 2.13 to the removed_in list (#58924) 2019-07-10 09:38:31 -04:00
ef1cf2d2e8 consul_session: ensure scheme parameter is used (#58692)
* Ensure an error occurs when unknown scheme is used
* consul_session: don't ignore 'scheme' parameter
2019-07-10 09:16:17 -04:00
7346b699ee Use templated loop_var/index_var when looping include_* (#58866)
Fixes #58820
2019-07-10 13:49:24 +02:00
ad49057330 fix the vm name 2019-07-10 12:19:55 +02:00
b7252b0815 fix type in doc issue 2019-07-10 12:19:55 +02:00
753b7d853f fix doc issue 2019-07-10 12:19:55 +02:00
b28614ea5a Update lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-10 12:19:55 +02:00
2fbf657cd4 Update lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-10 12:19:55 +02:00
5873521ddd Update lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-10 12:19:55 +02:00
fcc0b71c74 add new module vmware_guest_sendkey 2019-07-10 12:19:55 +02:00
41b7b1c6e9 jboss module: actualize doc formatting (#58913)
* jboss module: actualize doc formatting, remove exceptions from ignore.txt
2019-07-10 15:38:53 +05:30
753f998262 Pluribus Networks ipv6 security reguard vlan module with UT (#58319) 2019-07-10 14:39:53 +05:30
63b606ee94 postgresql_user: add integration tests (#58864)
* postgresql_user: add separate integration tests

* postgresql_user: add separate integration tests, add always block

* postgresql_user: add separate integration tests, include -> import_tasks, jinja checks

* postgresql_user: add separate integration tests, fix formatting

* postgresql_user: add separate integration tests, fix formatting

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-10 10:59:28 +02:00
13de8686e5 vmware: vmware_guidelines.rst
VMware specific documentation that explains:

- how to run the functional tests
- and the conventions.
- clarify the difference between govcsim and vcsim

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-10 09:40:17 +02:00
8731fc7a86 returning invalid security (#58595) 2019-07-10 00:40:31 -04:00
9e67953b2e Fix collection loader and add unit tests. (#58701)
* Use `compile` before `eval` in collection loader.

This fixes two issues:

1. File names are available when tracing execution, such as with code coverage.
2. Future statements are not inherited from the collection loader.

* Add unit tests for collection loading.

These tests verify several things:

1. That unit tests can import code from collections when the collection loader is installed.
2. That tracing reports the correct file and line numbers (to support code coverage).
3. That collection code does not inherit __future__ statements from the collection loader.

* Update unit test handling of the collection loader.

Since the collection loader is installed simply by importing ansible.plugins.loader,
we may already have a collection loader installed when the test runs. This occurs if
any other tests are collected which use that import during collection. Until that code
is moved into an initialization function to avoid loading during import, the unit tests
will need to replace any existing collection loaders so that they reflect the desired
configuration.

* Insert into sys.modules before calling exec.

This is a requirement of PEP 302.

It will prevent recursion errors when importing the current module or using a relative import.

* Use the correct value for __package__ in modules.

This allows using relative imports in collections.

* Add warning about modifying code for trace test.

* Add test for relative import in collection.

* Add __init__.py to collection to satisfy pylint.

The relative-beyond-top-level rule in pylint may not be appropriate for collections.
However, until that rule is disabled for collections this will keep tests passing.
2019-07-09 17:31:33 -07:00
1e1463401d Prepare ansible-test for supporting collections. (#58886)
This is a small but incomplete set of the initial changes for supporting testing of collections with ansible-test.
2019-07-09 17:31:04 -07:00
73a7a0877d Fix Pacman regex for unmatched Arch package name (#48558)
* Fix Pacman regex for unmatched Arch package name

`ansible -m pacman -a upgrade=yes $(hostname)` failed due to not
accounting for the `+` character in the `pacman -Qu` output line:

    libsigc++ 2.10.0-1 -> 2.10.1-1

Per the Arch wiki¹, package names can contain alphanumeric characters,
and any of {`@`, `.`, `_`, `+`, `-`}.

The existing `re` covered `_` (part of `\w` in Python), and `-`
(explicitly included). This change adds `@`, `.`, and `+` (in
ASCII-betical order).

¹: https://wiki.archlinux.org/index.php/Arch_package_guidelines#Package_naming

* Add explanation for `pacman -Qu` regex matching

* Remove unneeded non-capturing groups in regex
2019-07-09 20:14:14 -04:00
b9dafdbade Move integration tests to using RHEL 8.0 GA (#57772) 2019-07-09 17:45:06 -04:00
5ccd674dba Update default test container to use Python 3.8.0b2 (#58877) 2019-07-09 17:44:16 -04:00
0befccbeb9 Update intro_inventory.rst (#58732) 2019-07-09 15:56:21 -05:00
25a6e97046 win_firewall_rule - update doc for remoteport dep. on protocol (#58796) 2019-07-10 05:58:52 +10:00
b6791e6ae3 ansible-galaxy: add collection sub command (#57106)
* ansible-galaxy: add collection init sub command

* Fix changelog and other sanity issues

* Slim down skeleton structure, fix encoding issue on template

* Fix doc generation code to include sub commands

* Added build step

* Tidy up the build action

* Fixed up doc changes and slight testing tweaks

* Re-organise tests to use pytest

* Added publish step and fixed up issues after working with Galaxy

* Unit test improvments

* Fix unit test on 3.5

* Add remaining build tests

* Test fixes, make the integration tests clearer to debug on failures

* Removed unicode name tests until I've got further clarification

* Added publish unit tests

* Change expected length value

* Added collection install steps, tests forthcoming

* Added unit tests for collection install entrypoint

* Added some more tests for collection install

* follow proper encoding rules and added more tests

* Add remaining tests

* tidied up tests and code based on review

* exclude pre-release versions from galaxy API
2019-07-10 05:47:25 +10:00
d336a989e4 Bug fixes for GCP modules (#58848) 2019-07-09 14:35:35 -04:00
9721c4045b Bug fixes for GCP modules (#58849) 2019-07-09 14:35:25 -04:00
eb839c94ea Bug fixes for GCP modules (#58850) 2019-07-09 14:35:14 -04:00
d88f686976 Bug fixes for GCP modules (#58851) 2019-07-09 14:35:03 -04:00
4eba84ce78 New Module: gcp_appengine_firewall_rule_facts (#58853) 2019-07-09 14:34:52 -04:00
d1226b7663 Update azure_rm_subnet related document (#58445)
* Update azure_rm_subnet related document
2019-07-09 13:30:07 -05:00
a269c564c7 Delete the negation symbol "¬" by typo. (#58640)
* Delete the negation symbol "¬"

* Update lib/ansible/modules/packaging/os/yum.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-07-09 12:27:42 -05:00
e5a1d85092 clarify FQCN needs for plugins (#58870)
* clarify FQCN requirement, fix example
2019-07-09 12:25:06 -05:00
c2469648e4 Docs on general precedence (#50201)
* Add docs/docsite/rst/reference_appendices/general_precedence.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-07-09 12:14:40 -05:00
f9a31e3e17 Provide the list of packages in a modern way (#58668) 2019-07-09 12:04:12 -05:00
dbb1f01a56 Update vsphere_file.py (#58874)
wrong module name in examples
2019-07-09 11:58:43 -05:00
de7776e25d Update azure_rm_virtualmachinescaleset related document (#58699) 2019-07-09 11:57:21 -05:00
612223773a Daemonize service start on OpenBSD, fixes #50460 (#58528) 2019-07-09 11:28:10 -04:00
1d50d308fc Minor typo/language fixes in the documentation (#58856)
Minor typo/language fixes in the zabbix_map documentation
2019-07-09 18:15:28 +05:30
d50531c6bd New Fortinet's module for fortios_user_device (using new httpapi plugin) (#58291)
* New Fortinet's module for fortios_user_device (using new httpapi plugin

* Fix documentation errors

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-07-09 15:53:36 +05:30
140a8e53f3 vmware_guest: do not use infra.vm_list
Update the functional tests of `vmware_guest` to use the
`virtual_machines` data structure.
2019-07-09 11:55:12 +02:00
1c2c1c15d0 dnf - fix error formatting of module name in error message (#58647) 2019-07-09 10:16:42 +02:00
1f427249d5 Fixed examples module name in udm_dns_record (#58814)
Fixes: 58813
2019-07-09 12:52:02 +05:30
88ec5e14cb Add unit tests for lenient_lowercase function (#58586) 2019-07-08 18:33:15 -04:00
446919de6f Add apply to k8s module (#49053)
* Add apply to k8s module

Use apply method for updating k8s resources.

* Improve apply documentation

* k8s: Make apply and merge_type mutually exclusive
2019-07-08 13:47:41 -07:00
105f60cf48 unified required zabbix-api dependency version and removed no longer needed extend of ZabbixAPI class (#53334) 2019-07-08 15:46:25 -04:00
7ddcaafee5 many pslint fixes (#55862)
* Handles:

PSAvoidTrailingWhitespace
PSAvoidGlobalVars
PSAvoidAssignmentToAutomaticVariable
PSAvoidUsingCmdletAliases
PSAvoidUsingWriteHost
PSUseDeclaredVarsMoreThanAssignments
PSUsePSCredentialType
PSAvoidUsingPositionalParameters
PSAvoidUsingEmptyCatchBlock
PSAvoidUsingWMICmdlet

Replaced Write-Host with Write-Output
Added smart reboot check for win_domain feature installation
Modify the Creation of the pagefileto fit to CIM
Changelog fragment addition
Ignore.txt without fixes

* Changes after community reviews

* Change Out-Null to '> $null'

* Fixes after jborean93 comments

* Test

* Revert "Test"

This reverts commit 35c5c0648fa9d2868a18094d84954e53ffa28880.

* Removed all  > $null since they broke the module since the output got dumped

* run test again

* Revert "run test again"

This reverts commit 80eaf07143f9d8cb0116cbbc68a6a69c0ace840c.

* Changes after community review

* ignore PSUseDeclaredVarsMoreThanAssignments that are on a diffrent PR

* CI failed on extra line in ignore.txt

* Review changes

* PSlint errors

* Trail space

* send to null breaks the tests for  Set-Workgroup

* Lint stuff

* win_domain_user issue of indent.

* Update win_domain_user.ps1

* Update win_domain_membership.ps1

* Fix redirect to null

* lint space issue

* removed return from set-workgroup

* removed send to null
2019-07-09 05:41:58 +10:00
5689cc08ce Add examples (#58819)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example
2019-07-08 14:10:10 -05:00
6a5bc5f206 Fix wrong unit in documentation example of ec2_metric_alarm (#58622) 2019-07-08 14:07:28 -05:00
88364d4cfd Add purge_tags to s3_bucket to allow preservation of existing tags (#58754)
* Add purge_tags to s3_bucket to allow preservation of existing tags

Adding `purge_tags` with default `True` to maintain existing behaviour
allows users to set it to `False` to preserve existing tags

Fixes #29366

* s3_bucket: Add further tests and improve tag handling further

Additional tests for purge_tags: False suggested some incorrect
logic and thus further improvements

Increase wait timeout on bucket deletion as it wasn't always completing
in the default 100 seconds
2019-07-08 10:19:01 -07:00
737da1853e os_user_role: add support for named domain (#49891)
Fixes #49859.
2019-07-08 09:26:15 -04:00
79fdc2190a role: Fix role's hash_params (#55263)
* role: Fix role's hash_params

Fix based upon work done by alikins.

Fixes: #20596

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-08 09:25:59 -04:00
894d19b108 Update ec2_snapshot.py (#58753)
ansible ec2_snapshot ValueError: time data '2019-05-27T12:08:49.929Z' does not match format '%Y-%m-%dT%H:%M:%S.000Z'
2019-07-08 19:20:47 +10:00
5b2d1cc24d Fix broken slxos_config due to changed backup options (#58804) 2019-07-08 09:28:53 +05:30
2eb499cbb3 Minor typo in sros_config docstrings (#58803)
Changed `f` to `If`
2019-07-08 07:58:12 +05:30
9c140d26d5 VMware: add new module vmware_guest_network (#52075) 2019-07-08 07:54:54 +05:30
5b953581b4 win_domain_user - MAke the query user try catch block more accurate (#58782)
* win_domain_user - MAke the query user try catch block more accurate for missing identity

* change to minor_changes

* Update win_domain_user-make-query-try-catch-accurate.yml

* Update win_domain_user-make-query-try-catch-accurate.yml
2019-07-08 07:13:48 +10:00
6e4c2c61bd Remove redundant line in os_port (#57838)
* Remove redundant line in os_port

The renaming of the key 'vnic_type' to 'binding:vnic_type'
is reduced to a single line.
The old key is removed to avoid to possibility of
inconsistency.

* Add missing parameter in example of os_port

In the example "Create port of type 'direct'" the parameter
"network" is added, because this parameter is required on
creating new ports.
2019-07-07 05:00:09 -04:00
73db7e2901 Changed command for next-hop-self to next-hop-self instead of activate (#58789) 2019-07-07 02:09:10 +05:30
faf50dbace Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-06 22:37:23 +02:00
8ff97edd1a Add the singlePlacementGroup in the virtual machine scale set module (#58320) 2019-07-06 06:14:14 +08:00
0c992d5ae4 Fix for skipping of gitlab_runner test.
Correct variable name for skipping of the gitlab test when gitlab python
client is not installed.
2019-07-05 11:47:19 -07:00
fed90efc4d Fix unicode error in changelog generation 2019-07-05 11:15:17 -07:00
4f642daae5 Correct machinectl become plugin function arguments (#58734)
* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)
2019-07-05 11:03:24 -04:00
61647731e2 Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493
2019-07-05 15:02:29 +02:00
709fbcf804 Fix fetching existing AS (#58756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-05 18:03:08 +05:30
83f92987b8 Change default behaviour for network resource facts (#58750)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-05 17:30:35 +05:30
5e2471485a VMware: Warn user about dvswitch permissions (#58579)
Warn user about dvswitch permissions since permissions for
a distributed switch must be defined and managed on either
the datacenter or a folder containing the switch.

Fixes: #55248

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-05 17:11:25 +05:30
641f7c4ae3 VMware: Updates the DRS rule without deletion (#57119)
* The DRS rule will be updated if any changes in the configuration without deleting the existing rule.
The rule itself is updated by the given configuration.
* Lint errors fixed
* VMware: update vmware_vm_vm_drs_rule testcases
2019-07-05 17:00:05 +05:30
2fb06650a7 kubevirt: even more unit tests (#58593) 2019-07-05 20:35:32 +10:00
ff4001f470 Update junos module utils (#58730)
*  Add utils fucntion to build xml
   subtree
2019-07-05 12:21:38 +05:30
1bd91279d0 Fixed fail_json call in command module (#58615)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-05 11:00:10 +05:30
5c5d9ad669 Refactor nxos_facts to support resource module (#58705)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-05 09:26:33 +05:30
a6b7d0d00b win_domain_user and win_domain_group: add created result boolean (#57901)
* win_domain_user and win_domain_group: add created result boolean

* Fix YML

* add docs

* brackets

* Update win_domain_group.py

* Update win_domain_user.py

* Update win_domain_user.ps1

* fix indent
2019-07-05 08:44:07 +10:00
07edcab051 win_acl: Fix problems with special IDRef in different languages than english (#57281)
* Change special id ref recognitionto avoid language diff

* Changelog added

* specialIdRefPrefixes to array

* Changed to the more generic option
2019-07-05 08:08:23 +10:00
e0b8bc1ef9 win_firewall_rule: Only report changed when change is made (#57267)
* Fix bug https://github.com/ansible/ansible/issues/44450

* Added tests

* I will make this CI work

* Update win_firewall_rule.ps1
2019-07-05 08:06:34 +10:00
6e319ff088 win_psmodule - Missing SkipPublisherCheck in Prerq installations (#58090)
* win_psmodule - Missing SkipPublisherCheck in Prerq installations

* Handle different minors of PS5

* community revisions

* Update win_psmodule.ps1
2019-07-05 08:00:58 +10:00
db5656cf6e Add support for pester tags (#57918)
* correct argument name

* added documentation

* adding missing version_added to doc

* correcting description in docs

* change type to list

* add tests

* correct test file
2019-07-05 07:45:52 +10:00
48a518d9a3 win_get_url - Fix proxy_url not used correctly (#58738) 2019-07-05 07:42:05 +10:00
60fb9fc208 Fix EC2 test suite to work with testing policies (#44387)
* Update testing policies to ensure all required permissions are present
* Tidy up security policies to reduce duplicate permissions
* Make roles static so that they can be present before CI is run,
  meaning that role creation permission is not required by the CI
  itself, only by someone setting up the roles prior to testing
* Move contents to cloudfront policy to network policy to ensure policy
  count (maximum of 10) stays low
* Maintain compute policy below 6144 bytes
2019-07-04 15:25:19 -04:00
6cf722fed6 postgresql_query module: add autocommit parameter (#58704)
* postgresql_query: add autocommit parameter

* postgresql_query: add autocommit parameter, add CI tests

* postgresql_query: add autocommit parameter, add a changelog fragment

* postgresql_query: add autocommit parameter, fix sanity

* postgresql_query: add autocommit parameter, cosmetic fix
2019-07-04 12:25:51 +02:00
7b20535063 Fix repetitive ansible_net key in gather_subset (#58702)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-04 13:05:13 +05:30
8b844b67b5 fix 57711 (#58618)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-04 10:45:10 +05:30
1eb3fba51f Fix os_quota when volume service not available (#57364)
os_quota checks the current quotas for compute, network and volume
services and fails when no volume service is found in the catalog.

Since openstack test deployments without volume services are common,
os_quota shouldn't fail if such service is missing.

This was originally fixed in d31a09ceb7
and later adapted to catch exceptions raised by shade. Since then, this
module moved to using openstacksdk, which doesn't catch the exception
raised by keystoneauth1.

Fixes #41240
2019-07-04 00:48:28 -04:00
89be328a29 - Fixed error handling on aws_kms (#58690)
While alias creation failes, this PR fixes the requirement of passing 2 arguments for the `fail_json_aws` method.
2019-07-04 09:35:56 +10:00
9808ffecc7 Add JSON output option to ansible-doc (#58209)
* allow json from ansible-doc

* save the var

* try to yaml load

* let examples stay as text blob
2019-07-03 17:52:20 -04:00
b4f4cb9b87 Fix 32910 part2 (#38709)
* cloud/packet: remove bogus mutual exclusions

operating_system is a required parameter, for custom ipxe it should be
set to custom_ipxe. The always_pxe and ipxe_script_url parameters are
only valid when operating_system==custom_ipxe, but they are not mutually
exclusive.

* cloud/packet: disallow custom_ipxe settings for supported oses.
2019-07-03 17:35:32 -04:00
3bfe32b9d9 fixed formatting and spelling issues (#58686) 2019-07-03 13:53:58 -05:00
7db2ffcf5e add docs about retry (#58625) 2019-07-03 14:33:22 -04:00
d50c8c2b83 Improve setup_docker tests to work with RHEL 8 GA (#58649)
- use include_vars to set appropriate packages and pip packages per distribution and version
- install an older version of Docker CE on RHEL 8 since a dependency is unavailable
- disable warnings on tasks that are ok
- skip tests for CentOS/RHEL 6
2019-07-03 14:24:24 -04:00
ce79c8eb27 Fix typos in the Collections Tech Preview doc page (#58669) 2019-07-03 13:51:54 -04:00
737dbefd78 Get copy tests passing with split controller/target (#58516)
* Get copy tests passing with split controller/target

* Remove sudoers file

* add missed set_fact
2019-07-03 10:37:33 -05:00
16d6fcf514 Improve dnf test formatting and fix RHEL 8 module name (#58648)
- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
- use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA
2019-07-03 11:11:20 -04:00
2e9db87a1b azure_rm_gallery: add disabled to aliases (#58672) 2019-07-03 22:43:06 +08:00
96eccda23b VMware: Add module vmware_vm_storage_policy_info (#56263)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-03 16:01:08 +05:30
8f0bf3e453 Add the azure_rm_..._info modules (#58576) 2019-07-03 13:48:14 +08:00
1e3034b96d junos_facts refactor to work with resources modules (#58566)
* junos_facts refactor to work with resources modules

*  Refactor junos_facts module to work with
   network resource module.

* Fix unit test failures

* Fix review comments
2019-07-03 10:08:45 +05:30
6c5de9e6eb NxosCmdRef: fix python2 ordereddict import (#58397)
* NxosCmdRef: fix ordereddict import checks for pre-2.7

* Fix ws
2019-07-03 09:41:29 +05:30
ee4cba1b85 ensure bytes in run_command (#58411)
* ensure we pass bytes to run_command

* changed tests for new behaviour

* dont b the pytest

* fixes by sivel
2019-07-02 17:07:48 -05:00
7ec31194a5 Ensure only running instance facts are retrieved to match the following assertion
Otherwise lingering terminated instances may be in the result
Use the instance profile arn or the role name, but not the role arn
Mark tests as unstable
2019-07-02 17:48:07 -04:00
a6d757e074 Ensure block device instance creation outputs instances
Not waiting outputs results in a format that will never
be matched by the tests

Ensure instances get tidied up

Allow ec2:ReportInstanceStatus

ec2_instance: Improve test cleanup on failing tests

Improve describe/modify attribute error handling

Address feedback on PR
2019-07-02 17:48:07 -04:00
da1a621bd9 Removed nested role for ec2_instance tests
Also moved environment setup and environment cleanup to separate task
files

Added CI group

Updated c4.large instances to t3.nano, use ENA enabled AMI

Updated AMIs with Amazon Linux AMI

Updated us-east-1 AMI id

Specify EBS size

typo, volume_size

Removed 'state: running', updated AMI with amz ami

Also added several wait: false to speed things up

Check for instance state, correctly

Accept pending as valid state

tags_and_vpc_settings do not wait for instance to complete

wait for termination protected instance

Updated IAM role name to match with policy

Skip env cleanup when in CI

Do not wait instance in external_resource_attach

ENI remove is done in env_cleanup/CI

wait some time for instance_profile instnace to be up

Updated ebs_optimized_images

Corrected task name

Added aws_cleanup var in cloud-config-aws

typo in runme

default aws_cleanup to true
2019-07-02 17:48:07 -04:00
30a7670f36 fixes (#58598) 2019-07-02 17:35:37 -04:00
63bdd0d6cd VMware: looking up maxMksConnections in incorrect location (#58061)
maxMksConnections is contained in vim.vm.ConfigInfo not vim.vm.VirtualHardware

Fixes: #58060

Signed-off-by: lijok <28689084+lijok@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-02 11:49:00 -07:00
b2554ab3b7 Update azure_rm_trafficmanagerprofile related document (#58616)
* Update azure_rm_trafficmanagerprofile related document
2019-07-02 13:13:35 -04:00
4e230dbfb6 ovirt add version added to ipv6 (#58626) 2019-07-02 13:04:14 -04:00
e5203a0f39 postgresql_ext: add a changelog fragment for PR 58381 (#58634) 2019-07-02 13:03:01 -04:00
0e9cfd3ee8 Fix sanity tests that are failing with LC_ALL set (#58604) 2019-07-02 10:56:12 -05:00
a9fcd1d197 Handle mode-setting of symlink to RO filesystem (#58564)
Fix for https://github.com/ansible/ansible/issues/58562
2019-07-02 11:15:39 -04:00
6e9bcc2579 Check nfs_version properly (#58574)
* Check nfs_version properly
original commit: 63f81d20db

* Add a space to fix the identation
2019-07-02 10:37:11 -04:00
7f15331510 Add build.target option to docker_image module (#58487)
Signed-off-by: Antoine Bardoux <pluggi512@gmail.com>
2019-07-02 09:42:35 -04:00
4da6d8cbf9 postgresql_ext: add version parameter (#58381)
* postgresql_ext: add version new option

* postgresql_ext: add version new option, fix ssl tests

* postgresql_ext: add version new option, fix tests

* postgresql_ext: add version new option, fix examples

* postgresql_ext: add version new option, fix the doc

* postgresql_ext: add version new option, fix examples

* postgresql_ext: add version new option, fix typo in tests
2019-07-02 15:24:46 +02:00
051172f9bf ovirt vm migrate with state present (#58136)
* ovirt vm migrate with state present init

* add migrate comment
2019-07-02 06:14:19 -04:00
fb1610a9ac Ovirt host event log (#57935)
* host event log init

* show more events

* add time check

* correct pep8 syntax

* use event id as first elem

* init start event in constr

* update pep8 syntax

* remove precreate
2019-07-02 06:01:52 -04:00
2e25638abc Ovirt add vm cloud init ipv6 (#58112)
* update cloud init ipv6

* update examples cloud init

* add ipv6 docs version added
2019-07-02 05:59:52 -04:00
231afd7751 ovirt update vm migration domunetation (#58577)
* init update docs

* Update lib/ansible/modules/cloud/ovirt/ovirt_vm.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-07-02 05:57:44 -04:00
540ceb8622 Remove unnecessary pass (#58620)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-02 11:01:33 +02:00
c3978fed4b Load Ansible module_utils for ps_argspec validator (#58571)
* Load Ansible module_utils for ps_argspec validator

* fix validation for modules without Requires statement

* Moved future comment to proper location
2019-07-02 12:22:38 +10:00
c260721ce5 win_domain_user: do not hide error on failures (#58357)
* win_domain_user: do not hide error on failures

* Was a bit too overzealous in the removal

* Remove uneeded sanity ignore rule
2019-07-02 07:40:51 +10:00
5d5a7d6ebe openssl_privatekey: forgot to add secp256r1 (#58605)
* Forgot to add secp256r1. This one is the interoperable one.

* Add changelog.
2019-07-01 23:08:54 +02:00
10af2636d1 Add unit tests for human_to_bytes (#58584) 2019-07-01 13:50:54 -04:00
c1a23cd763 Add two new Azure groups to prevent timeouts
ci_complete
2019-07-01 10:38:24 -07:00
6557322e79 Update azure_rm_trafficmanagerendpoint related document (#58447) 2019-07-01 11:31:54 -05:00
c86c079837 Update azure_rm_storageaccount related document (#58313)
* Update azure_rm_storageaccount and azure_rm_storageblob module documentation
2019-07-01 11:15:37 -05:00
3a919d4bec Doc - editorial for correct acronym introduction (#58519)
Introduce acronym GCP on first use. Introduce GCE acronym at all.
2019-07-01 10:37:13 -05:00
06651d1055 Fix traceback when using the module (#58588)
Since bricks_in_volume is a list, it can't be compared to a int.

    Traceback (most recent call last):
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 114, in <module>
        _ansiballz_main()
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 106, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 49, in invoke_module
        imp.load_module('__main__', mod, module, MOD_DESC)
      File \"/usr/lib64/python3.7/imp.py\", line 234, in load_module
        return load_source(name, filename, file)
      File \"/usr/lib64/python3.7/imp.py\", line 169, in load_source
        module = _exec(spec, sys.modules[name])
      File \"<frozen importlib._bootstrap>\", line 630, in _exec
      File \"<frozen importlib._bootstrap_external>\", line 728, in exec_module
      File \"<frozen importlib._bootstrap>\", line 219, in _call_with_frames_removed
      File \"/tmp/ansible_gluster_volume_payload_d5mfag24/__main__.py\", line 610, in <module>
      File \"/tmp/ansible_gluster_volume_payload_d5mfag24/__main__.py\", line 551, in main
    TypeError: '<' not supported between instances of 'int' and 'list'
2019-07-01 10:36:59 -04:00
5f8080aaa0 consul_session: improve documentation and add integration tests (#56392)
* consul_session: Python 2.6 is always required on managed node
* consul_session: document all types
* consul_session: add doc for 'id' parameter
* consul_session: improve parameter descriptions
    - use formatting functions in descriptions
    - 'name' parameter is required when state=node
* consul_session: use required_if
* consul_session: add integration tests
* consul_session: use 'retry' with network dependent tasks
* Use ansible-ci-files bucket for consul binaries

Co-Authored-By: Matt Clay <matt@mystile.com>
2019-07-01 10:27:15 -04:00
580b013837 rpm_key - add fingerprint parameter (#58373)
This parameter can be used to verify keys before they are imported by providing the long form fingerprint of the key.
2019-07-01 09:57:45 -04:00
d2ccf90610 Added missing SSL parameters to rabbitmq_binding (#58064)
In rabbitmq_binding.py the SSL parameters ca_cert, client_cert, client_key were only passed to requests for post requests.
This change updates the DELETE and GET requests to include these parameters as well.
2019-07-01 07:22:40 -04:00
045caaa400 VMware: Adding IP-Specific properties to ESXi host firewall config (#56733)
* Adds IP-Specific properties to firewall config

Fixes: #51240
2019-07-01 16:13:58 +05:30
39fbdc22ff VMware: Add new module vmware_guest_screenshot (#57449)
Signed-off-by: Tomorrow9 <tommorrow7@gmail.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-01 15:58:05 +05:30
539f37ede3 PR to implement ansible_net_model for iosxr facts module (#58488)
* resolves 57767

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-01 12:26:04 +05:30
d582efcc51 Use atexit to logout after zabbix module run (#58525) 2019-06-30 13:35:05 -04:00
f0801879c7 Rename xenserver_guest_facts -> xenserver_guest_info (#57032)
* Rename xenserver_guest_facts -> xenserver_guest_info.

* Add changelog.

* Forgot one test.
2019-06-30 10:04:30 -04:00
2401154fc4 VMware: rename VMWare to VMware (#58535)
Follow the nomenclature convention decided in https://github.com/ansible/ansible/pull/56814
2019-06-30 19:30:42 +05:30
35dcd231be purefa_user: Fix Incorrect parameter used causing crashes. (#57588) 2019-06-29 17:32:22 +02:00
80d6a2f344 Add network resource modules utils function (#58273)
* Add network resource modules utils function

*  `FactsBase` parent class to handle
    facts gathering
*  `ConfigBase` parent class for resource
   module config handling
*  utils funtions for resource modules

* Fix review comments

* Fix CI issues and review comments

* Fix review comments

* Fix CI issues and minor updates
2019-06-29 18:20:15 +05:30
78c8ee9261 ce_snmp_target_host: update to fix bug: None has no 'lower()' function. (#57904)
* update to fix bug: None has not 'lower()' function.

* add a changelog fragment.

* update changlog fragment.

* Update 57904-ce_snmp_target_host.yml
2019-06-29 09:36:28 +02:00
8cfd0ba039 Allow for test groups with double digits (#58532) 2019-06-28 16:24:14 -07:00
ab6a9ef130 Get minor version number for CentOS and Debian (#57814)
* Get the most detailed version number from distro.version() for CentOS and Debian
* Update tests and fixtures
* Update fixture generation script to gather distro info and work with Python 3
* Update LinuxMint fixtures
* Cleanup fixture formatting
* Improvements based on feedback from abadger:
    - use unicode since that is what distro returns
    - use frozenset with a tuple
    - include link Debian to bug
2019-06-28 19:21:35 -04:00
2f91266aa9 ce_vxlan_gateway: update the regular expression to match the more accurate. (#58226)
* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate
2019-06-28 17:11:00 -04:00
23139cdbb9 update to fix a bug (#58228) 2019-06-28 17:10:48 -04:00
b7630ccb36 update to fix a bug (#58230) 2019-06-28 17:10:33 -04:00
715de33467 ce_netstream_aging: update to fix a bug. (#58231)
* update to fix a bug

* update to for shippable.
2019-06-28 17:10:23 -04:00
36cfa9e931 ce_bgp: update bgp to fix bugs (#57317)
* update bgp to fix bgus

* add a changelog fragment for bgp
2019-06-28 16:47:35 -04:00
bb33c922f7 ce_static_route: fix some bugs. (#58251)
* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.
2019-06-28 16:47:10 -04:00
442d275ae3 update vrrp (#57916) 2019-06-28 16:35:20 -04:00
6cf6f5a34b Use atexit to cleanup tmp dirs (#56532)
* Wrap everything in try/except to avoid leaving files behind
* Add unit tests, integration tests, and changelog
* Do text the correct way
2019-06-28 16:19:27 -04:00
875e7c3e50 update to fix a bug. (#58200) 2019-06-28 16:14:52 -04:00
4a6c86715a update to fix a bug (#58207) 2019-06-28 16:14:40 -04:00
e0f3e404c9 update to fix a bug (#58227) 2019-06-28 16:14:27 -04:00
8acf71f78f Skip tests with unsatisfied deps (#55853)
* Skip gitlab tests if dependencies aren't met

* Skip certain unittests if passlib is not installed

* Fix tests with deps on paramiko to skip if paramiko is not installed

* Use pytest to skip for cloudstack

If either on Python-2.6 or the cs library is not installed we cannot run
this test so skip it
2019-06-28 13:09:36 -07:00
35b6345bdc Add a banner message to warn when not on latest documentation (#58526)
* add banner to versions that are not latest

* move div into script

* fix div

* move comment

* fix shippable errors
2019-06-28 15:06:49 -05:00
da72644317 update acl interface. (#57905)
* update acl interface.

* update ce_interface

* update

* add a changelog fragment.

* update
2019-06-28 16:03:47 -04:00
b93411a5b2 update to fix a bug (#58229)
Signed-off-by: xuxiaowei0512 <786018072@qq.com>
2019-06-28 16:03:08 -04:00
e02353026d update ce_interface to fix bugs (#57907)
* update ce_interface

* update ce_interface

* add a changelog fragment.
2019-06-28 15:52:39 -04:00
fdfab01a2e clean up setup author metadata/bot ignore (#58529) 2019-06-28 12:51:50 -07:00
826f224f02 Handle vaulted non-ascii characters for Python2 (#58503)
* Handle vaulted non-ascii characters for Python2

* Add a test to ensure str() no longer raises UnicodeEncodeError
2019-06-28 13:23:15 -04:00
e28bc46353 vcenter provider: set default values
Set default value for the following optional parameters:

- vcenter_port
- vmware_proxy_host
- vmware_proxy_port

This way we won't get an error if they are not define in the
configuration file.
2019-06-28 13:13:30 -04:00
756cdebd37 New & fixed examples for aws_ssm lookup (#58293)
* New & fixed examples for aws_ssm lookup

* Apply suggestions from code review

Co-Authored-By: Sloane Hertel <shertel@redhat.com>

* Clarify example name
2019-06-28 12:06:08 -05:00
23f0ca0acd fix unarchive integration tests when LC_ALL is not set to en_US.UTF-8 (#58431) 2019-06-28 09:47:10 -07:00
7ed7d374e4 Fix onepassword lookup plugin and onepassword_facts module when a field has no name. (#58308)
* Fix onepassword lookup plugin crashing on fields with no 'name' or 't' property.

* Fix onepassword_facts module crashing on fields with no 'name' or 't' property.

* Add unit test for onepassword lookup plugin failing on entries without a name.

* Add changelog fragment for onepassword lookup plugin and onepassword_facts module fixes on fields without a name.
2019-06-28 12:37:14 -04:00
1a5ae366f4 hostname - fix Oracle Linux (#58510) 2019-06-28 12:24:03 -04:00
393ea1cd55 document problem when removing something from a dictionary (#58349)
the problem is described at https://github.com/ansible/ansible/pull/49053#issuecomment-480427406
2019-06-28 11:39:29 -04:00
16610fa399 Fix version_added for gcp_compute 2019-06-28 07:38:01 -07:00
2d595da6ba want to be a maintainer for cloudengine (#56527)
Hi ansible_team, I am work for cloudengine and also a member of HuaweiSwitch/cost.
To quickly fix bugs,I create this PR.
Thanks a lot.
2019-06-28 10:13:14 -04:00
7afdf11456 Add Oracle scenario guide (#58443)
* Create and update docs/docsite/rst/scenario_guides/guide_oracle.rst
2019-06-28 09:03:42 -05:00
184143e498 Fixed file_module hardlink example (#58485)
Fixes: #58451
2019-06-28 08:56:45 -05:00
5937080977 postgresql modules: remove extra lines from doc that are presented in ext doc fragment (#58501) 2019-06-28 08:44:32 -05:00
0a27ad6ea0 VMware: Add new module vmware_dvswitch_nioc (#44147)
Signed-off-by: Joseph Andreatta <joseph@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-28 18:11:33 +05:30
0868fec8bd nxos_vpc: pkl_vrf fixes for #57069 (#57370)
* nxos_vpc: pkl_vrf fixes for #57069

Fixes #57069

- Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state.

- Analysis:
 - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib.
   - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf.

 - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed.
   - e.g. playbook specifies this:
     ```
     { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf }
     ```

     ```
     peer-keepalive dest 10.1.1.1 src 10.2.2.2             # original

     peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf  # intended result

     peer-keepalive dest 10.1.1.1 vrf my_vrf               # actual result
     ```

 - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right).

- Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F`

* PEP fixes

* PEP fix 2

* pkl should merge by default, not override

* rmv debugs

* add mike's tests

* fix comments
2019-06-28 16:18:46 +05:30
760dc19284 VMware: Set vapp settings while creating VM (#58156)
vApp Settings can be set while creating VM.

Fixes: #50617

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-28 11:57:26 +05:30
3ec4739cc7 the env argument for docker_container wants a dict, not a list (#58475) 2019-06-28 06:59:09 +02:00
e2d159c40c VMware: Handle user unauthorization in tagging scenarios (#58405)
Handle unauthorization scenarios in VMware tagging APIs.

Fixes: #58326

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-28 07:59:54 +05:30
242f160747 update ce_vxlan_global to fix bugs. (#57947)
* update to fix bugs.

* add a changelog fragment.

* update a changelog fragment.
2019-06-27 21:42:07 -04:00
4403f866e3 Simplify Git class in ansible-test. 2019-06-27 18:01:02 -07:00
cf7ee8eb12 doc: ce_snmp_location: fix changelog fragement missing module (#58481) 2019-06-28 01:10:17 +02:00
afe7cd3fda ce_snmp_location: fix for out of array index. (#57903) 2019-06-28 00:53:55 +02:00
19c6448459 Fix "no matches for wildcard" error in env-setup.fish script. (#58345)
See https://github.com/ansible/ansible/pull/58345#discussion_r297288979
2019-06-27 18:15:11 -04:00
ec1287ca7e Fix notifying handlers by using an exact match (#55624)
* Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list

* Enforce better type checking for listeners

* Share code for validating handler listeners

* Add test for handlers without names

* Add test for templating in handlers

* Add test for include_role

* Add a couple notes about 'listen' for handlers

* changelog

* Add a test for handlers without names

* Test templating in handlers

* changelog

* Add some tests for include_role

* Add a couple notes about 'listen' for handlers

* make more sense

* move local function into a class method
2019-06-27 17:29:20 -04:00
ee52b60d7d Add note about delegate_facts to run_once (#58241)
* Add note about delegate_facts to run_once
2019-06-27 17:19:22 -04:00
1b90e10cf0 docker_swarm_service: Make secret_id and config_id optional (#58299)
* Lookup secret id by name if not set

* Lookup config id by name if not set

* Add changelog fragment

* Remove usage of secret/config_id in examples

* Python 2.6 compat

* Extend secrets and configs tests
2019-06-27 22:24:34 +02:00
4d5a3d3341 New maintainer for zabbix modules (#58471) 2019-06-27 12:30:46 -07:00
5064e67d37 yum: take care of stale/invalid yum.pid (#58457)
* yum: take care of stale/invalid yum.pid

* Add changelog
2019-06-27 15:24:14 -04:00
939e2b4c79 Use the filename from AnsibleFileNotFound instead of the included file. Fixes #58436 (#58464) 2019-06-27 15:05:42 -04:00
20ad120829 Omit -A and -G options in local mode since luseradd does not support these (#55401)
Add integration tests
2019-06-27 14:46:38 -04:00
44b6f2ff56 removes last :doc: links in other sections of the docs (#58432)
* removes last :doc: links in other sections of the docs

* fix references to playbooks intro page
2019-06-27 12:18:17 -04:00
9b96da9aa1 zabbix_host - added documentation for interfaces sub options (#57844) 2019-06-27 11:40:20 -04:00
1bba30981c Revert "Add podman container module to ansible" (#58422)
This reverts commit f01468a9d9.
2019-06-27 11:36:31 -04:00
b06f5634c5 Simplify ansible-test target expansion.
Targets are always expanded to full lists now instead of optimizing
for shorter lists by collapsing directories.

This change only affects unit tests and the ansible-doc sanity test,
as they were the only remaining tests using the old behavior.
2019-06-27 08:27:48 -07:00
de8ac79832 Encoding fixes to support py2 and py3 non-ascii data
Fixes #58418

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-06-27 08:02:35 -07:00
18f9595719 Documentation Update (#58355)
"scope" is not a valid option for mso_schema_template_contract_filter.py - example should use "contract_scope"
2019-06-27 09:40:29 -05:00
8d053ae037 Describe minimum password length of 16 chars (#58221)
Describe minimum password length of 16 chars under master_auth. If password is shorter an error message is shown when running ansible-playbook.
2019-06-27 09:36:49 -05:00
f6490422d9 Send logout to ZabbixAPI before exit (#58393) 2019-06-27 09:42:34 -04:00
a688d2ee39 Update team_vmware (#58407)
Remove dav1x from team_vmware per their request in IRC
2019-06-27 07:45:24 +05:30
c9d82024c7 shared image gallery modules (#57386)
* modules to handle shared image gallery

* update test

* and firewall update

* fixed gallery problems

* fixed gallery version

* fix

* several fixes to the gallery

* several fixes

* fixes

* fix non-updatable

* fixed test & image

* fixed idempotency

* fix test

* image version test fixed

* fixes

* changed ux

* trigger

* fix syntax

* fixed sanity

* updated module + test delete

* fixed some sanity & delete

* continue fixing sanity

* sanity fix and pause after deleting image version

* extended delay

* removed sanity ignore

* try to ignore errors

* repeat until successful

* more retries

* updated test, etc.

* updated test

* updated shared image gallery docs
2019-06-26 17:15:55 -07:00
eda5dd826f Add rds_snapshot module (#39994)
* new module uses modern ansible AWS standards
* adds additional tests for snapshots
* Update return_skeleton_generator for python3 - should
  set type to `str`, not `string`.
2019-06-26 16:27:11 -07:00
f109184753 Recognize module tracebacks on stdout and stderr.
Module tracebacks may be reported on stdout instead of stderr when
using some connection plugins. For example, the ssh connection plugin
will report tracebacks on stdout due to use of the -tt option.

This change results in tracebacks being recognized on both stdout
and stderr, instead of the previous behavior of just stderr.

ci_complete
2019-06-26 15:45:46 -07:00
11e2ac3abf Encoding fixes to support py2 and py3 non-ascii paths (#58414)
* Encoding fixes to support py2 and py3 non-ascii paths

* Remove unused import

* endswith instead of comparing slice on bytes

* join bytes, convert to to_native after

Co-Authored-By: Toshio Kuratomi <a.badger@gmail.com>

* Fix review comments

* Add missing comma

* Encoding fixes to support py2 and py3 non-ascii paths

* Use ascii encoding on paths added to the archive also
2019-06-26 15:16:07 -07:00
1a9b1d0edd Fix unhandled errors in command module 2019-06-26 14:58:05 -07:00
911a2ec6d3 Make nuage_vspk test more reliable
- don't background the nuage-vsd-sim
- increase the asncy timeout
- use uri to actually query the simulator API to make sure it is ready for connections
2019-06-26 14:32:23 -07:00
cc7556fb7f Disable podman_container test. 2019-06-26 14:21:11 -07:00
d4f0bc183e removes last :doc: links in user guide (#58433)
* removes last :doc: links in user guide
2019-06-26 17:07:27 -04:00
9ba7015458 podman_image_info - Do not fail when nonexistant image name is provided (#57962)
* Account for older versions of Podman lacking 'exists'
2019-06-26 17:04:26 -04:00
3fc0694ffc removes last :doc: links in the dev guide (#58417) 2019-06-26 14:59:33 -04:00
edcb5b6775 dms_replication_subnet_group (#56980
* dms_replication_subnet_group implementation
2019-06-26 10:04:27 -07:00
bc3c90f2f1 datadog_monitor: Fix docs with datatypes of params (#58371)
* datadog_monitor: Fix docs with datatypes of params

Fixes: #58342

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* indentation and other minor fixes
2019-06-26 11:21:41 -05:00
db0fe4b188 Fix netconf connection command timeout issue (#58322)
*  ncclient uses same timeout value at the time
   of connection initialisation and waiting response
*  Ansible has connect_timeout to control the waiting
   time during initial connection and `command_timeout`
   to control the wait time for resposne. Hence set the
   ncclient timeout seperately to Ansible command_timeout
   after the connection object is created sucessfully.
2019-06-26 11:53:06 -04:00
4591a300ae Update sanity test ignore for hostname module. 2019-06-26 08:41:04 -07:00
4613c74074 Update documentation for aci_interface_policy_cdp (#58395)
* Update documentation for aci_interface_policy_cdp

##### SUMMARY
Documentation only changes. Improved the examples and changed the `version_added` from 2.8 to 2.9.

* Update lib/ansible/modules/network/aci/aci_interface_policy_cdp.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Converted from mixed indentation to spaces
2019-06-26 10:16:23 -05:00
db689f7221 Fix ovsdb module not being idempotent (#57735)
openvswitch_db was not parsing properly some arguments, which caused
some commands to be executed when they shouldn't. This commit fixesit
and adds unit testing for the usecase.

Closes-Bug: #55432
Closes-bug: #43858
2019-06-26 10:48:46 -04:00
4f78573a99 Added 'use' option to hostname (#56679)
* Added 'use' option to hostname

  fixes #25543
2019-06-26 10:39:28 -04:00
b5ac9f5cf1 routeros_command: support spaces in device identity (#58328) 2019-06-26 19:50:23 +05:30
88c0907fed rabbitmq_user: Handle non-zero exit codes (#56164) (#57738)
When provided with a wrong password `rabbitmqctl
authenticate_user` returns a non-zero exit code
(65). This seems to be unexpected by the module and
it fails when `update_password` is set to 'always'.

To mitigate this behavior we augment the `_exec`
method by adding a `check_rc` flag (which defaults
to `True`, hence it's backward-compatible) and
override it when we need it (in `check_password`
method to address #56164).
2019-06-26 14:40:17 +02:00
f2cc447b4d dnsimple: fix missing defaults and doc (#58116)
* dnsimple: fix missing defaults and doc

* fix sanity
2019-06-26 13:21:13 +02:00
7d6f417f32 Multiple minor fixes (#58374)
* Documentation update
* Typo fixes
* fail_json fixes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-26 04:55:44 -04:00
77e01e6abc tower_role: ensure alias of "validate_certs" parameter is handled (#57518)
* tower_role: ensure alias of validate_certs is handled

* tower modules: remove tower_verify_ssl alias too

Error was:

    Failed to update role: The Tower server claims it was sent a bad request.
    GET https://tower/api/v2/projects/22/object_roles/
    Params: [('tower_verify_ssl', False), ('role_field', 'admin_role')]
    Data: None
    Response: {"detail": "Role has no field named 'tower_verify_ssl'"}

Full traceback:

    File "/tmp/ansible_tower_role_payload_7_2p0X/__main__.py", line 145, in main
      result = role.grant(**params)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 365, in grant
      return self.role_write(fail_on_found=fail_on_found, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 242, in role_write
      fail_on_multiple_results=True, **data)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/models/base.py", line 301, in read
      r = client.get(url, params=params)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 546, in get
      return self.request('GET', url, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/api.py", line 299, in request
      kwargs.get('data', None), r.content.decode('utf8'))
2019-06-26 10:04:49 +02:00
5e4f457a47 Fix incorrect assumptions in integration tests. (#58372)
* Fix service integration test.

Set the proper file mode when copying before asserting the mode is correct.

* Fix certificate_complete_chain test.

Do not assume that testhost is the same as localhost.
2019-06-25 22:56:59 -07:00
46214c9ef4 Replaces #16690 (#58369)
Adding integration tests for testing the 'mode' arg of the apt_repository module
2019-06-25 20:23:38 -07:00
d5542afd97 Properly enforce shebang on collections. 2019-06-25 19:21:05 -07:00
013b0039ba Fix incorrect assumptions in integration tests. (#58365)
* Fix nested template test.

There were two issues with the previous implementation:

1. The LOGNAME environment variable may not be set.
2. The comparison assumed that testhost is localhost.

* Fix variable display for cartesian lookup test.

* Fix vars list test.

The test assumed that the ansible_user variable is always set,
which is not guaranteed when using connections other than local.

* Fix supervisorctl integration test.

Use ansible_user_id instead of ansible_user since ansible_user
is not guaranteed to be available when the connection is not local.

* Fix file integration test.

Use ansible_user_id instead of ansible_user since ansible_user
is not guaranteed to be available when the connection is not local.

* Fix expect integration test.

Do not assume module_utils is available for utility scripts.

* Fix python_requirements_info integration test.

Check for pip instead of ansible, since ansible is not guaranteed
to be installed when using a connection other than local.

* Fix ansible-runner integration test.

Use implicit localhost to run the test since it requires access
to the ansible installation currently being tested.

* Fix tower_common integration test.

Accept errors on stdout or stderr.

* Fix tower_user integration test.

Recognize errors on stdout or stderr.
2019-06-25 18:39:41 -07:00
c604e347b2 Skip podman_container integration tests @ RHEL8b (#58363) 2019-06-25 17:39:30 -07:00
f01468a9d9 Add podman container module to ansible
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2019-06-26 02:05:25 +02:00
65b0e1425b win_pagefile - Fix idempotency when same settings as current (#57893)
* win_pagefile - Fix idempotency when same settings as current

* Fix tests and code

* Fix problem with system managed

* Fix again systemmanaged detection

* Change check of systemmanged in creation

* Fix readability and wrong flag for test
2019-06-25 13:19:59 -07:00
5e2451c1a8 Update net_interface.py (#58350)
typo in example command -- net_interface module accidentally listed as junos_interface
2019-06-25 14:37:37 -05:00
360a9f1a68 exoscale: exo_dns: fix sanity checks (#58312) 2019-06-25 21:20:41 +02:00
7fd10d821c Add service_account_contents parameter to allign with the modules (#57848) 2019-06-25 14:40:10 -04:00
0a5a74f192 Install hidden galaxy data files (e.g. .travis.yml) (#56005)
The package_data globs in setup.py were missing the necessary glob
to install:

galaxy/data/default/.travis.yml

A Python glob pattern will not by default match a hidden file
(i.e. a file basename beginning with a dot). If you want a glob
to pick up a hidden file in a directory you must explicitly specify
a glob pattern with "/.*".

Closes: #1777
Signed-off-by: John Dennis <jdennis@redhat.com>
2019-06-25 11:28:51 -07:00
42a831d42c Update azure_rm_sqlserver related document (#58267)
* Update azure_rm_sqlserver related documentation
2019-06-25 11:33:12 -05:00
bb2c7cf57d Update azure_rm_sqlfirewallrule related document (#58265)
* Update azure_rm_sqlfirewallrule related documentation
2019-06-25 11:32:11 -05:00
e32d60bbcd Add back _contains_vars method as maybe_template (#58290)
* Add back _contains_vars method as maybe_template. Fixes #58282

* Remove template guard in a few places

* maybe_template sounds like it might template something, rename to is_possibly_template

* Add tests for is_possibly_template
2019-06-25 10:54:37 -05:00
f5b9bd81fc gather_facts is core (#58341) 2019-06-25 10:36:00 -05:00
bc25ac20e1 Set _ansible_verbose_override in gather_facts action plugin. Fixes #58310 (#58339) 2019-06-25 10:28:09 -05:00
18d713e6d5 Use Mapping rather than dict when evaluation 'options' (#58215) 2019-06-25 10:17:44 -05:00
9069a681aa sysctl: fix 'err' referenced before assignment (#58161)
* sysctl: fix 'err' referenced before assignment

Fixes #58158

* Add changelog
2019-06-25 11:13:34 -04:00
a09aa205e1 Fix RDS test suite and minor bugs revealed (#57940)
* Update testing policy to be correct for RDS test suite
* Create read replica in same region to avoid more permissions being
  required
* Ensure modifying DB doesn't try to downgrade engine version
* Add tags to main test suite to limit number of tests run for problem
  solving
2019-06-25 09:54:03 -04:00
48af9bdfec Adds tls_version argument to mqtt module (#58264)
Fixes: #22034

This patch adds support for a tls_version parameter that allows the
TLS version used to be configurable. By default the module will let
the underlying system libraries pick the maximum supported version.

This parameter is useful for servers that are unable to support
newer versions of TLS
2019-06-25 15:27:32 +02:00
ac101f7f33 adds initial_hotfix parameter to vcmp guest (#58180) 2019-06-25 15:26:09 +02:00
d591014163 fixes an issue where rule_lists were not correctly applied to the AFM policy (#58181) 2019-06-25 15:25:22 +02:00
d50ee592d0 kubevirt: Add hostname and subdomain parameters (#57223) 2019-06-25 15:19:27 +02:00
lju
60378e991b Fix ec2.py dynamic inventory script when pulling down RDS cluster information (#48075)
* Fixes #26481

* Pass lint tests
2019-06-25 20:48:26 +10:00
fcc32bcf0e Fix junos netconf plugin get_configuration filter (#58271)
* junos `get_configuration` netconf api expects the
  filter as instance of ElementTree object
2019-06-25 16:00:56 +05:30
896b84bfbe VMware: Python3 migrations for vmware_inventory.py (#47538)
* Sort and pretty print json output and cache file
* Enable Python3 test for vmware_inventory.py

Fixes: #46727

Signed-off-by: Rowin Andruscavage <8740187+MTN-RowinAndruscavage@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-25 15:40:13 +05:30
06292566ec kubevirt: more unit tests (#57739)
* Add tests for KubeAPIVersion

* Legibility improvements for KubevirtVM tests

* Create units.utils.kubevirt with common stuff

* Add some VMIRS unit tests
2019-06-25 20:06:13 +10:00
cf528c562a postgresql_membership: remove debug print (#58315) 2019-06-25 13:42:11 +05:30
307a7c5853 This comment is no longer needed, as the calculation is done in the 'grow' method (#58109) 2019-06-25 03:55:01 -04:00
8555b728c3 also allow None Type for safe eval (#58269) 2019-06-24 17:05:18 -04:00
f749ef5c0a Remove existing invalid ignores. 2019-06-24 13:13:32 -07:00
535e646a66 Add test for invalid ignore entries. 2019-06-24 13:13:32 -07:00
547a29805e openssh_keypair: bugfix make regenerating keypairs via force possible… (#57801)
* openssh_keypair: bugfix make regenerating keypairs via force possible / add invalid file handling

* openssh_keypair: change permissions of read-only file instead of deleting it for regeneration; add changelog fragment

* address review feedbak, refactor

* add integration tests for bigfixes

* linter: fix indent

* fixup integration tests: use force when regenerating an invalid file

* linter: fix indent

* openssh_keypair: address review feedback

* openssh_keypair: fixup, remove backtick

* openssh_keypair: address review feedback

* Only pass 'y' into stdin of ssh-keygen when file exists.
2019-06-24 21:45:49 +02:00
b78d23d4ad Use newer test container. 2019-06-24 12:32:57 -07:00
57d8b68c03 Use to_text on value to activate _fail_with_undefined_error (#58214)
* Use to_text on value to activate _fail_with_undefined_error. Fixes #12186

* Add comment explaining in depth what to_text gives us
2019-06-24 12:43:18 -05:00
958f740cc3 fixed reference to a non-existing hcloud_server parameter (#57659) 2019-06-24 13:20:55 -04:00
2e1392eff8 ipaddr: unit tests for empty string (#58274)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-24 18:47:46 +02:00
5569135efd create scenario guide template file (#58212)
* create scenario guide template file

* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-06-24 11:35:37 -05:00
4d357ffca5 kubevirt: replace nested function with one from utils
Use dict_transformations.dict_merge() in kubevirt's merge_dicts()
2019-06-24 09:26:00 -07:00
23fcae7c9e Fix issue with displaying error about unreachable hosts when using Unixy Callback (#58076) 2019-06-24 11:58:04 -04:00
4376e88849 Coherence between example and text (use of to_native) (#58279) 2019-06-24 09:47:19 -05:00
67c251d13c Fix junos modules persistent connection check (#57986)
Fixes #57985

*  The check `USE_PERSISTENT_CONNECTION` flag is no longer
   required in action plugin as the junos modules in galaxy are renamed
   to start with `juniper_`.
2019-06-24 19:24:20 +05:30
278c59b17e postgresql_privs: bugfix of 27327 - incorrect views handling (#58272) 2019-06-24 18:08:12 +05:30
f94da94e62 ovirt add nic linked (#58053)
* ovirt add nic linked

* add version added

* update check method
2019-06-24 07:51:27 -04:00
fc1798cc14 Pluribus Networks ipv6security raguard module with UT (#57031)
* Pluribus Networks ipv6security raguard module with UT
* Doc fixes
2019-06-24 16:29:41 +05:30
94fe139f04 Revert "Fix junos module transport check (#58050)" (#58270)
This reverts commit f864f621d8.
2019-06-24 15:18:17 +05:30
44058e9425 Allow multiple databases(not all) to be dumped from mysql (#56721)
* Allow multiple databases(not all) to be dumped from mysql

Fixes: #56059

* Altered fail message to provide atleast one database name

* Minor grammatical fix
2019-06-24 09:29:18 +02:00
372b896ed1 win_snmp: Fixed example documentation (#58222) (#58261) 2019-06-24 08:00:18 +01:00
75ca8eb42f openssl_certificate: fix failing SAN comparisons (#58256)
* Fix failing SAN comparison for older cryptography versions due to not implemented __hashh__ functions.

* Fix SAN comparison: IPv6 addresses need to be normalized before comparing strings.

* Add changelog.

* Fix comment.
2019-06-24 06:34:12 +02:00
73dc4d7e97 Move changelog entry to fragment directory (#58065)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-24 09:35:20 +05:30
66a4000058 Adjust tests to new error messages for older docker-py versions. (#58253) 2019-06-23 21:52:24 +02:00
808cf4aa26 Remove from sanity ignores. (#57911) 2019-06-23 14:20:26 +02:00
4a12be31fb docker_* modules: improve error message when docker-py is missing (#57914)
* Improve error for docker modules when docker-py can't be imported.

* Add changelog.

* Mention platform and Python interpreter in more cases.

* Clarify wording.

* Adjust tests.
2019-06-23 06:27:33 -04:00
64c3b4fbb5 New HTTPAPI plugin for FortiOS (#56870)
* New HTTPAPI plugin for FortiOS

* Remove special char

* Updates after review - Comments from Qalthos
2019-06-22 19:31:21 -04:00
fbdf6e59f2 Fix ansible-vault cipher_whitelist (#57272)
* Fix ansible-vault cipher_whitelist Fixes: #57271

* Add changelog for #57272
2019-06-22 11:14:37 -04:00
de03c007bc BIGIP: fixes issue with image installation on multiblade platforms (#58176)
* fixes issue with image installation on multiblade platforms

* test
2019-06-21 17:12:30 -07:00
30ada17d4f Adds message routing transport module (#58201) 2019-06-21 12:58:02 -07:00
b8fd2f4df3 adds generic routing peer module (#58189) 2019-06-21 12:56:25 -07:00
429bf5340e adds module for message routing protocol (#58188) 2019-06-21 12:56:03 -07:00
0a3a94a493 adds new module to manage firewall schedules (#58187) 2019-06-21 12:55:50 -07:00
92a1e6845c Adds two modules to manage AFM log profiles (#58186) 2019-06-21 12:55:37 -07:00
db81b1d0f5 prepapre_vmware_tests: add a common vars file
Add a new file to record the variables that are shared with the two
scenarios (real_lab and vcsim).

The goal is to reduce the the amount of boilerplate configuration from
a user perspective.
2019-06-21 14:35:44 -04:00
927c59fb9f updating botmeta (#58167)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-21 14:33:03 -04:00
eb7e4591ae Fix ios test for python2 non-ascii paths 2019-06-21 11:32:28 -07:00
bd55617a5b hostname - Correct distribution for various Linux distros based on output from distro library (#56936)
* Adjust hostname classes based on output from distro

Corrects the following:
- OpenSUSE Leap
- ArchARM
- Oracle Linux

* Add CoreOS and Clear Linux distributions
2019-06-21 14:29:41 -04:00
d010510835 Remove more usage of pause with junos tests (#58153)
This removes more potential race conditions with junos testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-21 14:07:25 -04:00
1539e0e855 a doc fix for azure_rm_virtualmachinescaleset (#56448) 2019-06-21 12:12:26 -04:00
fbca93b8ad removes args from the code and corrects few missed tests (#58175) 2019-06-21 09:09:39 -07:00
56b3b1ac56 adds message routing router module (#58191) 2019-06-21 09:09:14 -07:00
c1f2df4753 adds message routing route module (#58190) 2019-06-21 09:08:56 -07:00
57596edcca Updated the playbooks_tags guide (#58011)
* Updated the playbooks_tags guide
2019-06-21 12:06:23 -04:00
7d4e3af11e Add Python 3 support to ovirt4 inventory script. (#57824)
Python 3 only allows strings through the config parser. This is fine for 
the URL, Username, and Password since these values are required. The CA 
File is optional so an empty string is used in leiu of None in the 
config dictionary.
2019-06-21 12:05:45 -04:00
b86c7759c5 Update Documentation mso_schema_template_bd.py (#58020)
* Update mso_schema_template_bd.py
2019-06-21 12:04:38 -04:00
1b7ef47776 Update azure_rm_securitygroup related document (#58035)
* Update azure_rm_securitygroup related document
2019-06-21 12:00:18 -04:00
1c49a9110a Update azure_rm_servicebus related document (#58105)
* Update azure_rm_servicebus related document
2019-06-21 11:59:07 -04:00
7e70184f10 Update azure_rm_servicebusqueue related document (#58160)
* Update azure_rm_servicebus related document
2019-06-21 11:55:09 -04:00
af000444d2 Update azure_rm_sqldatabase related document (#58163) 2019-06-21 11:53:51 -04:00
200eed6177 Implement display_ok_hosts and display_skipped_hosts for unixy (#53179)
* Implement display_ok_hosts and display_skipped_hosts like default callback

* Implement show_custom_stats and display_failed_stderr like default callback

* Fix pep8

* Clarify conditional

* Changelog fragment

* Import from defaults.py per feedback
2019-06-21 11:22:16 -04:00
7b9d991f78 Add Fedora 30 to test matrix (#57713)
Remove Fedora 28 from test matrix
2019-06-21 10:55:58 -04:00
95e59e7ee7 adds description to bigip snatpool (#58179) 2019-06-21 07:52:46 -07:00
655ad7456d adds multiple new parameters to bigip_profile_http (#58183) 2019-06-21 07:16:47 -07:00
022b5d8b79 adds support for IPV4 addressing for interfaces (#58182) 2019-06-21 07:16:31 -07:00
66c828d45f adds new parameters to tcp profile module (#58185)
minor fix in policy module
2019-06-21 07:07:48 -07:00
07fc880b3c minor fixes in two modules (#58178) 2019-06-21 07:07:17 -07:00
3531bf3148 fixes issue with ssl protocols ordering (#58177) 2019-06-21 06:46:53 -07:00
cee3d539cb Fixes issue with failure messages (#58173) 2019-06-21 06:45:57 -07:00
becca36c5e Added new module for remote user management (#58171) 2019-06-21 06:45:29 -07:00
e7c39460ed ipaddr: Handle ipaddress index in network correctly (#57896)
This commit prevents integer indices from being parsed as ip nets

Fixes #57895

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
2019-06-21 15:26:08 +02:00
0f12e1c7d8 Meraki - Improve type information in module documentation (#58114)
* Improve type information in module documentation
- Removed some duplicate documentation
- Ensure org_id is always string
- Add type information for items which don't have it

* Fix whitespace
2019-06-21 09:25:03 -04:00
dc8f7b38e6 Check that provider['options'] is a dictionary in validate-modules (#58078) 2019-06-21 08:39:12 -04:00
58d446e61a PR to fix where ansible_net_model was not being populated (#58159)
* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-21 16:18:59 +05:30
43872d6b88 Fix netconf guess_network_os to use ssh_config if supplied. (#55199)
* feature: use network_os=auto to trigger network os guessing

* doc: add debug messages

* fix linting

* fix test_netconf_init default network_os is auto

* add documentation

* fix rst errors

* use init lexer

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-06-21 09:04:13 +05:30
f864f621d8 Fix junos module transport check (#58050)
*  Since new junos resource modules will
   support only network_cli connection type
   modify the transport check from network_cli
   connection netconf as netconf only supported modules
   is a fronzen set.
2019-06-21 08:56:52 +05:30
28b67d809f Bug fixes for GCP modules (#58107) 2019-06-20 20:51:43 -04:00
ddf6d096c5 Support the new TLS termination on NLBs (#51327) (#58031) 2019-06-20 17:03:04 -07:00
b9d77b997e passwordstore lookup - replace expired GPG key (#58141)
- Replace private key that expired an 2019-06-20 with a key that does not expire
- Document how to generate a new GPG key using an input file
2019-06-20 18:03:22 -04:00
f8f2738351 docker_*: make modules more robust on Docker errors (#57913)
* Improve general error behavior if a Docker error is not caught.

* Don't die when network doesn't exist.

* Add changelog.

* Make API version always available. Also catch errors when retrieving version.

* Fix error message.

* Adjust fallback error messages.
2019-06-20 16:59:15 -04:00
122d4164c5 docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end
2019-06-20 15:58:32 -04:00
4188cd299b crypto modules: Improve requirements / error messages (#57868)
* Reformat requirements.

* Include Python lib versions in lib required error messages, if available.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>

* Add changelog.
2019-06-20 21:31:00 +02:00
4ae99ab34f revert #57246 (#58134)
* per gregdek/mckerr
2019-06-20 11:53:53 -07:00
320d05dc30 tower_workflow_template: Add missing options (#56891)
The following options can be set on a workflow template but the
functionallity to do so from this module was missing.

inventory
ask_variables_on_launch
ask_inventory_on_launch

Fixes #49728

Signed-off-by: Alberto Murillo <albertomurillosilva@gmail.com>
2019-06-20 13:55:37 -04:00
9dbc838d99 Add rudimentary wait for os_zone (#54391)
This adds a rudimentary wait functionality for the os_zone module.

It will wait for:
* Zone not in OpenStack API when choosing `absent`
* Zone `status` being `AVAILABLE` in OpenStack when choosing `present`
2019-06-20 13:00:57 -04:00
d0ee6e1e54 Implement protected parameter (#54114)
* Implement protected parameter

* version_added field

* Remove point at at the end of the sentence

* Update version_added to 2.9
2019-06-20 12:47:18 -04:00
2f70c90efd Update apt.py (#56479)
* Update apt.py

Tested under Debian 9 with installation of Apache2 and PostgreSQL
In both cases the daemons are started immediately upon installation

https://www.alextomkins.com/2018/03/runlevel-apt-get-install-package-alternative/
https://major.io/2014/06/26/install-debian-packages-without-starting-daemons/
2019-06-20 12:10:28 -04:00
bdb089b910 Update sysctl.py (#57984)
##### SUMMARY
Quote values to mitigate this ansible warning:

+label: docsite_pr
2019-06-20 11:46:25 -04:00
67e02b5eee Corrected module example in documentation (#58124) 2019-06-20 11:37:05 -04:00
77b6255305 PR to fix ios bgp TC failure (#58010)
* fix ios bgp tc failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-20 17:09:31 +02:00
2b5ad94a96 vmware_guest_disk_facts: return controller_bus_number and controller_type (#58117)
Fixes: #57608
Fixes: #57998
2019-06-20 20:07:17 +05:30
ffd117132f Create new instance of the action plugin per until iteration. Fixes #57886 (#58022) 2019-06-20 09:17:50 -05:00
375ac76e58 ssh: Ensure debug messages are properly converted to text (#57850)
* ssh: Ensure debug messages are properly converted to text. Fixes #57843

* surrogate_then_replace is default, be less explicit

* We only needed to_text for display, not exceptions
2019-06-20 09:15:53 -05:00
3a3465c47d Add the way to create a VM with the image id (#58106) 2019-06-20 16:42:09 +08:00
cc7bea2100 plugins/connection/netconf: remove unimplemented option (#58104)
closes #51972
2019-06-20 12:07:10 +05:30
8c1c2afd02 docker_container: Change expected config source (#57969)
* Change expected config source

* make it conditional

* rename property

* Add changelog fragment

* make it string

* Update changelogs/fragments/57969-docker_container-change-expected-config-source.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-19 23:32:59 +02:00
f3720c90e0 [WIP] Add dropdown version selection to docsite (#55655)
* docs: Add way to select version for documentation
2019-06-19 14:39:45 -05:00
8b6c6cf302 Bug fixes for GCP modules (#58041) 2019-06-19 14:20:43 -04:00
18feeb51a8 Change integration tests in order to pass on Fedora 30 (#58081)
* Use different package for DNF tests
    Ninja caused errors in Fedora 30. This works in both Fedora 29 and 30.

* Fix git integration tests
    Git >= 2.21.0 has either a bug or change in behavior where it errors when fetching a
    repository containing submodules that are behind the upstream submodule commits.
    It's weird and I don't fully understand it.

    Get around this my checking out specific commits from a repository rather than
    switch the origin URL.

* Fix PostgreSQL tests
    The error message is slightly different
2019-06-19 12:38:05 -04:00
bdd0bbf50a [nxos] New parameter vrf in nxos_file_copy (#57851)
* [nxos] New parameter vrf in nxos_file_copy

* Fix version_added

* Fix documentation default value
2019-06-19 21:26:07 +05:30
52c811c841 nxos_bgp_neighbor: Add bfd support (#56932)
* nxos_bgp_neighbor: Add bfd support

- Add support for bfd state in nxos_bgp_neighbor

- Feature Pull Request

- nxos_bgp_neighbor

- Tested on platforms: `N3K,N6K,N7K,N9K`

* bfd T/F now bfd enable/disable

* pep fix ws
2019-06-19 21:23:00 +05:30
727a6b405a nxos_ospf_vrf: Add 'bfd' support (#57425)
* nxos_ospf_vrf: Add 'bfd' support

* Add default to bfd doc hdr

* bfd T/F now bfd enable/disable
2019-06-19 21:22:32 +05:30
30830a4482 nxos_pim: Add bfd support (#56908)
* nxos_pim: Add bfd support

* Add integration sanity

* minor cleanup

* bfd T/F now bfd enable/disable
2019-06-19 21:22:03 +05:30
12d656901f Add CmdRef logic to handle multiples (#57495)
* Add CmdRef logic to handle multiples

* Fix python 2.6 issues

* Fix bug when existing is not a dict object

* Fix python2 vs python3 incompatibilty

* Ignore unnecessary-lambda warning
2019-06-19 21:15:32 +05:30
8f68c8d438 meraki_snmp - Enable check mode (#54625)
* Add support for check mode

* Add diff support

* Remove check mode for idempotent action
2019-06-19 11:35:10 -04:00
8cff96e388 Update azure_rm_roledefinition related document (#57927)
* Update azure_rm_roledefinition related documentation
2019-06-19 09:27:30 -05:00
f656959861 Fix RESTCONF media types (#58015)
Fixes #56680
2019-06-19 10:22:24 -04:00
64d0559e9f Postgres module_utils: add get_connect_params + unit tests (#58067)
* add get_conn_params

* add get_conn_params: add to the modules
2019-06-19 06:49:19 -07:00
6bace8aa54 vultr: vultr_account_facts -> info (#57563) 2019-06-19 14:10:55 +02:00
ee32222ae7 fixing vmss failure (#56625)
* triggering test

* deleting autocreated as last one

* fixed mistake
2019-06-19 05:00:43 -04:00
ec95086b69 add support for https (#57785) 2019-06-19 15:14:53 +08:00
3d452fb917 Update azure_rm_aks.py (#57898) 2019-06-19 15:13:16 +08:00
c609fad106 Ovirt vnic profile fix (#57936)
* ovirt vnic profile fix init

* ovirt vnic profile fix init

* update syntax whitespace

* document pass_through

* create get entity method

* update example syntax

* update docs

* change force_create style
2019-06-18 21:46:41 -04:00
Rob
feae35ab7e add IAM role assumption to aws_ec2 inventory (#41637)
* add IAM role assumption to aws_ec2 inventory
* Ensure inventory._options has necessary option keys populated since the plugin docs parser isn't accessible to unit tests yet
2019-06-18 15:34:41 -07:00
751134ff17 Clearer examples of hosts.yml inventory (#57999)
* Clearer examples of hosts.yml inventory
2019-06-18 15:58:28 -05:00
8646b6953d updated zabbix modules to use missing_required_lib helper (#58002) 2019-06-18 16:57:09 -04:00
446027341a Update playbooks_strategies.rst (#57784)
* Update playbooks_strategies.rst

##### SUMMARY
This page is very confusing and may suggest, that there is still a `serial` strategy (like it used to), but now it is just a directive of `linear` strategy. Multiple people reported this to me and it needs change.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Update docs/docsite/rst/user_guide/playbooks_strategies.rst

Co-Authored-By: Sam Doran <sdoran@redhat.com>

* Update docs/docsite/rst/user_guide/playbooks_strategies.rst

Co-Authored-By: Sam Doran <sdoran@redhat.com>

* Updates strategies page more broadly

* incorporate samdoran feedback

* fixes broken link

* new page title, focus on user intent

* more sdoran feedback

* adds details on setting the number of forks
2019-06-18 16:52:01 -04:00
7765bd41e6 add platform docs to network dev guide (#57960)
* add info on how to create platform docs to network dev guide
2019-06-18 15:35:09 -05:00
186210af8a postgresql modules: remove unused imports, remove blank lines after docstrings 2019-06-18 12:55:32 -07:00
7733dcabd3 Bug fixes for GCP modules (#57826) 2019-06-18 15:47:21 -04:00
a1128b6b94 Bug fixes for GCP modules (#58016) 2019-06-18 15:45:47 -04:00
158f97bfb2 updates docs reqs to specify Pygments version, remove tornado (#58007) 2019-06-18 14:24:57 -04:00
b4d4f77963 Ovirt add managed storage domain (#57995)
* init managed storage domain

* add version added

* add no log for sensitive options

* add driver default types

* update docs

* update pep8 syntax

* update example syntax

* update example syntax

* set default domain_fucntion for managed_block_storage

* correct pep8 syntax

* update managed example

* update managed docs
2019-06-18 14:05:48 -04:00
b768a0780c Update playbooks_vault.rst (#58005)
Corrected the internal reference link to point to the FAQ entry.

+label: docsite_pr
2019-06-18 11:23:30 -05:00
c87dbed20f Ovirt nic default vnic (#57945)
* default vnic init

* ovirt default nic

* add spacing

* use network must be specified

* Update ovirt_nic.py

* Update ovirt_nic.py

* add no vnic profile exception

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax
2019-06-18 12:16:45 -04:00
505c99265c docsite: remove lexers which have been fixed in Pygments 2.4.0 (#57508)
* Remove lexers which have been fixed in Pygments 2.4.0.
* Add Pygments >= 2.4.0 to test runner.
* Fix pages that triggered lexer errors.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-06-18 10:56:33 -05:00
cae6304356 add a member to team_mysql (#57987) 2019-06-18 11:43:34 -04:00
fe8a3108a8 Fix error when a deprecated alias of a deprecated module is processed. (#57774) 2019-06-18 10:22:19 -05:00
cc00f21a35 Fix issue in netconf plugin dispatch for junos and iosxr (#57981)
*  If case xml reply is transformed or namespace is removed in ncclient
   device specific handler return modified xml response as string

*  If data xml node is present in xml response return the xml string
   with data node as root node

*  If none above is true return raw xml string received from host
   with rpc-reply as the root node
2019-06-18 10:36:03 -04:00
21a95c0a16 Update azure_rm_route related document (#57928)
* Update docs for azure_rm_route, azure_rm_routetable, and azure_rm_routetable_facts
2019-06-18 09:19:52 -05:00
2bdc4e5b4a Documentation error in the Test if a list contains a value section (#57923)
* Update docs/docsite/rst/user_guide/playbooks_tests.rst - 'contains' test works with 'select/reject' and 'selectattr/rejectattr' but not 'map'
2019-06-18 09:15:09 -05:00
d4555cbd45 Examples on how to remove files and directories (#57766)
* Docs: file module - adds examples on how to remove files and directories
2019-06-18 09:07:31 -05:00
8dfa376e1c removes link from 404 content, explains options (#57971) 2019-06-18 09:25:12 -04:00
8dc51dfe1c Remove pause logic form junos_netconf tests (#57966)
We can switch to wait_for / meta, as using pause can lead to race
conditions on slower / faster hardware.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-18 08:31:05 -04:00
ec7b18952b gitlab_runner: Fix idempotency when creating runner (#57833) 2019-06-18 13:12:12 +02:00
81f0b70f11 junos_netconf: fix check mode, fixes #57929 (#57930) 2019-06-18 15:11:15 +05:30
d24e9ab4bb meraki_content_filtering - Add support for querying (#57273)
* Added querying functionality

* Fix PEP8 and documentation

* Increment version added

* Fix version info
2019-06-18 14:52:46 +05:30
a66687f2d2 rds_instance: allow empty iops and storage_type (#57943) 2019-06-18 07:56:01 +02:00
c58b715f82 hwc_network_vpc: fix typo (#57977) 2019-06-18 07:42:37 +02:00
40540f4d98 Fix changelog entry (#57979) 2019-06-18 15:37:34 +10:00
d63ccb5bc8 fix 57447 bug (#57938)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-18 10:09:43 +05:30
a82156a63f Updated Notes section of the meta (#57921)
Docs: note that 'meta` tasks are handled differently internally than 'normal tasks' so looping on meta tasks is not supported.
2019-06-17 16:33:06 -05:00
f56cf72e2b ufw: remove from sanity ignores (#57910)
* Remove from pylint ignore list.

* Make sure that option is called the same as in the documentation.
2019-06-17 22:57:55 +02:00
0cf6a418ab Correcting the documentation for win_package return value[log] (#57854)
* correcting the documentaiton for log return value

* grammar change
2019-06-18 06:56:57 +10:00
da6f6cc456 Fix missing doc type. (#57884) 2019-06-17 15:52:08 -05:00
eed7a338a0 aws: Fix typo in deprecation warning (#57946)
Changed "ec2_instance_information" to "ec2_instance_info" in deprecation warning.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 16:32:00 -04:00
1a63f8642e Update local module options (#57553)
* Docs: Point out that local plugins can be loaded based on ansible.cfg settings
2019-06-17 15:22:50 -05:00
9364b4c933 better metadata formatting on gcp_compute (#57778) 2019-06-17 16:10:27 -04:00
6e89fbe58a Update azure_rm_networkinterface related document (#57454)
* Update azure_rm_networkinterface related document
* fixes errors with plural nouns, typos, uses single quotes for version_added
2019-06-17 14:38:57 -05:00
e834cd7d41 updates reqs for building docs locally (#57967) 2019-06-17 15:32:01 -04:00
66728cb93f win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test
2019-06-18 05:25:38 +10:00
acc01f1109 Win_copy: doc fix when using become (#57690)
* win_copy: doc update

* Community review
2019-06-17 13:55:29 -05:00
924352a051 ecs_cluster test suite refactor (#57716)
* Combine testing policies

Because of the maximum of 10 policies per group, need to
consolidate testing policies as best we can.

* Tidy put-account-setting tasks and add permission

Using `environment` and `command` rather than `shell` avoids the
need for `no_log` and means that people can fix the problem

* refactor ecs_cluster test suite

move from runme.sh technique to virtualenv

use ec2_instance rather than ec2 module to
avoid need for boto
2019-06-17 11:41:20 -07:00
7751e97e1e Bug fixes for GCP modules (#57883) 2019-06-17 13:40:04 -04:00
5658b2ee3e Adds custom 404 with cowsay image (#57422)
* Adds custom 404 with image, updates CI reqs, sets version latest for TOC links on 404 page
2019-06-17 10:47:54 -05:00
fa738613dc Revert "Fix iosxr discard_changes netconf rpc issue (#57931)" (#57954)
This actually broken junos netconf_rpc, and was merged without properly
testing.

This reverts commit 795cb90367.
2019-06-17 11:45:30 -04:00
d40c44bd56 Fix python3 encoding with iosxr_config (#57919)
Python3 requires bytes when writing files.

Depends-On: https://github.com/ansible/ansible/pull/57909/
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 17:42:29 +02:00
5b8236132c properly tag become plugins (#57861)
* properly tag become plugins

* sdf
2019-06-17 10:39:03 -05:00
4a3e14f90b More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test
2019-06-17 17:22:46 +02:00
a096fa5c12 filter bare variable with |bool (deprecation warn) (#57691)
* filter bare variable with |bool (deprecation warn)

https://github.com/ansible/ansible/pull/57691#issuecomment-502134480
2019-06-17 10:53:30 -04:00
b51a614341 Add core lookups to botmeta (#57866) 2019-06-17 09:30:47 -05:00
795cb90367 Fix iosxr discard_changes netconf rpc issue (#57931)
* If dispatch() rpc response has data element
return the xml string from <data> element
else return the complete xml string from
<rpc-reply>.

Depends-On: #57909
Depends-On: #57919
2019-06-17 16:22:23 +05:30
cf623fa62f Terraform: Fix unbound local error (#57044)
* Added Unit tests
* Fixed regression

Fixes: #56934

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 08:23:59 +05:30
9e225fbb1e zabbix: New module zabbix mediatype (#57488)
Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>
2019-06-16 23:16:58 +02:00
7f536630eb Use wait_for in prepare_junos_tests.yaml (#57073)
This should reduce the amount of time we are waiting for netconf to come
online.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-16 16:03:55 -04:00
d0c4914469 win_shell - fix space escaping for custom executable (#57455) 2019-06-17 05:14:58 +10:00
0f2903780b purestorage: Add module to set MOTD banner text for Pure Storage FlashArray (#57500) 2019-06-16 09:43:51 +02:00
6b16be638d VMware: add facts about tags in vmware_host_facts (#56837)
Fixes: #46461

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-16 09:02:26 +05:30
7910361b52 Fix failed mounts in podman connector and handle errors (#57741)
Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.
2019-06-15 07:35:55 -04:00
0d2ffdd5a6 Fix iosxr netconf integration test (#57882)
* Modify testcase to work with Zuul CI enviornment
2019-06-15 16:58:09 +05:30
597d943dad Remove needs/ssh alias from callback_default test.
The test does not require ssh.
2019-06-14 14:49:03 -07:00
37ea47c848 Fix python injection when using a virtualenv. 2019-06-14 14:27:07 -07:00
84075fe351 Change RHEL8 image name to match changes in ansible-test (#57807)
* Change RHEL8 image name to match changes in ansible-test

Continue to use the beta version of RHEL 8 until we fix tests that are breaking with the GA version.

* Skip ufw integration test on RHEL 8 Beta
2019-06-14 13:47:26 -07:00
4f61654fc5 Change default test container to version 1.8.1 2019-06-14 13:44:29 -07:00
019a48361b Update azure_rm_resourcegroup related document (#57819)
* Update azure_rm_resourcegroup related document

* resolve shippable error
2019-06-14 15:34:20 -04:00
23eb465956 Update azure_rm_roleassignment related document (#57820)
* Update azure_rm_roleassignment related document

* add new
2019-06-14 15:27:06 -04:00
49983fdaf7 doc draft for collections (#57853)
* doc draft for collections

* fixes

* Update docs/docsite/rst/collections_tech_preview.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/collections_tech_preview.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Apply suggestions from doc review

* Update docs/docsite/rst/collections_tech_preview.rst

* Update docs/docsite/rst/collections_tech_preview.rst
2019-06-14 15:07:30 -04:00
342d77b32d removal of chdir in controller (#57781)
* removal of chdir in controller

also ensure fetch/put uses relative to task cwd
2019-06-14 13:45:41 -04:00
de87b25a45 show host_vars/ also in --graph (#56307)
* show host_vars/ also in --graph

  fixes #53422
2019-06-14 13:40:22 -04:00
e9c83b7a17 gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248
2019-06-14 12:55:22 -04:00
3fb4c91d4c validate-modules: ignore existing E337/E338 errors 2019-06-14 08:36:24 -07:00
c289006e05 validate-modules: new module: fail if 'type' isn't documented
Don't require 'type' when:
- parameter name starts with an underscore
2019-06-14 08:36:24 -07:00
8d635a82a4 Update azure_rm_publicipaddress related document (#57669)
* Update azure_rm_publicipaddress related document
2019-06-14 10:43:06 -04:00
78f87f2451 Updated "Speeding up Vault Operations" section (#57701)
* Updated "Speeding up Vault Operations" section


Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-06-14 10:17:40 -04:00
aeb72dfb06 Update azure_rm_resource related document (#57786)
* Update azure_rm_resource related document

* resolve shippable check error

* Resolve format error

* resolve format error---02

* Redefine the type variable
2019-06-14 10:13:32 -04:00
1903aced79 Update azure_rm_rediscache related document (#57721)
* Update azure_rm_rediscache related document

* Update according by comment
2019-06-14 10:06:18 -04:00
b9c893ec6f Updated the section under "Aborting the play" in the Error Handling In Playbooks page (#57705)
* Updated the section under "Aborting the play"

Updated "Aborting the play" section in the Error Handling In Playbooks page. Removed the reference to marking all hosts as failed.

+label: docsite_pr

* Update docs/docsite/rst/user_guide/playbooks_error_handling.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-06-14 10:04:05 -04:00
88a1fc28d8 Clean up iosxr get_config_diff function (#57589)
This fixes an index error issue when running tests on zuul.ansible.com
for iosxr. We can fix this by getting the last element in the list.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-14 15:06:21 +05:30
af25274d6a Remove backup from iosxr replace_config test (#57830)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-06-14 14:11:19 +05:30
6e8fcbf8c9 Adding idrac_pwd alias to modules (#57733) 2019-06-14 01:43:21 -04:00
71a704cc14 netbox: inventory: fix implementation of groups option (#57689) 2019-06-14 06:29:46 +02:00
7d85cbcc6c vmware: test-suite fixes
Minor fixes for the test-suite found during the integration with the CI.
2019-06-13 20:23:33 -04:00
33d0d36eaa AWS: Fix KeyError in aws_secret lookup (#54792) 2019-06-13 17:11:44 -07:00
7ce85ee9e8 vcenter test provider handle config vars handling (#57813)
Make vcenter test provider handle config file vars the same regardless of
whether it comes from static config or from worldstream provisioning
2019-06-13 16:48:35 -07:00
e7bf46d8bc Adds visibility parameter to gitlab group creation (#57024) 2019-06-13 18:40:14 -04:00
138f0e875a Bug fixes for GCP modules (#57724) 2019-06-13 18:25:57 -04:00
a58088f661 Bug fixes for GCP modules (#57725) 2019-06-13 18:25:46 -04:00
365d1dde25 Bug fixes for GCP modules (#57726) 2019-06-13 18:25:35 -04:00
366a9784ac Bug fixes for GCP modules (#57727) 2019-06-13 18:25:23 -04:00
ab0a548b0c Bug fixes for GCP modules (#57728) 2019-06-13 18:25:11 -04:00
625ef22dd9 New Module: gcp_tpu_node (#57729) 2019-06-13 18:25:00 -04:00
61ff61cdf6 Tests as filters were deprecated, remove unused param (#57796) 2019-06-13 15:36:52 -04:00
1d6d19f400 New Module: gcp_tpu_node_facts (#57730) 2019-06-13 15:11:46 -04:00
a85750dc98 Meraki - Convert response keys to snake_case from camelCase (#53891)
* Initial proposal for new parameter option for response format
- output_version parameter dictates the response key case
- new is snake_case, old is camelCase
- If new, conversion is done at the end of module execution
- This is purely a proposal and not a final draft

* Add support for ANSIBLE_MERAKI_FORMAT env var
- If env var is set to 'camelcase' it will output camelcase
- Otherwise, will default to snakecase
- Added note to documentation fragment
- As of now, all module documentation needs to be updated

* Fix pep8 errors and remove output_version args

* Restructure check in exit_json so it actually works

* Add changelog fragment

* Change output_format to a parameter with env var fallback
- ANSIBLE_MERAKI_FORMAT is the valid env var
- Added documentation

* Convert to camel_dict_to_snake_dict() which is from Ansible
- Fixed integration tests

* Fix yaml lint error

* exit_json camel_case conversion handles no data
- exit_json would fail if data wasn't provided
- Updated 3 integration tests for new naming convention

* convert_camel_to_snake() handles lists and dicts
- The native Ansible method doesn't handle first level lists
- convert_camel_to_snake() acts simply as a wrapper for the method
- There maybe a situation where nested lists are a problem, must test
- Fixed integration tests in some modules

* A few integration test fixes

* Convert response documentation to snake case
2019-06-13 15:07:30 -04:00
5243cba0b2 describe how to link to modules or plugins (#57806) 2019-06-13 12:52:40 -05:00
e264b4126f Update gcp_storage_object.py (#57802)
"name: ansible-storage-module" removed as name is not defined as parameter  


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-13 13:16:07 -04:00
231f4cfcf1 Fix example in vmware_drs_group module (#57805)
Signed-off-by: Harald Albers <github@albersweb.de>
2019-06-13 13:12:59 -04:00
99fd7821b3 Split azure_rm_virtualmachine integration tests to prevent timeouts (#57250) 2019-06-13 08:48:55 -07:00
d2dc4c9bc4 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-06-13 11:17:23 -04:00
3efb57f64e Typo (#57795) 2019-06-13 10:27:23 -04:00
1a5fd720a4 Ansible galaxy role download should not have to perform aditionnal check against tar archive file extension #56616. (#56617)
Ansible galaxy role download checked for `.tar.gz`, but `tarfile.is_tarfile(...)` can identify and open any valid tarfile. This change uses transparent stream compression to make `.tar.gz` and `.tar.bz2` formats valid with python 2.6.x/2.7.x (as well as `.tar.xz` with python 3.x).
2019-06-13 09:23:41 -05:00
6131de29d4 Improve regex_replace filter docs (#57450)
* Add a few examples of how to correctly use `regex_replace` filter
because it behaves differently on different Python versions when using
regex qualifiers that can match an empty string (e.g. '*', '?', etc).
2019-06-13 09:12:12 -05:00
d33ee72085 os_ironic_node: avoid set_node_instance_info and purge_node_instance_info (#54463)
These openstacksdk calls are awkward special-case wrappers around
patch_machine, and I would like to deprecate them in openstacksdk change
https://review.openstack.org/647730. Use much simpler update_machine instead.
2019-06-13 09:08:24 -04:00
886f4c66ca kubevirt: Add affinity parameters (#57359) 2019-06-13 12:25:30 +02:00
f7de9cb39f ovirt host facts fix (#57790) 2019-06-13 06:12:54 -04:00
51add5aa79 kubevirt: enable/update tests + fix merge_dicts() (#57685)
* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code
2019-06-13 11:07:16 +02:00
00604d3f2c VMware: Fix vmware_guest_move undefined VM name error (#57582)
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-13 13:07:26 +05:30
5143f52def vultr: vultr_ssh_key_facts -> info (#57571)
* vultr: deprecate vultr_ssh_key_facts

* vultr: rename tests

* vultr: adjust tests

* vultr: new vultr_ssh_key_info module

* vultr: test: vultr_ssh_key_info: improve tests

* update docs
2019-06-13 07:05:00 +02:00
8e9f29c40c Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables
2019-06-12 17:36:57 -04:00
73a16749cb Enable adjacent collections for ansible-doc (#57764)
* enable adjacent collections for ansible-doc
2019-06-12 17:10:17 -04:00
1d76635206 Remove required field on service_account_file in gcp_compute plugin inventory (#57345) 2019-06-12 16:51:57 -04:00
f6a0f9874d Improve speed of the gpc_compute dynamic inventory (#57591)
To get all instances gcp_compute made a call to the Google API for each
zone separately. Because of this if all zones needed to be queried
fetching hosts lasted 30+ seconds. Now the module will use a single
query that will return all the instances, so the execution should last
just a few seconds.

This commit also suppresses a warning from the google-auth library about
using user credentials because if an Ansible user wants to use user
credentials, there is no need to warn him about it.
2019-06-12 16:38:48 -04:00
4bf051b8bb redfish: fix a problem with Chassis/Power URI (#56185)
Fixes #56137 - problem with Chassis/Power URI and GetChassisPower command - assemble URI from data in Chassis resource
2019-06-12 20:40:30 +02:00
00691f43c5 Default become plugins to core support (#57771)
* Default become plugins to core support

* s/cache/become
2019-06-12 12:47:56 -05:00
5bddd55703 update vxlan (#57264)
* update vxlan

* add a changelog fragment for the PR 57264

* Update 57264-update-vxlan-to-fix-bugs.yml

update for change request

* Update ce_vxlan_vap.py

remove commented codes.
2019-06-12 13:00:55 -04:00
e009936f87 update acl (#57268) 2019-06-12 12:58:15 -04:00
6d21cebd7d Avi credentials added sub-options (#57531)
* Split Avi Credentials into two parts - secrets and login_info

* Fixed indentation issue

* Removed trailing whitespaces

* Added sub-options to avi credentials

* Added sub-options to avi credentials

* Updated argument specs to use fallback instead of getting defaults from environment variable
2019-06-12 12:19:29 -04:00
5ac3661176 update snmp modules to fix bugs for cloudengine (#57025)
* update snmp modules to fix bugs for cloudengine

* update snmp modules to fix bugs for cloudengine

* update "ce_snmp_contact", list may be out range
2019-06-12 11:27:21 -04:00
17c475b101 meraki_ssid - Improve change reporting (#56201)
* Improve change reporting for meraki_ssid
- Documentation is more clear about dependencies
- Not all change reports are accurate without new algorithm
- Improved integration tests

* Rename changelog fragment

* Enable all tests in integration tests
- Fix type merging

* Add more integration tests for code coverage

* Update URL creation
2019-06-12 11:06:00 -04:00
1fa7bfcd5d Fix --diff to produce output when creating a new file (#57744)
* Fix --diff to produce output when creating a new file

Fixes #57618

* Make the check more defensive
2019-06-12 10:56:14 -04:00
d07d394779 Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix
2019-06-12 10:45:20 -04:00
a50b3d7695 meraki_syslog - Module properly handles net_id parameter (#57286) 2019-06-12 10:44:05 -04:00
87169c4aa4 meraki_vlan - Enable check mode (#54627)
* Add support for check mode

* Add diff support
- diff support is based on "have" and "want" data structures.
- Review needs to be done on the diffs for accuracy and usefulness.
- Changed change mode changed responses to be accurate.

* Remove config template based integration tests
2019-06-12 10:43:02 -04:00
b13e5242e0 meraki_mr_l3_firewall - Fix integration test cleanup (#57562) 2019-06-12 10:28:09 -04:00
77ec0549b0 New module for AWS CodeBuild (#47187)
* New AWS module for the CodeBuild service, called aws_codebuild

* Integration test for new aws_codebuild module
2019-06-12 10:25:53 -04:00
83bf90e02f Fixes #55476 (#57715)
* fixes bug introduced by commit 8cb73720f0599b08794cb7a3fbdf36d430214446: "TypeError: argument of type 'NoneType' is not iterable" when using module systemd without param 'name' (e.g. with daemon_reload)
2019-06-12 09:50:32 -04:00
793c18506a lvg: fix default value type, should be str (#57723) 2019-06-12 14:52:43 +02:00
33a26d31fd New module for AWS CodePipeline (#47189)
* New module for AWS CodePipeline

* Added integration test for new aws_codepipeline module
2019-06-12 08:50:09 -04:00
4052d6d294 set ovirt disk active default (#57464)
* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs
2019-06-12 12:32:58 +02:00
6537d1bc0f vmware_host_ipv6: only changed when changed (#57702)
Do not return the `changed` status when a reboot is required. The
configuration is applied and so the configuration changed has already been
done.
2019-06-12 14:20:18 +05:30
166a5c909c ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
2019-06-12 04:41:51 -04:00
69ead0ba78 puppet: new arg to toggle no-/use_srv_records flag (#53095) 2019-06-12 10:02:58 +02:00
205f6b1699 nxos_pim_interface: Add 'bfd' support (#57133)
* nxos_pim_interface: Add 'bfd' support

* PEP fixes

* fix copyright date

* bfd states changed from T/F to enable/disable/default
2019-06-12 09:47:41 +05:30
7880be240f Remove usage of global var log_path for win_domain_* modules (#57092)
* Remove usage of global var log_path

* Add changelog and edit ignore.txt

* win_pagefile: not using testPath

* Revert "win_pagefile: not using testPath"

This reverts commit c8bc10234048257414454905e1c860a8f57a3b3f.

* PSLint error

* Update win_domain_membership.ps1

* Update win_domain_controller.ps1
2019-06-12 05:31:19 +10:00
d2909d5ef0 win_scheduled_task: Fix start/end boundry triggers to allow for timezone sync (#57282)
* Fix 49327

* Add a test

* Join test

* Test issue

* Fix missed assertion
2019-06-12 05:27:51 +10:00
1b5975f17e Fixes #54550 (#56279)
* "setup.ps1" - Change $env:COMPUTERNAME to [System.Net.Dns]::GetHostName(), to support non NETBIOS compliant hostnames

* Change method to base on WMI

* changed ansible_domain to use WMI

* Fixed per review

* Fixed dot stuff

* Revert "Fixed dot stuff"

This reverts commit a1d5be00f1.

* dot stuff

* dot stuff 2.0

* Update setup.ps1

* Wrap this up to go
2019-06-12 05:25:38 +10:00
6c23a8df66 VMware: Restrict vcenter_folder for vCenter
Folder creation API is only supported by vCenter, specifying
Standalone ESXi system will raise error.
This fix adds an user warning for suggesting this restriction.

Fixes: #49938

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-11 14:51:38 -04:00
31bec0dd95 Bug fixes for GCP modules (#57152) 2019-06-11 13:53:42 -04:00
087f560b7c Bug fixes for GCP modules (#57260) 2019-06-11 13:53:27 -04:00
142598972d Bug fixes for GCP modules (#57261) 2019-06-11 13:53:13 -04:00
ecbd1173b9 New Module: gcp_cloudscheduler_job (#57262) 2019-06-11 13:52:56 -04:00
fcff70f887 New Module: gcp_cloudscheduler_job_facts (#57263) 2019-06-11 13:52:41 -04:00
c06f890f55 add docs for vlan_parser filter (#57498) 2019-06-11 11:22:02 -05:00
e8948f7655 Actually run valid_include_keywords test (#57687) 2019-06-11 18:21:28 +02:00
8c6356326a add plugins/connection/buildah.py to botmeta (#57700)
* add plugins/connection/buildah.py to botmeta

* add podman to botmeta
2019-06-11 11:00:33 -05:00
20ec5e66e1 Fixed heading link password field in user module (#57694)
##### SUMMARY
In the [user module](https://docs.ansible.com/ansible/latest/modules/user_module.html#user-module), the password field links to `https://docs.ansible.com/ansible/faq.html#how-do-i-generate-crypted-passwords-for-the-user-module`, but the actual link is `https://docs.ansible.com/ansible/faq.html#how-do-i-generate-encrypted-passwords-for-the-user-module` as it was modified in d27d956d71

So I corrected the link in the user module to the actual link. 

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-11 11:38:30 -04:00
aba06b893b Add proxy vars to vcenter integration test config 2019-06-11 11:26:52 -04:00
1035a9aa49 kubevirt_pvc: fix parameter priority (#57617) 2019-06-11 11:03:32 -04:00
07e1bd8fe7 Fix ios_smoke failure (#57665)
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-11 10:52:54 -04:00
98da0e6c99 Bug Fixes for na_ontap_interface (#57363)
* bug fixes

* bug fix
2019-06-11 16:26:39 +02:00
e80d6f18ce Duplicate rules were being created if rule index was not set (#57379)
* bug fixes

* Revert "bug fixes"

This reverts commit 2d839ecf35.

* bug fix
2019-06-11 16:26:02 +02:00
c4f336081e fix tower_credential example: lookup are run on controller (#57516)
- don't advise to use lookups in order to fetch path on managed nodes
- fix example:
    - use slurp instead 'file' lookup
    - remove extraneous brackets
2019-06-11 10:25:39 -04:00
a25acbbf83 postgresql_idx: self.__exec_sql -> module_utils.postgres.exec_sql (#57684)
* postgresql_idx: self.__exec_sql -> module_utils.postgres.exec_sql

* postgresql_idx: exec_sql, added a changelog fragment

* postgresql_idx: exec_sql, fix the changelog fragment
2019-06-11 10:07:03 -04:00
aa3b2c47f1 Update azure_rm_virtualmachine.py (#57125)
Docs: Add resource_group values in examples of:
- Power On
- Restart
2019-06-11 08:54:29 -05:00
2013d4abc4 Update setup-iam playbook to use aws_caller_info rather than deprecated (#57675)
aws_caller_facts
2019-06-11 09:23:56 -04:00
a8ebbecd53 postgresql modules: use postgres.exec_sql instead of __exec_sql methods (#57674)
* postgresql modules: use postgres.exec_sql instead of __exec_sql methods

* postgresql modules: use exec_sql, added changelog fragment

* Update changelogs/fragments/57674-postgres_modules_use_exec_sql_instead_of_methods.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-11 13:42:53 +02:00
f80ac73316 postgresql_idx: add docstrings, remove extra doc lines (#57670) 2019-06-11 06:20:26 -04:00
bab1a3ceda PR to introduce cp_network and cp_publish as modules (#57621)
* network and install policy modules for example

network and install policy modules for example

* revert the changes in version

revert the changes in version

* documentation_fragment

documentation_fragment

* Checking the status code of the set request

* delete some of Rikis' files

* retrieve Rikis' files and call equals API method

* adding blanck line between functions

* implement host, address-range and group

* mostly sintax fixes

* try again with the old host and access rule

* small changes

* adding service udp and publish

* publish command

* little fix

* choises for state parameter

* support wait_for_task and API version

* imports

* refactor of function's name

* network module

* rename modules and return value from modules

* PR before examples to: tests, lookup, check_mode

* small fixes

* fixes for code review

* small fixes

* state parameter in examples and many /n

* white spaces

* 4 tries for how choices should be, and turn true to True
2019-06-11 12:27:03 +05:30
8c3382ec70 vultr: vultr_os_facts -> info (#57565)
* vultr: vultr_os_facts: rename to info

* vultr: vultr_os_facts: rename tests to info

* vultr: adjust tests

* vultr: new vultr_os_info module
2019-06-11 07:51:24 +02:00
0ca50c7d6f vultr: vultr_user_facts -> info (#57564)
* vultr: deprecate vultr_user_facts

* vultr: vultr_user_facts: rename to info

* vultr: adjust tests

* vultr: new vultr_user_info module
2019-06-11 07:49:24 +02:00
f7e5494a67 Small grammar error (#57654) 2019-06-10 23:32:19 +02:00
a87495d07c win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog
2019-06-10 17:07:10 -04:00
1ed7a654ba Improve testing of FactCache (#55739)
* Improve testing of FactCache
2019-06-10 16:26:24 -04:00
a8e133105c win_domain_group_membership: Fix missing @extra_vars on Get-ADObject to support different domain and credentials for retrieval (#57429)
* win_domain_group_membership - Fix missing @extra_vars on Get-ADObject to support dirrent domain and credentials for retrival

* win_domain_group_membership - Fix missing extra_vars on Get-ADObject
2019-06-11 06:26:01 +10:00
13f73adef5 AWS: _facts -> _info (part 4) (#57651)
* Rename ec2_vpc_dhcp_option_facts -> ec2_vpc_dhcp_option_info.

* Rename ec2_vpc_endpoint_facts -> ec2_vpc_endpoint_info.

* Rename ec2_vpc_igw_facts -> ec2_vpc_igw_info.

* Rename ec2_vpc_nacl_facts -> ec2_vpc_nacl_info.

* Rename ec2_vpc_nat_gateway_facts -> ec2_vpc_nat_gateway_info.

* Rename ec2_vpc_net_facts -> ec2_vpc_net_info.

* Rename ec2_vpc_peering_facts -> ec2_vpc_peering_info.

* Rename ec2_vpc_route_table_facts -> ec2_vpc_route_table_info.

* Rename ec2_vpc_subnet_facts -> ec2_vpc_subnet_info.

* Rename ec2_vpc_vgw_facts -> ec2_vpc_vgw_info.

* Rename ec2_vpc_vpn_facts -> ec2_vpc_vpn_info.

* Update module defaults, add changelog and porting guide.

* Update BOTMETA.
2019-06-10 21:40:05 +02:00
598a058afe [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog
2019-06-10 14:34:06 -04:00
1e6edf2ccc Limit tests to paramiko < 2.5.0. 2019-06-10 10:56:11 -07:00
804d5eaf8e AWS: _facts -> _info (part 3) (#57635)
* Rename ec2_ami_facts -> ec2_ami_info.

* Rename ec2_asg_facts -> ec2_asg_info.

* Rename ec2_customer_gateway_facts -> ec2_customer_gateway_info.

* Rename ec2_eip_facts -> ec2_eip_info.

* Rename ec2_elb_facts -> ec2_elb_info.

* Rename ec2_eni_facts -> ec2_eni_info.

* Rename ec2_group_facts -> ec2_group_info.

* Rename ec2_instance_facts -> ec2_instance_info.

* Rename ec2_lc_facts -> ec2_lc_info.

* Rename ec2_placement_group_facts -> ec2_placement_group_info.

* Rename ec2_snapshot_facts -> ec2_snapshot_info.

* Rename ec2_vol_facts -> ec2_vol_info.

* Update module defaults, add changelog and porting guide.

* Forgot one occurence of ec2_instance_facts.

* Update BOTMETA.

* Break too long line.
2019-06-10 19:33:38 +02:00
1d054a6671 clarifies docs while we await rds_snapshot module 2019-06-10 12:51:51 -04:00
822f82468d aws: Add suggestion about rds_instance in rds
rds_instance is boto3 based module, add a note in rds module documentation
about the same.

Fixes: #54686

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-10 12:51:51 -04:00
fc4bbff6e1 AWS: _facts -> _info (part 2) (#57626)
* Rename cloudwatchlogs_log_group_facts -> cloudwatchlogs_log_group_info.

* Rename elasticache_facts -> elasticache_info.

* redshift_facts -> redshift_info.

* Rename route53_facts -> route53_info.

* Rename rds_instance_facts -> rds_instance_info.

* Rename rds_snapshot_facts -> rds_snapshot_info.

* Rename iam_mfa_device_facts -> iam_mfa_device_info.

* Rename iam_role_facts -> iam_role_info.

* Rename iam_server_certificate_facts -> iam_server_certificate_info.

* Rename elb_application_lb_facts -> elb_application_lb_info.

* Renaming elb_classic_lb_facts -> elb_classic_lb_info.

* elb_target_facts -> elb_target_info.

* Rename elb_target_group_facts -> elb_target_group_info.

* Update porting guide.

* Add changelog.

* Fix module defaults (both for this PR and #57613).

* Two fixes.
2019-06-10 17:48:07 +02:00
3bee49a3bb Remove trailing new line while including vars (#57605)
While including var files using _raw_params adds additional new line
character, which makes Ansible to fail to include that file in.
This fix removes extraneous new line character while parsing the var file.

Fixes: #57593

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-10 11:23:38 -04:00
7cf0d82108 Update azure_rm_postgresqldatabase related document (#57458) 2019-06-10 10:02:42 -05:00
433e00c219 Clarify documentation on dockerfile. (#57570) 2019-06-10 10:42:59 -04:00
6cd2543a2b Update azure_rm_postgresqlconfiguration related document (#57596) 2019-06-10 09:21:53 -05:00
c3ca3757c9 Provide a better error when python-dnf install fails (#57622) 2019-06-10 09:21:41 -05:00
2575f0e39b Update azure_rm_postgresqlfirewallrule related document (#57598) 2019-06-10 09:20:42 -05:00
74c21d40f9 Update azure_rm_postgresqlserver relate document (#57600) 2019-06-10 09:20:13 -05:00
f709d2e2bb Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: https://github.com/ansible/ansible/pull/57309
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-10 16:11:31 +02:00
a867ced4de Fix junos integration zuul CI failures (#57309) 2019-06-10 16:10:57 +02:00
51229eb99c AWS modules: _facts -> _info (#57613)
* Rename aws_acm_facts -> aws_acm_info.

* Rename aws_az_facts -> aws_az_info.

* Rename aws_caller_facts -> aws_caller_info.

* Rename aws_kms_facts -> aws_kms_info.

* Rename aws_region_facts -> aws_region_info.

* Rename aws_sgw_facts -> aws_sgw_info.

* Rename aws_waf_facts -> aws_waf_info.

* Adjust docs.

* Add changelog and update porting guide.
2019-06-10 15:52:49 +02:00
4fa93d5b9b FTD configuration module: fix a bug with response parsing (#57480)
* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message
2019-06-10 18:30:35 +05:30
039eb892ba Second batch for _facts -> _info rename (#57020)
* Second batch of _facts -> _info.

* Forgot one reference.
2019-06-10 13:04:07 +02:00
e25269e1b3 Adding dell ome device_info module (#53438)
* Adding device_facts module for contribution

* changes added for pylint error

* Updated code to solve ansible-test compile error

* Changes to avoide comile error added

* Review Comments changes update

* Avoided blank line

* pylint error changes

* Removed ansible_facts return in error case

* Updated description

* modules renamed

* changing from ansible_facts to device_info

* avoide pep8 error

* Updated sample output

* version changed to 2.9

* Changed Copyright license to BSD

* Changed 3-clause BSD license to 2-clause BSD

* Added unit test support for ome_device_info

* version change

* removed pylint error in unit test modules

* Avoid Sanity error for unit test modules

* updated version
2019-06-10 06:41:48 -04:00
ef2d70a806 Rename ali_instance_facts -> ali_instance_info (#57036)
* Rename ali_instance_facts -> ali_instance_info.

* Add changelog.
2019-06-10 12:40:50 +02:00
9ba3b01ef0 Extended cloudfront_facts module to have a predictable return value… (#49061)
* Extended cloudfront_facts module to have a predictable return value for getting results.

* Updated RETURN docs with new field.

* Corrected the RETURN docs

* Fix typo in YAML
2019-06-10 19:23:05 +10:00
ffa172e3a6 postgresql: moved function exec_sql from the modules to module_utils (#57603) 2019-06-10 11:15:07 +02:00
17c5e0e016 postgresql_tablespace: remove extra lines from the doc, add docstrings (#57534) 2019-06-10 13:57:08 +05:30
c5dc48de81 Ovirt add job (#55440)
* init ovirt_job module

* ovirt job add state finished

* redone logic in ovirt job

* ovirt jobs add docs

* ovirt job update docs

* update failed status

* ovirt job update return docs

* ovirt job update docs

* check if job and step has finished

* remove job status end
2019-06-10 09:56:09 +02:00
e5972ccbab redfish_command: Avoid power on/off commands if system already in target state (#56069)
* avoid power on/off commands if system already in target state

* add changelog fragment
2019-06-10 09:50:04 +02:00
d86183f595 tower_user: Fix to create a system auditor properly (#54585)
- Fixed issue #54446: tower_user cannot create an auditor user

Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-06-10 09:48:02 +02:00
7eae4761b8 redfish: Add MACAddress property to GetNicInventory (#56864)
* add MACAddress property to GetNicInventory

* add changelog fragment
2019-06-10 09:45:56 +02:00
9151f343da redfish: docs: Add type for options (#56809)
* add type: for options in docs for Redfish modules

* add changelog fragment
2019-06-10 09:27:52 +02:00
a58570f1bc na_ontap_snapshot_policy: Add ability to multiple schedules (#57366) 2019-06-10 09:24:25 +02:00
5cc6486a2b Merge authentication options back into a single field to prevent losing options beyond the first (#57507)
* Merge authentication options back into a single field to prevent losing options beyond the first

* Add integration test and changelog

* Fix multiple options for local type connections. Also fix sorting errors between local type connections that lack a src

* Build again because of github problems?

* Add spaces before comments
2019-06-10 09:16:01 +02:00
c001391555 vultr_server: implement support for IDs to match resources (#55762) 2019-06-09 13:34:25 +02:00
7f68ebeed3 purefa: New module purefa_arrayname (#57496) 2019-06-09 12:15:05 +02:00
c1e70660aa purefa: new module purefa_syslog (#57486) 2019-06-09 12:10:04 +02:00
96b88b0510 purefa: Add module to enable or disable arrays phonehome capability (#57506) 2019-06-09 10:27:05 +02:00
30c9322e99 Fix idempotency issue when updating host object in FlashArray (#55347) 2019-06-08 14:11:10 -04:00
c50a75a41e acme_*: new test container, tests for IP certificates (#57530)
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.
2019-06-08 14:02:44 +02:00
9d67f476e6 acme_certificate: fix docs (#57557)
* Fix indentation.

* Forgot when condition for second acme_certificate call.
2019-06-08 02:11:58 -04:00
be84cada09 Upgrade tests to use default-test-container 1.8.0.
ci_complete
2019-06-07 18:42:30 -07:00
cd77ea3c7f File module - fix unicode paths and add a test (#57558)
* File module - Fix unicode paths

* Add a test for unicode paths for the file module
2019-06-07 21:27:38 -04:00
93a85b6c86 Additional rename fixes (#57527)
* adding symbolic link

* missing renames

* reverted version_added
2019-06-07 18:22:17 -07:00
8c631cbc0a Fix rds_instance module… (#56220)
* Fix rds_instance module to run against an (older) existing RDS instance successfully

* Only pop Iops param if no storage_type is given. If given and set to wrong type we get to the AWS client error that informs the user

* Docs syntax fix

* Fix typo in docs

Co-Authored-By: stefanhorning <stefan@hornings.de>
2019-06-07 20:32:49 -04:00
79685a4a2d Use Python 3.7 to run ansible-test coverage in CI. (#57555)
Generating XML for coverage reports on Python 3.7 uses far less
memory than on Python 2.7. This change should avoid the MemoryError
we've been seeing in the nightly coverage runs.
2019-06-07 15:48:17 -07:00
b211b24862 Move azure_rm_autoscale test from group 2 to 5. 2019-06-07 14:35:51 -07:00
1661c87bae Fix lack of support for Cumulus Linux with Hostname module in Ansible v2.8.0. (#57493) 2019-06-07 15:40:20 -04:00
7d9cac8e47 Fix azure_rm_virtualnetwork integration test.
Previously the test would fail when run after another test which also
created a virtual network tagged with the 'testing' tag.
2019-06-07 10:35:19 -07:00
76e06fa7c2 update vrf to fix bugs (#57270)
* update vrf

* update vrf
2019-06-07 13:03:53 -04:00
4dc6faea59 update info-center (#57269) 2019-06-07 13:02:06 -04:00
767e02f9fe Fix yamllint failure. 2019-06-07 09:58:48 -07:00
04bfcd08a8 PR to fix the IOS_NTP integration TC failure (#57481)
* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix for local connection

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-07 11:56:30 -04:00
91d326cb68 Update file.py's initial_diff() to list existing when state: absent (#56353) 2019-06-07 09:55:51 -04:00
fba67bbe53 Updated documentation for zabbix-screen module (#57325)
Updated module settings.
Do not check screens options because of module screens.
2019-06-07 13:36:25 +02:00
07d446825a New module postgresql_sequence (#55027)
* postgresql_sequence: initial commit with new module and tests

* change return variables and adjust tests

* fix sanity checks

* fix linter errors

* change formatting functions and put params alphabetically

* add new examples and remove restrict option
* remove restrict option
* remove `required: false`
* add links to documentation
* change some minor parts in documentation
* add new integration tests for
** drop cascade
** change owner

* change usage of owner and created a test case for set owner during creation

* remove some documents and use docsfragments

* add aliases for minvalue and maxvalue

* change to warn if sequence not exists but should be removed

* use connect_to_db from module_utils/postgres.py

* add checkmode for several tests

* fix psycopg2 import and connect_to_db

* add a test for drop nonexistent sequence

* change get_info funcrtion to use only one SQL statement

* rewrite the module for cleaner code
* remove psycopg2
* change check_mode behavior
* add docstrings for class and methods
* add test for create sequence with owner in check_mode

* fix typo in set_schema()

* fix docu and cleanup the code
* adjust documentation for state, schema and newschema
* remove mutually_exclusive for 'absent'
* remove unused code comments
* remove warning for drop non-exicsting sequence
* change autocommit condition

* adjust state documentation
2019-06-07 13:34:57 +02:00
03d64cd9ea Fix azure_rm_resourcegroup integration test. 2019-06-06 22:08:17 -07:00
bd844bc11c nxos_interface_ospf: Add bfd support (#56807)
* nxos_interface_ospf: Add bfd support

Add support for `bfd` state in `nxos_interface_ospf`

- Feature Pull Request

`nxos_interface_ospf`

* Fix pep issues

* sanity loop: syntax

* bfd states changed from T/F to enable/disable/default

* doc hdr fixes
2019-06-07 09:58:29 +05:30
b9a0086aac Fix RuntimeError on Python 3.8. 2019-06-06 18:35:07 -07:00
b2791718e5 Use bintray to install erlang for rabbitmq tests. 2019-06-06 17:05:13 -07:00
047fd3cfbc Revert "Disable the rabbitmq tests for now"
This reverts commit 5f47ab958f.
2019-06-06 17:05:13 -07:00
5f47ab958f Disable the rabbitmq tests for now
The erlang-solutions repository is broken for Ubuntu18 (They did not
sign their repository metadata).  For now, disable the rabbitmq tests
which depend upon that.  I'll open a PR with a revert of this commit.
We can watch it to see when it passes in Ci to know that the
erlang-soutions repository has been fixed
2019-06-06 15:11:48 -07:00
728fce0c44 Perf improvement for Templar.is_template (#57489)
* Faster is_template
2019-06-06 15:49:26 -04:00
95882faca6 Optimize the code for the callback module (#56827)
* Optimize the code for the callback module

* fix pep error

* Restore incorrectly submitted code

* fix pep error

* fix pep error

* Restore incorrectly submitted code

* Restore incorrectly submitted code

* fix condition

* fix condition

* fix pep error
2019-06-06 15:37:28 -04:00
b9b0b23015 safe_eval fix (#57188)
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests
2019-06-06 15:36:22 -04:00
99f9f49eca Correct grammar (#57385)
"it's" == "it is"
"its" == "belonging to it"
2019-06-06 15:05:01 -04:00
0dfc21c826 [elb_application_lb tests] narrow ami filter #43375 (#57432) 2019-06-06 13:58:18 -04:00
152202ceb0 add info about hwaddr conversion formats (#57491) 2019-06-06 12:56:10 -05:00
72297db686 Renames Digital Ocean cloud _facts modules to _info (#57315)
Fixes: #57276
2019-06-06 19:33:19 +02:00
bd48a7fb73 Implement a new module to support Batch Account (#55074)
* Implement a new module to support Batch Account.

* Fix the schema definition.

* Fix some lint errors.

* Normalize line endings.

* Remove not-recommended idempotency check.

* adding stubs for discussion

* Add one more output attribute.

* Leverage `idempotency_check` and `normalize_resource_id`.

* Fix line is too long error.

* normalize resource id implementation

* normalizing resource id fix indentation

* Fix linting issues.

* Fix runtime errors of Azure Python SDK.

* Add info module to Batch Account.

* Remove info module per suggestion.

* adding initial comparison function

* fix in idempotency check

* batch account update to support idempotence

* don't modify azure_rm_common for timebeing to avoid excessive ci

* adding first ci

* added more description on comparison function

* fixed storage account name

* fix

* fixed indent in common function + batch account name unpacking

* fix bug

* fixing sanity

* updated class relations

* fix in common

* updated disposition

* Add two more updatable/disposition in module_arg_spec

* updated common file

* Fix documentation for auto_storage_account.

* fixed line too long

* fixed keyvault reference

* fixed batch account creation

* fix pep8

* Regenerate code according to the feedbacks.

* test deleting batch account

* Add auto-generate comments to test file.

* renamed delete task, removed unstable

* clean up storage account
2019-06-06 09:10:01 -07:00
a87de8d7b0 flag added foy vyos_interface module (#57124)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-06-06 18:23:19 +05:30
ae5d3d76f6 ios_logging improvement (#57336)
* ios_logging: documentation update, add check for 'level' parameter

* ios_logging: add 'trap' destination
2019-06-06 16:52:31 +05:30
e0f6c17857 Fixed typo in task_executor (#57461)
Changed 'requied' to 'required'

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-06 12:27:18 +02:00
7aa0d26fda nxos_bfd_global / NxosCmdRef initial commit (#56317)
* nxos_bfd_global: initial commit

This is an initial POC with just a few commands included.  The code has been written somewhat generically so that it can act as a best practices template for re-use in future modules. The implementation follows the yaml cmd_ref style to define each command's getter/setter/type/default. It supports platform-specific defaults.

The basic logic is to collect all relevant data in a `cmd_ref` dict and pass that around to various methods.

In the BFD case the devices don't provide JSON output so we have to screen-scrape with show runs.

BFD does not support present/absent states so there is no state param.

BFD has three different property types to handle. We can add add'l types as needed:

- int
- int_list (list of ints)
- str (needs support for 'no' keyword)

* Use get_capabilities to find platform type

* PR comment fixes, round 1

* Minor cleanups

* nxos_bfd_global: create NxosCmdRef in module_utils

This commit just takes the latest bfd global code and moves the bulk
of the code into new `class NxosCmdRef` in `module_utils/nxos/nxos.py`.

The only remaining code in `nxos_bfd_global.py` are the calls from `main()`.

* Add remaining command properties and documentation

* update argument_spec

* Add check for _exclude; add sanity test

* Add targets files for bfd

* Context and state absent updates

* Add dict support to cmd_ref

* Changed remaining list commands to dict usage

* Add idempotence check for dict

* Fix existing overwrite bug

* Move pattern matching logic into its own method

* add support for 'command: absent'

* Add `get_platform_shortname`; update BFD platform-specific settings

* /absent/deleted/

* /sh/show/ in prepare_nxos_tests

* add dict check to get_platform_shortname

* Add normalize_defaults()

* UTs for bfd_global

* support yaml for both py2/py3

* update cmd_ref doc header

* Fix python2.6 incompatibility with dict comprehensions

* Fix bfd_global doc header (yaml syntax fail)

* more shippable fixes

* yet more shippable fixes

* shippable: remove r' ' wrappers

* docfix - remove ':'

* escape regex ctl chars in yaml table

* remove extra blank lines

* Fix str(None) issue

* Command context updates

* import PY2,PY3 instead of import sys

* fix ordereddict import & parent_context

* try/except for yaml import

* fix import issue for ordereddict

* remove epdb

* nxosCmdRef_import_check() workaround for shippable

* fix PEP ws errors
2019-06-06 15:52:55 +05:30
f65ac2cf23 Add tests for #56147 (#57256)
Tests are separate for easier backporting
2019-06-06 10:59:19 +02:00
d88739367e ovirt: Resolve also list of hrefs (#57299) 2019-06-06 10:58:26 +02:00
6e94b472e8 Fix #56640: Map k8s ansible keys to api keys (#57418)
* Fix #56643: Map ansible keys to api keys

* Remove errant print line

* Fix pep8 issue

* Fix doc line

* Added test for validate_certs -> verify_ssl translation for k8s module
2019-06-06 18:51:23 +10:00
8a02901e5f ovirt vmpool fix (#57453) 2019-06-06 04:30:30 -04:00
6f06fc9945 openssh_keypair: make fingerprint result a string (#57295)
The extant documentation says that the fingerprint return value is a
single string, but it is currently being returned as a split list.
Convert the returned value to a string as documented, and add some
basic test-case coverage for the return values.
2019-06-06 07:58:50 +02:00
c6097a268c rename modules azure_rm_..._facts to azure_rm_..._info (#57395) 2019-06-06 12:10:27 +08:00
870d8bf10b Fix nxos_vtp_version test (#57358) 2019-06-06 09:35:29 +05:30
7c73dd3e78 nxos_install_os: Fix nxapi local failures (#55993)
* Fix nxapi failures

* Remove logit debug calls

* Remove msg_timestamps

* Fix code alignment issue
2019-06-06 09:35:08 +05:30
1dc3fe5317 Add new logging facilties defaults (#57144) 2019-06-06 09:34:30 +05:30
817ec5ab48 Add PyYAML check for libyaml support. 2019-06-05 15:20:47 -07:00
d758d5bab1 Disable code-smell tests on Python 2.6. 2019-06-05 15:20:47 -07:00
490edbdc48 Add python version checking when using --tox. 2019-06-05 15:20:47 -07:00
58f6604efa Support passing CFLAGS and LDFLAGS. 2019-06-05 15:20:47 -07:00
7a4dc4b1b0 Comment on OBJC_DISABLE_INITIALIZE_FORK_SAFETY. 2019-06-05 15:20:47 -07:00
d80ef9e64b Update typed-ast version to support Python 3.8. 2019-06-05 15:20:47 -07:00
d9fcf95758 Add missing Python 2.6 constraint for voluptuous. 2019-06-05 15:20:47 -07:00
14f8aa622e Add missing constraints for hcloud requirement. 2019-06-05 15:20:47 -07:00
1637aeea29 Make purefa_pgsnap module handle its own exit correctly (#56954) 2019-06-05 18:07:39 -04:00
a05be890ad Fix podman_image_info parsing of podman output.
Stripping the output from `podman image ls -q` prevents passing
a blank image ID to `podman image inspect`, which would fail.
2019-06-05 14:31:11 -07:00
3136007032 update docsite breadcrumbs from sphinx_rtd_theme (#57316)
* improve breadcrumbs
* get edit on github working again
2019-06-05 14:26:34 -05:00
96693600f9 2.9 roadmap dates (#57420)
* add dates to 2.9 roadmap, remove alpha phase
2019-06-05 14:25:43 -05:00
ea9a0f36f3 postgresql_table: 57352 bugfix, add schema handling (#57391)
* 57352 bugfix, add schema handling

* 57352 bugfix, added a changelog fragment

* 57352 bugfix, added tests for rename

* 57352 bugfix, fixed tests

* 57352 bugfix, fixed typos, cosmetic changes
2019-06-05 15:06:23 -04:00
7a3914bd8b Support --valid_pgpkeys option in Git module ()
PR #55396

Make Git module support `--valid-pgpkeys` option, which allows
configuring a list of valid PGP fingerprints which are compared with the
used PGP fingerprint if verify_commit is true. This requires
verify_commit to be set to 'yes'.

Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
2019-06-05 20:18:37 +02:00
05e6339c49 option is marked as required but specifies a default (#57257)
* required and default are conflicting
2019-06-05 10:43:45 -04:00
229d20b6d9 update ce_facts (#57187) 2019-06-05 10:42:13 -04:00
9c3ae4c1f4 update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)
* update lib/ansible/plugins/action/ce.py
2019-06-05 10:41:33 -04:00
919f70c357 New module - meraki_malware (#56929)
* Initial commit for meraki_malware module
- Allows for manipulation of malware configuration

* Add full documentation and improve code coverage

* Add diff support

* Type change

* Sanity check fixes

* Convert org_id from str to int for consistency

* Sanity fixes again

* Fix argument type errors

* Remove ignore items for some Meraki modules so shippable is happy
2019-06-05 10:36:39 -04:00
8bcf9b5734 meraki_network - Restructure execution logic (#56818)
* Restructure meraki_network to be simpler and work for all int tests

* Enable all integration tests and enhance error reports

* Slight tweaks to integration tests
2019-06-05 10:33:55 -04:00
091bebcbf7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.
2019-06-05 10:32:14 -04:00
72f2d05b6f meraki_content_filtering - Enable check mode (#54638)
* Add support for check mode.

* Add diff support
- Need to analyze diff for accuracy
- Updated check mode changed value

* Improve test coverage

* Remove a duplicate integration test
2019-06-05 10:31:50 -04:00
6da2d40500 meraki_admin - Enable check mode (#54499)
* Add support for check mode

* Add changelog fragment

* Add diff support
- Fix a few changed status
- Removed auth_key check since that's done in module_utils now
2019-06-05 10:23:54 -04:00
30aeab4709 Make aws_ses_identity module work when region is provided via environment or config. (#51627)
fixes #51531
2019-06-05 09:51:58 -04:00
46f8bd47ce file: return 'useful' error message for recursion error (#57222)
* file: return 'useful' error message for recursion error

Fixes #56397

* Fix line length

* Re-phrase the error message
2019-06-05 09:30:09 -04:00
18f2ed63e0 file: fix setting relative paths for src for hard links (#56055) 2019-06-05 15:26:40 +02:00
705d0201cf file: fix setting attributes for symlinked file (#57217) 2019-06-05 15:25:43 +02:00
206f18dcca Update azure_rm_mysqlserver related document (#57382) 2019-06-05 09:10:12 -04:00
9b6a295ca5 Update azure_rm_mysqlfirewallrule related document (#57384) 2019-06-05 09:08:53 -04:00
dfaa72297c Fix an RST link to the changelog config in docs 2019-06-05 15:08:09 +02:00
6e9eac74f0 ovirt vmpools creating vm options (#55815)
* ovirt vm pools add vm vars

* remove cloud init persist

* ovirt vm pools add nics

* ovirt vm pools add vm docs

* ovirt vm pools update docs

* ovirt vm pools update cloud_init docs

* update ovirt_vm_pools docs

* correct ovirt vm pools version_added
2019-06-05 03:27:27 -04:00
b5b75daaa5 win_chocolatey - honour version when bootstrapping chocolatey and fix package listing (#57208)
* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection
2019-06-05 09:10:10 +10:00
b1e6ad9754 Limit Python 2.6 units to modules & module_utils. (#57377) 2019-06-04 15:15:36 -07:00
1fb0335243 group_chars: default change warning only when needed 2019-06-04 14:04:17 -07:00
47cfbd6605 Add integration test provider for vmware (#55772)
* Add integration test provider for vmware

This change adds a new remote cloud provider option for vmware,
supporting dynamic environments running on worldstream.nl as well as
static environments specific by the user in a cloud-config template.
2019-06-04 13:49:30 -07:00
b8b0a2a20c aws: Update description for iam_role (#57346)
If IAM Role is created without description using aws cli or UI,
then Ansible failed to update description for such IAM role.
This fixes such condition.

Fixes: #52942

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 11:52:03 -07:00
57b3160f13 new feature (#57320) 2019-06-04 13:57:54 -04:00
dw
3fadf4a1cb Fix file descriptor leak in lineinfile module. (#57328) 2019-06-04 12:45:19 -04:00
256d1a9947 Add Chris Meyers to the tower team (#57349) 2019-06-04 11:59:50 -04:00
1ddb37cdc2 Update azure_rm_mariadbserver related document (#57333) 2019-06-04 11:41:26 -04:00
695cd7f1da VMware: Notify team_vmware on connection plugin issues and PRs (#57279)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 11:35:32 -04:00
22b45f2c06 Clarify description of 'state' in the package module (#57241) 2019-06-04 09:45:49 -04:00
2cb3094b68 Update azure_rm_mysqlconfiguration related document (#57335) 2019-06-04 09:41:00 -04:00
15034fb5b5 Update azure_rm_mysqldatabase related document (#57338) 2019-06-04 09:37:22 -04:00
ee8a607cca ipaddr: Handle network address in ipmath (#57149)
* Updated testcase, documentation

Fixes: #54457

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 14:01:18 +05:30
e620e27609 PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)
* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-04 10:52:16 +05:30
78f6a7cbb1 New module for managing export groups in Vexata storage arrays. (#55481)
* Vexata export group module.
* Fix messages / error handling paths.
2019-06-04 10:05:40 +05:30
6bb13bbb84 nxos_vlan: fix broken purge behavior (issue #57101) (#57229)
* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check
2019-06-04 09:14:09 +05:30
333f54ec3b cloud/amazon/aws_config_recorder: add empty resourceTypes list if undefined (#50286) 2019-06-03 15:45:38 -07:00
858e3a7272 Correct virtualenv usage in integration tests. 2019-06-03 15:23:04 -07:00
8cf6f56a01 Added sort option for zabbix_screen module (#56237)
* Added sort option for zabbix_screen module

* FIX: sort variable

* Added changelog file

* Fixed misspelling

* Update lib/ansible/modules/monitoring/zabbix/zabbix_screen.py

Changed spelling in the documentation

Co-Authored-By: flowerysong <junk+github@flowerysong.com>
2019-06-03 21:23:20 +02:00
7b40b569b2 Rename memset_*_facts to memset_*_info (#57030)
* Rename memset_*_facts to memset_*_info

* Add changelog.
2019-06-03 21:19:49 +02:00
5162d21ea3 VMware: vSphere Automation SDK installation docs (#57280)
* VMware: adds instructions for installing vSphere Automation SDK to the dynamic inventory scenario
2019-06-03 13:52:30 -05:00
ddfaa83ccf s3_bucket: add encryption capabilities to the module (#55985)
* s3_bucket: add encryption capabilities to the module
2019-06-03 11:25:09 -07:00
3587f346c0 Update azre_rm_mariadbfirewallrule related document (#57288) 2019-06-03 12:51:02 -05:00
ceb91ef80a Update azure_rm_mariadbdatabase relate document (#57287) 2019-06-03 12:49:38 -05:00
ea939c7e3e ovirt vnic profile update readme (#57298)
removes second of two identical examples
2019-06-03 11:35:10 -05:00
bf0e846a39 Update playbooks_filters.rst (#57200)
* Update playbooks_filters.rst to show JSON in the "JSON Query Filter" example data structure
2019-06-03 11:15:11 -05:00
ce24b43f2e Set community support for NetApp unit tests (#57198) 2019-06-03 11:52:32 -04:00
ec511e84bc Update azure_rm_appgateway.py (#56780)
* Update azure_rm_appgateway.py documentation to explain the dependency of authentication_certificates on cookie_based_affinity being enabled
2019-06-03 10:44:15 -05:00
2d5c9e06fa Update azure_rm_manageddisk related document (#57206)
* Update azure_rm_manageddisk related documentation
2019-06-03 10:32:02 -05:00
0f10c4e8d2 aws: Handle exceptions while describing metric alarm (#57304)
Handle exceptions raised while describing the metric alarms rather than
printing tracebacks.

Fixes: #55786

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 11:23:53 -04:00
78b003858d Mention other ways to handle private key files (#57238)
Often when I am helping others learn Ansible, they are using nodes spun up on Amazon/Google/etc.  where private key files (pem) are needed.  Mentioning just a bit more on how to handle those private key files on the intro_getting_started page will help more folks get started faster.
I even reviewed the changes with my learning team and they all agreed this helped clarify immediately for them how to really get started with Ansible from a practical perspective.
2019-06-03 10:17:13 -05:00
3e06013eb6 unittests for module_utils.common.removed.removed_module function (#57214) 2019-06-03 11:12:12 -04:00
e6166b40cc Fixes typo in get_url (#57305)
Fixes Typo, need instead of ned
2019-06-03 20:36:48 +05:30
6306f18fc3 Update azure_rm_loganalyticsworkspace related module document (#57158)
* Update azure_rm_loganalyticsworkspace related module documentation
2019-06-03 10:05:20 -05:00
0e25f8aef2 Add find module patterns option use cases documentation (#57089)
* Specify that the pattern is matched against the dirent basename
* Specify that regexen must match the whole name of the dirent. It has been a pitfall for me.
2019-06-03 10:00:15 -05:00
2efb876b4c Fix ignored team (#57307)
* Fix ignored team
* add another team member
2019-06-03 10:10:19 -04:00
86be0985ce removed_module func: removed extra spaces from msg and docstring (#57209) 2019-06-03 10:00:19 -04:00
87422ea7e7 nxos_snmp_user, nxos_snmp_host integration test fixes. (#57201)
* Fix nxos_snmp tests

* Add imagetag check for nxos_snmp_user test
2019-06-03 18:33:52 +05:30
2e0229a4b6 ansible-vault: convert vault_password_files to list to prevent traceback (#57186)
* Convert vault_password_files to a list

* Add changelog and tests
2019-06-03 12:14:06 +02:00
21cd24a0dd improve conditional warnings (#57190)
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo
2019-06-03 12:12:32 +02:00
fecffea370 postgresql_db: add note to doc about pg_dump (#57297)
* postgresql_db: add note to doc about pg_dump

* Update lib/ansible/modules/database/postgresql/postgresql_db.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 05:19:06 -04:00
96bf243265 New module postgresql_copy: copy data between a file and a table (#56835)
* New module postgresql_copy

* New module postgresql_copy: added tests

* New module postgresql_copy: changed tests

* New module postgresql_copy: doc format fixes

* New module postgresql_copy: fixes

* New module postgresql_copy: added upper, PostgreSQL

* New module postgresql_copy: fixed description

* New module postgresql_copy: added note about superuser

* New module postgresql_copy: remove SQLParseError

* New module postgresql_copy: fixed opt_need_quotes type

* New module postgresql_copy: fixed check_mode

* New module postgresql_copy: small fix
2019-06-03 19:11:50 +10:00
0c66a5d3ca cloudcscale_floating_ip: add types (#56924) 2019-06-03 10:43:32 +02:00
6b2688245e Pluribus Networks ipv6security raguard port module with UT (#57033)
* Pluribus Networks ipv6security raguard port module with UT

* Dox fix
2019-06-03 11:44:28 +05:30
b8a317c527 Pluribus Networks vrouter packet relay module with UT (#57155)
* Pluribus Networks vrouter packet relay module with UT

* Doc fix
2019-06-03 11:43:29 +05:30
b33c9dad40 Improve docs w.r.t. networks_cli_compatible. (#56971) 2019-06-02 23:38:21 -04:00
012609b09a VMware: Update doc for num_cpus and num_cpu_cores_per_socket calculation (#57227)
Updated document to explain num_cpus is multiple num_cpu_cores_per_socket.
2019-06-02 17:39:33 +05:30
e460a219cd VMware: vmware_evc_mode: fix the functional tests (#56875)
* Updated vmware_evc_mode tests
* Remove extraneous line in main.yml

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-02 08:16:05 +05:30
c54d79bc13 Extend docker_image tests. (#57090) 2019-06-01 15:29:00 +02:00
c8eda7773e VMware: Update vmware_guest_powerstate (#57000)
* Updated documentation
* Updated testcases
* Updated example
* Updated logic
* Provided option to specify task name, task description, task enable status etc.

Fixes: #56987

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-01 08:10:05 +05:30
7364e79c0d k8s: Fix .to_dict not needed (#56147)
* k8s: Fix .to_dict not needed

* Add changelog fragment
2019-06-01 11:42:48 +10:00
7cd229aa97 Fix assignments in docker tests. (#57249) 2019-05-31 23:47:53 +02:00
1515afd92c set team ansible (#57246) 2019-05-31 17:17:46 -04:00
8bd4e2a144 cert validation fixes - Attempt 2 (#55953)
* Attempt 2 of cert validation fixes

* Remove unused code

* Cleanup the tmp cert using atexit

* Fix linting issues

* Only add SSLValidationHandler when not HAS_SSLCONTEXT

* Catch value errors on non PEM certs

* Only catch NotImplementedError to avoid masking issues

* set self._context even with PyOpenSSLContext for conformity

* Fix error building

* normalize how we interact with the context we create

* Remove unused code

* Address test for py3.7 message difference

* open_url should pass the ca_path through

* Account for new error in url lookup test

* Guard some code behind whether or not we are validating certs

* Make _make_context public

* Move atexit.register up to where the tmp file is created
2019-05-31 16:35:25 -04:00
c493593b4b Adjust assorted terminology and wording around product offerings. (#57242)
* Adjust assorted terminology and wording around product offerings.

* Update docs/docsite/rst/dev_guide/style_guide/trademarks.rst
* Update docs/docsite/rst/user_guide/modules_support.rst
* Update docs/docsite/rst/reference_appendices/tower.rst
2019-05-31 14:24:44 -05:00
2ef7759be1 Allow syslog_json callback options to be set in an Ansible configurat… (#57232)
* Allow syslog_json callback options to be set in an Ansible configuration file.

The syslog_json documentation says that it supports options via an Ansible
configuration file. In fact, they can only be specified via environment
variables.

I've updated the module to use the standard "get_options" handling which means
that it can now support options via environment variables *or* the
configuration file.

Options can be set in the configuration file as follows:

```
callback_whitelist = syslog_json

[callback_syslog_json]
syslog_server = localhost
syslog_port = 514
syslog_facility = user
```

* Use the original, documented, names for the modules options.

In the documentation text change syslog_server to server, syslog_port to port
and syslog_facility to facility.

* Add an item to the changelog.

* Update 57232-syslog-json-configuration-options.yml

Fix a YAML syntax error / typo.
2019-05-31 14:29:15 -04:00
fd95c7b506 Fix CI issue 2019-05-31 14:12:20 -04:00
e1d0795aa3 beadm: Make creation of boot environments in snapshot format idempotent 2019-05-31 14:12:20 -04:00
d8bf4f1ebb Adding support for OpenBSD syspatch (#55561)
* Initial commit

* Fixing issue where applying always returned changed status

* Adding return variables: reboot_needed, rc, stderr, stdout, warnings
2019-05-31 13:42:01 -04:00
4142cd595e Plugin paths need to be sent in exectutor, too (#57126)
* Combine `_start_connection` methods into executor
2019-05-31 11:44:42 -04:00
4c7fff315e Fix module_utils.common.test_collections testsuite
PR #57181
2019-05-31 13:40:18 +02:00
ae033f1ec3 vyos interfacefix and test cases (#57169)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-31 16:13:40 +05:30
223f509ea3 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-05-31 12:32:28 +02:00
e1f1f238b6 Removing myself from openstack team (#57212)
I guess you might have seen that I do not have much bandwidth to
maintain those modules. I want to step up for other modules, so
I will have to choose. The OpenStack modules are in good hands
anyway with the rest of the team_openstack :)

Sorry for the inconvenience.
2019-05-31 09:27:37 +02:00
94b711bac5 Update azure_rm_mariadbconfiguration related document (#57207) 2019-05-31 13:46:08 +08:00
49ec681a73 Fix ansible_async_dir in the migration doc 2019-05-31 00:15:13 +02:00
3ef09496a3 Update azure_rm_hdinsightcluster related document (#57037)
* Update azure_rm_hdinsightcluster related documentation
2019-05-30 10:34:38 -05:00
6bceea4f51 kubevirt: Rewrite merge dict method 2019-05-30 07:41:21 -07:00
94e2d87b2f suggest to use sequential IDs (#57142)
##### SUMMARY
Suggest to use sequential IDs - otherwise action is considered to be changed always.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-05-30 10:39:59 -04:00
42acf740e4 Update azure_rm_loadbalancer relate module document (#57154) 2019-05-30 10:37:51 -04:00
511c385da6 Update azure_rm_functionapp related document (#56985)
* Update azure_rm_functionapp related documentation
2019-05-30 09:33:11 -05:00
df442751f7 Update azure_rm_dnszone related document (#56984)
*  Update azure_rm_dnszone related documentation
2019-05-30 09:31:12 -05:00
a7e53906a6 Update azure_rm_dnsrecordset relate document (#56895)
* Update azure_rm_dnsrecordset related documentation
2019-05-30 09:25:16 -05:00
bf25889bfd test_postgres: fix typos 2019-05-30 07:18:30 -07:00
01ed7a489a Add unit tests for lib/ansible/module_utils/common/text/converters.py (#56915)
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-05-30 09:22:53 -04:00
cac34ac568 kubevirt_pvc: improve failure handling (#57163) 2019-05-30 05:14:27 -04:00
4c00fc7b32 update pkg_mgr.py for Amazon Linux support (#56618) 2019-05-30 10:18:31 +02:00
ac1895453f Add test case for k8s cascading deletes (#55987)
* Add test case for non-cascading deletes

Deleting a DaemonSet does not delete associated pods,
even though it should

* Add coverage module when using pip

Otherwise tests seemingly fail
2019-05-29 19:26:43 -04:00
5008e1d479 meraki_config_template - Enable check mode (#54502)
* Add support for check mode

* Check mode returns proper changed status
- Added is_template_valid()
- Restructured check_mode so it will always return data
- Check mode should show proper changed status
- Code is untested and integration tests need to be expanded

* Fix deleting networks
- Add integration tests for deleting networks
- Refine tests based on changed/unchanged

* Remove one task from integration test
2019-05-29 16:30:26 -04:00
4df53f869e meraki_network - Add support for disableRemoteStatusPage (#48971)
* Add support for disableRemoteStatusPage
- New feature in the Meraki API
- Yes, it's a double negative, I may fix at some point

* Remove double negative
- All disables became enable and logic is reversed
- This isn't yet tested

* Switching computers!!!

* Apply changes to make the logic work, even reversed

* Attempt to fix some formatting errors

* Add documentation fragment

* Fix whitespace

* Add disable_my_meraki back, with deprecation notice

* Edit changelog notice

* Update deprecation version

* Update example to be a block and change deprecation message.

* Remove duplicate delegate_to

* Change deprecation notice.
2019-05-29 16:29:40 -04:00
79bb7bde5f apt_repository: Fix crash caused by cache.update() raising an IOError on timeout. (#51996)
* Fix crash caused by cache.update() raising an IOError on timeout.

* Add changelog fragment.
2019-05-29 15:59:51 -04:00
c47e9d22b4 Rename one_image_facts -> one_image_info (#57035)
* Rename one_image_facts -> one_image_info.

* Add changelog.

* Forgot symlink.
2019-05-29 21:23:25 +02:00
ba18dd713a Update document related with azure_rm_keyvault module (#57110) 2019-05-29 14:15:36 -05:00
163d3efbf8 Update azure_rm_image relate document (#57043) 2019-05-29 14:12:36 -05:00
00067c8d54 Update rabbitmq_queue.py (#56912)
change description for when `state=absent`
2019-05-29 13:57:05 -05:00
e381135ace Update BOTMETA with latest community changes (#57064)
This is the requested change from #56816 for 'dch'
2019-05-29 13:43:12 -05:00
5183f84016 📝 Mention the minumum cherry-picker version in doc (#57139) 2019-05-29 13:39:10 -05:00
dea9644d21 Use correct variable for run_once regardless of batch example (#57077)
Changes example to `when: inventory_hostname == ansible_play_hosts_all[0]` to really run run_once regardless of serial.
2019-05-29 12:24:12 -05:00
39945b8570 Make query with errors='ignore' return a blank list (#57038)
The jinja2 query() function (or lookup with wantslist=True, which is
the same thing) should always return a list.

However, if you combine a query with errors='ignore' and take the
error path, the current code returns a None value.  This is important
in a case such as

 - name: Conditional include file
   import_tasks: '{{ item }}'
   vars:
     params:
       files:
         - path/file1.yaml
         - path/file2.yaml
   loop: "{{ q('first_found', params, errors='ignore') }}"

If neither file1.yaml or file2.yaml exist, this should do nothing by
returning an empty list to the loop.  Currently if you run the above
task you'll get a rather unhelpful:

 Invalid data passed to 'loop', it requires a list, got this instead: .

This change ensures that when a query ignores an error, it returns a
empty list.  The errors='ignore' case is tested in several variants
with first_found.  The extant (but deprecated) "skip: True" for
first_found doesn't seem to be explicitly tested; a test is added here
to avoid regressions before removal in 2.12.

This fixes a regression you'll hit if you follow the suggestion in the
deprecation message included with
e17a2b502d to use errors=ignore over
"skip: True" for first_found.  This change adds an example that points
out the query/lookup difference and also fixes the error message to
not mention the now deprecated "skip: True".

Closes #56775
2019-05-29 13:23:02 -04:00
b7f4e2a190 update ospf modules to fix bugs as software version changes (#56974) 2019-05-29 12:40:30 -04:00
0137c4343b update ce_ntp.py and remove the root tag name to find all nodes (#56976)
* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node
2019-05-29 12:39:37 -04:00
9e1f184b2d add terminal initial prompt for initial connection (#57057) 2019-05-29 12:37:13 -04:00
fe1f1c4541 Update BOTMETA with latest community changes (#57063)
This is the requested change for 'koladiya'
2019-05-29 11:16:44 -05:00
e5b2e4c1ac tower_credential: ssh_key_data isn't a path anymore (#57113) 2019-05-29 11:15:45 -05:00
8043940c93 Update azure_rm_devtestlabvirtualmachine relate document (#56828)
* Update azure_rm_devtestlabvirtualmachine documentation
2019-05-29 11:03:42 -05:00
7864df8cb9 meraki - Rewrite update requirement check (#48394)
* Rewrite idempotency check
- Check now operates recursively and works on multiple types
- Order of lists matter

* Remove blank line for lint

* Fixed idempotency checks in meraki_ssid
- New sanitize() method for finding keys unique in compared dicts
- Fixed bug in meraki_ssid where SSID specified by number breaks
  - This will require a backport
- Converted ignored_keys from tuple to list

* Made changes required for idempotency

* Add changelog fragment

* Add unidirectional option for testing

* Disable option 1 check

* General fixes for is_update_required testing
- Added commented out debug statements in method
- Fixed ignored_keys modifications

* Remove old commented algorithm
2019-05-29 10:18:01 -04:00
57e1063fc7 meraki_config_template - Remove mandatory network lookup (#56525)
* Module only makes network lookups when needed instead of every execution

* Formatting fixes
2019-05-29 19:27:38 +05:30
b143918f30 text format fan info mismatch and module info check (#57009)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-29 19:08:46 +05:30
a56a9e1eeb switch the deletion order (#57102) 2019-05-29 17:11:54 +08:00
b1a92a37b4 VMware: Add pgbidkar in team_vmware (#56993)
Add Pavan Bidkar from VMware India in team_vmware as per request.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-29 12:48:37 +05:30
c36bdee416 Remove wwitzel3 from BOTMETA (#57091) 2019-05-29 09:03:58 +02:00
2cf1dfc415 Fixed misc typos (#57103)
* Changed immuteable to immutable
* Changed conig to config

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-29 08:56:05 +02:00
0ada6b8d8d Fix junos_facts test (#57065)
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.
2019-05-28 20:25:45 -04:00
486370a744 Fix win_iis_virtualdirectory to remove a virtual directory that contains children (#56569)
* FIX #49755

* Added changelog fragment

* Changes according to review

* Fixed changelog
2019-05-29 05:59:50 +10:00
1544924550 add a maintainer (#56858) 2019-05-28 15:53:33 -04:00
4490c0ba51 correct behaviour of win_iis when using site_id if site not found (#56567)
* Fixed #47057

* Fix trailing whitespace

* Change for review
2019-05-29 05:31:00 +10:00
94566ed79c Win_hostname module: Change name check to WMI (#56420)
* Change name check to WMI

* Changelog fragment

* Fixed per review
2019-05-29 05:30:16 +10:00
35c8739c2a Add full change check for rabbitmq policy (#19073)
Add check for all policy fields (name, apply_to, pattern, tags,
priority) to have correct changed state. Previosly changed state was
based on policy name only.

* Add support for rabbitmq 3.7
* Fix exec args for rabbitmqctl status
* Add changelog and fix description for Ansible 2.9
2019-05-28 15:06:06 -04:00
1d22909f7c Make second group match of ufw status output optional (#56678)
* Make second group match of ufw status output optional

Fixes #56674

* Fix comparison logic.

* Add changelog fragment
2019-05-28 20:54:11 +02:00
86928a5f74 docker_image: fix module failing when build option is used without specifying path (#56940)
* Fix module failing when build option is used without specifying path.

* Add changelog.
2019-05-28 20:48:08 +02:00
56e2d48612 docker_image: fix default handling of old docker-build options nocache and rm (#56610)
* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.
2019-05-28 20:47:31 +02:00
1b66a13186 Fix flow in eos_l2_interface (#57059)
* Also fix test debug labels
2019-05-28 14:06:57 -04:00
cf00883c9d Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return
2019-05-28 13:44:00 -04:00
a837cc5694 Bug fixes for GCP modules (#55976) 2019-05-28 13:43:19 -04:00
713ac29054 Bug fixes for GCP modules (#56689) 2019-05-28 13:42:12 -04:00
0ff62fd5c4 Bug fixes for GCP modules (#56764) 2019-05-28 13:41:51 -04:00
70ac35da3e Bug fixes for GCP modules (#56765) 2019-05-28 13:41:36 -04:00
2220b9c851 Bug fixes for GCP modules (#56766) 2019-05-28 13:41:19 -04:00
532de89b44 Fix exception with load_provider function (#56959)
It is possible for provider.authorize to exist, but set to None. Rather
then loading this value blindly, assume the default is False.

   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 145, in run
     res = self._execute()
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 635, in _execute
     result = self._handler.run(task_vars=variables)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/plugins/action/ios.py", line 50, in run
     provider = load_provider(ios_provider_spec, self._task.args)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/network/common/utils.py", line 424, in load_provider
     provider['authorize'] = boolean(provider['authorize'])
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/parsing/convert_bool.py", line 26, in boolean
     raise TypeError("The value '%s' is not a valid boolean.  Valid booleans include: %s" % (to_text(value), ', '.join(repr(i) for i in BOOLEANS)))

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-28 12:19:34 -04:00
1a893a48a3 Allow finer grained control for dupe YAML keys (#56933)
* Allow finer grained control for dupe YAML keys

  fixes #16903

* expand option to handle errors

* remove clog for previous version of toggle

* added missing parens

* fix typoe
2019-05-28 11:57:16 -04:00
c97d8ce25b Update intro_installation.rst (#57027)
Updated RHEL 8 Repository Name
2019-05-28 11:49:14 -04:00
e17434c19f Correct repository name to install (#56991) 2019-05-28 11:13:36 -04:00
a3b13bcf0d Update BOTMETA with latest community changes (#57053)
These have all confirmed in #56816
2019-05-28 09:59:14 -05:00
615db8e6f4 clarify package facts errors and warnings (#56060)
* clarify package facts errors and warnings

  fixes #56056
2019-05-28 10:01:47 -04:00
6f1ff8eb8e Add missing scp dependency for ios_file tests (#56956)
This was required to be installed by a human, out side of our testing.
Add it so ansible-test can now manage.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-28 17:51:10 +05:30
94e007ed77 ansible-test: use become for connection=local on ios_user (#56960)
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-28 17:38:36 +05:30
a40dc1174e Add support to start a vm and put it on hold in one_vm (#56841)
* Add support to start a vm and put it on hold in one_vm

* Add version_added to vm_start_on_hold option for one_vm

* Add version_added to vm_start_on_hold option for one_vm#2

* Add version_added to vm_start_on_hold option for one_vm#3

* Fix indentation for one_vm
2019-05-28 07:58:13 -04:00
61b48778a7 Rename _facts -> _info (#57028) 2019-05-28 13:43:04 +02:00
f6e8492942 Update BOTMETA with latest community changes (#57049)
This reflects #56816 but only affects me.
2019-05-28 13:30:30 +02:00
d8dcd20294 docker_container: fix container creation with networks_cli_compatible=yes (#56687)
* Fix behavior.

* Add changelog.

* Add simple test to prevent #56620.
2019-05-28 03:19:52 -04:00
baac1df935 New module mysql_info - Gather information about MySQL servers (#55434)
* New module mysql_info: collect info about MySQL server instance

* mysql_info - CI tests

* mysql_info: fixes

* mysql_info: fixes Decimal

* mysql_info: fixes Decimal converters.py

* mysql_info: fixed err conn message and check_mode

* mysql_info: added decimal.Decimal to lib/ansible/parsing/ajson.py

* mysql_info: convert Decimal to float

* mysql_info: fix

* mysql_info: fix

* mysql_info: returned the args list as it was

* mysql_info: fix typo

* mysql_info: fixes

* mysql_info: removed aliases for login_db

* mysql_info: changed RETURN condition info

* mysql_info: fixed doc

* mysql_info: fixed role's parsing

* mysql_info: fixed role's parsing

* mysql_info: fixes

* mysql_info: fixed integration tests
2019-05-28 09:10:12 +02:00
f137527201 $result.reboot_required = $feature_result.RestartNeeded (#56419)
* $result.reboot_required = $feature_result.RestartNeeded

* Update relevent PSLint ignores

* CI Problem with pslint and ignore.txt
2019-05-28 01:21:56 -04:00
c6ba5eb8a0 Remove unnecessary pass (#56992)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-28 12:43:22 +08:00
fcfc122205 route53_facts: add check mode support (#56900)
* route53_facts: add check mode support

* route53_facts: add changelog fragment mentioning check mode support

* route53_facts: alter changelog fragment type from `minor_changes` to `bugfixes`

* Update changelogs/fragments/56900-route53-facts-check-mode.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-27 23:44:55 +02:00
89b73cb535 ios_ntp: Switch interface to GigabitEthernet0/1 for tests (#56964)
* ios_ntp: Switch interface to GigabitEthernet0/1 for tests

Lets use an interface we know that exists for testing, in some cases
Loopback0 maybe not be configured.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* ios_ntp: properly register result variable for testing

This is currently broken, and tests don't work. Fix this by properly
registering the result variable.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-27 13:11:58 -04:00
7a0af34ba9 First batch _facts -> _info rename. (#56822) 2019-05-27 18:17:42 +02:00
4f8abde081 Fix syntax issue with ios_ntp tests (#56958)
This was missing a yaml anchor.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-27 19:51:07 +05:30
0d75e2659e GH-56902 Copy to new list from dict.items() return
dict.items() in pytho2 returns a list of tuples which can be iterated
while modifying the dict. In python 3 it returns a view which is tied to
the underlying dict, meaning the modifications to the dict while
iterating are unsafe.

This commit generates new list containing the tuples from the iterator
in python 3 which breaks the link to the dict, allowing the dict to be
modified while iterating the list.

In python 2 it would simply copy the list.

Fixes #56902
2019-05-27 10:16:17 -04:00
a946d5d8ce postgresql_owner: added docstrings (#57010) 2019-05-27 08:04:58 -04:00
398f4b8233 Added the 'show commit config diff' output available from the IOSXR device (#54875) 2019-05-27 17:30:14 +05:30
cab02b7832 Update OpenNebula modules maintainers (#56914) 2019-05-27 13:55:28 +02:00
c0fd1bef7c postgresql_info: removed deprecated checks, added doc strings (#57005) 2019-05-27 07:13:22 -04:00
19a78bdc7b Pluribus Networks vrouter bgp module with unit test cases (#56434)
* Pluribus Networks vrouter bgp module with unit test cases
* Sanity fixes
2019-05-27 11:53:57 +05:30
7f08de6b6c hcloud_volume attach step should be idempotent (#56906) 2019-05-27 07:48:48 +02:00
8f89d1d3da VMware: Fix python 3 incompatibility (#54123)
Add Python2 and Python3 compatible `string.translate` for hostname customzation.

Fixes: #54118
2019-05-27 11:10:49 +05:30
d7f4f886f8 ansible-test: ios_command cli test should only be network_cli (#56955)
We do not support testing under ansible_connection=local

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-27 10:04:02 +05:30
d5ab712fad DNS Made Easy fix locale for date string (#44624) 2019-05-26 23:49:17 +02:00
6a50c6aae4 docker_network: Integration tests for IPAM config idempotence (#56975)
Integration tests for pull request #56901 which fixes found issues with idempotence.
2019-05-26 16:41:06 -04:00
37df89b2d8 [docker_network] Fix idempotency when using aux_addresses in ipam_config (#56901)
* [docker_network] Fix idempotency when using aux_addresses in ipam_config

Mismatch between keys returned by Docker API (AuxilliaryAddresses) vs
expected by Ansible module (aux_addresses) resulted in tasks always
have status 'changed'. The existing code normalizing one set of
keys to another missed this special case where converting
CamelCase to lowercase is not sufficent.

Please see
https://github.com/moby/moby/blob/master/api/types/network/network.go
for reference.

* Correct keywords formatting in changelog file

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-26 08:40:09 -04:00
2f523ad08e docker conncetion plugin: accept 'dev' as 'newest version' (#56947)
* Accept 'dev' as 'newest version'.

* Add changelog.

* Fix YAML.
2019-05-26 14:15:25 +02:00
a7837edcf2 some logging fixes (#56311)
* some logging fixes

  fixes #25757, #25758, #25761
  alternative to #41859 and #25765

* better color handling, courtesy of alikins
2019-05-24 16:43:47 -04:00
484c023316 ansible-test: prefer shlex.quote (#56823) 2019-05-24 22:10:33 +02:00
3b9478ade0 Migrate away from pipes.quote (#56785)
* Migrate away from pipes.quote

* Fix sanity
2019-05-24 15:48:41 -04:00
86354ff1fb postgresql: remove depricated lib (#56641) 2019-05-24 15:08:16 -04:00
27dcf8aaab Not native, but text (#55676)
* use to_text instead of to_native
* cleaned up some imports and other pyflakisms
* fix missing lib messages
2019-05-24 14:49:04 -04:00
6e66ea9f78 Properly detect is_chroot fact on XFS for non-root (#56899)
Fixes #56437
2019-05-24 14:23:46 -04:00
fca2a4c68b adds ltm policy to bigip facts (#56926)
facts no longer return changed but queried status in results
2019-05-24 10:12:43 -07:00
30210e7de0 added tests for log_plays (#56811)
* added tests for log_plays

* grep for warning

* Update tests to work with ansible-test.
2019-05-24 12:24:31 -04:00
f76556e56d Update package.py (#56731)
The "-" does not work as expected if I want to get a specific version of a package. After replacing the dash with the equal sign. the task passed successfully.
Depends on package manager - adds example so we show both syntaxes.
2019-05-24 11:01:48 -05:00
4f25435cd2 Handle openstacksdk < 0.10.0: fix AttributeError (#50285)
* openstacksdk < 0.10.0: fix AttributeError

`openstack.version.__version__` expression raises an `AttributeError`
exception when openstacksdk < 0.10.0 is used. `openstack.version` is
now imported as a module, which works for all openstacksdk versions.

Error was:

    The full traceback is:
    Traceback (most recent call last):
      File "$HOME/.ansible/tmp/ansible-tmp-1545612308.8-46792777824159/AnsiballZ_os_security_group.py", line 113, in <module>
        _ansiballz_main()
      File "$HOME/.ansible/tmp/ansible-tmp-1545612308.8-46792777824159/AnsiballZ_os_security_group.py", line 105, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File "$HOME/.ansible/tmp/ansible-tmp-1545612308.8-46792777824159/AnsiballZ_os_security_group.py", line 48, in invoke_module
        imp.load_module('__main__', mod, module, MOD_DESC)
      File "/tmp/ansible_os_security_group_payload_keFTIJ/__main__.py", line 163, in <module>
      File "/tmp/ansible_os_security_group_payload_keFTIJ/__main__.py", line 115, in main
      File "/tmp/ansible_os_security_group_payload_keFTIJ/ansible_os_security_group_payload.zip/ansible/module_utils/openstack.py", line 121, in openstack_cloud_from_module
    AttributeError: 'module' object has no attribute 'version'

* Add missing space & dot in error message

* Always require openstacksdk >= 0.12
2019-05-24 10:27:47 -05:00
6c74e29618 Add dns_domain into os_network.py (#56453)
* Add dns_domain into os_network.py

* Added changelog fragment for PR 56453

* fixed linting issue (lib/ansible/modules/cloud/openstack/os_network.py)
2019-05-24 10:27:20 -05:00
bc50a52ee2 Handle binding:vnic_type as optional (#55526)
According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.
2019-05-24 11:22:16 -04:00
db6407d6bf Correct typo in playbooks_intro.rst (#56919)
Typo in code block line: ansible-lint veryify-apache.yml should be
ansible-lint verify-apache.yml
2019-05-24 09:53:00 -05:00
f96529d20e warn on systemd globs (#56645)
* warn on systemd globs
* added note to docs

  fixes 55476
2019-05-24 10:52:36 -04:00
9a563f8947 Windows FAQ: fix reference (#56909) 2019-05-24 09:39:49 -05:00
dad62500af Update azure_rm_devtestlabvirtualnetwork relate document (#56893) 2019-05-24 09:35:36 -05:00
f65df9189e kubevirt_vm: simplify previous change + update comments (#56897) 2019-05-24 07:24:28 -04:00
d88d71e4b1 route53_zone: return existing zone id in check mode (#56702)
* Returns zone ID for existing zone or `null`
* route53_zone: add module unit tests
* route53_zone: add compatibility with Python 2.6 to the unit tests
* route53_zone: address pycodestyle warning (add blank line)
2019-05-24 16:28:55 +05:30
6ebfe413b0 Spelling typo (#56878)
Changed 'creatd' to 'created'
2019-05-24 09:22:15 +05:30
7834da41ff Move eos l3 test IP addresses to documentation ranges (#56726) 2019-05-23 21:22:27 -04:00
50b1a66649 Update instructions for running module directly (#56883)
The internals of AnsiballZ changed silghtly
2019-05-23 17:20:29 -05:00
9c5b72147e Validate types before asserting lengths (#56882) 2019-05-23 16:51:28 -05:00
6bb21c3db0 vmware: test-refactoring
- In order to keep the integration with `ansible-test`, we prefer to avoid any
  interaction with the Ansible inventory file.
- split up the prepare_vmware_tests/defaults/main.yml in two
  configuration files: one for vcsim and one for a real environment
- remove all the access to hostvars
- directly interact with the ESXi to mount/umount the datastore
  https://github.com/ansible/ansible/pull/56516
- record the virtual machine folder in the environment configuration
- vmware_guest_move: Use https://github.com/ansible/ansible/pull/55237
2019-05-23 17:40:19 -04:00
4adb7cfb5f Always keep subset data for callbacks (#56881)
results were only being preserved during no_log
  fixes #56704
2019-05-23 17:15:04 -04:00
3b16036ce2 Keep machinectl from parsing options of cmd (#56572)
This is needed on machinectl versions prior to v231 (d6c3537ea9 to be precise).

Fixes #56571
2019-05-23 16:01:40 -04:00
8cee127ee4 vmware_host_datastore: ability to target a ESXi
Until now, the module was only able to interact with vcenter. This
commit adds the ability to directly target an ESXi without the
`esxi_hostname` parameter.
2019-05-23 16:01:22 -04:00
fc94d79c47 CLI docs include license not copyright (#56871) 2019-05-23 14:53:07 -05:00
ab96d22b61 📝 Add a GitHub-specific security policy note
PR #56866

It'll show up at
https://github.com/ansible/ansible/security/policy
and will help us guide users to the proper docs page

Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-05-23 21:48:58 +02:00
206806265d Modify azure_rm_devtestlabschedule related document (#56819) 2019-05-23 13:59:44 -05:00
8168c965bc kubevirt_vm: Fix checking of VM update (#56846) 2019-05-23 14:26:58 -04:00
fa6d328b8f kubevirt: Fix RS and presets template parameters (#56865) 2019-05-23 14:26:21 -04:00
f9b43a0f68 Copyright fix for 2018 (#56860)
* update copyright in footer

* remove extraneous copyright from cli commands
2019-05-23 13:10:22 -05:00
3129fc0b17 Update RHEL repo for Ansible 2.8 (#56859) 2019-05-23 11:31:12 -05:00
7b9d7e6b5c yum: handle "_none_" value for proxy (#56725)
* yum: handle "_none_" value for proxy

Fixes #56538

* Fix sanity check
2019-05-23 10:41:17 -04:00
8f4f3750fe Ensure uri module always returns status even on failure (#56240)
- Also return url and update docs for other values to indicate they are only returned on success.
- Add integration tests
- Use info variable for common return values
- Use -1 as default status rather than None. This is lines up with with existing code in urls.py
- Add unit tests to ensure status and url are returned on failure
2019-05-23 10:17:17 -04:00
22b9525aa9 Preserve ssh error (#56460)
* Preserve ssh error

* more details on fail

* removed redundant caption to errors
2019-05-23 10:03:35 -04:00
7f0bf0a98a Config toggle for duplicate dict key warnings (fixes #56799) (#56805) 2019-05-23 08:42:44 -05:00
1da47bfa8c Prevent vars premature templating (#56117)
Avoid premature vars templating
  * added tests
  * avoid 'is template' warning in vars, since we want them for latter templating
2019-05-23 09:42:19 -04:00
3095df099d vmware_vmkernel: no error on state=absent
The `network.type` parameter is set to default on default on `static`.
As a consequence, the network parameter is always defined as `dict`.

This patch ensures we don't check the value of the network configuration
if we want to delete the interface.
2019-05-23 09:27:00 -04:00
26d38dd642 VMware: Add folder param in vmware_datastore_cluster
* Make datacenter as alias and optional
* Add folder param to place datastore cluster in specific folder
* Updated examples
* Updated tests

Fixes: #48010

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-23 09:12:10 -04:00
cebb363fcc eos_l2_interface handle "Interface does not exist" (#56787)
* Quick and dirty attempt to handle eapi error

* Well this should probably change

* Hopefully this works correctly?

* Fix check_rc handling with httpapi

* Add tests that should hopefully cover the error

* Fix warnings

* Improve tests
2019-05-23 17:02:46 +05:30
5005c353ef VMware: vcenter_folder: print full path of the new folder (#55237)
Print the full path of the freshly created folder in the output string.
2019-05-23 16:21:22 +05:30
0d842ff539 redfish: refactor service_root variable (#56198) 2019-05-23 10:57:22 +02:00
64b30b172e docs: cron: fix for example raises a warning. (#56701)
The following one:

    The value 2 (type int) in a string field was converted to '2'
2019-05-23 10:54:29 +02:00
124400f319 win_get_url: ignore defender false positive in tests (#56812) 2019-05-22 23:16:47 -07:00
2a9b9d63ba Show access keys for azure_rm_storageaccount (#56612) 2019-05-23 10:26:51 +08:00
54aa6f3921 ACI CDP Interface Policy Module Creation (#54818)
* initial commit

* Fix typo in integration test which caused an assertion to fail

* Updated integration testing

* Fix Ansible Sanity Errors

* Changed version added to 2.8 from 2.9

* added from __future__ import absolute_import, division, print_function
__metaclass__ = type
2019-05-23 00:47:44 +02:00
bb50fc3889 construct_deep_url() (#53475)
* Updates aci.py with the ability to add ACI objects to any depth

Changes start at line 411 (construct_deep_url() and supporting functions). One minor change to line 633 (the original construct_url()) to provide for testability:  ...join(sorted(self.child_classes)) vs ...join(self.child_classes)

I am also attaching two test files. One characterizing the existing construct_url() and the matching test set for construct_deep_url() to support my efforts and proof of parity

* Two PyTest files to support construct_deep_url

These two files provide testing parity, one characterizing the original construct_url() function and the other proofing construct_deep_url(). The ...deep_url.py test file goes five layers deep to provide better validation for the function

* Correcting previous upload to incorrect folder

These two files provide testing parity, one characterizing the original construct_url() function and the other proofing construct_deep_url(). The ...deep_url.py test file goes five layers deep to provide better validation for the function

* Deleting for file name change per Matt Clay

* Deleting for file name change per Matt Clay

* Correcting file names per Matt Clay

@mattclay Thanks again for your continued guidance and patience. Please cancel the previous (incorrect) request

* Wrong location for test file

* Wrong location for test file

* First attempt to comply with suggestions

lib/ansible/module_utils/network/aci/aci.py:517:0: SyntaxWarning: "is not" with a literal. Did you mean "!="?
lib/ansible/module_utils/network/aci/aci.py:534:0: SyntaxWarning: "is not" with a literal. Did you mean "!="?
lib/ansible/module_utils/network/aci/aci.py:558:161: E501 line too long (210 > 160 characters)

* First attempt to comply with suggestions

test/units/module_utils/network/aci/test_aci_construct_url.py:1:14: SyntaxError: import pytest
test/units/module_utils/network/aci/test_aci_deep_url.py:1:14: SyntaxError: import pytest
test/units/module_utils/network/aci/test_aci_construct_url.py:0:0: use "\n" for line endings instead of "\r\n"
test/units/module_utils/network/aci/test_aci_deep_url.py:0:0: use "\n" for line endings instead of "\r\n"
Shortened test function names (less descriptive)

* Second attempt to comply with suggestions

* Second attempt to comply with suggestions

* Third attempt to comply with suggestions

* Third attempt to comply with suggestions

* Pro Tip: Convert from 'CRLF' to 'LF' in VSCode

It's on the status bar to the right

* Added setup() support for tests

* Continued corrections to support testing

* Added two mocks to support testing

I could not find where to place fakes/mocks, so please let me know if the current location is incorrect

* Adding tmpdir property to mock_basic.py

* Added last blank line to mock_basic.py

To pass sanity test

* Attempt to correct setup() issues

* Attempt to correct setup() issues

* Attempt to correct setup() issues

* Attempt to correct setup() issues

* Withdrawing pending injectability tweak to aci.py

* Withdrawing pending injectability tweak to aci.py

* Withdrawing pending injectability tweak to aci.py

* Withdrawing pending injectability tweak to aci.py
2019-05-23 00:46:43 +02:00
391a1042c2 openssl_pkcs12: fix crash due to wrong path used for loading key in check mode (#56808)
* Used wrong path for private key.

* Add changelog.
2019-05-22 23:34:42 +02:00
eb9009c4f4 added missing version_added 2019-05-22 17:04:36 -04:00
57e42842b0 Add a new "log_folder" option to the log_plays callback plugin. (#56717)
* Add a new "log_folder" option to the log_plays callback plugin.

A a new option for the log_plays callback plugin which allows the user to
control where the callback where creates log files.

The option can be set via the ANSIBLE_LOG_FOLDER environment variable or in the
Ansible configuration file, e.g.:

[callback_log_plays]
log_folder = /path/to/my/log/folder
2019-05-22 17:00:00 -04:00
8bb3274711 Improvement on setting VALID_INCLUDE_KEYWORDS on HandlerTaskInclude (#56801) 2019-05-22 15:24:25 -05:00
584a32e028 modify azure_rm_devtestlabpolicy relate document (#56770) 2019-05-22 14:57:10 -05:00
4680ed4525 modify azure_rm_devtestlabenvironment relate document (#56769) 2019-05-22 14:56:13 -05:00
22d2c6282a Update azure_rm_cosmosdbaccount related module document (#56624)
* update azure_rm_cosmosdbaccount_facts document
2019-05-22 14:55:10 -05:00
16fb3ffbda modify azure_rm_devtestlabcustomimage's document (#56763) 2019-05-22 14:53:21 -05:00
71ec184688 modify document (#56762) 2019-05-22 14:52:37 -05:00
96d2dd3241 Adding example for add host to groups (#56756)
updates the documentation for the virtualbox plugin
2019-05-22 14:50:14 -05:00
831d3c7b62 add azure_rm_keyvault_info (#55497) 2019-05-23 03:39:37 +08:00
cea7151a5b The InventoryData class does not have a get_vars method and InventoryManager's get_vars never appears to have been used (#56804) 2019-05-22 13:56:47 -04:00
8fe9618c84 preserve underlying block building error (#56465)
fixes #56462
2019-05-22 11:28:06 -04:00
69b2d7e0f3 fix collection adjacent loading with --playbook-dir (#56194)
* added inventory adjacent test
2019-05-22 11:06:54 -04:00
4f89c1d508 Revert "ACI: Implement encoded query_string" (#56783)
This reverts commit 1690af04fe.
2019-05-22 15:44:22 +02:00
e4239d9424 Fix workload profileId indexing in netapp_e_volume module (#56747) 2019-05-22 09:43:21 -04:00
f9108e23e7 postgresql_db: bugfix 56703 (#56734) 2019-05-22 05:59:21 -04:00
f824a13952 remove azure_rm_cdnprofile quote (#56695) 2019-05-22 16:26:58 +08:00
459776eb82 VMware: Add folder option for vmware_dvswitch (#56707)
* Added folder param
* Mark datacenter as optional parameter
* Updated docs
* Updated tests

Fixes: #54986

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-22 11:40:09 +05:30
4065692e13 k8s minor bug fixes (#56168)
Ensure `wait_condition`s with `Status: Unknown` actually
complete

Return k8s object after wait rather than k8s object before
wait when object is patched.
2019-05-22 08:08:22 +02:00
3e8ca0285f lookup: consul_kv: Add datacenter parameter (#56647) 2019-05-22 08:02:39 +02:00
d8c1f67862 win_file_version: fix typos (#56751)
##### SUMMARY
Minor fixes in error messages


##### ISSUE TYPE
- Bugfix Pull Request

##### COMPONENT NAME
win_file_version

##### ADDITIONAL INFORMATION
2019-05-22 15:44:54 +10:00
6900378766 [WIP] Tip to see the content of a single encrypted var (#37887)
* Tip to see the content of a single var encrypted with Ansible Vault
2019-05-21 15:37:25 -05:00
cb9be4ddaf Update get_certificate.py (#56594)
* Update get_certificate.py with an example to calculate number of days until cert expires from get_certificate result.

* Update lib/ansible/modules/crypto/get_certificate.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-21 15:31:34 -05:00
53ec9c8019 Clarify that GPLv3+ module_utils need core team approval (#56740)
* Clarify that GPLv3+ module_utils need core team approval.

* Update docs/docsite/rst/dev_guide/shared_snippets/licensing.txt

Co-Authored-By: Sam Doran <sdoran@redhat.com>

* More 'module_util' -> 'file in module_utils'.
2019-05-21 15:15:55 -05:00
b275dede0c Adds one more example for rollbar_deployment module (#56535)
- Also `name` added to existing example in order to comply documentation styleguide
2019-05-21 15:12:54 -05:00
d7dc9586d5 Update azure_rm_deployment related document (#56627)
* add azure_rm_deployment documentation
2019-05-21 15:07:10 -05:00
41cc198b61 Update azure_rm_devtestlab related module document (#56681)
* update azure_rm_devtestlab documention
2019-05-21 14:43:47 -05:00
8495e3d9e4 update more azure documentation (#56700) 2019-05-21 14:41:11 -05:00
ac22cd31b6 fixed doc build errors (#56735) 2019-05-21 14:37:43 -05:00
e64083e4b6 remove quote (#56690) 2019-05-21 14:35:26 -05:00
a608ca0e86 na_ontap_volume - added qos policy module options (#56026)
* added qos policy module options

* reverting reformatting not needed

* removing unneeded variable

* updating docs and examples

* adding example with adaptive qos policy
2019-05-21 14:33:54 -04:00
388f5d0b2b Add links to quickstart guides (#56722)
* shell of quickstart

* link to existing quickstart guides
2019-05-21 10:48:50 -05:00
a68ac729ea yum: fix false error msg about autoremove support (#56459)
* yum: fix false error msg about autoremove support
2019-05-21 11:37:04 -04:00
77f997474a yum: use Custom Group in integration tests (#56439) 2019-05-21 11:32:36 -04:00
7f5b1e998f Out put the version of the dependency so we can better understand the problem. (#56379) 2019-05-21 11:28:16 -04:00
afc678e2c7 Raise error in case of empty hosts list in playbook (#56354)
Fixes cases of playbook contaiing:
- hosts:
  -
ERROR! Unexpected Exception, this is probably a bug: sequence item 0: expected string, NoneType found
2019-05-21 11:11:15 -04:00
e13566140a Move update_cache to after self.yum_baseurl definition (#56613) 2019-05-21 11:43:44 +02:00
a4144e15c0 kubevirt_vm: Improve create VM from template (#55927) 2019-05-21 09:31:58 +02:00
3b4b2e5021 [docker] support the lookup of images by digest (#56649)
* [docker] images: add support for lookup by sha256 digest

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [tests] docker image by digest: work on a minimal test case

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [docker] group branch conditions per lookup

Co-Authored-By: Felix Fontein <felix@fontein.de>

* [misc] add a news fragment for the added digest lookup for docker images

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
2019-05-21 02:54:05 -04:00
8e1dd58c2b Allow python_requirements_facts to cope with packages with dashes (#56166)
* Allow python_requirements_facts to cope with packages with dashes

```
python_requirements_facts:
  dependencies:
    - kubernetes-validate
```

should work as expected

* Ensure tests run for python_requirements_facts
2019-05-20 23:38:50 -04:00
d8a5efa00c iam_role.py remove_policies should remove all of the requested policies (not just the first) (#56331)
The remove_policies function in iam_role.py enumerates a list of policies to remove. However, due to an indentation issue on the return True line, only the first such policy would be removed.

This change outdents the return True so that all of the the requested policies are removed.
2019-05-20 17:09:26 -07:00
493cf817a9 Don't rely on netloc for determining hostname and port, just use hostname and port (#56270)
* Add changelog fragment
* Fix IPv6 address parsing for py2.6, and add tests
* make sure hostname isn't None
2019-05-20 16:50:54 -04:00
66bfa27685 Replace deprecated ansible-container references (#56427)
Link to ansible-bender instead of the deprecated ansible-container.

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-20 15:38:38 -05:00
6496084697 Update unarchive.py (#56285)
Clarify that the unarchive module does not unpack a compressed file, only archive files.
2019-05-20 15:20:13 -05:00
77f3e8451c Update uri.py (#56395)
1. Note that uri doesn't honor the no_proxy environment variable (due to https://github.com/ansible/ansible/issues/52705), and suggest a work around.
2. Added an example showing a test waiting for a URL to become available (using the `until:`, `retries:` and `delay:` settings) - based on https://gist.github.com/mikeifomin/67e233cd461331de16707ef59a07e372#gistcomment-2718587

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-20 15:18:47 -05:00
d56c975ce8 update azure_rm_availabilityset related module document (#56432)
* Update azure_rm_availabilityset.py
2019-05-20 15:09:11 -05:00
ded7949879 vultr: streamline docs (#56563) 2019-05-20 14:52:37 -05:00
6b240433b6 Update vagrant.py (#56568)
`inventory_file` has been renamed to `inventory_path`.
2019-05-20 14:30:57 -05:00
2a90cbd247 Update gcp_compute_instance_facts.py (#56581)
swapped dot inside brackets leading to wrong url
2019-05-20 14:22:38 -05:00
abca3f1956 Clarify documentation on _info vs. _facts modules (#56611)
* Clarify documentation on _info vs. _facts modules.

* Expand with examples for facts and non-facts.
2019-05-20 13:52:43 -05:00
b712b01f6e Bug fixes for GCP modules (#55973) 2019-05-20 14:44:29 -04:00
8d82df56ff Bug fixes for GCP modules (#55974) 2019-05-20 14:44:14 -04:00
d4b29e7838 Bug fixes for GCP modules (#55975) 2019-05-20 14:43:57 -04:00
e598eeeebe Bug fixes for GCP modules (#55977) 2019-05-20 14:43:37 -04:00
b37ae35ba0 azure_rm_azurefirewall (#56359)
* azure_rm_azurefirewall

* a few updates

* fixed mistake

* updated docs, fixed syntax

* updated priority

* use checkmode for idempotence test, as it's very long

* fix check mode
2019-05-20 10:38:55 -07:00
ea4842c0d3 Changing the license to Apache 2 2019-05-20 10:14:32 -07:00
34e9d6781b Templar: encapsulate _available_variables (#55435)
Ensure variables are reset between iterations
2019-05-20 11:49:54 -04:00
bd061fd632 BUGFIX updating existing managed filters fails (#56631) 2019-05-20 06:26:27 -04:00
8c29c78e22 Pluribus Networks vrouter loopback interface module with UT (#56450)
* Pluribus Networks vrouter loopback interface module with UT

* Sanity fixes
2019-05-20 12:04:05 +05:30
7a615a9e0e Pluribus Network vrouter ospf module with unit tests (#56435)
* Pluribus Network vrouter ospf module with unit tests

* Sanity fix

* Doc fixes
2019-05-20 12:02:05 +05:30
b2622f6c0f Add service endpoints when creation (#56561) 2019-05-19 22:15:35 -04:00
708bda06aa docker connection plugin: make privilege escalation code more similar to local.py (#56288)
* Make more similar to local.py

* Fix typo.
2019-05-19 08:00:25 -04:00
52a89b290f Fix typo in pg server ping (#56608) 2019-05-18 09:37:16 -04:00
386cef18ed module_utils.postgres: added unittests (#56381) 2019-05-17 23:33:45 -07:00
f1b5836836 lib/ansible/parsing/ajson.py: added UNIT-tests (#56398) 2019-05-17 23:29:42 -07:00
4742897635 Move backport guide to 2.8 (#56578)
The backport guide should refer to Ansible 2.8 instead of 2.7 as the target branch, since 2.8 is out.
2019-05-17 21:16:36 -05:00
3f4a22d8ef Add compat tojson filter for jinja2 versions missing it (#56596) 2019-05-17 20:36:41 -05:00
b8c170a322 vmware_datastore_facts: handle external datastore
Without this commit, `vmware_datastore_facts` ignores the datastores are
not associated with a cluster of a datastore. This case can happen if a NFS
share is mounted directly on a ESXi instance.
2019-05-17 16:40:00 -04:00
470371d009 Remove unused cloud config files.
These files have no associated cloud config plugin for ansible-test.
2019-05-17 12:21:52 -07:00
5a7bce1f8d Adding New Model onyx_qos for Configuring QoS on Onyx Switches (#55127)
* Adding New Model onyx_qos for Configuring QoS on Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_qos

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments on onyx_qos Module

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Shippable Comments Phase 3

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Current Version 2.9

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-17 14:20:56 -04:00
576593e175 Whitelist listen as a valid keyword on TaskInclude (#56586)
* Whitelist listen as a valid keyword on TaskInclude. Fixes #56580

* Move 'listen' to HandlerTaskInclude

* Remove trailing newline
2019-05-17 12:52:39 -05:00
b5935486da Updated utils to remove Avi SDK dependency and Avi 18.2.2 version update (#54894)
* Updated utils to remove Avi SDK dependency and Avi 18.2.2 version update

* Fixed the python 3.x errors failing for avi_disable_session_cache_as_fact not properly documented

* Updated version added fields for new parameters

* fixed pep8 errors

* made requests import optional

* removed setting requests to None

* Added try catch for the avi helper methods such that any import fails then module fail gracefully. This was needed to pass the requests library not found error

* removed deprecated modules. Also, trying another fix to deal with requests import error

* Fixed python3 errors

* fixed pep8, no-dict-iteritems and import test failures

* added version 2.8 for new field

* some more code cleanup and formatting

* updated the fail message and fixed plint errors

* added workaround for unicode pylint

* fixed the version added for new parameter app_learning_memory_percent and removed unicode_literals import

* Removed check of HAS_AVI for common argument spec

* Updated version added value from 2.8 to 2.9

* Version added value fixes of CI error
2019-05-17 13:12:06 -04:00
63e33f7e71 Fix eos_l2_interface idempotency (#56531)
* Attempt to handle just mode trunk properly

* Add test for trunk-only config and clean up tests

* Add missing eapi tests and remove references to provider as we do not test local
2019-05-17 13:06:27 -04:00
18f22de67e Fix typo that breaks invocation of os_stack (#56575)
* Fix typo that breaks invocation of os_stack

* Apply tags conditionally so that the module does not throw up an error when using an older distro of openstacksdk
2019-05-17 10:34:57 -04:00
6c1a255d98 Fix hcloud tests 2019-05-17 07:25:25 -07:00
27aca731b3 meraki_ssid - Add examples to documentation (#56425)
* Add standalone copy/paste-able examples
2019-05-17 08:21:34 -05:00
2897cf43ce Fix typo in mount doc (#56566) 2019-05-17 11:44:32 +02:00
c6b40f4d40 register: fail when invalid var name is specified (#56456) 2019-05-17 11:02:03 +02:00
11c63d6c1e Update azure_rm_cdnendpoint related module document (#56440) 2019-05-17 16:02:40 +08:00
dfab364a19 Update azure_rm_containerinstance related module document (#56556) 2019-05-17 14:59:38 +08:00
1eb5fb9541 Add os_profile to VM facts, allow to filter by OS (#48040) 2019-05-17 14:44:44 +08:00
ba8846ab74 update azure_rm_containerregisty document (#56560) 2019-05-17 14:34:28 +08:00
06c050e9bd asa_config fix (#56559)
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
2019-05-17 11:49:00 +05:30
6c1dbbe554 Fix the test syntax (#56557) 2019-05-17 13:41:30 +08:00
2a187f362a meraki - Unchanged requests now return the original data (#53576)
* Unchanged requests now return the original data

* Add changelog fragment

* Add integration tests for returned data for meraki_network

* Add integration tests for returned data

* Improve idempoetent output
- Make MX l3 rules always show default rule
- Add integration tests

* Add integration tests for returned data on meraki_network

* Improved idempotency in a few modules and improved tests
2019-05-17 08:34:16 +05:30
a3c3fd91f8 move too old version to 2.3 (#56540) 2019-05-16 20:31:01 -05:00
c8e179fbf1 Aws waf region (#48953)
* Add waiter for AWSRegional

* Add support for WAF Regional

* Add support for regional waf web acl

* Remove set_trace, pep formatting

* Add paginator for regional_waf

* Change name of param for waf_regional

This is more in line with how AWS refers to the service. Additional
 changes made to how client is called. Used ternary to reduce if
 statements

* Change parameter name to waf_regional

* Add support for removal waf regional condition

* Change parameter from cloudfront to waf_regional

* Added state: absent waf rule

* Remove set_trace

* Add integration tests for waf regional

* WIP: adding region parameter to tests

* Add support for waf facts module

* Add region to waf regional integration tests

* Update security policy for waf regional testing

* Add type to documentation for waf_regional param
2019-05-17 10:36:14 +10:00
32620b7e00 vsphere_copy: fix the E309 error (#56537)
Resolve the two following errors:

ERROR: lib/ansible/modules/cloud/vmware/vsphere_copy.py:0:0: E309 version_added for new option (host) should be '2.9'. Currently None
ERROR: lib/ansible/modules/cloud/vmware/vsphere_copy.py:0:0: E309 version_added for new option (login) should be '2.9'. Currently None
2019-05-16 14:42:36 -07:00
867e357eb1 When not using file_per_task, make sure we don't prematurely close the perf files (#56477)
* When not using file_per_task, make sure we don't prematurely close the perf files

* add changelog fragment
2019-05-16 15:38:36 -05:00
98246f6032 consul modules: update documentation (#56408)
* consul modules: Python 2.6 is always required on managed node, document all types, improve parameter descriptions, fix typos
* consul_kv: add doc for retrieve parameter
2019-05-16 13:54:05 -05:00
7e997fdca2 Update ovirt_vnic_profile.py (#56518)
##### SUMMARY
qos is not defined when port_mirroring is enabled, a NoneType is returned for entity.qos in this case
getattr is safer to use than using a direct call to entity.qos.name


##### ISSUE TYPE
- Bugfix Pull Request

+label: docsite_pr
2019-05-16 13:52:45 -04:00
730456b402 Add seed parameter to random_mac filter (#51841) 2019-05-16 13:41:08 -04:00
a910d19533 Temporary fix for vsphere_copy CI failure. 2019-05-16 10:08:20 -07:00
d59eb9edab meraki_switchport - Improve reliability (#54275)
* Rewrite much of the execution of meraki_switchport
- Previous versions had problems with idempotency and allowed_vlans

* Modified payload creation
- Parameter map is used
- propsed is created using .copy()
- Much cleaner this way

* Add whitespace for lint

* Add bugfix snippet for changelog
2019-05-16 12:10:32 -04:00
4b0014166b Bump erlang ping to 1:20.3.8.18-1 2019-05-16 11:35:54 -04:00
d5a272ce89 Fix eos_support_session logic (#56524) 2019-05-16 11:28:19 -04:00
409c46b2fa Properly handle check for session support on eos (#56407)
* Properly handle eos session check.

* Why is eos_use_sessions an int?

* Add changelog
2019-05-16 10:44:22 -04:00
f88b660717 adds 2.9 roadmap, reversed local TOC order (#56371) 2019-05-16 09:28:33 -05:00
a4f08617d4 VMware: vmware_datastore_maintenancemode: check params (#56515)
Check the `datastore` parameter and raise an error if nothing has been
found.
2019-05-16 19:52:17 +05:30
4b39748d21 Update azure_rm_cdnprofile related module document (#56503)
* modify azure_rm_cdnprofile module documentation
2019-05-16 09:11:47 -05:00
118cf3ece6 Cloud dev docs to rst (#56485)
* Moves developer docs for AWS, ovirt, and openstack modules out of lib/ansible/, integrates them with dev_guide, with abadger's fix to make python snippets pass rstcheck
2019-05-16 09:05:12 -05:00
75046f8410 postgresql_db: added tablespace support (#56390) 2019-05-16 12:13:40 +02:00
50e9955a23 VMware: Add new module vmware_folder_info (#54344)
* Adds a new vmware module to support getting the folders and their paths within a datacenter
* Add integration tests
* Bump version added
* Refactor integration test
* Improve grammar in docs
2019-05-16 14:18:07 +05:30
0e0735f10e VMware: Return facts about rule_affinity vmware_drs_rule_facts (#55813)
Added the rule_affinity while returning about the rule facts
2019-05-16 11:51:36 +05:30
216260cbb4 VMware: vsphere_copy: ability to target an esxi instance (#55930)
*`vsphere_copy` was only able to interact with a vCenter instance. This
patch change that.
* In addition, it also makes use of the `vmware_argument_spec`.

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-16 10:40:07 +05:30
ca7ff2ad05 VMware: return info about SCSI controller in vmware_guest_disk_facts (#56442)
vmware_guest_disk_facts module added bus number of the SCSI controller to the output
2019-05-16 10:27:17 +05:30
7636f36a8a gcp_compute_target_proxy does not exist, update deprecated redirect (#56496) 2019-05-15 21:08:58 -05:00
635931051b [Doc-Release-2.8] fixed broken module links in 2.8 porting guide (#56494)
* fixed broken module links
2019-05-15 20:35:14 -05:00
183ba93ba3 removed previouslly deprecated settings (#55662)
* removed previouslly deprecated settings

  fixes #55304

* also removed from play context
2019-05-15 16:36:30 -04:00
4bf134756b changed version to 2.8 (#56487) 2019-05-15 14:59:21 -05:00
f097dca60d update release table for 2.8 (#56486) 2019-05-15 14:58:53 -05:00
d55823b013 Update of Ansible 2.8 roadmap (add RC2 & RC3) (#56436)
##### SUMMARY

* Remove **if needed** for RC2 & RC3
* Set correct release date for RC3
2019-05-15 14:17:10 -04:00
db42cf5873 Update ovirt_vnic_profile.py (#56466)
##### SUMMARY
Update documentation to reflect module name


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-05-15 14:10:05 -04:00
6182f368e7 Small typo fix in documentation (#56480)
The documentation was probably C&P'd from user, leaving a "useradd" mention where a "groupadd" should be.
2019-05-15 14:08:01 -04:00
940d58e1b3 Nullify improperly licensed test file 2019-05-15 13:57:36 -04:00
322cfa49d0 Meraki - Add check for auth_key parameter (#56199)
* auth_key parameter is required
- This will have to change when httpapi is implemented

* Add integration test

* Add assertion

* Enable VLANs on network

* Add required for auth_key
2019-05-15 11:45:07 -04:00
fa7aedc4c3 Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-15 11:09:09 -04:00
63155983fe [eos] Allow ports to be configured with just trunk mode (#55887)
Fixes #55886
2019-05-15 19:57:46 +05:30
4928373a8b Allow config commands in aireos_command to support prompts (#56130)
* Switch failure on config command to just a warning.

* Change wording in documentation

* Missing whitespace
2019-05-15 10:25:14 -04:00
8ce09a0057 VMware: fix inventory plugin (#56431)
* Fixed regression introduced in #56071
* Added test to check if hostvars are populated
* Fix toml installation logic

Fixes: #56413

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-15 10:15:49 -04:00
3b08e75eb2 hetzner changed image tag for server, so its working with ids and names (#56406)
* hetzner changed image tag for server, so its working with ids and names

* changed trailing whitespace

* added higher retries count since server creation from own image takes a lot longer
2019-05-15 03:43:21 -04:00
666dfdc551 YUM - handle enable of non-existent repo (#53286) 2019-05-15 08:45:54 +02:00
5ef2c5314e Fixed error handling in github_issue module (#39652)
* Fixed error handling in github_issue module

Due to recent changes in github3.py library module stopped working.
This fix adds extra error handling for new changes in library.

Fixes: #39627

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Check version

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Refactor github_issue

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-15 02:35:11 -04:00
107d9efef3 VMware: Check to retrieve list of all used disks (#56380)
Fixes: #56290
2019-05-15 11:02:25 +05:30
3170e8b881 azure_rm_securitygroup - fix delete error handling (#56422) 2019-05-14 21:30:22 -04:00
8e2bff407a Change S3 bucket urls to new method as per #56124 (#56418)
* Change S3 bucket urls to new method as per #56124

* duplicate / and dded changelog fragment

* Revert "duplicate / and dded changelog fragment"

This reverts commit b89d5cbe6d.

* duplicate /
2019-05-14 20:50:56 -04:00
fd65f037f8 winrm - fix failure parsing for send input errors (#56245) 2019-05-14 19:55:41 -04:00
826b99d4bd dnf: fix wildcard matching for state: absent (#56013)
* dnf: fix wildcard matching for state: absent

Fixes #55938

* Add changelog...

* Fix sanity check failure...
2019-05-14 17:34:10 -04:00
e98e98757d Initial commit for Oracle Cloud Infrastructure modules 2019-05-14 13:51:45 -07:00
ec2db1aed7 Initial commit - Oracle modules
Revert "Revert oracle (#56364)"

This reverts commit eefc90b66f.
2019-05-14 13:51:45 -07:00
75788ecff4 azure_rm_virtualmachine (and _facts): add boot_diagnostics control and facts (#49661) 2019-05-14 12:06:06 -07:00
0d2a120454 Merge pull request #56383 from Tomorrow9/fix_pr56296
VMware: add timezone and hwclockUTC customize parameters for Linux guest in vmware_guest
2019-05-14 14:11:52 -04:00
4a2fa46429 Remove old references to cloud-config-aws.yml.
References to the new `cloud-config-aws.ini` file are provided by `"$@"` in tests.
2019-05-14 10:58:55 -07:00
2d4cbe0d5b Modify/fix handling of noreplace option issue #55365 (#55967)
Presently setting noreplace: no/false has no effect. Negating the default
to true from false and modifying conditionals seems to correct this.
Making it such that you can re-install and existing package. That did not
seem possible without such modifications.

Potential fix for issue #55365 pending issue reporter testing and feedback.
2019-05-14 12:17:15 -04:00
f9b56a5b56 Add sanity test to check for unwanted files. 2019-05-14 09:13:51 -07:00
22d7e7ea0b update azure_rm_appserviceplan related module documents (#56348)
* update azure_rm_appserviceplan module documentation
2019-05-14 09:32:19 -05:00
84f5666aab update azure_rm_appgateway document (#56339)
* update azure_rm_appgateway documentation
2019-05-14 09:28:33 -05:00
7f41cc40e6 [doc] expect module: mention all parameter types (#56394) 2019-05-14 09:06:00 -05:00
b3ab83bc70 [doc] fix example: always trigger the handler (#56384)
by default, debug task result isn't changed - add 'changed_when: yes' to trigger handler
2019-05-14 09:02:40 -05:00
674a57c3fa fix module defaults (#56020)
* fix module defaults

 - corrected precedence (specific module > group)
 - made into reusable function
 - use from gather_facts/service/package to match 'actual module used'
2019-05-14 09:59:18 -04:00
8968d41599 [doc] command module: mention all parameter types (#56396) 2019-05-14 08:50:49 -05:00
30ccc8e1bd Fix VyOS cli prompt issues (#56389)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-05-14 19:17:00 +05:30
88be323bcd Fix 2.8 changlog url and reverse order porting guides TOC (#56373)
* fixed url for 2.8 changelog, fixed spelling issues, reversed TOC order
2019-05-14 08:43:47 -05:00
0ee673a558 Issue55222 (#55223)
* Python 3.7 compatibility for re.Pattern (Fixes #55222)

* Python 3.7 compatibility for re.Pattern (Fixes #55222)
2019-05-14 18:58:43 +05:30
49ecfdbc10 update azure_rm_autoscale document (#56388) 2019-05-14 17:10:59 +08:00
7a32bd8080 VMware: Improve vmware_portgroup (#56382)
* Rewrite vmware_portgroup module
* support check mode
* VLAN ID isn't required anymore
* VLAN ID 0 (no tagging) is the default
* Options match values in vSphere Client and vmware_vswitch module
* Policy override is configured properly
* VMware: vmware_portgroup updates
2019-05-14 14:34:43 +05:30
5b4cd227d7 Revert "inventory: virtualbox: fix typo in examples (#56328)" (#56374)
This reverts commit 099917ddc8.
2019-05-14 07:08:17 +02:00
f88dedb39d Fixed snapshot module, Resource not found issue for persistent-disk-0 (#35341) 2019-05-13 17:38:20 -04:00
cf78759f5b vmware_vm_facts: fix the support with regular ESXi
Ensure the module still work with the ESXi where CustomFieldsManager
does not exist.

From: https://www.vmware.com/support/developer/converter-sdk/conv60_apireference/vim.CustomFieldsManager.html

    The CustomFieldsManager object is used to add and remove custom fields to
    managed entities.
    The custom fields values set on managed entities are available through the
    customValue property and through the summary objects for VirtualMachine
    and HostSystem. They are not available directly through this managed object.
    This functionality is only available through VirtualCenter.

Fixes: #56071
2019-05-13 17:25:16 -04:00
21d4e239b4 vmware_vm_facts: fix the test with vcsim
The VM is call `ha-host_VM0`, not `DC0_H0_VM0`. This commit adjusts
the test to make it more resilient if the VM name is different.
2019-05-13 17:04:17 -04:00
4b99a2ac50 vmware: use hostname in esxi_hostname
The use of the `hostvars[esxi1].ansible_host` was attempt to use
different hostname and IP address. But it's actually the source of
more problems.

VMware expects to be able to resolvable the host name. This means, that
if someone wants to run the test-suite, s/he needs to use a DNS or
update the `/etc/hosts` files on the different hosts.
2019-05-13 17:04:17 -04:00
eefc90b66f Revert oracle (#56364)
* Revert "Update vcn module documentation (#55888)"

This reverts commit 94ef24974a.

* Revert "Initial commit for Oracle Cloud Infrastructure modules (#53156)"

This reverts commit 07b9f52fd5.

* Revert "Add Oracle module maintainers (#55889)"

This reverts commit b0f3df360a.
2019-05-13 10:24:12 -07:00
6948e04276 Add myself to committer list. (#56363) 2019-05-13 19:22:02 +02:00
85fa65e5f0 docs: Update scopes value example (#56362)
Existing example in GCE guide returns "invalid scope" error; value needs "https://" prefix
2019-05-13 12:11:49 -05:00
ef0851dcd4 IBM_Storage: fixed a bug - Unwanted arguments cause failure (#56357)
* IBM_Storage: fixed a bug which caused several of our modules to pass unwanted arguments and fail

* IBM_Storage: Added a changelog for 56357 bug
2019-05-13 12:41:06 -04:00
110b8ba660 ansible-config doesn't edit configs (#56355)
Avoid suggesting that it does in the description since that capability doesn't yet exist.
2019-05-13 11:35:13 -05:00
c1ebc8d9c2 Update default roles_path documentation (#56320) 2019-05-13 11:32:52 -05:00
f49a677622 update azure_rm_applicationsecuritygroup document (#56344) 2019-05-13 07:48:06 -05:00
661f7be0fe To fix the issue where nios_zone module was running second time for same object (#55595)
* fix for 55128 issue

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-05-13 14:30:39 +05:30
d998791b4a Bug fixes for the nios member object (#56045)
* Bug fixes in api.py

* Examples updated in nios_member.py

* Update lib/ansible/module_utils/net_tools/nios/api.py

Co-Authored-By: Sumit Jaiswal <sjaiswal@redhat.com>
2019-05-13 12:53:25 +05:30
d0f2da4f76 nxos: remove deprecated test target files (#55949)
* nxos_switchport: remove deprecated test target files

* Remove tests for nxos_ip_interface, nxos_portchannel; update nxos_interface

- `nxos_ip_interface` and `nxos_portchannnel` tests have been removed

- `nxos_interface` now uses current module `nxos_l3_interface` instead of `nxos_ip_interface`
2019-05-13 10:43:01 +05:30
27fcd0fd9e Fix typo in aws log group return documentation (#56335)
Change from objetcs to objects
2019-05-13 08:37:41 +05:30
35c655c8f5 modify azure_rm_aks* document (#56293) 2019-05-13 10:29:10 +08:00
c6a8e99d34 Added the mtu property to the os_network module (#55881) (#54730)
The networking API v2 specification, which is implemented
by openstack neutron, features an optional MTU parameter that
allows operators to specify the value for the maximum
transmission unit value.
2019-05-12 10:26:27 +02:00
1a6b95a8f1 redfish: Add If-Match ETag header to PATCH requests (#56150)
* add If-Match ETag header to PATCH requests

* add changelog fragment

* ensure header keys are lowercase

* fix dict comprehension for python 2.6 and earlier
2019-05-12 10:24:07 +02:00
099917ddc8 inventory: virtualbox: fix typo in examples (#56328)
Typo fix in 'windows' word
2019-05-11 21:47:51 +02:00
05cee754b4 Hetzner failover IP info module (#56186)
* Add hetzner_failover_ip_info module.

* Extend return value.

* Adjust to changes from refactoring.

* Forgot to adjust example.
2019-05-11 21:45:38 +02:00
0f852f01c0 Adding Support For EVPN in BGP Module (#55503)
* Adding Support For EVPN in BGP Module

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_bgp.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_bgp.py Phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Remove file Variable

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-11 08:21:10 -04:00
0cb0fa918f Adding Support for NVE Protocol in onyx_protocol (#55513)
* Adding Support for NVE Protocol in onyx_protocol

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_protocol.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-11 08:09:48 -04:00
031655def0 Adding Support for Traffic Class in Onyx Switches (#55577)
* Adding Support for Traffic Class in Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Enhancing the code and elemenating code duplicate

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-11 08:08:52 -04:00
7e6be4e634 VMware: vmware_guest_disk support for use_instance_uuid (#56107)
All vmware_guest_* module support for use_instance_uuid from Ansible 2.8,
somehow vmware_guest_disk missed from this change.
This fix adds support for use_instance_uuid in vmware_guest_disk.

Fixes: #56021

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-11 11:58:13 +05:30
9f86257a65 VMware: support folder param in vmware_vm_facts (#56298)
folder can be used as a filter while gathering facts about VMs.

Fixes: #56125

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-11 11:56:57 +05:30
f5326aa6cd Update os_image documentation (#49705)
* Update os_image.py docs to show auth details
2019-05-10 11:21:13 -05:00
ecdb616954 NetApp ONTAP module for manage ipspaces (#49821)
* NetApp ONTAP module for manage ipspaces

* fixes for ci_cd and code layout

* indentation fixes

* code style fixes

* fixing yamllint issue

* unit test for module na_ontap_ipspace

* fixing sanity tests

* change pytest.skip to pytest.mark.skip

* adding ansible version to 2.9
2019-05-10 11:24:02 -04:00
3c8d8b1509 should have gone into 52373 (#56306) 2019-05-10 10:59:50 -04:00
3fdc4ba6b4 To fix IOS static route CI failure (#56292)
* ios static failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix CI failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-05-10 14:19:00 +05:30
1554befd95 nxos_vpc:Fix multiple idempotency issues, add missing commands (#55735)
* nxos_vpc:Fix idempotency issues with multiple attributes

Several attributes were causing idempotency problems on various platforms:

- `auto_recovery`
 - This command can be disabled on certain platforms and will nvgen as `no auto-recovery`
 - When enabled it has an additional optional-keyword for changing the `reload-delay` timer value
  - This was addressed by adding a new attribute `auto_recovery_reload_delay` to handle setting the timer value
  - This new attribute is mutually exclusive with `auto_recovery`

- `/show run vpc/show run vpc all/`
 - Changed the command that gets state to `all` so that it could differentiate between `auto-recovery` and `auto-recovery reload-delay`
 - This change resulted in also changing some attribute handling withing `get_vpc`, since some attributes like `peer_gw` relied on presence of the config to determine state true or false. With `all` the config is always there so these attrs must specifically check for `'no '` in the string.

- `delay_restore`
 - This command has two additional, optional keywords that exist on some platforms and not others.
 - New attrs:
  - `delay_restore_interface_vlan`
  - `delay_restore_orphan_port`

- Modified the `sanity` test to include the new attributes and to fix the platform issues.

- Bugfix Pull Request

`modules/network/nxos/nxos_vpc.py`

- Validated `nxos_vpc` `sanity` test on these platforms, all are now 100% Pass: N35, N3K, N3K-F, N6K, N7K, N9K, N9K-F

- TBD: Future work is needed to add support for `peer_gw_exclude_gw` timers. This could be addressed in the same way as the `auto_recovery_reload_delay` changes included here.

* lint fix

* Add 'version_added' tags for new options
2019-05-10 13:17:02 +05:30
1097632039 eos_l2_interface: Handle Interface does not exist (#56140)
* Fail on switchport error

* Handle `Interface does not exist` when gathering switchport.
2019-05-10 13:14:29 +05:30
776ec08ad5 Ensure 'authorize' is always bool, regardless of source (#56271) 2019-05-10 13:13:36 +05:30
8c56c116e5 nxos_snmp_user: platform fixes for get_snmp_user (#55832)
* nxos_snmp_user: platform fixes for get_snmp_user

snmp user output behavior varies quite a bit for the different nxos platforms and required several workarounds:

- N5K/N6k
 - These platforms do not support structured output for `show snmp user`.
 - The current code lands in an `except` clause when the output is not structured; so I added a new `get_non_structured_snmp_user` method to scrape the state from the regular cli output if it's present.

- N9K-F
 - The `group` data in the JSON output is different for this platform; it has a different key (just `group` instead of `TABLE_groups` or `group_names`) and it is not indexed
 - For a single group the value is a string, for multiple groups it's a list

- sanity
 - N5K/N6K/N9K-F platforms will reject `no snmp user <name> <role>` when it's the last role defined for the user.
 - workaround is to use `nxos_user` to remove the user

- Changes validated on:
 - `N3K, N3K-F, N35, N6K, N7K, N9K, N9K-F`
 - `6.0(2)A8`
 - `7.0(3)I2, 7.0(3)I4, 7.0(3)I5, 7.0(3)I6, 7.0(3)I7`
 - `7.3(2)D1`
 - `7.3(3)N1, 7.3(4)N1`
 - `8.3(2)`
 - `9.2(2), 9.2(3)`

* fix lint warning
2019-05-10 13:10:49 +05:30
bd47e64bc7 Hetzner failover IP: refactoring (#56203)
* Rename helper function.

* Extract hetzner.py module_utils.

* Rewrite docs.

* Add module docs fragment.

* Split up get_failover function.

* Add tests for new function.

* hetzner_pass -> hetzner_password

* Move common argspec to module_utils.
2019-05-10 08:33:51 +02:00
7a02c40bbc vmware: find_vmdk_file with trailing / (#55957)
With the example, the `file_result.folderPath` of the file
does not have any trailing '/'. `target_folder_path` is correctly
generated and equal: `[nfs_1] images`.
2019-05-10 11:49:03 +05:30
d55c0cf8dc nxos_vtp_*: Fixes n6k issues (#55737)
* Add n6k support for nxos_vtp_domain

* Add n6k support for nxos_vtp_version

* Add n6k support for nxos_vtp_password

* Fix shippable error
2019-05-10 10:54:51 +05:30
dd0b0ae47b Lack of "--update" flag in older Ubuntu distros (#56283)
When installing Ansible on older Ubuntu distributions be aware of the lack of ``-u`` or ``--update`` flag.

+label: docsite_pr
2019-05-09 19:09:41 -05:00
eac7f1fb58 dev_guide: Various small updates (#53273)
* Document the clarifications that I usually remark when doing reviews
* Update docs/docsite/rst/dev_guide/developing_modules_documenting.rst

Co-Authored-By: dagwieers <dag@wieers.com>
2019-05-09 18:44:28 -05:00
5346a5cdac updated to describe required parameter (#56197)
* update ec2.py to describe required parameters for each option for `state`
2019-05-09 17:44:53 -05:00
748cfd89ab VMware: Add examples of folder in vmware_deploy_ovf (#56216)
Fixes: #51825

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-09 17:33:20 -05:00
f1ca5552aa fix webapp slot test (#56156) 2019-05-09 15:02:21 -07:00
bfc3687f70 remove guest_id check when use template (#55281) 2019-05-09 15:58:19 -04:00
499355fc13 VMware: Cleanup vCloud references (#56268)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-09 12:55:02 -07:00
61e476b908 connection/docker: add privilege escalation support (#55816)
As described in #53385 (and #31759), the docker connection driver did
not support privilege escalation. This commit is a shameless
cut-and-paste of the privilege escalation support from the `local`
connection plugin into the `docker` plugin.

Closes: #53385
2019-05-09 15:02:53 -04:00
87d42ca11c Disable failing hcloud integration tests. 2019-05-09 09:50:49 -07:00
45ee165fcd os_nova_host_aggregate - Fix aggregate delete with hosts (#53166)
Aggregate delete task will fail in case it has hosts within the aggregate.
As by the OpenStack, the hosts should be removed from the aggregate
prior aggregate delete.

Add remove host in case provided.
2019-05-09 12:38:28 -04:00
46c44a4359 Add new command GetVolumeInventory / GetSessions / GetVirtualMedia (#55433) 2019-05-09 09:45:08 -04:00
d8314e1a45 refactor moudule utils of hwc_utils.py (#55858)
* use navigate_value instead navigate_hash

* add async wait method

* update dict compare

* remove unuse methods

* not all modules have timeouts parameter

* navigate_value, the input data may be None
2019-05-09 09:04:51 -04:00
34a8594c91 VMware: Modifying Rest Client to use vSphere-Api-Client instead of individual service(#55804)
* Same api client can be used for other service as well 
* Incorporated Review comments. Modified Category and Guest Fact modules which are also dependent on vmware_rest_client module util
* Adding Integration Tests for vmware_rest_client changes
* Changes to incroporate changes in vcsim testware
* Change to get vm name to attach the tag
2019-05-09 18:19:42 +05:30
0bead3672f eos_config: Fix test issues (#56180)
* Alter tests to pass

* Change diff_against to make changed work again

* Add another diff_against

* Expose supports_sessions across all EOS connection types

* Change session warning to failure

* supports_sessions needs to be a method to survive the rpc boundary

* Alter tests to match
2019-05-09 18:02:24 +05:30
a7bf728555 gitlab_group: doc: fix sample code that used 'parent_path' which does not exists (#56256) 2019-05-09 14:14:26 +02:00
ea41bbcd4e Don't detect update if vrf not set. (#56235) 2019-05-09 17:33:47 +05:30
f9589bd4b1 Don't validate ip address for mgmt interface (#56136)
It is possible the EOS appliance doesn't have an IP address on the
management1 interface, instead just check we have found that interface.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-09 17:32:49 +05:30
fbee506284 update azure_rm_acs document (#56158) 2019-05-09 14:54:53 +08:00
458b473d06 Pluribus network prefix list module (#55686)
* Pluribus network prefix list module

* Doc fix and unit test fix

* Added default value with args spec change

* Sanity fix
2019-05-09 10:31:06 +05:30
05e81b28e9 Fix to allow multiple origins with origin access identity enabled (#55189) 2019-05-08 13:33:19 -07:00
22c079e4b5 BOTMETA: add maintainer, support and labels for hwc_utils.py and unit… (#56092)
* BOTMETA: add maintainer, support and labels for hwc_utils.py and unit test

* using anchors and aliases to simplify the definitions
2019-05-08 14:40:56 -05:00
dae5564e2b Fix var naming (#55796)
* Fix var naming in GCE guide
2019-05-08 13:51:18 -05:00
59d7ce6c3b Add missing roles to tower_role module (#56182)
* Add missing roles to tower_role module

* Placate 'ansible-test sanity --test pep8'
2019-05-08 13:11:50 -04:00
463a7ff5ca [rds_instance] don't hardcode license_model choices (#53409)
* Don't hardcode license_model choices
2019-05-08 22:01:57 +05:30
c5f3b778c4 Fix addition of newline for eos & nxos (#56227) 2019-05-08 12:28:04 -04:00
bceca72eb7 nxos_interface: Fix admin_state check for n6k (#55673)
* Fix admin_state check for n6k

* Fix rx and tx_rate intent check test
2019-05-08 21:20:22 +05:30
a5b6a161b5 sysctl will now return an error if the value is invalid (#55695)
* sysctl will now return an error if the value is invalid

sysctl can fail to set a value even if it returns an exit status 0. More
details: https://bugzilla.redhat.com/show_bug.cgi?id=1264080. Because of
this in case of an invalid value or a read-only file system, sysctl
module would return OK, even though it didn't set anything. To be sure
that sysctl correctly applied the changes we also need to check the
output of stderr.

* Run sysctl with LANG=C

Because we are parsing sysctl stderr we need to make sure that errors
are persistent across different system language settings.

* Add changelog fragment for sysctl
2019-05-08 11:34:55 -04:00
cf585831b4 nxos_banner: test file cleanup (#55992)
- Created `sanity.yaml` to contain all of the tests previously kept in separate files

- Removed `cli` and `nxapi` test directories

- Tested on current supported platforms and versions: `N3K,N6K,N7K,N9K,N3K-F,N9K-F`
2019-05-08 21:01:11 +05:30
2e8a3efccb Revert nxos, ios, iosxr return_timestamps (#56206)
* Revert "nxos_command:run_commands results failure when commands array size >1 (#52670)"
This reverts commit 0df5b92af3.
* Revert "added timestamps to nxos_command module (#50261)"
This reverts commit e150943314.
* Revert "added timestamps to ios_command module (#50323)"
This reverts commit 2a432a093b.
* Revert "added response_timestamps to iosxr_command module (#50095)"
This reverts commit 2a0c356da9.
2019-05-08 20:49:29 +05:30
deae5b1bce remove deprecated get_md5 from stat (#55659)
* remove deprecated get_md5 from stat

  fixes #55309

* removed get_md5 from tests involving stat

* keep get_md5 but hide it

* rst it

* ammended comment

* ws

* added ignore for hidden md5
2019-05-08 10:45:45 -04:00
cd95843ea5 Make ansible adhoc work with include_role (#56163)
* Make ansible adhoc work with include_role

Fix logic condition so that include_role works
without

```
ERROR! 'async_val' is not a valid attribute for a IncludeRole

The error appears to be in 'None': line 0, column 0, but may
be elsewhere in the file depending on the exact syntax problem.

(could not open file to display line)
```

* Add include_role test for adhoc
2019-05-08 09:53:24 -04:00
2a39dc84b7 XenServer: Minor changes and fixes in xenserver_guest (#55678)
* XenServer: Minor changes and fixes in xenserver_guest

 - xenserver_guest module: ignore wait_for_ip_address when
   state=absent (fixes #55348). Module docs are updated to reflect this.
 - xenserver_guest module: show proper error message when maximum number
   of network interfaces is reached and multiple network interfaces are
   added at once (fix for changes introduced in #54697).
 - xenserver_guest module: fixed a bug in reconfigure() where VM would
   be powered off even though check mode is used when reconfiguration
   needs VM to be powered off.

* Added changelog fragment
2019-05-08 09:03:44 -04:00
5a6f888036 ec2_instance: Force int when ebs.volume_size or ebs.iops is specified (#55716)
* Force int when volume_size is specified

* changelog

* both volume_size and iops must be int

* updated changelog fragment
2019-05-08 22:10:58 +10:00
1462fd740b ec2_instance fix name idempotency (#55224) 2019-05-08 10:07:18 +01:00
57e0567310 fix nxos_vlan mode idempotence bug (#55144)
* fix nxos_vlan mode idempotence bug

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Fix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-05-08 11:19:15 +05:30
7a957ba64a openssl_certificate: fix passphrase handling for cryptography backend (#56155)
* Make sure passphrase is bytes string.

* Fix typo.

* Add more passphrase tests.

* Fix test names.

* Add changelog.
2019-05-07 23:58:15 -04:00
193f69064f VMware: remove duplicate implementation of memory reservation (#56161)
mem_reservation and memory_reservation has redundant implementation.
Combining them together.

Fixes: #54335

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-08 08:44:30 +05:30
e00f086c96 Update k8s_facts.py (#56193)
https://github.com/ansible/ansible/issues/55448
2019-05-08 11:36:10 +10:00
c99e79cc58 Fix wrong date_size skip logic in s3_sync module (#53935) 2019-05-07 16:44:08 -07:00
38890ddcaf Expose newline option to cli_command module (#55451)
* Add newline to all cliconf plugins

* Expose newline in cli_command

* Also hook up to anything using transform_commands directly
2019-05-07 17:25:57 -04:00
8ff27c4e0c more info on how vaults work (#56183)
also add warning about what it covers.
2019-05-07 14:53:34 -05:00
6f0ac90ec3 na_ontap_qtree / na_ontap_gather_facts: qtree new params and modify operation / new subsets (#55825)
* qtree new parameters and modify action

* fixing pylint offenses

* fixing shippable fails

* added igroup_info gather_subset

* added qos_policy_info / qos_adaptive_policy_info gather_subsets

* pylint fixes

* fixing shippable test failure

* requiring option flexvol_name for na_ontap_qtree module
2019-05-07 14:32:27 -04:00
ba9fee6c37 Hetzner failover IP module (#56103)
* First version of Hetzner failover IP module.

* Extend module.

* Add comments.

* Add basic unit tests.

* Add more tests.

* Tests for set_failover.
2019-05-07 19:11:15 +02:00
6a88b715f9 VMware: Remove ckotte from VMware notification (#56118)
As per request from ckotte, removing ckotte from
bot notification.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-07 22:11:34 +05:30
6e73150244 refactor iscsi network facts module, remove external grep call, add unit test (#55643)
* remove external grep call and parse with python
* use function for repeated code
* use module.get_bin_path() for iscsiutil on HPUX
* some code opt for HPUX
* clean up non-module code, module being defined is a requirement for this code
* import get_bin_path() directly and use without module prefix
* Add integration tests for AIX and HP-UX
* add changelog fragment
* Apply suggestions from code review
Co-Authored-By: mator <matorola@gmail.com>
* Apply suggestions from code review #2
Co-Authored-By: Sam Doran <sdoran@redhat.com>
* Remove strict requirement on executable to exist for get_bin_path() as
it will allow facts gathering to continue without an error. Almost all
other files under facts do not have "required=True" (except 2 files,
which should be probably fixed). And check return value for
get_bin_path() , before run attempt.

* add check for AIX lsattr run_command return code
2019-05-07 12:26:20 -04:00
53ed1bfc49 Improve rendering of default lists (#56041) 2019-05-07 10:35:36 -05:00
9c5745ad21 Fix netconf_config backup string issue (#56175)
*  Convert the ElementTree object to string
   before dumping the configuration in file.
2019-05-07 11:31:58 -04:00
7608bc821e Fix vyos cli prompt issues (#55589)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-05-07 20:51:35 +05:30
86e98c5213 Note that by default the regex test is identical to match, but can do much more (#50205)
* Note that the regex test behaves like 'match', with default settings
2019-05-07 10:00:00 -05:00
beca3661a4 Fix some index-references and warn about remaining (#55727)
The ACI MultiSite PATCH API has a deficiency requiring some objects to be referenced by index.
This can cause silent corruption on concurrent access when changing/removing on object as
the wrong object may be referenced.

This PR removes some references by index, and documents this issue for
others.
2019-05-07 15:00:04 +02:00
2007a79952 VMware: Add managed object id in VM facts (#53523)
Fixes: #53372

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-07 17:05:38 +05:30
ae373d5a10 Fix cli_config junos integration test failures (#56159)
*  Priviledge escalation is not required for junos
   cli_config backup opeation.
2019-05-07 06:56:17 -04:00
f79b6b06f1 postgresql_table: added cascade option (#56068) 2019-05-07 16:08:03 +05:30
9271b4e368 Fix net_get and net_put task run failure (#56145)
* net_get and net_put action plugin class need
  to inherit from ActionBase class as the action
  class implements the entire get and put logic
2019-05-07 06:34:36 -04:00
0e0c2a7db7 nxos_snmp_traps: fix 'group: all' for N35 platforms (#55995)
* nxos_snmp_traps: fix 'group: all' for N35 platforms

- `group: all` attempts to enable traps for all features defined in the module's `feature_list`

- `N35` platforms do not support `snmp-server enable traps bfd`; so removing `bfd` from the `feature_list` for that platform

- Minor cleanup in `sanity.yaml` test file

* whitespace lint fix
2019-05-07 13:57:55 +05:30
d39be3d3e0 eos_bgp needs become: yes (#56131)
We don't specify that in hostvars, so add it to the tests
2019-05-07 12:13:38 +05:30
a62f0a2fda Fix dtl test typo (#56094) 2019-05-07 09:43:22 +08:00
14c218bb2f Check existence before calling get method (#56105) 2019-05-07 09:26:02 +08:00
ec56ea4514 Fix junos_config backup testcase (#56148)
* For junos_config taking backup of running configuration
  does not required priviledge escalation.
2019-05-06 18:24:13 -04:00
6b474a1ecd Sync required flags from argument_spec to docs (#56121)
<!--- Your description here -->
The arguments for certificate, private_key and password are marked as required in the ArgumentSpec, but not in the documentation. 
+label: docsite_pr
2019-05-06 16:49:07 -05:00
647ed207af Fixes Netconf_config single parameter bug (#56138)
* Fixes Netconf_config single parameter bug
Fixes 56022

fixed get_config to not require multiple parameters to just run a backup

* Add Integration test for netconf_config
Associated with #56022

tests backup through netconf only using one parameter.

* Added debug to the begin and end of file

* Fix formatting of save config.  #56022

* removed blank line at end: #56022
2019-05-06 17:30:49 -04:00
9db3c8a40b bumped 'vcenter-test-container' to '1.5.0' 2019-05-06 17:07:47 -04:00
f42a32ad36 cs_network_acl_rule: implement cidr/cidrs as list (#56083) 2019-05-06 22:36:26 +02:00
864bd941af Add support for isolated virtualenv in tests. 2019-05-06 16:28:52 -04:00
8cb76408d3 Update include_role description (#56001)
* Update include_role description to discuss tasks: use

The previous description in this statement's description really threw me off, and is IMO ambiguous at best. 'Loads and executes a role as a task dynamically. This frees roles from the roles: directive and allows them to be treated more as tasks.'

For reference, I spent a long time trying to make include_role, with a loop, work under a roles: section. It doesn't work, but this documentation and its use of the roles: keyword in the opening, and the phrase '"more" as a task' muddies the waters.

+label: docsite_pr
2019-05-06 16:17:50 -04:00
dc711c3018 VMware: vCenter Cluster EVC Mode : new module (#56089)
* add vmware_evc_mode module

* alter result message for absent/absent

* Apply suggestions from code review

Co-Authored-By: CastawayEGR <36353334+CastawayEGR@users.noreply.github.com>

* add idempotency test

* change result dict to evc_mode_msg

* refactor to use pyvmomi class

* fix update to only process task on update

* minimize update code

* add single quotes around vars to match other code

* pass datacenter to cluster find

* add check_mode to disable test
2019-05-06 13:12:19 -07:00
3d9da0c468 Don't fail trying to read boot image without enable (#56126)
Also add a message when network_os_image can't be acquired.
2019-05-06 15:15:26 -04:00
fef1a10efc Skip iosxr_bgp tests if device is not running XR 6.1.3 (#56123)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-05-06 23:03:20 +05:30
33d6f6f2dd Use stdout_callback yaml for network-integration tests (#56102)
This gives us a little more structure to our console logs, which make it
easier for machines / humans to parse. It will be helpful once the
ansible network team starts importing this data into elastic-recheck.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-06 21:01:40 +05:30
93d24efe37 package_facts: Trivial docs cleanup (#56015)
Make a small documentation cleanup for the package_facts module to use
the current YAML style and remove unnecessary quotes around `auto`.

Signed-off-by: Major Hayden <major@redhat.com>
2019-05-06 09:59:14 -05:00
f90398a31d mysql_user: fix regression (#55292) 2019-05-06 16:25:43 +02:00
7d5ada7161 add doc example of multiline failed_when with OR (#56007)
* add doc example of multiline failed_when with OR

* add variety to multiple OR failed_when doc example
2019-05-06 09:11:27 -05:00
ba9f0d53b2 add missing exported state do doc string (#56109) 2019-05-06 09:08:32 -05:00
23e63c9237 vmware: check the SSL certification
If `validate_certs` is enable, we now validate the server SSL
certificate.
2019-05-06 09:15:16 -04:00
14ab205ea2 Fixed whitespace on server key 2019-05-05 12:49:56 -04:00
7ab67fb2fe Add PTR Examples to nsupdate module
<!---  Add PTR Examples since Nsupdate usage may not be straight forward  -->

+label: docsite_pr
2019-05-05 12:49:56 -04:00
5e74ecb4fd fix documentation for docker_container publish_ports option (#56093)
The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".
2019-05-05 06:24:32 -04:00
f692261ea0 oom_killer and oom_score_adj are available since docker-py 1.8.0. (#56012)
* oom_killer and oom_score_adj are available since docker-py 1.8.0.

* Add changelog.
2019-05-05 06:13:55 -04:00
59d20e004e Fix vyos_command integration test (#56091)
This has been broken for some time, but only noticed recently.  Because
vyos_command isn't supported on ansible_connection=local, update our
testing to account for that.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-05 09:04:47 +05:30
6e0f4c53b6 Add missing selectors2 requirement for network-integration tests
Otherwise, we get the following error:

  ERROR: ncclient 0.6.4 requires selectors2>=2.0.1, which is not installed.

when running ansible-test.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-04 19:39:03 -04:00
1a66121f03 Fix invalid src option return response for network config modules (#56076)
*  Add changed key in faliure case to maintain backward compatibility
2019-05-04 07:23:12 -04:00
fa5a94aa71 doc: fix typos in azure_rm_webappslot.py (#56004) 2019-05-04 08:57:38 +02:00
223321e7e2 vmware_datastore_facts: empty list if none found
When `vmware_datastore_facts` does not fine any datastore, it raises an error.
This is not consistent with the other _facts modules. It should just return
an empty list instead.
2019-05-03 18:29:00 -04:00
ad2c7ec9d7 Add new members to the Scaleway team (#56018) 2019-05-03 12:32:39 -07:00
2925f6960e Update openssl_privatekey.py (#55438)
* Update openssl_privatekey.py

<!--- Your description here -->

+label: docsite_pr

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
2019-05-03 18:52:26 +01:00
95d1564f70 docker_container: use restart() API function instead of stop/start sequence (#55894)
* Improve container restart.

* Adjust tests.

* Add changelog.

* Quote options.

* Move tests for restart/recreate options to start/stop tests.

* Fix changelog name.
2019-05-03 11:30:39 -04:00
93f0112953 vmware_host_config_manager: do not apply an empty list of change
In a multi-host context, `changed_list` will record all the changes
done on any host. So as soon as ONE host is changed, it will be `True`.

A host can potentially already have a parameter set, in this case
`change_option_list` will be empty.

This commit uses `change_option_list` instead of `changed_list` to
decided if a given host should be updated.
2019-05-03 11:04:30 -04:00
541d73d82a vmware: refactoring of the vcenter_* test roles
Refactoring of `vcenter_folder` and `vcenter_license` to make use of the
new `prepare_vmware_tests` role.

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-05-03 11:03:19 -04:00
affaedfca8 vmware: refactoring of vmware test roles -- part7 (#55732)
Refactoring of the following roles to make use of the new
`prepare_vmware_tests` role.

- `vmware_resource_pool`
- `vmware_resource_pool_facts`
- `vmware_target_canonical_facts`
- `vmware_vcenter_settings`
- `vmware_vcenter_statistics`
- `vmware_vm_facts`
- `vmware_vm_host_drs_rule`
- `vmware_vm_vm_drs_rule`
- `vmware_vmkernel`
- `vmware_vmkernel_facts`
- `vmware_vspan_session`
- `vmware_vswitch`
- `vmware_vswitch_facts`

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-05-02 23:19:01 -04:00
2ef8b297ff Fix loading namespaced doc_fragments from collections (#55249)
* Fix loading namespaced doc_fragments

The syntax for specifying a different fragment name was already
using '.' as a separator, so the code needed to be tweaked to
avoid choking on names like `testns.testcoll.fragname` and
`testns.testcoll.fragname.altvar`.

`get_plugin_class()` returns 'docfragment' for the fragment loader;
mangling `subdir` provides consistent alignment with the normal plugin
directory names and avoids needing special handling of plugin types
with 'module' in the name.

* Add changelog entry
2019-05-02 21:15:57 -04:00
fcca1a124d Fix non-signature authentication (#56038)
Apparently everyone is using signature authentication these days.
2019-05-03 01:47:29 +02:00
47b2cb748b Allow config boolean options to default to None (#55951)
* Allow plugin boolean options to default to None

* fix mistake

* changelog

* be more specific
2019-05-02 12:09:14 -07:00
89d767c046 BOTMETA: add @goneri in team_vmware 2019-05-02 13:39:28 -04:00
cabbb0a0e5 VMware: Assign vSAN License for cluster (#55916)
* Modified vcenter_license to accept vSAN license and assign to
the given cluster.
* review comments

Fixes: #55711

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-02 21:39:25 +05:30
3cebb79328 Feat/add GetChassisInventory to Chassis category of redfish_facts (#54269)
* Implement get_chassis_inventory() in redfish_utils

* Add GetChassisInventory command to redfish_facts
2019-05-02 16:00:43 +01:00
2307797a76 vmware: refactoring of vmware test roles -- part3
Refactoring of the following roles to make use of the new
`prepare_vmware_tests` role.

- `vmware_drs_group`
- `vmware_drs_group_facts`
- `vmware_drs_rule_facts`
- `vmware_drs_portgroup`
- `vmware_drs_portgroup_facts`
- `vmware_dvs_portgroup_facts`
- `vmware_dvswitch`
- `vmware_dvswitch_pvlans`

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-05-02 09:31:03 -04:00
636f8cbdab Merge pull request #55730 from goneri/vmware_refact_part5
vmware: refactoring of vmware test roles -- part5
2019-05-02 09:28:17 -04:00
39d1794ed9 vmware: refactoring of vmware test roles -- part6
Refactoring of the following roles to make use of the new
`prepare_vmware_tests` role.

- `vmware_inventory`
- `vmware_local_role_facts`
- `vmware_local_role_manager`
- `vmware_local_user_facts`
- `vmware_local_user_manager`
- `vmware_maintenancemode`
- `vmware_portgroup_facts`
- `vmware_resource_pool`
- `vmware_resource_pool_facts`

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-05-02 09:28:01 -04:00
b108d01b0f Feat/add GetBootOverride to Systems category of redfish_facts (#54273)
* Add GetBootOverride as possible Systems command

* Add conditional to call get_boot_override if command == GetBootOverride

* Implement get_boot_override() in redfish_utils

* Implement get_multi_boot_override() and modify get_boot_override() to support the multi wrapper

* Update GetBootOverride to use get_multi_boot_override

* Add example for new command in docstring

* fix indent

* Update lib/ansible/module_utils/redfish_utils.py

Co-Authored-By: xmadsen <xander.madsen@gmail.com>
2019-05-02 14:08:16 +01:00
5309d6c131 Pluribus networks fabric local module with UT (#55872)
* Pluribus networks fabric local module with UT

* Sanity fix

* Ansible doc standards

* Unit test fix
2019-05-02 18:34:29 +05:30
2614e823df Fix SetOneTimeBoot to use standard ComputerSystem 'Boot' property (#54201)
* fix SetOneTimeBoot to use standard ComputerSystem 'Boot' property

* add support for UefiTarget and UefiBootNext boot sources
2019-05-02 13:50:41 +01:00
eb7190264e Add GetChassisPower command to Chassis category of redfish_facts (#54314)
* Add GetChassisPower as viable Chassis command in redfish_facts

* Add conditional to catch command == 'GetChassisPower'

* Implement get_chassis_power() retrieving Watts-related and other useful power data from each Chassis

* Add RelatedItem property and remove MemberId property

* Check for length of data['PowerControl'] to be > 0 before checking index 0 of the list.

* Fix return statement being inside loop and result key not being 'entries' as is expected

* Update lib/ansible/module_utils/redfish_utils.py

Co-Authored-By: xmadsen <xander.madsen@gmail.com>

* Update lib/ansible/module_utils/redfish_utils.py

Co-Authored-By: xmadsen <xander.madsen@gmail.com>

* Update redfish_facts.py
2019-05-02 13:48:57 +01:00
9f830b77fc Fix passwordless workflow (#55441) 2019-05-02 18:06:25 +05:30
de8ce08fd8 nxos_vlan: vlan names containing regex ctl chars should be escaped (#55463)
The `nxos_vlan` module may raise with regex error `sre_constants.error: multiple repeat` in the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g.

```
VLAN Name                             Status    Ports
---- -------------------------------- --------- -------------------------------
1    default                          active    Eth1/3
14   my-vlan-name-is-***              active
```
2019-05-02 18:04:00 +05:30
869fdcd7d4 nxos_acl: some platforms/versions raise when no ACLs are present (#55609)
* `nxos_acl` may fail with `IndexError: list index out of range` while attempting to delete a non-existent ACL.

The failure occurs when the `acl` var is an empty list.

* nxos_acl: catch 501 'Structured output unsupported' when no ACLs present

With some older image versions, `show ip access-list | json` will raise a 501 error indicating `'Structured output unsupported'` when there are no access-lists configured. This change turns off the `check_rc` and then looks for the failure condition.

* Fix kwarg

* Fix lint issues
2019-05-02 18:03:27 +05:30
24a46deef5 Package facts apt fix (#55963)
* fixes for apt on package_facts

* reverse order, apt is newer

* moved warnings prop to base
2019-05-01 22:11:12 -04:00
edafa71f42 Developer documentation update involving module invocation (#55747)
* Update docs for the 2.7 change to AnsiballZ which invokes modules with one
  less Python interpreter

* Add a section on how module results are returned and on trust between modules, action plugins, and the executor.

* Update docs/docsite/rst/dev_guide/developing_program_flow_modules.rst

Co-Authored-By: abadger <a.badger@gmail.com>
2019-05-01 18:52:22 -05:00
c455635500 Fix firewalld source option handling to be exclusive (#55715)
- Fix issue #55683
- Add integration test for source option of firewalld module

Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-05-01 17:47:47 -04:00
c707dd7b62 Added implicit initialization of APT package manager '_cache' field (#55851) 2019-05-01 17:08:18 -04:00
b14f477bee docsite: correct path, list requirements for testing module docs, etc. (#52008)
* dev_guide: correct path, list requirements, etc.; module HTML docs are in '_build/html/module' subdir
2019-05-01 15:19:02 -05:00
3161a91d7e Implement a framework for having common code for release scripts (#55893)
* Implement a framework for having common code for release scripts

* Release scripts will go through hacking/build-ansible.  build-ansible is
  a pluggable script which will set a directory that has common code for
  non-enduser scripts.  It will then invoke the plugin which implements
  that subcommand.  Uses straight.plugin for loading each sub-command.

* We're going to add tools which are needed to test ansible (the changelog
  generation, for instance) so we need to include the pieces relevant to
  that in the tarball.

* Add straight.plugin to the sanity test requirements for the same
  reason

* Skip compile test just for build-ansible plugins which won't be run as
  part of sanity tests.
2019-05-01 13:57:03 -05:00
5d4c73e197 unite poll defaults (#55470)
* unite poll defaults and update docs
2019-05-01 13:47:50 -05:00
ac657f67c0 Support "force_subnet_association" parameter on na_ontap_interface (#52691)
* Support "force_subnet_association" parameter on na_ontap_interface

* fix validate-modules issue

* - Fix spurious commit
2019-05-01 14:41:48 -04:00
b0f3df360a Add Oracle module maintainers (#55889)
* Add Oracle module maintainers

* adds anchor and aliases for oracle botmeta
2019-05-01 19:06:45 +01:00
91237fa414 Meraki util - Add method to encode parameters in the URL (#49015)
* Add new method to encode parameters in the URL
- I'm not really encoding, I'm sure this is broke
- There maybe an Ansible native way to do this

* Fix whitepace

* Added urlencode support
- Relies on urllib module
- Fixed string delimiter

* Enable URL params
- construct_params_list() creates a list of parameters to encode
- encode_url_params() does encoding in a simple manner

* Added proper methods for urlencoding

* Remove duplicate functions

* Remove blank line for PEP8
2019-05-01 13:15:36 -04:00
76dba7aa4f Add faq note about ssh ServerAliveInterval (#55568) 2019-05-01 12:04:40 -05:00
a89a2cf33f meraki/meraki_network - Enable/disable VLANs on network (#48820)
* Redo branch to fix merge commit

* Add changelog fragment

* Make VLAN settings idempotent

* Fix conflict

* Change `version_added` to 2.9 instead of 2.8.
2019-05-01 12:24:39 -04:00
23ddc7738b Update sample (#55654)
Correct logConfiguration example on the ecs_taskdefinition module.
2019-05-01 11:15:28 -05:00
7505550500 VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-01 11:47:28 -04:00
e4cca4e40a vmware: refactoring of vmware test roles -- part4
Refactoring of the following roles to make use of the new
`prepare_vmware_tests` role.

- `vmware_guest`
- `vmware_guest_boot_facts`
- `vmware_guest_custom_attribute_defs`
- `vmware_guest_customization_facts`
- `vmware_guest_disk_facts`
- `vmware_guest_facts`
- `vmware_guest_find`
- `vmware_guest_move`
- `vmware_guest_powerstate`
- `vmware_guest_snapshot`
- `vmware_guest_snapshot_facts`
- `vmware_guest_tools_wait`

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-05-01 11:22:14 -04:00
281cfcddb1 add link in README (#55902)
* adds link in README to dev env setup
2019-05-01 10:13:20 -05:00
d9a1c8954f Coverity Bug Fix for cnos_vrf.py (#55954)
* Coverity Bug Fix for cnos_vrf.py

* Update cnos_vrf.py
2019-05-01 10:57:04 -04:00
6610d678f8 Add vrf option to static routes (#55298)
* added vrf to static route

* fix pylint errors

* version added 2.9 for vrf

* removed undocmented return values

* Update README.rst
2019-05-01 10:55:09 -04:00
ea57377ddf correct method docs (#55961) 2019-05-01 09:13:57 -05:00
8542459b95 Docs: edits & expands module_utils & search path info in dev guide (#55931)
* Update docs/docsite/rst/dev_guide/developing_module_utilities.rst
2019-05-01 07:52:34 -05:00
5439eb8bd8 Clarifies how Ansible processes multiple failed_when conditions (#55941)
Docs: Clarify that multiple failed_when conditions join with AND not OR to counter third-party pages online incorrectly stating that it uses `OR`. ([example](https://groups.google.com/d/msg/ansible-project/cIaQTmY3ZLE/c5w8rlmdHWIJ)).
2019-05-01 07:31:59 -05:00
0b002203b4 clarify docs for rel src state hard (#55972) 2019-05-01 07:17:30 -05:00
cc3b8b9f72 win_acl - fix network path qualifier parsing (#55970) 2019-05-01 17:21:26 +10:00
5228133d74 Ansible.Basic - fix when deserialising a json string of an array (#55691)
* Ansible.Basic - fix when deserialising a json string of an array

* Added changelog fragment
2019-05-01 11:08:23 +10:00
b9af6847c2 network facts, add unit test for FC WWN (#55848)
* use 'None' as return value for get_bin_path and set return code to non-zero on run_command error
2019-04-30 17:26:00 -04:00
005487cba2 Make packaging dep explicit
A couple sanity tests require the packaging module.  The azure tests are
dragging it in but list it explicitly in sanity so we don't run into
problems if those are ever split up
2019-04-30 15:57:00 -05:00
0e8a77520c Refactor of win_xml (2nd attempt) to add support for processing multiple nodes and counting nodes matched by xpath (#53362)
* add multi-node manipulation, delete on xpath match only and count capability to win_xml

* fix pep8 and yamllint errors identified by ci tests

* fixed bugs when handling multiple elements, multiple attribute nodes and handling for attribute nodes when using xpaths that only select attributes like //@lang.  Added more tests and tweaked documentation.

* fixed line-too-long error

* fixed trailing space errors

* trailing whitespace expunged

* bump version_added to 2.9 for new changes

* fix PSAvoidUsingPositionalParameters sanity check failure

* refix sanity check as it broke the msg return value
2019-04-30 13:19:56 -07:00
7e3b1da33f kubevirt_vm: Add example how to use davatavolumes (#55906) 2019-04-30 14:41:49 -05:00
7cf0626d7b Fixe cloudfront_distribution module issue #45043 (#49434) 2019-04-30 12:28:55 -07:00
f37476e247 template lookup: restore variables between calls (#55126)
* template lookup: restore variables between calls

Fixes #55113

* Address issues from the review
2019-04-30 15:22:37 -04:00
f6fbfeace8 Clean up use of connection: local in tests. 2019-04-30 11:35:08 -07:00
e105f5b436 Install rabbitmq from s3 in tests. 2019-04-30 10:00:04 -07:00
0e8a6e08ce Clarify documentation an reboot delay paramaters (#55934) 2019-04-30 11:28:33 -05:00
9961d02547 Fix changelog sanity test failure. 2019-04-30 09:04:59 -07:00
365239234b update azure working group team member (#55907) 2019-04-30 11:52:13 -04:00
7e7eced425 Commenting Cliconf support call for IOS-XR modules for Ansible 2.9 version (#55751)
* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-04-30 21:20:28 +05:30
45d21b6474 Fix and refix help text for CLI (#55831)
fixes #23395 giving clearer information on installed role path
  re-fixes 'home display issue' for module-path
2019-04-30 11:16:26 -04:00
11279a909d fix combine filter using undefined vars (#55840)
* Check variables are defined before using combine filter

* Add tests for the combine filter

* Remove dependencies that should already be installed

* relocate the function to recursively check for undefined vars

add another test

* changelog
2019-04-30 11:10:19 -04:00
c4004b5fb1 Adding changelog for fix to issue #55515 (#55928) 2019-04-30 09:09:08 -05:00
8cfc9e6d22 Add GetSupportedFirmwareUpdateMethods to redfish_facts/Update commands (#54268)
* Add GetSupportedFirmwareUpdateMethods to update category commands list

* Add condition when command == GetSupportedFirmwareUpdateMethods to call the forthcoming rf_utils function get_supported_firmware_update_methods

* Implement get_supporte_firmware_update_methods() in redfish_utils

* rename command to GetFirmwareUpdateCapabilities

* rename comand get_firmware_update_capabilities()

* Rename command get_firmware_update_capabilities()

* Group update protocols by the type of Action they are associated with.

* remove trailing whitespace

* Use safer method to get 'title' for each action type and its allowablevalues

* Add example to docstring for using GetFirmwareUpdateCapabilities

* fix line too long

* fix line too long and trailing whitespace

* Update redfish_utils.py

* remove trailing whitespace

* fix overindent

* Use self.update_uri instead of hard-coding '/redfish/v1' in get_firmware_update_capabilities()
2019-04-30 13:53:54 +01:00
1aec39a2d7 Add GetChassisThermals command to Chassis category of redfish_facts (#54399)
* Add GetChassisThermals command to Chassis list

* Add GetChassisThermals conditional and point to rf_utils.get_chassis_thermals() function

* Implement get_chassis_thermals() in redfish_utils

* Remove trailing whitespace

* Add more properties, including RelatedItem tto distinguish entries' contexts from each other.

* Remove trailing whitespace
2019-04-30 13:46:24 +01:00
216d8b5254 VMware: support check mode in all facts modules (#55689)
* vmware_cluster_facts
* vmware_guest_facts
* vmware_guest_snapshot_facts
* vmware_host_capability_facts
* vmware_host_package_facts
* vmware_target_canonical_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-30 16:39:21 +05:30
8328eaee91 ovirt_disk: Fix vm creation (#55910) 2019-04-30 06:32:54 -04:00
0e83384dfd vmware: refactoring of vmware test roles -- part2 (#55724)
Refactoring of the following roles to make use of the new
`prepare_vmware_tests` role.

- `vmware_datacenter`
- `vmware_datastore_cluster`
- `vmware_datastore_facts`
- `vmware_datastore_maintenancemode`

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-04-30 06:22:49 -04:00
c8c0f8c51a vmware: refactoring of vmware test roles -- part1 (#55723)
Refactoring of the following roles to make use of the new
`prepare_vmware_tests` role.

- `vmware_about_facts`
- `vmware_cluster`
- `vmware_cluster_facts`

This patch depends on: https://github.com/ansible/ansible/pull/55719

Original PR: https://github.com/ansible/ansible/pull/54882
2019-04-30 05:38:43 -04:00
815a375177 allow empty plays again, for now (#55878) 2019-04-29 17:59:10 -04:00
cb0ca89994 Fix integration test role syntax.
This does not fix the tests themselves, only the syntax (converting from playbooks to roles).
The aix_devices test fails due to use of unsupported state values.
2019-04-29 13:51:36 -07:00
94ef24974a Update vcn module documentation (#55888) 2019-04-29 15:38:50 -05:00
b3ce3fc5eb Restore ansible --version output (#55728)
* Add custom action class for version info
* Use args from CLI as prog for ArgumentParser object
* Make prog a required parameter of create_base_parser() and update all uses to pass in the newly required parameter.
* Add unit test for checking ansible --version
* Update other related unit tests
2019-04-29 16:38:31 -04:00
c195645575 Remove illegal basic provisioning example (#55892)
The bare minimum example in the docs (i.e. only supplying name, state, and cluster) results in the error `state is present but all of the following are missing: task_definition, desired_count`.
2019-04-29 15:36:50 -05:00
47a440774f Speed up the Sphinx documentation build (#55593)
* speeds up the docs build by changing the navigation collapse setting
2019-04-29 15:34:02 -05:00
164ceb599b Bug fixes for GCP modules (#55358) 2019-04-29 15:51:09 -04:00
50b72ec2b5 Bug fixes for GCP modules (#55359) 2019-04-29 15:50:53 -04:00
6193658608 Bug fixes for GCP modules (#55360) 2019-04-29 15:50:41 -04:00
ef3607f1e7 Bug fixes for GCP modules (#55361) 2019-04-29 15:50:29 -04:00
4a371ec84e Bug fixes for GCP modules (#55362) 2019-04-29 15:50:15 -04:00
c181e567a1 Update setup.py (#55871)
adds a note on privileges needed on BSD systems to use dmidecode
2019-04-29 11:17:50 -05:00
274f6e4818 Removed legacy Digital Ocean tasks (#51786) 2019-04-29 12:16:31 -04:00
9b17346d1e PostgreSQL modules: move params mapping from main to connect_to_db() function (#55799)
* PostgreSQL modules: move params mapping from main to connect_to_db() function

* PostgreSQL modules: fix postgresql_db

* PostgreSQL modules: fixes
2019-04-29 11:29:49 +01:00
25f485f79d Update nios_member.py (#54419)
* Update nios_member.py

* Update api.py

* Update nios_member.py

* Update nios_member.py

* Update api.py
2019-04-29 14:24:54 +05:30
8e82baba4a zfs: deprecate key=value 'option' (#55699)
* zfs: deprecate key=value 'option'

Fixes #55318

* Not needed to ignore these anymore
2019-04-29 08:07:22 +02:00
fd2ea34444 fix cross subs vnet peering (#55854) 2019-04-28 13:07:25 +08:00
ae7b6739ce a fix by replacing subscription with subscriptions (#55797) 2019-04-28 09:40:51 +08:00
149336319a Clean up local_action and delegate_to in tests. (#55835)
* Remove unnecessary delegate_to in tests.

* Remove incorrect delegate_to in tests.

* Remove unnecessary use of local_action in tests.

* Remove incorrect use of local_action in tests.

* Remove unnecessary use of local_action in tests.

* Remove incorrect use of local_action in tests.

* Remove unnecessary use of local_action in tests.

* Use delegate_to instead of local_action in tests.

* Use setup_remote_tmp_dir instead of TMPDIR.
2019-04-26 17:33:59 -07:00
2feda390b5 Fix ansible-test target change classification. 2019-04-26 14:14:16 -07:00
357dafffa4 Update ali_instance_facts examples in documentation (#55760) (#55803) 2019-04-26 11:58:28 -05:00
7a46fe6693 Be sure to use the active state when checking for any_errors_fatal (#55779)
The current code was not properly checking for the active state when
checking any_errors_fatal, so if the error occurred in a sub-block
or included file it is not properly detected.

Fixes #55515
2019-04-26 10:31:30 -05:00
943f7334c5 Fix var naming (#55795)
Make vars match tasks in Google Compute guide.
2019-04-26 10:15:51 -05:00
1e2cbefac0 Update ec2_eip_facts.py (#53040)
Add several additional examples showing how to filter on tag, how to filter on the EIP allocation id, and how to set a fact using the output.
2019-04-26 10:12:32 -05:00
52a1e4a599 Fix some module author names (#55770)
* Fix some module author names

During some data analysis we noticed some typos in author lines.
2019-04-26 16:11:35 +01:00
9d5b5d7ddd correct description of modules vs plugins (#55784) 2019-04-26 09:32:42 -05:00
bb5059f2c7 Add security group info and example to AWS guide (#55783)
* expand documentation on how to use lookup plugin aws_service_ip_ranges with ec2_group module

* fix rst syntax error
2019-04-26 09:31:49 -05:00
cef536fd51 BOTMETA: added new member to postgresql maintainers (#55809) 2019-04-26 13:06:20 +01:00
213501a2cc Add wait of image disk after upload (#55426) 2019-04-26 05:36:54 -04:00
0679fbc1d9 ovirt_disk: Check if disk is attached to vm (#55767) 2019-04-26 05:25:29 -04:00
03b2986227 Fix order integration test.
Previously the test always passed due to invoking cleanup on failure.
2019-04-25 22:35:36 -07:00
05fcb8502f options not optional for callbacks (#55660)
fixes #55305
2019-04-25 22:22:06 -04:00
c7bf3e035b Fix the get property (#55745) 2019-04-26 10:07:58 +08:00
dbc64ae64c Clarify poll value behaviour in playbook async doc (#54929)
Clarify the documentation for `async` and `poll`; describe the behavior when `poll` = 0 and when it does not.

* Update docs/docsite/rst/user_guide/playbooks_async.rst

* Update the default poll value in async doc

Co-Authored-By: tacatac <taca@kadisius.eu>
2019-04-25 17:23:13 -05:00
9c038b210b Fix template lookup description (#55557)
Previously, template lookup description was documented  as "mostly a noop".
Now,  describe that it returns template content with substituted variables.
2019-04-25 17:16:53 -05:00
1d49313dc4 huawei: use new client (#55368) 2019-04-25 22:29:08 +02:00
a237e2dd6a BOTMETA: Add labels for popular docs (#55764)
* BOTMETA: Add labels for popular docs

For the more active parts of the docs tree ensure we set the right
labels and maintainers so we get technical reviews.

* team_cloudstack

Signed-off-by: John R Barker <john@johnrbarker.com>
2019-04-25 14:28:13 -05:00
ed6fa82d0c Give felixfontein supershipit on crypto (#55708)
Also add in missing unit tests
2019-04-25 15:16:35 -04:00
272bb8da7a Fix test_postgresql dependency analysis. 2019-04-25 10:00:49 -07:00
b71133eeb5 Use LooseVersion instead of StrictVersion as StrictVersion doesn't understand "rc1" 2019-04-25 10:56:20 -06:00
6fe57846d0 Revert "postgres modules: move params mapping from main to connect_to_db (#55549)"
This reverts commit 2250257809.
2019-04-25 09:38:54 -07:00
7b86208fcd Add Microsoft Document URL for WinRM Memory Hotfix (#55680)
* Add microsoft document for memory hotfix

* Update docs/docsite/rst/user_guide/windows_setup.rst

Co-Authored-By: hiyokotaisa <thel.vadam2485@gmail.com>
2019-04-25 10:56:34 -05:00
2732cde031 Support using importlib on py>=3 to avoid imp deprecation (#54883)
* Support using importlib on py>=3 to avoid imp deprecation

* Add changelog fragment

* importlib coverage for py3

* Ansiballz execute should use importlib too

* recursive module_utils finder should utilize importlib too

* don't be dumb

* Fix up units

* Clean up tests

* Prefer importlib.util in plugin loader when available

* insert the module into sys.modules

* 3 before 2 for consistency

* ci_complete

* Address importlib.util.find_spec returning None
2019-04-25 10:28:18 -05:00
6d645c127f vmware: import prepare_vmware_tests
The vmware test roles do a lot of similar operation to prepare
the environment. This role will be used to reduce the amount of
duplicated code.

The role can prepare an environment on a baremetal environment, this
in addition to vcsim.

Original PR: https://github.com/ansible/ansible/pull/54882
2019-04-25 09:58:59 -04:00
1a6df99aa5 apt: strip whitespaces in package names (#55750)
Fixes #55741
2019-04-25 15:29:26 +02:00
2250257809 postgres modules: move params mapping from main to connect_to_db (#55549)
* params mapping to connect_to_db
2019-04-25 11:38:38 +01:00
03cac394cc mark entire module result untrusted as template (#55717)
* prevents accidental templating on intra-action postprocessing of an untrusted module result
* makes the view of a module result within an action consistent with the way it would be stored for future use (eg facts, register)
2019-04-24 15:15:20 -07:00
34e9c0f3a5 Migrated path creation to custom parameters (#54278) 2019-04-24 15:14:58 -05:00
56da3825c6 meraki_content_filtering - Remove redundant API call with get_nets() (#55531)
* Remove redundant API call with get_nets()

* Add changelog fragment
2019-04-24 14:27:21 -05:00
d0ae686525 Fix for Bug#54050 (#54863)
* testing

* Fixed bug #54050

* fixed pylint issues

* removed Reamde.RST changes
2019-04-24 15:14:17 -04:00
9b339de7b6 ovirt vm clone from snapshot (#55650)
* ovirt init clone from snapshot

* ovirt snapshot update cluster

* rename srcvm to snashot_vm

* update required together syntax

* update required together sytax
2019-04-24 12:50:20 -04:00
33374094d1 Added parsing of LLDP remote port description (#54873)
* Added parsing of LLDP remote port description

* Removed whitespace on blank line.
2019-04-24 22:04:59 +05:30
7b7d6a1fef meraki_static_route - Remove unnecessary API call (#55528)
* Make module not get all nets every time it's executed with net_id

* Add changelog fragment

* Update changelogs/fragments/meraki_static_route_api_calls.yml

Co-Authored-By: kbreit <kevin.breit@kevinbreit.net>
2019-04-24 12:16:51 -04:00
6e9379fe11 hcloud_server: clarify further for usage of ssh_keys (#55713)
* hcloud_server: clarify further for usage of `ssh_keys`
* Make lowercase and drop plural on ssh_key description
2019-04-24 11:05:38 -05:00
e38881410f caution tape on makedirs_safe (#55241)
* removed usages in winrm/psrp to be consistent with other connection plugins
2019-04-24 11:37:34 -04:00
3f0900f504 Update win_domain_group_membership.py (#55594)
* Update win_domain_group_membership.py by adding notes regarding a computer object and fixing a typo
2019-04-24 09:30:07 -05:00
7805be2449 Add WTI Serial Port Config module (#55102) 2019-04-24 09:53:40 -04:00
748af9db74 template add cloud init (#55379)
* template add cloud init

* template add cloud init persist doc

* remove duplicate version

* ovirt_template add sysprep

* update ovirt_template docs

* update ovirt_template examples

* update ovirt_template docs - pep8

* template remove cloud init persist
2019-04-24 09:46:33 -04:00
f5b3983aa8 ovirt_permission add group example (#55705) 2019-04-24 08:21:06 -04:00
a568e018be nxos_ospf_vrf:sanity: ignore no default-metric idempotence tests when I7 images (#55615)
* nxos_ospf_vrf:sanity: ignore no default-metric idempotence tests when I7 images

This is a sanity test cleanup to handle a known image bug with (N9K) I7 images.
The I7 image rejects 'no default-metric' configs, so we're skipping the idempotence
tests that involve this bug.

Tested on N9K images: 9.2(2), 7.0(3)I7, 7.0(3)I2

* simplify check for I7
2019-04-24 17:41:48 +05:30
4d46f44ff2 nxos_snmp_traps:sanity: skip idempotency tests for I7 image bug (#55618)
This is a sanity test cleanup to handle a known image bug with (N9K) I7 images.
The I7 image fails to enable some snmp trap link configs causing an idempotency failure in the sanity, so we're skipping the idempotence tests that involve this bug.

Tested on N9K images: 9.2(2), 7.0(3)I7.
2019-04-24 17:41:16 +05:30
7ac28b25ff nxos_nxapi:configure:6k: Add platform excludes to test yamls (#55663)
`N6K` should be present wherever `N5K` is included/excluded.
2019-04-24 17:39:54 +05:30
4798368b13 nxos_bgp_neighbor_af:sanity:6k: skip soft-reconfig 'always' test (#55661)
N5K / N6K do not support the `always` keyword on the `soft-reconfig in` configuration.
2019-04-24 17:39:35 +05:30
bc9074404e ec2_instance: remove network.ebs_optimized option (#55694)
Fixes #55307
2019-04-24 07:40:48 -04:00
43712f81e5 ec2_lc: deprecate device_type option (#55697)
Fixes #55308
2019-04-24 07:00:01 -04:00
27b64d6524 ec2: deprecate device_type option (#55692)
Fixes #55306
2019-04-24 06:42:55 -04:00
cce05c1ed2 Remove redundant method (#55566)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-24 15:29:55 +05:30
91d187f780 nxos_snmp_host:sanity:6k: Add platform excludes for sanity tests (#55664)
N6K should be present wherever N5K is included/excluded.
2019-04-24 15:08:03 +05:30
8de2acb819 adding final functionapp settings (#55693) 2019-04-24 15:02:41 +08:00
0d3d002505 add resource group test (#55688) 2019-04-24 14:15:13 +08:00
204db4d044 Adding support for Azure MSI user-assigned identity (#54884)
If more than one user-assigned identity is assigned to a host, then an identifier is required to specify which credentials are retrieved.  This change uses the existing support for client_id to retrieve the user-assigned identity by client_id.
2019-04-24 14:13:09 +08:00
35fdae7485 spelling: temaplte -> template (#55665)
Correct a common mis-spelling of 'template' including in the return
value of the lib/ansible/modules/cloud/cloudstack/cs_template.py
module.
2019-04-24 07:06:09 +02:00
e77260a4fb Enable azure manged disk test (#55681) 2019-04-24 12:43:52 +08:00
2cfaf6e80a sensu_subscription very minor docstring typo (#55675) 2019-04-23 16:42:01 -05:00
a5cb47d697 Improve consistency of loop documentation (#55674)
There were a series of sections with subheadings in the loop
documentation, but the most recent additions did not follow the same
pattern.
2019-04-23 16:39:14 -05:00
79198cad7a Clarify the Vault guide and add Vault ID examples (#55111)
updates docs/docsite/rst/user_guide/vault.rst
* Add reference to single variable vault encryption
* rST ref to jump to the section
* Clarify the two targets of vault encryption, with notes about advantages and drawbacks of each
* Add the default form for --vault-id
* Add Vault ID examples for normal operations

Co-Authored-By: tacatac <taca@kadisius.eu>
2019-04-23 16:36:39 -05:00
863340ee26 --become-method should not be restricted (#55670) 2019-04-23 15:35:11 -05:00
3fd27f0cac Update win_dns_record.py (#55378)
##### SUMMARY
<!--- Your description here -->
The documentation dictates the values are strings. but the examples don't show this.
This can be confusing for new people.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-04-23 15:13:03 -05:00
e0ea5bb512 tests: vultr: fix tests due to vultr API changes (#55621) 2019-04-23 21:23:02 +02:00
1705ef5f26 vultr_server: fix idempotency for private network and IPv6 options (#55619)
* vultr_server: fix idempotency for private network and IPv6 options

* add changelog
2019-04-23 21:22:17 +02:00
db6cc60352 Migrate command line parsing to argparse (#50610)
* Start of migration to argparse

* various fixes and improvements

* Linting fixes

* Test fixes

* Fix vault_password_files

* Add PrependAction for argparse

* A bunch of additional tweak/fixes

* Fix ansible-config tests

* Fix man page generation

* linting fix

* More adhoc pattern fixes

* Add changelog fragment

* Add support for argcomplete

* Enable argcomplete global completion

* Rename PrependAction to PrependListAction to better describe what it does

* Add documentation for installing and configuring argcomplete

* Address rebase issues

* Fix display encoding for vault

* Fix line length

* Address rebase issues

* Handle rebase issues

* Use mutually exclusive group instead of handling manually

* Fix rebase issues

* Address rebase issue

* Update version added for argcomplete support

* -e must be given a value

* ci_complete
2019-04-23 13:54:39 -05:00
7ee6c136fd Update bundled copy of six from 1.11.0 to 1.12.0 (#55456)
* Update bundled copy of six from 1.11.0 to 1.12.0. Fixes #55303

* Linting fix

* ci_complete
2019-04-23 11:53:25 -05:00
acc675e4a8 Update bundled copy of backports.ssl_match_hostname from 3.4.0.2 to 3.7.0.1 (#55461)
* Update bundled copy of backports.ssl_match_hostname from 3.4.0.2 to 3.7.0.1. Fixes #51794

* Address linting issues

* ci_complete
2019-04-23 11:53:11 -05:00
8f2976dcee Update bundled copy of distro from 1.3.0 to 1.4.0 (#55459)
* Update bundled copy of distro from 1.3.0 to 1.4.0. Fixes #55302

* ci_complete
2019-04-23 11:52:51 -05:00
e0f30ed0ee Update bundled copy of selectors2 from 1.1.0 to 1.1.1 (#55457)
* Update bundled copy of selectors2 from 1.1.0 to 1.1.1. Fixes #55300

* ci_complete
2019-04-23 11:52:24 -05:00
a9f24e097f Add ansible_parent_role_names magic variable (#46687)
-Add: Test cases for ansible_parent_role_names and ansible_parent_role_paths
-Add: ansible_parent_role_names/paths variables for when a role is being included by another role.
2019-04-23 11:55:05 -04:00
b442706b54 Move missing library abort to use rather than import for netconf (#55384) 2019-04-23 09:19:47 -04:00
780ee45819 ensure inventory plugin loading rel to play (#51177)
Ensure inventory plugin loading rel to play

  fixes #51033

*  clarify paths
* now adding dirs funciton in loader
* better warnings
* each cli should handle adding dirs depending on context
2019-04-22 19:32:50 -04:00
66493e47cf ansible-test: Use psrp for 2008 host ci_complete (#55273)
* ansible-test: Use psrp for 2008 host ci_complete

* reset Shippable info back to default
2019-04-23 08:13:03 +10:00
f27eccabbd User - Fix shadow file parsing on AIX (#55230)
Implement a new method for shadow file parsing so it can be subclassed.
2019-04-22 15:24:10 -04:00
d18beee641 Add WTI OOB and PDU Device info module (#55114) 2019-04-22 14:59:53 -04:00
cca365061c add how to create HttpApi plugins for network modules (#54340)
* initial port over from gdoc

* crosslink httpapi pages

* Add some examples?

* Add quick example of using Connection

* Fix indentation of python code blocks

* moved to a full developer guide for networks

* Try to clarify some examples

* Fix typos

How did I even do that?
2019-04-22 13:21:21 -04:00
5311ee9efa Fix performance_insights_retention_period type. 2019-04-22 09:59:48 -07:00
8c7e38af62 Update gcp_container_cluster_facts.py (#55475)
'state' is not a supported parameter in this module - the example failed with "Unsupported parameters for (gcp_container_cluster_facts) module"
2019-04-22 11:38:28 -05:00
6ea3eca8ff Update windows_setup.rst (#55535)
Wrong protocol and port in command.

+label: docsite_pr
2019-04-22 11:34:13 -05:00
7e0603282d Add changelog fragments for #44811 (#55427) 2019-04-22 10:35:51 -05:00
14c60e6ec8 docker_swarm_service: Use str type for configs/secrets gid/uid (#55591)
* Change type of secrets gid/uid to str
* Add changelog fragment

Co-Authored-By: hannseman <hannes@5monkeys.se>
2019-04-22 11:29:46 -04:00
a8c3eeaa3d rds_instance: add datatype info in documentation (#55578)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-22 11:07:55 -04:00
158452661a Correct link to Thomas' GitHub account (#55587)
Thomas renamed his account from tstringer to trstringer
2019-04-22 09:37:00 -05:00
19c87d829f Pluribus Networks modules handling empty output (#54971)
* Handling empty output string
* Change log fragment for PR 54971
2019-04-22 14:57:47 +05:30
5f8342bc4c "no macro" command should not be handled by edit_macro(), fixes #55212 (#55218) 2019-04-22 14:54:48 +05:30
71494c0bd9 fixing lb / ag replacement (#55546) 2019-04-21 22:27:08 -04:00
97b336767c update main.yml (#55550) 2019-04-22 09:52:17 +08:00
5bda9cbebf Add variable type for performance_insights_retention_period (#49905) 2019-04-21 12:46:42 -04:00
94f295e4a1 k8s: fix API call to _wait_for_response (#53937)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-20 02:22:52 -04:00
1e619c44cd Remove redundant defined variable (#55122)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-20 11:34:11 +05:30
5dcc178679 added python3 support to nginx_status_facts module (#55428) 2019-04-18 19:21:09 -04:00
9421a7fddf cs_loadbalancer_rule: add cleanup on unit tests (#55387) 2019-04-18 23:58:41 +02:00
701cf25891 [cosmetic] solaris wwn fix (#55154)
* Solaris WWN parsing cosmetic fix (commit 924f5b5467)

* simplify module.run_command by removing use_unsafe_shell and remove calling of external grep

* add changelog fragment
2019-04-18 16:31:40 -04:00
afb5e02c19 preserve same order as inventory manager when using host lookup (#55331)
* preserve same order as inventory manager when using inventory_hostnames lookup

add a test

* move generic code
2019-04-18 15:54:03 -04:00
0330ea616e Removed misleading padding from highlighted results of a search query (#55464) 2019-04-18 11:26:10 -05:00
c8a15b9dbc crypto modules: use module_utils.compat.ipaddress when possible (#55278)
* Use module_utils.compat.ipaddress where possible.

* Simplify reverse pointer computation.

* Use dummy for unused variables.

* Remove from ignore list.

* Adjust fix.

* Fix text handling for Python 2.

* Add changelog.
2019-04-18 15:36:53 +01:00
e298de0986 GCP deprecations (#53355)
* gcdns_record deprecation

* gcdns_zone deprecation

* gcp_forwarding_rule deprecation

* gcp_url_map deprecation

* gcspanner deprecation

* gcp_healthcheck deprecation

* porting guide

* test failures

* forgot to rename

* deprecating

* porting guide changes

* unit test fixes

* changing ignores
2019-04-18 15:30:27 +01:00
316d1db29f postgresql modules: move connect_to_db and get_pg_version to module_utils/postgres.py (#55514)
* postgresql modules: move connect_to_db, get_pg_version to module_utils

* postgresql modules: move connect_to_db, get_pg_version to module_utils 2

* postgresql modules: move connect_to_db, get_pg_version to module_utils 3
2019-04-18 14:15:51 +01:00
10b02e17b9 Dms endpoint module (#54660)
* - initial commit for the modules and tests

* initial implementation based on ec2_asg

* docstring implemtation and further methods initial implementation

* refactoring and pylint changes

* further implementation and integration tests

* added examples and parameter documentation

* removed files that were essentially templates

* added waiter for delete and updated the tests

* removed unit test

* fixed pep8 failure

* fixed pep8 failure

* fixed pep8 password field issue

* fixed pep8 password field issue

* fixed syntax issues

* fixed pep8 defaults

* password property documentation was breaking yaml

* fixed pep8 defaults

* fixed lack of defaults for wait parameter

* added default to boolean parameter

* pep8 fix

* fixed author entry

* adding type to wait parameter

* adding type to wait parameter

* fixed linting issues

* updated description and removed default from docs

* added metaclass
changed default for boolean

* changed declared defaults

* - fixe the delete function
- solved the yaml syntax issue

* added missing defaults for timeout, retry and removed the one for endpointtype as it should be None, becasue parameter is Required anyway

* fixed RETURN documentation issue

* trying to fix the import placement error

* trying to fix the doc error for missing params

* pep8 issues

* added endpoint aliases

* - added documentation

* pep8

* changed to unsupported tag

* changed no_log fact to yes in the integration tests

* added suggested changes to the integration tests

* - making severname use resource_prefix as well as a more generic domain
- removing test fact
2019-04-18 20:27:40 +10:00
da28089a78 Add proxy parameter to k8s module. (#55377) 2019-04-18 19:52:41 +10:00
0ff67d0a1c postgresql modules: missing_required_libs, removed excess param mapping (#55506) 2019-04-18 09:57:22 +01:00
62badd76a5 win_service - simply env test (#55498) 2019-04-18 15:06:45 +10:00
ffce456de9 VMware: Check return of FindByInventoryPath (#55282)
Check return value of FindByInventoryPath API which is used for
finding desired folder to deploy OVF.

Fixes: #54823

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-18 09:26:30 +05:30
f247c21d23 win_region - fix format issues when using psrp (#55487) 2019-04-18 13:42:21 +10:00
8542f16fa9 SCP filename validation docs (#55399)
* SCP filename validation docs

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: jborean93 <jborean93@gmail.com>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: jborean93 <jborean93@gmail.com>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: jborean93 <jborean93@gmail.com>

* edits to scp FAQ entry

* zeut alors I have missed one

* incorporate jborean feedback

* adds link to bug report
2019-04-18 12:02:09 +10:00
01a3048b98 Switch gitlab_hook test to non-deprecated name. 2019-04-17 17:56:01 -07:00
48cb681140 fix for removing subscripion_id from resource facts (#55203) 2019-04-18 08:53:58 +08:00
52b582a7a4 modules/notification/irc: Fix channel joining for some IRC servers. (#55444)
* Fix channel joining for some IRC servers.

Some IRC servers may return the channel in a different case than
requested.  For instance, you might request "foo" but the server
returns "FOO".  The regular expression matching must be case-insensitive
for the join response in order to handle this.

* ansible style guidelines want spaces
2019-04-17 18:55:43 -04:00
73b7ab71fe typo fix (#55424) 2019-04-17 23:16:16 +02:00
405c7b7ab3 lxd_container: Create container via fingerprint (#52737)
In addition to using creating container using image
aliases, containers can also be created using
fingerprints, provided that the playbook author provide
alternate values for 'server', 'protocol' and swap out
'alias' for 'fingerprint'.

+label: docsite_pr
2019-04-17 13:35:48 -05:00
d7f6493084 adds better links to tips and pitfalls page (#55458) 2019-04-17 14:30:34 -04:00
c3cbc39dd9 Postgresql docs fragments 2 (#55363)
* Postgres to use docsfragments
* Postgres to use docsfragments: redefined options in postgresql_user
2019-04-17 13:12:19 -05:00
12d26eceb1 docker modules: make sure everything works with older docker-py versions (#55258)
* General test improvements.

* Adjust tests to older docker-py versions.

* docker_swarm_server_info: work around problems with older docker-py versions

* Bump minimal docker-py version for options network_filters and disk_usage.

* More general test improvements.

* Correct usage of docker_image.

* Put files into output directory.

* Speed up test.

* Remove old check.
2019-04-17 13:50:57 -04:00
24b44e1772 Ensure discovery unsafe (#55295)
* Ensure safe discovery by marking it Unsafe
2019-04-17 12:08:51 -04:00
de3bd8b791 extends linux cpuinfo test unit with sparc64 data (#55394)
* added debian sparc64 ldom cpuinfo

* updated linux data test unit with sparc64 cpuinfo
2019-04-17 12:00:17 -04:00
252b6b5eac Add description (#55429) 2019-04-17 05:56:20 -04:00
1017f15c38 fix bugs for ce (#54750)
* Update ce.py

            while to_text(out, errors='surrogate_then_replace').strip().endswith(']'):
                display.vvvv('wrong context, sending exit to device', self._play_context.remote_addr)
                conn.exec_command('return')
                out = conn.get_prompt()

connetion has no send_command function and ce device has no 'exit' command to return user-view(a correct context),but 'return' .command.

* Add files via upload

Some bugs fix.

* Add files via upload

fix some bugs

* fix a bug for ce_command

Running a command with prompt via ce_command, It doesn't work.The reason is that the key word for network_cli recognition is answer not response.

* fix bugs

fix bugs for ce modules

* Update ce.py

* Delete ce_ftp.py

need modify

* Delete ce_lacp.py

* Add files via upload

* Delete ce_aaa_server.py

* Delete ce_aaa_server_host.py

* Compatible with Python 3

Compatible with Python 3 and fix bugs for ce

* Update ce_aaa_server.py

* Add files via upload

modify doc

* Add files via upload

Compatible with Python 3 and fix bugs

* Add files via upload

Compatible with Python 3 and fix bugs

* Add files via upload

Cancellation of change

* Update ce_netconf.py

It is a bug that response has no xml attribute:line 183

* Add files via upload

* Add files via upload

Compatible with Python 3 and fix bugs

* updatp ce_config.py

a bug for this module.
2019-04-17 12:51:58 +05:30
f8bebc61c8 ansible-test yamllint: fix UnicodeDecodeError (#55364)
* ansible-test yamllint: fix UnicodeDecodeError

* Conditional fix
2019-04-17 09:13:53 +02:00
dcbfa60413 Change to fix issue found while cloning template with opaque network (#55375)
Fixing Format issues in yml files. Check have failed

Signed-off-by: pgbidkar <pbidkar@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-17 11:18:17 +05:30
22f666c962 fix sample in docs (#55420) 2019-04-17 01:41:58 -04:00
339a0f4a8c vmware_datastore_facts: don't nodify dict in iter (#54869) (#54870)
With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes ##54869
2019-04-16 23:09:55 -04:00
bd0792397b Fix uri tasks (#55403)
* Fix uri tasks

* Fix apt task to install firewalld

* Fix invalid option in package_facts - ci_complete
2019-04-17 11:28:01 +10:00
fdf9df89f5 psrp - Fix raw and script tests for connection plugin (#55357)
* psrp - Fix raw and script tests for connection plugin

* Fix error propagation with raw in psrp

* uncomment test
2019-04-17 09:01:28 +10:00
49655a452d psrp - fix test_command rc for win_reboot (#55354) 2019-04-17 08:38:42 +10:00
52946c49a4 psrp - Fix fetch for large files (#55351)
* psrp - Fix fetch for large files

* Fix typo
2019-04-17 08:19:33 +10:00
33c2a9cea7 win_whoami - Fix tests to work over psrp (#55352) 2019-04-17 08:18:20 +10:00
15c331cb48 win_feature - get tests working on psrp (#55353) 2019-04-17 08:18:03 +10:00
aa8d23b42f ensure facts marked as unsafe (#55326)
dont rely on plugin layer to do so
2019-04-16 15:50:52 -04:00
ca83a5c110 Version in deprecate calls should be a string (#55395)
* Version in deprecate calls should be a string. Fixes #55312. Fixes #55313. Fixes #55314. Fixes #55315. Fixes #55316. Fixes #55317.

* Add changelog fragment
2019-04-16 14:40:20 -05:00
07443a2bcd Address 2.9 uri deprecations (#55330)
* Address 2.9 uri deprecations. Fixes #55310

* Add changelog fragment
2019-04-16 14:17:03 -05:00
9f83139dcb Don't register tests as filters (#55332)
* Don't register tests as filters. Fixes #55319

* Remove tests for deprecated functionality

* Remove no-tests-as-filters sanity tests

* Remove docs too

* Revert "Remove docs too"

This reverts commit 7daf457a74.

* Make no-tests-as-filters doc an orphan
2019-04-16 14:10:14 -05:00
960df24272 include windows server 2019 in supported hosts (#55367)
<!--- Your description here -->

+label: docsite_pr
2019-04-16 14:00:33 -05:00
b4e83642c8 Properly reset timezone in user test when it was originally n/a (#55389) 2019-04-16 14:12:13 -04:00
da1f86a40f docs/docsite: minor fixes in docs/docsite/README.md (#55356)
Added inline markup to important references. Fixed minor spelling error.

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
2019-04-16 11:46:01 -05:00
395d471065 Docs: adding stub page for module/plugin aliases (#54448)
* Adding stub pages for deprecated module/plugin aliases.
2019-04-16 11:37:28 -05:00
272dceef42 ec2_launch_template - fix spelling mistake (#55383) 2019-04-16 11:45:12 -04:00
4ec8599c38 apt: remove deprecated installed/removed aliases (#55338)
* apt: remove deprecated installed/removed aliases

Fixes #55311
2019-04-16 11:42:53 -04:00
9495ddbc21 ACI: Cleanup deprecated boolean behaviour (#55207)
* ACI: Cleanup deprecated boolean behaviour

* Remove from sanity ignore list
2019-04-16 14:13:24 +02:00
521e62aa38 Update set_module_args in unit test docs (#55244)
* Update docs/docsite/rst/dev_guide/testing_units_modules.rst
`set_unit_args()` should be imported and used in the unit test documentation. 

Co-Authored-By: kbreit <kevin.breit@kevinbreit.net>
2019-04-15 17:27:27 -05:00
b28c73af62 Fixes solaris (sunos) uptime in ansible facts module (#54626)
* correct uptime on solaris by using system boot_time instead of snaptime
* add unit test
2019-04-15 18:01:24 -04:00
91a664a93e Gce migration docs (#51838)
* migration docs for gce, with example playbook

* Update docs/docsite/rst/scenario_guides/guide_gce.rst

Co-Authored-By: rambleraptor <alexstephen@google.com>
2019-04-15 16:30:36 -05:00
a005dcfbbd Add example for full path on unit tests (#55243)
Docs: adds an example when a full path is needed for unit tests, with module_utils, etc.
2019-04-15 16:20:14 -05:00
04cae4134f Bump deps for ntlm-auth and PSScriptAnalyzer (#55269) 2019-04-16 06:43:41 +10:00
65dcb4242a Fix deprecated issue creator (#55327) 2019-04-15 15:28:25 -05:00
46420dd21a Clarify fact_path configurable in ansible.cfg (#54992)
Docs: Clarify that `fact_path` can be configured in `ansible.cfg`; uppercase two acronyms.
2019-04-15 15:21:00 -05:00
83f20e0ea0 Fixed wrong variable specification format in examples (#55252)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-04-15 15:18:11 -05:00
720f62bf85 Improving documentation of the aws_ec2 inventory plugin (#55255) 2019-04-15 15:16:21 -05:00
7efb952825 Adding missing comma (#55254) 2019-04-15 15:02:26 -05:00
3003954415 Update unit testing docs (#55272)
* Updated links
* Updated indentation
* Fixed typos

Fixes: #55242

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-15 14:27:06 -05:00
a8955b0c7c Revert "Disable hcloud tests until issues are resolved."
This reverts commit 216cd86cb8.
2019-04-15 11:58:00 -07:00
fb3cc7f687 meraki_vlan - Remove unnecessary API calls when net_id is specified (#54939)
* Remove unnecessary API calls when net_id is specified

* Remove temp_get_nets commented out code
2019-04-15 19:53:19 +01:00
2ef4ba3b4d Fix ansible-test unicode error with redact option. 2019-04-15 11:36:00 -07:00
f8834c5339 Template: Example of SELinux context type (#54861)
* Update template.py with an example using selinux with a suggestion of how to get the proper file context (cheating!)
2019-04-15 12:06:48 -05:00
e90df4b566 DOCS: Update "connections" data type (#55290)
The k8s plugin expects the "connections" field to be a list - current docs examples trigger:
 [WARNING]:  * Failed to parse {...}/inventory.yml with k8s plugin: Expecting connections to be a list.

Updated examples for `host` and  `namespaces` to reflect this.
2019-04-15 10:18:09 -05:00
f8c47262c4 postgresql SSL related tests (#55288)
* postgresql SSL tests

* postgresql SSL tests, added link to officiall doc
2019-04-15 14:19:22 +01:00
f88b2cbe59 Use different headers for each HTTP method (#55193) 2019-04-15 11:04:18 +01:00
4190985995 postgresql_slot - sslrootcert fix (#55277) 2019-04-15 10:56:25 +01:00
cb5c57bcd5 openssl_csr: fix idempotency problems (#55142)
* Add test for generating a CSR with everything, and testing idempotency.

* Proper SAN normalization before comparison.

* Fix check in cryptography backend.

* Convert SANs to text. Update comments.

* Add changelog.
2019-04-15 09:15:08 +02:00
91e808eed2 azure_rm_subnet: fix CI error for deleting the azure_tags (#55276) 2019-04-15 15:14:18 +08:00
32345641e7 azure_rm_subnet: remove documentation that says it supports tags (#55233) 2019-04-15 11:02:53 +08:00
7191d45885 VMware: vmware_tools tls warning fixes (#55187)
* vmware_tools: remove silence_tls_warnings option

* attempt import of bundled urllib3
2019-04-14 19:58:45 +05:30
36ab96e4a9 Fix minor documentation error: base64 -> b64encode (#55257)
* Fix minor documentation error: base64 -> b64encode

* Fix minor documentation error: base64 -> b64encode
2019-04-14 05:30:27 -04:00
7599229310 Rebalance Azure tests. 2019-04-12 16:03:08 -07:00
d64b17731d docker_container: improve log_options idempotency by converting to string (#54955)
* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.
2019-04-12 18:36:11 -04:00
6ff4547489 VMware: get_all_host_objs accepts list of host (#55146)
vmware_portgroup accepts list of hosts, get_all_host_objs API modified
to accept list of hosts.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-12 15:35:35 -07:00
216cd86cb8 Disable hcloud tests until issues are resolved. 2019-04-12 15:03:04 -07:00
837ea4b39f tag off long-running azure_rm_virtualnetworkgateway tests 2019-04-12 14:03:35 -07:00
6fff8e1d7e Fix spelling error in connection (#54957)
`connection` module utility had a spelling error. s/catergory/category
2019-04-12 16:53:59 -04:00
b4f41fd9e2 Document replacements (#55226)
* Document replacements

Document suggested replacement moduels for kubernetes, oc, and ec2_ami_find
modules in the porting guide

* remember the _module suffix
2019-04-12 13:50:41 -07:00
a1c8fc37e8 Remove modules which have ended their deprecation cycle
* Remove code but leave the metadata so that they can be listed as
  removed in documentation.
* Remove removed modules from validate-modules ignore
* Remove unittests for the removed nodules
* Remove links to removed modules and add list of removed moduels to the
  2.9 porting guide
2019-04-12 12:57:35 -07:00
e5a31e81b6 Add a script to generate a new porting guide
* porting-guide.py is allowed to be Python-3.6+ as it will only be run
  by release engineers
2019-04-12 12:57:35 -07:00
bc955b9d60 Cleanup the tree for post-2.8-branch
After branch, we do the following tasks:
* Remove all old changelog fragments.  The devel tree starts fresh.
* Remove all old generated changelog info (CHANGELOG-v2.8.rst and .changes.yaml)
* Set the new codename and version in release.py
2019-04-12 12:57:35 -07:00
a4d0c24bbf Fix ansible-test inventory and vars path handling. (#55186)
* Fix ansible-test inventory and vars path handling.
* Improve explanation for missing commit.
2019-04-12 11:52:44 -07:00
39445786ff Bugfixes when removing a tenant- Module reported changed when tenant was not removed.- Script error when removing a non existing tenant without parent_id (#55110) 2019-04-12 13:25:33 -04:00
daaea17801 Fixed incorrect response removing a group (#55116) 2019-04-12 13:25:18 -04:00
9f87552f06 add option to display per host start to default (#53819)
* add option to display per host start to default
2019-04-12 12:42:38 -04:00
5eb3117822 Added the OnFailure option to the AWS CloudFormation module (#52431)
* Added the OnFailure option to the AWS CloudFormation module

* Added unit tests for CloudFormation `on_create_failure`
2019-04-12 09:18:06 -07:00
e40832df84 become mixin is no more (#54002)
* become mixin is no more
  since sudo/su keywords are removed in 2.9 .. no need to keep this code around
 * also don't need test for code that is removed
 * made preprocess_data on base noop
   its not used by anything anymore, but kept for backwards compat since other methods of same name are used
2019-04-12 12:13:55 -04:00
9ddde6b27f AWS: add ec2_transit_gateway_info module (#54460)
* AWS: add ec2_transit_gateway_info module

* move info module test to main module and ensure unique description for parallel tests

* add type designators to module options in documentation

* assign results and return instead of exit.  Add elements directive available with ansible 2.8

* assign results and return instead of exit

* get() method superfluous for module.params

* correct return type in documentation for ASN and format the sample for Tag correctly

* added random uid to test description - removing unstable alias

* change random uuid to resource_prefix to improve source of object identification in testing
2019-04-13 01:35:39 +10:00
d790285e80 postgresql_idx: improved doc, tests, remove useless lines from code (#55131)
* postgresql_idx: improve doc

* postgresql_idx: improve doc, removed unuseless rows from code

* postgresql_idx: misc doc fix

* postgresql_idx: moved common params where they were

* postgresql_idx: moved common params where they were 2
2019-04-12 14:15:21 +01:00
6273574eb4 Fix ec2_eip parameter logic (#55194) 2019-04-12 21:40:25 +10:00
6039ff9a24 win_domain - fix for checking for domain on new host (#55195) 2019-04-12 14:14:49 +10:00
a5f13dd361 ec2_group: docs: fix example for deletion by group ID (#55169)
requires the region for the example task to work
2019-04-11 18:53:32 -05:00
05fe9ef816 vmware_tools: ignore absence of urllib3 2019-04-11 16:29:44 -07:00
f40778cae3 Update documentation of filetree to mention limits of 'src' attribute (#54347)
* Filetree plugin does not return the 'src' attribute when `item.state` is set to `directory`

Error is `'dict object' has no attribute 'src'`. See https://github.com/ansible/ansible/issues/51513#issuecomment-459150769 .

* Update filetree.py
2019-04-11 16:39:56 -05:00
04220478da Fewer examples use connection: local in docs (#55133)
* Fewer connection: local lines in module examples and scenario guides

The line 'connection: local' is not required. See
./docs/docsite/rst/inventory/implicit_localhost.rst
2019-04-11 16:28:14 -05:00
698d2454c7 Fix access_logs_s3_prefix leading/trailing slash (#55148)
- Add documentation regarding restrictions on access_logs_s3_prefix (cannot have a leading or trailing slash)
2019-04-11 16:07:17 -05:00
adc0d2cd83 fixes an edge case where order of devices parameters breaks idempotency (#55181)
code correction for aggregates in bigip_gtm_pool_member and bigip_pool to be in line with established patterns
2019-04-11 12:51:16 -07:00
30a216bf78 Remove unneccessary line in config section of purefa_facts (#55164) 2019-04-11 15:04:25 -04:00
6579dfda17 Correct plugin loader context for persistent (#54860)
* Correct plugin loader context for persistent
2019-04-11 14:32:52 -04:00
27a3ec3a12 Don't use SSLEOFError in vmware_tools.py 2019-04-11 10:17:59 -07:00
15473 changed files with 216334 additions and 1770494 deletions

View File

@ -0,0 +1,252 @@
trigger:
batch: true
branches:
include:
- devel
- stable-*
pr:
autoCancel: true
branches:
include:
- devel
- stable-*
schedules:
- cron: 0 7 * * *
displayName: Nightly
always: true
branches:
include:
- devel
- stable-*
variables:
- name: checkoutPath
value: ansible
- name: coverageBranches
value: devel
- name: pipelinesCoverage
value: coverage
- name: entryPoint
value: test/utils/shippable/shippable.sh
- name: fetchDepth
value: 500
resources:
containers:
- container: default
image: quay.io/ansible/azure-pipelines-test-container:1.9.0
pool: Standard
stages:
- stage: Sanity
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Test {0}
testFormat: sanity/{0}
targets:
- test: 1
- test: 2
- test: 3
- test: 4
- test: 5
- stage: Units
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: units/{0}
targets:
- test: 2.6
- test: 2.7
- test: 3.5
- test: 3.6
- test: 3.7
- test: 3.8
- test: 3.9
- stage: Windows
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Server {0}
testFormat: windows/{0}/1
targets:
- test: 2012
- test: 2012-R2
- test: 2016
- test: 2019
- stage: Remote
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
targets:
- name: macOS 11.1
test: macos/11.1
- name: RHEL 7.9
test: rhel/7.9
- name: RHEL 8.2
test: rhel/8.2
- name: FreeBSD 11.1
test: freebsd/11.1
- name: FreeBSD 12.1
test: freebsd/12.1
groups:
- 1
- 2
- 3
- 4
- 5
- stage: Docker
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
testFormat: linux/{0}
targets:
- name: CentOS 6
test: centos6
- name: CentOS 7
test: centos7
- name: CentOS 8
test: centos8
- name: Fedora 31
test: fedora31
- name: Fedora 32
test: fedora32
- name: openSUSE 15 py2
test: opensuse15py2
- name: openSUSE 15 py3
test: opensuse15
- name: Ubuntu 16.04
test: ubuntu1604
- name: Ubuntu 18.04
test: ubuntu1804
- name: Ubuntu 20.04
test: ubuntu2004
groups:
- 1
- 2
- 3
- 4
- 5
- stage: Fallaxy
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: fallaxy/{0}/1
targets:
- test: 2.7
- test: 3.6
- stage: Generic
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: generic/{0}/1
targets:
- test: 2.7
- test: 3.6
- stage: Incidental_Remote
displayName: Incidental Remote
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
testFormat: i/{0}
targets:
- name: OS X 10.11
test: osx/10.11
- name: RHEL 7.9
test: rhel/7.9
- name: RHEL 8.2
test: rhel/8.2
- name: FreeBSD 11.1
test: freebsd/11.1
- name: FreeBSD 12.1
test: freebsd/12.1
- stage: Incidental_Docker
displayName: Incidental Docker
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
testFormat: i/linux/{0}
targets:
- name: CentOS 6
test: centos6
- name: CentOS 7
test: centos7
- name: CentOS 8
test: centos8
- name: Fedora 31
test: fedora31
- name: Fedora 32
test: fedora32
- name: openSUSE 15 py2
test: opensuse15py2
- name: openSUSE 15 py3
test: opensuse15
- name: Ubuntu 16.04
test: ubuntu1604
- name: Ubuntu 18.04
test: ubuntu1804
- name: Ubuntu 20.04
test: ubuntu2004
- stage: Incidental_Windows
displayName: Incidental Windows
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Server {0}
testFormat: i/windows/{0}
targets:
- test: 2012
- test: 2012-R2
- test: 2016
- test: 2019
- stage: Incidental
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
testFormat: i/{0}/1
targets:
- name: IOS Python
test: ios/csr1000v/
- name: VyOS Python 2.7
test: vyos/1.1.8/2.7
- name: VyOS Python 3.6
test: vyos/1.1.8/3.6
- name: AWS Python 2.7
test: aws/2.7
- name: AWS Python 3.6
test: aws/3.6
- name: Cloud Python
test: cloud/
- stage: Summary
condition: succeededOrFailed()
dependsOn:
- Sanity
- Units
- Windows
- Remote
- Docker
- Fallaxy
- Generic
- Incidental_Remote
- Incidental_Docker
- Incidental_Windows
- Incidental
jobs:
- template: templates/coverage.yml

View File

@ -0,0 +1,20 @@
#!/usr/bin/env bash
# Aggregate code coverage results for later processing.
set -o pipefail -eu
agent_temp_directory="$1"
PATH="${PWD}/bin:${PATH}"
mkdir "${agent_temp_directory}/coverage/"
options=(--venv --venv-system-site-packages --color -v)
ansible-test coverage combine --export "${agent_temp_directory}/coverage/" "${options[@]}"
if ansible-test coverage analyze targets generate --help >/dev/null 2>&1; then
# Only analyze coverage if the installed version of ansible-test supports it.
# Doing so allows this script to work unmodified for multiple Ansible versions.
ansible-test coverage analyze targets generate "${agent_temp_directory}/coverage/coverage-analyze-targets.json" "${options[@]}"
fi

View File

@ -0,0 +1,60 @@
#!/usr/bin/env python
"""
Combine coverage data from multiple jobs, keeping the data only from the most recent attempt from each job.
Coverage artifacts must be named using the format: "Coverage $(System.JobAttempt) {StableUniqueNameForEachJob}"
The recommended coverage artifact name format is: Coverage $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)
Keep in mind that Azure Pipelines does not enforce unique job display names (only names).
It is up to pipeline authors to avoid name collisions when deviating from the recommended format.
"""
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import os
import re
import shutil
import sys
def main():
"""Main program entry point."""
source_directory = sys.argv[1]
if '/ansible_collections/' in os.getcwd():
output_path = "tests/output"
else:
output_path = "test/results"
destination_directory = os.path.join(output_path, 'coverage')
if not os.path.exists(destination_directory):
os.makedirs(destination_directory)
jobs = {}
count = 0
for name in os.listdir(source_directory):
match = re.search('^Coverage (?P<attempt>[0-9]+) (?P<label>.+)$', name)
label = match.group('label')
attempt = int(match.group('attempt'))
jobs[label] = max(attempt, jobs.get(label, 0))
for label, attempt in jobs.items():
name = 'Coverage {attempt} {label}'.format(label=label, attempt=attempt)
source = os.path.join(source_directory, name)
source_files = os.listdir(source)
for source_file in source_files:
source_path = os.path.join(source, source_file)
destination_path = os.path.join(destination_directory, source_file + '.' + label)
print('"%s" -> "%s"' % (source_path, destination_path))
shutil.copyfile(source_path, destination_path)
count += 1
print('Coverage file count: %d' % count)
print('##vso[task.setVariable variable=coverageFileCount]%d' % count)
print('##vso[task.setVariable variable=outputPath]%s' % output_path)
if __name__ == '__main__':
main()

View File

@ -0,0 +1,24 @@
#!/usr/bin/env bash
# Check the test results and set variables for use in later steps.
set -o pipefail -eu
if [[ "$PWD" =~ /ansible_collections/ ]]; then
output_path="tests/output"
else
output_path="test/results"
fi
echo "##vso[task.setVariable variable=outputPath]${output_path}"
if compgen -G "${output_path}"'/junit/*.xml' > /dev/null; then
echo "##vso[task.setVariable variable=haveTestResults]true"
fi
if compgen -G "${output_path}"'/bot/ansible-test-*' > /dev/null; then
echo "##vso[task.setVariable variable=haveBotResults]true"
fi
if compgen -G "${output_path}"'/coverage/*' > /dev/null; then
echo "##vso[task.setVariable variable=haveCoverageData]true"
fi

View File

@ -0,0 +1,27 @@
#!/usr/bin/env bash
# Upload code coverage reports to codecov.io.
# Multiple coverage files from multiple languages are accepted and aggregated after upload.
# Python coverage, as well as PowerShell and Python stubs can all be uploaded.
set -o pipefail -eu
output_path="$1"
curl --silent --show-error https://ansible-ci-files.s3.us-east-1.amazonaws.com/codecov/codecov.sh > codecov.sh
for file in "${output_path}"/reports/coverage*.xml; do
name="${file}"
name="${name##*/}" # remove path
name="${name##coverage=}" # remove 'coverage=' prefix if present
name="${name%.xml}" # remove '.xml' suffix
bash codecov.sh \
-f "${file}" \
-n "${name}" \
-X coveragepy \
-X gcov \
-X fix \
-X search \
-X xcode \
|| echo "Failed to upload code coverage report to codecov.io: ${file}"
done

View File

@ -0,0 +1,15 @@
#!/usr/bin/env bash
# Generate code coverage reports for uploading to Azure Pipelines and codecov.io.
set -o pipefail -eu
PATH="${PWD}/bin:${PATH}"
if ! ansible-test --help >/dev/null 2>&1; then
# Install the devel version of ansible-test for generating code coverage reports.
# This is only used by Ansible Collections, which are typically tested against multiple Ansible versions (in separate jobs).
# Since a version of ansible-test is required that can work the output from multiple older releases, the devel version is used.
pip install https://github.com/ansible/ansible/archive/devel.tar.gz --disable-pip-version-check
fi
ansible-test coverage xml --stub --venv --venv-system-site-packages --color -v

View File

@ -0,0 +1,34 @@
#!/usr/bin/env bash
# Configure the test environment and run the tests.
set -o pipefail -eu
entry_point="$1"
test="$2"
read -r -a coverage_branches <<< "$3" # space separated list of branches to run code coverage on for scheduled builds
export COMMIT_MESSAGE
export COMPLETE
export COVERAGE
export IS_PULL_REQUEST
if [ "${SYSTEM_PULLREQUEST_TARGETBRANCH:-}" ]; then
IS_PULL_REQUEST=true
COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD^2)
else
IS_PULL_REQUEST=
COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD)
fi
COMPLETE=
COVERAGE=
if [ "${BUILD_REASON}" = "Schedule" ]; then
COMPLETE=yes
if printf '%s\n' "${coverage_branches[@]}" | grep -q "^${BUILD_SOURCEBRANCHNAME}$"; then
COVERAGE=yes
fi
fi
"${entry_point}" "${test}" 2>&1 | "$(dirname "$0")/time-command.py"

View File

@ -0,0 +1,25 @@
#!/usr/bin/env python
"""Prepends a relative timestamp to each input line from stdin and writes it to stdout."""
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import sys
import time
def main():
"""Main program entry point."""
start = time.time()
sys.stdin.reconfigure(errors='surrogateescape')
sys.stdout.reconfigure(errors='surrogateescape')
for line in sys.stdin:
seconds = time.time() - start
sys.stdout.write('%02d:%02d %s' % (seconds // 60, seconds % 60, line))
sys.stdout.flush()
if __name__ == '__main__':
main()

View File

@ -0,0 +1,39 @@
# This template adds a job for processing code coverage data.
# It will upload results to Azure Pipelines and codecov.io.
# Use it from a job stage that completes after all other jobs have completed.
# This can be done by placing it in a separate summary stage that runs after the test stage(s) have completed.
jobs:
- job: Coverage
displayName: Code Coverage
container: default
workspace:
clean: all
steps:
- checkout: self
fetchDepth: $(fetchDepth)
path: $(checkoutPath)
- task: DownloadPipelineArtifact@2
displayName: Download Coverage Data
inputs:
path: coverage/
patterns: "Coverage */*=coverage.combined"
- bash: .azure-pipelines/scripts/combine-coverage.py coverage/
displayName: Combine Coverage Data
- bash: .azure-pipelines/scripts/report-coverage.sh
displayName: Generate Coverage Report
condition: gt(variables.coverageFileCount, 0)
- task: PublishCodeCoverageResults@1
inputs:
codeCoverageTool: Cobertura
# Azure Pipelines only accepts a single coverage data file.
# That means only Python or PowerShell coverage can be uploaded, but not both.
# Set the "pipelinesCoverage" variable to determine which type is uploaded.
# Use "coverage" for Python and "coverage-powershell" for PowerShell.
summaryFileLocation: "$(outputPath)/reports/$(pipelinesCoverage).xml"
displayName: Publish to Azure Pipelines
condition: gt(variables.coverageFileCount, 0)
- bash: .azure-pipelines/scripts/publish-codecov.sh "$(outputPath)"
displayName: Publish to codecov.io
condition: gt(variables.coverageFileCount, 0)
continueOnError: true

View File

@ -0,0 +1,55 @@
# This template uses the provided targets and optional groups to generate a matrix which is then passed to the test template.
# If this matrix template does not provide the required functionality, consider using the test template directly instead.
parameters:
# A required list of dictionaries, one per test target.
# Each item in the list must contain a "test" or "name" key.
# Both may be provided. If one is omitted, the other will be used.
- name: targets
type: object
# An optional list of values which will be used to multiply the targets list into a matrix.
# Values can be strings or numbers.
- name: groups
type: object
default: []
# An optional format string used to generate the job name.
# - {0} is the name of an item in the targets list.
- name: nameFormat
type: string
default: "{0}"
# An optional format string used to generate the test name.
# - {0} is the name of an item in the targets list.
- name: testFormat
type: string
default: "{0}"
# An optional format string used to add the group to the job name.
# {0} is the formatted name of an item in the targets list.
# {{1}} is the group -- be sure to include the double "{{" and "}}".
- name: nameGroupFormat
type: string
default: "{0} - {{1}}"
# An optional format string used to add the group to the test name.
# {0} is the formatted test of an item in the targets list.
# {{1}} is the group -- be sure to include the double "{{" and "}}".
- name: testGroupFormat
type: string
default: "{0}/{{1}}"
jobs:
- template: test.yml
parameters:
jobs:
- ${{ if eq(length(parameters.groups), 0) }}:
- ${{ each target in parameters.targets }}:
- name: ${{ format(parameters.nameFormat, coalesce(target.name, target.test)) }}
test: ${{ format(parameters.testFormat, coalesce(target.test, target.name)) }}
- ${{ if not(eq(length(parameters.groups), 0)) }}:
- ${{ each group in parameters.groups }}:
- ${{ each target in parameters.targets }}:
- name: ${{ format(format(parameters.nameGroupFormat, parameters.nameFormat), coalesce(target.name, target.test), group) }}
test: ${{ format(format(parameters.testGroupFormat, parameters.testFormat), coalesce(target.test, target.name), group) }}

View File

@ -0,0 +1,45 @@
# This template uses the provided list of jobs to create test one or more test jobs.
# It can be used directly if needed, or through the matrix template.
parameters:
# A required list of dictionaries, one per test job.
# Each item in the list must contain a "job" and "name" key.
- name: jobs
type: object
jobs:
- ${{ each job in parameters.jobs }}:
- job: test_${{ replace(replace(replace(job.test, '/', '_'), '.', '_'), '-', '_') }}
displayName: ${{ job.name }}
container: default
workspace:
clean: all
steps:
- checkout: self
fetchDepth: $(fetchDepth)
path: $(checkoutPath)
- bash: .azure-pipelines/scripts/run-tests.sh "$(entryPoint)" "${{ job.test }}" "$(coverageBranches)"
displayName: Run Tests
- bash: .azure-pipelines/scripts/process-results.sh
condition: succeededOrFailed()
displayName: Process Results
- bash: .azure-pipelines/scripts/aggregate-coverage.sh "$(Agent.TempDirectory)"
condition: eq(variables.haveCoverageData, 'true')
displayName: Aggregate Coverage Data
- task: PublishTestResults@2
condition: eq(variables.haveTestResults, 'true')
inputs:
testResultsFiles: "$(outputPath)/junit/*.xml"
displayName: Publish Test Results
- task: PublishPipelineArtifact@1
condition: eq(variables.haveBotResults, 'true')
displayName: Publish Bot Results
inputs:
targetPath: "$(outputPath)/bot/"
artifactName: "Bot $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)"
- task: PublishPipelineArtifact@1
condition: eq(variables.haveCoverageData, 'true')
displayName: Publish Coverage Data
inputs:
targetPath: "$(Agent.TempDirectory)/coverage/"
artifactName: "Coverage $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)"

View File

@ -1,26 +0,0 @@
# This configuration file is used for manual execution of coverage
# as well as for tests run through ansible-test.
[run]
branch = True
# Enable concurrency. This also enables parallel mode, which results in
# multiple coverage files being created. Concurrency allows us to collect
# results from multiple tests simultaneously, as well as supporting multiple
# test runs, such as from integration tests.
concurrency = multiprocessing
parallel = True
# When running tests through ansible-test, this option is overridden by
# the COVERAGE_FILE environment variable. This option is present for
# convenience when running coverage manually from this directory.
data_file = test/results/coverage/coverage
# Don't collect or report code coverage from files matching these patterns.
omit =
*/python*/dist-packages/*
*/python*/site-packages/*
*/python*/distutils/*
*/pyshared/*
*/pytest
*/AnsiballZ_*.py

29923
.github/BOTMETA.yml vendored

File diff suppressed because it is too large Load Diff

26
.github/ISSUE_TEMPLATE/config.yml vendored Normal file
View File

@ -0,0 +1,26 @@
# Ref: https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
blank_issues_enabled: true # default
contact_links:
- name: 🔐 Security bug report 🔥
url: https://docs.ansible.com/ansible/latest/community/reporting_bugs_and_features.html?utm_medium=github&utm_source=issue_template_chooser
about: |
Please learn how to report security vulnerabilities here.
For all security related bugs, email security@ansible.com
instead of using this issue tracker and you will receive
a prompt response.
For more information, see
https://docs.ansible.com/ansible/latest/community/reporting_bugs_and_features.html
- name: 📝 Ansible Code of Conduct
url: https://docs.ansible.com/ansible/latest/community/code_of_conduct.html?utm_medium=github&utm_source=issue_template_chooser
about: ❤ Be nice to other members of the community. ☮ Behave.
- name: 💬 Talks to the community
url: https://docs.ansible.com/ansible/latest/community/communication.html?utm_medium=github&utm_source=issue_template_chooser#mailing-list-information
about: Please ask and answer usage questions here
- name: ⚡ Working groups
url: https://github.com/ansible/community/wiki
about: Interested in improving a specific area? Become a part of a working group!
- name: 💼 For Enterprise
url: https://www.ansible.com/products/engine?utm_medium=github&utm_source=issue_template_chooser
about: Red Hat offers support for the Ansible Automation Platform

View File

@ -1,8 +0,0 @@
---
name: 🔥 Security bug report
about: How to report security vulnerabilities
---
For all security related bugs, email security@ansible.com instead of using this issue tracker and you will receive a prompt response.
For more information, see https://docs.ansible.com/ansible/latest/community/reporting_bugs_and_features.html

12
.github/RELEASE_NAMES.yml vendored Normal file
View File

@ -0,0 +1,12 @@
---
- 2.10.0 When the Levee Breaks
- 2.9.0 Immigrant Song
- 2.8.0 How Many More Times
- 2.7.0 In the Light
- 2.6.0 Heartbreaker
- 2.5.0 Kashmir
- 2.4.0 Dancing Days
- 2.3.0 Ramble On
- 2.2.0 The Battle of Evermore
- 2.1.0 The Song Remains the Same
- 2.0.0 Over the Hills and Far Away

15
.github/SECURITY.md vendored Normal file
View File

@ -0,0 +1,15 @@
# Security Policy
## Supported Versions
Ansible applies security fixes according to the 3-versions-back support
policy. Please find more information in [our docs](
https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#release-status
).
## Reporting a Vulnerability
We encourage responsible disclosure practices for security
vulnerabilities. Please read our [policies for reporting bugs](
https://docs.ansible.com/ansible/devel/community/reporting_bugs_and_features.html#reporting-a-bug
) if you want to report a security issue that might affect Ansible.

25
.gitignore vendored
View File

@ -32,10 +32,16 @@ docs/man/man3/*
docs/docsite/_build
docs/docsite/*.html
docs/docsite/htmlout
docs/docsite/rst/conf.py
docs/docsite/rst/index.rst
docs/docsite/rst/cli/ansible-*.rst
docs/docsite/rst/cli/ansible.rst
docs/docsite/rst/dev_guide/collections_galaxy_meta.rst
docs/docsite/rst/dev_guide/testing/sanity/index.rst.new
docs/docsite/rst/modules/*.rst
docs/docsite/rst/collections/*.rst
!docs/docsite/rst/collections/all_plugins.rst
docs/docsite/rst/collections/*/*.rst
docs/docsite/rst/playbooks_directives.rst
docs/docsite/rst/plugins_by_category.rst
docs/docsite/rst/plugins/*/*.rst
@ -63,6 +69,7 @@ credentials.yml
results.xml
coverage.xml
/test/units/cover-html
/test/integration/inventory
/test/integration/targets/*/backup/
/test/cache/*
# Development
@ -70,24 +77,22 @@ coverage.xml
venv
Vagrantfile
.vagrant
ansible.egg-info/
# Backwards compatibility with `stable-2.9` and earlier branches.
# Also used in the `devel` branch during early Ansible 2.10 development.
/lib/ansible.egg-info/
# First used in the `devel` branch during Ansible 2.10 development.
/lib/ansible_base.egg-info/
/shippable/
/test/integration/cloud-config-*.*
!/test/integration/cloud-config-*.*.template
.python-version
/hacking/tests/selinux/*.mod
/hacking/tests/selinux/*.pp
# Release directory
packaging/release/ansible_release
/.cache/
/test/results/coverage/*=coverage.*
/test/results/coverage/coverage*
/test/results/reports/coverage*.xml
/test/results/reports/coverage*/
/test/results/bot/*.json
/test/results/junit/*.xml
/test/results/logs/*.log
/test/results/data/*.json
/test/results/
/test/integration/cloud-config-aws.yml
/test/integration/inventory.remote
/test/integration/inventory.networking
/test/integration/inventory.winrm
/test/integration/cloud-config-aws.yml

View File

@ -1,10 +0,0 @@
Coding Guidelines
=================
Hi! Thanks for your interest in contributing to Ansible. We document our Coding Guidelines in the [Developer Guide](https://docs.ansible.com/ansible/devel/dev_guide/). We particularly suggest you review:
* [Contributing your module to Ansible](https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_checklist.html)
* [Development conventions, tips and pitfalls](https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html)
Our [Community Guide](https://docs.ansible.com/ansible/devel/community/) may also help you connect with the community of Ansible developers.

View File

@ -2,26 +2,38 @@ include README.rst
include COPYING
include SYMLINK_CACHE.json
include requirements.txt
include .coveragerc
include shippable.yml
include tox.ini
include bin/ansible-test
recursive-include docs *
include docs/docsite/rst/collections/all_plugins.rst
exclude docs/docsite/rst_warnings
exclude docs/docsite/rst/conf.py
exclude docs/docsite/rst/index.rst
recursive-exclude docs/docsite/_build *
recursive-exclude docs/docsite/_extensions *.pyc *.pyo
include examples/hosts
include examples/ansible.cfg
include examples/scripts/ConfigureRemotingForAnsible.ps1
include examples/scripts/upgrade_to_ps3.ps1
recursive-include lib/ansible/executor/powershell *
recursive-include lib/ansible/module_utils/csharp *
recursive-include lib/ansible/module_utils/powershell *
recursive-include lib/ansible/modules *
recursive-include lib/ansible/galaxy/data *
recursive-include docs *
recursive-include licenses *
recursive-include lib/ansible/executor/powershell *.ps1
recursive-include lib/ansible/module_utils/csharp *.cs
recursive-include lib/ansible/module_utils/powershell *.psm1
recursive-include lib/ansible/modules/windows *.ps1
recursive-include lib/ansible/galaxy/data *.yml *.j2 README.md ansible.cfg inventory .git_keep
recursive-include lib/ansible/config *.yml
recursive-include licenses *.txt
recursive-include packaging *
recursive-include test *
recursive-include test/ansible_test *.py Makefile
recursive-include test/integration *
recursive-include test/lib/ansible_test/config *.template
recursive-include test/lib/ansible_test/_data *.cfg *.ini *.json *.ps1 *.psd1 *.py *.sh *.txt *.yml coveragerc inventory
recursive-include test/lib/ansible_test/_data/injector ansible ansible-config ansible-connection ansible-console ansible-doc ansible-galaxy ansible-playbook ansible-pull ansible-test ansible-vault pytest
recursive-include test/lib/ansible_test/_data/sanity/validate-modules validate-modules
recursive-include test/sanity *.json *.py *.txt
recursive-include test/support *.py *.ps1 *.psm1 *.cs
exclude test/sanity/code-smell/botmeta.*
recursive-include test/units *
include Makefile
include MANIFEST.in
include changelogs/CHANGELOG*.rst
include contrib/README.md
recursive-include contrib/inventory *
exclude test/sanity/code-smell/botmeta.*
include changelogs/changelog.yaml
recursive-include hacking/build_library *.py
include hacking/build-ansible.py

View File

@ -1,5 +0,0 @@
# Module Maintainer Guidelines
The Ansible Module Maintainer Guidelines can now be found in the [official Ansible community guide](https://docs.ansible.com/ansible/latest/community/maintainers.html).
See also the [Developers Guide](https://docs.ansible.com/ansible/latest/dev_guide/)

160
Makefile
View File

@ -5,21 +5,20 @@
# useful targets:
# make clean ---------------- clean up
# make webdocs -------------- produce ansible doc at docs/docsite/_build/html
# make coredocs ------------- produce core doc at docs/docsite/_build/html
# make sdist ---------------- produce a tarball
# make srpm ----------------- produce a SRPM
# make rpm ----------------- produce RPMs
# make deb-src -------------- produce a DEB source
# make deb ------------------ produce a DEB
# make docs ----------------- rebuild the manpages (results are checked in)
# make tests ---------------- run the tests (see https://docs.ansible.com/ansible/devel/dev_guide/testing_units.html for requirements)
# make pyflakes, make pep8 -- source code checks
########################################################
# variable section
NAME = ansible
NAME = ansible-base
OS = $(shell uname -s)
PREFIX ?= '/usr/local'
SDIST_DIR ?= 'dist'
# This doesn't evaluate until it's called. The -D argument is the
# directory of the target file ($@), kinda like `dirname`.
@ -33,9 +32,7 @@ ASCII2MAN = @echo "ERROR: rst2man from docutils command is not installed but is
endif
PYTHON=python
GENERATE_CLI = $(PYTHON) docs/bin/generate_man.py
SITELIB = $(shell $(PYTHON) -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")
GENERATE_CLI = hacking/build-ansible.py generate-man
# fetch version from project release.py as single source-of-truth
VERSION := $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --raw || echo error)
@ -43,15 +40,9 @@ ifeq ($(findstring error,$(VERSION)), error)
$(error "version_helper failed")
endif
MAJOR_VERSION := $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --majorversion)
CODENAME := $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --codename)
# if a specific release was not requested, set to 1 (RPMs have "fancier" logic for this further down)
RELEASE ?= 1
# Get the branch information from git
ifneq ($(shell which git),)
GIT_DATE := $(shell git log -n 1 --format="%ai")
GIT_DATE := $(shell git log -n 1 --format="%ci")
GIT_HASH := $(shell git log -n 1 --format="%h")
GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD | sed 's/[-_.\/]//g')
GITINFO = .$(GIT_HASH).$(GIT_BRANCH)
@ -60,7 +51,7 @@ GITINFO = ""
endif
ifeq ($(shell echo $(OS) | egrep -c 'Darwin|FreeBSD|OpenBSD|DragonFly'),1)
DATE := $(shell date -j -r $(shell git log -n 1 --format="%at") +%Y%m%d%H%M)
DATE := $(shell date -j -r $(shell git log -n 1 --format="%ct") +%Y%m%d%H%M)
CPUS ?= $(shell sysctl hw.ncpu|awk '{print $$2}')
else
DATE := $(shell date --utc --date="$(GIT_DATE)" +%Y%m%d%H%M)
@ -98,32 +89,6 @@ PBUILDER_CACHE_DIR = /var/cache/pbuilder
PBUILDER_BIN ?= pbuilder
PBUILDER_OPTS ?= --debootstrapopts --variant=buildd --architecture $(PBUILDER_ARCH) --debbuildopts -b
# RPM build parameters
RPMSPECDIR= packaging/rpm
RPMSPEC = $(RPMSPECDIR)/ansible.spec
RPMDIST = $(shell rpm --eval '%{?dist}')
ifneq ($(OFFICIAL),yes)
RPMRELEASE = 100.git$(DATE)$(GITINFO)
endif
ifeq ($(PUBLISH),nightly)
# https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
RPMRELEASE = $(RELEASE).$(DATE)git.$(GIT_HASH)
endif
RPMVERSION ?= $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --baseversion)
RPMRELEASE ?= $(shell $(PYTHON) packaging/release/versionhelper/version_helper.py --rpmrelease)
RPMNVR = "$(NAME)-$(RPMVERSION)-$(RPMRELEASE)$(RPMDIST)$(REPOTAG)"
# MOCK build parameters
MOCK_BIN ?= mock
MOCK_CFG ?=
# dynamically add repotag define only if specified
ifneq ($(REPOTAG),)
EXTRA_RPM_DEFINES += --define "repotag $(REPOTAG)"
endif
# ansible-test parameters
ANSIBLE_TEST ?= bin/ansible-test
TEST_FLAGS ?=
@ -149,18 +114,10 @@ tests:
tests-py3:
$(ANSIBLE_TEST) units -v --python $(PYTHON3_VERSION) $(TEST_FLAGS)
.PHONY: tests-nonet
tests-nonet:
$(ANSIBLE_TEST) units -v --python $(PYTHON_VERSION) $(TEST_FLAGS) --exclude test/units/modules/network/
.PHONY: integration
integration:
$(ANSIBLE_TEST) integration -v --docker $(IMAGE) $(TARGET) $(TEST_FLAGS)
.PHONY: authors
authors:
sh hacking/authors.sh
# Regenerate %.1.rst if %.1.rst.in has been modified more
# recently than %.1.rst.
%.1.rst: %.1.rst.in
@ -172,24 +129,12 @@ authors:
%.1: %.1.rst lib/ansible/release.py
$(ASCII2MAN)
.PHONY: loc
loc:
sloccount lib library bin
.PHONY: pep8
pep8:
$(ANSIBLE_TEST) sanity --test pep8 --python $(PYTHON_VERSION) $(TEST_FLAGS)
.PHONY: pyflakes
pyflakes:
pyflakes lib/ansible/*.py lib/ansible/*/*.py bin/*
.PHONY: clean
clean:
@echo "Cleaning up distutils stuff"
rm -rf build
rm -rf dist
rm -rf lib/ansible.egg-info/
rm -rf lib/ansible*.egg-info/
@echo "Cleaning up byte compiled python stuff"
find . -type f -regex ".*\.py[co]$$" -delete
find . -type d -name "__pycache__" -delete
@ -209,15 +154,11 @@ clean:
rm -f test/units/.coverage*
rm -rf test/results/*/*
find test/ -type f -name '*.retry' -delete
@echo "Cleaning up RPM building stuff"
rm -rf MANIFEST rpm-build
@echo "Cleaning up Debian building stuff"
rm -rf debian
rm -rf deb-build
rm -rf docs/json
rm -rf docs/js
@echo "Cleaning up authors file"
rm -f AUTHORS.TXT
@echo "Cleaning up docsite"
$(MAKE) -C docs/docsite clean
@ -235,18 +176,19 @@ install_manpages:
.PHONY: sdist_check
sdist_check:
$(PYTHON) -c 'import setuptools, sys; sys.exit(int(not (tuple(map(int, setuptools.__version__.split("."))) > (39, 2, 0))))'
$(PYTHON) packaging/sdist/check-link-behavior.py
.PHONY: sdist
sdist: sdist_check clean docs
_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist
_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist --dist-dir=$(SDIST_DIR)
# Official releases generate the changelog as the last commit before the release.
# Snapshots shouldn't result in new checkins so the changelog is generated as
# part of creating the tarball.
.PHONY: snapshot
snapshot: sdist_check clean docs changelog
_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist
_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist --dist-dir=$(SDIST_DIR)
.PHONY: sdist_upload
sdist_upload: clean docs
@ -254,77 +196,7 @@ sdist_upload: clean docs
.PHONY: changelog
changelog:
PYTHONPATH=./lib packaging/release/changelogs/changelog.py release -vv && PYTHONPATH=./lib packaging/release/changelogs/changelog.py generate -vv
.PHONY: rpmcommon
rpmcommon: sdist
@mkdir -p rpm-build
@cp dist/*.gz rpm-build/
@cp $(RPMSPEC) rpm-build/$(NAME).spec
.PHONY: mock-srpm
mock-srpm: /etc/mock/$(MOCK_CFG).cfg rpmcommon
$(MOCK_BIN) -r $(MOCK_CFG) $(MOCK_ARGS) --resultdir rpm-build/ --bootstrap-chroot --old-chroot --buildsrpm --spec rpm-build/$(NAME).spec --sources rpm-build/ \
--define "rpmversion $(RPMVERSION)" \
--define "upstream_version $(VERSION)" \
--define "rpmrelease $(RPMRELEASE)" \
$(EXTRA_RPM_DEFINES)
@echo "#############################################"
@echo "Ansible SRPM is built:"
@echo rpm-build/*.src.rpm
@echo "#############################################"
.PHONY: mock-rpm
mock-rpm: /etc/mock/$(MOCK_CFG).cfg mock-srpm
$(MOCK_BIN) -r $(MOCK_CFG) $(MOCK_ARGS) --resultdir rpm-build/ --bootstrap-chroot --old-chroot --rebuild rpm-build/$(NAME)-*.src.rpm \
--define "rpmversion $(RPMVERSION)" \
--define "upstream_version $(VERSION)" \
--define "rpmrelease $(RPMRELEASE)" \
$(EXTRA_RPM_DEFINES)
@echo "#############################################"
@echo "Ansible RPM is built:"
@echo rpm-build/*.noarch.rpm
@echo "#############################################"
.PHONY: srpm
srpm: rpmcommon
@rpmbuild --define "_topdir %(pwd)/rpm-build" \
--define "_builddir %{_topdir}" \
--define "_rpmdir %{_topdir}" \
--define "_srcrpmdir %{_topdir}" \
--define "_specdir $(RPMSPECDIR)" \
--define "_sourcedir %{_topdir}" \
--define "upstream_version $(VERSION)" \
--define "rpmversion $(RPMVERSION)" \
--define "rpmrelease $(RPMRELEASE)" \
$(EXTRA_RPM_DEFINES) \
-bs rpm-build/$(NAME).spec
@rm -f rpm-build/$(NAME).spec
@echo "#############################################"
@echo "Ansible SRPM is built:"
@echo " rpm-build/$(RPMNVR).src.rpm"
@echo "#############################################"
.PHONY: rpm
rpm: rpmcommon
@rpmbuild --define "_topdir %(pwd)/rpm-build" \
--define "_builddir %{_topdir}" \
--define "_rpmdir %{_topdir}" \
--define "_srcrpmdir %{_topdir}" \
--define "_specdir $(RPMSPECDIR)" \
--define "_sourcedir %{_topdir}" \
--define "_rpmfilename $(RPMNVR).%%{ARCH}.rpm" \
--define "__python `which $(PYTHON)`" \
--define "upstream_version $(VERSION)" \
--define "rpmversion $(RPMVERSION)" \
--define "rpmrelease $(RPMRELEASE)" \
$(EXTRA_RPM_DEFINES) \
-ba rpm-build/$(NAME).spec
@rm -f rpm-build/$(NAME).spec
@echo "#############################################"
@echo "Ansible RPM is built:"
@echo " rpm-build/$(RPMNVR).noarch.rpm"
@echo "#############################################"
PYTHONPATH=./lib antsibull-changelog release -vv --use-ansible-doc && PYTHONPATH=./lib antsibull-changelog generate -vv --use-ansible-doc
.PHONY: debian
debian: sdist
@ -397,10 +269,18 @@ epub:
webdocs:
(cd docs/docsite/; CPUS=$(CPUS) $(MAKE) docs)
.PHONY: coredocs
coredocs:
(cd docs/docsite/; CPUS=$(CPUS) $(MAKE) coredocs)
.PHONY: linkcheckdocs
linkcheckdocs:
(cd docs/docsite/; CPUS=$(CPUS) $(MAKE) linkcheckdocs)
.PHONY: generate_rst
generate_rst: lib/ansible/cli/*.py
mkdir -p ./docs/man/man1/ ; \
PYTHONPATH=./lib $(GENERATE_CLI) --template-file=docs/templates/man.j2 --output-dir=docs/man/man1/ --output-format man lib/ansible/cli/*.py
$(GENERATE_CLI) --template-file=docs/templates/man.j2 --output-dir=docs/man/man1/ --output-format man lib/ansible/cli/*.py
docs: generate_rst

View File

@ -50,7 +50,7 @@ Get Involved
code to Ansible.
* Join a `Working Group
<https://github.com/ansible/community/wiki>`_, an organized community devoted to a specific technology domain or platform.
* Submit proposed a code update through a pull request to the ``devel`` branch.
* Submit a proposed code update through a pull request to the ``devel`` branch.
* Talk to us before making larger changes
to avoid duplicate efforts. This not only helps everyone
know what is going on, it also helps save time and effort if we decide
@ -58,13 +58,21 @@ Get Involved
* For a list of email lists, IRC channels and Working Groups, see the
`Communication page <https://docs.ansible.com/ansible/latest/community/communication.html>`_
Coding Guidelines
=================
We document our Coding Guidelines in the `Developer Guide <https://docs.ansible.com/ansible/devel/dev_guide/>`_. We particularly suggest you review:
* `Contributing your module to Ansible <https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_checklist.html>`_
* `Conventions, tips and pitfalls <https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html>`_
Branch Info
===========
* The ``devel`` branch corresponds to the release actively under development.
* The ``stable-2.X`` branches correspond to stable releases.
* For information about the active branches see the
`Ansible release and maintenance <https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html>`_ page.
* Create a branch based on ``devel`` and set up a `dev environment <https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#common-environment-setup>`_ if you want to open a PR.
* See the `Ansible release and maintenance <https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html>`_ page for information about active branches.
Roadmap
=======
@ -76,7 +84,7 @@ Authors
=======
Ansible was created by `Michael DeHaan <https://github.com/mpdehaan>`_
and has contributions from over 4000 users (and growing). Thanks everyone!
and has contributions from over 4700 users (and growing). Thanks everyone!
`Ansible <https://www.ansible.com>`_ is sponsored by `Red Hat, Inc.
<https://www.redhat.com>`_
@ -84,16 +92,16 @@ and has contributions from over 4000 users (and growing). Thanks everyone!
License
=======
GNU General Public License v3.0
GNU General Public License v3.0 or later
See `COPYING <COPYING>`_ to see the full text.
.. |PyPI version| image:: https://img.shields.io/pypi/v/ansible.svg
:target: https://pypi.org/project/ansible
.. |PyPI version| image:: https://img.shields.io/pypi/v/ansible-base.svg
:target: https://pypi.org/project/ansible-base
.. |Docs badge| image:: https://img.shields.io/badge/docs-latest-brightgreen.svg
:target: https://docs.ansible.com/ansible/latest/
.. |Build Status| image:: https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel
:target: https://app.shippable.com/projects/573f79d02a8192902e20e34b
.. |Build Status| image:: https://dev.azure.com/ansible/ansible/_apis/build/status/CI?branchName=stable-2.10
:target: https://dev.azure.com/ansible/ansible/_build/latest?definitionId=20&branchName=stable-2.10
.. |Chat badge| image:: https://img.shields.io/badge/chat-IRC-brightgreen.svg
:target: https://docs.ansible.com/ansible/latest/community/communication.html
.. |Code Of Conduct| image:: https://img.shields.io/badge/code%20of%20conduct-Ansible-silver.svg

View File

@ -1,155 +0,0 @@
#!/usr/bin/env python
# (c) 2012, Michael DeHaan <michael.dehaan@gmail.com>
#
# This file is part of Ansible
#
# Ansible is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Ansible is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
########################################################
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
__requires__ = ['ansible']
import os
import shutil
import sys
import traceback
from ansible import context
from ansible.errors import AnsibleError, AnsibleOptionsError, AnsibleParserError
from ansible.module_utils._text import to_text
# Used for determining if the system is running a new enough python version
# and should only restrict on our documented minimum versions
_PY3_MIN = sys.version_info[:2] >= (3, 5)
_PY2_MIN = (2, 6) <= sys.version_info[:2] < (3,)
_PY_MIN = _PY3_MIN or _PY2_MIN
if not _PY_MIN:
raise SystemExit('ERROR: Ansible requires a minimum of Python2 version 2.6 or Python3 version 3.5. Current version: %s' % ''.join(sys.version.splitlines()))
class LastResort(object):
# OUTPUT OF LAST RESORT
def display(self, msg, log_only=None):
print(msg, file=sys.stderr)
def error(self, msg, wrap_text=None):
print(msg, file=sys.stderr)
if __name__ == '__main__':
display = LastResort()
try: # bad ANSIBLE_CONFIG or config options can force ugly stacktrace
import ansible.constants as C
from ansible.utils.display import Display
except AnsibleOptionsError as e:
display.error(to_text(e), wrap_text=False)
sys.exit(5)
cli = None
me = os.path.basename(sys.argv[0])
try:
display = Display()
display.debug("starting run")
sub = None
target = me.split('-')
if target[-1][0].isdigit():
# Remove any version or python version info as downstreams
# sometimes add that
target = target[:-1]
if len(target) > 1:
sub = target[1]
myclass = "%sCLI" % sub.capitalize()
elif target[0] == 'ansible':
sub = 'adhoc'
myclass = 'AdHocCLI'
else:
raise AnsibleError("Unknown Ansible alias: %s" % me)
try:
mycli = getattr(__import__("ansible.cli.%s" % sub, fromlist=[myclass]), myclass)
except ImportError as e:
# ImportError members have changed in py3
if 'msg' in dir(e):
msg = e.msg
else:
msg = e.message
if msg.endswith(' %s' % sub):
raise AnsibleError("Ansible sub-program not implemented: %s" % me)
else:
raise
try:
args = [to_text(a, errors='surrogate_or_strict') for a in sys.argv]
except UnicodeError:
display.error('Command line args are not in utf-8, unable to continue. Ansible currently only understands utf-8')
display.display(u"The full traceback was:\n\n%s" % to_text(traceback.format_exc()))
exit_code = 6
else:
cli = mycli(args)
exit_code = cli.run()
except AnsibleOptionsError as e:
cli.parser.print_help()
display.error(to_text(e), wrap_text=False)
exit_code = 5
except AnsibleParserError as e:
display.error(to_text(e), wrap_text=False)
exit_code = 4
# TQM takes care of these, but leaving comment to reserve the exit codes
# except AnsibleHostUnreachable as e:
# display.error(str(e))
# exit_code = 3
# except AnsibleHostFailed as e:
# display.error(str(e))
# exit_code = 2
except AnsibleError as e:
display.error(to_text(e), wrap_text=False)
exit_code = 1
except KeyboardInterrupt:
display.error("User interrupted execution")
exit_code = 99
except Exception as e:
if C.DEFAULT_DEBUG:
# Show raw stacktraces in debug mode, It also allow pdb to
# enter post mortem mode.
raise
have_cli_options = bool(context.CLIARGS)
display.error("Unexpected Exception, this is probably a bug: %s" % to_text(e), wrap_text=False)
if not have_cli_options or have_cli_options and context.CLIARGS['verbosity'] > 2:
log_only = False
if hasattr(e, 'orig_exc'):
display.vvv('\nexception type: %s' % to_text(type(e.orig_exc)))
why = to_text(e.orig_exc)
if to_text(e) != why:
display.vvv('\noriginal msg: %s' % why)
else:
display.display("to see the full traceback, use -vvv")
log_only = True
display.display(u"the full traceback was:\n\n%s" % to_text(traceback.format_exc()), log_only=log_only)
exit_code = 250
finally:
# Remove ansible tmpdir
shutil.rmtree(C.DEFAULT_LOCAL_TMP, True)
sys.exit(exit_code)

1
bin/ansible Symbolic link
View File

@ -0,0 +1 @@
../lib/ansible/cli/scripts/ansible_cli_stub.py

View File

@ -1,335 +0,0 @@
#!/usr/bin/env python
# Copyright: (c) 2017, Ansible Project
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
__requires__ = ['ansible']
import fcntl
import hashlib
import os
import signal
import socket
import sys
import time
import traceback
import errno
import json
from contextlib import contextmanager
from ansible import constants as C
from ansible.module_utils._text import to_bytes, to_text
from ansible.module_utils.six import PY3
from ansible.module_utils.six.moves import cPickle, StringIO
from ansible.module_utils.connection import Connection, ConnectionError, send_data, recv_data
from ansible.module_utils.service import fork_process
from ansible.parsing.ajson import AnsibleJSONEncoder, AnsibleJSONDecoder
from ansible.playbook.play_context import PlayContext
from ansible.plugins.loader import connection_loader
from ansible.utils.path import unfrackpath, makedirs_safe
from ansible.utils.display import Display
from ansible.utils.jsonrpc import JsonRpcServer
def read_stream(byte_stream):
size = int(byte_stream.readline().strip())
data = byte_stream.read(size)
if len(data) < size:
raise Exception("EOF found before data was complete")
data_hash = to_text(byte_stream.readline().strip())
if data_hash != hashlib.sha1(data).hexdigest():
raise Exception("Read {0} bytes, but data did not match checksum".format(size))
# restore escaped loose \r characters
data = data.replace(br'\r', b'\r')
return data
@contextmanager
def file_lock(lock_path):
"""
Uses contextmanager to create and release a file lock based on the
given path. This allows us to create locks using `with file_lock()`
to prevent deadlocks related to failure to unlock properly.
"""
lock_fd = os.open(lock_path, os.O_RDWR | os.O_CREAT, 0o600)
fcntl.lockf(lock_fd, fcntl.LOCK_EX)
yield
fcntl.lockf(lock_fd, fcntl.LOCK_UN)
os.close(lock_fd)
class ConnectionProcess(object):
'''
The connection process wraps around a Connection object that manages
the connection to a remote device that persists over the playbook
'''
def __init__(self, fd, play_context, socket_path, original_path, ansible_playbook_pid=None):
self.play_context = play_context
self.socket_path = socket_path
self.original_path = original_path
self.fd = fd
self.exception = None
self.srv = JsonRpcServer()
self.sock = None
self.connection = None
self._ansible_playbook_pid = ansible_playbook_pid
def start(self, variables):
try:
messages = list()
result = {}
messages.append(('vvvv', 'control socket path is %s' % self.socket_path))
# If this is a relative path (~ gets expanded later) then plug the
# key's path on to the directory we originally came from, so we can
# find it now that our cwd is /
if self.play_context.private_key_file and self.play_context.private_key_file[0] not in '~/':
self.play_context.private_key_file = os.path.join(self.original_path, self.play_context.private_key_file)
self.connection = connection_loader.get(self.play_context.connection, self.play_context, '/dev/null',
ansible_playbook_pid=self._ansible_playbook_pid)
self.connection.set_options(var_options=variables)
self.connection._connect()
self.connection._socket_path = self.socket_path
self.srv.register(self.connection)
messages.extend([('vvvv', msg) for msg in sys.stdout.getvalue().splitlines()])
messages.append(('vvvv', 'connection to remote device started successfully'))
self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
self.sock.bind(self.socket_path)
self.sock.listen(1)
messages.append(('vvvv', 'local domain socket listeners started successfully'))
except Exception as exc:
messages.extend(self.connection.pop_messages())
result['error'] = to_text(exc)
result['exception'] = traceback.format_exc()
finally:
result['messages'] = messages
self.fd.write(json.dumps(result, cls=AnsibleJSONEncoder))
self.fd.close()
def run(self):
try:
while self.connection.connected:
signal.signal(signal.SIGALRM, self.connect_timeout)
signal.signal(signal.SIGTERM, self.handler)
signal.alarm(self.connection.get_option('persistent_connect_timeout'))
self.exception = None
(s, addr) = self.sock.accept()
signal.alarm(0)
signal.signal(signal.SIGALRM, self.command_timeout)
while True:
data = recv_data(s)
if not data:
break
log_messages = self.connection.get_option('persistent_log_messages')
if log_messages:
display.display("jsonrpc request: %s" % data, log_only=True)
signal.alarm(self.connection.get_option('persistent_command_timeout'))
resp = self.srv.handle_request(data)
signal.alarm(0)
if log_messages:
display.display("jsonrpc response: %s" % resp, log_only=True)
send_data(s, to_bytes(resp))
s.close()
except Exception as e:
# socket.accept() will raise EINTR if the socket.close() is called
if hasattr(e, 'errno'):
if e.errno != errno.EINTR:
self.exception = traceback.format_exc()
else:
self.exception = traceback.format_exc()
finally:
# allow time for any exception msg send over socket to receive at other end before shutting down
time.sleep(0.1)
# when done, close the connection properly and cleanup the socket file so it can be recreated
self.shutdown()
def connect_timeout(self, signum, frame):
msg = 'persistent connection idle timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and ' \
'Troubleshooting Guide.' % self.connection.get_option('persistent_connect_timeout')
display.display(msg, log_only=True)
raise Exception(msg)
def command_timeout(self, signum, frame):
msg = 'command timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and Troubleshooting Guide.'\
% self.connection.get_option('persistent_command_timeout')
display.display(msg, log_only=True)
raise Exception(msg)
def handler(self, signum, frame):
msg = 'signal handler called with signal %s.' % signum
display.display(msg, log_only=True)
raise Exception(msg)
def shutdown(self):
""" Shuts down the local domain socket
"""
lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % os.path.split(self.socket_path))
if os.path.exists(self.socket_path):
try:
if self.sock:
self.sock.close()
if self.connection:
self.connection.close()
except Exception:
pass
finally:
if os.path.exists(self.socket_path):
os.remove(self.socket_path)
setattr(self.connection, '_socket_path', None)
setattr(self.connection, '_connected', False)
if os.path.exists(lock_path):
os.remove(lock_path)
display.display('shutdown complete', log_only=True)
def main():
""" Called to initiate the connect to the remote device
"""
rc = 0
result = {}
messages = list()
socket_path = None
# Need stdin as a byte stream
if PY3:
stdin = sys.stdin.buffer
else:
stdin = sys.stdin
# Note: update the below log capture code after Display.display() is refactored.
saved_stdout = sys.stdout
sys.stdout = StringIO()
try:
# read the play context data via stdin, which means depickling it
vars_data = read_stream(stdin)
init_data = read_stream(stdin)
if PY3:
pc_data = cPickle.loads(init_data, encoding='bytes')
variables = cPickle.loads(vars_data, encoding='bytes')
else:
pc_data = cPickle.loads(init_data)
variables = cPickle.loads(vars_data)
play_context = PlayContext()
play_context.deserialize(pc_data)
display.verbosity = play_context.verbosity
except Exception as e:
rc = 1
result.update({
'error': to_text(e),
'exception': traceback.format_exc()
})
if rc == 0:
ssh = connection_loader.get('ssh', class_only=True)
ansible_playbook_pid = sys.argv[1]
cp = ssh._create_control_path(play_context.remote_addr, play_context.port, play_context.remote_user, play_context.connection, ansible_playbook_pid)
# create the persistent connection dir if need be and create the paths
# which we will be using later
tmp_path = unfrackpath(C.PERSISTENT_CONTROL_PATH_DIR)
makedirs_safe(tmp_path)
socket_path = unfrackpath(cp % dict(directory=tmp_path))
lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % os.path.split(socket_path))
with file_lock(lock_path):
if not os.path.exists(socket_path):
messages.append(('vvvv', 'local domain socket does not exist, starting it'))
original_path = os.getcwd()
r, w = os.pipe()
pid = fork_process()
if pid == 0:
try:
os.close(r)
wfd = os.fdopen(w, 'w')
process = ConnectionProcess(wfd, play_context, socket_path, original_path, ansible_playbook_pid)
process.start(variables)
except Exception:
messages.append(('error', traceback.format_exc()))
rc = 1
if rc == 0:
process.run()
else:
process.shutdown()
sys.exit(rc)
else:
os.close(w)
rfd = os.fdopen(r, 'r')
data = json.loads(rfd.read(), cls=AnsibleJSONDecoder)
messages.extend(data.pop('messages'))
result.update(data)
else:
messages.append(('vvvv', 'found existing local domain socket, using it!'))
conn = Connection(socket_path)
conn.set_options(var_options=variables)
pc_data = to_text(init_data)
try:
conn.update_play_context(pc_data)
except Exception as exc:
# Only network_cli has update_play context, so missing this is
# not fatal e.g. netconf
if isinstance(exc, ConnectionError) and getattr(exc, 'code', None) == -32601:
pass
else:
result.update({
'error': to_text(exc),
'exception': traceback.format_exc()
})
if os.path.exists(socket_path):
messages.extend(Connection(socket_path).pop_messages())
messages.append(('vvvv', sys.stdout.getvalue()))
result.update({
'messages': messages,
'socket_path': socket_path
})
sys.stdout = saved_stdout
if 'exception' in result:
rc = 1
sys.stderr.write(json.dumps(result, cls=AnsibleJSONEncoder))
else:
rc = 0
sys.stdout.write(json.dumps(result, cls=AnsibleJSONEncoder))
sys.exit(rc)
if __name__ == '__main__':
display = Display()
main()

1
bin/ansible-connection Symbolic link
View File

@ -0,0 +1 @@
../lib/ansible/cli/scripts/ansible_connection_cli_stub.py

View File

@ -1,15 +0,0 @@
#!/usr/bin/env python
# PYTHON_ARGCOMPLETE_OK
"""Primary entry point for ansible-test."""
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import os
import sys
if __name__ == '__main__':
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(os.path.dirname(__file__)), 'test', 'runner')))
import lib.cli
lib.cli.main()

1
bin/ansible-test Symbolic link
View File

@ -0,0 +1 @@
../test/lib/ansible_test/_data/cli/ansible_test_cli_stub.py

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

2870
changelogs/changelog.yaml Normal file

File diff suppressed because it is too large Load Diff

View File

@ -1,13 +1,22 @@
---
title: Ansible Base
release_tag_re: '(v(?:[\d.ab\-]|rc)+)'
pre_release_tag_re: '(?P<pre_release>(?:[ab]|rc)+\d*)$'
changes_file: changelog.yaml
changes_format: combined
keep_fragments: true
always_refresh: true
ignore_other_fragment_extensions: true
mention_ancestor: false
notesdir: fragments
prelude_section_name: release_summary
new_plugins_after_name: removed_features
sections:
- ['major_changes', 'Major Changes']
- ['minor_changes', 'Minor Changes']
- ['breaking_changes', 'Breaking Changes / Porting Guide']
- ['deprecated_features', 'Deprecated Features']
- ['removed_features', 'Removed Features (previously deprecated)']
- ['security_fixes', 'Security Fixes']
- ['bugfixes', 'Bugfixes']
- ['known_issues', 'Known Issues']

View File

@ -1,2 +0,0 @@
minor_changes:
- Add ``ansible_play_name`` magic var (https://github.com/ansible/ansible/issues/11349)

View File

@ -1,2 +0,0 @@
minor_changes:
- Add support for hex color values in Slack module.

View File

@ -0,0 +1,2 @@
bugfixes:
- display correct error information when an error exists in the last line of the file (https://github.com/ansible/ansible/issues/16456)

View File

@ -1,4 +0,0 @@
minor_changes:
- ansible.vars.unsafe_proxy - Removed deprecated file (https://github.com/ansible/ansible/issues/45040)
- fetch - Removed deprecated validate_md5 alias (https://github.com/ansible/ansible/issues/45039)
- include_role/import_role - Removed deprecated private argument (https://github.com/ansible/ansible/issues/45038)

View File

@ -1,6 +0,0 @@
removed_features:
- ec2_remote_facts - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
- azure - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
- cs_nic - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
- netscaler - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
- win_msi - deprecated module removed (https://github.com/ansible/ansible/pull/44985)

View File

@ -0,0 +1,3 @@
bugfixes:
- uri - Don't return the body even if it failed
(https://github.com/ansible/ansible/issues/21003)

View File

@ -1,2 +0,0 @@
minor_changes:
- cmdline fact parsing can return multiple values of a single key. Deprecate cmdline fact in favor of proc_cmdline.

View File

@ -1,2 +0,0 @@
minor_changes:
- yum/dnf - Add download_dir param (https://github.com/ansible/ansible/issues/24004)

View File

@ -1,2 +0,0 @@
bugfixes:
- copy - align invocation in return value between check and normal mode

View File

@ -1,2 +0,0 @@
bugfixes:
- docker_compose - fixed an issue where ``remove_orphans`` doesn't work reliably.

View File

@ -1,2 +0,0 @@
bugfixes:
- Fix handlers to allow for templated values in run_once (https://github.com/ansible/ansible/issues/27237)

View File

@ -1,2 +0,0 @@
bugfixes:
- Enhance the conditional check to include main.yml if it is not from 'role/vars/' (https://github.com/ansible/ansible/pull/51926).

View File

@ -0,0 +1,4 @@
bugfixes:
- >
pause - Fix indefinite hang when using a pause task on a background
process (https://github.com/ansible/ansible/issues/32142)

View File

@ -1,2 +0,0 @@
minor_changes:
- Fix documentation of match test. Match requires zero or more characters at beginning of the string.

View File

@ -0,0 +1,2 @@
minor_changes:
- debconf - add a note about no_log=True since module might expose sensitive information to logs (https://github.com/ansible/ansible/issues/32386).

View File

@ -1,2 +0,0 @@
minor_changes:
- "``osx_say`` callback plugin was renamed into ``say``."

View File

@ -1,2 +0,0 @@
minor_changes:
- "docker_image - set ``changed`` to ``false`` when using ``force: yes`` to load or build an image that ends up being identical to one already present on the Docker host."

View File

@ -1,2 +0,0 @@
minor_changes:
- Allow for vaulted templates in template lookup (https://github.com/ansible/ansible/issues/34209)

View File

@ -0,0 +1,2 @@
minor_changes:
- ssh - connection plugin now supports a new variable ``sshpass_prompt`` which gets passed to ``sshpass`` allowing the user to set a custom substring to search for a password prompt (requires sshpass 1.06+)

View File

@ -1,2 +0,0 @@
minor_changes:
- postgres_privs now accepts 'ALL_IN_SCHEMA' objs for 'function' type (https://github.com/ansible/ansible/pull/35331).

View File

@ -1,3 +0,0 @@
---
minor_changes:
- "docker_network - ``internal`` is now used to set the ``Internal`` property of the docker network during creation."

View File

@ -1,2 +0,0 @@
bugfixes:
- lvol - fixed ValueError when using float size (https://github.com/ansible/ansible/issues/32886, https://github.com/ansible/ansible/issues/29429)

View File

@ -1,3 +0,0 @@
---
bugfixes:
- "modprobe - The modprobe module now detects builtin kernel modules. If a kernel module is builtin the modprobe module will now: succeed (without incorrectly reporting changed) if ``state`` is ``present``; and fail if ``state`` is ``absent`` (with an error message like ``modprobe: ERROR: Module nfs is builtin.``). (https://github.com/ansible/ansible/pull/37150)"

View File

@ -1,3 +0,0 @@
---
minor_changes:
- conn_limit type is set to 'int' in postgresql_user module. This will allow module to compare conn_limit with record value without type casting.

View File

@ -0,0 +1,2 @@
minor_changes:
- subelements - clarify the lookup plugin documentation for parameter handling (https://github.com/ansible/ansible/issues/38182).

View File

@ -0,0 +1,2 @@
bugfixes:
- facts - account for Slackware OS with ``+`` in the name (https://github.com/ansible/ansible/issues/38760)

View File

@ -1,3 +0,0 @@
---
minor_changes:
- "postgresql_privs - introduces support for FOREIGN DATA WRAPPER and FOREIGN SERVER as object types in postgresql_privs module. (https://github.com/ansible/ansible/issues/38801)"

View File

@ -1,3 +0,0 @@
---
minor_changes:
- "docker_volume - option minimal versions now checked. (https://github.com/ansible/ansible/issues/38833)"

View File

@ -1,2 +0,0 @@
minor_changes:
- hashi_vault lookup plugin now supports username and password method for the authentication (https://github.com/ansible/ansible/issues/38878).

View File

@ -1,2 +0,0 @@
bugfixes:
- "mysql_user: match backticks, single and double quotes when checking user privileges."

View File

@ -1,3 +0,0 @@
---
minor_changes:
- junit callback plug-in - introduce a new option to consider a task only as test case if it has this value as prefix.

View File

@ -1,3 +0,0 @@
---
minor_changes:
- junit callback plug-in - introduce a new option to hide task arguments similar to no_log.

View File

@ -1,2 +0,0 @@
minor_changes:
- "add support for extending volumes in os_volume, also add module support for check_mode and diff"

View File

@ -1,2 +0,0 @@
bugfixes:
- postgresql_db - the module fails not always when pg_dump errors occured (https://github.com/ansible/ansible/issues/40424).

View File

@ -1,2 +0,0 @@
minor_changes:
- Added support for MX and SRV record in ipa_dnsrecord module (https://github.com/ansible/ansible/pull/42482).

View File

@ -1,2 +0,0 @@
bugfixes:
- ansible-galaxy - Prevent unicode errors when searching - https://github.com/ansible/ansible/issues/42866

View File

@ -1,3 +0,0 @@
---
minor_changes:
- Add support for per_host:no stats for the callback plugin **json** (https://github.com/ansible/ansible/pull/43123)

View File

@ -1,2 +0,0 @@
minor_changes:
- "docker_container - ``stop_timeout`` is now also used to set the ``StopTimeout`` property of the docker container when creating the container."

View File

@ -1,2 +0,0 @@
bugfixes:
- pamd - Allow for validation of definitive control in pamd module.

View File

@ -1,2 +0,0 @@
bugfixes:
- Fix unwanted ACLs when using copy module (https://github.com/ansible/ansible/issues/44412)

View File

@ -1,3 +0,0 @@
minor_changes:
- "default value for ``INVENTORY_ENABLED`` option was ``['host_list', 'script', 'yaml', 'ini', 'toml', 'auto']``
and is now ``['host_list', 'script', 'auto', 'yaml', 'ini', 'toml']``"

View File

@ -1,2 +0,0 @@
bugfixes:
- Fixed KeyError issue in vmware_host_config_manager when a supported option isn't already set (https://github.com/ansible/ansible/issues/44561).

View File

@ -1,2 +0,0 @@
bugfixes:
- "docker_container, docker_image, docker_image_facts - also find local image when image name is prefixed with ``docker.io/library/`` or ``docker.io/``."

View File

@ -1,2 +0,0 @@
bugfixes:
- assemble - avoid extra newline on Python 3 (https://github.com/ansible/ansible/issues/44739)

View File

@ -1,2 +0,0 @@
minor_changes:
- "The restart/idempotency behavior of docker_container can now be controlled with the new comparisons parameter."

View File

@ -1,2 +0,0 @@
bugfixes:
- "ACME modules support `POST-as-GET <https://community.letsencrypt.org/t/acme-v2-scheduled-deprecation-of-unauthenticated-resource-gets/74380>`__ and will be able to access Let's Encrypt ACME v2 endpoint after November 1st, 2019."

View File

@ -1,2 +0,0 @@
minor_changes:
- Update docs and return section of vmware_host_service_facts module.

View File

@ -1,2 +0,0 @@
bugfixes:
- "mysql_user: fix compatibility issues with various MySQL/MariaDB versions"

View File

@ -1,2 +0,0 @@
bugfixes:
- "fetch_url did not always return lower-case header names in case of HTTP errors (https://github.com/ansible/ansible/pull/45628)."

View File

@ -1,3 +0,0 @@
---
bugfixes:
- "uri: fix TypeError when file can't be saved"

View File

@ -1,2 +0,0 @@
bugfixes:
- "docker_container - the behavior is improved in case ``image`` is not specified, but needed for (re-)creating the container."

View File

@ -1,2 +0,0 @@
minor_changes:
- mongodb_user - Change value for parameter roles to empty (https://github.com/ansible/ansible/issues/46443)

View File

@ -1,11 +0,0 @@
minor_changes:
- magic variables - added a new ``ansible_role_names`` magic variable to include the names of roles being applied to
the host both directly and indirectly (via dependencies).
- magic variabels - added a new ``ansible_play_role_names`` magic variable to mimic the old functionality of
``role_names``. This variable only lists the names of roles being applied to the host directly, and does not
include those added via dependencies
- magic variables - added a new ``ansible_dependent_role_names`` magic variable to contain the names of roles
applied to the host indirectly, via dependencies.
deprecated_features:
- magic variables - documented the deprecation of the ``role_names`` magic variable in favor of either
``ansible_role_names`` (including dependency role names) or ``ansible_play_role_names`` (excluding dependencies).

View File

@ -1,2 +0,0 @@
bugfixes:
- "docker_container - ``publish_ports: all`` was not used correctly when checking idempotency."

View File

@ -1,2 +0,0 @@
bugfixes:
- "docker_container - fix idempotency check for published_ports in some special cases."

View File

@ -1,2 +0,0 @@
minor_changes:
- "docker_container - published_ports now supports port ranges, IPv6 addresses, and no longer accepts hostnames, which were never used correctly anyway."

View File

@ -1,2 +0,0 @@
minor_changes:
- "docker_container - mount modes in ``volumes`` allow more values, similar to when using the ``docker`` executable."

View File

@ -1,2 +0,0 @@
bugfixes:
- azure_rm inventory plugin - fix runtime error under Python3 (https://github.com/ansible/ansible/pull/46608)

View File

@ -1,2 +0,0 @@
minor_changes:
- Parsing plugin filter may raise TypeError, gracefully handle this exception and let user know about the syntax error in plugin filter file.

View File

@ -1,2 +0,0 @@
bugfixes:
- "gcp_compute_instance - fix crash when the instance metadata is not set"

View File

@ -1,2 +0,0 @@
bugfixes:
- "gcp_utils - fix google auth scoping issue with application default credentials or google cloud engine credentials. Only scope credentials that can be scoped."

View File

@ -1,2 +0,0 @@
bugfixes:
- templar - Do not strip new lines in native jinja - https://github.com/ansible/ansible/issues/46743

View File

@ -1,2 +0,0 @@
minor_changes:
- "docker_container - Added support for healthcheck."

View File

@ -1,2 +0,0 @@
bugfixes:
- aws_ec2 - fixed issue where cache did not contain the computed groups

View File

@ -1,2 +0,0 @@
bugfixes:
- mail - fix python 2.7 regression

View File

@ -0,0 +1,3 @@
---
bugfixes:
- copy - Fixed copy module not working in case that remote_src is enabled and dest ends in a / (https://github.com/ansible/ansible/pull/47238)

Some files were not shown because too many files have changed in this diff Show More