New release v2.9.0b1

* Rename checkpoint to check_point due to legal reasons, fix #61145 (#61172)

* Fix #61145

* Fix type keyword

* Removed file fragment

(cherry picked from commit 9744ce1e1d)

* add changelogs

* adding eol

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

.azure-pipelines/azure-pipelines.yml

@@ -1,219 +0,0 @@
-trigger:
-  batch: true
-  branches:
-    include:
-      - devel
-      - stable-*
-
-pr:
-  autoCancel: true
-  branches:
-    include:
-      - devel
-      - stable-*
-
-schedules:
-  - cron: 0 7 * * *
-    displayName: Nightly
-    always: true
-    branches:
-      include:
-        - devel
-        - stable-*
-
-variables:
-  - name: checkoutPath
-    value: ansible
-  - name: coverageBranches
-    value: devel
-  - name: pipelinesCoverage
-    value: coverage
-  - name: entryPoint
-    value: test/utils/shippable/shippable.sh
-  - name: fetchDepth
-    value: 100
-
-resources:
-  containers:
-    - container: default
-      image: quay.io/ansible/azure-pipelines-test-container:1.6.0
-
-pool: Standard
-
-stages:
-  - stage: Sanity
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Test {0}
-          testFormat: sanity/{0}
-          targets:
-            - test: 1
-            - test: 2
-            - test: 3
-            - test: 4
-  - stage: Units
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: units/{0}
-          targets:
-            - test: 2.6
-            - test: 2.7
-            - test: 3.5
-            - test: 3.6
-            - test: 3.7
-            - test: 3.8
-          groups:
-            - 1
-            - 2
-  - stage: Windows
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Server {0}
-          testFormat: windows/{0}
-          targets:
-            - test: 2012
-            - test: 2012-R2
-            - test: 2016
-            - test: 2019
-          groups:
-            - 1
-            - 2
-            - 3
-            - 4
-            - 5
-            - 6
-            - 7
-  - stage: Network
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: network/{0}
-          targets:
-            - test: ''
-  - stage: Remote
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          targets:
-            - name: OS X 10.11
-              test: osx/10.11
-            - name: RHEL 7.9
-              test: rhel/7.9
-            - name: RHEL 8.2
-              test: rhel/8.2
-            - name: FreeBSD 11.1
-              test: freebsd/11.1
-            - name: FreeBSD 12.0
-              test: freebsd/12.0
-          groups:
-            - 1
-            - 2
-            - 3
-            - 4
-  - stage: Docker
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: linux/{0}
-          targets:
-            - name: CentOS 6
-              test: centos6
-            - name: CentOS 7
-              test: centos7
-            - name: Fedora 29
-              test: fedora29
-            - name: Fedora 30
-              test: fedora30
-            - name: openSUSE 15 py2
-              test: opensuse15py2
-            - name: openSUSE 15 py3
-              test: opensuse15
-            - name: Ubuntu 16.04
-              test: ubuntu1604
-            - name: Ubuntu 18.04
-              test: ubuntu1804
-          groups:
-            - 1
-            - 2
-            - 3
-            - 4
-  - stage: AWS
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: aws/{0}
-          targets:
-            - test: 2.7
-            - test: 3.6
-          groups:
-            - 1
-            - 2
-  - stage: vCenter
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: vcenter/{0}/1
-          targets:
-            - test: 2.7
-            - test: 3.6
-  - stage: CloudStack
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: cs/{0}/1
-          targets:
-            - test: 2.7
-            - test: 3.6
-  - stage: Cloud
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: cloud/{0}/1
-          targets:
-            - test: 2.7
-            - test: 3.6
-  - stage: Hetzner
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: hcloud/{0}/1
-          targets:
-            - test: 2.7
-            - test: 3.6
-  - stage: Summary
-    condition: succeededOrFailed()
-    dependsOn:
-      - Sanity
-      - Units
-      - Windows
-      - Network
-      - Remote
-      - Docker
-      - AWS
-      - vCenter
-      - CloudStack
-      - Cloud
-      - Hetzner
-    jobs:
-      - template: templates/coverage.yml

.azure-pipelines/scripts/aggregate-coverage.sh

@@ -1,15 +0,0 @@
-#!/usr/bin/env bash
-# Aggregate code coverage results for later processing.
-
-set -o pipefail -eu
-
-agent_temp_directory="$1"
-
-PATH="${PWD}/bin:${PATH}"
-
-mkdir "${agent_temp_directory}/coverage/"
-
-options=(--venv --venv-system-site-packages --color -v)
-
-ansible-test coverage combine --export "${agent_temp_directory}/coverage/" "${options[@]}"
-ansible-test coverage analyze targets generate "${agent_temp_directory}/coverage/coverage-analyze-targets.json" "${options[@]}"

.azure-pipelines/scripts/combine-coverage.py

@@ -1,60 +0,0 @@
-#!/usr/bin/env python
-"""
-Combine coverage data from multiple jobs, keeping the data only from the most recent attempt from each job.
-Coverage artifacts must be named using the format: "Coverage $(System.JobAttempt) {StableUniqueNameForEachJob}"
-The recommended coverage artifact name format is: Coverage $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)
-Keep in mind that Azure Pipelines does not enforce unique job display names (only names).
-It is up to pipeline authors to avoid name collisions when deviating from the recommended format.
-"""
-
-from __future__ import (absolute_import, division, print_function)
-__metaclass__ = type
-
-import os
-import re
-import shutil
-import sys
-
-
-def main():
-    """Main program entry point."""
-    source_directory = sys.argv[1]
-
-    if '/ansible_collections/' in os.getcwd():
-        output_path = "tests/output"
-    else:
-        output_path = "test/results"
-
-    destination_directory = os.path.join(output_path, 'coverage')
-
-    if not os.path.exists(destination_directory):
-        os.makedirs(destination_directory)
-
-    jobs = {}
-    count = 0
-
-    for name in os.listdir(source_directory):
-        match = re.search('^Coverage (?P<attempt>[0-9]+) (?P<label>.+)$', name)
-        label = match.group('label')
-        attempt = int(match.group('attempt'))
-        jobs[label] = max(attempt, jobs.get(label, 0))
-
-    for label, attempt in jobs.items():
-        name = 'Coverage {attempt} {label}'.format(label=label, attempt=attempt)
-        source = os.path.join(source_directory, name)
-        source_files = os.listdir(source)
-
-        for source_file in source_files:
-            source_path = os.path.join(source, source_file)
-            destination_path = os.path.join(destination_directory, source_file + '.' + label)
-            print('"%s" -> "%s"' % (source_path, destination_path))
-            shutil.copyfile(source_path, destination_path)
-            count += 1
-
-    print('Coverage file count: %d' % count)
-    print('##vso[task.setVariable variable=coverageFileCount]%d' % count)
-    print('##vso[task.setVariable variable=outputPath]%s' % output_path)
-
-
-if __name__ == '__main__':
-    main()

.azure-pipelines/scripts/process-results.sh

@@ -1,24 +0,0 @@
-#!/usr/bin/env bash
-# Check the test results and set variables for use in later steps.
-
-set -o pipefail -eu
-
-if [[ "$PWD" =~ /ansible_collections/ ]]; then
-    output_path="tests/output"
-else
-    output_path="test/results"
-fi
-
-echo "##vso[task.setVariable variable=outputPath]${output_path}"
-
-if compgen -G "${output_path}"'/junit/*.xml' > /dev/null; then
-    echo "##vso[task.setVariable variable=haveTestResults]true"
-fi
-
-if compgen -G "${output_path}"'/bot/ansible-test-*' > /dev/null; then
-    echo "##vso[task.setVariable variable=haveBotResults]true"
-fi
-
-if compgen -G "${output_path}"'/coverage/*' > /dev/null; then
-    echo "##vso[task.setVariable variable=haveCoverageData]true"
-fi

.azure-pipelines/scripts/publish-codecov.sh

@@ -1,27 +0,0 @@
-#!/usr/bin/env bash
-# Upload code coverage reports to codecov.io.
-# Multiple coverage files from multiple languages are accepted and aggregated after upload.
-# Python coverage, as well as PowerShell and Python stubs can all be uploaded.
-
-set -o pipefail -eu
-
-output_path="$1"
-
-curl --silent --show-error https://codecov.io/bash > codecov.sh
-
-for file in "${output_path}"/reports/coverage*.xml; do
-    name="${file}"
-    name="${name##*/}"  # remove path
-    name="${name##coverage=}"  # remove 'coverage=' prefix if present
-    name="${name%.xml}"  # remove '.xml' suffix
-
-    bash codecov.sh \
-        -f "${file}" \
-        -n "${name}" \
-        -X coveragepy \
-        -X gcov \
-        -X fix \
-        -X search \
-        -X xcode \
-        || echo "Failed to upload code coverage report to codecov.io: ${file}"
-done

.azure-pipelines/scripts/report-coverage.sh

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-# Generate code coverage reports for uploading to Azure Pipelines and codecov.io.
-
-set -o pipefail -eu
-
-PATH="${PWD}/bin:${PATH}"
-
-ansible-test coverage xml --stub --venv --venv-system-site-packages --color -v

.azure-pipelines/scripts/run-tests.sh

@@ -1,34 +0,0 @@
-#!/usr/bin/env bash
-# Configure the test environment and run the tests.
-
-set -o pipefail -eu
-
-entry_point="$1"
-test="$2"
-read -r -a coverage_branches <<< "$3"  # space separated list of branches to run code coverage on for scheduled builds
-
-export COMMIT_MESSAGE
-export COMPLETE
-export COVERAGE
-export IS_PULL_REQUEST
-
-if [ "${SYSTEM_PULLREQUEST_TARGETBRANCH:-}" ]; then
-    IS_PULL_REQUEST=true
-    COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD^2)
-else
-    IS_PULL_REQUEST=
-    COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD)
-fi
-
-COMPLETE=
-COVERAGE=
-
-if [ "${BUILD_REASON}" = "Schedule" ]; then
-    COMPLETE=yes
-
-    if printf '%s\n' "${coverage_branches[@]}" | grep -q "^${BUILD_SOURCEBRANCHNAME}$"; then
-        COVERAGE=yes
-    fi
-fi
-
-"${entry_point}" "${test}" 2>&1 | "$(dirname "$0")/time-command.py"

.azure-pipelines/scripts/time-command.py

@@ -1,25 +0,0 @@
-#!/usr/bin/env python
-"""Prepends a relative timestamp to each input line from stdin and writes it to stdout."""
-
-from __future__ import (absolute_import, division, print_function)
-__metaclass__ = type
-
-import sys
-import time
-
-
-def main():
-    """Main program entry point."""
-    start = time.time()
-
-    sys.stdin.reconfigure(errors='surrogateescape')
-    sys.stdout.reconfigure(errors='surrogateescape')
-
-    for line in sys.stdin:
-        seconds = time.time() - start
-        sys.stdout.write('%02d:%02d %s' % (seconds // 60, seconds % 60, line))
-        sys.stdout.flush()
-
-
-if __name__ == '__main__':
-    main()

.azure-pipelines/templates/coverage.yml

@@ -1,39 +0,0 @@
-# This template adds a job for processing code coverage data.
-# It will upload results to Azure Pipelines and codecov.io.
-# Use it from a job stage that completes after all other jobs have completed.
-# This can be done by placing it in a separate summary stage that runs after the test stage(s) have completed.
-
-jobs:
-  - job: Coverage
-    displayName: Code Coverage
-    container: default
-    workspace:
-      clean: all
-    steps:
-      - checkout: self
-        fetchDepth: $(fetchDepth)
-        path: $(checkoutPath)
-      - task: DownloadPipelineArtifact@2
-        displayName: Download Coverage Data
-        inputs:
-          path: coverage/
-          patterns: "Coverage */*=coverage.combined"
-      - bash: .azure-pipelines/scripts/combine-coverage.py coverage/
-        displayName: Combine Coverage Data
-      - bash: .azure-pipelines/scripts/report-coverage.sh
-        displayName: Generate Coverage Report
-        condition: gt(variables.coverageFileCount, 0)
-      - task: PublishCodeCoverageResults@1
-        inputs:
-          codeCoverageTool: Cobertura
-          # Azure Pipelines only accepts a single coverage data file.
-          # That means only Python or PowerShell coverage can be uploaded, but not both.
-          # Set the "pipelinesCoverage" variable to determine which type is uploaded.
-          # Use "coverage" for Python and "coverage-powershell" for PowerShell.
-          summaryFileLocation: "$(outputPath)/reports/$(pipelinesCoverage).xml"
-        displayName: Publish to Azure Pipelines
-        condition: gt(variables.coverageFileCount, 0)
-      - bash: .azure-pipelines/scripts/publish-codecov.sh "$(outputPath)"
-        displayName: Publish to codecov.io
-        condition: gt(variables.coverageFileCount, 0)
-        continueOnError: true

.azure-pipelines/templates/matrix.yml

@@ -1,55 +0,0 @@
-# This template uses the provided targets and optional groups to generate a matrix which is then passed to the test template.
-# If this matrix template does not provide the required functionality, consider using the test template directly instead.
-
-parameters:
-  # A required list of dictionaries, one per test target.
-  # Each item in the list must contain a "test" or "name" key.
-  # Both may be provided. If one is omitted, the other will be used.
-  - name: targets
-    type: object
-
-  # An optional list of values which will be used to multiply the targets list into a matrix.
-  # Values can be strings or numbers.
-  - name: groups
-    type: object
-    default: []
-
-  # An optional format string used to generate the job name.
-  # - {0} is the name of an item in the targets list.
-  - name: nameFormat
-    type: string
-    default: "{0}"
-
-  # An optional format string used to generate the test name.
-  # - {0} is the name of an item in the targets list.
-  - name: testFormat
-    type: string
-    default: "{0}"
-
-  # An optional format string used to add the group to the job name.
-  # {0} is the formatted name of an item in the targets list.
-  # {{1}} is the group -- be sure to include the double "{{" and "}}".
-  - name: nameGroupFormat
-    type: string
-    default: "{0} - {{1}}"
-
-  # An optional format string used to add the group to the test name.
-  # {0} is the formatted test of an item in the targets list.
-  # {{1}} is the group -- be sure to include the double "{{" and "}}".
-  - name: testGroupFormat
-    type: string
-    default: "{0}/{{1}}"
-
-jobs:
-  - template: test.yml
-    parameters:
-      jobs:
-        - ${{ if eq(length(parameters.groups), 0) }}:
-          - ${{ each target in parameters.targets }}:
-            - name: ${{ format(parameters.nameFormat, coalesce(target.name, target.test)) }}
-              test: ${{ format(parameters.testFormat, coalesce(target.test, target.name)) }}
-        - ${{ if not(eq(length(parameters.groups), 0)) }}:
-          - ${{ each group in parameters.groups }}:
-            - ${{ each target in parameters.targets }}:
-              - name: ${{ format(format(parameters.nameGroupFormat, parameters.nameFormat), coalesce(target.name, target.test), group) }}
-                test: ${{ format(format(parameters.testGroupFormat, parameters.testFormat), coalesce(target.test, target.name), group) }}

.azure-pipelines/templates/test.yml

@@ -1,45 +0,0 @@
-# This template uses the provided list of jobs to create test one or more test jobs.
-# It can be used directly if needed, or through the matrix template.
-
-parameters:
-  # A required list of dictionaries, one per test job.
-  # Each item in the list must contain a "job" and "name" key.
-  - name: jobs
-    type: object
-
-jobs:
-  - ${{ each job in parameters.jobs }}:
-    - job: test_${{ replace(replace(replace(job.test, '/', '_'), '.', '_'), '-', '_') }}
-      displayName: ${{ job.name }}
-      container: default
-      workspace:
-        clean: all
-      steps:
-        - checkout: self
-          fetchDepth: $(fetchDepth)
-          path: $(checkoutPath)
-        - bash: .azure-pipelines/scripts/run-tests.sh "$(entryPoint)" "${{ job.test }}" "$(coverageBranches)"
-          displayName: Run Tests
-        - bash: .azure-pipelines/scripts/process-results.sh
-          condition: succeededOrFailed()
-          displayName: Process Results
-        - bash: .azure-pipelines/scripts/aggregate-coverage.sh "$(Agent.TempDirectory)"
-          condition: eq(variables.haveCoverageData, 'true')
-          displayName: Aggregate Coverage Data
-        - task: PublishTestResults@2
-          condition: eq(variables.haveTestResults, 'true')
-          inputs:
-            testResultsFiles: "$(outputPath)/junit/*.xml"
-          displayName: Publish Test Results
-        - task: PublishPipelineArtifact@1
-          condition: eq(variables.haveBotResults, 'true')
-          displayName: Publish Bot Results
-          inputs:
-            targetPath: "$(outputPath)/bot/"
-            artifactName: "Bot $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)"
-        - task: PublishPipelineArtifact@1
-          condition: eq(variables.haveCoverageData, 'true')
-          displayName: Publish Coverage Data
-          inputs:
-            targetPath: "$(Agent.TempDirectory)/coverage/"
-            artifactName: "Coverage $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)"

.coveragerc

@@ -1,26 +0,0 @@
-# This configuration file is used for manual execution of coverage
-# as well as for tests run through ansible-test.
-
-[run]
-branch = True
-
-# Enable concurrency. This also enables parallel mode, which results in
-# multiple coverage files being created. Concurrency allows us to collect
-# results from multiple tests simultaneously, as well as supporting multiple
-# test runs, such as from integration tests.
-concurrency = multiprocessing
-parallel = True
-
-# When running tests through ansible-test, this option is overridden by
-# the COVERAGE_FILE environment variable. This option is present for
-# convenience when running coverage manually from this directory.
-data_file = test/results/coverage/coverage
-
-# Don't collect or report code coverage from files matching these patterns.
-omit =
-    */python*/dist-packages/*
-    */python*/site-packages/*
-    */python*/distutils/*
-    */pyshared/*
-    */pytest
-    */AnsiballZ_*.py

.github/BOTMETA.yml

@@ -42,6 +42,8 @@ files:
     support: core
   changelogs/fragments/:
     support: community
+  $modules:
+    ignored: ryansb
   $modules/cloud/amazon/:
     ignored: erydo seiffert simplesteph nadirollo tedder
   $modules/cloud/amazon/aws_api_gateway.py: willthames
@@ -51,7 +53,7 @@ files:
   $modules/cloud/amazon/cloudformation.py:
     maintainers: ryansb
     ignored: tedder
-  $modules/cloud/amazon/cloudfront_facts.py: willthames
+  $modules/cloud/amazon/cloudfront_info.py: willthames
   $modules/cloud/amazon/cloudtrail.py: $team_ansible
   $modules/cloud/amazon/ec2.py:
     maintainers: $team_ansible
@@ -59,33 +61,33 @@ files:
   $modules/cloud/amazon/ec2_ami.py: willthames
   $modules/cloud/amazon/ec2_asg.py: $team_ansible s-hertel ryansb
   $modules/cloud/amazon/ec2_group.py: $team_ansible
-  $modules/cloud/amazon/ec2_group_facts.py: willthames
+  $modules/cloud/amazon/ec2_group_info.py: willthames
   $modules/cloud/amazon/ec2_instance.py: Shaps
-  $modules/cloud/amazon/ec2_instance_facts.py: willthames
+  $modules/cloud/amazon/ec2_instance_info.py: willthames
   $modules/cloud/amazon/ec2_key.py: $team_ansible
   $modules/cloud/amazon/ec2_lc.py: $team_ansible
-  $modules/cloud/amazon/ec2_lc_facts.py: willthames
+  $modules/cloud/amazon/ec2_lc_info.py: willthames
   $modules/cloud/amazon/ec2_metric_alarm.py: $team_ansible
   $modules/cloud/amazon/ec2_tag.py: $team_ansible
   $modules/cloud/amazon/ec2_vol.py: $team_ansible
   $modules/cloud/amazon/ec2_vpc_endpoint.py: willthames
-  $modules/cloud/amazon/ec2_vpc_endpoint_facts.py: willthames
+  $modules/cloud/amazon/ec2_vpc_endpoint_info.py: willthames
   $modules/cloud/amazon/ec2_vpc_igw.py: willthames
-  $modules/cloud/amazon/ec2_vpc_igw_facts.py: willthames
-  $modules/cloud/amazon/ec2_vpc_nat_gateway_facts.py: willthames
+  $modules/cloud/amazon/ec2_vpc_igw_info.py: willthames
+  $modules/cloud/amazon/ec2_vpc_nat_gateway_info.py: willthames
   $modules/cloud/amazon/ec2_vpc_net.py: $team_ansible
-  $modules/cloud/amazon/ec2_vpc_net_facts.py: whiter
-  $modules/cloud/amazon/ec2_vpc_peering_facts.py: willthames
+  $modules/cloud/amazon/ec2_vpc_net_info.py: whiter
+  $modules/cloud/amazon/ec2_vpc_peering_info.py: willthames
   $modules/cloud/amazon/ec2_vpc_subnet.py: willthames
   $modules/cloud/amazon/ecs_cluster.py: willthames
   $modules/cloud/amazon/ecs_ecr.py: willthames
   $modules/cloud/amazon/ecs_service.py: willthames
-  $modules/cloud/amazon/ecs_service_facts.py: willthames
+  $modules/cloud/amazon/ecs_service_info.py: willthames
   $modules/cloud/amazon/ecs_task.py: willthames
   $modules/cloud/amazon/ecs_taskdefinition.py: willthames
-  $modules/cloud/amazon/ecs_taskdefinition_facts.py: willthames
+  $modules/cloud/amazon/ecs_taskdefinition_info.py: willthames
   $modules/cloud/amazon/elasticache.py: alachaum
-  $modules/cloud/amazon/elb_target_group_facts.py: willthames
+  $modules/cloud/amazon/elb_target_group_info.py: willthames
   $modules/cloud/amazon/iam.py: $team_ansible
   $modules/cloud/amazon/iam_cert.py: $team_ansible
   $modules/cloud/amazon/iam_group.py: willthames
@@ -171,8 +173,12 @@ files:
   $modules/cloud/misc/virt_pool.py: *virt
   $modules/cloud/misc/xenserver_facts.py:
     ignored: andyhky
-  $modules/cloud/opennebula/: ilicmilan kustodian
+  $modules/cloud/opennebula/: ilicmilan kustodian xorel rsmontero
   $modules/cloud/openstack/: $team_openstack
+  $modules/cloud/oracle/: &oracle
+    labels: [ cloud, oracle ]
+    maintainers: $team_oracle
+    support: community
   $modules/cloud/ovirt/: *ovirt
   $modules/cloud/profitbricks/: baldwinSPC
   $modules/cloud/rackspace/:
@@ -185,7 +191,7 @@ files:
     maintainers: $team_solaris
   $modules/cloud/univention/: keachi
   $modules/cloud/vmware/: &vmware
-    ignored: cigamit jcpowermac mtnbikenc tchernomax
+    ignored: cigamit jcpowermac mtnbikenc tchernomax ckotte
     keywords: [ esx, vcenter, vcsa, vcsim, vsphere ]
     labels: [ cloud, vmware ]
     maintainers: $team_vmware
@@ -209,6 +215,10 @@ files:
     keywords: [ acme, letsencrypt, lets encrypt, luks, openssl ]
     labels: crypto
     maintainers: $team_crypto
+    supershipit: felixfontein
+  $modules/crypto/openssl_certificate.py:
+    maintainers: ctrufan
+  $modules/crypto/entrust/: ctrufan tylert
   $modules/database/influxdb/: kamsz
   $modules/database/mssql/mssql_db.py: Jmainguy kenichi-ogawa-1988
   $modules/database/mysql/: &mysql
@@ -262,7 +272,7 @@ files:
   $modules/monitoring/monit.py: brian-brazil
   $modules/monitoring/pagerduty.py:
     ignored: bpennypacker
-  $modules/monitoring/zabbix/: eikef D3DeFi
+  $modules/monitoring/zabbix/: eikef D3DeFi rubentsirunyan
   $modules/net_tools/basics/get_url.py: ptux
   $modules/net_tools/basics/slurp.py: $team_ansible
   $modules/net_tools/basics/uri.py:
@@ -278,13 +288,12 @@ files:
     labels:
       - networking
       - infoblox
-  $modules/net_tools/netbox/: fragmentedpacket
+  $modules/net_tools/netbox/: FragmentedPacket
   $modules/network/a10/: ericchou1 mischapeters
   $modules/network/aci/: &aci
     keywords: [ aci, cisco msc, cisco mso, multisite, multi-site ]
     labels: [ aci, cisco, networking ]
     maintainers: $team_aci
-    notified: koladiya
   $modules/network/aireos/: &aireos
     maintainers: $team_aireos
     labels: [ aireos, cisco, networking ]
@@ -295,7 +304,8 @@ files:
     labels: [ asa, cisco, networking ]
   $modules/network/avi/: $team_avi
   $modules/network/bigswitch/: jayakody tedelhourani vuile
-  $modules/network/cloudengine/: QijunPan
+  $modules/network/cloudengine/:
+    maintainers: $team_huawei
   $modules/network/cnos/: dkasberg amuraleedhar
   $modules/network/cumulus/: $team_cumulus
   $modules/network/dellos10/: skg-net
@@ -305,7 +315,8 @@ files:
   $modules/network/edgeswitch/: f-bor
   $modules/network/enos/: amuraleedhar
   $modules/network/eos/: trishnaguha
-  $modules/network/exos/: rdvencioneck
+  $modules/network/eric_eccli/: itercheng
+  $modules/network/exos/: rdvencioneck $team_extreme
   $modules/network/f5/:
     ignored: Etienne-Carriere mhite mryanlam perzizzle srvg JoeReifel $team_networking
     maintainers: caphrim007 wojtek0806
@@ -327,6 +338,7 @@ files:
     maintainers: $team_iosxr
   $modules/network/ironware/: paulquack
   $modules/network/junos/: Qalthos ganeshrn
+  $modules/network/icx/: sushma-alethea
   $modules/network/layer2/: $team_networking
   $modules/network/layer3/: $team_networking
   $modules/network/meraki/: &meraki
@@ -350,7 +362,6 @@ files:
   $modules/network/ordnance/: alexanderturner djh00t
   $modules/network/ovs/:
     ignored: stygstra
-    maintainers: rcarrillocruz
   $modules/network/panos/: ivanbojer jtschichold shinmog
   $modules/network/protocol/: $team_networking
   $modules/network/routeros/: heuels
@@ -359,7 +370,7 @@ files:
   $modules/network/sros/: privateip
   $modules/network/system/: $team_networking
   $modules/network/voss/: $team_extreme
-  $modules/network/vyos/: Qalthos samdoran NilashishC
+  $modules/network/vyos/: Qalthos NilashishC
   $modules/notification/_osx_say.py: $team_ansible
   $modules/notification/rocketchat.py:
     ignored: ramondelafuente
@@ -418,9 +429,12 @@ files:
     maintainers: $team_ansible kustodian
     ignored: skvidal
   $modules/packaging/os/zypper.py:
+    maintainers: $team_suse
     ignored: dirtyharrycallahan robinro
-  $modules/remote_management/foreman/: ehelms
-  $modules/remote_management/hpilo/: dagwieers haad
+  $modules/remote_management/foreman/: $team_foreman
+  $modules/remote_management/hpilo/:
+    ignored: dagwieers
+    maintainers: haad
   $modules/remote_management/imc/:
     labels: [ cisco ]
     maintainers: $team_imc
@@ -446,7 +460,9 @@ files:
     notified: jlozadad
   $modules/storage/hpe3par/: farhan7500 gautamphegde
   $modules/storage/infinidat/: GR360RY vmalloc
-  $modules/storage/netapp/: $team_netapp
+  $modules/storage/netapp/:
+    maintainers: $team_netapp
+    support: community
   $modules/storage/purestorage/:
     maintainers: $team_purestorage
     labels: pure_storage
@@ -481,7 +497,6 @@ files:
   $modules/system/selinux.py: samdoran
   $modules/system/service.py: $team_ansible
   $modules/system/setup.py:
-    ignored: david_obrien
     maintainers: $team_ansible
   $modules/system/solaris: *solaris
   $modules/system/sysctl.py: Akasurde
@@ -503,6 +518,7 @@ files:
   $modules/web_infrastructure/ansible_tower/: &tower
     labels: [ tower ]
     maintainers: $team_tower
+    ignored: wwitzel3
   $modules/web_infrastructure/sophos_utm/:
     maintainers: $team_e_spirit
     keywords:
@@ -521,10 +537,6 @@ files:
   $modules/windows/win_security_policy.py:
     <<: *windows
     maintainers: defionscode
-  bin/ansible-connection:
-    keywords:
-      - persistent connection
-    labels: networking
   contrib/:
     support: community
   contrib/inventory:
@@ -536,6 +548,8 @@ files:
     support: community
   contrib/inventory/digital_ocean.py: *digital_ocean
   contrib/inventory/docker: *docker
+  contrib/inventory/foreman.py:
+    maintainers: $team_foreman
   contrib/inventory/linode:
     keywords:
       - linode dynamic inventory script
@@ -657,6 +671,8 @@ files:
     labels:
       - aws
       - cloud
+  $module_utils/ecs/:
+    maintainers: ctrufan tylert $team_crypto
   $module_utils/facts:
     support: core
   $module_utils/facts/hardware/aix.py: *aix
@@ -686,7 +702,12 @@ files:
     maintainers: $team_google
     supershipit: $team_google
   $module_utils/gitlab.py: *gitlab
-  $module_utils/hwc_utils.py: *huawei
+  $module_utils/hwc_utils.py: &huawei_hwc
+    <<: *huawei
+    support: community
+    labels:
+      - networking
+      - huawei
   $module_utils/ipa.py:
     maintainers: $team_ipa
   $module_utils/k8s:
@@ -694,8 +715,9 @@ files:
     labels:
       - clustering
       - k8s
-  $module_utils/keycloak.py:
-    maintainers: eikef
+  $module_utils/identity/keycloak/:
+     maintainers: eikef
+     support: community
   $module_utils/kubevirt.py: *kubevirt
   $module_utils/manageiq.py:
     maintainers: $team_manageiq
@@ -711,6 +733,7 @@ files:
     maintainers: $team_networking sganesh-infoblox
   $module_utils/netapp:
     maintainers: $team_netapp
+    support: community
   $module_utils/network:
     labels: networking
   $module_utils/network/a10:
@@ -727,7 +750,7 @@ files:
   $module_utils/network/bigswitch:
     maintainers: jayakody tedelhourani vuile
   $module_utils/network/cloudengine:
-    maintainers: QijunPan
+    maintainers: $team_huawei
   $module_utils/network/cnos:
     maintainers: dkasberg amuraleedhar
   $module_utils/network/common:
@@ -746,8 +769,12 @@ files:
   $module_utils/network/eos:
     support: network
     maintainers: $team_networking
+  $module_utils/network/eric_eccli:
+    support: network
+    maintainers: $team_networking
+                 itercheng
   $module_utils/network/exos:
-    maintainers: rdvencioneck
+    maintainers: rdvencioneck $team_extreme
   $module_utils/network/f5:
     maintainers: caphrim007 wojtek0806
   $module_utils/f5_utils.py:
@@ -805,6 +832,7 @@ files:
     maintainers: $team_openstack
     labels:
       - cloud
+  $module_utils/oracle/: *oracle
   $module_utils/ovirt.py: *ovirt
   $module_utils/postgres.py: *postgresql
   $module_utils/powershell: *windows_core
@@ -888,6 +916,8 @@ files:
     support: core
   $plugins/action/fetch.py:
     support: core
+  $plugins/action/gather_facts.py:
+    support: core
   $plugins/action/group_by.py:
     support: core
   $plugins/action/include_vars.py:
@@ -979,6 +1009,16 @@ files:
     maintainers: $team_networking
     labels: networking
 ###############################
+# plugins/become
+  $plugins/become:
+    support: community
+  $plugins/become/__init__.py:
+    support: core
+  $plugins/become/su.py:
+    support: core
+  $plugins/become/sudo.py:
+    support: core
+###############################
 # plugins/cache
   $plugins/cache/__init__.py:
     support: core
@@ -994,6 +1034,8 @@ files:
     support: core
   $plugins/callback/grafana_annotations.py:
     maintainers: rrey
+  $plugins/callback/foreman.py:
+    maintainers: $team_foreman
   $plugins/callback/junit:
     support: core
   $plugins/callback/minimal:
@@ -1022,8 +1064,12 @@ files:
   $plugins/cliconf/eos.py:
     support: network
     maintainers: $team_networking
+  $plugins/cliconf/eric_eccli.py:
+    support: network
+    maintainers: $team_networking
+                 itercheng
   $plugins/cliconf/exos.py:
-    maintainers: rdvencioneck
+    maintainers: rdvencioneck $team_extreme
   $plugins/cliconf/ios.py:
     <<: *ios
     maintainers: $team_networking $team_ios
@@ -1058,6 +1104,9 @@ files:
 # plugins/connection
   $plugins/connection/:
     support: core
+  $plugins/connection/buildah.py:
+    support: community
+    maintainers: TomasTomecek
   $plugins/connection/docker.py:
     <<: *docker
     support: community
@@ -1065,6 +1114,10 @@ files:
     support: network
     maintainers: $team_networking
     labels: networking
+  $plugins/connection/kubectl.py:
+    support: community
+    maintainers: chouseknecht maxamillion fabianvf flaper87 willthames
+    labels: k8s
   $plugins/connection/lxd.py:
     maintainers: mattclay
   $plugins/connection/netconf.py:
@@ -1081,10 +1134,19 @@ files:
   $plugins/connection/persistent.py:
     maintainers: $team_networking
     labels: networking
+  $plugins/connection/podman.py:
+    support: community
+    maintainers: TomasTomecek
   $plugins/connection/psrp.py: *windows_core
   $plugins/connection/saltstack.py:
     support: community
   $plugins/connection/winrm.py: *windows_core
+  $plugins/connection/vmware_tools.py:
+    support: community
+    maintainers: $team_vmware
+    labels:
+      - vmware
+      - cloud
 ###############################
 # plugins/doc_fragments
   $plugins/doc_fragments/:
@@ -1103,7 +1165,8 @@ files:
     support: community
     supershipit: $team_google
     maintainers: $team_google
-  $plugins/doc_fragments/hwc.py: *huawei
+  $plugins/doc_fragments/hwc.py:
+    maintainers: $team_huawei
   $plugins/doc_fragments/intersight.py: *intersight
   $plugins/doc_fragments/mso.py: *aci
   $plugins/doc_fragments/mysql.py: *mysql
@@ -1112,10 +1175,11 @@ files:
   $plugins/doc_fragments/ucs.py: *ucs
   $plugins/doc_fragments/vultr.py: *vultr
   $plugins/doc_fragments/ovirt.py: *ovirt
-  $plugins/doc_fragments/ovirt_facts.py: *ovirt
+  $plugins/doc_fragments/ovirt_info.py: *ovirt
   $plugins/doc_fragments/xenserver.py:
     maintainers: bvitnik
   $plugins/doc_fragments/hpe3par.py: *hpe3par
+  $plugins/doc_fragments/oracle*: *oracle
 ###############################
 # plugins/filter
   $plugins/filter/:
@@ -1139,14 +1203,20 @@ files:
     maintainers: $team_networking
     labels: networking
   $plugins/httpapi/ftd.py: *ftd
+  $plugins/httpapi/exos.py:
+    maintainers: $team_extreme
 ###############################
 # plugins/inventory
   $plugins/inventory/__init__.py:
     support: core
+  $plugins/inventory/aws_ec2.py:
+    maintainers: s-hertel
   $plugins/inventory/docker: *docker
   $plugins/inventory/docker_swarm.py:
     <<: *docker
     maintainers: $team_docker morph027
+  $plugins/inventory/foreman.py:
+    maintainers: $team_foreman
   $plugins/inventory/gcp_compute.py:
     maintainers: $team_google
     supershipit: $team_google
@@ -1188,7 +1258,7 @@ files:
     keywords:
       - vmware inventory
       - vmware dynamic inventory plugin
-    ignored: cigamit jcpowermac mtnbikenc tchernomax
+    ignored: cigamit jcpowermac mtnbikenc tchernomax ckotte
   $plugins/inventory/vultr.py: *vultr
   $plugins/inventory/yaml.py:
     support: core
@@ -1197,6 +1267,50 @@ files:
 # plugins/lookup
   $plugins/lookup/__init__.py:
     support: core
+  $plugins/lookup/config.py:
+    support: core
+  $plugins/lookup/dict.py:
+    support: core
+  $plugins/lookup/env.py:
+    support: core
+  $plugins/lookup/file.py:
+    support: core
+  $plugins/lookup/fileglob.py:
+    support: core
+  $plugins/lookup/first_found.py:
+    support: core
+  $plugins/lookup/indexed_items.py:
+    support: core
+  $plugins/lookup/inventory_hostnames.py:
+    support: core
+  $plugins/lookup/items.py:
+    support: core
+  $plugins/lookup/lines.py:
+    support: core
+  $plugins/lookup/list.py:
+    support: core
+  $plugins/lookup/nested.py:
+    support: core
+  $plugins/lookup/password.py:
+    support: core
+  $plugins/lookup/pipe.py:
+    support: core
+  $plugins/lookup/random_choice.py:
+    support: core
+  $plugins/lookup/sequence.py:
+    support: core
+  $plugins/lookup/subelements.py:
+    support: core
+  $plugins/lookup/template.py:
+    support: core
+  $plugins/lookup/together.py:
+    support: core
+  $plugins/lookup/url.py:
+    support: core
+  $plugins/lookup/varnames.py:
+    support: core
+  $plugins/lookup/vars.py:
+    support: core
   $plugins/lookup/aws:
     labels:
       - aws
@@ -1261,8 +1375,11 @@ files:
   $plugins/terminal/eos.py:
     support: network
     maintainers: $team_networking
+  $plugins/terminal/eric_eccli.py:
+    support: community
+    maintainers: itercheng
   $plugins/terminal/exos.py:
-    maintainers: rdvencioneck
+    maintainers: rdvencioneck $team_extreme
   $plugins/terminal/ios.py:
     <<: *ios
     maintainers: $team_networking $team_ios
@@ -1294,7 +1411,7 @@ files:
     maintainers: $team_extreme
   $plugins/terminal/vyos.py:
     support: network
-    maintainers: $team_networking samdoran
+    maintainers: $team_networking
 ###############################
 # plugins/test
   $plugins/test:
@@ -1309,37 +1426,66 @@ files:
 
 ##############################
 # other lib
+  lib/ansible/cli/scripts/ansible_connection_cli_stub.py:
+    keywords:
+      - persistent connection
+    labels: networking
   lib/ansible/executor/powershell: *windows_core
   lib/ansible/template:
     keywords:
       - jinja
       - jinja2
-  test/sanity/validate-modules:
-    notified:
-      - mattclay
-    keywords:
-      - validate-modules
-  test/sanity/validate-modules/schema.py:
-    notified:
-      - gundalow
-      - sivel
-  test/sanity/validate-modules/main.py:
-    notified:
-      - gundalow
-      - sivel
+##############################
+# docs
   docs/:
     maintainers:
       - acozine
+  docs/docsite/rst/community/:
+    maintainers:
+      - gundalow
+  docs/docsite/rst/dev_guide/:
+    maintainers:
+      - gundalow
   docs/docsite/rst/dev_guide/developing_modules_general_aci.rst: *aci
   docs/docsite/rst/network/:
     labels: networking
     maintainers:
       - samccann
   docs/docsite/rst/scenario_guides/guide_aci.rst: *aci
+  docs/docsite/rst/scenario_guides/guide_aws.rst:
+    labels:
+      - aws
+      - cloud
+    maintainers: s-hertel
+  docs/docsite/rst/scenario_guides/guide_azure.rst:
+    labels:
+      - azure
+      - cloud
+    maintainers: $team_azure
+  docs/docsite/rst/scenario_guides/guide_cloudstack.rst:
+    labels:
+      - cloud
+      - cloudstack
+    maintainers: $team_cloudstack
   docs/docsite/rst/scenario_guides/guide_docker.rst: *docker
+  docs/docsite/rst/scenario_guides/guide_vmware.rst: *vmware
   docs/docsite/rst/user_guide/intro_bsd.rst: *bsd
+  docs/docsite/rst/user_guide/windows: *windows_core
 ###############################
 # 'test' is a component path, then 'test' label will be automatically added
+  test/lib/ansible_test/_data/sanity/validate-modules:
+    notified:
+      - mattclay
+    keywords:
+      - validate-modules
+  test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/schema.py:
+    notified:
+      - gundalow
+      - sivel
+  test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py:
+    notified:
+      - gundalow
+      - sivel
   test/integration/targets/aci_: *aci
   test/integration/targets/asa_: *asa
   test/integration/targets/acme: *crypto
@@ -1354,18 +1500,23 @@ files:
   test/integration/targets/gcp:
     maintainers: $team_google
     supershipit: $team_google
-  test/integration/targets/hwc_: *huawei
+  test/integration/targets/hwc_:
+    maintainers: $team_huawei
   test/integration/targets/inventory_docker: *docker
   test/integration/targets/inventory_docker_swarm:
     <<: *docker
     maintainers: $team_docker morph027
   test/integration/targets/intersight: *intersight
+  test/integration/targets/exos_: $team_extreme
   test/integration/targets/ios_: *ios
   test/integration/targets/iosxr_: *ios
   test/integration/targets/meraki_: *meraki
   test/integration/targets/mso_: *aci
   test/integration/targets/mysql: *mysql
   test/integration/targets/nxos_: *nxos
+  test/integration/targets/netapp:
+    maintainers: $team_netapp
+    support: community
   test/integration/targets/openssl: *crypto
   test/integration/targets/postgresql: *postgresql
   test/integration/targets/scaleway_: *scaleway
@@ -1374,57 +1525,64 @@ files:
   test/integration/targets/setup_openssl: *crypto
   test/integration/targets/setup_mysql_db: *mysql
   test/integration/targets/setup_zabbix:
-    maintainers: eikef D3DeFi
+    maintainers: eikef D3DeFi rubentsirunyan
   test/integration/targets/ucs_: *ucs
   test/integration/targets/vultr: *vultr
   test/legacy/:
     notified: mattclay
-  test/runner/:
+  test/lib/:
     notified: mattclay
-  test/runner/lib/cloud/acme.py: *crypto
+  test/lib/ansible_test/_internal/cloud/acme.py: *crypto
   test/sanity/:
     notified: mattclay
-  test/sanity/pep8/legacy-files.txt:
-    notified: mattclay
   test/units/module_utils/docker/:
     <<: *docker
     support: community
   test/units/module_utils/facts/network/test_generic_bsd.py: *bsd
-  test/units/module_utils/hwc: *huawei
+  test/units/module_utils/test_netapp.py:
+    maintainers: $team_netapp
+    support: community
+  test/units/module_utils/hwc:
+    maintainers: $team_huawei
   test/units/module_utils/acme: *crypto
   test/units/module_utils/xenserver/: bvitnik
   test/units/modules/cloud/docker:
     <<: *docker
     support: community
   test/units/modules/cloud/xenserver/: bvitnik
+  test/units/modules/crypto/: *crypto
   test/units/modules/network:
     maintainers: $team_networking
     labels: networking
   test/units/modules/network/aireos: *aireos
+  test/units/modules/network/exos: $team_extreme
   test/units/modules/network/ftd: *ftd
   test/units/modules/network/ios: *ios
   test/units/modules/network/iosxr: *iosxr
   test/units/modules/network/nso: *nso
   test/units/modules/network/nxos: *nxos
   test/units/modules/storage/hpe3par: *hpe3par
+  test/units/modules/storage/netapp:
+    maintainers: $team_netapp
+    support: community
   test/utils/shippable/:
     notified: mattclay
   hacking/report.py:
     notified: mattclay
-  tox.ini:
+  shippable.yml:
     notified: mattclay
 macros:
   module_utils: lib/ansible/module_utils
   modules: lib/ansible/modules
   plugins: lib/ansible/plugins
-  team_aci: brunocalogero dagwieers jmcgill298 mtorelli rsmeyers schunduri smnmtzgr
+  team_aci: brunocalogero dagwieers devarshishah3 fadallar jmcgill298 koladiya mtorelli rsmeyers schunduri smnmtzgr
   team_aireos: jmighion
-  team_aix: bcoca dagwieers flynn1973 gforster kairoaraujo marvin-sinister mator molekuul MorrisA ramooncamacho wtcross
-  team_asa: gdpak ogenstad
+  team_aix: bcoca dagwieers d-little flynn1973 gforster kairoaraujo marvin-sinister mator molekuul MorrisA ramooncamacho wtcross
+  team_asa: NilashishC ogenstad
   team_ansible: []
   team_avi: ericsysmin grastogi23 khaltore
-  team_azure: haroldwongms nitzmahone trstringer yuwzho xscript zikalino
-  team_bsd: bcoca dagwieers jasperla JoergFiedler MacLemon mekanix opoplawski overhacked tuxillo
+  team_azure: haroldwongms nitzmahone yuwzho yungezz zikalino
+  team_bsd: bcoca dagwieers dch jasperla JoergFiedler MacLemon mekanix opoplawski overhacked tuxillo
   team_cloudscale: gaudenz resmo
   team_cloudstack: resmo dpassante rhtyd
   team_crypto: felixfontein MarkusTeufelberger puiterwijk resmo Spredzy Shaps Xyon
@@ -1433,48 +1591,51 @@ macros:
   team_digital_ocean: aluvenko, BondAnthony, mgregson
   team_docker: akshay196 danihodovic dariko DBendit felixfontein jwitko kassiansun tbouvet WojciechowskiPiotr
   team_e_spirit: MatrixCrawler getjack
-  team_extreme: bigmstone LindsayHill
+  team_extreme: bigmstone LindsayHill ujwalkomarla
+  team_foreman: ehelms ares xprazak2 ekohl
   team_fortimanager: Ghilli3 lweighall p4r4n0y1ng Ftntcorecse
   team_ftd: annikulin
   team_gitlab: dj-wasabi Lunik marwatk Shaps waheedi
   team_google: rambleraptor erjohnso
   team_hcloud: cschmitt-hcloud LKaemmerling
   team_hpux: bcoca dagwieers davx8342
-  team_huawei: zhongjun2 zengchen1024 niuzhenguo freesky-edward TommyLike edisonxiang
+  team_huawei: zhongjun2 zengchen1024 niuzhenguo freesky-edward TommyLike edisonxiang QijunPan xuxiaowei0512 hwDCN
   team_imc: dagwieers
   team_intersight: dsoper2 movinalot
-  team_ios: rcarrillocruz
-  team_iosxr: rcarrillocruz gdpak
+  team_ios: justjais
+  team_iosxr: justjais NilashishC
   team_ipa: Nosmoht Akasurde fxfitz
   team_jboss: jairojunior wbrefvem Wolfant
   team_kubevirt: machacekondra mmazur pkliczewski
   team_linode: InTheCloudDan lwm displague rmcintosh
-  team_macos: akasurde dagwieers kyleabenson
+  team_macos: akasurde dagwieers kyleabenson martinm82
   team_manageiq: gtanzillo abellotti zgalor yaacov cben
-  team_meraki: dagwieers kbreit
-  team_mysql: bmalynovytch bmildren michaelcoburn oneiroi tolland Xyon
+  team_meraki: kbreit
+  team_mysql: Alexander198961 bmalynovytch bmildren michaelcoburn oneiroi tolland Xyon Andersson007 kurtdavis
   team_netapp: hulquest lmprice ndswartz amit0701 schmots1 carchi8py lonico
-  team_netbox: sieben anthony25 fragmentedpacket nikkytub pilou-
+  team_netbox: sieben anthony25 FragmentedPacket nikkytub pilou-
   team_netscaler: chiradeep giorgos-nikolopoulos
   team_netvisor: Qalthos amitsi pdam preetiparasar csharpe-pn
-  team_networking: Qalthos ganeshrn rcarrillocruz trishnaguha gdpak justjais NilashishC
+  team_networking: Qalthos ganeshrn trishnaguha justjais NilashishC danielmellado
   team_nso: cmoberg cnasten tbjurman
-  team_nxos: mikewiebe rahushen rcarrillocruz trishnaguha chrisvanheuveln
+  team_nxos: mikewiebe rahushen trishnaguha chrisvanheuveln
   team_onyx: anasbadaha samerd
-  team_openstack: emonty juliakreger rcarrillocruz Shrews dagnello mnaser odyssey4me evrardjp cloudnull gtema
-  team_openswitch: Qalthos gdpak
+  team_openstack: emonty juliakreger rcarrillocruz Shrews dagnello mnaser odyssey4me cloudnull gtema
+  team_openswitch: Qalthos danielmellado
+  team_oracle: nalsaber manojmeda mross22
   team_ovirt: machacekondra mwperina mnecas
-  team_postgresql: amenonsen Andersson007 andytom Dorn- jbscalia kostiantyn-nemchenko kustodian matburt nerzhul sebasmannem
-  team_purestorage: sdodsley sile16 lionmax genegr raekins bannaych opslounge
+  team_postgresql: amenonsen Andersson007 andytom Dorn- jbscalia kostiantyn-nemchenko kustodian matburt nerzhul sebasmannem tcraxs
+  team_purestorage: sdodsley sile16 lionmax genegr raekins bannaych opslounge dnix101
   team_rabbitmq: chrishoffman manuel-sousa hyperized
   team_redfish: jose-delarosa mraineri tomasg2012 billdodd
   team_rhn: alikins barnabycourt FlossWare vritant
-  team_scaleway: sieben Spredzy abarbare Anthony25 pilou-
-  team_solaris: bcoca dagwieers fishman jpdasma jasperla mator scathatheworm troy2914 xen0l
-  team_tower: ghjm matburt wwitzel3 ryanpetrello rooftopcellist AlanCoding jladdjr kdelee
+  team_scaleway: remyleone abarbare DenBeke jerome-quere kindermoumoute QuentinBrosse
+  team_solaris: bcoca dagwieers danowar2k fishman jpdasma jasperla mator scathatheworm troy2914 xen0l
+  team_suse: evrardjp toabctl dcermak lrupp commel
+  team_tower: ghjm matburt ryanpetrello rooftopcellist AlanCoding jladdjr kdelee chrismeyersfsu
   team_ucs: dsoper2 movinalot SDBrett vallard vvb
-  team_vmware: Akasurde dav1x warthog9 ckotte Tomorrow9
+  team_vmware: Akasurde warthog9 Tomorrow9 goneri pgbidkar
   team_virt: joshainglis karmab
   team_vultr: resmo Spredzy
-  team_windows: dagwieers jborean93 jhawkesworth nitzmahone
+  team_windows: jborean93 jhawkesworth nitzmahone ShachafGoldstein
   team_windows_core: nitzmahone jborean93

.github/SECURITY.md

@@ -0,0 +1,15 @@
+# Security Policy
+
+## Supported Versions
+
+Ansible applies security fixes according to the 3-versions-back support
+policy. Please find more information in [our docs](
+https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#release-status
+).
+
+## Reporting a Vulnerability
+
+We encourage responsible disclosure practices for security
+vulnerabilities. Please read our [policies for reporting bugs](
+https://docs.ansible.com/ansible/devel/community/reporting_bugs_and_features.html#reporting-a-bug
+) if you want to report a security issue that might affect Ansible.

.gitignore

@@ -34,6 +34,7 @@ docs/docsite/*.html
 docs/docsite/htmlout
 docs/docsite/rst/cli/ansible-*.rst
 docs/docsite/rst/cli/ansible.rst
+docs/docsite/rst/dev_guide/collections_galaxy_meta.rst
 docs/docsite/rst/dev_guide/testing/sanity/index.rst.new
 docs/docsite/rst/modules/*.rst
 docs/docsite/rst/playbooks_directives.rst
@@ -78,16 +79,8 @@ ansible.egg-info/
 # Release directory
 packaging/release/ansible_release
 /.cache/
-/test/results/coverage/*=coverage.*
-/test/results/coverage/coverage*
-/test/results/reports/coverage*.xml
-/test/results/reports/coverage*/
-/test/results/bot/*.json
-/test/results/junit/*.xml
-/test/results/logs/*.log
-/test/results/data/*.json
+/test/results/
 /test/integration/cloud-config-aws.yml
-/test/integration/inventory.remote
 /test/integration/inventory.networking
 /test/integration/inventory.winrm
 /test/integration/cloud-config-aws.yml
@@ -106,3 +99,5 @@ test/units/.coverage.*
 /SYMLINK_CACHE.json
 changelogs/.plugin-cache.yaml
 .ansible-test-timeout.json
+# ansible-test temporary metadata file for use with delgation
+/metadata-*.json

MANIFEST.in

@@ -2,25 +2,38 @@ include README.rst
 include COPYING
 include SYMLINK_CACHE.json
 include requirements.txt
-include .coveragerc
-include tox.ini
-include bin/ansible-test
+include shippable.yml
+recursive-include docs *
+exclude docs/docsite/rst_warnings
+recursive-exclude docs/docsite/_build *
+recursive-exclude docs/docsite/_extensions *.pyc *.pyo
 include examples/hosts
 include examples/ansible.cfg
 include examples/scripts/ConfigureRemotingForAnsible.ps1
 include examples/scripts/upgrade_to_ps3.ps1
-recursive-include lib/ansible/executor/powershell *
-recursive-include lib/ansible/module_utils/csharp *
-recursive-include lib/ansible/module_utils/powershell *
-recursive-include lib/ansible/modules *
-recursive-include lib/ansible/galaxy/data *
-recursive-include docs *
-recursive-include licenses *
+recursive-include lib/ansible/executor/powershell *.ps1
+recursive-include lib/ansible/module_utils/csharp *.cs
+recursive-include lib/ansible/module_utils/powershell *.psm1
+recursive-include lib/ansible/modules/windows *.ps1
+recursive-include lib/ansible/galaxy/data *.yml *.j2 README.md ansible.cfg inventory .git_keep
+recursive-include lib/ansible/config *.yml
+recursive-include licenses *.txt
 recursive-include packaging *
-recursive-include test *
+recursive-include test/ansible_test *.py Makefile
+recursive-include test/cache .keep
+recursive-include test/integration *
+recursive-include test/lib/ansible_test/config *.template
+recursive-include test/lib/ansible_test/_data *.cfg *.ini *.json *.ps1 *.psd1 *.py *.sh *.txt *.yml coveragerc inventory
+recursive-include test/lib/ansible_test/_data/injector ansible ansible-config ansible-connection ansible-console ansible-doc ansible-galaxy ansible-playbook ansible-pull ansible-test ansible-vault pytest
+recursive-include test/lib/ansible_test/_data/sanity/validate-modules validate-modules
+recursive-include test/results .keep
+recursive-include test/sanity *.json *.py *.txt
+exclude test/sanity/code-smell/botmeta.*
+recursive-include test/units *
 include Makefile
 include MANIFEST.in
 include changelogs/CHANGELOG*.rst
 include contrib/README.md
-recursive-include contrib/inventory *
-exclude test/sanity/code-smell/botmeta.*
+recursive-include contrib/inventory *.py *.ini *.yml *.yaml
+recursive-include hacking/build_library *.py
+include hacking/build-ansible.py

Makefile

@@ -12,7 +12,6 @@
 #   make deb ------------------ produce a DEB
 #   make docs ----------------- rebuild the manpages (results are checked in)
 #   make tests ---------------- run the tests (see https://docs.ansible.com/ansible/devel/dev_guide/testing_units.html for requirements)
-#   make pyflakes, make pep8 -- source code checks
 
 ########################################################
 # variable section
@@ -20,6 +19,7 @@
 NAME = ansible
 OS = $(shell uname -s)
 PREFIX ?= '/usr/local'
+SDIST_DIR ?= 'dist'
 
 # This doesn't evaluate until it's called. The -D argument is the
 # directory of the target file ($@), kinda like `dirname`.
@@ -33,7 +33,7 @@ ASCII2MAN = @echo "ERROR: rst2man from docutils command is not installed but is
 endif
 
 PYTHON=python
-GENERATE_CLI = $(PYTHON) docs/bin/generate_man.py
+GENERATE_CLI = hacking/build-ansible.py generate-man
 
 SITELIB = $(shell $(PYTHON) -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")
 
@@ -172,18 +172,6 @@ authors:
 %.1: %.1.rst lib/ansible/release.py
 	$(ASCII2MAN)
 
-.PHONY: loc
-loc:
-	sloccount lib library bin
-
-.PHONY: pep8
-pep8:
-	$(ANSIBLE_TEST) sanity --test pep8 --python $(PYTHON_VERSION) $(TEST_FLAGS)
-
-.PHONY: pyflakes
-pyflakes:
-	pyflakes lib/ansible/*.py lib/ansible/*/*.py bin/*
-
 .PHONY: clean
 clean:
 	@echo "Cleaning up distutils stuff"
@@ -239,14 +227,14 @@ sdist_check:
 
 .PHONY: sdist
 sdist: sdist_check clean docs
-	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist
+	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist --dist-dir=$(SDIST_DIR)
 
 # Official releases generate the changelog as the last commit before the release.
 # Snapshots shouldn't result in new checkins so the changelog is generated as
 # part of creating the tarball.
 .PHONY: snapshot
 snapshot: sdist_check clean docs changelog
-	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist
+	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist --dist-dir=$(SDIST_DIR)
 
 .PHONY: sdist_upload
 sdist_upload: clean docs

README.rst

@@ -50,7 +50,7 @@ Get Involved
    code to Ansible.
 *  Join a `Working Group
    <https://github.com/ansible/community/wiki>`_, an organized community devoted to a specific technology domain or platform.
-*  Submit proposed a code update through a pull request to the ``devel`` branch.
+*  Submit a proposed code update through a pull request to the ``devel`` branch.
 *  Talk to us before making larger changes
    to avoid duplicate efforts. This not only helps everyone
    know what is going on, it also helps save time and effort if we decide
@@ -63,8 +63,8 @@ Branch Info
 
 *  The ``devel`` branch corresponds to the release actively under development.
 *  The ``stable-2.X`` branches correspond to stable releases.
-*  For information about the active branches see the
-   `Ansible release and maintenance <https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html>`_ page.
+*  Create a branch based on ``devel`` and set up a `dev environment <https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#common-environment-setup>`_ if you want to open a PR.
+*  See the `Ansible release and maintenance <https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html>`_ page for information about active branches.
 
 Roadmap
 =======
@@ -84,7 +84,7 @@ and has contributions from over 4000 users (and growing). Thanks everyone!
 License
 =======
 
-GNU General Public License v3.0 or later
+GNU General Public License v3.0
 
 See `COPYING <COPYING>`_ to see the full text.
 
@@ -92,8 +92,8 @@ See `COPYING <COPYING>`_ to see the full text.
    :target: https://pypi.org/project/ansible
 .. |Docs badge| image:: https://img.shields.io/badge/docs-latest-brightgreen.svg
    :target: https://docs.ansible.com/ansible/latest/
-.. |Build Status| image:: https://dev.azure.com/ansible/ansible/_apis/build/status/CI?branchName=stable-2.8
-   :target: https://dev.azure.com/ansible/ansible/_build/latest?definitionId=20&branchName=stable-2.8
+.. |Build Status| image:: https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel
+   :target: https://app.shippable.com/projects/573f79d02a8192902e20e34b
 .. |Chat badge| image:: https://img.shields.io/badge/chat-IRC-brightgreen.svg
    :target: https://docs.ansible.com/ansible/latest/community/communication.html
 .. |Code Of Conduct| image:: https://img.shields.io/badge/code%20of%20conduct-Ansible-silver.svg

bin/ansible

@@ -1,152 +0,0 @@
-#!/usr/bin/env python
-
-# (c) 2012, Michael DeHaan <michael.dehaan@gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-########################################################
-from __future__ import (absolute_import, division, print_function)
-__metaclass__ = type
-
-__requires__ = ['ansible']
-
-
-import os
-import shutil
-import sys
-import traceback
-
-from ansible import context
-from ansible.errors import AnsibleError, AnsibleOptionsError, AnsibleParserError
-from ansible.module_utils._text import to_text
-
-
-# Used for determining if the system is running a new enough python version
-# and should only restrict on our documented minimum versions
-_PY3_MIN = sys.version_info[:2] >= (3, 5)
-_PY2_MIN = (2, 6) <= sys.version_info[:2] < (3,)
-_PY_MIN = _PY3_MIN or _PY2_MIN
-if not _PY_MIN:
-    raise SystemExit('ERROR: Ansible requires a minimum of Python2 version 2.6 or Python3 version 3.5. Current version: %s' % ''.join(sys.version.splitlines()))
-
-
-class LastResort(object):
-    # OUTPUT OF LAST RESORT
-    def display(self, msg, log_only=None):
-        print(msg, file=sys.stderr)
-
-    def error(self, msg, wrap_text=None):
-        print(msg, file=sys.stderr)
-
-
-if __name__ == '__main__':
-
-    display = LastResort()
-
-    try:  # bad ANSIBLE_CONFIG or config options can force ugly stacktrace
-        import ansible.constants as C
-        from ansible.utils.display import Display
-    except AnsibleOptionsError as e:
-        display.error(to_text(e), wrap_text=False)
-        sys.exit(5)
-
-    cli = None
-    me = os.path.basename(sys.argv[0])
-
-    try:
-        display = Display()
-        display.debug("starting run")
-
-        sub = None
-        target = me.split('-')
-        if target[-1][0].isdigit():
-            # Remove any version or python version info as downstreams
-            # sometimes add that
-            target = target[:-1]
-
-        if len(target) > 1:
-            sub = target[1]
-            myclass = "%sCLI" % sub.capitalize()
-        elif target[0] == 'ansible':
-            sub = 'adhoc'
-            myclass = 'AdHocCLI'
-        else:
-            raise AnsibleError("Unknown Ansible alias: %s" % me)
-
-        try:
-            mycli = getattr(__import__("ansible.cli.%s" % sub, fromlist=[myclass]), myclass)
-        except ImportError as e:
-            # ImportError members have changed in py3
-            if 'msg' in dir(e):
-                msg = e.msg
-            else:
-                msg = e.message
-            if msg.endswith(' %s' % sub):
-                raise AnsibleError("Ansible sub-program not implemented: %s" % me)
-            else:
-                raise
-
-        try:
-            args = [to_text(a, errors='surrogate_or_strict') for a in sys.argv]
-        except UnicodeError:
-            display.error('Command line args are not in utf-8, unable to continue.  Ansible currently only understands utf-8')
-            display.display(u"The full traceback was:\n\n%s" % to_text(traceback.format_exc()))
-            exit_code = 6
-        else:
-            cli = mycli(args)
-            exit_code = cli.run()
-
-    except AnsibleOptionsError as e:
-        cli.parser.print_help()
-        display.error(to_text(e), wrap_text=False)
-        exit_code = 5
-    except AnsibleParserError as e:
-        display.error(to_text(e), wrap_text=False)
-        exit_code = 4
-# TQM takes care of these, but leaving comment to reserve the exit codes
-#    except AnsibleHostUnreachable as e:
-#        display.error(str(e))
-#        exit_code = 3
-#    except AnsibleHostFailed as e:
-#        display.error(str(e))
-#        exit_code = 2
-    except AnsibleError as e:
-        display.error(to_text(e), wrap_text=False)
-        exit_code = 1
-    except KeyboardInterrupt:
-        display.error("User interrupted execution")
-        exit_code = 99
-    except Exception as e:
-        if C.DEFAULT_DEBUG:
-            # Show raw stacktraces in debug mode, It also allow pdb to
-            # enter post mortem mode.
-            raise
-        have_cli_options = bool(context.CLIARGS)
-        display.error("Unexpected Exception, this is probably a bug: %s" % to_text(e), wrap_text=False)
-        if not have_cli_options or have_cli_options and context.CLIARGS['verbosity'] > 2:
-            log_only = False
-            if hasattr(e, 'orig_exc'):
-                display.vvv('\nexception type: %s' % to_text(type(e.orig_exc)))
-                why = to_text(e.orig_exc)
-                if to_text(e) != why:
-                    display.vvv('\noriginal msg: %s' % why)
-        else:
-            display.display("to see the full traceback, use -vvv")
-            log_only = True
-        display.display(u"the full traceback was:\n\n%s" % to_text(traceback.format_exc()), log_only=log_only)
-        exit_code = 250
-
-    sys.exit(exit_code)

bin/ansible

@@ -0,0 +1 @@
+../lib/ansible/cli/scripts/ansible_cli_stub.py

bin/ansible-connection

@@ -1,335 +0,0 @@
-#!/usr/bin/env python
-# Copyright: (c) 2017, Ansible Project
-# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
-from __future__ import (absolute_import, division, print_function)
-
-__metaclass__ = type
-__requires__ = ['ansible']
-
-
-import fcntl
-import hashlib
-import os
-import signal
-import socket
-import sys
-import time
-import traceback
-import errno
-import json
-
-from contextlib import contextmanager
-
-from ansible import constants as C
-from ansible.module_utils._text import to_bytes, to_text
-from ansible.module_utils.six import PY3
-from ansible.module_utils.six.moves import cPickle, StringIO
-from ansible.module_utils.connection import Connection, ConnectionError, send_data, recv_data
-from ansible.module_utils.service import fork_process
-from ansible.parsing.ajson import AnsibleJSONEncoder, AnsibleJSONDecoder
-from ansible.playbook.play_context import PlayContext
-from ansible.plugins.loader import connection_loader
-from ansible.utils.path import unfrackpath, makedirs_safe
-from ansible.utils.display import Display
-from ansible.utils.jsonrpc import JsonRpcServer
-
-
-def read_stream(byte_stream):
-    size = int(byte_stream.readline().strip())
-
-    data = byte_stream.read(size)
-    if len(data) < size:
-        raise Exception("EOF found before data was complete")
-
-    data_hash = to_text(byte_stream.readline().strip())
-    if data_hash != hashlib.sha1(data).hexdigest():
-        raise Exception("Read {0} bytes, but data did not match checksum".format(size))
-
-    # restore escaped loose \r characters
-    data = data.replace(br'\r', b'\r')
-
-    return data
-
-
-@contextmanager
-def file_lock(lock_path):
-    """
-    Uses contextmanager to create and release a file lock based on the
-    given path. This allows us to create locks using `with file_lock()`
-    to prevent deadlocks related to failure to unlock properly.
-    """
-
-    lock_fd = os.open(lock_path, os.O_RDWR | os.O_CREAT, 0o600)
-    fcntl.lockf(lock_fd, fcntl.LOCK_EX)
-    yield
-    fcntl.lockf(lock_fd, fcntl.LOCK_UN)
-    os.close(lock_fd)
-
-
-class ConnectionProcess(object):
-    '''
-    The connection process wraps around a Connection object that manages
-    the connection to a remote device that persists over the playbook
-    '''
-    def __init__(self, fd, play_context, socket_path, original_path, ansible_playbook_pid=None):
-        self.play_context = play_context
-        self.socket_path = socket_path
-        self.original_path = original_path
-
-        self.fd = fd
-        self.exception = None
-
-        self.srv = JsonRpcServer()
-        self.sock = None
-
-        self.connection = None
-        self._ansible_playbook_pid = ansible_playbook_pid
-
-    def start(self, variables):
-        try:
-            messages = list()
-            result = {}
-
-            messages.append(('vvvv', 'control socket path is %s' % self.socket_path))
-
-            # If this is a relative path (~ gets expanded later) then plug the
-            # key's path on to the directory we originally came from, so we can
-            # find it now that our cwd is /
-            if self.play_context.private_key_file and self.play_context.private_key_file[0] not in '~/':
-                self.play_context.private_key_file = os.path.join(self.original_path, self.play_context.private_key_file)
-            self.connection = connection_loader.get(self.play_context.connection, self.play_context, '/dev/null',
-                                                    ansible_playbook_pid=self._ansible_playbook_pid)
-            self.connection.set_options(var_options=variables)
-
-            self.connection._connect()
-
-            self.connection._socket_path = self.socket_path
-            self.srv.register(self.connection)
-            messages.extend([('vvvv', msg) for msg in sys.stdout.getvalue().splitlines()])
-            messages.append(('vvvv', 'connection to remote device started successfully'))
-
-            self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
-            self.sock.bind(self.socket_path)
-            self.sock.listen(1)
-            messages.append(('vvvv', 'local domain socket listeners started successfully'))
-        except Exception as exc:
-            messages.extend(self.connection.pop_messages())
-            result['error'] = to_text(exc)
-            result['exception'] = traceback.format_exc()
-        finally:
-            result['messages'] = messages
-            self.fd.write(json.dumps(result, cls=AnsibleJSONEncoder))
-            self.fd.close()
-
-    def run(self):
-        try:
-            while self.connection.connected:
-                signal.signal(signal.SIGALRM, self.connect_timeout)
-                signal.signal(signal.SIGTERM, self.handler)
-                signal.alarm(self.connection.get_option('persistent_connect_timeout'))
-
-                self.exception = None
-                (s, addr) = self.sock.accept()
-                signal.alarm(0)
-                signal.signal(signal.SIGALRM, self.command_timeout)
-                while True:
-                    data = recv_data(s)
-                    if not data:
-                        break
-                    log_messages = self.connection.get_option('persistent_log_messages')
-
-                    if log_messages:
-                        display.display("jsonrpc request: %s" % data, log_only=True)
-
-                    signal.alarm(self.connection.get_option('persistent_command_timeout'))
-                    resp = self.srv.handle_request(data)
-                    signal.alarm(0)
-
-                    if log_messages:
-                        display.display("jsonrpc response: %s" % resp, log_only=True)
-
-                    send_data(s, to_bytes(resp))
-
-                s.close()
-
-        except Exception as e:
-            # socket.accept() will raise EINTR if the socket.close() is called
-            if hasattr(e, 'errno'):
-                if e.errno != errno.EINTR:
-                    self.exception = traceback.format_exc()
-            else:
-                self.exception = traceback.format_exc()
-
-        finally:
-            # allow time for any exception msg send over socket to receive at other end before shutting down
-            time.sleep(0.1)
-
-            # when done, close the connection properly and cleanup the socket file so it can be recreated
-            self.shutdown()
-
-    def connect_timeout(self, signum, frame):
-        msg = 'persistent connection idle timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and ' \
-              'Troubleshooting Guide.' % self.connection.get_option('persistent_connect_timeout')
-        display.display(msg, log_only=True)
-        raise Exception(msg)
-
-    def command_timeout(self, signum, frame):
-        msg = 'command timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and Troubleshooting Guide.'\
-              % self.connection.get_option('persistent_command_timeout')
-        display.display(msg, log_only=True)
-        raise Exception(msg)
-
-    def handler(self, signum, frame):
-        msg = 'signal handler called with signal %s.' % signum
-        display.display(msg, log_only=True)
-        raise Exception(msg)
-
-    def shutdown(self):
-        """ Shuts down the local domain socket
-        """
-        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % os.path.split(self.socket_path))
-        if os.path.exists(self.socket_path):
-            try:
-                if self.sock:
-                    self.sock.close()
-                if self.connection:
-                    self.connection.close()
-            except Exception:
-                pass
-            finally:
-                if os.path.exists(self.socket_path):
-                    os.remove(self.socket_path)
-                    setattr(self.connection, '_socket_path', None)
-                    setattr(self.connection, '_connected', False)
-
-        if os.path.exists(lock_path):
-            os.remove(lock_path)
-
-        display.display('shutdown complete', log_only=True)
-
-
-def main():
-    """ Called to initiate the connect to the remote device
-    """
-    rc = 0
-    result = {}
-    messages = list()
-    socket_path = None
-
-    # Need stdin as a byte stream
-    if PY3:
-        stdin = sys.stdin.buffer
-    else:
-        stdin = sys.stdin
-
-    # Note: update the below log capture code after Display.display() is refactored.
-    saved_stdout = sys.stdout
-    sys.stdout = StringIO()
-
-    try:
-        # read the play context data via stdin, which means depickling it
-        vars_data = read_stream(stdin)
-        init_data = read_stream(stdin)
-
-        if PY3:
-            pc_data = cPickle.loads(init_data, encoding='bytes')
-            variables = cPickle.loads(vars_data, encoding='bytes')
-        else:
-            pc_data = cPickle.loads(init_data)
-            variables = cPickle.loads(vars_data)
-
-        play_context = PlayContext()
-        play_context.deserialize(pc_data)
-        display.verbosity = play_context.verbosity
-
-    except Exception as e:
-        rc = 1
-        result.update({
-            'error': to_text(e),
-            'exception': traceback.format_exc()
-        })
-
-    if rc == 0:
-        ssh = connection_loader.get('ssh', class_only=True)
-        ansible_playbook_pid = sys.argv[1]
-        cp = ssh._create_control_path(play_context.remote_addr, play_context.port, play_context.remote_user, play_context.connection, ansible_playbook_pid)
-
-        # create the persistent connection dir if need be and create the paths
-        # which we will be using later
-        tmp_path = unfrackpath(C.PERSISTENT_CONTROL_PATH_DIR)
-        makedirs_safe(tmp_path)
-
-        socket_path = unfrackpath(cp % dict(directory=tmp_path))
-        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % os.path.split(socket_path))
-
-        with file_lock(lock_path):
-            if not os.path.exists(socket_path):
-                messages.append(('vvvv', 'local domain socket does not exist, starting it'))
-                original_path = os.getcwd()
-                r, w = os.pipe()
-                pid = fork_process()
-
-                if pid == 0:
-                    try:
-                        os.close(r)
-                        wfd = os.fdopen(w, 'w')
-                        process = ConnectionProcess(wfd, play_context, socket_path, original_path, ansible_playbook_pid)
-                        process.start(variables)
-                    except Exception:
-                        messages.append(('error', traceback.format_exc()))
-                        rc = 1
-
-                    if rc == 0:
-                        process.run()
-                    else:
-                        process.shutdown()
-
-                    sys.exit(rc)
-
-                else:
-                    os.close(w)
-                    rfd = os.fdopen(r, 'r')
-                    data = json.loads(rfd.read(), cls=AnsibleJSONDecoder)
-                    messages.extend(data.pop('messages'))
-                    result.update(data)
-
-            else:
-                messages.append(('vvvv', 'found existing local domain socket, using it!'))
-                conn = Connection(socket_path)
-                conn.set_options(var_options=variables)
-                pc_data = to_text(init_data)
-                try:
-                    conn.update_play_context(pc_data)
-                except Exception as exc:
-                    # Only network_cli has update_play context, so missing this is
-                    # not fatal e.g. netconf
-                    if isinstance(exc, ConnectionError) and getattr(exc, 'code', None) == -32601:
-                        pass
-                    else:
-                        result.update({
-                            'error': to_text(exc),
-                            'exception': traceback.format_exc()
-                        })
-
-    if os.path.exists(socket_path):
-        messages.extend(Connection(socket_path).pop_messages())
-    messages.append(('vvvv', sys.stdout.getvalue()))
-    result.update({
-        'messages': messages,
-        'socket_path': socket_path
-    })
-
-    sys.stdout = saved_stdout
-    if 'exception' in result:
-        rc = 1
-        sys.stderr.write(json.dumps(result, cls=AnsibleJSONEncoder))
-    else:
-        rc = 0
-        sys.stdout.write(json.dumps(result, cls=AnsibleJSONEncoder))
-
-    sys.exit(rc)
-
-
-if __name__ == '__main__':
-    display = Display()
-    main()

bin/ansible-connection

@@ -0,0 +1 @@
+../lib/ansible/cli/scripts/ansible_connection_cli_stub.py

bin/ansible-test

@@ -1,15 +0,0 @@
-#!/usr/bin/env python
-# PYTHON_ARGCOMPLETE_OK
-"""Primary entry point for ansible-test."""
-
-from __future__ import (absolute_import, division, print_function)
-
-__metaclass__ = type
-
-import os
-import sys
-
-if __name__ == '__main__':
-    sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(os.path.dirname(__file__)), 'test', 'runner')))
-    import lib.cli
-    lib.cli.main()

bin/ansible-test

@@ -0,0 +1 @@
+../test/lib/ansible_test/_data/cli/ansible_test_cli_stub.py

changelogs/config.yaml

@@ -7,9 +7,7 @@ new_plugins_after_name: removed_features
 sections:
 - ['major_changes', 'Major Changes']
 - ['minor_changes', 'Minor Changes']
-- ['breaking_changes', 'Breaking Changes / Porting Guide']
 - ['deprecated_features', 'Deprecated Features']
 - ['removed_features', 'Removed Features (previously deprecated)']
-- ['security_fixes', 'Security Fixes']
 - ['bugfixes', 'Bugfixes']
 - ['known_issues', 'Known Issues']

changelogs/fragments/11349-add-ansible_play_name-var.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-    - Add ``ansible_play_name`` magic var (https://github.com/ansible/ansible/issues/11349)

changelogs/fragments/11935-slack-add_hex_color_values.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-    - Add support for hex color values in Slack module.

changelogs/fragments/159_kubectl.yml

@@ -1,2 +0,0 @@
-security_fixes:
-- kubectl - connection plugin now redact kubectl_token and kubectl_password in console log (https://github.com/ansible-collections/community.kubernetes/issues/65) (CVE-2020-1753).

changelogs/fragments/2.8-core-deprecations.yaml

@@ -1,4 +0,0 @@
-minor_changes:
-- ansible.vars.unsafe_proxy - Removed deprecated file (https://github.com/ansible/ansible/issues/45040)
-- fetch - Removed deprecated validate_md5 alias (https://github.com/ansible/ansible/issues/45039)
-- include_role/import_role - Removed deprecated private argument (https://github.com/ansible/ansible/issues/45038)

changelogs/fragments/2.8-removed-modules.yaml

@@ -1,6 +0,0 @@
-removed_features:
-- ec2_remote_facts - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- azure - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- cs_nic - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- netscaler - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- win_msi - deprecated module removed (https://github.com/ansible/ansible/pull/44985)

changelogs/fragments/20596-role-param_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- Fixed role's hash_params behavior to not union (https://github.com/ansible/ansible/issues/20596).

changelogs/fragments/225-mysql_user_fix_no_database_selected.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- mysql_user - fix the error No database selected (https://github.com/ansible/ansible/issues/68070).

changelogs/fragments/22766-fact-cmdline-return_multiple_lvm_values.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- cmdline fact parsing can return multiple values of a single key. Deprecate cmdline fact in favor of proc_cmdline.

changelogs/fragments/24004-yum-dnf-add-download_dir-param.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - yum/dnf - Add download_dir param (https://github.com/ansible/ansible/issues/24004)

changelogs/fragments/24633-copy-coherency-between-check-normal-mode.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - copy - align invocation in return value between check and normal mode

changelogs/fragments/26937-fix-remove-orphans.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - docker_compose - fixed an issue where ``remove_orphans`` doesn't work reliably.

changelogs/fragments/27237-handlers-template-run_once.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - Fix handlers to allow for templated values in run_once (https://github.com/ansible/ansible/issues/27237)

changelogs/fragments/29124-has-dead-workers.yaml

@@ -0,0 +1,4 @@
+bugfixes:
+- TaskQueueManager - Ensure ``has_dead_workers`` can function, by using the
+  correct reference, and only allow an exit code of 0.
+  (https://github.com/ansible/ansible/issues/29124)

changelogs/fragments/29135-include_vars-check_for_main.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- Enhance the conditional check to include main.yml if it is not from 'role/vars/' (https://github.com/ansible/ansible/pull/51926).

changelogs/fragments/29264-rabbitmq_policy-add-full-change-check.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - rabbitmq_policy - Add full check for rabbit policy changes (https://github.com/ansible/ansible/issues/29264)

changelogs/fragments/29366-allow-preservation-of-s3-bucket-tags.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - add purge_tags parameter to s3_bucket to allow preservation of existing tags when updating tags.

changelogs/fragments/31238-uri-multi-content-type.yaml

@@ -0,0 +1,3 @@
+bugfixes:
+- uri - Handle multiple Content-Type headers correctly
+  (https://github.com/ansible/ansible/pull/31238)

changelogs/fragments/31735-fix-hostnames-lookup-order.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - inventory_hostnames lookup - use the same order for the returned hosts as the inventory manager

changelogs/fragments/32366-test-match_fix_docs.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-    - Fix documentation of match test. Match requires zero or more characters at beginning of the string.

changelogs/fragments/32386_debconf_password.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- debconf - add a note about no_log=True since module might expose sensitive information to logs (https://github.com/ansible/ansible/issues/32386).

changelogs/fragments/33604-add-service-to-getent-module.yml

@@ -0,0 +1,2 @@
+minor_changes:
+    - getent - add service parameter to getent to lookup specified service

changelogs/fragments/33740-osx_say_callback_renamed_say.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - "``osx_say`` callback plugin was renamed into ``say``."

changelogs/fragments/33754-docker_image_fix_changed_in_force_mode.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_image - set ``changed`` to ``false`` when using ``force: yes`` to load or build an image that ends up being identical to one already present on the Docker host."

changelogs/fragments/34209-template-lookup-vault-support.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-  - Allow for vaulted templates in template lookup (https://github.com/ansible/ansible/issues/34209)

changelogs/fragments/35331-postgres_privs-add-all_in_schema-for-functions.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-  - postgres_privs now accepts 'ALL_IN_SCHEMA' objs for 'function' type (https://github.com/ansible/ansible/pull/35331).

changelogs/fragments/35370-add_support_for_docker_network_internal_flag.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - "docker_network - ``internal`` is now used to set the ``Internal`` property of the docker network during creation."

changelogs/fragments/36811-fix-lvol-valueerror-with-float-size.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - lvol - fixed ValueError when using float size (https://github.com/ansible/ansible/issues/32886, https://github.com/ansible/ansible/issues/29429)

changelogs/fragments/37150-make_modprobe_module_check_for_builtins_as_well.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-- "modprobe - The modprobe module now detects builtin kernel modules. If a kernel module is builtin the modprobe module will now: succeed (without incorrectly reporting changed) if ``state`` is ``present``; and fail if ``state`` is ``absent`` (with an error message like ``modprobe: ERROR: Module nfs is builtin.``). (https://github.com/ansible/ansible/pull/37150)"

changelogs/fragments/38118-postgresql_user-fix_conn_limit_type.yml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - conn_limit type is set to 'int' in postgresql_user module. This will allow module to compare conn_limit with record value without type casting.

changelogs/fragments/38803-postgresql_privs_fdw_and_fs_obj_types.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - "postgresql_privs - introduces support for FOREIGN DATA WRAPPER and FOREIGN SERVER as object types in postgresql_privs module. (https://github.com/ansible/ansible/issues/38801)"

changelogs/fragments/38833-docker_volume-option-minimum-versions.yml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - "docker_volume - option minimal versions now checked. (https://github.com/ansible/ansible/issues/38833)"

changelogs/fragments/38878-hashi_vault-support_userpass.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- hashi_vault lookup plugin now supports username and password method for the authentication (https://github.com/ansible/ansible/issues/38878).

changelogs/fragments/40092-mysql_user-match-backticks.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - "mysql_user: match backticks, single and double quotes when checking user privileges."

changelogs/fragments/40174-junit-test-case-prefix-filter.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-- junit callback plug-in - introduce a new option to consider a task only as test case if it has this value as prefix.

changelogs/fragments/40176-junit-hide-task-arguments.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-- junit callback plug-in - introduce a new option to hide task arguments similar to no_log.

changelogs/fragments/40366-modify-existing-volume.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - "add support for extending volumes in os_volume, also add module support for check_mode and diff"

changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - postgresql_db - the module fails not always when pg_dump errors occurred (https://github.com/ansible/ansible/issues/40424).

changelogs/fragments/42482-ipa_dnsrecord-srv_mx_record.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- Added support for MX and SRV record in ipa_dnsrecord module (https://github.com/ansible/ansible/pull/42482).

changelogs/fragments/42866-galaxy-search-unicode.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-   - ansible-galaxy - Prevent unicode errors when searching - https://github.com/ansible/ansible/issues/42866

changelogs/fragments/43123-add_support_for_per_host_no_stats.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - Add support for per_host:no stats for the callback plugin **json** (https://github.com/ansible/ansible/pull/43123)

changelogs/fragments/43874-docker_container-stop_timeout.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - ``stop_timeout`` is now also used to set the ``StopTimeout`` property of the docker container when creating the container."

changelogs/fragments/44278-pamd_valid_simple_controls.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- pamd - Allow for validation of definitive control in pamd module.

changelogs/fragments/44412-copy-fix-unwanted-acls.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - Fix unwanted ACLs when using copy module (https://github.com/ansible/ansible/issues/44412)

changelogs/fragments/44428-inventory-plugin-list.yml

@@ -1,3 +0,0 @@
-minor_changes:
-  - "default value for ``INVENTORY_ENABLED`` option was ``['host_list', 'script', 'yaml', 'ini', 'toml', 'auto']``
-    and is now ``['host_list', 'script', 'auto', 'yaml', 'ini', 'toml']``"

changelogs/fragments/44561-vmware_host_config_manager-fix_key_error.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- Fixed KeyError issue in vmware_host_config_manager when a supported option isn't already set (https://github.com/ansible/ansible/issues/44561).

changelogs/fragments/44624-dnsmadeeasy-fix_locale.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - dnsmadeeasy - force the date to be rendered with C (POSIX system default) locale as English short date names are required by API

changelogs/fragments/44692-docker-find-image.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container, docker_image, docker_image_facts - also find local image when image name is prefixed with ``docker.io/library/`` or ``docker.io/``."

changelogs/fragments/44739-assemble-avoid-extra-newline-Py3.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - assemble - avoid extra newline on Python 3 (https://github.com/ansible/ansible/issues/44739)

changelogs/fragments/44789-docker_container-comparisons.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "The restart/idempotency behavior of docker_container can now be controlled with the new comparisons parameter."

changelogs/fragments/44988-acme-post-as-get.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "ACME modules support `POST-as-GET <https://community.letsencrypt.org/t/acme-v2-scheduled-deprecation-of-unauthenticated-resource-gets/74380>`__ and will be able to access Let's Encrypt ACME v2 endpoint after November 1st, 2019."

changelogs/fragments/45155-vmware_host_service_facts-update_docs.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- Update docs and return section of vmware_host_service_facts module.

changelogs/fragments/45355-mysql_user-fix-versions-compatibilities.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- "mysql_user: fix compatibility issues with various MySQL/MariaDB versions"

changelogs/fragments/45628-fetch_url-error-headers.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "fetch_url did not always return lower-case header names in case of HTTP errors (https://github.com/ansible/ansible/pull/45628)."

changelogs/fragments/45631-empty-cow-whitelist.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- cowsay - Fix issue with an empty cow_whitelist (https://github.com/ansible/ansible/issues/45631)

changelogs/fragments/45824-uri-fix-TypeError.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-  - "uri: fix TypeError when file can't be saved"

changelogs/fragments/46322-docker_container-image-not-given.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container - the behavior is improved in case ``image`` is not specified, but needed for (re-)creating the container."

changelogs/fragments/46332-aws-improve-etag-handling.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - aws_s3 module - Improve ETag calculation, allow overwrite=always to work on FIPS-140-2

changelogs/fragments/46443-mongodb_user-fix-roles-default-value.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- mongodb_user - Change value for parameter roles to empty (https://github.com/ansible/ansible/issues/46443)

changelogs/fragments/46458-vmware_cluster_facts-show_tag.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - vmware_cluster_facts now supports tag facts (https://github.com/ansible/ansible/issues/46458).

changelogs/fragments/46461-vmware_host_facts-show_tag.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - vmware_host_facts now supports tag facts (https://github.com/ansible/ansible/issues/46461).

changelogs/fragments/46483-role_names-change.yaml

@@ -1,11 +0,0 @@
-minor_changes:
-  - magic variables - added a new ``ansible_role_names`` magic variable to include the names of roles being applied to
-    the host both directly and indirectly (via dependencies).
-  - magic variables - added a new ``ansible_play_role_names`` magic variable to mimic the old functionality of
-    ``role_names``. This variable only lists the names of roles being applied to the host directly, and does not
-    include those added via dependencies
-  - magic variables - added a new ``ansible_dependent_role_names`` magic variable to contain the names of roles
-    applied to the host indirectly, via dependencies.
-deprecated_features:
-  - magic variables - documented the deprecation of the ``role_names`` magic variable in favor of either
-    ``ansible_role_names`` (including dependency role names) or ``ansible_play_role_names`` (excluding dependencies).

changelogs/fragments/46594-docker_container-publish-all-ports.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container - ``publish_ports: all`` was not used correctly when checking idempotency."

changelogs/fragments/46595-docker_container-expected_ports.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container - fix idempotency check for published_ports in some special cases."

changelogs/fragments/46596-docker_container-published_ports.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - published_ports now supports port ranges, IPv6 addresses, and no longer accepts hostnames, which were never used correctly anyway."

changelogs/fragments/46598-docker_container-volume-modes.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - mount modes in ``volumes`` allow more values, similar to when using the ``docker`` executable."

changelogs/fragments/46608_azure_rm_inv_py3.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- azure_rm inventory plugin - fix runtime error under Python3 (https://github.com/ansible/ansible/pull/46608)

changelogs/fragments/46658-plugin_filter-improve_error_handling.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- Parsing plugin filter may raise TypeError, gracefully handle this exception and let user know about the syntax error in plugin filter file.

changelogs/fragments/46739-gcp-compute-instance-metadata.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - "gcp_compute_instance - fix crash when the instance metadata is not set"

changelogs/fragments/46740-gcp-utils-credentials-scoping.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - "gcp_utils - fix google auth scoping issue with application default credentials or google cloud engine credentials. Only scope credentials that can be scoped."

changelogs/fragments/46743-fix-native-jinja-newlines.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-    - templar - Do not strip new lines in native jinja - https://github.com/ansible/ansible/issues/46743

changelogs/fragments/46772-docker_container-healthcheck.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - Added support for healthcheck."

changelogs/fragments/46961_fix_aws_ec2_cache.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - aws_ec2 - fixed issue where cache did not contain the computed groups