Compare commits

...

596 Commits

Author SHA1 Message Date
8c16b47d11 New release v2.8.20 2021-04-12 17:26:44 -05:00
48c28ae7ae Update Ansible release version to v2.8.20rc1.post0. 2021-04-05 23:35:16 -05:00
2b584b6f3d New release v2.8.20rc1 2021-04-05 21:43:54 -05:00
6ac19b7757 [security] Add more missing no_logs (#74116)
Change:
- Add missing no_log on fields and subfields which should have it.
- Update several changelogs with CVE id.

Signed-off-by: Rick Elrod <rick@elrod.me>
2021-04-04 19:00:41 -05:00
6ed3e37df1 Backport of https://github.com/ansible-collections/community.docker/pull/103. (#73911) 2021-04-03 11:35:49 -05:00
ede3b02576 Backport of https://github.com/ansible-collections/community.network/pull/223. (#73913) 2021-04-03 11:26:55 -05:00
d523263945 Backport of https://github.com/ansible-collections/community.general/pull/2018. (#73912) 2021-04-03 11:26:33 -05:00
6b8c35cd41 Backport of https://github.com/ansible-collections/community.aws/pull/475. (#73910) 2021-04-03 11:24:36 -05:00
8ed0c02e5c Partial backport of community.aws/471 - no_log=True for aws_secret (#73873) 2021-04-03 11:22:39 -05:00
399b895095 [stable-2.8] Bump azure-pipelines-test-container to version 1.8.0 (#73551)
(cherry picked from commit c3e2bdd3a8)

Co-authored-by: Alexander Sowitzki <asowitzk@redhat.com>
2021-03-07 21:09:00 -06:00
8fbdaf2929 Pin version of openshift library (#73752)
The latest update to 0.12.0 is causing CI failures due to a difference in output.
2021-03-02 11:20:58 -06:00
bdb745798f Update signing key used in incidental_setup_flatpak_remote tests
The original key was created using the default expiration time of two years.
Signed the repo again using a key that expires in twenty years.
2021-02-22 12:30:53 -08:00
84e5a97e9a Update Ansible release version to v2.8.19.post0. 2021-02-18 18:33:42 -06:00
1205ad6a1a New release v2.8.19 2021-02-17 16:28:00 -06:00
7f4c962c5c Update Ansible release version to v2.8.19rc1.post0. 2021-02-08 23:07:35 -06:00
d1e7984c82 New release v2.8.19rc1 2021-02-08 19:07:27 -06:00
ce801e8a69 [setup_rpm_repo test] Ensure rpm-build is present (#73516) (#73519)
Change:
- Other targets might remove rpm-build as they clean up after
  themselves. Ensure that it's present in setup_rpm_repo because
  rpmfluff needs it.

Test Plan:
- Local experimentation with yum_repository and mysql_db (the latter of
  which depends on a handler which was removing rpm-build) on
  stable-2.9.

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit aca5b0e43b)
2021-02-05 15:37:24 -06:00
0785772a03 [bp-2.8] snmp_facts: Hide user sensitive information in console (#73189)
**SECURITY** - CVE-2021-20178

Hide user sensitive information like `privkey` and `authkey`
while logging in console.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2021-02-05 14:50:59 -06:00
bfea16c4f7 [bp-2.8] bitbucket_pipeline_variable: Hide secured values in console log (#73242)
**SECURITY** - CVE-2021-20180

Hide user sensitive information which is marked as ``secured``
while logging in console.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2021-02-05 14:49:31 -06:00
f8ff395d81 no_log mask suboption fallback values and defaults CVE-2021-20228 (#73487) (#73492)
(cherry picked from commit 0cdc410dce)
2021-02-05 11:35:30 -06:00
5829717315 no_log keycloak_client's registration_access_token (#73501)
Change:
- Address missing no_log change from #73489.

Tickets:
- Refs #73489

Signed-off-by: Rick Elrod <rick@elrod.me>
2021-02-05 11:31:43 -06:00
cc82d986c4 [security] Add no_log to several module args (CVE-2021-20191) [2.8] (#73488)
Change:
- A number of modules were missing no_log=True where they should have
  had it.

Test Plan:
- Lots of grepping.

Tickets:
- Refs https://github.com/ansible-collections/community.general/pull/1725

Signed-off-by: Rick Elrod <rick@elrod.me>
2021-02-04 18:06:39 -06:00
beeaf10c9f [stable-2.8] Fix yum_repository tests for CentOS 8 (#64863) (#73466)
* [stable-2.8] Fix yum_repository tests for CentOS 8 (#64863)

Refactor tests to run the same tasks with CentOS and Fedora using different variables..
(cherry picked from commit 05a7ce798d)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Make yum_repository test more reliable (#73467)

* Improve setup_rpm_repo

- add handlers to remove repos
- add variable to control whethere or not repos are created

* Use local repo for all distros
* Change repo creation script to module

(cherry picked from commit 997b2d2a19)

* Disable GPG check on install
2021-02-04 09:11:57 -08:00
21914b2ee3 [stable-2.8] Use a versioned pip bootstrapper in ansible-test. (#73361)
(cherry picked from commit fc590aeb21)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-01-25 15:38:07 -06:00
02b8a88846 [stable-2.8] Handle get-pip.py breaking change on Python 2.7.
(cherry picked from commit 484e4af4d0)

Co-authored-by: Matt Clay <matt@mystile.com>
2021-01-23 12:49:30 -08:00
fa01cd78c0 [2.8] update the docs requirements versions (#73108) (#73254)
* update the docs requirements versions (#73108)

(cherry picked from commit 0936623901)

* remove antsibull
2021-01-15 13:07:46 -06:00
0d0cb310a7 [stable-2.8] Update azure pipelines container
(cherry picked from commit 0eb1e22cd9)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2021-01-08 09:16:31 -08:00
2d2ea756a6 [stable-2.8] Constrain pexpect and ptyprocess (#73109)
The recent update of ptyprocess to 0.7.0 is incompatible with Python 2.6 and
is causing test failures.

* Add setup_pexpect role to expect test
(cherry picked from commit 003a9e890d)

Co-authored-by: Sam Doooran <sdoran@redhat.com>
2021-01-04 13:55:31 -08:00
cb848c927e [stable-2.8] Update Azure Pipelines scripts and config. (#72986)
* Increase fetch depth to reduce the frequency of full test runs for out-of-date PRs.
* Update scripts to match those which will be used in collections.
(cherry picked from commit 3274e02fd8)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-12-15 17:05:31 -08:00
ecfe290a6a Update Ansible release version to v2.8.18.post0. 2020-12-14 20:27:21 -06:00
9c83cbccf3 New release v2.8.18 2020-12-14 15:11:01 -06:00
6691dd5200 Update Ansible release version to v2.8.18rc1.post0. 2020-12-08 09:23:05 -06:00
77ad6c4574 New release v2.8.18rc1 2020-12-07 19:32:50 -06:00
0f1bd4de10 Disable win_rds* tests in CI (#72889) 2020-12-07 16:44:14 -06:00
be57020315 [stable-2.8] Remove shippable.yml. (#72884)
(cherry picked from commit 711064a073)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-12-07 16:43:39 -06:00
41f1209186 [2.8] [cloud_init_data_facts tests] fix for centos8 (#72886) (#72888)
Change:
- `udev` is provided by `systemd-udev`, which our `state=present` check
  doesn't match. For now, work around this so we don't end up trying to
  upgrade all of systemd.
- In the future, we should discuss if the `yum` module does the right
  thing here.

Test Plan:
- Locally in docker
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 8eaa7423d4)
2020-12-07 16:09:15 -06:00
35409b732d [stable-2.8] Use AZP config for integration-aliases test.
No changelog entry since this test is limited to the ansible/ansible repo.

Backport of https://github.com/ansible/ansible/pull/72842
2020-12-03 16:17:45 -08:00
94df5ab8e2 [stable-2.8] Fix Azure Pipelines change detection. (#72824)
(cherry picked from commit 08842cd6bb)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-12-03 10:12:07 -08:00
b279a05efa Fix resource name. 2020-12-02 21:59:19 -08:00
83ee185f84 [stable-2.8] Fix CI schedule. 2020-12-02 20:49:20 -08:00
a7fad72319 Fix resource name length. 2020-12-02 20:18:47 -08:00
1ff0ae1f6b update build badge for AZP (#72807) (#72812)
(cherry picked from commit d567a553a9)
2020-12-02 17:56:53 -08:00
14bde6cb84 [iso_extract tests] Fix another bad EPEL hardcode
Change:
- Use mirrorlist instead of baseurl here.

Test Plan:
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-12-02 16:39:01 -08:00
6f771ebe2f [stable-2.8] Azure Pipelines config. 2020-12-02 15:30:27 -08:00
7666b7f035 [yum_repository tests] account for EOL'd EPEL
Change:
- Let the tests continue to run on EOL'd CentOS 6 and EOL'd EPEL 6.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-12-02 15:20:48 -08:00
8192ed4454 [centos6] update container for EOL
Change:
- Reference:
  https://lists.centos.org/pipermail/centos-devel/2020-December/056208.html
- Bump centos6 container to 1.25.0

Test Plan:
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-12-02 14:01:30 -08:00
a9ac2a02c1 [stable-2.8] Pull images from Quay to avoid Docker Hub limits (#72700)
* Pull image from Quay to avoid Dockerhub limits

CI tests are failing in certain situations due to the new Docker Hub limits on anonymous pulls. Switch
to pulling an equivalent image from Quay.io.

* Use images in Quay that we control for CI

* Use images from a single test repo on Quay with tags

* Use correct hello-world image

* More image cleanup

* Fix bad replacement

* A few more alpine images

* Adjust expected output to match what the playbook sets it to
2020-12-01 17:05:29 -08:00
773ae7c3b2 Add RHEL 7.9 (#72558) - 2.8 (#72566)
* Add RHEL 7.9 - ci_complete (#72558)

(cherry picked from commit d451433e5d)

* Added changelog for RHEL 7.9 (#72572)

(cherry picked from commit bdd0c48837)
2020-12-01 12:51:32 -08:00
dc7f8badd5 [zypper_repository test] Use repo that doesn't 404 (#72779)
Change:
- The repo we were testing with no longer seems to exist. Point to one
  that does.

Test Plan:
- local test in docker
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-12-01 14:09:02 -06:00
9d1047f326 [stable-2.8] - ansible-test - add cryptography constraint for cffi (#72761)
The recently released version of cffi fails to install on systems with an older version of gcc. In
our case, this in the CentOS 6 test image. There is a fix but it has not yet been released.

https://foss.heptapod.net/pypy/cffi/-/issues/480
2020-12-01 10:32:23 -08:00
643c118cbd Test pip fix (#72766)
(cherry picked from commit 2eb9795543)
2020-12-01 10:36:33 -06:00
103ae173c7 [stable-2.8] Fix super annoying Python 2.6 multiprocessing.Queue stack trace in CI (#72604) (#72610)
* Fix super annoying Python 2.6 multiprocessing.Queue stack trace in CI

A bug exists in Python 2.6 that sometimes raises an exception during interpreter shutdown. We
encounter this frequently in our CI since we run tests on CentOS 6 as the control node, which
has Python 2.6.6 with this bug.

This PR adds a very minor sleep only on Python 2.6 which gets around this issue. I did lot of testing
using a standalon script I found that easily duplicated the issue to find the minimum sleep value
needed to avoid this issue.

CPython issue: https://bugs.python.org/issue4106
Fix in CPython: https://hg.python.org/cpython/rev/d316315a8781

* Use correct attribute
(cherry picked from commit bbef250c2b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-11-20 13:10:58 -06:00
c0be689295 replace porting guides with stub pages - issue 71687 (#71988) (#72600)
(cherry picked from commit 5a3a2d1a39)
2020-11-13 14:39:45 -06:00
0ea82ba711 [stable-2.8] Fix container discovery for the acme test plugin.
(cherry picked from commit f022dedd0a)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-11-09 15:30:23 -08:00
2529281ed8 Fix ansible-test tar format handling.
Effectively a backport of https://github.com/ansible/ansible/pull/66926
2020-11-02 17:08:25 -08:00
6606e79220 Update Ansible release version to v2.8.17.post0. 2020-11-02 19:05:30 -06:00
a6da75b908 New release v2.8.17 2020-11-02 15:28:55 -06:00
92128720bf [stable-2.8] Update pip tests to omit install dev extras to avoid dep issues (#72436) (#72440)
(cherry picked from commit 2ee5af5)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-11-02 11:06:02 -06:00
a4935c5780 Update Ansible release version to v2.8.17rc1.post0. 2020-10-26 19:02:16 -05:00
a345add182 New release v2.8.17rc1 2020-10-26 14:19:14 -05:00
75ef18dae1 Remove ansible-galaxy login (#72288) (#72330)
* GitHub is removing the underlying API used to implement the `login` command. Since the general consensus seems to be that relatively nobody currently uses this command (in favor of explicit token passing), support was simply removed for interactive login. If a future need arises, this command should be reimplemented via OAuth Device Auth Grants.
* login or role login commands now produce a fatal error with a descriptive message
 
(cherry picked from commit 83909bfa22)
2020-10-26 13:30:20 -05:00
73b2199fa2 [stable-2.8] [stable-2.9] [stable-2.10] Fix ansible-test handling of user-defined docker networks. (#72256) (#72310)
* Fix ansible-test docker container detection.

* Attach test containers to the correct network.

* Do not assume `localhost` for accesing Docker.

* Look for containers on current network.

* Always map /var/run/docker.sock into containers.

This fixes issues when using a remote Docker host.

* Support container IP lookup from networks list.

* Fix container network attachment.

* Remove redundant container detection messages.

* Limit DOCKER_HOST parsing to TCP.

* Restore docker socket existence check.

The check is skipped if the docker hostname is not localhost.

* Correct changelog entry..
(cherry picked from commit 3c2e8b99be)

Co-authored-by: Matt Clay <mclay@redhat.com>.
(cherry picked from commit 6362232c30)

Co-authored-by: Matt Clay <mclay@redhat.com>.
(cherry picked from commit 7c83f1f045)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-10-22 23:50:12 -05:00
d86d4285e1 CI stability updates. (#72307)
* Avoid issues with user-defined docker networks.
* Increase CI timeout.
* Increase unit test timeout.
2020-10-22 16:33:26 -07:00
785fa40dc5 [stable-2.8] Fix ansible-test Azure Pipelines container auth.
(cherry picked from commit 2ef4b7e07e)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-10-21 14:18:59 -07:00
2faf48f5f9 [2.8] kubectl: Follow up fix in connection plugin (#72131)
PR #71535 broke, _build_exec_cmd API in kubectl connection
plugin.

Fixes: #72171

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-10-09 11:46:16 -05:00
527dfa368a Update Ansible release version to v2.8.16.post0. 2020-10-05 18:55:16 -05:00
4b9308bd29 New release v2.8.16 2020-10-05 16:01:30 -05:00
f66f05f4bb [tests] Try re-enabling hcloud (#72034)
Change:
- See if they have fixed their issues yet.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-10-01 12:53:22 -05:00
b926f73309 [tests] --no-use-pep517 in kubevirt_conformance (#72016)
Change:
- This enables the inventory_kubevirt_conformance test to pass again on
  freebsd.
- This was due to a google-auth version bump. The dep chain looks like
  this: openshift -> kubernetes -> google-auth -> aiohttp -> multidict

Test Plan:
- ansible-test integration inventory_kubevirt_conformance --remote
  freebsd/12.0

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-09-30 10:46:11 -05:00
aac6ed13e6 [stable-2.8] Disabled inconsistent pylint checks..
(cherry picked from commit 8152d8bc1a)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-09-29 09:30:25 -07:00
1781285ceb Update Ansible release version to v2.8.16rc1.post0. 2020-09-28 14:51:31 -05:00
d2f85078b1 New release v2.8.16rc1 2020-09-28 12:17:31 -05:00
ed4db892d3 add CVE ref to kubectl changelog fragment (#71985)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-09-28 12:10:48 -05:00
b8f6c2d4b9 [stable-2.8] CI provider fixes for ansible-test. (#71929) (#71934)
* Make Azure Pipelines resource_prefix lowercase.

* Make classification of CI files consistent.

* Update package-data sanity test for AZP..
(cherry picked from commit 92b66e3e31)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-09-28 11:19:08 -05:00
15fe8c0239 [2.9] kubectl: redacted token and password from console log (#71971)
** SECURITY_FIX ** for CVE-2020-1753

kubectl connection plugin now redact kubectl_token and
kubectl_password from console log.

Fixes: ansible-collections/community.kubernetes#65

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-09-28 00:24:38 -05:00
f3d3c43c00 [tests] disable hcloud for now
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-09-26 03:39:08 -05:00
97c4064b87 [2.8] [tests] uninstall docker stuff for podman
Change:
- This isn't a direct backport of #71949 because in stable-2.8,
  setup_docker doesn't use handlers like more modern branches to clean
  up after itself.
- Instead, here we just make sure the docker packages are gone before
  the podman test runs.

Test Plan:
- CI
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-09-26 03:39:08 -05:00
2953544616 [backport][2.8] remove github link from plugins (#70951) (#71915)
* remove github link from plugins (#70951)

(cherry picked from commit e28b20d729)

* remove cli section
2020-09-24 14:07:53 -05:00
67cd27400a [2.9] Redirect inventory script links (#71732) (#71862)
(cherry picked from commit ef5f2c35ee)
2020-09-24 13:36:05 -05:00
4616b3bbac [incidental_setup_docker] changes to upstream repo (#71897) (#71901)
Change:
- The docker-ce.repo file for centos does not work on RHEL since it uses
  $releasever and on RHEL that is, e.g., "7Server".
- Instead, set up the repo manually.
- Additionally, the docker centos8 repo no longer has old versions, so
  we use the (only) version in the repo instead.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 31ddca4c0d)
(cherry picked from commit 651c0a2d03)
2020-09-23 21:36:46 -05:00
8ceb36098d update version switcher for 2.10 release (#71869)
(cherry picked from commit bf4e102d97)
2020-09-22 14:25:53 -05:00
e35aafa81c [stable-2.8] Fix attribute testing in file integration test. (#71843)
The file test will no longer attempt to test attributes if `lsattr -vd` does not work on the system under test.
(cherry picked from commit 17765cd4e8)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-09-21 15:06:42 -07:00
caf82158d0 [stable-2.8] openssl_privatekey test - Add pause for macOS
The stat time granularity on macOS is one second. We recently upgraded
to faster macOS hosts, so some tests that run closely together to see if
something changed will have the same timestamp intermittently.
2020-09-18 13:16:06 -07:00
81f660f606 [stable-2.8] incidental_setup_openssl - Pin version of Python packages
A recent update to cffi that was yanked is still being installed on our
Mac OS X 10.11 test image since the version of pip there is very old and
does not ignore yanked packages.

Pin the version of pyOpenSSL and its dependencies to fix this and avoid
future spontaneous failures..
(cherry picked from commit 65cdb86c8a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-09-17 08:45:31 -07:00
9a5999aa7e Backport documentation correction (#71633)
* Remove "mode: preserve" option from documentation #71486

(cherry picked from commit 7127d37466)
2020-09-09 11:47:23 -05:00
909ac41247 [stable-2.8] Backport ansible-test CI provider support. (#71625)
* Add types.py from devel to support backport.

* [stable-2.9] Backport ansible-test CI provider support. (#71614)

* Add encoding.py from devel to support backports.

* Add io.py from devel to support backports.

* Update ansible-test support for CI providers. (#69522)

Refactored CI provider code to simplify multiple provider support and addition of new providers.

(cherry picked from commit d8e0aadc0d)

* Add Shippable request signing to ansible-test. (#69526)

(cherry picked from commit e7c2eb519b)

* ansible-test local change detection: use --base-branch if specified (#69508)

(cherry picked from commit 43acd61901)

* Add Azure Pipelines support to ansible-test.

(cherry picked from commit 8ffaed00f8)

* Update ansible-test remote endpoint handling. (#71413)

* Request ansible-core-ci resources by provider.
* Remove obsolete us-east-2 CI endpoint.
* Add new --remote-endpoint option.
* Add warning for --remote-aws-region option.
* Update service endpoints.
* Allow non-standard remote stages.
* Add changelog fragment.

(cherry picked from commit d099591964)

* Fix ansible-test coverage traceback. (#71446)

* Add integration test for ansible-test coverage.

* Fix ansible-test coverage traceback.

* Fix coverage reporting on Python 2.6.

(cherry picked from commit f5b6df14ab)

* Use new endpoint for Parallels based instances.

(cherry picked from commit 98febab975)

* Add pause to avoid same mtime in test.

(cherry picked from commit 3d769f3a76)

Co-authored-by: Felix Fontein <felix@fontein.de>

(cherry picked from commit 417e408f59)
2020-09-03 18:42:38 -07:00
04ff489698 Update Ansible release version to v2.8.15.post0. 2020-09-01 01:13:11 -05:00
01d9ef008b New release v2.8.15 2020-08-31 20:13:44 -05:00
83eda14330 [tests] fix fallout from dnf gpg fix (#71550)
Change:
- Missed needed gpg ignores

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-31 20:09:30 -05:00
69827e0894 Re-add changelogs and add docs for CVE-2020-1736 reverts [2.8] (#71516)
Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-08-31 15:42:11 -05:00
a0ddefde38 Fix inventory_kubevirt_conformance test (#71545) 2020-08-31 15:28:50 -05:00
1fa2d5fd6b [dnf] ensure packages are gpg-verified (#71541)
Change:
- By default the dnf API does not gpg-verify packages. This is a feature
  that is executed in its CLI code. It never made it into Ansible's
  usage of the API, so packages were previously not verified.
- This fixes CVE-2020-14365.

Test Plan:
- New integration tests

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-31 10:05:42 -05:00
53be4cc03d point all older release pages to devel (#71428) (#71471)
(cherry picked from commit 3be597419d)
2020-08-27 10:20:12 -05:00
555b1fdd7a tests: Use hg serve instead of bitbucket for hg (#71403)
Change:
- Uses `hg serve` instead of a bitbucket repo for hg tests
- bitbucket no longer serves hg

Backport of #71398

Test Plan:
- CI, fixed integration tests

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-21 13:48:07 -05:00
eddb0920e4 Revert "[stable-2.8] Cap pytest version to avoid relative import issue."
This reverts commit 9c5663699f.
2020-08-18 11:45:26 -07:00
c6eff6bdb2 Revert "[stable-2.8] Change default file permissions so they are not world readable (#70221) (#70827)" (#71233)
This reverts commit 11738aed97.
2020-08-12 12:29:22 -05:00
8ba8a41b95 Update Ansible release version to v2.8.14.post0. 2020-08-10 22:41:25 -05:00
c404bd75ff New release v2.8.14 2020-08-10 20:30:00 -05:00
eb1114a1b1 [tests] pin docker to <4.3.0 (#71193)
Change:
- New python docker lib wants a newer docker than we have in CI.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-10 18:21:29 -05:00
f35e825440 [2.8] Sanitize URI module keys with no_log values (#70762) (#70822)
* Sanitize URI module keys with no_log values (#70762)

* Add sanitize_keys() to module_utils.

* More robust tests

* Revert 69653 change

* Allow list or dict

* fix pep8

* Sanitize lists within dict values

* words

* First pass at uri module

* Fix insane sanity tests

* fix integration tests

* Add changelog

* Remove unit test introduced in 69653

* Add ignore_keys param

* Sanitize all-the-things

* Ignore '_ansible*' keys

* cleanup

* Use module.no_log_values

* Avoid deep recursion issues by using deferred removal structure.

* Nit cleanups

* Add doc blurb

* spelling

* ci_complete

(cherry picked from commit bf98f031f3)

* update changelog for security_fixes

* Update 70762-sanitize-uri-keys.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
2020-08-07 16:57:50 -05:00
d73793fac7 Update integration tests to support rpmfluff-0.6 (#71155) (#71161)
Co-authored-by: Matt Martz <matt@sivel.net>
2020-08-07 14:52:26 -05:00
291f94934c copy - redact 'content' from invocation in check mode (#71033) (#71069)
* sanitize copy module invocation secrets in check mode

(cherry picked from commit 991714b9d1)
2020-08-07 12:10:43 -05:00
11738aed97 [stable-2.8] Change default file permissions so they are not world readable (#70221) (#70827)
* [stable-2.8] Change default file permissions so they are not world readable (#70221)

* Change default file permissions so they are not world readable

CVE-2020-1736

Set the default permissions for files we create with atomic_move() to 0o0660. Track
which files we create that did not exist and warn if the module supports 'mode'
and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults.

A code audit is needed to find all instances of modules that call atomic_move()
but do not call set_mode_if_different(). The findings need to be documented in
a changelog since we are not warning. Warning in those instances would be frustrating
to the user since they have no way to change the module code.

- use a set for storing list of created files
- just check the argument spac and params rather than using another property
- improve the warning message to include the default permissions.
(cherry picked from commit 5260527c4a)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Fix service test

* Fix lamdba_policy test

* Fix aws_lamdba test

* Fix warning for new default permissions when mode is not specified (#70976)

Follow up to #70221
Related to #67794
CVE-2020-1736

When set_mode_if_different() is called with mode of 'None', ensure we issue
a warning about the change in default permissions.

Add integration tests to ensure the warning works properly.

* Fix tests
- actually use custom module 🤦‍♂️
- verify file permission on created files
- use remote_tmp_dir so we're ready for split controller
- improve test module so we can skip the call to set_fs_attributes_if_different()
- fix tests for CentOS 6

(cherry picked from commit dc79528cc6)

* Use new category in changelog fragments
2020-08-06 19:03:48 -05:00
b95e520602 [stable-2.8] Drop "rhui-" prefix from RHEL repositories in AMI (#71130) (#71133)
The repository names seem to have changed and no longer have the "rhui-" prefix.
(cherry picked from commit 6ac4439a6a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-08-06 18:17:52 -05:00
7b8a66f284 [2.8] debconf: add a note about no_log usage (#70755)
debconf module exposes sensitive information to logs, console.
Add a note to user about using no_log=True to hide such
information from console.

Fixes: #32386

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 84b4387702)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 9b9bc112d5)
2020-08-06 15:55:48 -05:00
f6d5d548b7 Add ansible-releases@redhat.com to announce template (#70815)
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-08-06 12:38:37 -05:00
d1b2f66e16 backport of PRs 64763 and 70849 (#71098)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-08-06 10:05:05 -05:00
8ec313a107 use security_fix category in changelogs (#71072)
(cherry picked from commit 3d5217b6d5)

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
2020-08-03 14:55:25 -05:00
9c5663699f [stable-2.8] Cap pytest version to avoid relative import issue.
(cherry picked from commit 3a8ac62596)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-28 17:14:37 -07:00
eb7597c5cb [stable-2.8] Pin psutil version in pids test (#70716) 2020-07-17 15:58:00 -05:00
9d7594c627 [stable-2.8] ansible_runner test - Add constraints (#70667) (#70671)
A recent updated to psutil, which is a dependency of ansible-runner, fails
to install on older versions of pip.

Commit with the breaking change:

  135628639b
(cherry picked from commit 9d27d7c8b1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-15 17:39:23 -05:00
00db64d370 Update Ansible release version to v2.8.13.post0. 2020-07-14 18:18:55 -05:00
0c89598b8a New release v2.8.13 2020-07-14 16:43:19 -05:00
bff0724e9e [2.8] pipe: update docs for Popen with shell=True usage (#70604)
pipe lookup plugin uses Popen with shell=True intentionally.
This is considered a security issue if user input is not validated.
Updated docs to reflect this information for the user. Also, added
Bandit B602 documentation link for further reading.

Fixes: #70159

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit e5649ca3e8)
2020-07-13 13:01:07 -07:00
97d8a5d160 Remove deprecation for TRANSFORM_INVALID_GROUP_CHARS (#66650) (#69488)
Fixes #61889

(cherry picked from commit 6086ea62ee)
2020-07-13 12:59:59 -07:00
0f96e7e4cf [stable-2.8] Default ansible-test provisioning to us-east-1.
Previously windows instances on Shippable would be automatically directed to us-east-2.
(cherry picked from commit 1cf26896c5)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-07-07 15:19:08 -07:00
9fa105f183 Remove Azure module tests from CI. 2020-06-30 15:10:07 -07:00
0923e156c1 pip tests, use py2 compat sampleproject fork
Change:
- sampleproject has gone py3 only. Use a py2 compatible fork.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-06-26 09:04:03 -07:00
0b41e9b2f0 adds japanese translation as a version-switcher option (#70214) (#70216)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit 4a0f42923b)
2020-06-22 15:53:50 -05:00
b354b66c4b [stable-2.8] Pin version of netaddr and jmespath in filters test 2020-06-19 09:23:56 -07:00
14bcd3b7a3 yum - fix bug where enablerepo is not honored when disablerepo all (#66557) (#70085)
Fixes #66549

The inefficiency improvement
https://github.com/ansible/ansible/pull/63713 introduced a bug where
`enablerepo` was not being honored if combined with
`disablerepo="*"`. This fixes that issue.

Signed-off-by: Adam Miller <admiller@redhat.com>

Co-authored-by: Adam Miller <admiller@redhat.com>
2020-06-15 20:51:07 -05:00
a0f80fc2da Fix documentation of docker_host_info (it does not delete). (#69746) 2020-05-28 15:10:16 -05:00
47256e921c [stable-2.8] Pin Docker version at 19.03.1 (#69635) (#69646)
* [stable-2.8] Pin Docker version at 19.03.1
(cherry picked from commit fe941a4045)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* [stable-2.8] Pin docker-ce-cli version in tests (#69620)

Installing docker-ce has a dependency of docker-ce-cli. If the version of docker-ci-cli is not specified, it installs the latest version.

(cherry picked from commit 889da811d7)
2020-05-21 13:27:31 -07:00
60a6f5905f Update Ansible release version to v2.8.12.post0. 2020-05-12 08:32:00 -07:00
f2c259b152 New release v2.8.12 2020-05-11 16:31:14 -07:00
4cdbcc4ed9 Disable failing azure_rm_dnszone test.
The module requires updates to work with the current Azure API.
2020-05-07 22:32:19 -07:00
85dfb1f49a Fix win_psmodule and win_psrepository tests 2020-05-06 20:39:47 -07:00
bdc4c2a1c2 redfish_config: fix support for boolean BIOS attributes
Backport of ansible-collections/community.general#189 to stable-2.8

Currently the redfish_config module will convert boolean bios_attribute_value
settings to strings (type str). This will cause BMCs expecting booleans to
error out.

This PR will change the default type of bios_attribute_value to 'raw' in order
to support strings and booleans.

Fixes #68251
2020-05-05 19:33:42 -07:00
e60adefb46 mysql_user: fix error No database selected 2020-05-05 19:27:58 -07:00
7b50ca633f [2.8] Docs: point inventory script to respective version
With collections migration, inventory scripts are moved from devel (2.10).
Point docs for inventory script to their respective version.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-05-05 19:26:10 -07:00
e022b0d578 Add RHEL 8.2 to CI
Change:
RHEL 8.2 GA was released this week, test it in CI instead of 8.1.

Test Plan:
CI

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-30 14:58:37 -07:00
94751ef971 Enable dnf integration tests on CentOS 8
Change:
We were only testing dnf on RHEL previously.
Test on CentOS 8 as well.

Test Plan:
Ran locally in docker.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-30 14:58:37 -07:00
75c5c543cb [dnf] Make behavior/errors compatible for new DNF
Change:
Extend the logic for custom error handling in the dnf module, so that on
newer DNF (such as DNF that ships with modern Fedora 31 container
images, and ships with RHEL 8.2) we report errors consistently with
older DNF.

Test Plan:
Ran dnf integration tests against an old Fedora 31 container image and a
brand new Fedora 32 container image; tess passed on both.

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-30 14:58:37 -07:00
273d8538db document danger of kubectl options (#68195) 2020-04-21 11:45:43 -07:00
40969ff438 Fix incorrect CVE reference in changelog fragment
Change:
This corrects an incorrect CVE identifier in the changelog entry for
CVE-2020-1735.

Test Plan:
N/A

Tickets:
Refs #67793, #68720

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-21 11:43:32 -07:00
d9d236ff56 [stable-2.8] pip - Fix check_mode for prerelease packages (#68690)
* pip - Fix check_mode for prerelease packages

Fixes #68592.

Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Matt Martz <matt@sivel.net>
(cherry picked from commit 82c60db49b)

Co-authored-by: Rick Elrod <rick@elrod.me>
2020-04-21 11:31:23 -07:00
b02a996936 Update Ansible release version to v2.8.11.post0. 2020-04-16 20:04:47 -07:00
b9ebc0ceef New release v2.8.11 2020-04-16 16:33:11 -07:00
6f75aa2664 fixed fetch traversal from slurp (#68720)
* fixed fetch traversal from slurp

  * ignore slurp result for dest
  * fixed naming when source is relative
  * added tests with fake slurp
  * moved existing role tests into runme.sh
  * normalized on action excepts
  * moved dest transform down to when needed
  * added is_subpath check

fixes #67793

CVE-2019-3828

(cherry picked from commit ba87c225cd)
2020-04-15 12:47:45 -07:00
2a563514f0 safely use vault to edit secrets (#68644)
* when possible, use filedescriptors from mkstemp to avoid race
  * when using path strings, ensure we are always creating the file

CVE-2020-1740
Fixes #67798

Co-authored-by: samdoran
(cherry picked from commit 28f9fbdb5e)
2020-04-15 12:41:33 -07:00
e6199d768c [2.8] CVE-2020-1746 - Remove the params module option from ldap_attr and ldap_entry (#68715)
* Remove the params module option from ldap_attr and ldap_entry

Module options that circumvent Ansible's option handling were disallowed
in:
https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html

Additionally, this particular usage can be insecure if bind_pw is set
this way as the password could end up in a logfile or displayed on
stdout.

Fixes CVE-2020-1746

(cherry picked from commit 0ff609f1bc)

* Fix formatting for option names

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix fail_json

* update sanity

* fix indentation error

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-04-14 19:27:12 -07:00
5eabf7bb93 prevent ansible_facts injection (#68431) (#68445)
* prevent ansible_facts injection (#68431)

- also only replace when needed
 - switched from replace to index
 - added test to verify bogus_facts are not accepted

CVE-2020-10684

(cherry picked from commit a9d2ceafe4)

* added to ignore
2020-04-14 19:14:08 -07:00
e1273b6faf fix vault temp file handling (#68433)
* fix vault tmpe file handling

 * use local temp dir instead of system temp
 * ensure each worker clears dataloader temp files
 * added test for dangling temp files
 * added notes to data loader

CVE-2020-10685

(cherry picked from commit 6452a82452)
2020-04-14 18:48:12 -07:00
6c74a29870 subversion module - provide password securely when possible or warn (#67829)
* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658ec0c)
2020-04-14 18:42:03 -07:00
0e433f3d8f [backport/2.8/63280] acl: fix module failure if there're spaces in a path (#63280) (#63809)
* acl: fix module failure if there're spaces in a path (#63280)

* Make acl module to work with whitespaces in path

* Added a changelog fragment

* Add quotes to changelog fragment

(cherry picked from commit 504d76e956)

* Fix tests
2020-04-14 17:41:53 -07:00
75a28fe35f [stable-2.8] Always set the discovered interpreter on the delegated host (#64906)
* Always set the discovered interpreter on the delegated host. Fixes #63180

* Make code a little more generic

* Move code into a function

* Implement some changes based on reviews

* Add changelog fragment
(cherry picked from commit 123c624)

Co-authored-by: Matt Martz <matt@sivel.net>
2020-04-14 17:03:29 -07:00
8251d9f4c2 avoid mkdir -p (#68921) (#68927)
* avoid mkdir -p (#68921)

* also consolidated temp dir name generation, added pid for more 'uniqness'
* generalize error message
* added notes about remote expansion

CVE-2020-1733
fixes #67791

(cherry picked from commit 8077d8e401)

* C
2020-04-14 16:46:45 -07:00
a46a9b8fac win_unzip - normalize and compare paths to prevent path traversal (#67799)
* Actually inspect the paths and prevent escape
* Add integration tests
* Generate zip files for use in integration test
* Adjust error message

(cherry picked from commit d30c57ab22)
2020-04-14 12:55:40 -07:00
0a8d8b5c98 Disable failing azure_rm_cosmosdbaccount test. 2020-04-09 17:50:37 -07:00
191a17a67f [stable-2.8] Update tests to use RHEL 7.8. (#68787)
* Update tests to use RHEL 7.8.

Keeping support for RHEL 7.6 since collections are still using it.

* Fix tests for RHEL 7.7+ due to extras repo name change..
(cherry picked from commit 04edd77c42)

Co-authored-by: Matt Clay <mclay@redhat.com>
2020-04-09 01:53:37 -07:00
0e2e863f5c Fix win_psrepository tests
Backport of a5414cb0e4

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-09 00:32:22 -07:00
66cc931f0d OpenSUSE15.1 container image + necessary test changes (2.8 edition) (#68794)
* add changelog fragment

Signed-off-by: Rick Elrod <rick@elrod.me>

* Update changelogs/fragments/ansible-test-opensuse-15.1.yml

Co-Authored-By: Matt Clay <matt@mystile.com>

* handle installing mysql on suse

Signed-off-by: Rick Elrod <rick@elrod.me>

* attempt to get tests passing again

Signed-off-by: Rick Elrod <rick@elrod.me>

* Update docker.txt to use the OpenSUSE 15.1 container image

Signed-off-by: Rick Elrod <rick@elrod.me>

Co-authored-by: Matt Clay <matt@mystile.com>
2020-04-09 00:30:26 -07:00
18a2183a0b Backport of ansible-collections/community.crypto@28827db5d9 (#68631) 2020-04-03 14:15:42 -05:00
dd0b031a71 Update Ansible release version to v2.8.10.post0. 2020-03-05 13:50:25 -08:00
27d32fb88c New release v2.8.10 2020-03-05 11:08:39 -08:00
6883e0cc92 Add changelog entry for #68043 2020-03-05 10:31:04 -08:00
285ddf463e OpenStack: ensure min_version is a string
https://github.com/ansible/ansible/pull/67577/files broke OpenStack
modules in Ansible 2.8.9. The problem is that min_version should be a
string, since it is passed to StrictVersion(). However, after that
change min_version ends up as a StrictVersion. This causes a TypeError
when later used to instantiate another StrictVersion:

    TypeError: expected string or buffer

This change fixes the issue by ensuring min_version is a string. This
change is not required on other branches since the relevant code was
applied only in the 2.8 backport.

Fixes: #68042
2020-03-05 10:00:30 -08:00
668cdc3ce8 New release v2.8.9 2020-03-04 18:26:07 -08:00
a824c02ae4 Backport of 66995: mysql_user doesnt support privileges with underscore (#66999)
* Backport of 66995: mysql_user doesnt support privileges with underscore

* fix
2020-03-03 19:16:35 -08:00
9e4bd9b08b [stable-2.8] openssl_* modules: prevent crash on fingerprint determination in FIPS mode (#67515)
* openssl_* modules: prevent crash on fingerprint determination in FIPS mode.

* Add changelog.
(cherry picked from commit ca57871954)

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-03-03 18:55:13 -08:00
25e30573f4 win_unzip - LiteralPath fix (#66972)
* win_unzip - LiteralPath fix

* Fix up Python sanity issues

(cherry picked from commit 2a9ec8975f)
2020-03-03 18:52:15 -08:00
dfccf18d03 Fix user_agent string not getting set
(cherry picked from commit cb9e24fbd2)
2020-03-02 16:32:41 -08:00
22dd4e113d win_uri: fix up tests (#67064)
(cherry picked from commit 3ada0b2f65)
2020-03-02 16:32:13 -08:00
e3aa8a997e line indentation issue in postgresql_set (#67859)
Fixed indentation issue with the `register` for the example task in postgresql_set module.
(cherry picked from commit b437167671)
2020-03-02 16:31:53 -08:00
8fd095377a [stable-2.8] tests: ipify_facts: retry on fail (#66897)
(cherry picked from commit 91063f40d6)

Co-authored-by: Rene Moser <mail@renemoser.net>
2020-03-02 16:29:31 -08:00
e9a190e9c1 [backport 2.8] Bump min openstacksdk version for os_network/port_security_enabled
To make use of the port_security_enabled [a] parameter, [b] needs
to be present in the openstacksdk or the os_network module will
return an error like:

TypeError: create_network() got an unexpected keyword argument 'port_security_enabled'

To handle this, we fail the module if one of the arguments are used
and the minimum openstacksdk version for that argument is not met.

[a] eaf238b033
[b] 8eb788af07

Backport-of: https://review.opendev.org/708119
Fixes: #62062
2020-03-02 15:54:30 -08:00
b4614c949e Make nios_txt_record use text field for object lookup
Up until now, nios_txt_record assumed that the name and view
parameters uniquely described a TXT record. What this meant is that it
was impossible to have more than one TXT record with a certain name.

Changes in this commit expands the set of parameters that uniquely
identify the TXT record with a text field.
2020-03-02 13:17:54 -08:00
fc6e715e38 postgresql_info module: fix broken link (#67517) (#67522)
(cherry picked from commit 5a7c58b2be)
2020-02-18 09:49:01 -06:00
76fff030a8 [stable-2.8] Remove Tower module tests from CI. (#67368) (#67372)
* [stable-2.8] Remove Tower module tests from CI. (#67368)

* Remove Tower module tests from CI.

The required AMIs are no longer available.

* Mark Tower tests as unsupported..
(cherry picked from commit b041d96762)

Co-authored-by: Matt Clay <mclay@redhat.com>

* Mark tower_common unsupported.
2020-02-12 22:14:14 -08:00
70b577ab09 Docs: improve anchors vs. header bar (#67244) (#67319)
(cherry picked from commit fd43619f1a)
2020-02-11 15:36:57 -06:00
5e411807e7 [stable-2.8] ansible-test - add constraint for virtualenv (#67289)
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 8f296a6533)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-02-10 18:01:55 -08:00
6f5c94ffea [stable-2.8] Add constraints for Jinja2 on Python 2.6. (#66826)
* Add constraint for Jinja2 on Python 2.6.

* Fix constraint in inventory_aws_conformance test.

* Add constrraints for template_jinja2_latest test.
(cherry picked from commit 965854fbd2)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-01-27 15:55:57 -08:00
cb54c7c3b1 Update Ansible release version to v2.8.8.post0. 2020-01-15 15:22:34 -08:00
d28e4b63c7 New release v2.8.8 2020-01-15 15:04:55 -08:00
2d2c841ded [stable-2.8] Ignore warnings in ansible-test environment check.
(cherry picked from commit 3db1ac4f56)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-01-14 08:50:37 -08:00
2cd12efdb7 Remove Server 2008 from CI 2020-01-14 00:02:30 -08:00
6af5aad3cf [stable-2.8] Add test constraint for setuptools. (#66426)
* Add test constraint for setuptools.

* Update pip test to work on centos6 container.
(cherry picked from commit 51e5b714e0)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-01-13 14:02:14 -08:00
3edff5d42a Backport/2.8/63713 yum single yum base instantiation 53286 non existent repos (#65575)
* yum - only instantiate YumBase once (#63713)

* yum - only instantiate YumBase once

Previously, this code was re-instantiating the `YumBase` object
many times which is unnecessary and slow. However, we must do it
twice in the `state: absent` case because the `yumSack` and
`rpmSack` data of the previously instantiated object becomes
invalid and is no longer useful post transaction when we verify
that the package removal did in fact take place. Also, this patch
removes the repetitive re-processing of enable/disable of repos in
various places.

Here's a display of the speed increase against a RHEL7 host:

```yaml
- hosts: rhel7
  remote_user: root
  tasks:
  - name: Install generic packages
    yum:
      state: present
      name:
        - iptraf-ng
        - screen
        - erlang
  - name: Remove generic packages
    yum:
      state: absent
      name:
        - iptraf-ng
        - screen
        - erlang
```

Before this patch:
```
real    0m52.728s
user    0m5.645s
sys     0m0.482s
```

After this patch:
```
real    0m17.139s
user    0m3.238s
sys     0m0.277s
```

Fixes #63588
Fixes #63551

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* YUM - handle enable of non-existent repo (#53286)
2020-01-10 15:37:04 -08:00
41bddb61b8 Ensure allow_duplicates: true enables to run single role multiple times (#64902) (#65063)
* Ensure `allow_duplicates: true` enables to run single role multiple times(#64902)

* Changed return value in `_load_roles` . Fixes #64902

* Add changelog fragment

* Add an integration test for the issue

* Fix changelog generation error and integration test.

* Fix yaml syntax error in changelog fragment

* Fix typo in a changelog fragment of #64902

(cherry picked from commit daecbb9bf0)
(cherry picked from commit 33094e6c8e)
2020-01-10 15:31:43 -08:00
bbbde15562 [stable-2.8] Add ansible-test constraint to avoid coverage 5.0+
(cherry picked from commit 9ea5b539b6)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-01-10 15:25:48 -08:00
519846a1be docker_network: fix multiple subnet (of same IP version) idempotence (#65839)
* Fix multiple subnet (of same IP version) idempotence for docker_network.

* Add changelog.

* Unit tests no longer make sense, since the part of the code they test has been removed.

* Re-add CIDR validation. Move it to better position (module setup instead of idempotence check).

* Update changelog.

* Only run new tests on VM test images.

* Actually do what is documented. Especially since an empty object is a valid value for aux_addresses.

(cherry picked from commit 17ef253ad1)
2020-01-10 15:07:48 -08:00
3f98e1ff4e docker_container - #65993 - update restart policy (restart policy & restart retries) wit… (#66192)
* #65993 - update restart policy (restart policy & restart retries) without restarting the container

* - proper indentation on the continuation-line
- set restart_policy to the correct value independent from the api version

* - move restart_policy definitions into the if block
- add a new variable for the restart_policy configuration value

* add changelog fragment

* typo; minus -> underscore

* rename changelog fragment to contain the correct module name

* rename restart_policy_config_value to just restart_policy and refer to the correct dict values

(cherry picked from commit 02c126f5ee)
2020-01-10 15:03:55 -08:00
facf938690 [2.8] docker_container: wait for removal if removal is in process (#66118)
* docker_container: wait for removal if removal is in process (#65854)

* Allow to inspect containers directly.

* Wait for containers to be removed before recreating them.

* Also wait for containers to be removed before creating them.

* Add changelog.

(cherry picked from commit 4df5bdb11e)

* Don't wait for removal during check mode. (#66145)

(cherry picked from commit 14e32c85b4)
2020-01-10 14:22:39 -08:00
fc9d6ea64c [Backport 2.8] gitlab_runner: fix idempotency for shared runners (#65546)
* gitlab_runner: fix idempotency for shared runners (#65176)

* add changelog
2020-01-10 14:15:18 -08:00
11dd391784 dnf: don't return fail_json['msg'] as list (#65302)
Although it's not enforced that fail_json['msg'] should be a string
[1], I think it is pretty strongly implied.

In this case the failure_response['msg'] is sent through as the
fail_json['msg'], and the trailing commas here turn it into a tuple.
It's not clear if this is a typo or intended, but it does cause
problems for callbacks that expect this as a string (e.g. [2]).

Since there seems no point to having these values as a tuple, remove
the trailing commas so they return a string as per everywhere else.

[1] 4c589661c2/lib/ansible/module_utils/basic.py (L2078)
[2] https://review.opendev.org/#/c/696081

(cherry picked from commit fc54ae9227)
2020-01-10 12:19:33 -08:00
576a906393 [stable-2.8] Handle InternalError raised by cryptography when running in FIPS mode (#65477)
Since older versions of paramiko do not require cryptography,
we cannot catch the exact exception from cryptography.

Remove other exceptions since we're catching everything now
(cherry picked from commit d35c1a435b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-01-10 11:33:14 -08:00
15a53276aa [stable-2.8] user - honor update_password parameter on BusyBox hosts (#65977)
The check for this parameter was missing from BusyBox.modify_user(), resulting in unexpected password changes to existing user accounts.
(cherry picked from commit 18130e1419)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-01-10 11:32:00 -08:00
7a55bc1902 docker_swarm_service: Fix parsing of Healthcheck.StartPeriod (#66151)
* Parse Healthcheck.StartPeriod properly

* Add changelog fragment

* Use proper markup in changelog

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit f31b8e08b2)
2020-01-10 11:30:32 -08:00
0d08d78637 [2.8] Fix nxos_file_copy option value path validation (#65847)
* Fix nxos_file_copy option value path validation (#65423)

* Fix nxos_file_copy option value path validation

*  Modify `local_file`, `local_file_directory` and
   `remote_file` option type from `str` to `path`
   so that the option value is validated in Ansible
   for a legitimate path value

* Fix review comments

(cherry picked from commit 88008badb1)

* Fix trailing whitespace in docs.

Co-authored-by: Matt Clay <matt@mystile.com>
2020-01-10 11:11:18 -08:00
589a415f88 [2.8] solaris_zone: Allow only valid characters in zone name
CVE-2019-14904 - solaris_zone module accepts zone name and performs actions related to that.
However, there is no user input validation done while performing actions.
A malicious user could provide a crafted zone name which allows executing commands
into the server manipulating the module behaviour.

Adding user input validation as per Solaris Zone documentation fixes this issue.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7d2ae7e322)
2020-01-10 10:45:09 -08:00
b3a0ccc485 [stable-2.8] Simplify docker_setup on Fedora.
This avoids installing dnf-plugins-core, which breaks the yum and dnf modules
when uninstalling packages using a wildcard after they have already been removed.

This should resolve issues with the yum integration tests failing after docker tests run.
(cherry picked from commit a5c36eedd8)

Co-authored-by: Matt Clay <matt@mystile.com>
2020-01-08 16:14:21 -08:00
588cc8359c Add notes on docker_network connectivity for containers and services. (#65840) (#65965)
(cherry picked from commit d3b6db3754)
2020-01-02 15:50:50 -06:00
c290ea13f3 docker_swarm_service: Fix description of limits.memory (#66078) (#66112)
This option corresponds to the '--limit-memory' option. Also
fix other mentions memory reservation instead of limit.

(cherry picked from commit 30cfa92e90)

Co-authored-by: Pedro Alvarez Piedehierro <palvarez89@gmail.com>
2020-01-02 15:24:32 -06:00
77ce11b21d [stable-2.8] Disable failing azure_rm_storageaccount test.
(cherry picked from commit 342b9953bc)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-12-20 16:21:49 -08:00
d9368e195d [stable-2.8] Fix 'Assert CNAME failure' assertion (#65875)
(cherry picked from commit 14ebceec25)

Co-authored-by: Justin Ossevoort <github@internetionals.nl>
2019-12-20 13:48:48 -08:00
4efb8bdc4f update version metadata to get faceted swiftype search running (#65574) (#65580)
* update version metadata to get faceted swiftype search running

(cherry picked from commit 96cbbdd59f)
2019-12-10 14:03:06 -06:00
b1121828c0 [stable-2.8] Fix and reenable hcloud tests.
(cherry picked from commit 5ad61ed7c1)

Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
2019-12-06 10:04:31 -08:00
14a243c486 [stable-2.8] Disable failing hcloud tests..
(cherry picked from commit 85722c360f)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-12-04 10:43:17 -08:00
e9bdf249f5 Remove k8s_scale dependency on k8s_raw (#65271)
* Remove k8s_scale dependency on k8s_raw (#59887)

* Remove k8s_scale dependency on k8s_raw

* fix sanity checks

(cherry picked from commit e60cdc310d)

* Add changelog fragment

* Rename 59887-scale-bug to 59887-scale-bug.yml
2019-12-03 14:08:13 -08:00
b186ba8ee3 acme_certificate: Fix ACME v1 support when modify_account is set to false (#64648) (#65413)
* Fix ACME v1 when modify_account is set to false.

* Add changelog.

(cherry picked from commit 08b53b94a9)
2019-12-03 13:10:19 -08:00
0ed744c0a0 openssl_csr: make sure privatekey_path is specified when state is present (#65435) (#65460)
* Make sure privatekey_path is specified when state is present.

* Add changelog.

(cherry picked from commit ae4363f6d1)
2019-12-03 12:59:15 -08:00
34eb3f54dd [stable-2.8] Add or later to the license expressed in the README (#65288)
This is a clarification, not a relicensing.

Our source code says "GPLv3+" or "version 3 of the License, or later".
Our documentation says GPLv3+:

https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_checklist.rst#contributing-to-ansible-objective-requirements

We were just lazy when we wrote the README and left out the "or later".
this update to the README brings it in line with what everything else
says.
(cherry picked from commit a15fb26)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-12-03 12:56:47 -08:00
b3f06706ba docker_container and docker_network: avoid None errors (#65018) (#65234)
* Avoid None errors.

* Add changelog.

(cherry picked from commit 63b94fca7e)
2019-12-03 12:45:37 -08:00
0a6e22aeb0 Update plugins/netconf/ce.py to fix a bug(failed to get veriosn information via neocnf). (#65065) (#65231)
* fix version fail.

* add a changelog fragment.

* Update ce.py

* Rename plugins-netconf-ce-fix.yaml to 65065-plugins-netconf-ce-fix.yaml

* Update ce.py

(cherry picked from commit da8ec327cc)
2019-12-03 12:45:12 -08:00
188bd6dc54 [yarn] Set name_version when version is not specified (#62348) (#65214)
* Set name_version when version is not specified, fix #55097

This will default to installing the latest version available

* Add changelog fragment

* update changelog

(cherry picked from commit 136dc27572)
2019-12-03 11:14:01 -08:00
96bdcbe90c openssh_keypair: fix idempotence issue (#65017) (#65127)
* Fix idempotence issue.

* Add changelog.

(cherry picked from commit b36f572256)
2019-12-03 11:13:44 -08:00
666acb1754 gitlab module: set max version for python-gitlab lib (#65052) 2019-12-03 11:12:26 -08:00
8b452357ce gitlab_user: Fix ssh key add and group membership add when there's other changes (#63621) (#65045)
* Fixed syntax in sshkey/group add

* Added changelog

* pep8 fix

(cherry picked from commit b4bb3dee9a)
2019-12-03 11:11:06 -08:00
1593f68d72 Backport/2.8/64397 (#64794)
* [FIX] graceful is not an immutable attribute

(cherry picked from commit 1f4d15fc55)

* [ADD] changelog fragment for PR 64397 to stable-2.8
2019-12-03 10:58:35 -08:00
290e63aba5 Backport/2.8/64351 Doc notes 6 (#64351) (#64945)
* Doc notes 6 (#64351)

(cherry picked from commit 25e03b1e75)

* add a changelog
2019-11-19 11:36:06 -06:00
c1c2c76ad0 Backport/2.8/64928 Doc notes 5 (#64928) (#64944)
* Doc notes 5 (#64928)

* new version 2.10 can not be backported

(cherry picked from commit 8ea9d0c06a)

* add a changelog
2019-11-19 11:35:11 -06:00
23812f4b6e Backport/2.8/64927 Doc notes 4 (#64927) (#64940)
* Doc notes 4 (#64927)

* exclude new in 2.10

(cherry picked from commit 2ccdf29b5b)

* add a changelog, update 64940_update_modules_docs_notes.yml
2019-11-19 11:33:08 -06:00
564570faf2 Backport/2.8/64348 Doc notes 3 (#64348) (#64941)
* Doc notes 3 (#64348)

(cherry picked from commit ad0769c095)

* add a changelog
2019-11-19 11:31:53 -06:00
686592bdb1 Backport/2.8/64347 Doc notes 2 (#64347) (#64942)
* Doc notes 2 (#64347)
* Update ce_evpn_bgp_rr.py
* Update ce_evpn_bgp.py

(cherry picked from commit 9e3b1f3b32)

* add a changelog.
2019-11-19 11:31:03 -06:00
5781d19ab5 Backport/2.8/64346 Doc notes 1 (#64346) (#64943)
* Doc notes 1 (#64346)

(cherry picked from commit 705c014ec3)

* add  a changelog.
2019-11-19 11:30:00 -06:00
37435c0df1 Update openssl_certificate.py (#64772) (#64803)
Changed 'generate' to 'generating'

(cherry picked from commit 83927c3437)
2019-11-18 15:36:23 -06:00
7eb9808ee8 Update Ansible release version to v2.8.7.post0. 2019-11-13 17:00:13 -08:00
24220a618a New release v2.8.7 2019-11-13 12:46:45 -08:00
63b0ae494e Improve handling of "restarted" state for win_iis_website module (#63829) (#64759)
* Improve handling of "restarted" state for win_iis_website module

* Added changelog fragment

(cherry picked from commit bd9a0b6700)
2019-11-12 18:47:12 -08:00
39f83ce38c win_acl no longer needs SeSecurityPrivilege (#57804) (#64757)
* win_acl no longer needs SeSecurityPrivilege
Set-ACL raises missing SeSecurityPrivilege error when the inheritance
from the parent directory is disabled.

* fixes test sanity

* registry rights can only be modified with Set-ACL

* add changelog

(cherry picked from commit 95d613f3ab)
2019-11-12 18:46:31 -08:00
59f417c469 Corrected Get-adcomputer (#63093) (#64755)
* Corrected Get-adcomputer

Corrected Get-adcomputer on "Remove-ConstructedState" and "Set-ConstructedState" functions.
resolved error: Unable to contact the server. This may be because this server does not exist, it is currently down, or it does not have the Active Directory Web Services running.

* Update lib/ansible/modules/windows/win_domain_computer.ps1

Co-Authored-By: Daniel-Sanchez-Fabregas <33929811+Daniel-Sanchez-Fabregas@users.noreply.github.com>

* Update win_domain_computer.ps1

changed
"-credential $credential" to "@extra_args" (Line 115 and 150)
corrected exception message (Line 122)

* Added changelog fragment, minor code tweak

(cherry picked from commit e77426dad3)
2019-11-12 18:45:39 -08:00
2dbe024fcb ce_config/bug/jingdong: a bug from jingdong. (#62872) (#63978)
* update to fix "`quit` may make seesion closed."

* update to fix "`quit` may make seesion closed."

* 274:49: E272: multiple spaces before keyword

* add a changelog fragment.

* Update ce_config.py

using run_command for prompts.

* Update ce_config.py

* Update ce_config.py

typo error

* update to use get_prompt

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

* Update ce_config.py

(cherry picked from commit e4b6dd1862)
2019-11-12 11:57:48 -08:00
20a8bf592e {Backport/2.8/64018]update ce_acl_interface to fix bugs (#64024)
* update ce_acl_interface to fix bugs

(cherry picked from commit 2849738e24)

* Module modification information
2019-11-12 11:56:01 -08:00
dfa74b5c52 change $partition variable name to $ansible_partition (#63968) (#64691)
* change $partition variable name to $ansbile_partition

* Added changelog fragment

(cherry picked from commit 8b13836b1f)
2019-11-12 10:34:45 -08:00
436b2c44f6 [2.8] Remove temp directory created by wait_for_connection (#64739)
wait_for_connection creates AnsiballZ_ping.py in temp directory,
which remains on remote machine even after playbook run.

Fixes: #62407

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 68428efc39)
2019-11-12 10:30:08 -08:00
773644e35c 2.8: perf: reduce getting handler variables (#59969) (#64675)
* perf: reduce getting handler variables (#59969)

ci_complete

(cherry picked from commit 9ccef9e819)

* Add changelog

* Fix incorrectly resolved conflict

* set_available_variables
2019-11-12 08:48:49 -08:00
421612ed02 Buypass now has a ACME v2 production endpoint. (#64649) (#64681)
(cherry picked from commit 4083d02989)
2019-11-11 19:14:45 -08:00
ec01279a9c postgresql_query: add note to the documentation (#64540) 2019-11-11 19:06:06 -08:00
595bdfa8bb [2.8] openssl_csr and openssl_certificate: fix support for Ed25519 and Ed448 private keys (#64126)
* openssl_csr and openssl_certificate: fix support for Ed25519 and Ed448 private keys (#63984)

* Move X25519, X448, Ed25519 and Ed448 feature tests to module_utils.

* Correctly sign with Ed25519 and Ed448 keys.

* Fix public key comparison. Ed25519 and Ed448 do not have public_numbers().

* Add tests.

* Add changelog.

* Give better errors for cryptography 2.6.x and 2.7.x.

* Test for new errors.

* Forgot one.

* Used wrong private key.

* Use private key password for CA key. Add more stuff to its certificate.

(cherry picked from commit fed267df03)

* Pass select_crypto_backend also to test implementation. This exists in devel but not yet in stable-2.8.
2019-11-11 19:04:43 -08:00
85cb406753 Backport #59614 to stable-2.8 (#64011)
* VMware: Fix Service Content calls in vmware_deploy_ovf

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* add changelog
2019-11-11 19:01:07 -08:00
1855494378 XenServer: Update docs with recent changes in XenAPI python lib and branding (#63728) (#63816)
- xenserver module_util: XenAPI lib import error message handling is now
   ported to missing_required_lib(). Updated unit tests.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   docs are updated to reflect recent changes in availability of XenAPI lib
   on PyPI.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   docs are updated to reflect recent Citrix rebranding of XenServer. Broken
   URLs to external resources are fixed.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   more tested platforms are mentioned in docs.

(cherry picked from commit 7afba9420a)
2019-11-11 18:11:14 -08:00
0daa435467 Backport/2.8/58525 - Use atexit to logout after zabbix module run (#63783)
* Use atexit to logout after zabbix module run (#58525)

(cherry picked from commit d582efcc51)

* added changelog fragment
2019-11-11 18:07:51 -08:00
d3e13aae09 Fixes #56832: Remove warning when falling back to apt-get if aptitude is missing. (#61782) (#64651)
(cherry picked from commit a6ec6c3175)
2019-11-11 18:04:24 -08:00
4f9a301594 docker_swarm_service: Allow source to be omitted for tmpfs mounts (#64637) (#64641)
* Allow source to be omitted for tmpfs mounts.

* Add changelog.

(cherry picked from commit 574bd32db2)
2019-11-11 18:03:25 -08:00
d98b9ddb3b docker_login: Use with statement for accessing files (#64382) (#64392) (#64525)
* docker_login: Use with statement for accessing files (#64382)

* Update changelogs/fragments/64382-docker_login-fix-invalid-json.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit 52c4c1b00d)
2019-11-11 18:01:53 -08:00
050f92f960 [2.8] Callback: removing args from task_fields from Sumologic and Splunk plugin (#64273)
CVE-2019-14864 Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs

Fixes #63522

Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit c76e074e4c)
2019-11-11 18:00:55 -08:00
6749ffe824 [stable-2.8] paramiko_ssh - Improve authentication error message (#64157) (#64165)
The error is not always an invalid username/password. It could be a connection timeout or refusal.
(cherry picked from commit d5fbe6573b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-11-11 17:59:52 -08:00
8b5cd5b64c sysctl: fix 'err' referenced before assignment (#64139)
* sysctl: fix 'err' referenced before assignment
* Add changelog

Fixes #63967

(cherry picked from commit 9069a681aa)
2019-11-11 17:58:49 -08:00
0c89a97107 [stable-2.8] copy - check for changes beyond first level of subdirectories (#58323) (#64112)
Add integration test for copy: deep recursive with remote_src=True
(cherry picked from commit b7e38dfa52)

Co-authored-by: Alexander Korsunsky <A.Korsunsky@gmail.com>
2019-11-11 17:37:58 -08:00
ba29567210 lineinfile - don't run os.makedirs on empty dir path (#63921) (#64090)
* Fix #63919: don't run os.makedirs on empty dir path

* integration test for lineinfile create: yes without path

(cherry picked from commit 3c978a3225)
2019-11-11 17:36:23 -08:00
fc62483b3e ACMEAccount.get_request check status code value lower boundary (#63140) (#64072)
* check status code value lower boundary

Any HTTP code below 200 cannot be considered a success, should be
handled like a failure instead.

This is particularly true for below zero status codes.

Fixes #63139

* provide changelog fragment

* ensure connection errors are handled in Acme module

* add fetch_url check to ACME.send_signed_request

* remove module.fail_json

* move _assert_fetch_url_success out of ACMEAccount

* fix ansible-lint errors

* use simplified syntax status checking

(cherry picked from commit 0d905a0496)
2019-11-11 17:34:56 -08:00
f861c284d0 [stable-2.8] lineinfile - use correct index value when inserting at the end (#63696) (#63795)
(cherry picked from commit 92cd13a2cf)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-11-11 17:29:52 -08:00
cbe69adf37 [stable-2.8] lineinfile - properly insert line when line exists and backrefs are enabled (#63763) (#63791)
Use a separate variable for the boolean test rather than having the same variable sometimes be a boolean and sometimes be a regular expression match object

Add integration tests to cover this scenario
(cherry picked from commit 29d4d318a5)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-11-11 17:29:02 -08:00
d3a9bbc9d1 action/ce.py:clear configuration candidate when return to user-view. (#63513) (#63704)
* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c201b)
2019-11-11 17:26:51 -08:00
0846bb85d3 Backportable subset of: openssl_csr: deprecate version option (#63432) (#63675)
Cherry-picked from ba686154b9.
2019-11-11 17:23:54 -08:00
484fd8271e Improve module return values (#63541) (#63645)
* Remove lists from contains:, fix types, some more details.

* Adjust types.

* Add new type.

* Re-add meraki_mx_l7_firewall docs at right indentation level.

(cherry picked from commit a129499cf4)
2019-11-11 16:54:32 -08:00
95417c2260 ansible-vault: convert vault_password_files to list to prevent traceback (#57186) (#63622)
* Convert vault_password_files to a list

* Add changelog and tests
2019-11-11 16:51:14 -08:00
f471f7a6b3 Backport 2.8: Fix Gitlab module deprecation warning (#60425) (#63498)
* Fix Gitlab module deprecation warning (#60425)

* gitlab modules : Fix deprecation warnings and parameters

Also preparing for 2.10 deprecation

* gitlab modules : Correct deprecation message

(cherry picked from commit 7bb90999d3)

* gitlab_modules :  remove misssing required parameter (#63690)

* gitlab_group: remove required=True on server_url param

* gitlab_project: remove required=True on server_url param

* Revert "Example incorrect: server_url is required argument (#63670)"

This reverts commit b02467961a.
This modification shouldn't have been made.
This parameter is deprecated and #60425 forget to remove the required
parameter

(cherry picked from commit 0af32a1093)

* gitlab modules : Add changelog
2019-11-11 16:39:22 -08:00
a6687bef32 Fix issue when setting an empty pass to no_log param (#62804) - 2.8 (#62813)
* Fix issue when setting an empty pass to no_log param (#62804)

* Fix issue when setting an empty pass to no_log param

* Fix typo

(cherry picked from commit 322e225830)

* Fix up actual get for older versions
2019-11-11 15:38:40 -08:00
34c76bf2a1 [stable-2.8] Switch from RHEL 8.0 & 8.1b to 8.1 in CI.
(cherry picked from commit 75646037dc)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-11-07 14:58:58 -08:00
4afd3ad03b add porting guide for bare vars in conditionals (#60943) (#64289)
(cherry picked from commit 0b7d478200)
2019-11-01 14:08:33 -05:00
6dec6a736e [Doc-Release-2.9] Backport/2.8/docs release (#64270)
* docs: update version-checker to latest 3 versions (#64109)

(cherry picked from commit 409545825f)

* [Doc-Release-2.9] update release and maintenance page for 2.9 (#64166)

* update release and maintenance page for 2.9
* only 2.4 and earlier used the old changelog system

(cherry picked from commit 3f808d9ed6)
2019-11-01 09:42:05 -05:00
76f046be72 win_hotfix: fix docs typo (#63807)
(cherry picked from commit b43a2b0607)
2019-10-29 14:34:46 -05:00
2ac8308edf Updated with slipped dates for the 2.9.0 release (#63243) (#63799)
(cherry picked from commit 5997d33381)
2019-10-22 12:25:02 -05:00
ebefd0b715 Update Ansible release version to v2.8.6.post0. 2019-10-17 14:59:59 -07:00
d778c59c43 New release v2.8.6 2019-10-17 09:57:00 -07:00
5eac93e7fd [2.8] Fix return value documentation (2/2) (#63534)
* Fix return value documentation (2/2) (#63478)
* Avoid validation errors for missing 'contains:'.
* Convert JSON text to JSON dict.
* example -> sample.
* Fix YAML.

(cherry picked from commit 4bc298af83)

* Update validate-modules/ignore.txt.
2019-10-16 11:43:25 -05:00
293ae8030b [2.8] Fix return value documentation (1/2) (#63517)
* Fix return value documentation (1/2) (#63477)
* Avoid validation errors for missing 'contains:'.

(cherry picked from commit 6bea1597cc)

* Add validate-modules/ignore.txt entries.
2019-10-16 11:37:57 -05:00
d95ddf8519 Fix doc - porting_guide_2.8 value example (#63493) (#63525)
(cherry picked from commit e0f67b58ce)
2019-10-16 10:27:17 -05:00
4d322654e7 mysql_user: add seealso (#63497) (#63501)
(cherry picked from commit ecf71dd720)
2019-10-15 13:58:40 -05:00
d1e198e8ea docker_node_info: improve error handling (#63418)
* Improve error handling for get_service_inspect().

* Add changelog fragment.

(cherry picked from commit d753168e9d)
2019-10-14 17:02:27 -07:00
45278ceef7 [stable-2.8] user - fix shadow file parsing on AIX (#62547)
Initialize variables in case the shadow file is not found.
Handle IndexErrors if something goes wrong with file parsing.
(cherry picked from commit e9d10f94b7)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-10-14 17:00:32 -07:00
15ef4d119c [Backport/2.8/63331]Update ce_facts to fix bugs (#63456)
* Update ce_facts to fix bugs

(cherry picked from commit 73e7da40ff)

* Update ce_facts modified information
2019-10-14 16:58:19 -07:00
db083ad943 Backport/2.8/62471 ce_link_status:update to fix a bug. (#62417) (#63422)
* update to fix a bug. (#62417)


(cherry picked from commit 7541dab1ef)

* add a changelog fragment.
2019-10-14 16:57:14 -07:00
3dfb8e81bb [stable-2.8] Properly mask no_log values is sub parameters during failure (#63405)
* Get no_log parameters from subspec

* Add changelog and unit tests

* Handle list of dicts in suboptions

Add fancy error message (this will probably haunt me)

* Update unit tests to test for list of dicts in suboptions

* Add integration tests

* Validate parameters in dict and list

In case it comes in as a string

* Make changes based on feedback, fix tests

* Simplify validators since we only need to validate dicts

Add test for suboptions passed in as strings to ensure they get validated properly and turned into a dictionary.

ci_complete

* Add a few more integration tests
(cherry picked from commit e9d29b1fe4)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-10-14 16:46:37 -07:00
33af5752cd [backport 2.8] facts: detect FreeBSD jails guest (#62857) (#62911)
* facts: detect FreeBSD jails guest (#62857)

* facts: detect FreeBSD jails

* PEP8 fix

* changelog for pr62913
2019-10-14 16:45:58 -07:00
bae45dd930 [stable-2.8] package_facts - use AnsibleModule.warn() for warnings
(cherry picked from commit 2b1e24f)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-10-14 15:55:42 -07:00
8dd0c80ab7 clarify package facts errors and warnings (#56060)
* clarify package facts errors and warnings

  fixes #56056

(cherry picked from commit 615db8e6f4)
2019-10-14 15:27:56 -07:00
ae1bbfa008 Package facts apt fix (#55963)
* fixes for apt on package_facts

* reverse order, apt is newer

* moved warnings prop to base

(cherry picked from commit 24a46deef5)
2019-10-14 14:18:39 -07:00
12459b19b1 Added implicit initialization of APT package manager '_cache' field (#55851)
(cherry picked from commit c707dd7b62)
2019-10-14 14:18:39 -07:00
006156dee1 docker_image: fix option parameter so that warnings are issued (#63345)
* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784131)
2019-10-12 10:00:22 -07:00
ffe9368d35 Backport/2.8/63332 ce_netstream_global: bugs fix(list index out of range) (#63332) (#63388)
* ce_netstream_global: bugs fix(list index out of range) (#63332)

* update to fix bugs:index out of range

* list index out of range

* list index out of range

* update for bad-whitespace

* Update ce_netstream_aging.py

* Update ce_netstream_aging.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_aging.py

(cherry picked from commit b7f12f9ff3)

* add a changelog fragment.

* Update 63388_ce_netsream_list_index_out_of_range.yml

changelogs/fragments/63388_ce_netsream_list_index_out_of_range.yml:5:1: empty-lines too many blank lines (1 > 0)
2019-10-12 09:58:08 -07:00
baec182fa9 Backport/2.8/59450 ce_file_copy: update to Compatible with multiple version of NETCONF A… (#63386)
* ce_file_copy: update to Compatible with multiple version of NETCONF API. (#59450)

* update to Compatible with multiple version of NETCONF API.

* update for  shippable.

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

(cherry picked from commit 86937e06e3)

* add a changelog fragment.
2019-10-12 09:55:08 -07:00
b7fe3407c3 clean "changed" only after it has been processed (#59958)
* clean "changed" after it has been processed

without this change, a loop of `debug` tasks with `changed_when`
causes the "changed" status to get lost before output

* runme.sh tests for debug loop status

(cherry picked from commit bfd32c9b00)
2019-10-12 09:14:33 -07:00
6046da759f [2.8] Add cookie handling from issue #61672 (#62968)
* issue #61672 backporting in Ansible 2.8

* YAML extension added for Changelog fragment
2019-10-12 09:12:21 -07:00
e56ee65ca7 Docs - Add Meraki to platform option list (#61651)
(cherry picked from commit 54906a68fe)
2019-10-12 08:55:21 -07:00
f8cd3ca5a8 docker_* modules: docs improvements (#63165)
* Improve docker_container docs.

* Fix usage of C(...) and I(...).

* Fix abuses of I(...).

* tls_verify has been made an alias of validate_certs some time ago.

* Fix YAML problems.

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Fix order.

* Split long description.

* Improve formatting.

* Rewrite state docs.

* Make proper sentences.

(cherry picked from commit 5349b3ae4c)
2019-10-12 08:54:22 -07:00
3d8df9de72 lineinfile - fix bug with insertbefore/insertafter and firstmatch (#63194)
(cherry picked from commit 3b18337cac)
2019-10-12 08:51:16 -07:00
533cd12a5d Backport/2.8/62587 module_utils/network/cloudengine:fix get_nc_next. (#62751)
* fix plugins/netconf/ce.py for netconf/capability/exchange (#60569)


(cherry picked from commit 037401b6e0)

* for capability/exchange/1.0 (#60630)

* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py

(cherry picked from commit 28227c95a4)

* module_utils-network-cloudengine: fix get_nc_next. (#62587)

* fix get_nc_next.

* add a changelog fragment.

* upadte for  changelgo fragment.

* merge two prs, one depens another.

* merge two prs, one depens another.

* update changelog.

(cherry picked from commit d6ef7c8530)
2019-10-12 08:48:25 -07:00
ff5e23cbc9 [Backport/2.8/62589]update ce_bgp_af to fix bugs (#62651)
* update ce_bgp_af to fix bugs (#62589)

* update to fix bugs

* update to fix bugs

(cherry picked from commit 2a206f0e4c)

* Update ce_bgp_af modified information
2019-10-12 08:44:02 -07:00
f1df6ca828 [Backport/2.8/61442]Update ce_mtu to fix bugs (#62683)
* Update ce_mtu to fix bugs

(cherry picked from commit cb8a3a4c06)

* Update ce_mtu modified information
2019-10-12 08:42:28 -07:00
9a11582612 Bugfix for aggregate function in junos_user module (#62340)
* Update junos_user.py (#60459)

(cherry picked from commit c226c1015e)

* junos_module fixed issue with aggregate mode
2019-10-12 08:41:06 -07:00
0a8221132d [Backport/2.8/61431]Update ce_interface_ospf to fix bugs (#62685)
* Update ce_interface_ospf modified information

* Update ce_interface_ospf to fix bugs

(cherry picked from commit b7e9bb8448)
2019-10-12 08:39:49 -07:00
028496d256 [Backport/2.8/61283]Update ce_info_center_global to fix bugs (#62687)
* Update ce_info_center_global modified information

* Update ce_info_center_global to fix bugs (#61283)

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

(cherry picked from commit 2d85cb3ded)
2019-10-12 08:30:43 -07:00
61a6a47ad4 [Backport/2.8/61168]Update ce_evpn_bgp_rr to fix bugs (#62689)
* Update ce_evpn_bgp_rr modified information

* Update ce_evpn_bgp_rr to fix bugs

(cherry picked from commit 2cb3da3fa6)
2019-10-11 13:00:24 -07:00
d6117dc690 [Backport/2.8/61136]Update ce_evpn_bgp to fix bugs (#62691)
* Update ce_evpn_bgp modified information

* Update ce_evpn_bgp to fix bugs

(cherry picked from commit 05d984b180)
2019-10-11 12:57:21 -07:00
89d6d1ce75 [Backport/2.8/61652]Update ce_netstream_export to fix bugs (#62681)
* Update ce_netstream_export to fix bugs (#61652)

* Update ce_netstream_export to fix bugs

* Update ce_netstream_export to fix bugs

(cherry picked from commit 8233389446)

* Update ce_netstream_export modified information
2019-10-11 12:55:42 -07:00
4eaa8a81a8 [Backport/2.8/61653]Update ce_netstream_aging to fix bugs (#62657)
* Update ce_netstream_aging to fix bugs (#61653)

* Update ce_netstream_aging to fix bugs

* Update ce_netstream_aging to fix bugs

(cherry picked from commit 80fa2a0816)

* Update ce_netstream_aging modified information
2019-10-11 12:45:59 -07:00
bc28c964c9 [Backport/2.8/61654]Update ce_ntp to fix bugs (#62655)
* Update ce_ntp to fix bugs

(cherry picked from commit afea7cc454)

* Update ce_ntp modified information
2019-10-11 12:44:47 -07:00
9a3243a7e7 [Backport/2.8/61683]Update ce_vrf_af to fix bugs (#62653)
* Update ce_vrf_af to fix bugs

(cherry picked from commit 0c65db1a23)

* Update ce_vrf_af modified information
2019-10-11 12:41:13 -07:00
5ae23d712c [Backport/2.8/61013]Update ce_evpn_global to fix bugs (#62693)
* Update ce_evpn_global modified information

* Update ce_evpn_global to fix bugs

(cherry picked from commit 9c6899a92f)
2019-10-11 12:39:24 -07:00
faf37dd939 [Backport/2.8/60937]Update ce_bgp_neighbor_af to fix bugs (#62695)
* Update ce_bgp_neighbor_af modified information

* Update ce_bgp_neighbor_af to fix bugs (#60937)

* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs

(cherry picked from commit a260209098)
2019-10-11 12:37:47 -07:00
32fd34635d [Backport/2.8/60634]Update ce_bgp_neighbor to fix bugs (#62697)
* Update ce_bgp_neighbor modified information

* Update ce_bgp_neighbor to fix bugs

(cherry picked from commit dc5f127086)
2019-10-11 12:35:08 -07:00
2cbd8775ca [stable-2.8] Wrap CLI passwords as AnsibleUnsafeText (#63352)
* isa string should rewrap as unsafe in get_validated_value

* _is_unsafe shouldn't be concerned with underlying types

* Start with passwords as text, instead of bytes

* Remove unused imports

* Add changelog fragment

* Update changelog with CVE
(cherry picked from commit baeff74)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-10-11 09:22:47 -07:00
3c58d5f793 adapt to firewalld 0.7.0 for RHEL 8.1 Beta, Fedora 31+
Fixes #63254

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-11 07:39:17 -07:00
cb0f535a8b Fix for plugins which used the boto libraries leaking the boto credentials to logs 2019-10-10 21:21:05 -07:00
e6a49f2e96 [stable-2.8] Add RHEL 8.1b to the Shippable test matrix.
(cherry picked from commit 811127d64d)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-10-10 09:30:40 -07:00
2ccfc29b7e [2.8] Fix STS assume role error message when role does not exist (#63305)
* Fix STS assume role error message when role does not exist (#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests

* [2.8] Fix STS assume role error message when role does not exist

* fix changelog sanity
2019-10-10 09:29:57 -07:00
ca830ef42d [stable-2.8] cronvar - use correct binary name (#63279)
(cherry picked from commit 9d014778ad)
2019-10-10 09:15:25 -07:00
b64c3c42bd [stable-2.8] cron: add integration tests (#59830)
(cherry picked from commit 3c8abc0b82)
2019-10-10 09:15:25 -07:00
aac216a242 [stable-2.8] Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493

(cherry picked from commit 61647731e2)
2019-10-10 09:15:25 -07:00
3a3c6d0f9a update ce_bgp to fix bugs (#60573)
* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* Update ce_bgp to fix bugs

(cherry picked from commit 5f35916b22)
2019-10-09 21:01:03 -07:00
322ad124ed Update ce_bgp modified information 2019-10-09 21:01:03 -07:00
4b2992c203 docker_container: improve image finding / change detection (#62971)
* Improve image finding / change detection.

* Checked wrong object.

* Improve behavior. (Let docker daemon sort this out.)

* Add changelog.

* Add simple test.

* Fix image name.

* Use new docker_image params.

* Rewrite.

(cherry picked from commit 41eafc2051)
2019-10-09 20:48:44 -07:00
7e3f336160 Fix Bum Traffic Payload keyword (backport 2.8)
The payload was using the incorrect keyword to push the True or False
statement to the device and was getting dropped. This would also result
in erroring out if layer2_unknown_unicase was set to Flood instread of
Proxy.
2019-10-09 20:46:32 -07:00
6d9762aef8 Fix whitespace issue in filter (backport 2.8)
This fixes reported issue #60276
2019-10-09 20:42:18 -07:00
d25b46b3dc dnf - properly handle idempotent removal of wildcard globs (#63034)
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-09 20:27:05 -07:00
ddd9f6081e [2.8] docker_container: fix idempotency for network IP addresses (#62959)
* docker_container: fix idempotency for network IP addresses (#62928)

* Specifying IP addresses needs API version 1.22 or newer.

* Simplify code.

* Use IPAMConfig.IPv*Address instead of IPAddress and GlobalIPv6Address.

* Add changelog.

* Fix syntax errors.

* Add integration test.

* Don't rely on netaddr.

* Normalize IPv6 addresses before comparison.

* Install netaddr, and use it.

(cherry picked from commit 62c0cae29a)

* Remove IPv6 tests, use intermediate state of tests from PR which don't need ipaddr filter.
2019-10-09 20:15:24 -07:00
eeb829ccaa Fix _validate_csr_subject and _validate_csr_signature (#62790)
On python 3, if there is no explicit "return True", the
function call will be seen as "False", thus failling the module

(cherry picked from commit 75c4e9ec05)
2019-10-09 20:05:56 -07:00
1b6d6fe96d ACME modules: make compatible to Buypass ACME v1 CA, and fix bug in ACME v1 account update (#61693)
(cherry picked from commit c6dcf78f53)
2019-10-09 19:56:24 -07:00
1d67e78272 docker_login: fix Python 3 problem in #60381 (#62621)
* Fix Python 3 problem: run_command() returns native strings, not byte strings.

* Add changelog.

(cherry picked from commit 2e5137078d)
2019-10-09 19:41:10 -07:00
5b0a67062a [stable-2.8] Work around ssh-keygen issue in ansible-test. (#63211)
Newer versions of ssh-keygen create PEM keys that are not recognized by Paramiko.

Now ansible-test compensates for this by updating they keys it generates so Paramiko will recognize them..
(cherry picked from commit 022335669c)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-10-09 16:58:16 -07:00
dce682fc3e [stable-2.8] Install zip for unarchive test when using dnf.
(cherry picked from commit 86ae3cfa12)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-10-08 09:16:52 -07:00
08a6e8b95a Fix failed mounts in podman connector and handle errors (#57741)
Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.

(cherry picked from commit 7910361b52)
2019-10-04 08:28:42 -07:00
e80a771f84 Limit Shippable matrix check to ansible repo.
(cherry picked from commit ada02f1966)
2019-10-01 13:57:28 -07:00
68de8e1986 Replace old shippable.py with new check_matrix.py. (#60022)
This new script does not depend on ansible-test and provides much more robust job matrix testing.

It is also run on every job in the matrix now, to detect issues with jobs being re-run after matrix changes are made.

(cherry picked from commit d3da8e4a5b)
2019-10-01 13:57:28 -07:00
27d7a7e048 docker_container: document some of the unexpected behaviors. (#62325) (#62945)
(cherry picked from commit fd627e3b78)
2019-09-30 15:07:31 -04:00
9302ed5bd3 package_facts: improve return value documentation (#62725) (#62890)
* Improve documentation for package_facts.
* Add sample return value.

(cherry picked from commit 1520eba0a7)
2019-09-30 15:00:50 -04:00
bf7cf633a3 Improved docs on docker_swarm_service (#62712) (#62888)
* Improved docs on docker_swarm_service

Co-Authored-By: Piotr Wojciechowski <23406016+WojciechowskiPiotr@users.noreply.github.com>

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit d4064a965b)
2019-09-30 14:56:34 -04:00
5991297474 Fix MSO examples (#62840)
Fix reported issues with the examples.
2019-09-30 14:52:35 -04:00
e8b14e02fe [stable-2.8] cron - Use get_bin_path() to find executable (#62462) (#62546)
* [stable-2.8] cron - Use the default crontab executable in cron and cronvar modules (#59765)

In some remote environments, the `crontab` executable is
overloaded with a custom executable, which typically does
some pre/post processing before forwarding to crontab.

Instead of using the hardcoded `/usr/bin/crontab`, this uses
the `get_bin_path` utility to locate the default crontab executable..
(cherry picked from commit 951a80c8b0)

Co-authored-by: Jean-Frédéric <JeanFred@users.noreply.github.com>

* [stable-2.8] cron - Only run get_bin_path() once (#62554)

(cherry picked from commit b7897e3a8d)
2019-09-20 16:27:10 -07:00
912c493307 Backport/2.8/theme (#62611)
* cherrypick #58832
* fix width (#61619)

(cherry picked from commit 1d40d2b572)

* Minify theme (#61734)

* moved most ansible edits out of theme.css
* remove unnecessary edit to theme.css
* replace with upstream minified theme.css for 0.4.3

(cherry picked from commit de826b437d)

* Minify ansible (#61792)

* make all comments special to survive minify
* minified css

(cherry picked from commit 7efaad711e)
2019-09-19 13:29:53 -05:00
4fc2674536 psexec - Fix kerb and interactive support (#62556)
(cherry picked from commit 064e443ea5)
2019-09-19 10:54:24 -07:00
63020a8be2 [Backport/2.8/62498]update ce_static_route to fix bugs (#62591)
* update ce_static_route to fix bugs

(cherry picked from commit 9a458d658f)

* Update ce_static_route modified information
2019-09-19 10:54:03 -07:00
60c35442a0 [Backport/2.8/61684]Update ce_ospf to fix bugs (#62595)
* Update ce_ospf to fix bugs

(cherry picked from commit 1583c5ead2)

* Update ce_ospf modified information
2019-09-19 10:53:46 -07:00
b587b5a3ee [2.8] VMware: Add support for storagePod
* Added find_resource_pool_by_cluster API

Fixes: #61645

(cherry picked from commit de66abe521)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-19 10:52:45 -07:00
d9b62e6e85 Add hint for config option priority (#62463)
* Add hint for config option priority

* Fix some spelling issues

(cherry picked from commit bf5b6695ec)
2019-09-19 10:27:37 -07:00
950959ebc5 win_exec_wrapper - Be more defensive when trying to get output errors (#62376)
* win_exec_wrapper - Be more defensive when trying to get output errors

* Fix up property search

(cherry picked from commit bad338aca6)
2019-09-19 10:27:03 -07:00
4cbaaa4f06 Add link to become plugins in become docs (#62462)
(cherry picked from commit d16ee65ecd)
2019-09-19 10:26:39 -07:00
fd2d0c254e [Backport/2.8/61774]Update ce_stp to fix bugs (#62511)
* Update ce_stp to fix bugs

(cherry picked from commit c62a0b35c7)

* Update ce_stp modified information
2019-09-18 09:41:48 -07:00
4dc467f8f3 [Backport/2.8/61842]Update ce_snmp_target_host to fix bugs (#62508)
* Update ce_snmp_target_host to fix bugs

(cherry picked from commit 76016f9988)

* update ce_snmp_target_host to fix bugs
2019-09-18 09:41:39 -07:00
605ba86da7 [Backport/2.8/61843]Update ce_snmp_traps to fix bugs (#62506)
* Update ce_snmp_traps to fix bugs

(cherry picked from commit fd11b82272)

* update ce_snmp_traps to fix bugs
2019-09-18 09:41:23 -07:00
4052c790cd [Backport/2.8/61995]update ce_vxlan_arp to fix bugs (#62504)
* Update ce_vxlan_arp to fix bugs (#61995)

* Update ce_vxlan_arp to fix bugs

* Update ce_vxlan_arp to fix bugs

(cherry picked from commit 12512f7319)

* update ce_vxlan_arp to fix bugs
2019-09-18 09:41:12 -07:00
9f2e500c5b update ce_vxlan_vap to fix bugs 2019-09-18 09:40:53 -07:00
bde55031c5 Update ce_vxlan_vap to fix bugs
(cherry picked from commit 2db73601ba)
2019-09-18 09:40:53 -07:00
44f88ca49b [stable-2.8] Remove leading space in warning messages (#62002)
ci_complete
(cherry picked from commit ea6e96985a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-09-18 09:38:35 -07:00
6dd2cb0262 Backport of 62320: fix typos in network modules 2019-09-17 18:16:01 -07:00
f43110b0ed [stable-2.8] Mark ansible-test cloud credentials as sensitive..
(cherry picked from commit 9f7b124a6f)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-09-17 18:10:39 -07:00
d8bd6ea72f [stable-2.8] test: disable hcloud_floating_ip_info
Temporarily disable `hcloud_floating_ip_info`, this until #62414 is
resolved..
(cherry picked from commit edf15b346f)

Co-authored-by: Gonéri Le Bouder <goneri@lebouder.net>
2019-09-17 17:05:04 -07:00
0f7ed58718 Re-enable some docker_swarm tests. (#61875)
(cherry picked from commit 098a13dff4)
2019-09-17 14:00:14 -07:00
98fc6a627c [stable-2.8] Don't treat no checksum as a checksum match (#62146)
Fixes #61978
* moar tests for get_url fetch behavior with existing file
* add changelog fragment
(cherry picked from commit 7d51cac)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-09-17 13:59:56 -07:00
8d05f468f3 rabbitmq_publish fix for incorrectly stating message was not published to the queue (#61960)
* Pika v1.0.0 and above were causing issues for publish_message.  Updated
to ensure publish_message works with pika 0.13.1 and 1.0.0 and above.

* Adding changelog fragment for rabbitmq_publish fix.

* Updating return value.

(cherry picked from commit 1b2fd2cb5f)
2019-09-17 13:58:32 -07:00
7693b2945a lookup_rabbitmq pika > 1.0.0 is_closing bug fix (#61959)
* In pika v1.0.0 BlockingChannel.is_closing was removed.  Updating
plugin accordingly.

Ref: https://github.com/pika/pika/pull/1034

* Adding change fragment for is_closing bug.

* Updated change fragment description.

(cherry picked from commit 9b149917a6)
2019-09-17 13:57:42 -07:00
a0c0e64518 Fix fetching existing AS (#58756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 709fbcf804)

Add changelog for eos_bgp fix
2019-09-17 13:48:08 -07:00
78771b4eb2 Set no_log to True for junos_user encrypted_password (#62184)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 4e6270750a)

Add changelog for junos_user fix
2019-09-17 13:42:52 -07:00
08bff987d9 [stable-2.8] Split unit tests into two groups (#61528) (#62070)
* [stable-2.8] Fix ansible-test coverage path handling. (#61528)

* Fix ansible-test coverage path handling.
* Split CI unit tests into two groups..
(cherry picked from commit e4e5005640)

Co-authored-by: Matt Clay <matt@mystile.com>

* Increase unit test timeout to account for long image download times (#61717)

(cherry picked from commit c9e7a2122d)
2019-09-17 13:42:20 -07:00
c01378a299 [stable-2.8] Mark AWS credentials in ansible-test as sensitive.
This avoids displaying the credentials in CI when retrying tests at maximum verbosity.
(cherry picked from commit b73e772)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-09-17 13:31:43 -07:00
c284e40866 [stable-2.8] Redact sensitive values by default in ansible-test.
(cherry picked from commit 0631e057e9)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-09-17 13:18:38 -07:00
5c1c91c3d2 Backport of 62333: fix typos in storage modules (#62384) 2019-09-17 11:10:03 -05:00
09db81e942 explicited RouterOS does not support connection: local (#62230)
(cherry picked from commit b8aa87bd06)
2019-09-16 11:04:02 -05:00
2d967c3537 Backport of 62135: fix typos in modules (#62170) 2019-09-16 10:41:37 -05:00
97eba0fc60 Backport of 62125: Fix typos in database modules and their integration tests (#62173) 2019-09-16 10:37:13 -05:00
7974950f90 fix typos in web_infrastructure modules (#62257) 2019-09-16 10:33:09 -05:00
c2c096e4f2 Backport of 62201: fix typos in net_tools_modules (#62263) 2019-09-16 10:31:48 -05:00
2a484a649f Backport of 62200: fix typos in identity modules (#62267) 2019-09-16 10:29:58 -05:00
923fc2e247 fix typos in commands modules (#62197) (#62270)
(cherry picked from commit 6691527799)
2019-09-16 10:28:33 -05:00
8c72fd0bb7 Backport of 62196: fix typos in clustering modules (#62272) 2019-09-16 10:26:45 -05:00
d11fc4d09c Backport of 62336: fix typos in remote_management modules (#62341) 2019-09-16 10:20:08 -05:00
01ca3aa8b5 revert back to contiguous (#62301) (#62306)
(cherry picked from commit f6a51b3f07)
2019-09-13 16:12:41 -05:00
255754a4d1 Backport of 62194: fix typos in cloud modules (#62277) 2019-09-13 14:11:48 -05:00
f2be4f688d Improve documentation on doc fragments (#62219) (#62292)
Add information and examples on how to use additional properties from a doc fragment
Add info about layering properties

(cherry picked from commit 9b348e690c)
(cherry picked from commit 5deb01c84d)
(cherry picked from commit 041c52d629)
2019-09-13 13:40:49 -05:00
770e10ca60 win_template - use shared doc fragment for shared options (#59701) (#59828)
* win_template - use shared doc fragment for shared options (#59701)

* win_template - use shared doc fragment for shared options

* Change smart quote to em dash and fix whitespace issue

(cherry picked from commit 652bfc7e19)

* template - move backup to its own doc (#59893)

* template - move backup to its own doc

* Use the backup doc fragment for template

(cherry picked from commit 737a500a30)
2019-09-12 18:58:02 -07:00
b4a78e5658 Update Ansible release version to v2.8.5.post0. 2019-09-12 17:27:15 -07:00
eb1995d41d New release v2.8.5 2019-09-12 12:54:03 -07:00
659147b2e2 VMware: not ssl.SSLContext if validate_certs false (#57185)
Python < 2.7.9 does not have the ssl.SSLContext attribute.
ssl.SSLContext is only required when we want to validate the SSL
connection. If `validate_certs` is false, we don't initialize the
`ssl_context` variable.

Add unit-test coverage and a little refactoring:

- avoid the use of `mocker`, when we can push `monkeypatch` which is
  `pytest`'s default.
- use `mock.Mocker()` when possible

closes: #57072
(cherry picked from commit 3ea8e0a144)
2019-09-09 13:26:23 -07:00
3dec34c118 fix erroneous failures in docker_compose due to deprecation warnings … (#61650)
* fix erroneous failures in docker_compose due to deprecation warnings from docker (#60961)

* Update error handling to work with new method of capturing output

Co-Authored-By: Felix Fontein <felix@fontein.de>

* update error handling

* fix syntax error

* fix indentation

* fix indentation (again)

* remove erroneous line

(cherry picked from commit 0c73e47a42)
2019-09-09 13:22:18 -07:00
211fc3e0ab docker_container: improve port range parsing error behavior (#61740)
* Improve port range parsing.

* Add changelog.

(cherry picked from commit d40ba28fb4)
2019-09-09 13:19:39 -07:00
c0ba6a9ed3 XenServer: When VM is in powered on state, plug newly added disks
Fixes: #60693
(cherry picked from commit 04e0f9d4ea)
2019-09-09 13:18:40 -07:00
b844671747 Fix bug #61924 with API version check 2019-09-09 13:16:30 -07:00
adb742deff [stable-2.8] User - correct group removal description in docs (#61936)
(cherry picked from commit 61efffcbe1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-09-06 13:40:56 -07:00
b9769abde7 [stable-2.8] test: disable the docker swarm tests (#61816) (#61862)
`docker_swarm` tests tend to hang during the creation of the Swarn
cluster.

See: https://github.com/ansible/ansible/issues/61815
(cherry picked from commit 7132466327)

Co-authored-by: Gonéri Le Bouder <goneri@lebouder.net>
2019-09-05 09:01:34 -07:00
70798b84d2 documentation: modify the link to the docker.txt listing all images (#61838) (#61847)
The file was moved.

(cherry picked from commit aadb192846)
2019-09-05 10:07:39 -05:00
446df8d2cb [stable-2.8] Use new version of default test image that contains Python 3.8.0b3 (#60139)
(cherry picked from commit a20848bf66)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-09-04 18:01:21 -07:00
1b8c1c364d Add changelog fragment 2019-09-04 15:22:41 -07:00
e7fcb37e6c Fix extended loop_control with includes (#61231)
* Fix extended loop_control with includes

* Use assert for testing extended loop_control

* fix typo

(cherry picked from commit a213b9160c)
2019-09-04 15:22:41 -07:00
59280a933e [stable-2.8] apt_facts - Fix cache related performance regression (#60511)
* apt_facts - Fix cache related performance regression

* Another minor performance improvement
(cherry picked from commit 0f35e4b7b9)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-09-04 13:38:35 -07:00
05d084b366 s3 - improve waiting for the bucket (#61802)
(cherry picked from commit ff05991265)
2019-09-04 12:42:07 -07:00
e93b8f054e [stable-2.8] aws_s3 - wait for the bucket before setting ACLs (#61735)
* Wait for the bucket to become available if possible before setting ACLs
(cherry picked from commit 91ccb03552)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
2019-09-04 12:42:07 -07:00
99f9eab19d fixes assert statements in tests (#59998)
(cherry picked from commit d00aaf66d7)
2019-09-04 12:21:23 -07:00
c087030e5c [stable-2.8] Allow 13 asterisk characters in password field without warning (#54893)
On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

> [WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone..
(cherry picked from commit 1dea661ce8)

Co-authored-by: kucharskim <mikolaj@kucharski.name>
2019-09-04 12:20:28 -07:00
48e22639ee Fix creation of DigitalOcean droplets using digital_ocean_droplet module (#61655)
* Omit disallowed 'id' attribute in request body to create a droplet

* Add changelog fragment for PR #61655
2019-09-04 12:19:39 -07:00
aec6dc3b26 systemd module will now wait on deactivating state (#59471) (#60939)
* systemd module will now wait on deactivating state (#59471)

If a service is in the 'deactivating' state running systemctl stop foo,
would wait for the foo service to actually stop before it exits. The
module didn't behave like that and it considered the deactivating state
as if the service wasn't running. This change will align the module with
the systemctl behaviour.

(cherry picked from commit 54d9d7805d)

* Fix systemd start state with deactivating service state

(cherry picked from commit ee4b3b8854)
2019-09-04 12:18:43 -07:00
0af0a7f8bb Add exception handling to win_domain_controller (#58234)
* Add exception handling to win_domain_controller

* Add changelog

* Fix PSUseDeclaredVarsMoreThanAssignments

* Remove dns domain cannot be resolved error message

As requested by PR review in https://github.com/ansible/ansible/pull/58234#discussion_r300509880
2019-09-04 12:14:34 -07:00
7c752a43b3 Set win_pagefile as unstable as thats what it is (#61732)
(cherry picked from commit 00add5b668)
2019-09-04 12:13:42 -07:00
6310e96034 [stable-2.8] - meraki_syslog - Properly handle net_id (#61744)
* meraki_syslog - Module properly handles net_id parameter (#57286)

(cherry picked from commit a50b3d7695)

* Add changelog fragment and clean up commented tests
2019-09-03 21:58:00 -07:00
db5539dce3 Update host parameter notes to include China. (#60967)
(cherry picked from commit 48a04fade4)
2019-09-03 21:57:32 -07:00
e1922be671 postgresql: Run all tests under postgres_* (#61676)
* Make sure postgresql tests are run for all postgres_* modules (#61647)

(cherry picked from commit 4d057e0331)

* Make sure postgresql tests are run for all postgres_* modules (#61647), remove non-existent
2019-09-03 21:39:49 -07:00
bc0ea200d2 Update ce_bfd_global to fix bugs (#60477)
* Update ce_bfd_global to fix bugs

(cherry picked from commit c742ce8ee3)

* Update ce_bfd_global modified information
2019-09-03 21:38:25 -07:00
d71d111c3a Fix nxos_install_os test cases typo (#58825)
This should be ansible_connection, not connection_type. We can also
update local testing logic.

Remove nxos_install_os/tasks/network_local.yaml as it is nolonger used.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 9e1b19e364)
2019-09-03 21:37:39 -07:00
cc1bc400dd [stable-2.8] Fix pipelining in buildah connection plugin 2019-09-03 21:35:27 -07:00
ccd0b5bede acme_certificate: make compatible to Buypass' ACME v2 testing endpoint (#60727)
* Don't unnecessarily use location from header.

* Add changelog.

(cherry picked from commit 7f4f2506a0)
2019-09-03 21:34:21 -07:00
9218856617 Search project in domain when it's defined
Since there might be several projects with the same name in different
domains, it's required to define domain_id during project search.
Otherwise openstacksdk will raise "Multiple matches found" error

(cherry picked from commit 33ab7ca162)
2019-09-03 21:32:18 -07:00
6468dcc4be Ovirt template search by datacenter backport (#60478)
* add changelog

* ovirt_vm update template search backport
2019-09-03 21:29:57 -07:00
c2f6576fbe proxmox_kvm: While a VM is beeing created, vm has no name item (#58196)
* While a VM is beeing created, vm as no name attribute

* Add changelogs fragment

(cherry picked from commit 8923d13537)
2019-09-03 12:58:54 -07:00
a0ebf60dea ovirt_vm add linux boot param warning backport (#60581)
* ovirt_vm add linux boot param warning (#60474)

* ovirt_vm add kernel param check

* update check

* update docs phrase

* use douple quotes

* add changelog
2019-09-03 12:44:53 -07:00
1ff1e2d9a6 ovirt vm update kernel docs backport (#60582)
* ovirt vm update kernel docs (#60407)

* ovirt vm update kernel docs

* update doc phrase

* update docs

* add changelog
2019-09-03 12:43:56 -07:00
b66433f47d docker_logout: report change on successful logout (#60381)
* Mark logout as changed when docker logout does not return 'Not logged in to '.

* Add changelog.

* Improve logout detection.

* Also return output of 'docker logout'.

(cherry picked from commit 99fb0fcb2f)
2019-09-03 12:43:12 -07:00
9fe0971004 Backport/2.8/57418 (#60683)
* Backport to stable-2.8: Fix #56640: Map k8s ansible keys to api keys (#57418)

* Fix #56643: Map ansible keys to api keys

* Remove errant print line

* Fix pep8 issue

* Fix doc line

* Added test for validate_certs -> verify_ssl translation for k8s module

(cherry picked from commit 6e94b472e8)

* Removed proxy from AUTH_ARG_MAP and added fragment for backport

* Rename backport-57418.yaml to 60683-backport-57418.yaml

* Update 60683-backport-57418.yaml
2019-09-03 12:42:15 -07:00
db9cb0682d fix: docker_swarm_service does not publish both tcp and udp ports (#60616)
* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value

(cherry picked from commit 064cd63f3d)
2019-09-03 12:40:54 -07:00
06623fb79a openssl_certificate: fix idempotency (#60745)
* Fix openssl_certificate idempotency.

* Add changelog.

* Add integration test.

(cherry picked from commit 0d88ec241f)
2019-09-03 11:49:53 -07:00
d70b4f6665 Correct indentation of the code in the example (#61622) (#61727) 2019-09-03 13:47:45 -05:00
ec50e1191f Backport: win_domain reboot required exception incorrectly reported (#60496) (#60809)
* win_domain reboot required exception incorrectly reported (#60496)

* Set reboot required dependent on exception message.

* Use exception id instead of it's message

* Add changelog fragment
2019-09-03 11:17:28 -07:00
b77abd0491 Warn when transforming constructed groups (#60912)
* Warn when transforming constructed groups

The `keyed_groups` field has used sanitization since 2.6, but `groups` only started doing so in 2.8.
This adds a warning for the change in behavior.

* changelog

(cherry picked from commit 3247626ac7)
2019-09-03 11:15:23 -07:00
0bc1285987 [stable-2.8] fixes issue with recieve parameter idempotency (#59999) (#60541)
* [stable-2.8] fixes issue with recieve parameter idempotency (#59999)

fixes assert statements in unit tests
(cherry picked from commit c9a9621a02)

Co-authored-by: Wojciech Wypior <w.wypior@f5.com>

* Add changelog
2019-09-03 10:44:21 -07:00
e352e7223e Update Fedora 29 test image
(cherry picked from commit 3d78dad84b)
2019-09-03 09:55:04 -07:00
1e9eebdc93 Backport of 61538: postgresql modules: explicit defaults for bool params (#61677) 2019-09-03 11:38:50 -05:00
db9744d29e [stable-2.8] Add porting guide entry for gathering facts tag change (#61180) (#61555)
* Add porting guide entry for gathering facts tag change

(cherry picked from commit 0175620)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-09-03 11:36:58 -05:00
813b32856a Fix typo in postgresql_privs.py (#61365) (#61427)
Change 'default_prives' to 'default_privs'

(cherry picked from commit 0074fa5672)
2019-08-28 10:53:45 -05:00
6fc1f3ab1c Add changelog fragment for backporting PR #57096 to stable-2.8 branch 2019-08-27 14:04:10 -07:00
3cbe15aae9 Add thin-volumes to the netapp_e_lun_mapping update_mapping_info method. 2019-08-27 14:04:10 -07:00
71ec1d0b17 Fix netapp_e_host module bug when lun=0 2019-08-27 14:04:10 -07:00
74717f1ac2 Fix hosts with same lun number conflict in netapp_e_lun_mapping.
This patch fixes an issue of when multiple hosts are created and then
subsequently volume(s) are mapped to them using the same specified number.
2019-08-27 14:04:10 -07:00
a389e9e4bf docker_image_info: improve docs (#60622) (#60885)
* Improve return value documentation and example, fix typo in lib/ansible/modules/cloud/docker/docker_image_info.py

(cherry picked from commit 7a9e865a23)
2019-08-22 09:39:59 -05:00
6af9aef659 Bugfix of issue 60707: add python-apt package to requirements of package_facts module (#60999) (#61101)
* Issue 60707: add python-apt package to requirements of package_facts module, fix formatting, change fail msg

(cherry picked from commit cf291f272d)
2019-08-22 09:38:29 -05:00
826523559d Fix mispelling in postgresql_query docs (#60648) (#60670)
Changed `arbitraty` to `arbitrary` in postgresql_query docs
(cherry picked from commit 06d1705752)
2019-08-16 09:32:22 -05:00
e99b08a0ad Update Ansible release version to v2.8.4.post0. 2019-08-15 19:56:25 -07:00
c4902421d9 New release v2.8.4 2019-08-15 14:07:35 -07:00
49935b1e95 [stable-2.8] Fix sanity tests based on newer version of shellcheck (#60423) (#60442)
* [stable-2.8] Fix sanity tests based on newer version of shellcheck (#60423)

- change egrep to grep -E
- store exit codes and check them directly
- ignore SC1091.
(cherry picked from commit c485a1b91e)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Fix sanity test
2019-08-13 10:31:03 -07:00
768e515a3e Ovirt host update force docs backport (#60475)
* add changelog

* Ovirt host update force docs (#60202)

* update docs

* update pep8 syntax

* update pep8 syntax
2019-08-13 10:29:41 -07:00
beb108e887 Update ce_acl_advance modified information 2019-08-12 18:38:01 -07:00
51a849c89f vmware_datastore_facts: don't modify dict in iter
With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes #54869

(cherry picked from commit 339a0f4a8c)
2019-08-12 18:33:22 -07:00
d112106985 Move windows test to another group (#60391)
(cherry picked from commit 35b87b8633)
2019-08-12 18:29:29 -07:00
282ab4cb72 openssh_keypair - Add public key and key comment validation (#57993)
- Split the key validation to separate private and public.
- In case public key does not exist, recreate it.
- Validate comment of the key.
- In case comment changed, update the private and public keys.

(cherry picked from commit 27e414200f)
2019-08-12 18:29:03 -07:00
4bac987591 Backport/2.8/58943 - win_domain_group_membership extar_vars forests env fix 2019-08-12 18:26:26 -07:00
d350269da1 update ce_acl to fix bugs (#60357)
* update ce_acl to fix bugs (#60274)

(cherry picked from commit 66c3e9bb9b)

* Update ce_acl modified information
2019-08-12 18:23:52 -07:00
34d3a80fb5 update ce_aaa_server_host to fix bugs (#60356)
* update ce_aaa_server_host to fix bugs (#60272)

(cherry picked from commit 9aabe70452)

* Update ce_aaa_server_host modified information
2019-08-12 18:23:23 -07:00
f4aaf4d148 update ce_aaa_server to fix bugs (#60355)
* update ce_aaa_server to fix bugs (#60270)

* update ce_aaa_server to fix bugs

* update ce_aaa_server to fix bugs

(cherry picked from commit c2e7683926)

* Update ce_aaa_server modified information
2019-08-12 18:22:02 -07:00
b51fdab9ea [stable-2.8] Fix unit tests to work with pytest >= 5.0 (#60246) (#60332)
pytest made a change in the way the message from ExceptionInfo objects was returned.

https://docs.pytest.org/en/latest/changelog.html#pytest-5-0-0-2019-06-28.
(cherry picked from commit 2d266fbc87)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-08-12 18:12:28 -07:00
5f15cc409e Improve docker_compose module documentation (#60064) (#60347)
* Improve docker_compose module documentation
* Mentions of files (docker-compose.yml) are now rendered correctly.
* Compose files are now called just that.
* Further clarify options "services", "stopped" and "restarted"
* Update lib/ansible/modules/cloud/docker/docker_compose.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit e9fc095123)
2019-08-12 10:48:02 -05:00
9bfdb0aec5 fix spelling: certifivate -> certificate (#60369) (#60373)
docs spelling fix

(cherry picked from commit a3d55a5ddb)
2019-08-12 10:45:58 -05:00
490f17c7f9 Improve performane of UnsafeProxy __new__
This adds an early return to the __new__ method of the UnsafeProxy object
which avoids creating the unsafe object if the incoming object is already
unsafe.

(cherry picked from commit c1e23c22a9)
2019-08-09 14:46:14 -07:00
a6eec912c7 [stable-2.8] Pin openshift <=0.9.0 to prevent test failures (#60245)
(cherry picked from commit 9cb47832d1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-08-09 14:40:41 -07:00
fa0cd3782f [stable-2.8] Move assertion in unit test inside loop (#60232)
(cherry picked from commit aa717661af)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-08-09 14:40:07 -07:00
5d3f0fe02c facts: fix double-counting of CPUs on POWER systems (#58360)
On POWER systems, /proc/cpuinfo provides a 'processor' entry as a
counter, and a 'cpu' entry with a description (similar to 'model name'
on x86). Support for POWER in get_cpu_facts was added via the 'cpu'
entry in commit 8746e692c1.  Subsequent
support for ARM64 in commit ce4ada93f9
used the 'processor' entry, resulting in double-counting of cores on
POWER systems.

When unit tests were later written for this code in
commit 55306906cf, the erroneous values
were just accepted in the test instead of being diagnosed.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
(cherry picked from commit 93d9d64038)
2019-08-09 14:20:32 -07:00
8e56708e22 prevent recursive logging csharp stackoverflow. (#59503)
* prevent recursive logging situation.

* Add changelog

(cherry picked from commit 6a5cd9a820)
2019-08-09 14:12:22 -07:00
a0afc2d656 Move win target back a group (#60257)
(cherry picked from commit 534a40c5cd)
2019-08-09 14:11:24 -07:00
bc06946581 Added group 7 to Windows groups - ci_complete (#60240)
(cherry picked from commit 81cb6f366a)
2019-08-09 14:11:24 -07:00
c2abfd8c4d Remove Python 2.6 from Windows tests (#60235)
(cherry picked from commit 3a3727d200)
2019-08-09 14:10:35 -07:00
1eb11edb14 Removed breaking type check from nagios module (#49568)
* Removed extraneous type check from nagios module, in order to allow python 3.x

* Removed now useless import types

* Added changelog fragment

* Update changelog.

* Rebased and removed check due to module adding earlier guardrails

* Updated changelog to mention earlier fix adding now completely removed guardrails

* Remove superfluous type checks. Fix docs type.

* Update ignore.txt.

(cherry picked from commit 5d8302120b)
2019-08-09 14:09:53 -07:00
08e23a2a93 Don't truncate cidr_ipv6 addresses in ec2_group.py (#59106)
* Better cidr_ipv6 validation in ec2_group.py

* Improve warning/error handling, add changelog

* Update unit test for ipv6 validation

* Fix logic that was causing non /128 cidrs with host bits to not be handled

(cherry picked from commit 4308b87d72)
2019-08-09 14:02:42 -07:00
b4b76c924c Ovirt vnic profile fix backport (#60198)
* update vnic profile docs

* vnic profile fix

* merge updates

* add changelog
2019-08-09 14:00:52 -07:00
0bcfb05bad Fix changelog entry for playbook_dir fix
The final version of the fix makes the addition in two places instead of
moving the single addition from one place to another

(cherry picked from commit 84e3c0ef1d)
2019-08-09 13:51:14 -07:00
f44eb33000 [stable-2.8] Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI (#59557)
* Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI. Fixes #59548

* Restore cli additions
(cherry picked from commit 923e218)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-08-09 13:51:14 -07:00
3b987ae53d Add CVE number to changelog 2019-08-09 13:50:35 -07:00
5004e9adcd too many docs changes 2019-08-09 13:50:35 -07:00
b0e2d90dcf cherrypick 2019-08-09 13:50:35 -07:00
2d14c0ce70 no logging for service account contents (#60149)
* no logging for service account contents

* changelog

* fixes
2019-08-09 13:50:35 -07:00
a02c5c4683 win_user - use proper error code when failing to validate creds (#60181)
(cherry picked from commit 45d0e5994a)
2019-08-09 13:24:07 -07:00
d497d5865b Backport/2.8/60075 ce_rollback: set mmi-mode enable to run commands and unset after running. (#60075) (#60084)
* set mmi-mode enable to run commands nad unset after running. (#60075)


(cherry picked from commit 16e237e095)

* add a changelog fragment.
2019-08-09 11:44:52 -07:00
56639d0f68 TRANSFORM_INVALID_GROUP_CHARS: document "ignore" option (#57318) (#60289)
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit c954c07271)
2019-08-09 10:59:09 -05:00
4e94423e41 Backport/2.8/60071 ce_config : It is necessary to undo mmi-mode enable after running commands. (#60071) (#60085)
* It is necessary to undo mmi-mode enable after running commands. (#60071)


(cherry picked from commit 13c8f7b00c)

* add a changelog fragment.
2019-08-07 21:57:55 -07:00
81a5183428 Backport/2.8/60105: turn off the default db warning where it doesn't make sense (#60107)
* Bugfix 60043: turn off the default db warning where it doesn't make sense (#60105)

(cherry picked from commit d2cc9f5f06)

* Backport of 60105: turn off the default db warning where it doesn't make sense
2019-08-07 13:58:37 -07:00
4f763037b0 [stable-2.8] Fix hcloud tests
(cherry picked from commit 6c1a255d98)

Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
2019-08-07 13:50:31 -07:00
2a862ee82e fix misleading example in docker_image doc (#60207) (#60231)
Using docker_image to tag an image as "latest" only updates an existing
tag when used with "force_tag: yes" option. As "latest" is present in
most cases, the option is added to the example to prevent unexpected
behaviour.

(cherry picked from commit 5a6003d0ed)
2019-08-07 15:43:48 -05:00
978dd9f541 [stable-2.8] Fix async output with adhoc callbacks. Fixes #15988 (#59935)
(cherry picked from commit df6b8d2)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-08-07 13:17:40 -07:00
215aa73843 update ce_bgp_af to fix bugs (#60032)
* update ce_bgp_af to fix bugs (#59678)

* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs

* update ce_vrrp to fix bugs

* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs

(cherry picked from commit d6fd4eb8e6)

* Update ce_bgp_af modified information

* Update ce_bgp_af modified information
2019-08-07 13:16:03 -07:00
f75fbf94f8 update ce_vrrp to fix bugs (#60034)
* update ce_vrrp to resolve conflicts

* Update ce_vrrp modified information

* Update ce_vrrp modified information
2019-08-07 12:23:17 -07:00
777395ec18 Backport/2.8/59690 ce_netstream_template: update to fix a bug. (#59690) (#60033)
* ce_netstream_template: update to fix a bug. (#59690)

* update to fix a bug.

* Update ce_netstream_template.py

* Update ce_netstream_template.py

* Update ce_netstream_template.py

(cherry picked from commit adfbd04b3a)

* add  a changelog fragment.
2019-08-07 12:16:32 -07:00
adc494a9e1 [stable-2.8] Change dummy package name in yum/dnf tests to not collide with an actual package (#60225)
When targeting 'foo*' in tests, it pulled in packages other than the dummy packages in our testing repo that have many dependencies, some of which were causing tests to fail.

Also change 'bar' package name to avoid the same issue in the future.
(cherry picked from commit 47796af64f)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-08-07 12:13:11 -07:00
feb39dc35a docker_container: fix port bindings with IPv6 addresses (#59715)
* Pass IPv6 addresses for port bindings without square brackets.

* Add changelog.

* Add test.

(cherry picked from commit a7573102bc)
2019-08-07 12:10:49 -07:00
22ab4683df Only error out if the gid exists with a different group name (#59769)
Only error out if the gid exists with a different group name as
otherwise it will error out if the group with this gid already
exists, like on a rerun of the playbook. This fixes a regression
introduced by 4898b0a4a298448677c2aee2a03157ba5b662759.(cherry picked from commit f94772f807)
2019-08-07 11:59:25 -07:00
a55d6c37ec [stable-2.8] Handle new output for podman image build (#59807)
(cherry picked from commit 372f21e3b5)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-08-07 11:49:27 -07:00
24a4b1d9e7 Move ome_* and idrac_* modules one level up (#59698)
* Move ome_* and idrac_* modules one level up.

* Fix paths.

* Fix package name.

* Oranize in different directories.

* Update BOTMETA.

* Update new ignore entries.

* Revert "Update BOTMETA."
Revert "Oranize in different directories."
Adjust ignores.txt.

(cherry picked from commit 6d074d8a94)
2019-08-07 11:48:48 -07:00
a307a6a89a os_subnet: allow using non-default subnet pool (#52608)
(cherry picked from commit 17f2b5f73e)
2019-08-07 11:47:44 -07:00
04ca93a5c0 Rebalance Windows CI groups based on recent delays to 2016 (#59838)
* Change to test out server 2016 CI issues

* ci_complete

(cherry picked from commit 349b2bdf43)
2019-08-07 09:05:29 -07:00
678b9c1b3c Use correct extension on changelog fragment 2019-08-07 07:41:06 -07:00
7edc4be583 backport aws_s3: Improve ETag handling (#46332) 2019-08-07 07:41:06 -07:00
38a7dfca26 aws_s3: Improve ETag handling (#46332)
* cosmetic: Remove useless call to ec2_argument_spec()

* aws_s3: Improve ETag handling

* Extract ETag calculation into a utility function for reuse by
  aws_s3_sync.
* Reduce code duplication in put/get by restructuring the logic
* Only calculate ETag when overwrite == different
* Fail gracefully when overwrite == different and MD5 isn't available
  (e.g. due to FIPS-140-2).

* aws_s3: clean up integration tests

Clean up tests, add tests for overwrite settings in both directions.

(cherry picked from commit c513c1e2d3)
2019-08-07 07:41:06 -07:00
d39488ece4 prevent templating of passwords from prompt (#59246)
* prevent templating of passwords from prompt

  fixes CVE-2019-10206

(cherry picked from commit e9a37f8e31)
2019-08-07 07:11:01 -07:00
b2c43bd2b7 [stable-2.8] Wait for Ansible Tower instance to be ready
(cherry picked from commit ea209e1c2f)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-08-02 13:58:26 -07:00
67fe363297 Fix strat inv (#58982)
* Fix strategy functions that update inventory

* added tests


(cherry picked from commit a7b14ec1be)
2019-08-02 09:40:28 -07:00
3fbf1163a3 removed module from support list (#59878)
(cherry picked from commit eb15ee91df)
2019-08-01 07:47:04 -07:00
79795ba5b0 [stable-2.8] Update version in metadata for bundled distro (#59869)
(cherry picked from commit 81d254da4c)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-31 10:37:39 -07:00
fd7b4238e2 [stable-2.8] Update constraints for coverage on Python 3.8 (#59733)
This fixes the unit tests hanging when run with Python 3.8 with coverage enabled
(cherry picked from commit ed4a729fd6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-31 10:36:34 -07:00
e2df33563c backport fix qos update ovirt_vnic_profile (#59862)
Update ovirt_vnic_profile.py (#56518)

qos is not defined when port_mirroring is enabled, a NoneType is returned for entity.qos in this case
getattr is safer to use than using a direct call to entity.qos.name
2019-07-31 10:32:03 -07:00
703618336f [stable-2.8] Don't warn if local user is found in user database (#56838)
If the 'local' parameter of the 'user' Ansible module is enabled, and
the user has been found in the local user database, don't emit
a warning, because this is an expected outcome.

Add changelog and integration tests

Co-authored-by: drybed <drybjed@gmail.com>
(cherry picked from commit 75be309242)

Co-authored-by: Maciej Delmanowski <drybjed@drybjed.net>
2019-07-31 10:30:46 -07:00
e5759e587a Update docs for pesize. (#59751)
(cherry picked from commit 1534d6aea3)
2019-07-31 10:29:33 -07:00
b6192a5ce8 Added changelog fragment for backport pr relating to pbrun become plugin default become_user. 2019-07-31 08:31:43 -07:00
7648619a3f pbrun: Use default value for become_user (#59754)
* Update pbrun.py

Require ternary operator for if get_option('user') returns NoneType object.

* Update pbrun.py

Added default value to become_user in documentation.

* Update pbrun.py

Changed default for become_user to be '' instead of root.

(cherry picked from commit 1d560e5ce9)
2019-07-31 08:31:43 -07:00
d6e7011d14 [stable-2.8] Order data in xml integration test (#59742)
A recent update to lxml for Python >= 3.6 now preserves key order. Change the test input so the input is sorted, making tests pass on previous versions of lxml as well as the latest version.
(cherry picked from commit 19299f3310)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-30 21:17:22 -07:00
aabc0aff57 win_dsc - be more lenient with datetime parsing (#59703)
* win_dsc - be more lenient with datetime parsing

* Remove l that shouldn't be there

(cherry picked from commit 04ec47bdf1)
2019-07-30 17:33:58 -07:00
8af9c9ccc9 Add pipelining to podman connection plugin 2019-07-30 17:33:22 -07:00
ce59df01e3 [stable-2.8] Fix podman_image integration tests (#59805)
Pin podman package at a specific version
(cherry picked from commit 691976c3d0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-30 17:30:41 -07:00
ac1e647e55 [2.8] fixed _merge_dictionaries calls in GcpSession class
(cherry picked from commit c24b841c0a)
2019-07-30 17:29:21 -07:00
b866036365 add eol banner (#59254)
(cherry picked from commit 00699735e9)
2019-07-30 17:26:21 -07:00
77df9ddaa8 Backport/2.8/59689 ce_netstream_global: update to fix a bug. (#59689) (#59786)
* ce_netstream_global: update to fix a bug. (#59689)

* update to fix a bug.

* Update ce_netstream_global.py

(cherry picked from commit 3c7e8f7905)

* add a changelog fragment.
2019-07-30 17:25:01 -07:00
11e087ff7a consul_session: improve documentation and add integration tests (#56392) (#59357)
* consul_session: Python 2.6 is always required on managed node
* consul_session: document all types
* consul_session: add doc for 'id' parameter
* consul_session: improve parameter descriptions
    - use formatting functions in descriptions
    - 'name' parameter is required when state=node
* consul_session: use required_if
* consul_session: add integration tests
* consul_session: use 'retry' with network dependent tasks
* Use ansible-ci-files bucket for consul binaries

Co-Authored-By: Matt Clay <matt@mystile.com>
(cherry picked from commit 5f8080aaa0)

* add a changelog fragment
2019-07-30 17:21:44 -07:00
712a11bdf7 Backport/2.8/59523 ce_config: Optimize multi-level views & fix a bug. (#59523) (#59728)
* ce_config: Optimize multi-level views & fix a bug. (#59523)

* Optimize multi-level views

* update to rewrite load_config.

* update.

* update.

* update.

* update.

(cherry picked from commit 9182d54e98)

* add a changelog fragment.
2019-07-30 13:36:21 -07:00
8badf3b3cb Backport/2.8/59347 ce_stp: update to fix a bug. (#59347) (#59685)
* ce_stp: update to fix a bug. (#59347)

* update to fix a bug.

* update for shippable.

* Update ce_stp.py

(cherry picked from commit c3d1f9b085)

* add a changelog fragment.

* Update 59685-ce_stp-to-fix-bugs.yml
2019-07-30 13:34:14 -07:00
2a1e7403c4 ec2_instance: Force int when ebs.volume_size or ebs.iops is specified (#55716)
* Force int when volume_size is specified

* changelog

* both volume_size and iops must be int

* updated changelog fragment

(cherry picked from commit 5a6f888036)
2019-07-30 13:16:45 -07:00
bce7ccc26d Backport/2.8/59336 ce_mlag_config: update to fix a bug(#59336) (#59684)
* ce_mlag_config: update to fix a bug. (#59336)

* update to fix a bug.

* update

* Update ce_mlag_config.py

* Update ce_mlag_config.py

(cherry picked from commit 585128e5ac)

* add a changelog fragment.
2019-07-30 13:15:03 -07:00
6b4f153459 sysctl - Reload also when current system values differ (#56153)
Previously if `sysctl_set=no` (which is the default) this module only
checked for changes in the sysctl.conf file to decide whether it should
reload it or not. This means that if the values in the conf file are the
same as they are set with the module, but the current values on the
system are different, that this module wouldn't apply the changes on the
system and thus the value set with the module wouldn't be applied on the
OS. This isn't obvious and it doesn't make sense that the module works
like that by default, especially because there is a separate option
`reload`. Now sysctl will also check if the current value differs on the
system and if it does, it will reload the file again.

(cherry picked from commit 5fc769f6b1)
2019-07-30 13:14:21 -07:00
e97ceafa82 [2.8] Fix traceback when using gluster_volume
Since bricks_in_volume is a list, it can't be compared to a int.

(cherry picked from commit 06651d1055)
2019-07-30 12:35:51 -07:00
35ba55599a PR to implement ansible_net_model for iosxr facts module (#58488)
* resolves 57767

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 539f37ede3)

Handle lowercase in version info (#59565)

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 3a103405b1)

Add changelog for iosxr_facts fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-30 12:17:20 -07:00
95fd0d58e6 [stable-2.8] Make docker swarm integration tests more reliable (#59473)
(cherry picked from commit 3ceeae0de9)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-30 12:07:14 -07:00
ed027203c6 2.8: Clear 'connection related' plugin vars for next loop iteration (#59024) v2 (#59510)
* Clear 'connection related' plugin vars for next loop iteration (#59024)

Fixes #58876

(cherry picked from commit a752e2a467)

* Preserve original variables when using a loop (#59426)

Fixes #59414

(cherry picked from commit 1010363c0b)
2019-07-29 14:48:31 -07:00
a06b3a5174 Backport/2.8/59346 ce_startup: update to fix a bug (#59520)
* update to fix a bug (#59346)


(cherry picked from commit 6ff54c546e)

* add a changelog fragment.
2019-07-29 12:38:01 -07:00
9d32d06104 Backport/2.8/59497 fix code formatting, remove unused imports (#59518)
* postgresql modules: fix by flake8 (#59497)

(cherry picked from commit fd35833554)

* Backport of 59497: fix code formatting, remove unused imports
2019-07-29 12:27:50 -07:00
282cf8fd78 backport/2.8/59343 ce_mtu: update to fix bugs. (#59343) (#59515)
* ce_mtu: update to fix bugs. (#59343)

* update to fix bug.

* Update ce_mtu.py

* Update ce_mtu.py

* Update ce_mtu.py

(cherry picked from commit 93265bf92e)

* add a changelog fragment to PR 59515.
2019-07-29 12:26:54 -07:00
e08427a138 Correct places where match was intended
pytest.raises has two parameters, message and match.  message is meant
to be the error message that pytest gives when the tested code does not
raise the expected exception.  match is the string that pytest expects
to be a match for the repr of the exception.  Unfortunately, it seems
that message is often mistakenly used where match is meant.  Fix those
cases.

message is also deprecated so removed our usage of it.  Perhaps we
should write a sanity test later that prevents the use of
pytest.raises(message) to avoid this mistake.

seealso: https://docs.pytest.org/en/4.6-maintenance/deprecations.html#message-parameter-of-pytest-raises

Also update the exception message tested for as we're now properly
detecting that the messages have changed.

(cherry picked from commit 87601969a3)

Fix root filter test

On python-2.6 the error message is different

(cherry picked from commit 67fb3a8215)

Fix the pytest match test for python-2.6

(cherry picked from commit 8a880d6032)
2019-07-29 12:08:15 -07:00
65c6306f37 Backport/2.8/59345 ce_rollback: shouldn't load xml configure via network_cli. (#59445)
* update to fix bugs.

(cherry picked from commit 657ff644ca)

* add a changelog fragment.
2019-07-29 12:07:47 -07:00
4b81be97fa Backport/2.8/59344 ce_ntp_auth: update to fix "state is present but all of the following are missing: pas… (#59437)
* update to "state is present but all of the following are missing: password" bug

(cherry picked from commit 661b009f36)

* add a changelog fragment.

* update changelog fragment: section "bugfixes" list items must be type str not dict.

* update
2019-07-29 12:06:53 -07:00
5410128801 Ovirt host event log backport (#59432)
* Ovirt host event log (#57935)

* host event log init

* show more events

* add time check

* correct pep8 syntax

* use event id as first elem

* init start event in constr

* update pep8 syntax

* remove precreate

* add changelog
2019-07-29 12:05:22 -07:00
9a3dc5f798 Fix netconf connection command timeout issue (#58322)
*  ncclient uses same timeout value at the time
   of connection initialisation and waiting response
*  Ansible has connect_timeout to control the waiting
   time during initial connection and `command_timeout`
   to control the wait time for resposne. Hence set the
   ncclient timeout seperately to Ansible command_timeout
   after the connection object is created sucessfully.

(cherry picked from commit db0fe4b188)
2019-07-29 09:32:57 -07:00
e2c8a64b45 [stable-2.8] Fix for skipping of gitlab_runner test.
Correct variable name for skipping of the gitlab test when gitlab python
client is not installed.
(cherry picked from commit 0c992d5ae4)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-07-26 15:18:31 -07:00
542aec6166 Minor docs fix for sanity test docs backport. 2019-07-26 11:03:45 -07:00
dd42aac878 Remove redundant "Sanity Tests »" from page title.
The docs now have multi-level breadcrumbs so including "Sanity Tests »" in the title on a sanity test page is redundant.

(cherry picked from commit b4494fa547)
2019-07-26 10:15:21 -07:00
4782c6b0b8 remove ambiguity: use "my_test" as module name (#59335) (#59519)
Use "my_test" as the sample module name on the developing_modules_general page.

(cherry picked from commit 28b9f71640)
2019-07-25 15:49:03 -05:00
8e9c8c5b8f Fix return values types for find module in docs (#59480)
* Update find.py (#59456)
Return values for `matched` and `examined` in the find module are integers and not strings.
(cherry picked from commit 7b4ce9e4ae)
2019-07-25 15:47:39 -05:00
9b1615058e psexec - update example for for delegation example (#59475) (#59482)
(cherry picked from commit 3581e63ca8)
2019-07-25 15:44:43 -05:00
4b5c13ff76 Update Ansible release version to v2.8.3.post0. 2019-07-25 13:37:02 -07:00
be6918689a New release v2.8.3 2019-07-25 10:03:46 -07:00
42c2b3e496 [stable-2.8] Fix nightly rpm release
The nightly rpm builds were using a timestamp from the last git commit
in their Release field.  Unfortunately, that was using author timestamp
which is nonsequential.  Change to using commit timestamp which is
sequential.

note that this still has a cornercase if the branch's history is ever
rewritten.
(cherry picked from commit 97edfcc)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-07-24 09:49:13 -07:00
b64f3b3b98 [stable-2.8] Re-enable docker_container tests (#59425)
Mark dependent container's ipc_mode as shareable
(cherry picked from commit 266d6e77a9)

Co-authored-by: Felix Fontein <felix@fontein.de>
2019-07-24 09:15:08 -07:00
fc684b6204 [stable-2.8] Mark Docker tests unstable (#59408)
* Mark Docker tests unstable

- docker_swarm is unstable on RHEL 8
- docker_container is unstable on RHEL 7

* Disable docker_container test.
(cherry picked from commit 67c69f3)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-22 18:59:41 -07:00
a0688027a5 Revert "Clear 'connection related' plugin vars for next loop iteration (#59024)"
This reverts commit 5e7e9b57c0.

This causes a new set of regressions from 2.8.2:
https://github.com/ansible/ansible/pull/59284#issuecomment-514021543

So this issue won't be fixed in 2.8.3 but work towards a fix for 2.8.4
will continue.
2019-07-22 18:54:45 -07:00
37f8684330 if users are None/empty, dont assume sameness (#58875)
(cherry picked from commit 4ef2545eb5)

 also fix all cases of none remote/become users (#59397)
 some cases failed, when defaults were None on the plugins

(cherry picked from commit 74ac229fa8)
2019-07-22 18:46:09 -07:00
89963a0062 Fix gather facts ignoring gather_subsets config (#59271)
* Fix gather facts ignoring gather_subsets config

 fixes #58728

* Update lib/ansible/playbook/play.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8a886a6bee)
2019-07-22 18:45:06 -07:00
18fc915b15 [2.8] VMware: Fix vmware_guest cloning bug
* fix vmware_guest cloning bug
* added tests for resizing disks during clone

(cherry picked from commit 3a5d13b0d7)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 18:43:53 -07:00
89d5830da0 2.8: Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280) (#59373)
* Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)

This reverts commit 6069d09b9d.

Fixes #57351

(cherry picked from commit b7868529ee)

* Add changelog for #59280 (#59380)


(cherry picked from commit d6b1376006)
2019-07-22 17:07:46 -07:00
e989f4c38d Backport 59342, postgresql_schema: parameter ensure replaced by state (#59368)
* parameter ensure replaced by state (#59342)

corrected a typo at the absent-example.
(cherry picked from commit 883cc665e3)

* Backport 59342, postgresql_schema: parameter ensure replaced by state
2019-07-22 17:05:23 -07:00
6e9c928817 [2.8] Address regression causing bootproto=dhcp for manual IP addresses
Commit b7724fdf85
appears to have caused a regression, where `ip4`, `gw4`, `ip6`, `gw6`
were converted to `ipv4.address`, `ipv4.gateway` etc.

This causes bootproto (or `ipv4.method`) to remain `dhcp`, as noted in https://github.com/ansible/ansible/issues/36615

This commit only reverts the key-value pairs to the original names,
which is in line with both expectation (manual ip addr == no dhcp) and
the language used in the playbook, which is, for example, "ip4" not
"ipv4.address"

Co-authored-by: Stuart Pollock <spollock@pivotal.io>
Co-authored-by: Tyler Ramer <tramer@pivotal.io>
(cherry picked from commit 8d0f2e5725)
2019-07-22 17:03:59 -07:00
02c605b4c9 ovirt vm when creating Nonetypefix (#59377)
* ovirt vm when creating Nonetypefix

* update fix and add comment

* add changelog

* Update 59377-ovirt-vm-when-creating-fix.yml
2019-07-22 16:49:02 -07:00
e0dbe1bf26 [stable-2.8] Omit -A and -G options in local mode since luseradd does not support these (#55401) (#58480)
* [stable-2.8] Omit -A and -G options in local mode since luseradd does not support these (#55401)

Add integration tests
(cherry picked from commit 20ad120829)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* User - make groups and append mutually exclusive with local (#59309)

* Update intigration tests

(cherry picked from commit 8edad83ae0)
2019-07-22 16:48:28 -07:00
302de41a31 [2.8] VMware: Accept 0 as valid value for memory reservation
vmware_guest accepts 0MB as valid value for memory reservation in
virtual machine hardware configuration. This fixes the regression
introduced via 193f69064f.

Fixes: #59190

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 1f49abb51c)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 16:37:02 -07:00
e5f68cad5a Fix win_reg_stat for HKU hives (#59359)
(cherry picked from commit 2f2b106423)
2019-07-22 16:35:06 -07:00
ffa92f7725 Fix typo in import package name. (#59229)
(cherry picked from commit cdf0947df0)
2019-07-22 16:29:19 -07:00
6c14bdeb7e disable s3_lifecycle tests (#59311)
(cherry picked from commit 1d3f2c7764)
2019-07-22 16:24:57 -07:00
2f5c3b3cb4 [stable-2.8] Handle situation where ansible_architecure may not be defined when gathering facts (#55466)
(cherry picked from commit f231f21669)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-22 16:22:04 -07:00
c40949df8a Ovirt vnic profile docs backport (#59288)
* ovirt vnic profile update readme (#57298)

removes second of two identical examples

* add changelog
2019-07-22 16:20:30 -07:00
5e7e9b57c0 Clear 'connection related' plugin vars for next loop iteration (#59024)
Fixes #58876

(cherry picked from commit a752e2a467)
2019-07-22 15:44:33 -07:00
a2d6f9acd9 Win setup fix 2.8 (#59211)
* Wrap Get-MachineSid's body in a try/catch

It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: #47813
(cherry picked from commit b8a41a90b8)

* add changelog


(cherry picked from commit 277690bcc6)
2019-07-22 15:21:02 -07:00
4f939d4b2b [stable-2.8] Move integration tests to using RHEL 8.0 GA (#57772).
(cherry picked from commit b9dafdbade)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-22 15:20:32 -07:00
c55d83f41e Backport/2.8/59071 ce_file_copy : update ce_file_copy to fix a bug. (#59071) (#59243)
* ce_file_copy : update ce_file_copy to fix a bug. (#59071)

* update ce_file_copy to fix a bug.

* Update ce_file_copy.py

* Update ce_file_copy.py

(cherry picked from commit 7a0a21ea7a)

* add a changelog fragment to PR 59243.
2019-07-22 15:11:16 -07:00
b373d45839 Correct a documentation of the jenkins_plugin module (#59331)
It's a backport of #59139
2019-07-22 16:11:53 -05:00
2fbf4ca99c [2.8] Fix ec2_eip parameter logic
device_id is required when private_ip_address is set, but the reverse is not true.

(cherry picked from commit 6273574eb4)

Signed-off-by: flowerysong <junk+github@flowerysong.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 14:01:02 -07:00
d0f74f495b dzdo: fix password prompt (#59208)
(cherry picked from commit 28259ee247)
2019-07-22 13:59:53 -07:00
a5178d8a34 Add pslint ignore rules 2019-07-22 13:59:02 -07:00
9c391ea78e [stable-2.8] Update default test container to use Python 3.8.0b2 (#58877).
(cherry picked from commit 5ccd674dba)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-22 13:59:02 -07:00
5447dc855b Ovirt correct sysprep backport (#59286)
* use sysprep only when needed (#59196)

* add changelog
2019-07-22 13:53:52 -07:00
8074fa9a3e patch ansible-connection collection plugin loading (#59119)
(cherry picked from commit d28f25d118)
2019-07-17 15:34:16 -07:00
f837444a77 [stable-2.8] Add test for meta: end_play (#59118)
- Set ansible_python_interpreter for hosts using local connection
(cherry picked from commit d17e7a91b1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-17 15:32:26 -07:00
0d86a4dbaa group: detect duplicate GIDs when local=yes (#58469)
(cherry picked from commit 4898b0a4a2)
2019-07-17 14:30:55 -07:00
299fff1d5e Fix os_quota when volume service not available
os_quota checks the current quotas for compute, network and volume
services and fails when no volume service is found in the catalog.

Since openstack test deployments without volume services are common,
os_quota shouldn't fail if such service is missing.

This was originally fixed in d31a09ceb7
and later adapted to catch exceptions raised by shade. Since then, this
module moved to using openstacksdk, which doesn't catch the exception
raised by keystoneauth1.

Fixes #41240

(cherry picked from commit 1aca1f21f9)
2019-07-17 14:28:26 -07:00
afb91e5140 [2.8] tower_role: ensure alias of "validate_certs" parameter is handled
* tower_role: ensure alias of validate_certs is handled

* tower modules: remove tower_verify_ssl alias too

Error was:

    Failed to update role: The Tower server claims it was sent a bad request.
    GET https://tower/api/v2/projects/22/object_roles/
    Params: [('tower_verify_ssl', False), ('role_field', 'admin_role')]
    Data: None
    Response: {"detail": "Role has no field named 'tower_verify_ssl'"}

Full traceback:

    File "/tmp/ansible_tower_role_payload_7_2p0X/__main__.py", line 145, in main
      result = role.grant(**params)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 365, in grant
      return self.role_write(fail_on_found=fail_on_found, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 242, in role_write
      fail_on_multiple_results=True, **data)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/models/base.py", line 301, in read
      r = client.get(url, params=params)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 546, in get
      return self.request('GET', url, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/api.py", line 299, in request
      kwargs.get('data', None), r.content.decode('utf8'))

(cherry picked from commit 77e01e6abc)
2019-07-17 12:44:31 -07:00
863520b077 Update 58227-update-cce_evpn_bd_vni-to-fix-a-bug.yml 2019-07-17 12:16:46 -07:00
550cac42bc add a changelog fragment to PR 58558. 2019-07-17 12:16:46 -07:00
98725b25f7 update to fix a bug (#58227)
(cherry picked from commit e0f3e404c9)
2019-07-17 12:16:46 -07:00
6491c5cdd7 Backport/2.8/58226 ce_vxlan_gateway: update the regular expression to match the more acc… (#58557)
* ce_vxlan_gateway: update the regular expression to match the more accurate. (#58226)

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

(cherry picked from commit 2f91266aa9)

* add a changlog fragment to PR 58557.

* Update 58226-update-ce_vxlan_gateway-to-fix-a-bug.yml
2019-07-17 12:14:47 -07:00
d170588ab6 [2.8] Define region for aws_secret (#58722)
* AWS: Fix KeyError in aws_secret lookup (#54792)

(cherry picked from commit 33d0d36eaa)

* changelog
2019-07-17 12:11:24 -07:00
494ec6d752 Backport/2.8/59070 ce_interface : update ce_interface to fix a bug (#59072)
* update ce_interface to fix a bug. (#59070)


(cherry picked from commit 07a598089a)

* add a changelog fragment to PR 59072.
2019-07-17 11:49:09 -07:00
3d999dbe39 docker_* modules: improve tag validation and requests error handling (#58791)
* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.

(cherry picked from commit 8d6f1846a6)
2019-07-17 11:48:27 -07:00
1e20cc8bd1 docker_container: add support for nocopy mode (#59043)
* Add support for nocopy mode.

* Add changelog.

(cherry picked from commit fa7c387f9b)
2019-07-17 09:24:21 -07:00
eb8c4eaa01 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit d2dc4c9bc4)
2019-07-16 20:03:51 -07:00
e6c93bea0d Fix gather_facts error/skipped reporting (#58927)
now give back full output from each module executed
 fixes #57204

(cherry picked from commit adea964c3e)
2019-07-16 19:50:37 -07:00
0f292cd886 nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
(cherry picked from commit e8f4ebb22c)
2019-07-16 17:57:45 -07:00
4477af7f90 ovirt: Resolve also list of hrefs 2019-07-16 17:56:37 -07:00
909f68d035 Ovirt vm migrate with state present backport (#58720)
* ovirt vm migrate with state present  (#58136)

* ovirt vm migrate with state present init

* add migrate comment

* add changelog
2019-07-16 17:50:18 -07:00
d3afa17930 Use templated loop_var/index_var when looping include_* (#58866)
Fixes #58820

(cherry picked from commit 7346b699ee)
2019-07-16 15:11:57 -07:00
044923e4ae Fix broken slxos_config due to changed backup options (#58804)
(cherry picked from commit 5b2d1cc24d)
2019-07-16 14:48:28 -07:00
6d146c89f2 Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit faf50dbace)
2019-07-16 14:46:21 -07:00
6d467a8bd9 Backport machinectl become plugin fixes (#58734) (#58774)
* Correct machinectl become plugin function arguments (#58734)

* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)

(cherry picked from commit 4f642daae5)

* Update PR number in changelog fragment

* Revert "Update PR number in changelog fragment"

This reverts commit 38e6b4785a.
2019-07-16 14:40:36 -07:00
3516406d59 win_get_url - Fix proxy_url not used correctly
(cherry picked from commit a21d40474c)
2019-07-16 14:23:01 -07:00
5fb2a0ae2d Backport PR to resolve NoneType error in issue 57711 (#58706)
* fix 57711 (#58618)

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 8b844b67b5)

* changelog file
2019-07-16 14:22:18 -07:00
396e48b36e Ovirt update vm migrate docs backport (#58717)
* ovirt update vm migration domunetation (#58577)

* init update docs

* Update lib/ansible/modules/cloud/ovirt/ovirt_vm.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* add changelog
2019-07-16 14:21:16 -07:00
4519688a95 Ovirt add host retry doc backport (#58718)
* add changelog

* add docs about retry (#58625)
2019-07-16 14:19:40 -07:00
04762f1c26 [stable-2.8] Improve setup_docker tests to work with RHEL 8 GA (#58649)
- use include_vars to set appropriate packages and pip packages per distribution and version
- install an older version of Docker CE on RHEL 8 since a dependency is unavailable
- disable warnings on tasks that are ok
- skip tests for CentOS/RHEL 6
(cherry picked from commit d50c8c2b83)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-16 14:18:54 -07:00
6e0f2a37aa [stable-2.8] Improve dnf test formatting and fix RHEL 8 module name (#58648)
- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
- use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA
(cherry picked from commit 16d6fcf514)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-16 14:06:10 -07:00
db7c82ea21 Backport/2.8/55218 (#58639)
* "no macro" command should not be handled by edit_macro(), fixes #55212
(cherry picked from commit 2cdab1379f)

* fixed ios_config issue where the "no macro" command was erroneously handled by edit_macro()
2019-07-16 14:03:45 -07:00
7e8b81ae18 [2.8] VMware: looking up maxMksConnections in incorrect location
maxMksConnections is contained in vim.vm.ConfigInfo not vim.vm.VirtualHardware

Fixes: #58060

Signed-off-by: lijok <28689084+lijok@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 63bdd0d6cd)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 14:01:56 -07:00
752c40464f Docs on general precedence (#50201) (#59120)
* Add docs/docsite/rst/reference_appendices/general_precedence.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
(cherry picked from commit c2469648e4)
2019-07-16 14:10:32 -05:00
e8450891ba Load Ansible module_utils for ps_argspec validator (#58571)
* Load Ansible module_utils for ps_argspec validator

* fix validation for modules without Requires statement

* Moved future comment to proper location

(cherry picked from commit c3978fed4b)
2019-07-16 12:10:09 -07:00
014b7ecc07 win_domain_user: do not hide error on failures (#58357)
* win_domain_user: do not hide error on failures

* Was a bit too overzealous in the removal

* Remove uneeded sanity ignore rule

(cherry picked from commit c260721ce5)
2019-07-16 12:05:20 -07:00
dd758f582a openssl_privatekey: forgot to add secp256r1 (#58605)
* Forgot to add secp256r1. This one is the interoperable one.

* Add changelog.

(cherry picked from commit 5d5a7d6ebe)
2019-07-16 12:04:37 -07:00
0306b9a907 [2.8] VMware: Set vapp settings while creating VM
vApp Settings can be set while creating VM.

Fixes: #50617

(cherry picked from commit 760dc19284)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 11:56:14 -07:00
28077887c2 2.8: yum: take care of stale/invalid yum.pid (#58457) (#58489)
* yum: take care of stale/invalid yum.pid (#58457)

* yum: take care of stale/invalid yum.pid

* Add changelog

(cherry picked from commit 5064e67d37)

* yum: check whether the lock file disappeared (#58581)


(cherry picked from commit b0f38931b0)
2019-07-15 13:58:53 -07:00
b41199f1f2 Remove reference to Windows for assemble docs (#59082) (#59098)
(cherry picked from commit 66a5ed64ca)
2019-07-15 15:58:14 -05:00
4d9542a789 Backport/2.8/58251 ce_static_route: fix some bugs. (#58251) (#58565)
* ce_static_route:  fix some bugs. (#58251)

* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.

(cherry picked from commit bb33c922f7)

* add a changelog fragment to PR 58565.

* Update 58565-update-ce_static_route-to-fix-a-bug.yml
2019-07-15 13:57:35 -07:00
fb5a6e1250 Cleanup EXAMPLES (#58972) (#59012)
(cherry picked from commit 4ab364eaaf)
2019-07-12 15:36:50 -05:00
840d869c22 Backport/2.8/58936 (#58939)
* Changing LBName used by same task inside azure_rm_loadbalancer (#58936)

fixes #58933

(cherry picked from commit 00d7aed56b)

* Backporting #58933 to stable-2.8
2019-07-10 19:34:21 -07:00
87f0e0405e Add examples (#58819) (#58917)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example

(cherry picked from commit 5689cc08ce)
2019-07-10 14:43:38 -05:00
9724b230e3 backport/2.8/58231 ce_netstream_aging: update to fix a bug. (#58231) (#58563)
* ce_netstream_aging: update to fix a bug. (#58231)

* update to fix a bug

* update to for shippable.

(cherry picked from commit 715de33467)

* add a changelog fragment.

* Update 58563-update-ce_netstream_aging-to-fix-a-bug.yml
2019-07-08 21:44:11 -07:00
ae17f3842e Backport/2.8/58230 ce_link_status: update to fix a bug (#58230) (#58561)
* update to fix a bug (#58230)


(cherry picked from commit b7630ccb36)

* add a changelog fragment.
2019-07-08 21:43:08 -07:00
eb9f6ce790 Update 58229-update-ce_interface_ospf-to-fix-a-bug.yml 2019-07-08 21:42:01 -07:00
b7c348afda add a changelog fragment. 2019-07-08 21:42:01 -07:00
e072a5b111 update to fix a bug (#58229)
Signed-off-by: xuxiaowei0512 <786018072@qq.com>
(cherry picked from commit b93411a5b2)
2019-07-08 21:42:01 -07:00
e61ea32779 Backport/2.8/58228 ce_evpn_bgp_rr: update to fix a bug (#58228) (#58559)
* update to fix a bug (#58228)


(cherry picked from commit 23139cdbb9)

* add a changlog fragment.

* Update 58559-update-ce_evpn_bgp_rr-to-fix-a-bug.yml
2019-07-08 18:02:27 -07:00
ead3787fc7 Backport/2.8/57947 update ce_vxlan_global to fix bugs. (#57947) (#58553)
* update ce_vxlan_global to fix bugs.  (#57947)

* update to fix bugs.

* add a changelog fragment.

* update a changelog fragment.

(cherry picked from commit 242f160747)

* Update 57947-update-ce_vxlan_global-to-fix-bugs.yml
2019-07-08 18:01:49 -07:00
7f87698e79 backport/2.8/58207 ce_bfd_view: update to fix a bug (#58207) (#58556)
* update to fix a bug (#58207)


(cherry picked from commit 4a6c86715a)

* add a changelog fragment to PR 58556.

* Update 58207-update-ce_bfd_view-to-fix-a-bug.yml
2019-07-08 18:01:01 -07:00
db5ceb2390 Backport/2.8/58200 ce_bfd_global: update to fix a bug. (#58200) (#58555)
* update to fix a bug. (#58200)


(cherry picked from commit 875e7c3e50)

* add a changlog fragment to PR 58200.

* Update 58200-update-ce_bfd_global-to-fix-a-bug.yml
2019-07-08 18:00:21 -07:00
b53ed66d78 backport/2.8/57916 ce_vrrp: update ce_vrrp to fix a bug (#57916) (#58554)
* update vrrp (#57916)


(cherry picked from commit 442d275ae3)

* add a changelog fragment to PR 58554.

* Update 58554-update-ce_vrrp-to-fix-a-bug.yml
2019-07-08 17:58:19 -07:00
c66ee98d23 update ce_interface to fix bugs (#57907)
* update ce_interface

* update ce_interface

* add a changelog fragment.

(cherry picked from commit e02353026d)
2019-07-08 17:57:34 -07:00
15529abbed [2.8] VMware: Warn user about dvswitch permissions (#58758)
Warn user that permissions for a distributed switch must be defined and managed on either
the datacenter or a folder containing the switch.

(cherry picked from commit 5e2471485a)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-08 15:32:08 -05:00
2c6c631a38 [stable-2.8] Fix unicode error in changelog generation
(cherry picked from commit fed90ef)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-07-05 11:47:27 -07:00
3d9c2e8c23 Add a banner message to warn when not on latest documentation (#58526) (#58762)
* add banner to versions that are not latest

(cherry picked from commit 35b6345bdc)
2019-07-05 09:35:39 -05:00
8321cfb2a4 Update Ansible release version to v2.8.2.post0. 2019-07-03 13:41:29 -07:00
1678 changed files with 19314 additions and 12262 deletions

View File

@ -0,0 +1,219 @@
trigger:
batch: true
branches:
include:
- devel
- stable-*
pr:
autoCancel: true
branches:
include:
- devel
- stable-*
schedules:
- cron: 0 7 * * *
displayName: Nightly
always: true
branches:
include:
- devel
- stable-*
variables:
- name: checkoutPath
value: ansible
- name: coverageBranches
value: devel
- name: pipelinesCoverage
value: coverage
- name: entryPoint
value: test/utils/shippable/shippable.sh
- name: fetchDepth
value: 500
resources:
containers:
- container: default
image: quay.io/ansible/azure-pipelines-test-container:1.8.0
pool: Standard
stages:
- stage: Sanity
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Test {0}
testFormat: sanity/{0}
targets:
- test: 1
- test: 2
- test: 3
- test: 4
- stage: Units
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: units/{0}
targets:
- test: 2.6
- test: 2.7
- test: 3.5
- test: 3.6
- test: 3.7
- test: 3.8
groups:
- 1
- 2
- stage: Windows
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Server {0}
testFormat: windows/{0}
targets:
- test: 2012
- test: 2012-R2
- test: 2016
- test: 2019
groups:
- 1
- 2
- 3
- 4
- 5
- 6
- 7
- stage: Network
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: network/{0}
targets:
- test: ''
- stage: Remote
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
targets:
- name: OS X 10.11
test: osx/10.11
- name: RHEL 7.9
test: rhel/7.9
- name: RHEL 8.2
test: rhel/8.2
- name: FreeBSD 11.1
test: freebsd/11.1
- name: FreeBSD 12.0
test: freebsd/12.0
groups:
- 1
- 2
- 3
- 4
- stage: Docker
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
testFormat: linux/{0}
targets:
- name: CentOS 6
test: centos6
- name: CentOS 7
test: centos7
- name: Fedora 29
test: fedora29
- name: Fedora 30
test: fedora30
- name: openSUSE 15 py2
test: opensuse15py2
- name: openSUSE 15 py3
test: opensuse15
- name: Ubuntu 16.04
test: ubuntu1604
- name: Ubuntu 18.04
test: ubuntu1804
groups:
- 1
- 2
- 3
- 4
- stage: AWS
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: aws/{0}
targets:
- test: 2.7
- test: 3.6
groups:
- 1
- 2
- stage: vCenter
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: vcenter/{0}/1
targets:
- test: 2.7
- test: 3.6
- stage: CloudStack
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: cs/{0}/1
targets:
- test: 2.7
- test: 3.6
- stage: Cloud
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: cloud/{0}/1
targets:
- test: 2.7
- test: 3.6
- stage: Hetzner
dependsOn: []
jobs:
- template: templates/matrix.yml
parameters:
nameFormat: Python {0}
testFormat: hcloud/{0}/1
targets:
- test: 2.7
- test: 3.6
- stage: Summary
condition: succeededOrFailed()
dependsOn:
- Sanity
- Units
- Windows
- Network
- Remote
- Docker
- AWS
- vCenter
- CloudStack
- Cloud
- Hetzner
jobs:
- template: templates/coverage.yml

View File

@ -0,0 +1,20 @@
#!/usr/bin/env bash
# Aggregate code coverage results for later processing.
set -o pipefail -eu
agent_temp_directory="$1"
PATH="${PWD}/bin:${PATH}"
mkdir "${agent_temp_directory}/coverage/"
options=(--venv --venv-system-site-packages --color -v)
ansible-test coverage combine --export "${agent_temp_directory}/coverage/" "${options[@]}"
if ansible-test coverage analyze targets generate --help >/dev/null 2>&1; then
# Only analyze coverage if the installed version of ansible-test supports it.
# Doing so allows this script to work unmodified for multiple Ansible versions.
ansible-test coverage analyze targets generate "${agent_temp_directory}/coverage/coverage-analyze-targets.json" "${options[@]}"
fi

View File

@ -0,0 +1,60 @@
#!/usr/bin/env python
"""
Combine coverage data from multiple jobs, keeping the data only from the most recent attempt from each job.
Coverage artifacts must be named using the format: "Coverage $(System.JobAttempt) {StableUniqueNameForEachJob}"
The recommended coverage artifact name format is: Coverage $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)
Keep in mind that Azure Pipelines does not enforce unique job display names (only names).
It is up to pipeline authors to avoid name collisions when deviating from the recommended format.
"""
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import os
import re
import shutil
import sys
def main():
"""Main program entry point."""
source_directory = sys.argv[1]
if '/ansible_collections/' in os.getcwd():
output_path = "tests/output"
else:
output_path = "test/results"
destination_directory = os.path.join(output_path, 'coverage')
if not os.path.exists(destination_directory):
os.makedirs(destination_directory)
jobs = {}
count = 0
for name in os.listdir(source_directory):
match = re.search('^Coverage (?P<attempt>[0-9]+) (?P<label>.+)$', name)
label = match.group('label')
attempt = int(match.group('attempt'))
jobs[label] = max(attempt, jobs.get(label, 0))
for label, attempt in jobs.items():
name = 'Coverage {attempt} {label}'.format(label=label, attempt=attempt)
source = os.path.join(source_directory, name)
source_files = os.listdir(source)
for source_file in source_files:
source_path = os.path.join(source, source_file)
destination_path = os.path.join(destination_directory, source_file + '.' + label)
print('"%s" -> "%s"' % (source_path, destination_path))
shutil.copyfile(source_path, destination_path)
count += 1
print('Coverage file count: %d' % count)
print('##vso[task.setVariable variable=coverageFileCount]%d' % count)
print('##vso[task.setVariable variable=outputPath]%s' % output_path)
if __name__ == '__main__':
main()

View File

@ -0,0 +1,24 @@
#!/usr/bin/env bash
# Check the test results and set variables for use in later steps.
set -o pipefail -eu
if [[ "$PWD" =~ /ansible_collections/ ]]; then
output_path="tests/output"
else
output_path="test/results"
fi
echo "##vso[task.setVariable variable=outputPath]${output_path}"
if compgen -G "${output_path}"'/junit/*.xml' > /dev/null; then
echo "##vso[task.setVariable variable=haveTestResults]true"
fi
if compgen -G "${output_path}"'/bot/ansible-test-*' > /dev/null; then
echo "##vso[task.setVariable variable=haveBotResults]true"
fi
if compgen -G "${output_path}"'/coverage/*' > /dev/null; then
echo "##vso[task.setVariable variable=haveCoverageData]true"
fi

View File

@ -0,0 +1,27 @@
#!/usr/bin/env bash
# Upload code coverage reports to codecov.io.
# Multiple coverage files from multiple languages are accepted and aggregated after upload.
# Python coverage, as well as PowerShell and Python stubs can all be uploaded.
set -o pipefail -eu
output_path="$1"
curl --silent --show-error https://codecov.io/bash > codecov.sh
for file in "${output_path}"/reports/coverage*.xml; do
name="${file}"
name="${name##*/}" # remove path
name="${name##coverage=}" # remove 'coverage=' prefix if present
name="${name%.xml}" # remove '.xml' suffix
bash codecov.sh \
-f "${file}" \
-n "${name}" \
-X coveragepy \
-X gcov \
-X fix \
-X search \
-X xcode \
|| echo "Failed to upload code coverage report to codecov.io: ${file}"
done

View File

@ -0,0 +1,15 @@
#!/usr/bin/env bash
# Generate code coverage reports for uploading to Azure Pipelines and codecov.io.
set -o pipefail -eu
PATH="${PWD}/bin:${PATH}"
if ! ansible-test --help >/dev/null 2>&1; then
# Install the devel version of ansible-test for generating code coverage reports.
# This is only used by Ansible Collections, which are typically tested against multiple Ansible versions (in separate jobs).
# Since a version of ansible-test is required that can work the output from multiple older releases, the devel version is used.
pip install https://github.com/ansible/ansible/archive/devel.tar.gz --disable-pip-version-check
fi
ansible-test coverage xml --stub --venv --venv-system-site-packages --color -v

View File

@ -0,0 +1,34 @@
#!/usr/bin/env bash
# Configure the test environment and run the tests.
set -o pipefail -eu
entry_point="$1"
test="$2"
read -r -a coverage_branches <<< "$3" # space separated list of branches to run code coverage on for scheduled builds
export COMMIT_MESSAGE
export COMPLETE
export COVERAGE
export IS_PULL_REQUEST
if [ "${SYSTEM_PULLREQUEST_TARGETBRANCH:-}" ]; then
IS_PULL_REQUEST=true
COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD^2)
else
IS_PULL_REQUEST=
COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD)
fi
COMPLETE=
COVERAGE=
if [ "${BUILD_REASON}" = "Schedule" ]; then
COMPLETE=yes
if printf '%s\n' "${coverage_branches[@]}" | grep -q "^${BUILD_SOURCEBRANCHNAME}$"; then
COVERAGE=yes
fi
fi
"${entry_point}" "${test}" 2>&1 | "$(dirname "$0")/time-command.py"

View File

@ -0,0 +1,25 @@
#!/usr/bin/env python
"""Prepends a relative timestamp to each input line from stdin and writes it to stdout."""
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import sys
import time
def main():
"""Main program entry point."""
start = time.time()
sys.stdin.reconfigure(errors='surrogateescape')
sys.stdout.reconfigure(errors='surrogateescape')
for line in sys.stdin:
seconds = time.time() - start
sys.stdout.write('%02d:%02d %s' % (seconds // 60, seconds % 60, line))
sys.stdout.flush()
if __name__ == '__main__':
main()

View File

@ -0,0 +1,39 @@
# This template adds a job for processing code coverage data.
# It will upload results to Azure Pipelines and codecov.io.
# Use it from a job stage that completes after all other jobs have completed.
# This can be done by placing it in a separate summary stage that runs after the test stage(s) have completed.
jobs:
- job: Coverage
displayName: Code Coverage
container: default
workspace:
clean: all
steps:
- checkout: self
fetchDepth: $(fetchDepth)
path: $(checkoutPath)
- task: DownloadPipelineArtifact@2
displayName: Download Coverage Data
inputs:
path: coverage/
patterns: "Coverage */*=coverage.combined"
- bash: .azure-pipelines/scripts/combine-coverage.py coverage/
displayName: Combine Coverage Data
- bash: .azure-pipelines/scripts/report-coverage.sh
displayName: Generate Coverage Report
condition: gt(variables.coverageFileCount, 0)
- task: PublishCodeCoverageResults@1
inputs:
codeCoverageTool: Cobertura
# Azure Pipelines only accepts a single coverage data file.
# That means only Python or PowerShell coverage can be uploaded, but not both.
# Set the "pipelinesCoverage" variable to determine which type is uploaded.
# Use "coverage" for Python and "coverage-powershell" for PowerShell.
summaryFileLocation: "$(outputPath)/reports/$(pipelinesCoverage).xml"
displayName: Publish to Azure Pipelines
condition: gt(variables.coverageFileCount, 0)
- bash: .azure-pipelines/scripts/publish-codecov.sh "$(outputPath)"
displayName: Publish to codecov.io
condition: gt(variables.coverageFileCount, 0)
continueOnError: true

View File

@ -0,0 +1,55 @@
# This template uses the provided targets and optional groups to generate a matrix which is then passed to the test template.
# If this matrix template does not provide the required functionality, consider using the test template directly instead.
parameters:
# A required list of dictionaries, one per test target.
# Each item in the list must contain a "test" or "name" key.
# Both may be provided. If one is omitted, the other will be used.
- name: targets
type: object
# An optional list of values which will be used to multiply the targets list into a matrix.
# Values can be strings or numbers.
- name: groups
type: object
default: []
# An optional format string used to generate the job name.
# - {0} is the name of an item in the targets list.
- name: nameFormat
type: string
default: "{0}"
# An optional format string used to generate the test name.
# - {0} is the name of an item in the targets list.
- name: testFormat
type: string
default: "{0}"
# An optional format string used to add the group to the job name.
# {0} is the formatted name of an item in the targets list.
# {{1}} is the group -- be sure to include the double "{{" and "}}".
- name: nameGroupFormat
type: string
default: "{0} - {{1}}"
# An optional format string used to add the group to the test name.
# {0} is the formatted test of an item in the targets list.
# {{1}} is the group -- be sure to include the double "{{" and "}}".
- name: testGroupFormat
type: string
default: "{0}/{{1}}"
jobs:
- template: test.yml
parameters:
jobs:
- ${{ if eq(length(parameters.groups), 0) }}:
- ${{ each target in parameters.targets }}:
- name: ${{ format(parameters.nameFormat, coalesce(target.name, target.test)) }}
test: ${{ format(parameters.testFormat, coalesce(target.test, target.name)) }}
- ${{ if not(eq(length(parameters.groups), 0)) }}:
- ${{ each group in parameters.groups }}:
- ${{ each target in parameters.targets }}:
- name: ${{ format(format(parameters.nameGroupFormat, parameters.nameFormat), coalesce(target.name, target.test), group) }}
test: ${{ format(format(parameters.testGroupFormat, parameters.testFormat), coalesce(target.test, target.name), group) }}

View File

@ -0,0 +1,45 @@
# This template uses the provided list of jobs to create test one or more test jobs.
# It can be used directly if needed, or through the matrix template.
parameters:
# A required list of dictionaries, one per test job.
# Each item in the list must contain a "job" and "name" key.
- name: jobs
type: object
jobs:
- ${{ each job in parameters.jobs }}:
- job: test_${{ replace(replace(replace(job.test, '/', '_'), '.', '_'), '-', '_') }}
displayName: ${{ job.name }}
container: default
workspace:
clean: all
steps:
- checkout: self
fetchDepth: $(fetchDepth)
path: $(checkoutPath)
- bash: .azure-pipelines/scripts/run-tests.sh "$(entryPoint)" "${{ job.test }}" "$(coverageBranches)"
displayName: Run Tests
- bash: .azure-pipelines/scripts/process-results.sh
condition: succeededOrFailed()
displayName: Process Results
- bash: .azure-pipelines/scripts/aggregate-coverage.sh "$(Agent.TempDirectory)"
condition: eq(variables.haveCoverageData, 'true')
displayName: Aggregate Coverage Data
- task: PublishTestResults@2
condition: eq(variables.haveTestResults, 'true')
inputs:
testResultsFiles: "$(outputPath)/junit/*.xml"
displayName: Publish Test Results
- task: PublishPipelineArtifact@1
condition: eq(variables.haveBotResults, 'true')
displayName: Publish Bot Results
inputs:
targetPath: "$(outputPath)/bot/"
artifactName: "Bot $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)"
- task: PublishPipelineArtifact@1
condition: eq(variables.haveCoverageData, 'true')
displayName: Publish Coverage Data
inputs:
targetPath: "$(Agent.TempDirectory)/coverage/"
artifactName: "Coverage $(System.JobAttempt) $(System.StageDisplayName) $(System.JobDisplayName)"

2
.github/BOTMETA.yml vendored
View File

@ -1411,8 +1411,6 @@ files:
notified: mattclay
hacking/report.py:
notified: mattclay
shippable.yml:
notified: mattclay
tox.ini:
notified: mattclay
macros:

View File

@ -3,7 +3,6 @@ include COPYING
include SYMLINK_CACHE.json
include requirements.txt
include .coveragerc
include shippable.yml
include tox.ini
include bin/ansible-test
include examples/hosts

View File

@ -51,7 +51,7 @@ RELEASE ?= 1
# Get the branch information from git
ifneq ($(shell which git),)
GIT_DATE := $(shell git log -n 1 --format="%ai")
GIT_DATE := $(shell git log -n 1 --format="%ci")
GIT_HASH := $(shell git log -n 1 --format="%h")
GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD | sed 's/[-_.\/]//g')
GITINFO = .$(GIT_HASH).$(GIT_BRANCH)
@ -60,7 +60,7 @@ GITINFO = ""
endif
ifeq ($(shell echo $(OS) | egrep -c 'Darwin|FreeBSD|OpenBSD|DragonFly'),1)
DATE := $(shell date -j -r $(shell git log -n 1 --format="%at") +%Y%m%d%H%M)
DATE := $(shell date -j -r $(shell git log -n 1 --format="%ct") +%Y%m%d%H%M)
CPUS ?= $(shell sysctl hw.ncpu|awk '{print $$2}')
else
DATE := $(shell date --utc --date="$(GIT_DATE)" +%Y%m%d%H%M)

View File

@ -84,7 +84,7 @@ and has contributions from over 4000 users (and growing). Thanks everyone!
License
=======
GNU General Public License v3.0
GNU General Public License v3.0 or later
See `COPYING <COPYING>`_ to see the full text.
@ -92,8 +92,8 @@ See `COPYING <COPYING>`_ to see the full text.
:target: https://pypi.org/project/ansible
.. |Docs badge| image:: https://img.shields.io/badge/docs-latest-brightgreen.svg
:target: https://docs.ansible.com/ansible/latest/
.. |Build Status| image:: https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel
:target: https://app.shippable.com/projects/573f79d02a8192902e20e34b
.. |Build Status| image:: https://dev.azure.com/ansible/ansible/_apis/build/status/CI?branchName=stable-2.8
:target: https://dev.azure.com/ansible/ansible/_build/latest?definitionId=20&branchName=stable-2.8
.. |Chat badge| image:: https://img.shields.io/badge/chat-IRC-brightgreen.svg
:target: https://docs.ansible.com/ansible/latest/community/communication.html
.. |Code Of Conduct| image:: https://img.shields.io/badge/code%20of%20conduct-Ansible-silver.svg

View File

@ -1627,6 +1627,139 @@ releases:
- win_acl-network.yaml
- winrm-input-failures.yaml
release_date: '2019-06-06'
2.8.10:
codename: How Many More Times
fragments:
- openstack-regression.yml
- v2.8.10_summary.yaml
release_date: '2020-03-05'
2.8.11:
codename: How Many More Times
fragments:
- 63280-fix_acl_spaces_in_path.yml
- 64906-always-delegate-fact-prefixes.yml
- af_clean.yml
- ansible-test-opensuse-15.1.yml
- ansible-test-rhel-7.8.yml
- fetch_no_slurp.yml
- ldap-params-removal.yml
- remote_mkdir_fix.yml
- subversion_password.yaml
- v2.8.11_summary.yaml
- vault_tmp_file.yml
- vault_tmp_race_fix.yml
- win-unzip-check-extraction-path.yml
release_date: '2020-04-16'
2.8.12:
codename: How Many More Times
fragments:
- 225-mysql_user_fix_no_database_selected.yml
- 68251-redfish_config-fix-boolean-bios-attr-support.yaml
- 68592-pip-check_mode-prereleases.yml
- ansible-test-rhel-82.yml
- dnf-4-2-18.yml
- inventory_docs_fix.yml
- v2.8.12_summary.yaml
- win_psmodule-repo-tls.yaml
release_date: '2020-05-11'
2.8.13:
codename: How Many More Times
fragments:
- 61889-change-transform_invalid_group_chars-default.yml
- 66549-enablerepo-not-honored-when-used-with-disablerepo-all.yml
- 70261_pipe_lookup.yml
- v2.8.13_summary.yaml
release_date: '2020-07-14'
2.8.14:
codename: How Many More Times
fragments:
- 32386_debconf_password.yml
- 67794-atomic_move-default-perms.yml
- 67794-default-permissions-warning-fix.yml
- 70762-sanitize-uri-keys.yml
- copy-sanitize-check-mode-invocation-args.yaml
- rpmfluff-compat-fixes.yml
- test-ansible-runner-pin-psutil.yml
- v2.8.14_summary.yaml
release_date: '2020-08-10'
2.8.15:
codename: How Many More Times
fragments:
- cve-2020-1736-revert.yml
- dnf_gpg.yml
- v2.8.15_summary.yaml
release_date: '2020-08-31'
2.8.16:
codename: How Many More Times
fragments:
- ansible-test-sanity-pylint-config-fix.yml
- v2.8.16_summary.yaml
release_date: '2020-10-05'
2.8.16rc1:
codename: How Many More Times
fragments:
- 159_kubectl.yml
- 69508-ansible-test-local-changes-detection.yml
- ansible-test-azp-resource-prefix.yml
- ansible-test-change-classification.yml
- ansible-test-ci-support-azure.yml
- ansible-test-ci-support-shippable-auth.yml
- ansible-test-ci-support.yml
- ansible-test-endpoint-update.yml
- ansible-test-parallels-endpoint.yml
- v2.8.16rc1_summary.yaml
release_date: '2020-09-28'
2.8.17:
codename: How Many More Times
fragments:
- v2.8.17_summary.yaml
release_date: '2020-11-02'
2.8.17rc1:
codename: How Many More Times
fragments:
- 71535_kubectl_followup.yml
- ansible-test-azp-agent-temp-dir.yml
- ansible-test-container-ip-lookup.yml
- ansible-test-docker-default-network.yml
- ansible-test-docker-detection-fix.yml
- ansible-test-docker-not-localhost.yml
- ansible-test-docker-socket.yml
- ansible-test-network-container-search.yml
- galaxy_login_bye.yml
- v2.8.17rc1_summary.yaml
release_date: '2020-10-26'
2.8.18:
codename: How Many More Times
fragments:
- v2.8.18_summary.yaml
release_date: '2020-12-14'
2.8.18rc1:
codename: How Many More Times
fragments:
- ansible-test-acme-test-plugin.yml
- ansible-test-azp-change-detection.yml
- ansible-test-centos6-eol.yml
- cffi-constraint.yml
- py26-multiprocess-queue-bug.yml
- rhel-7.9.yml
- v2.8.18rc1_summary.yaml
release_date: '2020-12-07'
2.8.19:
codename: How Many More Times
fragments:
- v2.8.19_summary.yaml
release_date: '2021-02-17'
2.8.19rc1:
codename: How Many More Times
fragments:
- ansible-test-pip-bootstrap-s3.yml
- ansible-test-pip-bootstrap.yml
- cve_bitbucket_pipeline_variable.yml
- new-nolog-entries.yml
- no_log-fallback.yml
- snmp_facts.yml
- v2.8.19rc1_summary.yaml
release_date: '2021-02-08'
2.8.2:
codename: How Many More Times
fragments:
@ -1730,3 +1863,331 @@ releases:
- win_get_url-Fix-restricted-header-handling.yml
- win_shell-arg-space.yaml
release_date: '2019-07-03'
2.8.20:
codename: How Many More Times
fragments:
- v2.8.20_summary.yaml
release_date: '2021-04-12'
2.8.20rc1:
codename: How Many More Times
fragments:
- 471-no_log.yml
- community.aws-475-no_log-missing.yml
- community.docker-103-docker_swarm-no_log.yml
- community.general-2018-missing-no_log-again.yml
- community.network-223-no_log-missing.yml
- more-no_log-fixes.yml
- v2.8.20rc1_summary.yaml
release_date: '2021-04-05'
2.8.3:
codename: How Many More Times
fragments:
- 41240-fix-os_quota-without-cinder.yaml
- 50617-vmware_guest-vapp_settings.yml
- 54790-fix-region-aws_secret-lookup.yaml
- 55194-ec2_eip-required_together.yml
- 56376-bootproto_dhcp_regression.yaml
- 56481-group-detect-duplicate-gids-local.yaml
- 57298-ovirt_vnic_remove_duplication_readme.yml
- 57351-role-custom-filter.yaml
- 57518-tower_role-fix_validate_certs.yml
- 57711-To_resolve_NoneType_error_in_aci_l3out.yaml
- 57907-update-ce_interface-to-fix-bugs.yml
- 57947-update-ce_vxlan_global-to-fix-bugs.yml
- 58060-vmware_guest-make_max_connections_work.yml
- 58136-ovirt_vm_migrate_with_state_present.yml
- 58200-update-ce_bfd_global-to-fix-a-bug.yml
- 58207-update-ce_bfd_view-to-fix-a-bug.yml
- 58226-update-ce_vxlan_gateway-to-fix-a-bug.yml
- 58227-update-cce_evpn_bd_vni-to-fix-a-bug.yml
- 58229-update-ce_interface_ospf-to-fix-a-bug.yml
- 58483-win_setup_resilience.yml
- 58554-update-ce_vrrp-to-fix-a-bug.yml
- 58559-update-ce_evpn_bgp_rr-to-fix-a-bug.yml
- 58561-update-ce_link_status-to-fix-a-bug.yml
- 58563-update-ce_netstream_aging-to-fix-a-bug.yml
- 58565-update-ce_static_route-to-fix-a-bug.yml
- 58569-nagios-fifo-fix.yaml
- 58577-ovirt_update_vm_migration_domunetation.yml
- 58579-vmware_object_role_perm_fix.yml
- 58605-openssl_privatekey-secp256r1.yml
- 58625-ovirt_add_host_retry_doc.yml
- 58734-correct-machinectl-become-plugin.yaml
- 58737-vmware_guest-fix_clone_guest.yml
- 58791-docker-errors.yml
- 58820-use-templated-loop_var-in-include_tasks.yaml
- 58949-nmcli-vlanid-typecast.yml
- 59043-docker_container-nocopy.yml
- 59072-update-ce_interface-to-fix-a-bug.yml
- 59190-vmware_guest-mem_reservation.yml
- 59196-ovirt_use_sysprep_when_needed.yml
- 59243-update-ce_file_copy-to-fix-a-bug.yml
- 59342_postgresql_schema-fix-example.yml
- 59377-ovirt-vm-when-creating-fix.yml
- ac_collection_plugin_load.yml
- become_none.yml
- dzdo_password_prompt.yml
- facts-linux-cpu-arm-architecture.yml
- fix_gathering_reporting.yml
- gather_subset_defaults.yml
- ios_command_edit_macro_dont_handle_no_macro.yaml
- ovirt_fetch_also_list_of_hrefs.yaml
- slxos_config_fix.yaml
- user-local-mode-group-append.yaml
- v2.8.3_summary.yaml
- win_domain_user-error.yaml
- win_get_url-proxy-not-used.yml
- win_reg_stat-hku.yaml
- yum-handle-stale-lock-file.yaml
- yum-sane-default-lockfile-timeout.yml
release_date: '2019-07-25'
2.8.4:
codename: How Many More Times
fragments:
- 46332-aws-improve-etag-handling.yml
- 49568-type-checking.yaml
- 49754-default-become-user-pbrun-become-plugin.yaml
- 55716-ec2_instance_int_volume_size.yml
- 56392-consul_session-improve_doc_and_add_integration_tests.yaml
- 56844-glusterfs_volume-fix_compare.yml
- 57579-add-pipelining-to-podman-connection-plugin.yaml
- 57935-ovirt-host-event-log.yml
- 57993-openssh_keypair-add-public-key-and-key-comment-validation.yml
- 58360-fix-cpu-count-ppc.yaml
- 58876-do-not-reuse-remote_user-from-prev-loop.yaml
- 59106-fix-ipv6-truncating-in-ec2_group.yml
- 59335-developing_modules_general-update_docs.yaml
- 59437-update-ce_ntp_auth-to-fix-a-bug.yml
- 59445-ce_rollback_shouldnt_load_xml_configure_via_network_cli.yml
- 59456-find-return-values.yaml
- 59497_postgresql-modules-remove-unused-imports.yml
- 59503-fix-recursive-csharp-logging.yml
- 59515-ce_mtu-update-to-fix-bugs.yml
- 59520-ce_startup-update-to-fix-a-bug.yml
- 59548-import-playbook-plugin-dirs.yml
- 59677-ce_vrrp-to-fix-bugs.yml
- 59678-ce_bgp_af-to-fix-bugs.yml
- 59684-ce_mlag_config-to-fix-bugs.yml
- 59685-ce_stp-to-fix-bugs.yml
- 59715-docker_container-ipv6-port-bind.yml
- 59728-ce_config-to-fix-bugs.yml
- 59769-fix_ansible_issue_58469_regression.yaml
- 59786-ce_netstream_global-to-fix-bugs.yml
- 59862-ovirt-vnic-profile-qos-update-fix.yml
- 60033-ce_netstream_template-to-fix-bugs.yml
- 60084-ce_ce_rollback_set_mmi-mode-enable.yaml
- 60085-ce_config _set_mmi-mode.yml
- 60105-postgresql_turn_off_db_default_warnings.yml
- 60198-ovirt-vnic-profile-check-fix.yml
- 60202-ovirt-host-update-force-docs.yml
- 60270-ce_aaa_server-to-fix-bugs.yml
- 60272-ce_aaa_server_host-to-fix-bugs.yml
- 60274-ce_acl-to-fix-bugs.yml
- adhoc-command-async-output.yaml
- aws_s3-etags.yaml
- dont_template_passwords_from_prompt.yml
- fix_iosxr_facts.yaml
- fix_strategy_inv_up.yml
- gcp-session-merge_dict.yml
- gcp_fixes.yml
- group-chars-ignore-doc.yaml
- netconf_command_timeout.yaml
- os_subnet-subnetpool-id-allowed.yaml
- podman_image-build-output-format.yaml
- sysctl-check-file-and-system.yaml
- user-local-warning-fix.yaml
- v2.8.4_summary.yaml
- vmware_datastore_facts_dict_iter.yml
- win_domain_group_membership-Fix-missing-vars-for-Get-command.yml
- win_dsc-datetime.yaml
- win_user-logon-err.yaml
release_date: '2019-08-15'
2.8.5:
codename: How Many More Times
fragments:
- 57096-netapp_e_lun_mapping-Fix-confict-and-zero-lun.yaml
- 57185-fix_vmware_modules_py_pre2.79.yaml
- 58194-vm-name-item-not-yet-present-at-creation-time.yaml
- 59471-systemd-wait-while-deactivating.yaml
- 59745-fix-pipelining-in-buildah-connection-plugin.yml
- 60381-docker_login-logout-change.yml
- 60410-search-project-in-domain.yml
- 60412-ce_bfd_global-to-fix-bugs.yml
- 60461-ovirt-vm-update-template-search-by-datacenter.yml
- 60581-ovirt-vm-add-linux-boot-param-warning.yml
- 60582-ovirt-vm-update-kernel-docs.yml
- 60616-support-multiple-port.yaml
- 60683-backport-57418.yaml
- 60727-acme_certificate-acme-compatibility.yml
- 60737-xenserver_guest-vbd-plug-fix.yml
- 60745-openssl_certificate-idempotency.yml
- 60912-constructed-groups-option-sanitization.yaml
- 60961-docker_compose-fix-deprecation-warning.yml
- 61231-extended-loop-include.yaml
- 61655-fix-digital-ocean-droplet-create.yaml
- 61735-wait-for-s3-bucket-to-exist-before-modifying.yaml
- 61740-docker_container-port-range-parsing.yml
- bigip-monitor-http-receive-parameter.yaml
- meraki-syslog-net-id.yaml
- meraki_syslog_net_id.yaml
- nxos_install_os_28_testfix.yaml
- openbsd-disabled-account-no-warning-for-passwd.yaml
- package_facts-performace-regression-fix.yaml
- purefa_facts-api-version-check-for-admin-and-all.yml
- user-docs-group-fix.yaml
- v2.8.5_summary.yaml
- win_domain-exceptions-2.yaml
- win_domain-exceptions.yaml
release_date: '2019-09-12'
2.8.6:
codename: How Many More Times
fragments:
- 55919-rabbitmq_publish-fix-for-recent-pika-versions.yml
- 57741-podman-connection-plugin-fix-mount.yaml
- 58756-fix_eos_bgp_fetching_as.yaml
- 58978-junos_user-fix-ssh-key-assignment.yaml
- 59450-ce_file_copy_different_version_sshserver_xml.yml
- 59765-cron-cronvar-use-get-bin-path.yaml
- 60569-plugins-netconf-ce.yml
- 60573-ce_bgp-to-fix-bugs.yml
- 60634-ce_bgp_neighbor-to-fix-bugs.yml
- 60937-ce_bgp_neighbor_af-to-fix-bugs.yml
- 61013-ce_evpn_bgp-to-fix-bugs.yml
- 61136-ce_evpn_bgp-to-fix-bugs.yml
- 61168-ce_evpn_bgp_rrl-to-fix-bugs.yml
- 61283-ce_info_center_global-to-fix-bugs.yml
- 61431-ce_interface_ospf-to-fix-bugs.yml
- 61442-ce_mtu-to-fix-bugs.yml
- 61652-ce_netstream_export-to-fix-bugs.yml
- 61653-ce_netstream_aging-to-fix-bugs.yml
- 61654-ce_ntp-to-fix-bugs.yml
- 61672-jenkins_modules-csrf-handling-in-versions-more-2.173.3.yaml
- 61683-ce_vrf_af-to-fix-bugs.yml
- 61684-ce_ospf-to-fix-bugs.yml
- 61693-acme-buypass-acme-v1.yml
- 61774-ce_stp-to-fix-bugs.yml
- 61842-ce_snmp_target_host-to-fix-bugs.yml
- 61843-ce_snmp_traps-to-fix-bugs.yml
- 61978-get-url-no-checksum.yml
- 61995-ce_vxlan_arp-to-fix-bugs.yml
- 61996-ce_vxlan_vap-to-fix-bugs.yml
- 62184-junos_user_encrypted_password_fix.yaml
- 62498-ce_static_route-to-fix-bugs.yml
- 62587-module_utils-network-cloudengine.yml
- 62589-ce_bgp_af-to-fix-bugs.yml
- 62621-docker_login-fix-60381.yaml
- 62790-openssl_certificate_fix_assert.yml
- 62809-dnf-wildcard-absent-failure.yml
- 62857-detect-freebsd-jails.yaml
- 62928-docker_container-ip-address-idempotency.yml
- 62971-docker_container-image-finding.yml
- 63194-lineinfile_insertafter_duplicate.yaml
- 63249-fix-sts-assume-role-test.yml
- 63331-ce_facts-to-fix-bugs.yml
- 63345-docker_image-deprecation-warnings.yml
- 63388_ce_netsream_list_index_out_of_range.yml
- 63418-docker_node_info-errors.yml
- 63422-ce_link_status_fix_bugs.yaml
- aci-42-filter-whitespace.yaml
- ansible-test-redact.yml
- ansible-test-ssh-keygen-fix.yml
- boto-logging-credentials.yml
- cron-only-get-bin-path-once.yaml
- cronvar-correct-binary-name.yaml
- debug_loop_changed.yaml
- display-warning-remove-erroneous-space.yaml
- dont-template-cli-passwords.yml
- firewalld-version-0_7_0.yml
- lookup_rabbitmq-is_closing-bug.yml
- mso_schema_template_bd-payload-fix.yaml
- no-log-sub-options-invalid-parameter.yaml
- package-facts-use-module-warnings.yaml
- package_facts_apt_fix.yml
- package_facts_clarify.yml
- psexec-kerb-and-interactive.yaml
- user-aix-shadow-unbound-local.yaml
- v2.8.6_summary.yaml
- vmware-use_non_default.yml
- win_exec-error.yaml
release_date: '2019-10-17'
2.8.7:
codename: How Many More Times
fragments:
- 56832-remove-aptitude-warning.yml
- 57804-win_acl-no-longer-needs-SeSecurityPrivilege.yml
- 58158-sysctl-fix-referenced-before-assignment.yaml
- 58323-copy-deep-recursive-with-remote_src.yaml
- 58525-zabbix-modules-logout.yml
- 59017-perf-regression-handlers.yml
- 60425-gitlab-fix-deprecation-warning.yml
- 62407-wait_for_connection.yml
- 62872-ce_config_too_many_quit_close_connection.yml
- 63140-acme-fix-fetch-url-status-codes.yaml
- 63432-openssl_csr-version.yml
- 63513-ce_action_wait_prompt_trigger_time_out.yaml
- 63522-remove-args-from-sumologic-and-splunk-callbacks.yml
- 63919-lineinfile-create-no-dir-path.yml
- 63984-openssl-ed25519-ed448.yml
- 64011_vmware_deploy_ovf.yml
- 64018-ce_acl_interface-to-fix-bugs.yml
- 64382-docker_login-fix-invalid-json.yml
- 64637-docker_swarm_service-tmpfs-source.yml
- ansible-test-rhel-8.1-testing.yml
- ansible_basic_no_log_empty_string.yaml
- lineinfile-backrefs-match-object-type.yaml
- lineinfile-use-correct-index-value.yaml
- paramiko_ssh-improve-error-message.yaml
- v2.8.7_summary.yaml
- vault-ensure-vault-password-files-are-list.yaml
- win_domain_computer-credential.yaml
- win_iis_website-restarted.yaml
- win_partition-var.yaml
release_date: '2019-11-13'
2.8.8:
codename: How Many More Times
fragments:
- 59887-scale-bug.yml
- 62348-yarn-no_version_install_fix.yml
- 63551-yum-single-YumBase-instantiation.yaml
- 63621-gitlab_user-fix-sshkey-and-user.yml
- 64397-netscaler_service-bugfix.yml
- 64648-acme_certificate-acmev1.yml
- 64902-fix-allow-duplicates-in-single-role.yml
- 64940_update_modules_docs_notes.yml
- 64941_update_modules_docs_notes.yml
- 64942_update_modules_docs_notes.yml
- 64943_update_modules_docs_notes.yml
- 64944_update_modules_docs_notes.yml
- 64945_update_modules_docs_notes.yml
- 65017-openssh_keypair-idempotence.yml
- 65018-docker-none-errors.yml
- 65065-plugins-netconf-ce-fix.yaml
- 65176-gitlab-runner-idempotency.yaml
- 65302-dnf-msg-return.yml
- 65435-openssl_csr-privatekey_path-required.yml
- 65839-docker_network-idempotence.yml
- 65854-docker_container-wait-for-removal.yml
- 65993-restart-docker_container-on-restart-policy-updates.yaml
- 66151-docker_swarm_service-healthcheck-start-period.yml
- ansible-test-coverage-constraint.yml
- ansible-test-ignore-pip-warnings.yml
- ansible-test-setuptools-constraint.yml
- fips-paramiko-import-error.yaml
- nxos_file_copy_path_issue.yml
- solaris_zone_name_fix.yml
- user-alpine-on-changed-fix.yaml
- v2.8.8_summary.yaml
- yum-enable-missing-repo.yaml
release_date: '2020-01-15'
2.8.9:
codename: How Many More Times
fragments:
- 62062-os_network-openstacksdk-min.yml
- 66914-purefa_user_string.yaml
- 66974-mysql_user_doesnt_support_privs_with_underscore.yml
- 67515-openssl-fingerprint-fips.yml
- ansible-test-constraints-virtualenv.yml
- ansible-test-jinja2-python-2.6.yml
- v2.8.9_summary.yaml
- win_unzip-paths.yaml
release_date: '2020-03-04'

View File

@ -5,6 +5,816 @@ Ansible 2.8 "How Many More Times" Release Notes
.. contents:: Topics
v2.8.20
=======
Release Summary
---------------
| Release Date: 2021-04-12
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Breaking Changes / Porting Guide
--------------------------------
- docker_swarm - if ``join_token`` is specified, a returned join token with the same value will be replaced by ``VALUE_SPECIFIED_IN_NO_LOG_PARAMETER``. Make sure that you do not blindly use the join tokens from the return value of this module when the module is invoked with ``join_token`` specified! This breaking change appears in a minor release since it is necessary to fix a security issue (https://github.com/ansible-collections/community.docker/pull/103). (CVE-2021-3447)
Security Fixes
--------------
- avi_cloudconnectoruser - mark the ``azure_userpass`` parameter as ``no_log`` to prevent leaking of secret values (https://github.com/ansible-collections/community.network/pull/223). (CVE-2021-3447)
- avi_sslkeyandcertificate - mark the ``enckey_base64`` parameter as ``no_log`` to prevent potential leaking of secret values (https://github.com/ansible-collections/community.network/pull/223). (CVE-2021-3447)
- avi_webhook - mark the ``verification_token`` parameter as ``no_log`` to prevent potential leaking of secret values (https://github.com/ansible-collections/community.network/pull/223). (CVE-2021-3447)
- aws_direct_connect_virtual_interface - mark the ``authentication_key`` parameter as ``no_log`` to avoid accidental leaking of secrets in logs (https://github.com/ansible-collections/community.aws/pull/475). (CVE-2021-3447)
- aws_secret - flag the ``secret`` parameter as containing sensitive data which shouldn't be logged (https://github.com/ansible-collections/community.aws/pull/471) (CVE-2021-3447).
- azure_rm_devtestlabartifactsource - ``security_token`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- bigip_device_license - ``license_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- bigip_dns_nameserver - ``tsig_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- bigip_dns_zone - ``tsig_server_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- bigip_profile_client_ssl - ``key`` and ``passphrase`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- docker_swarm - the ``join_token`` option is now marked as ``no_log`` so it is no longer written into logs (https://github.com/ansible-collections/community.docker/pull/103). (CVE-2021-3447)
- fortios_dlp_fp_doc_source - ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_endpoint_control_forticlient_ems - ``admin_password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_endpoint_control_profile - ``preshared_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_endpoint_control_settings - ``forticlient_reg_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_extender_controller_extender - ``aaa_shared_secret``, ``ha_shared_secret``, ``modem_passwd``, and ``ppp_password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_firewall_ssh_local_ca - ``password`` and ``private_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_firewall_ssh_local_key - ``password`` and ``private_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_log_disk_setting - ``uploadpass`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_router_bgp - ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_router_ospf - ``authentication_key`` and `md5_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_router_rip - ``auth_string`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_system_admin - ``fortitoken`` and ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_system_api_user - ``api_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_system_interface - ``password`` and ``pptp_password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_system_sdn_connector - ``access_key``, ``client_secret``, ``key_passwd``, ``password``, ``private_key``, and ``secret_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_system_virtual_wan_link - ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_user_radius - ``secret``, ``rsso_secret``, ``secondary_secret``, and ``tertiary_secret`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_user_tacacsplus - ``key``, ``secondary_key``, and ``tertiary_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_vpn_ipsec_manualkey - ``authkey`` and ``enckey`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_vpn_ipsec_manualkey_interface - ``auth_key`` and ``enc_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_vpn_ipsec_phase1 - ``authpasswd``, ``group_authentication_secret``, ``ppk_secret``, ``psksecret``, and ``psksecret_remote`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_vpn_ipsec_phase1_interface - ``authpasswd``, ``group_authentication_secret``, ``ppk_secret``, ``psksecret``, and ``psksecret_remote`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_vpn_ssl_web_portal - ``logon_password`` and ``sso_password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_wireless_controller_vap - ``captive_portal_macauth_radius_secret``, ``captive_portal_radius_secret``, ``key``, and ``passphrase`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_wireless_controller_wtp - ``login_passwd`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- fortios_wireless_controller_wtp_profile - ``fortipresence_secret`` and ``login_passwd`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- gcp_compute_instance - ``raw_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- gcp_container_cluster - ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- gcp_sql_instance - ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- ios_ntp - ``auth_key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- logentries_msg - ``token`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- na_cdot_user - mark the ``set_password`` parameter as ``no_log`` to avoid leakage of secrets (https://github.com/ansible-collections/community.general/pull/2018). (CVE-2021-3447)
- na_elementsw_cluster_snmp - ``password`` and ``passphrase`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- netscaler_lb_monitor - ``password`` and ``secondarypassword`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- nxos_aaa_server_host - ``key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- ovirt_auth - ``token`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- pingdom - ``key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- rollbar_deployment - ``token` no longer appears in logs (``no_log``) (CVE-2021-3447)
- stackdriver - ``key`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- sts_assume_role - mark the ``mfa_token`` parameter as ``no_log`` to avoid accidental leaking of secrets in logs (https://github.com/ansible-collections/community.aws/pull/475). (CVE-2021-3447)
- sts_session_token - mark the ``mfa_token`` parameter as ``no_log`` to avoid accidental leaking of secrets in logs (https://github.com/ansible-collections/community.aws/pull/475). (CVE-2021-3447)
- tower_credential - ``security_token`` and ``secret`` no longer appears in logs (``no_log``) (CVE-2021-3447)
- zabbix_action - ``password`` no longer appears in logs (``no_log``) (CVE-2021-3447)
v2.8.19
=======
Release Summary
---------------
| Release Date: 2021-02-17
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Security Fixes
--------------
- **security issue** - Mask default and fallback values for ``no_log`` module options (CVE-2021-20228)
- _sf_account_manager - `initiator_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- _sf_account_manager - `target_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- bitbucket_pipeline_variable - hide user sensitive information which are marked as ``secured`` from logging into the console (https://github.com/ansible-collections/community.general/pull/1635) (CVE-2021-20180).
- ce_vrrp - `auth_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- docker_swarm - `signing_ca_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_backend_service - `oauth2_client_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_disk - `disk_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_disk - `source_image_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_disk - `source_snapshot_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_image - `image_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_image - `source_disk_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_instance_template - `disk_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_instance_template - `source_image_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_region_disk - `disk_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_region_disk - `source_snapshot_encryption_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_ssl_certificate - `private_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_compute_vpn_tunnel - `shared_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gcp_sql_instance - `client_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- gitlab_runner - `registration_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- iap_start_workflow - `token_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- ibm_sa_host - `iscsi_chap_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- keycloak_client - `auth_client_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- keycloak_client - `registration_access_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- keycloak_clienttemplate - `auth_client_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- keycloak_group - `auth_client_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- librato_annotation - `api_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- na_elementsw_account - `initiator_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- na_elementsw_account - `target_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- netscaler_lb_monitor - `radkey` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- nios_nsgroup - `tsig_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- nxos_aaa_server - `global_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- nxos_pim_interface - `hello_auth_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- oneandone_firewall_policy - `auth_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- oneandone_load_balancer - `auth_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- oneandone_monitoring_policy - `auth_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- oneandone_private_network - `auth_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- oneandone_public_ip - `auth_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- ovirt - `instance_rootpw` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- pagerduty_alert - `api_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- pagerduty_alert - `integration_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- pagerduty_alert - `service_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- pulp_repo - `feed_client_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- rax_clb_ssl - `private_key` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- snmp_facts - hide user sensitive information such as ``privkey`` and ``authkey`` from logging into the console (https://github.com/ansible-collections/community.general/pull/1621) (CVE-2021-20178).
- spotinst_aws_elastigroup - `multai_token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- spotinst_aws_elastigroup - `token` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
- utm_proxy_auth_profile - `frontend_cookie_secret` is now masked with no_log and no longer emitted in logging/output (CVE-2021-20191).
Bugfixes
--------
- ansible-test - The ``--remote`` option has been updated for Python 2.7 to work around breaking changes in the newly released ``get-pip.py`` bootstrapper.
- ansible-test - The ``--remote`` option has been updated to use a versioned ``get-pip.py`` bootstrapper to avoid issues with future releases.
v2.8.18
=======
Release Summary
---------------
| Release Date: 2020-12-14
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ansible-test - Added the ``-remote rhel/7.9`` option to run tests on RHEL 7.9
- ansible-test - Fix container hostname/IP discovery for the ``acme`` test plugin.
- ansible-test - centos6 end of life - container image updated to point to vault base repository (https://github.com/ansible/distro-test-containers/pull/54)
Bugfixes
--------
- account for bug in Python 2.6 that occurs during interpreter shutdown to avoid stack trace
- ansible-test - Correctly detect changes in a GitHub pull request when running on Azure Pipelines.
- ansible-test - add constraint for ``cffi`` to prevent failure on systems with older versions of ``gcc`` (https://foss.heptapod.net/pypy/cffi/-/issues/480)
v2.8.17
=======
Release Summary
---------------
| Release Date: 2020-11-02
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ansible-test - Add a ``--docker-network`` option to choose the network for running containers when using the ``--docker`` option.
Breaking Changes / Porting Guide
--------------------------------
- ansible-galaxy login command has been removed (see https://github.com/ansible/ansible/issues/71560)
Bugfixes
--------
- ansible-test - Always connect additional Docker containers to the network used by the current container (if any).
- ansible-test - Always map ``/var/run/docker.sock`` into test containers created by the ``--docker`` option if the docker host is not ``localhost``.
- ansible-test - Attempt to detect the Docker hostname instead of assuming ``localhost``.
- ansible-test - Correctly detect running in a Docker container on Azure Pipelines.
- ansible-test - Prefer container IP at ``.NetworkSettings.Networks.{NetworkName}.IPAddress`` over ``.NetworkSettings.IPAddress``.
- ansible-test - The ``cs`` and ``openshift`` test plugins now search for containers on the current network instead of assuming the ``bridge`` network.
- ansible-test - Using the ``--remote`` option on Azure Pipelines now works from a job running in a container.
- kubectl - follow up fix in _build_exec_cmd API (https://github.com/ansible/ansible/issues/72171).
v2.8.16
=======
Release Summary
---------------
| Release Date: 2020-10-05
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ansible-test - Added CI provider support for Azure Pipelines.
- ansible-test - Added support for Ansible Core CI request signing for Shippable.
- ansible-test - Allow custom ``--remote-stage`` options for development and testing.
- ansible-test - Refactored CI related logic into a basic provider abstraction.
- ansible-test - Remove the discontinued ``us-east-2`` choice from the ``--remote-aws-region`` option.
- ansible-test - Request remote resources by provider name for all provider types.
- ansible-test - Show a warning when the obsolete ``--remote-aws-region`` option is used.
- ansible-test - Support custom remote endpoints with the ``--remote-endpoint`` option.
- ansible-test - Update built-in service endpoints for the ``--remote`` option.
- ansible-test - Use new endpoint for Parallels based instances with the ``--remote`` option.
Security Fixes
--------------
- kubectl - connection plugin now redact kubectl_token and kubectl_password in console log (https://github.com/ansible-collections/community.kubernetes/issues/65) (CVE-2020-1753).
Bugfixes
--------
- ansible-test - Change classification using ``--changed`` now consistently handles common configuration files for supported CI providers.
- ansible-test - Disabled the ``duplicate-code`` and ``cyclic-import`` checks for the ``pylint`` sanity test due to inconsistent results.
- ansible-test - The ``resource_prefix`` variable provided to tests running on Azure Pipelines is now converted to lowercase to match other CI providers.
- ansible-test - for local change detection, allow to specify branch to compare to with ``--base-branch`` for all types of tests (https://github.com/ansible/ansible/pull/69508).
v2.8.15
=======
Release Summary
---------------
| Release Date: 2020-08-31
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Security Fixes
--------------
- The fix for CVE-2020-1736 has been reverted. Users are encouraged to specify a ``mode`` parameter in their file-based tasks when the files being manipulated contain sensitive data.
- dnf - Previously, regardless of the ``disable_gpg_check`` option, packages were not GPG validated. They are now. (CVE-2020-14365)
v2.8.14
=======
Release Summary
---------------
| Release Date: 2020-08-10
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- debconf - add a note about no_log=True since module might expose sensitive information to logs (https://github.com/ansible/ansible/issues/32386).
Security Fixes
--------------
- **security issue** - copy - Redact the value of the no_log 'content' parameter in the result's invocation.module_args in check mode. Previously when used with check mode and with '-vvv', the module would not censor the content if a change would be made to the destination path. (CVE-2020-14332)
- **security issue** atomic_move - change default permissions when creating temporary files so they are not world readable (https://github.com/ansible/ansible/issues/67794) (CVE-2020-1736)
- Fix warning for default permission change when no mode is specified. Follow up to https://github.com/ansible/ansible/issues/67794. (CVE-2020-1736)
- Sanitize no_log values from any response keys that might be returned from the uri module (CVE-2020-14330).
Bugfixes
--------
- Address compat with rpmfluff-0.6 for integration tests
- add constraints file for ``anisble_runner`` test since an update to ``psutil`` is now causing test failures
v2.8.13
=======
Release Summary
---------------
| Release Date: 2020-07-14
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- Remove the deprecation message for the ``TRANSFORM_INVALID_GROUP_CHARS`` setting. (https://github.com/ansible/ansible/issues/61889)
- pipe lookup - update docs for Popen with shell=True usages (https://github.com/ansible/ansible/issues/70159).
Bugfixes
--------
- yum - fix bug that caused ``enablerepo`` to not be honored when used with disablerepo all wildcard/glob (https://github.com/ansible/ansible/issues/66549)
v2.8.12
=======
Release Summary
---------------
| Release Date: 2020-05-11
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- Point inventory script location to their respective version rather than devel version in documentation.
- ansible-test - Now includes testing support for RHEL 8.2
Bugfixes
--------
- dnf - Unified error messages when trying to install a nonexistent package with newer dnf (4.2.18) vs older dnf (4.2.9)
- dnf - Unified error messages when trying to remove a wildcard name that is not currently installed, with newer dnf (4.2.18) vs older dnf (4.2.9)
- mysql_user - fix the error No database selected (https://github.com/ansible/ansible/issues/68070).
- pip - check_mode with ``state: present`` now returns the correct state for pre-release versioned packages
- redfish_config - fix support for boolean bios attrs (https://github.com/ansible/ansible/pull/68251)
- win_psmodule - Fix TLS 1.2 compatibility with PSGallery.
- win_psrepository - Fix TLS 1.2 compatibility with PSGallery.
- win_psrepository - Fix ``Ignore`` error when trying to retrieve the list of registered repositories
v2.8.11
=======
Release Summary
---------------
| Release Date: 2020-04-16
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ansible-test - Upgrade OpenSUSE containers to use Leap 15.1.
- ansible-test now supports testing against RHEL 7.8 when using the ``--remote`` option.
Removed Features (previously deprecated)
----------------------------------------
- ldap_attr, ldap_entry - The ``params`` option has been removed in Ansible-2.10 as it circumvents Ansible's option handling. Setting ``bind_pw`` with the ``params`` option was disallowed in Ansible-2.7, 2.8, and 2.9 as it was insecure. For information about this policy, see the discussion at: https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html This fixes CVE-2020-1746
Security Fixes
--------------
- **security issue** - The ``subversion`` module provided the password via the svn command line option ``--password`` and can be retrieved from the host's /proc/<pid>/cmdline file. Update the module to use the secure ``--password-from-stdin`` option instead, and add a warning in the module and in the documentation if svn version is too old to support it. (CVE-2020-1739)
- **security issue** win_unzip - normalize paths in archive to ensure extracted files do not escape from the target directory (CVE-2020-1737)
- **security_issue** - create temporary vault file with strict permissions when editing and prevent race condition (CVE-2020-1740)
- Ensure we get an error when creating a remote tmp if it already exists. CVE-2020-1733
- In fetch action, avoid using slurp return to set up dest, also ensure no dir traversal CVE-2020-1735.
Bugfixes
--------
- Ensure DataLoader temp files are removed at appropriate times and that we observe the LOCAL_TMP setting.
- Ensure we don't allow ansible_facts subkey of ansible_facts to override top level, also fix 'deprefixing' to prevent key transforms.
- Fact Delegation - Add ability to indicate which facts must always be delegated. Primarily for ``discovered_interpreter_python`` right now, but extensible later. (https://github.com/ansible/ansible/issues/61002)
- acl - fixed module failure if there are spaces in a path
v2.8.10
=======
Release Summary
---------------
| Release Date: 2020-03-05
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Bugfixes
--------
- Fix ``TypeError`` in OpenStack modules introduced in Ansible 2.8.9 (https://github.com/ansible/ansible/pull/68043).
v2.8.9
======
Release Summary
---------------
| Release Date: 2020-03-04
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Bugfixes
--------
- Bump the minimum openstacksdk version to 0.18.0 when os_network uses the port_security_enabled argument.
- ansible-test - Use ``virtualenv`` versions before 20 on provisioned macOS instances to remain compatible with an older pip install.
- ansible-test now limits Jinja2 installs to version 2.10 and earlier on Python 2.6
- mysql_user - fix support privileges with underscore (https://github.com/ansible/ansible/issues/66974).
- openssl_* modules - prevent crash on fingerprint determination in FIPS mode (https://github.com/ansible/ansible/issues/67213).
- pure - fix incorrect user_string setting in module_utils file (https://github.com/ansible/ansible/pull/66914)
- win_unzip - Fix support for paths with square brackets not being detected properly
v2.8.8
======
Release Summary
---------------
| Release Date: 2020-01-15
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- docker_container.py - update a containers restart_policy without restarting the container (https://github.com/ansible/ansible/issues/65993)
Bugfixes
--------
- **SECURITY** - CVE-2019-14904 - solaris_zone module accepts zone name and performs actions related to that. However, there is no user input validation done while performing actions. A malicious user could provide a crafted zone name which allows executing commands into the server manipulating the module behaviour. Adding user input validation as per Solaris Zone documentation fixes this issue.
- CVE-2019-14905 - nxos_file_copy module accepts remote_file parameter which is used for destination name and performs actions related to that on the device using the value of remote_file which is of string type However, there is no user input validation done while performing actions. A malicious code could crafts the filename parameter to take advantage by performing an OS command injection. This fix validates the option value if it is legitimate file path or not.
- acme_certificate - fix misbehavior when ACME v1 is used with ``modify_account`` set to ``false``.
- ansible-test no longer tries to install ``coverage`` 5.0+ since those versions are unsupported
- ansible-test no longer tries to install ``setuptools`` 45+ on Python 2.x since those versions are unsupported
- ansible-test now ignores warnings when comparing pip versions before and after integration tests run
- ce modules - Update(add) docs notes to tell user modules work connection.
- ce modules - Update(add) docs notes to tell user modules work connection.
- ce modules - Update(add) docs notes to tell user modules work connection.
- ce modules - Update(add) docs notes to tell user modules work connection.
- ce modules - Update(add) docs notes to tell user modules work connection.
- ce modules - Update(add) docs notes to tell user modules work connection.
- decouple k8s_scale from the k8s module utils so that it doesn't complain about missing arguments
- dnf module - Ensure the modules exit_json['msg'] response is always string, not sometimes a tuple.
- docker_container - fix network idempotence comparison error.
- docker_container - wait for removal of container if docker API returns early (https://github.com/ansible/ansible/issues/65811).
- docker_network - fix idempotence comparison error.
- docker_network - fix idempotency for multiple IPAM configs of the same IP version (https://github.com/ansible/ansible/issues/65815).
- docker_network - validate IPAM config subnet CIDR notation on module setup and not during idempotence checking.
- docker_swarm_service - fix task always reporting as changed when using ``healthcheck.start_period``.
- gitlab_runner - fix idempotency for shared runner
- gitlab_user - Fix adding ssh key to new/changed user and adding group membership for new/changed user
- netscaler_service - fixed issue preventing use of graceful attribute
- openssh_keypair - fixes idempotence issue with public key (https://github.com/ansible/ansible/issues/64969).
- openssl_csr - the module will now enforce that ``privatekey_path`` is specified when ``state=present``.
- paramiko - catch and handle exception to prevent stack trace when running in FIPS mode
- plugins-netconf-ce - Fix failed to get version information.
- roles - Ensure that ``allow_duplicates: true`` enables to run single role multiple times (https://github.com/ansible/ansible/issues/64902)
- user - on systems using busybox, honor the ``on_changed`` parameter to prevent unnecessary password changing (https://github.com/ansible/ansible/issues/65711)
- yarn - handle no version when installing module by name (https://github.com/ansible/ansible/issues/55097)
- yum - gracefully handle failure case of enabling a non existent repo, as the yum cli does (Fixes https://github.com/ansible/ansible/issues/52582)
- yum - performance bugfix, the YumBase object was being instantiated multiple times unnecessarily, which lead to considerable overhead when operating against large sets of packages.
v2.8.7
======
Release Summary
---------------
| Release Date: 2019-11-13
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ansible-test - switch from testing RHEL 8.0 and RHEL 8.1 Beta to RHEL 8.1
Bugfixes
--------
- **security issue** - Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs (CVE-2019-14864)
- ACME modules: make sure some connection errors are handled properly
- Ansible.Basic - Fix issue when setting a ``no_log`` parameter to an empty string - https://github.com/ansible/ansible/issues/62613
- Fix deprecation warning on GitLab modules
- Fix for performance regression in handler invocation (https://github.com/ansible/ansible/issues/59017)
- Fix requirements on non required module parameters
- Remove a temp directory created by wait_for_connection action plugin (https://github.com/ansible/ansible/issues/62407).
- Remove the unnecessary warning about aptitude not being installed (https://github.com/ansible/ansible/issues/56832).
- action/ce - fix a bug, some new version os will not discard uncommitted configure with a return directly.(https://github.com/ansible/ansible/pull/63513).
- ansible-vault - fix error when multiple vault password files are specified (https://github.com/ansible/ansible/issues/57172)
- ce_acl_interface - update to fix some bugs - Modified the prompt statement when the switch device cannot be configured. (https://github.com/ansible/ansible/pull/64018)
- ce_config - fixed issue - Re-building commands(config src) by replacing '#' with 'quit','quit' commands may close connection (https://github.com/ansible/ansible/issues/62872)
- copy - recursive copy with ``remote_src=yes`` now recurses beyond first level. (Fixes https://github.com/ansible/ansible/issues/58284)
- docker_login - Use ``with`` statement when accessing files, to prevent that invalid JSON output is produced.
- docker_swarm_service - ``source`` must no longer be specified for ``tmpfs`` mounts.
- lineinfile - don't attempt mkdirs when path doesn't contain directory path
- lineinfile - properly handle inserting a line when backrefs are enabled and the line already exists in the file (https://github.com/ansible/ansible/issues/63756)
- lineinfile - use correct index value when inserting a line at the end of a file (https://github.com/ansible/ansible/issues/63684)
- openssl_certificate and openssl_csr - fix Ed25519 and Ed448 private key support for ``cryptography`` backend. This probably needs at least cryptography 2.8, since older versions have problems with signing certificates or CSRs with such keys. (https://github.com/ansible/ansible/issues/59039, PR https://github.com/ansible/ansible/pull/63984)
- openssl_csr - a warning is issued if an unsupported value for ``version`` is used for the ``cryptography`` backend.
- paramiko_ssh - improve authentication error message so it is less confusing
- sysctl - fix err referenced before assignment (https://github.com/ansible/ansible/issues/58158)
- vmware_deploy_ovf - backport content fix from 2.9 (https://github.com/ansible/ansible/pull/59614)
- win_acl - Fixed error when setting rights on directory for which inheritance from parent directory has been disabled.
- win_domain_computer - Honour the explicit domain server and credentials when moving or removing a computer object - https://github.com/ansible/ansible/pull/63093
- win_iis_website - Actually restart the site when ``state=restarted`` - https://github.com/ansible/ansible/issues/63828
- win_partition - Fix invalid variable name causing a failure on checks - https://github.com/ansible/ansible/issues/62401
- zabbix_* modules - modules will now properly disconnect existing sessions from Zabbix server (see https://github.com/ansible/ansible/pull/58525)
v2.8.6
======
Release Summary
---------------
| Release Date: 2019-10-17
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ansible-test defaults to redacting sensitive values (disable with the ``--no-redact`` option)
- dnf - Properly handle idempotent transactions with package name wildcard globs (https://github.com/ansible/ansible/issues/62809)
Security Fixes
--------------
- **security issue** - Convert CLI provided passwords to text initially, to prevent unsafe context being lost when converting from bytes->text during post processing of PlayContext. This prevents CLI provided passwords from being incorrectly templated (CVE-2019-14856)
- **security issue** - properly hide parameters marked with ``no_log`` in suboptions when invalid parameters are passed to the module (CVE-2019-14858)
Bugfixes
--------
- **SECURITY** - CVE-2019-14846 - Several Ansible plugins could disclose aws credentials in log files. inventory/aws_ec2.py, inventory/aws_rds.py, lookup/aws_account_attribute.py, and lookup/aws_secret.py, lookup/aws_ssm.py use the boto3 library from the Ansible process. The boto3 library logs credentials at log level DEBUG. If Ansible's logging was enabled (by setting LOG_PATH to a value) Ansible would set the global log level to DEBUG. This was inherited by boto and would then log boto credentials to the file specified by LOG_PATH. This did not affect aws ansible modules as those are executed in a separate process. This has been fixed by switching to log level INFO
- ACI modules - Fix a whitespace issue in filters for ACI 4.2 strict validation
- ACME modules: fix bug in ACME v1 account update code
- ACME modules: support Buypass' ACME v1 endpoint
- Cloudengine module_utils - the ``set-id`` (RPC-REPLY XML attribute) may change over the time althougth ``set-id`` is the identity of the next RPC packet.
- Cloudengine netconf plugin - add a dispatch RPC function,just return original RPC-REPLY, the function is used by ``Cloudengine module_utils``.
- For package_facts, correct information about apt being missing and fix missing attribute.
- ansible-podman connection plugin - Fix case when mount of podman container fails and files can't be copied to/from container. Also add error handling in case of failed podman commands. (https://github.com/ansible/ansible/issues/57740)
- ansible-test now updates SSH keys it generates with newer versions of ssh-keygen to function with Paramiko
- ce_bgp - update to fix some bugs - When the vrf_name parameter is in the module and the configuration is repeatedly sent to the device, the module displays change = True. (https://github.com/ansible/ansible/pull/60573)
- ce_bgp_af - update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/62589)
- ce_bgp_neighbor - update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/60934)
- ce_bgp_neighbor_af - update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/60937)
- ce_evpn_bgp - update to fix some bugs - Modify the configured query statement and replace get_config with exec_command. (https://github.com/ansible/ansible/pull/61136)
- ce_evpn_bgp_rr - update to fix some bugs - Modify the configured query statement and replace get_config with exec_command. (https://github.com/ansible/ansible/pull/61168)
- ce_evpn_global - update to fix some bugs - Modify the configured query statement and replace get_config with exec_command. (https://github.com/ansible/ansible/pull/61013)
- ce_facts - update to fix some bugs - Modifying regular expression errors. (https://github.com/ansible/ansible/pull/63331)
- ce_file_copy - update to Compatible with multiple version of NETCONF API(sshServer). (https://github.com/ansible/ansible/pull/59450)
- ce_info_center_global- update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/61283)
- ce_interface_ospf- update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/61431)
- ce_link_status - fix some bugs, result of interface <get> operation involves a large amount of data,interact with the device through the <get-next>.(https://github.com/ansible/ansible/pull/62417).
- ce_mtu- update to fix some bugs - Contrast before and after adding configuration. (https://github.com/ansible/ansible/pull/61442)
- ce_netstream_aging - Fix bugs(list index out of range).
- ce_netstream_aging- update to fix some bugs - Modify the configured query statement and replace get_config with exec_command. (https://github.com/ansible/ansible/pull/61653)
- ce_netstream_export- update to fix some bugs - Modify the configured query statement and replace get_config with exec_command. (https://github.com/ansible/ansible/pull/61652)
- ce_netstream_global - Fix bugs(list index out of range and key error).
- ce_netstream_template - Fix bugs(list index out of range and update commands error).
- ce_ntp - update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/61654)
- ce_ospf - update to fix some bugs - Contrast before and after adding configuration. (https://github.com/ansible/ansible/pull/61684)
- ce_snmp_target_host - update to fix some bugs - Contrast before and after adding configuration. (https://github.com/ansible/ansible/pull/61842)
- ce_snmp_traps - update to fix some bugs - Contrast before and after adding configuration. (https://github.com/ansible/ansible/pull/61843)
- ce_static_route - update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/62498)
- ce_stp - update to fix some bugs - Modify the configured query statement and replace get_config with exec_command. (https://github.com/ansible/ansible/pull/61774)
- ce_vrf_af - update to fix some bugs - Add some update statements. (https://github.com/ansible/ansible/pull/61683)
- ce_vxlan_arp - update to fix some bugs - Modifying regular expressions. (https://github.com/ansible/ansible/pull/61995)
- ce_vxlan_vap - update to fix some bugs - Modify the Operator Difference between Python 2 and Python 3. (https://github.com/ansible/ansible/pull/61996)
- clarify error messages for 'auto' and missing libs, add missing lib msg for rpm.
- cron and cronvar - use get_bin_path utility to locate the default crontab executable instead of the hardcoded /usr/bin/crontab. (https://github.com/ansible/ansible/pull/59765)
- cron cronvar - only run ``get_bin_path()`` once
- cronvar - use correct binary name (https://github.com/ansible/ansible/issues/63274)
- debug - fixed an issue introduced in Ansible 2.4 where a loop of debug tasks would lose the "changed" status on each item.
- display - remove leading space when displaying WARNING messages
- docker_container - fix idempotency for IP addresses for networks. The old implementation checked the effective IP addresses assigned by the Docker daemon, and not the specified ones. This causes idempotency issues for containers which are not running, since they have no effective IP addresses assigned.
- docker_container - make sure that when image is missing, check mode indicates a change (image will be pulled).
- docker_image - make sure that deprecated options also emit proper deprecation warnings next to warnings which indicate how to replace them.
- docker_login - correct broken fix for https://github.com/ansible/ansible/pull/60381 which crashes for Python 3.
- docker_node_info - improve error handling when service inspection fails, for example because node name being ambiguous (https://github.com/ansible/ansible/issues/63353, PR https://github.com/ansible/ansible/pull/63418).
- eos_bgp - Fix fetching AS failure if BGP is not already configured (https://github.com/ansible/ansible/pull/58756)
- facts/virtual
- firewalld - enable the firewalld module to function offline with firewalld version 0.7.0 and newer (https://github.com/ansible/ansible/issues/63254)
- get_url - Don't treat no checksum as a checksum match (https://github.com/ansible/ansible/issues/61978)
- jenkins modules - CSRF handling fixed accordingly the latest updates in Jenkins Security model for versions > 2.173.3
- junos_user - Add no_log=True to junos_user `encrypted_password` (https://github.com/ansible/ansible/pull/62184)
- junos_user - fixed issue with adding multiple values for a Junos account with aggregate mode
- lineinfile - fix bug that caused multiple line insertions (https://github.com/ansible/ansible/issues/58923).
- mso_schema_template_bd - Fix incorrect payload when setting intersiteBUMTrafficAllow.
- openssl_certificate - fix ``assertonly`` provider certificate verification, causing 'private key mismatch' and 'subject mismatch' errors.
- package_facts - use module warnings rather than a custom implementation for reporting warnings
- plugins-netconf-ce - to get attribute 'set-id' from rpc-reply.
- psexec - Fix issue where the Kerberos package was not detected as being available.
- psexec - Fix issue where the ``interactive`` option was not being passed down to the library.
- rabbitmq lookup plugin - Fix for rabbitmq lookups failing when using pika v1.0.0 and newer.
- rabbitmq_publish - Fix to ensure the module works correctly for pika v1.0.0 and later. (https://github.com/ansible/ansible/pull/61960)
- sts_assume_role - fix assertion text in integration test
- user - fix stack trace on AIX when attempting to parse shadow file that does not exist (https://github.com/ansible/ansible/issues/62510)
- vmware_deploy_ovf use user specified resource pool or resource pool pod rather than cluster default (https://github.com/ansible/ansible/issues/61645).
- win_exec_wrapper - Be more defensive when it comes to getting unhandled exceptions
v2.8.5
======
Release Summary
---------------
| Release Date: 2019-09-12
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- ovirt_vm - add documentation warning about linux boot params - they will not be suported since oVirt 4.4 (https://bugzilla.redhat.com/1732437)
- ovirt_vm - add warning message about linux boot params - they will not be suported since oVirt 4.4 (https://bugzilla.redhat.com/1732437)
Bugfixes
--------
- Backported to stable-2.8 - Fix
- Extended loop variables now work with includes (https://github.com/ansible/ansible/pull/61231)
- Fix nxos_install_os test cases typo (https://github.com/ansible/ansible/pull/58825).
- Pipelining now works with the buildah plugin.
- acme_certificate - improve compatibility when finalizing ACME v2 orders. Fixes problem with Buypass' ACME v2 testing endpoint.
- apt_facts - fix performance regression when getting facts about apt packages (https://github.com/ansible/ansible/issues/60450)
- aws_s3 - Try to wait for the bucket to exist before setting the access control list.
- bigip_monitor_http - fix issue with receive parameter idempotency (https://github.com/ansible/ansible/pull/59999)
- ce_bfd_global - update to fix some bugs - When BFD is unavailable, tosExp and other parameters are sent down to report errors; this error is corrected and the query results are processed again. (https://github.com/ansible/ansible/pull/60412)
- constructed - Add a warning for the change in behavior in the sanitization of the groups option.
- digital_ocean_droplet - Fix creation of DigitalOcean droplets using digital_ocean_droplet module (https://github.com/ansible/ansible/pull/61655)
- docker_compose - fix issue where docker deprecation warning results in ansible erroneously reporting a failure
- docker_container - improve error behavior when parsing port ranges fails.
- docker_login - report change on successful logout (https://github.com/ansible/ansible/issues/59232)
- docker_swarm_service - allow the same port to be published both with TCP and UDP.
- meraki_syslog - Module would ignore net_id parameter if passed.
- meraki_syslog - Properly handle tasks with `net_id` instead of `net_name`.
- netapp_e_lun_mapping - Fix hosts with same lun number conflict in netapp_e_lun_mapping
- netapp_e_lun_mapping - Fix netapp_e_host module bug when lun=0
- openssl_certificate - if both private key and CSR were specified, the idempotency check for ``selfsigned`` and ``ownca`` providers ignored the CSR.
- os_user - when domain is provided, default_project will be taken from this domain.
- ovirt_vm - update tempalte search by datacenter (https://github.com/ansible/ansible/issues/59189)
- proxmox_kvm - fixed issue when vm has not yet a name item (https://github.com/ansible/ansible/issues/58194)
- purefa_facts - Fix bug which causes module failure when selecting I(admins) or I(all) against an old Purity version
- systemd - wait for a service which is in deactivating state when using ``state=stopped`` (https://github.com/ansible/ansible/pull/59471)
- user - allow 13 asterisk characters in password field without warning
- user - update docs to reflect proper way to remove account from all groups
- vmware - Ensure we can use the modules with Python < 2.7.9 or RHEL/CentOS < 7.4, this as soon as ``validate_certs`` is disabled.
- win_domain - Set reboot required dependent on exception and add exception id to error message
- win_domain_controller - Do not fail the play without the user being able to catch dcpromo failing because of a pending reboot within a playbook using ignore_error or retry logic.
- xenserver_guest - when adding disks to a VM in powered on state, disks are now properly plugged/activated (https://github.com/ansible/ansible/issues/60693).
v2.8.4
======
Release Summary
---------------
| Release Date: 2019-08-15
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- Correct the return values of matched and examined from string to int
- Fix call from "merge_dictionaries" to "_merge_dictionaries" in GcpSession object (https://github.com/ansible/ansible/issues/57140).
- Fixes comparison of list to integer in gluster_volume (https://github.com/ansible/ansible/issues/56844).
- The `podman` connection plugin now supports pipelining.
- With Python3, we cannot iterate on a dict and modify it at the same time (https://github.com/ansible/ansible/issues/54869).
- ovirt_host - update force parameter documentation (https://bugzilla.redhat.com/show_bug.cgi?id=1719271#c11)
- remove ambiguity in module naming; use "my_test" as module name
Bugfixes
--------
- Add no_log to credentials field to avoid disclosures (CVE-2019-10217)
- Do not re-use remote_user from previous loop iteration (https://github.com/ansible/ansible/issues/58876)
- Fix netconf connection command timeout issue (https://github.com/ansible/ansible/pull/58322)
- Fix strategy functions that update inventory and back 'add_host' and 'group_by' actions.
- Fixed issue where `ansible_net_model` was not being populated in iosxr_facts (https://github.com/ansible/ansible/pull/58488)
- ansible.basics - fix core C# recursive call when logging fails (e.g. if insufficient permissions are held) (https://github.com/ansible/ansible/pull/59503)
- async - Fix async callback plugins to allow async output to be displayed when running command/shell (https://github.com/ansible/ansible/issues/15988)
- aws_s3 - Improve usability when the execution host lacks MD5 support (e.g. due to FIPS-140-2).
- aws_s3 module - Improve ETag calculation, allow overwrite=always to work on FIPS-140-2
- ce_aaa_server - update to fix some bugs - When you want to delete a parameter, a conflict will occur, causing the download configuration to fail. (https://github.com/ansible/ansible/pull/60270)
- ce_aaa_server_host - update to fix some bugs - module CMD update in ansible is inconsistent with switch; when parameter is bool type, it is impossible to judge the value of expensive parameter. (https://github.com/ansible/ansible/pull/60272)
- ce_acl - update to fix some bugs - When the frag_type parameter is in the module and the configuration is repeatedly sent to the device, the module displays change = True. (https://github.com/ansible/ansible/pull/60274)
- ce_bgp_af - update to fix some bugs - XML query result error, update_cmds statement missing. (https://github.com/ansible/ansible/pull/59678)
- ce_config - It is also necessary to undo mmi-mode enable after running commands.Otherwise it will make a effect to next tasks.(https://github.com/ansible/ansible/pull/60071).
- ce_config - Optimize multi-level views & fix a bug. (https://github.com/ansible/ansible/pull/59523)
- ce_mlag_config - update to fix some bugs - Configuration does not absent as expect. (https://github.com/ansible/ansible/pull/59336)
- ce_mtu - bug-info - unable to parse request, to fix the bug (https://github.com/ansible/ansible/pull/59343)
- ce_netstream_global - The 'get_config', which is from 'ansible.module_utils.network.cloudengine.ce', try to return the result from cache,however the configure has changed. (https://github.com/ansible/ansible/pull/59689)
- ce_netstream_global - The 'get_config', which is from 'ansible.module_utils.network.cloudengine.ce', try to return the result from cache,however the configure has changed. (https://github.com/ansible/ansible/pull/59690)
- ce_ntp_auth - update to fix "state is present but all of the following are missing-password" bug(https://github.com/ansible/ansible/pull/59344)
- ce_rollback - set mmi-mode enable to run commands and unset after running(https://github.com/ansible/ansible/pull/60075).
- ce_rollback - shouldn't load xml configure via network_cli(https://github.com/ansible/ansible/pull/59345)
- ce_startup - update to fix a bug - netconf and cli are all used to load configure at a time (https://github.com/ansible/ansible/pull/59346 )
- ce_stp - update to fix some bugs - The config of first time showing is same as second because of 'get_config', using regular to search & show config (https://github.com/ansible/ansible/pull/59347 )
- ce_vrrp - update to fix some bugs - Solving the mistake of parameter judgment, update_cmds statement missing. (https://github.com/ansible/ansible/pull/59677)
- consul_session - ``state`` parameter: use ``required_if``, document ``id`` parameter, update ``name`` parameter documentation
- docker_container - fix port bindings with IPv6 addresses.
- documented ``ignore`` option for ``TRANSFORM_INVALID_GROUP_CHARS``
- ec2_group - Don't truncate the host bits off of IPv6 CIDRs. CIDRs will be passed thru to EC2 as-is provided they are valid IPv6 representations. (https://github.com/ansible/ansible/issues/53297)
- ec2_instance - Ensures ``ebs.volume_size`` and ``ebs.iops`` are ``int`` to avoid issues with Jinja2 templating
- facts - fixed double-counting of CPUs on POWER systems
- group - The group module errored of if the gid exists with the same group name. This prevents reruns of the playbook. This fixes a regression introduced by 4898b0a.
- nagios - Removed redundant type check which caused crashes. Guardrails added elsewhere in earlier change.
- openssh_keypair - add public key and key comment validation on change
- os_subnet - it is valid to specify an explicit ``subnetpool_id`` rather than ``use_default_subnetpool`` or ``cidr``
- ovirt_host - add event log on failure (https://github.com/oVirt/ovirt-ansible-infra/issues/8)
- ovirt_vnic_profile - fix for updating vnic profile (https://github.com/ansible/ansible/pull/56518)
- ovirt_vnic_profile - update qos and pass_through logic (https://bugzilla.redhat.com/show_bug.cgi?id=1597537)
- pbrun - add default user for become plugin (https://github.com/ansible/ansible/pull/59754)
- plugin loader - Restore adding plugin loader playbook dir to ``Playbook`` in addition to ``PlaybookCLI`` to solve sub directory playbook relative plugins to be located (https://github.com/ansible/ansible/issues/59548)
- podman_image - handle new output format for image build
- postgresql_db.py - Fix code formatting (https://github.com/ansible/ansible/pull/59497)
- postgresql_ext.py - Remove pg_quote_identifier unused import (https://github.com/ansible/ansible/pull/59497)
- postgresql_lang.py - Remove pg_quote_identifier and to_native unused imports (https://github.com/ansible/ansible/pull/59497)
- postgresql_membership - turn off the default database warning (https://github.com/ansible/ansible/pull/60043)
- postgresql_ping - turn off the default database warning (https://github.com/ansible/ansible/pull/60043)
- postgresql_slot - turn off the default database warning for slot_type physical (https://github.com/ansible/ansible/issues/60043)
- postgresql_table.py - Fix code formatting (https://github.com/ansible/ansible/pull/59497)
- postgresql_tablespace - turn off the default database warning (https://github.com/ansible/ansible/pull/60043)
- resolves CVE-2019-10206, by avoiding templating passwords from prompt as it is probable they have special characters.
- sysctl - check system values, not just sysctl.conf file, when determing state (https://github.com/ansible/ansible/pull/56153#issuecomment-514384922)
- user - do not warn when using ``local: yes`` if user already exists (https://github.com/ansible/ansible/issues/58063)
- win_domain_group_membership - Fix missing @extra_args on Get-ADObject to support dirrent domain and credentials for retrival (https://github.com/ansible/ansible/issues/57404)
- win_dsc - Be more leniant around the accepted DateTime values for backwards compatibility - https://github.com/ansible/ansible/issues/59667
- win_user - Get proper error code when failing to validate the user's credentials
v2.8.3
======
Release Summary
---------------
| Release Date: 2019-07-25
| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
Minor Changes
-------------
- In ec2_eip, device_id is required when private_ip_address is set, but the reverse is not true (https://github.com/ansible/ansible/pull/55194).
- Typecast vlan id to string in nmcli module (https://github.com/ansible/ansible/issues/58949).
- Warn user about Distributed vSwitch permission in vmware_object_role_permission (https://github.com/ansible/ansible/issues/55248).
- When using `fetch_nested` fetch also list of href, instead only single object hrefs.
- dnf - set lock_timeout to a sane default (30 seconds, as is the cli)
- fix exception when tower_verify_ssl parameter is used in tower_role module (https://github.com/ansible/ansible/pull/57518).
- vApp setting can be set while VM creation in vmware_guest (https://github.com/ansible/ansible/issues/50617).
- yum - set lock_timeout to a sane default (30 seconds, as is the cli)
Bugfixes
--------
- Check when user does pass empty dict to sysprep. Fixes https://github.com/oVirt/ovirt-ansible-vm-infra/issues/104
- Do not assume None is equal as connection and become tools can have different unspecified defaults.
- Fix broken slxos_config due to changed backup options (https://github.com/ansible/ansible/pull/58804).
- Fix regression when including a role with a custom filter (https://github.com/ansible/ansible/issues/57351)
- Fixed disk already exists issue while cloning guest in vmware_guest module (https://github.com/ansible/ansible/issues/56861).
- Gather facts should use gather_subset config by default.
- Make max_connections parameter work again in vmware_guest module (https://github.com/ansible/ansible/pull/58061).
- To find specified interfaces, add a interface-type.
- To resolve NoneType error as it was missing NoneType check for l3protocol param in aci_l3out. (https://github.com/ansible/ansible/pull/58618).
- Use templated loop_var/index_var when looping include_* (https://github.com/ansible/ansible/issues/58820)
- Using neconf API to send cli commands is a bug, now fix it(https://github.com/ansible/ansible/pull/59071)
- aws_secret - Document region so the config manager can retrieve its value.
- ce_bfd_global - line284, 'data' tag of xpath should be removed. line498, add "self.existing == self.end_state" to compare the status and get 'changed'.
- ce_bfd_view - line287, line293, 'data' tag of a xpath should be removed to find a element.line500, running result judgment.
- ce_evpn_bd_vni - modify xml function to find data.(https://github.com/ansible/ansible/pull/58227)
- ce_evpn_bgp_rr - fix bugs,get wrong config, get wrong result.changed .(https://github.com/ansible/ansible/pull/58228)
- ce_interface - It is not a good way to find data from a xml tree by regular. lin379 line405.
- ce_interface - line 750,779 Some attributes of interfaces are missing, 'ifAdminStatus', 'ifDescr', 'isL2SwitchPort'.So add them when get interface status.
- ce_interface_ospf - remove the 'data' tag to fix a bug,.(https://github.com/ansible/ansible/pull/58229)
- ce_link_status - remove the 'data' tag to fix a bug,.(https://github.com/ansible/ansible/pull/58229)
- ce_netstream_aging - line318, Redundant regular. line326,line33, there may be out of array rang,some time.(https://github.com/ansible/ansible/pull/58231)
- ce_static_route The IPv6 binary system has a length of 128 bits and is grouped by 16 bits. Each group is separated by a colon ":" and can be divided into 8 groups, each group being represented by 4 hexadecimal. You can use a double colon "::" to represent a group of 0 or more consecutive 0s, but only once. Divisible compatible with Python2 and Python3. To find all elements, Data root node that is taged 'data' should be removed.(https://github.com/ansible/ansible/pull/58251)
- ce_vrrp - tag 'data' is the root node of data xml tree,remove 'data' tag to find all. line 700,747 "vrrp_group_info["adminIgnoreIfDown"]", value is string and lower case. line 1177,1240. Compare wrong! They should be same key of value to be compared.
- ce_vxlan_gateway - update the regular expression to match the more.(https://github.com/ansible/ansible/pull/58226)
- ce_vxlan_global - line 242 , bd_info is a string array,and it should be 'extend' operation. line 423, 'if' and 'else' should set a different value. if 'exist', that value is 'enable'. line 477, To get state of result, if it is changed or not.
- docker_* modules - behave better when requests errors are not caught by docker-py.
- docker_container - add support for ``nocopy`` mode for volumes.
- docker_image - validate ``tag`` option value.
- dzdo did not work with password authentication
- facts - handle situation where ``ansible_architecture`` may not be defined (https://github.com/ansible/ansible/issues/55400)
- fixed collection-based plugin loading in ansible-connection (eg networking plugins)
- gather_facts now correctly passes back the full output of modules on error and skipped, fixes
- group - properly detect duplicate GIDs when local=yes (https://github.com/ansible/ansible/issues/56481)
- ios_config - fixed issue where the "no macro" command was erroneously handled by edit_macro(). https://github.com/ansible/ansible/issues/55212
- machinectl become plugin - correct bugs which induced errors on plugin usage
- nagios module - Fix nagios module to recognize if ``cmdfile`` exists and is fifo pipe.
- nmcli - fixed regression caused by commit b7724fd, github issue
- openssl_privatekey - ``secp256r1`` got accidentally forgotten in the curve list.
- os_quota - fix failure to set compute or network quota when volume service is not available
- ovirt add host retry example to documentation BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1719271)
- ovirt migrate virtual machine with state present and not only running BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1722403)
- ovirt update vm migration domunetation BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1724535)
- ovirt vnic profile: remove duplication in readme
- ovirt_vm - fix for module failure on creation (https://github.com/ansible/ansible/issues/59385)
- postgresql_schema - Parameter ensure replaced by state in the drop schema example (https://github.com/ansible/ansible/pull/59342)
- setup (Windows) - prevent setup module failure if Get-MachineSid fails (https://github.com/ansible/ansible/issues/47813)
- user - omit incompatible options when operating in local mode (https://github.com/ansible/ansible/issues/48722)
- vmware_guest accepts 0 MB of memory reservation, fix regression introduced via 193f69064fb40a83e3e7d2112ef24868b45233b3 (https://github.com/ansible/ansible/issues/59190).
- win_domain_user - Do not hide error and stacktrace on failures
- win_get_url - Fix proxy_url not used correctly (https://github.com/ansible/ansible/issues/58691)
- win_reg_stat - fix issue when trying to check keys in ``HKU:\`` - https://github.com/ansible/ansible/issues/59337
- yum - handle stale/invalid yum.pid lock file (https://github.com/ansible/ansible/issues/57189)
v2.8.2
======
@ -1503,9 +2313,9 @@ vmware
xenserver
^^^^^^^^^
- xenserver_guest - Manages virtual machines running on Citrix XenServer host or pool
- xenserver_guest_facts - Gathers facts for virtual machines running on Citrix XenServer host or pool
- xenserver_guest_powerstate - Manages power states of virtual machines running on Citrix XenServer host or pool
- xenserver_guest - Manages virtual machines running on Citrix Hypervisor/XenServer host or pool
- xenserver_guest_facts - Gathers facts for virtual machines running on Citrix Hypervisor/XenServer host or pool
- xenserver_guest_powerstate - Manages power states of virtual machines running on Citrix Hypervisor/XenServer host or pool
Clustering
~~~~~~~~~~
@ -1916,7 +2726,7 @@ fortios
- fortios_report_layout - Report layout configuration in Fortinet's FortiOS and FortiGate.
- fortios_report_setting - Report setting configuration in Fortinet's FortiOS and FortiGate.
- fortios_report_style - Report style configuration in Fortinet's FortiOS and FortiGate.
- fortios_report_theme - Report themes configuratio in Fortinet's FortiOS and FortiGate.
- fortios_report_theme - Report themes configuration in Fortinet's FortiOS and FortiGate.
- fortios_router_access_list - Configure access lists in Fortinet's FortiOS and FortiGate.
- fortios_router_auth_path - Configure authentication based routing in Fortinet's FortiOS and FortiGate.
- fortios_router_bfd - Configure BFD in Fortinet's FortiOS and FortiGate.
@ -2141,8 +2951,8 @@ cpm
- cpm_plugconfig - Get and Set Plug Parameters on WTI OOB and PDU power devices
- cpm_plugcontrol - Get and Set Plug actions on WTI OOB and PDU power devices
dellemc.idrac
^^^^^^^^^^^^^
dellemc
^^^^^^^
- idrac_firmware - Firmware update from a repository on a network share (CIFS, NFS).
- idrac_server_config_profile - Export or Import iDRAC Server Configuration Profile (SCP).

View File

@ -7,7 +7,9 @@ new_plugins_after_name: removed_features
sections:
- ['major_changes', 'Major Changes']
- ['minor_changes', 'Minor Changes']
- ['breaking_changes', 'Breaking Changes / Porting Guide']
- ['deprecated_features', 'Deprecated Features']
- ['removed_features', 'Removed Features (previously deprecated)']
- ['security_fixes', 'Security Fixes']
- ['bugfixes', 'Bugfixes']
- ['known_issues', 'Known Issues']

View File

@ -0,0 +1,2 @@
security_fixes:
- kubectl - connection plugin now redact kubectl_token and kubectl_password in console log (https://github.com/ansible-collections/community.kubernetes/issues/65) (CVE-2020-1753).

View File

@ -0,0 +1,2 @@
bugfixes:
- mysql_user - fix the error No database selected (https://github.com/ansible/ansible/issues/68070).

View File

@ -0,0 +1,2 @@
minor_changes:
- debconf - add a note about no_log=True since module might expose sensitive information to logs (https://github.com/ansible/ansible/issues/32386).

View File

@ -0,0 +1,3 @@
---
bugfixes:
- "os_quota - fix failure to set compute or network quota when volume service is not available"

View File

@ -0,0 +1,2 @@
bugfixes:
- aws_s3 module - Improve ETag calculation, allow overwrite=always to work on FIPS-140-2

View File

@ -0,0 +1,2 @@
security_fixes:
- aws_secret - flag the ``secret`` parameter as containing sensitive data which shouldn't be logged (https://github.com/ansible-collections/community.aws/pull/471) (CVE-2021-3447).

View File

@ -0,0 +1,3 @@
---
bugfixes:
- "nagios - Removed redundant type check which caused crashes. Guardrails added elsewhere in earlier change."

View File

@ -0,0 +1,2 @@
bugfixes:
- pbrun - add default user for become plugin (https://github.com/ansible/ansible/pull/59754)

View File

@ -0,0 +1,2 @@
minor_changes:
- vApp setting can be set while VM creation in vmware_guest (https://github.com/ansible/ansible/issues/50617).

View File

@ -0,0 +1,2 @@
bugfixes:
- aws_secret - Document region so the config manager can retrieve its value.

View File

@ -0,0 +1,2 @@
minor_changes:
- In ec2_eip, device_id is required when private_ip_address is set, but the reverse is not true (https://github.com/ansible/ansible/pull/55194).

View File

@ -0,0 +1,2 @@
bugfixes:
- ec2_instance - Ensures ``ebs.volume_size`` and ``ebs.iops`` are ``int`` to avoid issues with Jinja2 templating

View File

@ -0,0 +1,2 @@
bugfixes:
- rabbitmq_publish - Fix to ensure the module works correctly for pika v1.0.0 and later. (https://github.com/ansible/ansible/pull/61960)

View File

@ -0,0 +1,2 @@
bugfixes:
- nmcli - fixed regression caused by commit b7724fd, github issue #36615 (https://github.com/ansible/ansible/issues/36615)

View File

@ -0,0 +1,3 @@
---
bugfixes:
- "consul_session - ``state`` parameter: use ``required_if``, document ``id`` parameter, update ``name`` parameter documentation"

View File

@ -0,0 +1,2 @@
bugfixes:
- group - properly detect duplicate GIDs when local=yes (https://github.com/ansible/ansible/issues/56481)

View File

@ -0,0 +1,2 @@
bugfixes:
- Remove the unnecessary warning about aptitude not being installed (https://github.com/ansible/ansible/issues/56832).

View File

@ -0,0 +1,2 @@
minor_changes:
- Fixes comparison of list to integer in gluster_volume (https://github.com/ansible/ansible/issues/56844).

View File

@ -0,0 +1,3 @@
bugfixes:
- netapp_e_lun_mapping - Fix hosts with same lun number conflict in netapp_e_lun_mapping
- netapp_e_lun_mapping - Fix netapp_e_host module bug when lun=0

View File

@ -0,0 +1,2 @@
bugfixes:
- vmware - Ensure we can use the modules with Python < 2.7.9 or RHEL/CentOS < 7.4, this as soon as ``validate_certs`` is disabled.

View File

@ -0,0 +1,2 @@
bugfixes:
- "ovirt vnic profile: remove duplication in readme"

View File

@ -0,0 +1,2 @@
bugfixes:
- Fix regression when including a role with a custom filter (https://github.com/ansible/ansible/issues/57351)

View File

@ -0,0 +1,2 @@
minor_changes:
- fix exception when tower_verify_ssl parameter is used in tower_role module (https://github.com/ansible/ansible/pull/57518).

View File

@ -0,0 +1,2 @@
minor_changes:
- The `podman` connection plugin now supports pipelining.

View File

@ -0,0 +1,3 @@
bugfixes:
- To resolve NoneType error as it was missing NoneType check for l3protocol param in aci_l3out.
(https://github.com/ansible/ansible/pull/58618).

View File

@ -0,0 +1,2 @@
bugfixes:
- ansible-podman connection plugin - Fix case when mount of podman container fails and files can't be copied to/from container. Also add error handling in case of failed podman commands. (https://github.com/ansible/ansible/issues/57740)

View File

@ -0,0 +1,2 @@
bugfixes:
- win_acl - Fixed error when setting rights on directory for which inheritance from parent directory has been disabled.

View File

@ -0,0 +1,3 @@
bugfixes:
- ce_interface - It is not a good way to find data from a xml tree by regular. lin379 line405.
- ce_interface - line 750,779 Some attributes of interfaces are missing, 'ifAdminStatus', 'ifDescr', 'isL2SwitchPort'.So add them when get interface status.

View File

@ -0,0 +1,2 @@
bugfixes:
- ovirt_host - add event log on failure (https://github.com/oVirt/ovirt-ansible-infra/issues/8)

View File

@ -0,0 +1,4 @@
bugfixes:
- ce_vxlan_global - line 242 , bd_info is a string array,and it should be 'extend' operation.
line 423, 'if' and 'else' should set a different value. if 'exist', that value is 'enable'.
line 477, To get state of result, if it is changed or not.

View File

@ -0,0 +1,2 @@
bugfixes:
- openssh_keypair - add public key and key comment validation on change

View File

@ -0,0 +1,2 @@
bugfixes:
- Make max_connections parameter work again in vmware_guest module (https://github.com/ansible/ansible/pull/58061).

View File

@ -0,0 +1,2 @@
bugfixes:
- ovirt migrate virtual machine with state present and not only running BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1722403)

View File

@ -0,0 +1,2 @@
bugfixes:
- sysctl - fix err referenced before assignment (https://github.com/ansible/ansible/issues/58158)

View File

@ -0,0 +1,2 @@
bugfixes:
- proxmox_kvm - fixed issue when vm has not yet a name item (https://github.com/ansible/ansible/issues/58194)

View File

@ -0,0 +1,3 @@
bugfixes:
- ce_bfd_global - line284, 'data' tag of xpath should be removed.
line498, add "self.existing == self.end_state" to compare the status and get 'changed'.

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_bfd_view - line287, line293, 'data' tag of a xpath should be removed to find a element.line500, running result judgment.

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_vxlan_gateway - update the regular expression to match the more.(https://github.com/ansible/ansible/pull/58226)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_evpn_bd_vni - modify xml function to find data.(https://github.com/ansible/ansible/pull/58227)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_interface_ospf - remove the 'data' tag to fix a bug,.(https://github.com/ansible/ansible/pull/58229)

View File

@ -0,0 +1,2 @@
bugfixes:
- copy - recursive copy with ``remote_src=yes`` now recurses beyond first level. (Fixes https://github.com/ansible/ansible/issues/58284)

View File

@ -0,0 +1,2 @@
bugfixes:
- facts - fixed double-counting of CPUs on POWER systems

View File

@ -0,0 +1,2 @@
bugfixes:
- setup (Windows) - prevent setup module failure if Get-MachineSid fails (https://github.com/ansible/ansible/issues/47813)

View File

@ -0,0 +1,2 @@
bugfixes:
- zabbix_* modules - modules will now properly disconnect existing sessions from Zabbix server (see https://github.com/ansible/ansible/pull/58525)

View File

@ -0,0 +1,4 @@
bugfixes:
- ce_vrrp - tag 'data' is the root node of data xml tree,remove 'data' tag to find all.
line 700,747 "vrrp_group_info["adminIgnoreIfDown"]", value is string and lower case.
line 1177,1240. Compare wrong! They should be same key of value to be compared.

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_evpn_bgp_rr - fix bugs,get wrong config, get wrong result.changed .(https://github.com/ansible/ansible/pull/58228)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_link_status - remove the 'data' tag to fix a bug,.(https://github.com/ansible/ansible/pull/58229)

View File

@ -0,0 +1,3 @@
bugfixes:
- ce_netstream_aging - line318, Redundant regular.
line326,line33, there may be out of array rang,some time.(https://github.com/ansible/ansible/pull/58231)

View File

@ -0,0 +1,7 @@
bugfixes:
- ce_static_route
The IPv6 binary system has a length of 128 bits and is grouped by 16 bits.
Each group is separated by a colon ":" and can be divided into 8 groups, each group being represented by 4 hexadecimal.
You can use a double colon "::" to represent a group of 0 or more consecutive 0s, but only once.
Divisible compatible with Python2 and Python3.
To find all elements, Data root node that is taged 'data' should be removed.(https://github.com/ansible/ansible/pull/58251)

View File

@ -0,0 +1,2 @@
bugfixes:
- nagios module - Fix nagios module to recognize if ``cmdfile`` exists and is fifo pipe.

View File

@ -0,0 +1,2 @@
bugfixes:
- ovirt update vm migration domunetation BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1724535)

View File

@ -0,0 +1,2 @@
minor_changes:
- Warn user about Distributed vSwitch permission in vmware_object_role_permission (https://github.com/ansible/ansible/issues/55248).

View File

@ -0,0 +1,2 @@
bugfixes:
- "openssl_privatekey - ``secp256r1`` got accidentally forgotten in the curve list."

View File

@ -0,0 +1,2 @@
bugfixes:
- ovirt add host retry example to documentation BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1719271)

View File

@ -0,0 +1,2 @@
bugfixes:
- machinectl become plugin - correct bugs which induced errors on plugin usage

View File

@ -0,0 +1,2 @@
bugfixes:
- Fixed disk already exists issue while cloning guest in vmware_guest module (https://github.com/ansible/ansible/issues/56861).

View File

@ -0,0 +1,2 @@
bugfixes:
- eos_bgp - Fix fetching AS failure if BGP is not already configured (https://github.com/ansible/ansible/pull/58756)

View File

@ -0,0 +1,3 @@
bugfixes:
- "docker_image - validate ``tag`` option value."
- "docker_* modules - behave better when requests errors are not caught by docker-py."

View File

@ -0,0 +1,2 @@
bugfixes:
- Use templated loop_var/index_var when looping include_* (https://github.com/ansible/ansible/issues/58820)

View File

@ -0,0 +1,2 @@
bugfixes:
- Do not re-use remote_user from previous loop iteration (https://github.com/ansible/ansible/issues/58876)

View File

@ -0,0 +1,2 @@
minor_changes:
- Typecast vlan id to string in nmcli module (https://github.com/ansible/ansible/issues/58949).

View File

@ -0,0 +1,2 @@
bugfixes:
- junos_user - fixed issue with adding multiple values for a Junos account with aggregate mode

View File

@ -0,0 +1,2 @@
bugfixes:
- Fix for performance regression in handler invocation (https://github.com/ansible/ansible/issues/59017)

View File

@ -0,0 +1,2 @@
bugfixes:
- "docker_container - add support for ``nocopy`` mode for volumes."

View File

@ -0,0 +1,2 @@
bugfixes:
- "To find specified interfaces, add a interface-type."

View File

@ -0,0 +1,4 @@
bugfixes:
- ec2_group - Don't truncate the host bits off of IPv6 CIDRs.
CIDRs will be passed thru to EC2 as-is provided they are valid IPv6
representations. (https://github.com/ansible/ansible/issues/53297)

View File

@ -0,0 +1,2 @@
bugfixes:
- vmware_guest accepts 0 MB of memory reservation, fix regression introduced via 193f69064fb40a83e3e7d2112ef24868b45233b3 (https://github.com/ansible/ansible/issues/59190).

View File

@ -0,0 +1,2 @@
bugfixes:
- "Check when user does pass empty dict to sysprep. Fixes https://github.com/oVirt/ovirt-ansible-vm-infra/issues/104"

View File

@ -0,0 +1,2 @@
bugfixes:
- Using neconf API to send cli commands is a bug, now fix it(https://github.com/ansible/ansible/pull/59071)

View File

@ -0,0 +1,2 @@
minor_changes:
- remove ambiguity in module naming; use "my_test" as module name

View File

@ -0,0 +1,2 @@
bugfixes:
- postgresql_schema - Parameter ensure replaced by state in the drop schema example (https://github.com/ansible/ansible/pull/59342)

View File

@ -0,0 +1,2 @@
bugfixes:
- ovirt_vm - fix for module failure on creation (https://github.com/ansible/ansible/issues/59385)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_ntp_auth - update to fix "state is present but all of the following are missing-password" bug(https://github.com/ansible/ansible/pull/59344)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_rollback - shouldn't load xml configure via network_cli(https://github.com/ansible/ansible/pull/59345)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_file_copy - update to Compatible with multiple version of NETCONF API(sshServer). (https://github.com/ansible/ansible/pull/59450)

View File

@ -0,0 +1,2 @@
minor_changes:
- Correct the return values of matched and examined from string to int

View File

@ -0,0 +1,2 @@
bugfixes:
- systemd - wait for a service which is in deactivating state when using ``state=stopped`` (https://github.com/ansible/ansible/pull/59471)

View File

@ -0,0 +1,5 @@
bugfixes:
- postgresql_db.py - Fix code formatting (https://github.com/ansible/ansible/pull/59497)
- postgresql_ext.py - Remove pg_quote_identifier unused import (https://github.com/ansible/ansible/pull/59497)
- postgresql_lang.py - Remove pg_quote_identifier and to_native unused imports (https://github.com/ansible/ansible/pull/59497)
- postgresql_table.py - Fix code formatting (https://github.com/ansible/ansible/pull/59497)

View File

@ -0,0 +1,2 @@
bugfixes:
- ansible.basics - fix core C# recursive call when logging fails (e.g. if insufficient permissions are held) (https://github.com/ansible/ansible/pull/59503)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_mtu - bug-info - unable to parse request, to fix the bug (https://github.com/ansible/ansible/pull/59343)

View File

@ -0,0 +1,2 @@
bugfixes:
- ce_startup - update to fix a bug - netconf and cli are all used to load configure at a time (https://github.com/ansible/ansible/pull/59346 )

View File

@ -0,0 +1,4 @@
bugfixes:
- plugin loader - Restore adding plugin loader playbook dir to ``Playbook`` in
addition to ``PlaybookCLI`` to solve sub directory playbook relative plugins
to be located (https://github.com/ansible/ansible/issues/59548)

Some files were not shown because too many files have changed in this diff Show More