New release v2.6.4

(cherry picked from commit 4173a30941)

.cherry_picker.toml

@@ -1,5 +0,0 @@
-team = "ansible"
-repo = "ansible"
-check_sha = "f31421576b00f0b167cdbe61217c31c21a41ac02"  # the very first commit in repo
-fix_commit_msg = false  # Don't replace "#" with "GH-"
-default_branch = "devel"

.coveragerc

@@ -23,4 +23,3 @@ omit =
     */python*/distutils/*
     */pyshared/*
     */pytest
-    */AnsiballZ_*.py

.github/CONTRIBUTING.md

@@ -1,25 +0,0 @@
-# WELCOME TO ANSIBLE GITHUB
-
-Hi! Nice to see you here!
-
-## QUESTIONS ?
-
-Please see the [Community Guide](https://docs.ansible.com/ansible/latest/community/index.html) for information on how to ask questions on the [mailing lists](https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information) and IRC.
-
-The GitHub issue tracker is not the best place for questions for various reasons, but both IRC and the mailing list are very helpful places for those things, as the community page explains best.
-
-## CONTRIBUTING ?
-
-By contributing you agree that these contributions are your own (or approved by your employer) and you grant a full, complete, irrevocable copyright license to all users and developers of the project, present and future, pursuant to the license of the project. You can also read the same [CLA](https://docs.ansible.com/ansible/latest/community/contributor_license_agreement.html) on the Ansible docsite.
-
-Please review the [Community Guide](https://docs.ansible.com/ansible/latest/community/index.html) for more information on contributing to Ansible.
-
-## BUG TO REPORT ?
-
-First and foremost, also check the [Community Guide](https://docs.ansible.com/ansible/latest/community/index.html).
-
-You can report bugs or make enhancement requests at the [Ansible GitHub issue page](http://github.com/ansible/ansible/issues/new/choose) by filling out the issue template that will be presented.
-
-Also please make sure you are testing on the latest released version of Ansible or the development branch; see the [Installation Guide](https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html) for details.
-
-Thanks!

.github/ISSUE_TEMPLATE.md

@@ -1 +1,58 @@
-Please raise issues via the [new interface](https://github.com/ansible/ansible/issues/new/choose)
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
+
+##### SUMMARY
+<!--- Explain the problem briefly -->
+
+##### ISSUE TYPE
+<!--- Pick one below and delete the rest -->
+ - Bug Report
+ - Feature Idea
+ - Documentation Report
+
+##### COMPONENT NAME
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
+
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
+
+```
+
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,54 +1,61 @@
 ---
 name: 🐛 Bug report
 about: Create a report to help us improve
+
 ---
-<!--- Verify first that your issue is not already reported on GitHub -->
-<!--- Also test if the latest release and devel branch are affected too -->
-<!--- Complete *all* sections as described, this form is processed automatically -->
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
 
 ##### SUMMARY
-<!--- Explain the problem briefly below -->
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-- Bug Report
+ - Bug Report
 
 ##### COMPONENT NAME
-<!--- Write the short name of the module, plugin, task or feature below, use your best guess if unsure -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
 ##### ANSIBLE VERSION
-<!--- Paste verbatim output from "ansible --version" between quotes -->
-```paste below
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
 
 ```
 
 ##### CONFIGURATION
-<!--- Paste verbatim output from "ansible-config dump --only-changed" between quotes -->
-```paste below
-
-```
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
 
 ##### OS / ENVIRONMENT
-<!--- Provide all relevant information below, e.g. target OS versions, network device firmware, etc. -->
-
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
 
 ##### STEPS TO REPRODUCE
-<!--- Describe exactly how to reproduce the problem, using a minimal test-case -->
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
 
 <!--- Paste example playbooks or commands between quotes below -->
 ```yaml
 
 ```
 
-<!--- HINT: You can paste gist.github.com links for larger files -->
+<!--- You can also paste gist.github.com links for larger files -->
 
 ##### EXPECTED RESULTS
-<!--- Describe what you expected to happen when running the steps above -->
-
+<!--- What did you expect to happen when running the steps above? -->
 
 ##### ACTUAL RESULTS
-<!--- Describe what actually happened. If possible run with extra verbosity (-vvvv) -->
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
 
-<!--- Paste verbatim command output between quotes -->
-```paste below
+<!--- Paste verbatim command output between quotes below -->
+```
 
 ```

.github/ISSUE_TEMPLATE/documentation_report.md

@@ -1,38 +1,61 @@
 ---
 name: 📝 Documentation Report
 about: Ask us about docs
+
 ---
-<!--- Verify first that your improvement is not already reported on GitHub -->
-<!--- Also test if the latest release and devel branch are affected too -->
-<!--- Complete *all* sections as described, this form is processed automatically -->
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
 
 ##### SUMMARY
-<!--- Explain the problem briefly below, add suggestions to wording or structure -->
-
-<!--- HINT: Did you know the documentation has an "Edit on GitHub" link on every page ? -->
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-- Documentation Report
+ - Documentation Report
 
 ##### COMPONENT NAME
-<!--- Write the short name of the rst file, module, plugin, task or feature below, use your best guess if unsure -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
 ##### ANSIBLE VERSION
-<!--- Paste verbatim output from "ansible --version" between quotes -->
-```paste below
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
 
 ```
 
 ##### CONFIGURATION
-<!--- Paste verbatim output from "ansible-config dump --only-changed" between quotes -->
-```paste below
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
 
 ```
 
-##### OS / ENVIRONMENT
-<!--- Provide all relevant information below, e.g. OS version, browser, etc. -->
+<!--- You can also paste gist.github.com links for larger files -->
 
-##### ADDITIONAL INFORMATION
-<!--- Describe how this improves the documentation, e.g. before/after situation or screenshots -->
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
 
-<!--- HINT: You can paste gist.github.com links for larger files -->
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,25 +1,61 @@
 ---
 name: ✨ Feature request
 about: Suggest an idea for this project
+
 ---
-<!--- Verify first that your feature was not already discussed on GitHub -->
-<!--- Complete *all* sections as described, this form is processed automatically -->
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
 
 ##### SUMMARY
-<!--- Describe the new feature/improvement briefly below -->
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-- Feature Idea
+ - Feature Idea
 
 ##### COMPONENT NAME
-<!--- Write the short name of the module, plugin, task or feature below, use your best guess if unsure -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
-##### ADDITIONAL INFORMATION
-<!--- Describe how the feature would be used, why it is needed and what it would solve -->
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
 
 <!--- Paste example playbooks or commands between quotes below -->
 ```yaml
 
 ```
 
-<!--- HINT: You can also paste gist.github.com links for larger files -->
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/security_bug_report.md

@@ -1,8 +0,0 @@
----
-name: 🔥 Security bug report
-about: How to report security vulnerabilities
----
-
-For all security related bugs, email security@ansible.com instead of using this issue tracker and you will receive a prompt response.
-
-For more information, see https://docs.ansible.com/ansible/latest/community/reporting_bugs_and_features.html

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,23 +1,33 @@
 ##### SUMMARY
-<!--- Describe the change below, including rationale and design decisions -->
+<!--- Describe the change, including rationale and design decisions -->
 
-<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
+<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
+commit message and your description; but you should still explain what
+the change does.-->
 
 ##### ISSUE TYPE
-<!--- Pick one below and delete the rest -->
-- Bugfix Pull Request
-- Docs Pull Request
-- Feature Pull Request
-- New Module Pull Request
+<!--- Pick one below and delete the rest: -->
+ - Feature Pull Request
+ - New Module Pull Request
+ - Bugfix Pull Request
+ - Docs Pull Request
 
 ##### COMPONENT NAME
-<!--- Write the short name of the module, plugin, task or feature below -->
+<!--- Name of the module, plugin, module or task -->
 
-##### ADDITIONAL INFORMATION
-<!--- Include additional information to help people understand the change here -->
-<!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->
-
-<!--- Paste verbatim command output below, e.g. before and after your change -->
-```paste below
+##### ANSIBLE VERSION
+<!--- Paste verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+
+##### ADDITIONAL INFORMATION
+<!--- Include additional information to help people understand the change here.
+For bugs that don't have a linked bug report, a step-by-step reproduction
+of the problem is helpful. -->
+
+<!--- Paste verbatim command output below, e.g. before and after your change -->
+```
 
 ```

.gitignore

@@ -29,12 +29,13 @@ docs/man/man3/*
 *.sublime-project
 *.sublime-workspace
 # docsite stuff...
+docs/api/_build/
+docs/api/rst/
 docs/docsite/_build
 docs/docsite/*.html
 docs/docsite/htmlout
 docs/docsite/rst/cli/ansible-*.rst
 docs/docsite/rst/cli/ansible.rst
-docs/docsite/rst/dev_guide/testing/sanity/index.rst.new
 docs/docsite/rst/modules/*.rst
 docs/docsite/rst/playbooks_directives.rst
 docs/docsite/rst/plugins_by_category.rst
@@ -86,7 +87,6 @@ packaging/release/ansible_release
 /test/results/junit/*.xml
 /test/results/logs/*.log
 /test/results/data/*.json
-/test/integration/cloud-config-aws.yml
 /test/integration/inventory.remote
 /test/integration/inventory.networking
 /test/integration/inventory.winrm
@@ -103,6 +103,4 @@ htmlcov/
 # ansible-test coverage results
 test/units/.coverage.*
 /test/integration/cloud-config-azure.yml
-/SYMLINK_CACHE.json
 changelogs/.plugin-cache.yaml
-.ansible-test-timeout.json

CODING_GUIDELINES.md

@@ -1,10 +1,316 @@
 Coding Guidelines
 =================
 
-Hi! Thanks for your interest in contributing to Ansible. We document our Coding Guidelines in the [Developer Guide](https://docs.ansible.com/ansible/devel/dev_guide/). We particularly suggest you review:
+Hi!  Thanks for your interest in contributing to Ansible.
 
-* [Contributing your module to Ansible](https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_checklist.html)
+Here are some guidelines for contributing code.  The purpose of this document is to establish what we're looking for in code contributions, and to make sure
+new contributors know some of the conventions that we've been using.
 
-* [Development conventions, tips and pitfalls](https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html)
+We don't think much of this should be too strange to readers familiar with contributing to Python projects, though it helps if we all get on the same page.
 
-Our [Community Guide](https://docs.ansible.com/ansible/devel/community/) may also help you connect with the community of Ansible developers.
+Language
+========
+
+  * While not all components of Ansible must be in Python, core contributions to the Ansible repo must be written in Python.  This is to maximize the ability of everyone to contribute.
+  * If you want to write non-Python ansible modules or inventory scripts, that's fine, but they are not going to get merged in most likely.  Sorry!!
+
+PEP 8 and basic style checks
+============================
+
+  * [PEP 8](https://www.python.org/dev/peps/pep-0008/) is a great Python style guide, which you should read.
+  * PEP 8 must not be strictly followed in all aspects, but most of it is good advice.
+  * The line is limited to 160 characters.
+  * To run checks for things we care about, use [ansible-test](https://docs.ansible.com/ansible/devel/dev_guide/testing_sanity.html).
+  * Similarly, additional checks can be made with "make pyflakes".
+  * There is no need to submit code changes for PEP 8 and pyflakes fixes, as these break attribution history.  Project leadership will make these periodically.
+  * Do not submit pull requests that simply adjust whitespace in the code.
+
+Testing
+=======
+
+  * Much of Ansible's testing needs are in integration, not unit tests.  Add module tests there.
+  * That being said, there are unit tests too!
+  * Code written must absolutely pass tests (i.e. "make tests")
+  * You should anticipate any error paths in your code and test down those error paths.
+  * Additions to tests for core code are welcome, but not always possible.  Be sure things are at least well tested manually in that case.
+
+Whitespace
+==========
+
+  * Four space indent is strictly required
+  * Include meaningful whitespace between lines of code
+
+Shebang Lines
+=============
+
+  * /usr/bin/scripts should start with '/usr/bin/env python'
+  * module code should still use '/usr/bin/python' as this is replaced automatically by 'ansible_python_interpreter', see the FAQ in the docs for more info.
+
+Comments
+========
+
+  * Readability is one of the most important goals for this project
+  * Comment any non-trivial code where someone might not know why you are doing something in a particular way
+  * Though if something should be commented, that's often a sign someone should write a function
+  * All new functions must have a basic docstring comment
+  * Commenting above a line is preferable to commenting at the end of a line
+
+Classes
+=======
+
+  * With the exception of module code (where inline is better), it is desirable to see classes in their own files.
+  * Classes should generally not cause side effects as soon as they are instantiated, move meaningful behavior to methods rather than constructors.
+
+Functions and Methods
+=====================
+
+  * In general, functions should not be 'too long' and should describe a meaningful amount of work
+  * When code gets too nested, that's usually the sign the loop body could benefit from being a function
+  * Parts of our existing code are not the best examples of this at times.
+  * Functions should have names that describe what they do, along with docstrings
+  * Functions should be named with_underscores
+  * "Don't repeat yourself" is generally a good philosophy
+
+Variables
+=========
+
+  * Use descriptive variable names instead of variables like 'x', unless x is an obvious loop index
+  * Ansible python code uses identifiers like 'ClassesLikeThis and variables_like_this
+  * Module parameters should also use_underscores and not runtogether
+
+Module Security
+===============
+
+  * Modules must take steps to avoid passing user input from the shell and always check return codes
+  * always use module.run_command instead of subprocess or Popen or os.system -- this is mandatory
+  * if you need to use the shell you must pass use_unsafe_shell=True to module.run_command
+  * if you do not need the shell, avoid using the shell
+  * any variables that can come from the user input with use_unsafe_shell=True must be wrapped by pipes.quote(x)
+  * downloads of https:// resource urls must import module_utils.urls and use the fetch_url method
+
+Misc Preferences
+================
+
+Use the dict constructor where possible when allocating dictionaries:
+
+    # not this:
+    foo = {
+       'a' : 12,
+       'b' : 34
+    }
+
+    # this:
+    foo = dict(
+       a=12,
+       b=34,
+    )
+
+Do not line up variables
+
+    # not this
+    a        = 12
+    foosball = 34
+    xyz      = 'dog'
+
+    # this
+    a = 12
+    foosball = 34
+    xyz = 'dog'
+
+Don't use line continuations:
+
+    # no
+    if (this_is_a_very_long_line and foo and \
+       i_am_going_to_continue_it):
+          bar()
+
+    # better:
+    if (this_is_a_very_long_line and foo and i_am_going_to_continue_it):
+       bar()
+
+Spacing:
+
+    # no
+    x = [1,2,3]
+
+    # no
+    x = [ 1, 2, 3 ]
+
+    # yes
+    x = [1, 2, 3]
+
+Spacing continued:
+
+    # no
+    x=foo(12)
+
+    # no
+    x = foo( 12 )
+
+    # yes
+    x = foo(12)
+
+Licenses
+========
+
+Every file should have a license header, including the copyright of the original author.  Major additions to the module are allowed
+to add an additional copyright line, and this is especially true of rewrites, but original authorship copyright messages should be preserved.
+
+All contributions to the core repo should preserve original licenses and new contributions must include the GPLv3 header.
+
+Module Documentation
+====================
+
+All module pull requests must include a DOCUMENTATION docstring (YAML format,
+see other modules for examples) as well as an EXAMPLES docstring, which is free form.
+
+When adding new modules, any new parameter must have a "version_added" attribute.
+When submitting a new module, the module should have a "version_added" attribute in the
+pull request as well, set to the current development version.
+
+Be sure to check grammar and spelling.
+
+It's frequently the case that modules get submitted with YAML that isn't valid,
+so you can run "make webdocs" from the checkout to preview your module's documentation.
+If it fails to build, take a look at your DOCUMENTATION string
+or you might have a Python syntax error in there too.
+
+Python Imports
+==============
+
+To make it clear what a module is importing, imports should not be sprinkled throughout the code.
+
+Python Imports should happen at the top of the file, exempting code from module_utils.
+
+When a conditional runtime import is required, do so something like this instead:
+
+    HAS_FOO = False
+    try:
+       import foo
+       HAS_FOO = True
+    except ImportError:
+       pass
+
+    ...
+
+    if not HAS_FOO:
+       raise Exception("the foo library is required")
+
+This makes it clear what optional dependencies are but allows this to be deferred until runtime.   In the case of module code, the raising of the Exception will be replaced
+with a "module.exit_json" call.
+
+Exceptions
+==========
+
+In the main body of the code, use typed exceptions where possible:
+
+    # not this
+    raise Exception("panic!")
+
+    # this
+    from ansible import errors
+    ...
+    raise errors.AnsibleError("panic!")
+
+Similarly, exception checking should be fine grained:
+
+    # not this
+    try:
+       foo()
+    except:
+       bar()
+
+    # but this
+    try:
+       foo()
+    except SomeTypedException:
+       bar()
+
+List Comprehensions
+===================
+
+In general list comprehensions are always preferred to map() and filter() calls.
+
+However, they can be abused.  Optimize for readability, and avoid nesting them too deeply.
+
+Regexes
+=======
+
+There is a time and place for them, but here's an illustrative joke.
+
+"A developer had a problem, and used a regular expression to solve it.  Now the developer had two problems".
+
+Often regexes are difficult to maintain, and a trusty call to other string operations can be a great solution, faster,
+and more readable.
+
+File Conventions
+================
+
+If a piece of code looks for a named YAML file in a directory, it should assume it can take no extension, or an extension of '.yml' or '.yaml'.
+This should be true against all code that loads files.
+
+Any code that uses directories should consider the possibility that the directory may be symlink.
+
+New Ansible language parameters
+===============================
+
+If adding a new parameter, like 'can_fizzbuzz: True/False' be sure the value of the parameter is templated somewhere in the Runner code, as if anything can be parameterized in Ansible,
+there is a user that will try to parameterize it.
+
+String Find
+===========
+
+Use 'in':
+
+    # not this:
+    if x.find('foo') != -1:
+
+    # this:
+    if 'foo' in x:
+
+String checks
+=============
+
+To test if something is a string, consider that it may be unicode.
+
+    # no
+    if type(x) == str:
+
+    # yes
+    from ansible.module_utils.six import string_types
+    if isinstance(x, string_types):
+
+Cleverness
+==========
+
+Ansible's code is intended to be read by as many people as possible, so we don't particularly encourage clever or heavily idiomatic code.
+
+In particular, metaclasses are probably not appropriate, however entertaining they may be to add.
+
+Git Practices
+=============
+
+Pull requests cannot be accepted if they contain merge commits.
+
+Always do "git pull --rebase" and "git rebase" vs "git pull" or "git merge". See [rebasing a pull request](https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html) for more information.
+
+Always create a new branch for each pull request to avoid intermingling different features or fixes on the same branch.
+
+
+Python Version Compliance
+=========================
+
+All code in Ansible core must support a minimum version of Python 2.6.
+
+Module code must support a minimum of Python 2.4, with occasional exceptions for modules that require code that themselves require 2.6 and later.
+
+A quick reminder is that list comprehensions in Python 2.4 are not as fully fleshed out, there are no 'dict' comprehensions, and there is no 'with' statement.
+But otherwise it's pretty much all the same.
+
+The End
+=======
+
+This was not meant to be a scary document, so we hope it wasn't, but we also hope this helps you write code that is easier to maintain by others in the future.
+If you have questions about this document, please ask on the ansible-devel mailing list.
+
+Thank you!

CONTRIBUTING.md

@@ -0,0 +1,28 @@
+# WELCOME TO ANSIBLE GITHUB
+
+Hi! Nice to see you here!
+
+## QUESTIONS ?
+
+Please see the [community guide](https://docs.ansible.com/ansible/latest/community/index.html) for information on how to ask questions on the [mailing lists](https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information) and IRC.
+
+The GitHub issue tracker is not the best place for questions for various reasons, but both IRC and the mailing list are very helpful places for those things, as the community page explains best.
+
+## CONTRIBUTING ?
+
+By contributing you agree that these contributions are your own (or approved by your employer) and you grant a full, complete, irrevocable copyright license to all users and developers of the project, present and future, pursuant to the license of the project.
+
+Please see the [community guide](https://docs.ansible.com/ansible/latest/community/index.html) for information regarding the contribution process. Important license agreement information is also included on that page.
+
+## BUG TO REPORT ?
+
+First and foremost, also check the [community guide](https://docs.ansible.com/ansible/latest/community/index.html).
+
+You can report bugs or make enhancement requests at the [Ansible GitHub issue page](http://github.com/ansible/ansible/issues/new/choose) by filling out the issue template that will be presented.
+
+Also please make sure you are testing on the latest released version of Ansible or the development branch. You can find the latest releases and development branch at:
+
+- https://github.com/ansible/ansible/releases
+- https://github.com/ansible/ansible/archive/devel.tar.gz
+
+Thanks!

MANIFEST.in

@@ -1,17 +1,11 @@
+prune hacking
 include README.rst
 include COPYING
 include SYMLINK_CACHE.json
 include requirements.txt
 include .coveragerc
-include shippable.yml
-include tox.ini
-include bin/ansible-test
 include examples/hosts
 include examples/ansible.cfg
-include examples/scripts/ConfigureRemotingForAnsible.ps1
-include examples/scripts/upgrade_to_ps3.ps1
-recursive-include lib/ansible/executor/powershell *
-recursive-include lib/ansible/module_utils/csharp *
 recursive-include lib/ansible/module_utils/powershell *
 recursive-include lib/ansible/modules *
 recursive-include lib/ansible/galaxy/data *
@@ -21,7 +15,6 @@ recursive-include packaging *
 recursive-include test *
 include Makefile
 include MANIFEST.in
-include changelogs/CHANGELOG*.rst
+include changelogs/CHANGELOG-*.rst
 include contrib/README.md
 recursive-include contrib/inventory *
-exclude test/sanity/code-smell/botmeta.*

MODULE_GUIDELINES.md

@@ -1,5 +1,3 @@
 # Module Maintainer Guidelines
 
 The Ansible Module Maintainer Guidelines can now be found in the [official Ansible community guide](https://docs.ansible.com/ansible/latest/community/maintainers.html).
-
-See also the [Developers Guide](https://docs.ansible.com/ansible/latest/dev_guide/)

Makefile

@@ -3,8 +3,6 @@
 # Makefile for Ansible
 #
 # useful targets:
-#   make clean ---------------- clean up
-#   make webdocs -------------- produce ansible doc at docs/docsite/_build/html
 #   make sdist ---------------- produce a tarball
 #   make srpm ----------------- produce a SRPM
 #   make rpm  ----------------- produce RPMs
@@ -31,10 +29,9 @@ ASCII2MAN = rst2man.py $< $@
 else
 ASCII2MAN = @echo "ERROR: rst2man from docutils command is not installed but is required to build $(MANPAGES)" && exit 1
 endif
+GENERATE_CLI = docs/bin/generate_man.py
 
 PYTHON=python
-GENERATE_CLI = $(PYTHON) docs/bin/generate_man.py
-
 SITELIB = $(shell $(PYTHON) -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")
 
 # fetch version from project release.py as single source-of-truth
@@ -51,7 +48,7 @@ RELEASE ?= 1
 
 # Get the branch information from git
 ifneq ($(shell which git),)
-GIT_DATE := $(shell git log -n 1 --format="%ci")
+GIT_DATE := $(shell git log -n 1 --format="%ai")
 GIT_HASH := $(shell git log -n 1 --format="%h")
 GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD | sed 's/[-_.\/]//g')
 GITINFO = .$(GIT_HASH).$(GIT_BRANCH)
@@ -60,7 +57,7 @@ GITINFO = ""
 endif
 
 ifeq ($(shell echo $(OS) | egrep -c 'Darwin|FreeBSD|OpenBSD|DragonFly'),1)
-DATE := $(shell date -j -r $(shell git log -n 1 --format="%ct") +%Y%m%d%H%M)
+DATE := $(shell date -j -r $(shell git log -n 1 --format="%at") +%Y%m%d%H%M)
 CPUS ?= $(shell sysctl hw.ncpu|awk '{print $$2}')
 else
 DATE := $(shell date --utc --date="$(GIT_DATE)" +%Y%m%d%H%M)
@@ -125,7 +122,7 @@ ifneq ($(REPOTAG),)
 endif
 
 # ansible-test parameters
-ANSIBLE_TEST ?= bin/ansible-test
+ANSIBLE_TEST ?= test/runner/ansible-test
 TEST_FLAGS ?=
 
 # ansible-test units parameters (make test / make test-py3)
@@ -220,6 +217,7 @@ clean:
 	rm -f AUTHORS.TXT
 	@echo "Cleaning up docsite"
 	$(MAKE) -C docs/docsite clean
+	$(MAKE) -C docs/api clean
 
 .PHONY: python
 python:
@@ -233,20 +231,9 @@ install_manpages:
 	gzip -9 $(wildcard ./docs/man/man1/ansible*.1)
 	cp $(wildcard ./docs/man/man1/ansible*.1.gz) $(PREFIX)/man/man1/
 
-.PHONY: sdist_check
-sdist_check:
-	$(PYTHON) packaging/sdist/check-link-behavior.py
-
 .PHONY: sdist
-sdist: sdist_check clean docs
-	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist
-
-# Official releases generate the changelog as the last commit before the release.
-# Snapshots shouldn't result in new checkins so the changelog is generated as
-# part of creating the tarball.
-.PHONY: snapshot
-snapshot: sdist_check clean docs changelog
-	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist
+sdist: clean docs
+	$(PYTHON) setup.py sdist
 
 .PHONY: sdist_upload
 sdist_upload: clean docs
@@ -254,7 +241,7 @@ sdist_upload: clean docs
 
 .PHONY: changelog
 changelog:
-	PYTHONPATH=./lib packaging/release/changelogs/changelog.py release -vv && PYTHONPATH=./lib packaging/release/changelogs/changelog.py generate -vv
+	packaging/release/changelogs/changelog.py release -vv && packaging/release/changelogs/changelog.py generate -vv
 
 .PHONY: rpmcommon
 rpmcommon: sdist
@@ -411,3 +398,4 @@ alldocs: docs webdocs
 
 version:
 	@echo $(VERSION)
+

README.rst

@@ -1,85 +1,112 @@
-|PyPI version| |Docs badge| |Chat badge| |Build Status| |Code Of Conduct| |Mailing Lists| |License|
+|PyPI version| |Docs badge| |Build Status|
 
 *******
 Ansible
 *******
 
 Ansible is a radically simple IT automation system. It handles
-configuration management, application deployment, cloud provisioning,
-ad-hoc task execution, network automation, and multi-node orchestration. Ansible makes complex
-changes like zero-downtime rolling updates with load balancers easy. More information on `the Ansible website <https://ansible.com/>`_.
+configuration-management, application deployment, cloud provisioning,
+ad-hoc task-execution, and multinode orchestration -- including
+trivializing things like zero-downtime rolling updates with load
+balancers.
+
+Read the documentation and more at https://ansible.com/
+
+You can find installation instructions
+`here <https://docs.ansible.com/intro_getting_started.html>`_ for a
+variety of platforms.
+
+Most users should probably install a released version of Ansible from ``pip``, a package manager or
+our `release repository <https://releases.ansible.com/ansible/>`_. `Officially supported
+<https://www.ansible.com/ansible-engine>`_ builds of Ansible are also available. Some power users
+run directly from the development branch - while significant efforts are made to ensure that
+``devel`` is reasonably stable, you're more likely to encounter breaking changes when running
+Ansible this way.
 
 Design Principles
 =================
 
-*  Have a dead simple setup process and a minimal learning curve.
-*  Manage machines very quickly and in parallel.
+*  Have a dead simple setup process and a minimal learning curve
+*  Manage machines very quickly and in parallel
 *  Avoid custom-agents and additional open ports, be agentless by
-   leveraging the existing SSH daemon.
+   leveraging the existing SSH daemon
 *  Describe infrastructure in a language that is both machine and human
-   friendly.
-*  Focus on security and easy auditability/review/rewriting of content.
+   friendly
+*  Focus on security and easy auditability/review/rewriting of content
 *  Manage new remote machines instantly, without bootstrapping any
-   software.
-*  Allow module development in any dynamic language, not just Python.
-*  Be usable as non-root.
+   software
+*  Allow module development in any dynamic language, not just Python
+*  Be usable as non-root
 *  Be the easiest IT automation system to use, ever.
 
-Use Ansible
-===========
-
-You can install a released version of Ansible via ``pip``, a package manager, or
-our `release repository <https://releases.ansible.com/ansible/>`_. See our
-`installation guide <https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html>`_ for details on installing Ansible
-on a variety of platforms.
-
-Red Hat offers supported builds of `Ansible Engine <https://www.ansible.com/ansible-engine>`_.
-
-Power users and developers can run the ``devel`` branch, which has the latest
-features and fixes, directly. Although it is reasonably stable, you are more likely to encounter
-breaking changes when running the ``devel`` branch. We recommend getting involved
-in the Ansible community if you want to run the ``devel`` branch.
-
 Get Involved
 ============
 
 *  Read `Community
-   Information <https://docs.ansible.com/ansible/latest/community>`_ for all
+   Information <https://docs.ansible.com/community.html>`_ for all
    kinds of ways to contribute to and interact with the project,
    including mailing list information and how to submit bug reports and
    code to Ansible.
-*  Join a `Working Group
-   <https://github.com/ansible/community/wiki>`_, an organized community devoted to a specific technology domain or platform.
-*  Submit proposed a code update through a pull request to the ``devel`` branch.
-*  Talk to us before making larger changes
-   to avoid duplicate efforts. This not only helps everyone
-   know what is going on, it also helps save time and effort if we decide
+*  All code submissions are done through pull requests. Take care to
+   make sure no merge commits are in the submission, and use
+   ``git rebase`` vs ``git merge`` for this reason. If submitting a
+   large code change (other than modules), it's probably a good idea to
+   join ansible-devel and talk about what you would like to do or add
+   first to avoid duplicate efforts. This not only helps everyone
+   know what's going on, it also helps save time and effort if we decide
    some changes are needed.
-*  For a list of email lists, IRC channels and Working Groups, see the
-   `Communication page <https://docs.ansible.com/ansible/latest/community/communication.html>`_
+*  Users list:
+   `ansible-project <https://groups.google.com/group/ansible-project>`_
+*  Development list:
+   `ansible-devel <https://groups.google.com/group/ansible-devel>`_
+*  Announcement list:
+   `ansible-announce <https://groups.google.com/group/ansible-announce>`_
+   -- read only
+*  irc.freenode.net: #ansible
 
 Branch Info
 ===========
 
-*  The ``devel`` branch corresponds to the release actively under development.
-*  The ``stable-2.X`` branches correspond to stable releases.
-*  For information about the active branches see the
-   `Ansible release and maintenance <https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html>`_ page.
+*  Releases are named after Led Zeppelin songs. (Releases prior to 2.0
+   were named after Van Halen songs.)
+*  The devel branch corresponds to the release actively under
+   development.
+*  Various release-X.Y branches exist for previous releases.
+*  We'd love to have your contributions, read `Community
+   Information <https://docs.ansible.com/community.html>`_ for notes on
+   how to get started.
 
 Roadmap
 =======
 
-Based on team and community feedback, an initial roadmap will be published for a major or minor version (ex: 2.7, 2.8).
-The `Ansible Roadmap page <https://docs.ansible.com/ansible/devel/roadmap/>`_ details what is planned and how to influence the roadmap.
+Based on team and community feedback, an initial roadmap will be published for a major or minor version (ex: 2.0, 2.1).
+Subminor versions will generally not have roadmaps published.
+
+Ansible 2.1 was the first release which published this and asked for feedback in this manner.
+Feedback on the roadmap and the new process is quite welcome.
+The team is aiming for further transparency and better inclusion of both community desires and submissions.
+
+These are the team's *best guess* roadmaps based on the Ansible team's experience and are also based on requests and feedback from the community.
+There are things that may not make it due to time constraints, lack of community maintainers, etc.
+Each roadmap is published both as an idea of what is upcoming in Ansible, and as a medium for seeking further feedback from the community.
+
+There are multiple places for you to submit feedback:
+
+- Add to the agenda of an IRC `Core Team Meeting <https://github.com/ansible/community/blob/master/meetings/README.md>`_ (preferred)
+- Ansible's google-group: ansible-devel
+- AnsibleFest conferences
+- IRC Freenode channel: #ansible-devel (this one may have things lost in lots of conversation)
+
+For additional details consult the published `Ansible Roadmap <https://docs.ansible.com/ansible/devel/roadmap/>`_.
 
 Authors
 =======
 
 Ansible was created by `Michael DeHaan <https://github.com/mpdehaan>`_
-and has contributions from over 4000 users (and growing). Thanks everyone!
+(michael.dehaan/gmail/com) and has contributions from over 1000 users
+(and growing). Thanks everyone!
 
-`Ansible <https://www.ansible.com>`_ is sponsored by `Red Hat, Inc.
-<https://www.redhat.com>`_
+Ansible is sponsored by `Ansible, Inc <https://ansible.com>`_
 
 License
 =======
@@ -91,17 +118,6 @@ See `COPYING <COPYING>`_ to see the full text.
 .. |PyPI version| image:: https://img.shields.io/pypi/v/ansible.svg
    :target: https://pypi.org/project/ansible
 .. |Docs badge| image:: https://img.shields.io/badge/docs-latest-brightgreen.svg
-   :target: https://docs.ansible.com/ansible/latest/
+   :target: https://docs.ansible.com/ansible
 .. |Build Status| image:: https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel
    :target: https://app.shippable.com/projects/573f79d02a8192902e20e34b
-.. |Chat badge| image:: https://img.shields.io/badge/chat-IRC-brightgreen.svg
-   :target: https://docs.ansible.com/ansible/latest/community/communication.html
-.. |Code Of Conduct| image:: https://img.shields.io/badge/code%20of%20conduct-Ansible-silver.svg
-   :target: https://docs.ansible.com/ansible/latest/community/code_of_conduct.html
-   :alt: Ansible Code of Conduct
-.. |Mailing Lists| image:: https://img.shields.io/badge/mailing%20lists-Ansible-orange.svg
-   :target: https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information
-   :alt: Ansible mailing lists
-.. |License| image:: https://img.shields.io/badge/license-GPL%20v3.0-brightgreen.svg
-   :target: COPYING
-   :alt: Repository License

bin/ansible

@@ -22,14 +22,21 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 __requires__ = ['ansible']
-
+try:
+    import pkg_resources
+except Exception:
+    # Use pkg_resources to find the correct versions of libraries and set
+    # sys.path appropriately when there are multiversion installs.  But we
+    # have code that better expresses the errors in the places where the code
+    # is actually used (the deps are optional for many code paths) so we don't
+    # want to fail here.
+    pass
 
 import os
 import shutil
 import sys
 import traceback
 
-from ansible import context
 from ansible.errors import AnsibleError, AnsibleOptionsError, AnsibleParserError
 from ansible.module_utils._text import to_text
 
@@ -107,6 +114,7 @@ if __name__ == '__main__':
             exit_code = 6
         else:
             cli = mycli(args)
+            cli.parse()
             exit_code = cli.run()
 
     except AnsibleOptionsError as e:
@@ -134,9 +142,9 @@ if __name__ == '__main__':
             # Show raw stacktraces in debug mode, It also allow pdb to
             # enter post mortem mode.
             raise
-        have_cli_options = bool(context.CLIARGS)
+        have_cli_options = cli is not None and cli.options is not None
         display.error("Unexpected Exception, this is probably a bug: %s" % to_text(e), wrap_text=False)
-        if not have_cli_options or have_cli_options and context.CLIARGS['verbosity'] > 2:
+        if not have_cli_options or have_cli_options and cli.options.verbosity > 2:
             log_only = False
             if hasattr(e, 'orig_exc'):
                 display.vvv('\nexception type: %s' % to_text(type(e.orig_exc)))
@@ -148,5 +156,8 @@ if __name__ == '__main__':
             log_only = True
         display.display(u"the full traceback was:\n\n%s" % to_text(traceback.format_exc()), log_only=log_only)
         exit_code = 250
+    finally:
+        # Remove ansible tmpdir
+        shutil.rmtree(C.DEFAULT_LOCAL_TMP, True)
 
     sys.exit(exit_code)

bin/ansible-connection

@@ -6,6 +6,10 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 __requires__ = ['ansible']
 
+try:
+    import pkg_resources
+except Exception:
+    pass
 
 import fcntl
 import hashlib
@@ -13,7 +17,6 @@ import os
 import signal
 import socket
 import sys
-import time
 import traceback
 import errno
 import json
@@ -21,12 +24,11 @@ import json
 from contextlib import contextmanager
 
 from ansible import constants as C
-from ansible.module_utils._text import to_bytes, to_text
+from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.module_utils.six import PY3
 from ansible.module_utils.six.moves import cPickle, StringIO
 from ansible.module_utils.connection import Connection, ConnectionError, send_data, recv_data
 from ansible.module_utils.service import fork_process
-from ansible.parsing.ajson import AnsibleJSONEncoder, AnsibleJSONDecoder
 from ansible.playbook.play_context import PlayContext
 from ansible.plugins.loader import connection_loader
 from ansible.utils.path import unfrackpath, makedirs_safe
@@ -90,7 +92,7 @@ class ConnectionProcess(object):
             messages = list()
             result = {}
 
-            messages.append(('vvvv', 'control socket path is %s' % self.socket_path))
+            messages.append('control socket path is %s' % self.socket_path)
 
             # If this is a relative path (~ gets expanded later) then plug the
             # key's path on to the directory we originally came from, so we can
@@ -100,25 +102,22 @@ class ConnectionProcess(object):
             self.connection = connection_loader.get(self.play_context.connection, self.play_context, '/dev/null',
                                                     ansible_playbook_pid=self._ansible_playbook_pid)
             self.connection.set_options(var_options=variables)
-
             self.connection._connect()
-
             self.connection._socket_path = self.socket_path
             self.srv.register(self.connection)
-            messages.extend([('vvvv', msg) for msg in sys.stdout.getvalue().splitlines()])
-            messages.append(('vvvv', 'connection to remote device started successfully'))
+            messages.extend(sys.stdout.getvalue().splitlines())
+            messages.append('connection to remote device started successfully')
 
             self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
             self.sock.bind(self.socket_path)
             self.sock.listen(1)
-            messages.append(('vvvv', 'local domain socket listeners started successfully'))
+            messages.append('local domain socket listeners started successfully')
         except Exception as exc:
-            messages.extend(self.connection.pop_messages())
             result['error'] = to_text(exc)
             result['exception'] = traceback.format_exc()
         finally:
             result['messages'] = messages
-            self.fd.write(json.dumps(result, cls=AnsibleJSONEncoder))
+            self.fd.write(json.dumps(result))
             self.fd.close()
 
     def run(self):
@@ -131,23 +130,17 @@ class ConnectionProcess(object):
                 self.exception = None
                 (s, addr) = self.sock.accept()
                 signal.alarm(0)
+
                 signal.signal(signal.SIGALRM, self.command_timeout)
                 while True:
                     data = recv_data(s)
                     if not data:
                         break
-                    log_messages = self.connection.get_option('persistent_log_messages')
 
-                    if log_messages:
-                        display.display("jsonrpc request: %s" % data, log_only=True)
-
-                    signal.alarm(self.connection.get_option('persistent_command_timeout'))
+                    signal.alarm(self.connection._play_context.timeout)
                     resp = self.srv.handle_request(data)
                     signal.alarm(0)
 
-                    if log_messages:
-                        display.display("jsonrpc response: %s" % resp, log_only=True)
-
                     send_data(s, to_bytes(resp))
 
                 s.close()
@@ -161,50 +154,39 @@ class ConnectionProcess(object):
                 self.exception = traceback.format_exc()
 
         finally:
-            # allow time for any exception msg send over socket to receive at other end before shutting down
-            time.sleep(0.1)
-
-            # when done, close the connection properly and cleanup the socket file so it can be recreated
+            # when done, close the connection properly and cleanup
+            # the socket file so it can be recreated
             self.shutdown()
 
     def connect_timeout(self, signum, frame):
-        msg = 'persistent connection idle timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and ' \
-              'Troubleshooting Guide.' % self.connection.get_option('persistent_connect_timeout')
-        display.display(msg, log_only=True)
-        raise Exception(msg)
+        display.display('persistent connection idle timeout triggered, timeout value is %s secs'
+                        % self.connection.get_option('persistent_connect_timeout'), log_only=True)
+        self.shutdown()
 
     def command_timeout(self, signum, frame):
-        msg = 'command timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and Troubleshooting Guide.'\
-              % self.connection.get_option('persistent_command_timeout')
-        display.display(msg, log_only=True)
-        raise Exception(msg)
+        display.display('command timeout triggered, timeout value is %s secs' % self.play_context.timeout, log_only=True)
+        self.shutdown()
 
     def handler(self, signum, frame):
-        msg = 'signal handler called with signal %s.' % signum
-        display.display(msg, log_only=True)
-        raise Exception(msg)
+        display.display('signal handler called with signal %s' % signum, log_only=True)
+        self.shutdown()
 
     def shutdown(self):
         """ Shuts down the local domain socket
         """
-        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % os.path.split(self.socket_path))
         if os.path.exists(self.socket_path):
             try:
                 if self.sock:
                     self.sock.close()
                 if self.connection:
                     self.connection.close()
-            except Exception:
+            except:
                 pass
             finally:
                 if os.path.exists(self.socket_path):
                     os.remove(self.socket_path)
                     setattr(self.connection, '_socket_path', None)
                     setattr(self.connection, '_connected', False)
-
-        if os.path.exists(lock_path):
-            os.remove(lock_path)
-
         display.display('shutdown complete', log_only=True)
 
 
@@ -259,12 +241,12 @@ def main():
         tmp_path = unfrackpath(C.PERSISTENT_CONTROL_PATH_DIR)
         makedirs_safe(tmp_path)
 
+        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % (tmp_path, play_context.remote_addr))
         socket_path = unfrackpath(cp % dict(directory=tmp_path))
-        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % os.path.split(socket_path))
 
         with file_lock(lock_path):
             if not os.path.exists(socket_path):
-                messages.append(('vvvv', 'local domain socket does not exist, starting it'))
+                messages.append('local domain socket does not exist, starting it')
                 original_path = os.getcwd()
                 r, w = os.pipe()
                 pid = fork_process()
@@ -276,30 +258,27 @@ def main():
                         process = ConnectionProcess(wfd, play_context, socket_path, original_path, ansible_playbook_pid)
                         process.start(variables)
                     except Exception:
-                        messages.append(('error', traceback.format_exc()))
+                        messages.append(traceback.format_exc())
                         rc = 1
 
                     if rc == 0:
                         process.run()
-                    else:
-                        process.shutdown()
 
                     sys.exit(rc)
 
                 else:
                     os.close(w)
                     rfd = os.fdopen(r, 'r')
-                    data = json.loads(rfd.read(), cls=AnsibleJSONDecoder)
+                    data = json.loads(rfd.read())
                     messages.extend(data.pop('messages'))
                     result.update(data)
 
             else:
-                messages.append(('vvvv', 'found existing local domain socket, using it!'))
+                messages.append('found existing local domain socket, using it!')
                 conn = Connection(socket_path)
-                conn.set_options(var_options=variables)
                 pc_data = to_text(init_data)
                 try:
-                    conn.update_play_context(pc_data)
+                    messages.extend(conn.update_play_context(pc_data))
                 except Exception as exc:
                     # Only network_cli has update_play context, so missing this is
                     # not fatal e.g. netconf
@@ -311,9 +290,7 @@ def main():
                             'exception': traceback.format_exc()
                         })
 
-    if os.path.exists(socket_path):
-        messages.extend(Connection(socket_path).pop_messages())
-    messages.append(('vvvv', sys.stdout.getvalue()))
+    messages.append(sys.stdout.getvalue())
     result.update({
         'messages': messages,
         'socket_path': socket_path
@@ -322,10 +299,10 @@ def main():
     sys.stdout = saved_stdout
     if 'exception' in result:
         rc = 1
-        sys.stderr.write(json.dumps(result, cls=AnsibleJSONEncoder))
+        sys.stderr.write(json.dumps(result))
     else:
         rc = 0
-        sys.stdout.write(json.dumps(result, cls=AnsibleJSONEncoder))
+        sys.stdout.write(json.dumps(result))
 
     sys.exit(rc)
 

bin/ansible-test

@@ -1,15 +0,0 @@
-#!/usr/bin/env python
-# PYTHON_ARGCOMPLETE_OK
-"""Primary entry point for ansible-test."""
-
-from __future__ import (absolute_import, division, print_function)
-
-__metaclass__ = type
-
-import os
-import sys
-
-if __name__ == '__main__':
-    sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(os.path.dirname(__file__)), 'test', 'runner')))
-    import lib.cli
-    lib.cli.main()

changelogs/CHANGELOG-v2.6.rst

@@ -0,0 +1,703 @@
+========================================
+Ansible 2.6 "Heartbreaker" Release Notes
+========================================
+
+v2.6.4
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-09-06
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- add azure_rm_storageaccount support to StorageV2 kind. (https://github.com/ansible/ansible/pull/44242)
+- import_tasks - Do not allow import_tasks to transition to dynamic if the file is missing (https://github.com/ansible/ansible/issues/44822)
+
+Bugfixes
+--------
+
+- Add md5sum check in nxos_file_copy module (https://github.com/ansible/ansible/pull/43423).
+- Allow arbitrary ``log_driver`` for docker_container (https://github.com/ansible/ansible/pull/33579).
+- Fix Python2.6 regex bug terminal plugin nxos, iosxr (https://github.com/ansible/ansible/pull/45135).
+- Fix check_mode in nxos_static_route module (https://github.com/ansible/ansible/pull/44252).
+- Fix glob path of rc.d Some distribtuions like SUSE has the rc%.d directories under /etc/init.d
+- Fix network config diff issue for lines (https://github.com/ansible/ansible/pull/43889)
+- Fixed an issue where ``ansible_facts.pkg_mgr`` would incorrectly set to ``zypper`` on Debian/Ubuntu systems that happened to have the command installed.
+- The docker_* modules respect the DOCKER_* environment variables again (https://github.com/ansible/ansible/pull/42641).
+- The fix for `CVE-2018-10875 <https://access.redhat.com/security/cve/cve-2018-10875>`_ prints out a warning message about skipping a config file from a world writable current working directory.  However, if the user is in a world writable current working directory which does not contain a config file, it should not print a warning message.  This release fixes that extaneous warning.
+- To resolve nios_network issue where vendor-encapsulated-options can not have a use_option flag. (https://github.com/ansible/ansible/pull/43925)
+- To resolve the issue of handling exception for Nios lookup gracefully. (https://github.com/ansible/ansible/pull/44078)
+- always correctly template no log for tasks https://github.com/ansible/ansible/issues/43294
+- ansible-galaxy - properly list all roles in roles_path (https://github.com/ansible/ansible/issues/43010)
+- basic.py - catch ValueError in case a FIPS enabled platform raises this exception - https://github.com/ansible/ansible/issues/44447
+- docker_container: fixing ``working_dir`` idempotency problem (https://github.com/ansible/ansible/pull/42857)
+- docker_container: makes unit parsing for memory sizes more consistent, and fixes idempotency problem when ``kernel_memory`` is set (see https://github.com/ansible/ansible/pull/16748 and https://github.com/ansible/ansible/issues/42692)
+- fix  example code for AWS lightsail documentation
+- fix the enable_snat parameter that is only supposed to be used by an user with the right policies. https://github.com/ansible/ansible/pull/44418
+- fixes docker_container check and debug mode (https://github.com/ansible/ansible/pull/42380)
+- improves docker_container idempotency (https://github.com/ansible/ansible/pull/44808)
+- ios_l2_interface - fix bug when list of vlans ends with comma (https://github.com/ansible/ansible/pull/43879)
+- ios_l2_interface - fix issue with certain interface types (https://github.com/ansible/ansible/pull/43819)
+- ios_user - fix unable to delete user admin issue (https://github.com/ansible/ansible/pull/44904)
+- ios_vlan - fix unable to work on certain interface types issue (https://github.com/ansible/ansible/pull/43819)
+- nxos_facts test lldp feature and fix nxapi check_rc (https://github.com/ansible/ansible/pull/44104).
+- nxos_interface port-channel idempotence fix for mode (https://github.com/ansible/ansible/pull/44248).
+- nxos_linkagg mode fix (https://github.com/ansible/ansible/pull/44294).
+- nxos_system idempotence fix (https://github.com/ansible/ansible/pull/44752).
+- nxos_vlan refactor to support non structured output (https://github.com/ansible/ansible/pull/43805).
+- one_host - fixes settings via environment variables (https://github.com/ansible/ansible/pull/44568)
+- use retry_json nxos_banner (https://github.com/ansible/ansible/pull/44376).
+- user - Strip trailing comments in /etc/default/passwd (https://github.com/ansible/ansible/pull/43931)
+- user - when creating a new user without an expiration date, properly set no expiration rather that expirining the account (https://github.com/ansible/ansible/issues/44155)
+- win_domain_computer - fixed deletion of computer active directory object that have dependent objects (https://github.com/ansible/ansible/pull/44500)
+- win_domain_computer - fixed error in diff_support
+- win_domain_computer - fixed error when description parameter is empty (https://github.com/ansible/ansible/pull/44054)
+- win_psexec - changed code to not escape the command option when building the args - https://github.com/ansible/ansible/issues/43839
+- win_uri -- Fix support for JSON output when charset is set
+- win_wait_for - fix issue where timeout doesn't wait unless state=drained - https://github.com/ansible/ansible/issues/43446
+
+v2.6.3
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-08-16
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Bugfixes
+--------
+
+- Fix lxd module to be idempotent when the given configuration for the lxd container has not changed (https://github.com/ansible/ansible/pull/38166)
+- Fix setting value type to str to avoid conversion during template read. Fix Idempotency in case of 'no key'.
+- Fix the mount module's handling of swap entries in fstab (https://github.com/ansible/ansible/pull/42837)
+- The fix for `CVE-2018-10875 <https://access.redhat.com/security/cve/cve-2018-10875>`_ prints out a warning message about skipping a config file from a world writable current working directory.  However, if the user explicitly specifies that the config file should be used via the ANSIBLE_CONFIG environment variable then Ansible would honor that but still print out the warning message.  This has been fixed so that Ansible honors the user's explicit wishes and does not print a warning message in that circumstance.
+- To fix the bug where existing host_record was deleted when existing record name is used with different IP. (https://github.com/ansible/ansible/pull/43235)
+- VMware handle pnic in proxyswitch (https://github.com/ansible/ansible/pull/42996)
+- fix azure security group cannot add rules when purge_rule set to false. (https://github.com/ansible/ansible/pull/43699)
+- fix azure_rm_deployment collect tags from existing Resource Group. (https://github.com/ansible/ansible/pull/26104)
+- fix azure_rm_loadbalancer_facts list takes at least 2 arguments. (https://github.com/ansible/ansible/pull/29050)
+- fix for the bundled selectors module (used in the ssh and local connection plugins) when a syscall is restarted after being interrupted by a signal (https://github.com/ansible/ansible/issues/41630)
+- get_url - fix the bug that get_url does not change mode when checksum matches (https://github.com/ansible/ansible/issues/29614)
+- nicer error when multiprocessing breaks https://github.com/ansible/ansible/issues/43090
+- openssl_certificate - Convert valid_date to bytes for conversion
+- openstack_inventory.py dynamic inventory file fixed the plugin to the script so that it will work with current ansible-inventory. Also redirect stdout before dumping the ouptput, because not doing so will cause JSON parse errors in some cases. (https://github.com/ansible/ansible/pull/43432)
+- slack callback - Fix invocation by looking up data from cli.options (https://github.com/ansible/ansible/pull/43542)
+- sysvinit module: handle values of optional parameters (https://github.com/ansible/ansible/pull/42786). Don't disable service when `enabled` parameter isn't set. Fix command when `arguments` parameter isn't set.
+- vars_prompt - properly template play level variables in vars_prompt (https://github.com/ansible/ansible/issues/37984)
+- win_domain - ensure the Netlogon service is up and running after promoting host to controller - https://github.com/ansible/ansible/issues/39235
+- win_domain_controller - ensure the Netlogon service is up and running after promoting host to controller - https://github.com/ansible/ansible/issues/39235
+
+v2.6.2
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-07-27
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- Scenario guide for removing an existing virtual machine is added.
+- lineinfile - add warning when using an empty regexp (https://github.com/ansible/ansible/issues/29443)
+
+Bugfixes
+--------
+
+- Add text output along with structured output in nxos_facts (https://github.com/ansible/ansible/pull/42886).
+- Allow more than one page of results by using the right pagination indicator ('NextMarker' instead of 'NextToken').
+- Fix an atomic_move error that is 'true', but  misleading. Now we show all 3 files involved and clarify what happened.
+- Fix eos_l2_interface eapi (https://github.com/ansible/ansible/pull/42270).
+- Fix fetching old style facts in junos_facts module (https://github.com/ansible/ansible/pull/42351)
+- Fix get_device_info nxos zero or more whitespace regex (https://github.com/ansible/ansible/pull/43178).
+- Fix nxos CI failures (https://github.com/ansible/ansible/pull/42240).
+- Fix nxos_nxapi default http behavior (https://github.com/ansible/ansible/pull/41817).
+- Fix nxos_vxlan_vtep_vni (https://github.com/ansible/ansible/pull/42240).
+- Fix regex network_os_platform nxos (https://github.com/ansible/ansible/pull/42288).
+- Refactor nxos cliconf get_device_info for non structured output supported devices (https://github.com/ansible/ansible/pull/42089).
+- To fix the NoneType error raised in ios_l2_interface when Access Mode VLAN is unassigned (https://github.com/ansible/ansible/pull/42312)
+- emtpy host/group name is an error https://github.com/ansible/ansible/issues/42044
+- fix default SSL version for docker modules https://github.com/ansible/ansible/issues/42897
+- fix mail module when using starttls https://github.com/ansible/ansible/issues/42338
+- fix nmap config example https://github.com/ansible/ansible/pull/42925
+- fix ps detection of service https://github.com/ansible/ansible/pull/43014
+- fix the remote tmp folder permissions issue when becoming a non admin user - https://github.com/ansible/ansible/issues/41340, https://github.com/ansible/ansible/issues/42117
+- fix typoe in sysvinit that breaks update.rc-d detection https://github.com/ansible/ansible/issues/42734
+- fixes docker_container compatibilty with docker-py < 2.2
+- get_capabilities in nxapi module_utils should not return empty dictionary (https://github.com/ansible/ansible/pull/42688).
+- inventory - When using an inventory directory, ensure extension comparison uses text types (https://github.com/ansible/ansible/pull/42475)
+- ios_vlan - fix unable to identify correct vlans issue (https://github.com/ansible/ansible/pull/42247)
+- nxos_facts warning message improved (https://github.com/ansible/ansible/pull/42969).
+- openvswitch_db - make 'key' argument optional https://github.com/ansible/ansible/issues/42108
+- pause - do not set stdout to raw mode when redirecting to a file (https://github.com/ansible/ansible/issues/41717)
+- pause - nest try except when importing curses to gracefully fail if curses is not present (https://github.com/ansible/ansible/issues/42004)
+- plugins/inventory/openstack.py - Do not create group with empty name if region is not set
+- preseve delegation info on nolog https://github.com/ansible/ansible/issues/42344
+- remove ambiguity when it comes to 'the source'
+- remove dupes from var precedence
+- restores filtering out conflicting facts https://github.com/ansible/ansible/issues/41684
+- user - fix bug that resulted in module always reporting a change when specifiying the home directory on FreeBSD (https://github.com/ansible/ansible/issues/42484)
+- user - use correct attribute name in FreeBSD for creat_home (https://github.com/ansible/ansible/pull/42711)
+- vultr - Do not fail trying to load configuration from ini files if required variables have been set as environment variables.
+- vyos_command correcting conditionals looping (https://github.com/ansible/ansible/pull/43331).
+- win_chocolatey - enable TLSv1.2 support when downloading the Chocolatey installer https://github.com/ansible/ansible/issues/41906
+- win_reboot - fix for handling an already scheduled reboot and other minor log formatting issues
+- win_reboot - fix issue when overridding connection timeout hung the post reboot uptime check - https://github.com/ansible/ansible/issues/42185 https://github.com/ansible/ansible/issues/42294
+- win_reboot - handle post reboots when running test_command - https://github.com/ansible/ansible/issues/41713
+- win_security_policy - allows an empty string to reset a policy value https://github.com/ansible/ansible/issues/40869
+- win_share - discard any cmdlet output we don't use to ensure only the return json is received by Ansible
+- win_unzip - discard any cmdlet output we don't use to ensure only the return json is received by Ansible
+- win_updates - fixed module return value is lost in error in some cases (https://github.com/ansible/ansible/pull/42647)
+- win_user - Use LogonUser to validate the password as it does not rely on SMB/RPC to be available https://github.com/ansible/ansible/issues/24884
+
+v2.6.1
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-07-05
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- Restore module_utils.basic.BOOLEANS variable for backwards compatibility with the module API in older ansible releases.
+
+Bugfixes
+--------
+
+- **Security Fix** - avoid loading host/group vars from cwd when not specifying a playbook or playbook base dir
+- **Security Fix** - avoid using ansible.cfg in a world writable dir.
+- Fix junos_config confirm commit timeout issue (https://github.com/ansible/ansible/pull/41527)
+- file module - The touch subcommand had its diff output broken during the 2.6.x development cycle.  The patch to fix that broke check mode. This is now fixed (https://github.com/ansible/ansible/issues/42111)
+- inventory manager - This fixes required options being populated before the inventory config file is read, so the required options may be set in the config file.
+- nsupdate - allow hmac-sha384 https://github.com/ansible/ansible/pull/42209
+- win_domain - fixes typo in one of the AD cmdlets https://github.com/ansible/ansible/issues/41536
+- win_group_membership - uses the internal Ansible SID conversion logic and uses that when comparing group membership instead of the name https://github.com/ansible/ansible/issues/40649
+
+v2.6.0
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-06-28
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_
+
+
+Minor Changes
+-------------
+
+- Added an ``encoding`` option to the ``b64encode`` and ``b64decode`` filters to specify the encoding of the string that is base64 encoded.
+- PowerShell modules that use Convert-ToSID in Ansible.ModuleUtils.SID.psm1 like win_user_right now accept an actual SID as an input string. This means any local or domain accounts that are named like a SID need to be prefixed with the domain, hostname, or . to ensure it converts to that accounts SID https://github.com/ansible/ansible/issues/38502
+- Raise AnsibleParserError which was missing previously
+- The aws_ses_identity module supports check mode
+- ``postgresql_user`` module changed ``encrypted=yes`` to be the default. This shouldn't break any current playbooks, the module will just store passwords hashed by default. This change was done because Postgres 10 dropped support for ``UNENCRYPTED`` passwords and because all versions since Postgres 7.2 support storing encrypted passwords.
+- azure_rm_loadbalancer - add support for sku
+- azure_rm_publicipaddress - add support for sku
+- cloudflare_dns module - Removed restriction from protocol to allow other protocols than tcp and udp to be specified.
+- command module - Added argv option to allow command to be specified as a list vs. a string (https://github.com/ansible/ansible/issues/19392)
+- gem - add ability to specify a custom directory for installing gems (https://github.com/ansible/ansible/pull/38195)
+- import/include - Cache task_vars to speed up IncludedFile.process_include_results (https://github.com/ansible/ansible/pull/39026)
+- postgresql_user module - Changed encrypted=yes to be the default. This shouldn't break any current playbooks, the module will just store passwords hashed by default. This change was done because Postgres 10 dropped support for UNENCRYPTED passwords and because all versions since Postgres 7.2 support storing encrypted passwords.
+- vmware_target_canonical_facts module - The target_id parameter is an optional parameter.
+
+Deprecated Features
+-------------------
+
+- nxos_igmp_interface module - The oif_prefix and oif_source properties are deprecated. Use the oif_ps parameter with a dictionary of prefix and source to values instead.
+
+Removed Features (previously deprecated)
+----------------------------------------
+
+- removed the deprecated always_run task option, please use ``check_mode: no`` instead
+- win_chocolatey - removed deprecated upgrade option and choco_* output return values
+- win_feature - removed deprecated reboot option
+- win_iis_webapppool - removed the ability to supply attributes as a string in favour of a dictionary
+- win_package - removed deprecated name option
+- win_regedit - removed deprecated support for specifying HKCC as HCCC
+
+Bugfixes
+--------
+
+- **Security Fix** - Some connection exceptions would cause no_log specified on a task to be ignored.  If this happened, the task information, including any private information could have been displayed to stdout and (if enabled, not the default) logged to a log file specified in ansible.cfg's log_path. Additionally, sites which redirected stdout from ansible runs to a log file may have stored that private information onto disk that way as well. (https://github.com/ansible/ansible/pull/41414)
+- Changed the admin_users config option to not include "admin" by default as admin is frequently used for a non-privileged account  (https://github.com/ansible/ansible/pull/41164)
+- Changed the output to "text" for "show vrf" command as default "json" output format with respect to "eapi" transport was failing (https://github.com/ansible/ansible/pull/41470)
+- Document mode=preserve for both the copy and template module
+- Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response. (https://github.com/ansible/ansible/pull/41431)
+- Fix an encoding issue when parsing the examples from a plugins' documentation
+- Fix iosxr_config module to handle route-policy, community-set, prefix-set, as-path-set and rd-set blocks. All these blocks are part of route-policy language of iosxr.
+- Fix mode=preserve with remote_src=True for the copy module
+- Implement mode=preserve for the template module
+- The yaml callback plugin now allows non-ascii characters to be displayed.
+- Various grafana_* modules - Port away from the deprecated b64encodestring function to the b64encode function instead. https://github.com/ansible/ansible/pull/38388
+- added missing 'raise' to exception definition https://github.com/ansible/ansible/pull/41690
+- allow custom endpoints to be used in the aws_s3 module (https://github.com/ansible/ansible/pull/36832)
+- allow set_options to be called multiple times https://github.com/ansible/ansible/pull/41913
+- ansible-doc - fixed traceback on missing plugins (https://github.com/ansible/ansible/pull/41167)
+- cast the device_mapping volume size to an int in the ec2_ami module (https://github.com/ansible/ansible/pull/40938)
+- copy - fixed copy to only follow symlinks for files in the non-recursive case
+- copy module - The copy module was attempting to change the mode of files for remote_src=True even if mode was not set as a parameter.  This failed on filesystems which do not have permission bits (https://github.com/ansible/ansible/pull/40099)
+- copy module - fixed recursive copy with relative paths (https://github.com/ansible/ansible/pull/40166)
+- correct debug display for all cases https://github.com/ansible/ansible/pull/41331
+- correctly check hostvars for vars term https://github.com/ansible/ansible/pull/41819
+- correctly handle yaml inventory files when entries are null dicts https://github.com/ansible/ansible/issues/41692
+- dynamic includes - Allow inheriting attributes from static parents (https://github.com/ansible/ansible/pull/38827)
+- dynamic includes - Don't treat undefined vars for conditional includes as truthy (https://github.com/ansible/ansible/pull/39377)
+- dynamic includes - Fix IncludedFile comparison for free strategy (https://github.com/ansible/ansible/pull/37083)
+- dynamic includes - Improved performance by fixing re-parenting on copy (https://github.com/ansible/ansible/pull/38747)
+- dynamic includes - Use the copied and merged task for calculating task vars (https://github.com/ansible/ansible/pull/39762)
+- file - fixed the default follow behaviour of file to be true
+- file module - Eliminate an error if we're asked to remove a file but something removes it while we are processing the request (https://github.com/ansible/ansible/pull/39466)
+- file module - Fix error when recursively assigning permissions and a symlink to a nonexistent file is present in the directory tree (https://github.com/ansible/ansible/issues/39456)
+- file module - Fix error when running a task which assures a symlink to a nonexistent file exists for the second and subsequent times (https://github.com/ansible/ansible/issues/39558)
+- file module - The file module allowed the user to specify src as a parameter when state was not link or hard.  This is documented as only applying to state=link or state=hard but in previous Ansible, this could have an effect in rare cornercases.  For instance, "ansible -m file -a 'state=directory path=/tmp src=/var/lib'" would create /tmp/lib.  This has been disabled and a warning emitted (will change to an error in Ansible-2.10).
+- file module - The touch subcommand had its diff output broken during the 2.6.x development cycle.  This is now fixed (https://github.com/ansible/ansible/issues/41755)
+- fix BotoCoreError exception handling
+- fix apt-mark on debian6 (https://github.com/ansible/ansible/pull/41530)
+- fix async for the aws_s3 module by adding async support to the action plugin (https://github.com/ansible/ansible/pull/40826)
+- fix decrypting vault files for the aws_s3 module (https://github.com/ansible/ansible/pull/39634)
+- fix errors with S3-compatible APIs if they cannot use ACLs for buckets or objects
+- fix permission handling to try to download a file even if the user does not have permission to list all objects in the bucket
+- fixed config required handling, specifically for _terms in lookups https://github.com/ansible/ansible/pull/41740
+- gce_net - Fix sorting of allowed ports (https://github.com/ansible/ansible/pull/41567)
+- group_by - support implicit localhost (https://github.com/ansible/ansible/pull/41860)
+- import/include - Ensure role handlers have the proper parent, allowing for correct attribute inheritance (https://github.com/ansible/ansible/pull/39426)
+- import_playbook - Pass vars applied to import_playbook into parsing of the playbook as they may be needed to parse the imported plays (https://github.com/ansible/ansible/pull/39521)
+- include_role/import_role - Don't overwrite included role handlers with play handlers on parse (https://github.com/ansible/ansible/pull/39563)
+- include_role/import_role - Fix parameter templating (https://github.com/ansible/ansible/pull/36372)
+- include_role/import_role - Use the computed role name for include_role/import_role so to diffentiate between names computed from host vars (https://github.com/ansible/ansible/pull/39516)
+- include_role/import_role - improved performance and recursion depth (https://github.com/ansible/ansible/pull/36470)
+- lineinfile - fix insertbefore when used with BOF to not insert duplicate lines (https://github.com/ansible/ansible/issues/38219)
+- password lookup - Do not load password lookup in network filters, allowing the password lookup to be overriden (https://github.com/ansible/ansible/pull/41907)
+- pause - ensure ctrl+c interrupt works in all cases (https://github.com/ansible/ansible/issues/35372)
+- powershell - use the tmpdir set by ``remote_tmp`` for become/async tasks instead of the generic $env:TEMP - https://github.com/ansible/ansible/pull/40210
+- selinux - correct check mode behavior to report same changes as normal mode (https://github.com/ansible/ansible/pull/40721)
+- spwd - With python 3.6 spwd.getspnam returns PermissionError instead of KeyError if user does not have privileges (https://github.com/ansible/ansible/issues/39472)
+- synchronize - Ensure the local connection created by synchronize uses _remote_is_local=True, which causes ActionBase to build a local tmpdir (https://github.com/ansible/ansible/pull/40833)
+- template - Fix for encoding issues when a template path contains non-ascii characters and using the template path in ansible_managed (https://github.com/ansible/ansible/issues/27262)
+- template action plugin - fix the encoding of filenames to avoid tracebacks on Python2 when characters that are not present in the user's locale are present. (https://github.com/ansible/ansible/pull/39424)
+- user - only change the expiration time when necessary (https://github.com/ansible/ansible/issues/13235)
+- uses correct conn info for reset_connection  https://github.com/ansible/ansible/issues/27520
+- win_environment - Fix for issue where the environment value was deleted when a null value or empty string was set - https://github.com/ansible/ansible/issues/40450
+- win_file - fix issue where special chars like [ and ] were not being handled correctly https://github.com/ansible/ansible/pull/37901
+- win_get_url - fixed a few bugs around authentication and force no when using an FTP URL
+- win_iis_webapppool - redirect some module output to null so Ansible can read the output JSON https://github.com/ansible/ansible/issues/40874
+- win_template - fix when specifying the dest option as a directory with and without the trailing slash https://github.com/ansible/ansible/issues/39886
+- win_updates - Added the ability to run on a scheduled task for older hosts so async starts working again - https://github.com/ansible/ansible/issues/38364
+- win_updates - Fix logic when using a whitelist for multiple updates
+- win_updates - Fix typo that hid the download error when a download failed
+- win_updates - Fixed issue where running win_updates on async fails without any error
+- windows become - Show better error messages when the become process fails
+- winrm - Add better error handling when the kinit process fails
+- winrm - allow ``ansible_user`` or ``ansible_winrm_user`` to override ``ansible_ssh_user`` when both are defined in an inventory - https://github.com/ansible/ansible/issues/39844
+- winrm - ensure pexpect is set to not echo the input on a failure and have a manual sanity check afterwards https://github.com/ansible/ansible/issues/41865
+- winrm connection plugin - Fix exception messages sometimes raising a traceback when the winrm connection plugin encounters an unrecoverable error.  https://github.com/ansible/ansible/pull/39333
+- xenserver_facts - ensure module works with newer versions of XenServer (https://github.com/ansible/ansible/pull/35821)
+
+New Plugins
+-----------
+
+Callback
+~~~~~~~~
+
+- cgroup_memory_recap - Profiles maximum memory usage of tasks and full execution using cgroups
+- grafana_annotations - send ansible events as annotations on charts to grafana over http api.
+- sumologic - Sends task result events to Sumologic
+
+Connection
+~~~~~~~~~~
+
+- httpapi - Use httpapi to run command on network appliances
+
+Inventory
+~~~~~~~~~
+
+- foreman - foreman inventory source
+- gcp_compute - Google Cloud Compute Engine inventory source
+- generator - Uses Jinja2 to construct hosts and groups from patterns
+- nmap - Uses nmap to find hosts to target
+
+Lookup
+~~~~~~
+
+- onepassword - fetch field values from 1Password
+- onepassword_raw - fetch raw json data from 1Password
+
+New Modules
+-----------
+
+Cloud
+~~~~~
+
+amazon
+^^^^^^
+
+- aws_caller_facts - Get facts about the user and account being used to make AWS calls.
+- aws_config_aggregation_authorization - Manage cross-account AWS Config authorizations
+- aws_config_aggregator - Manage AWS Config aggregations across multiple accounts
+- aws_config_delivery_channel - Manage AWS Config delivery channels
+- aws_config_recorder - Manage AWS Config Recorders
+- aws_config_rule - Manage AWS Config resources
+- aws_glue_connection - Manage an AWS Glue connection
+- aws_glue_job - Manage an AWS Glue job
+- aws_inspector_target - Create, Update and Delete Amazon Inspector Assessment Targets
+- aws_ses_identity_policy - Manages SES sending authorization policies
+- aws_sgw_facts - Fetch AWS Storage Gateway facts
+- ec2_eip_facts - List EC2 EIP details
+- ec2_vpc_vpn_facts - Gather facts about VPN Connections in AWS.
+- elb_network_lb - Manage a Network Load Balancer
+- rds_instance_facts - obtain facts about one or more RDS instances
+- rds_snapshot_facts - obtain facts about one or more RDS snapshots
+
+azure
+^^^^^
+
+- azure_rm_aks - Manage a managed Azure Container Service (AKS) Instance.
+- azure_rm_aks_facts - Get Azure Kubernetes Service facts.
+- azure_rm_resource - Create any Azure resource.
+- azure_rm_resource_facts - Generic facts of Azure resources.
+
+cloudstack
+^^^^^^^^^^
+
+- cs_role_permission - Manages role permissions on Apache CloudStack based clouds.
+
+digital_ocean
+^^^^^^^^^^^^^
+
+- digital_ocean_account_facts - Gather facts about DigitalOcean User account
+- digital_ocean_certificate_facts - Gather facts about DigitalOcean certificates
+- digital_ocean_domain_facts - Gather facts about DigitalOcean Domains
+- digital_ocean_image_facts - Gather facts about DigitalOcean images
+- digital_ocean_load_balancer_facts - Gather facts about DigitalOcean load balancers
+- digital_ocean_region_facts - Gather facts about DigitalOcean regions
+- digital_ocean_size_facts - Gather facts about DigitalOcean Droplet sizes
+- digital_ocean_snapshot_facts - Gather facts about DigitalOcean Snapshot
+- digital_ocean_tag_facts - Gather facts about DigitalOcean tags
+- digital_ocean_volume_facts - Gather facts about DigitalOcean volumes
+
+google
+^^^^^^
+
+- gcp_compute_address - Creates a GCP Address
+- gcp_compute_backend_bucket - Creates a GCP BackendBucket
+- gcp_compute_backend_service - Creates a GCP BackendService
+- gcp_compute_disk - Creates a GCP Disk
+- gcp_compute_firewall - Creates a GCP Firewall
+- gcp_compute_forwarding_rule - Creates a GCP ForwardingRule
+- gcp_compute_global_address - Creates a GCP GlobalAddress
+- gcp_compute_global_forwarding_rule - Creates a GCP GlobalForwardingRule
+- gcp_compute_health_check - Creates a GCP HealthCheck
+- gcp_compute_http_health_check - Creates a GCP HttpHealthCheck
+- gcp_compute_https_health_check - Creates a GCP HttpsHealthCheck
+- gcp_compute_image - Creates a GCP Image
+- gcp_compute_instance - Creates a GCP Instance
+- gcp_compute_instance_group - Creates a GCP InstanceGroup
+- gcp_compute_instance_group_manager - Creates a GCP InstanceGroupManager
+- gcp_compute_instance_template - Creates a GCP InstanceTemplate
+- gcp_compute_network - Creates a GCP Network
+- gcp_compute_route - Creates a GCP Route
+- gcp_compute_ssl_certificate - Creates a GCP SslCertificate
+- gcp_compute_subnetwork - Creates a GCP Subnetwork
+- gcp_compute_target_http_proxy - Creates a GCP TargetHttpProxy
+- gcp_compute_target_https_proxy - Creates a GCP TargetHttpsProxy
+- gcp_compute_target_pool - Creates a GCP TargetPool
+- gcp_compute_target_ssl_proxy - Creates a GCP TargetSslProxy
+- gcp_compute_target_tcp_proxy - Creates a GCP TargetTcpProxy
+- gcp_compute_url_map - Creates a GCP UrlMap
+- gcp_container_cluster - Creates a GCP Cluster
+- gcp_container_node_pool - Creates a GCP NodePool
+- gcp_dns_resource_record_set - Creates a GCP ResourceRecordSet
+- gcp_pubsub_subscription - Creates a GCP Subscription
+- gcp_pubsub_topic - Creates a GCP Topic
+- gcp_storage_bucket - Creates a GCP Bucket
+- gcp_storage_bucket_access_control - Creates a GCP BucketAccessControl
+
+heroku
+^^^^^^
+
+- heroku_collaborator - Add or delete app collaborators on Heroku
+
+memset
+^^^^^^
+
+- memset_dns_reload - Request reload of Memset's DNS infrastructure,
+- memset_zone - Creates and deletes Memset DNS zones.
+- memset_zone_domain - Create and delete domains in Memset DNS zones.
+- memset_zone_record - Create and delete records in Memset DNS zones.
+
+misc
+^^^^
+
+- cloud_init_data_facts - Retrieve facts of cloud-init.
+
+opennebula
+^^^^^^^^^^
+
+- one_host - Manages OpenNebula Hosts
+- one_image - Manages OpenNebula images
+- one_image_facts - Gather facts about OpenNebula images
+- one_service - Deploy and manage OpenNebula services
+- one_vm - Creates or terminates OpenNebula instances
+
+openstack
+^^^^^^^^^
+
+- os_server_metadata - Add/Update/Delete Metadata in Compute Instances from OpenStack
+- os_volume_snapshot - Create/Delete Cinder Volume Snapshots
+
+scaleway
+^^^^^^^^
+
+- scaleway_compute - Scaleway compute management module
+- scaleway_sshkey - Scaleway SSH keys management module
+
+vmware
+^^^^^^
+
+- vmware_cluster_facts - Gather facts about clusters available in given vCenter
+- vmware_datastore_cluster - Manage VMware vSphere datastore clusters
+- vmware_datastore_maintenancemode - Place a datastore into maintenance mode
+- vmware_guest_disk_facts - Gather facts about disks of given virtual machine
+- vmware_guest_snapshot_facts - Gather facts about virtual machine's snapshots in vCenter
+- vmware_host_capability_facts - Gathers facts about an ESXi host's capability information
+- vmware_host_powerstate - Manages power states of host systems in vCenter
+- vmware_local_user_facts - Gather facts about users on the given ESXi host
+- vmware_portgroup_facts - Gathers facts about an ESXi host's portgroup configuration
+- vmware_resource_pool_facts - Gathers facts about resource pool information
+- vmware_tag - Manage VMware tags
+- vmware_tag_facts - Manage VMware tag facts
+- vmware_vswitch_facts - Gathers facts about an ESXi host's vswitch configurations
+
+Clustering
+~~~~~~~~~~
+
+k8s
+^^^
+
+- k8s - Manage Kubernetes (K8s) objects
+
+Commands
+~~~~~~~~
+
+- psexec - Runs commands on a remote Windows host based on the PsExec model
+
+Monitoring
+~~~~~~~~~~
+
+- spectrum_device - Creates/deletes devices in CA Spectrum.
+
+zabbix
+^^^^^^
+
+- zabbix_group_facts - Gather facts about Zabbix hostgroup
+
+Net Tools
+~~~~~~~~~
+
+ldap
+^^^^
+
+- ldap_passwd - Set passwords in LDAP.
+
+Network
+~~~~~~~
+
+aci
+^^^
+
+- aci_l3out - Manage Layer 3 Outside (L3Out) objects (l3ext:Out)
+
+avi
+^^^
+
+- avi_autoscalelaunchconfig - Module for setup of AutoScaleLaunchConfig Avi RESTful Object
+- avi_l4policyset - Module for setup of L4PolicySet Avi RESTful Object
+- avi_useraccount - Avi UserAccount Module
+
+cnos
+^^^^
+
+- cnos_command - Run arbitrary commands on Lenovo CNOS devices
+- cnos_config - Manage Lenovo CNOS configuration sections
+
+exos
+^^^^
+
+- exos_command - Run commands on remote devices running Extreme EXOS
+
+f5
+^^
+
+- bigip_data_group - Manage data groups on a BIG-IP
+- bigip_device_license - Manage license installation and activation on BIG-IP devices
+- bigip_gtm_global - Manages global GTM settings
+- bigip_gtm_monitor_bigip - Manages F5 BIG-IP GTM BIG-IP monitors
+- bigip_gtm_monitor_external - Manages external GTM monitors on a BIG-IP
+- bigip_gtm_monitor_firepass - Manages F5 BIG-IP GTM FirePass monitors
+- bigip_gtm_monitor_http - Manages F5 BIG-IP GTM http monitors
+- bigip_gtm_monitor_https - Manages F5 BIG-IP GTM https monitors
+- bigip_gtm_monitor_tcp - Manages F5 BIG-IP GTM tcp monitors
+- bigip_gtm_monitor_tcp_half_open - Manages F5 BIG-IP GTM tcp half-open monitors
+- bigip_gtm_pool_member - Manage GTM pool member settings
+- bigip_gtm_virtual_server - Manages F5 BIG-IP GTM virtual servers
+- bigip_log_destination - Manages log destinations on a BIG-IP.
+- bigip_log_publisher - Manages log publishers on a BIG-IP
+- bigip_management_route - Manage system management routes on a BIG-IP
+- bigip_monitor_external - Manages external LTM monitors on a BIG-IP
+- bigip_profile_dns - Manage DNS profiles on a BIG-IP
+- bigip_profile_tcp - Manage TCP profiles on a BIG-IP
+- bigip_profile_udp - Manage UDP profiles on a BIG-IP
+- bigip_service_policy - Manages service policies on a BIG-IP.
+- bigip_smtp - Manages SMTP settings on the BIG-IP
+- bigip_snmp_community - Manages SNMP communities on a BIG-IP.
+- bigip_timer_policy - Manage timer policies on a BIG-IP
+- bigip_trunk - Manage trunks on a BIG-IP
+- bigiq_application_fasthttp - Manages BIG-IQ FastHTTP applications
+- bigiq_application_fastl4_tcp - Manages BIG-IQ FastL4 TCP applications
+- bigiq_application_fastl4_udp - Manages BIG-IQ FastL4 UDP applications
+- bigiq_application_http - Manages BIG-IQ HTTP applications
+- bigiq_application_https_offload - Manages BIG-IQ HTTPS offload applications
+- bigiq_application_https_waf - Manages BIG-IQ HTTPS WAF applications
+- bigiq_regkey_license_assignment - Manage regkey license assignment on BIG-IPs from a BIG-IQ.
+- bigiq_utility_license - Manage utility licenses on a BIG-IQ
+
+files
+^^^^^
+
+- net_get - Copy a file from a network device to Ansible Controller
+- net_put - Copy a file from Ansible Controller to a network device
+
+fortios
+^^^^^^^
+
+- fortios_webfilter - Configure webfilter capabilities of FortiGate and FortiOS.
+
+meraki
+^^^^^^
+
+- meraki_admin - Manage administrators in the Meraki cloud
+- meraki_network - Manage networks in the Meraki cloud
+- meraki_organization - Manage organizations in the Meraki cloud
+- meraki_snmp - Manage organizations in the Meraki cloud
+
+netconf
+^^^^^^^
+
+- netconf_get - Fetch configuration/state data from NETCONF enabled network devices.
+- netconf_rpc - Execute operations on NETCONF enabled network devices.
+
+slxos
+^^^^^
+
+- slxos_command - Run commands on remote devices running Extreme Networks SLX-OS
+- slxos_config - Manage Extreme Networks SLX-OS configuration sections
+- slxos_facts - Collect facts from devices running Extreme SLX-OS
+- slxos_interface - Manage Interfaces on Extreme SLX-OS network devices
+- slxos_l2_interface - Manage Layer-2 interface on Extreme Networks SLXOS devices.
+- slxos_l3_interface - Manage L3 interfaces on Extreme Networks SLXOS network devices.
+- slxos_linkagg - Manage link aggregation groups on Extreme Networks SLXOS network devices
+- slxos_vlan - Manage VLANs on Extreme Networks SLX-OS network devices
+
+Packaging
+~~~~~~~~~
+
+language
+^^^^^^^^
+
+- yarn - Manage node.js packages with Yarn
+
+os
+^^
+
+- flatpak - Manage flatpaks
+- flatpak_remote - Manage flatpak repository remotes
+
+Source Control
+~~~~~~~~~~~~~~
+
+- gitlab_deploy_key - Manages GitLab project deploy keys.
+- gitlab_hooks - Manages GitLab project hooks.
+
+Storage
+~~~~~~~
+
+glusterfs
+^^^^^^^^^
+
+- gluster_peer - Attach/Detach peers to/from the cluster
+
+netapp
+^^^^^^
+
+- na_ontap_aggregate - Manage NetApp ONTAP aggregates.
+- na_ontap_broadcast_domain - Manage NetApp ONTAP broadcast domains.
+- na_ontap_broadcast_domain_ports - Manage NetApp Ontap broadcast domain ports
+- na_ontap_cifs - Manage NetApp cifs-share
+- na_ontap_cifs_acl - Manage NetApp cifs-share-access-control
+- na_ontap_cifs_server - cifs server configuration
+- na_ontap_cluster - Create/Join ONTAP cluster. Apply license to cluster
+- na_ontap_cluster_ha - Manage HA status for cluster
+- na_ontap_export_policy - Manage NetApp ONTAP export-policy
+- na_ontap_export_policy_rule - Manage ONTAP Export rules
+- na_ontap_igroup - ONTAP iSCSI igroup configuration
+- na_ontap_interface - ONTAP LIF configuration
+- na_ontap_iscsi - Manage NetApp Ontap iscsi service
+- na_ontap_job_schedule - Manage NetApp Ontap Job Schedule
+- na_ontap_license - Manage NetApp ONTAP protocol and feature licenses
+- na_ontap_lun - Manage  NetApp Ontap luns
+- na_ontap_lun_map - Manage NetApp Ontap lun maps
+- na_ontap_net_ifgrp - Create, modify, destroy the network interface group
+- na_ontap_net_port - Manage NetApp Ontap network ports.
+- na_ontap_net_routes - Manage NetApp Ontap network routes
+- na_ontap_net_vlan - Manage NetApp Ontap network vlan
+- na_ontap_nfs - Manage Ontap NFS status
+- na_ontap_ntp - Create/Delete/modify_version ONTAP NTP server
+- na_ontap_qtree - Manage qtrees
+- na_ontap_service_processor_network - Manage NetApp Ontap service processor network
+- na_ontap_snapshot - Manage NetApp Sanpshots
+- na_ontap_snmp - Manage NetApp SNMP community
+- na_ontap_svm - Manage NetApp Ontap svm
+- na_ontap_ucadapter - ONTAP UC adapter configuration
+- na_ontap_user - useradmin configuration and management
+- na_ontap_user_role - useradmin configuration and management
+- na_ontap_volume - Manage NetApp ONTAP volumes.
+- na_ontap_volume_clone - Manage NetApp Ontap volume clones.
+
+purestorage
+^^^^^^^^^^^
+
+- purefa_ds - Configure FlashArray Directory Service
+- purefa_facts - Collect facts from Pure Storage FlashArray
+- purefa_pgsnap - Manage protection group snapshots on Pure Storage FlashArrays
+- purefb_fs - Manage filesystemon Pure Storage FlashBlade`
+- purefb_snap - Manage filesystem snapshots on Pure Storage FlashBlades
+
+System
+~~~~~~
+
+- sysvinit - Manage SysV services.
+
+Web Infrastructure
+~~~~~~~~~~~~~~~~~~
+
+- acme_account - Create, modify or delete accounts with Let's Encrypt
+
+Windows
+~~~~~~~
+
+- win_domain_computer - Manage computers in Active Directory
+- win_hostname - Manages local Windows computer name.
+- win_pester - Run Pester tests on Windows hosts

changelogs/CHANGELOG.rst

@@ -1,6 +0,0 @@
-Placeholder changelog
-=====================
-
-This file is a placeholder; a version-specific ``CHANGELOG-vX.Y.rst`` will be generated during releases from fragments
-under changelogs/fragments. On release branches once a release has been created, consult the branch's version-specific
-file for changes that have occurred in that branch.

changelogs/fragments/11349-add-ansible_play_name-var.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-    - Add ``ansible_play_name`` magic var (https://github.com/ansible/ansible/issues/11349)

changelogs/fragments/11935-slack-add_hex_color_values.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-    - Add support for hex color values in Slack module.

changelogs/fragments/16748-docker_container-memory.yaml

@@ -0,0 +1,5 @@
+bugfixes:
+- "docker_container: makes unit parsing for memory sizes more consistent, and
+   fixes idempotency problem when ``kernel_memory`` is set (see
+   https://github.com/ansible/ansible/pull/16748 and
+   https://github.com/ansible/ansible/issues/42692)"

changelogs/fragments/2.8-core-deprecations.yaml

@@ -1,4 +0,0 @@
-minor_changes:
-- ansible.vars.unsafe_proxy - Removed deprecated file (https://github.com/ansible/ansible/issues/45040)
-- fetch - Removed deprecated validate_md5 alias (https://github.com/ansible/ansible/issues/45039)
-- include_role/import_role - Removed deprecated private argument (https://github.com/ansible/ansible/issues/45038)

changelogs/fragments/2.8-removed-modules.yaml

@@ -1,6 +0,0 @@
-removed_features:
-- ec2_remote_facts - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- azure - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- cs_nic - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- netscaler - deprecated module removed (https://github.com/ansible/ansible/pull/44985)
-- win_msi - deprecated module removed (https://github.com/ansible/ansible/pull/44985)

changelogs/fragments/22766-fact-cmdline-return_multiple_lvm_values.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- cmdline fact parsing can return multiple values of a single key. Deprecate cmdline fact in favor of proc_cmdline.

changelogs/fragments/24004-yum-dnf-add-download_dir-param.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - yum/dnf - Add download_dir param (https://github.com/ansible/ansible/issues/24004)

changelogs/fragments/24633-copy-coherency-between-check-normal-mode.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - copy - align invocation in return value between check and normal mode

changelogs/fragments/26937-fix-remove-orphans.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - docker_compose - fixed an issue where ``remove_orphans`` doesn't work reliably.

changelogs/fragments/27237-handlers-template-run_once.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - Fix handlers to allow for templated values in run_once (https://github.com/ansible/ansible/issues/27237)

changelogs/fragments/29135-include_vars-check_for_main.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- Enhance the conditional check to include main.yml if it is not from 'role/vars/' (https://github.com/ansible/ansible/pull/51926).

changelogs/fragments/31735-fix-hostnames-lookup-order.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - inventory_hostnames lookup - use the same order for the returned hosts as the inventory manager

changelogs/fragments/32366-test-match_fix_docs.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-    - Fix documentation of match test. Match requires zero or more characters at beginning of the string.

changelogs/fragments/33579-docker_container-log_driver.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "Allow arbitrary ``log_driver`` for docker_container (https://github.com/ansible/ansible/pull/33579)."

changelogs/fragments/33740-osx_say_callback_renamed_say.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - "``osx_say`` callback plugin was renamed into ``say``."

changelogs/fragments/33754-docker_image_fix_changed_in_force_mode.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_image - set ``changed`` to ``false`` when using ``force: yes`` to load or build an image that ends up being identical to one already present on the Docker host."

changelogs/fragments/34209-template-lookup-vault-support.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-  - Allow for vaulted templates in template lookup (https://github.com/ansible/ansible/issues/34209)

changelogs/fragments/35331-postgres_privs-add-all_in_schema-for-functions.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-  - postgres_privs now accepts 'ALL_IN_SCHEMA' objs for 'function' type (https://github.com/ansible/ansible/pull/35331).

changelogs/fragments/35370-add_support_for_docker_network_internal_flag.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - "docker_network - ``internal`` is now used to set the ``Internal`` property of the docker network during creation."

changelogs/fragments/36811-fix-lvol-valueerror-with-float-size.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - lvol - fixed ValueError when using float size (https://github.com/ansible/ansible/issues/32886, https://github.com/ansible/ansible/issues/29429)

changelogs/fragments/37150-make_modprobe_module_check_for_builtins_as_well.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-- "modprobe - The modprobe module now detects builtin kernel modules. If a kernel module is builtin the modprobe module will now: succeed (without incorrectly reporting changed) if ``state`` is ``present``; and fail if ``state`` is ``absent`` (with an error message like ``modprobe: ERROR: Module nfs is builtin.``). (https://github.com/ansible/ansible/pull/37150)"

changelogs/fragments/38118-postgresql_user-fix_conn_limit_type.yml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - conn_limit type is set to 'int' in postgresql_user module. This will allow module to compare conn_limit with record value without type casting.

changelogs/fragments/38803-postgresql_privs_fdw_and_fs_obj_types.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - "postgresql_privs - introduces support for FOREIGN DATA WRAPPER and FOREIGN SERVER as object types in postgresql_privs module. (https://github.com/ansible/ansible/issues/38801)"

changelogs/fragments/38833-docker_volume-option-minimum-versions.yml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - "docker_volume - option minimal versions now checked. (https://github.com/ansible/ansible/issues/38833)"

changelogs/fragments/38878-hashi_vault-support_userpass.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- hashi_vault lookup plugin now supports username and password method for the authentication (https://github.com/ansible/ansible/issues/38878).

changelogs/fragments/40092-mysql_user-match-backticks.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - "mysql_user: match backticks, single and double quotes when checking user privileges."

changelogs/fragments/40174-junit-test-case-prefix-filter.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-- junit callback plug-in - introduce a new option to consider a task only as test case if it has this value as prefix.

changelogs/fragments/40176-junit-hide-task-arguments.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-- junit callback plug-in - introduce a new option to hide task arguments similar to no_log.

changelogs/fragments/40366-modify-existing-volume.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - "add support for extending volumes in os_volume, also add module support for check_mode and diff"

changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - postgresql_db - the module fails not always when pg_dump errors occurred (https://github.com/ansible/ansible/issues/40424).

changelogs/fragments/40839-docker_container_init.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- fixes docker_container compatibilty with docker-py < 2.2

changelogs/fragments/41167_ansible_doc_regression.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- ansible-doc - fixed traceback on missing plugins (https://github.com/ansible/ansible/pull/41167)

changelogs/fragments/41240-fix-os_quota-without-cinder.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-  - "os_quota - fix failure to set compute or network quota when volume service is not available"

changelogs/fragments/41530-apt-mark-deb6.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - fix apt-mark on debian6 (https://github.com/ansible/ansible/pull/41530)

changelogs/fragments/42042-inventory_with_no_region.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- plugins/inventory/openstack.py - Do not create group with empty name if region is not set

changelogs/fragments/42380-docker_container-check-mode.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "fixes docker_container check and debug mode (https://github.com/ansible/ansible/pull/42380)"

changelogs/fragments/42482-ipa_dnsrecord-srv_mx_record.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- Added support for MX and SRV record in ipa_dnsrecord module (https://github.com/ansible/ansible/pull/42482).

changelogs/fragments/42641-44812-docker-env-variables.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "The docker_* modules respect the DOCKER_* environment variables again (https://github.com/ansible/ansible/pull/42641)."

changelogs/fragments/42647-win_updates.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- win_updates - fixed module return value is lost in error in some cases (https://github.com/ansible/ansible/pull/42647)

changelogs/fragments/42786-sysvinit-fix-2-issues.yml

@@ -0,0 +1,4 @@
+bugfixes:
+- "sysvinit module: handle values of optional parameters (https://github.com/ansible/ansible/pull/42786).
+  Don't disable service when `enabled` parameter isn't set.
+  Fix command when `arguments` parameter isn't set."

changelogs/fragments/42857-docker_container-working_dir.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container: fixing ``working_dir`` idempotency problem (https://github.com/ansible/ansible/pull/42857)"

changelogs/fragments/42866-galaxy-search-unicode.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-   - ansible-galaxy - Prevent unicode errors when searching - https://github.com/ansible/ansible/issues/42866

changelogs/fragments/42943_vmware_vmnic_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- VMware handle pnic in proxyswitch (https://github.com/ansible/ansible/pull/42996)

changelogs/fragments/43123-add_support_for_per_host_no_stats.yaml

@@ -1,3 +0,0 @@
----
-minor_changes:
-  - Add support for per_host:no stats for the callback plugin **json** (https://github.com/ansible/ansible/pull/43123)

changelogs/fragments/43874-docker_container-stop_timeout.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - ``stop_timeout`` is now also used to set the ``StopTimeout`` property of the docker container when creating the container."

changelogs/fragments/43931-strip-trailing-comments.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - user - Strip trailing comments in /etc/default/passwd (https://github.com/ansible/ansible/pull/43931)

changelogs/fragments/44054--win_domain_computer.yaml

@@ -0,0 +1,3 @@
+bugfixes:
+- win_domain_computer - fixed error when description parameter is empty (https://github.com/ansible/ansible/pull/44054)
+- win_domain_computer - fixed error in diff_support

changelogs/fragments/44278-pamd_valid_simple_controls.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- pamd - Allow for validation of definitive control in pamd module.

changelogs/fragments/44412-copy-fix-unwanted-acls.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - Fix unwanted ACLs when using copy module (https://github.com/ansible/ansible/issues/44412)

changelogs/fragments/44428-inventory-plugin-list.yml

@@ -1,3 +0,0 @@
-minor_changes:
-  - "default value for ``INVENTORY_ENABLED`` option was ``['host_list', 'script', 'yaml', 'ini', 'toml', 'auto']``
-    and is now ``['host_list', 'script', 'auto', 'yaml', 'ini', 'toml']``"

changelogs/fragments/44500-win_domain_computer.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- win_domain_computer - fixed deletion of computer active directory object that have dependent objects (https://github.com/ansible/ansible/pull/44500)

changelogs/fragments/44561-vmware_host_config_manager-fix_key_error.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- Fixed KeyError issue in vmware_host_config_manager when a supported option isn't already set (https://github.com/ansible/ansible/issues/44561).

changelogs/fragments/44692-docker-find-image.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container, docker_image, docker_image_facts - also find local image when image name is prefixed with ``docker.io/library/`` or ``docker.io/``."

changelogs/fragments/44739-assemble-avoid-extra-newline-Py3.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - assemble - avoid extra newline on Python 3 (https://github.com/ansible/ansible/issues/44739)

changelogs/fragments/44789-docker_container-comparisons.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "The restart/idempotency behavior of docker_container can now be controlled with the new comparisons parameter."

changelogs/fragments/44808-docker_container-idempotency.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "improves docker_container idempotency (https://github.com/ansible/ansible/pull/44808)"

changelogs/fragments/44811-xml-insertbefore-and-insertafter-parameters.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-  - xml - Introduce ``insertbefore`` and ``insertafter`` to specify the position (https://github.com/ansible/ansible/pull/44811)

changelogs/fragments/44988-acme-post-as-get.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "ACME modules support `POST-as-GET <https://community.letsencrypt.org/t/acme-v2-scheduled-deprecation-of-unauthenticated-resource-gets/74380>`__ and will be able to access Let's Encrypt ACME v2 endpoint after November 1st, 2019."

changelogs/fragments/45155-vmware_host_service_facts-update_docs.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- Update docs and return section of vmware_host_service_facts module.

changelogs/fragments/45355-mysql_user-fix-versions-compatibilities.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- "mysql_user: fix compatibility issues with various MySQL/MariaDB versions"

changelogs/fragments/45628-fetch_url-error-headers.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "fetch_url did not always return lower-case header names in case of HTTP errors (https://github.com/ansible/ansible/pull/45628)."

changelogs/fragments/45824-uri-fix-TypeError.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-  - "uri: fix TypeError when file can't be saved"

changelogs/fragments/46322-docker_container-image-not-given.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container - the behavior is improved in case ``image`` is not specified, but needed for (re-)creating the container."

changelogs/fragments/46443-mongodb_user-fix-roles-default-value.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- mongodb_user - Change value for parameter roles to empty (https://github.com/ansible/ansible/issues/46443)

changelogs/fragments/46483-role_names-change.yaml

@@ -1,11 +0,0 @@
-minor_changes:
-  - magic variables - added a new ``ansible_role_names`` magic variable to include the names of roles being applied to
-    the host both directly and indirectly (via dependencies).
-  - magic variables - added a new ``ansible_play_role_names`` magic variable to mimic the old functionality of
-    ``role_names``. This variable only lists the names of roles being applied to the host directly, and does not
-    include those added via dependencies
-  - magic variables - added a new ``ansible_dependent_role_names`` magic variable to contain the names of roles
-    applied to the host indirectly, via dependencies.
-deprecated_features:
-  - magic variables - documented the deprecation of the ``role_names`` magic variable in favor of either
-    ``ansible_role_names`` (including dependency role names) or ``ansible_play_role_names`` (excluding dependencies).

changelogs/fragments/46594-docker_container-publish-all-ports.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container - ``publish_ports: all`` was not used correctly when checking idempotency."

changelogs/fragments/46595-docker_container-expected_ports.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- "docker_container - fix idempotency check for published_ports in some special cases."

changelogs/fragments/46596-docker_container-published_ports.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - published_ports now supports port ranges, IPv6 addresses, and no longer accepts hostnames, which were never used correctly anyway."

changelogs/fragments/46598-docker_container-volume-modes.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - mount modes in ``volumes`` allow more values, similar to when using the ``docker`` executable."

changelogs/fragments/46608_azure_rm_inv_py3.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- azure_rm inventory plugin - fix runtime error under Python3 (https://github.com/ansible/ansible/pull/46608)

changelogs/fragments/46658-plugin_filter-improve_error_handling.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- Parsing plugin filter may raise TypeError, gracefully handle this exception and let user know about the syntax error in plugin filter file.

changelogs/fragments/46739-gcp-compute-instance-metadata.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - "gcp_compute_instance - fix crash when the instance metadata is not set"

changelogs/fragments/46740-gcp-utils-credentials-scoping.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - "gcp_utils - fix google auth scoping issue with application default credentials or google cloud engine credentials. Only scope credentials that can be scoped."

changelogs/fragments/46743-fix-native-jinja-newlines.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-    - templar - Do not strip new lines in native jinja - https://github.com/ansible/ansible/issues/46743

changelogs/fragments/46772-docker_container-healthcheck.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - Added support for healthcheck."

changelogs/fragments/46961_fix_aws_ec2_cache.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - aws_ec2 - fixed issue where cache did not contain the computed groups