New release v2.7.1

* Major slow down due to using the wrong loader for plugin_types
* traceback due to adding httpapi and cliconf plugins to the plugins we
allow ansible-doc to process
(cherry picked from commit e5a245d)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>

.coveragerc

@@ -0,0 +1,26 @@
+# This configuration file is used for manual execution of coverage
+# as well as for tests run through ansible-test.
+
+[run]
+branch = True
+
+# Enable concurrency. This also enables parallel mode, which results in
+# multiple coverage files being created. Concurrency allows us to collect
+# results from multiple tests simultaneously, as well as supporting multiple
+# test runs, such as from integration tests.
+concurrency = multiprocessing
+parallel = True
+
+# When running tests through ansible-test, this option is overridden by
+# the COVERAGE_FILE environment variable. This option is present for
+# convenience when running coverage manually from this directory.
+data_file = test/results/coverage/coverage
+
+# Don't collect or report code coverage from files matching these patterns.
+omit =
+    */python*/dist-packages/*
+    */python*/site-packages/*
+    */python*/distutils/*
+    */pyshared/*
+    */pytest
+    */AnsiballZ_*.py

.github/CONTRIBUTING.md

@@ -4,22 +4,25 @@ Hi! Nice to see you here!
 
 ## QUESTIONS ?
 
-Please see the [Community Guide](https://docs.ansible.com/ansible/latest/community/index.html) for information on how to ask questions on the [mailing lists](https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information) and IRC.
+Please see the [community guide](https://docs.ansible.com/ansible/latest/community/index.html) for information on how to ask questions on the [mailing lists](https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information) and IRC.
 
 The GitHub issue tracker is not the best place for questions for various reasons, but both IRC and the mailing list are very helpful places for those things, as the community page explains best.
 
 ## CONTRIBUTING ?
 
-By contributing you agree that these contributions are your own (or approved by your employer) and you grant a full, complete, irrevocable copyright license to all users and developers of the project, present and future, pursuant to the license of the project. You can also read the same [CLA](https://docs.ansible.com/ansible/latest/community/contributor_license_agreement.html) on the Ansible docsite.
+By contributing you agree that these contributions are your own (or approved by your employer) and you grant a full, complete, irrevocable copyright license to all users and developers of the project, present and future, pursuant to the license of the project.
 
-Please review the [Community Guide](https://docs.ansible.com/ansible/latest/community/index.html) for more information on contributing to Ansible.
+Please see the [community guide](https://docs.ansible.com/ansible/latest/community/index.html) for information regarding the contribution process. Important license agreement information is also included on that page.
 
 ## BUG TO REPORT ?
 
-First and foremost, also check the [Community Guide](https://docs.ansible.com/ansible/latest/community/index.html).
+First and foremost, also check the [community guide](https://docs.ansible.com/ansible/latest/community/index.html).
 
 You can report bugs or make enhancement requests at the [Ansible GitHub issue page](http://github.com/ansible/ansible/issues/new/choose) by filling out the issue template that will be presented.
 
-Also please make sure you are testing on the latest released version of Ansible or the development branch; see the [Installation Guide](https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html) for details.
+Also please make sure you are testing on the latest released version of Ansible or the development branch. You can find the latest releases and development branch at:
+
+- https://github.com/ansible/ansible/releases
+- https://github.com/ansible/ansible/archive/devel.tar.gz
 
 Thanks!

.github/ISSUE_TEMPLATE.md

@@ -1 +1,58 @@
-Please raise issues via the [new interface](https://github.com/ansible/ansible/issues/new/choose)
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
+
+##### SUMMARY
+<!--- Explain the problem briefly -->
+
+##### ISSUE TYPE
+<!--- Pick one below and delete the rest -->
+ - Bug Report
+ - Feature Idea
+ - Documentation Report
+
+##### COMPONENT NAME
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
+
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
+
+```
+
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,54 +1,61 @@
 ---
 name: 🐛 Bug report
 about: Create a report to help us improve
+
 ---
-<!--- Verify first that your issue is not already reported on GitHub -->
-<!--- Also test if the latest release and devel branch are affected too -->
-<!--- Complete *all* sections as described, this form is processed automatically -->
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
 
 ##### SUMMARY
-<!--- Explain the problem briefly below -->
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-- Bug Report
+ - Bug Report
 
 ##### COMPONENT NAME
-<!--- Write the short name of the module, plugin, task or feature below, use your best guess if unsure -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
 ##### ANSIBLE VERSION
-<!--- Paste verbatim output from "ansible --version" between quotes -->
-```paste below
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
 
 ```
 
 ##### CONFIGURATION
-<!--- Paste verbatim output from "ansible-config dump --only-changed" between quotes -->
-```paste below
-
-```
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
 
 ##### OS / ENVIRONMENT
-<!--- Provide all relevant information below, e.g. target OS versions, network device firmware, etc. -->
-
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
 
 ##### STEPS TO REPRODUCE
-<!--- Describe exactly how to reproduce the problem, using a minimal test-case -->
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
 
 <!--- Paste example playbooks or commands between quotes below -->
 ```yaml
 
 ```
 
-<!--- HINT: You can paste gist.github.com links for larger files -->
+<!--- You can also paste gist.github.com links for larger files -->
 
 ##### EXPECTED RESULTS
-<!--- Describe what you expected to happen when running the steps above -->
-
+<!--- What did you expect to happen when running the steps above? -->
 
 ##### ACTUAL RESULTS
-<!--- Describe what actually happened. If possible run with extra verbosity (-vvvv) -->
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
 
-<!--- Paste verbatim command output between quotes -->
-```paste below
+<!--- Paste verbatim command output between quotes below -->
+```
 
 ```

.github/ISSUE_TEMPLATE/documentation_report.md

@@ -1,38 +1,61 @@
 ---
 name: 📝 Documentation Report
 about: Ask us about docs
+
 ---
-<!--- Verify first that your improvement is not already reported on GitHub -->
-<!--- Also test if the latest release and devel branch are affected too -->
-<!--- Complete *all* sections as described, this form is processed automatically -->
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
 
 ##### SUMMARY
-<!--- Explain the problem briefly below, add suggestions to wording or structure -->
-
-<!--- HINT: Did you know the documentation has an "Edit on GitHub" link on every page ? -->
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-- Documentation Report
+ - Documentation Report
 
 ##### COMPONENT NAME
-<!--- Write the short name of the rst file, module, plugin, task or feature below, use your best guess if unsure -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
 ##### ANSIBLE VERSION
-<!--- Paste verbatim output from "ansible --version" between quotes -->
-```paste below
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
 
 ```
 
 ##### CONFIGURATION
-<!--- Paste verbatim output from "ansible-config dump --only-changed" between quotes -->
-```paste below
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
+
+<!--- Paste example playbooks or commands between quotes below -->
+```yaml
 
 ```
 
-##### OS / ENVIRONMENT
-<!--- Provide all relevant information below, e.g. OS version, browser, etc. -->
+<!--- You can also paste gist.github.com links for larger files -->
 
-##### ADDITIONAL INFORMATION
-<!--- Describe how this improves the documentation, e.g. before/after situation or screenshots -->
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
 
-<!--- HINT: You can paste gist.github.com links for larger files -->
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,25 +1,61 @@
 ---
 name: ✨ Feature request
 about: Suggest an idea for this project
+
 ---
-<!--- Verify first that your feature was not already discussed on GitHub -->
-<!--- Complete *all* sections as described, this form is processed automatically -->
+
+<!---
+Verify first that your issue/request is not already reported on GitHub.
+THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
+Also test if the latest release, and devel branch are affected too.
+ALWAYS add information AFTER (OUTSIDE) these html comments.
+Otherwise it may end up being automatically closed by our bot. -->
 
 ##### SUMMARY
-<!--- Describe the new feature/improvement briefly below -->
+<!--- Explain the problem briefly -->
 
 ##### ISSUE TYPE
-- Feature Idea
+ - Feature Idea
 
 ##### COMPONENT NAME
-<!--- Write the short name of the module, plugin, task or feature below, use your best guess if unsure -->
+<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
+Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or the full path-->
 
-##### ADDITIONAL INFORMATION
-<!--- Describe how the feature would be used, why it is needed and what it would solve -->
+##### ANSIBLE VERSION
+<!--- Paste, BELOW THIS COMMENT, verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+##### CONFIGURATION
+<!--- If using Ansible 2.4 or above, paste, BELOW THIS COMMENT, the results of "ansible-config dump --only-changed"
+Otherwise, mention any settings you have changed/added/removed in ansible.cfg
+(or using the ANSIBLE_* environment variables).-->
+
+##### OS / ENVIRONMENT
+<!--- Mention, BELOW THIS COMMENT, the OS you are running Ansible from, and the OS you are
+managing, or say "N/A" for anything that is not platform-specific.
+Also mention the specific version of what you are trying to control,
+e.g. if this is a network bug the version of firmware on the network device.-->
+
+##### STEPS TO REPRODUCE
+<!--- For bugs, show exactly how to reproduce the problem, using a minimal test-case.
+For new features, show how the feature would be used. -->
 
 <!--- Paste example playbooks or commands between quotes below -->
 ```yaml
 
 ```
 
-<!--- HINT: You can also paste gist.github.com links for larger files -->
+<!--- You can also paste gist.github.com links for larger files -->
+
+##### EXPECTED RESULTS
+<!--- What did you expect to happen when running the steps above? -->
+
+##### ACTUAL RESULTS
+<!--- What actually happened? If possible run with extra verbosity (-vvvv) -->
+
+<!--- Paste verbatim command output between quotes below -->
+```
+
+```

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,23 +1,33 @@
 ##### SUMMARY
-<!--- Describe the change below, including rationale and design decisions -->
+<!--- Describe the change, including rationale and design decisions -->
 
-<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
+<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
+commit message and your description; but you should still explain what
+the change does.-->
 
 ##### ISSUE TYPE
-<!--- Pick one below and delete the rest -->
-- Bugfix Pull Request
-- Docs Pull Request
-- Feature Pull Request
-- New Module Pull Request
+<!--- Pick one below and delete the rest: -->
+ - Feature Pull Request
+ - New Module Pull Request
+ - Bugfix Pull Request
+ - Docs Pull Request
 
 ##### COMPONENT NAME
-<!--- Write the short name of the module, plugin, task or feature below -->
+<!--- Name of the module, plugin, task or feature -->
 
-##### ADDITIONAL INFORMATION
-<!--- Include additional information to help people understand the change here -->
-<!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->
-
-<!--- Paste verbatim command output below, e.g. before and after your change -->
-```paste below
+##### ANSIBLE VERSION
+<!--- Paste verbatim output from "ansible --version" between quotes below -->
+```
+
+```
+
+
+##### ADDITIONAL INFORMATION
+<!--- Include additional information to help people understand the change here.
+For bugs that don't have a linked bug report, a step-by-step reproduction
+of the problem is helpful. -->
+
+<!--- Paste verbatim command output below, e.g. before and after your change -->
+```
 
 ```

.github/SECURITY.md

@@ -1,15 +0,0 @@
-# Security Policy
-
-## Supported Versions
-
-Ansible applies security fixes according to the 3-versions-back support
-policy. Please find more information in [our docs](
-https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#release-status
-).
-
-## Reporting a Vulnerability
-
-We encourage responsible disclosure practices for security
-vulnerabilities. Please read our [policies for reporting bugs](
-https://docs.ansible.com/ansible/devel/community/reporting_bugs_and_features.html#reporting-a-bug
-) if you want to report a security issue that might affect Ansible.

.gitignore

@@ -29,13 +29,13 @@ docs/man/man3/*
 *.sublime-project
 *.sublime-workspace
 # docsite stuff...
+docs/api/_build/
+docs/api/rst/
 docs/docsite/_build
 docs/docsite/*.html
 docs/docsite/htmlout
 docs/docsite/rst/cli/ansible-*.rst
 docs/docsite/rst/cli/ansible.rst
-docs/docsite/rst/dev_guide/collections_galaxy_meta.rst
-docs/docsite/rst/dev_guide/testing/sanity/index.rst.new
 docs/docsite/rst/modules/*.rst
 docs/docsite/rst/playbooks_directives.rst
 docs/docsite/rst/plugins_by_category.rst
@@ -79,8 +79,15 @@ ansible.egg-info/
 # Release directory
 packaging/release/ansible_release
 /.cache/
-/test/results/
-/test/integration/cloud-config-aws.yml
+/test/results/coverage/*=coverage.*
+/test/results/coverage/coverage*
+/test/results/reports/coverage*.xml
+/test/results/reports/coverage*/
+/test/results/bot/*.json
+/test/results/junit/*.xml
+/test/results/logs/*.log
+/test/results/data/*.json
+/test/integration/inventory.remote
 /test/integration/inventory.networking
 /test/integration/inventory.winrm
 /test/integration/cloud-config-aws.yml
@@ -98,6 +105,3 @@ test/units/.coverage.*
 /test/integration/cloud-config-azure.yml
 /SYMLINK_CACHE.json
 changelogs/.plugin-cache.yaml
-.ansible-test-timeout.json
-# ansible-test temporary metadata file for use with delgation
-/metadata-*.json

CODING_GUIDELINES.md

@@ -1,10 +1,316 @@
 Coding Guidelines
 =================
 
-Hi! Thanks for your interest in contributing to Ansible. We document our Coding Guidelines in the [Developer Guide](https://docs.ansible.com/ansible/devel/dev_guide/). We particularly suggest you review:
+Hi!  Thanks for your interest in contributing to Ansible.
 
-* [Contributing your module to Ansible](https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_checklist.html)
+Here are some guidelines for contributing code.  The purpose of this document is to establish what we're looking for in code contributions, and to make sure
+new contributors know some of the conventions that we've been using.
 
-* [Development conventions, tips and pitfalls](https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html)
+We don't think much of this should be too strange to readers familiar with contributing to Python projects, though it helps if we all get on the same page.
 
-Our [Community Guide](https://docs.ansible.com/ansible/devel/community/) may also help you connect with the community of Ansible developers.
+Language
+========
+
+  * While not all components of Ansible must be in Python, core contributions to the Ansible repo must be written in Python.  This is to maximize the ability of everyone to contribute.
+  * If you want to write non-Python ansible modules or inventory scripts, that's fine, but they are not going to get merged in most likely.  Sorry!!
+
+PEP 8 and basic style checks
+============================
+
+  * [PEP 8](https://www.python.org/dev/peps/pep-0008/) is a great Python style guide, which you should read.
+  * PEP 8 must not be strictly followed in all aspects, but most of it is good advice.
+  * The line is limited to 160 characters.
+  * To run checks for things we care about, use [ansible-test](https://docs.ansible.com/ansible/devel/dev_guide/testing_sanity.html).
+  * Similarly, additional checks can be made with "make pyflakes".
+  * There is no need to submit code changes for PEP 8 and pyflakes fixes, as these break attribution history.  Project leadership will make these periodically.
+  * Do not submit pull requests that simply adjust whitespace in the code.
+
+Testing
+=======
+
+  * Much of Ansible's testing needs are in integration, not unit tests.  Add module tests there.
+  * That being said, there are unit tests too!
+  * Code written must absolutely pass tests (i.e. "make tests")
+  * You should anticipate any error paths in your code and test down those error paths.
+  * Additions to tests for core code are welcome, but not always possible.  Be sure things are at least well tested manually in that case.
+
+Whitespace
+==========
+
+  * Four space indent is strictly required
+  * Include meaningful whitespace between lines of code
+
+Shebang Lines
+=============
+
+  * /usr/bin/scripts should start with '/usr/bin/env python'
+  * module code should still use '/usr/bin/python' as this is replaced automatically by 'ansible_python_interpreter', see the FAQ in the docs for more info.
+
+Comments
+========
+
+  * Readability is one of the most important goals for this project
+  * Comment any non-trivial code where someone might not know why you are doing something in a particular way
+  * Though if something should be commented, that's often a sign someone should write a function
+  * All new functions must have a basic docstring comment
+  * Commenting above a line is preferable to commenting at the end of a line
+
+Classes
+=======
+
+  * With the exception of module code (where inline is better), it is desirable to see classes in their own files.
+  * Classes should generally not cause side effects as soon as they are instantiated, move meaningful behavior to methods rather than constructors.
+
+Functions and Methods
+=====================
+
+  * In general, functions should not be 'too long' and should describe a meaningful amount of work
+  * When code gets too nested, that's usually the sign the loop body could benefit from being a function
+  * Parts of our existing code are not the best examples of this at times.
+  * Functions should have names that describe what they do, along with docstrings
+  * Functions should be named with_underscores
+  * "Don't repeat yourself" is generally a good philosophy
+
+Variables
+=========
+
+  * Use descriptive variable names instead of variables like 'x', unless x is an obvious loop index
+  * Ansible python code uses identifiers like 'ClassesLikeThis and variables_like_this
+  * Module parameters should also use_underscores and not runtogether
+
+Module Security
+===============
+
+  * Modules must take steps to avoid passing user input from the shell and always check return codes
+  * always use module.run_command instead of subprocess or Popen or os.system -- this is mandatory
+  * if you need to use the shell you must pass use_unsafe_shell=True to module.run_command
+  * if you do not need the shell, avoid using the shell
+  * any variables that can come from the user input with use_unsafe_shell=True must be wrapped by pipes.quote(x)
+  * downloads of https:// resource urls must import module_utils.urls and use the fetch_url method
+
+Misc Preferences
+================
+
+Use the dict constructor where possible when allocating dictionaries:
+
+    # not this:
+    foo = {
+       'a' : 12,
+       'b' : 34
+    }
+
+    # this:
+    foo = dict(
+       a=12,
+       b=34,
+    )
+
+Do not line up variables
+
+    # not this
+    a        = 12
+    foosball = 34
+    xyz      = 'dog'
+
+    # this
+    a = 12
+    foosball = 34
+    xyz = 'dog'
+
+Don't use line continuations:
+
+    # no
+    if (this_is_a_very_long_line and foo and \
+       i_am_going_to_continue_it):
+          bar()
+
+    # better:
+    if (this_is_a_very_long_line and foo and i_am_going_to_continue_it):
+       bar()
+
+Spacing:
+
+    # no
+    x = [1,2,3]
+
+    # no
+    x = [ 1, 2, 3 ]
+
+    # yes
+    x = [1, 2, 3]
+
+Spacing continued:
+
+    # no
+    x=foo(12)
+
+    # no
+    x = foo( 12 )
+
+    # yes
+    x = foo(12)
+
+Licenses
+========
+
+Every file should have a license header, including the copyright of the original author.  Major additions to the module are allowed
+to add an additional copyright line, and this is especially true of rewrites, but original authorship copyright messages should be preserved.
+
+All contributions to the core repo should preserve original licenses and new contributions must include the GPLv3 header.
+
+Module Documentation
+====================
+
+All module pull requests must include a DOCUMENTATION docstring (YAML format,
+see other modules for examples) as well as an EXAMPLES docstring, which is free form.
+
+When adding new modules, any new parameter must have a "version_added" attribute.
+When submitting a new module, the module should have a "version_added" attribute in the
+pull request as well, set to the current development version.
+
+Be sure to check grammar and spelling.
+
+It's frequently the case that modules get submitted with YAML that isn't valid,
+so you can run "make webdocs" from the checkout to preview your module's documentation.
+If it fails to build, take a look at your DOCUMENTATION string
+or you might have a Python syntax error in there too.
+
+Python Imports
+==============
+
+To make it clear what a module is importing, imports should not be sprinkled throughout the code.
+
+Python Imports should happen at the top of the file, exempting code from module_utils.
+
+When a conditional runtime import is required, do so something like this instead:
+
+    HAS_FOO = False
+    try:
+       import foo
+       HAS_FOO = True
+    except ImportError:
+       pass
+
+    ...
+
+    if not HAS_FOO:
+       raise Exception("the foo library is required")
+
+This makes it clear what optional dependencies are but allows this to be deferred until runtime.   In the case of module code, the raising of the Exception will be replaced
+with a "module.exit_json" call.
+
+Exceptions
+==========
+
+In the main body of the code, use typed exceptions where possible:
+
+    # not this
+    raise Exception("panic!")
+
+    # this
+    from ansible import errors
+    ...
+    raise errors.AnsibleError("panic!")
+
+Similarly, exception checking should be fine grained:
+
+    # not this
+    try:
+       foo()
+    except:
+       bar()
+
+    # but this
+    try:
+       foo()
+    except SomeTypedException:
+       bar()
+
+List Comprehensions
+===================
+
+In general list comprehensions are always preferred to map() and filter() calls.
+
+However, they can be abused.  Optimize for readability, and avoid nesting them too deeply.
+
+Regexes
+=======
+
+There is a time and place for them, but here's an illustrative joke.
+
+"A developer had a problem, and used a regular expression to solve it.  Now the developer had two problems".
+
+Often regexes are difficult to maintain, and a trusty call to other string operations can be a great solution, faster,
+and more readable.
+
+File Conventions
+================
+
+If a piece of code looks for a named YAML file in a directory, it should assume it can take no extension, or an extension of '.yml' or '.yaml'.
+This should be true against all code that loads files.
+
+Any code that uses directories should consider the possibility that the directory may be symlink.
+
+New Ansible language parameters
+===============================
+
+If adding a new parameter, like 'can_fizzbuzz: True/False' be sure the value of the parameter is templated somewhere in the Runner code, as if anything can be parameterized in Ansible,
+there is a user that will try to parameterize it.
+
+String Find
+===========
+
+Use 'in':
+
+    # not this:
+    if x.find('foo') != -1:
+
+    # this:
+    if 'foo' in x:
+
+String checks
+=============
+
+To test if something is a string, consider that it may be unicode.
+
+    # no
+    if type(x) == str:
+
+    # yes
+    from ansible.module_utils.six import string_types
+    if isinstance(x, string_types):
+
+Cleverness
+==========
+
+Ansible's code is intended to be read by as many people as possible, so we don't particularly encourage clever or heavily idiomatic code.
+
+In particular, metaclasses are probably not appropriate, however entertaining they may be to add.
+
+Git Practices
+=============
+
+Pull requests cannot be accepted if they contain merge commits.
+
+Always do "git pull --rebase" and "git rebase" vs "git pull" or "git merge". See [rebasing a pull request](https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html) for more information.
+
+Always create a new branch for each pull request to avoid intermingling different features or fixes on the same branch.
+
+
+Python Version Compliance
+=========================
+
+All code in Ansible core must support a minimum version of Python 2.6.
+
+Module code must support a minimum of Python 2.4, with occasional exceptions for modules that require code that themselves require 2.6 and later.
+
+A quick reminder is that list comprehensions in Python 2.4 are not as fully fleshed out, there are no 'dict' comprehensions, and there is no 'with' statement.
+But otherwise it's pretty much all the same.
+
+The End
+=======
+
+This was not meant to be a scary document, so we hope it wasn't, but we also hope this helps you write code that is easier to maintain by others in the future.
+If you have questions about this document, please ask on the ansible-devel mailing list.
+
+Thank you!

MANIFEST.in

@@ -2,36 +2,23 @@ include README.rst
 include COPYING
 include SYMLINK_CACHE.json
 include requirements.txt
+include .coveragerc
 include shippable.yml
-recursive-include docs *
-exclude docs/docsite/rst_warnings
-recursive-exclude docs/docsite/_build *
-recursive-exclude docs/docsite/_extensions *.pyc *.pyo
+include tox.ini
+include bin/ansible-test
 include examples/hosts
 include examples/ansible.cfg
 include examples/scripts/ConfigureRemotingForAnsible.ps1
 include examples/scripts/upgrade_to_ps3.ps1
-recursive-include lib/ansible/executor/powershell *.ps1
-recursive-include lib/ansible/module_utils/csharp *.cs
-recursive-include lib/ansible/module_utils/powershell *.psm1
-recursive-include lib/ansible/modules/windows *.ps1
-recursive-include lib/ansible/galaxy/data *.yml *.j2 README.md ansible.cfg inventory .git_keep
-recursive-include lib/ansible/config *.yml
-recursive-include licenses *.txt
+recursive-include lib/ansible/module_utils/powershell *
+recursive-include lib/ansible/modules *
+recursive-include lib/ansible/galaxy/data *
+recursive-include docs *
+recursive-include licenses *
 recursive-include packaging *
-recursive-include test/ansible_test *.py Makefile
-recursive-include test/integration *
-recursive-include test/lib/ansible_test/config *.template
-recursive-include test/lib/ansible_test/_data *.cfg *.ini *.json *.ps1 *.psd1 *.py *.sh *.txt *.yml coveragerc inventory
-recursive-include test/lib/ansible_test/_data/injector ansible ansible-config ansible-connection ansible-console ansible-doc ansible-galaxy ansible-playbook ansible-pull ansible-test ansible-vault pytest
-recursive-include test/lib/ansible_test/_data/sanity/validate-modules validate-modules
-recursive-include test/sanity *.json *.py *.txt
-exclude test/sanity/code-smell/botmeta.*
-recursive-include test/units *
+recursive-include test *
 include Makefile
 include MANIFEST.in
 include changelogs/CHANGELOG*.rst
 include contrib/README.md
-recursive-include contrib/inventory *.py *.ini *.yml *.yaml
-recursive-include hacking/build_library *.py
-include hacking/build-ansible.py
+recursive-include contrib/inventory *

MODULE_GUIDELINES.md

@@ -1,5 +1,3 @@
 # Module Maintainer Guidelines
 
 The Ansible Module Maintainer Guidelines can now be found in the [official Ansible community guide](https://docs.ansible.com/ansible/latest/community/maintainers.html).
-
-See also the [Developers Guide](https://docs.ansible.com/ansible/latest/dev_guide/)

Makefile

@@ -3,8 +3,6 @@
 # Makefile for Ansible
 #
 # useful targets:
-#   make clean ---------------- clean up
-#   make webdocs -------------- produce ansible doc at docs/docsite/_build/html
 #   make sdist ---------------- produce a tarball
 #   make srpm ----------------- produce a SRPM
 #   make rpm  ----------------- produce RPMs
@@ -12,6 +10,7 @@
 #   make deb ------------------ produce a DEB
 #   make docs ----------------- rebuild the manpages (results are checked in)
 #   make tests ---------------- run the tests (see https://docs.ansible.com/ansible/devel/dev_guide/testing_units.html for requirements)
+#   make pyflakes, make pep8 -- source code checks
 
 ########################################################
 # variable section
@@ -19,7 +18,6 @@
 NAME = ansible
 OS = $(shell uname -s)
 PREFIX ?= '/usr/local'
-SDIST_DIR ?= 'dist'
 
 # This doesn't evaluate until it's called. The -D argument is the
 # directory of the target file ($@), kinda like `dirname`.
@@ -31,10 +29,9 @@ ASCII2MAN = rst2man.py $< $@
 else
 ASCII2MAN = @echo "ERROR: rst2man from docutils command is not installed but is required to build $(MANPAGES)" && exit 1
 endif
+GENERATE_CLI = docs/bin/generate_man.py
 
 PYTHON=python
-GENERATE_CLI = hacking/build-ansible.py generate-man
-
 SITELIB = $(shell $(PYTHON) -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")
 
 # fetch version from project release.py as single source-of-truth
@@ -51,7 +48,7 @@ RELEASE ?= 1
 
 # Get the branch information from git
 ifneq ($(shell which git),)
-GIT_DATE := $(shell git log -n 1 --format="%ci")
+GIT_DATE := $(shell git log -n 1 --format="%ai")
 GIT_HASH := $(shell git log -n 1 --format="%h")
 GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD | sed 's/[-_.\/]//g')
 GITINFO = .$(GIT_HASH).$(GIT_BRANCH)
@@ -60,7 +57,7 @@ GITINFO = ""
 endif
 
 ifeq ($(shell echo $(OS) | egrep -c 'Darwin|FreeBSD|OpenBSD|DragonFly'),1)
-DATE := $(shell date -j -r $(shell git log -n 1 --format="%ct") +%Y%m%d%H%M)
+DATE := $(shell date -j -r $(shell git log -n 1 --format="%at") +%Y%m%d%H%M)
 CPUS ?= $(shell sysctl hw.ncpu|awk '{print $$2}')
 else
 DATE := $(shell date --utc --date="$(GIT_DATE)" +%Y%m%d%H%M)
@@ -172,6 +169,18 @@ authors:
 %.1: %.1.rst lib/ansible/release.py
 	$(ASCII2MAN)
 
+.PHONY: loc
+loc:
+	sloccount lib library bin
+
+.PHONY: pep8
+pep8:
+	$(ANSIBLE_TEST) sanity --test pep8 --python $(PYTHON_VERSION) $(TEST_FLAGS)
+
+.PHONY: pyflakes
+pyflakes:
+	pyflakes lib/ansible/*.py lib/ansible/*/*.py bin/*
+
 .PHONY: clean
 clean:
 	@echo "Cleaning up distutils stuff"
@@ -208,6 +217,7 @@ clean:
 	rm -f AUTHORS.TXT
 	@echo "Cleaning up docsite"
 	$(MAKE) -C docs/docsite clean
+	$(MAKE) -C docs/api clean
 
 .PHONY: python
 python:
@@ -221,20 +231,9 @@ install_manpages:
 	gzip -9 $(wildcard ./docs/man/man1/ansible*.1)
 	cp $(wildcard ./docs/man/man1/ansible*.1.gz) $(PREFIX)/man/man1/
 
-.PHONY: sdist_check
-sdist_check:
-	$(PYTHON) packaging/sdist/check-link-behavior.py
-
 .PHONY: sdist
-sdist: sdist_check clean docs
-	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist --dist-dir=$(SDIST_DIR)
-
-# Official releases generate the changelog as the last commit before the release.
-# Snapshots shouldn't result in new checkins so the changelog is generated as
-# part of creating the tarball.
-.PHONY: snapshot
-snapshot: sdist_check clean docs changelog
-	_ANSIBLE_SDIST_FROM_MAKEFILE=1 $(PYTHON) setup.py sdist --dist-dir=$(SDIST_DIR)
+sdist: clean docs
+	$(PYTHON) setup.py sdist
 
 .PHONY: sdist_upload
 sdist_upload: clean docs
@@ -242,7 +241,7 @@ sdist_upload: clean docs
 
 .PHONY: changelog
 changelog:
-	PYTHONPATH=./lib packaging/release/changelogs/changelog.py release -vv && PYTHONPATH=./lib packaging/release/changelogs/changelog.py generate -vv
+	packaging/release/changelogs/changelog.py release -vv && packaging/release/changelogs/changelog.py generate -vv
 
 .PHONY: rpmcommon
 rpmcommon: sdist
@@ -301,7 +300,7 @@ rpm: rpmcommon
 	--define "_srcrpmdir %{_topdir}" \
 	--define "_specdir $(RPMSPECDIR)" \
 	--define "_sourcedir %{_topdir}" \
-	--define "_rpmfilename %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm" \
+	--define "_rpmfilename $(RPMNVR).%%{ARCH}.rpm" \
 	--define "__python `which $(PYTHON)`" \
 	--define "upstream_version $(VERSION)" \
 	--define "rpmversion $(RPMVERSION)" \
@@ -399,3 +398,4 @@ alldocs: docs webdocs
 
 version:
 	@echo $(VERSION)
+

README.rst

@@ -1,82 +1,110 @@
-|PyPI version| |Docs badge| |Chat badge| |Build Status| |Code Of Conduct| |Mailing Lists| |License|
+|PyPI version| |Docs badge| |Build Status|
 
 *******
 Ansible
 *******
 
 Ansible is a radically simple IT automation system. It handles
-configuration management, application deployment, cloud provisioning,
-ad-hoc task execution, network automation, and multi-node orchestration. Ansible makes complex
-changes like zero-downtime rolling updates with load balancers easy. More information on `the Ansible website <https://ansible.com/>`_.
+configuration-management, application deployment, cloud provisioning,
+ad-hoc task-execution, and multinode orchestration -- including
+trivializing things like zero-downtime rolling updates with load
+balancers.
+
+Read the documentation and more at https://ansible.com/
+
+You can find installation instructions
+`here <https://docs.ansible.com/intro_getting_started.html>`_ for a
+variety of platforms.
+
+Most users should probably install a released version of Ansible from ``pip``, a package manager or
+our `release repository <https://releases.ansible.com/ansible/>`_. `Officially supported
+<https://www.ansible.com/ansible-engine>`_ builds of Ansible are also available. Some power users
+run directly from the development branch - while significant efforts are made to ensure that
+``devel`` is reasonably stable, you're more likely to encounter breaking changes when running
+Ansible this way.
 
 Design Principles
 =================
 
-*  Have a dead simple setup process and a minimal learning curve.
-*  Manage machines very quickly and in parallel.
+*  Have a dead simple setup process and a minimal learning curve
+*  Manage machines very quickly and in parallel
 *  Avoid custom-agents and additional open ports, be agentless by
-   leveraging the existing SSH daemon.
+   leveraging the existing SSH daemon
 *  Describe infrastructure in a language that is both machine and human
-   friendly.
-*  Focus on security and easy auditability/review/rewriting of content.
+   friendly
+*  Focus on security and easy auditability/review/rewriting of content
 *  Manage new remote machines instantly, without bootstrapping any
-   software.
-*  Allow module development in any dynamic language, not just Python.
-*  Be usable as non-root.
+   software
+*  Allow module development in any dynamic language, not just Python
+*  Be usable as non-root
 *  Be the easiest IT automation system to use, ever.
 
-Use Ansible
-===========
-
-You can install a released version of Ansible via ``pip``, a package manager, or
-our `release repository <https://releases.ansible.com/ansible/>`_. See our
-`installation guide <https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html>`_ for details on installing Ansible
-on a variety of platforms.
-
-Red Hat offers supported builds of `Ansible Engine <https://www.ansible.com/ansible-engine>`_.
-
-Power users and developers can run the ``devel`` branch, which has the latest
-features and fixes, directly. Although it is reasonably stable, you are more likely to encounter
-breaking changes when running the ``devel`` branch. We recommend getting involved
-in the Ansible community if you want to run the ``devel`` branch.
-
 Get Involved
 ============
 
 *  Read `Community
-   Information <https://docs.ansible.com/ansible/latest/community>`_ for all
+   Information <https://docs.ansible.com/community.html>`_ for all
    kinds of ways to contribute to and interact with the project,
    including mailing list information and how to submit bug reports and
    code to Ansible.
-*  Join a `Working Group
-   <https://github.com/ansible/community/wiki>`_, an organized community devoted to a specific technology domain or platform.
-*  Submit a proposed code update through a pull request to the ``devel`` branch.
-*  Talk to us before making larger changes
-   to avoid duplicate efforts. This not only helps everyone
-   know what is going on, it also helps save time and effort if we decide
+*  All code submissions are done through pull requests. Take care to
+   make sure no merge commits are in the submission, and use
+   ``git rebase`` vs ``git merge`` for this reason. If submitting a
+   large code change (other than modules), it's probably a good idea to
+   join ansible-devel and talk about what you would like to do or add
+   first to avoid duplicate efforts. This not only helps everyone
+   know what's going on, it also helps save time and effort if we decide
    some changes are needed.
-*  For a list of email lists, IRC channels and Working Groups, see the
-   `Communication page <https://docs.ansible.com/ansible/latest/community/communication.html>`_
+*  Users list:
+   `ansible-project <https://groups.google.com/group/ansible-project>`_
+*  Development list:
+   `ansible-devel <https://groups.google.com/group/ansible-devel>`_
+*  Announcement list:
+   `ansible-announce <https://groups.google.com/group/ansible-announce>`_
+   -- read only
+*  irc.freenode.net: #ansible
 
 Branch Info
 ===========
 
-*  The ``devel`` branch corresponds to the release actively under development.
-*  The ``stable-2.X`` branches correspond to stable releases.
-*  Create a branch based on ``devel`` and set up a `dev environment <https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#common-environment-setup>`_ if you want to open a PR.
-*  See the `Ansible release and maintenance <https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html>`_ page for information about active branches.
+*  Releases are named after Led Zeppelin songs. (Releases prior to 2.0
+   were named after Van Halen songs.)
+*  The devel branch corresponds to the release actively under
+   development.
+*  Various release-X.Y branches exist for previous releases.
+*  We'd love to have your contributions, read `Community
+   Information <https://docs.ansible.com/community.html>`_ for notes on
+   how to get started.
 
 Roadmap
 =======
 
-Based on team and community feedback, an initial roadmap will be published for a major or minor version (ex: 2.7, 2.8).
-The `Ansible Roadmap page <https://docs.ansible.com/ansible/devel/roadmap/>`_ details what is planned and how to influence the roadmap.
+Based on team and community feedback, an initial roadmap will be published for a major or minor version (ex: 2.0, 2.1).
+Subminor versions will generally not have roadmaps published.
+
+Ansible 2.1 was the first release which published this and asked for feedback in this manner.
+Feedback on the roadmap and the new process is quite welcome.
+The team is aiming for further transparency and better inclusion of both community desires and submissions.
+
+These are the team's *best guess* roadmaps based on the Ansible team's experience and are also based on requests and feedback from the community.
+There are things that may not make it due to time constraints, lack of community maintainers, etc.
+Each roadmap is published both as an idea of what is upcoming in Ansible, and as a medium for seeking further feedback from the community.
+
+There are multiple places for you to submit feedback:
+
+- Add to the agenda of an IRC `Core Team Meeting <https://github.com/ansible/community/blob/master/meetings/README.md>`_ (preferred)
+- Ansible's google-group: ansible-devel
+- AnsibleFest conferences
+- IRC Freenode channel: #ansible-devel (this one may have things lost in lots of conversation)
+
+For additional details consult the published `Ansible Roadmap <https://docs.ansible.com/ansible/devel/roadmap/>`_.
 
 Authors
 =======
 
 Ansible was created by `Michael DeHaan <https://github.com/mpdehaan>`_
-and has contributions from over 4000 users (and growing). Thanks everyone!
+(michael.dehaan/gmail/com) and has contributions from over 3700 users
+(and growing). Thanks everyone!
 
 `Ansible <https://www.ansible.com>`_ is sponsored by `Red Hat, Inc.
 <https://www.redhat.com>`_
@@ -84,24 +112,13 @@ and has contributions from over 4000 users (and growing). Thanks everyone!
 License
 =======
 
-GNU General Public License v3.0 or later
+GNU General Public License v3.0
 
 See `COPYING <COPYING>`_ to see the full text.
 
 .. |PyPI version| image:: https://img.shields.io/pypi/v/ansible.svg
    :target: https://pypi.org/project/ansible
 .. |Docs badge| image:: https://img.shields.io/badge/docs-latest-brightgreen.svg
-   :target: https://docs.ansible.com/ansible/latest/
+   :target: https://docs.ansible.com/ansible
 .. |Build Status| image:: https://api.shippable.com/projects/573f79d02a8192902e20e34b/badge?branch=devel
    :target: https://app.shippable.com/projects/573f79d02a8192902e20e34b
-.. |Chat badge| image:: https://img.shields.io/badge/chat-IRC-brightgreen.svg
-   :target: https://docs.ansible.com/ansible/latest/community/communication.html
-.. |Code Of Conduct| image:: https://img.shields.io/badge/code%20of%20conduct-Ansible-silver.svg
-   :target: https://docs.ansible.com/ansible/latest/community/code_of_conduct.html
-   :alt: Ansible Code of Conduct
-.. |Mailing Lists| image:: https://img.shields.io/badge/mailing%20lists-Ansible-orange.svg
-   :target: https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information
-   :alt: Ansible mailing lists
-.. |License| image:: https://img.shields.io/badge/license-GPL%20v3.0-brightgreen.svg
-   :target: COPYING
-   :alt: Repository License

bin/ansible

@@ -1 +0,0 @@
-../lib/ansible/cli/scripts/ansible_cli_stub.py

bin/ansible

@@ -0,0 +1,163 @@
+#!/usr/bin/env python
+
+# (c) 2012, Michael DeHaan <michael.dehaan@gmail.com>
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+
+########################################################
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+__requires__ = ['ansible']
+try:
+    import pkg_resources
+except Exception:
+    # Use pkg_resources to find the correct versions of libraries and set
+    # sys.path appropriately when there are multiversion installs.  But we
+    # have code that better expresses the errors in the places where the code
+    # is actually used (the deps are optional for many code paths) so we don't
+    # want to fail here.
+    pass
+
+import os
+import shutil
+import sys
+import traceback
+
+from ansible.errors import AnsibleError, AnsibleOptionsError, AnsibleParserError
+from ansible.module_utils._text import to_text
+
+
+# Used for determining if the system is running a new enough python version
+# and should only restrict on our documented minimum versions
+_PY3_MIN = sys.version_info[:2] >= (3, 5)
+_PY2_MIN = (2, 6) <= sys.version_info[:2] < (3,)
+_PY_MIN = _PY3_MIN or _PY2_MIN
+if not _PY_MIN:
+    raise SystemExit('ERROR: Ansible requires a minimum of Python2 version 2.6 or Python3 version 3.5. Current version: %s' % ''.join(sys.version.splitlines()))
+
+
+class LastResort(object):
+    # OUTPUT OF LAST RESORT
+    def display(self, msg, log_only=None):
+        print(msg, file=sys.stderr)
+
+    def error(self, msg, wrap_text=None):
+        print(msg, file=sys.stderr)
+
+
+if __name__ == '__main__':
+
+    display = LastResort()
+
+    try:  # bad ANSIBLE_CONFIG or config options can force ugly stacktrace
+        import ansible.constants as C
+        from ansible.utils.display import Display
+    except AnsibleOptionsError as e:
+        display.error(to_text(e), wrap_text=False)
+        sys.exit(5)
+
+    cli = None
+    me = os.path.basename(sys.argv[0])
+
+    try:
+        display = Display()
+        display.debug("starting run")
+
+        sub = None
+        target = me.split('-')
+        if target[-1][0].isdigit():
+            # Remove any version or python version info as downstreams
+            # sometimes add that
+            target = target[:-1]
+
+        if len(target) > 1:
+            sub = target[1]
+            myclass = "%sCLI" % sub.capitalize()
+        elif target[0] == 'ansible':
+            sub = 'adhoc'
+            myclass = 'AdHocCLI'
+        else:
+            raise AnsibleError("Unknown Ansible alias: %s" % me)
+
+        try:
+            mycli = getattr(__import__("ansible.cli.%s" % sub, fromlist=[myclass]), myclass)
+        except ImportError as e:
+            # ImportError members have changed in py3
+            if 'msg' in dir(e):
+                msg = e.msg
+            else:
+                msg = e.message
+            if msg.endswith(' %s' % sub):
+                raise AnsibleError("Ansible sub-program not implemented: %s" % me)
+            else:
+                raise
+
+        try:
+            args = [to_text(a, errors='surrogate_or_strict') for a in sys.argv]
+        except UnicodeError:
+            display.error('Command line args are not in utf-8, unable to continue.  Ansible currently only understands utf-8')
+            display.display(u"The full traceback was:\n\n%s" % to_text(traceback.format_exc()))
+            exit_code = 6
+        else:
+            cli = mycli(args)
+            cli.parse()
+            exit_code = cli.run()
+
+    except AnsibleOptionsError as e:
+        cli.parser.print_help()
+        display.error(to_text(e), wrap_text=False)
+        exit_code = 5
+    except AnsibleParserError as e:
+        display.error(to_text(e), wrap_text=False)
+        exit_code = 4
+# TQM takes care of these, but leaving comment to reserve the exit codes
+#    except AnsibleHostUnreachable as e:
+#        display.error(str(e))
+#        exit_code = 3
+#    except AnsibleHostFailed as e:
+#        display.error(str(e))
+#        exit_code = 2
+    except AnsibleError as e:
+        display.error(to_text(e), wrap_text=False)
+        exit_code = 1
+    except KeyboardInterrupt:
+        display.error("User interrupted execution")
+        exit_code = 99
+    except Exception as e:
+        if C.DEFAULT_DEBUG:
+            # Show raw stacktraces in debug mode, It also allow pdb to
+            # enter post mortem mode.
+            raise
+        have_cli_options = cli is not None and cli.options is not None
+        display.error("Unexpected Exception, this is probably a bug: %s" % to_text(e), wrap_text=False)
+        if not have_cli_options or have_cli_options and cli.options.verbosity > 2:
+            log_only = False
+            if hasattr(e, 'orig_exc'):
+                display.vvv('\nexception type: %s' % to_text(type(e.orig_exc)))
+                why = to_text(e.orig_exc)
+                if to_text(e) != why:
+                    display.vvv('\noriginal msg: %s' % why)
+        else:
+            display.display("to see the full traceback, use -vvv")
+            log_only = True
+        display.display(u"the full traceback was:\n\n%s" % to_text(traceback.format_exc()), log_only=log_only)
+        exit_code = 250
+    finally:
+        # Remove ansible tmpdir
+        shutil.rmtree(C.DEFAULT_LOCAL_TMP, True)
+
+    sys.exit(exit_code)

bin/ansible-connection

@@ -1 +0,0 @@
-../lib/ansible/cli/scripts/ansible_connection_cli_stub.py

bin/ansible-connection

@@ -0,0 +1,323 @@
+#!/usr/bin/env python
+# Copyright: (c) 2017, Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+from __future__ import (absolute_import, division, print_function)
+
+__metaclass__ = type
+__requires__ = ['ansible']
+
+try:
+    import pkg_resources
+except Exception:
+    pass
+
+import fcntl
+import hashlib
+import os
+import signal
+import socket
+import sys
+import time
+import traceback
+import errno
+import json
+
+from contextlib import contextmanager
+
+from ansible import constants as C
+from ansible.module_utils._text import to_bytes, to_text
+from ansible.module_utils.six import PY3
+from ansible.module_utils.six.moves import cPickle, StringIO
+from ansible.module_utils.connection import Connection, ConnectionError, send_data, recv_data
+from ansible.module_utils.service import fork_process
+from ansible.playbook.play_context import PlayContext
+from ansible.plugins.loader import connection_loader
+from ansible.utils.path import unfrackpath, makedirs_safe
+from ansible.utils.display import Display
+from ansible.utils.jsonrpc import JsonRpcServer
+
+
+def read_stream(byte_stream):
+    size = int(byte_stream.readline().strip())
+
+    data = byte_stream.read(size)
+    if len(data) < size:
+        raise Exception("EOF found before data was complete")
+
+    data_hash = to_text(byte_stream.readline().strip())
+    if data_hash != hashlib.sha1(data).hexdigest():
+        raise Exception("Read {0} bytes, but data did not match checksum".format(size))
+
+    # restore escaped loose \r characters
+    data = data.replace(br'\r', b'\r')
+
+    return data
+
+
+@contextmanager
+def file_lock(lock_path):
+    """
+    Uses contextmanager to create and release a file lock based on the
+    given path. This allows us to create locks using `with file_lock()`
+    to prevent deadlocks related to failure to unlock properly.
+    """
+
+    lock_fd = os.open(lock_path, os.O_RDWR | os.O_CREAT, 0o600)
+    fcntl.lockf(lock_fd, fcntl.LOCK_EX)
+    yield
+    fcntl.lockf(lock_fd, fcntl.LOCK_UN)
+    os.close(lock_fd)
+
+
+class ConnectionProcess(object):
+    '''
+    The connection process wraps around a Connection object that manages
+    the connection to a remote device that persists over the playbook
+    '''
+    def __init__(self, fd, play_context, socket_path, original_path, ansible_playbook_pid=None):
+        self.play_context = play_context
+        self.socket_path = socket_path
+        self.original_path = original_path
+
+        self.fd = fd
+        self.exception = None
+
+        self.srv = JsonRpcServer()
+        self.sock = None
+
+        self.connection = None
+        self._ansible_playbook_pid = ansible_playbook_pid
+
+    def start(self, variables):
+        try:
+            messages = list()
+            result = {}
+
+            messages.append('control socket path is %s' % self.socket_path)
+
+            # If this is a relative path (~ gets expanded later) then plug the
+            # key's path on to the directory we originally came from, so we can
+            # find it now that our cwd is /
+            if self.play_context.private_key_file and self.play_context.private_key_file[0] not in '~/':
+                self.play_context.private_key_file = os.path.join(self.original_path, self.play_context.private_key_file)
+            self.connection = connection_loader.get(self.play_context.connection, self.play_context, '/dev/null',
+                                                    ansible_playbook_pid=self._ansible_playbook_pid)
+            self.connection.set_options(var_options=variables)
+            self.connection._connect()
+
+            self.connection._socket_path = self.socket_path
+            self.srv.register(self.connection)
+            messages.extend(sys.stdout.getvalue().splitlines())
+            messages.append('connection to remote device started successfully')
+
+            self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
+            self.sock.bind(self.socket_path)
+            self.sock.listen(1)
+            messages.append('local domain socket listeners started successfully')
+        except Exception as exc:
+            result['error'] = to_text(exc)
+            result['exception'] = traceback.format_exc()
+        finally:
+            result['messages'] = messages
+            self.fd.write(json.dumps(result))
+            self.fd.close()
+
+    def run(self):
+        try:
+            while self.connection.connected:
+                signal.signal(signal.SIGALRM, self.connect_timeout)
+                signal.signal(signal.SIGTERM, self.handler)
+                signal.alarm(self.connection.get_option('persistent_connect_timeout'))
+
+                self.exception = None
+                (s, addr) = self.sock.accept()
+                signal.alarm(0)
+
+                signal.signal(signal.SIGALRM, self.command_timeout)
+                while True:
+                    data = recv_data(s)
+                    if not data:
+                        break
+
+                    signal.alarm(self.connection.get_option('persistent_command_timeout'))
+                    resp = self.srv.handle_request(data)
+                    signal.alarm(0)
+
+                    send_data(s, to_bytes(resp))
+
+                s.close()
+
+        except Exception as e:
+            # socket.accept() will raise EINTR if the socket.close() is called
+            if hasattr(e, 'errno'):
+                if e.errno != errno.EINTR:
+                    self.exception = traceback.format_exc()
+            else:
+                self.exception = traceback.format_exc()
+
+        finally:
+            # allow time for any exception msg send over socket to receive at other end before shutting down
+            time.sleep(0.1)
+
+            # when done, close the connection properly and cleanup the socket file so it can be recreated
+            self.shutdown()
+
+    def connect_timeout(self, signum, frame):
+        msg = 'persistent connection idle timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and ' \
+              'Troubleshooting Guide.' % self.connection.get_option('persistent_connect_timeout')
+        display.display(msg, log_only=True)
+        raise Exception(msg)
+
+    def command_timeout(self, signum, frame):
+        msg = 'command timeout triggered, timeout value is %s secs.\nSee the timeout setting options in the Network Debug and Troubleshooting Guide.'\
+              % self.connection.get_option('persistent_command_timeout')
+        display.display(msg, log_only=True)
+        raise Exception(msg)
+
+    def handler(self, signum, frame):
+        msg = 'signal handler called with signal %s.' % signum
+        display.display(msg, log_only=True)
+        raise Exception(msg)
+
+    def shutdown(self):
+        """ Shuts down the local domain socket
+        """
+        if os.path.exists(self.socket_path):
+            try:
+                if self.sock:
+                    self.sock.close()
+                if self.connection:
+                    self.connection.close()
+            except:
+                pass
+            finally:
+                if os.path.exists(self.socket_path):
+                    os.remove(self.socket_path)
+                    setattr(self.connection, '_socket_path', None)
+                    setattr(self.connection, '_connected', False)
+        display.display('shutdown complete', log_only=True)
+
+
+def main():
+    """ Called to initiate the connect to the remote device
+    """
+    rc = 0
+    result = {}
+    messages = list()
+    socket_path = None
+
+    # Need stdin as a byte stream
+    if PY3:
+        stdin = sys.stdin.buffer
+    else:
+        stdin = sys.stdin
+
+    # Note: update the below log capture code after Display.display() is refactored.
+    saved_stdout = sys.stdout
+    sys.stdout = StringIO()
+
+    try:
+        # read the play context data via stdin, which means depickling it
+        vars_data = read_stream(stdin)
+        init_data = read_stream(stdin)
+
+        if PY3:
+            pc_data = cPickle.loads(init_data, encoding='bytes')
+            variables = cPickle.loads(vars_data, encoding='bytes')
+        else:
+            pc_data = cPickle.loads(init_data)
+            variables = cPickle.loads(vars_data)
+
+        play_context = PlayContext()
+        play_context.deserialize(pc_data)
+        display.verbosity = play_context.verbosity
+
+    except Exception as e:
+        rc = 1
+        result.update({
+            'error': to_text(e),
+            'exception': traceback.format_exc()
+        })
+
+    if rc == 0:
+        ssh = connection_loader.get('ssh', class_only=True)
+        ansible_playbook_pid = sys.argv[1]
+        cp = ssh._create_control_path(play_context.remote_addr, play_context.port, play_context.remote_user, play_context.connection, ansible_playbook_pid)
+
+        # create the persistent connection dir if need be and create the paths
+        # which we will be using later
+        tmp_path = unfrackpath(C.PERSISTENT_CONTROL_PATH_DIR)
+        makedirs_safe(tmp_path)
+
+        lock_path = unfrackpath("%s/.ansible_pc_lock_%s" % (tmp_path, play_context.remote_addr))
+        socket_path = unfrackpath(cp % dict(directory=tmp_path))
+
+        with file_lock(lock_path):
+            if not os.path.exists(socket_path):
+                messages.append('local domain socket does not exist, starting it')
+                original_path = os.getcwd()
+                r, w = os.pipe()
+                pid = fork_process()
+
+                if pid == 0:
+                    try:
+                        os.close(r)
+                        wfd = os.fdopen(w, 'w')
+                        process = ConnectionProcess(wfd, play_context, socket_path, original_path, ansible_playbook_pid)
+                        process.start(variables)
+                    except Exception:
+                        messages.append(traceback.format_exc())
+                        rc = 1
+
+                    if rc == 0:
+                        process.run()
+                    else:
+                        process.shutdown()
+
+                    sys.exit(rc)
+
+                else:
+                    os.close(w)
+                    rfd = os.fdopen(r, 'r')
+                    data = json.loads(rfd.read())
+                    messages.extend(data.pop('messages'))
+                    result.update(data)
+
+            else:
+                messages.append('found existing local domain socket, using it!')
+                conn = Connection(socket_path)
+                conn.set_options(var_options=variables)
+                pc_data = to_text(init_data)
+                try:
+                    messages.extend(conn.update_play_context(pc_data))
+                except Exception as exc:
+                    # Only network_cli has update_play context, so missing this is
+                    # not fatal e.g. netconf
+                    if isinstance(exc, ConnectionError) and getattr(exc, 'code', None) == -32601:
+                        pass
+                    else:
+                        result.update({
+                            'error': to_text(exc),
+                            'exception': traceback.format_exc()
+                        })
+
+    messages.append(sys.stdout.getvalue())
+    result.update({
+        'messages': messages,
+        'socket_path': socket_path
+    })
+
+    sys.stdout = saved_stdout
+    if 'exception' in result:
+        rc = 1
+        sys.stderr.write(json.dumps(result))
+    else:
+        rc = 0
+        sys.stdout.write(json.dumps(result))
+
+    sys.exit(rc)
+
+
+if __name__ == '__main__':
+    display = Display()
+    main()

bin/ansible-test

@@ -1 +0,0 @@
-../test/lib/ansible_test/_data/cli/ansible_test_cli_stub.py

bin/ansible-test

@@ -0,0 +1,15 @@
+#!/usr/bin/env python
+# PYTHON_ARGCOMPLETE_OK
+"""Primary entry point for ansible-test."""
+
+from __future__ import (absolute_import, division, print_function)
+
+__metaclass__ = type
+
+import os
+import sys
+
+if __name__ == '__main__':
+    sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(os.path.dirname(__file__)), 'test', 'runner')))
+    import lib.cli
+    lib.cli.main()

changelogs/CHANGELOG-v2.7.rst

@@ -0,0 +1,847 @@
+========================================
+Ansible 2.7 "In the Light" Release Notes
+========================================
+
+.. contents:: Topics
+
+
+v2.7.1
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-10-25
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
+
+
+Minor Changes
+-------------
+
+- Fix yum module to properly check for empty conf_file value
+- added capability to set the scheme for the consul_kv lookup.
+- added optional certificate and certificate verification for consul_kv lookups
+- dnf - properly handle modifying the enable/disable excludes data field
+- dnf appropriately handles disable_excludes repoid argument
+- dnf properly honor disable_gpg_check for local (on local disk of remote node) package installation
+- fix yum module to handle list argument optional empty strings properly
+- netconf_config - Make default_operation optional in netconf_config module (https://github.com/ansible/ansible/pull/46333)
+- win_nssm - Drop support of literal YAML dictionnary for ``app_parameters`` option. Use the ``key=value;`` string form instead
+- yum - properly handle proxy password and username embedded in url
+- yum/dnf - fail when space separated string of names (https://github.com/ansible/ansible/pull/47109)
+
+Bugfixes
+--------
+
+- Ansible JSON Decoder - Switch from decode to object_hook to support nested use of __ansible_vault and __ansible_unsafe (https://github.com/ansible/ansible/pull/45514)
+- Don't parse parameters and options when ``state`` is ``absent`` (https://github.com/ansible/ansible/pull/45700).
+- FieldAttribute - Do not use mutable defaults, instead allow supplying a callable for defaults of mutable types (https://github.com/ansible/ansible/issues/46824)
+- Fix an issue with the default telnet prompt handling. The value needs to be escaped otherwise it does not work when converted to bytes.
+- Fix calling deprecate with correct arguments (https://github.com/ansible/ansible/pull/46062).
+- Fix iterator to list conversion in ldap_entry module.
+- Fix nxos_ospf_vrf module auto-cost idempotency and module check mode (https://github.com/ansible/ansible/pull/47190).
+- Fix pip module so that it can recognize multiple extras
+- Fix prompt mismatch issue for ios (https://github.com/ansible/ansible/issues/47004)
+- Fix the issue with refreshing the token by storing Authorization header inside HttpApi connection plugin.
+- Fix the quoting of vhost and other names in rabbitmq_binding
+- Fix the win_reboot plugin so that the post_reboot_delay parameter is honored
+- Fixed an issue with ansible-doc -l failing when parsing some plugin documentation.
+- Fixed: Appropriate code to expand value was missing so assigning SSL certificate is not working as described in the documentation. https://github.com/ansible/ansible/pull/45830
+- Fixes an error that occurs when attempting to see if the netns already exists on the remote device. This change will now execute ``ip netns list`` and check if the desired namespace is in the output.
+- Give user better error messages and more information on verbose about inventory plugin behaviour
+- Hardware fact gathering now completes on Solaris 8.  Previously, it aborted with error `Argument 'args' to run_command must be list or string`.
+- Ignore empty result of rabbitmqctl list_user_permissions.
+- In systemd module, allow scope to default to 'system'
+- In systemd module, fix check if a systemd+initd service is enabled - disabled in systemd means disabled
+- Only access EC2 volume tags when set
+- Only delete host key from redis in-memory cache if present.
+- PLUGIN_FILTERS_CFG - Ensure that the value is treated as type=path, and that we use the standard section of ``defaults`` instead of ``default`` (https://github.com/ansible/ansible/pull/45994)
+- Refactor virtual machine disk logic.
+- Restore SIGPIPE to SIG_DFL when creating subprocesses to avoid it being ignored under Python 2.
+- Rewrite get_resource_pool method for correct resource_pool selection.
+- The docker_* modules more uniformly check versions of docker-py/docker and (if necessary) the docker API.
+- Update callbacks to use Ansible's JSON encoder to avoid known serialization issues
+- Update the signatures of many cliconf plugins' get() methods to support the check_all paramter. Specifically, aireos, aruba, asa, ce, cnos, dellos6, dellos9, dellos10, edgeos, enos, exos, ironware, nos, onyx, routeros, slxos, and voss were updated. This fixes the cli_command module for these platforms
+- Vultr - fix for unreliable API behaviors resulting in timeouts (https://github.com/ansible/ansible/pull/45712/).
+- ansible-connection - Clean up socket files if playbook aborted before connection is started.
+- ansible-doc, removed local hardcoded listing, now uses the 'central' list from constants and other minor issues
+- aws_ec2 - fixed issue where cache did not contain the computed groups
+- aws_ssm_parameter_store - AWS Systems Manager Parameter Store may reach an internal limit before finding the expected parameter, causing misleading results. This is resolved by paginating the describe_parameters call.
+- azure_rm_deployment - fixed regression that prevents resource group from being created (https://github.com/ansible/ansible/issues/45941)
+- blockinfile - use bytes rather than a native string to prevent a stacktrace in Python 3 when writing to the file (https://github.com/ansible/ansible/issues/46237)
+- chroot connection - Support empty files with copying to target (https://github.com/ansible/ansible/issues/36725)
+- cs_instance - Fix docs and typo in examples (https://github.com/ansible/ansible/pull/46035).
+- cs_instance - Fix host migration without volume (https://github.com/ansible/ansible/pull/46115).
+- delegate_to - When templating ``delegate_to`` in a loop, don't use the task for a cache, return a special cache through ``get_vars`` allowing looping over a hostvar (https://github.com/ansible/ansible/issues/47207)
+- docker connection - Support empty files with copying to target (https://github.com/ansible/ansible/issues/36725)
+- docker_container - Fix idempotency problems with ``cap_drop`` and ``groups`` (when numeric group IDs were used).
+- docker_container - Fix type conversion errors for ``log_options``.
+- docker_container - Fixing various comparison/idempotency problems related to wrong comparisons. In particular, comparisons for ``command`` and ``entrypoint`` (both lists) no longer ignore missing elements during idempotency checks.
+- docker_container - Makes ``blkio_weight``, ``cpuset_mems``, ``dns_opts`` and ``uts`` options actually work.
+- docker_container - ``publish_ports: all`` was not used correctly when checking idempotency.
+- docker_container - fail if ``ipv4_address`` or ``ipv6_address`` is used with a too old docker-py version.
+- docker_container - fix ``memory_swappiness`` documentation.
+- docker_container - fix behavior of ``detach: yes`` if ``auto_remove: yes`` is specified.
+- docker_container - fix idempotency check for published_ports in some special cases.
+- docker_container - the behavior is improved in case ``image`` is not specified, but needed for (re-)creating the container.
+- docker_network - fixes idempotency issues (https://github.com/ansible/ansible/issues/33045) and name substring issue (https://github.com/ansible/ansible/issues/32926).
+- docker_service - correctly parse string values for the `scale` parameter https://github.com/ansible/ansible/pull/45508
+- docker_volume - fix ``force`` and change detection logic. If not both evaluated to ``True``, the volume was not recreated.
+- dynamic includes - Use the copied and merged task for calculating task vars in the free strategy (https://github.com/ansible/ansible/issues/47024)
+- ec2_group - There can be multiple security groups with the same name in different VPCs. Prior to 2.6 if a target group name was provided, the group matching the name and VPC had highest precedence. Restore this behavior by updated the dictionary with the groups matching the VPC last.
+- ec2_group - support EC2-Classic by not assuming security groups have VPCs.
+- ec2_metadata_facts - Parse IAM role name from metadata ARN instead of security credential field.
+- fetch_url did not always return lower-case header names in case of HTTP errors (https://github.com/ansible/ansible/pull/45628).
+- fix azure_rm_autoscale module can create a schedule with fixed start/end date (https://github.com/ansible/ansible/pull/47186)
+- fix flatten to properly handle multiple lists in lists https://github.com/ansible/ansible/issues/46343
+- get_url - improve code that parses checksums from a file so it is not fragile and reports a helpful error when no matching checksum is found
+- handlers - fix crash when handler task include tasks
+- jail connection - Support empty files with copying to target (https://github.com/ansible/ansible/issues/36725)
+- junos - fix terminal prompt regex (https://github.com/ansible/ansible/pull/47096)
+- k8s - allow kubeconfig or context to be set without the other
+- k8s_facts now returns a resources key in all situations
+- kubectl connection - Support empty files with copying to target (https://github.com/ansible/ansible/issues/36725)
+- libvirt_lxc connection - Support empty files with copying to target (https://github.com/ansible/ansible/issues/36725)
+- lineinfile - fix index out of range error when using insertbefore on a file with only one line (https://github.com/ansible/ansible/issues/46043)
+- mail - Fix regression when sending mail without TLS/SSL
+- mysql_*, proxysql_* - PyMySQL (a pure-Python MySQL driver) is now a preferred dependency also supporting Python 3.X.
+- netconf_config - Fix in confirmed_commit capability in netconf_config modules  (https://github.com/ansible/ansible/pull/46778)
+- netconf_config - Fix netconf module_utils dict changed size issue (https://github.com/ansible/ansible/pull/46778)
+- nmcli - fix syntax of vlan modification command (https://github.com/ansible/ansible/issues/42322)
+- nxos_file_copy fix for binary files (https://github.com/ansible/ansible/pull/46822).
+- openssl_csr - fix byte encoding issue on Python 3
+- openssl_pkcs12 - fix byte encoding issue on Python 3
+- os_router - ``enable_snat: no`` was ignored.
+- ovirt_host_network - check for empty user_opts (https://github.com/ansible/ansible/pull/47283).
+- ovirt_vm - Check next_run configuration update if exist (https://github.com/ansible/ansible/pull/47282/).
+- ovirt_vm - Fix initialization of cloud init (https://github.com/ansible/ansible/pull/47354).
+- ovirt_vm - Fix issue in SSO option (https://github.com/ansible/ansible/pull/47312).
+- ovirt_vm - Fix issue in setting the custom_compatibility_version to NULL (https://github.com/ansible/ansible/pull/47388).
+- pamd: add delete=False to NamedTemporaryFile() fixes OSError on module completion, and removes print statement from module code. (see https://github.com/ansible/ansible/pull/47281 and https://github.com/ansible/ansible/issues/47080)
+- pamd: use module.tmpdir for NamedTemporaryFile() (see https://github.com/ansible/ansible/pull/47133 and https://github.com/ansible/ansible/issues/36954)
+- postgresql_user - create pretty error message when creating a user without an encrypted password on newer PostgreSQL versions
+- psexec - Handle socket.error exceptions properly
+- psexec - give proper error message when the psexec requirements are not installed
+- psrp - Fix UTF-8 output - https://github.com/ansible/ansible/pull/46998
+- psrp - Fix issue when dealing with unicode values in the output for Python 2
+- reboot - add reboot_timeout parameter to the list of parameters so it can be used.
+- reboot - add support for OpenBSD
+- reboot - use correct syntax for fetching a value from a dict and account for bare Linux systems (https://github.com/ansible/ansible/pull/45607#issuecomment-422403177)
+- reboot - use unicode instead of bytes for stdout and stderr to match the type returned from low_level_execute()
+- roles - Ensure that we don't overwrite roles that have been registered (from imports) while parsing roles under the roles header (https://github.com/ansible/ansible/issues/47454)
+- route53 - fix CAA record ordering for idempotency.
+- ssh connection - Support empty files with piped transfer_method (https://github.com/ansible/ansible/issues/45426)
+- templar - Do not strip new lines in native jinja - https://github.com/ansible/ansible/issues/46743
+- unsafe - Add special casing to sets, to support wrapping elements of sets correctly in Python 3 (https://github.com/ansible/ansible/issues/47372)
+- use proper module_util to get Ansible version for Azure requests
+- user - add documentation on what underlying tools are used on each platform (https://github.com/ansible/ansible/issues/44266)
+- user module - do not pass ssh_key_passphrase on cmdline (CVE-2018-16837)
+- vmware - honor "wait_for_ip_address" when powering on a VM
+- vultr_server - fix diff for user data (https://github.com/ansible/ansible/pull/45753/).
+- vyos_facts - fix vyos_facts not returning version number issue (https://github.com/ansible/ansible/pull/39115)
+- win_copy - Fix issue where the dest return value would be enclosed in single quote when dest is a folder - https://github.com/ansible/ansible/issues/45281
+- win_nssm - Add missing space between parameters with ``app_parameters``
+- win_nssm - Correctly escape argument line when a parameter contains spaces, quotes or backslashes
+- win_nssm - Fix error when several services were given to the ``dependencies`` option
+- win_nssm - Fix extra space added in argument line with ``app_parameters`` or ``app_parameters_free_form`` when a parameter start by a dash and is followed by a period (https://github.com/ansible/ansible/issues/44079)
+- win_nssm - Fix service not started when ``state=started`` (https://github.com/ansible/ansible/issues/35442)
+- win_nssm - Fix several issues and idempotency problems (https://github.com/ansible/ansible/pull/44755)
+- winrm - Only use pexpect for auto kerb auth if it is installed and contains the required kwargs - https://github.com/ansible/ansible/issues/43462
+- zabbix_host - module was failing when zabbix host was updated with new interface and template depending on that interface at the same time
+- zone connection - Support empty files with copying to target (https://github.com/ansible/ansible/issues/36725)
+
+v2.7.0
+======
+
+Release Summary
+---------------
+
+| Release Date: 2018-10-04
+| `Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`__
+
+
+Major Changes
+-------------
+
+- Allow config to enable native jinja types (https://github.com/ansible/ansible/pull/32738)
+- Extends `module_defaults` by adding a prefix to defaults `group/` which denotes a builtin or user-specified list of modules, such as `group/aws` or `group/gcp`
+- New keyword `ignore_unreachable` for plays and blocks. Allows ignoring tasks that fail due to unreachable hosts, and check results with `is unreachable` test.
+- New yumdnf module defines the shared argument specification for both yum and dnf modules and provides an entry point to share code when applicable
+- Remove support for simplejson (https://github.com/ansible/ansible/issues/42761)
+- Support for running an Ansible controller with Python-2.6 has been dropped. You can still manage machines which use Python-2.6 but you will have to manage them from a machine which has Python-2.7 or Python-3.5 or greater installed.  See the `porting guide <https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.7.html>`_ if you need more information.
+- new yum action plugin enables the yum module to work with both yum3 and dnf-based yum4 by detecting the backend package manager and routing commands through the correct Ansible module for that python API
+- yum and dnf modules now at feature parity
+
+Minor Changes
+-------------
+
+- ActionBase - removed deprecated _fixup_perms method (https://github.com/ansible/ansible/pull/44320)
+- Add `is_boto3_error_code` function to `module_utils/aws/core.py` to make it easier for modules to handle special AWS error codes.
+- Add use_backend to yum module/action plugin
+- Added PrivilegeUtil PowerShell module util to easily control Windows Privileges in a process
+- Added capability to skip ssl verification on zabbix host with dynamic inventory
+- Added inventory.any_unparsed_is_failed configuration setting. In an inventory with a static hosts file and (say) ec2.py, enabling this setting will cause a failure instead of a warning if ec2.py fails.
+- Added new filter to generate random MAC addresses from a given string acting as a prefix. Refer to the appropriate entry which has been added to user_guide playbook_filters.rst document.
+- Added the from_yaml_all filter to parse multi-document yaml strings. Refer to the appropriate entry which as been added to user_guide playbooks_filters.rst document.
+- Ansible-2.7 changes the Ansiballz strategy for running modules remotely so that invoking a module only needs to invoke python once per module on the remote machine instead of twice.
+- Better error handling for depsolve and transaction errors in DNF
+- Changed the prefix of all Vultr modules from vr to vultr (https://github.com/ansible/ansible/issues/42942).
+- Enable installroot tests for yum4(dnf) integration testing, dnf backend now supports that
+- Explicit encoding for the output of the template module, to be able to generate non-utf8 files from a utf-8 template. (https://github.com/ansible/proposals/issues/121)
+- File locking feature added, making it possible to gain exclusive access to given file through module_utils.common.file.FileLock (https://github.com/ansible/ansible/issues/29962)
+- Fix dnf handling of autoremove to be compatible with yum
+- Fix timer in exponential backoff algorithm in vmware.py.
+- Fixed group action idempotent transactions in dnf backend
+- Fixed group actions in check mode to report correct changed state
+- GCP Modules will do home path expansion on service account file paths
+- In Ansible-2.4 and above, Ansible passes the temporary directory a module should use to the module.  This is done via a module parameter (_ansible_tmpdir).  An earlier version of this which was also prototyped in Ansible-2.4 development used an environment variable, ANSIBLE_REMOTE_TMP to pass this information to the module instead.  When we switched to using a module parameter, the environment variable was left in by mistake. Ansible-2.7 removes that variable.  Any third party modules which relied on it should use the module parameter instead.
+- New config options `display_ok_hosts` and `display_failed_stderr` (along with the existing `display_skipped_hosts` option) allow more fine-grained control over the way that ansible displays output from a playbook (https://github.com/ansible/ansible/pull/41058)
+- Removed an unnecessary import from the AnsiballZ wrapper
+- Restore module_utils.basic.BOOLEANS variable for backwards compatibility with the module API in older ansible releases.
+- Setting file attributes (via the file module amongst others) now accepts + and - modifiers to add or remove individual attributes. (https://github.com/ansible/ansible/issues/33838)
+- Switch from zip to bc for certain package install/remove test cases in yum integration tests. The dnf depsolver downgrades python when you uninstall zip which alters the test environment and we have no control over that.
+- The acme_account and acme_certificate modules now support two backends: the Python cryptograpy module or the OpenSSL binary. By default, the modules detect if a new enough cryptography module is available and use it, with the OpenSSL binary being a fallback. If the detection fails for some reason, the OpenSSL binary backend can be explicitly selected by setting select_crypto_backend to openssl.
+- The apt, ec2_elb_lb, elb_classic_lb, and unarchive modules have been ported away from using __file__.  This is futureproofing as__file__ won't work if we switch to using python -m to invoke modules in the future or if we figure out a way to make a module never touch disk for pipelining purposes.
+- The password_hash filter supports all parameters of passlib. This allows users to provide a rounds parameter. (https://github.com/ansible/ansible/issues/15326)
+- action plugins strictly accept valid parameters and report invalid parameters
+- allow user to customize default ansible-console prompt/msg default color
+- aws_caller_facts - The module now outputs the "account_alias" as well
+- aws_rds - Add new inventory plugin for RDS instances and clusters to match behavior in the ec2 inventory script.
+- command module - Add support for check mode when passing creates or removes arguments. (https://github.com/ansible/ansible/pull/40428)
+- dnf - group removal does not work if group was installed with Ansible because of dnf upstream bug https://bugzilla.redhat.com/show_bug.cgi?id=1620324
+- ec2_group - Add diff mode support with and without check mode. This feature is preview and may change when a common framework is adopted for AWS modules.
+- elasticsearch_plugin - Add the possibility to use the elasticsearch_plugin installation batch mode to install plugins with advanced privileges without user interaction.
+- gather_subset - removed deprecated functionality for using comma separated list with gather_subset (https://github.com/ansible/ansible/pull/44320)
+- get_url - implement [expend checksum format to <algorithm>:(<checksum>|<url>)] (https://github.com/ansible/ansible/issues/27617)
+- import_tasks - Do not allow import_tasks to transition to dynamic if the file is missing (https://github.com/ansible/ansible/issues/44822)
+- lineinfile - add warning when using an empty regexp (https://github.com/ansible/ansible/issues/29443)
+- onepassword/onepassword_raw - accept subdomain and vault_password to allow Ansible to unlock 1Password vaults
+- password_hash is not restricted to the subset provided by crypt.crypt (https://github.com/ansible/ansible/issues/17266)
+- passwordstore - Add backup option when overwriting password (off by default)
+- puppet - Add support for --debug, --verbose, --summarize https://github.com/ansible/ansible/issues/37986
+- puppet - Add support for setting logdest to both stdout and syslog via 'all'
+- replace copy.deepcopy in high workload areas with a custom function to improve performance (https://github.com/ansible/ansible/pull/44337)
+- roles - removed deprecated functionality for non YAML role specs (https://github.com/ansible/ansible/pull/44320)
+- roles - removed deprecated special casing functionality of connection, port, and remote_user for role params (https://github.com/ansible/ansible/pull/44320)
+- service - removed deprecated state=running (https://github.com/ansible/ansible/pull/44320)
+- shell module - Add support for check mode when passing creates or removes arguments. (https://github.com/ansible/ansible/pull/40428)
+- sns_topic - Port sns_topic module to boto3 and add an integration test suite.
+- ssh - reset connection will show a warning instead of failing for older OpenSSH versions
+- to_nice_json - specify separators to json.dumps to normalize the output between python2 and python3 (https://github.com/ansible/ansible/pull/42633)
+- user - backup shadow file on platforms where the module modifies it directly (https://github.com/ansible/ansible/issues/40696)
+- user module - add a sanity check for the user's password and a more helpful warning message (https://github.com/ansible/ansible/pull/43615)
+- vars_prompt - removed deprecated functionality supporting 'short form' for vars_prompt (https://github.com/ansible/ansible/pull/44320)
+- vault - removed deprecated functionality for insecure VaultAES class (https://github.com/ansible/ansible/pull/44320)
+- win_chocolatey - Add support for installing Chocolatey itself from a source feed
+- win_chocolatey - Add support for username and password on source feeds
+- win_chocolatey - Added ability to specify multiple packages as a list in 1 module invocation
+- win_chocolatey - Removed the need to manually escape double quotes in the proxy username and password
+- win_chocolatey - Will no longer upgrade Chocolatey in check mode
+- win_chocolatey - set the rc return value to always be returned, default to 0 https://github.com/ansible/ansible/issues/41758
+- win_disk_image - return a list of mount paths with the return value ``mount_paths``, this will always be a list and contain all mount points in an image
+- win_psexec - Added the ``session`` option to specify a session to start the process in
+- winrm - change the _reset() method to use reset() that is part of ConnectionBase
+
+Deprecated Features
+-------------------
+
+- Modules will no longer be able to rely on the __file__ attribute pointing to a real file.  If your third party module is using __file__ for something it should be changed before 2.8.  See the 2.7 porting guide for more information.
+- The `skippy`, `full_skip`, `actionable`, and `stderr` callback plugins have been deprecated in favor of config options that influence the behavior of the `default` callback plugin (https://github.com/ansible/ansible/pull/41058)
+- win_disk_image - the return value ``mount_path`` is deprecated and will be removed in 2.11, this can be accessed through ``mount_paths[0]`` instead.
+
+Removed Features (previously deprecated)
+----------------------------------------
+
+- The configuration toggle, ``merge_multiple_cli_tags``, has been removed. This setting controlled whether specifying ``--tags`` or ``--skip-tags`` multiple times on the commandline would merge the specified tags or use the old behaviour of overwriting the previous entry.  The overwriting behaviour was deprecated in 2.3 and the default value of the config option became merge in 2.4.
+- ec2_facts - deprecated module removed (https://github.com/ansible/ansible/pull/44536)
+- s3 - deprecated module removed (https://github.com/ansible/ansible/pull/44537)
+
+Bugfixes
+--------
+
+- **Security Fix** - Some connection exceptions would cause no_log specified on a task to be ignored.  If this happened, the task information, including any private information could have been displayed to stdout and (if enabled, not the default) logged to a log file specified in ansible.cfg's log_path. Additionally, sites which redirected stdout from ansible runs to a log file may have stored that private information onto disk that way as well. (https://github.com/ansible/ansible/pull/41414)
+- **Security Fix** - avoid loading host/group vars from cwd when not specifying a playbook or playbook base dir
+- **Security Fix** - avoid using ansible.cfg in a world writable dir.
+- Add ambiguous command check as the error message is not persistent on nexus devices (https://github.com/ansible/ansible/pull/45337).
+- Add argspec to aws_application_scaling_policy module to handle metric specifications, scaling cooldowns, and target values. https://github.com/ansible/ansible/pull/45235
+- Additional checks ensure that there is always a result of hashing passwords in the password_hash filter and vars_prompt, otherwise an error is returned. Some modules (like user module) interprets None as no password at all, which can be dangerous if the password given above is passed directly into those modules.
+- Allow arbitrary ``log_driver`` for docker_container (https://github.com/ansible/ansible/pull/33579).
+- Avoids deprecated functionality of passlib with newer library versions.
+- Changed the admin_users config option to not include "admin" by default as admin is frequently used for a non-privileged account  (https://github.com/ansible/ansible/pull/41164)
+- Fix alt linux detection/matching
+- Fix an atomic_move error that is 'true', but  misleading. Now we show all 3 files involved and clarify what happened.
+- Fix ec2_group support for multi-account and peered VPC security groups. Reported in https://github.com/ansible/ansible/issue/44788 and fixed in https://github.com/ansible/ansible/pull/45296
+- Fix ecs_taskdefinition handling of changed role_arn. If the task role in a ECS task definition changes ansible should create a new revsion of the task definition. https://github.com/ansible/ansible/pull/45317
+- Fix glob path of rc.d Some distribtuions like SUSE has the rc%.d directories under /etc/init.d
+- Fix health check parameter handling in elb_target_group per https://github.com/ansible/ansible/issues/43244 about health_check_port. Fixed in https://github.com/ansible/ansible/pull/45314
+- Fix lambda_policy updates when principal is an account number. Backport of https://github.com/ansible/ansible/pull/44871
+- Fix lxd module to be idempotent when the given configuration for the lxd container has not changed (https://github.com/ansible/ansible/pull/38166)
+- Fix python2.6 `nothing to repeat` nxos terminal plugin bug (https://github.com/ansible/ansible/pull/45271).
+- Fix s3_lifecycle module backwards compatibility without providing prefix. Blank prefixes regression was introduced in boto3 rewrite. https://github.com/ansible/ansible/pull/45318
+- Fix terminal plugin regex nxos, iosxr (https://github.com/ansible/ansible/pull/45135).
+- Fix the mount module's handling of swap entries in fstab (https://github.com/ansible/ansible/pull/42837)
+- Fixed an issue where ``ansible_facts.pkg_mgr`` would incorrectly set to ``zypper`` on Debian/Ubuntu systems that happened to have the command installed.
+- Fixed runtime module to be able to handle syslog_facility properly when python systemd module installed in a target system. (https://github.com/ansible/ansible/pull/41078)
+- Grafana dashboard module compatible with grafana 5 (https://github.com/ansible/ansible/pull/41249)
+- On Python2, loading config values from environment variables could lead to a traceback if there were nonascii characters present.  Converted them to text strings so that no traceback will occur (https://github.com/ansible/ansible/pull/43468)
+- Remove spurious `changed=True` returns when ec2_group module is used with numeric ports. https://github.com/ansible/ansible/pull/45240
+- Support key names that contain spaces in ec2_metadata_facts module. https://github.com/ansible/ansible/pull/45313
+- The docker_* modules respect the DOCKER_* environment variables again (https://github.com/ansible/ansible/pull/42641).
+- The fix for `CVE-2018-10875 <https://access.redhat.com/security/cve/cve-2018-10875>`__ prints out a warning message about skipping a config file from a world writable current working directory.  However, if the user explicitly specifies that the config file should be used via the ANSIBLE_CONFIG environment variable then Ansible would honor that but still print out the warning message.  This has been fixed so that Ansible honors the user's explicit wishes and does not print a warning message in that circumstance.
+- The fix for `CVE-2018-10875 <https://access.redhat.com/security/cve/cve-2018-10875>`__ prints out a warning message about skipping a config file from a world writable current working directory.  However, if the user is in a world writable current working directory which does not contain a config file, it should not print a warning message.  This release fixes that extaneous warning.
+- The ssh connection plugin was categorizing all 255 exit statuses as an ssh error but modules can return exit code 255 as well.  The connection plugin has now been changed to know that certain instances of exit code 255 are not ssh-related.  (https://github.com/ansible/ansible/pull/41716)
+- allow custom endpoints to be used in the aws_s3 module (https://github.com/ansible/ansible/pull/36832)
+- allow gathering env exception to work even when injection is off
+- always correctly template no log for tasks https://github.com/ansible/ansible/issues/43294
+- ansible-galaxy - properly list all roles in roles_path (https://github.com/ansible/ansible/issues/43010)
+- authorized_key now have an option for following symlinks, default behaviour (False) can be changed by setting follow True/False
+- basic.py - catch ValueError in case a FIPS enabled platform raises this exception - https://github.com/ansible/ansible/issues/44447
+- become runas - changed runas process so it does not create a temporary file on the disk during execution
+- cloudfront_distribution - replace call to nonexistent method 'validate_distribution_id_from_caller_reference' with 'validate_distribution_from_caller_reference' and set the distribution_id variable to the distribution's 'Id' key.
+- corrected and clarified 'user' option deprecation in systemd module in favor of 'scope' option.
+- delegate_to - ensure if we get a non-Task object in _get_delegated_vars, we return early (https://github.com/ansible/ansible/pull/44934)
+- docker_container: fixing ``working_dir`` idempotency problem (https://github.com/ansible/ansible/pull/42857)
+- docker_container: makes unit parsing for memory sizes more consistent, and fixes idempotency problem when ``kernel_memory`` is set (see https://github.com/ansible/ansible/pull/16748 and https://github.com/ansible/ansible/issues/42692)
+- ec2_group - Sanitize the ingress and egress rules before operating on them by flattening any lists within lists describing the target CIDR(s) into a list of strings. Prior to Ansible 2.6 the ec2_group module accepted a list of strings, a list of lists, or a combination of strings and lists within a list. https://github.com/ansible/ansible/pull/45594
+- ec2_vpc_route_table - check the origin before replacing routes. Routes with the origin 'EnableVgwRoutePropagation' may not be replaced.
+- elasticsearch_plugin - Improve error messages and show stderr of elasticsearch commands
+- elb_application_lb - Fix a dangerous behavior of deleting an ELB if state was omitted from the task. Now state defaults to 'present', which is typical throughout AWS modules.
+- elb_target_group - cast target ports to integers before making API calls after the key 'Targets' is in params.
+- file module - The touch subcommand had its diff output broken during the 2.6.x development cycle.  The patch to fix that broke check mode. This is now fixed (https://github.com/ansible/ansible/issues/42111)
+- file module - The touch subcommand had its diff output broken during the 2.6.x development cycle.  This is now fixed (https://github.com/ansible/ansible/issues/41755)
+- fix async for the aws_s3 module by adding async support to the action plugin (https://github.com/ansible/ansible/pull/40826)
+- fix azure storage blob cannot create blob container in non-public azure cloud environment. (https://github.com/ansible/ansible/issues/35223)
+- fix azure_rm_autoscale module can use dict to identify target (https://github.com/ansible/ansible/pull/45477)
+- fix decrypting vault files for the aws_s3 module (https://github.com/ansible/ansible/pull/39634)
+- fix default SSL version for docker modules https://github.com/ansible/ansible/issues/42897
+- fix for the bundled selectors module (used in the ssh and local connection plugins) when a syscall is restarted after being interrupted by a signal (https://github.com/ansible/ansible/issues/41630)
+- fix mail module for python 3.7.0 (https://github.com/ansible/ansible/pull/44552)
+- fix nxos_facts indefinite hang for text based output (https://github.com/ansible/ansible/pull/45845).
+- fix the enable_snat parameter that is only supposed to be used by an user with the right policies. https://github.com/ansible/ansible/pull/44418
+- fix the remote tmp folder permissions issue when becoming a non admin user - https://github.com/ansible/ansible/issues/41340, https://github.com/ansible/ansible/issues/42117
+- fixed typo in config that prevented keys matching
+- fixes docker_container check and debug mode (https://github.com/ansible/ansible/pull/42380)
+- flatten filter - use better method of type checking allowing flattening of mutable and non-mutable sequences (https://github.com/ansible/ansible/pull/44331)
+- gce_net - Fix sorting of allowed ports (https://github.com/ansible/ansible/pull/41567)
+- get_url - Don't re-download files unnecessarily when force=no (https://github.com/ansible/ansible/issues/45491)
+- get_url - fix the bug that get_url does not change mode when checksum matches (https://github.com/ansible/ansible/issues/29614)
+- get_url - support remote checksum files with paths specified with leading dots (`./path/to/file`)
+- get_url / uri - Use custom rfc2822 date format function instead of locale specific strftime (https://github.com/ansible/ansible/issues/44857)
+- improved block docs
+- improves docker_container idempotency (https://github.com/ansible/ansible/pull/44808)
+- include - Change order of where the new block is inserted with apply so that apply args are not applied to the include also (https://github.com/ansible/ansible/pull/44912)
+- includes - ensure we do not double register handlers from includes to prevent exception (https://github.com/ansible/ansible/issues/44848)
+- inventory - When using an inventory directory, ensure extension comparison uses text types (https://github.com/ansible/ansible/pull/42475)
+- loop - Ensure that a loop with a when condition that evaluates to false and delegate_to, will short circuit if the loop references an undefined variable. This matches the behavior in the same scenario without delegate_to (https://github.com/ansible/ansible/issues/45189)
+- loop - Ensure we only cache the loop when the task had a loop and delegate_to was templated (https://github.com/ansible/ansible/issues/44874)
+- made irc module python3 compatible https://github.com/ansible/ansible/issues/42256
+- nclu - no longer runs net on empty lines in templates (https://github.com/ansible/ansible/pull/43024)
+- nicer message when we are missing interpreter
+- password_hash does not hard-code the salt-length, which fixes bcrypt in connection with passlib as bcrypt requires a salt with length 22.
+- pause - do not set stdout to raw mode when redirecting to a file (https://github.com/ansible/ansible/issues/41717)
+- pause - nest try except when importing curses to gracefully fail if curses is not present (https://github.com/ansible/ansible/issues/42004)
+- plugins/inventory/openstack.py - Do not create group with empty name if region is not set
+- preseve delegation info on nolog https://github.com/ansible/ansible/issues/42344
+- remove ambiguity when it comes to 'the source'
+- script inventory plugin - Don't pass file_name to DataLoader.load, which will prevent misleading error messages (https://github.com/ansible/ansible/issues/34164)
+- urls - Only assume GET method if data is empty, otherwise POST
+- user - Strip trailing comments in /etc/default/passwd (https://github.com/ansible/ansible/pull/43931)
+- user - fix bug that resulted in module always reporting a change when specifiying the home directory on FreeBSD (https://github.com/ansible/ansible/issues/42484)
+- user - use correct attribute name in FreeBSD for creat_home (https://github.com/ansible/ansible/pull/42711)
+- vars_prompt - properly template play level variables in vars_prompt (https://github.com/ansible/ansible/issues/37984)
+- vars_prompt with encrypt does not require passlib for the algorithms supported by crypt.
+- vault - fix error message encoding, and ensure we present a friendlier error when the EDITOR is missing (https://github.com/ansible/ansible/pull/44423)
+- win_chocolatey - enable TLSv1.2 support when downloading the Chocolatey installer https://github.com/ansible/ansible/issues/41906
+- win_chocolatey - fix issue where state=downgrade would upgrade a package if no version was set
+- win_domain - ensure the Netlogon service is up and running after promoting host to controller - https://github.com/ansible/ansible/issues/39235
+- win_domain - fixes typo in one of the AD cmdlets https://github.com/ansible/ansible/issues/41536
+- win_domain_computer - fixed deletion of computer active directory object that have dependent objects (https://github.com/ansible/ansible/pull/44500)
+- win_domain_controller - ensure the Netlogon service is up and running after promoting host to controller - https://github.com/ansible/ansible/issues/39235
+- win_group_membership - fix intermittent issue where it failed to convert the ADSI object to the .NET object after using it once
+- win_iis_webapppool - redirect some module output to null so Ansible can read the output JSON https://github.com/ansible/ansible/issues/40874
+- win_lineinfile - changed `-Path` to `-LiteralPath` so that square brackes in the path are interpreted literally -  https://github.com/ansible/ansible/issues/44508
+- win_psexec - changed code to not escape the command option when building the args - https://github.com/ansible/ansible/issues/43839
+- win_reboot - fix for handling an already scheduled reboot and other minor log formatting issues
+- win_reboot - fix issue when overridding connection timeout hung the post reboot uptime check - https://github.com/ansible/ansible/issues/42185 https://github.com/ansible/ansible/issues/42294
+- win_reboot - handle post reboots when running test_command - https://github.com/ansible/ansible/issues/41713
+- win_say - fix syntax error in module and get tests working
+- win_security_policy - allows an empty string to reset a policy value https://github.com/ansible/ansible/issues/40869
+- win_updates - Fixed issue where running win_updates on async fails without any error
+- win_updates - fixed module return value is lost in error in some cases (https://github.com/ansible/ansible/pull/42647)
+- win_uri: Fix support for JSON output when charset is set
+- win_user - Use LogonUser to validate the password as it does not rely on SMB/RPC to be available https://github.com/ansible/ansible/issues/24884
+- win_wait_for - fix issue where timeout doesn't wait unless state=drained - https://github.com/ansible/ansible/issues/43446
+- winrm - ensure pexpect is set to not echo the input on a failure and have a manual sanity check afterwards https://github.com/ansible/ansible/issues/41865
+- winrm - running async with become on a Server 2008 or 2008 R2 host will now work
+
+New Plugins
+-----------
+
+Callback
+~~~~~~~~
+
+- counter_enabled - adds counters to the output items (tasks and hosts/task)
+- logdna - Sends playbook logs to LogDNA
+- splunk - Sends task result events to Splunk HTTP Event Collector
+
+Connection
+~~~~~~~~~~
+
+- psrp - Run tasks over Microsoft PowerShell Remoting Protocol
+
+Inventory
+~~~~~~~~~
+
+- tower - Ansible dynamic inventory plugin for Ansible Tower.
+
+Lookup
+~~~~~~
+
+- cpm_metering - Get Power and Current data from WTI OOB/Combo and PDU devices
+- cpm_status - Get status and parameters from WTI OOB and PDU devices.
+- grafana_dashboard - list or search grafana dashboards
+- nios_next_network - Return the next available network range for a network-container
+
+Strategy
+~~~~~~~~
+
+- host_pinned - Executes tasks on each host without interruption
+
+New Modules
+-----------
+
+Cloud
+~~~~~
+
+amazon
+^^^^^^
+
+- aws_eks_cluster - Manage Elastic Kubernetes Service Clusters
+- cloudformation_stack_set - Manage groups of CloudFormation stacks
+- elb_target_facts - Gathers which target groups a target is associated with.
+- rds_instance - Manage RDS instances
+
+azure
+^^^^^
+
+- azure_rm_appgateway - Manage Application Gateway instance.
+- azure_rm_appserviceplan - Manage App Service Plan
+- azure_rm_appserviceplan_facts - Get azure app service plan facts.
+- azure_rm_autoscale - Manage Azure autoscale setting.
+- azure_rm_autoscale_facts - Get Azure Auto Scale Setting facts.
+- azure_rm_containerregistry_facts - Get Azure Container Registry facts.
+- azure_rm_mysqldatabase_facts - Get Azure MySQL Database facts.
+- azure_rm_mysqlserver_facts - Get Azure MySQL Server facts.
+- azure_rm_postgresqldatabase_facts - Get Azure PostgreSQL Database facts.
+- azure_rm_postgresqlserver_facts - Get Azure PostgreSQL Server facts.
+- azure_rm_route - Manage Azure route resource.
+- azure_rm_routetable - Manage Azure route table resource.
+- azure_rm_routetable_facts - Get route table facts.
+- azure_rm_sqlfirewallrule - Manage Firewall Rule instance.
+- azure_rm_trafficmanagerendpoint - Manage Azure Traffic Manager endpoint.
+- azure_rm_trafficmanagerendpoint_facts - Get Azure Traffic Manager endpoint facts
+- azure_rm_trafficmanagerprofile - Manage Azure Traffic Manager profile.
+- azure_rm_trafficmanagerprofile_facts - Get Azure Traffic Manager profile facts
+- azure_rm_virtualmachine_facts - Get virtual machine facts.
+- azure_rm_webapp - Manage Web App instance.
+- azure_rm_webapp_facts - Get azure web app facts.
+
+cloudstack
+^^^^^^^^^^
+
+- cs_disk_offering - Manages disk offerings on Apache CloudStack based clouds.
+
+docker
+^^^^^^
+
+- docker_swarm - Manage Swarm cluster
+- docker_swarm_service - docker swarm service
+
+google
+^^^^^^
+
+- gcp_compute_address_facts - Gather facts for GCP Address
+- gcp_compute_backend_bucket_facts - Gather facts for GCP BackendBucket
+- gcp_compute_backend_service_facts - Gather facts for GCP BackendService
+- gcp_compute_disk_facts - Gather facts for GCP Disk
+- gcp_compute_firewall_facts - Gather facts for GCP Firewall
+- gcp_compute_forwarding_rule_facts - Gather facts for GCP ForwardingRule
+- gcp_compute_global_address_facts - Gather facts for GCP GlobalAddress
+- gcp_compute_global_forwarding_rule_facts - Gather facts for GCP GlobalForwardingRule
+- gcp_compute_health_check_facts - Gather facts for GCP HealthCheck
+- gcp_compute_http_health_check_facts - Gather facts for GCP HttpHealthCheck
+- gcp_compute_https_health_check_facts - Gather facts for GCP HttpsHealthCheck
+- gcp_compute_image_facts - Gather facts for GCP Image
+- gcp_compute_instance_facts - Gather facts for GCP Instance
+- gcp_compute_instance_group_facts - Gather facts for GCP InstanceGroup
+- gcp_compute_instance_group_manager_facts - Gather facts for GCP InstanceGroupManager
+- gcp_compute_instance_template_facts - Gather facts for GCP InstanceTemplate
+- gcp_compute_network_facts - Gather facts for GCP Network
+- gcp_compute_route_facts - Gather facts for GCP Route
+- gcp_compute_router - Creates a GCP Router
+- gcp_compute_router_facts - Gather facts for GCP Router
+- gcp_compute_ssl_certificate_facts - Gather facts for GCP SslCertificate
+- gcp_compute_ssl_policy - Creates a GCP SslPolicy
+- gcp_compute_ssl_policy_facts - Gather facts for GCP SslPolicy
+- gcp_compute_subnetwork_facts - Gather facts for GCP Subnetwork
+- gcp_compute_target_http_proxy_facts - Gather facts for GCP TargetHttpProxy
+- gcp_compute_target_https_proxy_facts - Gather facts for GCP TargetHttpsProxy
+- gcp_compute_target_pool_facts - Gather facts for GCP TargetPool
+- gcp_compute_target_ssl_proxy_facts - Gather facts for GCP TargetSslProxy
+- gcp_compute_target_tcp_proxy_facts - Gather facts for GCP TargetTcpProxy
+- gcp_compute_target_vpn_gateway - Creates a GCP TargetVpnGateway
+- gcp_compute_target_vpn_gateway_facts - Gather facts for GCP TargetVpnGateway
+- gcp_compute_url_map_facts - Gather facts for GCP UrlMap
+- gcp_compute_vpn_tunnel - Creates a GCP VpnTunnel
+- gcp_compute_vpn_tunnel_facts - Gather facts for GCP VpnTunnel
+- gcp_spanner_database - Creates a GCP Database
+- gcp_spanner_instance - Creates a GCP Instance
+- gcp_sql_database - Creates a GCP Database
+- gcp_sql_instance - Creates a GCP Instance
+- gcp_sql_user - Creates a GCP User
+
+online
+^^^^^^
+
+- online_user_facts - Gather facts about Online user.
+
+openstack
+^^^^^^^^^
+
+- os_coe_cluster_template - Add/Remove COE cluster template from OpenStack Cloud
+- os_listener - Add/Delete a listener for a load balancer from OpenStack Cloud
+- os_loadbalancer - Add/Delete load balancer from OpenStack Cloud
+- os_member - Add/Delete a member for a pool in load balancer from OpenStack Cloud
+- os_pool - Add/Delete a pool in the load balancing service from OpenStack Cloud
+
+scaleway
+^^^^^^^^
+
+- scaleway_image_facts - Gather facts about the Scaleway images available.
+- scaleway_ip_facts - Gather facts about the Scaleway ips available.
+- scaleway_organization_facts - Gather facts about the Scaleway organizations available.
+- scaleway_security_group_facts - Gather facts about the Scaleway security groups available.
+- scaleway_server_facts - Gather facts about the Scaleway servers available.
+- scaleway_snapshot_facts - Gather facts about the Scaleway snapshots available.
+- scaleway_volume - Scaleway volumes management module
+- scaleway_volume_facts - Gather facts about the Scaleway volumes available.
+
+vmware
+^^^^^^
+
+- vmware_about_facts - Provides information about VMware server to which user is connecting to
+- vmware_category - Manage VMware categories
+- vmware_category_facts - Gather facts about VMware tag categories
+- vmware_deploy_ovf - Deploys a VMware virtual machine from an OVF or OVA file
+- vmware_guest_boot_facts - Gather facts about boot options for the given virtual machine
+- vmware_guest_boot_manager - Manage boot options for the given virtual machine
+- vmware_guest_custom_attribute_defs - Manage custom attributes definitions for virtual machine from VMWare
+- vmware_guest_custom_attributes - Manage custom attributes from VMWare for the given virtual machine
+- vmware_guest_move - Moves virtual machines in vCenter
+- vmware_host_ntp_facts - Gathers facts about NTP configuration on an ESXi host
+- vmware_host_ssl_facts - Gather facts of ESXi host system about SSL
+- vmware_local_role_facts - Gather facts about local roles on an ESXi host
+
+vultr
+^^^^^
+
+- vultr_block_storage - Manages block storage volumes on Vultr.
+- vultr_block_storage_facts - Gather facts about the Vultr block storage volumes available.
+- vultr_dns_domain_facts - Gather facts about the Vultr DNS domains available.
+- vultr_firewall_group_facts - Gather facts about the Vultr firewall groups available.
+- vultr_network - Manages networks on Vultr.
+- vultr_network_facts - Gather facts about the Vultr networks available.
+- vultr_os_facts - Gather facts about the Vultr OSes available.
+- vultr_plan_facts - Gather facts about the Vultr plans available.
+- vultr_region_facts - Gather facts about the Vultr regions available.
+- vultr_server_facts - Gather facts about the Vultr servers available.
+- vultr_ssh_key_facts - Gather facts about the Vultr SSH keys available.
+- vultr_startup_script_facts - Gather facts about the Vultr startup scripts available.
+- vultr_user_facts - Gather facts about the Vultr user available.
+
+Clustering
+~~~~~~~~~~
+
+k8s
+^^^
+
+- k8s_facts - Describe Kubernetes (K8s) objects
+
+Crypto
+~~~~~~
+
+- certificate_complete_chain - Complete certificate chain given a set of untrusted and root certificates
+- openssl_pkcs12 - Generate OpenSSL PKCS#12 archive.
+
+acme
+^^^^
+
+- acme_account_facts - Retrieves information on ACME accounts
+- acme_certificate_revoke - Revoke certificates with the ACME protocol
+- acme_challenge_cert_helper - Prepare certificates required for ACME challenges such as C(tls-alpn-01)
+
+Identity
+~~~~~~~~
+
+- onepassword_facts - Fetch facts from 1Password items
+
+ipa
+^^^
+
+- ipa_config - Manage Global FreeIPA Configuration Settings
+- ipa_vault - Manage FreeIPA vaults
+
+Monitoring
+~~~~~~~~~~
+
+zabbix
+^^^^^^
+
+- zabbix_host_facts - Gather facts about Zabbix host
+
+Net Tools
+~~~~~~~~~
+
+- netcup_dns - manage Netcup DNS records
+
+nios
+^^^^
+
+- nios_a_record - Configure Infoblox NIOS A records
+- nios_cname_record - Configure Infoblox NIOS CNAME records
+- nios_mx_record - Configure Infoblox NIOS MX records
+- nios_naptr_record - Configure Infoblox NIOS NAPTR records
+- nios_ptr_record - Configure Infoblox NIOS PTR records
+- nios_srv_record - Configure Infoblox NIOS SRV records
+- nios_txt_record - Configure Infoblox NIOS txt records
+
+Network
+~~~~~~~
+
+aci
+^^^
+
+- aci_interface_policy_ospf - Manage OSPF interface policies (ospf:IfPol)
+
+cli
+^^^
+
+- cli_command - Run a cli command on cli-based network devices
+- cli_config - Push text based configuration to network devices over network_cli
+
+exos
+^^^^
+
+- exos_config - Manage Extreme Networks EXOS configuration sections
+- exos_facts - Collect facts from devices running Extreme EXOS
+
+f5
+^^
+
+- bigip_appsvcs_extension - Manage application service deployments
+- bigip_cli_alias - Manage CLI aliases on a BIG-IP
+- bigip_cli_script - Manage CLI scripts on a BIG-IP
+- bigip_device_auth - Manage system authentication on a BIG-IP
+- bigip_device_facts - Collect facts from F5 BIG-IP devices
+- bigip_firewall_dos_profile - Manage AFM DoS profiles on a BIG-IP
+- bigip_firewall_policy - Manage AFM security firewall policies on a BIG-IP
+- bigip_firewall_rule - Manage AFM Firewall rules
+- bigip_firewall_rule_list - Manage AFM security firewall policies on a BIG-IP
+- bigip_monitor_dns - Manage DNS monitors on a BIG-IP
+- bigip_profile_http - Manage HTTP profiles on a BIG-IP
+- bigip_profile_http_compression - Manage HTTP compression profiles on a BIG-IP
+- bigip_profile_oneconnect - Manage OneConnect profiles on a BIG-IP
+- bigip_profile_persistence_src_addr - Manage source address persistence profiles
+- bigip_remote_role - Manage remote roles on a BIG-IP
+- bigip_software_image - Manage software images on a BIG-IP
+- bigip_software_install - Install software images on a BIG-IP
+- bigip_tunnel - Manage tunnels on a BIG-IP
+- bigiq_utility_license_assignment - Manage utility license assignment on BIG-IPs from a BIG-IQ
+
+fortimanager
+^^^^^^^^^^^^
+
+- fmgr_provisioning - Provision devices via FortiMananger
+
+ftd
+^^^
+
+- ftd_configuration - Manages configuration on Cisco FTD devices over REST API
+- ftd_file_download - Downloads files from Cisco FTD devices over HTTP(S)
+- ftd_file_upload - Uploads files to Cisco FTD devices over HTTP(S)
+
+meraki
+^^^^^^
+
+- meraki_config_template - Manage configuration templates in the Meraki cloud
+- meraki_device - Manage devices in the Meraki cloud
+- meraki_mr_l3_firewall - Manage MR access point layer 3 firewalls in the Meraki cloud
+- meraki_mx_l3_firewall - Manage MX appliance layer 3 firewalls in the Meraki cloud
+- meraki_ssid - Manage wireless SSIDs in the Meraki cloud
+- meraki_switchport - Manage switchports on a switch in the Meraki cloud
+- meraki_vlan - Manage VLANs in the Meraki cloud
+
+nos
+^^^
+
+- nos_command - Run commands on remote devices running Extreme Networks NOS
+- nos_config - Manage Extreme Networks NOS configuration sections
+- nos_facts - Collect facts from devices running Extreme NOS
+
+nxos
+^^^^
+
+- nxos_rpm - Install patch or feature rpms on Cisco NX-OS devices.
+
+onyx
+^^^^
+
+- onyx_igmp - Configures IGMP globl parameters
+
+opx
+^^^
+
+- opx_cps - CPS operations on networking device running Openswitch (OPX)
+
+panos
+^^^^^
+
+- panos_set - Execute arbitrary commands on a PAN-OS device using XPath and element
+
+routeros
+^^^^^^^^
+
+- routeros_command - Run commands on remote devices running MikroTik RouterOS
+
+slxos
+^^^^^
+
+- slxos_lldp - Manage LLDP configuration on Extreme Networks SLX-OS network devices.
+
+voss
+^^^^
+
+- voss_command - Run commands on remote devices running Extreme VOSS
+- voss_facts - Collect facts from remote devices running Extreme VOSS
+
+Remote Management
+~~~~~~~~~~~~~~~~~
+
+cobbler
+^^^^^^^
+
+- cobbler_sync - Sync Cobbler
+- cobbler_system - Manage system objects in Cobbler
+
+cpm
+^^^
+
+- cpm_user - Get various status and parameters from WTI OOB and PDU devices
+
+redfish
+^^^^^^^
+
+- redfish_command - Manages Out-Of-Band controllers using Redfish APIs
+- redfish_config - Manages Out-Of-Band controllers using Redfish APIs
+- redfish_facts - Manages Out-Of-Band controllers using Redfish APIs
+
+ucs
+^^^
+
+- ucs_ntp_server - Configures NTP server on Cisco UCS Manager
+- ucs_storage_profile - Configures storage profiles on Cisco UCS Manager
+- ucs_timezone - Configures timezone on Cisco UCS Manager
+- ucs_uuid_pool - Configures server UUID pools on Cisco UCS Manager
+
+Storage
+~~~~~~~
+
+emc
+^^^
+
+- emc_vnx_sg_member - Manage storage group member on EMC VNX
+
+ibm
+^^^
+
+- ibm_sa_host - Adds hosts to or removes them from IBM Spectrum Accelerate storage systems.
+- ibm_sa_pool - Handles pools on an IBM Spectrum Accelerate storage array.
+- ibm_sa_vol - Handle volumes on an IBM Spectrum Accelerate storage array
+
+netapp
+^^^^^^
+
+- na_elementsw_access_group - NetApp Element Software Manage Access Groups
+- na_elementsw_account - NetApp Element Software Manage Accounts
+- na_elementsw_admin_users - NetApp Element Software Manage Admin Users
+- na_elementsw_backup - NetApp Element Software Create Backups
+- na_elementsw_check_connections - NetApp Element Software Check connectivity to MVIP and SVIP.
+- na_elementsw_cluster - NetApp Element Software Create Cluster
+- na_elementsw_cluster_pair - NetApp Element Software Manage Cluster Pair
+- na_elementsw_drive - NetApp Element Software Manage Node Drives
+- na_elementsw_ldap - NetApp Element Software Manage ldap admin users
+- na_elementsw_network_interfaces - NetApp Element Software Configure Node Network Interfaces
+- na_elementsw_node - NetApp Element Software Node Operation
+- na_elementsw_snapshot - NetApp Element Software Manage Snapshots
+- na_elementsw_snapshot_restore - NetApp Element Software Restore Snapshot
+- na_elementsw_snapshot_schedule - NetApp Element Software Snapshot Schedules
+- na_elementsw_vlan - NetApp Element Software Manage VLAN
+- na_elementsw_volume - NetApp Element Software Manage Volumes
+- na_elementsw_volume_clone - NetApp Element Software Create Volume Clone
+- na_elementsw_volume_pair - NetApp Element Software Volume Pair
+- na_ontap_autosupport - NetApp ONTAP manage Autosupport
+- na_ontap_cg_snapshot - NetApp ONTAP manage consistency group snapshot
+- na_ontap_cluster_peer - NetApp ONTAP Manage Cluster peering
+- na_ontap_command - NetApp ONTAP Run any cli command
+- na_ontap_disks - NetApp ONTAP Assign disks to nodes
+- na_ontap_dns - NetApp ONTAP Create, delete, modify DNS servers.
+- na_ontap_fcp - NetApp ONTAP Start, Stop and Enable FCP services.
+- na_ontap_firewall_policy - NetApp ONTAP Manage a firewall policy
+- na_ontap_gather_facts - NetApp information gatherer
+- na_ontap_motd - Setup motd on cDOT
+- na_ontap_node - NetApp ONTAP Rename a node.
+- na_ontap_snapmirror - NetApp ONTAP Manage SnapMirror
+- na_ontap_software_update - NetApp ONTAP Update Software
+- na_ontap_svm_options - NetApp ONTAP Modify SVM Options
+- na_ontap_vserver_peer - NetApp ONTAP Vserver peering
+- netapp_e_alerts - NetApp E-Series manage email notification settings
+- netapp_e_asup - NetApp E-Series manage auto-support settings
+- netapp_e_auditlog - NetApp E-Series manage audit-log configuration
+- netapp_e_global - NetApp E-Series manage global settings configuration
+- netapp_e_iscsi_interface - NetApp E-Series manage iSCSI interface configuration
+- netapp_e_iscsi_target - NetApp E-Series manage iSCSI target configuration
+- netapp_e_ldap - NetApp E-Series manage LDAP integration to use for authentication
+- netapp_e_mgmt_interface - NetApp E-Series management interface configuration
+- netapp_e_syslog - NetApp E-Series manage syslog settings
+
+purestorage
+^^^^^^^^^^^
+
+- purefb_facts - Collect facts from Pure Storage FlashBlade
+
+System
+~~~~~~
+
+- java_keystore - Create or delete a Java keystore in JKS format.
+- python_requirements_facts - Show python path and assert dependency versions
+- reboot - Reboot a machine
+
+Web Infrastructure
+~~~~~~~~~~~~~~~~~~
+
+ansible_tower
+^^^^^^^^^^^^^
+
+- tower_credential_type - Create, update, or destroy custom Ansible Tower credential type.
+- tower_inventory_source - create, update, or destroy Ansible Tower inventory source.
+- tower_settings - Modify Ansible Tower settings.
+- tower_workflow_template - create, update, or destroy Ansible Tower workflow template.
+
+Windows
+~~~~~~~
+
+- win_chocolatey_config - Manages Chocolatey config settings
+- win_chocolatey_feature - Manages Chocolatey features
+- win_chocolatey_source - Manages Chocolatey sources
+- win_wait_for_process - Waits for a process to exist or not exist before continuing.
+- win_xml - Add XML fragment to an XML parent

changelogs/fragments/16748-docker_container-memory.yaml

@@ -0,0 +1,5 @@
+bugfixes:
+- "docker_container: makes unit parsing for memory sizes more consistent, and
+   fixes idempotency problem when ``kernel_memory`` is set (see
+   https://github.com/ansible/ansible/pull/16748 and
+   https://github.com/ansible/ansible/issues/42692)"

changelogs/fragments/20596-role-param_fix.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-- Fixed role's hash_params behavior to not union (https://github.com/ansible/ansible/issues/20596).

changelogs/fragments/225-mysql_user_fix_no_database_selected.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- mysql_user - fix the error No database selected (https://github.com/ansible/ansible/issues/68070).

changelogs/fragments/29124-has-dead-workers.yaml

@@ -1,4 +0,0 @@
-bugfixes:
-- TaskQueueManager - Ensure ``has_dead_workers`` can function, by using the
-  correct reference, and only allow an exit code of 0.
-  (https://github.com/ansible/ansible/issues/29124)

changelogs/fragments/29264-rabbitmq_policy-add-full-change-check.yml

@@ -1,2 +0,0 @@
-bugfixes:
-  - rabbitmq_policy - Add full check for rabbit policy changes (https://github.com/ansible/ansible/issues/29264)

changelogs/fragments/29366-allow-preservation-of-s3-bucket-tags.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - add purge_tags parameter to s3_bucket to allow preservation of existing tags when updating tags.

changelogs/fragments/31238-uri-multi-content-type.yaml

@@ -1,3 +0,0 @@
-bugfixes:
-- uri - Handle multiple Content-Type headers correctly
-  (https://github.com/ansible/ansible/pull/31238)

changelogs/fragments/32738-native-jinja-types.yaml

@@ -0,0 +1,2 @@
+major_changes:
+- Allow config to enable native jinja types (https://github.com/ansible/ansible/pull/32738)

changelogs/fragments/33156-vmware_guest-resource_pool.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- Rewrite get_resource_pool method for correct resource_pool selection.

changelogs/fragments/33579-docker_container-log_driver.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "Allow arbitrary ``log_driver`` for docker_container (https://github.com/ansible/ansible/pull/33579)."

changelogs/fragments/33604-add-service-to-getent-module.yml

@@ -1,2 +0,0 @@
-minor_changes:
-    - getent - add service parameter to getent to lookup specified service

changelogs/fragments/34863-rabbitmq_user_unpack_fix.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- Ignore empty result of rabbitmqctl list_user_permissions.

changelogs/fragments/35120-redis_inventory_plugin_flush_cache.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- Only delete host key from redis in-memory cache if present.

changelogs/fragments/38679-vmware_guest-refactor_disk_logic.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- Refactor virtual machine disk logic.

changelogs/fragments/41240-fix-os_quota-without-cinder.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-  - "os_quota - fix failure to set compute or network quota when volume service is not available"

changelogs/fragments/42042-inventory_with_no_region.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- plugins/inventory/openstack.py - Do not create group with empty name if region is not set

changelogs/fragments/42170-acme-backend-selection.yaml

@@ -0,0 +1,8 @@
+---
+minor_changes:
+- "The acme_account and acme_certificate modules now support two backends:
+   the Python cryptograpy module or the OpenSSL binary. By default, the
+   modules detect if a new enough cryptography module is available and
+   use it, with the OpenSSL binary being a fallback. If the detection
+   fails for some reason, the OpenSSL binary backend can be explicitly
+   selected by setting select_crypto_backend to openssl."

changelogs/fragments/42322-nmcli_fix_vlan_mod_function.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "nmcli - fix syntax of vlan modification command (https://github.com/ansible/ansible/issues/42322)"

changelogs/fragments/42380-docker_container-check-mode.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "fixes docker_container check and debug mode (https://github.com/ansible/ansible/pull/42380)"

changelogs/fragments/42456-consul_kv-lookup.yaml

@@ -0,0 +1,3 @@
+minor_changes:
+  - added capability to set the scheme for the consul_kv lookup.
+  - added optional certificate and certificate verification for consul_kv lookups

changelogs/fragments/42641-44812-docker-env-variables.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "The docker_* modules respect the DOCKER_* environment variables again (https://github.com/ansible/ansible/pull/42641)."

changelogs/fragments/42647-win_updates.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- win_updates - fixed module return value is lost in error in some cases (https://github.com/ansible/ansible/pull/42647)

changelogs/fragments/42669-add_ssl_zabbix_inventory.yaml

@@ -0,0 +1,4 @@
+---
+minor_changes:
+  - Added capability to skip ssl verification 
+    on zabbix host with dynamic inventory

changelogs/fragments/42857-docker_container-working_dir.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container: fixing ``working_dir`` idempotency problem (https://github.com/ansible/ansible/pull/42857)"

changelogs/fragments/43024-nclu-empty-net-commands.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- nclu - no longer runs net on empty lines in templates (https://github.com/ansible/ansible/pull/43024)

changelogs/fragments/43931-strip-trailing-comments.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - user - Strip trailing comments in /etc/default/passwd (https://github.com/ansible/ansible/pull/43931)

changelogs/fragments/43997-docker_network-inspect.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_network - fixes idempotency issues (https://github.com/ansible/ansible/issues/33045) and name substring issue (https://github.com/ansible/ansible/issues/32926)."

changelogs/fragments/44500-win_domain_computer.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- win_domain_computer - fixed deletion of computer active directory object that have dependent objects (https://github.com/ansible/ansible/pull/44500)

changelogs/fragments/44508-win_lineinfile.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- win_lineinfile - changed `-Path` to `-LiteralPath` so that square brackes in the path are interpreted literally -  https://github.com/ansible/ansible/issues/44508

changelogs/fragments/44552-mail-py370-compat.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- fix mail module for python 3.7.0 (https://github.com/ansible/ansible/pull/44552)

changelogs/fragments/44624-dnsmadeeasy-fix_locale.yaml

@@ -1,2 +0,0 @@
-bugfixes:
-  - dnsmadeeasy - force the date to be rendered with C (POSIX system default) locale as English short date names are required by API

changelogs/fragments/44755-win_nssm_fixes.yaml

@@ -0,0 +1,10 @@
+bugfixes:
+- win_nssm - Fix several issues and idempotency problems (https://github.com/ansible/ansible/pull/44755)
+- win_nssm - Fix service not started when ``state=started`` (https://github.com/ansible/ansible/issues/35442)
+- win_nssm - Correctly escape argument line when a parameter contains spaces, quotes or backslashes
+- win_nssm - Add missing space between parameters with ``app_parameters``
+- win_nssm - Fix extra space added in argument line with ``app_parameters`` or ``app_parameters_free_form`` when a parameter start by a dash and is followed by a period (https://github.com/ansible/ansible/issues/44079)
+- win_nssm - Fix error when several services were given to the ``dependencies`` option
+
+minor_changes:
+- win_nssm - Drop support of literal YAML dictionnary for ``app_parameters`` option. Use the ``key=value;`` string form instead

changelogs/fragments/44808-docker_container-idempotency.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "improves docker_container idempotency (https://github.com/ansible/ansible/pull/44808)"

changelogs/fragments/44811-xml-insertbefore-and-insertafter-parameters.yaml

@@ -1,2 +0,0 @@
-minor_changes:
-  - xml - Introduce ``insertbefore`` and ``insertafter`` to specify the position (https://github.com/ansible/ansible/pull/44811)

changelogs/fragments/45226-vmware_wait_for_ip_address.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- vmware - honor "wait_for_ip_address" when powering on a VM

changelogs/fragments/45417-ldap_entry-list_conversion.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- Fix iterator to list conversion in ldap_entry module.

changelogs/fragments/45501-get_url-better_checksums.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- get_url - support remote checksum files with paths specified with leading dots (`./path/to/file`)

changelogs/fragments/45508-parse-docker-service-parameter.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - docker_service - correctly parse string values for the `scale` parameter https://github.com/ansible/ansible/pull/45508

changelogs/fragments/45543-rabbitmq_bindings-fix-quote.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- Fix the quoting of vhost and other names in rabbitmq_binding

changelogs/fragments/45628-fetch_url-error-headers.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "fetch_url did not always return lower-case header names in case of HTTP errors (https://github.com/ansible/ansible/pull/45628)."

changelogs/fragments/45631-empty-cow-whitelist.yml

@@ -1,2 +0,0 @@
-bugfixes:
-- cowsay - Fix issue with an empty cow_whitelist (https://github.com/ansible/ansible/issues/45631)

changelogs/fragments/45700-docker_container-dont-parse-absent.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "Don't parse parameters and options when ``state`` is ``absent`` (https://github.com/ansible/ansible/pull/45700)."

changelogs/fragments/45712-45753-vultr-timeout.yml

@@ -0,0 +1,3 @@
+bugfixes:
+- Vultr - fix for unreliable API behaviors resulting in timeouts (https://github.com/ansible/ansible/pull/45712/).
+- vultr_server - fix diff for user data (https://github.com/ansible/ansible/pull/45753/).

changelogs/fragments/45830-fixed-assigning-ssl-certificate.yaml

@@ -0,0 +1,4 @@
+bugfixes:
+- "Fixed: Appropriate code to expand value was missing so assigning SSL
+   certificate is not working as described in the documentation.
+   https://github.com/ansible/ansible/pull/45830"

changelogs/fragments/45921-os_router-ignores-enable_snat-no.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - "os_router - ``enable_snat: no`` was ignored."

changelogs/fragments/46049-route53-caa-ordering.txt

@@ -0,0 +1,2 @@
+bugfixes:
+- "route53 - fix CAA record ordering for idempotency."

changelogs/fragments/46115-46035-cs_instance-fixes.yml

@@ -0,0 +1,3 @@
+bugfixes:
+- cs_instance - Fix host migration without volume (https://github.com/ansible/ansible/pull/46115).
+- cs_instance - Fix docs and typo in examples (https://github.com/ansible/ansible/pull/46035).

changelogs/fragments/46245-systemd-fix-service-enable-logic.yaml

@@ -0,0 +1,3 @@
+bugfixes:
+- In systemd module, allow scope to default to 'system'
+- In systemd module, fix check if a systemd+initd service is enabled - disabled in systemd means disabled

changelogs/fragments/46322-docker_container-image-not-given.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - the behavior is improved in case ``image`` is not specified, but needed for (re-)creating the container."

changelogs/fragments/46458-vmware_cluster_facts-show_tag.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - vmware_cluster_facts now supports tag facts (https://github.com/ansible/ansible/issues/46458).

changelogs/fragments/46461-vmware_host_facts-show_tag.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - vmware_host_facts now supports tag facts (https://github.com/ansible/ansible/issues/46461).

changelogs/fragments/46521-zabbix_host-fix-link-template-error.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "zabbix_host - module was failing when zabbix host was updated with new interface and template depending on that interface at the same time"

changelogs/fragments/46594-docker_container-publish-all-ports.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - ``publish_ports: all`` was not used correctly when checking idempotency."

changelogs/fragments/46595-docker_container-expected_ports.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - fix idempotency check for published_ports in some special cases."

changelogs/fragments/46743-fix-native-jinja-newlines.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+    - templar - Do not strip new lines in native jinja - https://github.com/ansible/ansible/issues/46743

changelogs/fragments/46800-ec2_vol_facts-handle-missing-tags.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- Only access EC2 volume tags when set

changelogs/fragments/46961_fix_aws_ec2_cache.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - aws_ec2 - fixed issue where cache did not contain the computed groups

changelogs/fragments/47046-docker-versions.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "The docker_* modules more uniformly check versions of docker-py/docker and (if necessary) the docker API."

changelogs/fragments/47096-junos-terminal-regex-fix.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - junos - fix terminal prompt regex (https://github.com/ansible/ansible/pull/47096)

changelogs/fragments/47109-fail-space-separated-string-pkgs.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+  - yum/dnf - fail when space separated string of names (https://github.com/ansible/ansible/pull/47109)

changelogs/fragments/47133-pamd_use_module_tmpdir.yml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+- "pamd: use module.tmpdir for NamedTemporaryFile()
+   (see https://github.com/ansible/ansible/pull/47133 and https://github.com/ansible/ansible/issues/36954)" 

changelogs/fragments/47281-pamd-dont-delete-named_temporary_file_on_close.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+- "pamd: add delete=False to NamedTemporaryFile() fixes OSError on module completion, and
+   removes print statement from module code.
+   (see https://github.com/ansible/ansible/pull/47281 and https://github.com/ansible/ansible/issues/47080)" 

changelogs/fragments/47296-docker_container-memory_swappiness.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - fix ``memory_swappiness`` documentation."

changelogs/fragments/47307-handler-include-task.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "handlers - fix crash when handler task include tasks"

changelogs/fragments/47395-docker_container-ipvX_address.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - fail if ``ipv4_address`` or ``ipv6_address`` is used with a too old docker-py version."

changelogs/fragments/47396-docker_container-detach-auto-remove.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - fix behavior of ``detach: yes`` if ``auto_remove: yes`` is specified."

changelogs/fragments/48010-vmware_datastore_cluster-add_folder.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - Add folder option in vmware_datastore_cluster to place datastore cluster in specific folder (https://github.com/ansible/ansible/issues/48010).

changelogs/fragments/48394-meraki-idempotency-change.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - "meraki_* - Idempotency check has been rewritten. The new version is more thorough."

changelogs/fragments/48820-meraki_network-enable-vlans.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - "meraki_network - Add support for enabling or disabling VLANs on a network."

changelogs/fragments/48971-meraki_network-enable-status-pages.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - meraki_network - Add support for disabling remote status page on a network.

changelogs/fragments/48971-meraki_ssid-docs.yml

@@ -1,2 +0,0 @@
-minor_changes:
-  - meraki_ssid - Add examples to documentation.

changelogs/fragments/49568-type-checking.yaml

@@ -1,3 +0,0 @@
----
-bugfixes:
-- "nagios - Removed redundant type check which caused crashes. Guardrails added elsewhere in earlier change."

changelogs/fragments/49808-docker_container-mounts.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- "docker_container - add ``mounts`` option."

changelogs/fragments/49938-vcenter_folder-restrict_folder.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- Restrict vcenter_folder to vCenter only, since folder creation api is not supported on ESXi hostsystem (https://github.com/ansible/ansible/issues/49938).

changelogs/fragments/50617-vmware_guest-vapp_settings.yml

@@ -1,2 +0,0 @@
-minor_changes:
-- vApp setting can be set while VM creation in vmware_guest (https://github.com/ansible/ansible/issues/50617).

changelogs/fragments/51489-apt-not-honor-update-cache.yml

@@ -1,4 +0,0 @@
----
-bugfixes:
-- apt - Fixed the issue the cache being updated while auto-installing its
-  dependencies even when ``update_cache`` is set to false.