providers/proxy: avoid erroring on logout with session_id is None (#9119)

* providers/proxy: avoid erroring on logout with session_id is None

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* check for session and session_key in signals

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens Langhammer <jens@goauthentik.io>

authentik/core/signals.py

@@ -52,6 +52,8 @@ def user_logged_in_session(sender, request: HttpRequest, user: User, **_):
 @receiver(user_logged_out)
 def user_logged_out_session(sender, request: HttpRequest, user: User, **_):
     """Delete AuthenticatedSession if it exists"""
+    if not request.session or not request.session.session_key:
+        return
     AuthenticatedSession.objects.filter(session_key=request.session.session_key).delete()
 
 

authentik/enterprise/providers/rac/signals.py

@@ -21,6 +21,8 @@ from authentik.enterprise.providers.rac.models import ConnectionToken, Endpoint
 @receiver(user_logged_out)
 def user_logged_out_session(sender, request: HttpRequest, user: User, **_):
     """Disconnect any open RAC connections"""
+    if not request.session or not request.session.session_key:
+        return
     layer = get_channel_layer()
     async_to_sync(layer.group_send)(
         RAC_CLIENT_GROUP_SESSION

authentik/providers/oauth2/signals.py

@@ -11,5 +11,7 @@ from authentik.providers.oauth2.models import AccessToken
 @receiver(user_logged_out)
 def user_logged_out_oauth_access_token(sender, request: HttpRequest, user: User, **_):
     """Revoke access tokens upon user logout"""
+    if not request.session or not request.session.session_key:
+        return
     hashed_session_key = sha256(request.session.session_key.encode("ascii")).hexdigest()
     AccessToken.objects.filter(user=user, session_id=hashed_session_key).delete()

authentik/providers/proxy/signals.py

@@ -12,6 +12,8 @@ from authentik.providers.proxy.tasks import proxy_on_logout
 @receiver(user_logged_out)
 def logout_proxy_revoke_direct(sender: type[User], request: HttpRequest, **_):
     """Catch logout by direct logout and forward to proxy providers"""
+    if not request.session or not request.session.session_key:
+        return
     proxy_on_logout.delay(request.session.session_key)