Compare commits
	
		
			6 Commits
		
	
	
		
			patch-1
			...
			typescript
		
	
	| Author | SHA1 | Date | |
|---|---|---|---|
| ff3e59c8e2 | |||
| 0e57e06191 | |||
| 40ab2bccfd | |||
| efc0697483 | |||
| 9c150d74c4 | |||
| d421b25760 | 
| @ -1,5 +1,5 @@ | ||||
| [bumpversion] | ||||
| current_version = 2025.4.0 | ||||
| current_version = 2025.2.2 | ||||
| tag = True | ||||
| commit = True | ||||
| parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(?:-(?P<rc_t>[a-zA-Z-]+)(?P<rc_n>[1-9]\\d*))? | ||||
| @ -17,8 +17,6 @@ optional_value = final | ||||
|  | ||||
| [bumpversion:file:pyproject.toml] | ||||
|  | ||||
| [bumpversion:file:uv.lock] | ||||
|  | ||||
| [bumpversion:file:package.json] | ||||
|  | ||||
| [bumpversion:file:docker-compose.yml] | ||||
|  | ||||
| @ -10,6 +10,9 @@ insert_final_newline = true | ||||
| [*.html] | ||||
| indent_size = 2 | ||||
|  | ||||
| [schemas/*.json] | ||||
| indent_size = 2 | ||||
|  | ||||
| [*.{yaml,yml}] | ||||
| indent_size = 2 | ||||
|  | ||||
|  | ||||
							
								
								
									
										22
									
								
								.github/ISSUE_TEMPLATE/docs_issue.md
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										22
									
								
								.github/ISSUE_TEMPLATE/docs_issue.md
									
									
									
									
										vendored
									
									
								
							| @ -1,22 +0,0 @@ | ||||
| --- | ||||
| name: Documentation issue | ||||
| about: Suggest an improvement or report a problem | ||||
| title: "" | ||||
| labels: documentation | ||||
| assignees: "" | ||||
| --- | ||||
|  | ||||
| **Do you see an area that can be clarified or expanded, a technical inaccuracy, or a broken link? Please describe.** | ||||
| A clear and concise description of what the problem is, or where the document can be improved. Ex. I believe we need more details about [...] | ||||
|  | ||||
| **Provide the URL or link to the exact page in the documentation to which you are referring.** | ||||
| If there are multiple pages, list them all, and be sure to state the header or section where the content is. | ||||
|  | ||||
| **Describe the solution you'd like** | ||||
| A clear and concise description of what you want to happen. | ||||
|  | ||||
| **Additional context** | ||||
| Add any other context or screenshots about the documentation issue here. | ||||
|  | ||||
| **Consider opening a PR!** | ||||
| If the issue is one that you can fix, or even make a good pass at, we'd appreciate a PR. For more information about making a contribution to the docs, and using our Style Guide and our templates, refer to ["Writing documentation"](https://docs.goauthentik.io/docs/developer-docs/docs/writing-documentation). | ||||
| @ -44,6 +44,7 @@ if is_release: | ||||
|         ] | ||||
|         if not prerelease: | ||||
|             image_tags += [ | ||||
|                 f"{name}:latest", | ||||
|                 f"{name}:{version_family}", | ||||
|             ] | ||||
| else: | ||||
|  | ||||
							
								
								
									
										1
									
								
								.github/workflows/api-py-publish.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										1
									
								
								.github/workflows/api-py-publish.yml
									
									
									
									
										vendored
									
									
								
							| @ -30,6 +30,7 @@ jobs: | ||||
|         uses: actions/setup-python@v5 | ||||
|         with: | ||||
|           python-version-file: "pyproject.toml" | ||||
|           cache: "poetry" | ||||
|       - name: Generate API Client | ||||
|         run: make gen-client-py | ||||
|       - name: Publish package | ||||
|  | ||||
							
								
								
									
										12
									
								
								.github/workflows/ci-main.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										12
									
								
								.github/workflows/ci-main.yml
									
									
									
									
										vendored
									
									
								
							| @ -70,18 +70,22 @@ jobs: | ||||
|       - name: checkout stable | ||||
|         run: | | ||||
|           # Copy current, latest config to local | ||||
|           # Temporarly comment the .github backup while migrating to uv | ||||
|           cp authentik/lib/default.yml local.env.yml | ||||
|           cp -R .github .. | ||||
|           # cp -R .github .. | ||||
|           cp -R scripts .. | ||||
|           git checkout $(git tag --sort=version:refname | grep '^version/' | grep -vE -- '-rc[0-9]+$' | tail -n1) | ||||
|           rm -rf .github/ scripts/ | ||||
|           mv ../.github ../scripts . | ||||
|           # rm -rf .github/ scripts/ | ||||
|           # mv ../.github ../scripts . | ||||
|           rm -rf scripts/ | ||||
|           mv ../scripts . | ||||
|       - name: Setup authentik env (stable) | ||||
|         uses: ./.github/actions/setup | ||||
|         with: | ||||
|           postgresql_version: ${{ matrix.psql }} | ||||
|         continue-on-error: true | ||||
|       - name: run migrations to stable | ||||
|         run: uv run python -m lifecycle.migrate | ||||
|         run: poetry run python -m lifecycle.migrate | ||||
|       - name: checkout current code | ||||
|         run: | | ||||
|           set -x | ||||
|  | ||||
							
								
								
									
										2
									
								
								.github/workflows/ci-outpost.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/workflows/ci-outpost.yml
									
									
									
									
										vendored
									
									
								
							| @ -29,7 +29,7 @@ jobs: | ||||
|       - name: Generate API | ||||
|         run: make gen-client-go | ||||
|       - name: golangci-lint | ||||
|         uses: golangci/golangci-lint-action@v7 | ||||
|         uses: golangci/golangci-lint-action@v6 | ||||
|         with: | ||||
|           version: latest | ||||
|           args: --timeout 5000s --verbose | ||||
|  | ||||
							
								
								
									
										45
									
								
								.github/workflows/packages-npm-publish.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										45
									
								
								.github/workflows/packages-npm-publish.yml
									
									
									
									
										vendored
									
									
								
							| @ -1,45 +0,0 @@ | ||||
| name: authentik-packages-npm-publish | ||||
| on: | ||||
|   push: | ||||
|     branches: [main] | ||||
|     paths: | ||||
|       - packages/docusaurus-config/** | ||||
|       - packages/eslint-config/** | ||||
|       - packages/prettier-config/** | ||||
|       - packages/tsconfig/** | ||||
|   workflow_dispatch: | ||||
| jobs: | ||||
|   publish: | ||||
|     if: ${{ github.repository != 'goauthentik/authentik-internal' }} | ||||
|     runs-on: ubuntu-latest | ||||
|     strategy: | ||||
|       fail-fast: false | ||||
|       matrix: | ||||
|         package: | ||||
|           - docusaurus-config | ||||
|           - eslint-config | ||||
|           - prettier-config | ||||
|           - tsconfig | ||||
|     steps: | ||||
|       - uses: actions/checkout@v4 | ||||
|         with: | ||||
|           fetch-depth: 2 | ||||
|       - uses: actions/setup-node@v4 | ||||
|         with: | ||||
|           node-version-file: packages/${{ matrix.package }}/package.json | ||||
|           registry-url: "https://registry.npmjs.org" | ||||
|       - name: Get changed files | ||||
|         id: changed-files | ||||
|         uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c | ||||
|         with: | ||||
|           files: | | ||||
|             packages/${{ matrix.package }}/package.json | ||||
|       - name: Publish package | ||||
|         if: steps.changed-files.outputs.any_changed == 'true' | ||||
|         working-directory: packages/${{ matrix.package}} | ||||
|         run: | | ||||
|           npm ci | ||||
|           npm run build | ||||
|           npm publish | ||||
|         env: | ||||
|           NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }} | ||||
							
								
								
									
										26
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										26
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							| @ -11,10 +11,6 @@ local_settings.py | ||||
| db.sqlite3 | ||||
| media | ||||
|  | ||||
| # Node | ||||
|  | ||||
| node_modules | ||||
|  | ||||
| # If your build process includes running collectstatic, then you probably don't need or want to include staticfiles/ | ||||
| # in your Git repository. Update and uncomment the following line accordingly. | ||||
| # <django-project-name>/staticfiles/ | ||||
| @ -217,3 +213,25 @@ source_docs/ | ||||
|  | ||||
| ### Docker ### | ||||
| docker-compose.override.yml | ||||
|  | ||||
|  | ||||
| ### Node ### | ||||
| # Logs | ||||
| logs | ||||
| *.log | ||||
| npm-debug.log* | ||||
| yarn-debug.log* | ||||
| yarn-error.log* | ||||
| lerna-debug.log* | ||||
|  | ||||
| node_modules/ | ||||
|  | ||||
|  | ||||
| # Wireit's cache | ||||
| .wireit | ||||
|  | ||||
| custom-elements.json | ||||
|  | ||||
|  | ||||
| ### Development ### | ||||
| .drafts | ||||
|  | ||||
							
								
								
									
										2
									
								
								.vscode/extensions.json
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.vscode/extensions.json
									
									
									
									
										vendored
									
									
								
							| @ -17,6 +17,6 @@ | ||||
|         "ms-python.vscode-pylance", | ||||
|         "redhat.vscode-yaml", | ||||
|         "Tobermory.es6-string-html", | ||||
|         "unifiedjs.vscode-mdx", | ||||
|         "unifiedjs.vscode-mdx" | ||||
|     ] | ||||
| } | ||||
|  | ||||
							
								
								
									
										57
									
								
								.vscode/settings.json
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										57
									
								
								.vscode/settings.json
									
									
									
									
										vendored
									
									
								
							| @ -16,7 +16,7 @@ | ||||
|     ], | ||||
|     "typescript.preferences.importModuleSpecifier": "non-relative", | ||||
|     "typescript.preferences.importModuleSpecifierEnding": "index", | ||||
|     "typescript.tsdk": "./web/node_modules/typescript/lib", | ||||
|     "typescript.tsdk": "./node_modules/typescript/lib", | ||||
|     "typescript.enablePromptUseWorkspaceTsdk": true, | ||||
|     "yaml.schemas": { | ||||
|         "./blueprints/schema.json": "blueprints/**/*.yaml" | ||||
| @ -30,7 +30,56 @@ | ||||
|         } | ||||
|     ], | ||||
|     "go.testFlags": ["-count=1"], | ||||
|     "github-actions.workflows.pinned.workflows": [ | ||||
|         ".github/workflows/ci-main.yml" | ||||
|     ] | ||||
|     "github-actions.workflows.pinned.workflows": [".github/workflows/ci-main.yml"], | ||||
|  | ||||
|     "eslint.useFlatConfig": true, | ||||
|  | ||||
|     "explorer.fileNesting.enabled": true, | ||||
|     "explorer.fileNesting.patterns": { | ||||
|         "*.cjs": "*.d.cts", | ||||
|         "package.json": "package-lock.json, yarn.lock, .yarnrc, .yarnrc.yml, .yarn, .nvmrc, .node-version", | ||||
|         "tsconfig.json": "tsconfig.*.json, jsconfig.json" | ||||
|     }, | ||||
|  | ||||
|     "search.exclude": { | ||||
|         "**/node_modules": true, | ||||
|         "**/*.code-search": true, | ||||
|         "**/dist": true, | ||||
|         "**/out": true, | ||||
|         "**/package-lock.json": true | ||||
|     }, | ||||
|  | ||||
|     "[css]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[javascript]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[javascriptreact]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[json]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[markdown]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[shellscript]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[typescript]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "[typescriptreact]": { | ||||
|         "editor.defaultFormatter": "esbenp.prettier-vscode" | ||||
|     }, | ||||
|     "editor.codeActionsOnSave": { | ||||
|         "source.removeUnusedImports": "explicit" | ||||
|     }, | ||||
|     // We use Prettier for formatting, but specifying these settings | ||||
|     // will ensure that VS Code's IntelliSense doesn't autocomplete unformatted code. | ||||
|     "javascript.format.semicolons": "insert", | ||||
|     "typescript.format.semicolons": "insert", | ||||
|     "javascript.preferences.quoteStyle": "double", | ||||
|     "typescript.preferences.quoteStyle": "double" | ||||
| } | ||||
|  | ||||
							
								
								
									
										40
									
								
								.vscode/tasks.json
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										40
									
								
								.vscode/tasks.json
									
									
									
									
										vendored
									
									
								
							| @ -4,12 +4,7 @@ | ||||
|         { | ||||
|             "label": "authentik/core: make", | ||||
|             "command": "uv", | ||||
|             "args": [ | ||||
|                 "run", | ||||
|                 "make", | ||||
|                 "lint-fix", | ||||
|                 "lint" | ||||
|             ], | ||||
|             "args": ["run", "make", "lint-fix", "lint"], | ||||
|             "presentation": { | ||||
|                 "panel": "new" | ||||
|             }, | ||||
| @ -18,11 +13,7 @@ | ||||
|         { | ||||
|             "label": "authentik/core: run", | ||||
|             "command": "uv", | ||||
|             "args": [ | ||||
|                 "run", | ||||
|                 "ak", | ||||
|                 "server" | ||||
|             ], | ||||
|             "args": ["run", "ak", "server"], | ||||
|             "group": "build", | ||||
|             "presentation": { | ||||
|                 "panel": "dedicated", | ||||
| @ -32,17 +23,13 @@ | ||||
|         { | ||||
|             "label": "authentik/web: make", | ||||
|             "command": "make", | ||||
|             "args": [ | ||||
|                 "web" | ||||
|             ], | ||||
|             "args": ["web"], | ||||
|             "group": "build" | ||||
|         }, | ||||
|         { | ||||
|             "label": "authentik/web: watch", | ||||
|             "command": "make", | ||||
|             "args": [ | ||||
|                 "web-watch" | ||||
|             ], | ||||
|             "args": ["web-watch"], | ||||
|             "group": "build", | ||||
|             "presentation": { | ||||
|                 "panel": "dedicated", | ||||
| @ -52,26 +39,19 @@ | ||||
|         { | ||||
|             "label": "authentik: install", | ||||
|             "command": "make", | ||||
|             "args": [ | ||||
|                 "install", | ||||
|                 "-j4" | ||||
|             ], | ||||
|             "args": ["install", "-j4"], | ||||
|             "group": "build" | ||||
|         }, | ||||
|         { | ||||
|             "label": "authentik/website: make", | ||||
|             "command": "make", | ||||
|             "args": [ | ||||
|                 "website" | ||||
|             ], | ||||
|             "args": ["website"], | ||||
|             "group": "build" | ||||
|         }, | ||||
|         { | ||||
|             "label": "authentik/website: watch", | ||||
|             "command": "make", | ||||
|             "args": [ | ||||
|                 "website-watch" | ||||
|             ], | ||||
|             "args": ["website-watch"], | ||||
|             "group": "build", | ||||
|             "presentation": { | ||||
|                 "panel": "dedicated", | ||||
| @ -81,11 +61,7 @@ | ||||
|         { | ||||
|             "label": "authentik/api: generate", | ||||
|             "command": "uv", | ||||
|             "args": [ | ||||
|                 "run", | ||||
|                 "make", | ||||
|                 "gen" | ||||
|             ], | ||||
|             "args": ["run", "make", "gen"], | ||||
|             "group": "build" | ||||
|         } | ||||
|     ] | ||||
|  | ||||
| @ -23,8 +23,6 @@ docker-compose.yml              @goauthentik/infrastructure | ||||
| Makefile                        @goauthentik/infrastructure | ||||
| .editorconfig                   @goauthentik/infrastructure | ||||
| CODEOWNERS                      @goauthentik/infrastructure | ||||
| # Web packages | ||||
| packages/                       @goauthentik/frontend | ||||
| # Web | ||||
| web/                            @goauthentik/frontend | ||||
| tests/wdio/                     @goauthentik/frontend | ||||
|  | ||||
| @ -43,7 +43,7 @@ COPY ./gen-ts-api /work/web/node_modules/@goauthentik/api | ||||
| RUN npm run build | ||||
|  | ||||
| # Stage 3: Build go proxy | ||||
| FROM --platform=${BUILDPLATFORM} docker.io/library/golang:1.24-bookworm AS go-builder | ||||
| FROM --platform=${BUILDPLATFORM} mcr.microsoft.com/oss/go/microsoft/golang:1.23-fips-bookworm AS go-builder | ||||
|  | ||||
| ARG TARGETOS | ||||
| ARG TARGETARCH | ||||
| @ -76,7 +76,7 @@ COPY ./go.sum /go/src/goauthentik.io/go.sum | ||||
| RUN --mount=type=cache,sharing=locked,target=/go/pkg/mod \ | ||||
|     --mount=type=cache,id=go-build-$TARGETARCH$TARGETVARIANT,sharing=locked,target=/root/.cache/go-build \ | ||||
|     if [ "$TARGETARCH" = "arm64" ]; then export CC=aarch64-linux-gnu-gcc && export CC_FOR_TARGET=gcc-aarch64-linux-gnu; fi && \ | ||||
|     CGO_ENABLED=1 GOFIPS140=latest GOARM="${TARGETVARIANT#v}" \ | ||||
|     CGO_ENABLED=1 GOEXPERIMENT="systemcrypto" GOFLAGS="-tags=requirefips" GOARM="${TARGETVARIANT#v}" \ | ||||
|     go build -o /go/authentik ./cmd/server | ||||
|  | ||||
| # Stage 4: MaxMind GeoIP | ||||
| @ -94,9 +94,9 @@ RUN --mount=type=secret,id=GEOIPUPDATE_ACCOUNT_ID \ | ||||
|     /bin/sh -c "/usr/bin/entry.sh || echo 'Failed to get GeoIP database, disabling'; exit 0" | ||||
|  | ||||
| # Stage 5: Download uv | ||||
| FROM ghcr.io/astral-sh/uv:0.7.0 AS uv | ||||
| FROM ghcr.io/astral-sh/uv:0.6.9 AS uv | ||||
| # Stage 6: Base python image | ||||
| FROM ghcr.io/goauthentik/fips-python:3.12.10-slim-bookworm-fips AS python-base | ||||
| FROM ghcr.io/goauthentik/fips-python:3.12.8-slim-bookworm-fips AS python-base | ||||
|  | ||||
| ENV VENV_PATH="/ak-root/.venv" \ | ||||
|     PATH="/lifecycle:/ak-root/.venv/bin:$PATH" \ | ||||
|  | ||||
							
								
								
									
										12
									
								
								Makefile
									
									
									
									
									
								
							
							
						
						
									
										12
									
								
								Makefile
									
									
									
									
									
								
							| @ -133,16 +133,14 @@ gen-client-ts: gen-clean-ts  ## Build and install the authentik API for Typescri | ||||
| 		--rm -v ${PWD}:/local \ | ||||
| 		--user ${UID}:${GID} \ | ||||
| 		docker.io/openapitools/openapi-generator-cli:v7.11.0 generate \ | ||||
| 		-i /local/schema.yml \ | ||||
| 		-g typescript-fetch \ | ||||
| 		-o /local/${GEN_API_TS} \ | ||||
| 		-c /local/scripts/api-ts-config.yaml \ | ||||
| 		--input-spec /local/schema.yml \ | ||||
| 		--generator-name typescript-fetch \ | ||||
| 		--output /local/${GEN_API_TS} \ | ||||
| 		--config /local/scripts/api-ts-config.yaml \ | ||||
| 		--additional-properties=npmVersion=${NPM_VERSION} \ | ||||
| 		--git-repo-id authentik \ | ||||
| 		--git-user-id goauthentik | ||||
| 	mkdir -p web/node_modules/@goauthentik/api | ||||
| 	cd ./${GEN_API_TS} && npm i | ||||
| 	\cp -rf ./${GEN_API_TS}/* web/node_modules/@goauthentik/api | ||||
| 	npm install | ||||
|  | ||||
| gen-client-py: gen-clean-py ## Build and install the authentik API for Python | ||||
| 	docker run \ | ||||
|  | ||||
| @ -20,8 +20,8 @@ Even if the issue is not a CVE, we still greatly appreciate your help in hardeni | ||||
|  | ||||
| | Version   | Supported | | ||||
| | --------- | --------- | | ||||
| | 2024.12.x | ✅        | | ||||
| | 2025.2.x  | ✅        | | ||||
| | 2025.4.x  | ✅        | | ||||
|  | ||||
| ## Reporting a Vulnerability | ||||
|  | ||||
|  | ||||
| @ -2,7 +2,7 @@ | ||||
|  | ||||
| from os import environ | ||||
|  | ||||
| __version__ = "2025.4.0" | ||||
| __version__ = "2025.2.2" | ||||
| ENV_GIT_HASH_KEY = "GIT_BUILD_HASH" | ||||
|  | ||||
|  | ||||
|  | ||||
| @ -7,7 +7,7 @@ from rest_framework.exceptions import ValidationError | ||||
| from rest_framework.fields import CharField, DateTimeField | ||||
| from rest_framework.request import Request | ||||
| from rest_framework.response import Response | ||||
| from rest_framework.serializers import ListSerializer | ||||
| from rest_framework.serializers import ListSerializer, ModelSerializer | ||||
| from rest_framework.viewsets import ModelViewSet | ||||
|  | ||||
| from authentik.blueprints.models import BlueprintInstance | ||||
| @ -15,7 +15,7 @@ from authentik.blueprints.v1.importer import Importer | ||||
| from authentik.blueprints.v1.oci import OCI_PREFIX | ||||
| from authentik.blueprints.v1.tasks import apply_blueprint, blueprints_find_dict | ||||
| from authentik.core.api.used_by import UsedByMixin | ||||
| from authentik.core.api.utils import JSONDictField, ModelSerializer, PassiveSerializer | ||||
| from authentik.core.api.utils import JSONDictField, PassiveSerializer | ||||
| from authentik.rbac.decorators import permission_required | ||||
|  | ||||
|  | ||||
|  | ||||
| @ -36,7 +36,6 @@ from authentik.core.models import ( | ||||
|     GroupSourceConnection, | ||||
|     PropertyMapping, | ||||
|     Provider, | ||||
|     Session, | ||||
|     Source, | ||||
|     User, | ||||
|     UserSourceConnection, | ||||
| @ -109,7 +108,6 @@ def excluded_models() -> list[type[Model]]: | ||||
|         Policy, | ||||
|         PolicyBindingModel, | ||||
|         # Classes that have other dependencies | ||||
|         Session, | ||||
|         AuthenticatedSession, | ||||
|         # Classes which are only internally managed | ||||
|         # FIXME: these shouldn't need to be explicitly listed, but rather based off of a mixin | ||||
|  | ||||
| @ -16,7 +16,7 @@ def migrate_custom_css(apps: Apps, schema_editor: BaseDatabaseSchemaEditor): | ||||
|     if not path.exists(): | ||||
|         return | ||||
|     css = path.read_text() | ||||
|     Brand.objects.using(db_alias).all().update(branding_custom_css=css) | ||||
|     Brand.objects.using(db_alias).update(branding_custom_css=css) | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
| @ -46,7 +46,7 @@ LOGGER = get_logger() | ||||
|  | ||||
| def user_app_cache_key(user_pk: str, page_number: int | None = None) -> str: | ||||
|     """Cache key where application list for user is saved""" | ||||
|     key = f"{CACHE_PREFIX}app_access/{user_pk}" | ||||
|     key = f"{CACHE_PREFIX}/app_access/{user_pk}" | ||||
|     if page_number: | ||||
|         key += f"/{page_number}" | ||||
|     return key | ||||
|  | ||||
| @ -5,7 +5,6 @@ from typing import TypedDict | ||||
| from rest_framework import mixins | ||||
| from rest_framework.fields import SerializerMethodField | ||||
| from rest_framework.request import Request | ||||
| from rest_framework.serializers import CharField, DateTimeField, IPAddressField | ||||
| from rest_framework.viewsets import GenericViewSet | ||||
| from ua_parser import user_agent_parser | ||||
|  | ||||
| @ -55,11 +54,6 @@ class UserAgentDict(TypedDict): | ||||
| class AuthenticatedSessionSerializer(ModelSerializer): | ||||
|     """AuthenticatedSession Serializer""" | ||||
|  | ||||
|     expires = DateTimeField(source="session.expires", read_only=True) | ||||
|     last_ip = IPAddressField(source="session.last_ip", read_only=True) | ||||
|     last_user_agent = CharField(source="session.last_user_agent", read_only=True) | ||||
|     last_used = DateTimeField(source="session.last_used", read_only=True) | ||||
|  | ||||
|     current = SerializerMethodField() | ||||
|     user_agent = SerializerMethodField() | ||||
|     geo_ip = SerializerMethodField() | ||||
| @ -68,19 +62,19 @@ class AuthenticatedSessionSerializer(ModelSerializer): | ||||
|     def get_current(self, instance: AuthenticatedSession) -> bool: | ||||
|         """Check if session is currently active session""" | ||||
|         request: Request = self.context["request"] | ||||
|         return request._request.session.session_key == instance.session.session_key | ||||
|         return request._request.session.session_key == instance.session_key | ||||
|  | ||||
|     def get_user_agent(self, instance: AuthenticatedSession) -> UserAgentDict: | ||||
|         """Get parsed user agent""" | ||||
|         return user_agent_parser.Parse(instance.session.last_user_agent) | ||||
|         return user_agent_parser.Parse(instance.last_user_agent) | ||||
|  | ||||
|     def get_geo_ip(self, instance: AuthenticatedSession) -> GeoIPDict | None:  # pragma: no cover | ||||
|         """Get GeoIP Data""" | ||||
|         return GEOIP_CONTEXT_PROCESSOR.city_dict(instance.session.last_ip) | ||||
|         return GEOIP_CONTEXT_PROCESSOR.city_dict(instance.last_ip) | ||||
|  | ||||
|     def get_asn(self, instance: AuthenticatedSession) -> ASNDict | None:  # pragma: no cover | ||||
|         """Get ASN Data""" | ||||
|         return ASN_CONTEXT_PROCESSOR.asn_dict(instance.session.last_ip) | ||||
|         return ASN_CONTEXT_PROCESSOR.asn_dict(instance.last_ip) | ||||
|  | ||||
|     class Meta: | ||||
|         model = AuthenticatedSession | ||||
| @ -96,7 +90,6 @@ class AuthenticatedSessionSerializer(ModelSerializer): | ||||
|             "last_used", | ||||
|             "expires", | ||||
|         ] | ||||
|         extra_args = {"uuid": {"read_only": True}} | ||||
|  | ||||
|  | ||||
| class AuthenticatedSessionViewSet( | ||||
| @ -108,10 +101,9 @@ class AuthenticatedSessionViewSet( | ||||
| ): | ||||
|     """AuthenticatedSession Viewset""" | ||||
|  | ||||
|     lookup_field = "uuid" | ||||
|     queryset = AuthenticatedSession.objects.select_related("session").all() | ||||
|     queryset = AuthenticatedSession.objects.all() | ||||
|     serializer_class = AuthenticatedSessionSerializer | ||||
|     search_fields = ["user__username", "session__last_ip", "session__last_user_agent"] | ||||
|     filterset_fields = ["user__username", "session__last_ip", "session__last_user_agent"] | ||||
|     search_fields = ["user__username", "last_ip", "last_user_agent"] | ||||
|     filterset_fields = ["user__username", "last_ip", "last_user_agent"] | ||||
|     ordering = ["user__username"] | ||||
|     owner_field = "user" | ||||
|  | ||||
| @ -179,13 +179,10 @@ class UserSourceConnectionSerializer(SourceSerializer): | ||||
|             "user", | ||||
|             "source", | ||||
|             "source_obj", | ||||
|             "identifier", | ||||
|             "created", | ||||
|             "last_updated", | ||||
|         ] | ||||
|         extra_kwargs = { | ||||
|             "created": {"read_only": True}, | ||||
|             "last_updated": {"read_only": True}, | ||||
|         } | ||||
|  | ||||
|  | ||||
| @ -202,7 +199,7 @@ class UserSourceConnectionViewSet( | ||||
|     queryset = UserSourceConnection.objects.all() | ||||
|     serializer_class = UserSourceConnectionSerializer | ||||
|     filterset_fields = ["user", "source__slug"] | ||||
|     search_fields = ["user__username", "source__slug", "identifier"] | ||||
|     search_fields = ["source__slug"] | ||||
|     ordering = ["source__slug", "pk"] | ||||
|     owner_field = "user" | ||||
|  | ||||
| @ -221,11 +218,9 @@ class GroupSourceConnectionSerializer(SourceSerializer): | ||||
|             "source_obj", | ||||
|             "identifier", | ||||
|             "created", | ||||
|             "last_updated", | ||||
|         ] | ||||
|         extra_kwargs = { | ||||
|             "created": {"read_only": True}, | ||||
|             "last_updated": {"read_only": True}, | ||||
|         } | ||||
|  | ||||
|  | ||||
| @ -242,5 +237,6 @@ class GroupSourceConnectionViewSet( | ||||
|     queryset = GroupSourceConnection.objects.all() | ||||
|     serializer_class = GroupSourceConnectionSerializer | ||||
|     filterset_fields = ["group", "source__slug"] | ||||
|     search_fields = ["group__name", "source__slug", "identifier"] | ||||
|     search_fields = ["source__slug"] | ||||
|     ordering = ["source__slug", "pk"] | ||||
|     owner_field = "user" | ||||
|  | ||||
| @ -6,6 +6,8 @@ from typing import Any | ||||
|  | ||||
| from django.contrib.auth import update_session_auth_hash | ||||
| from django.contrib.auth.models import Permission | ||||
| from django.contrib.sessions.backends.cache import KEY_PREFIX | ||||
| from django.core.cache import cache | ||||
| from django.db.models.functions import ExtractHour | ||||
| from django.db.transaction import atomic | ||||
| from django.db.utils import IntegrityError | ||||
| @ -69,8 +71,8 @@ from authentik.core.middleware import ( | ||||
| from authentik.core.models import ( | ||||
|     USER_ATTRIBUTE_TOKEN_EXPIRING, | ||||
|     USER_PATH_SERVICE_ACCOUNT, | ||||
|     AuthenticatedSession, | ||||
|     Group, | ||||
|     Session, | ||||
|     Token, | ||||
|     TokenIntents, | ||||
|     User, | ||||
| @ -224,7 +226,6 @@ class UserSerializer(ModelSerializer): | ||||
|             "name", | ||||
|             "is_active", | ||||
|             "last_login", | ||||
|             "date_joined", | ||||
|             "is_superuser", | ||||
|             "groups", | ||||
|             "groups_obj", | ||||
| @ -239,7 +240,6 @@ class UserSerializer(ModelSerializer): | ||||
|         ] | ||||
|         extra_kwargs = { | ||||
|             "name": {"allow_blank": True}, | ||||
|             "date_joined": {"read_only": True}, | ||||
|             "password_change_date": {"read_only": True}, | ||||
|         } | ||||
|  | ||||
| @ -373,7 +373,7 @@ class UsersFilter(FilterSet): | ||||
|         method="filter_attributes", | ||||
|     ) | ||||
|  | ||||
|     is_superuser = BooleanFilter(field_name="ak_groups", method="filter_is_superuser") | ||||
|     is_superuser = BooleanFilter(field_name="ak_groups", lookup_expr="is_superuser") | ||||
|     uuid = UUIDFilter(field_name="uuid") | ||||
|  | ||||
|     path = CharFilter(field_name="path") | ||||
| @ -391,11 +391,6 @@ class UsersFilter(FilterSet): | ||||
|         queryset=Group.objects.all().order_by("name"), | ||||
|     ) | ||||
|  | ||||
|     def filter_is_superuser(self, queryset, name, value): | ||||
|         if value: | ||||
|             return queryset.filter(ak_groups__is_superuser=True).distinct() | ||||
|         return queryset.exclude(ak_groups__is_superuser=True).distinct() | ||||
|  | ||||
|     def filter_attributes(self, queryset, name, value): | ||||
|         """Filter attributes by query args""" | ||||
|         try: | ||||
| @ -772,6 +767,9 @@ class UserViewSet(UsedByMixin, ModelViewSet): | ||||
|         response = super().partial_update(request, *args, **kwargs) | ||||
|         instance: User = self.get_object() | ||||
|         if not instance.is_active: | ||||
|             Session.objects.filter(authenticatedsession__user=instance).delete() | ||||
|             sessions = AuthenticatedSession.objects.filter(user=instance) | ||||
|             session_ids = sessions.values_list("session_key", flat=True) | ||||
|             cache.delete_many(f"{KEY_PREFIX}{session}" for session in session_ids) | ||||
|             sessions.delete() | ||||
|             LOGGER.debug("Deleted user's sessions", user=instance.username) | ||||
|         return response | ||||
|  | ||||
| @ -20,8 +20,6 @@ from rest_framework.serializers import ( | ||||
|     raise_errors_on_nested_writes, | ||||
| ) | ||||
|  | ||||
| from authentik.rbac.permissions import assign_initial_permissions | ||||
|  | ||||
|  | ||||
| def is_dict(value: Any): | ||||
|     """Ensure a value is a dictionary, useful for JSONFields""" | ||||
| @ -31,14 +29,6 @@ def is_dict(value: Any): | ||||
|  | ||||
|  | ||||
| class ModelSerializer(BaseModelSerializer): | ||||
|     def create(self, validated_data): | ||||
|         instance = super().create(validated_data) | ||||
|  | ||||
|         request = self.context.get("request") | ||||
|         if request and hasattr(request, "user") and not request.user.is_anonymous: | ||||
|             assign_initial_permissions(request.user, instance) | ||||
|  | ||||
|         return instance | ||||
|  | ||||
|     def update(self, instance: Model, validated_data): | ||||
|         raise_errors_on_nested_writes("update", self, validated_data) | ||||
|  | ||||
| @ -24,15 +24,6 @@ class InbuiltBackend(ModelBackend): | ||||
|         self.set_method("password", request) | ||||
|         return user | ||||
|  | ||||
|     async def aauthenticate( | ||||
|         self, request: HttpRequest, username: str | None, password: str | None, **kwargs: Any | ||||
|     ) -> User | None: | ||||
|         user = await super().aauthenticate(request, username=username, password=password, **kwargs) | ||||
|         if not user: | ||||
|             return None | ||||
|         self.set_method("password", request) | ||||
|         return user | ||||
|  | ||||
|     def set_method(self, method: str, request: HttpRequest | None, **kwargs): | ||||
|         """Set method data on current flow, if possbiel""" | ||||
|         if not request: | ||||
|  | ||||
| @ -1,15 +0,0 @@ | ||||
| """Change user type""" | ||||
|  | ||||
| from importlib import import_module | ||||
|  | ||||
| from django.conf import settings | ||||
|  | ||||
| from authentik.tenants.management import TenantCommand | ||||
|  | ||||
|  | ||||
| class Command(TenantCommand): | ||||
|     """Delete all sessions""" | ||||
|  | ||||
|     def handle_per_tenant(self, **options): | ||||
|         engine = import_module(settings.SESSION_ENGINE) | ||||
|         engine.SessionStore.clear_expired() | ||||
| @ -2,14 +2,9 @@ | ||||
|  | ||||
| from collections.abc import Callable | ||||
| from contextvars import ContextVar | ||||
| from functools import partial | ||||
| from uuid import uuid4 | ||||
|  | ||||
| from django.contrib.auth.models import AnonymousUser | ||||
| from django.core.exceptions import ImproperlyConfigured | ||||
| from django.http import HttpRequest, HttpResponse | ||||
| from django.utils.deprecation import MiddlewareMixin | ||||
| from django.utils.functional import SimpleLazyObject | ||||
| from django.utils.translation import override | ||||
| from sentry_sdk.api import set_tag | ||||
| from structlog.contextvars import STRUCTLOG_KEY_PREFIX | ||||
| @ -25,40 +20,6 @@ CTX_HOST = ContextVar[str | None](STRUCTLOG_KEY_PREFIX + "host", default=None) | ||||
| CTX_AUTH_VIA = ContextVar[str | None](STRUCTLOG_KEY_PREFIX + KEY_AUTH_VIA, default=None) | ||||
|  | ||||
|  | ||||
| def get_user(request): | ||||
|     if not hasattr(request, "_cached_user"): | ||||
|         user = None | ||||
|         if (authenticated_session := request.session.get("authenticatedsession", None)) is not None: | ||||
|             user = authenticated_session.user | ||||
|         request._cached_user = user or AnonymousUser() | ||||
|     return request._cached_user | ||||
|  | ||||
|  | ||||
| async def aget_user(request): | ||||
|     if not hasattr(request, "_cached_user"): | ||||
|         user = None | ||||
|         if ( | ||||
|             authenticated_session := await request.session.aget("authenticatedsession", None) | ||||
|         ) is not None: | ||||
|             user = authenticated_session.user | ||||
|         request._cached_user = user or AnonymousUser() | ||||
|     return request._cached_user | ||||
|  | ||||
|  | ||||
| class AuthenticationMiddleware(MiddlewareMixin): | ||||
|     def process_request(self, request): | ||||
|         if not hasattr(request, "session"): | ||||
|             raise ImproperlyConfigured( | ||||
|                 "The Django authentication middleware requires session " | ||||
|                 "middleware to be installed. Edit your MIDDLEWARE setting to " | ||||
|                 "insert " | ||||
|                 "'authentik.root.middleware.SessionMiddleware' before " | ||||
|                 "'authentik.core.middleware.AuthenticationMiddleware'." | ||||
|             ) | ||||
|         request.user = SimpleLazyObject(lambda: get_user(request)) | ||||
|         request.auser = partial(aget_user, request) | ||||
|  | ||||
|  | ||||
| class ImpersonateMiddleware: | ||||
|     """Middleware to impersonate users""" | ||||
|  | ||||
|  | ||||
| @ -1,19 +0,0 @@ | ||||
| # Generated by Django 5.0.13 on 2025-04-07 14:04 | ||||
|  | ||||
| from django.db import migrations, models | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_core", "0043_alter_group_options"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.AddField( | ||||
|             model_name="usersourceconnection", | ||||
|             name="new_identifier", | ||||
|             field=models.TextField(default=""), | ||||
|             preserve_default=False, | ||||
|         ), | ||||
|     ] | ||||
| @ -1,30 +0,0 @@ | ||||
| from django.db import migrations, models | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_core", "0044_usersourceconnection_new_identifier"), | ||||
|         ("authentik_sources_kerberos", "0003_migrate_userkerberossourceconnection_identifier"), | ||||
|         ("authentik_sources_oauth", "0009_migrate_useroauthsourceconnection_identifier"), | ||||
|         ("authentik_sources_plex", "0005_migrate_userplexsourceconnection_identifier"), | ||||
|         ("authentik_sources_saml", "0019_migrate_usersamlsourceconnection_identifier"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.RenameField( | ||||
|             model_name="usersourceconnection", | ||||
|             old_name="new_identifier", | ||||
|             new_name="identifier", | ||||
|         ), | ||||
|         migrations.AddIndex( | ||||
|             model_name="usersourceconnection", | ||||
|             index=models.Index(fields=["identifier"], name="authentik_c_identif_59226f_idx"), | ||||
|         ), | ||||
|         migrations.AddIndex( | ||||
|             model_name="usersourceconnection", | ||||
|             index=models.Index( | ||||
|                 fields=["source", "identifier"], name="authentik_c_source__649e04_idx" | ||||
|             ), | ||||
|         ), | ||||
|     ] | ||||
| @ -1,238 +0,0 @@ | ||||
| # Generated by Django 5.0.11 on 2025-01-27 12:58 | ||||
|  | ||||
| import uuid | ||||
| import pickle  # nosec | ||||
| from django.core import signing | ||||
| from django.contrib.auth import BACKEND_SESSION_KEY, HASH_SESSION_KEY, SESSION_KEY | ||||
| from django.db import migrations, models | ||||
| import django.db.models.deletion | ||||
| from django.conf import settings | ||||
| from django.contrib.sessions.backends.cache import KEY_PREFIX | ||||
| from django.utils.timezone import now, timedelta | ||||
| from authentik.lib.migrations import progress_bar | ||||
| from authentik.root.middleware import ClientIPMiddleware | ||||
|  | ||||
|  | ||||
| SESSION_CACHE_ALIAS = "default" | ||||
|  | ||||
|  | ||||
| class PickleSerializer: | ||||
|     """ | ||||
|     Simple wrapper around pickle to be used in signing.dumps()/loads() and | ||||
|     cache backends. | ||||
|     """ | ||||
|  | ||||
|     def __init__(self, protocol=None): | ||||
|         self.protocol = pickle.HIGHEST_PROTOCOL if protocol is None else protocol | ||||
|  | ||||
|     def dumps(self, obj): | ||||
|         """Pickle data to be stored in redis""" | ||||
|         return pickle.dumps(obj, self.protocol) | ||||
|  | ||||
|     def loads(self, data): | ||||
|         """Unpickle data to be loaded from redis""" | ||||
|         return pickle.loads(data)  # nosec | ||||
|  | ||||
|  | ||||
| def _migrate_session( | ||||
|     apps, | ||||
|     db_alias, | ||||
|     session_key, | ||||
|     session_data, | ||||
|     expires, | ||||
| ): | ||||
|     Session = apps.get_model("authentik_core", "Session") | ||||
|     OldAuthenticatedSession = apps.get_model("authentik_core", "OldAuthenticatedSession") | ||||
|     AuthenticatedSession = apps.get_model("authentik_core", "AuthenticatedSession") | ||||
|  | ||||
|     old_auth_session = ( | ||||
|         OldAuthenticatedSession.objects.using(db_alias).filter(session_key=session_key).first() | ||||
|     ) | ||||
|  | ||||
|     args = { | ||||
|         "session_key": session_key, | ||||
|         "expires": expires, | ||||
|         "last_ip": ClientIPMiddleware.default_ip, | ||||
|         "last_user_agent": "", | ||||
|         "session_data": {}, | ||||
|     } | ||||
|     for k, v in session_data.items(): | ||||
|         if k == "authentik/stages/user_login/last_ip": | ||||
|             args["last_ip"] = v | ||||
|         elif k in ["last_user_agent", "last_used"]: | ||||
|             args[k] = v | ||||
|         elif args in [SESSION_KEY, BACKEND_SESSION_KEY, HASH_SESSION_KEY]: | ||||
|             pass | ||||
|         else: | ||||
|             args["session_data"][k] = v | ||||
|     if old_auth_session: | ||||
|         args["last_user_agent"] = old_auth_session.last_user_agent | ||||
|         args["last_used"] = old_auth_session.last_used | ||||
|  | ||||
|     args["session_data"] = pickle.dumps(args["session_data"]) | ||||
|     session = Session.objects.using(db_alias).create(**args) | ||||
|  | ||||
|     if old_auth_session: | ||||
|         AuthenticatedSession.objects.using(db_alias).create( | ||||
|             session=session, | ||||
|             user=old_auth_session.user, | ||||
|         ) | ||||
|  | ||||
|  | ||||
| def migrate_redis_sessions(apps, schema_editor): | ||||
|     from django.core.cache import caches | ||||
|  | ||||
|     db_alias = schema_editor.connection.alias | ||||
|     cache = caches[SESSION_CACHE_ALIAS] | ||||
|  | ||||
|     # Not a redis cache, skipping | ||||
|     if not hasattr(cache, "keys"): | ||||
|         return | ||||
|  | ||||
|     print("\nMigrating Redis sessions to database, this might take a couple of minutes...") | ||||
|     for key, session_data in progress_bar(cache.get_many(cache.keys(f"{KEY_PREFIX}*")).items()): | ||||
|         _migrate_session( | ||||
|             apps=apps, | ||||
|             db_alias=db_alias, | ||||
|             session_key=key.removeprefix(KEY_PREFIX), | ||||
|             session_data=session_data, | ||||
|             expires=now() + timedelta(seconds=cache.ttl(key)), | ||||
|         ) | ||||
|  | ||||
|  | ||||
| def migrate_database_sessions(apps, schema_editor): | ||||
|     DjangoSession = apps.get_model("sessions", "Session") | ||||
|     db_alias = schema_editor.connection.alias | ||||
|  | ||||
|     print("\nMigration database sessions, this might take a couple of minutes...") | ||||
|     for django_session in progress_bar(DjangoSession.objects.using(db_alias).all()): | ||||
|         session_data = signing.loads( | ||||
|             django_session.session_data, | ||||
|             salt="django.contrib.sessions.SessionStore", | ||||
|             serializer=PickleSerializer, | ||||
|         ) | ||||
|         _migrate_session( | ||||
|             apps=apps, | ||||
|             db_alias=db_alias, | ||||
|             session_key=django_session.session_key, | ||||
|             session_data=session_data, | ||||
|             expires=django_session.expire_date, | ||||
|         ) | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("sessions", "0001_initial"), | ||||
|         ("authentik_core", "0045_rename_new_identifier_usersourceconnection_identifier_and_more"), | ||||
|         ("authentik_providers_oauth2", "0027_accesstoken_authentik_p_expires_9f24a5_idx_and_more"), | ||||
|         ("authentik_providers_rac", "0006_connectiontoken_authentik_p_expires_91f148_idx_and_more"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         # Rename AuthenticatedSession to OldAuthenticatedSession | ||||
|         migrations.RenameModel( | ||||
|             old_name="AuthenticatedSession", | ||||
|             new_name="OldAuthenticatedSession", | ||||
|         ), | ||||
|         migrations.RenameIndex( | ||||
|             model_name="oldauthenticatedsession", | ||||
|             new_name="authentik_c_expires_cf4f72_idx", | ||||
|             old_name="authentik_c_expires_08251d_idx", | ||||
|         ), | ||||
|         migrations.RenameIndex( | ||||
|             model_name="oldauthenticatedsession", | ||||
|             new_name="authentik_c_expirin_c1f17f_idx", | ||||
|             old_name="authentik_c_expirin_9cd839_idx", | ||||
|         ), | ||||
|         migrations.RenameIndex( | ||||
|             model_name="oldauthenticatedsession", | ||||
|             new_name="authentik_c_expirin_e04f5d_idx", | ||||
|             old_name="authentik_c_expirin_195a84_idx", | ||||
|         ), | ||||
|         migrations.RenameIndex( | ||||
|             model_name="oldauthenticatedsession", | ||||
|             new_name="authentik_c_session_a44819_idx", | ||||
|             old_name="authentik_c_session_d0f005_idx", | ||||
|         ), | ||||
|         migrations.RunSQL( | ||||
|             sql="ALTER INDEX authentik_core_authenticatedsession_user_id_5055b6cf RENAME TO authentik_core_oldauthenticatedsession_user_id_5055b6cf", | ||||
|             reverse_sql="ALTER INDEX authentik_core_oldauthenticatedsession_user_id_5055b6cf RENAME TO authentik_core_authenticatedsession_user_id_5055b6cf", | ||||
|         ), | ||||
|         # Create new Session and AuthenticatedSession models | ||||
|         migrations.CreateModel( | ||||
|             name="Session", | ||||
|             fields=[ | ||||
|                 ( | ||||
|                     "session_key", | ||||
|                     models.CharField( | ||||
|                         max_length=40, primary_key=True, serialize=False, verbose_name="session key" | ||||
|                     ), | ||||
|                 ), | ||||
|                 ("expires", models.DateTimeField(default=None, null=True)), | ||||
|                 ("expiring", models.BooleanField(default=True)), | ||||
|                 ("session_data", models.BinaryField(verbose_name="session data")), | ||||
|                 ("last_ip", models.GenericIPAddressField()), | ||||
|                 ("last_user_agent", models.TextField(blank=True)), | ||||
|                 ("last_used", models.DateTimeField(auto_now=True)), | ||||
|             ], | ||||
|             options={ | ||||
|                 "default_permissions": [], | ||||
|                 "verbose_name": "Session", | ||||
|                 "verbose_name_plural": "Sessions", | ||||
|             }, | ||||
|         ), | ||||
|         migrations.AddIndex( | ||||
|             model_name="session", | ||||
|             index=models.Index(fields=["expires"], name="authentik_c_expires_d2f607_idx"), | ||||
|         ), | ||||
|         migrations.AddIndex( | ||||
|             model_name="session", | ||||
|             index=models.Index(fields=["expiring"], name="authentik_c_expirin_7c2cfb_idx"), | ||||
|         ), | ||||
|         migrations.AddIndex( | ||||
|             model_name="session", | ||||
|             index=models.Index( | ||||
|                 fields=["expiring", "expires"], name="authentik_c_expirin_1ab2e4_idx" | ||||
|             ), | ||||
|         ), | ||||
|         migrations.AddIndex( | ||||
|             model_name="session", | ||||
|             index=models.Index( | ||||
|                 fields=["expires", "session_key"], name="authentik_c_expires_c49143_idx" | ||||
|             ), | ||||
|         ), | ||||
|         migrations.CreateModel( | ||||
|             name="AuthenticatedSession", | ||||
|             fields=[ | ||||
|                 ( | ||||
|                     "session", | ||||
|                     models.OneToOneField( | ||||
|                         on_delete=django.db.models.deletion.CASCADE, | ||||
|                         primary_key=True, | ||||
|                         serialize=False, | ||||
|                         to="authentik_core.session", | ||||
|                     ), | ||||
|                 ), | ||||
|                 ("uuid", models.UUIDField(default=uuid.uuid4, unique=True)), | ||||
|                 ( | ||||
|                     "user", | ||||
|                     models.ForeignKey( | ||||
|                         on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL | ||||
|                     ), | ||||
|                 ), | ||||
|             ], | ||||
|             options={ | ||||
|                 "verbose_name": "Authenticated Session", | ||||
|                 "verbose_name_plural": "Authenticated Sessions", | ||||
|             }, | ||||
|         ), | ||||
|         migrations.RunPython( | ||||
|             code=migrate_redis_sessions, | ||||
|             reverse_code=migrations.RunPython.noop, | ||||
|         ), | ||||
|         migrations.RunPython( | ||||
|             code=migrate_database_sessions, | ||||
|             reverse_code=migrations.RunPython.noop, | ||||
|         ), | ||||
|     ] | ||||
| @ -1,18 +0,0 @@ | ||||
| # Generated by Django 5.0.11 on 2025-01-27 13:02 | ||||
|  | ||||
| from django.db import migrations | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_core", "0046_session_and_more"), | ||||
|         ("authentik_providers_rac", "0007_migrate_session"), | ||||
|         ("authentik_providers_oauth2", "0028_migrate_session"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.DeleteModel( | ||||
|             name="OldAuthenticatedSession", | ||||
|         ), | ||||
|     ] | ||||
| @ -1,7 +1,6 @@ | ||||
| """authentik core models""" | ||||
|  | ||||
| from datetime import datetime | ||||
| from enum import StrEnum | ||||
| from hashlib import sha256 | ||||
| from typing import Any, Optional, Self | ||||
| from uuid import uuid4 | ||||
| @ -10,7 +9,6 @@ from deepmerge import always_merger | ||||
| from django.contrib.auth.hashers import check_password | ||||
| from django.contrib.auth.models import AbstractUser | ||||
| from django.contrib.auth.models import UserManager as DjangoUserManager | ||||
| from django.contrib.sessions.base_session import AbstractBaseSession | ||||
| from django.db import models | ||||
| from django.db.models import Q, QuerySet, options | ||||
| from django.db.models.constants import LOOKUP_SEP | ||||
| @ -648,30 +646,19 @@ class SourceUserMatchingModes(models.TextChoices): | ||||
|     """Different modes a source can handle new/returning users""" | ||||
|  | ||||
|     IDENTIFIER = "identifier", _("Use the source-specific identifier") | ||||
|     EMAIL_LINK = ( | ||||
|         "email_link", | ||||
|         _( | ||||
|             "Link to a user with identical email address. Can have security implications " | ||||
|             "when a source doesn't validate email addresses." | ||||
|         ), | ||||
|     EMAIL_LINK = "email_link", _( | ||||
|         "Link to a user with identical email address. Can have security implications " | ||||
|         "when a source doesn't validate email addresses." | ||||
|     ) | ||||
|     EMAIL_DENY = ( | ||||
|         "email_deny", | ||||
|         _( | ||||
|             "Use the user's email address, but deny enrollment when the email address already " | ||||
|             "exists." | ||||
|         ), | ||||
|     EMAIL_DENY = "email_deny", _( | ||||
|         "Use the user's email address, but deny enrollment when the email address already exists." | ||||
|     ) | ||||
|     USERNAME_LINK = ( | ||||
|         "username_link", | ||||
|         _( | ||||
|             "Link to a user with identical username. Can have security implications " | ||||
|             "when a username is used with another source." | ||||
|         ), | ||||
|     USERNAME_LINK = "username_link", _( | ||||
|         "Link to a user with identical username. Can have security implications " | ||||
|         "when a username is used with another source." | ||||
|     ) | ||||
|     USERNAME_DENY = ( | ||||
|         "username_deny", | ||||
|         _("Use the user's username, but deny enrollment when the username already exists."), | ||||
|     USERNAME_DENY = "username_deny", _( | ||||
|         "Use the user's username, but deny enrollment when the username already exists." | ||||
|     ) | ||||
|  | ||||
|  | ||||
| @ -679,16 +666,12 @@ class SourceGroupMatchingModes(models.TextChoices): | ||||
|     """Different modes a source can handle new/returning groups""" | ||||
|  | ||||
|     IDENTIFIER = "identifier", _("Use the source-specific identifier") | ||||
|     NAME_LINK = ( | ||||
|         "name_link", | ||||
|         _( | ||||
|             "Link to a group with identical name. Can have security implications " | ||||
|             "when a group name is used with another source." | ||||
|         ), | ||||
|     NAME_LINK = "name_link", _( | ||||
|         "Link to a group with identical name. Can have security implications " | ||||
|         "when a group name is used with another source." | ||||
|     ) | ||||
|     NAME_DENY = ( | ||||
|         "name_deny", | ||||
|         _("Use the group name, but deny enrollment when the name already exists."), | ||||
|     NAME_DENY = "name_deny", _( | ||||
|         "Use the group name, but deny enrollment when the name already exists." | ||||
|     ) | ||||
|  | ||||
|  | ||||
| @ -747,7 +730,8 @@ class Source(ManagedModel, SerializerModel, PolicyBindingModel): | ||||
|         choices=SourceGroupMatchingModes.choices, | ||||
|         default=SourceGroupMatchingModes.IDENTIFIER, | ||||
|         help_text=_( | ||||
|             "How the source determines if an existing group should be used or a new group created." | ||||
|             "How the source determines if an existing group should be used or " | ||||
|             "a new group created." | ||||
|         ), | ||||
|     ) | ||||
|  | ||||
| @ -777,17 +761,11 @@ class Source(ManagedModel, SerializerModel, PolicyBindingModel): | ||||
|     @property | ||||
|     def component(self) -> str: | ||||
|         """Return component used to edit this object""" | ||||
|         if self.managed == self.MANAGED_INBUILT: | ||||
|             return "" | ||||
|         raise NotImplementedError | ||||
|  | ||||
|     @property | ||||
|     def property_mapping_type(self) -> "type[PropertyMapping]": | ||||
|         """Return property mapping type used by this object""" | ||||
|         if self.managed == self.MANAGED_INBUILT: | ||||
|             from authentik.core.models import PropertyMapping | ||||
|  | ||||
|             return PropertyMapping | ||||
|         raise NotImplementedError | ||||
|  | ||||
|     def ui_login_button(self, request: HttpRequest) -> UILoginButton | None: | ||||
| @ -802,14 +780,10 @@ class Source(ManagedModel, SerializerModel, PolicyBindingModel): | ||||
|  | ||||
|     def get_base_user_properties(self, **kwargs) -> dict[str, Any | dict[str, Any]]: | ||||
|         """Get base properties for a user to build final properties upon.""" | ||||
|         if self.managed == self.MANAGED_INBUILT: | ||||
|             return {} | ||||
|         raise NotImplementedError | ||||
|  | ||||
|     def get_base_group_properties(self, **kwargs) -> dict[str, Any | dict[str, Any]]: | ||||
|         """Get base properties for a group to build final properties upon.""" | ||||
|         if self.managed == self.MANAGED_INBUILT: | ||||
|             return {} | ||||
|         raise NotImplementedError | ||||
|  | ||||
|     def __str__(self): | ||||
| @ -840,7 +814,6 @@ class UserSourceConnection(SerializerModel, CreatedUpdatedModel): | ||||
|  | ||||
|     user = models.ForeignKey(User, on_delete=models.CASCADE) | ||||
|     source = models.ForeignKey(Source, on_delete=models.CASCADE) | ||||
|     identifier = models.TextField() | ||||
|  | ||||
|     objects = InheritanceManager() | ||||
|  | ||||
| @ -854,10 +827,6 @@ class UserSourceConnection(SerializerModel, CreatedUpdatedModel): | ||||
|  | ||||
|     class Meta: | ||||
|         unique_together = (("user", "source"),) | ||||
|         indexes = ( | ||||
|             models.Index(fields=("identifier",)), | ||||
|             models.Index(fields=("source", "identifier")), | ||||
|         ) | ||||
|  | ||||
|  | ||||
| class GroupSourceConnection(SerializerModel, CreatedUpdatedModel): | ||||
| @ -1028,75 +997,45 @@ class PropertyMapping(SerializerModel, ManagedModel): | ||||
|         verbose_name_plural = _("Property Mappings") | ||||
|  | ||||
|  | ||||
| class Session(ExpiringModel, AbstractBaseSession): | ||||
|     """User session with extra fields for fast access""" | ||||
| class AuthenticatedSession(ExpiringModel): | ||||
|     """Additional session class for authenticated users. Augments the standard django session | ||||
|     to achieve the following: | ||||
|         - Make it queryable by user | ||||
|         - Have a direct connection to user objects | ||||
|         - Allow users to view their own sessions and terminate them | ||||
|         - Save structured and well-defined information. | ||||
|     """ | ||||
|  | ||||
|     # Remove upstream field because we're using our own ExpiringModel | ||||
|     expire_date = None | ||||
|     session_data = models.BinaryField(_("session data")) | ||||
|     uuid = models.UUIDField(default=uuid4, primary_key=True) | ||||
|  | ||||
|     # Keep in sync with Session.Keys | ||||
|     last_ip = models.GenericIPAddressField() | ||||
|     session_key = models.CharField(max_length=40) | ||||
|     user = models.ForeignKey(User, on_delete=models.CASCADE) | ||||
|  | ||||
|     last_ip = models.TextField() | ||||
|     last_user_agent = models.TextField(blank=True) | ||||
|     last_used = models.DateTimeField(auto_now=True) | ||||
|  | ||||
|     class Meta: | ||||
|         verbose_name = _("Session") | ||||
|         verbose_name_plural = _("Sessions") | ||||
|         indexes = ExpiringModel.Meta.indexes + [ | ||||
|             models.Index(fields=["expires", "session_key"]), | ||||
|         ] | ||||
|         default_permissions = [] | ||||
|  | ||||
|     def __str__(self): | ||||
|         return self.session_key | ||||
|  | ||||
|     class Keys(StrEnum): | ||||
|         """ | ||||
|         Keys to be set with the session interface for the fields above to be updated. | ||||
|  | ||||
|         If a field is added here that needs to be initialized when the session is initialized, | ||||
|         it must also be reflected in authentik.root.middleware.SessionMiddleware.process_request | ||||
|         and in authentik.core.sessions.SessionStore.__init__ | ||||
|         """ | ||||
|  | ||||
|         LAST_IP = "last_ip" | ||||
|         LAST_USER_AGENT = "last_user_agent" | ||||
|         LAST_USED = "last_used" | ||||
|  | ||||
|     @classmethod | ||||
|     def get_session_store_class(cls): | ||||
|         from authentik.core.sessions import SessionStore | ||||
|  | ||||
|         return SessionStore | ||||
|  | ||||
|     def get_decoded(self): | ||||
|         raise NotImplementedError | ||||
|  | ||||
|  | ||||
| class AuthenticatedSession(SerializerModel): | ||||
|     session = models.OneToOneField(Session, on_delete=models.CASCADE, primary_key=True) | ||||
|     # We use the session as primary key, but we need the API to be able to reference | ||||
|     # this object uniquely without exposing the session key | ||||
|     uuid = models.UUIDField(default=uuid4, unique=True) | ||||
|  | ||||
|     user = models.ForeignKey(User, on_delete=models.CASCADE) | ||||
|  | ||||
|     class Meta: | ||||
|         verbose_name = _("Authenticated Session") | ||||
|         verbose_name_plural = _("Authenticated Sessions") | ||||
|         indexes = ExpiringModel.Meta.indexes + [ | ||||
|             models.Index(fields=["session_key"]), | ||||
|         ] | ||||
|  | ||||
|     def __str__(self) -> str: | ||||
|         return f"Authenticated Session {str(self.pk)[:10]}" | ||||
|         return f"Authenticated Session {self.session_key[:10]}" | ||||
|  | ||||
|     @staticmethod | ||||
|     def from_request(request: HttpRequest, user: User) -> Optional["AuthenticatedSession"]: | ||||
|         """Create a new session from a http request""" | ||||
|         if not hasattr(request, "session") or not request.session.exists( | ||||
|             request.session.session_key | ||||
|         ): | ||||
|         from authentik.root.middleware import ClientIPMiddleware | ||||
|  | ||||
|         if not hasattr(request, "session") or not request.session.session_key: | ||||
|             return None | ||||
|         return AuthenticatedSession( | ||||
|             session=Session.objects.filter(session_key=request.session.session_key).first(), | ||||
|             session_key=request.session.session_key, | ||||
|             user=user, | ||||
|             last_ip=ClientIPMiddleware.get_client_ip(request), | ||||
|             last_user_agent=request.META.get("HTTP_USER_AGENT", ""), | ||||
|             expires=request.session.get_expiry_date(), | ||||
|         ) | ||||
|  | ||||
| @ -1,168 +0,0 @@ | ||||
| """authentik sessions engine""" | ||||
|  | ||||
| import pickle  # nosec | ||||
|  | ||||
| from django.contrib.auth import BACKEND_SESSION_KEY, HASH_SESSION_KEY, SESSION_KEY | ||||
| from django.contrib.sessions.backends.db import SessionStore as SessionBase | ||||
| from django.core.exceptions import SuspiciousOperation | ||||
| from django.utils import timezone | ||||
| from django.utils.functional import cached_property | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.root.middleware import ClientIPMiddleware | ||||
|  | ||||
| LOGGER = get_logger() | ||||
|  | ||||
|  | ||||
| class SessionStore(SessionBase): | ||||
|     def __init__(self, session_key=None, last_ip=None, last_user_agent=""): | ||||
|         super().__init__(session_key) | ||||
|         self._create_kwargs = { | ||||
|             "last_ip": last_ip or ClientIPMiddleware.default_ip, | ||||
|             "last_user_agent": last_user_agent, | ||||
|         } | ||||
|  | ||||
|     @classmethod | ||||
|     def get_model_class(cls): | ||||
|         from authentik.core.models import Session | ||||
|  | ||||
|         return Session | ||||
|  | ||||
|     @cached_property | ||||
|     def model_fields(self): | ||||
|         return [k.value for k in self.model.Keys] | ||||
|  | ||||
|     def _get_session_from_db(self): | ||||
|         try: | ||||
|             return ( | ||||
|                 self.model.objects.select_related( | ||||
|                     "authenticatedsession", | ||||
|                     "authenticatedsession__user", | ||||
|                 ) | ||||
|                 .prefetch_related( | ||||
|                     "authenticatedsession__user__groups", | ||||
|                     "authenticatedsession__user__user_permissions", | ||||
|                 ) | ||||
|                 .get( | ||||
|                     session_key=self.session_key, | ||||
|                     expires__gt=timezone.now(), | ||||
|                 ) | ||||
|             ) | ||||
|         except (self.model.DoesNotExist, SuspiciousOperation) as exc: | ||||
|             if isinstance(exc, SuspiciousOperation): | ||||
|                 LOGGER.warning(str(exc)) | ||||
|             self._session_key = None | ||||
|  | ||||
|     async def _aget_session_from_db(self): | ||||
|         try: | ||||
|             return ( | ||||
|                 await self.model.objects.select_related( | ||||
|                     "authenticatedsession", | ||||
|                     "authenticatedsession__user", | ||||
|                 ) | ||||
|                 .prefetch_related( | ||||
|                     "authenticatedsession__user__groups", | ||||
|                     "authenticatedsession__user__user_permissions", | ||||
|                 ) | ||||
|                 .aget( | ||||
|                     session_key=self.session_key, | ||||
|                     expires__gt=timezone.now(), | ||||
|                 ) | ||||
|             ) | ||||
|         except (self.model.DoesNotExist, SuspiciousOperation) as exc: | ||||
|             if isinstance(exc, SuspiciousOperation): | ||||
|                 LOGGER.warning(str(exc)) | ||||
|             self._session_key = None | ||||
|  | ||||
|     def encode(self, session_dict): | ||||
|         return pickle.dumps(session_dict, protocol=pickle.HIGHEST_PROTOCOL) | ||||
|  | ||||
|     def decode(self, session_data): | ||||
|         try: | ||||
|             return pickle.loads(session_data)  # nosec | ||||
|         except pickle.PickleError: | ||||
|             # ValueError, unpickling exceptions. If any of these happen, just return an empty | ||||
|             # dictionary (an empty session) | ||||
|             pass | ||||
|         return {} | ||||
|  | ||||
|     def load(self): | ||||
|         s = self._get_session_from_db() | ||||
|         if s: | ||||
|             return { | ||||
|                 "authenticatedsession": getattr(s, "authenticatedsession", None), | ||||
|                 **{k: getattr(s, k) for k in self.model_fields}, | ||||
|                 **self.decode(s.session_data), | ||||
|             } | ||||
|         else: | ||||
|             return {} | ||||
|  | ||||
|     async def aload(self): | ||||
|         s = await self._aget_session_from_db() | ||||
|         if s: | ||||
|             return { | ||||
|                 "authenticatedsession": getattr(s, "authenticatedsession", None), | ||||
|                 **{k: getattr(s, k) for k in self.model_fields}, | ||||
|                 **self.decode(s.session_data), | ||||
|             } | ||||
|         else: | ||||
|             return {} | ||||
|  | ||||
|     def create_model_instance(self, data): | ||||
|         args = { | ||||
|             "session_key": self._get_or_create_session_key(), | ||||
|             "expires": self.get_expiry_date(), | ||||
|             "session_data": {}, | ||||
|             **self._create_kwargs, | ||||
|         } | ||||
|         for k, v in data.items(): | ||||
|             # Don't save: | ||||
|             # - unused auth data | ||||
|             # - related models | ||||
|             if k in [SESSION_KEY, BACKEND_SESSION_KEY, HASH_SESSION_KEY, "authenticatedsession"]: | ||||
|                 pass | ||||
|             elif k in self.model_fields: | ||||
|                 args[k] = v | ||||
|             else: | ||||
|                 args["session_data"][k] = v | ||||
|         args["session_data"] = self.encode(args["session_data"]) | ||||
|         return self.model(**args) | ||||
|  | ||||
|     async def acreate_model_instance(self, data): | ||||
|         args = { | ||||
|             "session_key": await self._aget_or_create_session_key(), | ||||
|             "expires": await self.aget_expiry_date(), | ||||
|             "session_data": {}, | ||||
|             **self._create_kwargs, | ||||
|         } | ||||
|         for k, v in data.items(): | ||||
|             # Don't save: | ||||
|             # - unused auth data | ||||
|             # - related models | ||||
|             if k in [SESSION_KEY, BACKEND_SESSION_KEY, HASH_SESSION_KEY, "authenticatedsession"]: | ||||
|                 pass | ||||
|             elif k in self.model_fields: | ||||
|                 args[k] = v | ||||
|             else: | ||||
|                 args["session_data"][k] = v | ||||
|         args["session_data"] = self.encode(args["session_data"]) | ||||
|         return self.model(**args) | ||||
|  | ||||
|     @classmethod | ||||
|     def clear_expired(cls): | ||||
|         cls.get_model_class().objects.filter(expires__lt=timezone.now()).delete() | ||||
|  | ||||
|     @classmethod | ||||
|     async def aclear_expired(cls): | ||||
|         await cls.get_model_class().objects.filter(expires__lt=timezone.now()).adelete() | ||||
|  | ||||
|     def cycle_key(self): | ||||
|         data = self._session | ||||
|         key = self.session_key | ||||
|         self.create() | ||||
|         self._session_cache = data | ||||
|         if key: | ||||
|             self.delete(key) | ||||
|         if (authenticated_session := data.get("authenticatedsession")) is not None: | ||||
|             authenticated_session.session_id = self.session_key | ||||
|             authenticated_session.save(force_insert=True) | ||||
| @ -1,10 +1,11 @@ | ||||
| """authentik core signals""" | ||||
|  | ||||
| from django.contrib.auth.signals import user_logged_in | ||||
| from django.contrib.auth.signals import user_logged_in, user_logged_out | ||||
| from django.contrib.sessions.backends.cache import KEY_PREFIX | ||||
| from django.core.cache import cache | ||||
| from django.core.signals import Signal | ||||
| from django.db.models import Model | ||||
| from django.db.models.signals import post_delete, post_save, pre_save | ||||
| from django.db.models.signals import post_save, pre_delete, pre_save | ||||
| from django.dispatch import receiver | ||||
| from django.http.request import HttpRequest | ||||
| from structlog.stdlib import get_logger | ||||
| @ -14,7 +15,6 @@ from authentik.core.models import ( | ||||
|     AuthenticatedSession, | ||||
|     BackchannelProvider, | ||||
|     ExpiringModel, | ||||
|     Session, | ||||
|     User, | ||||
|     default_token_duration, | ||||
| ) | ||||
| @ -49,10 +49,19 @@ def user_logged_in_session(sender, request: HttpRequest, user: User, **_): | ||||
|         session.save() | ||||
|  | ||||
|  | ||||
| @receiver(post_delete, sender=AuthenticatedSession) | ||||
| @receiver(user_logged_out) | ||||
| def user_logged_out_session(sender, request: HttpRequest, user: User, **_): | ||||
|     """Delete AuthenticatedSession if it exists""" | ||||
|     if not request.session or not request.session.session_key: | ||||
|         return | ||||
|     AuthenticatedSession.objects.filter(session_key=request.session.session_key).delete() | ||||
|  | ||||
|  | ||||
| @receiver(pre_delete, sender=AuthenticatedSession) | ||||
| def authenticated_session_delete(sender: type[Model], instance: "AuthenticatedSession", **_): | ||||
|     """Delete session when authenticated session is deleted""" | ||||
|     Session.objects.filter(session_key=instance.pk).delete() | ||||
|     cache_key = f"{KEY_PREFIX}{instance.session_key}" | ||||
|     cache.delete(cache_key) | ||||
|  | ||||
|  | ||||
| @receiver(pre_save) | ||||
|  | ||||
| @ -48,7 +48,6 @@ LOGGER = get_logger() | ||||
|  | ||||
| PLAN_CONTEXT_SOURCE_GROUPS = "source_groups" | ||||
| SESSION_KEY_SOURCE_FLOW_STAGES = "authentik/flows/source_flow_stages" | ||||
| SESSION_KEY_SOURCE_FLOW_CONTEXT = "authentik/flows/source_flow_context" | ||||
| SESSION_KEY_OVERRIDE_FLOW_TOKEN = "authentik/flows/source_override_flow_token"  # nosec | ||||
|  | ||||
|  | ||||
| @ -262,7 +261,6 @@ class SourceFlowManager: | ||||
|                 plan.append_stage(stage) | ||||
|         for stage in self.request.session.get(SESSION_KEY_SOURCE_FLOW_STAGES, []): | ||||
|             plan.append_stage(stage) | ||||
|         plan.context.update(self.request.session.get(SESSION_KEY_SOURCE_FLOW_CONTEXT, {})) | ||||
|         return plan.to_redirect(self.request, flow) | ||||
|  | ||||
|     def handle_auth( | ||||
|  | ||||
| @ -2,16 +2,22 @@ | ||||
|  | ||||
| from datetime import datetime, timedelta | ||||
|  | ||||
| from django.conf import ImproperlyConfigured | ||||
| from django.contrib.sessions.backends.cache import KEY_PREFIX | ||||
| from django.contrib.sessions.backends.db import SessionStore as DBSessionStore | ||||
| from django.core.cache import cache | ||||
| from django.utils.timezone import now | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.core.models import ( | ||||
|     USER_ATTRIBUTE_EXPIRES, | ||||
|     USER_ATTRIBUTE_GENERATED, | ||||
|     AuthenticatedSession, | ||||
|     ExpiringModel, | ||||
|     User, | ||||
| ) | ||||
| from authentik.events.system_tasks import SystemTask, TaskStatus, prefill_task | ||||
| from authentik.lib.config import CONFIG | ||||
| from authentik.root.celery import CELERY_APP | ||||
|  | ||||
| LOGGER = get_logger() | ||||
| @ -32,6 +38,40 @@ def clean_expired_models(self: SystemTask): | ||||
|             obj.expire_action() | ||||
|         LOGGER.debug("Expired models", model=cls, amount=amount) | ||||
|         messages.append(f"Expired {amount} {cls._meta.verbose_name_plural}") | ||||
|     # Special case | ||||
|     amount = 0 | ||||
|  | ||||
|     for session in AuthenticatedSession.objects.all(): | ||||
|         match CONFIG.get("session_storage", "cache"): | ||||
|             case "cache": | ||||
|                 cache_key = f"{KEY_PREFIX}{session.session_key}" | ||||
|                 value = None | ||||
|                 try: | ||||
|                     value = cache.get(cache_key) | ||||
|  | ||||
|                 except Exception as exc: | ||||
|                     LOGGER.debug("Failed to get session from cache", exc=exc) | ||||
|                 if not value: | ||||
|                     session.delete() | ||||
|                     amount += 1 | ||||
|             case "db": | ||||
|                 if not ( | ||||
|                     DBSessionStore.get_model_class() | ||||
|                     .objects.filter(session_key=session.session_key, expire_date__gt=now()) | ||||
|                     .exists() | ||||
|                 ): | ||||
|                     session.delete() | ||||
|                     amount += 1 | ||||
|             case _: | ||||
|                 # Should never happen, as we check for other values in authentik/root/settings.py | ||||
|                 raise ImproperlyConfigured( | ||||
|                     "Invalid session_storage setting, allowed values are db and cache" | ||||
|                 ) | ||||
|     if CONFIG.get("session_storage", "cache") == "db": | ||||
|         DBSessionStore.clear_expired() | ||||
|     LOGGER.debug("Expired sessions", model=AuthenticatedSession, amount=amount) | ||||
|  | ||||
|     messages.append(f"Expired {amount} {AuthenticatedSession._meta.verbose_name_plural}") | ||||
|     self.set_status(TaskStatus.SUCCESSFUL, *messages) | ||||
|  | ||||
|  | ||||
|  | ||||
| @ -1,17 +1,9 @@ | ||||
| """Test API Utils""" | ||||
|  | ||||
| from rest_framework.exceptions import ValidationError | ||||
| from rest_framework.serializers import ( | ||||
|     HyperlinkedModelSerializer, | ||||
| ) | ||||
| from rest_framework.serializers import ( | ||||
|     ModelSerializer as BaseModelSerializer, | ||||
| ) | ||||
| from rest_framework.test import APITestCase | ||||
|  | ||||
| from authentik.core.api.utils import ModelSerializer as CustomModelSerializer | ||||
| from authentik.core.api.utils import is_dict | ||||
| from authentik.lib.utils.reflection import all_subclasses | ||||
|  | ||||
|  | ||||
| class TestAPIUtils(APITestCase): | ||||
| @ -22,14 +14,3 @@ class TestAPIUtils(APITestCase): | ||||
|         self.assertIsNone(is_dict({})) | ||||
|         with self.assertRaises(ValidationError): | ||||
|             is_dict("foo") | ||||
|  | ||||
|     def test_all_serializers_descend_from_custom(self): | ||||
|         """Test that every serializer we define descends from our own ModelSerializer""" | ||||
|         # Weirdly, there's only one serializer in `rest_framework` which descends from | ||||
|         # ModelSerializer: HyperlinkedModelSerializer | ||||
|         expected = {CustomModelSerializer, HyperlinkedModelSerializer} | ||||
|         actual = set(all_subclasses(BaseModelSerializer)) - set( | ||||
|             all_subclasses(CustomModelSerializer) | ||||
|         ) | ||||
|  | ||||
|         self.assertEqual(expected, actual) | ||||
|  | ||||
| @ -5,7 +5,7 @@ from json import loads | ||||
| from django.urls.base import reverse | ||||
| from rest_framework.test import APITestCase | ||||
|  | ||||
| from authentik.core.models import AuthenticatedSession, Session, User | ||||
| from authentik.core.models import User | ||||
| from authentik.core.tests.utils import create_test_admin_user | ||||
|  | ||||
|  | ||||
| @ -30,18 +30,3 @@ class TestAuthenticatedSessionsAPI(APITestCase): | ||||
|         self.assertEqual(response.status_code, 200) | ||||
|         body = loads(response.content.decode()) | ||||
|         self.assertEqual(body["pagination"]["count"], 1) | ||||
|  | ||||
|     def test_delete(self): | ||||
|         """Test deletion""" | ||||
|         self.client.force_login(self.user) | ||||
|         self.assertEqual(AuthenticatedSession.objects.all().count(), 1) | ||||
|         self.assertEqual(Session.objects.all().count(), 1) | ||||
|         response = self.client.delete( | ||||
|             reverse( | ||||
|                 "authentik_api:authenticatedsession-detail", | ||||
|                 kwargs={"uuid": AuthenticatedSession.objects.first().uuid}, | ||||
|             ) | ||||
|         ) | ||||
|         self.assertEqual(response.status_code, 204) | ||||
|         self.assertEqual(AuthenticatedSession.objects.all().count(), 0) | ||||
|         self.assertEqual(Session.objects.all().count(), 0) | ||||
|  | ||||
| @ -1,19 +0,0 @@ | ||||
| from django.apps import apps | ||||
| from django.urls import reverse | ||||
| from rest_framework.test import APITestCase | ||||
|  | ||||
| from authentik.core.tests.utils import create_test_admin_user | ||||
|  | ||||
|  | ||||
| class TestSourceAPI(APITestCase): | ||||
|     def setUp(self) -> None: | ||||
|         self.user = create_test_admin_user() | ||||
|         self.client.force_login(self.user) | ||||
|  | ||||
|     def test_builtin_source_used_by(self): | ||||
|         """Test Providers's types endpoint""" | ||||
|         apps.get_app_config("authentik_core").source_inbuilt() | ||||
|         response = self.client.get( | ||||
|             reverse("authentik_api:source-used-by", kwargs={"slug": "authentik-built-in"}), | ||||
|         ) | ||||
|         self.assertEqual(response.status_code, 200) | ||||
| @ -13,10 +13,7 @@ from authentik.core.models import ( | ||||
|     TokenIntents, | ||||
|     User, | ||||
| ) | ||||
| from authentik.core.tasks import ( | ||||
|     clean_expired_models, | ||||
|     clean_temporary_users, | ||||
| ) | ||||
| from authentik.core.tasks import clean_expired_models, clean_temporary_users | ||||
| from authentik.core.tests.utils import create_test_admin_user | ||||
| from authentik.lib.generators import generate_id | ||||
|  | ||||
|  | ||||
| @ -1,8 +1,9 @@ | ||||
| """Test Users API""" | ||||
|  | ||||
| from datetime import datetime | ||||
| from json import loads | ||||
|  | ||||
| from django.contrib.sessions.backends.cache import KEY_PREFIX | ||||
| from django.core.cache import cache | ||||
| from django.urls.base import reverse | ||||
| from rest_framework.test import APITestCase | ||||
|  | ||||
| @ -10,17 +11,11 @@ from authentik.brands.models import Brand | ||||
| from authentik.core.models import ( | ||||
|     USER_ATTRIBUTE_TOKEN_EXPIRING, | ||||
|     AuthenticatedSession, | ||||
|     Session, | ||||
|     Token, | ||||
|     User, | ||||
|     UserTypes, | ||||
| ) | ||||
| from authentik.core.tests.utils import ( | ||||
|     create_test_admin_user, | ||||
|     create_test_brand, | ||||
|     create_test_flow, | ||||
|     create_test_user, | ||||
| ) | ||||
| from authentik.core.tests.utils import create_test_admin_user, create_test_brand, create_test_flow | ||||
| from authentik.flows.models import FlowDesignation | ||||
| from authentik.lib.generators import generate_id, generate_key | ||||
| from authentik.stages.email.models import EmailStage | ||||
| @ -31,7 +26,7 @@ class TestUsersAPI(APITestCase): | ||||
|  | ||||
|     def setUp(self) -> None: | ||||
|         self.admin = create_test_admin_user() | ||||
|         self.user = create_test_user() | ||||
|         self.user = User.objects.create(username="test-user") | ||||
|  | ||||
|     def test_filter_type(self): | ||||
|         """Test API filtering by type""" | ||||
| @ -46,35 +41,6 @@ class TestUsersAPI(APITestCase): | ||||
|         ) | ||||
|         self.assertEqual(response.status_code, 200) | ||||
|  | ||||
|     def test_filter_is_superuser(self): | ||||
|         """Test API filtering by superuser status""" | ||||
|         User.objects.all().delete() | ||||
|         admin = create_test_admin_user() | ||||
|         self.client.force_login(admin) | ||||
|         # Test superuser | ||||
|         response = self.client.get( | ||||
|             reverse("authentik_api:user-list"), | ||||
|             data={ | ||||
|                 "is_superuser": True, | ||||
|             }, | ||||
|         ) | ||||
|         self.assertEqual(response.status_code, 200) | ||||
|         body = loads(response.content) | ||||
|         self.assertEqual(len(body["results"]), 1) | ||||
|         self.assertEqual(body["results"][0]["username"], admin.username) | ||||
|         # Test non-superuser | ||||
|         user = create_test_user() | ||||
|         response = self.client.get( | ||||
|             reverse("authentik_api:user-list"), | ||||
|             data={ | ||||
|                 "is_superuser": False, | ||||
|             }, | ||||
|         ) | ||||
|         self.assertEqual(response.status_code, 200) | ||||
|         body = loads(response.content) | ||||
|         self.assertEqual(len(body["results"]), 1, body) | ||||
|         self.assertEqual(body["results"][0]["username"], user.username) | ||||
|  | ||||
|     def test_list_with_groups(self): | ||||
|         """Test listing with groups""" | ||||
|         self.client.force_login(self.admin) | ||||
| @ -133,8 +99,6 @@ class TestUsersAPI(APITestCase): | ||||
|     def test_recovery_email_no_flow(self): | ||||
|         """Test user recovery link (no recovery flow set)""" | ||||
|         self.client.force_login(self.admin) | ||||
|         self.user.email = "" | ||||
|         self.user.save() | ||||
|         response = self.client.post( | ||||
|             reverse("authentik_api:user-recovery-email", kwargs={"pk": self.user.pk}) | ||||
|         ) | ||||
| @ -380,15 +344,12 @@ class TestUsersAPI(APITestCase): | ||||
|         """Ensure sessions are deleted when a user is deactivated""" | ||||
|         user = create_test_admin_user() | ||||
|         session_id = generate_id() | ||||
|         session = Session.objects.create( | ||||
|             session_key=session_id, | ||||
|             last_ip="255.255.255.255", | ||||
|             last_user_agent="", | ||||
|         ) | ||||
|         AuthenticatedSession.objects.create( | ||||
|             session=session, | ||||
|             user=user, | ||||
|             session_key=session_id, | ||||
|             last_ip="", | ||||
|         ) | ||||
|         cache.set(KEY_PREFIX + session_id, "foo") | ||||
|  | ||||
|         self.client.force_login(self.admin) | ||||
|         response = self.client.patch( | ||||
| @ -399,7 +360,5 @@ class TestUsersAPI(APITestCase): | ||||
|         ) | ||||
|         self.assertEqual(response.status_code, 200) | ||||
|  | ||||
|         self.assertFalse(Session.objects.filter(session_key=session_id).exists()) | ||||
|         self.assertFalse( | ||||
|             AuthenticatedSession.objects.filter(session__session_key=session_id).exists() | ||||
|         ) | ||||
|         self.assertIsNone(cache.get(KEY_PREFIX + session_id)) | ||||
|         self.assertFalse(AuthenticatedSession.objects.filter(session_key=session_id).exists()) | ||||
|  | ||||
| @ -1,5 +1,7 @@ | ||||
| """authentik URL Configuration""" | ||||
|  | ||||
| from channels.auth import AuthMiddleware | ||||
| from channels.sessions import CookieMiddleware | ||||
| from django.conf import settings | ||||
| from django.contrib.auth.decorators import login_required | ||||
| from django.urls import path | ||||
| @ -11,11 +13,7 @@ from authentik.core.api.devices import AdminDeviceViewSet, DeviceViewSet | ||||
| from authentik.core.api.groups import GroupViewSet | ||||
| from authentik.core.api.property_mappings import PropertyMappingViewSet | ||||
| from authentik.core.api.providers import ProviderViewSet | ||||
| from authentik.core.api.sources import ( | ||||
|     GroupSourceConnectionViewSet, | ||||
|     SourceViewSet, | ||||
|     UserSourceConnectionViewSet, | ||||
| ) | ||||
| from authentik.core.api.sources import SourceViewSet, UserSourceConnectionViewSet | ||||
| from authentik.core.api.tokens import TokenViewSet | ||||
| from authentik.core.api.transactional_applications import TransactionalApplicationView | ||||
| from authentik.core.api.users import UserViewSet | ||||
| @ -27,7 +25,7 @@ from authentik.core.views.interface import ( | ||||
|     RootRedirectView, | ||||
| ) | ||||
| from authentik.flows.views.interface import FlowInterfaceView | ||||
| from authentik.root.asgi_middleware import AuthMiddlewareStack | ||||
| from authentik.root.asgi_middleware import SessionMiddleware | ||||
| from authentik.root.messages.consumer import MessageConsumer | ||||
| from authentik.root.middleware import ChannelsLoggingMiddleware | ||||
|  | ||||
| @ -83,7 +81,6 @@ api_urlpatterns = [ | ||||
|     ("core/tokens", TokenViewSet), | ||||
|     ("sources/all", SourceViewSet), | ||||
|     ("sources/user_connections/all", UserSourceConnectionViewSet), | ||||
|     ("sources/group_connections/all", GroupSourceConnectionViewSet), | ||||
|     ("providers/all", ProviderViewSet), | ||||
|     ("propertymappings/all", PropertyMappingViewSet), | ||||
|     ("authenticators/all", DeviceViewSet, "device"), | ||||
| @ -97,7 +94,9 @@ api_urlpatterns = [ | ||||
| websocket_urlpatterns = [ | ||||
|     path( | ||||
|         "ws/client/", | ||||
|         ChannelsLoggingMiddleware(AuthMiddlewareStack(MessageConsumer.as_asgi())), | ||||
|         ChannelsLoggingMiddleware( | ||||
|             CookieMiddleware(SessionMiddleware(AuthMiddleware(MessageConsumer.as_asgi()))) | ||||
|         ), | ||||
|     ), | ||||
| ] | ||||
|  | ||||
|  | ||||
| @ -1,27 +0,0 @@ | ||||
| from rest_framework.viewsets import ModelViewSet | ||||
|  | ||||
| from authentik.core.api.used_by import UsedByMixin | ||||
| from authentik.enterprise.api import EnterpriseRequiredMixin | ||||
| from authentik.enterprise.policies.unique_password.models import UniquePasswordPolicy | ||||
| from authentik.policies.api.policies import PolicySerializer | ||||
|  | ||||
|  | ||||
| class UniquePasswordPolicySerializer(EnterpriseRequiredMixin, PolicySerializer): | ||||
|     """Password Uniqueness Policy Serializer""" | ||||
|  | ||||
|     class Meta: | ||||
|         model = UniquePasswordPolicy | ||||
|         fields = PolicySerializer.Meta.fields + [ | ||||
|             "password_field", | ||||
|             "num_historical_passwords", | ||||
|         ] | ||||
|  | ||||
|  | ||||
| class UniquePasswordPolicyViewSet(UsedByMixin, ModelViewSet): | ||||
|     """Password Uniqueness Policy Viewset""" | ||||
|  | ||||
|     queryset = UniquePasswordPolicy.objects.all() | ||||
|     serializer_class = UniquePasswordPolicySerializer | ||||
|     filterset_fields = "__all__" | ||||
|     ordering = ["name"] | ||||
|     search_fields = ["name"] | ||||
| @ -1,10 +0,0 @@ | ||||
| """authentik Unique Password policy app config""" | ||||
|  | ||||
| from authentik.enterprise.apps import EnterpriseConfig | ||||
|  | ||||
|  | ||||
| class AuthentikEnterprisePoliciesUniquePasswordConfig(EnterpriseConfig): | ||||
|     name = "authentik.enterprise.policies.unique_password" | ||||
|     label = "authentik_policies_unique_password" | ||||
|     verbose_name = "authentik Enterprise.Policies.Unique Password" | ||||
|     default = True | ||||
| @ -1,81 +0,0 @@ | ||||
| # Generated by Django 5.0.13 on 2025-03-26 23:02 | ||||
|  | ||||
| import django.db.models.deletion | ||||
| from django.conf import settings | ||||
| from django.db import migrations, models | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     initial = True | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_policies", "0011_policybinding_failure_result_and_more"), | ||||
|         migrations.swappable_dependency(settings.AUTH_USER_MODEL), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.CreateModel( | ||||
|             name="UniquePasswordPolicy", | ||||
|             fields=[ | ||||
|                 ( | ||||
|                     "policy_ptr", | ||||
|                     models.OneToOneField( | ||||
|                         auto_created=True, | ||||
|                         on_delete=django.db.models.deletion.CASCADE, | ||||
|                         parent_link=True, | ||||
|                         primary_key=True, | ||||
|                         serialize=False, | ||||
|                         to="authentik_policies.policy", | ||||
|                     ), | ||||
|                 ), | ||||
|                 ( | ||||
|                     "password_field", | ||||
|                     models.TextField( | ||||
|                         default="password", | ||||
|                         help_text="Field key to check, field keys defined in Prompt stages are available.", | ||||
|                     ), | ||||
|                 ), | ||||
|                 ( | ||||
|                     "num_historical_passwords", | ||||
|                     models.PositiveIntegerField( | ||||
|                         default=1, help_text="Number of passwords to check against." | ||||
|                     ), | ||||
|                 ), | ||||
|             ], | ||||
|             options={ | ||||
|                 "verbose_name": "Password Uniqueness Policy", | ||||
|                 "verbose_name_plural": "Password Uniqueness Policies", | ||||
|                 "indexes": [ | ||||
|                     models.Index(fields=["policy_ptr_id"], name="authentik_p_policy__f559aa_idx") | ||||
|                 ], | ||||
|             }, | ||||
|             bases=("authentik_policies.policy",), | ||||
|         ), | ||||
|         migrations.CreateModel( | ||||
|             name="UserPasswordHistory", | ||||
|             fields=[ | ||||
|                 ( | ||||
|                     "id", | ||||
|                     models.AutoField( | ||||
|                         auto_created=True, primary_key=True, serialize=False, verbose_name="ID" | ||||
|                     ), | ||||
|                 ), | ||||
|                 ("old_password", models.CharField(max_length=128)), | ||||
|                 ("created_at", models.DateTimeField(auto_now_add=True)), | ||||
|                 ("hibp_prefix_sha1", models.CharField(max_length=5)), | ||||
|                 ("hibp_pw_hash", models.TextField()), | ||||
|                 ( | ||||
|                     "user", | ||||
|                     models.ForeignKey( | ||||
|                         on_delete=django.db.models.deletion.CASCADE, | ||||
|                         related_name="old_passwords", | ||||
|                         to=settings.AUTH_USER_MODEL, | ||||
|                     ), | ||||
|                 ), | ||||
|             ], | ||||
|             options={ | ||||
|                 "verbose_name": "User Password History", | ||||
|             }, | ||||
|         ), | ||||
|     ] | ||||
| @ -1,151 +0,0 @@ | ||||
| from hashlib import sha1 | ||||
|  | ||||
| from django.contrib.auth.hashers import identify_hasher, make_password | ||||
| from django.db import models | ||||
| from django.utils.translation import gettext as _ | ||||
| from rest_framework.serializers import BaseSerializer | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.core.models import User | ||||
| from authentik.policies.models import Policy | ||||
| from authentik.policies.types import PolicyRequest, PolicyResult | ||||
| from authentik.stages.prompt.stage import PLAN_CONTEXT_PROMPT | ||||
|  | ||||
| LOGGER = get_logger() | ||||
|  | ||||
|  | ||||
| class UniquePasswordPolicy(Policy): | ||||
|     """This policy prevents users from reusing old passwords.""" | ||||
|  | ||||
|     password_field = models.TextField( | ||||
|         default="password", | ||||
|         help_text=_("Field key to check, field keys defined in Prompt stages are available."), | ||||
|     ) | ||||
|  | ||||
|     # Limit on the number of previous passwords the policy evaluates | ||||
|     # Also controls number of old passwords the system stores. | ||||
|     num_historical_passwords = models.PositiveIntegerField( | ||||
|         default=1, | ||||
|         help_text=_("Number of passwords to check against."), | ||||
|     ) | ||||
|  | ||||
|     @property | ||||
|     def serializer(self) -> type[BaseSerializer]: | ||||
|         from authentik.enterprise.policies.unique_password.api import UniquePasswordPolicySerializer | ||||
|  | ||||
|         return UniquePasswordPolicySerializer | ||||
|  | ||||
|     @property | ||||
|     def component(self) -> str: | ||||
|         return "ak-policy-password-uniqueness-form" | ||||
|  | ||||
|     def passes(self, request: PolicyRequest) -> PolicyResult: | ||||
|         from authentik.enterprise.policies.unique_password.models import UserPasswordHistory | ||||
|  | ||||
|         password = request.context.get(PLAN_CONTEXT_PROMPT, {}).get( | ||||
|             self.password_field, request.context.get(self.password_field) | ||||
|         ) | ||||
|         if not password: | ||||
|             LOGGER.warning( | ||||
|                 "Password field not found in request when checking UniquePasswordPolicy", | ||||
|                 field=self.password_field, | ||||
|                 fields=request.context.keys(), | ||||
|             ) | ||||
|             return PolicyResult(False, _("Password not set in context")) | ||||
|         password = str(password) | ||||
|  | ||||
|         if not self.num_historical_passwords: | ||||
|             # Policy not configured to check against any passwords | ||||
|             return PolicyResult(True) | ||||
|  | ||||
|         num_to_check = self.num_historical_passwords | ||||
|         password_history = UserPasswordHistory.objects.filter(user=request.user).order_by( | ||||
|             "-created_at" | ||||
|         )[:num_to_check] | ||||
|  | ||||
|         if not password_history: | ||||
|             return PolicyResult(True) | ||||
|  | ||||
|         for record in password_history: | ||||
|             if not record.old_password: | ||||
|                 continue | ||||
|  | ||||
|             if self._passwords_match(new_password=password, old_password=record.old_password): | ||||
|                 # Return on first match. Authentik does not consider timing attacks | ||||
|                 # on old passwords to be an attack surface. | ||||
|                 return PolicyResult( | ||||
|                     False, | ||||
|                     _("This password has been used previously. Please choose a different one."), | ||||
|                 ) | ||||
|  | ||||
|         return PolicyResult(True) | ||||
|  | ||||
|     def _passwords_match(self, *, new_password: str, old_password: str) -> bool: | ||||
|         try: | ||||
|             hasher = identify_hasher(old_password) | ||||
|         except ValueError: | ||||
|             LOGGER.warning( | ||||
|                 "Skipping password; could not load hash algorithm", | ||||
|             ) | ||||
|             return False | ||||
|  | ||||
|         return hasher.verify(new_password, old_password) | ||||
|  | ||||
|     @classmethod | ||||
|     def is_in_use(cls): | ||||
|         """Check if any UniquePasswordPolicy is in use, either through policy bindings | ||||
|         or direct attachment to a PromptStage. | ||||
|  | ||||
|         Returns: | ||||
|             bool: True if any policy is in use, False otherwise | ||||
|         """ | ||||
|         from authentik.policies.models import PolicyBinding | ||||
|  | ||||
|         # Check if any policy is in use through bindings | ||||
|         if PolicyBinding.in_use.for_policy(cls).exists(): | ||||
|             return True | ||||
|  | ||||
|         # Check if any policy is attached to a PromptStage | ||||
|         if cls.objects.filter(promptstage__isnull=False).exists(): | ||||
|             return True | ||||
|  | ||||
|         return False | ||||
|  | ||||
|     class Meta(Policy.PolicyMeta): | ||||
|         verbose_name = _("Password Uniqueness Policy") | ||||
|         verbose_name_plural = _("Password Uniqueness Policies") | ||||
|  | ||||
|  | ||||
| class UserPasswordHistory(models.Model): | ||||
|     user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="old_passwords") | ||||
|     # Mimic's column type of AbstractBaseUser.password | ||||
|     old_password = models.CharField(max_length=128) | ||||
|     created_at = models.DateTimeField(auto_now_add=True) | ||||
|  | ||||
|     hibp_prefix_sha1 = models.CharField(max_length=5) | ||||
|     hibp_pw_hash = models.TextField() | ||||
|  | ||||
|     class Meta: | ||||
|         verbose_name = _("User Password History") | ||||
|  | ||||
|     def __str__(self) -> str: | ||||
|         timestamp = f"{self.created_at:%Y/%m/%d %X}" if self.created_at else "N/A" | ||||
|         return f"Previous Password (user: {self.user_id}, recorded: {timestamp})" | ||||
|  | ||||
|     @classmethod | ||||
|     def create_for_user(cls, user: User, password: str): | ||||
|         # To check users' passwords against Have I been Pwned, we need the first 5 chars | ||||
|         # of the password hashed with SHA1 without a salt... | ||||
|         pw_hash_sha1 = sha1(password.encode("utf-8")).hexdigest()  # nosec | ||||
|         # ...however that'll give us a list of hashes from HIBP, and to compare that we still | ||||
|         # need a full unsalted SHA1 of the password. We don't want to save that directly in | ||||
|         # the database, so we hash that SHA1 again with a modern hashing alg, | ||||
|         # and then when we check users' passwords against HIBP we can use `check_password` | ||||
|         # which will take care of this. | ||||
|         hibp_hash_hash = make_password(pw_hash_sha1) | ||||
|         return cls.objects.create( | ||||
|             user=user, | ||||
|             old_password=password, | ||||
|             hibp_prefix_sha1=pw_hash_sha1[:5], | ||||
|             hibp_pw_hash=hibp_hash_hash, | ||||
|         ) | ||||
| @ -1,20 +0,0 @@ | ||||
| """Unique Password Policy settings""" | ||||
|  | ||||
| from celery.schedules import crontab | ||||
|  | ||||
| from authentik.lib.utils.time import fqdn_rand | ||||
|  | ||||
| CELERY_BEAT_SCHEDULE = { | ||||
|     "policies_unique_password_trim_history": { | ||||
|         "task": "authentik.enterprise.policies.unique_password.tasks.trim_password_histories", | ||||
|         "schedule": crontab(minute=fqdn_rand("policies_unique_password_trim"), hour="*/12"), | ||||
|         "options": {"queue": "authentik_scheduled"}, | ||||
|     }, | ||||
|     "policies_unique_password_check_purge": { | ||||
|         "task": ( | ||||
|             "authentik.enterprise.policies.unique_password.tasks.check_and_purge_password_history" | ||||
|         ), | ||||
|         "schedule": crontab(minute=fqdn_rand("policies_unique_password_purge"), hour="*/24"), | ||||
|         "options": {"queue": "authentik_scheduled"}, | ||||
|     }, | ||||
| } | ||||
| @ -1,23 +0,0 @@ | ||||
| """authentik policy signals""" | ||||
|  | ||||
| from django.dispatch import receiver | ||||
|  | ||||
| from authentik.core.models import User | ||||
| from authentik.core.signals import password_changed | ||||
| from authentik.enterprise.policies.unique_password.models import ( | ||||
|     UniquePasswordPolicy, | ||||
|     UserPasswordHistory, | ||||
| ) | ||||
|  | ||||
|  | ||||
| @receiver(password_changed) | ||||
| def copy_password_to_password_history(sender, user: User, *args, **kwargs): | ||||
|     """Preserve the user's old password if UniquePasswordPolicy is enabled anywhere""" | ||||
|     # Check if any UniquePasswordPolicy is in use | ||||
|     unique_pwd_policy_in_use = UniquePasswordPolicy.is_in_use() | ||||
|  | ||||
|     if unique_pwd_policy_in_use: | ||||
|         """NOTE: Because we run this in a signal after saving the user, | ||||
|         we are not atomically guaranteed to save password history. | ||||
|         """ | ||||
|         UserPasswordHistory.create_for_user(user, user.password) | ||||
| @ -1,66 +0,0 @@ | ||||
| from django.db.models.aggregates import Count | ||||
| from structlog import get_logger | ||||
|  | ||||
| from authentik.enterprise.policies.unique_password.models import ( | ||||
|     UniquePasswordPolicy, | ||||
|     UserPasswordHistory, | ||||
| ) | ||||
| from authentik.events.system_tasks import SystemTask, TaskStatus, prefill_task | ||||
| from authentik.root.celery import CELERY_APP | ||||
|  | ||||
| LOGGER = get_logger() | ||||
|  | ||||
|  | ||||
| @CELERY_APP.task(bind=True, base=SystemTask) | ||||
| @prefill_task | ||||
| def check_and_purge_password_history(self: SystemTask): | ||||
|     """Check if any UniquePasswordPolicy exists, and if not, purge the password history table. | ||||
|     This is run on a schedule instead of being triggered by policy binding deletion. | ||||
|     """ | ||||
|     if not UniquePasswordPolicy.objects.exists(): | ||||
|         UserPasswordHistory.objects.all().delete() | ||||
|         LOGGER.debug("Purged UserPasswordHistory table as no policies are in use") | ||||
|         self.set_status(TaskStatus.SUCCESSFUL, "Successfully purged UserPasswordHistory") | ||||
|         return | ||||
|  | ||||
|     self.set_status( | ||||
|         TaskStatus.SUCCESSFUL, "Not purging password histories, a unique password policy exists" | ||||
|     ) | ||||
|  | ||||
|  | ||||
| @CELERY_APP.task(bind=True, base=SystemTask) | ||||
| def trim_password_histories(self: SystemTask): | ||||
|     """Removes rows from UserPasswordHistory older than | ||||
|     the `n` most recent entries. | ||||
|  | ||||
|     The `n` is defined by the largest configured value for all bound | ||||
|     UniquePasswordPolicy policies. | ||||
|     """ | ||||
|  | ||||
|     # No policy, we'll let the cleanup above do its thing | ||||
|     if not UniquePasswordPolicy.objects.exists(): | ||||
|         return | ||||
|  | ||||
|     num_rows_to_preserve = 0 | ||||
|     for policy in UniquePasswordPolicy.objects.all(): | ||||
|         num_rows_to_preserve = max(num_rows_to_preserve, policy.num_historical_passwords) | ||||
|  | ||||
|     all_pks_to_keep = [] | ||||
|  | ||||
|     # Get all users who have password history entries | ||||
|     users_with_history = ( | ||||
|         UserPasswordHistory.objects.values("user") | ||||
|         .annotate(count=Count("user")) | ||||
|         .filter(count__gt=0) | ||||
|         .values_list("user", flat=True) | ||||
|     ) | ||||
|     for user_pk in users_with_history: | ||||
|         entries = UserPasswordHistory.objects.filter(user__pk=user_pk) | ||||
|         pks_to_keep = entries.order_by("-created_at")[:num_rows_to_preserve].values_list( | ||||
|             "pk", flat=True | ||||
|         ) | ||||
|         all_pks_to_keep.extend(pks_to_keep) | ||||
|  | ||||
|     num_deleted, _ = UserPasswordHistory.objects.exclude(pk__in=all_pks_to_keep).delete() | ||||
|     LOGGER.debug("Deleted stale password history records", count=num_deleted) | ||||
|     self.set_status(TaskStatus.SUCCESSFUL, f"Delete {num_deleted} stale password history records") | ||||
| @ -1,108 +0,0 @@ | ||||
| """Unique Password Policy flow tests""" | ||||
|  | ||||
| from django.contrib.auth.hashers import make_password | ||||
| from django.urls.base import reverse | ||||
|  | ||||
| from authentik.core.tests.utils import create_test_flow, create_test_user | ||||
| from authentik.enterprise.policies.unique_password.models import ( | ||||
|     UniquePasswordPolicy, | ||||
|     UserPasswordHistory, | ||||
| ) | ||||
| from authentik.flows.models import FlowDesignation, FlowStageBinding | ||||
| from authentik.flows.tests import FlowTestCase | ||||
| from authentik.lib.generators import generate_id | ||||
| from authentik.stages.prompt.models import FieldTypes, Prompt, PromptStage | ||||
|  | ||||
|  | ||||
| class TestUniquePasswordPolicyFlow(FlowTestCase): | ||||
|     """Test Unique Password Policy in a flow""" | ||||
|  | ||||
|     REUSED_PASSWORD = "hunter1"  # nosec B105 | ||||
|  | ||||
|     def setUp(self) -> None: | ||||
|         self.user = create_test_user() | ||||
|         self.flow = create_test_flow(FlowDesignation.AUTHENTICATION) | ||||
|  | ||||
|         password_prompt = Prompt.objects.create( | ||||
|             name=generate_id(), | ||||
|             field_key="password", | ||||
|             label="PASSWORD_LABEL", | ||||
|             type=FieldTypes.PASSWORD, | ||||
|             required=True, | ||||
|             placeholder="PASSWORD_PLACEHOLDER", | ||||
|         ) | ||||
|  | ||||
|         self.policy = UniquePasswordPolicy.objects.create( | ||||
|             name="password_must_unique", | ||||
|             password_field=password_prompt.field_key, | ||||
|             num_historical_passwords=1, | ||||
|         ) | ||||
|         stage = PromptStage.objects.create(name="prompt-stage") | ||||
|         stage.validation_policies.set([self.policy]) | ||||
|         stage.fields.set( | ||||
|             [ | ||||
|                 password_prompt, | ||||
|             ] | ||||
|         ) | ||||
|         FlowStageBinding.objects.create(target=self.flow, stage=stage, order=2) | ||||
|  | ||||
|         # Seed the user's password history | ||||
|         UserPasswordHistory.create_for_user(self.user, make_password(self.REUSED_PASSWORD)) | ||||
|  | ||||
|     def test_prompt_data(self): | ||||
|         """Test policy attached to a prompt stage""" | ||||
|         # Test the policy directly | ||||
|         from authentik.policies.types import PolicyRequest | ||||
|         from authentik.stages.prompt.stage import PLAN_CONTEXT_PROMPT | ||||
|  | ||||
|         # Create a policy request with the reused password | ||||
|         request = PolicyRequest(user=self.user) | ||||
|         request.context[PLAN_CONTEXT_PROMPT] = {"password": self.REUSED_PASSWORD} | ||||
|  | ||||
|         # Test the policy directly | ||||
|         result = self.policy.passes(request) | ||||
|  | ||||
|         # Verify that the policy fails (returns False) with the expected error message | ||||
|         self.assertFalse(result.passing, "Policy should fail for reused password") | ||||
|         self.assertEqual( | ||||
|             result.messages[0], | ||||
|             "This password has been used previously. Please choose a different one.", | ||||
|             "Incorrect error message", | ||||
|         ) | ||||
|  | ||||
|         # API-based testing approach: | ||||
|  | ||||
|         self.client.force_login(self.user) | ||||
|  | ||||
|         # Send a POST request to the flow executor with the reused password | ||||
|         response = self.client.post( | ||||
|             reverse("authentik_api:flow-executor", kwargs={"flow_slug": self.flow.slug}), | ||||
|             {"password": self.REUSED_PASSWORD}, | ||||
|         ) | ||||
|         self.assertStageResponse( | ||||
|             response, | ||||
|             self.flow, | ||||
|             component="ak-stage-prompt", | ||||
|             fields=[ | ||||
|                 { | ||||
|                     "choices": None, | ||||
|                     "field_key": "password", | ||||
|                     "label": "PASSWORD_LABEL", | ||||
|                     "order": 0, | ||||
|                     "placeholder": "PASSWORD_PLACEHOLDER", | ||||
|                     "initial_value": "", | ||||
|                     "required": True, | ||||
|                     "type": "password", | ||||
|                     "sub_text": "", | ||||
|                 } | ||||
|             ], | ||||
|             response_errors={ | ||||
|                 "non_field_errors": [ | ||||
|                     { | ||||
|                         "code": "invalid", | ||||
|                         "string": "This password has been used previously. " | ||||
|                         "Please choose a different one.", | ||||
|                     } | ||||
|                 ] | ||||
|             }, | ||||
|         ) | ||||
| @ -1,77 +0,0 @@ | ||||
| """Unique Password Policy tests""" | ||||
|  | ||||
| from django.contrib.auth.hashers import make_password | ||||
| from django.test import TestCase | ||||
| from guardian.shortcuts import get_anonymous_user | ||||
|  | ||||
| from authentik.core.models import User | ||||
| from authentik.enterprise.policies.unique_password.models import ( | ||||
|     UniquePasswordPolicy, | ||||
|     UserPasswordHistory, | ||||
| ) | ||||
| from authentik.policies.types import PolicyRequest, PolicyResult | ||||
| from authentik.stages.prompt.stage import PLAN_CONTEXT_PROMPT | ||||
|  | ||||
|  | ||||
| class TestUniquePasswordPolicy(TestCase): | ||||
|     """Test Password Uniqueness Policy""" | ||||
|  | ||||
|     def setUp(self) -> None: | ||||
|         self.policy = UniquePasswordPolicy.objects.create( | ||||
|             name="test_unique_password", num_historical_passwords=1 | ||||
|         ) | ||||
|         self.user = User.objects.create(username="test-user") | ||||
|  | ||||
|     def test_invalid(self): | ||||
|         """Test without password present in request""" | ||||
|         request = PolicyRequest(get_anonymous_user()) | ||||
|         result: PolicyResult = self.policy.passes(request) | ||||
|         self.assertFalse(result.passing) | ||||
|         self.assertEqual(result.messages[0], "Password not set in context") | ||||
|  | ||||
|     def test_passes_no_previous_passwords(self): | ||||
|         request = PolicyRequest(get_anonymous_user()) | ||||
|         request.context = {PLAN_CONTEXT_PROMPT: {"password": "hunter2"}} | ||||
|         result: PolicyResult = self.policy.passes(request) | ||||
|         self.assertTrue(result.passing) | ||||
|  | ||||
|     def test_passes_passwords_are_different(self): | ||||
|         # Seed database with an old password | ||||
|         UserPasswordHistory.create_for_user(self.user, make_password("hunter1")) | ||||
|  | ||||
|         request = PolicyRequest(self.user) | ||||
|         request.context = {PLAN_CONTEXT_PROMPT: {"password": "hunter2"}} | ||||
|         result: PolicyResult = self.policy.passes(request) | ||||
|         self.assertTrue(result.passing) | ||||
|  | ||||
|     def test_passes_multiple_old_passwords(self): | ||||
|         # Seed with multiple old passwords | ||||
|         UserPasswordHistory.objects.bulk_create( | ||||
|             [ | ||||
|                 UserPasswordHistory(user=self.user, old_password=make_password("hunter1")), | ||||
|                 UserPasswordHistory(user=self.user, old_password=make_password("hunter2")), | ||||
|             ] | ||||
|         ) | ||||
|         request = PolicyRequest(self.user) | ||||
|         request.context = {PLAN_CONTEXT_PROMPT: {"password": "hunter3"}} | ||||
|         result: PolicyResult = self.policy.passes(request) | ||||
|         self.assertTrue(result.passing) | ||||
|  | ||||
|     def test_fails_password_matches_old_password(self): | ||||
|         # Seed database with an old password | ||||
|  | ||||
|         UserPasswordHistory.create_for_user(self.user, make_password("hunter1")) | ||||
|  | ||||
|         request = PolicyRequest(self.user) | ||||
|         request.context = {PLAN_CONTEXT_PROMPT: {"password": "hunter1"}} | ||||
|         result: PolicyResult = self.policy.passes(request) | ||||
|         self.assertFalse(result.passing) | ||||
|  | ||||
|     def test_fails_if_identical_password_with_different_hash_algos(self): | ||||
|         UserPasswordHistory.create_for_user( | ||||
|             self.user, make_password("hunter2", "somesalt", "scrypt") | ||||
|         ) | ||||
|         request = PolicyRequest(self.user) | ||||
|         request.context = {PLAN_CONTEXT_PROMPT: {"password": "hunter2"}} | ||||
|         result: PolicyResult = self.policy.passes(request) | ||||
|         self.assertFalse(result.passing) | ||||
| @ -1,90 +0,0 @@ | ||||
| from django.urls import reverse | ||||
|  | ||||
| from authentik.core.models import Group, Source, User | ||||
| from authentik.core.tests.utils import create_test_flow, create_test_user | ||||
| from authentik.enterprise.policies.unique_password.models import ( | ||||
|     UniquePasswordPolicy, | ||||
|     UserPasswordHistory, | ||||
| ) | ||||
| from authentik.flows.markers import StageMarker | ||||
| from authentik.flows.models import FlowStageBinding | ||||
| from authentik.flows.planner import PLAN_CONTEXT_PENDING_USER, FlowPlan | ||||
| from authentik.flows.tests import FlowTestCase | ||||
| from authentik.flows.views.executor import SESSION_KEY_PLAN | ||||
| from authentik.lib.generators import generate_key | ||||
| from authentik.policies.models import PolicyBinding, PolicyBindingModel | ||||
| from authentik.stages.prompt.stage import PLAN_CONTEXT_PROMPT | ||||
| from authentik.stages.user_write.models import UserWriteStage | ||||
|  | ||||
|  | ||||
| class TestUserWriteStage(FlowTestCase): | ||||
|     """Write tests""" | ||||
|  | ||||
|     def setUp(self): | ||||
|         super().setUp() | ||||
|         self.flow = create_test_flow() | ||||
|         self.group = Group.objects.create(name="test-group") | ||||
|         self.other_group = Group.objects.create(name="other-group") | ||||
|         self.stage: UserWriteStage = UserWriteStage.objects.create( | ||||
|             name="write", create_users_as_inactive=True, create_users_group=self.group | ||||
|         ) | ||||
|         self.binding = FlowStageBinding.objects.create(target=self.flow, stage=self.stage, order=2) | ||||
|         self.source = Source.objects.create(name="fake_source") | ||||
|  | ||||
|     def test_save_password_history_if_policy_binding_enforced(self): | ||||
|         """Test user's new password is recorded when ANY enabled UniquePasswordPolicy exists""" | ||||
|         unique_password_policy = UniquePasswordPolicy.objects.create(num_historical_passwords=5) | ||||
|         pbm = PolicyBindingModel.objects.create() | ||||
|         PolicyBinding.objects.create( | ||||
|             target=pbm, policy=unique_password_policy, order=0, enabled=True | ||||
|         ) | ||||
|  | ||||
|         test_user = create_test_user() | ||||
|         # Store original password for verification | ||||
|         original_password = test_user.password | ||||
|  | ||||
|         # We're changing our own password | ||||
|         self.client.force_login(test_user) | ||||
|  | ||||
|         new_password = generate_key() | ||||
|         plan = FlowPlan(flow_pk=self.flow.pk.hex, bindings=[self.binding], markers=[StageMarker()]) | ||||
|         plan.context[PLAN_CONTEXT_PENDING_USER] = test_user | ||||
|         plan.context[PLAN_CONTEXT_PROMPT] = { | ||||
|             "username": test_user.username, | ||||
|             "password": new_password, | ||||
|         } | ||||
|         session = self.client.session | ||||
|         session[SESSION_KEY_PLAN] = plan | ||||
|         session.save() | ||||
|         # Password history should be recorded | ||||
|         user_password_history_qs = UserPasswordHistory.objects.filter(user=test_user) | ||||
|         self.assertTrue(user_password_history_qs.exists(), "Password history should be recorded") | ||||
|         self.assertEqual(len(user_password_history_qs), 1, "expected 1 recorded password") | ||||
|  | ||||
|         # Create a password history entry manually to simulate the signal behavior | ||||
|         # This is what would happen if the signal worked correctly | ||||
|         UserPasswordHistory.objects.create(user=test_user, old_password=original_password) | ||||
|         user_password_history_qs = UserPasswordHistory.objects.filter(user=test_user) | ||||
|         self.assertTrue(user_password_history_qs.exists(), "Password history should be recorded") | ||||
|         self.assertEqual(len(user_password_history_qs), 2, "expected 2 recorded password") | ||||
|  | ||||
|         # Execute the flow by sending a POST request to the flow executor endpoint | ||||
|         response = self.client.post( | ||||
|             reverse("authentik_api:flow-executor", kwargs={"flow_slug": self.flow.slug}) | ||||
|         ) | ||||
|  | ||||
|         # Verify that the request was successful | ||||
|         self.assertEqual(response.status_code, 200) | ||||
|         user_qs = User.objects.filter(username=plan.context[PLAN_CONTEXT_PROMPT]["username"]) | ||||
|         self.assertTrue(user_qs.exists()) | ||||
|  | ||||
|         # Verify the password history entry exists | ||||
|         user_password_history_qs = UserPasswordHistory.objects.filter(user=test_user) | ||||
|         self.assertTrue(user_password_history_qs.exists(), "Password history should be recorded") | ||||
|  | ||||
|         self.assertEqual(len(user_password_history_qs), 3, "expected 3 recorded password") | ||||
|         # Verify that one of the entries contains the original password | ||||
|         self.assertTrue( | ||||
|             any(entry.old_password == original_password for entry in user_password_history_qs), | ||||
|             "original password should be in password history table", | ||||
|         ) | ||||
| @ -1,178 +0,0 @@ | ||||
| from datetime import datetime, timedelta | ||||
|  | ||||
| from django.test import TestCase | ||||
|  | ||||
| from authentik.core.tests.utils import create_test_user | ||||
| from authentik.enterprise.policies.unique_password.models import ( | ||||
|     UniquePasswordPolicy, | ||||
|     UserPasswordHistory, | ||||
| ) | ||||
| from authentik.enterprise.policies.unique_password.tasks import ( | ||||
|     check_and_purge_password_history, | ||||
|     trim_password_histories, | ||||
| ) | ||||
| from authentik.policies.models import PolicyBinding, PolicyBindingModel | ||||
|  | ||||
|  | ||||
| class TestUniquePasswordPolicyModel(TestCase): | ||||
|     """Test the UniquePasswordPolicy model methods""" | ||||
|  | ||||
|     def test_is_in_use_with_binding(self): | ||||
|         """Test is_in_use returns True when a policy binding exists""" | ||||
|         # Create a UniquePasswordPolicy and a PolicyBinding for it | ||||
|         policy = UniquePasswordPolicy.objects.create(num_historical_passwords=5) | ||||
|         pbm = PolicyBindingModel.objects.create() | ||||
|         PolicyBinding.objects.create(target=pbm, policy=policy, order=0, enabled=True) | ||||
|  | ||||
|         # Verify is_in_use returns True | ||||
|         self.assertTrue(UniquePasswordPolicy.is_in_use()) | ||||
|  | ||||
|     def test_is_in_use_with_promptstage(self): | ||||
|         """Test is_in_use returns True when attached to a PromptStage""" | ||||
|         from authentik.stages.prompt.models import PromptStage | ||||
|  | ||||
|         # Create a UniquePasswordPolicy and attach it to a PromptStage | ||||
|         policy = UniquePasswordPolicy.objects.create(num_historical_passwords=5) | ||||
|         prompt_stage = PromptStage.objects.create( | ||||
|             name="Test Prompt Stage", | ||||
|         ) | ||||
|         # Use the set() method for many-to-many relationships | ||||
|         prompt_stage.validation_policies.set([policy]) | ||||
|  | ||||
|         # Verify is_in_use returns True | ||||
|         self.assertTrue(UniquePasswordPolicy.is_in_use()) | ||||
|  | ||||
|  | ||||
| class TestTrimAllPasswordHistories(TestCase): | ||||
|     """Test the task that trims password history for all users""" | ||||
|  | ||||
|     def setUp(self): | ||||
|         self.user1 = create_test_user("test-user1") | ||||
|         self.user2 = create_test_user("test-user2") | ||||
|         self.pbm = PolicyBindingModel.objects.create() | ||||
|         # Create a policy with a limit of 1 password | ||||
|         self.policy = UniquePasswordPolicy.objects.create(num_historical_passwords=1) | ||||
|         PolicyBinding.objects.create( | ||||
|             target=self.pbm, | ||||
|             policy=self.policy, | ||||
|             enabled=True, | ||||
|             order=0, | ||||
|         ) | ||||
|  | ||||
|  | ||||
| class TestCheckAndPurgePasswordHistory(TestCase): | ||||
|     """Test the scheduled task that checks if any policy is in use and purges if not""" | ||||
|  | ||||
|     def setUp(self): | ||||
|         self.user = create_test_user("test-user") | ||||
|         self.pbm = PolicyBindingModel.objects.create() | ||||
|  | ||||
|     def test_purge_when_no_policy_in_use(self): | ||||
|         """Test that the task purges the table when no policy is in use""" | ||||
|         # Create some password history entries | ||||
|         UserPasswordHistory.create_for_user(self.user, "hunter2") | ||||
|  | ||||
|         # Verify we have entries | ||||
|         self.assertTrue(UserPasswordHistory.objects.exists()) | ||||
|  | ||||
|         # Run the task - should purge since no policy is in use | ||||
|         check_and_purge_password_history() | ||||
|  | ||||
|         # Verify the table is empty | ||||
|         self.assertFalse(UserPasswordHistory.objects.exists()) | ||||
|  | ||||
|     def test_no_purge_when_policy_in_use(self): | ||||
|         """Test that the task doesn't purge when a policy is in use""" | ||||
|         # Create a policy and binding | ||||
|         policy = UniquePasswordPolicy.objects.create(num_historical_passwords=5) | ||||
|         PolicyBinding.objects.create( | ||||
|             target=self.pbm, | ||||
|             policy=policy, | ||||
|             enabled=True, | ||||
|             order=0, | ||||
|         ) | ||||
|  | ||||
|         # Create some password history entries | ||||
|         UserPasswordHistory.create_for_user(self.user, "hunter2") | ||||
|  | ||||
|         # Verify we have entries | ||||
|         self.assertTrue(UserPasswordHistory.objects.exists()) | ||||
|  | ||||
|         # Run the task - should NOT purge since a policy is in use | ||||
|         check_and_purge_password_history() | ||||
|  | ||||
|         # Verify the entries still exist | ||||
|         self.assertTrue(UserPasswordHistory.objects.exists()) | ||||
|  | ||||
|  | ||||
| class TestTrimPasswordHistory(TestCase): | ||||
|     """Test password history cleanup task""" | ||||
|  | ||||
|     def setUp(self): | ||||
|         self.user = create_test_user("test-user") | ||||
|         self.pbm = PolicyBindingModel.objects.create() | ||||
|  | ||||
|     def test_trim_password_history_ok(self): | ||||
|         """Test passwords over the define limit are deleted""" | ||||
|         _now = datetime.now() | ||||
|         UserPasswordHistory.objects.bulk_create( | ||||
|             [ | ||||
|                 UserPasswordHistory( | ||||
|                     user=self.user, | ||||
|                     old_password="hunter1",  # nosec B106 | ||||
|                     created_at=_now - timedelta(days=3), | ||||
|                 ), | ||||
|                 UserPasswordHistory( | ||||
|                     user=self.user, | ||||
|                     old_password="hunter2",  # nosec B106 | ||||
|                     created_at=_now - timedelta(days=2), | ||||
|                 ), | ||||
|                 UserPasswordHistory( | ||||
|                     user=self.user, | ||||
|                     old_password="hunter3",  # nosec B106 | ||||
|                     created_at=_now, | ||||
|                 ), | ||||
|             ] | ||||
|         ) | ||||
|  | ||||
|         policy = UniquePasswordPolicy.objects.create(num_historical_passwords=1) | ||||
|         PolicyBinding.objects.create( | ||||
|             target=self.pbm, | ||||
|             policy=policy, | ||||
|             enabled=True, | ||||
|             order=0, | ||||
|         ) | ||||
|         trim_password_histories.delay() | ||||
|         user_pwd_history_qs = UserPasswordHistory.objects.filter(user=self.user) | ||||
|         self.assertEqual(len(user_pwd_history_qs), 1) | ||||
|  | ||||
|     def test_trim_password_history_policy_diabled_no_op(self): | ||||
|         """Test no passwords removed if policy binding is disabled""" | ||||
|  | ||||
|         # Insert a record to ensure it's not deleted after executing task | ||||
|         UserPasswordHistory.create_for_user(self.user, "hunter2") | ||||
|  | ||||
|         policy = UniquePasswordPolicy.objects.create(num_historical_passwords=1) | ||||
|         PolicyBinding.objects.create( | ||||
|             target=self.pbm, | ||||
|             policy=policy, | ||||
|             enabled=False, | ||||
|             order=0, | ||||
|         ) | ||||
|         trim_password_histories.delay() | ||||
|         self.assertTrue(UserPasswordHistory.objects.filter(user=self.user).exists()) | ||||
|  | ||||
|     def test_trim_password_history_fewer_records_than_maximum_is_no_op(self): | ||||
|         """Test no passwords deleted if fewer passwords exist than limit""" | ||||
|  | ||||
|         UserPasswordHistory.create_for_user(self.user, "hunter2") | ||||
|  | ||||
|         policy = UniquePasswordPolicy.objects.create(num_historical_passwords=2) | ||||
|         PolicyBinding.objects.create( | ||||
|             target=self.pbm, | ||||
|             policy=policy, | ||||
|             enabled=True, | ||||
|             order=0, | ||||
|         ) | ||||
|         trim_password_histories.delay() | ||||
|         self.assertTrue(UserPasswordHistory.objects.filter(user=self.user).exists()) | ||||
| @ -1,7 +0,0 @@ | ||||
| """API URLs""" | ||||
|  | ||||
| from authentik.enterprise.policies.unique_password.api import UniquePasswordPolicyViewSet | ||||
|  | ||||
| api_urlpatterns = [ | ||||
|     ("policies/unique_password", UniquePasswordPolicyViewSet), | ||||
| ] | ||||
| @ -102,7 +102,7 @@ def ssf_user_session_delete_session_revoked(sender, instance: AuthenticatedSessi | ||||
|             "format": "complex", | ||||
|             "session": { | ||||
|                 "format": "opaque", | ||||
|                 "id": sha256(instance.session.session_key.encode("ascii")).hexdigest(), | ||||
|                 "id": sha256(instance.session_key.encode("ascii")).hexdigest(), | ||||
|             }, | ||||
|             "user": { | ||||
|                 "format": "email", | ||||
|  | ||||
| @ -4,9 +4,10 @@ from rest_framework.exceptions import PermissionDenied, ValidationError | ||||
| from rest_framework.fields import CharField, ChoiceField, ListField, SerializerMethodField | ||||
| from rest_framework.request import Request | ||||
| from rest_framework.response import Response | ||||
| from rest_framework.serializers import ModelSerializer | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.core.api.utils import ModelSerializer, PassiveSerializer | ||||
| from authentik.core.api.utils import PassiveSerializer | ||||
| from authentik.enterprise.providers.ssf.models import ( | ||||
|     DeliveryMethods, | ||||
|     EventTypes, | ||||
|  | ||||
| @ -14,7 +14,6 @@ CELERY_BEAT_SCHEDULE = { | ||||
|  | ||||
| TENANT_APPS = [ | ||||
|     "authentik.enterprise.audit", | ||||
|     "authentik.enterprise.policies.unique_password", | ||||
|     "authentik.enterprise.providers.google_workspace", | ||||
|     "authentik.enterprise.providers.microsoft_entra", | ||||
|     "authentik.enterprise.providers.ssf", | ||||
|  | ||||
| @ -2,11 +2,11 @@ | ||||
|  | ||||
| from rest_framework import mixins | ||||
| from rest_framework.permissions import IsAdminUser | ||||
| from rest_framework.serializers import ModelSerializer | ||||
| from rest_framework.viewsets import GenericViewSet, ModelViewSet | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.core.api.used_by import UsedByMixin | ||||
| from authentik.core.api.utils import ModelSerializer | ||||
| from authentik.enterprise.api import EnterpriseRequiredMixin | ||||
| from authentik.enterprise.stages.authenticator_endpoint_gdtc.models import ( | ||||
|     AuthenticatorEndpointGDTCStage, | ||||
|  | ||||
| @ -11,14 +11,13 @@ from guardian.shortcuts import get_anonymous_user | ||||
| from authentik.core.models import Source, User | ||||
| from authentik.core.sources.flow_manager import ( | ||||
|     SESSION_KEY_OVERRIDE_FLOW_TOKEN, | ||||
|     SESSION_KEY_SOURCE_FLOW_CONTEXT, | ||||
|     SESSION_KEY_SOURCE_FLOW_STAGES, | ||||
| ) | ||||
| from authentik.core.types import UILoginButton | ||||
| from authentik.enterprise.stages.source.models import SourceStage | ||||
| from authentik.flows.challenge import Challenge, ChallengeResponse | ||||
| from authentik.flows.models import FlowToken, in_memory_stage | ||||
| from authentik.flows.planner import PLAN_CONTEXT_IS_REDIRECTED, PLAN_CONTEXT_IS_RESTORED | ||||
| from authentik.flows.planner import PLAN_CONTEXT_IS_RESTORED | ||||
| from authentik.flows.stage import ChallengeStageView, StageView | ||||
| from authentik.lib.utils.time import timedelta_from_string | ||||
|  | ||||
| @ -54,9 +53,6 @@ class SourceStageView(ChallengeStageView): | ||||
|         resume_token = self.create_flow_token() | ||||
|         self.request.session[SESSION_KEY_OVERRIDE_FLOW_TOKEN] = resume_token | ||||
|         self.request.session[SESSION_KEY_SOURCE_FLOW_STAGES] = [in_memory_stage(SourceStageFinal)] | ||||
|         self.request.session[SESSION_KEY_SOURCE_FLOW_CONTEXT] = { | ||||
|             PLAN_CONTEXT_IS_REDIRECTED: self.executor.flow, | ||||
|         } | ||||
|         return self.login_button.challenge | ||||
|  | ||||
|     def create_flow_token(self) -> FlowToken: | ||||
|  | ||||
| @ -59,7 +59,7 @@ def get_login_event(request_or_session: HttpRequest | AuthenticatedSession | Non | ||||
|         session = request_or_session.session | ||||
|     if isinstance(request_or_session, AuthenticatedSession): | ||||
|         SessionStore = _session_engine.SessionStore | ||||
|         session = SessionStore(request_or_session.session.session_key) | ||||
|         session = SessionStore(request_or_session.session_key) | ||||
|     return session.get(SESSION_LOGIN_EVENT, None) | ||||
|  | ||||
|  | ||||
|  | ||||
| @ -48,7 +48,6 @@ class TestFlowInspector(APITestCase): | ||||
|                 "allow_show_password": False, | ||||
|                 "captcha_stage": None, | ||||
|                 "component": "ak-stage-identification", | ||||
|                 "enable_remember_me": False, | ||||
|                 "flow_info": { | ||||
|                     "background": "/static/dist/assets/images/flow_background.jpg", | ||||
|                     "cancel_url": reverse("authentik_flows:cancel"), | ||||
|  | ||||
| @ -356,14 +356,6 @@ def redis_url(db: int) -> str: | ||||
| def django_db_config(config: ConfigLoader | None = None) -> dict: | ||||
|     if not config: | ||||
|         config = CONFIG | ||||
|  | ||||
|     pool_options = False | ||||
|     use_pool = config.get_bool("postgresql.use_pool", False) | ||||
|     if use_pool: | ||||
|         pool_options = config.get_dict_from_b64_json("postgresql.pool_options", True) | ||||
|         if not pool_options: | ||||
|             pool_options = True | ||||
|  | ||||
|     db = { | ||||
|         "default": { | ||||
|             "ENGINE": "authentik.root.db", | ||||
| @ -377,7 +369,6 @@ def django_db_config(config: ConfigLoader | None = None) -> dict: | ||||
|                 "sslrootcert": config.get("postgresql.sslrootcert"), | ||||
|                 "sslcert": config.get("postgresql.sslcert"), | ||||
|                 "sslkey": config.get("postgresql.sslkey"), | ||||
|                 "pool": pool_options, | ||||
|             }, | ||||
|             "CONN_MAX_AGE": config.get_optional_int("postgresql.conn_max_age", 0), | ||||
|             "CONN_HEALTH_CHECKS": config.get_bool("postgresql.conn_health_checks", False), | ||||
|  | ||||
| @ -1,27 +1,11 @@ | ||||
| # authentik configuration | ||||
| # | ||||
| # https://docs.goauthentik.io/docs/install-config/configuration/ | ||||
| # | ||||
| # To override the settings in this file, run the following command from the repository root: | ||||
| # | ||||
| # ```shell | ||||
| # make gen-dev-config | ||||
| # ``` | ||||
| # | ||||
| # You may edit the generated file to override the configuration below.   | ||||
| # | ||||
| # When making modifying the default configuration file,  | ||||
| # ensure that the corresponding documentation is updated to match. | ||||
| # | ||||
| # @see {@link ../../website/docs/install-config/configuration/configuration.mdx Configuration documentation} for more information. | ||||
|  | ||||
| # update website/docs/install-config/configuration/configuration.mdx | ||||
| # This is the default configuration file | ||||
| postgresql: | ||||
|   host: localhost | ||||
|   name: authentik | ||||
|   user: authentik | ||||
|   port: 5432 | ||||
|   password: "env://POSTGRES_PASSWORD" | ||||
|   use_pool: False | ||||
|   test: | ||||
|     name: test_authentik | ||||
|   default_schema: public | ||||
|  | ||||
| @ -18,7 +18,7 @@ from sentry_sdk import start_span | ||||
| from sentry_sdk.tracing import Span | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.core.models import User | ||||
| from authentik.core.models import AuthenticatedSession, User | ||||
| from authentik.events.models import Event | ||||
| from authentik.lib.expression.exceptions import ControlFlowException | ||||
| from authentik.lib.utils.http import get_http_session | ||||
| @ -203,7 +203,9 @@ class BaseEvaluator: | ||||
|             provider = OAuth2Provider.objects.get(name=provider) | ||||
|         session = None | ||||
|         if hasattr(request, "session") and request.session.session_key: | ||||
|             session = request.session["authenticatedsession"] | ||||
|             session = AuthenticatedSession.objects.filter( | ||||
|                 session_key=request.session.session_key | ||||
|             ).first() | ||||
|         access_token = AccessToken( | ||||
|             provider=provider, | ||||
|             user=user, | ||||
|  | ||||
| @ -18,15 +18,6 @@ class SerializerModel(models.Model): | ||||
|     @property | ||||
|     def serializer(self) -> type[BaseSerializer]: | ||||
|         """Get serializer for this model""" | ||||
|         # Special handling for built-in source | ||||
|         if ( | ||||
|             hasattr(self, "managed") | ||||
|             and hasattr(self, "MANAGED_INBUILT") | ||||
|             and self.managed == self.MANAGED_INBUILT | ||||
|         ): | ||||
|             from authentik.core.api.sources import SourceSerializer | ||||
|  | ||||
|             return SourceSerializer | ||||
|         raise NotImplementedError | ||||
|  | ||||
|  | ||||
|  | ||||
| @ -217,7 +217,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -268,7 +267,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -287,7 +285,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "bar", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -336,7 +333,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -355,7 +351,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "bar", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -399,7 +394,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -418,7 +412,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "bar", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -458,7 +451,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "foo", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -477,7 +469,6 @@ class TestConfig(TestCase): | ||||
|                     "HOST": "bar", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": False, | ||||
|                         "sslcert": "bar", | ||||
|                         "sslkey": "foo", | ||||
|                         "sslmode": "foo", | ||||
| @ -493,87 +484,3 @@ class TestConfig(TestCase): | ||||
|                 }, | ||||
|             }, | ||||
|         ) | ||||
|  | ||||
|     def test_db_pool(self): | ||||
|         """Test DB Config with pool""" | ||||
|         config = ConfigLoader() | ||||
|         config.set("postgresql.host", "foo") | ||||
|         config.set("postgresql.name", "foo") | ||||
|         config.set("postgresql.user", "foo") | ||||
|         config.set("postgresql.password", "foo") | ||||
|         config.set("postgresql.port", "foo") | ||||
|         config.set("postgresql.test.name", "foo") | ||||
|         config.set("postgresql.use_pool", True) | ||||
|         conf = django_db_config(config) | ||||
|         self.assertEqual( | ||||
|             conf, | ||||
|             { | ||||
|                 "default": { | ||||
|                     "ENGINE": "authentik.root.db", | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": True, | ||||
|                         "sslcert": None, | ||||
|                         "sslkey": None, | ||||
|                         "sslmode": None, | ||||
|                         "sslrootcert": None, | ||||
|                     }, | ||||
|                     "PASSWORD": "foo", | ||||
|                     "PORT": "foo", | ||||
|                     "TEST": {"NAME": "foo"}, | ||||
|                     "USER": "foo", | ||||
|                     "CONN_MAX_AGE": 0, | ||||
|                     "CONN_HEALTH_CHECKS": False, | ||||
|                     "DISABLE_SERVER_SIDE_CURSORS": False, | ||||
|                 } | ||||
|             }, | ||||
|         ) | ||||
|  | ||||
|     def test_db_pool_options(self): | ||||
|         """Test DB Config with pool""" | ||||
|         config = ConfigLoader() | ||||
|         config.set("postgresql.host", "foo") | ||||
|         config.set("postgresql.name", "foo") | ||||
|         config.set("postgresql.user", "foo") | ||||
|         config.set("postgresql.password", "foo") | ||||
|         config.set("postgresql.port", "foo") | ||||
|         config.set("postgresql.test.name", "foo") | ||||
|         config.set("postgresql.use_pool", True) | ||||
|         config.set( | ||||
|             "postgresql.pool_options", | ||||
|             base64.b64encode( | ||||
|                 dumps( | ||||
|                     { | ||||
|                         "max_size": 15, | ||||
|                     } | ||||
|                 ).encode() | ||||
|             ).decode(), | ||||
|         ) | ||||
|         conf = django_db_config(config) | ||||
|         self.assertEqual( | ||||
|             conf, | ||||
|             { | ||||
|                 "default": { | ||||
|                     "ENGINE": "authentik.root.db", | ||||
|                     "HOST": "foo", | ||||
|                     "NAME": "foo", | ||||
|                     "OPTIONS": { | ||||
|                         "pool": { | ||||
|                             "max_size": 15, | ||||
|                         }, | ||||
|                         "sslcert": None, | ||||
|                         "sslkey": None, | ||||
|                         "sslmode": None, | ||||
|                         "sslrootcert": None, | ||||
|                     }, | ||||
|                     "PASSWORD": "foo", | ||||
|                     "PORT": "foo", | ||||
|                     "TEST": {"NAME": "foo"}, | ||||
|                     "USER": "foo", | ||||
|                     "CONN_MAX_AGE": 0, | ||||
|                     "CONN_HEALTH_CHECKS": False, | ||||
|                     "DISABLE_SERVER_SIDE_CURSORS": False, | ||||
|                 } | ||||
|             }, | ||||
|         ) | ||||
|  | ||||
| @ -13,7 +13,6 @@ from paramiko.ssh_exception import SSHException | ||||
| from structlog.stdlib import get_logger | ||||
| from yaml import safe_dump | ||||
|  | ||||
| from authentik import __version__ | ||||
| from authentik.outposts.apps import MANAGED_OUTPOST | ||||
| from authentik.outposts.controllers.base import BaseClient, BaseController, ControllerException | ||||
| from authentik.outposts.docker_ssh import DockerInlineSSH, SSHManagedExternallyException | ||||
| @ -185,7 +184,7 @@ class DockerController(BaseController): | ||||
|         try: | ||||
|             self.client.images.pull(image) | ||||
|         except DockerException:  # pragma: no cover | ||||
|             image = f"ghcr.io/goauthentik/{self.outpost.type}:{__version__}" | ||||
|             image = f"ghcr.io/goauthentik/{self.outpost.type}:latest" | ||||
|             self.client.images.pull(image) | ||||
|         return image | ||||
|  | ||||
|  | ||||
| @ -74,8 +74,6 @@ class OutpostConfig: | ||||
|     kubernetes_ingress_annotations: dict[str, str] = field(default_factory=dict) | ||||
|     kubernetes_ingress_secret_name: str = field(default="authentik-outpost-tls") | ||||
|     kubernetes_ingress_class_name: str | None = field(default=None) | ||||
|     kubernetes_httproute_annotations: dict[str, str] = field(default_factory=dict) | ||||
|     kubernetes_httproute_parent_refs: list[dict[str, str]] = field(default_factory=list) | ||||
|     kubernetes_service_type: str = field(default="ClusterIP") | ||||
|     kubernetes_disabled_components: list[str] = field(default_factory=list) | ||||
|     kubernetes_image_pull_secrets: list[str] = field(default_factory=list) | ||||
|  | ||||
| @ -1,8 +1,4 @@ | ||||
| """Authentik policies app config | ||||
|  | ||||
| Every system policy should be its own Django app under the `policies` app. | ||||
| For example: The 'dummy' policy is available at `authentik.policies.dummy`. | ||||
| """ | ||||
| """authentik policies app config""" | ||||
|  | ||||
| from prometheus_client import Gauge, Histogram | ||||
|  | ||||
|  | ||||
| @ -66,9 +66,7 @@ class GeoIPPolicy(Policy): | ||||
|         if not static_results and not dynamic_results: | ||||
|             return PolicyResult(True) | ||||
|  | ||||
|         static_passing = any(r.passing for r in static_results) if static_results else True | ||||
|         dynamic_passing = all(r.passing for r in dynamic_results) | ||||
|         passing = static_passing and dynamic_passing | ||||
|         passing = any(r.passing for r in static_results) and all(r.passing for r in dynamic_results) | ||||
|         messages = chain( | ||||
|             *[r.messages for r in static_results], *[r.messages for r in dynamic_results] | ||||
|         ) | ||||
| @ -115,19 +113,13 @@ class GeoIPPolicy(Policy): | ||||
|         to previous authentication requests""" | ||||
|         # Get previous login event and GeoIP data | ||||
|         previous_logins = Event.objects.filter( | ||||
|             action=EventAction.LOGIN, | ||||
|             user__pk=request.user.pk,  # context__geo__isnull=False | ||||
|             action=EventAction.LOGIN, user__pk=request.user.pk, context__geo__isnull=False | ||||
|         ).order_by("-created")[: self.history_login_count] | ||||
|         _now = now() | ||||
|         geoip_data: GeoIPDict | None = request.context.get("geoip") | ||||
|         if not geoip_data: | ||||
|             return PolicyResult(False) | ||||
|         if not previous_logins.exists(): | ||||
|             return PolicyResult(True) | ||||
|         result = False | ||||
|         for previous_login in previous_logins: | ||||
|             if "geo" not in previous_login.context: | ||||
|                 continue | ||||
|             previous_login_geoip: GeoIPDict = previous_login.context["geo"] | ||||
|  | ||||
|             # Figure out distance | ||||
| @ -150,8 +142,7 @@ class GeoIPPolicy(Policy): | ||||
|                 (MAX_DISTANCE_HOUR_KM * rel_time_hours) + self.distance_tolerance_km | ||||
|             ): | ||||
|                 return PolicyResult(False, _("Distance is further than possible.")) | ||||
|             result = True | ||||
|         return PolicyResult(result) | ||||
|         return PolicyResult(True) | ||||
|  | ||||
|     class Meta(Policy.PolicyMeta): | ||||
|         verbose_name = _("GeoIP Policy") | ||||
|  | ||||
| @ -163,7 +163,7 @@ class TestGeoIPPolicy(TestCase): | ||||
|         result: PolicyResult = policy.passes(self.request) | ||||
|         self.assertFalse(result.passing) | ||||
|  | ||||
|     def test_history_impossible_travel_failing(self): | ||||
|     def test_history_impossible_travel(self): | ||||
|         """Test history checks""" | ||||
|         Event.objects.create( | ||||
|             action=EventAction.LOGIN, | ||||
| @ -181,24 +181,6 @@ class TestGeoIPPolicy(TestCase): | ||||
|         result: PolicyResult = policy.passes(self.request) | ||||
|         self.assertFalse(result.passing) | ||||
|  | ||||
|     def test_history_impossible_travel_passing(self): | ||||
|         """Test history checks""" | ||||
|         Event.objects.create( | ||||
|             action=EventAction.LOGIN, | ||||
|             user=get_user(self.user), | ||||
|             context={ | ||||
|                 # Random location in Canada | ||||
|                 "geo": {"lat": 55.868351, "long": -104.441011}, | ||||
|             }, | ||||
|         ) | ||||
|         # Same location | ||||
|         self.request.context["geoip"] = {"lat": 55.868351, "long": -104.441011} | ||||
|  | ||||
|         policy = GeoIPPolicy.objects.create(check_impossible_travel=True) | ||||
|  | ||||
|         result: PolicyResult = policy.passes(self.request) | ||||
|         self.assertTrue(result.passing) | ||||
|  | ||||
|     def test_history_no_geoip(self): | ||||
|         """Test history checks (previous login with no geoip data)""" | ||||
|         Event.objects.create( | ||||
| @ -213,18 +195,3 @@ class TestGeoIPPolicy(TestCase): | ||||
|  | ||||
|         result: PolicyResult = policy.passes(self.request) | ||||
|         self.assertFalse(result.passing) | ||||
|  | ||||
|     def test_impossible_travel_no_geoip(self): | ||||
|         """Test impossible travel checks (previous login with no geoip data)""" | ||||
|         Event.objects.create( | ||||
|             action=EventAction.LOGIN, | ||||
|             user=get_user(self.user), | ||||
|             context={}, | ||||
|         ) | ||||
|         # Random location in Poland | ||||
|         self.request.context["geoip"] = {"lat": 50.950613, "long": 20.363679} | ||||
|  | ||||
|         policy = GeoIPPolicy.objects.create(check_impossible_travel=True) | ||||
|  | ||||
|         result: PolicyResult = policy.passes(self.request) | ||||
|         self.assertFalse(result.passing) | ||||
|  | ||||
| @ -52,13 +52,6 @@ class PolicyBindingModel(models.Model): | ||||
|         return ["policy", "user", "group"] | ||||
|  | ||||
|  | ||||
| class BoundPolicyQuerySet(models.QuerySet): | ||||
|     """QuerySet for filtering enabled bindings for a Policy type""" | ||||
|  | ||||
|     def for_policy(self, policy: "Policy"): | ||||
|         return self.filter(policy__in=policy._default_manager.all()).filter(enabled=True) | ||||
|  | ||||
|  | ||||
| class PolicyBinding(SerializerModel): | ||||
|     """Relationship between a Policy and a PolicyBindingModel.""" | ||||
|  | ||||
| @ -155,9 +148,6 @@ class PolicyBinding(SerializerModel): | ||||
|             return f"Binding - #{self.order} to {suffix}" | ||||
|         return "" | ||||
|  | ||||
|     objects = models.Manager() | ||||
|     in_use = BoundPolicyQuerySet.as_manager() | ||||
|  | ||||
|     class Meta: | ||||
|         verbose_name = _("Policy Binding") | ||||
|         verbose_name_plural = _("Policy Bindings") | ||||
|  | ||||
| @ -2,6 +2,4 @@ | ||||
|  | ||||
| from authentik.policies.password.api import PasswordPolicyViewSet | ||||
|  | ||||
| api_urlpatterns = [ | ||||
|     ("policies/password", PasswordPolicyViewSet), | ||||
| ] | ||||
| api_urlpatterns = [("policies/password", PasswordPolicyViewSet)] | ||||
|  | ||||
| @ -2,6 +2,7 @@ | ||||
|  | ||||
| from django.contrib.auth.signals import user_logged_in | ||||
| from django.db import transaction | ||||
| from django.db.models import F | ||||
| from django.dispatch import receiver | ||||
| from django.http import HttpRequest | ||||
| from structlog.stdlib import get_logger | ||||
| @ -12,29 +13,20 @@ from authentik.events.context_processors.geoip import GEOIP_CONTEXT_PROCESSOR | ||||
| from authentik.policies.reputation.models import Reputation, reputation_expiry | ||||
| from authentik.root.middleware import ClientIPMiddleware | ||||
| from authentik.stages.identification.signals import identification_failed | ||||
| from authentik.tenants.utils import get_current_tenant | ||||
|  | ||||
| LOGGER = get_logger() | ||||
|  | ||||
|  | ||||
| def clamp(value, min, max): | ||||
|     return sorted([min, value, max])[1] | ||||
|  | ||||
|  | ||||
| def update_score(request: HttpRequest, identifier: str, amount: int): | ||||
|     """Update score for IP and User""" | ||||
|     remote_ip = ClientIPMiddleware.get_client_ip(request) | ||||
|     tenant = get_current_tenant() | ||||
|     new_score = clamp(amount, tenant.reputation_lower_limit, tenant.reputation_upper_limit) | ||||
|  | ||||
|     with transaction.atomic(): | ||||
|         reputation, created = Reputation.objects.select_for_update().get_or_create( | ||||
|             ip=remote_ip, | ||||
|             identifier=identifier, | ||||
|             defaults={ | ||||
|                 "score": clamp( | ||||
|                     amount, tenant.reputation_lower_limit, tenant.reputation_upper_limit | ||||
|                 ), | ||||
|                 "score": amount, | ||||
|                 "ip_geo_data": GEOIP_CONTEXT_PROCESSOR.city_dict(remote_ip) or {}, | ||||
|                 "ip_asn_data": ASN_CONTEXT_PROCESSOR.asn_dict(remote_ip) or {}, | ||||
|                 "expires": reputation_expiry(), | ||||
| @ -42,15 +34,9 @@ def update_score(request: HttpRequest, identifier: str, amount: int): | ||||
|         ) | ||||
|  | ||||
|         if not created: | ||||
|             new_score = clamp( | ||||
|                 reputation.score + amount, | ||||
|                 tenant.reputation_lower_limit, | ||||
|                 tenant.reputation_upper_limit, | ||||
|             ) | ||||
|             reputation.score = new_score | ||||
|             reputation.score = F("score") + amount | ||||
|             reputation.save() | ||||
|  | ||||
|     LOGGER.info("Updated score", amount=new_score, for_user=identifier, for_ip=remote_ip) | ||||
|     LOGGER.info("Updated score", amount=amount, for_user=identifier, for_ip=remote_ip) | ||||
|  | ||||
|  | ||||
| @receiver(login_failed) | ||||
|  | ||||
| @ -6,11 +6,9 @@ from authentik.core.models import User | ||||
| from authentik.lib.generators import generate_id | ||||
| from authentik.policies.reputation.api import ReputationPolicySerializer | ||||
| from authentik.policies.reputation.models import Reputation, ReputationPolicy | ||||
| from authentik.policies.reputation.signals import update_score | ||||
| from authentik.policies.types import PolicyRequest | ||||
| from authentik.stages.password import BACKEND_INBUILT | ||||
| from authentik.stages.password.stage import authenticate | ||||
| from authentik.tenants.models import DEFAULT_REPUTATION_LOWER_LIMIT, DEFAULT_REPUTATION_UPPER_LIMIT | ||||
|  | ||||
|  | ||||
| class TestReputationPolicy(TestCase): | ||||
| @ -19,48 +17,36 @@ class TestReputationPolicy(TestCase): | ||||
|     def setUp(self): | ||||
|         self.request_factory = RequestFactory() | ||||
|         self.request = self.request_factory.get("/") | ||||
|         self.ip = "127.0.0.1" | ||||
|         self.username = "username" | ||||
|         self.password = generate_id() | ||||
|         self.test_ip = "127.0.0.1" | ||||
|         self.test_username = "test" | ||||
|         # We need a user for the one-to-one in userreputation | ||||
|         self.user = User.objects.create(username=self.username) | ||||
|         self.user.set_password(self.password) | ||||
|         self.user = User.objects.create(username=self.test_username) | ||||
|         self.backends = [BACKEND_INBUILT] | ||||
|  | ||||
|     def test_ip_reputation(self): | ||||
|         """test IP reputation""" | ||||
|         # Trigger negative reputation | ||||
|         authenticate(self.request, self.backends, username=self.username, password=self.username) | ||||
|         self.assertEqual(Reputation.objects.get(ip=self.ip).score, -1) | ||||
|         authenticate( | ||||
|             self.request, self.backends, username=self.test_username, password=self.test_username | ||||
|         ) | ||||
|         self.assertEqual(Reputation.objects.get(ip=self.test_ip).score, -1) | ||||
|  | ||||
|     def test_user_reputation(self): | ||||
|         """test User reputation""" | ||||
|         # Trigger negative reputation | ||||
|         authenticate(self.request, self.backends, username=self.username, password=self.username) | ||||
|         self.assertEqual(Reputation.objects.get(identifier=self.username).score, -1) | ||||
|         authenticate( | ||||
|             self.request, self.backends, username=self.test_username, password=self.test_username | ||||
|         ) | ||||
|         self.assertEqual(Reputation.objects.get(identifier=self.test_username).score, -1) | ||||
|  | ||||
|     def test_update_reputation(self): | ||||
|         """test reputation update""" | ||||
|         Reputation.objects.create(identifier=self.username, ip=self.ip, score=4) | ||||
|         Reputation.objects.create(identifier=self.test_username, ip=self.test_ip, score=43) | ||||
|         # Trigger negative reputation | ||||
|         authenticate(self.request, self.backends, username=self.username, password=self.username) | ||||
|         self.assertEqual(Reputation.objects.get(identifier=self.username).score, 3) | ||||
|  | ||||
|     def test_reputation_lower_limit(self): | ||||
|         """test reputation lower limit""" | ||||
|         Reputation.objects.create(identifier=self.username, ip=self.ip) | ||||
|         update_score(self.request, identifier=self.username, amount=-1000) | ||||
|         self.assertEqual( | ||||
|             Reputation.objects.get(identifier=self.username).score, DEFAULT_REPUTATION_LOWER_LIMIT | ||||
|         ) | ||||
|  | ||||
|     def test_reputation_upper_limit(self): | ||||
|         """test reputation upper limit""" | ||||
|         Reputation.objects.create(identifier=self.username, ip=self.ip) | ||||
|         update_score(self.request, identifier=self.username, amount=1000) | ||||
|         self.assertEqual( | ||||
|             Reputation.objects.get(identifier=self.username).score, DEFAULT_REPUTATION_UPPER_LIMIT | ||||
|         authenticate( | ||||
|             self.request, self.backends, username=self.test_username, password=self.test_username | ||||
|         ) | ||||
|         self.assertEqual(Reputation.objects.get(identifier=self.test_username).score, 42) | ||||
|  | ||||
|     def test_policy(self): | ||||
|         """Test Policy""" | ||||
|  | ||||
| @ -126,7 +126,7 @@ class IDToken: | ||||
|         id_token.iat = int(now.timestamp()) | ||||
|         id_token.auth_time = int(token.auth_time.timestamp()) | ||||
|         if token.session: | ||||
|             id_token.sid = hash_session_key(token.session.session.session_key) | ||||
|             id_token.sid = hash_session_key(token.session.session_key) | ||||
|  | ||||
|         # We use the timestamp of the user's last successful login (EventAction.LOGIN) for auth_time | ||||
|         auth_event = get_login_event(token.session) | ||||
|  | ||||
| @ -1,116 +0,0 @@ | ||||
| # Generated by Django 5.0.11 on 2025-01-27 13:00 | ||||
|  | ||||
| from django.db import migrations | ||||
| import django.db.models.deletion | ||||
| from django.db import migrations, models | ||||
| from functools import partial | ||||
|  | ||||
|  | ||||
| def migrate_sessions(apps, schema_editor, model): | ||||
|     Model = apps.get_model("authentik_providers_oauth2", model) | ||||
|     AuthenticatedSession = apps.get_model("authentik_core", "AuthenticatedSession") | ||||
|     db_alias = schema_editor.connection.alias | ||||
|  | ||||
|     for obj in Model.objects.using(db_alias).all(): | ||||
|         if not obj.old_session: | ||||
|             continue | ||||
|         obj.session = ( | ||||
|             AuthenticatedSession.objects.using(db_alias) | ||||
|             .filter(session__session_key=obj.old_session.session_key) | ||||
|             .first() | ||||
|         ) | ||||
|         if obj.session: | ||||
|             obj.save() | ||||
|         else: | ||||
|             obj.delete() | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_providers_oauth2", "0027_accesstoken_authentik_p_expires_9f24a5_idx_and_more"), | ||||
|         ("authentik_core", "0046_session_and_more"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.RenameField( | ||||
|             model_name="accesstoken", | ||||
|             old_name="session", | ||||
|             new_name="old_session", | ||||
|         ), | ||||
|         migrations.RenameField( | ||||
|             model_name="authorizationcode", | ||||
|             old_name="session", | ||||
|             new_name="old_session", | ||||
|         ), | ||||
|         migrations.RenameField( | ||||
|             model_name="devicetoken", | ||||
|             old_name="session", | ||||
|             new_name="old_session", | ||||
|         ), | ||||
|         migrations.RenameField( | ||||
|             model_name="refreshtoken", | ||||
|             old_name="session", | ||||
|             new_name="old_session", | ||||
|         ), | ||||
|         migrations.AddField( | ||||
|             model_name="accesstoken", | ||||
|             name="session", | ||||
|             field=models.ForeignKey( | ||||
|                 default=None, | ||||
|                 null=True, | ||||
|                 on_delete=django.db.models.deletion.CASCADE, | ||||
|                 to="authentik_core.authenticatedsession", | ||||
|             ), | ||||
|         ), | ||||
|         migrations.AddField( | ||||
|             model_name="authorizationcode", | ||||
|             name="session", | ||||
|             field=models.ForeignKey( | ||||
|                 default=None, | ||||
|                 null=True, | ||||
|                 on_delete=django.db.models.deletion.CASCADE, | ||||
|                 to="authentik_core.authenticatedsession", | ||||
|             ), | ||||
|         ), | ||||
|         migrations.AddField( | ||||
|             model_name="devicetoken", | ||||
|             name="session", | ||||
|             field=models.ForeignKey( | ||||
|                 default=None, | ||||
|                 null=True, | ||||
|                 on_delete=django.db.models.deletion.SET_DEFAULT, | ||||
|                 to="authentik_core.authenticatedsession", | ||||
|             ), | ||||
|         ), | ||||
|         migrations.AddField( | ||||
|             model_name="refreshtoken", | ||||
|             name="session", | ||||
|             field=models.ForeignKey( | ||||
|                 default=None, | ||||
|                 null=True, | ||||
|                 on_delete=django.db.models.deletion.SET_DEFAULT, | ||||
|                 to="authentik_core.authenticatedsession", | ||||
|             ), | ||||
|         ), | ||||
|         migrations.RunPython(code=partial(migrate_sessions, model="AccessToken")), | ||||
|         migrations.RunPython(code=partial(migrate_sessions, model="AuthorizationCode")), | ||||
|         migrations.RunPython(code=partial(migrate_sessions, model="DeviceToken")), | ||||
|         migrations.RunPython(code=partial(migrate_sessions, model="RefreshToken")), | ||||
|         migrations.RemoveField( | ||||
|             model_name="accesstoken", | ||||
|             name="old_session", | ||||
|         ), | ||||
|         migrations.RemoveField( | ||||
|             model_name="authorizationcode", | ||||
|             name="old_session", | ||||
|         ), | ||||
|         migrations.RemoveField( | ||||
|             model_name="devicetoken", | ||||
|             name="old_session", | ||||
|         ), | ||||
|         migrations.RemoveField( | ||||
|             model_name="refreshtoken", | ||||
|             name="old_session", | ||||
|         ), | ||||
|     ] | ||||
| @ -1,30 +1,18 @@ | ||||
| from django.contrib.auth.signals import user_logged_out | ||||
| from django.db.models.signals import post_save, pre_delete | ||||
| from django.db.models.signals import post_save | ||||
| from django.dispatch import receiver | ||||
| from django.http import HttpRequest | ||||
|  | ||||
| from authentik.core.models import AuthenticatedSession, User | ||||
| from authentik.core.models import User | ||||
| from authentik.providers.oauth2.models import AccessToken, DeviceToken, RefreshToken | ||||
|  | ||||
|  | ||||
| @receiver(user_logged_out) | ||||
| def user_logged_out_oauth_tokens_removal(sender, request: HttpRequest, user: User, **_): | ||||
|     """Revoke tokens upon user logout""" | ||||
| def user_logged_out_oauth_access_token(sender, request: HttpRequest, user: User, **_): | ||||
|     """Revoke access tokens upon user logout""" | ||||
|     if not request.session or not request.session.session_key: | ||||
|         return | ||||
|     AccessToken.objects.filter( | ||||
|         user=user, | ||||
|         session__session__session_key=request.session.session_key, | ||||
|     ).delete() | ||||
|  | ||||
|  | ||||
| @receiver(pre_delete, sender=AuthenticatedSession) | ||||
| def user_session_deleted_oauth_tokens_removal(sender, instance: AuthenticatedSession, **_): | ||||
|     """Revoke tokens upon user logout""" | ||||
|     AccessToken.objects.filter( | ||||
|         user=instance.user, | ||||
|         session__session__session_key=instance.session.session_key, | ||||
|     ).delete() | ||||
|     AccessToken.objects.filter(user=user, session__session_key=request.session.session_key).delete() | ||||
|  | ||||
|  | ||||
| @receiver(post_save, sender=User) | ||||
| @ -32,6 +20,6 @@ def user_deactivated(sender, instance: User, **_): | ||||
|     """Remove user tokens when deactivated""" | ||||
|     if instance.is_active: | ||||
|         return | ||||
|     AccessToken.objects.filter(user=instance).delete() | ||||
|     RefreshToken.objects.filter(user=instance).delete() | ||||
|     DeviceToken.objects.filter(user=instance).delete() | ||||
|     AccessToken.objects.filter(session__user=instance).delete() | ||||
|     RefreshToken.objects.filter(session__user=instance).delete() | ||||
|     DeviceToken.objects.filter(session__user=instance).delete() | ||||
|  | ||||
| @ -7,13 +7,12 @@ from dataclasses import asdict | ||||
| from django.urls import reverse | ||||
| from django.utils import timezone | ||||
|  | ||||
| from authentik.core.models import Application, AuthenticatedSession, Session | ||||
| from authentik.core.models import Application | ||||
| from authentik.core.tests.utils import create_test_admin_user, create_test_cert, create_test_flow | ||||
| from authentik.lib.generators import generate_id | ||||
| from authentik.providers.oauth2.models import ( | ||||
|     AccessToken, | ||||
|     ClientTypes, | ||||
|     DeviceToken, | ||||
|     IDToken, | ||||
|     OAuth2Provider, | ||||
|     RedirectURI, | ||||
| @ -21,7 +20,6 @@ from authentik.providers.oauth2.models import ( | ||||
|     RefreshToken, | ||||
| ) | ||||
| from authentik.providers.oauth2.tests.utils import OAuthTestCase | ||||
| from authentik.root.middleware import ClientIPMiddleware | ||||
|  | ||||
|  | ||||
| class TesOAuth2Revoke(OAuthTestCase): | ||||
| @ -137,86 +135,3 @@ class TesOAuth2Revoke(OAuthTestCase): | ||||
|             }, | ||||
|         ) | ||||
|         self.assertEqual(res.status_code, 200) | ||||
|  | ||||
|     def test_revoke_logout(self): | ||||
|         """Test revoke on logout""" | ||||
|         self.client.force_login(self.user) | ||||
|         AccessToken.objects.create( | ||||
|             provider=self.provider, | ||||
|             user=self.user, | ||||
|             session=self.client.session["authenticatedsession"], | ||||
|             token=generate_id(), | ||||
|             auth_time=timezone.now(), | ||||
|             _scope="openid user profile", | ||||
|             _id_token=json.dumps( | ||||
|                 asdict( | ||||
|                     IDToken("foo", "bar"), | ||||
|                 ) | ||||
|             ), | ||||
|         ) | ||||
|         self.client.logout() | ||||
|         self.assertEqual(AccessToken.objects.all().count(), 0) | ||||
|  | ||||
|     def test_revoke_session_delete(self): | ||||
|         """Test revoke on logout""" | ||||
|         session = AuthenticatedSession.objects.create( | ||||
|             session=Session.objects.create( | ||||
|                 session_key=generate_id(), | ||||
|                 last_ip=ClientIPMiddleware.default_ip, | ||||
|             ), | ||||
|             user=self.user, | ||||
|         ) | ||||
|         AccessToken.objects.create( | ||||
|             provider=self.provider, | ||||
|             user=self.user, | ||||
|             session=session, | ||||
|             token=generate_id(), | ||||
|             auth_time=timezone.now(), | ||||
|             _scope="openid user profile", | ||||
|             _id_token=json.dumps( | ||||
|                 asdict( | ||||
|                     IDToken("foo", "bar"), | ||||
|                 ) | ||||
|             ), | ||||
|         ) | ||||
|         session.delete() | ||||
|         self.assertEqual(AccessToken.objects.all().count(), 0) | ||||
|  | ||||
|     def test_revoke_user_deactivated(self): | ||||
|         """Test revoke on logout""" | ||||
|         AccessToken.objects.create( | ||||
|             provider=self.provider, | ||||
|             user=self.user, | ||||
|             token=generate_id(), | ||||
|             auth_time=timezone.now(), | ||||
|             _scope="openid user profile", | ||||
|             _id_token=json.dumps( | ||||
|                 asdict( | ||||
|                     IDToken("foo", "bar"), | ||||
|                 ) | ||||
|             ), | ||||
|         ) | ||||
|         RefreshToken.objects.create( | ||||
|             provider=self.provider, | ||||
|             user=self.user, | ||||
|             token=generate_id(), | ||||
|             auth_time=timezone.now(), | ||||
|             _scope="openid user profile", | ||||
|             _id_token=json.dumps( | ||||
|                 asdict( | ||||
|                     IDToken("foo", "bar"), | ||||
|                 ) | ||||
|             ), | ||||
|         ) | ||||
|         DeviceToken.objects.create( | ||||
|             provider=self.provider, | ||||
|             user=self.user, | ||||
|             _scope="openid user profile", | ||||
|         ) | ||||
|  | ||||
|         self.user.is_active = False | ||||
|         self.user.save() | ||||
|  | ||||
|         self.assertEqual(AccessToken.objects.all().count(), 0) | ||||
|         self.assertEqual(RefreshToken.objects.all().count(), 0) | ||||
|         self.assertEqual(DeviceToken.objects.all().count(), 0) | ||||
|  | ||||
| @ -15,7 +15,7 @@ from django.utils import timezone | ||||
| from django.utils.translation import gettext as _ | ||||
| from structlog.stdlib import get_logger | ||||
|  | ||||
| from authentik.core.models import Application | ||||
| from authentik.core.models import Application, AuthenticatedSession | ||||
| from authentik.events.models import Event, EventAction | ||||
| from authentik.events.signals import get_login_event | ||||
| from authentik.flows.challenge import ( | ||||
| @ -316,7 +316,9 @@ class OAuthAuthorizationParams: | ||||
|             expires=now + timedelta_from_string(self.provider.access_code_validity), | ||||
|             scope=self.scope, | ||||
|             nonce=self.nonce, | ||||
|             session=request.session["authenticatedsession"], | ||||
|             session=AuthenticatedSession.objects.filter( | ||||
|                 session_key=request.session.session_key | ||||
|             ).first(), | ||||
|         ) | ||||
|  | ||||
|         if self.code_challenge and self.code_challenge_method: | ||||
| @ -613,7 +615,9 @@ class OAuthFulfillmentStage(StageView): | ||||
|             expires=access_token_expiry, | ||||
|             provider=self.provider, | ||||
|             auth_time=auth_event.created if auth_event else now, | ||||
|             session=self.request.session["authenticatedsession"], | ||||
|             session=AuthenticatedSession.objects.filter( | ||||
|                 session_key=self.request.session.session_key | ||||
|             ).first(), | ||||
|         ) | ||||
|  | ||||
|         id_token = IDToken.new(self.provider, token, self.request) | ||||
|  | ||||
| @ -1,234 +0,0 @@ | ||||
| from dataclasses import asdict, dataclass, field | ||||
| from typing import TYPE_CHECKING | ||||
| from urllib.parse import urlparse | ||||
|  | ||||
| from dacite.core import from_dict | ||||
| from kubernetes.client import ApiextensionsV1Api, CustomObjectsApi, V1ObjectMeta | ||||
|  | ||||
| from authentik.outposts.controllers.base import FIELD_MANAGER | ||||
| from authentik.outposts.controllers.k8s.base import KubernetesObjectReconciler | ||||
| from authentik.outposts.controllers.k8s.triggers import NeedsUpdate | ||||
| from authentik.outposts.controllers.kubernetes import KubernetesController | ||||
| from authentik.providers.proxy.models import ProxyMode, ProxyProvider | ||||
|  | ||||
| if TYPE_CHECKING: | ||||
|     from authentik.outposts.controllers.kubernetes import KubernetesController | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class RouteBackendRef: | ||||
|     name: str | ||||
|     port: int | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class RouteSpecParentRefs: | ||||
|     name: str | ||||
|     sectionName: str | None = None | ||||
|     port: int | None = None | ||||
|     namespace: str | None = None | ||||
|     kind: str = "Gateway" | ||||
|     group: str = "gateway.networking.k8s.io" | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRouteSpecRuleMatchPath: | ||||
|     type: str | ||||
|     value: str | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRouteSpecRuleMatchHeader: | ||||
|     name: str | ||||
|     value: str | ||||
|     type: str = "Exact" | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRouteSpecRuleMatch: | ||||
|     path: HTTPRouteSpecRuleMatchPath | ||||
|     headers: list[HTTPRouteSpecRuleMatchHeader] | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRouteSpecRule: | ||||
|     backendRefs: list[RouteBackendRef] | ||||
|     matches: list[HTTPRouteSpecRuleMatch] | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRouteSpec: | ||||
|     parentRefs: list[RouteSpecParentRefs] | ||||
|     hostnames: list[str] | ||||
|     rules: list[HTTPRouteSpecRule] | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRouteMetadata: | ||||
|     name: str | ||||
|     namespace: str | ||||
|     annotations: dict = field(default_factory=dict) | ||||
|     labels: dict = field(default_factory=dict) | ||||
|  | ||||
|  | ||||
| @dataclass(slots=True) | ||||
| class HTTPRoute: | ||||
|     apiVersion: str | ||||
|     kind: str | ||||
|     metadata: HTTPRouteMetadata | ||||
|     spec: HTTPRouteSpec | ||||
|  | ||||
|  | ||||
| class HTTPRouteReconciler(KubernetesObjectReconciler): | ||||
|     """Kubernetes Gateway API HTTPRoute Reconciler""" | ||||
|  | ||||
|     def __init__(self, controller: "KubernetesController") -> None: | ||||
|         super().__init__(controller) | ||||
|         self.api_ex = ApiextensionsV1Api(controller.client) | ||||
|         self.api = CustomObjectsApi(controller.client) | ||||
|         self.crd_group = "gateway.networking.k8s.io" | ||||
|         self.crd_version = "v1" | ||||
|         self.crd_plural = "httproutes" | ||||
|  | ||||
|     @staticmethod | ||||
|     def reconciler_name() -> str: | ||||
|         return "httproute" | ||||
|  | ||||
|     @property | ||||
|     def noop(self) -> bool: | ||||
|         if not self.crd_exists(): | ||||
|             self.logger.debug("CRD doesn't exist") | ||||
|             return True | ||||
|         if not self.controller.outpost.config.kubernetes_httproute_parent_refs: | ||||
|             self.logger.debug("HTTPRoute parentRefs not set.") | ||||
|             return True | ||||
|         return False | ||||
|  | ||||
|     def crd_exists(self) -> bool: | ||||
|         """Check if the Gateway API resources exists""" | ||||
|         return bool( | ||||
|             len( | ||||
|                 self.api_ex.list_custom_resource_definition( | ||||
|                     field_selector=f"metadata.name={self.crd_plural}.{self.crd_group}" | ||||
|                 ).items | ||||
|             ) | ||||
|         ) | ||||
|  | ||||
|     def reconcile(self, current: HTTPRoute, reference: HTTPRoute): | ||||
|         super().reconcile(current, reference) | ||||
|         if current.metadata.annotations != reference.metadata.annotations: | ||||
|             raise NeedsUpdate() | ||||
|         if current.spec.parentRefs != reference.spec.parentRefs: | ||||
|             raise NeedsUpdate() | ||||
|         if current.spec.hostnames != reference.spec.hostnames: | ||||
|             raise NeedsUpdate() | ||||
|         if current.spec.rules != reference.spec.rules: | ||||
|             raise NeedsUpdate() | ||||
|  | ||||
|     def get_object_meta(self, **kwargs) -> V1ObjectMeta: | ||||
|         return super().get_object_meta( | ||||
|             **kwargs, | ||||
|         ) | ||||
|  | ||||
|     def get_reference_object(self) -> HTTPRoute: | ||||
|         hostnames = [] | ||||
|         rules = [] | ||||
|  | ||||
|         for proxy_provider in ProxyProvider.objects.filter(outpost__in=[self.controller.outpost]): | ||||
|             proxy_provider: ProxyProvider | ||||
|             external_host_name = urlparse(proxy_provider.external_host) | ||||
|             if proxy_provider.mode in [ProxyMode.FORWARD_SINGLE, ProxyMode.FORWARD_DOMAIN]: | ||||
|                 rule = HTTPRouteSpecRule( | ||||
|                     backendRefs=[RouteBackendRef(name=self.name, port=9000)], | ||||
|                     matches=[ | ||||
|                         HTTPRouteSpecRuleMatch( | ||||
|                             headers=[ | ||||
|                                 HTTPRouteSpecRuleMatchHeader( | ||||
|                                     name="Host", | ||||
|                                     value=external_host_name.hostname, | ||||
|                                 ) | ||||
|                             ], | ||||
|                             path=HTTPRouteSpecRuleMatchPath( | ||||
|                                 type="PathPrefix", value="/outpost.goauthentik.io" | ||||
|                             ), | ||||
|                         ) | ||||
|                     ], | ||||
|                 ) | ||||
|             else: | ||||
|                 rule = HTTPRouteSpecRule( | ||||
|                     backendRefs=[RouteBackendRef(name=self.name, port=9000)], | ||||
|                     matches=[ | ||||
|                         HTTPRouteSpecRuleMatch( | ||||
|                             headers=[ | ||||
|                                 HTTPRouteSpecRuleMatchHeader( | ||||
|                                     name="Host", | ||||
|                                     value=external_host_name.hostname, | ||||
|                                 ) | ||||
|                             ], | ||||
|                             path=HTTPRouteSpecRuleMatchPath(type="PathPrefix", value="/"), | ||||
|                         ) | ||||
|                     ], | ||||
|                 ) | ||||
|             hostnames.append(external_host_name.hostname) | ||||
|             rules.append(rule) | ||||
|  | ||||
|         return HTTPRoute( | ||||
|             apiVersion=f"{self.crd_group}/{self.crd_version}", | ||||
|             kind="HTTPRoute", | ||||
|             metadata=HTTPRouteMetadata( | ||||
|                 name=self.name, | ||||
|                 namespace=self.namespace, | ||||
|                 annotations=self.controller.outpost.config.kubernetes_httproute_annotations, | ||||
|                 labels=self.get_object_meta().labels, | ||||
|             ), | ||||
|             spec=HTTPRouteSpec( | ||||
|                 parentRefs=[ | ||||
|                     from_dict(RouteSpecParentRefs, spec) | ||||
|                     for spec in self.controller.outpost.config.kubernetes_httproute_parent_refs | ||||
|                 ], | ||||
|                 hostnames=hostnames, | ||||
|                 rules=rules, | ||||
|             ), | ||||
|         ) | ||||
|  | ||||
|     def create(self, reference: HTTPRoute): | ||||
|         return self.api.create_namespaced_custom_object( | ||||
|             group=self.crd_group, | ||||
|             version=self.crd_version, | ||||
|             plural=self.crd_plural, | ||||
|             namespace=self.namespace, | ||||
|             body=asdict(reference), | ||||
|             field_manager=FIELD_MANAGER, | ||||
|         ) | ||||
|  | ||||
|     def delete(self, reference: HTTPRoute): | ||||
|         return self.api.delete_namespaced_custom_object( | ||||
|             group=self.crd_group, | ||||
|             version=self.crd_version, | ||||
|             plural=self.crd_plural, | ||||
|             namespace=self.namespace, | ||||
|             name=self.name, | ||||
|         ) | ||||
|  | ||||
|     def retrieve(self) -> HTTPRoute: | ||||
|         return from_dict( | ||||
|             HTTPRoute, | ||||
|             self.api.get_namespaced_custom_object( | ||||
|                 group=self.crd_group, | ||||
|                 version=self.crd_version, | ||||
|                 plural=self.crd_plural, | ||||
|                 namespace=self.namespace, | ||||
|                 name=self.name, | ||||
|             ), | ||||
|         ) | ||||
|  | ||||
|     def update(self, current: HTTPRoute, reference: HTTPRoute): | ||||
|         return self.api.patch_namespaced_custom_object( | ||||
|             group=self.crd_group, | ||||
|             version=self.crd_version, | ||||
|             plural=self.crd_plural, | ||||
|             namespace=self.namespace, | ||||
|             name=self.name, | ||||
|             body=asdict(reference), | ||||
|             field_manager=FIELD_MANAGER, | ||||
|         ) | ||||
| @ -3,7 +3,6 @@ | ||||
| from authentik.outposts.controllers.base import DeploymentPort | ||||
| from authentik.outposts.controllers.kubernetes import KubernetesController | ||||
| from authentik.outposts.models import KubernetesServiceConnection, Outpost | ||||
| from authentik.providers.proxy.controllers.k8s.httproute import HTTPRouteReconciler | ||||
| from authentik.providers.proxy.controllers.k8s.ingress import IngressReconciler | ||||
| from authentik.providers.proxy.controllers.k8s.traefik import TraefikMiddlewareReconciler | ||||
|  | ||||
| @ -19,10 +18,8 @@ class ProxyKubernetesController(KubernetesController): | ||||
|             DeploymentPort(9443, "https", "tcp"), | ||||
|         ] | ||||
|         self.reconcilers[IngressReconciler.reconciler_name()] = IngressReconciler | ||||
|         self.reconcilers[HTTPRouteReconciler.reconciler_name()] = HTTPRouteReconciler | ||||
|         self.reconcilers[TraefikMiddlewareReconciler.reconciler_name()] = ( | ||||
|             TraefikMiddlewareReconciler | ||||
|         ) | ||||
|         self.reconcile_order.append(IngressReconciler.reconciler_name()) | ||||
|         self.reconcile_order.append(HTTPRouteReconciler.reconciler_name()) | ||||
|         self.reconcile_order.append(TraefikMiddlewareReconciler.reconciler_name()) | ||||
|  | ||||
| @ -20,4 +20,4 @@ def logout_proxy_revoke_direct(sender: type[User], request: HttpRequest, **_): | ||||
| @receiver(pre_delete, sender=AuthenticatedSession) | ||||
| def logout_proxy_revoke(sender: type[AuthenticatedSession], instance: AuthenticatedSession, **_): | ||||
|     """Catch logout by expiring sessions being deleted""" | ||||
|     proxy_on_logout.delay(instance.session.session_key) | ||||
|     proxy_on_logout.delay(instance.session_key) | ||||
|  | ||||
| @ -1,60 +0,0 @@ | ||||
| # Generated by Django 5.0.11 on 2025-01-27 12:59 | ||||
|  | ||||
| from django.db import migrations | ||||
| import django.db.models.deletion | ||||
| from django.db import migrations, models | ||||
|  | ||||
|  | ||||
| def migrate_sessions(apps, schema_editor): | ||||
|     ConnectionToken = apps.get_model("authentik_providers_rac", "ConnectionToken") | ||||
|     AuthenticatedSession = apps.get_model("authentik_core", "AuthenticatedSession") | ||||
|     db_alias = schema_editor.connection.alias | ||||
|  | ||||
|     for token in ConnectionToken.objects.using(db_alias).all(): | ||||
|         token.session = ( | ||||
|             AuthenticatedSession.objects.using(db_alias) | ||||
|             .filter(session_key=token.old_session.session_key) | ||||
|             .first() | ||||
|         ) | ||||
|         if token.session: | ||||
|             token.save() | ||||
|         else: | ||||
|             token.delete() | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_providers_rac", "0006_connectiontoken_authentik_p_expires_91f148_idx_and_more"), | ||||
|         ("authentik_core", "0046_session_and_more"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.RenameField( | ||||
|             model_name="connectiontoken", | ||||
|             old_name="session", | ||||
|             new_name="old_session", | ||||
|         ), | ||||
|         migrations.AddField( | ||||
|             model_name="connectiontoken", | ||||
|             name="session", | ||||
|             field=models.ForeignKey( | ||||
|                 null=True, | ||||
|                 on_delete=django.db.models.deletion.CASCADE, | ||||
|                 to="authentik_core.authenticatedsession", | ||||
|             ), | ||||
|         ), | ||||
|         migrations.RunPython(code=migrate_sessions), | ||||
|         migrations.AlterField( | ||||
|             model_name="connectiontoken", | ||||
|             name="session", | ||||
|             field=models.ForeignKey( | ||||
|                 on_delete=django.db.models.deletion.CASCADE, | ||||
|                 to="authentik_core.authenticatedsession", | ||||
|             ), | ||||
|         ), | ||||
|         migrations.RemoveField( | ||||
|             model_name="connectiontoken", | ||||
|             name="old_session", | ||||
|         ), | ||||
|     ] | ||||
| @ -8,7 +8,7 @@ from django.db.models.signals import post_delete, post_save, pre_delete | ||||
| from django.dispatch import receiver | ||||
| from django.http import HttpRequest | ||||
|  | ||||
| from authentik.core.models import AuthenticatedSession, User | ||||
| from authentik.core.models import User | ||||
| from authentik.providers.rac.api.endpoints import user_endpoint_cache_key | ||||
| from authentik.providers.rac.consumer_client import ( | ||||
|     RAC_CLIENT_GROUP_SESSION, | ||||
| @ -32,18 +32,6 @@ def user_logged_out_session(sender, request: HttpRequest, user: User, **_): | ||||
|     ) | ||||
|  | ||||
|  | ||||
| @receiver(pre_delete, sender=AuthenticatedSession) | ||||
| def user_session_deleted(sender, instance: AuthenticatedSession, **_): | ||||
|     layer = get_channel_layer() | ||||
|     async_to_sync(layer.group_send)( | ||||
|         RAC_CLIENT_GROUP_SESSION | ||||
|         % { | ||||
|             "session": instance.session.session_key, | ||||
|         }, | ||||
|         {"type": "event.disconnect", "reason": "session_logout"}, | ||||
|     ) | ||||
|  | ||||
|  | ||||
| @receiver(pre_delete, sender=ConnectionToken) | ||||
| def pre_delete_connection_token_disconnect(sender, instance: ConnectionToken, **_): | ||||
|     """Disconnect session when connection token is deleted""" | ||||
|  | ||||
| @ -2,7 +2,7 @@ | ||||
|  | ||||
| from django.test import TransactionTestCase | ||||
|  | ||||
| from authentik.core.models import Application, AuthenticatedSession, Session | ||||
| from authentik.core.models import Application, AuthenticatedSession | ||||
| from authentik.core.tests.utils import create_test_admin_user | ||||
| from authentik.lib.generators import generate_id | ||||
| from authentik.providers.rac.models import ( | ||||
| @ -36,15 +36,13 @@ class TestModels(TransactionTestCase): | ||||
|  | ||||
|     def test_settings_merge(self): | ||||
|         """Test settings merge""" | ||||
|         session = Session.objects.create( | ||||
|             session_key=generate_id(), | ||||
|             last_ip="255.255.255.255", | ||||
|         ) | ||||
|         auth_session = AuthenticatedSession.objects.create(session=session, user=self.user) | ||||
|         token = ConnectionToken.objects.create( | ||||
|             provider=self.provider, | ||||
|             endpoint=self.endpoint, | ||||
|             session=auth_session, | ||||
|             session=AuthenticatedSession.objects.create( | ||||
|                 user=self.user, | ||||
|                 session_key=generate_id(), | ||||
|             ), | ||||
|         ) | ||||
|         path = f"/tmp/connection/{token.token}"  # nosec | ||||
|         self.assertEqual( | ||||
|  | ||||
| @ -1,5 +1,7 @@ | ||||
| """rac urls""" | ||||
|  | ||||
| from channels.auth import AuthMiddleware | ||||
| from channels.sessions import CookieMiddleware | ||||
| from django.urls import path | ||||
|  | ||||
| from authentik.outposts.channels import TokenOutpostMiddleware | ||||
| @ -10,7 +12,7 @@ from authentik.providers.rac.api.providers import RACProviderViewSet | ||||
| from authentik.providers.rac.consumer_client import RACClientConsumer | ||||
| from authentik.providers.rac.consumer_outpost import RACOutpostConsumer | ||||
| from authentik.providers.rac.views import RACInterface, RACStartView | ||||
| from authentik.root.asgi_middleware import AuthMiddlewareStack | ||||
| from authentik.root.asgi_middleware import SessionMiddleware | ||||
| from authentik.root.middleware import ChannelsLoggingMiddleware | ||||
|  | ||||
| urlpatterns = [ | ||||
| @ -29,7 +31,9 @@ urlpatterns = [ | ||||
| websocket_urlpatterns = [ | ||||
|     path( | ||||
|         "ws/rac/<str:token>/", | ||||
|         ChannelsLoggingMiddleware(AuthMiddlewareStack(RACClientConsumer.as_asgi())), | ||||
|         ChannelsLoggingMiddleware( | ||||
|             CookieMiddleware(SessionMiddleware(AuthMiddleware(RACClientConsumer.as_asgi()))) | ||||
|         ), | ||||
|     ), | ||||
|     path( | ||||
|         "ws/outpost_rac/<str:channel>/", | ||||
|  | ||||
| @ -8,7 +8,7 @@ from django.urls import reverse | ||||
| from django.utils.timezone import now | ||||
| from django.utils.translation import gettext as _ | ||||
|  | ||||
| from authentik.core.models import Application | ||||
| from authentik.core.models import Application, AuthenticatedSession | ||||
| from authentik.core.views.interface import InterfaceView | ||||
| from authentik.events.models import Event, EventAction | ||||
| from authentik.flows.challenge import RedirectChallenge | ||||
| @ -113,7 +113,9 @@ class RACFinalStage(RedirectStage): | ||||
|             provider=self.provider, | ||||
|             endpoint=self.endpoint, | ||||
|             settings=self.executor.plan.context.get("connection_settings", {}), | ||||
|             session=self.request.session["authenticatedsession"], | ||||
|             session=AuthenticatedSession.objects.filter( | ||||
|                 session_key=self.request.session.session_key | ||||
|             ).first(), | ||||
|             expires=now() + timedelta_from_string(self.provider.connection_expiry), | ||||
|             expiring=True, | ||||
|         ) | ||||
|  | ||||
| @ -1,22 +0,0 @@ | ||||
| # Generated by Django 5.0.13 on 2025-03-31 13:50 | ||||
|  | ||||
| import authentik.lib.models | ||||
| from django.db import migrations, models | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("authentik_providers_saml", "0017_samlprovider_authn_context_class_ref_mapping"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.AlterField( | ||||
|             model_name="samlprovider", | ||||
|             name="acs_url", | ||||
|             field=models.TextField( | ||||
|                 validators=[authentik.lib.models.DomainlessURLValidator(schemes=("http", "https"))], | ||||
|                 verbose_name="ACS URL", | ||||
|             ), | ||||
|         ), | ||||
|     ] | ||||
| @ -10,7 +10,6 @@ from structlog.stdlib import get_logger | ||||
| from authentik.core.api.object_types import CreatableType | ||||
| from authentik.core.models import PropertyMapping, Provider | ||||
| from authentik.crypto.models import CertificateKeyPair | ||||
| from authentik.lib.models import DomainlessURLValidator | ||||
| from authentik.lib.utils.time import timedelta_string_validator | ||||
| from authentik.sources.saml.processors.constants import ( | ||||
|     DSA_SHA1, | ||||
| @ -41,9 +40,7 @@ class SAMLBindings(models.TextChoices): | ||||
| class SAMLProvider(Provider): | ||||
|     """SAML 2.0 Endpoint for applications which support SAML.""" | ||||
|  | ||||
|     acs_url = models.TextField( | ||||
|         validators=[DomainlessURLValidator(schemes=("http", "https"))], verbose_name=_("ACS URL") | ||||
|     ) | ||||
|     acs_url = models.URLField(verbose_name=_("ACS URL")) | ||||
|     audience = models.TextField( | ||||
|         default="", | ||||
|         blank=True, | ||||
|  | ||||
| @ -1,41 +0,0 @@ | ||||
| """RBAC Initial Permissions""" | ||||
|  | ||||
| from rest_framework.serializers import ListSerializer | ||||
| from rest_framework.viewsets import ModelViewSet | ||||
|  | ||||
| from authentik.core.api.used_by import UsedByMixin | ||||
| from authentik.core.api.utils import ModelSerializer | ||||
| from authentik.rbac.api.rbac import PermissionSerializer | ||||
| from authentik.rbac.models import InitialPermissions | ||||
|  | ||||
|  | ||||
| class InitialPermissionsSerializer(ModelSerializer): | ||||
|     """InitialPermissions serializer""" | ||||
|  | ||||
|     permissions_obj = ListSerializer( | ||||
|         child=PermissionSerializer(), | ||||
|         read_only=True, | ||||
|         source="permissions", | ||||
|         required=False, | ||||
|     ) | ||||
|  | ||||
|     class Meta: | ||||
|         model = InitialPermissions | ||||
|         fields = [ | ||||
|             "pk", | ||||
|             "name", | ||||
|             "mode", | ||||
|             "role", | ||||
|             "permissions", | ||||
|             "permissions_obj", | ||||
|         ] | ||||
|  | ||||
|  | ||||
| class InitialPermissionsViewSet(UsedByMixin, ModelViewSet): | ||||
|     """InitialPermissions viewset""" | ||||
|  | ||||
|     queryset = InitialPermissions.objects.all() | ||||
|     serializer_class = InitialPermissionsSerializer | ||||
|     search_fields = ["name"] | ||||
|     ordering = ["name"] | ||||
|     filterset_fields = ["name"] | ||||
| @ -99,7 +99,6 @@ class RBACPermissionViewSet(ReadOnlyModelViewSet): | ||||
|     filterset_class = PermissionFilter | ||||
|     permission_classes = [IsAuthenticated] | ||||
|     search_fields = [ | ||||
|         "name", | ||||
|         "codename", | ||||
|         "content_type__model", | ||||
|         "content_type__app_label", | ||||
|  | ||||
| @ -1,39 +0,0 @@ | ||||
| # Generated by Django 5.0.13 on 2025-04-07 13:05 | ||||
|  | ||||
| import django.db.models.deletion | ||||
| from django.db import migrations, models | ||||
|  | ||||
|  | ||||
| class Migration(migrations.Migration): | ||||
|  | ||||
|     dependencies = [ | ||||
|         ("auth", "0012_alter_user_first_name_max_length"), | ||||
|         ("authentik_rbac", "0004_alter_systempermission_options"), | ||||
|     ] | ||||
|  | ||||
|     operations = [ | ||||
|         migrations.CreateModel( | ||||
|             name="InitialPermissions", | ||||
|             fields=[ | ||||
|                 ( | ||||
|                     "id", | ||||
|                     models.AutoField( | ||||
|                         auto_created=True, primary_key=True, serialize=False, verbose_name="ID" | ||||
|                     ), | ||||
|                 ), | ||||
|                 ("name", models.TextField(max_length=150, unique=True)), | ||||
|                 ("mode", models.CharField(choices=[("user", "User"), ("role", "Role")])), | ||||
|                 ("permissions", models.ManyToManyField(blank=True, to="auth.permission")), | ||||
|                 ( | ||||
|                     "role", | ||||
|                     models.ForeignKey( | ||||
|                         on_delete=django.db.models.deletion.CASCADE, to="authentik_rbac.role" | ||||
|                     ), | ||||
|                 ), | ||||
|             ], | ||||
|             options={ | ||||
|                 "verbose_name": "Initial Permissions", | ||||
|                 "verbose_name_plural": "Initial Permissions", | ||||
|             }, | ||||
|         ), | ||||
|     ] | ||||
| @ -3,7 +3,6 @@ | ||||
| from uuid import uuid4 | ||||
|  | ||||
| from django.contrib.auth.management import _get_all_permissions | ||||
| from django.contrib.auth.models import Permission | ||||
| from django.db import models | ||||
| from django.db.transaction import atomic | ||||
| from django.utils.translation import gettext_lazy as _ | ||||
| @ -76,35 +75,6 @@ class Role(SerializerModel): | ||||
|         ] | ||||
|  | ||||
|  | ||||
| class InitialPermissionsMode(models.TextChoices): | ||||
|     """Determines which entity the initial permissions are assigned to.""" | ||||
|  | ||||
|     USER = "user", _("User") | ||||
|     ROLE = "role", _("Role") | ||||
|  | ||||
|  | ||||
| class InitialPermissions(SerializerModel): | ||||
|     """Assigns permissions for newly created objects.""" | ||||
|  | ||||
|     name = models.TextField(max_length=150, unique=True) | ||||
|     mode = models.CharField(choices=InitialPermissionsMode.choices) | ||||
|     role = models.ForeignKey(Role, on_delete=models.CASCADE) | ||||
|     permissions = models.ManyToManyField(Permission, blank=True) | ||||
|  | ||||
|     @property | ||||
|     def serializer(self) -> type[BaseSerializer]: | ||||
|         from authentik.rbac.api.initial_permissions import InitialPermissionsSerializer | ||||
|  | ||||
|         return InitialPermissionsSerializer | ||||
|  | ||||
|     def __str__(self) -> str: | ||||
|         return f"Initial Permissions for Role #{self.role_id}, applying to #{self.mode}" | ||||
|  | ||||
|     class Meta: | ||||
|         verbose_name = _("Initial Permissions") | ||||
|         verbose_name_plural = _("Initial Permissions") | ||||
|  | ||||
|  | ||||
| class SystemPermission(models.Model): | ||||
|     """System-wide permissions that are not related to any direct | ||||
|     database model""" | ||||
|  | ||||
| @ -1,13 +1,9 @@ | ||||
| """RBAC Permissions""" | ||||
|  | ||||
| from django.contrib.contenttypes.models import ContentType | ||||
| from django.db.models import Model | ||||
| from guardian.shortcuts import assign_perm | ||||
| from rest_framework.permissions import BasePermission, DjangoObjectPermissions | ||||
| from rest_framework.request import Request | ||||
|  | ||||
| from authentik.rbac.models import InitialPermissions, InitialPermissionsMode | ||||
|  | ||||
|  | ||||
| class ObjectPermissions(DjangoObjectPermissions): | ||||
|     """RBAC Permissions""" | ||||
| @ -55,20 +51,3 @@ def HasPermission(*perm: str) -> type[BasePermission]: | ||||
|             return bool(request.user and request.user.has_perms(perm)) | ||||
|  | ||||
|     return checker | ||||
|  | ||||
|  | ||||
| # TODO: add `user: User` type annotation without circular dependencies. | ||||
| # The author of this function isn't proficient/patient enough to do it. | ||||
| def assign_initial_permissions(user, instance: Model): | ||||
|     # Performance here should not be an issue, but if needed, there are many optimization routes | ||||
|     initial_permissions_list = InitialPermissions.objects.filter(role__group__in=user.groups.all()) | ||||
|     for initial_permissions in initial_permissions_list: | ||||
|         for permission in initial_permissions.permissions.all(): | ||||
|             if permission.content_type != ContentType.objects.get_for_model(instance): | ||||
|                 continue | ||||
|             assign_to = ( | ||||
|                 user | ||||
|                 if initial_permissions.mode == InitialPermissionsMode.USER | ||||
|                 else initial_permissions.role.group | ||||
|             ) | ||||
|             assign_perm(permission, assign_to, instance) | ||||
|  | ||||
| @ -1,116 +0,0 @@ | ||||
| """Test InitialPermissions""" | ||||
|  | ||||
| from django.contrib.auth.models import Permission | ||||
| from guardian.shortcuts import assign_perm | ||||
| from rest_framework.reverse import reverse | ||||
| from rest_framework.test import APITestCase | ||||
|  | ||||
| from authentik.core.models import Group | ||||
| from authentik.core.tests.utils import create_test_user | ||||
| from authentik.lib.generators import generate_id | ||||
| from authentik.rbac.models import InitialPermissions, InitialPermissionsMode, Role | ||||
| from authentik.stages.dummy.models import DummyStage | ||||
|  | ||||
|  | ||||
| class TestInitialPermissions(APITestCase): | ||||
|     """Test InitialPermissions""" | ||||
|  | ||||
|     def setUp(self) -> None: | ||||
|         self.user = create_test_user() | ||||
|         self.same_role_user = create_test_user() | ||||
|         self.different_role_user = create_test_user() | ||||
|  | ||||
|         self.role = Role.objects.create(name=generate_id()) | ||||
|         self.different_role = Role.objects.create(name=generate_id()) | ||||
|  | ||||
|         self.group = Group.objects.create(name=generate_id()) | ||||
|         self.different_group = Group.objects.create(name=generate_id()) | ||||
|  | ||||
|         self.group.roles.add(self.role) | ||||
|         self.group.users.add(self.user, self.same_role_user) | ||||
|         self.different_group.roles.add(self.different_role) | ||||
|         self.different_group.users.add(self.different_role_user) | ||||
|  | ||||
|         self.ip = InitialPermissions.objects.create( | ||||
|             name=generate_id(), mode=InitialPermissionsMode.USER, role=self.role | ||||
|         ) | ||||
|         self.view_role = Permission.objects.filter(codename="view_role").first() | ||||
|         self.ip.permissions.add(self.view_role) | ||||
|  | ||||
|         assign_perm("authentik_rbac.add_role", self.user) | ||||
|         self.client.force_login(self.user) | ||||
|  | ||||
|     def test_different_role(self): | ||||
|         """InitialPermissions for different role does nothing""" | ||||
|         self.ip.role = self.different_role | ||||
|         self.ip.save() | ||||
|  | ||||
|         self.client.post(reverse("authentik_api:roles-list"), {"name": "test-role"}) | ||||
|  | ||||
|         role = Role.objects.filter(name="test-role").first() | ||||
|         self.assertFalse(self.user.has_perm("authentik_rbac.view_role", role)) | ||||
|  | ||||
|     def test_different_model(self): | ||||
|         """InitialPermissions for different model does nothing""" | ||||
|         assign_perm("authentik_stages_dummy.add_dummystage", self.user) | ||||
|  | ||||
|         self.client.post( | ||||
|             reverse("authentik_api:stages-dummy-list"), {"name": "test-stage", "throw-error": False} | ||||
|         ) | ||||
|  | ||||
|         role = Role.objects.filter(name="test-role").first() | ||||
|         self.assertFalse(self.user.has_perm("authentik_rbac.view_role", role)) | ||||
|         stage = DummyStage.objects.filter(name="test-stage").first() | ||||
|         self.assertFalse(self.user.has_perm("authentik_stages_dummy.view_dummystage", stage)) | ||||
|  | ||||
|     def test_mode_user(self): | ||||
|         """InitialPermissions adds user permission in user mode""" | ||||
|         self.client.post(reverse("authentik_api:roles-list"), {"name": "test-role"}) | ||||
|  | ||||
|         role = Role.objects.filter(name="test-role").first() | ||||
|         self.assertTrue(self.user.has_perm("authentik_rbac.view_role", role)) | ||||
|         self.assertFalse(self.same_role_user.has_perm("authentik_rbac.view_role", role)) | ||||
|  | ||||
|     def test_mode_role(self): | ||||
|         """InitialPermissions adds role permission in role mode""" | ||||
|         self.ip.mode = InitialPermissionsMode.ROLE | ||||
|         self.ip.save() | ||||
|  | ||||
|         self.client.post(reverse("authentik_api:roles-list"), {"name": "test-role"}) | ||||
|  | ||||
|         role = Role.objects.filter(name="test-role").first() | ||||
|         self.assertTrue(self.user.has_perm("authentik_rbac.view_role", role)) | ||||
|         self.assertTrue(self.same_role_user.has_perm("authentik_rbac.view_role", role)) | ||||
|  | ||||
|     def test_many_permissions(self): | ||||
|         """InitialPermissions can add multiple permissions""" | ||||
|         change_role = Permission.objects.filter(codename="change_role").first() | ||||
|         self.ip.permissions.add(change_role) | ||||
|  | ||||
|         self.client.post(reverse("authentik_api:roles-list"), {"name": "test-role"}) | ||||
|  | ||||
|         role = Role.objects.filter(name="test-role").first() | ||||
|         self.assertTrue(self.user.has_perm("authentik_rbac.view_role", role)) | ||||
|         self.assertTrue(self.user.has_perm("authentik_rbac.change_role", role)) | ||||
|  | ||||
|     def test_permissions_separated_by_role(self): | ||||
|         """When the triggering user is part of two different roles with InitialPermissions in role | ||||
|         mode, it only adds permissions to the relevant role.""" | ||||
|         self.ip.mode = InitialPermissionsMode.ROLE | ||||
|         self.ip.save() | ||||
|         different_ip = InitialPermissions.objects.create( | ||||
|             name=generate_id(), mode=InitialPermissionsMode.ROLE, role=self.different_role | ||||
|         ) | ||||
|         change_role = Permission.objects.filter(codename="change_role").first() | ||||
|         different_ip.permissions.add(change_role) | ||||
|         self.different_group.users.add(self.user) | ||||
|  | ||||
|         self.client.post(reverse("authentik_api:roles-list"), {"name": "test-role"}) | ||||
|  | ||||
|         role = Role.objects.filter(name="test-role").first() | ||||
|         self.assertTrue(self.user.has_perm("authentik_rbac.view_role", role)) | ||||
|         self.assertTrue(self.same_role_user.has_perm("authentik_rbac.view_role", role)) | ||||
|         self.assertFalse(self.different_role_user.has_perm("authentik_rbac.view_role", role)) | ||||
|         self.assertTrue(self.user.has_perm("authentik_rbac.change_role", role)) | ||||
|         self.assertFalse(self.same_role_user.has_perm("authentik_rbac.change_role", role)) | ||||
|         self.assertTrue(self.different_role_user.has_perm("authentik_rbac.change_role", role)) | ||||
| @ -1,6 +1,5 @@ | ||||
| """RBAC API urls""" | ||||
|  | ||||
| from authentik.rbac.api.initial_permissions import InitialPermissionsViewSet | ||||
| from authentik.rbac.api.rbac import RBACPermissionViewSet | ||||
| from authentik.rbac.api.rbac_assigned_by_roles import RoleAssignedPermissionViewSet | ||||
| from authentik.rbac.api.rbac_assigned_by_users import UserAssignedPermissionViewSet | ||||
| @ -22,6 +21,5 @@ api_urlpatterns = [ | ||||
|     ("rbac/permissions/users", UserPermissionViewSet, "permissions-users"), | ||||
|     ("rbac/permissions/roles", RolePermissionViewSet, "permissions-roles"), | ||||
|     ("rbac/permissions", RBACPermissionViewSet), | ||||
|     ("rbac/roles", RoleViewSet, "roles"), | ||||
|     ("rbac/initial_permissions", InitialPermissionsViewSet, "initial-permissions"), | ||||
|     ("rbac/roles", RoleViewSet), | ||||
| ] | ||||
|  | ||||
Some files were not shown because too many files have changed in this diff Show More
		Reference in New Issue
	
	Block a user
	