habsi/elasticsearch-js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #324

Browse Source 
Added support for string hosts in ConnectionAbstract constructor.
Host constructor is used with supplied host string to create host object for ConnectionAbstract.
This commit is contained in:
Iurii Sergiichuk
2016-01-31 12:40:01 +02:00
parent 54033c9019
commit 916aca58c8
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/connection.js
View File

@ -22,6 +22,8 @@ function ConnectionAbstract(host, config) {
throw new TypeError('Missing host');
} else if (host instanceof Host) {
this.host = host;
} else if (typeof host === "string"){
this.host = new Host(host);
} else {
throw new TypeError('Invalid host');
}
@ -96,4 +98,4 @@ ConnectionAbstract.prototype.setStatus = function (status) {
if (status === 'closed') {
this.removeAllListeners();
}
};
};

9
test/unit/specs/connection_abstract.js
View File

@ -15,6 +15,15 @@ describe('Connection Abstract', function () {
expect(conn.host).to.be(host);
});
it('constructs with string host using Host constructor', function(){
var host = 'localhost';
var port = 9200;
var hostUrl = host+':'+port;
var conn = new ConnectionAbstract(hostUrl);
expect(conn.host.host).to.be(host);
expect(conn.host.port).to.be(port);
});
it('requires a valid host', function () {
expect(function () {
new ConnectionAbstract();